[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32343|0                           |1
        is obsolete|                            |

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 32380
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32380&action=edit
[SIGNED OFF] Bug 13084: Mixup of columns in deletedborrowers (3.14 version)

I could reproduce this problem in 3.14.4 where I wrote the patch.
Fields shifted like branchcode moved to B_phone.
Could not reproduce it for master.
But this code change seems to improve things on master too.

NOTE: The callers of this routine should use the return value to check,
and not simply assume that it will be fine ;) Changing those places is
out of the scope of this report.

TEST PLAN
---------
1) Alter the order of your deletedborrowers table.
   e.g. alter table deletedborrowers change column privacy privacy int(11)
after city;
2) Apply the 3.14.x test patch.
3) prove -v t/db_dependent/Members.t
   -- Will fail on the new test.
4) Apply the 3.14.x code change patch.
5) prove -v t/db_dependent/Members.t
   -- Will succeed on the new test.
6) run koha qa test tools.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.