[Koha-bugs] [Bug 12653] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in tests

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12653

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 32477
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32477
Bug 12653: PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in
tests

Review of attachment 32477:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12653&attachment=32477)
-----------------------------------------------------------------

::: xt/single_quotes.t
@@ +43,4 @@
>  my @files;
>  find(
>      sub {
>          open my $fh, $_ or die "Could not open $_: $!";

Since @themes has no /en, I would have expected something here.

@@ +46,5 @@
>          open my $fh, $_ or die "Could not open $_: $!";
>          my @lines = sort grep /\_\(\'/, <$fh>;
>          push @files, { name => "$_", lines => \@lines } if @lines;
> +    },
> +    @themes

Note: @themes does not have /en on the values in the array.
Not that it should only be en, but this likely tests the wrong directory level.

@@ -31,5 @@
> -    },qw#
> -    ./koha-tmpl/opac-tmpl/prog/en
> -    ./koha-tmpl/opac-tmpl/bootstrap/en
> -    ./koha-tmpl/intranet-tmpl/prog/en
> -    #

Note: all these have /en on them.

-- 
You are receiving this mail because:
You are watching all bug changes.