[Koha-bugs] [Bug 12653] PROG/CCSR deprecation: Correct hard-coded opac-tmpl/prog path in tests

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Oct 20 16:35:14 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12653

--- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to M. Tompsett from comment #14)
> ./opac-tmpl/bootstrap/itemtypeimg/crystal-clear/_COPYING.txt
> ./opac-tmpl/ccsr/itemtypeimg/crystal-clear/_COPYING.txt
> -- these lack two empty lines at the end of the file
> 
> ./intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt
> ./opac-tmpl/bootstrap/itemtypeimg/crystal-clear/_COPYING.txt
> -- which these two files have
> 
> Can someone else confirm their files differ this way?


On current master (not my patch), 
~/kohaclone/koha-tmpl$ diff
./intranet-tmpl/prog/img/itemtypeimg/crystal-clear/_COPYING.txt
./opac-tmpl/ccsr/itemtypeimg/crystal-clear/_COPYING.txt
121,122d120
< 
< 

CCSR is not fixed, differs in more than that file. But because is about to be
removed soon, I skipped the test there. There is no point to update/fix
itemtypeimg for ccsr (perhaps yes for <= 3.16 versions)

About your next comment, I fix only files needed to make test pass.

I'll resubmit because I forgot to add a later fix (a missing '/en' on
tt_valid.t, it checks more than necessary)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list