[Koha-bugs] [Bug 13115] Holidays.t will fail some unit tests on Sundays

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Oct 21 23:26:15 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32532|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 32567
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32567&action=edit
[PASSED QA] Bug 13115 - Holidays.t will fail some unit tests on Sundays

Due to the fact that Sunday is a repeating holiday in the example data
which is used for part but not all of Holidays.t, the last test will
fail on Sundays. The test is to see if today is *not* a special holiday
for MPL, but since it's already a repeating holiday, is_holiday will
return true rather than false.

Test Plan:
1) Wait until Sunday
2) prove t/db_dependent/Holidays.t
3) Note the failure
4) Apply this patch
5) Repeat step 2
6) Note there is no longer a failure

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Used my time machine... :)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list