[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Oct 23 15:05:41 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I have been playing around allot with this lately and my general feeling is
that it's pretty workable already and a viable route to using proper objects in
Koha. Whilst it has allot of further enhancements required to make it 'really'
useful, it's in a good state as is for a first step as is.

I'll happily QA if someone else wants to signoff.. or I can signoff if another
of the QA team is happy expending the effort of getting to grips with it ;)

My general thoughts as a whole follow:

I still feel the objects kinda of lock away allot of the advantages of dbic
behind an abstraction that sometimes detracts rather than enhances; but with
our debates going on and on I'de rather see Koha moving forward than stagnating
in debate territory.  The only other option I see perhaps working is setting a
bunch of coding rules/guidelines really pushing people in the direction of
consistent objects.

My real feeling after all this is that we're doing way too much logical work in
our .pl's.. if it's logic based at all, it really belongs in a .pm where it can
be fully tested ;-) ! (Though I'de love to see Services in PM's tested, and UI
in Angular Tested as a future route.. I'll be posting up some demo code for
such soon)

This one is holding up bug 12892 now, so I'd really like to encourage some
additional input, signoff and qa thought go into it asap :)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list