[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #4 from Frédéric Demians <frederic at tamil.fr> ---
Yes, it could be great to notify the budget owner, as you said.

Some remarks:

- A patch add a new TO_PROCESS notice to en/mandatory/sample_notices.sql. Why
  no notice for other languages?

- notice_unprocessed_suggestion.pl script has no execution permisions like
  other scripts in misc/cronjobs

- The script help should say that the script uses a notice named TO_PROCESS

- It would be a plus, if running the script without -c were sending the result
  to STDOUT.

- Patron name & surname are in TO_PROCESS notice, but are not displayed. It
  appears that, calling EnqueueLetter, your script doesn't provide borrowers
  table info. You should have:

   tables      => {
       suggestions => $suggestion->{suggestionid},
       branches    => $patron->{branchcode},
       borrowers   => $patron->{borrowernumber},
   },

-- 
You are receiving this mail because:
You are watching all bug changes.