[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

--- Comment #27 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 32808
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32808
Bug 9580 Cover images from Coce, a remote image URL cache

Review of attachment 32808:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9580&attachment=32808)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
@@ +257,5 @@
>                                                              [% END %]
>                                                          [% END %]
>  
> +                                                        [% IF Koha.Preference('CoceProviders') %]
> +                                                          [% IF ( SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn ) %]

Split this into an IF/ELSIF/ELSE
(http://template-toolkit.org/docs/manual/Directives.html#section_IF_UNLESS_ELSIF_ELSE)
So that you can more plainly meet
http://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML

@@ +258,5 @@
>                                                          [% END %]
>  
> +                                                        [% IF Koha.Preference('CoceProviders') %]
> +                                                          [% IF ( SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn ) %]
> +                                                            <span style="block" title="[% SEARCH_RESULT.biblionumber |url %]" class="[% IF ( SEARCH_RESULT.normalized_ean ) %][% SEARCH_RESULT.normalized_ean %][% ELSE %][% SEARCH_RESULT.normalized_isbn %][% END %]" id="coce-thumbnail[% loop.count %]"></span>

Because this is hard to read.

-- 
You are receiving this mail because:
You are watching all bug changes.