[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
This is actually a bug fix. If you read the preference, it reads that
RandomizeHoldsQueueWeight should work even if StaticHoldsQueueWeight is empty.
However, in the original code this was not true.

This change otherwise has no effect on the behavior of the feature. Previously,
if load_branches_to_pull returned undef,
GetItemsAvailableToFillHoldRequestsForBib would use all branches. This is still
true, it just makes more logical sense now.

If you would like me to revert the RandomizeHoldsQueueWeight behavior so the
bug can be fixed separately, I'd be more than happy to do so.


(In reply to Jonathan Druart from comment #13)
> Before this patch, load_branches_to_pull_from return undef if
> StaticHoldsQueueWeight was empty, now RandomizeHoldsQueueWeight and
> HoldsQueueSkipClosed are take into account.
> Kyle, could you please confirm it is an error?
> I am not comfortable enough to fix it in a followup.

-- 
You are receiving this mail because:
You are watching all bug changes.