[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13177                       |

--- Comment #91 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle, 

I went through my notes again and I think the templates, and
adding/editing/deleting rotating collections is now ok. 
There is only one minor thing about the branch list not being alphabetical
(2.3.5).

Running out of time now, please answer my questions about transfer 
behaviour in comment #89 and check comment #79 from Owen, about the behaviour 
for an item that was 'in transit' before the rotating collections transfer.

I will try to continue there tonight.

1. CODE REVIEW

1.1 QA script
- OK  

1.2 Code
- OK, no more problems spotted.

1.3 Database structure 
- OK, changes are consistent.

2. FEATURE TEST

As this brings the Rotating collections feature back to life, I think we
also need to test the feature here. 

2.1 Documentation

2.1.1 Question: Is there a good documentation about the feature 
somewhere? Feeling a bit like flying blind here :)

2.1.2 Problem - no blocker
I have filed bug 13177 for the missing help pages.


2.2 Navigation

2.2.1 OK - FIXED
There is no entry for "Rotating collections" on the side navigation when
you are on a tool's page.

2.2.2 OK - FIXED
The main page of the Rotating collection page is missing the side
navigation altogether.

2.2.3 OK
In several places we have a button to return to the Rotating collections
start page, maybe this could be replaced by the side navigation link?


2.3 Adding a rotating collection

2.3.1 OK - FIXED
The 'new collection' form should have 'Title' marked as required.

2.3.2 OK - FIXED
The error messages stem from RotatingCollections.pm and are not
translatable (see bug 11595). Please fix!

2.3.3 OK - FIXED
The table shows the branch code instead of the description name, 
easy to fix today, with TT!

2.3.4 OK - FIXED with a new toolbar
It feels a bit weird, that I have to use a button to get to a page
where I can edit the collections. Why not have this functionality
accessible from the table on the start page? (Adding "Edit" and "Delete"
links to the table and a "New collection" button at the top? This way
it would fit in a bit better with Koha's usual way of doing things.

2.3.5 Problem - trivial
Branches in the list are not sorted alphabetically by description.

2.3.6 Question - could the description be optional?


2.4 Rotating collections home

2.4.1 OK - FIXED
Several capitalization 'problems' on rotatingCollections.pl.

2.4.1 OK - FIXED
The table shows the branch code instead of the description name, 
easy to fix today, with TT!


2.5 Adding/removing items

2.5.1 OK - FIXED
The error messages stem from RotatingCollections.pm and are not
translatable (see also bug 11595). Please fix!

2.5.2 OK - FIXED 
Error messages should use the usual styling
to stand out a bit more. Example: remove a barcode that is not in the
collection.

2.5.3 OK - FIXED
I am not sure this error makes sense to the user: 
Reason: No Itemnumber Given
I think it would be better to say: Barcode doesn't exist (or similar)

2.5.4 Enhancement idea - OK DONE!
Removing an item from the collection currently requires that you enter
the barcode. It would be nice to also have a 'Delete' link in the 
table.


2.6 Transfers 

Collection goes to Troy.

2.6.1 OK Checking in an item that is "waiting" in Centerville
The rotating collection message shows, but also the hold message.
I confirm the hold message.
The item is still 'waiting' for the patron.
No transfer is generated.

2.6.2 OK Check-out the waiting item in Centerville to the borrower.

2.6.3 OK Check-in item in Centerville.
There is another hold in Springfield for another patron. 
Confirm transfer.
Transfer is generated.

2.6.4 OK Check-in of the item in Springfield.
Confirm hold.
Transfer is completed.

2.6.5 OK Check-out to the patron the item is waiting for.

2.6.6 OK? Check-in of the item in _Centerville_
Patron returns the item at another branch. 
I still see the dialog, that the item shoudl go to "Troy", but
no transfer message is generated, is this the way it's supposed to work?

Note: I think it would be nicer if the rotating collection message
wouldn't show up, when there is a hold message at the same time.


2.7 Transferring a collection

2.7.1  OK
Verified that waiting and checked out items don't get transferred
automatically. 


X. Possible enhancements
- Show rotating collection information in staff detail pages
- Add redirect operations after Add/edit/delete/transfer operations

-- 
You are receiving this mail because:
You are watching all bug changes.