[Koha-bugs] [Bug 11319] Marc modification templates improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319

--- Comment #46 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment bug 11319:
Generally looks good. The current implementation in master is not error free.
This will not resolve all bugs.
5 patches, no koha-qa complaints, added 2 qa follow-ups.
I pass QA on this patch (taking into account the amount of work), but we are
not ready yet. Discussion continues on follow-up reports..

>From patch 3 (as well as the restrictions mentioned in patch 5) -- Actually, I
repeat myself here:
> Note: I don't see the meaning for the add/update action if no subfield is given. So the call without subfield raises an error.
Moving 001 to 029a should be possible. But is not allowed now. Moving 001 to
029 should not be possible (since 001 has no subfields, and 029 has). This is
possible, but will generate an invalid MARC record.
I will not block this patch however for that reason, because current master
does not implement it correctly either. Current master moves the 001 to
<subfield code="001"></subfield> in field 029. Also invalid MARC !

No blocker, but a welcome improvement: Fields are inserted at the end. I would
rather insert the fields in the same group of fields 0XX, 1XX, etc. You could
use insert_grouped_field for that.

Still see some related warnings (resolved another one):
marc_modification_templates.pl: Use of uninitialized value in string eq at
marc_modification_templates.pl line 70.
stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at
/usr/local/lib64/perl5/Template/Provider.pm line 964.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.