[Koha-bugs] [Bug 13116] Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13116

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32920|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 33075
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33075&action=edit
Bug 13116 - Make it possible to propagate errors from
C4::Reserves::CanItemBeReserved() to the web-templates.

This patch changes the way CanBookBeReserved() and CanItemBeReserved() return
error
messages and how they are dealt with in the templates. This change makes it
possible
to distinguish between different types of reservation failure.

Currently only two types of errors are handled, all the way to the user, from
the CanItemBeReserved():
-ageRestricted
-tooManyReserves which translates to maxreserves

 #############
 - TEST PLAN -
 #############
((-- AGE RESTRICTION --))
STAFF CLIENT
1. Find a Record with Items, update the MARC Subfield 521a to "PEGI 16".
2. Get a Borrower who is younger than 16 years.
3. Place a hold for the underage Borrower for the ageRestricted Record.
4. You get a notification, that placing a hold on ageRestricted material is
   forbidden. (previously you just got a notification about maximum amount of
reserves reached)

((-- MAXIMUM RESERVES REACHED --))
0. Set the  maxreserves -syspref to 3 (or any low value)
STAFF CLIENT AND OPAC
1. Make a ton of reserves for one borrower.
2. Observe the notification about maximum reserves reached blocking your
reservations.

((-- MULTIPLE HOLDS STAFF CLIENT --))
3. Observe the error notification "Cannot place hold on some items"

((-- MULTIPLE HOLDS OPAC --))
1. Make a search with many results, of which atleast one is age restricted to
the current borrower.
2. Select few results and "Place hold" from to result summary header element.
       (Not individual results "Place hold")
3. Observe individual Biblios getting the "age restricted"-notification, where
others can be
   reserved just fine.

Updated the unit tests to match the new method return values.
t/db_dependent/Holds.t & Reserves.t

Followed test plan. Works as expected and displays meaningful messages for the
reason why placing a hold is not possible.

Signed-off-by: Marc Veron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.