[Koha-bugs] [Bug 12788] Refine search displays 4xx fields from authority records

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Sep 2 05:27:11 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12788

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31269|0                           |1
        is obsolete|                            |

--- Comment #16 from David Cook <dcook at prosentient.com.au> ---
Created attachment 31317
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31317&action=edit
Bug 12788: (followup) minor optimization with proper tests

This patch removes the $facets_info calculation from the
_get_facets_data_from_record
sub so it is not done for each record. It introduces a new sub,
_get_facets_info
that is called from the getRecords loop, that does the job only once.

To test:
- Apply on top of the previous patches
- Run
  $ prove -v t/db_dependent/Search.t
=> SUCCESS: _get_facets_info gets tested and it passes for both MARC21 and
UNIMARC.
  Facets rendering should remain unchaged on the UI.
- Sign off :-D

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list