[Koha-bugs] [Bug 12790] Perl modules: Display required version numbers on about page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Since the code change is minimal, the signoff of Nick still holds.
I saw the About page on a wider screen now, and it looks good.
If you make the window smaller, it still does not look nice.

Looking at the template code (not your added lines only), it seems that this
could be simplified. For instance, a check on the module name does not really
make sense. If there is no module name, there should be no row.
Furthermore, the template contains several style attrs which probably should be
moved to css.

Imo the display still needs improvement for a smaller screen, but I will not
block this patch for that reason.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.