[Koha-bugs] [Bug 12788] Refine search displays 4xx fields from authority records

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 5 20:34:26 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12788

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31315|0                           |1
        is obsolete|                            |
  Attachment #31316|0                           |1
        is obsolete|                            |
  Attachment #31317|0                           |1
        is obsolete|                            |

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 31422
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31422&action=edit
[PASSED QA] Bub 12788: (regression test) refactor facet extraction code to
allow testing

This patch refactors the facet extraction loop into a proper function.
The loop is changed so the MARC::Record objects are created only once
instead of the old/current behaviour: once for each defined facet (in
C4::Koha::getFacets).

To test:
- Apply the patch
=> SUCCESS: verify facets functionality remains unchanged.
- Run:
  $ prove -v t/db_dependent/Search.t
=> SUCCESS: tests for _get_facets_data_from_record fail, because
  100$a is considered for fields with indicator 1=z (field added
  by IncludeSeeFromInSearches syspref).
- Sign off :-D

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, passes tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list