[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Sep 11 00:12:02 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

--- Comment #34 from M. Tompsett <mtompset at hotmail.com> ---
Okay, this patch needs to be AFTER 10900, and the test cases are in 10895, but
those depend on 10900 as well.

Bug 10589 is an ENHANCEMENT. It was signed off rather quickly, but at the time
I didn't have tests for this. Since it was signed off, I figured I'd write the
tests on another report, bug 10895.

While trying to write the tests, I discovered the calling convention for
set_userenv was broken. So rather than use the broken calling method, I made it
uniform across the board to -> instead of ::. Bug 10900 was the result.

10900 is what corrects the set_userenv calls. To test it, I would pay attention
to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900#c10
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900#c32

Once done then apply bug 10589 and bug 10895.
Kind of like what is talked about in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895#c15

Hope this clarifies this mess of code.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list