[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #51 from Paola Rossi <paola.rossi at cineca.it> ---
I've applied the patch against 3.17.00.025

The patches can be applied with the following note.

NB. The 5-th patch:
All basketgroups on one page - several fixes

changes updatadatabase.pl

So, upgrading the database has to be done after having applied the 5-th patch.
Otherwise, if database is upgraded soon after the 1-st patch, the 6-th patch
can't be applied. That is the error:
Applying: Bug 11708: Remove the amount columns
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
Failed to merge in the changes.

------------------------------------------------------------------------------

So I pass the patch to "Signed Off" status.

------------------------------------------------------------------------------
Having no test plan, I've made some tests on basket groups and written the
following notes. The first notes esplicitly relate to the new all bgs' page. 
IMO the 7-th and 8-th notes come straightforward using the basket groups. I
invite to consider the 9-th note to define a better use (I can't suggest) for
that option. In the case described in 10-th the name of the basket group is
empty in the db, so perhaps the bug can be described better.
I beg your pardon if some of the following notes/errors are out of this patch.
In any case I hope the following notes can help in QA.

basketgroup = bg 

1) On the page of all bgs, after having selected "Delete" action on a bg, the
next page is not the current one; the next page is about only one vendor [he is
the one whose bg I've asked to delete] and it is the bgs' page of the vendor
selected on the closed bgs' tag (ERROR). I think that the next page should be
on the open bgs, at least. 
The closed bgs are completely different from deleted bgs. Moveover no closed bg
can be deleted. So the current next page after deleting bgs can be misleading,
and is unfriendly.

2) Displaying all bgs on one page, the "Delete" action is shown for all the
open bgs. But only bgs without baskets inside are really deleted.
So, the "Delete" action should not be shown [, or the delete should be done,]
for open bgs with baskets inside.

3) On the page of all bgs, after having selected "Delete" action on a bg with
baskets inside, now no message was shown if the bg is not deleted (see above,
2)).

4) : starting from a single vendor's bg, the behaviours described in 1), 2) and
3) are exactly the same. I beg your pardon if this point 4) is certainly out of
this patch, but the problem is the same. 

5) : the 2) and 3) problems occurred also deleting from the tag "xDelete basket
group" [shown at the top of a just reopened bg, "Edit"ing an open bg, ...].

6) On the all bgs page, I had a closed bg whose Billing place and Delivery
place fields were none ("--"). I selected the "View" action of the bg: on the
contrary the two fields were shown filled [with the current user's library].
This error occurred also: :
6b) on open bgs page, using "Edit" action in the all bgs page
6c) from the basket page, selecting the link to the linked closed bg
6d) editing a closed bg, using the "Reopen this bg" tag at the top of the page.
Perhaps the case of a closed bg with Billing place and Delivery place fields
set to none might be prevented by koha at all. 

7) On the all baskets page, you can consider if the bg closeddate' column might
be added. On the all baskets page, the "Bg" column is at the left of the column
of the "Closed" date (which is the basket's close date). No basket can be
attached to a bg before it (the basket) has been closed, so exchanging the two
columns would be consistent with the sequence of events. If added, the bg's
closeddate column would be the last column on the right before the actions'
one.

8) On ACQ, I select a vendor. Under the right permission, in the "New" tag the
Basketgroup option might be added to the current ones: Basket, Contract and
Vendor. 

9) baskets can be homonymous; bgs can be homonymous too. Closing an open
basket, the option "Attach this basket to a new basket group with the same
name" can easely create homonymous bgs, adding new closed ones to already
existent open and closed ones. 

10) For a vendor I created a new bg without filling the Basket group name. Then
I selected a closed basket: but, using "Change bg" option, I saw an empty row
added to the drop down list of the attachable bgs.

------------------------------------------------------------------------------

-- 
You are receiving this mail because:
You are watching all bug changes.