From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:14:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 08:14:42 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:23:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 08:23:21 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:23:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 08:23:24 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 --- Comment #1 from Jonathan Druart --- Created attachment 37412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37412&action=edit Bug 13934: C4::ItemType->get should return undef if no parameter given The issue: If you try to check in an item with a non existent barcode, the application will exploded with a software error: "Can't bless non-reference at .../ItemType.pm Line 64". It's caused by: commit 7431f8cfe29e330e2232b0df591afc4d923b0a52 Bug 11944: Fix encoding issue in C4::ItemType and the following change: @@ -105,9 +104,6 @@ sub get { my $data = $dbh->selectrow_hashref( "SELECT * FROM itemtypes WHERE itemtype = ?", undef, $itemtype ); - if ( $data->{description} ) { - $data->{description} = Encode::encode('UTF-8', $data->{description}); - } because of the following: my $s; $s->{foo} = "bar" if $s->{foo}; use Data::Dumper;warn Dumper $s; => {} # not undef So later, bless $opts => $class; will fail because $opts is undef and was not (i.e. {}) before. Test plan: Try to check in an item with a non existent barcode and confirm you have the friendly warning message instead of the ugly software error. Note for QA: C4::ItemType->get is only uses in circ/return.pl. So even if the behavior is changed, it should not introduce any regression somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:23:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 08:23:36 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 10:23:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 08:23:36 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13934 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:00:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:00:00 +0000 Subject: [Koha-bugs] [Bug 13935] New: Add API route to list borrower's accountlines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13935 Bug ID: 13935 Summary: Add API route to list borrower's accountlines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Web services Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 13799 Add API route to list borrower's accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:00:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:00:00 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13935 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:00:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:00:12 +0000 Subject: [Koha-bugs] [Bug 13090] Using <> in html notices gives wrong encoding in generated letters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13090 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Sophie, Could you explain more precisely please? I tried with unicode characters in the letter template and in the branches.opac_info => it works I tried with diacritics (?) in the letter template and in the branches.opac_info => it displays "é" for the opac_info. Same behavior for html and non-html letters. Note that the é is contained in opac_info (because of mce). Was it your issue? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:00:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:00:32 +0000 Subject: [Koha-bugs] [Bug 13935] Add API route to list borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13935 --- Comment #1 from Julian Maurice --- Created attachment 37413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37413&action=edit Bug 13935: Add API route to list borrower's accountlines GET /borrowers/{borrowernumber}/accountlines GET /borrowers/{borrowernumber}/accountlines?accounttype={accounttype} Unit tests in t/db_dependent/api/v1/borrowers/accountlines.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:00:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:00:48 +0000 Subject: [Koha-bugs] [Bug 13935] Add API route to list borrower's accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13935 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:28:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:28:36 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7989 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:28:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:28:36 +0000 Subject: [Koha-bugs] [Bug 7989] RIS export file type incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7989 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12357 CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:38:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:38:32 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:38:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:38:34 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 --- Comment #1 from Jonathan Druart --- Created attachment 37414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37414&action=edit Bug 8050: Die if package building fails The debian/build-git-snapshot script should not return success if an error occurred. Note that sys_command_output won't raise an error if something fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:38:56 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Robin, do you think this patch could be useful for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:45:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:45:40 +0000 Subject: [Koha-bugs] [Bug 9153] Problem with config file for qa-test-tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9153 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Jonathan Druart --- This is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 11:54:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 09:54:14 +0000 Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search - reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 --- Comment #7 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #6) > Patch pushed to master. > > Thanks Jonathan! There is something wrong with the last past, the patrons search (using the checkout tab) is broken. Working on it and will submit a patch asap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:04:15 +0000 Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search - reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 --- Comment #8 from Jonathan Druart --- Comment on attachment 37361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37361 Bug 13894: Fix if the search returns only 1 result Review of attachment 37361: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13894&attachment=37361) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +487,4 @@ > [% END %] > > > +[% IF ( borrowers ) %] This change was for bug 13926. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:06:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:06:16 +0000 Subject: [Koha-bugs] [Bug 13936] New: Fix patrons search on using the checkout tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Bug ID: 13936 Summary: Fix patrons search on using the checkout tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Patrons Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:06:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:06:30 +0000 Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search - reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13936 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:06:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:06:30 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13894 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:07:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:07:26 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:07:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:07:28 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 --- Comment #1 from Jonathan Druart --- Created attachment 37415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37415&action=edit Bug 13936: Last patch contained wrong change One of the 2 changes done in the last patch was not for this bug report. The tt change was intended for bug 13926. This patch revert it. ! BE CARE: This should NOT be pushed AFTER bug 13926! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:07:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:07:57 +0000 Subject: [Koha-bugs] [Bug 13894] SQLHelper replacement - C4::Members::Search - reserve.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 --- Comment #9 from Jonathan Druart --- Patch on bug 13936, sorry for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:39:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:39:16 +0000 Subject: [Koha-bugs] [Bug 13760] Authorities merge sometimes create duplicate fields in biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 --- Comment #6 from Jacek Ablewicz --- (In reply to Fridolin SOMERS from comment #0) > Actually some cases create a duplicate field. > For example, a biblio record as : > 600 $9 11 $a Son Goku > 600 $9 12 $a Vegeta > If you merge the authorities id=11 and id=12 into id=11 (creating Gogeta), > you actually get : > 600 $9 11 $a Son Goku > 600 $9 11 $a Son Goku This patch seems to work fine for relativelly simple cases. But what about some more complex ones, like e.g: 700 $9 11 $a Son Goku $t Aaa Bbb 700 $9 12 $a Vegeta $t Ddd Ccc 700 $9 12 $a Vegeta $t Eee Fff after merge, result will be: 700 $9 11 $a Son Goku $t Aaa Bbb instead of 700 $9 11 $a Son Goku $t Aaa Bbb 700 $9 11 $a Son Goku $t Ddd Ccc 700 $9 11 $a Son Goku $t Eee Fff > Having two identical fields linked to the same authority is useless. I agree, but there is no check anywhere to ensure that the suspected "duplicates" are in fact identical? While having 2+ $9 links to the same authority record from one biblio record is probably not very common (depending on the material type, local cataloguing rules etc.), AFAIK this can happen occasionally and in such cases it's not always necessarily an error and/or a duplicate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:52:40 +0000 Subject: [Koha-bugs] [Bug 9099] Checked-in barcode export should not send empty file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- This could increase significantly all pages where this link is displayed. I am not sure it is worth to do it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:59:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:59:02 +0000 Subject: [Koha-bugs] [Bug 9081] Opac news not output on check in and check out notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9081 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |7001 --- Comment #1 from Jonathan Druart --- Looking at the code, I would say it only works for letter_code == ISSUESLIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 12:59:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 10:59:02 +0000 Subject: [Koha-bugs] [Bug 7001] User Configurable Slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9081 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:01:04 +0000 Subject: [Koha-bugs] [Bug 9083] <> in checkin/checkout notices does nothing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- items.content only works with overdue and advanced notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:05:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:05:01 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 --- Comment #3 from Robin Sheat --- I haven't had a look at the detail, but based on the subject I think it's a good thing. I'll look closer soon I hope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:08:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:08:40 +0000 Subject: [Koha-bugs] [Bug 9080] Encoding on pay fines page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9080 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Could you confirm this is fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:16:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:16:05 +0000 Subject: [Koha-bugs] [Bug 9071] Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, | |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com --- Comment #4 from Jonathan Druart --- The good practice would be to have an "insert ignore into" statement. But actually you are right, we missed a lot of "insert into" without any check. QAers should keep a closed eye on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:26:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:26:59 +0000 Subject: [Koha-bugs] [Bug 9071] Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #5 from M. de Rooy --- Sounds like we can close this report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:30:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:30:01 +0000 Subject: [Koha-bugs] [Bug 9071] Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #6 from Chris Nighswonger --- (In reply to M. de Rooy from comment #5) > Sounds like we can close this report? Had the problem been addressed in a sustainable way? I'm not sure it has. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:32:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:32:09 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:32:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:32:14 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #2 from Jonathan Druart --- Created attachment 37416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37416&action=edit Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" No behavior should exist on importing bibliographic records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:32:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:32:42 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #74 from Martin Renvoize --- Indeed, I had a hunt around the sysprefs code in koha last night after making my suggestion and decided it would be a nightmare to implement at the koha side :( I might add a route to coce (and a pull request) anyway to get the available providers as it would perhaps be useful in the other app we're developing that uses it. I like the idea of a shared 'local image store'.. it's a shame that the OpenLibrary project is slowing as you suspect though :(. Certainly.. I'd pass qa on your followups Tomas, so I'd suggest pushing as is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:33:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:33:21 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10097 Patch complexity|--- |Small patch --- Comment #3 from Jonathan Druart --- (In reply to Magnus Enger from comment #0) > the text "Add new bibliographic records into this framework:" followed by a > dropdown containing the bibliographic frameworks. See attached screenshot. This has been done by bug 10097. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:33:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:33:21 +0000 Subject: [Koha-bugs] [Bug 10097] Hide framework selection when importing staged authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10097 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9067 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:34:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:34:32 +0000 Subject: [Koha-bugs] [Bug 9071] Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #7 from Jonathan Druart --- It should be added to the coding guidelines and catched by QAers for new patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 13:40:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 11:40:57 +0000 Subject: [Koha-bugs] [Bug 9071] Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #8 from Chris Nighswonger --- (In reply to Jonathan Druart from comment #7) > It should be added to the coding guidelines and catched by QAers for new > patches. I'd like to see it added and a link posted here when the bug is marked resolved for continuity's sake. I'm working on my phone or I'd do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:00:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:00:33 +0000 Subject: [Koha-bugs] [Bug 9081] Opac news not output on check in and check out notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9081 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement --- Comment #2 from Katrin Fischer --- I am switching to an enhancement request :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:01:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:01:34 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 --- Comment #1 from Jonathan Druart --- Created attachment 37417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37417&action=edit Bug 9006: Remove AUTOLOAD in C4::Context Happily this was only used for intranetdir. It's time to remove it and replace existing calls. I used the following commands to catch calls to C4::Context: git grep 'C4::Context\->' | grep -v 'C4::Context->preference' | grep -v 'C4::Context->config' | grep -v 'C4::Context->userenv' | grep -v 'C4::Context->IsSuperLibrarian' | grep -v 'C4::Context->dbh' | grep -v 'C4::Context->set_preference' | grep -v '_syspref_cache' | grep -v _userenv | grep -v 'C4::Context->interface' | grep -v 'C4::Context->Zconn' | grep -v 'C4::Context->queryparser' | grep -v 'C4::Context->tz' | grep -v 'C4::Context->boolean_preference' | grep -v 'C4::Context->memcached' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:01:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:01:32 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:02:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:02:09 +0000 Subject: [Koha-bugs] [Bug 9006] autoload in C4::Context is a bad idea In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9006 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:05:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:05:39 +0000 Subject: [Koha-bugs] [Bug 9099] Checked-in barcode export should not send empty file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099 --- Comment #3 from Katrin Fischer --- Hm, could we always display the link, but fall back to a nice alert "no checkouts to export" after the link was clicked? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:09:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:09:02 +0000 Subject: [Koha-bugs] [Bug 9099] Checked-in barcode export should not send empty file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099 --- Comment #4 from Jonathan Druart --- If the file is empty, I suppose the librarian will understand easily why it is empty, don't you think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:09:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:09:39 +0000 Subject: [Koha-bugs] [Bug 9083] <> in checkin/checkout notices does nothing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9083 --- Comment #2 from Katrin Fischer --- I think it is not functional, it should ideally not appear in the list on the left side for markers to use in the notice - but not sure this can be done, as the notices are all in "circulation". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:14:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:14:54 +0000 Subject: [Koha-bugs] [Bug 9099] Checked-in barcode export should not send empty file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099 --- Comment #5 from Katrin Fischer --- It would save some additional steps - saving and checking the file. It would be nice, I suggest changing this to enh. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:46:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:46:22 +0000 Subject: [Koha-bugs] [Bug 13937] New: Add a 'primary status' field for items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Bug ID: 13937 Summary: Add a 'primary status' field for items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries have found that Koha doesn't work well with some external services like SHAREit that utilize z39.50 to get information about a record and its' items. a) We propose to add field 'status' to items table ( this field can be mapped to whatever MARC tag you wish ) b) Engineer a subroutine that would generate the item's status The precedence for status would be as follows: 1) Checked Out 2) Lost 3) Not for Loan 4) Damaged 5) On Hold ( In Transit ) 6) In Transit 7) On Hold This status could eventually be used within Koha to simplify our status display logic, but that is outside the immediate scope of this enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:46:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:46:30 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 14:56:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 12:56:01 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure about this idea - do we really need to store it in the database as it is a calculated value? Or could it be something that is added on export? Some libraries allow check-out of damaged items depending on severity - not sure if the sequence is something that should/could be configurable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 15:06:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 13:06:38 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #83 from Matthias Meusburger --- Created attachment 37418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37418&action=edit Bug 8236: Tests for Renewing policy in overdue or restriction case - Add tests in t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 15:18:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 13:18:00 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #2 from Kyle M Hall --- (In reply to Katrin Fischer from comment #1) > I am not sure about this idea - do we really need to store it in the > database as it is a calculated value? Or could it be something that is added > on export? > Some libraries allow check-out of damaged items depending on severity - not > sure if the sequence is something that should/could be configurable. It must have the ability to be stored in the MARC, otherwise it won't be useful. The problem is that external software utilizing z39.50 cannot determine the true status of an item based on the fields returned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 15:21:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 13:21:36 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #3 from Kyle M Hall --- I would also like the emphasize that this will be a completely optional component and will not be a required feature in Koha. As I wrote, we *could* use this feature within Koha, but I don't see that happening any time soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 15:32:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 13:32:10 +0000 Subject: [Koha-bugs] [Bug 8902] Many columns do not appear in batch modification if selected records do not include them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8902 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- It looks like this is fixed. Could someone confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 15:36:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 13:36:50 +0000 Subject: [Koha-bugs] [Bug 8879] silence messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|silence messages from |silence messages from |running prove ./t ./xt |running prove ./t (omnibus) |(omnibus) | CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- % prove xt xt/permissions.t ............ ok xt/sample_notices.t ......... ok xt/single_quotes.t .......... ok xt/tt_valid.t ............... ok xt/verify-debian-docbook.t .. ok xt/yaml_valid.t ............. ok All tests successful. Files=6, Tests=116, 3 wallclock secs ( 0.06 usr 0.00 sys + 3.56 cusr 0.04 csys = 3.66 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 15:51:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 13:51:07 +0000 Subject: [Koha-bugs] [Bug 8835] Two indexes on biblioitems.issn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Since 3.01 is a quite old version, I think this bug report could be closed. Fridolin, do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 15:59:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 13:59:07 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #3 from Jonathan Druart --- *** Bug 8830 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 15:59:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 13:59:07 +0000 Subject: [Koha-bugs] [Bug 8830] authority cataloging errors not helpful In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8830 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- Please have a look to the fix I submitted on bug 8399. *** This bug has been marked as a duplicate of bug 8399 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:07:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:07:02 +0000 Subject: [Koha-bugs] [Bug 8807] add Carton support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:09:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:09:30 +0000 Subject: [Koha-bugs] [Bug 13938] New: Staging MARC records for import fails Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Bug ID: 13938 Summary: Staging MARC records for import fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It appears that bug 8970 has introduced a bug where a MARC file uploaded for staging fails to import *unless* a matching rule is selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:12:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:12:20 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:12:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:12:26 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 --- Comment #1 from Kyle M Hall --- Created attachment 37419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37419&action=edit Bug 13938 - Staging MARC records for import fails It appears that bug 8970 has introduced a bug where a MARC file uploaded for staging fails to import *unless* a matching rule is selected. Test Plan: 1) Apply this patch 2) Stage and import a MARC record *without* choosing a matching rule 3) Note the staging works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:12:40 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:12:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:12:55 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13938 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:12:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:12:55 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8970 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:26:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:26:21 +0000 Subject: [Koha-bugs] [Bug 8802] Library group records - category type reverts to "searchdomain" when editing group record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:26:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:26:24 +0000 Subject: [Koha-bugs] [Bug 8802] Library group records - category type reverts to "searchdomain" when editing group record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8802 --- Comment #2 from Jonathan Druart --- Created attachment 37420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37420&action=edit Bug 8802: On editing a library group category type is not set The category type was always set to 'searchdomain', because it's the first of the dropdown list. Test plan: 1/ Create or edit a library group 2/ Set the category type to "properties" 3/ Edit it again 4/ Confirm "properties" is correctly selected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:27:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:27:10 +0000 Subject: [Koha-bugs] [Bug 8802] Library group records - category type reverts to "searchdomain" when editing group record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:30:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:30:09 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Sophie, do you know if this is still valid for recent version of Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:41:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:41:34 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- (In reply to Kyle M Hall from comment #2) > (In reply to Katrin Fischer from comment #1) > > I am not sure about this idea - do we really need to store it in the > > database as it is a calculated value? Or could it be something that is added > > on export? > > Some libraries allow check-out of damaged items depending on severity - not > > sure if the sequence is something that should/could be configurable. > > It must have the ability to be stored in the MARC, otherwise it won't be > useful. The problem is that external software utilizing z39.50 cannot > determine the true status of an item based on the fields returned. I'm +1 for the general idea of providing a unified item status value to consumers of Koha APIs, Z39.50 clients, and metadata exports. But responding to your response to Katrin's point: for the purpose of a Z39.50 client or a consumer of a MARC export, it doesn't need to be _stored_ in the MARC record or in the items table; it only needs to be emitted when called for. This could, for example, be invoked by EmbedItemsInMarcBiblio(). Another option would be to have it be a derived DBIC virtual field. Why not store it in an items.status column? Because doing so automatically creates more work: it would HAVE to be kept up to date whenever an item gets modified or participates in a circulation transaction. Why? You can't stop folks from writing SQL queries on it, and you can't stop developers who are not intimately familiar with Koha's notion of item status from trying to use it. To put it another way, *storing* the calculated unified item status value in the database means that you couldn't evade the scope creep of fixing all the item status things in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:47:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:47:33 +0000 Subject: [Koha-bugs] [Bug 8767] Import patron can't handle large files well In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8767 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |INVALID --- Comment #1 from Jonathan Druart --- Check your reverse proxy configuration. It does not come from Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 16:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 14:50:36 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #5 from Katrin Fischer --- Hm, it would also be very annoying to correct in case of changing the logic or adding to it. Calculating on the fly might allow for more flexibility and configuration options here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 17:16:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 15:16:10 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > The checks for duplicate values within the order work, but it's not > correctly checking the database. What did you mean with "not correctly"? Does this still valid? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 17:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 15:20:25 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 --- Comment #6 from Katrin Fischer --- Hm, thinking about it, this is probably what I meant: - if you have duplicates in the forms on the order page (2 items, same barcode) it is found. - if you have a barcode in an item, that already exists in the database, it isn't found I haven't retested, but I think that's what happened. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 17:21:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 15:21:42 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock at ccfls.org --- Comment #2 from Cindy Murdock Ames --- Created attachment 37421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37421&action=edit Signed Off patch for bug 13938 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 17:22:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 15:22:37 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Cindy Murdock Ames --- Applied patch and was able to upload records without having a matching rule selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 17:40:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 15:40:17 +0000 Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break (from bug 13601) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37401|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 37422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37422&action=edit [PASSED QA] Bug 13933: Fix t/DateUtils.t without DB If the mysql server is not running, the DateUtils.t tests failed. This is caused by commit dd9f456ab7c2f0e66173a6feb7df2a38604c82cd Bug 13601: Add tests to highlight the problems with DateTime::Format::DateParse The pref dateformat and TimeFormat were retrieved before the mock. Before bug 13601, the complete preference method was mocked, that's why the error did not appear. Test plan: sudo service mysql stop prove t/DateUtils.t should be happy Signed-off-by: Nicolas Legrand Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 17:40:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 15:40:15 +0000 Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break (from bug 13601) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 17:49:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 15:49:29 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 --- Comment #4 from Kyle M Hall --- I should note that I'm not seeing this bug on all 3.18.04 servers, but have seen it on couple. I cannot ascertain the exact circumstances that trigger the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 17:50:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 15:50:57 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37419|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 17:51:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 15:51:55 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37421|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 37423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37423&action=edit [SIGNED-OFF] Bug 13938 - Staging MARC records for import fails It appears that bug 8970 has introduced a bug where a MARC file uploaded for staging fails to import *unless* a matching rule is selected. Test Plan: 1) Apply this patch 2) Stage and import a MARC record *without* choosing a matching rule 3) Note the staging works as expected Signed-off-by: Cindy Ames Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 18:12:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 16:12:36 +0000 Subject: [Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #75 from Tom?s Cohen Arazi --- Feature pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 18:13:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 16:13:46 +0000 Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break (from bug 13601) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 18:52:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 16:52:03 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- To echo Galen, the items are not stored in MARC .. we got rid of that in Koha 3.4 it's only exported to MARC when we are generating the MARC for zebra or an export. So yeah, adding it to the EmbedItemsInMarcBiblio() subroutine would make a lot of sense to me. Since that is the single point in Koha where items data is converted to MARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 20:29:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 18:29:28 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 20:29:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 18:29:30 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37281|0 |1 is obsolete| | --- Comment #15 from Winona Salesky --- Created attachment 37424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37424&action=edit Bug 13383 - RDA: 100/110/111 changes to XSLT Test plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 100,110,111 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 100,110,111 to show subfields a,b,c,d,q and t.Multiple fields are separated by span class=separator |. 7) Repeat steps 4 - 6 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 22:13:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 20:13:25 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 22:14:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 20:14:42 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 22:16:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 20:16:50 +0000 Subject: [Koha-bugs] [Bug 8437] Plack and database backup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 1 23:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 21:47:16 +0000 Subject: [Koha-bugs] [Bug 4040] Placing a hold on an item while it is in transit results in duplicate dialogs upon check-in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4040 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 00:00:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 22:00:14 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37414|0 |1 is obsolete| | --- Comment #4 from Robin Sheat --- Created attachment 37425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37425&action=edit Bug 8050: Die if package building fails The debian/build-git-snapshot script should not return success if an error occurred. Note that sys_command_output won't raise an error if something fails. Signed-off-by: Robin Sheat Made a minor change to print the command, add a newline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 00:00:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 22:00:47 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 00:01:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 22:01:24 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 --- Comment #5 from Robin Sheat --- Jonathan, if you can give my changes a quick review then that'll be enough for me to consider it passed QA too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 00:04:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 22:04:21 +0000 Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break (from bug 13601) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933 --- Comment #5 from Robin Sheat --- Cheers, I had a quick look but I couldn't actually see _why_ it was happening. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 00:05:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 22:05:08 +0000 Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 00:06:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Apr 2015 22:06:09 +0000 Subject: [Koha-bugs] [Bug 12887] User logged out on refresh after CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12887 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 06:19:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 04:19:59 +0000 Subject: [Koha-bugs] [Bug 13939] New: ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13939 Bug ID: 13939 Summary: ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 06:20:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 04:20:20 +0000 Subject: [Koha-bugs] [Bug 13939] ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13939 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 06:25:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 04:25:45 +0000 Subject: [Koha-bugs] [Bug 13939] ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13939 --- Comment #1 from Josef Moravec --- Created attachment 37426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37426&action=edit Bug 13939: ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron Test plan: 1) Enable ILS DI (system preference 'ILS-DI') 2) Try to access the URL http:///cgi-bin/koha/ilsdi.pl?service=GetServices&patron_id=&item_id= Choose the patron and item to be available for hold You'll see an error instead of valid XML response 3) apply the patch 4) try to access the same URL, you should see valid XML response with services "title level hold" and eventually "item level hold" returned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 06:26:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 04:26:15 +0000 Subject: [Koha-bugs] [Bug 13939] ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13939 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 06:34:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 04:34:14 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 06:49:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 04:49:08 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 --- Comment #2 from M. Tompsett --- Comment on attachment 37412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37412 Bug 13934: C4::ItemType->get should return undef if no parameter given Review of attachment 37412: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13934&attachment=37412) ----------------------------------------------------------------- ::: C4/ItemType.pm @@ +99,5 @@ > > sub get { > my ($class, $itemtype) = @_; > + > + return unless $itemtype; Hypothetical question: Could not someone do something crazy like have an itemtype code of 0? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 06:54:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 04:54:09 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 06:54:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 04:54:11 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37412|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 37427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37427&action=edit Bug 13934: C4::ItemType->get should return undef if no parameter given The issue: If you try to check in an item with a non existent barcode, the application will exploded with a software error: "Can't bless non-reference at .../ItemType.pm Line 64". It's caused by: commit 7431f8cfe29e330e2232b0df591afc4d923b0a52 Bug 11944: Fix encoding issue in C4::ItemType and the following change: @@ -105,9 +104,6 @@ sub get { my $data = $dbh->selectrow_hashref( "SELECT * FROM itemtypes WHERE itemtype = ?", undef, $itemtype ); - if ( $data->{description} ) { - $data->{description} = Encode::encode('UTF-8', $data->{description}); - } because of the following: my $s; $s->{foo} = "bar" if $s->{foo}; use Data::Dumper;warn Dumper $s; => {} # not undef So later, bless $opts => $class; will fail because $opts is undef and was not (i.e. {}) before. More explicit test plan: 1) Log in to staff client 2) Circulation -> Check in 3) Type a non-existent barcode into 'Enter item barcode:' textbox 4) Click 'Submit' -- Should receive nasty error. 5) apply patch 6) repeat steps 2-4 -- Should be told 'No item with barcode: {what you typed}' 7) prove -v t/ItemType.t -- All tests should run successfully. 7) run koha qa test tools Note: Having tried to create and use an itemtype '0', this only demonstrates a lack of validation on the itemtype creation screen. Unable to use it without tweaking back end. That is beyond the scope of this bug. Note for QA: C4::ItemType->get is only uses in circ/return.pl. So even if the behavior is changed, it should not introduce any regression somewhere else. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 08:17:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 06:17:21 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #14 from M. Tompsett --- I'm just curious why not use IPC::Run::run? Is the time stamp on the file of when we ran the updates important? It seems like update log files will just build up forever. Is there a point to their accumulation? What questions are we trying to answer with them? I'm wondering if there is an optimization that is being missed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 08:21:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 06:21:13 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 --- Comment #15 from M. Tompsett --- Never mind. I saw the 13793 bug now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 09:36:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 07:36:20 +0000 Subject: [Koha-bugs] [Bug 13254] Delete record don't wait for confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Fridolin SOMERS --- Pushed to 3.14, will be in 3.14.15. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 09:49:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 07:49:59 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 IT-and-COMM changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |IT at bibliothek-grossauheim.d | |e -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 09:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 07:57:38 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 --- Comment #1 from IT-and-COMM --- Well it should show _at least_ 20 entries. And it should start five years in the past, since patrons creation requests for the age from 0 years to 5 years are not dropping in that frequently. Do they? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 10:45:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 08:45:51 +0000 Subject: [Koha-bugs] [Bug 13212] Use CSS3 ellipsis instead of FacetLabelTruncationLength In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13212 --- Comment #1 from Fridolin SOMERS --- Created attachment 37428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37428&action=edit Bug 13212 - Use CSS3 ellipsis instead of FacetLabelTruncationLength - intranet CSS3 has text-overflow: ellipsis - should use that instead of FacetLabelTruncationLength. This patch provides a POC for intranet. It adds ellipsis on all facet types except the availability one. Try to play with facets block size to see ellipsis is correct. See that facet count is hidden when ellipsis is used. An easy way to correct would be to set facet count first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 10:46:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 08:46:58 +0000 Subject: [Koha-bugs] [Bug 13212] Use CSS3 ellipsis instead of FacetLabelTruncationLength In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13212 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m Status|NEW |ASSIGNED --- Comment #2 from Fridolin SOMERS --- This a POC to test on intranet facets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 10:48:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 08:48:58 +0000 Subject: [Koha-bugs] [Bug 13053] Do not use template cache when from commandline In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13053 --- Comment #7 from Fridolin SOMERS --- Can this be backported to 3.16.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 10:50:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 08:50:30 +0000 Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #30 from Fridolin SOMERS --- Can this be backported to 3.16.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 10:53:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 08:53:56 +0000 Subject: [Koha-bugs] [Bug 12616] Locale in subscriptions should not default to English when empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #2 from Katrin Fischer --- This is still a problem in 3.18.5.1 The pull down defaults to Urdu instead of empty. The note says: If empty, English is used - independent of the selected display language. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 10:58:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 08:58:33 +0000 Subject: [Koha-bugs] [Bug 12856] koha-disable fails without disabling site In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12856 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m Depends on| |11404 --- Comment #14 from Fridolin SOMERS --- Depends on Bug 11404 that adds $instancefile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 10:58:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 08:58:33 +0000 Subject: [Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12856 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 10:59:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 08:59:23 +0000 Subject: [Koha-bugs] [Bug 12616] Locale in subscriptions should not default to English when empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #3 from Katrin Fischer --- Hm, there is a deeper problem behind this in the creation of the language list. Multiple entries are marked as selected in the source code with an empty value attribute: ... ... The preselection of Urdu also happens in the English GUI. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 11:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 09:04:48 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS --- Pushed to 3.14, will be in 3.14.15. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 11:07:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 09:07:10 +0000 Subject: [Koha-bugs] [Bug 12616] Locale in subscriptions not preselecting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12616 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Locale in subscriptions |Locale in subscriptions not |should not default to |preselecting correctly |English when empty | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 11:12:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 09:12:33 +0000 Subject: [Koha-bugs] [Bug 13940] New: Testing C4::OAI::Sets Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Bug ID: 13940 Summary: Testing C4::OAI::Sets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Test Suite Assignee: julian.fiol at biblibre.com Reporter: julian.fiol at biblibre.com QA Contact: gmcharlt at gmail.com Testing C4::OAI::Sets in t/db_dependent/OAI/Sets.t Adding &DelOAISetsBiblio in @EXPORT at the beginning of OAI/Sets.pm, it was the only one missing TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/OAI/Sets.t -- All 145 tests should run successfully without any error or warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 11:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 09:16:02 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 --- Comment #1 from Julian FIOL --- Created attachment 37429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37429&action=edit Bug 13940 : Testing C4::OAI::Sets Testing C4::OAI::Sets in t/db_dependent/OAI/Sets.t Adding &DelOAISetsBiblio in @EXPORT at the beginning of OAI/Sets.pm, it was the only one missing TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/OAI/Sets.t -- All 145 tests should run successfully without any error or warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 11:17:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 09:17:09 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 11:17:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 09:17:08 +0000 Subject: [Koha-bugs] [Bug 13941] New: Add ids to pages in staff client where missing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Bug ID: 13941 Summary: Add ids to pages in staff client where missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Some time ago we added ids and classes to all the pages in the staff client to make it easier to customize. The newly added modules are missing those and we should add them. So far I noticed they are missing on the course reserves pages, but a search would probably turn up some more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 11:27:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 09:27:43 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 --- Comment #21 from Katrin Fischer --- Running into the problem with "term" again - which has 2 different meanings in German. Any progress on this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 11:33:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 09:33:27 +0000 Subject: [Koha-bugs] [Bug 13502] A bug was introduced by 1861 - meaning borrowers sometimes cant be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13502 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13602 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 11:33:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 09:33:27 +0000 Subject: [Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolyn.somers at biblibre.co | |m Depends on| |13502 --- Comment #17 from Fridolin SOMERS --- Depends on Bug 13502 which changed the behavior of Check_Userid with undefined $uid. Not needed for 3.14.x. By the way, why check userid when this data is unchanged (not in $newdata because not edited) ? Also, the flag $NoUpdateLogin manages whether or not the userid can be edited. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 11:57:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 09:57:36 +0000 Subject: [Koha-bugs] [Bug 13942] New: Testing the 'recordpayment' function in C4::Accounts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 Bug ID: 13942 Summary: Testing the 'recordpayment' function in C4::Accounts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Test Suite Assignee: julian.fiol at biblibre.com Reporter: julian.fiol at biblibre.com QA Contact: gmcharlt at gmail.com Testing the 'recordpayment' function in C4::Accounts TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Accounts.t -- All 15 tests should run successfully without any error or warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 12:00:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 10:00:30 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 --- Comment #1 from Julian FIOL --- Created attachment 37430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37430&action=edit Bug 13942 : Testing the 'recordpayment' function in C4::Accounts TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Accounts.t -- All 15 tests should run successfully without any error or warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 12:07:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 10:07:15 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 12:23:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 10:23:12 +0000 Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36672|0 |1 is obsolete| | --- Comment #16 from Matthias Meusburger --- Created attachment 37431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37431&action=edit Bug 13507: Add intranet support for CAS authentication This patch allows to use CAS authentication for intranet login. It works exactly the same as the OPAC login, except that the staffClientBaseURL syspref must be set for intranet login (like OPACBaseURL must be set for OPAC login). Signed-off-by: Koha Team AMU Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 12:23:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 10:23:43 +0000 Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #17 from Matthias Meusburger --- It was just a template issue, rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 12:38:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 10:38:25 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 12:46:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 10:46:47 +0000 Subject: [Koha-bugs] [Bug 13939] ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13939 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37426|0 |1 is obsolete| | CC| |misilot at fit.edu --- Comment #2 from Tom Misilo --- Created attachment 37432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37432&action=edit Sign off of patch Test plan works as stated, and resolves error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 12:46:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 10:46:59 +0000 Subject: [Koha-bugs] [Bug 13939] ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13939 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 13:49:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 11:49:49 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37429|0 |1 is obsolete| | --- Comment #2 from Julian FIOL --- Created attachment 37433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37433&action=edit Bug 13940 : Testing C4::OAI::Sets Testing C4::OAI::Sets in t/db_dependent/OAI/Sets.t Adding &DelOAISetsBiblio in @EXPORT at the beginning of OAI/Sets.pm, it was the only one missing TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/OAI/Sets.t -- All 145 tests should run successfully without any error or warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 13:54:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 11:54:55 +0000 Subject: [Koha-bugs] [Bug 13943] New: Cancelling the deletion process of an item deletes item anyway Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 Bug ID: 13943 Summary: Cancelling the deletion process of an item deletes item anyway Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This is kind of an odd bug, as we have not been able to reproduce the problem consistently. - search for a record with items - go to the detail page - edit > edit items - click the delete link at the beginning of the items table on top - in the alert window 'do you really want...' click 'cancel' - the page reloads and the item is deleted anyway A library reported the problem to us and after I couldn't reproduce it, we did a screenshare to see if we could find what we were doing differently. The first item we deleted showed the wrong behaviour, after that we were not able to reproduce it agan. Koha version is 3.18.5.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 14:12:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 12:12:12 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 --- Comment #3 from Julian FIOL --- TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for the statements of this module. Coverage BEFORE this patch : Statement : 6,7% Branch : 0,0% Condition : 0,0% Subroutine : 21,1% Pod : 100,0% Coverage AFTER this patch : Statement : 100,0% Branch : 89,5% Condition : 88,8% Subroutine : 100,0% Pod : 100,0% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 14:49:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 12:49:04 +0000 Subject: [Koha-bugs] [Bug 13896] PID is created in /tmp/ instead of in /var/run/koha/... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 14:49:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 12:49:06 +0000 Subject: [Koha-bugs] [Bug 13896] PID is created in /tmp/ instead of in /var/run/koha/... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37164|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 37434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37434&action=edit Bug 13896: Fix pid file creation, use proper directory instead of /tmp/ daemon uses by default /tmp/ for pid files, if they are unspecified. Pass the right directory to daemon, so it knows where to put the pid file. Signed-off-by: Attila Kinali TEST PLAN --------- 1) Roll a distribution and confirm it works. OR 1) Hack all the /var directories to point to git directories 2) Add a dummy user for the instance name 3) sudo the script with the faked instance name. -- the daemon should be running and the pid file should be in the expected directory. The first way is the proper way to test, I did the latter. :) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:14:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:14:08 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:14:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:14:10 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37197|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 37435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37435&action=edit Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected NOTE: I did not run this test plan. Verification steps ------------------ 1. Find out where barcode_check is used. $ git grep barcode_check -- This is only in serials-edit.tt and serials-receive.tt 2. This patch only affects serials-edit.tt, so check who put the $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- note the commit related number. 3. Check out the commit. $ git show 77b64098 -- should show bug 5917, but the patches on bugzilla don't have the change nicely, so... 4. Hunt through the pages to find the change. -- Note: it is part of a "new file" diff! 5. Since this code hasn't been running since it was added... 6. apply the patch 7. run koha-qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:17:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:17:11 +0000 Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break (from bug 13601) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr --- Comment #6 from Nicolas Legrand --- Created attachment 37436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37436&action=edit Reproduce Bug 13933 This patch create subfields that should break when updating DBRev to 3.19.00.006. Here is the ouptut on a 3.18.x box : $ ./reproduce_bug_13933.pl Add subfield 666z and 666Z Try update to DBRev 3.19.00.006 for marc_subfield_structure only DBD::mysql::db do failed: Duplicate entry '666-z' for key 'PRIMARY' at ./reproduce_bug_13933.pl line 29. Remove subfield 666z and 666Z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:20:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:20:40 +0000 Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break (from bug 13601) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933 --- Comment #7 from Nicolas Legrand --- argh sorry wrong bug, is there a way to remove my attachment and comments? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:23:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:23:34 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr --- Comment #5 from Nicolas Legrand --- Created attachment 37437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37437&action=edit Reproduce Bug 13810 This patch create subfields that should break when updating DBRev to 3.19.00.006. Here is the ouptut on a 3.18.x box : ./reproduce_bug_13810.pl Add subfields 666z and 666Z Try update to DBRev 3.19.00.006 for marc_subfield_structure only DBD::mysql::db do failed: Duplicate entry '666-z' for key 'PRIMARY' at ./reproduce_bug_13810.pl line 29. Remove subfields 666z and 666Z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:25:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:25:12 +0000 Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break (from bug 13601) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37436|0 |1 is obsolete| | --- Comment #8 from Nicolas Legrand --- Comment on attachment 37436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37436 Reproduce Bug 13933 Make it obsolete, sorry for the noise :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:36:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:36:37 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:36:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:36:39 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37433|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 37438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37438&action=edit Bug 13940 : Testing C4::OAI::Sets Testing C4::OAI::Sets in t/db_dependent/OAI/Sets.t Adding &DelOAISetsBiblio in @EXPORT at the beginning of OAI/Sets.pm, it was the only one missing TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/OAI/Sets.t -- All 145 tests should run successfully without any error or warning 3. Run koha qa test tools -- No issues found. Additionally, I comfirmed why DelOAISetsBiblio was added in the list of exported functions. $ grep "^sub " C4/OAI/Sets.pm | sort > check1 $ for i in `grep "\&[A-Z]" C4/OAI/Sets.pm | xargs `; do echo $i; done | sort > check2 Of course the outputs have a little extra around them, so $ vi check1 $ vi check2 $ diff check1 check2 Lo and behold, it was that one function. Necessary for 100% coverage. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:52:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:52:16 +0000 Subject: [Koha-bugs] [Bug 13944] New: Fund sorting is inconsistent across different parts of Koha Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13944 Bug ID: 13944 Summary: Fund sorting is inconsistent across different parts of Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Fund sorting is quite erratic between different parts of Koha: 1) Acquisitions Home ( acqui/acqui-home.pl ) Default Sort: Fund Code 2) Funds for a Budget ( admin/aqbudgets.pl ) Default Sort: Order of Creation ( aka no sorting ) 3) Fund pulldown for an order line ( acqui/neworderempty.pl ) Default Sort: Fund Name It would be nice to get all these sorted the same by default. I think the choices are: a) Sort all by Fund Name b) Sort all by Fund Code ( requires adding the Fund Code to the funds list pulldown for order lines ) The question is, which of these choices would be best? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:52:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:52:21 +0000 Subject: [Koha-bugs] [Bug 13944] Fund sorting is inconsistent across different parts of Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13944 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:53:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:53:23 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:53:25 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37430|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 37439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37439&action=edit Bug 13942 : Testing the 'recordpayment' function in C4::Accounts TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Accounts.t -- All 15 tests should run successfully without any error or warning Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 15:56:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 13:56:39 +0000 Subject: [Koha-bugs] [Bug 13944] Fund sorting is inconsistent across different parts of Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think I'd prefer a sorting by fund name. But on the funds administration page it might make sense to sort by code instead, not sure. 2) seems the most problematic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:08:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:08:31 +0000 Subject: [Koha-bugs] [Bug 13945] New: Multiple dialogs for item that needs transferred and hold captured at checkin Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945 Bug ID: 13945 Summary: Multiple dialogs for item that needs transferred and hold captured at checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 37440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37440&action=edit Screenshot If an item is checked in at library A, and the item needs transferred to library B, *and* there is a hold trapped for pickup at library B, the librarian will see a dialog both for the transfer, and for the hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:08:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:08:39 +0000 Subject: [Koha-bugs] [Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:09:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:09:58 +0000 Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:10:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:10:00 +0000 Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37408|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 37441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37441&action=edit Bug 8246: Allow deleting record if no more items The "Delete records if no items remain" was only available if the batch did not contain "too many" items (see MaxItemsForBatch). This limitation does not make any sense. Test plan: 1/ Set MaxItemsForBatch=10 2/ Use the batch item deletion to delete 10+ items 3/ Confirm the checkbox "Delete records if no items remain" is displayed 4/ Check it 5/ Launch the job 6/ Run koha qa test tools Verify that the records without items have been deleted also. NOTE: My test db only had two biblios with items, so I set MaxItemsForBatch=1. Before patch, checkbox did not display. After patch, checkbox did display. This patch merely moves one line out of the IF/ELSE/END block, and reindents for more readability. Though, there is a missing

if you want to get picky. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:12:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:12:14 +0000 Subject: [Koha-bugs] [Bug 13946] New: Change order status 'Pending' to ordered like in database Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13946 Bug ID: 13946 Summary: Change order status 'Pending' to ordered like in database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The order status seen in the pull down list on the advanced acquisition search lists: - new - pending - partially received - ... I suggest changing 'pending' to 'ordered' as this is a bit more clear and also matches the status as it is stored in the database. Additional bonus for translation: no clash with the pending status for suggestions, that has a different meaning (= waiting to be processed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:15:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:15:32 +0000 Subject: [Koha-bugs] [Bug 13944] Fund sorting is inconsistent across different parts of Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13944 --- Comment #2 from Kyle M Hall --- Since acqui-home.l has sorting, we can make the default sort by fund name, and since aqbudgets.pl has no sorting at all, we can sort it by fund name. How does that sound? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:19:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:19:56 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:34:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:34:11 +0000 Subject: [Koha-bugs] [Bug 13929] opac description not showing on search results for authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13929 --- Comment #1 from Nicole C. Engard --- This is the same for 'not for loan'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:37:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:37:53 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #6 from Nicolas Legrand --- also, I was wrong, it seems commit a303cdec4871d3d3740d419c972eea7faf8e5a8a does also break everything -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:51:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:51:39 +0000 Subject: [Koha-bugs] [Bug 10708] make fine receipt customizable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #3 from bondiurbano --- This would be a great enhancement, broadly claimed by customers... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:53:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:53:43 +0000 Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:53:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:53:46 +0000 Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37126|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 37442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37442&action=edit Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally Existing framework code is currently not retained when local record gets replaced during batch import, or when the restore/reverse function is being used. This patch fixes aforementioned issues by correcting outdated GetBiblio() calls in C4/ImportBatch.pm To test: 1/ try to replicate the issue: import some MARC records with "Tools -> Stage MARC records for import" etc., using test setup, matching rules and so on such that some existing records will get replaced with imported ones 2/ observe that records replaced during import now open in the editor with 'Default' framework, even if they have some other framework set up previously 3/ apply patch 4/ redo 1/, confirming that this problem is no longer replicable 5/ try use 'restore' function with some freshly imported records, ensure that original framework code got retained in the records which had their imports reverted NOTE: I confirmed this change by 1) git grep "=\s*GetBiblio\s*(" -- this shows how GetBiblio is called elsewhere. It differed! So then... 2) vi C4/Biblio.pm /sub GetBiblio -- find the right one, notice it only returns a HASH ref, not an array. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 16:55:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 14:55:56 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #2 from Colin Campbell --- There are a number of bugs meaning that Koha does not implement no_block handling although some of the ILS routines appear to handle it. The formats parsing fixed fields are incorrect for single character flags such as no_block In the template they are defined as C which does not return a single character string but the integer value of that octet so where the code tests if ($no_block eq 'Y') that always fails because no_block == 89 If you fix the above issuing a non_block checkout calls a method checkout_no_block unfortunately no such method is present and the SIPServer instance crashes Will try fixing these and testing if we can then get the correct behaviour -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:00:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:00:19 +0000 Subject: [Koha-bugs] [Bug 13947] New: serials/subscription-history.pl calls GetBiblio incorrectly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Bug ID: 13947 Summary: serials/subscription-history.pl calls GetBiblio incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com While looking at bug 10906, I noticed that this bug existed as well, but it was not reported. Look at C4/Biblio.pm and find the GetBiblio function. It is obvious that it only returns undef or a HASH reference. However, serials/subscription-history.pl calls it expecting ($count, $biblio), which is wrong. 1) confirm the problem: $ git grep "=\s*GetBiblio\s*(" | grep subscription-history 2) apply the patch 3) confirm the fix: $ git grep "=\s*GetBiblio\s*(" | grep subscription-history -- The return value should be just a single parameter as expected. 4) run koha-qa test tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:02:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:02:07 +0000 Subject: [Koha-bugs] [Bug 13948] New: Add ability to dump template toolkit variables to html comment Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Bug ID: 13948 Summary: Add ability to dump template toolkit variables to html comment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be incredibly helpful if we could easily enable Koha to dump all Template Toolkit variables to a comment for debugging purposes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:16:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:16:07 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:22:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:22:52 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:22:55 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 --- Comment #1 from M. Tompsett --- Created attachment 37443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37443&action=edit Bug 13947: Correct call to GetBiblio to receive correct return value When you attempt to edit the manual history for a subscription, the title is blank. This is a result of an incorrect use of the GetBiblio function. TEST PLAN --------- 1) Log in to staff client 2) Serials 3) Search for an existing serial with manual history checked. -- creating one as needed is left as an exercise to the reader. 4) Click on the title of the serial for the details page. 5) Go to the Planning tab and click 'Edit History' -- Heading will be 'Subscription history for' without a title. 6) Apply patch 7) Refresh page. -- Heading will include the title correctly. 8) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:24:26 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10906 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:24:26 +0000 Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13947 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:34:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:34:01 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:34:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:34:03 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #1 from Kyle M Hall --- Created attachment 37444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37444&action=edit Bug 13948 - Add ability to dump template toolkit variables to html comment It would be incredibly helpful if we could easily enable Koha to dump all Template Toolkit variables to a comment for debugging purposes. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preferences DumpTemplateVarsIntranet and DumpTemplateVarsOpac 4) Load a page in the staff intranet, view the html source 5) Note the template toolkit variables are embedded in an html comment 6) Load a page in the opac, view the html source 7) Note the template toolkit variable are embedded in an html comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:35:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:35:34 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37444|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 37445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37445&action=edit Bug 13948 - Add ability to dump template toolkit variables to html comment It would be incredibly helpful if we could easily enable Koha to dump all Template Toolkit variables to a comment for debugging purposes. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preferences DumpTemplateVarsIntranet and DumpTemplateVarsOpac 4) Load a page in the staff intranet, view the html source 5) Note the template toolkit variables are embedded in an html comment 6) Load a page in the opac, view the html source 7) Note the template toolkit variable are embedded in an html comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 17:36:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 15:36:35 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #3 from Colin Campbell --- Created attachment 37446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37446&action=edit patch incorrect formats An initial patch correct the formats. But beware we dont want to deploy this until the affected handlers have been corrected, this bug has in effect been hiding a bigger one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 18:05:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 16:05:59 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37443|0 |1 is obsolete| | --- Comment #2 from Jacek Ablewicz --- Created attachment 37447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37447&action=edit Bug 13947: Correct call to GetBiblio to receive correct return value When you attempt to edit the manual history for a subscription, the title is blank. This is a result of an incorrect use of the GetBiblio function. TEST PLAN --------- 1) Log in to staff client 2) Serials 3) Search for an existing serial with manual history checked. -- creating one as needed is left as an exercise to the reader. 4) Click on the title of the serial for the details page. 5) Go to the Planning tab and click 'Edit History' -- Heading will be 'Subscription history for' without a title. 6) Apply patch 7) Refresh page. -- Heading will include the title correctly. 8) run koha qa test tools Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 18:05:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 16:05:57 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 18:06:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 16:06:44 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 18:08:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 16:08:11 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 18:54:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 16:54:58 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37227|0 |1 is obsolete| | --- Comment #53 from Marc V?ron --- Comment on attachment 37227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37227 Bug 13813 - Remove C4::Dates from reserve/request.pl Obsoleted because of merge conflicts. Will add new patch later. /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 19:00:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 17:00:41 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 19:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 17:00:43 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37073|0 |1 is obsolete| | --- Comment #30 from Winona Salesky --- Created attachment 37448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37448&action=edit Bug 13382 - RDA: 700/710/711 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span class=separator |. Adds Related and Contained Works as new headings. 7) Repeat steps 4 - 6 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 19:03:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 17:03:03 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #31 from Winona Salesky --- Thanks Nick for catching all of those. This patch should address the following issues: 1 - For related or contained works subfields n & p are not displaying 2 - 710/711 with subfield i appear in Contributors and not Related Works 3 - 710/711 with subfield i and 2nd indicator 2 do not appear -Winona (In reply to Winona Salesky from comment #30) > Created attachment 37448 [details] [review] > Bug 13382 - RDA: 700/710/711 display in XSLT > > Test Plan: > 1) Apply this patch > 2) Ensure you are using the default XSLT setting for the staff and opac > search results and record details > 3) Find or create a record with MARC tags 700,710,711 > 4) Perform an opac search that would show the record in the search results. > 5) Click title to review record. > 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, > g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by > span class=separator |. Adds Related and Contained Works as new headings. > 7) Repeat steps 4 - 6 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 19:31:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 17:31:20 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Great idea! However, with patch I get in staff client: Software error: Template process failed: plugin error - Stash: plugin not found at /usr/share/kohaclone/C4/Templates.pm line 121. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 20:08:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 18:08:35 +0000 Subject: [Koha-bugs] [Bug 13949] New: Item search should have holding library Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949 Bug ID: 13949 Summary: Item search should have holding library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Right now when you do an item search in the staff client you can only search for home library, we should have the option to search holding library too. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 20:13:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 18:13:41 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 --- Comment #4 from Marc V?ron --- Found: Template::Plugin::Stash (1.006) Not Installed However: If somebody enables the system preference DumpTemplateVarsIntranet without first checking the Perl modules on the About page, he is locked out and can not set back the preference, beause the template process fails on every page. Maybe this should be handled more gracefully, e.g. by checking if the perl module is installed before using it. Best way would be to write a warning as HTML comment instead of the template variables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 20:18:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 18:18:49 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #1 from Gaetan Boisson --- This is actually not a feature difference, but i just noticed that results display is much slower (twice as slow it seems) when going through xslt. Which is probably not a surprise, but maybe a good thing to mention here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 22:14:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 20:14:22 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 22:19:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 20:19:42 +0000 Subject: [Koha-bugs] [Bug 5002] No error message if category code already exists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5002 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #15 from Chris Cormack --- Does not apply on 3.18.x, please rebase if you think it is nessecary -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 22:21:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 20:21:55 +0000 Subject: [Koha-bugs] [Bug 3969] Budget Search Doesn't Work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3969 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #26 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 22:23:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 20:23:56 +0000 Subject: [Koha-bugs] [Bug 5844] Unhilight cuts off some strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5844 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 2 22:48:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 20:48:14 +0000 Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff client cart has been deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 00:27:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 22:27:43 +0000 Subject: [Koha-bugs] [Bug 13929] opac description not showing on search results for authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13929 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Nicole, I think there is no way to tell the "right" description from the authorised values as the value that displays in the result list is a summary - it's a group description for the number of items in the various lost or not for loan status on the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 00:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 22:31:38 +0000 Subject: [Koha-bugs] [Bug 13929] opac description not showing on search results for authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13929 --- Comment #3 from Katrin Fischer --- Hm, I think I misunderstood (it's terribly late...) - you meant the admin area? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 00:40:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Apr 2015 22:40:26 +0000 Subject: [Koha-bugs] [Bug 13809] The Notices tab on staff client disappeared In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13809 --- Comment #2 from Jurgens Breytenbach --- Yup, that was exactly the fix. Thanks. I must've inadvertently changed this setting. (In reply to Josef Moravec from comment #1) > Do you have the system preference EnhancedMessagingPreferences allowed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 02:34:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 00:34:09 +0000 Subject: [Koha-bugs] [Bug 13929] opac description not showing on search results for authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13929 --- Comment #4 from Nicole C. Engard --- No, I mean the OPAC search results - it says lost instead of 'missing' if that's the description. But then when you click the title you'll see missing instead of lost in the holdings table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 03:52:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 01:52:14 +0000 Subject: [Koha-bugs] [Bug 13949] Item search should have holding library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 03:53:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 01:53:14 +0000 Subject: [Koha-bugs] [Bug 13949] Item search should have holding library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949 --- Comment #1 from Heather Braum --- I was about to look for this very bug report during my testing in 3.18. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 04:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 02:00:43 +0000 Subject: [Koha-bugs] [Bug 13950] New: Item search home library list needs to be alphabetized Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13950 Bug ID: 13950 Summary: Item search home library list needs to be alphabetized Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org The home library option in the new item search feature needs to be alphabetized. Our system displays the options: All Libraries Leavenworth... Carbondale... Prairie Hills Schools -- Sabetha... Lyndon... and so on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 05:33:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 03:33:01 +0000 Subject: [Koha-bugs] [Bug 12291] Replace the acronym HTML tag with abbr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 05:37:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 03:37:58 +0000 Subject: [Koha-bugs] [Bug 13740] Timeout on deleting patrons if too many patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13740 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 05:46:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 03:46:39 +0000 Subject: [Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #24 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 08:29:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 06:29:27 +0000 Subject: [Koha-bugs] [Bug 13809] The Notices tab on staff client disappeared In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13809 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 08:51:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 06:51:25 +0000 Subject: [Koha-bugs] [Bug 13951] New: patron card problem: When i choose the "Download as PDF" I always get an empty fields and iam getting patron image , barcode correctly in PDF FILE. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13951 Bug ID: 13951 Summary: patron card problem: When i choose the "Download as PDF" I always get an empty fields and iam getting patron image , barcode correctly in PDF FILE. Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: sai4746 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 37449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37449&action=edit patron card pdf patron card problem: When i choose the "Download as PDF" I always get an empty fields and iam getting patron image , barcode correctly in PDF FILE. this is the error iam getting "my" variable $template masks earlier declaration in same scope at /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl line 66., referer: http://library.defindia.org:8080/cgi-bin/koha/patroncards/print.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 08:55:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 06:55:17 +0000 Subject: [Koha-bugs] [Bug 13951] patron card problem: When i choose the "Download as PDF" I always get an empty fields and iam getting patron image , barcode correctly in PDF FILE. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13951 sai changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37449|0 |1 is obsolete| | --- Comment #1 from sai --- Created attachment 37450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37450&action=edit patron card pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 09:16:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 07:16:44 +0000 Subject: [Koha-bugs] [Bug 13949] Item search should have holding library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I think you can configure it to show up additionally, but it won't offer the branches list then - you'd have to search with the branchcode (administration > items search fields) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 09:27:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 07:27:03 +0000 Subject: [Koha-bugs] [Bug 13929] opac description not showing on search results for authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13929 --- Comment #5 from Katrin Fischer --- What I meant is that you have a record with lots of items and about five different status of 'not for loan' between them, it will say 5 'for reference' in the result list - because it's a count of all of them, independent of the individual description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 09:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 07:30:43 +0000 Subject: [Koha-bugs] [Bug 13952] New: Import and export of authority types Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Bug ID: 13952 Summary: Import and export of authority types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We need the function to export and import authority types. It should work the way like import/export of biblio marc frameworks works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 09:55:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 07:55:08 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 14:16:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 12:16:49 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 --- Comment #8 from Kyle M Hall --- Created attachment 37451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37451&action=edit Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated The description of the BakerTaylorBookstoreURL syspref says "Baker and Taylor "My Library Bookstore" links should be accessed at https:// isbn (this should be filled in with something like ocls.mylibrarybookstore.com/MLB/actions/searchHandler.do?nextPage=bookDetails&parentNum=10923&key=). Leave it blank to disable these links." Leaving this syspref blank does not disable the links. Instead, they are populated without the bookstore URL: the cover image for ISBN 1575725738 will cause koha to make a request to http://1575725738, which will, of course, time out. Leaving BakerTaylorBookstoreURL blank should disable any URL that depends on this syspref, as stated in the syspref description. Test Plan: 1) Apply this patch 2) Enable Baker & Taylor cover images, but *not* BakerTaylorBookstoreURL 3) Perform an OPAC search where you have B&T cover images in the results 4) Note the image links now direct you to the record details -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 14:16:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 12:16:47 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 14:26:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 12:26:55 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 14:26:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 12:26:57 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37427|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 37452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37452&action=edit [PASSED QA] Bug 13934: C4::ItemType->get should return undef if no parameter given The issue: If you try to check in an item with a non existent barcode, the application will exploded with a software error: "Can't bless non-reference at .../ItemType.pm Line 64". It's caused by: commit 7431f8cfe29e330e2232b0df591afc4d923b0a52 Bug 11944: Fix encoding issue in C4::ItemType and the following change: @@ -105,9 +104,6 @@ sub get { my $data = $dbh->selectrow_hashref( "SELECT * FROM itemtypes WHERE itemtype = ?", undef, $itemtype ); - if ( $data->{description} ) { - $data->{description} = Encode::encode('UTF-8', $data->{description}); - } because of the following: my $s; $s->{foo} = "bar" if $s->{foo}; use Data::Dumper;warn Dumper $s; => {} # not undef So later, bless $opts => $class; will fail because $opts is undef and was not (i.e. {}) before. More explicit test plan: 1) Log in to staff client 2) Circulation -> Check in 3) Type a non-existent barcode into 'Enter item barcode:' textbox 4) Click 'Submit' -- Should receive nasty error. 5) apply patch 6) repeat steps 2-4 -- Should be told 'No item with barcode: {what you typed}' 7) prove -v t/ItemType.t -- All tests should run successfully. 7) run koha qa test tools Note: Having tried to create and use an itemtype '0', this only demonstrates a lack of validation on the itemtype creation screen. Unable to use it without tweaking back end. That is beyond the scope of this bug. Note for QA: C4::ItemType->get is only uses in circ/return.pl. So even if the behavior is changed, it should not introduce any regression somewhere else. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 14:37:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 12:37:33 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 14:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 12:37:35 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37425|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 37453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37453&action=edit [PASSED QA] Bug 8050: Die if package building fails The debian/build-git-snapshot script should not return success if an error occurred. Note that sys_command_output won't raise an error if something fails. Signed-off-by: Robin Sheat Made a minor change to print the command, add a newline. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 14:39:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 12:39:40 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 14:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 12:39:42 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37438|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 37454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37454&action=edit [PASSED QA] Bug 13940 : Testing C4::OAI::Sets Testing C4::OAI::Sets in t/db_dependent/OAI/Sets.t Adding &DelOAISetsBiblio in @EXPORT at the beginning of OAI/Sets.pm, it was the only one missing TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/OAI/Sets.t -- All 145 tests should run successfully without any error or warning 3. Run koha qa test tools -- No issues found. Additionally, I comfirmed why DelOAISetsBiblio was added in the list of exported functions. $ grep "^sub " C4/OAI/Sets.pm | sort > check1 $ for i in `grep "\&[A-Z]" C4/OAI/Sets.pm | xargs `; do echo $i; done | sort > check2 Of course the outputs have a little extra around them, so $ vi check1 $ vi check2 $ diff check1 check2 Lo and behold, it was that one function. Necessary for 100% coverage. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 15:09:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 13:09:39 +0000 Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 15:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 13:09:41 +0000 Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37441|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 37455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37455&action=edit [PASSED QA] Bug 8246: Allow deleting record if no more items The "Delete records if no items remain" was only available if the batch did not contain "too many" items (see MaxItemsForBatch). This limitation does not make any sense. Test plan: 1/ Set MaxItemsForBatch=10 2/ Use the batch item deletion to delete 10+ items 3/ Confirm the checkbox "Delete records if no items remain" is displayed 4/ Check it 5/ Launch the job 6/ Run koha qa test tools Verify that the records without items have been deleted also. NOTE: My test db only had two biblios with items, so I set MaxItemsForBatch=1. Before patch, checkbox did not display. After patch, checkbox did display. This patch merely moves one line out of the IF/ELSE/END block, and reindents for more readability. Though, there is a missing

if you want to get picky. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 15:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 13:24:10 +0000 Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 15:24:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 13:24:17 +0000 Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37442|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 37456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37456&action=edit [PASSED QA] Bug 10906 - Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally Existing framework code is currently not retained when local record gets replaced during batch import, or when the restore/reverse function is being used. This patch fixes aforementioned issues by correcting outdated GetBiblio() calls in C4/ImportBatch.pm To test: 1/ try to replicate the issue: import some MARC records with "Tools -> Stage MARC records for import" etc., using test setup, matching rules and so on such that some existing records will get replaced with imported ones 2/ observe that records replaced during import now open in the editor with 'Default' framework, even if they have some other framework set up previously 3/ apply patch 4/ redo 1/, confirming that this problem is no longer replicable 5/ try use 'restore' function with some freshly imported records, ensure that original framework code got retained in the records which had their imports reverted NOTE: I confirmed this change by 1) git grep "=\s*GetBiblio\s*(" -- this shows how GetBiblio is called elsewhere. It differed! So then... 2) vi C4/Biblio.pm /sub GetBiblio -- find the right one, notice it only returns a HASH ref, not an array. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 15:46:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 13:46:29 +0000 Subject: [Koha-bugs] [Bug 13953] New: Bad QueryParser YAML config + old version of YAML::XS can cause segfault Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13953 Bug ID: 13953 Summary: Bad QueryParser YAML config + old version of YAML::XS can cause segfault Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org A system that happens to have an old version of YAML::XS that does not have the fix for CVE-2014-9130 (https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2014-9130) can be subject to having processes that invoke a catalog search segfault if the following conditions are met: - QueryParser is enabled - etc/searchengine/queryparser.yaml is malformed in such a way as to trigger the assert that's the subject of the CVE - YAML::XS is installed on the system and is either older than version 0.53 or didn't get the fix backpatched by the distro The following mitigations are available: - first, fix queryparser.yaml - install a more recent version of YAML::XS - *remove* YAML::XS, in which case YAML::Any will switch to using YAML::Syck This bug is filed for informational purposes; since changes to queryparser.yaml have to be done on the filesystem, and since as near as I can tell, other uses of YAML are parsed using YAML::Syck or the pure-perl YAML module, I don't see there being a remote exploit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 16:07:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 14:07:27 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 16:07:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 14:07:38 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37407|0 |1 is obsolete| | Attachment #37418|0 |1 is obsolete| | --- Comment #84 from Kyle M Hall --- Created attachment 37457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37457&action=edit [PASSED QA] Bug 8236 Renewing policy in overdue or restriction case This patch introduces 2 sysprefs : RestrictionBlockRenewing to allow/block renewal of items when patron is restricted. OverduesBlockRenewing to allow, block only the late ones or block all checked out items Default is "allow" in both case. Signed-off-by: Matthias Meusburger Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 16:22:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 14:22:17 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #85 from Kyle M Hall --- Created attachment 37458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37458&action=edit [PASSED QA] Bug 8236: Tests for Renewing policy in overdue or restriction case - Add tests in t/db_dependent/Circulation.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 16:22:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 14:22:29 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #86 from Kyle M Hall --- Created attachment 37459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37459&action=edit Bug 8236 [QA Followup] - Tweak language, fix whitespace error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 16:39:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 14:39:22 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #3 from Kyle M Hall --- I received the following when I ran the unit tests with an installation using the sample data: prove -v t/db_dependent/Accounts.t t/db_dependent/Accounts.t .. 1..15 ok 1 - use C4::Accounts; ok 2 - use Koha::Object; ok 3 - use Koha::Borrower; ok 4 - use Data::Dumper; ok 5 - C4::Accounts->can(...) DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_kohaqa`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/Accounts.t line 53. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_kohaqa`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/Accounts.t line 53. # Looks like you planned 15 tests but ran 5. # Looks like your test exited with 255 just after 5. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 10/15 subtests Test Summary Report ------------------- t/db_dependent/Accounts.t (Wstat: 65280 Tests: 5 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 15 tests but ran 5. Files=1, Tests=5, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.46 cusr 0.04 csys = 0.52 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 18:54:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 16:54:00 +0000 Subject: [Koha-bugs] [Bug 9530] Allow separate 'Reply To' and 'From' email address for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530 --- Comment #43 from M. Tompsett --- Comment on attachment 31929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31929 [PASSED QA] Bug 9530: Making changes to C4::Letters Review of attachment 31929: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9530&attachment=31929) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +286,5 @@ > + my $message = Koha::Email->new(); > + my %mail = $message->create_message_headers( > + { > + to => $email, > + from => $branchdetails->{'branchemail'}, Was there a reason the || C4::Context->preference("KohaAdminEmailAddress") portion was removed? I'm trying to rescue bug 8000. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:07:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:07:51 +0000 Subject: [Koha-bugs] [Bug 13896] PID is created in /tmp/ instead of in /var/run/koha/... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37434|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 37460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37460&action=edit [PASSED QA] Bug 13896: Fix pid file creation, use proper directory instead of /tmp/ daemon uses by default /tmp/ for pid files, if they are unspecified. Pass the right directory to daemon, so it knows where to put the pid file. Signed-off-by: Attila Kinali TEST PLAN --------- 1) Roll a distribution and confirm it works. OR 1) Hack all the /var directories to point to git directories 2) Add a dummy user for the instance name 3) sudo the script with the faked instance name. -- the daemon should be running and the pid file should be in the expected directory. The first way is the proper way to test, I did the latter. :) Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:07:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:07:49 +0000 Subject: [Koha-bugs] [Bug 13896] PID is created in /tmp/ instead of in /var/run/koha/... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:13:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:13:45 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #36777|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:14:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:14:22 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:16:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:16:10 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36777|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:21:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:21:07 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:21:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:21:14 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:24:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:24:02 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Kyle M Hall --- The only non-obsoleted patch no long makes the strings in serials-recieve.tt translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:27:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:27:25 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:27:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:27:27 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37447|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 37461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37461&action=edit [PASSED QA] Bug 13947: Correct call to GetBiblio to receive correct return value When you attempt to edit the manual history for a subscription, the title is blank. This is a result of an incorrect use of the GetBiblio function. TEST PLAN --------- 1) Log in to staff client 2) Serials 3) Search for an existing serial with manual history checked. -- creating one as needed is left as an exercise to the reader. 4) Click on the title of the serial for the details page. 5) Go to the Planning tab and click 'Edit History' -- Heading will be 'Subscription history for' without a title. 6) Apply patch 7) Refresh page. -- Heading will include the title correctly. 8) run koha qa test tools Signed-off-by: Jacek Ablewicz Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:29:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:29:12 +0000 Subject: [Koha-bugs] [Bug 13939] ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13939 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:29:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:29:14 +0000 Subject: [Koha-bugs] [Bug 13939] ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13939 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37432|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 37462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37462&action=edit [PASSED QA] Bug 13939: ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron Test plan: 1) Enable ILS DI (system preference 'ILS-DI') 2) Try to access the URL http:///cgi-bin/koha/ilsdi.pl?service=GetServices&patron_id=&item_id= Choose the patron and item to be available for hold You'll see an error instead of valid XML response 3) apply the patch 4) try to access the same URL, you should see valid XML response with services "title level hold" and eventually "item level hold" returned Signed-off-by: Thomas Misilo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:33:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:33:51 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25924|0 |1 is obsolete| | --- Comment #37 from M. Tompsett --- Created attachment 37463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37463&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:33:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:33:57 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25925|0 |1 is obsolete| | --- Comment #38 from M. Tompsett --- Created attachment 37464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37464&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:34:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:34:05 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25926|0 |1 is obsolete| | --- Comment #39 from M. Tompsett --- Created attachment 37465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37465&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:34:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:34:11 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25928|0 |1 is obsolete| | --- Comment #40 from M. Tompsett --- Created attachment 37466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37466&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:34:16 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25939|0 |1 is obsolete| | --- Comment #41 from M. Tompsett --- Created attachment 37467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37467&action=edit Bug 8000 [QA Followup] - Change mis-used qw to q -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:34:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:34:23 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25951|0 |1 is obsolete| | --- Comment #42 from M. Tompsett --- Created attachment 37468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37468&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:34:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:34:28 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26446|0 |1 is obsolete| | --- Comment #43 from M. Tompsett --- Created attachment 37469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37469&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:38:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:38:34 +0000 Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:41:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:41:21 +0000 Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37366|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 37470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37470&action=edit [PASSED QA] Bug 13882 : Adding new unit tests in t/Borrower.t This adds testing for all the 'borrower' database fields. TEST PLAN --------- 1) apply patch 2) prove -v t/Borrowers.t -- All 67 subtests for both the setter and accessor should run successfully. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:41:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:41:19 +0000 Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:41:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:41:28 +0000 Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 --- Comment #6 from Kyle M Hall --- Created attachment 37471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37471&action=edit Bug 13882 - Tidy t/Borrower.t to fix whitespace errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:44:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:44:07 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37463|0 |1 is obsolete| | --- Comment #44 from M. Tompsett --- Created attachment 37472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37472&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:44:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:44:12 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37464|0 |1 is obsolete| | --- Comment #45 from M. Tompsett --- Created attachment 37473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37473&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:44:16 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37465|0 |1 is obsolete| | --- Comment #46 from M. Tompsett --- Created attachment 37474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37474&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:44:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:44:21 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37466|0 |1 is obsolete| | --- Comment #47 from M. Tompsett --- Created attachment 37475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37475&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:44:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:44:25 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37467|0 |1 is obsolete| | --- Comment #48 from M. Tompsett --- Created attachment 37476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37476&action=edit Bug 8000 [QA Followup] - Change mis-used qw to q -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:44:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:44:31 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37468|0 |1 is obsolete| | --- Comment #49 from M. Tompsett --- Created attachment 37477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37477&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:44:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:44:39 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37469|0 |1 is obsolete| | --- Comment #50 from M. Tompsett --- Created attachment 37478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37478&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:45:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:45:52 +0000 Subject: [Koha-bugs] [Bug 13069] Enable sort by title to ignore articles on circulation and patron detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:45:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:45:54 +0000 Subject: [Koha-bugs] [Bug 13069] Enable sort by title to ignore articles on circulation and patron detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37395|0 |1 is obsolete| | Attachment #37396|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 37479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37479&action=edit [PASSED QA] Bug 13069 - Enable sort by title to ignore articles on circulation and patron detail pages With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. This patch corrects the problem by adding the "anti-the" configuration to the relevant column in the DataTables initializtion script. To test, apply the patch and clear your cache if necessary. Check out to a patron who has multiple checkouts, some of which have titles beginning with "a," "an," and "the." Sorting those checkouts by title should ignore articles. Test the patron detail page for that patron as well. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart NOTE: This is the one early in the javascript file. This is the one visible by having multiple checkouts where the title excluding the articles is a different order than titles including the articles. Patrons -> Details (scroll down to check out area, view checkouts and toggle the title sort) Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:45:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:45:59 +0000 Subject: [Koha-bugs] [Bug 13069] Enable sort by title to ignore articles on circulation and patron detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 --- Comment #10 from Kyle M Hall --- Created attachment 37480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37480&action=edit [PASSED QA] Bug 13069 - (follow-up) Enable sort by title to ignore articles This should affect the relatives' checkouts table too. Signed-off-by: Jonathan Druart NOTE: This is the one later in the javascript file. Checkout tab on the patron details page. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:48:06 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37472|0 |1 is obsolete| | --- Comment #51 from M. Tompsett --- Created attachment 37481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37481&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:48:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:48:12 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37473|0 |1 is obsolete| | --- Comment #52 from M. Tompsett --- Created attachment 37482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37482&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:48:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:48:17 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37474|0 |1 is obsolete| | --- Comment #53 from M. Tompsett --- Created attachment 37483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37483&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:48:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:48:22 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37475|0 |1 is obsolete| | --- Comment #54 from M. Tompsett --- Created attachment 37484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37484&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:48:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:48:28 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37476|0 |1 is obsolete| | --- Comment #55 from M. Tompsett --- Created attachment 37485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37485&action=edit Bug 8000 [QA Followup] - Change mis-used qw to q -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:48:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:48:32 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37477|0 |1 is obsolete| | --- Comment #56 from M. Tompsett --- Created attachment 37486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37486&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:48:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:48:37 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37478|0 |1 is obsolete| | --- Comment #57 from M. Tompsett --- Created attachment 37487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37487&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:58:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:58:14 +0000 Subject: [Koha-bugs] [Bug 13800] Diacritics not mapped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37387|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Created attachment 37488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37488&action=edit Bug 13800 - Diacritics not mapped -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 19:58:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 17:58:21 +0000 Subject: [Koha-bugs] [Bug 13800] Diacritics not mapped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 20:08:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 18:08:25 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #58 from M. Tompsett --- The FailedQA is more likely to get someone to fix this. I believe I have corrected the existing patches to apply to master. The issue now is that the email validations done in the very first patch were not updated when the validation of emails was added. They still have the =~ /@/ type code in them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 20:26:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 18:26:40 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Summary|add print receipt option to |remove unused sco/receipt |Koha self-check |template file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 20:27:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 18:27:29 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 20:27:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 18:27:32 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22301|0 |1 is obsolete| | Attachment #22302|0 |1 is obsolete| | --- Comment #68 from M. Tompsett --- Created attachment 37489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37489&action=edit Bug 8033 - Remove unused template file. Bugs 11349 and 12062 implements part 1 and 2 of the 3 things listed before. This patch removes the unused receipt.tt file. TEST PLAN --------- 1) Confirm the file isn't used. $ git grep "sco/receipt" | grep -v "\.po:" -- this should list nothing, because there are still po files referencing it, but they aren't needed either. 2) ls Reimplementation of Kyle's follow-up, minus the addition of " References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37489|0 |1 is obsolete| | --- Comment #69 from M. Tompsett --- Created attachment 37490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37490&action=edit Bug 8033 - Remove unused template file. All prog related patches were obsoleted from this bug. Bug 11349 changed the code to have the proper template name used (sco/printslip.tt instead of sco/printsplit.tmpl). Bug 12062 moved the hard coded string logic into the template, and passed the borrower number. This only leaves the patch to remove the unused receipt.tt file. TEST PLAN --------- 1) Confirm the file isn't used. $ git grep "sco/receipt" | grep -v "\.po:" -- this should list nothing, because there are still po files referencing it, but they aren't needed either. 2) ls ./koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt -- there should be a file 3) apply patch 4) repeat step 2 -- the file should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 20:46:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 18:46:34 +0000 Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726 --- Comment #12 from M. Tompsett --- Comment on attachment 20709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20709 Bug 10726: UNIMARC charts corresponding to 6th french edition of the bibliographic manual and 3rd english edition of authorities manual Review of attachment 20709: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10726&attachment=20709) ----------------------------------------------------------------- I was going to attempt to rescue and look at this, but there are likely other issues that need to be looked at first. ::: installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql @@ +1468,4 @@ > ('503', 'k', 'num?rotation (chiffres arabes)', '', 0, 0, '', 5, '', '', '', 0, 0, '', NULL, '', ''), > ('503', 'l', 'num?rotation (chiffres romains)', '', 0, 0, '', 5, '', '', '', 0, 0, '', NULL, '', ''), > ('503', 'm', 'localisation', '', 0, 0, '', 5, '', '', '', 0, 0, '', NULL, '', ''), > +('503', 'n', '?tablissement pr?sidant la localisation', , 0, 0, '', 5, '', '', '', 0, 0, '', NULL, '', ''), Was there an accidental deletion of '' after the text? @@ +1629,4 @@ > ('616', 'f', 'dates', '', 1, 0, '', 6, '', '', '', 0, 0, '', NULL, '', ''), > ('616', 'j', 'subdivision de forme', '', 0, 0, '', 6, '', '', '', 0, 0, '', NULL, '', ''), > ('616', 'x', 'subdivision de la cat?gorie sujet sous forme textuelle', '', 0, 0, '', 6, '', '', '', 0, 0, '', NULL, '', ''), > +('616', 'y', 'subdivision g?ographique', ', 0, 0, '', 6, '', '', '', 0, 0, '', NULL, '', ''), A single '?! Typo, right? ::: installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/framework_DEFAULT.sql @@ +3224,4 @@ > INSERT INTO `marc_subfield_structure` (`tagfield`, `tagsubfield`, `liblibrarian`, `libopac`, `repeatable`, `mandatory`, `kohafield`, `tab`, `authorised_value`, `authtypecode`, `value_builder`, `isurl`, `hidden`, `frameworkcode`, `seealso`, `link`, `defaultvalue`) VALUES ('600', '2', 'code du syst?me d''indexation', '', 0, 0, '', -1, '', '', '', NULL, 0, 'ARTI', '', NULL, NULL); > INSERT INTO `marc_subfield_structure` (`tagfield`, `tagsubfield`, `liblibrarian`, `libopac`, `repeatable`, `mandatory`, `kohafield`, `tab`, `authorised_value`, `authtypecode`, `value_builder`, `isurl`, `hidden`, `frameworkcode`, `seealso`, `link`, `defaultvalue`) VALUES ('600', '3', 'num?ro de la notice d''autorit?', '', 0, 0, '', 2, '', '', '', NULL, -1, 'ARTI', '', NULL, NULL); > INSERT INTO `marc_subfield_structure` (`tagfield`, `tagsubfield`, `liblibrarian`, `libopac`, `repeatable`, `mandatory`, `kohafield`, `tab`, `authorised_value`, `authtypecode`, `value_builder`, `isurl`, `hidden`, `frameworkcode`, `seealso`, `link`, `defaultvalue`) VALUES ('600', '9', 'koha internal code', '', 0, 0, '', 2, '', '', '', NULL, -1, 'ARTI', '', NULL, NULL); > +INSERT INTO `marc_subfield_structure` (`tagfield`, `tagsubfield`, `liblibrarian`, `libopac`, `repeatable`, `mandatory`, `kohafield`, `tab`, `authorised_value`, `authtypecode`, `value_builder`, `isurl`, `hidden`, `frameworkcode`, `seealso`, `link`, `defaultvalue`) VALUES ('600', 'a', 'nom', 'sujet', 0, 0, '', 2, '', 'SAUT', '', NULL, 0,'ARTI','''600b'',''600c'',''600d'',''600f'',''600x'',''600y'',''600z''', NULL, NULL); I think there are some quote issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 21:14:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 19:14:28 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #108 from Blou --- Created attachment 37491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37491&action=edit Bug 8753 - Add forgot password link to OPAC This redo includes the following - usage of the template letters for the email instead of a .tt (that feature didn't exist when the functionnality was initially coded for our client) - removal of the prog version - removal of the code that was initially put into Members.pm - Added a letter into updatedatabase.pl and sample_notices.sql - Of course, rebase to latest master. The rest remain unchanged since the previous comments/approvals. As such, what worked before should still work. TEST PLAN: 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. That will cause the link 'Forgot yo 2b) make sure that OpacPasswordChange is also ON. 3) refresh front page, click on 'Forgot your password' and enter a VALID address (one that is associated to an en 3b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 4) An email should be received at that address with a link. 5) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 6) Go to main page try the new password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 21:15:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 19:15:07 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com Attachment #37491|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 21:15:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 19:15:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36819|0 |1 is obsolete| | --- Comment #79 from Blou --- Created attachment 37492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37492&action=edit Bug 8753 - Add forgot password link to OPAC This redo includes the following - usage of the template letters for the email instead of a .tt (that feature didn't exist when the functionnality was initially coded for our client) - removal of the prog version - removal of the code that was initially put into Members.pm - Added a letter into updatedatabase.pl and sample_notices.sql - Of course, rebase to latest master. The rest remain unchanged since the previous comments/approvals. As such, what worked before should still work. TEST PLAN: 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. That will cause the link 'Forgot yo 2b) make sure that OpacPasswordChange is also ON. 3) refresh front page, click on 'Forgot your password' and enter a VALID address (one that is associated to an en 3b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 4) An email should be received at that address with a link. 5) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 6) Go to main page try the new password. http://bugs.koha-community.org/show_bug.cgi?id=13068 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 21:17:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 19:17:06 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #109 from Blou --- Sorry about that, wrong bug. I wish I could just completely remove my previous comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 22:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 20:33:13 +0000 Subject: [Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 22:53:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 20:53:43 +0000 Subject: [Koha-bugs] [Bug 13954] New: other image shows an inadequate rough pixelation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Bug ID: 13954 Summary: other image shows an inadequate rough pixelation Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: Heinrich.Hartl at email.de QA Contact: testopia at bugs.koha-community.org Created attachment 37493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37493&action=edit pixaleted picture side by side with irfanview window of same picture I am preparing a patron card layout including a logo. Since the real logo is not already available I decided to use an arbitrary other .jpg instead. The result in the created pdf is showing the picture in right size and position but badly pixelated. Providing the same picture in .png did not help. I suspect that the resizing operation is not done such as to give an acceptable or optimum result. Please find the following attachments: Screenshot of layout used (template has labels 70*36 mm) Screenshot taken with irfanview showing the pdf created by export viewed 400% and on top of it irfanview Window displaying the same photo - here you can see the pixelated picture side by side with a reasonably resized version of the same picture The used picture to allow you to reproduce my result or even better to use in a testcase for the resolved problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 22:56:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 20:56:17 +0000 Subject: [Koha-bugs] [Bug 13954] other image shows an inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 --- Comment #1 from Heinrich Hartl --- Created attachment 37494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37494&action=edit layout of paatron card (on template with labels 70*36mm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 22:58:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 20:58:27 +0000 Subject: [Koha-bugs] [Bug 13954] other image shows an inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 --- Comment #2 from Heinrich Hartl --- Created attachment 37495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37495&action=edit picture used as other image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 22:59:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 20:59:38 +0000 Subject: [Koha-bugs] [Bug 13954] other image shows an inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Heinrich Hartl changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37494|layout of paatron card (on |layout of patron card (on description|template with labels |template with labels |70*36mm) |70*36mm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 3 23:01:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Apr 2015 21:01:00 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #5 from Barton Chittenden --- (In reply to Marc V?ron from comment #4) > Found: > Template::Plugin::Stash (1.006) Not Installed > > However: If somebody enables the system preference DumpTemplateVarsIntranet > without first checking the Perl modules on the About page, he is locked out > and can not set back the preference, beause the template process fails on > every page. > > Maybe this should be handled more gracefully, e.g. by checking if the perl > module is installed before using it. Best way would be to write a warning as > HTML comment instead of the template variables. I got the same error -- Template::Stash is part of template toolkit, but Template::Plugin::Stash is not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 05:16:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 03:16:47 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37080|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 37496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37496&action=edit Bug 7369 - duplicate item This patch adds a link to duplicate existing items on the edit items screen To test: 1 - Apply patch 2 - navigate to the edit items screen for a record with existing items 3 - click the duplicate link and ensure item info but not barcode are carried over 4 - save the item and ensure it is added correctly 5 - check that all previous functionality on page works as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 05:17:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 03:17:55 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|nengard at gmail.com |nick at quecheelibrary.org --- Comment #4 from Nick Clemens --- Leaving as ASSIGNED, getting a valid_template error with qa tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 06:34:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 04:34:11 +0000 Subject: [Koha-bugs] [Bug 13951] patron card problem: When i choose the "Download as PDF" I always get an empty fields and iam getting patron image , barcode correctly in PDF FILE. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13951 sai changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 08:32:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 06:32:32 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #70 from Marc V?ron --- Created attachment 37497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37497&action=edit [Signed-off] Bug 8033 - Remove unused template file. All prog related patches were obsoleted from this bug. Bug 11349 changed the code to have the proper template name used (sco/printslip.tt instead of sco/printsplit.tmpl). Bug 12062 moved the hard coded string logic into the template, and passed the borrower number. This only leaves the patch to remove the unused receipt.tt file. TEST PLAN --------- 1) Confirm the file isn't used. $ git grep "sco/receipt" | grep -v "\.po:" -- this should list nothing, because there are still po files referencing it, but they aren't needed either. 2) ls ./koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt -- there should be a file 3) apply patch 4) repeat step 2 -- the file should be removed Followed test plan, file does no longer exist. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 08:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 06:33:04 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37490|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 08:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 06:33:22 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 11:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 09:06:02 +0000 Subject: [Koha-bugs] [Bug 13951] patron card problem: When i choose the "Download as PDF" I always get an empty fields and iam getting patron image , barcode correctly in PDF FILE. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13951 --- Comment #2 from sai --- please help me any one.. for patron card problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 12:08:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 10:08:00 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 12:08:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 10:08:02 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #5 from Nick Clemens --- Created attachment 37498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37498&action=edit Bug 7369 - Use dropdown buttons for item actions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 12:08:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 10:08:54 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #6 from Nick Clemens --- passes qa-test-tools and uses dropdown for item actions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 12:51:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 10:51:31 +0000 Subject: [Koha-bugs] [Bug 13951] patron card problem: When i choose the "Download as PDF" I always get an empty fields and iam getting patron image , barcode correctly in PDF FILE. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13951 sai changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://library.defindia.org | |:8080/cgi-bin/koha/patronca | |rds/print.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 15:52:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 13:52:29 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 --- Comment #9 from M. Tompsett --- Comment on attachment 18463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18463 Bug 10374 - Clean up and unify CircControl related code Review of attachment 18463: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10374&attachment=18463) ----------------------------------------------------------------- This was the oldest bug that was "Patch does not apply", but since there are minor logic issues. I figure this commentary on them might spur a fix. ::: C4/Circulation.pm @@ +2249,5 @@ > + if ( $circcontrol eq 'PickupLibrary' ) { > + if ( C4::Context->userenv && C4::Context->userenv->{branch} ) > + { > + $branch = C4::Context->userenv->{branch}; > + } else { If one is tweaking the if/else's, why not use a consistent style? Here it is "} else {" a few lines later "}" with "else {" on the next line. @@ +2265,5 @@ > + else { > + $branch = $item->{ C4::Context->preference('HomeOrHoldingBranch') } > + || $item->{homebranch}; > + } > + } What happened to the else case? What if $circcontrol is not 'PickupLibrary', 'PatronLibrary', or 'ItemHomeLibrary'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 16:55:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 14:55:28 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #16 from M. Tompsett --- Even if I rescued this, the problem is the print() called prints the current page which includes those things, not a different template which would have them hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 19:15:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 17:15:53 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #17 from Christopher Brannon --- (In reply to M. Tompsett from comment #16) > Even if I rescued this, the problem is the print() called prints the current > page which includes those things, not a different template which would have > them hidden. Well, that's pretty much what this ticket addresses. Sounds like someone needs to setup some print tags and css printing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 20:57:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 18:57:08 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #18 from M. Tompsett --- (In reply to Christopher Brannon from comment #17) > (In reply to M. Tompsett from comment #16) > > Even if I rescued this, the problem is the print() called prints the current > > page which includes those things, not a different template which would have > > them hidden. > > Well, that's pretty much what this ticket addresses. Sounds like someone > needs to setup some print tags and css printing. Yes, except it doesn't work. print() doesn't load a different page. There's no @media type CSS. I did rescue it, but discovered it failed. I found there's no print.less file 1) Copied print.css to print.less 2) Got lessc installed and working -- steps left as a fun exercise for the reader. 3) edited print.less to have the following at the end ---- BEGIN SNIPPET ---- .navbar, #navigation, .pages, .actions, #toolbar, #selections-toolbar, #remove-selected, .breadcrumb, #members,#opac-main-search,#opac-user-views .ui-tabs-nav,input,h2 span.hint,td.resultscontrol,.pages,.suggestion,.views,#action,#export,#bibliodescriptions .ui-tabs-nav,#addshelf,fieldset.action, .list-actions, .ft, #facetcontainer,.results_summary.actions,.koha_url,.yui-b { display : none; } .row-fluid { margin-top: 30px; } ---- END SNIPPET ---- 4) lessc --compress < ~/kohaclone/koha-tmpl/opac-tmpl/bootstrap/less/print.less > ~/kohaclone/koha-tmpl/opac-tmpl/bootstrap/css/print.css I ignored the warned about --compress being deprecated. That basically fixes the patch, as far as I can tell. 1) Created a list. 2) Logged into the opac 3) Found my list. 4) Clicked 'Print List', but chose 'CutePDF Writer' instead of my printer. 5) Was disappointed in the results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 21:03:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 19:03:24 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #19 from Christopher Brannon --- (In reply to M. Tompsett from comment #18) > Yes, except it doesn't work. > print() doesn't load a different page. There's no @media type CSS. I did > rescue it, but discovered it failed. Odd that @media isn't working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 22:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 20:58:13 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 22:58:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 20:58:16 +0000 Subject: [Koha-bugs] [Bug 11574] Printing Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25883|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 37499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37499&action=edit Bug 11574 - Clean up Printing Lists Removes extraneous stuff from prints - toolbars, breadcrumbs, etc. To test: 1. make a list 2. print it to a file (from OPAC), observe wasted paper 3. apply patch 4. print list, compare 5. if you like it, sign off. ;) Patch cleans up OPAC list printing as expected. Signed-off-by: Marc V?ron NOTE: Made functional again. Turns out my issues were a result of cached CSS pages. Tested in IE and Firefox successfully. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:05:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:05:12 +0000 Subject: [Koha-bugs] [Bug 10424] Search against order numbers and pull up the related invoice to see when the item was receipted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:05:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:05:17 +0000 Subject: [Koha-bugs] [Bug 10424] Search against order numbers and pull up the related invoice to see when the item was receipted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22033|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 37500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37500&action=edit Bug 10424 - Search received orders Search against order numbers and pull up the related invoice to see when the item was received. This allows users to see details of received orders, including the details against which invoice the order is received. Test Plan: 1) Create a basket. 2) Create a orders under basket and close the basket. 3) Click on Receive shipment button and enter the invoice no and shipment date. 4) Click on Receive link to receive the items. 5) Click on Received orders link on the left hand side. 6) This allow user to search by orderline, basket, title, author, ISBN, vendor and date received. 7) Users will be able to see details of received orders. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:07:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:07:39 +0000 Subject: [Koha-bugs] [Bug 10424] Search against order numbers and pull up the related invoice to see when the item was receipted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #13 from M. Tompsett --- You can't sign off your own patch, Amit. :) I have rescued this. It was a simple enough fix. I have not tested it. See the test plan provided in comment #12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:17:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:17:35 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #12 from M. Tompsett --- Is this left as "Patch doesn't apply" because someone thinks anti-the isn't a good multilingual solution? It's easy enough to rescue if you know which columns need tweaking in parcel.tt, but I'm curious why the delay in saving this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:21:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:21:59 +0000 Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #11 from M. Tompsett --- Should this be rescued, and if so how? The whole sequential number problem needs a better solution than writing sequence generation for each number we encounter. See bug 10454 which sort of got lost in discussion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:23:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:23:29 +0000 Subject: [Koha-bugs] [Bug 4960] No way to enter custom purchase order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4960 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- Katrin, what about 4456? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:32:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:32:44 +0000 Subject: [Koha-bugs] [Bug 12354] Prevent reserving items based on item field values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12354 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:32:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:32:46 +0000 Subject: [Koha-bugs] [Bug 12354] Prevent reserving items based on item field values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12354 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28630|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 37501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37501&action=edit Bug 12354 - Prevent reserving items based on item field values Add a system preference PreventItemHoldsFieldvalues, which is a pipe-delimited list of "fieldname=value", where fieldname is one of the fields from items -table in the database. If the field has the exact value, the item cannot be reserved. For example, "ccode=PILA|location=OHE" would prevent reserving the item if it's collection code is 'PILA' or if it's location is 'OHE'. To test: 1) Go to the page where you put a hold on an item, and look at the list of items. Note which ones are available for hold and which ones aren't. 2) Apply patch, set the syspref value to eg. homebranch=FOO|biblionumber=12345 3) Check that items with homebranch FOO or items for biblio 12345 cannot be reserved by patrons, and need override permission for staff to reserve. NOTE: This should apply, but is missing tests added to t/db_dependent/Reserves.t -- mtompset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:35:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:35:27 +0000 Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #29 from M. Tompsett --- (In reply to Olli-Antti Kivilahti from comment #27) > This patch just created an issue for us in conjunction with Bug 12624. > > It was very useful in our initial migration but after that it will be > worthless. So, should this be left as "Patch doesn't apply" or perhaps change it to "Resolved - Won't Fix"? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:39:39 +0000 Subject: [Koha-bugs] [Bug 11676] Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #12 from M. Tompsett --- This still doesn't apply, and it is worse now. You would think that someone would have hash referenced the parameters for generate_subfield_form when they added $restrictededition. *sigh* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 4 23:41:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 21:41:21 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #12 from M. Tompsett --- Scary! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 01:07:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 23:07:43 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #7 from M. Tompsett --- Comment on attachment 37496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37496 Bug 7369 - duplicate item Review of attachment 37496: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7369&attachment=37496) ----------------------------------------------------------------- ::: cataloguing/additem.pl @@ +581,5 @@ > + $fieldItem->delete_subfields($tagsubfield); > + $itemrecord->insert_fields_ordered($fieldItem); > + } > + > + #check for hidden subfield and remove them for the duplicated item Why? Duplicate means duplicate everything (except itemnumber and barcode), right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 01:12:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 23:12:11 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |In Discussion --- Comment #8 from M. Tompsett --- BTW, I love the button dropdown on the Edit/Duplicate/Delete. Such a pretty improvement! Now for the question: Why is the delete an else on whether there are analytics or not? Moving to 'In Discussion' to reflect that I have asked some questions before signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 01:15:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 23:15:12 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #9 from Nick Clemens --- > Why? Duplicate means duplicate everything (except itemnumber and barcode), > right? The hidden fields include issues and on loan etc., I think duplicating fields you can't manually touch or edit is not helpful. Essentially it's an extension of Add+duplicate, giving you the option to add additional copies after initial cataloging. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 01:17:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 23:17:30 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #10 from Nick Clemens --- (In reply to M. Tompsett from comment #8) > > Now for the question: Why is the delete an else on whether there are > analytics or not? > I honestly wondered that myself when editing but not knowing the answer I assumed whoever did that had intention and was better to leave as is than to bug fix someone's feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 01:37:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Apr 2015 23:37:00 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #11 from Nick Clemens --- (In reply to Nick Clemens from comment #10) > (In reply to M. Tompsett from comment #8) > > > > Now for the question: Why is the delete an else on whether there are > > analytics or not? > > Ah, okay, when adding an analytical record (say a separate record for an article in a journal) you attach it to a specific item on the parent record. This check ensures that if the record has an analytical/'child' record you don't delete it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 02:57:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 00:57:51 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37496|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 37502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37502&action=edit Bug 7369 - duplicate item This patch adds a link to duplicate existing items on the edit items screen To test: 1 - Apply patch 2 - navigate to the edit items screen for a record with existing items 3 - click the duplicate link and ensure item info but not barcode are carried over 4 - save the item and ensure it is added correctly 5 - check that all previous functionality on page works as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 02:57:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 00:57:58 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37498|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 37503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37503&action=edit Bug 7369 - Use dropdown buttons for item actions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 02:59:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 00:59:36 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37503|0 |1 is obsolete| | --- Comment #14 from M. Tompsett --- Created attachment 37504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37504&action=edit Bug 7369 - Use dropdown buttons for item actions Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 03:01:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 01:01:30 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37502|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 37505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37505&action=edit Bug 7369 - duplicate item This patch adds a link to duplicate existing items on the edit items screen To test: 1 - Apply patch 2 - navigate to the edit items screen for a record with existing items 3 - click the duplicate link and ensure item info but not barcode are carried over 4 - save the item and ensure it is added correctly 5 - check that all previous functionality on page works as before Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 03:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 01:02:16 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 03:02:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 01:02:30 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37505|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 03:02:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 01:02:36 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 03:02:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 01:02:53 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #16 from M. Tompsett --- Created attachment 37506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37506&action=edit Bug 7369 - duplicate item This patch adds a link to duplicate existing items on the edit items screen To test: 1 - Apply patch 2 - navigate to the edit items screen for a record with existing items 3 - click the duplicate link and ensure item info but not barcode are carried over 4 - save the item and ensure it is added correctly 5 - check that all previous functionality on page works as before Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 03:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 01:02:58 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #17 from M. Tompsett --- Created attachment 37507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37507&action=edit Bug 7369 - Use dropdown buttons for item actions NOTE: Tested both patches together. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 03:28:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 01:28:18 +0000 Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #14 from M. Tompsett --- (In reply to Olli-Antti Kivilahti from comment #13) > Sorry, I cannot work on this currently. I will let this slide to the next > one who encounters this issue and wants to fix it. Hopefully using some of > my code :) I felt like fainting getting half way through with no sign of any obvious changes, except for white space. Do you have time to make reading and testing it more feasible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 07:55:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 05:55:25 +0000 Subject: [Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 08:01:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 06:01:41 +0000 Subject: [Koha-bugs] [Bug 13857] Email input field for sharing lists is too small In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13857 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 22:15:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 20:15:12 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 22:15:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 20:15:14 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37423|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 37508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37508&action=edit [PASSED QA] Bug 13938 - Staging MARC records for import fails It appears that bug 8970 has introduced a bug where a MARC file uploaded for staging fails to import *unless* a matching rule is selected. Test Plan: 1) Apply this patch 2) Stage and import a MARC record *without* choosing a matching rule 3) Note the staging works as expected Signed-off-by: Cindy Ames Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 22:21:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 20:21:09 +0000 Subject: [Koha-bugs] [Bug 13955] New: 'Processing...' message out of place Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13955 Bug ID: 13955 Summary: 'Processing...' message out of place Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To test: - create a hold for your patron - go to the patron account - go to the details (not checkouts!) tab - load the holds tab - notice the 'Processing...' message appears at the very top left instead of close to the table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 22:21:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 20:21:51 +0000 Subject: [Koha-bugs] [Bug 13923] Holds tab on the circulation page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13923 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 22:21:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 20:21:54 +0000 Subject: [Koha-bugs] [Bug 13923] Holds tab on the circulation page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13923 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37302|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 37509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37509&action=edit [PASSED QA] Bug 13923: The prefetch used on existing constraint The belongs_to constraint has been removed by bug 13713. Not sure if it was a good idea, but atm the easy and quick way is to remove the prefetch. Test plan: Go on the circulation page, holds tab Confirm that there is no regression (Same on the patron details page > Holds tab) Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 22:22:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 20:22:18 +0000 Subject: [Koha-bugs] [Bug 13923] Holds tab on the circulation page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13923 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Seems to do the trick - found bug 13955 while testing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 22:38:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 20:38:07 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 22:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 20:38:10 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37321|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 37510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37510&action=edit [PASSED QA] Bug 6911: Remember search terms in the log viewer tool The modules and actions selected by the user are now selected when a log search is done. Note that this patch also add the multiple attribute to the actions select in order to add the ability to select several actions. The code to do that already existed. Test plan: 1/ Go on the log viewer tool (tools/viewlog.pl) 2/ Launch a search with modules and actions selected. 3/ Confirm that the values you have selected is still selected after the search. Patch works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 22:38:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 20:38:32 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch --- Comment #4 from Katrin Fischer --- Thx Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 22:53:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 20:53:06 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- Hm, something is not looking quite right in my test. I marked all existing budgets as inactive. I created a new one without any fund and also marked it inactive. I click on the inactive budget, select Planning and the perl error occurs without the patch. With the patch, I do the same, example URL: http://localhost:8080/cgi-bin/koha/admin/aqplan.pl?budget_period_id=8&authcat=BRANCHES Message displayed: No funds to display for this search criteria When I know submit the filters, the budget selection seems to be forgotten: http://localhost:8080/cgi-bin/koha/admin/aqplan.pl And instead of displaying the new error message I see some fund values that maybe belong to one of the other budgets? I know this is a messy script - but can we catch this easily maybe? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 23:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 21:03:38 +0000 Subject: [Koha-bugs] [Bug 7480] The Basket manager is always the logged in user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 23:03:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 21:03:41 +0000 Subject: [Koha-bugs] [Bug 7480] The Basket manager is always the logged in user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37338|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 37511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37511&action=edit [PASSED QA] Bug 7480: Don't display current logged in user as basket manager The "Managed by" field displayed on creating/editing an order is always the name of the logged in user. To reproduce: 1/ Log in with patron A 2/ Create a basket 3/ Create an order 4/ Log in with patron B 5/ Edit the order 6/ The "Managed by" line is "patron B" Test plan: Apply the patch and confirm that the "patron A" is always the basket manager. Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 23:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 21:04:40 +0000 Subject: [Koha-bugs] [Bug 7480] The Basket manager is always the logged in user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480 --- Comment #6 from Katrin Fischer --- Funny noone ever noticed the visible effect of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 23:13:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 21:13:45 +0000 Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 23:13:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 21:13:48 +0000 Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37327|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 37512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37512&action=edit Bug 6950: Hide the resort option when searching for a tag If you click a link from the Tag Cloud, the results page offers the usual select menu to resort your results. However, doing so resubmits the search as a standard keyword search. Test plan: 1/ Click on a tag 2/ Confirm that the resort dropdown list does not appear. Dropdown list disappears with tags as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 23:14:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 21:14:19 +0000 Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37512|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 37513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37513&action=edit [PASSED QA] Bug 6950: Hide the resort option when searching for a tag If you click a link from the Tag Cloud, the results page offers the usual select menu to resort your results. However, doing so resubmits the search as a standard keyword search. Test plan: 1/ Click on a tag 2/ Confirm that the resort dropdown list does not appear. Dropdown list disappears with tags as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 23:15:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 21:15:04 +0000 Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- And another one bites the dust... :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 23:31:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 21:31:21 +0000 Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring default sort preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 23:31:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 21:31:24 +0000 Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring default sort preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37225|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 37514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37514&action=edit [PASSED QA] Bug 13908 - Checkouts table sorting is not honoring default sort preferences The checkouts table no longer honors the system preferences todaysIssuesDefaultSortOrder and previousIssuesDefaultSortOrder. This causes much frustration for librarians who prefer a different sort order. In particular, many librarians prefer to see the oldest previous issues at the top of the list so those overdue items are visible "above the fold". Test Plan: 1) Apply this patch 2) Find a patron with many previous checkouts due on different days 3) Try all 4 combinations of todaysIssuesDefaultSortOrder and previousIssuesDefaultSortOrder 4) Note they all sort correctly Signed-off-by: Sean McGarvey Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 5 23:58:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 21:58:00 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I found t/db_dependent/ImportBatch.t, but it only includes 5 tests. Maybe they could be a starting point? I am a bit worried by the mismatch of the MARC view with the new diff view. Could we also include the item information in the new diff view? Please read 'Failed QA' as 'Asking for feedback' - tests looking ok so far :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 00:07:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 22:07:08 +0000 Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous characters ( e.g. '$' ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- Some thoughts on this: 1) I think displaying the 0 is not good for ergonomy. I can type 03.00, but I feel libraries will think they need to delete the 0 first, before typing in the correct amount. 2) Also: with the 0 in the field, you can still accidentally save 0 value credits and fines easily and the 'required' attribute on the field doesn't kick in. 3) The message is very unspecific. For example, when I enter 'agahgag' it will just ask me to 'fill out the field' Can we have the field empty and have a better error message? Maybe something like: 'The entered amount is not valid'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 00:16:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 22:16:08 +0000 Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with date last seen greater than the inventory date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- The search option is named 'inventory date' - If I understood correctly, this could be more clear as 'inventory date before'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 00:16:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 22:16:16 +0000 Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with date last seen greater than the inventory date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 00:23:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 22:23:23 +0000 Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with date last seen greater than the inventory date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Bit confused as the following lines were introduced by bug 12631 and are undone here: Patch from 12631: + my $paramdatelastseen = ($compareinv2barcd) ? $datelastseen : ''; + ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $paramdatelastseen, $branchcode, $branch, 0, undef, $staton); Patch attached to this bug: - my $paramdatelastseen = ($compareinv2barcd) ? $datelastseen : ''; - ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $paramdatelastseen, $branchcode, $branch, 0, undef, $staton); + ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $datelastseen, $branchcode, $branch, 0, undef, $staton); Are we sure there is no regression on bug 12631 by this change? I had problems testing 12631 when I tried, so not sure. Can you please take a look and explain? The test plan works for me - I'd just like to be careful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 00:39:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 22:39:04 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- I think it could be a nice addition to limit the cataloguing framework in cataloguing to the FA framework - choosing another framework will send you to the login page as he permission is missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 00:39:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 22:39:50 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 00:39:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 22:39:53 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37380|0 |1 is obsolete| | Attachment #37381|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 37515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37515&action=edit [PASSED QA] Bug 7561: Fast cataloging - Allow add/edit items and delete record With the fast cataloging permission, a librarian was not able to add/edit items and to delete a record with the FA framework. This patch fixes that. Test plan: 0/ Set the permission fast_cataloging (and only this one under editcatalogue) to a librarian 1/ Log in with this account 2/ Go to Circulation > Fast cataloging 3/ Confirm you can create a record 4/ Save and confirm you can create items 5/ Confirm you are able to edit items, remove all of them and delete the record. 6/ Make sure it only works for records with the FA framework code. Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 00:40:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 22:40:09 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 --- Comment #18 from Katrin Fischer --- Created attachment 37516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37516&action=edit [PASSED QA] Bug 7561: Redirect to the add items form if it's a fast cataloging Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 00:55:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 22:55:47 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Printing Lists |Clean up printing of lists | |in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 00:56:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 22:56:25 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #21 from Katrin Fischer --- This report was initially for the staff client, but we got a patch for the OPAC so I think we should file a new report for staff to make it (hopefully) a little less confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 01:00:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 23:00:12 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #22 from Katrin Fischer --- Cleans up the printout significantly. It would be nice to move things around a bit as the removed navigation leaves a lot of blank space on the left. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 01:01:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 23:01:07 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37499|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 37517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37517&action=edit [PASSED QA] Bug 11574 - Clean up Printing Lists Removes extraneous stuff from prints - toolbars, breadcrumbs, etc. To test: 1. make a list 2. print it to a file (from OPAC), observe wasted paper 3. apply patch 4. print list, compare 5. if you like it, sign off. ;) Patch cleans up OPAC list printing as expected. Signed-off-by: Marc V?ron NOTE: Made functional again. Turns out my issues were a result of cached CSS pages. Tested in IE and Firefox successfully. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 01:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 23:01:04 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 01:04:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 23:04:57 +0000 Subject: [Koha-bugs] [Bug 9846] system preference for required purchase suggestion fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9846 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10848 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 01:04:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 23:04:57 +0000 Subject: [Koha-bugs] [Bug 10848] Allow configuration of mandatory/required fields on the suggestion form in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #29 from Katrin Fischer --- *** Bug 9846 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 01:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Apr 2015 23:27:14 +0000 Subject: [Koha-bugs] [Bug 5927] Show series information in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Is this still valid? Which fields are missing where? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 02:51:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 00:51:05 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #24 from M. Tompsett --- (In reply to Katrin Fischer from comment #21) > This report was initially for the staff client, but we got a patch for the > OPAC so I think we should file a new report for staff to make it (hopefully) > a little less confusing. Strangely, the obsoleted patches were all for opac, even though you are right it is staff client requested in comment #1. So, because it was opac, that's what I rescued and signed off. Perhaps the description was wrong? After all, staff can create lists in the staff client to use in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 03:02:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 01:02:38 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #8 from M. Tompsett --- (In reply to Katrin Fischer from comment #7) [ISSUE SNIPPED] > > I know this is a messy script - but can we catch this easily maybe? That's beyond the scope of this patch, as far as I can tell. I wouldn't fail this patch for the failing of the whole larger mess. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 03:49:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 01:49:45 +0000 Subject: [Koha-bugs] [Bug 5927] Show series information in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5927 --- Comment #3 from Nicole C. Engard --- I believe it's the 490 field and subfields. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 09:03:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 07:03:05 +0000 Subject: [Koha-bugs] [Bug 13890] Full serial permission is needed to change sequence on a routing list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 09:05:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 07:05:01 +0000 Subject: [Koha-bugs] [Bug 7391] Return to cart after adding items to a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7391 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 10:25:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 08:25:42 +0000 Subject: [Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 10:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 08:28:50 +0000 Subject: [Koha-bugs] [Bug 13868] Date on routing list slip is not well formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13868 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 10:29:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 08:29:29 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 --- Comment #9 from Katrin Fischer --- This patch introduces a new error message, that I have not been able to trigger in my tests. The Perl error is gone, which is great - but the information showing in my install now is also quite confusing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 10:31:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 08:31:57 +0000 Subject: [Koha-bugs] [Bug 6820] hide receive option if there is nothing to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6820 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|minor |enhancement -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 10:38:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 08:38:47 +0000 Subject: [Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #18 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 10:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 08:45:04 +0000 Subject: [Koha-bugs] [Bug 13859] Fix item search result list - obsolete "by" and display of publication date for MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13859 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 10:47:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 08:47:39 +0000 Subject: [Koha-bugs] [Bug 9481] charge not showing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9481 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #27 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 10:55:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 08:55:30 +0000 Subject: [Koha-bugs] [Bug 4277] budget planning refreshes funny In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4277 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:14:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:14:01 +0000 Subject: [Koha-bugs] [Bug 13956] New: Add Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13956 Bug ID: 13956 Summary: Add Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:15:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:15:46 +0000 Subject: [Koha-bugs] [Bug 13956] Add budget information to funds pull down on crating an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13956 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add |Add budget information to | |funds pull down on crating | |an order --- Comment #1 from Katrin Fischer --- When receiving an order with mulitple budgets active, we now have a nicely structured list, that is ordered by budgets and shows the funds below the budget. I think it would be great to have a similar display on the order creation form, so it's easier to spot the right fund with mulitple active budgets. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:18:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:18:22 +0000 Subject: [Koha-bugs] [Bug 13875] Columns configuration - table name cannot contain underscore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:18:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:18:25 +0000 Subject: [Koha-bugs] [Bug 13875] Columns configuration - table name cannot contain underscore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37403|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 37518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37518&action=edit [PASSED QA] Bug 13875: Columns configuration - Allow underscore in table name This is a bug fix for bug the columns configuration feature, and specialy for bug 13864. Test plan: Apply patches on bug 13864 and save columns for the late orders (in the columns configuration admin page). Confirm that they are correctly saved. Signed-off-by: Josef Moravec works as expected Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:19:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:19:28 +0000 Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- This works nicely for me, but could we improve display for long column names? The estimated delivery date is not looking nice in the display and I am a bit worried about our very long German terms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:21:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:21:32 +0000 Subject: [Koha-bugs] [Bug 13875] Columns configuration - table name cannot contain underscore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37518|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 37519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37519&action=edit [PASSED QA] Bug 13864: Columns configuration - Late orders This patch adds the ability to hide columns on the late orders page (acqui/lateorders.pl). Test plan: Go on the late orders page and confirm you are able to hide columns. You can also play with the columns configuration admin page and confirm that the behaviors are consistent. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:33:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:33:16 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37355|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 37520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37520&action=edit [PASSED QA] Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec Works as expected Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:33:13 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:46:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:46:05 +0000 Subject: [Koha-bugs] [Bug 13850] C4::Ris does not manage correctly 660 and 661 - UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:46:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:46:08 +0000 Subject: [Koha-bugs] [Bug 13850] C4::Ris does not manage correctly 660 and 661 - UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13850 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37384|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 37521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37521&action=edit [PASSED QA] Bug 13850: Fix typo in C4::Ris In C4/Ris.pm: @field_list = ('600', '601', '602', '604', '605', '606','607', '608', '610', '615', '620', '660'. '661', '670', '675', '676', '680', '686'); Note the '660'. '661' instead of '660', '661' Test plan: Add a 660 and 661 field to a record and export it in RIS The 660 and 661 field should be displayed (after "KW"). Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:50:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:50:08 +0000 Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly limited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:59:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:59:08 +0000 Subject: [Koha-bugs] [Bug 13957] New: Patron autocomplete shows NULL in list of results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Bug ID: 13957 Summary: Patron autocomplete shows NULL in list of results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When doing a search for a patron from the checkout tab, using the autocomplete feature, the result list shows a 'null' at the end of each result line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 11:59:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 09:59:30 +0000 Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly limited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822 --- Comment #14 from Katrin Fischer --- This works ok, I am seeing a small issue with and without the patch - filed bug 13957 for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 12:01:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 10:01:31 +0000 Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly limited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 12:01:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 10:01:34 +0000 Subject: [Koha-bugs] [Bug 13822] Patron autocomplete search is severly limited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37331|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 37522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37522&action=edit [PASSED QA] Bug 13822 - Patron autocomplete search is severly limited The script that returns data for the patron autocomplete does not use C4::Members::Search. Instead it uses bespoke code that does not behave like the traditional search and is very limited in how it can search. If, for example, I search for "Kyle Hall" in the standard search, I would get "Kyle Hall" back as a result. For the autocomplete search, I will not. This script should use C4::Members::Search to provide better searching and to keep the code base DRY. Test Plan: 1) Enable the system preference CircAutocompl 2) Create a user with the first name "Test" and the surname "User" 3) Perform a checkout autocomplete search for "Test User" 4) Note you do not get the user as a result 5) Apply this patch 6) Try different combinations of "Test" and "User" such as Test User User Test U Test Test U etc. 7) Note these searches now work Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 12:05:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 10:05:21 +0000 Subject: [Koha-bugs] [Bug 13875] Columns configuration - table name cannot contain underscore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37519|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 37523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37523&action=edit [PASSED QA] Bug 13875: Columns configuration - Allow underscore in table name This is a bug fix for bug the columns configuration feature, and specialy for bug 13864. Test plan: Apply patches on bug 13864 and save columns for the late orders (in the columns configuration admin page). Confirm that they are correctly saved. Signed-off-by: Josef Moravec works as expected Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 12:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 10:06:17 +0000 Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 12:06:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 10:06:20 +0000 Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37300|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 37524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37524&action=edit [PASSED QA] Bug 13864: Columns configuration - Late orders This patch adds the ability to hide columns on the late orders page (acqui/lateorders.pl). Test plan: Go on the late orders page and confirm you are able to hide columns. You can also play with the columns configuration admin page and confirm that the behaviors are consistent. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer http://bugs.koha-community.org/show_bug.cgi?id=13875 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 12:33:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 10:33:42 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #54 from Katrin Fischer --- Starting on this... - QA script OK - Code review OK ------------------- 1) New test is failing for me: not ok 8 - Koha::Acquisition::Order->insert set created_by to logged in user if not given # Failed test 'Koha::Acquisition::Order->insert set created_by to logged in user if not given' # at t/db_dependent/Acquisition/NewOrder.t line 91. # got: undef # expected: '42' # Looks like you failed 1 test of 8. 2) Why only display the order line creator during the receive process, but not on the order pages? We can only see the basket creator there. 3) On the order receive page: Maybe we should write "Ordered by" instead of "Created by"? 4) On the parcel page: You change the display for the unreceived order lines table, but the received orders miss the link to the order. I think it would be better to be consistent and also to keep the | for separating the links from each other. 5) The popup window appers 'unstyled' - for example it appears in a much bigger than the rest serif font for me. Maybe something for a follow up? Could you please take a look? Especially at the failing test and 4) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 13:12:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 11:12:33 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #33 from Katrin Fischer --- Some notes about this: 1) I know it's outside the scope of this bug, but we are about to make the feature much more prominent and easier to use with this patch. I am worried about the lack of good error messages and possible missing checks in the patron deletion tool (see also comment#27). In general we always need to check at least for: - checkouts - fines - guarantor relationships Example: Argh? I created a patron list with 6 patrons, I checked out a book to one of the patrons. The test run on the patron delete tells me the that 6 patrons would have been deleted. I feel like we need to get the base feature working well, before we can extend it's use like that. 2) Patron list page: I don't like the "2 symbol" concept on the buttons, because that won't work well for translations. You can't assume safely that the Verb is always on the left side and the subject on the right. For example in the German translations we could have both: L?sche Benutzer and Benutzer l?schen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 13:39:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 11:39:53 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Hi Kyle, 0) The QA script fails: FAIL misc/migration_tools/import_lexile.pl FAIL critic I/O layer ":utf8" used at line 39, column 1. Use ":encoding(UTF-8)" to get strict validation. FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK pod OK valid 1) Is copyright 2013 correct? 2) I am not sure what one of the options means from the description, could you clarify? + --source-value Defines the value to put stored in the "Source" subfield ( default: "Lexile" ) 3) The documentation for --file says: "acquired from Lexile.com", but the actual file format is not documented. I think maybe we need to decide here if this is a vendor specific or a general purpose script. If it's vendor specific, we might want to reflect that more clearly in the file name and description. If it's general purpose, we should include notes about the file format to make this easier to reuse. 4) We didn't really finish our discussions about the standard options for CLI scripts (http://wiki.koha-community.org/wiki/Coding_Guidelines#Command-line_argument_conventions), but maybe this should have a -c for confirming the action as it's going to change data? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 13:43:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 11:43:26 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #27 from Katrin Fischer --- Hi Courret, you could create a sql report with the following statement: select * from suggestions; This will show you everything that is in your suggestions table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 13:54:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 11:54:35 +0000 Subject: [Koha-bugs] [Bug 13954] other image shows an inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Created attachment 37525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37525&action=edit Compare PDF with downsampled image (without patch) with PDF internally scaled image (with patch) The problem is that the image is downsampled to a very small size before it ist inserted into the PDF file. The downscaling should be done inside PDF. See screenshots from PDF, image height 67pt, displayed in Adobe Reader at 400%. Patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 14:02:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 12:02:53 +0000 Subject: [Koha-bugs] [Bug 13392] New statistics wizard for suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer --- Hi Julian, working on this again: 1) The QA script outputs some warnings, could you please take a look? I can also see those in my logs on accessing the new page: Processing files before patches |========================>| 13 / 13 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. Argument "" isn't numeric in numeric gt (>) at /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/reports/suggestions_stats.tt line 52. |========================>| 13 / 13 (100.00%) 2) Some strings need to be changed from 'Acquisitions' to 'Suggestions' - like the table legend on the form and the heading on the result page. 3) We need some POD for the new GetBudgetDescendantsIds. 4) I was worried about some of the TT constructs translatability and ran some tests, but looking good so far :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 14:18:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 12:18:42 +0000 Subject: [Koha-bugs] [Bug 13954] other image shows an inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Priority|P5 - low |P4 QA Contact|testopia at bugs.koha-communit |veron at veron.ch |y.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 14:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 12:19:50 +0000 Subject: [Koha-bugs] [Bug 13954] other image shows an inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 --- Comment #4 from Marc V?ron --- Created attachment 37526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37526&action=edit Bug 13954 - Patroncards: images show inadequate rough pixelation This patch provides a much better quality of images on patron cards. It inserts images at a higher resolution into the PDF file and then scales it down internally in PDF. Additionaly, the patch removes the follwing warning: "my" variable $template masks earlier declaration in same scope at /usr/share/kohaclone/patroncards/create-pdf.pl line 66 To test: - Create patron cards, save them as PDF and display them with a PDF viewer, e.g. at 400% - Without patch, the images are very pixelated. - Apply patch - Verify that in the PDF the images now display with a much better quality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 14:20:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 12:20:56 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Summary|other image shows an |Patroncards: images show |inadequate rough pixelation |inadequate rough pixelation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 14:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 12:31:04 +0000 Subject: [Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour finesCalendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|_debar_user_on_return |Suspension days calculation |doesn't honour |doesn't honour |finesCalendar |finesCalendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 14:33:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 12:33:15 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8796 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 14:33:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 12:33:15 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13954 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 14:56:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 12:56:23 +0000 Subject: [Koha-bugs] [Bug 13821] Add possibility to select more than one department on a course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13821 --- Comment #1 from Kyle M Hall --- Created attachment 37527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37527&action=edit Bug 13812 - Facet links broken because double-quotes are not URL encoded. This bug is analogous to Bug 13442, but it affects shelf location rather than collection code: Limiting a search by shelf location is broken, because it wraps double-quotes around the "value" part of the key-value pair in the URL. This breaks the href= part of the anchor tag. The anchor tag generated for the shelf location faced is Paetro, Maxine, Once again, double-quotes inside the URL are causing a premature close of the href, which results in a broken link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 14:58:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 12:58:02 +0000 Subject: [Koha-bugs] [Bug 13821] Add possibility to select more than one department on a course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #37527|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 14:58:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 12:58:16 +0000 Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 --- Comment #2 from Kyle M Hall --- Created attachment 37528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37528&action=edit Bug 13812 - Facet links broken because double-quotes are not URL encoded. This bug is analogous to Bug 13442, but it affects shelf location rather than collection code: Limiting a search by shelf location is broken, because it wraps double-quotes around the "value" part of the key-value pair in the URL. This breaks the href= part of the anchor tag. The anchor tag generated for the shelf location faced is Paetro, Maxine, Once again, double-quotes inside the URL are causing a premature close of the href, which results in a broken link. http://bugs.koha-community.org/show_bug.cgi?id=13821 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 15:01:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 13:01:49 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Chris Nighswonger --- (In reply to Marc V?ron from comment #4) > This patch provides a much better quality of images on patron cards. > It inserts images at a higher resolution into the PDF file and then scales > it down internally in PDF. > I think $oversize_factor should not be hard-coded. Based on past experience (at least in this area of the code), hard-coded vars end up making it very difficult to figure out what is going on both for the end user and for devs working on bugs, etc. Furthermore, it may be desirable to have this as a per-image parameter to allow the end user to decide what amount of over-sizing is needed to achieve the desired end results for each image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 15:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 13:02:41 +0000 Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|NEW |Needs Signoff --- Comment #3 from Kyle M Hall --- Patch removes quotes. Another possibility would be to escape or encode the quotes, but I'm not well versed enough with the XSLT to do so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 15:15:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 13:15:00 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Not sure if this value would be easy to understand/use for users from the GUI. It seems to fix a problem that some people have reported in the past - could this be a first step with more refinement later? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 15:43:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 13:43:49 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 --- Comment #7 from Marc V?ron --- The way how the images are first downsampled and then added to the PDF file is simply wrong. It leads to a very poor quality of the printed cards. The images should be added to the PDF with a higher quality and downscaled (transformed) with PDF internal operators. Rule of thumb for this kind of printing is to have it 5 times bigger (I know such things; I do PDF stuff since 1995). This is fixed in my patch, and the wole card creation works the same way as before. I do not think that it makes much sense to expose this var to the end user, because it is merely a technical thing. For the encanced quality, see: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37525 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 15:54:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 13:54:17 +0000 Subject: [Koha-bugs] [Bug 13958] New: Add a suspensionsCalendar syspref Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Bug ID: 13958 Summary: Add a suspensionsCalendar syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We need a way to provide more granularity to the circulation/fines/suspensions rules. Specifically we would benefit from decoupling fines and suspensions regarding how overdue days are calculated. For that purpose we need to have a suspensionsCalendar syspref that does the same finesCalendar does for fines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 15:54:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 13:54:21 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 16:03:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 14:03:01 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 --- Comment #8 from Chris Nighswonger --- Marc, thanks for you work on this. Nothing here is meant to discredit that or convey anything other than great appreciation for all of the help I can get on bugs in this code. I've only done PDF stuff since 2000, so you've go the goods on me there, however, I would really like to have time to convince myself that this is where/what the fix should be. If you feel that the problem really lies elsewhere in the code, I would prefer that the fix be made there rather than in this location. ATM, I am attempting to duplicate your issue on the current master. After that, if the fix as it is makes sense to me, I'll have no problem signing off on it. Also, citing some sort of documentation on scale-up/scale-down inside the pdf as the preferred technique would be appreciated as well. I have tried to do this as comments in the code where I felt it might be helpful to my own poor memory as well as to the next sad soul who has to work on the "code soup" I have written. AAMOF, if doing the scaling inside the pdf both works in every case and is the preferred method, then perhaps we can eliminate a large chunk of code moving the scaling entirely to the pdf renderer. I'm all for purging old/bad/poorly-written/unnecessary code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 16:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 14:12:40 +0000 Subject: [Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour finesCalendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13958 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 16:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 14:12:40 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13909 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 16:50:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 14:50:09 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 --- Comment #10 from M. Tompsett --- Comment on attachment 37354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37354 Bug 4502: Catch software error if no active budget defined Review of attachment 37354: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=4502&attachment=37354) ----------------------------------------------------------------- ::: admin/aqplan.pl @@ +107,5 @@ > $authcat = 'Asort1' if not defined $authcat; # defaults to Asort if no authcat given > > +# If no active budget is defined, budget_period_id is undef > +# This is the behavior of GetBudgetPeriod > +$authcat = '' unless $budget_period_id; Perhaps it should be 'Asort1'? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 16:54:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 14:54:56 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 --- Comment #11 from Katrin Fischer --- Not sure if that makes sense... asort1 might not even be an existing authorised value. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 18:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 16:01:45 +0000 Subject: [Koha-bugs] [Bug 13959] New: itemBarcodeFallbackSearch does not appear to work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13959 Bug ID: 13959 Summary: itemBarcodeFallbackSearch does not appear to work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I have just tested in 3.16.x and master and it looks like the new circ interface makes it so that the itemBarcodeFallbackSearch preference does not work. I am in training right now but can provide more details when done if necessary -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 18:03:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 16:03:21 +0000 Subject: [Koha-bugs] [Bug 13959] itemBarcodeFallbackSearch does not appear to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I showed the feature in training too - it worked ok in 3.18.3. We used it with callnumbers and title keywords. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 18:08:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 16:08:44 +0000 Subject: [Koha-bugs] [Bug 13959] itemBarcodeFallbackSearch does not appear to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13959 --- Comment #2 from Katrin Fischer --- Hm, just retested in master, turned the feature on and made sure Zebra was working - then it worked nicely. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 18:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 16:25:47 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 --- Comment #15 from Nicole C. Engard --- Why is this in discussion? I see a new patch here - are we ready for sign off again? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 19:02:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 17:02:27 +0000 Subject: [Koha-bugs] [Bug 13959] itemBarcodeFallbackSearch does not appear to work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13959 --- Comment #3 from Nicole C. Engard --- Strange, I tested it on with two systems and both failed without error. I'll check zebra when done with training. Nicole -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 19:14:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 17:14:51 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37451|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 37529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37529&action=edit Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated The description of the BakerTaylorBookstoreURL syspref says "Baker and Taylor "My Library Bookstore" links should be accessed at https:// isbn (this should be filled in with something like ocls.mylibrarybookstore.com/MLB/actions/searchHandler.do?nextPage=bookDetails&parentNum=10923&key=). Leave it blank to disable these links." Leaving this syspref blank does not disable the links. Instead, they are populated without the bookstore URL: the cover image for ISBN 1575725738 will cause koha to make a request to http://1575725738, which will, of course, time out. Leaving BakerTaylorBookstoreURL blank should disable any URL that depends on this syspref, as stated in the syspref description. Test Plan: 1) Apply this patch 2) Enable Baker & Taylor cover images, but *not* BakerTaylorBookstoreURL 3) Perform an OPAC search where you have B&T cover images in the results 4) Note the image links now direct you to the record details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 19:17:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 17:17:21 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 19:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 17:17:24 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37529|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 37530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37530&action=edit Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated The description of the BakerTaylorBookstoreURL syspref says "Baker and Taylor "My Library Bookstore" links should be accessed at https:// isbn (this should be filled in with something like ocls.mylibrarybookstore.com/MLB/actions/searchHandler.do?nextPage=bookDetails&parentNum=10923&key=). Leave it blank to disable these links." Leaving this syspref blank does not disable the links. Instead, they are populated without the bookstore URL: the cover image for ISBN 1575725738 will cause koha to make a request to http://1575725738, which will, of course, time out. Leaving BakerTaylorBookstoreURL blank should disable any URL that depends on this syspref, as stated in the syspref description. Test Plan: 1) Apply this patch 2) Enable Baker & Taylor cover images, but *not* BakerTaylorBookstoreURL 3) Perform an OPAC search where you have B&T cover images in the results 4) Note the image links now direct you to the record details Signed-off-by: Sheila Kearns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 20:09:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 18:09:30 +0000 Subject: [Koha-bugs] [Bug 9302] merge patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 20:17:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 18:17:06 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer --- I have stared at this for a while, there are some things I am not completely happy with: 1) There is a visible change on the result list with this patch - the added 'Call number: ' in front of every entry. This can be hidden with CSS, so I think it's probably ok. Example: Availability: Items available for loan: Fairfield [Call number: 320] (1), Franklin [Call number: 320] (1), Riverside [Call number: 320] (1), Union [Call number: 320] (1). 2) I am stumbling a bit over 'CommasWithLinebreaks' as a class name. I'd like something that describes the content better. 3) The 'Call number: ' change is not consistent. If you have an item whose item type is marked as not for loan, it will show up separately: Example: Availability: Items available for loan: Franklin [Call number: 320] (1), Riverside [Call number: 320] (1), Union [Call number: 320] (1). Items available for reference: Fairfield [320] (1 ). Failing for 3) - would be good to get another opinion on 1) and 2). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 20:18:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 18:18:00 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 20:48:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 18:48:49 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 --- Comment #9 from Marc V?ron --- Chris, thank you very much for your comment. There is an example for scaling images in PDF Reference: http://wwwimages.adobe.com/www.adobe.com/content/dam/Adobe/en/devnet/pdf/pdfs/pdf_reference_1-7.pdf Page 339, Example 4.72 % = comment ---snip--- q % Save graphics state 1 0 0 1 100 200 cm % Translate 0.7071 0.7071 ?0.7071 0.7071 0 0 cm % Rotate [not yet used in our case, MV] 150 0 0 80 0 0 cm % Scale /Image1 Do % Paint image Q % Restore graphics state ---snip--- - Translate puts the image at a given position - Rotate is not used at in Patroncard.pm (but could be used at a later stage) - Scale (new line in Patroncard.pm) does what it says (it does not shrink the image data, however, it scales it). - The Do operator paints the image using the transformation rules above. Page 206 (Chapter 4.2 Coordinate Systems -> 4.2.2. Common Transformatons) says: ---snip--- If several transformations are combined, the order in which they are applied is significant. For example, first scaling and then translating the x axis is not the same as first translating and then scaling it. In general, to obtain the expected results, transformations should be done in the following order: 1.Translate 2.Rotate 3.Scale or skew ---snip--- On the same page is a figure that shows the big differences in the result if you apply the transformations in different sequences. In our case the issue was that the image was downsampled / shrinked to a very small size (using ImageMagick) before it was applied to the PDF. The resulting image had (in my test case) a height of about 70 units (pixels). The quality was like (or even less) the quality of a thumbnail picture. The PDF viewer then had to scale it up for displaying or printing - that's why it looked so 'pixelated'. If the picture has a height of 350 units (pixels) and is transformed down to 70 while preparing it for the display it, the result is much better, simply because we have more image data available. In short, the steps are: - Prepare a normalized jpg image with a good quality / size using ImageMagick - Position this image on the PDF page (Translate) - (Rotate /chew it if necessary, we don't do it here) - Scale it down to the final display size PS: I can imagine some sophisticatd enhancements as well. For example, it would be nice to have the possibility to put an image as background or to rotate an image etc., with appropriate parameters in the UI. But that would not be in the scope of this Bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 21:24:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 19:24:43 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37526|0 |1 is obsolete| | --- Comment #10 from Chris Nighswonger --- Created attachment 37531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37531&action=edit [SIGNED-OFF] Bug 13954 - Patroncards: images show inadequate rough pixelation This patch provides a much better quality of images on patron cards. It inserts images at a higher resolution into the PDF file and then scales it down internally in PDF. Additionaly, the patch removes the follwing warning: "my" variable $template masks earlier declaration in same scope at /usr/share/kohaclone/patroncards/create-pdf.pl line 66 To test: - Create patron cards, save them as PDF and display them with a PDF viewer, e.g. at 400% - Without patch, the images are very pixelated. - Apply patch - Verify that in the PDF the images now display with a much better quality. Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 21:25:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 19:25:17 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 --- Comment #11 from Chris Nighswonger --- I can't tell you how many times I've looked at that particular part of the spec and completely missed the scale options... thanks for pointing it out. I ran some tests on your patch using some extremely large, compressed jpegs and it works fine on everything I've thrown at it so far. I still have an issue (not too much of one) with the approach to the fix. I'd love to see us rip out the ImageMagick stuff, keep some restrictions on the size of what can be uploaded, and let the scaling be handled during rendering. Its been a while since I worked on all of the affected sections of code, so this might be a big project. With that in mind, I'll drop my objection to this patch (and even sign-off on it) with the condition that a new enhancement request be opened to suggest a more through cleanup of this. Thanks again, Marc. I have never really liked ImageMagick as it always seemed a bit klungy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 21:25:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 19:25:29 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 22:18:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 20:18:52 +0000 Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #64 from Katrin Fischer --- Wow, first comment here from me was over a year ago :( As this is a bigger feature with a longer history, I will leave some longer testing notes for reference: Automated Testing: - OK - QA script passes on current 5 patches - OK - Unit tests, especially all in t/db_dependent/Serial* pass Code Review: - OK - New sub GetPreviousSerialid has unit tests and is used to get the last arrived serial item. - OK - Database changes in updatedatabase and kohastructure are the same. - (1) serials-edit.pl: Patch adds SQL to the .pl script - please move this out of the pl script. - (2) System preference description currently reads: previous serial automatically available when collecting a new serial. Please note that the item-level_itypes syspref must be set to specific item. -- s/collecting/receiving -- s/serial/serial issue (?) -- It would be nice to add a note that this will also enable you to switch the itemtype of the last issue to another item type on receiving a new issue. Testing: - OK Adding subscription (syspref is OFF) -- System preference not active, only item type shows on form -- Item type is saved - Receiving issue and creating an item -- (3) In the item form, the selected itemtype doesn't preselect - OK Editing subscription -- Changes save correctly - Editing subscription (syspref is now ON) -- "Previous item type:" shows up now -- (4) I think the descrption might be misleading - as it's the final and not really the previous item type of the issue. Not sure I can explain that well. Maybe we could use a longer description? --- Item type for newest issue: / Item type for older issues: - OK receiving issues -- This is ok, as the last issue is set to my defined item type, but (3) is still showing as a problem here I have used numbers to mark some problematic bits. Please take a look! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 22:19:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 20:19:43 +0000 Subject: [Koha-bugs] [Bug 13960] New: Patroncards: Code needs some cleanup / enhancement Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13960 Bug ID: 13960 Summary: Patroncards: Code needs some cleanup / enhancement Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Parts of the patron card code needs some clean-up, including - if possible get rid of ImageMagick module - enhanced display options (e.g. background image / rotating images) - more options in UI Some background information can be found in comments to Bug 13954 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 22:20:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 20:20:17 +0000 Subject: [Koha-bugs] [Bug 13960] Patroncards: Code needs some cleanup / enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13954 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 22:20:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 20:20:17 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13960 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 22:58:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 20:58:38 +0000 Subject: [Koha-bugs] [Bug 13949] Item search should have holding library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13949 --- Comment #3 from Katrin Fischer --- comment#2 was meant a possible workaround - not a fix. Just to be clear :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 23:30:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 21:30:24 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer --- Patch fails the QA script: 1) FAIL Koha/Borrower/Import.pm FAIL critic Package declaration must match filename at line 1, column 1. Correct the filename or package statement. OK forbidden patterns OK pod OK valid 2) Patch removes the recently added matching option on userid: - 3) Is the copyright for the new file import_borrowers.pl correct? +# Copyright 2007 Liblime +# Parts copyright 2010 BibLibre +# Parts copyright 2014 ByWater Solutions 4) c is used for csv file here, but as confirm in other scripts. Again... not sure what we finally agreed to, but should we change this and maybe implement a 'confirm'? Can you please fix? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 23:32:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 21:32:51 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 6 23:53:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 21:53:26 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #25 from Liz Rea --- Sorry to cause confusion, it is for the OPAC but he did ask for Staff all those months ago. Maybe I'll do one for the staff client (on another bug) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 00:18:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 22:18:53 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #56 from Katrin Fischer --- Bit confused about the dependencies here - can you give me some pointers? I got libhtml-entities-numbered-perl installed. But I am still missing RDF::Trine. Do I need to install from CPAN? Can it be packaged? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 00:24:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 22:24:17 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #32 from M. Tompsett --- Katrin, you'll note the obsoleted "Add changes to opac.less" file which an be used to build tweaks to the opac.css file which would hide the label. So, I don't think (1) is an issue, except that perhaps the less and corresponding css change shouldn't be obsoleted? CommasWithLinebreaks is EXACTLY what it can be used for. With the appropriate CSS, Linebreaks between the items can be forced. I don't think the name is so far off what it actually is intended to do. So, I don't see an issue with (2). However, you rightly point out (3) is inconsistent. I agree that should be fixed before signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 00:26:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 22:26:20 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #26 from M. Tompsett --- When you do, Liz Rea, please add it to the see also for this bug, so I can look at and sign it off. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 00:48:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 22:48:58 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 00:49:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 22:49:00 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36242|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 37532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37532&action=edit Add check to determine if d.lib exists Add a check to see if d.lib exists, if it does display that value. Otherwise display the authorised value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 00:50:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 22:50:18 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- Rescued Tom's patch. It looks good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 00:50:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 22:50:25 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #57 from H?ctor Eduardo Castro Avalos --- (In reply to Katrin Fischer from comment #56) > Bit confused about the dependencies here - can you give me some pointers? > > I got libhtml-entities-numbered-perl installed. > But I am still missing RDF::Trine. > Do I need to install from CPAN? > Can it be packaged? Hi Katrin The package is librdf-trine-perl but this package exists only in Debian, stable, testing and unstable not in oldstable (squeeze). I don't know if this package can be made in oldstable, maybe Robin or some one else can help us. Another package that is needed is libhtml-parser-perl. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 00:54:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 22:54:21 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #5 from Tom Misilo --- Thanks for fixing the patch! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 01:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 23:31:05 +0000 Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- (In reply to Kyle M Hall from comment #3) > Patch removes quotes. Another possibility would be to escape or encode the > quotes, but I'm not well versed enough with the XSLT to do so. We could register an extension function with XML::LibXSLT, using XML::LibXSLT::register_function(), that allows us to escape or encode quotes. While I think XSLT 2.0 has a uri encoding function, XSLT 1.0 doesn't, so extension functions have to be used. I thought about adding this to the XSLT handler, but it's a global option, so we can just set it after "use XML::LibXSLT" to make the extension function available. (I wonder a bit about the repercussions while using Plack, but I don't yet know enough about Plack to really speculate on that one. I suppose it depends on the scope in which XML::LibXSLT is loaded.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 01:57:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Apr 2015 23:57:36 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 --- Comment #12 from M. Tompsett --- Created attachment 37533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37533&action=edit Bug 4502 - An attempt to make things more sensible. The reason the budget_period_id was not defined was because in two cases it was not passed! This patch adds those missing parameters. And as a result, cuts out the attempt to default the authcat to '' unless the budget_period_id is defined. Additionally, the start and end months don't seem to be passed, so rather than have it blow up, checking them forces the else case logic. budget_period_id is the budget id. If you have two budgets, you can craft a URL to work with budget_period_id matching those two ids. Anything else should trigger the new error which was modified to reflect more of what the problem is. Follow the test plan in comment #6. Feel free to also to attempt crafting URLs and triggering errors. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 02:30:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 00:30:44 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37533|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 37534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37534&action=edit Bug 4502 - An attempt to make things more sensible. The reason the budget_period_id was not defined was because in two cases it was not passed! This patch adds those missing parameters. And as a result, cuts out the attempt to default the authcat to '' unless the budget_period_id is defined. Additionally, the start and end months don't seem to be passed, so rather than have it blow up, checking them forces the else case logic. budget_period_id is the budget id. If you have two budgets, you can craft a URL to work with budget_period_id matching those two ids. Anything else should trigger the new error which was modified to reflect more of what the problem is. Follow the test plan in comment #6. Feel free to also to attempt crafting URLs and triggering errors. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 02:32:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 00:32:46 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #14 from M. Tompsett --- How about these two together, Katrin? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 02:44:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 00:44:21 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 --- Comment #22 from H?ctor Eduardo Castro Avalos --- (In reply to Katrin Fischer from comment #21) > Running into the problem with "term" again - which has 2 different meanings > in German. Any progress on this? translate script with msgctxt must do something like: #: intranet-tmpl/prog/en/modules/serials/member-search.tt:55 #: intranet-tmpl/prog/en/modules/patron_lists/list.tt:142 #: intranet-tmpl/prog/en/modules/members/member.tt:165 #: intranet-tmpl/prog/en/modules/patroncards/members-search.tt:77 msgctxt "Patron card" msgid "Card" msgstr "" ? #: intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt:162 #: intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt:177 #: intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt:150 #: intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt:193 #: intranet-tmpl/prog/en/modules/acqui/z3950_search.tt:172 #: intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:196 #: intranet-tmpl/prog/en/modules/acqui/parcel.tt:289 #: intranet-tmpl/prog/en/modules/acqui/parcel.tt:437 msgctxt "ISBD Card" msgid "Card" msgstr "" All the files containing the word "Card" or "Term" must have useful comments like and then the script must recognize the Disambiguation of contexts. I will try to study a case by case basis, but first i need to know how these scripts work Regards -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 05:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 03:25:14 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #58 from Robin Sheat --- Just running through the dependencies: * HTML::Entities provided by libhtml-parser-perl. 3.66 is in squeeze, the Koha dependencies file specifies 3.69. Does this patch require version 3.69, or will it work with 3.66? * HTML::Entities::Numbered is fine. * RDF::Trine is in as librdf-trine-perl from wheezy and up. In Ubuntu 12.04, only version 0.138 though, and we require 1.000+. I'll have to backport this anyway for squeeze... ...and this won't really work... Depends: libalgorithm-combinatorics-perl but it is not installable Depends: libmoosex-arrayref-perl but it is not installable Depends: libxml-commonns-perl but it is not installable Depends: libxml-namespace-perl but it is not installable Depends: libtrycatch-perl but it is not installable Depends: librdf-query-perl but it is not installable Depends: librdf-rdfa-parser-perl but it is not installable Depends: librdf-trine-node-literal-xml-perl but it is not installable I think there are too many dependencies not in squeeze to make it reasonable to dive down that rabbit hole. However, I really really want to retire support for squeeze (and Ubuntu 12.04) anyway, so I'm going to use this as a chance to start that discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 06:02:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 04:02:01 +0000 Subject: [Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #30 from David Cook --- (In reply to M. de Rooy from comment #27) > > Not sure if other people on other distros will have similar problems. I've just run into this problem today while using OpenSuse 13.2, and I'm pretty sure I ran into this problem in the past as well. The problem is that you're missing the headers for the fribidi library. If you do a "ls /usr/include/fribidi/fribidi.h", I suspect that you'll get nothing. Look for a package like "fribidi-devel" and install that, as that will include the headers that Text::Bidi needs when it's compiling code. You can see some of that in the guts of the Text::Bidi Makefile: http://cpansearch.perl.org/src/KAMENSKY/Text-Bidi-2.09/Makefile.PL I just installed "fribidi" and "fribidi-devel", and now I've managed to install Text::Bidi on OpenSuse 13.2. The building and testing took a long time, so be patient with it, but it should install once you have those fribidi C headers installed :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 08:34:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 06:34:58 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #59 from Katrin Fischer --- Ok, one step further: sudo apt-get install librdf-trine-perl :) As usual I will start with the automated tests. In my test run, I notice that 2 tests in t/db_dependent/Records.t failing: # Failed test 'testing marc2dcxml' # at t/db_dependent/Record.t line 59. # got: undef # expected: ' # # ' # Failed test 'testing marcQualified' # at t/db_dependent/Record.t line 71. # got: undef # expected: ' # # ' # Looks like you failed 2 tests of 11. Can you please check? The QA script points out various uses of given-when - can you please fix by rewriting those parts? FAIL C4/Record.pm OK critic OK forbidden patterns OK pod FAIL valid when is experimental given is experimental FAIL Koha/DublinCoreTransformer.pm OK critic OK forbidden patterns OK pod FAIL valid given is experimental when is experimental FAIL catalogue/export.pl OK critic OK forbidden patterns OK pod FAIL valid when is experimental given is experimental FAIL opac/opac-export.pl OK critic OK forbidden patterns OK pod FAIL valid given is experimental when is experimental -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 09:30:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 07:30:18 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37415|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 37535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37535&action=edit Bug 13936: Last patch contained wrong change One of the 2 changes done in the last patch was not for this bug report. The tt change was intended for bug 13926. This patch reverts it. BE CARE: This should NOT be pushed AFTER bug 13926! Test plan: Search for a patron using the 'check out' tab in the circulation module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 09:48:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 07:48:27 +0000 Subject: [Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break (from bug 13601) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933 --- Comment #9 from Jonathan Druart --- (In reply to Robin Sheat from comment #5) > Cheers, I had a quick look but I couldn't actually see _why_ it was > happening. It's what I tried to explain in the commit description. Before 13601, the C4::Context->preference method was mocked: for all calls, "us" was returned. The patches for 13601 replaced this global mock with a call to t::lib::Mocks::mock_preference, which mocks only the dateformat pref. But somewhere (dt_from_string if I remember correctly) the value for TimeFormat is retrieved. Since it's not mocked, the value in the DB is picked. You know the rest of the story :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 10:08:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 08:08:14 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 10:08:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 08:08:16 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37452|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 37536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37536&action=edit Bug 13934: C4::ItemType->get should return undef if no parameter given The issue: If you try to check in an item with a non existent barcode, the application will exploded with a software error: "Can't bless non-reference at .../ItemType.pm Line 64". It's caused by: commit 7431f8cfe29e330e2232b0df591afc4d923b0a52 Bug 11944: Fix encoding issue in C4::ItemType and the following change: @@ -105,9 +104,6 @@ sub get { my $data = $dbh->selectrow_hashref( "SELECT * FROM itemtypes WHERE itemtype = ?", undef, $itemtype ); - if ( $data->{description} ) { - $data->{description} = Encode::encode('UTF-8', $data->{description}); - } because of the following: my $s; $s->{foo} = "bar" if $s->{foo}; use Data::Dumper;warn Dumper $s; => {} # not undef So later, bless $opts => $class; will fail because $opts is undef and was not (i.e. {}) before. More explicit test plan: 1) Log in to staff client 2) Circulation -> Check in 3) Type a non-existent barcode into 'Enter item barcode:' textbox 4) Click 'Submit' -- Should receive nasty error. 5) apply patch 6) repeat steps 2-4 -- Should be told 'No item with barcode: {what you typed}' 7) prove -v t/ItemType.t -- All tests should run successfully. 7) run koha qa test tools Note: Having tried to create and use an itemtype '0', this only demonstrates a lack of validation on the itemtype creation screen. Unable to use it without tweaking back end. That is beyond the scope of this bug. Note for QA: C4::ItemType->get is only uses in circ/return.pl. So even if the behavior is changed, it should not introduce any regression somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 10:09:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 08:09:12 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 --- Comment #6 from Jonathan Druart --- (In reply to M. Tompsett from comment #2) > Hypothetical question: Could not someone do something crazy like have an > itemtype code of 0? I think this is consistent. The last patch replaced the line return unless $itemtype; with return unless defined $itemtype; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 10:13:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 08:13:46 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 --- Comment #7 from Jonathan Druart --- (In reply to Robin Sheat from comment #5) > Jonathan, if you can give my changes a quick review then that'll be enough > for me to consider it passed QA too. Good for me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 11:11:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 09:11:03 +0000 Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864 --- Comment #13 from Jonathan Druart --- Created attachment 37537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37537&action=edit Bug 13864: Fix height for Colvis entries On the late orders page, the "Show/hide columns" displays the "estimated delivery date" is a litle bit to long and overflows between 2 lines. This patch fixes the height to 100%. Test plan: Go on the late orders page and confirm the "estimeated delivery date" entry is correctly displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 11:12:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 09:12:07 +0000 Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864 --- Comment #14 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > This works nicely for me, but could we improve display for long column > names? The estimated delivery date is not looking nice in the display and I > am a bit worried about our very long German terms. Done in the last patch. Could I get your SO on this one? I would like to avoid create a new bug report for this one line patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 11:25:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 09:25:40 +0000 Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous characters ( e.g. '$' ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37202|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 37538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37538&action=edit Bug 2542: Replace default value "0" with "" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 11:26:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 09:26:33 +0000 Subject: [Koha-bugs] [Bug 2542] Manual invoice fails on superfluous characters ( e.g. '$' ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > Some thoughts on this: > > 1) I think displaying the 0 is not good for ergonomy. I can type 03.00, but > I feel libraries will think they need to delete the 0 first, before typing > in the correct amount. > > 2) Also: with the 0 in the field, you can still accidentally save 0 value > credits and fines easily and the 'required' attribute on the field doesn't > kick in. The default value is now "" > 3) The message is very unspecific. For example, when I enter 'agahgag' it > will just ask me to 'fill out the field' > > Can we have the field empty and have a better error message? Maybe something > like: 'The entered amount is not valid'? Sorry but I did not manage to do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 11:39:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 09:39:11 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #3 from Mason James --- Created attachment 37539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37539&action=edit Bug 13871 - OverDrive message when user authentication fails perltidy build_patron_status() sub -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 11:50:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 09:50:32 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #7 from Jonathan Druart --- Created attachment 37540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37540&action=edit Bug 6520: Display items for staged record - diff view This patchs adds the item information in the diff view. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 12:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 10:13:39 +0000 Subject: [Koha-bugs] [Bug 1387] fgfgffff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1387 --- Comment #1 from Mason James --- Created attachment 37541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37541&action=edit Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha?' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha?' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha?' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 12:17:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 10:17:11 +0000 Subject: [Koha-bugs] [Bug 1387] fgfgffff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1387 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37541|0 |1 is obsolete| | --- Comment #2 from Mason James --- Created attachment 37542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37542&action=edit Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha?' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha?' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha?' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 12:18:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 10:18:41 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37539|0 |1 is obsolete| | --- Comment #4 from Mason James --- Created attachment 37543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37543&action=edit Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha?' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha?' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha?' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' http://bugs.koha-community.org/show_bug.cgi?id=1387 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 12:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 10:20:25 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37539|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 12:30:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 10:30:31 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 12:30:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 10:30:34 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #8 from Jonathan Druart --- Created attachment 37544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37544&action=edit Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 12:33:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 10:33:46 +0000 Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #19 from Katrin Fischer --- I was about to file a bug for the holds calculated expiration date not caring about the calendar (calculate ReservesMaxPickUpDelay in opening days vs. calendar days), but will leave a not here instead. This bug seems to have a wider scope tho. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 12:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 10:39:26 +0000 Subject: [Koha-bugs] [Bug 9071] Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #9 from Jonathan Druart --- Added on http://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_preference and http://wiki.koha-community.org/wiki/Database_updates#updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 12:45:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 10:45:41 +0000 Subject: [Koha-bugs] [Bug 9071] Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 --- Comment #10 from Jonathan Druart --- + http://lists.koha-community.org/pipermail/koha-devel/2015-April/041310.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 13:31:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 11:31:01 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Kyle M Hall --- (In reply to Fridolin SOMERS from comment #5) > (In reply to David Cook from comment #4) > > (In reply to Abby from comment #3) > > > The search cookie is no longer used in master, search history is stored in > > > the database. > > > > > > Have we missed anything? > > > > Interesting! I haven't looked at master recently, so I'm not sure. I wonder > > which commit changed the use of the search cookie... > > I think its not the same thing, user search history is the history of wich > search query he has used. > Bug 11369 concerns the browser used after a search to go to previous or next > result. If that's true, shouldn't my test plan fail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 13:54:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 11:54:05 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 --- Comment #7 from Jonathan Druart --- Ok confirmed, still valid on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 13:55:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 11:55:56 +0000 Subject: [Koha-bugs] [Bug 7178] Improve order item creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8684 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 13:55:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 11:55:56 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7178 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 14:15:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 12:15:51 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Depends on| |11425 --- Comment #8 from Jonathan Druart --- Actually introduced by bug 11425 (pushed after this bug report has been opened, hum...). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 14:15:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 12:15:51 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8684 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 14:23:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 12:23:49 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 --- Comment #9 from Jonathan Druart --- Created attachment 37545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37545&action=edit Bug 8684: Fix duplicate check on creating items in the acquisition module The script acqui/check_uniqueness.pl has been introduced by bug 7178. But bug 11425 added a call to a new subroutine SearchItemsByField in order to refactore some code. This subroutine calls SearchItems with an arrayref, which is not what SearchItems is expecting. This broke the duplicate check done on creating items in the acquisition module. To reproduce the issue: 1/ Fill the pref UniqueItemFields with "barcode" and AcqCreateItem with "placing an order" 2/ Create a new basket 3/ Create a new order 4/ Close the basket 5/ Receive items and set barcode with one already in your DB 6/ Save 7/ Nothing happen on the interface, but an error should have been added in your Koha log file: Can't use an undefined value as an ARRAY reference at /home/koha/src/acqui/check_uniqueness.pl line 48. Test plan: 1/ Repeat steps 1-6 2/ You should see a warning on the interface Note that this should also happen with AcqCreateItem set to "creating an order". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 14:23:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 12:23:46 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 14:24:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 12:24:42 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #70 from Jonathan Druart --- This introduced a regression on checking for duplicate, see bug 8684 for a fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 14:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 12:26:19 +0000 Subject: [Koha-bugs] [Bug 9099] Checked-in barcode export should not send empty file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 14:26:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 12:26:57 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #16 from Blou --- It seems Charles squashed the previous patches that were signed off to create this new one with the extra system preference to answer Galen's second point, as well as rebase I presume. I understand Galen's points, but it seems to me that a simple Recall feature is a good step one. It simnply allows for notices to be sent. It doesn't claim to do more, but it seems certain libraries could already use this. The discussion about holds, shortening loan period, higher fines, who, what... That is a full blown Discussion that should require its own taskId, wiki page, and time. I do not think this should "stop" the current progress. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 15:17:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 13:17:42 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #6 from Katrin Fischer --- Would be great to see this moving. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 15:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 13:30:54 +0000 Subject: [Koha-bugs] [Bug 1232] Add Invoice/Credit/Fines Payed For Day on Issues (Print Page) (Print Slip) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1232 --- Comment #8 from Katrin Fischer --- Would be nice to see this moving - old and still asked for! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 15:37:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 13:37:07 +0000 Subject: [Koha-bugs] [Bug 13961] New: Option to include patron's total amount of fines in notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Bug ID: 13961 Summary: Option to include patron's total amount of fines in notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if we had the option to include information about the patron's total of fines in notices. - overdues (fine per item can be printed, but no total) - checkin - checkout - predue - due -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 15:40:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 13:40:38 +0000 Subject: [Koha-bugs] [Bug 8409] purchase order saying 'Books' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- I am marking this one as resolved. Nicole, please reopen if I am wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 15:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 13:46:03 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Bug 8362 depends on bug 8364, which changed state. Bug 8364 Summary: Inconsistency in hold count http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8364 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 15:46:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 13:46:02 +0000 Subject: [Koha-bugs] [Bug 8364] Inconsistency in hold count In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- This seems to be fixed, please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 15:47:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 13:47:20 +0000 Subject: [Koha-bugs] [Bug 11818] include serial enumeration in the browse shelf function In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11818 giuseppe.angilella at ct.infn.it changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giuseppe.angilella at ct.infn. | |it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 15:56:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 13:56:29 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Kyle M Hall --- (In reply to M. de Rooy from comment #15) > First I set max holds to 5, and I place 4 biblio level holds in opac. OK > Then I select 2 biblios and try again to place a hold in opac on both > (multiplacehold): the first hold is placed, the second is not. > There is no warning. If you would not check the list, you would think that > both holds were placed. > > Before these patches, these six biblio level holds would have been approved. > Although you could consider this as outside the scope of this report, this > report would be the cause of this step back. > > Would you see opportunity for a small fix of this case? > Parking in FQA for now. Yes, I would consider this to be outside the scope of this bug report. This patch makes no changes to the possible return values of CanItemBeReserved so that issue must be separate and distinct from this one. If you file a bug report for this issue and make it depend on this bug report, I'd be more than happy to take a crack a fixing it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:12:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:12:04 +0000 Subject: [Koha-bugs] [Bug 8317] Cursor appears again not in Search box of catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:12:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:12:07 +0000 Subject: [Koha-bugs] [Bug 8317] Cursor appears again not in Search box of catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 --- Comment #2 from Jonathan Druart --- Created attachment 37546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37546&action=edit Bug 8317: Puts focus in search box on page load - OPAC At the OPAC, it would make sense to put the focus in the search box. Test plan: Go at the OPAC and confirm that the focus is automatically put on in the search box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:12:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:12:23 +0000 Subject: [Koha-bugs] [Bug 8317] Cursor appears again not in Search box of catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:21:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:21:22 +0000 Subject: [Koha-bugs] [Bug 8295] patron duplicate message not checking required fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8295 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Looks good to me using master, please confirm. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:23:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:23:48 +0000 Subject: [Koha-bugs] [Bug 7001] User Configurable Slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 Bug 7001 depends on bug 8259, which changed state. Bug 8259 Summary: Library for notices not saving correctly http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8259 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:23:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:23:48 +0000 Subject: [Koha-bugs] [Bug 8259] Library for notices not saving correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED --- Comment #2 from Jonathan Druart --- This should be fixed, please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:25:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:25:44 +0000 Subject: [Koha-bugs] [Bug 8248] Invalid characters entered in bib record cause 500 error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8248 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- Should be fixed, please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:29:40 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 --- Comment #28 from Kyle M Hall --- Created attachment 37547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37547&action=edit Bug 13159 [QA Followup] - Remove unused call to localtime() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:33:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:33:27 +0000 Subject: [Koha-bugs] [Bug 8126] Funkiness with Patrons w/ Most Checkouts Report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13914 CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:33:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:33:27 +0000 Subject: [Koha-bugs] [Bug 13914] The holds statistics report return random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8126 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:33:37 +0000 Subject: [Koha-bugs] [Bug 10188] Top Most-circulated items doesn't count current loans In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13914 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:33:37 +0000 Subject: [Koha-bugs] [Bug 13914] The holds statistics report return random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10188 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:34:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:34:11 +0000 Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The holds statistics report |The holds statistics report |return random data |returns random data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:38:41 +0000 Subject: [Koha-bugs] [Bug 13962] New: Add vendor to new acq tab in staff client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13962 Bug ID: 13962 Summary: Add vendor to new acq tab in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When using AcquisitionDetails a new tab is shown on the staff client detail page that shows order information from the acquisition module. Feedback at our user meeting was, that it would be nice to see the vendor for the orders there as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:39:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:39:50 +0000 Subject: [Koha-bugs] [Bug 8059] local use recorded on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED --- Comment #1 from Jonathan Druart --- Should have been fixed by bug 2546 and bug 12415. Please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:46:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:46:27 +0000 Subject: [Koha-bugs] [Bug 13892] SQLHelper replacement - C4::Members::Search - ysearch.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13957 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:46:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:46:27 +0000 Subject: [Koha-bugs] [Bug 13957] Patron autocomplete shows NULL in list of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13892 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m CC| |jonathan.druart at biblibre.co | |m Status|NEW |ASSIGNED --- Comment #1 from Jonathan Druart --- Introduced by bug 13892. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:48:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:48:45 +0000 Subject: [Koha-bugs] [Bug 13963] New: Date picker/widget always requires to click on a day as last action Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13963 Bug ID: 13963 Summary: Date picker/widget always requires to click on a day as last action Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I know that the date widget is an external library, but I wanted to log this in case there is an easy fix or configuration option: - Select da date in the current month by clicking on the date - The widget closes, the date appears in the field - Notice that you need the same date, but a month earlier - Change the month using the arrows - click somewhere - The date remains as it was before - ... *sigh* ... - Change the month again, click on the day again after picking the right month - Date is changed correctly It would be nice if there was a simple way to just change the date/year with the date widget, without having to select the day again. This has been reported by one of our libraries, but I know the feeling as I keep doing this as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:49:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:49:04 +0000 Subject: [Koha-bugs] [Bug 13957] Patron autocomplete shows NULL in list of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:49:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:49:06 +0000 Subject: [Koha-bugs] [Bug 13957] Patron autocomplete shows NULL in list of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 --- Comment #2 from Jonathan Druart --- Created attachment 37548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37548&action=edit Bug 13957: If not value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 16:50:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 14:50:07 +0000 Subject: [Koha-bugs] [Bug 13957] Patron autocomplete shows NULL in list of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37548|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 37549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37549&action=edit Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 17:06:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 15:06:25 +0000 Subject: [Koha-bugs] [Bug 10388] acq edited items showing 'null's In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 --- Comment #3 from Jonathan Druart --- Created attachment 37550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37550&action=edit Bug 10388: Does not display 'null' after editing an item on receiving After editing an item on receiving, 'null' is displayed if no value is defined for a field. It should be blank. Test plan: 0/ Set AcqCreateItem to 'ordering' 1/ Go on the receipt page page 2/ Edit an item 3/ Does not fill all values 4/ Confirm that undefined values are replaced with an empty string -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 17:06:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 15:06:22 +0000 Subject: [Koha-bugs] [Bug 10388] acq edited items showing 'null's In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 17:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 15:08:06 +0000 Subject: [Koha-bugs] [Bug 10388] acq edited items showing 'null's In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 17:16:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 15:16:54 +0000 Subject: [Koha-bugs] [Bug 8055] reversing fines wonky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8055 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, | |kyle at bywatersolutions.com --- Comment #3 from Jonathan Druart --- I am a bit stuck on this one, I don't find an easy way to fix it without breaking something else... Kyle, could you have a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 17:46:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 15:46:41 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 17:54:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 15:54:31 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 21:20:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 19:20:51 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Barton Chittenden --- Notes for Katrin and/or other QA: Nick Clemens tested this successfully on a clean kohadevbox install; noted that the javascript in my test procedure was missing the closing ");" I have seen issues recently where 'gitify' does not take into account the fact that $KOHA_CONF needs to point to an instance specific version of zebra-biblios-dom.cfg -- it stays pointed to the package version, which has the wrong profilePath. This will cause any changes made to DOM indexes to be ignored... so before testing, you might want to do the following: * grep zebra-biblios-dom.cfg $KOHA_CONF This will show you the path to zebra-biblios-dom.cfg. * grep profilePath [PATH TO zebra-biblios-dom.cfg]/zebra-biblios-dom.cfg If profilePath does not include your git directory (e.g. kohaclone), your tests will fail. Here's an updated test procedure, including the corrected javascript. 1) Apply patch 2) Make sure that you have a bib that has MARC21 035$a (and possibly also 035$z) populated. 3) Rebuild zebra: misc/migration_tools/rebuild_zebra.pl -x -b -z 4) Add the following to the intranetuserjs syspref: $(document).ready(function(){ // Add Other Control Number to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append(''); } }); 5) Do an advanced search, select "Other Control Number" from the search menu, then add the Other Control Number in 035$a for the bib specified in step 1. The advanced search should return that biblio record. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 21:55:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 19:55:33 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock at ccfls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:02:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:02:06 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:02:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:02:10 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37530|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 37551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37551&action=edit [PASSED QA] Bug 12210 - Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated The description of the BakerTaylorBookstoreURL syspref says "Baker and Taylor "My Library Bookstore" links should be accessed at https:// isbn (this should be filled in with something like ocls.mylibrarybookstore.com/MLB/actions/searchHandler.do?nextPage=bookDetails&parentNum=10923&key=). Leave it blank to disable these links." Leaving this syspref blank does not disable the links. Instead, they are populated without the bookstore URL: the cover image for ISBN 1575725738 will cause koha to make a request to http://1575725738, which will, of course, time out. Leaving BakerTaylorBookstoreURL blank should disable any URL that depends on this syspref, as stated in the syspref description. Test Plan: 1) Apply this patch 2) Enable Baker & Taylor cover images, but *not* BakerTaylorBookstoreURL 3) Perform an OPAC search where you have B&T cover images in the results 4) Note the image links now direct you to the record details Signed-off-by: Sheila Kearns Signed-off-by: Katrin Fischer Only affects Baker & Taylor related parts of the code. Read the code carefully, but couldn't test in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:13:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:13:32 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #9 from Katrin Fischer --- Created attachment 37552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37552&action=edit [PASSED QA] Bug 6520: Display items for staged record When records are imported into Koha, the items is stored into the import_items table. This marcxml in this table is never retrieved to display items. Test plan: 1/ Import a records with items 2/ Before importing the batch into the catalog, you can see the marc of the records, in the table below. 3/ Verify that the items is correctly displayed. QA note: This patch does not provide test for new subroutines but the module (C4::ImportBatch) is not tested at all and it will be time consuming to provide them. Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:13:36 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #10 from Katrin Fischer --- Created attachment 37553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37553&action=edit [PASSED QA] Bug 6520: Display items for staged record - diff view This patchs adds the item information in the diff view. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:13:39 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 --- Comment #11 from Katrin Fischer --- Created attachment 37554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37554&action=edit [PASSED QA] Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:13:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:13:57 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:13:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:13:59 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37344|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:14:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:14:01 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37544|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:14:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:14:03 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37540|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:15:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:15:13 +0000 Subject: [Koha-bugs] [Bug 2542] Manual fine/credit fail on superfluous characters ( e.g. '$' ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Manual invoice fails on |Manual fine/credit fail on |superfluous characters ( |superfluous characters ( |e.g. '$' ) |e.g. '$' ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:24:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:24:55 +0000 Subject: [Koha-bugs] [Bug 2542] Manual fine/credit fail on superfluous characters ( e.g. '$' ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:24:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:24:58 +0000 Subject: [Koha-bugs] [Bug 2542] Manual fine/credit fail on superfluous characters ( e.g. '$' ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37166|0 |1 is obsolete| | Attachment #37538|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 37555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37555&action=edit [PASSED QA] Bug 2542: Validate the amount of a manual invoice/create If a manual invoice/credit amount is not correctly set, it should not be accepted. Test plan: Try to create a manual invoice and a manual credit with an amount containing something else than numbers. It should not be possible. Followed test plan. Patch behaves OK, including that negative values are not allowed. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:26:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:26:03 +0000 Subject: [Koha-bugs] [Bug 2542] Manual fine/credit fail on superfluous characters ( e.g. '$' ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542 --- Comment #15 from Katrin Fischer --- This is a good start to prevent empty fine lines and other mistakes - the style is a little off, but I think that's not a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:26:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:26:11 +0000 Subject: [Koha-bugs] [Bug 2542] Manual fine/credit fail on superfluous characters ( e.g. '$' ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542 --- Comment #16 from Katrin Fischer --- Created attachment 37556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37556&action=edit [PASSED QA] Bug 2542: Replace default value "0" with "" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:45:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:45:18 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 --- Comment #12 from Katrin Fischer --- Thx for the screenshots - it made testing this a lot easier. The image quality is greatly improved by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:46:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:46:30 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:46:33 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37531|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 37557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37557&action=edit [PASSED QA] Bug 13954 - Patroncards: images show inadequate rough pixelation This patch provides a much better quality of images on patron cards. It inserts images at a higher resolution into the PDF file and then scales it down internally in PDF. Additionaly, the patch removes the follwing warning: "my" variable $template masks earlier declaration in same scope at /usr/share/kohaclone/patroncards/create-pdf.pl line 66 To test: - Create patron cards, save them as PDF and display them with a PDF viewer, e.g. at 400% - Without patch, the images are very pixelated. - Apply patch - Verify that in the PDF the images now display with a much better quality. Signed-off-by: Chris Nighswonger Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:55:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:55:04 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:55:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:55:16 +0000 Subject: [Koha-bugs] [Bug 13324] The fund values must be based on tax included values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:55:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:55:30 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 22:56:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 20:56:17 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 23:04:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 21:04:14 +0000 Subject: [Koha-bugs] [Bug 13964] New: "Withdrawn" status does not appear in Staff search results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13964 Bug ID: 13964 Summary: "Withdrawn" status does not appear in Staff search results Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: snicker1 at maine.rr.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl After marking an item "withdrawn", that item does not show as withdrawn in the Staff client in a summary list of a keyword search (search.pl). If you click on the title in the Staff client to get details (detail.pl) the status displays properly, as do the summary list and detail pages in the OPAC client (opac-search.pl and opac-detail.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 7 23:14:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 21:14:58 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 00:13:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 22:13:21 +0000 Subject: [Koha-bugs] [Bug 13965] New: date last seen on item search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13965 Bug ID: 13965 Summary: date last seen on item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice to have the date last seen on the item search page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 00:18:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 22:18:36 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #60 from H?ctor Eduardo Castro Avalos --- (In reply to Katrin Fischer from comment #59) Hi Katrin > Ok, one step further: sudo apt-get install librdf-trine-perl :) > > As usual I will start with the automated tests. In my test run, I notice > that 2 tests in t/db_dependent/Records.t failing: > I didn't know about this kind of unit test. But fails because Record.t is coded for the previous output which i've changed in this new patch. As shown below in the chunk of xml tags. Can I change this Unit Test in Record.t to fit with this patch? Give me some positive feedback. > # Failed test 'testing marc2dcxml' > # at t/db_dependent/Record.t line 59. > # got: undef > # expected: ' > # # xmlns="http://example.org/myapp/" > # xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > # xsi:schemaLocation="http://example.org/myapp/ > http://example.org/myapp/schema.xsd" > # xmlns:dc="http://purl.org/dc/elements/1.1/" > # xmlns:dcterms="http://purl.org/dc/terms/"> > # ' > > # Failed test 'testing marcQualified' > # at t/db_dependent/Record.t line 71. > # got: undef > # expected: ' > # # xmlns="http://example.org/myapp/" > # xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" > # xsi:schemaLocation="http://example.org/myapp/ > http://example.org/myapp/schema.xsd" > # xmlns:dc="http://purl.org/dc/elements/1.1/" > # xmlns:dcterms="http://purl.org/dc/terms/"> > # ' > # Looks like you failed 2 tests of 11. > > Can you please check? > > The QA script points out various uses of given-when - can you please fix by > rewriting those parts? > > FAIL C4/Record.pm > OK critic > OK forbidden patterns > OK pod > FAIL valid > when is experimental > given is experimental > > FAIL Koha/DublinCoreTransformer.pm > OK critic > OK forbidden patterns > OK pod > FAIL valid > given is experimental > when is experimental > > FAIL catalogue/export.pl > OK critic > OK forbidden patterns > OK pod > FAIL valid > when is experimental > given is experimental > > FAIL opac/opac-export.pl > OK critic > OK forbidden patterns > OK pod > FAIL valid > given is experimental > when is experimental You're right that kind of code is experimental, I will change this. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 00:20:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Apr 2015 22:20:56 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #61 from Katrin Fischer --- Hi Hector, yes, changing the unit tests should be ok if the new result is the desired one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 04:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 02:00:43 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 04:08:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 02:08:47 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Bob Birchall --- This is running in production for the sponsor, using 3.16.07. It works nicely. I'll sign off, but it may need another sign-off against Master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 08:54:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 06:54:17 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 --- Comment #7 from Josef Moravec --- Created attachment 37558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37558&action=edit [SIGNED-OFF] Bug 13934: C4::ItemType->get should return undef if no parameter given The issue: If you try to check in an item with a non existent barcode, the application will exploded with a software error: "Can't bless non-reference at .../ItemType.pm Line 64". It's caused by: commit 7431f8cfe29e330e2232b0df591afc4d923b0a52 Bug 11944: Fix encoding issue in C4::ItemType and the following change: @@ -105,9 +104,6 @@ sub get { my $data = $dbh->selectrow_hashref( "SELECT * FROM itemtypes WHERE itemtype = ?", undef, $itemtype ); - if ( $data->{description} ) { - $data->{description} = Encode::encode('UTF-8', $data->{description}); - } because of the following: my $s; $s->{foo} = "bar" if $s->{foo}; use Data::Dumper;warn Dumper $s; => {} # not undef So later, bless $opts => $class; will fail because $opts is undef and was not (i.e. {}) before. More explicit test plan: 1) Log in to staff client 2) Circulation -> Check in 3) Type a non-existent barcode into 'Enter item barcode:' textbox 4) Click 'Submit' -- Should receive nasty error. 5) apply patch 6) repeat steps 2-4 -- Should be told 'No item with barcode: {what you typed}' 7) prove -v t/ItemType.t -- All tests should run successfully. 7) run koha qa test tools Note: Having tried to create and use an itemtype '0', this only demonstrates a lack of validation on the itemtype creation screen. Unable to use it without tweaking back end. That is beyond the scope of this bug. Note for QA: C4::ItemType->get is only uses in circ/return.pl. So even if the behavior is changed, it should not introduce any regression somewhere else. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 08:54:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 06:54:29 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 08:54:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 06:54:50 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37536|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 09:11:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 07:11:44 +0000 Subject: [Koha-bugs] [Bug 13966] New: Backport HEA to Koha 3.16 and/or 3.14 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Bug ID: 13966 Summary: Backport HEA to Koha 3.16 and/or 3.14 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org This bug is to track the backport of the HEA feature to Koha 3.16 and/or 3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 09:23:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 07:23:34 +0000 Subject: [Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 --- Comment #1 from Mason James --- Created attachment 37559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37559&action=edit Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14 This trivial patch stops any potential SQL errors/warnings for a HEA enabled 3.16 or 3.14 Koha, when upgrading to a newer Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 09:39:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 07:39:34 +0000 Subject: [Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Mason James --- Once this patch is appears in a future Koha release, the HEA patchset can be added to older Kohas. Note: this patch is not essential for HEA to be backported, as the 'duplicated rows' SQL warnings without this patch are harmless and not fatal - but it would be nice to avoid those warnings, if possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 09:40:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 07:40:53 +0000 Subject: [Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11926 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 09:40:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 07:40:53 +0000 Subject: [Koha-bugs] [Bug 11926] HEA - Report usage statistics to Koha community In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13966 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 09:55:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 07:55:44 +0000 Subject: [Koha-bugs] [Bug 7550] Self checkout should limit display of patron image to logged-in patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- (In reply to Owen Leonard from comment #0) > The patron image display in the self-checkout takes a GET parameter from the > image source, so if someone copied the image location and substituted the > barcode string they could browse through all patron images: > > > > It would offer patrons better privacy to limit that request based on the > currently-logged-in user. It could only work if SelfCheckoutByLogin is set to 'username and password'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:09:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:09:35 +0000 Subject: [Koha-bugs] [Bug 6059] Problem with changing quantity on uncertain prices list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:09:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:09:38 +0000 Subject: [Koha-bugs] [Bug 6059] Problem with changing quantity on uncertain prices list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 --- Comment #4 from Jonathan Druart --- Created attachment 37560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37560&action=edit Bug 6059: Don't permit to change the quantity when items are created on ordering If items are created on ordering, the quantity for uncertain prices should not be editable. Test plan: 0/ Set AcqCreateItem to "on ordering" 1/ Create a basket and add an order with 1+ items 2/ Mark it as uncertain prices 3/ Go on the uncertain prices page for this vendor (acqui/uncertainprice.pl?booksellerid=X) 4/ Confirm you are not allowed to update the quantity 5/ Change the price and save 6/ Confirm the quantity is still correct Set the pref to another value and confirm the behavior has not changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:10:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:10:17 +0000 Subject: [Koha-bugs] [Bug 6059] Problem with changing quantity on uncertain prices list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:16:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:16:49 +0000 Subject: [Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- What's the discussion here? The patch does not apply on 3.14.x nor 3.16.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:30:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:30:01 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:30:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:30:04 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37535|0 |1 is obsolete| | --- Comment #4 from Nicolas Legrand --- Created attachment 37561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37561&action=edit Bug 13936: Last patch contained wrong change One of the 2 changes done in the last patch was not for this bug report. The tt change was intended for bug 13926. This patch reverts it. BE CARE: This should NOT be pushed AFTER bug 13926! Test plan: Search for a patron using the 'check out' tab in the circulation module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:32:39 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37561|0 |1 is obsolete| | --- Comment #5 from Nicolas Legrand --- Created attachment 37562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37562&action=edit Bug 13936: Last patch contained wrong change One of the 2 changes done in the last patch was not for this bug report. The tt change was intended for bug 13926. This patch reverts it. BE CARE: This should NOT be pushed AFTER bug 13926! Test plan: Search for a patron using the 'check out' tab in the circulation module. Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:46:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:46:00 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords| |rel_3_16_candidate Status|Pushed to Master |Pushed to Stable --- Comment #11 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:47:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:47:43 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:49:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:49:27 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 10:50:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 08:50:10 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 --- Comment #12 from Mason James --- (In reply to Mason James from comment #11) > Pushed to 3.16.x, will be in 3.16.10 Fridolyn, you might want this for 3.14.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:11:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:11:49 +0000 Subject: [Koha-bugs] [Bug 6007] Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:11:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:11:52 +0000 Subject: [Koha-bugs] [Bug 6007] Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 --- Comment #4 from Jonathan Druart --- Created attachment 37563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37563&action=edit Bug 6007: Fix MARC framework display when only used tags/subfields The "Display only used tags/subfields" output breaks DataTables and the output is unusable. Test plan: 1/ Go on admin/marctagstructure.pl after you have selected a framework 2/ Check the checkbox 3/ The table should be correctly displayed. Before this patch, the table have 2 lines per tag, now all data are contained into the same line. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:14:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:14:40 +0000 Subject: [Koha-bugs] [Bug 6007] Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|paul.poulain at biblibre.com |jonathan.druart at biblibre.co | |m Severity|normal |major --- Comment #5 from Jonathan Druart --- Since an error appears, I consider this one as major. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:18:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:18:04 +0000 Subject: [Koha-bugs] [Bug 1487] Set only the used fields/subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:18:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:18:07 +0000 Subject: [Koha-bugs] [Bug 1487] Set only the used fields/subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1487 --- Comment #5 from Jonathan Druart --- Created attachment 37564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37564&action=edit Bug 1487: Store the "display only used tags/subf" value in a cookie On the marc framework page, the checkbox to display only used tags/subfields is always unchecked. It should be stored into a cookie to always display the same view. Test plan: 1/ Go on the marc framework page 2/ Check the checkbox 3/ Go somewhere else on the staff interface 4/ Back to the marc framework page, the checkbox should be checked -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:18:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:18:30 +0000 Subject: [Koha-bugs] [Bug 1487] Set only the used fields/subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1487 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain at biblibre.com |jonathan.druart at biblibre.co | |m Hardware|Macintosh |All CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:21:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:21:36 +0000 Subject: [Koha-bugs] [Bug 5998] Error "failed to submit form parsererror" and empty staged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- This should have been fixed. Please reopen if the issue appears again. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:24:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:24:05 +0000 Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37368|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 37565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37565&action=edit [SIGNED-OFF] Bug 13928: Clean up noisy t/Borrower.t tests While testing bug 13882, noisy messages were noticed. Also, Test::Warn was used, but no catching attempts were made. This patch solves that problem. TEST PLAN --------- 1) prove -v t/Borrowers.t -- There should be three noisy lines. 2) apply patch 3) prove -v t/Borrowers.t -- There will be 3 more tests and no noisy lines. 4) Run koha qa test tool -- There should be no issues. NOTE: This will conflict with bug 13882 if either gets pushed to master, but fixing the conflict should be easy enough. Signed-off-by: Josef Moravec Works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:24:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:24:18 +0000 Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:27:37 +0000 Subject: [Koha-bugs] [Bug 13957] Patron autocomplete shows NULL in list of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37549|0 |1 is obsolete| | --- Comment #4 from Nicolas Legrand --- Created attachment 37566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37566&action=edit Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country, address, zipcode, city 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". Signed-off-by: Nicolas Legrand Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:28:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:28:17 +0000 Subject: [Koha-bugs] [Bug 13957] Patron autocomplete shows NULL in list of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:28:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:28:19 +0000 Subject: [Koha-bugs] [Bug 13957] Patron autocomplete shows NULL in list of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37566|0 |1 is obsolete| | --- Comment #5 from Nicolas Legrand --- Created attachment 37567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37567&action=edit Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country, address, zipcode, city 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:51:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:51:47 +0000 Subject: [Koha-bugs] [Bug 9500] GetNormalizedISBN only ever checks the first populated ISBN field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9500 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Could you describe an issue visible on the interface? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 11:55:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 09:55:50 +0000 Subject: [Koha-bugs] [Bug 9482] set library redirects wrong on fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jonathan Druart --- This seems to be fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:19:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:19:21 +0000 Subject: [Koha-bugs] [Bug 6007] Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37563|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 37568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37568&action=edit [SIGNED-OFF] Bug 6007: Fix MARC framework display when only used tags/subfields The "Display only used tags/subfields" output breaks DataTables and the output is unusable. Test plan: 1/ Go on admin/marctagstructure.pl after you have selected a framework 2/ Check the checkbox 3/ The table should be correctly displayed. Before this patch, the table have 2 lines per tag, now all data are contained into the same line. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:19:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:19:39 +0000 Subject: [Koha-bugs] [Bug 6007] Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:28:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:28:33 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:28:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:28:36 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #1 from Jonathan Druart --- Created attachment 37569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37569&action=edit Bug 9472: Order subfields alphabeticaly when cataloging On cataloging a record, the subfields without data were put at the end of the other subfields. This patch orders the subfields alphabeticaly even if they don't containt any data. Test plan: 1/ Edit a record with some subfields without any data => The subfield should not be visible (maybe they are if they are mandatory). 2/ Click on a tag to expand the subfield list. 3/ The subfields should be ordered alphabaticaly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:29:40 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:31:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:31:26 +0000 Subject: [Koha-bugs] [Bug 1487] Set only the used fields/subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1487 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37564|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 37570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37570&action=edit [SIGNED-OFF] Bug 1487: Store the "display only used tags/subf" value in a cookie On the marc framework page, the checkbox to display only used tags/subfields is always unchecked. It should be stored into a cookie to always display the same view. Test plan: 1/ Go on the marc framework page 2/ Check the checkbox 3/ Go somewhere else on the staff interface 4/ Back to the marc framework page, the checkbox should be checked Signed-off-by: Josef Moravec -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:33:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:33:33 +0000 Subject: [Koha-bugs] [Bug 1487] Set only the used fields/subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1487 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37570|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Created attachment 37571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37571&action=edit [SIGNED-OFF] Bug 1487: Store the "display only used tags/subf" value in a cookie On the marc framework page, the checkbox to display only used tags/subfields is always unchecked. It should be stored into a cookie to always display the same view. Test plan: 1/ Go on the marc framework page 2/ Check the checkbox 3/ Go somewhere else on the staff interface 4/ Back to the marc framework page, the checkbox should be checked Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:34:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:34:09 +0000 Subject: [Koha-bugs] [Bug 1487] Set only the used fields/subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1487 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:38:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:38:20 +0000 Subject: [Koha-bugs] [Bug 13967] New: System preferences need a package Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Bug ID: 13967 Summary: System preferences need a package Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org System preferences should have a package based on Koha::Object to remove the need for direct manipulation via SQL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:39:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:39:37 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:39:39 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #1 from Kyle M Hall --- Created attachment 37572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37572&action=edit Bug 13967 - System preferences need a package System preferences should have a package based on Koha::Object to remove the need for direct manipulation via SQL. Test Plan: 1) Apply this patch 2) prove t/db_dependent/sysprefs.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:47:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:47:02 +0000 Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search - circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:47:04 +0000 Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search - circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37362|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 37573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37573&action=edit [SIGNED-OFF] Bug 13926: ake circulation.pl not using C4::Members::Search This patch uses the same method as bug 13894. Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Search for a patron using the checkout tab 2/ The patron list should appear correctly Test with different type of search (returns 0, 1, 1+ results). No behavior changes should be observed. Signed-off-by: Josef Moravec works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:51:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:51:21 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close and confirm reopen JavaScript alerts do not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:51:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:51:24 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close and confirm reopen JavaScript alerts do not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 --- Comment #3 from Jonathan Druart --- Created attachment 37574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37574&action=edit Bug 9333: Remove useless JS code - confirm close basket On closing a basket, the librarian is redirect to a new page for the confirmation, the JavaScript confirmation is useless. This code is never triggered and can be removed. Test plan: Without this patch, confirm you don't get a JavaScript confirmation popup on closing a basket With this patch, confirm you don't get any JavaScript error on closing/reopening a basket. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:51:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:51:57 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close JavaScript alerts is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Summary|Confirm close and confirm |Confirm close JavaScript |reopen JavaScript alerts do |alerts is not used |not work | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:52:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:52:08 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close JavaScript alerts is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:52:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:52:45 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37572|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 37575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37575&action=edit Bug 13967 - System preferences need a package System preferences should have a package based on Koha::Object to remove the need for direct manipulation via SQL. Test Plan: 1) Apply this patch 2) prove t/db_dependent/sysprefs.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:52:48 +0000 Subject: [Koha-bugs] [Bug 9071] Updates adding systempreferences should verify the absence of those preferences prior to attempting to add them In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9071 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9327 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:52:48 +0000 Subject: [Koha-bugs] [Bug 9327] Database update system should provide utility function for adding sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9071 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:54:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:54:05 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37575|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 37576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37576&action=edit Bug 13967 - System preferences need a package System preferences should have a package based on Koha::Object to remove the need for direct manipulation via SQL. Test Plan: 1) Apply this patch 2) prove t/db_dependent/sysprefs.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:56:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:56:50 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11998, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9327 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:56:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:56:50 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13967 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 12:56:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 10:56:50 +0000 Subject: [Koha-bugs] [Bug 9327] Database update system should provide utility function for adding sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13967 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 13:14:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 11:14:35 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #2 from M. de Rooy --- I have only glanced at your solution, but if this is a general sort of all subfields, it is not the right solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 13:19:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 11:19:34 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #3 from Jonathan Druart --- (In reply to M. de Rooy from comment #2) > I have only glanced at your solution, but if this is a general sort of all > subfields, it is not the right solution. Sort of all subfields for a tag, and not for all tags. What is the right solution if this is not the one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 13:26:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 11:26:11 +0000 Subject: [Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Since I suggested to remove the broken pref AddPatronLists in bug 13497, I think the better would be to simply remove the message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 13:29:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 11:29:51 +0000 Subject: [Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13497 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Version|3.8 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 13:29:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 11:29:51 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9314 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 13:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 11:32:02 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #4 from M. de Rooy --- (In reply to Jonathan Druart from comment #3) > Sort of all subfields for a tag, and not for all tags. > What is the right solution if this is not the one? Good question :) I am not aware of UNIMARC specifics here, but in MARC21 there are quite some fields with constructions like this: 100a - 100q - 100d The order should not be alphabetical by default and for all tags. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 13:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 11:40:21 +0000 Subject: [Koha-bugs] [Bug 9327] Database update system should provide utility function for adding sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9327 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 13:41:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 11:41:26 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 13:42:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 11:42:16 +0000 Subject: [Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 13:42:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 11:42:22 +0000 Subject: [Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 --- Comment #3 from Jonathan Druart --- Created attachment 37577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37577&action=edit Bug 9314: Remove useless code related to the type_only parameter Since the pref AddPatronLists has been removed in bug 13497, the code related to type_only and category_type in memberentry.pl is useless. Test plan: Confirm you don't the information message. You can also confirm that the message was wrong and nothing was saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 14:09:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 12:09:56 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #5 from Jonathan Druart --- (In reply to M. de Rooy from comment #4) > (In reply to Jonathan Druart from comment #3) > > Sort of all subfields for a tag, and not for all tags. > > What is the right solution if this is not the one? > > Good question :) > I am not aware of UNIMARC specifics here, but in MARC21 there are quite some > fields with constructions like this: > 100a - 100q - 100d > The order should not be alphabetical by default and for all tags. Yes, I am aware of that. But actually, against master, the display is: all subfields, alphabetically sorted, present in the record followed by: all subfields, alphabetically sorted, non present in the record. (search for foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) ~ l.600-700) This patch just suggests to display all subfields, alphabetically sorted. Which makes more sense. If my dsecription of how it works on master is wrong, my patch is certainly wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 14:34:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 12:34:55 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 --- Comment #21 from Benjamin Rokseth --- Stephen, I was not able to reproduce your issue. Looking at your schema the marcxml row looks ok. Are you able to get a detailed description of the issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 14:49:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 12:49:36 +0000 Subject: [Koha-bugs] [Bug 12344] Multi transport types for issues and checkins In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12344 --- Comment #13 from Benjamin Rokseth --- Ah, I see. It was an old vagrant instance used on the first patch. How do you suggest I change? New patch and obsolete? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 14:51:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 12:51:35 +0000 Subject: [Koha-bugs] [Bug 13968] New: Branch email hints are misleading Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13968 Bug ID: 13968 Summary: Branch email hints are misleading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In the branch settings since bug 9530 you have been able to set separate addresses for From, Reply-To and Return-Path. With Reply-To and Return-Path there is a note, 'if different to Email', which infers that these address will fall back to the content of the 'Email' field. This is not the case, actually they will fall back to the contents of the system settings for those fields, unless those settings have not been filled out either. This note is therefore rather misleading. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 14:51:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 12:51:48 +0000 Subject: [Koha-bugs] [Bug 13968] Branch email hints are misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13968 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 14:53:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 12:53:33 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Kyle, what do u think of Koha::Config::SysPrefs instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:00:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:00:00 +0000 Subject: [Koha-bugs] [Bug 13968] Branch email hints are misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:21:02 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9314 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:21:02 +0000 Subject: [Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13497 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:21:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:21:24 +0000 Subject: [Koha-bugs] [Bug 13969] New: Testing C4::Review Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Bug ID: 13969 Summary: Testing C4::Review Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: julian.fiol at biblibre.com Reporter: julian.fiol at biblibre.com QA Contact: gmcharlt at gmail.com Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:31:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:31:07 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:31:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:31:32 +0000 Subject: [Koha-bugs] [Bug 13970] New: Remove related code to category_type Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 Bug ID: 13970 Summary: Remove related code to category_type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In the member module, some code related to the category_type should be removed. Instead the categorycode should be used, not the category_type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:32:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:32:09 +0000 Subject: [Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13970 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:32:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:32:09 +0000 Subject: [Koha-bugs] [Bug 13970] Remove related code to category_type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9314, 13497 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:32:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:32:09 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13970 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:32:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:32:23 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 --- Comment #6 from Tom?s Cohen Arazi --- Comment on attachment 37454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37454 [PASSED QA] Bug 13940 : Testing C4::OAI::Sets >+#Test to enter in the 'else' case of 'AddOAISet' line 280 >+{ >+ my $dbi_st = Test::MockModule->new('DBI::st', no_auto => 1); # ref($sth) == 'DBI::st' >+ $dbi_st->mock('execute', sub { return 0; }); >+ >+ my $setWrong = { >+ 'spec' => 'specWrong', >+ 'name' => 'nameWrong', >+ }; >+ my $setWrong_id = AddOAISet($setWrong); >+ >+ DelOAISet($setWrong_id); >+} It seems to me that you forgot to actually test behaviour here. You are traversing that branch in the code, but still need to test for: - Side effects (no side effects should be tested if such was the case) - The code raises a warning. It whould be tested with a block like this: my $setWrong_id; warning_is ( $setWrong_id = AddOAISet($setWrong) ) 'AddOAISet failed', 'AddOAISet raises warning in XXX condition'; There's also another warning not being tested. You need to add use Test::Warn; for this purpose. I leave you the task to put the pieces together :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:32:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:32:34 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:35:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:35:32 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #5 from M. Tompsett --- Comment on attachment 37576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37576 Bug 13967 - System preferences need a package Review of attachment 37576: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13967&attachment=37576) ----------------------------------------------------------------- ::: C4/Context.pm @@ +106,5 @@ > use Module::Load::Conditional qw(can_load); > use Carp; > > +use C4::Boolean; > +use C4::Debug; Why move these two lines? ::: Koha/Objects.pm @@ +84,4 @@ > > my $result = $self->_resultset()->find($id); > > + return unless $result; This is a behaviour we want for backward compatibility with preference(), but is this a correction? If so, perhaps this is a separate bug fix, technically? More scope creep? ::: Koha/SysPrefs.pm @@ +28,5 @@ > +use base qw(Koha::Objects); > + > +=head1 NAME > + > +Koha::SysPrefs - Koha Borrower Object set class Cut and paste issues? What does Borrower got to do with anything? ::: t/db_dependent/sysprefs.t @@ +27,4 @@ > $dbh->{RaiseError} = 1; > $dbh->{AutoCommit} = 0; > > +my $opacheader = C4::Context->preference('opacheader'); Good thing this is small. Perl tidying should be a separate patch. @@ +31,4 @@ > my $newopacheader = "newopacheader"; > > +C4::Context->set_preference( 'OPACHEADER', $newopacheader ); > +is( C4::Context->preference('opacheader'), $newopacheader ); This is the better way, in my opinion, to test. ok() with 'eq' type compatisons is asking for trouble. However, if the scope of this bug is to add Koha::SysPref(s), then this is scope creep. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:39:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:39:40 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- (In reply to Tom?s Cohen Arazi from comment #4) > Kyle, what do u think of Koha::Config::SysPrefs instead? Out of curiousity? If logic related to the koha-conf.xml was moved into its own object, would that make it Koha::Config::Config? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:40:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:40:27 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #7 from Tom?s Cohen Arazi --- (In reply to M. Tompsett from comment #6) > (In reply to Tom?s Cohen Arazi from comment #4) > > Kyle, what do u think of Koha::Config::SysPrefs instead? > > Out of curiousity? If logic related to the koha-conf.xml was moved into its > own object, would that make it Koha::Config::Config? Koha::Config sounds more reasonable :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:43:42 +0000 Subject: [Koha-bugs] [Bug 13970] Remove related code to category_type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:43:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:43:45 +0000 Subject: [Koha-bugs] [Bug 13970] Remove related code to category_type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 --- Comment #1 from Jonathan Druart --- Created attachment 37578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37578&action=edit Bug 13970: Remove category_type related code Working on bug 13497 and bug 9314, I run into some Koha vestiges. The category_type parameter should not be passed to memberentry. On creating a new patron, the categorycode should be passed, and on editing, it's useless. We can work with the borrowernumber and retrieve these values. Details of the changes: - members-toolbar.inc: Remove the category_type parameter passed to memberentry.pl - memberentrygen.tt: Just remove the useless category_type parameter on editing a patron. Also remove the unused one passed to guarantor_search.pl. - tables/members_results.tt: the borrowernumber is enough to edit a patron. - memberentry.pl: check_categorytype is never used in the template, all the process to calculate/retrieve it is unnecessary. - members/nl-search.tt: The borrowernumber is enough to edit a patron. Test plan: Try to create and edit patrons and verify that - the guarantor search still work - the form (memberentry) behave as before Edit a patron from the nl-search.pl script (Magnus?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:48:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:48:40 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from M. Tompsett --- (In reply to Tom?s Cohen Arazi from comment #7) > (In reply to M. Tompsett from comment #6) > > (In reply to Tom?s Cohen Arazi from comment #4) > > > Kyle, what do u think of Koha::Config::SysPrefs instead? > > > > Out of curiousity? If logic related to the koha-conf.xml was moved into its > > own object, would that make it Koha::Config::Config? > > Koha::Config sounds more reasonable :-D Since the invocation currently is C4::Context->preference() and C4::Context->config(), I don't see why we would move system preferences to a different level compared to koha-conf.xml values. P.S. Reminder that at least one of my comments in comment #5, needs addressing at least (the Borrower?! one). Changing status accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:54:12 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #9 from Chris Nighswonger --- (In reply to M. Tompsett from comment #8) > Since the invocation currently is C4::Context->preference() and > C4::Context->config(), I don't see why we would move system preferences to a > different level compared to koha-conf.xml values. > Which really raises the questions: What was intended by "Context" and would it be better/desireable at this juncture to separate system preferences (which arguably are a form of configuration) and back-end configuration? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:56:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:56:01 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:58:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:58:36 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:59:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:59:09 +0000 Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring default sort preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 15:59:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 13:59:34 +0000 Subject: [Koha-bugs] [Bug 12210] Baker & Taylor book jackets not disabled when BakerTaylorBookstoreURL is not populated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12210 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:00:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:00:04 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:00:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:00:48 +0000 Subject: [Koha-bugs] [Bug 13850] C4::Ris does not manage correctly 660 and 661 - UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13850 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Good catch Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:01:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:01:25 +0000 Subject: [Koha-bugs] [Bug 13923] Holds tab on the circulation page is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13923 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:01:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:01:49 +0000 Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for patrons - sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:02:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:02:59 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:17:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:17:22 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37576|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 37579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37579&action=edit Bug 13967 - System preferences need a package System preferences should have a package based on Koha::Object to remove the need for direct manipulation via SQL. Test Plan: 1) Apply this patch 2) prove t/db_dependent/sysprefs.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:24:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:24:37 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #11 from Kyle M Hall --- (In reply to M. Tompsett from comment #5) > Comment on attachment 37576 [details] [review] > Bug 13967 - System preferences need a package > > Review of attachment 37576 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Context.pm > @@ +106,5 @@ > > use Module::Load::Conditional qw(can_load); > > use Carp; > > > > +use C4::Boolean; > > +use C4::Debug; > > Why move these two lines? Just to group our internal libraries separately from external ones. I'd say more perl files in Koha due this than not, and I figured I'd do it while I was in there. > > ::: Koha/Objects.pm > @@ +84,4 @@ > > > > my $result = $self->_resultset()->find($id); > > > > + return unless $result; > > This is a behaviour we want for backward compatibility with preference(), > but is this a correction? If so, perhaps this is a separate bug fix, > technically? More scope creep? Yes, I suppose this is a bug fix. I can split it out if you wish. > > ::: Koha/SysPrefs.pm > @@ +28,5 @@ > > +use base qw(Koha::Objects); > > + > > +=head1 NAME > > + > > +Koha::SysPrefs - Koha Borrower Object set class > > Cut and paste issues? What does Borrower got to do with anything? Indeed, I starting with the Borrower objects as templates. Fixed! > > ::: t/db_dependent/sysprefs.t > @@ +27,4 @@ > > $dbh->{RaiseError} = 1; > > $dbh->{AutoCommit} = 0; > > > > +my $opacheader = C4::Context->preference('opacheader'); > > Good thing this is small. Perl tidying should be a separate patch > > @@ +31,4 @@ > > my $newopacheader = "newopacheader"; > > > > +C4::Context->set_preference( 'OPACHEADER', $newopacheader ); > > +is( C4::Context->preference('opacheader'), $newopacheader ); > > This is the better way, in my opinion, to test. ok() with 'eq' type > compatisons is asking for trouble. However, if the scope of this bug is to > add Koha::SysPref(s), then this is scope creep. I can see what you mean, but I did add a unit test as well, and since the syspref unit tests are part and parcel with this, I hope it's not too big a deal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:25:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:25:41 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 --- Comment #2 from Jonathan Druart --- Created attachment 37580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37580&action=edit Bug 9139: New subscription form - Does not check form on the first page The vendor and Record input try to sent the form if the focus is on the inputs (normal behavior). But the form is on 2 pages, and the popup message ask you to fill info on the second page when you are on the first one. This does not make sense. This patch suggests to launch search when the enter key is press on these inputs. Test plan: 1/ Create a new subscription 2/ Put the focus in the Vendor input and press enter: the vendor search popup should appear 3/ Put the focus in the Record input and press enter: the record search popup should appear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:25:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:25:38 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:25:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:25:57 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:27:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:27:52 +0000 Subject: [Koha-bugs] [Bug 13971] New: Adjusted locations in koha-rebuild-zebra for gitified instance Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 Bug ID: 13971 Summary: Adjusted locations in koha-rebuild-zebra for gitified instance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:29:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:29:14 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37579|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 37581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37581&action=edit Bug 13967 - System preferences need a package System preferences should have a package based on Koha::Object to remove the need for direct manipulation via SQL. Test Plan: 1) Apply this patch 2) prove t/db_dependent/sysprefs.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:36:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:36:43 +0000 Subject: [Koha-bugs] [Bug 7480] The Basket manager is always the logged in user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:37:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:37:10 +0000 Subject: [Koha-bugs] [Bug 13380] Auto fill order cancellation reasons from authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13380 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #37 from Tom?s Cohen Arazi --- Followup pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:37:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:37:45 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Abby! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:38:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:38:14 +0000 Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:38:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:38:47 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:55:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:55:39 +0000 Subject: [Koha-bugs] [Bug 13971] Adjusted locations in koha-rebuild-zebra for gitified instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:55:42 +0000 Subject: [Koha-bugs] [Bug 13971] Adjusted locations in koha-rebuild-zebra for gitified instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 --- Comment #1 from M. de Rooy --- Created attachment 37582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37582&action=edit Bug 13971: Adjusted locations in koha-rebuild-zebra for gitified instance This patch adds a few lines to koha-rebuild-zebra in order to adjust the locations for PERL5LIB and rebuild_zebra.pl script. It builds on the notion that /etc/koha/sites/[instance] contains a file called gitified containing the path to the gitified instance (instead of the default /usr/share/koha or other installed default). NOTE: As long as the gitified file does not exist, behavior does not change. I will submit a separate follow-up report for creating the gitified file. Furthermore, I would like to use the Zebra setup from the gitified instance instead of the default files in /etc/koha/zebradb. Will put that in another report too. Test plan: [1] Do not have a file /etc/koha/sites/[instance]/gitified. [2] Run koha-rebuild-zebra -a -b -v [instance] [3] If you have a gitified Koha instance, put the path in that etc file. [4] Run koha-rebuild-zebra -a -b -v [instance] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:58:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:58:24 +0000 Subject: [Koha-bugs] [Bug 13971] Adjusted locations in koha-rebuild-zebra for gitified instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | --- Comment #2 from M. de Rooy --- Would be interested in feedback on this idea (including the mentioned follow-ups in the commit message) from Robin for packages or Chris for gitify! Note that I am just exploring Debian now finally :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 16:59:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 14:59:34 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37581|0 |1 is obsolete| | --- Comment #13 from Chris Nighswonger --- Created attachment 37583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37583&action=edit [SIGNED OFF] Bug 13967 - System preferences need a package System preferences should have a package based on Koha::Object to remove the need for direct manipulation via SQL. Test Plan: 1) Apply this patch 2) prove t/db_dependent/sysprefs.t Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:00:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:00:01 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Chris Nighswonger --- Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:10:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:10:42 +0000 Subject: [Koha-bugs] [Bug 9978] OMNIBUS: update GNU licenses header in Koha files from GPL2 to GPL3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9978 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:10:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:10:46 +0000 Subject: [Koha-bugs] [Bug 9978] OMNIBUS: update GNU licenses header in Koha files from GPL2 to GPL3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9978 --- Comment #1 from Jonathan Druart --- Created attachment 37584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37584&action=edit Bug 9978: Replace license header with the correct license (GPLv3+) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:11:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:11:07 +0000 Subject: [Koha-bugs] [Bug 9978] Update GNU licenses header in Koha files from GPL2 to GPL3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9978 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Summary|OMNIBUS: update GNU |Update GNU licenses header |licenses header in Koha |in Koha files from GPL2 to |files from GPL2 to GPL3 |GPL3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:12:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:12:08 +0000 Subject: [Koha-bugs] [Bug 9978] Update GNU licenses header in Koha files from GPL2 to GPL3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9978 --- Comment #2 from Jonathan Druart --- Created attachment 37585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37585&action=edit Script used to replace perl license_replace.pl `git grep -l 'either version 2 of the License' | xargs` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:13:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:13:43 +0000 Subject: [Koha-bugs] [Bug 13972] New: Serial notification email (RLIST) should include subscriptions and serials tables Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 Bug ID: 13972 Summary: Serial notification email (RLIST) should include subscriptions and serials tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The sample notice RLIST is used for a notification of the patron when a new issue of a serial arrives (independent from the routing list feature). You can subscribe to the notice from the OPAC - subscription tab - more details. The notice currently allows to include fields from branches, biblio, biblioitems and borrowers. It would be very good to also include subscriptions, serials and items so you can print information about which field has arrived into the notice. Related code is here: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Letters.pm;hb=c16e19b3fdff71e20db1df036931d96dfabcce4d#l411 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:18:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:18:52 +0000 Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:19:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:19:07 +0000 Subject: [Koha-bugs] [Bug 9978] Update GNU licenses header in Koha files from GPL2 to GPL3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9978 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37584|0 |1 is obsolete| | --- Comment #3 from Chris Nighswonger --- Created attachment 37587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37587&action=edit [SIGNED OFF] Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:18:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:18:55 +0000 Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37565|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 37586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37586&action=edit Bug 13928: Clean up noisy t/Borrower.t tests While testing bug 13882, noisy messages were noticed. Also, Test::Warn was used, but no catching attempts were made. This patch solves that problem. TEST PLAN --------- 1) prove -v t/Borrowers.t -- There should be three noisy lines. 2) apply patch 3) prove -v t/Borrowers.t -- There will be 3 more tests and no noisy lines. 4) Run koha qa test tool -- There should be no issues. NOTE: This will conflict with bug 13882 if either gets pushed to master, but fixing the conflict should be easy enough. Signed-off-by: Josef Moravec Works as expected Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:19:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:19:26 +0000 Subject: [Koha-bugs] [Bug 9978] Update GNU licenses header in Koha files from GPL2 to GPL3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9978 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |cnighswonger at foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:22:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:22:09 +0000 Subject: [Koha-bugs] [Bug 13507] Add intranet support for CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Feature pushed to master. Thanks Matthias and congrats! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:22:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:22:41 +0000 Subject: [Koha-bugs] [Bug 13928] Noisy t/Borrower tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13928 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! They annoy me too! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:23:27 +0000 Subject: [Koha-bugs] [Bug 13882] Adding new unit tests in t/Borrower.t, testing all 'borrower' database fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13882 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patches pushed to master. Good job Julian! Note: I rebased it on top of bug 13928, no big deal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:24:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:24:00 +0000 Subject: [Koha-bugs] [Bug 11239] show hour of due date in history circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11239 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! We miss you around! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:28:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:28:43 +0000 Subject: [Koha-bugs] [Bug 9678] fields in wrong tab in books framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Nicole, is it still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:31:38 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 --- Comment #15 from Marc V?ron --- Hi Tom?s, Thank you for pushing this one. Is it possible to push Bug 8796 as well? - Would be great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 17:34:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 15:34:35 +0000 Subject: [Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour finesCalendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 19:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 17:42:28 +0000 Subject: [Koha-bugs] [Bug 9978] Update GNU licenses header in Koha files from GPL2 to GPL3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9978 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37587|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 37588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37588&action=edit [SIGNED OFF] Bug 9978: Replace license header with the correct license (GPLv3+) Signed-off-by: Chris Nighswonger Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 19:57:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 17:57:46 +0000 Subject: [Koha-bugs] [Bug 13896] PID is created in /tmp/ instead of in /var/run/koha/... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 37589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37589&action=edit Bug 13896: (QA followup) fix koha-{stop|restart}-zebra too Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 19:59:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 17:59:47 +0000 Subject: [Koha-bugs] [Bug 13896] PID is created in /tmp/ instead of in /var/run/koha/... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Attila! Congratulations for your patch! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:00:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:00:17 +0000 Subject: [Koha-bugs] [Bug 2542] Manual fine/credit fail on superfluous characters ( e.g. '$' ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #17 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:00:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:00:52 +0000 Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:03:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:03:59 +0000 Subject: [Koha-bugs] [Bug 13875] Columns configuration - table name cannot contain underscore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13875 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:08:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:08:38 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #27 from Tom?s Cohen Arazi --- Can someone explain the dependency on 11601 and how it is passed with the other bug ASSIGNED? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:11:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:11:13 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #15 from M. Tompsett --- I was noticing that the test that was added also works in the unpatched master. And on a different note, the whole enable, disable, and clear system preferences cache needs to escape C4::Context as well. This provides a good step in the right direction, even if it is small. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:21:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:21:59 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11601 | --- Comment #28 from Katrin Fischer --- Hm, I think comment#18 - Mark created the less file, so I think that obsoleted the dependency to 11601. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:21:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:21:59 +0000 Subject: [Koha-bugs] [Bug 11601] Bootstrap theme has CSS files that do not have LESS counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11601 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11574 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:26:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:26:06 +0000 Subject: [Koha-bugs] [Bug 13973] New: Z39.50 Client Connection Failed with Z39.50 Servers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13973 Bug ID: 13973 Summary: Z39.50 Client Connection Failed with Z39.50 Servers Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: rizwan.ahmed at 1campusconsulting.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl We are unable to search books using Z39.50 client and always getting an error message "Connection Failed" even if the Z39.50 server credentials are correct. One of Z39.50 server credentials are below for Library of Congress. Hostname: lx2.loc.gov Port: 210 Database: LCDB Encoding: utf8 Syntax: MARC21/USMARC Can you please let us know the possible reasons of this error and how can we fix this issue ? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:26:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:26:37 +0000 Subject: [Koha-bugs] [Bug 13973] Z39.50 Client Connection Failed with Z39.50 Servers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13973 Rizwan changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:27:57 +0000 Subject: [Koha-bugs] [Bug 13973] Z39.50 Client Connection Failed with Z39.50 Servers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Rizwan, is it possible that your firewall is blocking the port 210? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:33:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:33:45 +0000 Subject: [Koha-bugs] [Bug 13973] Z39.50 Client Connection Failed with Z39.50 Servers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13973 --- Comment #2 from Rizwan --- Hi Katrin, Our network team has made some security changes last few weeks ago, I am not sure whether the port 210 is blocked or not. How can we check whether the firewall is blocking port 210 or not ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:35:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:35:36 +0000 Subject: [Koha-bugs] [Bug 13973] Z39.50 Client Connection Failed with Z39.50 Servers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13973 --- Comment #3 from Katrin Fischer --- I think best might be to talk to your network team. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:35:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:35:58 +0000 Subject: [Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574 --- Comment #29 from M. Tompsett --- (In reply to Katrin Fischer from comment #28) > Hm, I think comment#18 - Mark created the less file, so I think that > obsoleted the dependency to 11601. I agree. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:44:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:44:43 +0000 Subject: [Koha-bugs] [Bug 13974] New: Unable to Receive KOHA Noifications via Email Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13974 Bug ID: 13974 Summary: Unable to Receive KOHA Noifications via Email Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: rizwan.ahmed at 1campusconsulting.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We are now unable to receive KOHA notifications via email such as in case of Item Check In, Check Out, Hold, Renewal, Due Reminder etc. This was working fine few weeks ago. We have also verified that the cron jobs are scheduled, earlier we noticed that these jobs were not scheduled because of server restart etc. When we go to "Notices" page it shows notification status is "Sent" but the person do not receive any notification. Would you please let us know the possible reasons of these notifications failures and which settings or steps we need to follow to fix this problem. Appreciate your help in advance. Thanks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:45:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:45:10 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #16 from M. Tompsett --- Comment on attachment 37583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37583 [SIGNED OFF] Bug 13967 - System preferences need a package Review of attachment 37583: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13967&attachment=37583) ----------------------------------------------------------------- Not worth failing over, but after my testing, this is the only issue I can seem to find. ::: t/db_dependent/sysprefs.t @@ -44,3 @@ > ); > > -$dbh->rollback; I know it is automatically done when the script closes, but it would be nice to keep it explicit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:45:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:45:31 +0000 Subject: [Koha-bugs] [Bug 13974] Unable to Receive KOHA Noifications via Email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13974 Rizwan changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:46:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:46:58 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #17 from M. Tompsett --- To clarify, for those who think my comments mean I forgot to change the status: no. I would still consider this signed off and worthy of QA checking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:55:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:55:49 +0000 Subject: [Koha-bugs] [Bug 13974] Unable to Receive KOHA Noifications via Email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Rizwan, I think this is a local problem with your mail setup on the server not a bug in Koha. People can try to help you limit down the problem, but the mailing list is a better place for that. Please also always include the Koha version you are using. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 20:55:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 18:55:56 +0000 Subject: [Koha-bugs] [Bug 13974] Unable to Receive KOHA Noifications via Email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 21:02:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 19:02:18 +0000 Subject: [Koha-bugs] [Bug 13974] Unable to Receive KOHA Noifications via Email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13974 Rizwan changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #2 from Rizwan --- All of these notifications were earlier working fine, which mail settings you are referring ? Please highlight me any steps if I need to verify in KOHA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 21:03:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 19:03:00 +0000 Subject: [Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock at ccfls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 21:11:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 19:11:02 +0000 Subject: [Koha-bugs] [Bug 13974] Unable to Receive KOHA Noifications via Email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13974 --- Comment #3 from Rizwan --- Is there any notification log file which can be further referred to identify the problem ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 21:16:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 19:16:35 +0000 Subject: [Koha-bugs] [Bug 13974] Unable to Receive KOHA Noifications via Email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13974 --- Comment #4 from Rizwan --- Created attachment 37590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37590&action=edit KOHA Notification Status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 21:21:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 19:21:53 +0000 Subject: [Koha-bugs] [Bug 13974] Unable to Receive KOHA Noifications via Email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |INVALID --- Comment #5 from Katrin Fischer --- Please bring this to the mailing list - it's not a problem in Koha's code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 21:43:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 19:43:03 +0000 Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 21:44:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 19:44:58 +0000 Subject: [Koha-bugs] [Bug 13800] Diacritics not mapped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13800 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 21:45:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 19:45:28 +0000 Subject: [Koha-bugs] [Bug 13939] ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13939 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 21:59:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 19:59:18 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #18 from Kyle M Hall --- (In reply to M. Tompsett from comment #16) > Comment on attachment 37583 [details] [review] > [SIGNED OFF] Bug 13967 - System preferences need a package > > Review of attachment 37583 [details] [review]: > ----------------------------------------------------------------- > > Not worth failing over, but after my testing, this is the only issue I can > seem to find. > > ::: t/db_dependent/sysprefs.t > @@ -44,3 @@ > > ); > > > > -$dbh->rollback; > > I know it is automatically done when the script closes, but it would be nice > to keep it explicit. At some point it was generally decided to remove the rollback calls. I don't recall when or where. That being said I have no strong opinion on the matter. We can leave that for QA ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 23:15:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 21:15:01 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37448|0 |1 is obsolete| | --- Comment #32 from Nick Clemens --- Created attachment 37591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37591&action=edit Bug 13382 - RDA: 700/710/711 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span class=separator |. Adds Related and Contained Works as new headings. 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 23:14:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 21:14:56 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 23:37:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 21:37:05 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Nick Clemens --- Okay, fixed what I saw before but noticed new issue: -Multiple relator terms/codes do seem to be showing (only shows first $e/$4 (or $j/$4 for 111) Also a question: Should we display 100$j (Attribution qualifier)? I don't know if I have ever used it, but seems like it should show if present (and all if repeated) I think that is it then, trying to catch all the cases but so many little details to watch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 8 23:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 21:57:42 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org Status|Needs Signoff |Failed QA --- Comment #6 from Nick Clemens --- Looks good in terms of displaying the correct fields, but two issues: 1 - 655 are now showing in both the Subject and Genre/Form Sections, they should only show as Genre/Form 2 - When displaying as Genre/Form the headings are not linked for searching, I think they should still be clickable. This is just my opinion though, willing to concede ts one. (In reply to Winona Salesky from comment #5) > Test Plan: > 1) Apply this patch > 2) Ensure you are using the default XSLT setting for the staff and opac > search results and record details > 3) Find or create a record with MARC tags 655 > 4) Perform an opac search that would show the record in the search results > 5) Note this patch adds field 655 to display. Displays subfields a,v,x,y,z. > uses a vertical bar to separate multiple titles. Vertical bar is wrapped in > span class="separator" for easy suppression/customization of separator. > 6) Repeat steps 4 and 5 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 00:30:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 22:30:05 +0000 Subject: [Koha-bugs] [Bug 13434] 586 XSLT improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36806|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 37592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37592&action=edit [SIGNED OFF] Updated display for 586 in XSLT http://bugs.koha-community.org/show_bug.cgi?id=13434 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 00:30:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 22:30:02 +0000 Subject: [Koha-bugs] [Bug 13434] 586 XSLT improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 00:30:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 22:30:39 +0000 Subject: [Koha-bugs] [Bug 13434] 586 XSLT improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #4 from Nick Clemens --- Separation and display look good so signing off, but I have some questions that I am leaving for QA: 1 - Before this patch the awards displayed in the description tab only on staff-client, and both in detail view and description tab on opac. I am thinking if we are going to display on the details page we should remove from description tab on both staff/opac - maybe out of scope. 2 - indicator 1 is supposed to control generation of display content "Awards:" (display if blank, dont if =8) and it does if all =8, but with multiple fields and a mix of =8 or =# you always get the "Awards:" I don't know if it would be worth splitting them into two display sections based on the indicator or if it isn't a big deal (In reply to Winona Salesky from comment #2) > Test Plan: > 1) Apply this patch > 2) Ensure you are using the default XSLT setting for the staff and opac > search results and record details > 3) Find or create a record with MARC tags 586 > 4) Perform an opac search that would show the record in the search results > 5) Note the fields uses a vertical bar to separate multiple titles. Vertical > bar is wrapped in span class="separator" for easy suppression/customization > of separator. > 6) Repeat steps 4 and 5 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 01:08:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 23:08:07 +0000 Subject: [Koha-bugs] [Bug 13971] Adjusted locations in koha-rebuild-zebra for gitified instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 --- Comment #3 from Robin Sheat --- So, Liz and I were chatting about this just yesterday. What I was thinking was having a library file/function that all the scripts run that exports PERL5LIB into the environment, taking it from, perhaps, koha-conf.xml. Currently koha-conf.xml doesn't really have a facility for a path for this, but adding one wouldn't be a big deal. On the other hand, I like better your more general (and easier to work with programmatically) method of having a file, though I'd be not inclined to call it 'gitify' just because it's useful in other situations too, I'm sure (though I don't know what :) So yeah, like the plan and the approach, just think it should be generalised a bit more using the library stuff we have so it works for other scripts too (_especially_ koha-upgrade-schema.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 01:26:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 23:26:03 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #19 from Robin Sheat --- (In reply to Kyle M Hall from comment #18) > At some point it was generally decided to remove the rollback calls. I don't > recall when or where. This sounds dangerous for plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 01:41:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 Apr 2015 23:41:30 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org Status|Needs Signoff |Failed QA --- Comment #10 from Nick Clemens --- looks good for single fields, but repeated fields 33x or multiple $a in one field need a separator. I think using the same '|' wrapped in a span as similar bugs makes sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 02:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 00:02:03 +0000 Subject: [Koha-bugs] [Bug 8317] Cursor appears again not in Search box of catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 02:02:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 00:02:06 +0000 Subject: [Koha-bugs] [Bug 8317] Cursor appears again not in Search box of catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37546|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 37593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37593&action=edit [SIGNED OFF] Bug 8317: Puts focus in search box on page load - OPAC At the OPAC, it would make sense to put the focus in the search box. Test plan: Go at the OPAC and confirm that the focus is automatically put on in the search box. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 02:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 00:57:38 +0000 Subject: [Koha-bugs] [Bug 4281] reports dictionary limited to only 1 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4281 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 02:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 00:57:42 +0000 Subject: [Koha-bugs] [Bug 4281] reports dictionary limited to only 1 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4281 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37182|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 37594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37594&action=edit [SIGNED OFF]Bug 4281: Reports dictionary supports only 1 field selection The reports dictionary allows the user to select several fields, but only 1 is used. The interface is quite confusing. This patch removes the multiple selection and permit to select only 1 field. Test plan: 1/ Create a report dictionary (reports/dictionary.pl) 2/ On the step 3, confirm that only 1 field can be selected Confirm there is no regression on this tool. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 04:23:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 02:23:02 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m, mtj at kohaaloha.com Keywords| |rel_3_14_candidate, | |rel_3_16_candidate --- Comment #10 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 07:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 05:15:37 +0000 Subject: [Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 --- Comment #4 from Mason James --- (In reply to Jonathan Druart from comment #3) > What's the discussion here? > The patch does not apply on 3.14.x nor 3.16.x. the patch is only to be applied for the master/3.18.x branches it's just to stop any 'duplicate rows' SQL upgrade warnings, when a 3.16/3.14 Koha upgrades to 3.18.x or higher make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 07:47:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 05:47:51 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close JavaScript alerts is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 07:47:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 05:47:54 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close JavaScript alerts is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37574|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 37596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37596&action=edit Bug 9333: Remove useless JS code - confirm close basket On closing a basket, the librarian is redirect to a new page for the confirmation, the JavaScript confirmation is useless. This code is never triggered and can be removed. Test plan: Without this patch, confirm you don't get a JavaScript confirmation popup on closing a basket With this patch, confirm you don't get any JavaScript error on closing/reopening a basket. NOTE: acqui/basket.tt is only used by acqui/basket.pl git grep "confirm_close" | grep -v "\.po:" doesn't show anything else. Reopening only works on basketgroups, not baskets. Unable to trigger any errors as expected and desired. :) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 08:52:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 06:52:16 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #3 from Fr?d?ric Demians --- The second patch doesn't apply: fatal: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). Le d?p?t n'a pas les blobs n?cessaires pour un retour ? une fusion ? 3 points. Impossible de retourner ? une fusion ? 3 points. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 08:53:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 06:53:55 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35444|0 |1 is obsolete| | --- Comment #4 from Fr?d?ric Demians --- Created attachment 37597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37597&action=edit [SIGNED-OFF] Bug 13606: Remove previous job data from the session Bug 11395 uses the session to store the report sent to the interface (update on biblio XX OK, etc.). If the session is stored in mysql, the max size of the sessions.a_session will be reached easily (TEXT field). To reproduce: 0/ Set SessionStorage to 'mysql' 1/ Create a file with 500 biblionumbers: mysql -e "select biblionumber from biblio limit 500;" | tail -n 500 > /tmp/biblionumbers.txt 2/ Define a marc modification template (something like "delete field 99$9" is nice) 3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool 4/ Repeat 3 You will get: Syck parser (line 1534, column 6): syntax error at /usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75. None Koha page is reachable. It comes from get_template_and_user > checkauth > get_session > l.1595 $session = new CGI::Session("driver:MySQL;serializer:yaml;id:md5", $sessionID, {Handle=>$dbh}); 5/ Get your sessionID contained in your CGISESSID cookie Have a look at the value a_session in the sessions table: mysql> select a_session from sessions where id="YOUR_SESSIONID"; You should see that the yaml is not correctly ended. The size of the DB field has been reached and the yaml is truncated. Test plan: 0/ Delete your CGISESSID cookie 1/ Try to reproduce the previous issue 2/ After the second batch, have a look at the sessions table and confirm that only one job_$JOB_ID exist in the yaml Signed-off-by: Frederic Demians I can reproduce de bug. I can see also the useless C4::BackgroundJob session data. I confirm that modifying two consecutive 500 records batches broke entirely the session YAML representation deserialization. And finally I confirm that this patch fixes all those issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 08:59:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 06:59:33 +0000 Subject: [Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour finesCalendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 08:59:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 06:59:36 +0000 Subject: [Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour finesCalendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37374|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 37598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37598&action=edit [SIGNED-OFF] Bug 13909: Suspension days calculation should respect finesCalendar This patch make _debar_user_on_return respect the finesCalendar syspref. It does so, by replacing the ad-hoc overdue days calculation in favor of C4::Overdues::_get_chargeable_units (which is renamed C4::Overdues::get_chargeable_units and exported). There's no behaviour change besides making the calculation simpler and correct. To test: - Set finesCalendar = "directly" - Have a circulation rule stating: interval for calculating fines = 1 suspension days = 3 - Have the calendar set for sunday and saturday as holidays. - Checkout an item with a branch/itype/borrower category that matches the defined circ rule with a hand-writen due date to (say) last friday. - Check the item in => FAIL: Notice that the user is debarred using the calendar (skipping saturday and sunday). - Apply the patch - Repeat the previous steps => SUCCESS: calculation is correct (counting saturday and sunday as overdue days, i.e. 'directly'). - Set finesCalendar = "calendar" - Repeat the test => SUCCESS: calculation is correct (skipping holidays). - Sign off. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 09:28:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 07:28:56 +0000 Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 09:28:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 07:28:59 +0000 Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985 --- Comment #8 from Fr?d?ric Demians --- Created attachment 37599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37599&action=edit [SIGNED-OFF] Bug 10985: [UNIMARC] Fix authority summary The problem is the template in authority type summary is not respected at all. It is only read to see which fields and subfields should appear in the summary. This patch fixes that. It also fixes a bug in auth_finder.pl plugin when summary contains fields other than 2XX. Test plan: 0/ You must use a UNIMARC setup for those tests 1/ edit an authority type summary with: NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*] 2/ create a new authority with previous fields (it is possible some fields don't exist). 3/ search this authority and verify the summary is someting like: NP : Name, D.-- NP -- 23849 ppn: my_ppn 4/ Verify some summary for existing authorities and check they are correct. 5/ Edit a biblio record and use the plugin auth_finder.pl (for example in a 7XX field) 6/ Do a search and verify the summary is correct 7/ Click on 'choose' or one of the numbered links ('1', '2', ... ; you should have multiple 2XX fields for the numbered links to show up) 8/ Verify that the biblio field is correctly filled. /!\ For the ppn, it should be defined in the zebra indexes. In MARC21 and NORMARC setups, this patch should change nothing, please verify that too (you can check that the auth_finder.pl plugin is still working and the auth type summary is correctly displayed in authorities search and auth_finder.pl plugin). Signed-off-by: Frederic Demians It works as described, both in authority search result page, and in authority data entry plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 09:29:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 07:29:36 +0000 Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Attachment #36809|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 09:39:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 07:39:01 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- (In reply to Kyle M Hall from comment #3) > I received the following when I ran the unit tests with an installation > using the sample data: > prove -v t/db_dependent/Accounts.t > t/db_dependent/Accounts.t .. > 1..15 > ok 1 - use C4::Accounts; > ok 2 - use Koha::Object; > ok 3 - use Koha::Borrower; > ok 4 - use Data::Dumper; > ok 5 - C4::Accounts->can(...) > DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign > key constraint fails (`koha_kohaqa`.`issues`, CONSTRAINT `issues_ibfk_1` > FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON > UPDATE CASCADE) at t/db_dependent/Accounts.t line 53. This is because you have issues in your DB, so not the default sample data :) But this needs to be fixed anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 09:51:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 07:51:45 +0000 Subject: [Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #5 from Jonathan Druart --- (In reply to Mason James from comment #4) > (In reply to Jonathan Druart from comment #3) > > What's the discussion here? > > The patch does not apply on 3.14.x nor 3.16.x. > > > the patch is only to be applied for the master/3.18.x branches > > it's just to stop any 'duplicate rows' SQL upgrade warnings, when a > 3.16/3.14 Koha upgrades to 3.18.x or higher > > make sense? Ha yes, sorry. It defenitely makes sense! So needs signoff :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 09:52:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 07:52:45 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37439|0 |1 is obsolete| | --- Comment #5 from Julian FIOL --- Created attachment 37600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37600&action=edit Bug 13942 : Testing the 'recordpayment' function in C4::Accounts for Kyle M Hall : Adding removal of the 'issues' table TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Accounts.t -- All 15 tests should run successfully without any error or warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 09:55:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 07:55:56 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35445|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 37601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37601&action=edit Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT The previous patch fixed partially the problem. If you try to update more that 1000 records, you will get the same error. This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT (32mb). Test plan: 1/ Try to modify a huge amount of records (1000 should be enough) 2/ Confirm it worked! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 09:56:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 07:56:08 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 09:56:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 07:56:50 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #6 from Jonathan Druart --- I am raising the priority of this one, it should absolutely be present in 3.20. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:01:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:01:40 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:02:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:02:20 +0000 Subject: [Koha-bugs] [Bug 9712] Add command line script to recalculate existing due dates based on current issuing rules and retroactively update the issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9712 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:03:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:03:18 +0000 Subject: [Koha-bugs] [Bug 10007] Totals in checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10007 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:03:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:03:48 +0000 Subject: [Koha-bugs] [Bug 11952] utility scripts hard-coded to expect apache, breaks when koha is installed under nginx In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11952 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:04:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:04:00 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #7 from Jonathan Druart --- Actually I am wondering what happens if 2 jobs are launched simultaneously :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:08:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:08:26 +0000 Subject: [Koha-bugs] [Bug 7789] Add translations of item type and authorized value descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7789 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:11:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:11:02 +0000 Subject: [Koha-bugs] [Bug 8579] Need script for updating authority 001s In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8579 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:25:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:25:52 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 --- Comment #7 from Julian FIOL --- Created attachment 37602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37602&action=edit Bug 13940 : Testing C4::OAI::Sets (QA followup) Testing C4::OAI::Sets in t/db_dependent/OAI/Sets.t Adding &DelOAISetsBiblio in @EXPORT at the beginning of OAI/Sets.pm, it was the only one missing To Tom?s Cohen Arazi on comment #6 : Adding tests on the 2 warnings not tested with 'warning_is' like you suggested it. Hope it's good enough :) TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/OAI/Sets.t -- All 145 tests should run successfully without any error or warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:26:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:26:58 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets (QA followup) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Testing C4::OAI::Sets |Testing C4::OAI::Sets (QA | |followup) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:32:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:32:06 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26806|0 |1 is obsolete| | Attachment #26807|0 |1 is obsolete| | Attachment #26808|0 |1 is obsolete| | Attachment #26809|0 |1 is obsolete| | Attachment #26810|0 |1 is obsolete| | Attachment #26811|0 |1 is obsolete| | Attachment #26815|0 |1 is obsolete| | Attachment #26854|0 |1 is obsolete| | Attachment #27613|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart --- Created attachment 37603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37603&action=edit Bug 11759: Batch checkout - prepare the ground This patch does not introduce any changes. It prepares the circulation script to accept several barcodes in parameter. A loop is done on all barcodes (until now, only 1) to generate a structure to sent to the template. At the end, only the first generated data is sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:32:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:32:14 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #36 from Jonathan Druart --- Created attachment 37604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37604&action=edit Bug 11759: Batch checkout - Add the new template This patch is the main patch. It adds: - the new template circ/circulation_batch_checkouts.tt - the change into circ/circulation.pl === Why this feature is useful for some libraries? === Currently Koha does not allow to checkout several items at once to a user. This can cause a waste of time when a user want to checkout more than 10 items. This development has been asked to have statistics on in-house use. Every night, a librarian will enter a barcode list (from a file or a scanner : the librarian scans the barcode of the documents that users let on the tables). Barcodes will be added to a statistics patron in order to count the number of items consulted. The development has been expanded to cover another need: some special libraries (BDP for "Bibliotheque departementale de pret": "Loan Regional Library"). These libraries loan items to smaller libraries (municipal). The number of items could be very important and the current way offered by Koha is not adequate. === Test plan === 0/ Apply all patches and execute the DB change entry. 1/ Verify you are abble to do some checkouts (with confirmations, errors). = Statistics way = 2/ Create a statistical patron (e.g. category code STATS). 3/ Update the batch_checkouts pref with the category code (STATS). 4/ Go on the member page and verify the new "Batch check out" tab appears (and only for this user). 5/ Check some items out on the new page using the textarea or a file. 6/ Verify the table contains the item's information and the "Information" column contains "Local use recorded". = Real checkouts = 7/ Create a non statistical patron and update the pref. 8/ Check some items out on the new page using the textarea or a file. 9/ Verify the information in the table is consistent. 10/ Verify item without confirmation needed or impossible alert is checked out. 11/ If the logged in user has the "force_checkout" permission, all checkouts with a "confirmation needed" message can be done. If the logged in user does not have it, there is no way to force the checkout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:32:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:32:19 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #37 from Jonathan Druart --- Created attachment 37605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37605&action=edit Bug 11759: Add links to the new page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:32:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:32:25 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #38 from Jonathan Druart --- Created attachment 37606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37606&action=edit Bug 11759: Add some css to highlight warnings and errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:32:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:32:30 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #39 from Jonathan Druart --- Created attachment 37607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37607&action=edit Bug 11759: Batch checkout - DB changes Add the new pref batch_checkouts in DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:32:36 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #40 from Jonathan Druart --- Created attachment 37608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37608&action=edit Bug 11759: (follow-up) Some fixes This is a squash of the following patches: Bug 11759: (follow-up) Prevent access to the batch checkout if not allowed If a user pass '&batch=1' to the url, he was allowed to access to the batch checkout page even if the patron is not in an authorised category. This patch also fixes the link to "Batch check out" from the "Details" tab (cf changes in circ-menu.inc). Bug 11759: FIX Javascript error The following JS error occurred: ReferenceError: MSG_ADD_MESSAGE is not defined The circulation.js file is useless and should not be included. Bug 11759: FIX the alert message if an item is on hold. If an item is on hold, the hold is not cancelled. This patch corrects the message displayed in this case. Bug 11759: FIX issue list is empty The issue list is empty after checking an item out to a patron without existing checkout. To reproduce: - Search for a patron without checkout. - Check an item out using the "normal" checkout. - Verify the checkout list contain the checkout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:34:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:34:41 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets (QA followup) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:36:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:36:17 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #41 from Jonathan Druart --- A quick note on this feature: I took a moment to rebase it, I tested it quickly and it seems to work as expected (i.e. as developed initially). This is more or less abandoned on the BibLibre side, so I don't plan to spent time on enhancement request: it should be took as it, or find someone else to do the job. Of course, I am still around for a quick fix if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:36:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:36:26 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 10:43:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 08:43:30 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets (QA followup) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37454|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 11:07:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 09:07:08 +0000 Subject: [Koha-bugs] [Bug 13080] Addition of noEnterSubmit class should not apply to textarea, only to input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS --- Can this be backported to 3.16.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 11:28:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 09:28:52 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 11:28:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 09:28:57 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37603|0 |1 is obsolete| | Attachment #37604|0 |1 is obsolete| | Attachment #37605|0 |1 is obsolete| | Attachment #37606|0 |1 is obsolete| | Attachment #37607|0 |1 is obsolete| | Attachment #37608|0 |1 is obsolete| | --- Comment #42 from Josef Moravec --- Created attachment 37609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37609&action=edit [SIGNED-OFF] Bug 11759: Batch checkout - prepare the ground This patch does not introduce any changes. It prepares the circulation script to accept several barcodes in parameter. A loop is done on all barcodes (until now, only 1) to generate a structure to sent to the template. At the end, only the first generated data is sent. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 11:29:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 09:29:14 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #43 from Josef Moravec --- Created attachment 37610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37610&action=edit [SIGNED-OFF] Bug 11759: Batch checkout - Add the new template This patch is the main patch. It adds: - the new template circ/circulation_batch_checkouts.tt - the change into circ/circulation.pl === Why this feature is useful for some libraries? === Currently Koha does not allow to checkout several items at once to a user. This can cause a waste of time when a user want to checkout more than 10 items. This development has been asked to have statistics on in-house use. Every night, a librarian will enter a barcode list (from a file or a scanner : the librarian scans the barcode of the documents that users let on the tables). Barcodes will be added to a statistics patron in order to count the number of items consulted. The development has been expanded to cover another need: some special libraries (BDP for "Bibliotheque departementale de pret": "Loan Regional Library"). These libraries loan items to smaller libraries (municipal). The number of items could be very important and the current way offered by Koha is not adequate. === Test plan === 0/ Apply all patches and execute the DB change entry. 1/ Verify you are abble to do some checkouts (with confirmations, errors). = Statistics way = 2/ Create a statistical patron (e.g. category code STATS). 3/ Update the batch_checkouts pref with the category code (STATS). 4/ Go on the member page and verify the new "Batch check out" tab appears (and only for this user). 5/ Check some items out on the new page using the textarea or a file. 6/ Verify the table contains the item's information and the "Information" column contains "Local use recorded". = Real checkouts = 7/ Create a non statistical patron and update the pref. 8/ Check some items out on the new page using the textarea or a file. 9/ Verify the information in the table is consistent. 10/ Verify item without confirmation needed or impossible alert is checked out. 11/ If the logged in user has the "force_checkout" permission, all checkouts with a "confirmation needed" message can be done. If the logged in user does not have it, there is no way to force the checkout. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 11:29:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 09:29:24 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #44 from Josef Moravec --- Created attachment 37611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37611&action=edit [SIGNED-OFF] Bug 11759: Add links to the new page Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 11:29:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 09:29:31 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #45 from Josef Moravec --- Created attachment 37612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37612&action=edit [SIGNED-OFF] Bug 11759: Add some css to highlight warnings and errors Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 11:29:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 09:29:41 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #46 from Josef Moravec --- Created attachment 37613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37613&action=edit [SIGNED-OFF] Bug 11759: Batch checkout - DB changes Add the new pref batch_checkouts in DB. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 11:29:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 09:29:51 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #47 from Josef Moravec --- Created attachment 37614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37614&action=edit [SIGNED-OFF] Bug 11759: (follow-up) Some fixes This is a squash of the following patches: Bug 11759: (follow-up) Prevent access to the batch checkout if not allowed If a user pass '&batch=1' to the url, he was allowed to access to the batch checkout page even if the patron is not in an authorised category. This patch also fixes the link to "Batch check out" from the "Details" tab (cf changes in circ-menu.inc). Bug 11759: FIX Javascript error The following JS error occurred: ReferenceError: MSG_ADD_MESSAGE is not defined The circulation.js file is useless and should not be included. Bug 11759: FIX the alert message if an item is on hold. If an item is on hold, the hold is not cancelled. This patch corrects the message displayed in this case. Bug 11759: FIX issue list is empty The issue list is empty after checking an item out to a patron without existing checkout. To reproduce: - Search for a patron without checkout. - Check an item out using the "normal" checkout. - Verify the checkout list contain the checkout. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 11:33:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 09:33:03 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #48 from Josef Moravec --- Thank you Jonathan, I've just test it, and everything seems to work as expected, so I'm signing off. For me it's fine now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 12:12:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 10:12:16 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #110 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #107) > Improvement pushed to master. > > Thanks Paul and Marcel. > Please help me update the wiki to reflect the new workflow. See http://wiki.koha-community.org/wiki/Database_updates#updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 12:16:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 10:16:45 +0000 Subject: [Koha-bugs] [Bug 13068] New feature for DB update and sandbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #111 from Jonathan Druart --- Tomas, it would be good to have a test somewhere to be sure a release (stable or master) does not have anything in the atomicupdate directory. Do you launch some tests before pushing into master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 12:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 10:33:22 +0000 Subject: [Koha-bugs] [Bug 10165] Trying to clear reading history when AnonymousPatron unset and DEBUG is on causes fatal error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10165 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- This means you run the OPAC with DEBUG set and enabled a feature without configuring it :) IMO this is not valid. Note that the error is correctly handled if DEBUG is off. Please reopen if you disagree. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 12:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 10:33:22 +0000 Subject: [Koha-bugs] [Bug 9944] cleanborrowers.pl does not check for anonymisation errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9944 Bug 9944 depends on bug 10165, which changed state. Bug 10165 Summary: Trying to clear reading history when AnonymousPatron unset and DEBUG is on causes fatal error http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10165 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 12:34:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 10:34:12 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #1 from Julian FIOL --- Created attachment 37615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37615&action=edit Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 12:34:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 10:34:36 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 12:42:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 10:42:47 +0000 Subject: [Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 --- Comment #4 from Rolando Isidoro --- Jonathan, following your comments I can confirm that the information message is no longer displayed so this bug report is deprecated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 13:16:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 11:16:52 +0000 Subject: [Koha-bugs] [Bug 13971] Adjusted locations in koha-rebuild-zebra for gitified instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37582|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 37616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37616&action=edit Bug 13971: Adjusted locations in koha-rebuild-zebra for gitified instance This patch adds a few lines to koha-rebuild-zebra in order to adjust the locations for PERL5LIB and rebuild_zebra.pl script. It also adds two functions to koha-functions: is_gitified and get_perl5lib. It builds on the notion that koha-conf.xml contains a tag for gitified installs. It also looks for a perl5lib tag in koha-conf. NOTE: If the gitified or the perl5lib tag does not exist, behavior does not change. I will submit a separate follow-up report for adding those tags. The use of function get_perl5lib can replace hardcoded paths in the other scripts too; I will also move that to a new report. Furthermore, I would like to use the Zebra setup from the gitified instance instead of the default files in /etc/koha/zebradb. Will put that in another report too. Test plan: [1] Verify that your koha-conf does not contain: 1 [2] Run koha-rebuild-zebra -a -b -v [instance] [3] If you have a gitified instance, add the gitified tag to your koha-conf and the path in a perl5lib tag. [4] Run koha-rebuild-zebra -a -b -v [instance] Verify that you run the right version of rebuild_zebra.pl. You could do that by adding a simple debug print. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 13:21:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 11:21:06 +0000 Subject: [Koha-bugs] [Bug 13971] Adjusted locations in koha-rebuild-zebra for gitified instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 --- Comment #5 from M. de Rooy --- (In reply to Robin Sheat from comment #3) > So, Liz and I were chatting about this just yesterday. What I was thinking > was having a library file/function that all the scripts run that exports > PERL5LIB into the environment, taking it from, perhaps, koha-conf.xml. > > Currently koha-conf.xml doesn't really have a facility for a path for this, > but adding one wouldn't be a big deal. > > On the other hand, I like better your more general (and easier to work with > programmatically) method of having a file, though I'd be not inclined to > call it 'gitify' just because it's useful in other situations too, I'm sure > (though I don't know what :) > > So yeah, like the plan and the approach, just think it should be generalised > a bit more using the library stuff we have so it works for other scripts too > (_especially_ koha-upgrade-schema.) Thanks. Submitted an adjusted patch for those two actually separate things: 1) get a path from koha-conf with get_perl5lib 2) get gitified status from koha-conf too with is_gitified (no longer a file) So two new functions in koha-functions. Please look too at the scriptdir lines in koha-rebuild-zebra at the start. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 14:01:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 12:01:37 +0000 Subject: [Koha-bugs] [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 --- Comment #1 from Jonathan Druart --- Created attachment 37617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37617&action=edit Bug 9942: Make Koha fails if privacy is not respected If a patron has requested anonymity on returning items and the system is not correctly configured (AnonymousPatron no set or set to an inexistent patron), the application should take it into account and not fail quietly. This patch is quite radical: the script will die loudly if the privacy is not respected. To be care of the bad "Software error", some checks are done in the updatedatabase to be sure the admin will be warned is something is wrong in the configuration. Test plan: 1/ Test the updatedatabase entry: a. Turn on OPACPrivacy and set AnonymousPatron to an existing patron => You will get a warning b. Turn on OPACPrivacy and set AnonymousPatron to 0 or '' => You will get a warning c. Turn on OPACPrivacy and set the privacy to 2 (Never) for at least 1 patron Turn off OPACPrivacy => You will get a warning d. In all other cases you will get no error 2/ Test the interface a. Turn on OPACPrivacy and set the privacy to 2 (Never) for a patron b. Now you can turn off OPACPrivacy or keep it on, behavior should be the same c. check an item out the patron d. Check the item in using the check out table => fail e. Check the item in using the Check in tab => fail (not gracefully). Note that the software error could appear on other pages too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 14:01:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 12:01:34 +0000 Subject: [Koha-bugs] [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 14:01:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 12:01:56 +0000 Subject: [Koha-bugs] [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|peterAtKohaBugzilla at pck.co. |jonathan.druart at biblibre.co |nz |m Severity|critical |major Version|3.12 |master CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 14:02:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 12:02:27 +0000 Subject: [Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 --- Comment #5 from Jonathan Druart --- Rolando, without the path I submitted on comment 3, the message can longer appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 14:27:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 12:27:53 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- How does http://wiki.koha-community.org/w/images/Export_RDA.csv fit into this? (See http://wiki.koha-community.org/wiki/MARC_frameworks) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 14:42:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 12:42:22 +0000 Subject: [Koha-bugs] [Bug 8317] Cursor appears again not in Search box of catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 --- Comment #4 from Owen Leonard --- I'm concerned about how this affects the user in situations like this: - Page starts loading - Patron sees search results begin to display - Patron scrolls down through results - DOM ready event fires, focus is transferred to the search box - The page scrolls back to the top and the patron loses their place -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:31:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:31:22 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37615|0 |1 is obsolete| | --- Comment #2 from Julian FIOL --- Created attachment 37618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37618&action=edit Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod : 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% Pod : 100,0% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:33:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:33:43 +0000 Subject: [Koha-bugs] [Bug 8317] Cursor appears again not in Search box of catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #5 from Jonathan Druart --- Agreed, but I don't have another solution to suggest :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:40:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:40:58 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #15 from Tom?s Cohen Arazi --- Please rebase so I push it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:42:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:42:58 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Testing C4::OAI::Sets (QA |Testing C4::OAI::Sets |followup) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:50:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:50:58 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 --- Comment #8 from Tom?s Cohen Arazi --- Maybe I wasn't clear enough. Sorry: The regular workflow when we ask for QA followups is to leave the currently testted patch as-is (with its signoffs, for instance) and provide a "new" patch to be applied on top of the original one. *That* new patch should have "(QA followup)" on its subject. Take a look at bug 13075 for example. You'll see an original bug, and a followup (this time made by me). So, I suggest you obsolete the new one, de-obsolete de passed-qa one, and provide just a small followup with the last changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:51:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:51:30 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37454|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:51:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:51:44 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37602|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:53:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:53:36 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:53:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:53:40 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 --- Comment #3 from Jonathan Druart --- Created attachment 37619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37619&action=edit Bug 9892: MAke export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:53:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:53:52 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:53:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:53:59 +0000 Subject: [Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 15:57:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 13:57:04 +0000 Subject: [Koha-bugs] [Bug 8317] Cursor appears again not in Search box of catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 --- Comment #6 from Owen Leonard --- > Agreed, but I don't have another solution to suggest :) The alternative is to do nothing, which in my opinion is the right thing to do. The question is: Is an OPAC more like Google.com, where searching is the what everyone arriving at the page intends to do? Or is the OPAC more like Amazon.com where searching is something users are likely to do but they might also be taking other paths to access content. I think the analogy might be different for different libraries, but I suspect Amazon is more often the correct analogue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:01:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:01:34 +0000 Subject: [Koha-bugs] [Bug 13975] New: Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13975 Bug ID: 13975 Summary: Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org % perl -wc misc/export_borrowers.pl Use of the encoding pragma is deprecated at misc/export_borrowers.pl line 29. misc/export_borrowers.pl syntax OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:12:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:12:16 +0000 Subject: [Koha-bugs] [Bug 13975] Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:12:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:12:22 +0000 Subject: [Koha-bugs] [Bug 13975] Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13975 --- Comment #1 from Jonathan Druart --- Created attachment 37620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37620&action=edit Bug 13975: Remove compilation warning about encoding pragma deprecation Test plan: 0/ Does not apply the patch 1/ Launch the export_borrowers.pl script to export data with unicode characters % perl misc/export_borrowers.pl -w "borrowernumber=42" --field borrowernumber --field surname --field firstname Use of the encoding pragma is deprecated at misc/export_borrowers.pl 7874,JOUBU,?????? 2/ Apply this patch 3/ Repeat 1 % perl misc/export_borrowers.pl -w "borrowernumber=42" --field borrowernumber --field surname --field firstname 7874,JOUBU,?????? Note that the deprecated message is gone and the encoding is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:15:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:15:24 +0000 Subject: [Koha-bugs] [Bug 8317] Cursor appears again not in Search box of catalogue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #7 from Jonathan Druart --- Owen, I am ok with you. The patch is here if someone wants it. I am marking this bug report as invalid. Thanks for the feedback! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:15:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:15:31 +0000 Subject: [Koha-bugs] [Bug 13849] Introduce acceptance tests with cucumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36942|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:16:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:16:07 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37601|0 |1 is obsolete| | --- Comment #8 from Fr?d?ric Demians --- Created attachment 37621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37621&action=edit Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT The previous patch fixed partially the problem. If you try to update more that 1000 records, you will get the same error. This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT (32mb). Test plan: 1/ Try to modify a huge amount of records (1000 should be enough) 2/ Confirm it worked! Signed-off-by: Frederic Demians I confirm that with more than 1000 records the session object is truncated, and then can't be anymore be desirialized, blocking completely Koha. Fixed with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:16:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:16:38 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:17:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:17:30 +0000 Subject: [Koha-bugs] [Bug 13849] Introduce acceptance tests with cucumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 37622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37622&action=edit Example Cucumber tests for the overdues rewrite Having written a new overdue gathering and sending module and using Cucumber tests, here are the test features I used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:19:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:19:04 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #9 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #7) > Actually I am wondering what happens if 2 jobs are launched simultaneously > :-/ Good question! Above ~1000 records, the processing time is long, and the UI feedback is not that good. So users could be tempted to refresh the page. It may be advisable to limit processing to let say 1000 records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:25:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:25:48 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:25:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:25:52 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 --- Comment #2 from Jonathan Druart --- Created attachment 37623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37623&action=edit Bug 9878: Add consistentcy on restriction messages Between both pages circ/circulation.pl and members/moremember.pl, the restriction messages should be the same. Test plan: 1/ Add a non-unlimited restrictions to a patron 2/ Go on both pages and confirm the restriction message is the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:26:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:26:40 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:29:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:29:34 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 --- Comment #9 from Julian FIOL --- Created attachment 37624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37624&action=edit Bug 13940 : (QA followup) Add tests for the 2 warnings which was not tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:36:24 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #10 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #9) > (In reply to Jonathan Druart from comment #7) > > Actually I am wondering what happens if 2 jobs are launched simultaneously > > :-/ > > Good question! Above ~1000 records, the processing time is long, and the UI > feedback is not that good. So users could be tempted to refresh the page. It > may be advisable to limit processing to let say 1000 records. I would be tempt to only keep the DB changes, not the first patch. I did not try, but if several jobs are launched (any jobs using the BackgroundJob module), the last one will erase data from previous ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:37:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:37:53 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #11 from Jonathan Druart --- The first patch should be improved to only delete data from finished jobs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 16:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 14:54:33 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 --- Comment #10 from Julian FIOL --- Created attachment 37625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37625&action=edit Bug 13940 : (QA followup) Add test for ModOAISet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:04:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:04:26 +0000 Subject: [Koha-bugs] [Bug 13976] New: Sorting search results by popularity is alphabetical Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Bug ID: 13976 Summary: Sorting search results by popularity is alphabetical Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org After performing a search, sorting by popularity is an alphabetical sort instead of a numerical. For example, sorting the values of totalissues 5, 7, 9, 66, 85, 91, 808 will give : 91->9->85->808->7->66->5 The Zebra configuration is the default UNIMARC with : melm 942$0 totalissues:n,totalissues:s I've looked into doc of http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#sort%28%29 It seems there is no option for numerical sort. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:04:35 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:06:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:06:40 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12995 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:06:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:06:40 +0000 Subject: [Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13976 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:19:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:19:10 +0000 Subject: [Koha-bugs] [Bug 13977] New: Option to give shorter ReservesMaxPickUpDelay for patrons with e-mail address Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13977 Bug ID: 13977 Summary: Option to give shorter ReservesMaxPickUpDelay for patrons with e-mail address Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com A secondary ReservesMaxPickUpDelay preference for patrons with e-mail addresses would be nice. We set this setting to 7 days to allow for the speed of regular mail, but it would be great to set it to 3 for those with e-mail, like we do for our OverDrive users. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:19:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:19:37 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #11 from Winona Salesky --- Okay, I will take a look. Thanks. -Winona (In reply to Nick Clemens from comment #10) > looks good for single fields, but repeated fields 33x or multiple $a in one > field need a separator. > > I think using the same '|' wrapped in a span as similar bugs makes sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:20:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:20:30 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 --- Comment #7 from Winona Salesky --- Thanks Nick, I will take a look and fix these two issues. -Winona (In reply to Nick Clemens from comment #6) > Looks good in terms of displaying the correct fields, but two issues: > > 1 - 655 are now showing in both the Subject and Genre/Form Sections, they > should only show as Genre/Form > > 2 - When displaying as Genre/Form the headings are not linked for searching, > I think they should still be clickable. This is just my opinion though, > willing to concede ts one. > > (In reply to Winona Salesky from comment #5) > > Test Plan: > > 1) Apply this patch > > 2) Ensure you are using the default XSLT setting for the staff and opac > > search results and record details > > 3) Find or create a record with MARC tags 655 > > 4) Perform an opac search that would show the record in the search results > > 5) Note this patch adds field 655 to display. Displays subfields a,v,x,y,z. > > uses a vertical bar to separate multiple titles. Vertical bar is wrapped in > > span class="separator" for easy suppression/customization of separator. > > 6) Repeat steps 4 and 5 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:21:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:21:00 +0000 Subject: [Koha-bugs] [Bug 13978] New: Hold notification e-mails Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13978 Bug ID: 13978 Summary: Hold notification e-mails Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be great if hold notification e-mails could include a button to click if a patron doesn't need the item any longer. They could click the button to cancel the hold and notify the holding library. All without logging into their account. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:29:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:29:30 +0000 Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in ISSUESLIP and ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:40:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:40:15 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- I wonder which one it maps to: http://www.indexdata.com/yaz/doc/zoom.query.html#zoom-sort-strategy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:42:40 +0000 Subject: [Koha-bugs] [Bug 13827] stuck on offline screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13827 Randy Catlin changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:45:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:45:24 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 --- Comment #2 from M. Tompsett --- http://www.indexdata.com/yaz/doc/zoom.resultsets.html#zoom.z3950.resultset.sort http://www.indexdata.com/yaz/doc/yaz-client.html#sortspec Hmmm... There is a problem, isn't there? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:57:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:57:33 +0000 Subject: [Koha-bugs] [Bug 11496] The number of tested records when searching for duplicates during import is too low In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:57:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:57:35 +0000 Subject: [Koha-bugs] [Bug 11496] The number of tested records when searching for duplicates during import is too low In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24006|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 37626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37626&action=edit Bug 11496: Raise number of tested records when searching for duplicate during import. - Previously, only the first 10 records returned by koha for a given matchpoint were tested. This is not enough in many cases, because a significant matching record can be beyond these 10 first results. This patch raise the search to 1000 records, for more accurate, but slower results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 17:58:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 15:58:17 +0000 Subject: [Koha-bugs] [Bug 11496] The number of tested records when searching for duplicates during import is too low In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496 --- Comment #5 from M. Tompsett --- Rescued this from a 'Patch Does Not Apply' situation. Also, please provide a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 18:05:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 16:05:29 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37597|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 37627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37627&action=edit Bug 13606: Remove previous job data from the session -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 18:05:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 16:05:26 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 18:09:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 16:09:05 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset at hotmail.com --- Comment #27 from M. Tompsett --- Please put the css files (because they are minified) in a seperate patch, so the person testing, can skip and rebuild them easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 18:09:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 16:09:10 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) > The first patch should be improved to only delete data from finished jobs. Frederic, I rewrote my first patch. The job entries in the session are now deleted when a new job is created. It looks better like that and we should not get issue with simultaneous jobs. Could you confirm the progress bar is broken, even on the items modification tool? I tried with an old version of the code, and same issue. Not sure if it comes from me or if it's an issue... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 18:34:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 16:34:28 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #16 from Marc V?ron --- Created attachment 37628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37628&action=edit Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec Works as expected Signed-off-by: Katrin Fischer Rebased to apply on master / MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 18:36:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 16:36:11 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37628|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Comment on attachment 37628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37628 Bug 8796 - patron cards not starting on designated card Did a mistake while rebasing. Obsoleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 18:42:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 16:42:20 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #18 from Marc V?ron --- Created attachment 37629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37629&action=edit Bug 8796 - patron cards not starting on designated card The patron cards always printed from position 1 on the print form, because patroncards/create-pdf.pl expected start_label as parameter and got star_card instead. To verify and test: 1) Go to Home > Tools >Patron card creator >Manage batches 2) Select a batch anc click "Export" 3) Set "Enter starting card number" e.g. to 5 4) Export 5) Download PDF and view it Result: The first card is always printed on position 1 (top left) instead of position 5. Apply patch Repeat steps above Step 3) should now read "Enter starting card position" Result after step 5) The first card ist printed at the correct position on the printing form. Signed-off-by: Josef Moravec Works as expected Signed-off-by: Katrin Fischer Rebased for current master and tested. /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 18:45:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 16:45:24 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #19 from Marc V?ron --- I hope it's OK to put it back to Passed QA after rebase (1 line). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 18:45:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 16:45:49 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 18:59:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 16:59:13 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #14 from M. Tompsett --- Why is there no "Started: 2015-04-09 12:58:00" type value in the job session information? You could easily also delete anything that is more than 24 hours old, if there was a way to determine it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 19:13:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 17:13:52 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #20 from Tom?s Cohen Arazi --- (In reply to Marc V?ron from comment #19) > I hope it's OK to put it back to Passed QA after rebase (1 line). It is! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 19:53:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 17:53:18 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37558|0 |1 is obsolete| | --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 37630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37630&action=edit [SIGNED OFF] Bug 13934: C4::ItemType->get should return undef if no parameter given The issue: If you try to check in an item with a non existent barcode, the application will exploded with a software error: "Can't bless non-reference at .../ItemType.pm Line 64". It's caused by: commit 7431f8cfe29e330e2232b0df591afc4d923b0a52 Bug 11944: Fix encoding issue in C4::ItemType and the following change: @@ -105,9 +104,6 @@ sub get { my $data = $dbh->selectrow_hashref( "SELECT * FROM itemtypes WHERE itemtype = ?", undef, $itemtype ); - if ( $data->{description} ) { - $data->{description} = Encode::encode('UTF-8', $data->{description}); - } because of the following: my $s; $s->{foo} = "bar" if $s->{foo}; use Data::Dumper;warn Dumper $s; => {} # not undef So later, bless $opts => $class; will fail because $opts is undef and was not (i.e. {}) before. More explicit test plan: 1) Log in to staff client 2) Circulation -> Check in 3) Type a non-existent barcode into 'Enter item barcode:' textbox 4) Click 'Submit' -- Should receive nasty error. 5) apply patch 6) repeat steps 2-4 -- Should be told 'No item with barcode: {what you typed}' 7) prove -v t/ItemType.t -- All tests should run successfully. 7) run koha qa test tools Note: Having tried to create and use an itemtype '0', this only demonstrates a lack of validation on the itemtype creation screen. Unable to use it without tweaking back end. That is beyond the scope of this bug. Note for QA: C4::ItemType->get is only uses in circ/return.pl. So even if the behavior is changed, it should not introduce any regression somewhere else. Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Works as expected. Fixes the problem and no regressions found. It even has regression tests :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 19:56:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 17:56:15 +0000 Subject: [Koha-bugs] [Bug 13940] Testing C4::OAI::Sets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13940 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. Good job Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 19:57:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 17:57:49 +0000 Subject: [Koha-bugs] [Bug 13166] add all restrictions purge to cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13166 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 19:58:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 17:58:36 +0000 Subject: [Koha-bugs] [Bug 13611] Serial enumeration not visible in the opac-user.pl when browsing own holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13611 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Olli! Note: if there are warnings in the opac because of this you have to fix it, on a separate bug :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 19:59:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 17:59:39 +0000 Subject: [Koha-bugs] [Bug 13349] Allow library code to display against users pending changes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13349 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 20:00:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 18:00:21 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 20:33:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 18:33:26 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 21:08:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 19:08:43 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #15 from M. Tompsett --- Also, perhaps a 'LastTouched: 2015-04-09 15:07:00' type entry would be useful too. If it isn't touched in 30 minutes, is it even running? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 21:16:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 19:16:33 +0000 Subject: [Koha-bugs] [Bug 13302] Use CSS3 ellipsis for email address in staff client patron sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13302 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 21:18:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 19:18:28 +0000 Subject: [Koha-bugs] [Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 22:00:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 20:00:08 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 --- Comment #2 from Katrin Fischer --- Hi Mark, we have updated the MARC frameworks a while ago to include all the RDA fields and subfields. For older installations this framework could be useful, but probably doesn't have the newest additions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 22:04:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 20:04:27 +0000 Subject: [Koha-bugs] [Bug 12514] Pressing 'print and confirm hold' on check in triggers race condition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12514 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock at ccfls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 22:12:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 20:12:44 +0000 Subject: [Koha-bugs] [Bug 12514] Pressing 'print and confirm hold' on check in triggers race condition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12514 --- Comment #2 from Cindy Murdock Ames --- Yes Jason, it occurs for me too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 23:40:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 21:40:20 +0000 Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #8 from Christopher Brannon --- I know it is a little late in the game, but just to stir up the pot a bit, what if the list was collapsed during edit? Show only the record being edited, and all other items are in an expandable list? The list would be expanded when not editing, and contracts during edit. The plus to this is you get to see the line, and there is less scrolling. Frankly, I don't think the edit screen should always be open. I think it leads to confusion as to whether you've got something new or editing something from the list. I would go as far as collapsing the edit list when not in use, or making it modal. Just my added two cents. Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 9 23:43:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 21:43:49 +0000 Subject: [Koha-bugs] [Bug 13680] Items list on edit items page separates add items form from header and sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #9 from Katrin Fischer --- Hi Christopher, I had similar thoughts at this +1 for your suggestions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 00:03:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 22:03:35 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 00:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 22:03:38 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 --- Comment #9 from Katrin Fischer --- Created attachment 37631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37631&action=edit [PASSED QA] Bug 13934: C4::ItemType->get should return undef if no parameter given The issue: If you try to check in an item with a non existent barcode, the application will exploded with a software error: "Can't bless non-reference at .../ItemType.pm Line 64". It's caused by: commit 7431f8cfe29e330e2232b0df591afc4d923b0a52 Bug 11944: Fix encoding issue in C4::ItemType and the following change: @@ -105,9 +104,6 @@ sub get { my $data = $dbh->selectrow_hashref( "SELECT * FROM itemtypes WHERE itemtype = ?", undef, $itemtype ); - if ( $data->{description} ) { - $data->{description} = Encode::encode('UTF-8', $data->{description}); - } because of the following: my $s; $s->{foo} = "bar" if $s->{foo}; use Data::Dumper;warn Dumper $s; => {} # not undef So later, bless $opts => $class; will fail because $opts is undef and was not (i.e. {}) before. More explicit test plan: 1) Log in to staff client 2) Circulation -> Check in 3) Type a non-existent barcode into 'Enter item barcode:' textbox 4) Click 'Submit' -- Should receive nasty error. 5) apply patch 6) repeat steps 2-4 -- Should be told 'No item with barcode: {what you typed}' 7) prove -v t/ItemType.t -- All tests should run successfully. 7) run koha qa test tools Note: Having tried to create and use an itemtype '0', this only demonstrates a lack of validation on the itemtype creation screen. Unable to use it without tweaking back end. That is beyond the scope of this bug. Note for QA: C4::ItemType->get is only uses in circ/return.pl. So even if the behavior is changed, it should not introduce any regression somewhere else. Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Works as expected. Fixes the problem and no regressions found. It even has regression tests :-D Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 00:12:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 22:12:00 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 00:12:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 22:12:03 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37562|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 37632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37632&action=edit [PASSED QA] Bug 13936: Last patch contained wrong change One of the 2 changes done in the last patch was not for this bug report. The tt change was intended for bug 13926. This patch reverts it. BE CARE: This should NOT be pushed AFTER bug 13926! Test plan: Search for a patron using the 'check out' tab in the circulation module. Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer - use the checkout tab to search for a patron not using the autocomplete, but hitting enter - without the patch, there won't be results - with the patch there are Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 01:22:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 23:22:22 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #16 from M. Tompsett --- I successfully (and that's not a good thing) ran two batch modify concurrently, and one progress bar hung, but the other finished. I suspect the process was killed by OS, because the javascript kept pulling the 99% just fine. However, on a positive note, this does make a significant improvement. In the same kind of test ran multiple times, I actually had the error (mentioned in comment #1) triggered behind the scenes and the progress bar seemed to get stuck before the patch. I did not encounter the same problem after. Though, the patch for the paragraph 1 problem would likely solve, as a side-effect the hidden hang in the paragraph 2 problem. If we store the process ID of the child in the job session, then the progress javascript call can check for the existence of that process if the status is not completed. If the process does not exist, then it can change the status to failed OR perhaps attempt to restart with a smaller data set in order to continue. This, of course, is discussion for the creation of another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 01:45:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 23:45:10 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 01:45:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 23:45:13 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37621|0 |1 is obsolete| | --- Comment #17 from M. Tompsett --- Created attachment 37633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37633&action=edit Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT The previous patch fixed partially the problem. If you try to update more that 1000 records, you will get the same error. This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT (32mb). Test plan: 1/ Try to modify a huge amount of records (1000 should be enough) 2/ Confirm it worked! Signed-off-by: Frederic Demians I confirm that with more than 1000 records the session object is truncated, and then can't be anymore be desirialized, blocking completely Koha. Fixed with this patch. Signed-off-by: Mark Tompsett This only pushes off the problem expontentially (64KB vs. 16MB), but this is a good start. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 01:45:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 23:45:38 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37633|0 |1 is obsolete| | --- Comment #18 from M. Tompsett --- Created attachment 37634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37634&action=edit Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT The previous patch fixed partially the problem. If you try to update more that 1000 records, you will get the same error. This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT (32mb). Test plan: 1/ Try to modify a huge amount of records (1000 should be enough) 2/ Confirm it worked! Signed-off-by: Frederic Demians I confirm that with more than 1000 records the session object is truncated, and then can't be anymore be desirialized, blocking completely Koha. Fixed with this patch. Signed-off-by: Mark Tompsett This only pushes off the problem expontentially (64KB vs. 16MB), but this is a good start. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 01:45:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 Apr 2015 23:45:44 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37627|0 |1 is obsolete| | --- Comment #19 from M. Tompsett --- Created attachment 37635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37635&action=edit Bug 13606: Remove previous job data from the session Bug 11395 uses the session to store the report sent to the interface (update on biblio XX OK, etc.). If the session is stored in mysql, the max size of the sessions.a_session will be reached easily (TEXT field). To reproduce: 0/ Set SessionStorage to 'mysql' 1/ Create a file with 500 biblionumbers: mysql -e "select biblionumber from biblio limit 500;" | tail -n 500 > /tmp/biblionumbers.txt 2/ Define a marc modification template (something like "delete field 99$9" is nice) 3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool 4/ Repeat 3 You will get: Syck parser (line 1534, column 6): syntax error at /usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75. None Koha page is reachable. It comes from get_template_and_user > checkauth > get_session > l.1595 $session = new CGI::Session("driver:MySQL;serializer:yaml;id:md5", $sessionID, {Handle=>$dbh}); 5/ Get your sessionID contained in your CGISESSID cookie Have a look at the value a_session in the sessions table: mysql> select a_session from sessions where id="YOUR_SESSIONID"; You should see that the yaml is not correctly ended. The size of the DB field has been reached and the yaml is truncated. Test plan: 0/ Delete your CGISESSID cookie 1/ Try to reproduce the previous issue 2/ After the second batch, have a look at the sessions table and confirm that only one job_$JOB_ID exist in the yaml Signed-off-by: Mark Tompsett Confirmed that last completed run is the only thing in the session, under normal circumstances, now. This will go a long way to preventing the 16MB MEDIUMTEXT from filling up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 04:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 02:31:59 +0000 Subject: [Koha-bugs] [Bug 13979] New: Packages uninstallable on Debian Jessie Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Bug ID: 13979 Summary: Packages uninstallable on Debian Jessie Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz This is because libyui-js is no longer shipped in debian, so we're going to have to remove our dependency on it and carry the built in version around until it's exorcised for good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 04:32:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 02:32:14 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | Severity|enhancement |major Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 06:54:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 04:54:35 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 06:55:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 04:55:54 +0000 Subject: [Koha-bugs] [Bug 12913] wrong inventory results when notforloan filter is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 06:56:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 04:56:15 +0000 Subject: [Koha-bugs] [Bug 13915] Inventory tool no longer hides items with date last seen greater than the inventory date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 08:22:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 06:22:39 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- (In reply to Mason James from comment #4) > 1/ attempt to view a subscription-detail that has a NULL value for either > it's 'startdate' or 'enddate' The date picker forces it or a length to be entered. How do you get this situation without messing with data in the back end? > an example url would be... > > http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail. > pl?subscriptionid=1 > > observe error... > 'Date::Calc::PP::Delta_Days(): Usage: > Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at > /your/koha/C4/Serials.pm line 2325' > > 2/ apply patch > 3/ repeat step 1/ > observe that detail page displays OK Could you just confirm test steps more explicitly, assuming fresh install with one superlibrarian created and defaults all installed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 08:43:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 06:43:06 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #20 from Fr?d?ric Demians --- Jonathan, reading your code, I understand better now how it interact with C4::Background module. Your last patch clear the batch modification job data when a new job is created. Wouldn't it be simpler to clear it just after the job is completed in batch_record_modification.pl? I will do a proposal patch for that, hoping I don't miss something important. And, yes, I confirm that progress bar is also broken in batch item modification. It may works that way since a while. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 08:50:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 06:50:49 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #21 from Fr?d?ric Demians --- Created attachment 37636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37636&action=edit Proposal to clear the job session data at the end of the process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 08:51:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 06:51:47 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37636|application/mbox |text/plain mime type| | Attachment #37636|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 09:18:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 07:18:50 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37635|0 |1 is obsolete| | Attachment #37636|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 37637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37637&action=edit Bug 13606 Clear job data in session when the job is completed Bug 11395 uses the session to store the report sent to the interface (update on biblio XX OK, etc.). If the session is stored in mysql, the max size of the sessions.a_session will be reached easily (TEXT field). To reproduce: 0/ Set SessionStorage to 'mysql' 1/ Create a file with 500 biblionumbers: mysql -e "select biblionumber from biblio limit 500;" | tail -n 500 > /tmp/biblionumbers.txt 2/ Define a marc modification template (something like "delete field 99$9" is nice) 3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool 4/ Repeat 3 You will get: Syck parser (line 1534, column 6): syntax error at /usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75. None Koha page is reachable. It comes from get_template_and_user > checkauth > get_session > l.1595 $session = new CGI::Session("driver:MySQL;serializer:yaml;id:md5", $sessionID, {Handle=>$dbh}); 5/ Get your sessionID contained in your CGISESSID cookie Have a look at the value a_session in the sessions table: mysql> select a_session from sessions where id="YOUR_SESSIONID"; You should see that the yaml is not correctly ended. The size of the DB field has been reached and the yaml is truncated. Test plan: 0/ Delete your CGISESSID cookie 1/ Try to reproduce the previous issue 2/ After the second batch, have a look at the sessions table and confirm that only one job_$JOB_ID exist in the yaml Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 09:26:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 07:26:37 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #23 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #20) > Jonathan, reading your code, I understand better now how it interact with > C4::Background module. Your last patch clear the batch modification job data > when a new job is created. Wouldn't it be simpler to clear it just after the > job is completed in batch_record_modification.pl? I will do a proposal patch > for that, hoping I don't miss something important. It works nicely. I have tried to add this line in the finish method, but did not work. The only concern could be in case we need debugging. If something wrong happens it is good to know what kind of batch has been launched. Apart from that my patch was not much better than yours... > And, yes, I confirm that progress bar is also broken in batch item > modification. It may works that way since a while. That's really weird, I'm sure it worked when I have submitted my patch set on bug 11395. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 09:28:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 07:28:47 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #24 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #21) > Created attachment 37636 [details] [review] > Proposal to clear the job session data at the end of the process Note that I have c/p my test plan to your commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 10:10:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 08:10:47 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #25 from Jonathan Druart --- (In reply to Jonathan Druart from comment #23) > > And, yes, I confirm that progress bar is also broken in batch item > > modification. It may works that way since a while. > > That's really weird, I'm sure it worked when I have submitted my patch set > on bug 11395. It does not work on my dev install, but works perfectly on sandboxes (tested with batch records modification, and import). I would suspect the perl version (5.20.1 vs 5.14.2). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 10:39:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 08:39:33 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_9874=5D__Adding_subfield_=C2=ABamper?= =?utf-8?q?sand=C2=BB_produce_unexpected_behaviours?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- This is fixed, I have tried with a subfield '?' and '?' and it works quite well (I have also tried to save the record/edit again, all is fine). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 10:40:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 08:40:34 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 10:44:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 08:44:39 +0000 Subject: [Koha-bugs] [Bug 9853] Overdues fine cap empty in circulation rules means fines accrue forever In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9853 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- To me this is invalid, it seems to be the expected behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 10:49:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 08:49:32 +0000 Subject: [Koha-bugs] [Bug 9853] Overdues fine cap empty in circulation rules means fines accrue forever In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9853 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Katrin Fischer --- I think the problem was that my fines.pl script unexpectedly created a few thousands of fines - but as noone has reported problems with this behaviour since, I think marking WONTFIX is alright. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 11:34:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 09:34:08 +0000 Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 11:52:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 09:52:13 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 12:03:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 10:03:40 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #26 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #23) > I have tried to add this line in the finish method, but did not work. As I understand background process, the finish() method is called when the job is achieved. Then the job result is stored in the session. And from there, the result can be retrieved by a web page (like batch modification page). So the job data clearing must separated from marking a job as finished. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 12:05:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 10:05:41 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 12:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 10:06:02 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #2 from Jonathan Druart --- Created attachment 37638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37638&action=edit Bug 9809: Get rid of reserveconstraints First, to be honest, I am not completely sure this patch won't introduce regression. We need several pairs of eyes, and if possible from someone in place for a long time in the project :) Once again this looks vestige of Koha 2, and comments like "FIXME", "This does not make sense", "probably never reached" appears all around this code. Confirmed, reserveconstraints was in commit d0374d003716dfb40796caad6390a4d69bfb0376 Author: rangi Date: Tue Dec 19 23:45:51 2000 +0000 Initial revision This patch is not complete, the reserves.constrainttype should be removed too (to confirm?), and all call to *Reserves using it be updated. What I understood: This feature has never been finished, and has never worked. Developers try not touch the code not to break something. The only place something could be inserted in this table is in C4::Reserves::AddReserve, if the parameter "constraint" starts with an "o" or "e" (hum...). The only place (I found) where it is possible is in the quite muddled serials/routing-preview.pl script (if RoutingListAddReserves is set). This parameter is set to 'o' since the beginning of the history and it's not clear why. I suspect a simple wrong c/p. There are 2 places where something could be retrieved from this table: - C4::Reserves::GetReservesFromBiblionumber. I did not find any calls using something else than the number of reserves or data from the reserves table. Looking at the number of FIXME in this area, not sure it has already worked. - _Findgroupreserve: I let you have a look at the sql query but to me this cannot return anything if the reserveconstraints table is empty. Test plan: 0/ Don't apply this patch 1/ Try to add something in the reserveconstraints table ( :D ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 12:06:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 10:06:22 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 12:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 10:13:39 +0000 Subject: [Koha-bugs] [Bug 9709] actual cost staying zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9709 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED Version|3.8 |master Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart --- Fixed on master, since 3.8 is not longer supported, I closed this bug report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 13:26:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 11:26:53 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 13:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 11:26:56 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #6 from Jonathan Druart --- Created attachment 37639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37639&action=edit Bug 10020: Remove code related to ethnicity This is a(nother) vestige of Koha (2.2?). This patch removes unused code related to the 'ethnicity'. In detail: There is no way to fill the ethnicity table. There is no way to fill the borrowers.ethnicity and borrowers.ethnotes. BUT if borrowers.ethnicity exists, the value is displayed on members/moremember.pl (and only here). Test plan: Apply this patch and confirm there is no regression on adding/updating/deleting patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 13:27:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 11:27:03 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #7 from Jonathan Druart --- Created attachment 37640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37640&action=edit Bug 10020: Remove DB table and fields related to ethnicity This patch remove the ethnicity table and the ethnicity and ethnotes fields from the 3 tables: borrowers, deletedborrowers and borrower_modifications IF no data exist. Test plan: 0/ Apply this patch and update the Koha::Schema (misc/devel/update_dbix_class_files.pl). 1/ Make sure the ethnicity has at least 1 entry 2/ Launch the updatedb entry and confirm you get a warning message and the DB structure is not updated. 3/ truncate the ethnicity table and fill ethnicity (or ethnotes) for at least 1 row of the borrowers table. 4/ Launch the updatedb entry and confirm you get a warning message and the DB structure is not updated. 5/ Make sure the ethnicity table is empty as well as the ethniciy and the ethnotes fields of borrowers, deletedborrowers and borrower_modifications 6/ Launch the updatedb entry and confirm you don't get the warning message and the DB structure is updated (ie. table and fields dropped). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 13:30:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 11:30:01 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37639|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 37641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37641&action=edit Bug 10020: Remove code related to ethnicity This is a(nother) vestige of Koha (2.2?). This patch removes unused code related to the 'ethnicity'. In detail: There is no way to fill the ethnicity table. There is no way to fill the borrowers.ethnicity and borrowers.ethnotes. BUT if borrowers.ethnicity exists, the value is displayed on members/moremember.pl (and only here). Test plan: Apply this patch and confirm there is no regression on adding/updating/deleting patrons. Note that you don't see the ethnicity value on the moremember.pl page even if a patron has it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 13:30:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 11:30:32 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m CC| |jonathan.druart at biblibre.co | |m Component|Database |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 13:46:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 11:46:59 +0000 Subject: [Koha-bugs] [Bug 10014] printcirculationslips missing documentation or obsolete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Not sure it's HLT specific, the pref is set to 1 in sysprefs.sql. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 13:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 11:55:35 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from M. Tompsett --- If you add a function to a C4 library, you need to add corresponding tests in a .t file too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 13:56:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 11:56:55 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_9874=5D__Adding_subfield_=C2=ABamper?= =?utf-8?q?sand=C2=BB_produce_unexpected_behaviours?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9874 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #2 from Pablo AB --- This bug isn't fixed yet. Tried with my 3.18.05.100 Koha and still there. As I said on the first comment, the problem is not with those other characters but with ampersand (and maybe others like "?"). Those are used on query section of the URI by Koha (I'm pretty sure that's the root of the bug). RFC 3986 describes the URI format, such as what characters are permitted and what must be escaped. Koha doesn't escape ampersands. I'll upload two screenshots to illustrate the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 13:58:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 11:58:18 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_9874=5D__Adding_subfield_=C2=ABamper?= =?utf-8?q?sand=C2=BB_produce_unexpected_behaviours?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9874 --- Comment #3 from Pablo AB --- Created attachment 37642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37642&action=edit Screenshot of what it happens if you tried to open a non-escaped character -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 13:59:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 11:59:11 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_9874=5D__Adding_subfield_=C2=ABamper?= =?utf-8?q?sand=C2=BB_produce_unexpected_behaviours?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9874 --- Comment #4 from Pablo AB --- Created attachment 37643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37643&action=edit Screenshot after trying to delete such subfields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 14:00:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 12:00:21 +0000 Subject: [Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 14:00:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 12:00:24 +0000 Subject: [Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011 --- Comment #3 from Jonathan Druart --- Created attachment 37644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37644&action=edit Bug 10011: Save branch limitations on creating a new patron category The code was just badly placed. It should be executed on update but also on insert. Test plan: 1/ Create a new patron category and select 1+ branch limitations 2/ Confirm it's correctly saved 3/ Edit it and change the branch limitations 4/ Confirm it's correctly saved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 14:00:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 12:00:44 +0000 Subject: [Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 14:07:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 12:07:08 +0000 Subject: [Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 --- Comment #10 from Kyle M Hall --- (In reply to Katrin Fischer from comment #9) > Wondering if we should update this to be a 'new feature'? I would certainly consider this to be a new feature! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 14:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 12:39:39 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 14:39:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 12:39:41 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37600|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 37645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37645&action=edit [PASSED QA] Bug 13942 : Testing the 'recordpayment' function in C4::Accounts for Kyle M Hall : Adding removal of the 'issues' table TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Accounts.t -- All 15 tests should run successfully without any error or warning Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 14:55:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 12:55:49 +0000 Subject: [Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour finesCalendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 14:55:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 12:55:51 +0000 Subject: [Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour finesCalendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37598|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 37646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37646&action=edit [PASSED QA] Bug 13909: Suspension days calculation should respect finesCalendar This patch make _debar_user_on_return respect the finesCalendar syspref. It does so, by replacing the ad-hoc overdue days calculation in favor of C4::Overdues::_get_chargeable_units (which is renamed C4::Overdues::get_chargeable_units and exported). There's no behaviour change besides making the calculation simpler and correct. To test: - Set finesCalendar = "directly" - Have a circulation rule stating: interval for calculating fines = 1 suspension days = 3 - Have the calendar set for sunday and saturday as holidays. - Checkout an item with a branch/itype/borrower category that matches the defined circ rule with a hand-writen due date to (say) last friday. - Check the item in => FAIL: Notice that the user is debarred using the calendar (skipping saturday and sunday). - Apply the patch - Repeat the previous steps => SUCCESS: calculation is correct (counting saturday and sunday as overdue days, i.e. 'directly'). - Set finesCalendar = "calendar" - Repeat the test => SUCCESS: calculation is correct (skipping holidays). - Sign off. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:11:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:11:30 +0000 Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:11:32 +0000 Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37375|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 37647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37647&action=edit [PASSED QA] Bug 13866: Columns configuration - Patrons search This patch adds the ability to hide columns on the patrons search page (acqui/lateorders.pl). Test plan: Go on the patrons search page and confirm you are able to hide columns. You can also play with the columns configuration admin page and confirm that the behaviors are consistent. Signed-off-by: Josef Moravec Works as expected Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:11:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:11:52 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #20 from Kyle M Hall --- (In reply to M. Tompsett from comment #15) > I was noticing that the test that was added also works in the unpatched > master. > > And on a different note, the whole enable, disable, and clear system > preferences cache needs to escape C4::Context as well. This provides a good > step in the right direction, even if it is small. I completely agree! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:12:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:12:37 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #21 from Kyle M Hall --- (In reply to Robin Sheat from comment #19) > (In reply to Kyle M Hall from comment #18) > > At some point it was generally decided to remove the rollback calls. I don't > > recall when or where. > > This sounds dangerous for plack. I was not aware of that! Should we create a bug report to re-add the rollback to all unit tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:14:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:14:24 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #22 from Tom?s Cohen Arazi --- (In reply to Kyle M Hall from comment #21) > (In reply to Robin Sheat from comment #19) > > (In reply to Kyle M Hall from comment #18) > > > At some point it was generally decided to remove the rollback calls. I don't > > > recall when or where. > > > > This sounds dangerous for plack. > > I was not aware of that! Should we create a bug report to re-add the > rollback to all unit tests? We haven't been removing them, just not requesting them as mandatory. I've added rollback calls to all the tests I wrote so far :-D So what we need is have it written on the Coding guidelines, and have the QA team enforce it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:17:36 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Attachment #37630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:18:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:18:30 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #28 from Fr?d?ric Demians --- (In reply to M. Tompsett from comment #27) > If you add a function to a C4 library, you need to add corresponding tests > in a .t file too. Is there somewhere a form to fill out in three copies? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:21:27 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:21:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:21:29 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #29 from Fr?d?ric Demians --- Created attachment 37648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37648&action=edit Bug 13606 New test for added method to C4::BackgroundJob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:29:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:29:18 +0000 Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:29:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:29:20 +0000 Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37371|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 37649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37649&action=edit [PASSED QA] Bug 13865: Columns configuration - Orders search This patch adds the ability to hide columns on the orders search page (acqui/histsearch.pl). Test plan: Go on the orders search page and confirm you are able to hide columns. You can also play with the columns configuration admin page and confirm that the behaviors are consistent. Signed-off-by: Nicole http://bugs.koha-community.org/show_bug.cgi?id=13685 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:29:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:29:33 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #23 from M. Tompsett --- In light of Tom?s' comments in comment #22, could we have the rollback left alone? Or am I just being too particular, but we will on a forward basis? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 15:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 13:55:35 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #49 from Kyle M Hall --- Created attachment 37650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37650&action=edit Bug 11759 [QA Followup] - Fix koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:04:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:04:49 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #50 from Kyle M Hall --- Jonathan, can you check my followup? I don't understand the double call to GetMemberIssuesAndFines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:11:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:11:04 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:11:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:11:07 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #71 from Kyle M Hall --- Created attachment 37651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37651&action=edit [PASSED QA] Bug 8033 - Remove unused template file. All prog related patches were obsoleted from this bug. Bug 11349 changed the code to have the proper template name used (sco/printslip.tt instead of sco/printsplit.tmpl). Bug 12062 moved the hard coded string logic into the template, and passed the borrower number. This only leaves the patch to remove the unused receipt.tt file. TEST PLAN --------- 1) Confirm the file isn't used. $ git grep "sco/receipt" | grep -v "\.po:" -- this should list nothing, because there are still po files referencing it, but they aren't needed either. 2) ls ./koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt -- there should be a file 3) apply patch 4) repeat step 2 -- the file should be removed Followed test plan, file does no longer exist. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:11:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:11:22 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #37497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:13:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:13:40 +0000 Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:13:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:13:42 +0000 Subject: [Koha-bugs] [Bug 9089] show suggestion number on suggestion management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37369|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 37652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37652&action=edit [PASSED QA] Bug 9089 - show suggestion number Show suggestion number on suggestion management. Signed-off-by: Nicole Engard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:13:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:13:58 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #51 from Jonathan Druart --- Comment on attachment 37650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37650 Bug 11759 [QA Followup] - Fix koha-qa errors Review of attachment 37650: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11759&attachment=37650) ----------------------------------------------------------------- All is good, thanks! ::: circ/circulation.pl @@ -400,4 @@ > $template_params->{getTitleMessageIteminfo} = $iteminfo->{'title'}; > $template_params->{getBarcodeMessageIteminfo} = $iteminfo->{'barcode'}; > $template_params->{NEEDSCONFIRMATION} = 1; > - $template_params->{onsite_checkout} => $onsite_checkout, oops, thanks! @@ -413,5 @@ > > my ( $od, $issue, $fines ) = GetMemberIssuesAndFines($borrowernumber); > > - # FIXME If the issue is confirmed, we launch another time GetMemberIssuesAndFines, now display the issue count after issue > - my ( $od, $issue, $fines ) = GetMemberIssuesAndFines( $borrowernumber ); It a bad conflict issue. The fixme has already been removed on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:15:49 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37650|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart --- Created attachment 37653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37653&action=edit Bug 11759 [QA Followup] - Fix koha-qa errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:16:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:16:27 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close JavaScript alerts is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:16:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:16:29 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close JavaScript alerts is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37596|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 37654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37654&action=edit [PASSED QA] Bug 9333: Remove useless JS code - confirm close basket On closing a basket, the librarian is redirect to a new page for the confirmation, the JavaScript confirmation is useless. This code is never triggered and can be removed. Test plan: Without this patch, confirm you don't get a JavaScript confirmation popup on closing a basket With this patch, confirm you don't get any JavaScript error on closing/reopening a basket. NOTE: acqui/basket.tt is only used by acqui/basket.pl git grep "confirm_close" | grep -v "\.po:" doesn't show anything else. Reopening only works on basketgroups, not baskets. Unable to trigger any errors as expected and desired. :) Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:34:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:34:30 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:34:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:34:32 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37506|0 |1 is obsolete| | Attachment #37507|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 37655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37655&action=edit [PASSED QA] Bug 7369 - duplicate item This patch adds a link to duplicate existing items on the edit items screen To test: 1 - Apply patch 2 - navigate to the edit items screen for a record with existing items 3 - click the duplicate link and ensure item info but not barcode are carried over 4 - save the item and ensure it is added correctly 5 - check that all previous functionality on page works as before Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:34:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:34:39 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 --- Comment #19 from Kyle M Hall --- Created attachment 37656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37656&action=edit [PASSED QA] Bug 7369 - Use dropdown buttons for item actions NOTE: Tested both patches together. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:36:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:36:31 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |mail at jkozlovsky.cz --- Comment #3 from Ji?? Kozlovsk? --- Supported services are: LookupUser LookupItem LookupItemSet LookupRequest RequestItem CancelRequestItem RenewItem This module was basically written in order to parse only relevant data from Koha, respecting good manners like doing C4::Reserves::CanBookBeReserved or CanItemBeReserved before the RequestItem service is done and so on.. Output format is JSON if there was success. Else proprietary status code is returned with a little text/plain response. We are using xcncip2toolkit because it is being maintained by eXtensible Catalog as open source & any changes made to NCIP schema protocol are afterwards commited to git available to public (https://code.google.com/p/xcncip2toolkit/source/browse/) .. Then it is as easy to implement changes made to protocol as pulling changes from git :) Also a good reason is that in xcncip2toolkit are all values parsed in proprietary standardized classes, easy to read & work with .. also it has built-in schema validator & in a way it is all prepared for a programmer to focus on the goal he needs to achieve, as is writing an connector for Koha .. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:42:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:42:17 +0000 Subject: [Koha-bugs] [Bug 1487] Set only the used fields/subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1487 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:42:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:42:20 +0000 Subject: [Koha-bugs] [Bug 1487] Set only the used fields/subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1487 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37571|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 37657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37657&action=edit [PASSED QA] Bug 1487: Store the "display only used tags/subf" value in a cookie On the marc framework page, the checkbox to display only used tags/subfields is always unchecked. It should be stored into a cookie to always display the same view. Test plan: 1/ Go on the marc framework page 2/ Check the checkbox 3/ Go somewhere else on the staff interface 4/ Back to the marc framework page, the checkbox should be checked Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall Works as advertised, getting datatables error when using feature but the error exists pre-patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:54:15 +0000 Subject: [Koha-bugs] [Bug 1487] Set only the used fields/subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1487 --- Comment #9 from Jonathan Druart --- (In reply to Kyle M Hall from comment #8) > Signed-off-by: Kyle M Hall > Works as advertised, getting datatables error when using feature > but the error exists pre-patch You shouldn't see it after bug 6007. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 16:55:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 14:55:03 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from M. Tompsett --- (In reply to Fr?d?ric Demians from comment #28) > Is there somewhere a form to fill out in three copies? No, just trying to keep the quality high. I see that you encountered the same kind of problem I did when trying to make the test. Here's the problem that still exists. $ mysql -u root -p > use koha_library; > delete from sessions; ^Z $ prove -v t/db_dependent/BackgroundJob.t $ fg > select a_session from sessions where a_session like '%complete%'; ... There are still LOTS of anonymous sessions created for each stage tested in the file. That doesn't seem correct to me. Because if I run it from within Koha, there are not. And from within Koha clear() works, but in the test context it does not. The fail is for a test that doesn't successfully test clear(). Perhaps clear() needs to actually clear based on jobID? I apologize for being a testing pain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:08:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:08:32 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36830|0 |1 is obsolete| | --- Comment #54 from Marc V?ron --- Comment on attachment 36830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36830 Bug 13813 - Remove C4::Dates from overdue_notices.pl Obsoleted because not sure if three-was-merge will break things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:13:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:13:18 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #31 from Jonathan Druart --- I have a patch for tests, will be ready soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:20:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:20:46 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:20:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:20:50 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37648|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 37658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37658&action=edit Bug 13606: Add tests and fix existing ones Some tests was wrong and not executed in a transaction. Lot of sessions were created in DB because the session was never flushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:21:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:21:58 +0000 Subject: [Koha-bugs] [Bug 13322] Update MARC21 frameworks to Update No. 19 (October 2014) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:26:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:26:00 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_9874=5D__Adding_subfield_=C2=ABamper?= =?utf-8?q?sand=C2=BB_produce_unexpected_behaviours?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9874 --- Comment #5 from Jonathan Druart --- (In reply to Pablo AB from comment #2) > This bug isn't fixed yet. Tried with my 3.18.05.100 Koha and still there. > As I said on the first comment, the problem is not with those other > characters but with ampersand (and maybe others like "?"). Those are used on > query section of the URI by Koha (I'm pretty sure that's the root of the > bug). RFC 3986 describes the URI format, such as what characters are > permitted and what must be escaped. Koha doesn't escape ampersands. > I'll upload two screenshots to illustrate the problem. Sorry, I read too quickly the description, you are right, it is still broken with '&'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:27:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:27:30 +0000 Subject: [Koha-bugs] [Bug 6007] Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:27:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:27:39 +0000 Subject: [Koha-bugs] [Bug 6007] Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37568|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 37659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37659&action=edit [PASSED QA] Bug 6007: Fix MARC framework display when only used tags/subfields The "Display only used tags/subfields" output breaks DataTables and the output is unusable. Test plan: 1/ Go on admin/marctagstructure.pl after you have selected a framework 2/ Check the checkbox 3/ The table should be correctly displayed. Before this patch, the table have 2 lines per tag, now all data are contained into the same line. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:28:05 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_9874=5D__Adding_subfield_=C2=ABamper?= =?utf-8?q?sand=C2=BB_produce_unexpected_behaviours?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9874 --- Comment #6 from Jonathan Druart --- But... why do you want to use this character? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:28:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:28:12 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_9874=5D__Adding_subfield_=C2=ABamper?= =?utf-8?q?sand=C2=BB_produce_unexpected_behaviours?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:29:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:29:27 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37658|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 37660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37660&action=edit Bug 13606: Add tests and fix existing ones Some tests were wrong and not executed in a transaction. Lot of sessions were created in DB because the session was never flushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:34:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:34:09 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37295|0 |1 is obsolete| | --- Comment #23 from Marc V?ron --- Created attachment 37661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37661&action=edit Bug 4041 - Second Step: Add system preference and "German style" address formats for staff To test: Apply patch Do a database update (e.g. by changing version number in kohaversion.pl) Find new system preference 'addressformat' in I18N/L10N Choose 'German style' Go to Patrons and edit a patron / create new patron Verify that Zip code appears above City Change system preference to 'US style' Verify that Zip code appears between State and Country. BTW: New formats can be added by editing i18n_l10n.pref (add a new code, e.g. fr for "French style") and copy / modify the includes using the same code as postfix. Signed-off-by: Mirko Tietgen Patch amended to move street number after address. /Marc Signed-off-by: Mirko Tietgen Amended do resolve conflict with updatedatabase.pl /Marc Rebased for current master /Marc -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:34:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:34:30 +0000 Subject: [Koha-bugs] [Bug 13016] Add fine grace period by hour In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13016 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:36:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:36:27 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #34 from Fr?d?ric Demians --- Jonathan: +1 for testing correctly Mark: +1 for keeping the quality high, or elevating it even -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 17:36:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 15:36:37 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_9874=5D__Adding_subfield_=C2=ABamper?= =?utf-8?q?sand=C2=BB_produce_unexpected_behaviours?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9874 --- Comment #7 from Pablo AB --- Don't problem Jonathan :) I don't want it, but a creative librarian think it was a good idea and hence found the bug. I always feel uncomfortable getting out of [0-9a-z] subfields, even ?The data element may be any ASCII lowercase alphabetic, numeric, or graphic symbol except blank? (http://www.loc.gov/marc/specifications/specrecstruc.html ) Maybe this bug represent a particular case of a major bug. Koha *always* / anywhere should escape certain characters (RFC3986) while using them on URI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 18:14:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 16:14:46 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 --- Comment #4 from Ji?? Kozlovsk? --- To apply this patch, you have to create NCIP folder inside C4 with these modules: https://github.com/jirislav/Koha/tree/master/C4/NCIP then add two new subroutines into C4::Reserves (GetReserveCountFromItemnumber & GetReserveFromBorrowernumberAndItemnumber): https://github.com/jirislav/Koha/blob/master/C4/Reserves.pm then finally create svc/ncip: https://github.com/jirislav/Koha/blob/master/svc/ncip Test plan is as follows: 1. Apply the patch 2. Use json validator on all responses (except when status code isn't 200 OK) (e.g http://jsonlint.com/) to check the json is valid 3. Try this URLs with your own parameters, check the response is appropriate to your data : Get patron: http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_user&userId= (returns basic user data) http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_user&userId=&loanedItemsDesired¬UserInfo (returns only items issued by user) http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_user&userId=&requestedItemsDesired¬UserInfo (returns only items requested by user) http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_user&userId=&userFiscalAccountDesired¬UserInfo (returns only user's transactions - fees etc) - notUserInfo says to omit user's info & all parameters can be joined together as follows: http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_user&userId=&loanedItemsDesired&requestedItemsDesired&userFiscalAccountDesired¬UserInfo 4. repeat 2.-3. for these URLs: Get an item: http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_item&itemId= (returns basic item data) http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_item&itemId=&holdQueueLengthDesired¬ItemInfo (returns hold queue length - number of reserves placed on item) http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_item&itemId=&circulationStatusDesired¬ItemInfo (returns NCIP formatted circulation status - can be 'Available On Shelf' etc.. all possible values are specified here: https://github.com/moravianlibrary/xcncip2toolkit/blob/master/core/trunk/service/src/main/java/org/extensiblecatalog/ncip/v2/service/Version1CirculationStatus.java) - notItemInfo again says to omit item's info & all params can be joined: http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_item&itemId=&circulationStatusDesired&holdQueueLengthDesired¬ItemInfo 5. repeat 2.-3. for these URLs: Get biblio with items: http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_item_set&bibId= (returns bibliographic information & items belonging to this biblio) http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_item_set&bibId=&holdQueueLengthDesired¬BibInfo (returns items belonging to specified biblio & each item now has element 'holdQueueLength' with number of reserves placed on it) http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_item_set&bibId=&circulationStatusDesired¬BibInfo (returns items of biblio & each item has additional 'circulationStatus' defined before) - notBibInfo again says to omit biblio's info & all params can be joined: http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_item_set&bibId=&holdQueueLengthDesired&circulationStatusDesired¬BibInfo 6. repeat 2.-3. for these URLs: Place reserve as patron on item & write down it's 'reserve_id': http://intranet:8080/cgi-bin/koha/svc/ncip?service=request_item&userId=&itemId=&pickupExpiryDate=&earliestDateNeeded= - please note that pickupExpiryDate & earliestDateNeeded are optional params .. but should be checked if were properly processed Place reserve as patron on biblio & write down it's 'reserve_id': http://intranet:8080/cgi-bin/koha/svc/ncip?service=request_item&userId=&bibId= - pickupExpiryDate & earliestDateNeeded could be specified here too Lookup those reserves using reserve ids you have written down: http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_request&requestId= Get reserve from patron & item number: http://intranet:8080/cgi-bin/koha/svc/ncip?service=lookup_request&userId=&itemId= Cancel reserve by reserve_id & user_id: http://intranet:8080/cgi-bin/koha/svc/ncip?service=cancel_request_item&requestId=&userId= Cancel reserve by item_id & user_id: http://intranet:8080/cgi-bin/koha/svc/ncip?service=cancel_request_item&itemId=&userId= Now check both reserves were properly cancelled .. 7. repeat 2.-3. for these URLs: Renew patron's loan (first manually do a checkout to a user ..): http://intranet:8080/cgi-bin/koha/svc/ncip?service=renew_item&itemId=&userId=&desiredDateDue= - desiredDateDue param is optional & if it is bigger than the date generated from koha's config, than is used the generated one That should be all .. If you experience any problems don't hesitate to contact me at mail at jkozlovsky.cz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 18:22:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 16:22:09 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37634|0 |1 is obsolete| | --- Comment #35 from M. Tompsett --- Created attachment 37662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37662&action=edit Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT The previous patch fixed partially the problem. If you try to update more that 1000 records, you will get the same error. This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT (32mb). Test plan: 1/ Try to modify a huge amount of records (1000 should be enough) 2/ Confirm it worked! Signed-off-by: Frederic Demians I confirm that with more than 1000 records the session object is truncated, and then can't be anymore be desirialized, blocking completely Koha. Fixed with this patch. Signed-off-by: Mark Tompsett This only pushes off the problem expontentially (64KB vs. 16MB), but this is a good start. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 18:22:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 16:22:22 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37637|0 |1 is obsolete| | --- Comment #36 from M. Tompsett --- Created attachment 37663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37663&action=edit Bug 13606 Clear job data in session when the job is completed Bug 11395 uses the session to store the report sent to the interface (update on biblio XX OK, etc.). If the session is stored in mysql, the max size of the sessions.a_session will be reached easily (TEXT field). To reproduce: 0/ Set SessionStorage to 'mysql' 1/ Create a file with 500 biblionumbers: mysql -e "select biblionumber from biblio limit 500;" | tail -n 500 > /tmp/biblionumbers.txt 2/ Define a marc modification template (something like "delete field 99$9" is nice) 3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool 4/ Repeat 3 You will get: Syck parser (line 1534, column 6): syntax error at /usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75. None Koha page is reachable. It comes from get_template_and_user > checkauth > get_session > l.1595 $session = new CGI::Session("driver:MySQL;serializer:yaml;id:md5", $sessionID, {Handle=>$dbh}); 5/ Get your sessionID contained in your CGISESSID cookie Have a look at the value a_session in the sessions table: mysql> select a_session from sessions where id="YOUR_SESSIONID"; You should see that the yaml is not correctly ended. The size of the DB field has been reached and the yaml is truncated. Test plan: 0/ Delete your CGISESSID cookie 1/ Try to reproduce the previous issue 2/ After the second batch, have a look at the sessions table and confirm that only one job_$JOB_ID exist in the yaml Signed-off-by: Jonathan Druart NOTE: Nicely clears batch job session information. (2) is incorrect. This cleans up after a full run. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 18:22:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 16:22:37 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37660|0 |1 is obsolete| | --- Comment #37 from M. Tompsett --- Created attachment 37664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37664&action=edit Bug 13606: Add tests and fix existing ones Some tests were wrong and not executed in a transaction. Lot of sessions were created in DB because the session was never flushed. TEST PLAN --------- $ mysql ... > delete from sessions; ^Z $ prove -v t/db_dependent/BackgroundJob.t ... $ fg > select id from sessions; -- There will be lots of ids (10, if I recall) ^Z $ git bz apply 13606 ... $ prove -v t/db_dependent/BackgroundJob.t ... $ fg > select * from sessions; -- there should only be the one orphaned job. You can tell it is correct by the "making new job". > quit Run the koha-qa test tools. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 18:24:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 16:24:12 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #38 from M. Tompsett --- This is so ready for QA now. :) Thanks everyone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 18:37:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 16:37:23 +0000 Subject: [Koha-bugs] [Bug 4281] reports dictionary limited to only 1 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4281 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 18:37:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 16:37:33 +0000 Subject: [Koha-bugs] [Bug 4281] reports dictionary limited to only 1 field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4281 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37594|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 37665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37665&action=edit [PASSED QA] Bug 4281: Reports dictionary supports only 1 field selection The reports dictionary allows the user to select several fields, but only 1 is used. The interface is quite confusing. This patch removes the multiple selection and permit to select only 1 field. Test plan: 1/ Create a report dictionary (reports/dictionary.pl) 2/ On the step 3, confirm that only 1 field can be selected Confirm there is no regression on this tool. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 18:41:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 16:41:25 +0000 Subject: [Koha-bugs] [Bug 13957] Patron autocomplete shows NULL in list of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 18:41:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 16:41:28 +0000 Subject: [Koha-bugs] [Bug 13957] Patron autocomplete shows NULL in list of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37567|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 37666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37666&action=edit [PASSED QA] Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country, address, zipcode, city 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". Signed-off-by: Nicolas Legrand Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 19:17:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 17:17:59 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 19:29:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 17:29:41 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 19:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 17:29:48 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36252|0 |1 is obsolete| | Attachment #37297|0 |1 is obsolete| | Attachment #37661|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 37667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37667&action=edit [PASSED QA] Bug 4041 - First step (staff interface): Extract address blocks to include files This patch extracts the address blocks in memberentrygen.tt to include files. To test: The overall functionality should remain the same with this patch. In further steps, more country- or region-dependent includes could be added, along with functionality to select them using a system preference. Signed-off-by: Mirko Tietgen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 19:30:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 17:30:07 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 --- Comment #25 from Kyle M Hall --- Created attachment 37668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37668&action=edit [PASSED QA] Bug 4041 - Third step - Display address on patron's pages using the system preference This patch displays the address information in the left column of the patron's pages using the new system preference. The address is formatted in member-display-address-style-us.inc and member-display-address-style-de.inc To test: - Apply patch on top of 1st and 2nd patch - Select 'German style' in system preference 'addressformat' in I18N/L10N - Verify that the address information displays properly in the left column of all patron's pages. - Verify that the address displays properly in the main area of moremember.pl as well (Note: In right column, Alternate address /contact are not yet touched)) - Switch system preference to US style, repeat checks Signed-off-by: Mirko Tietgen AMending without changes to put this patch at the end of the patch list / Marc Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 19:30:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 17:30:17 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 --- Comment #26 from Kyle M Hall --- Created attachment 37669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37669&action=edit [PASSED QA] Bug 4041 - Second Step: Add system preference and "German style" address formats for staff To test: Apply patch Do a database update (e.g. by changing version number in kohaversion.pl) Find new system preference 'addressformat' in I18N/L10N Choose 'German style' Go to Patrons and edit a patron / create new patron Verify that Zip code appears above City Change system preference to 'US style' Verify that Zip code appears between State and Country. BTW: New formats can be added by editing i18n_l10n.pref (add a new code, e.g. fr for "French style") and copy / modify the includes using the same code as postfix. Signed-off-by: Mirko Tietgen Patch amended to move street number after address. /Marc Signed-off-by: Mirko Tietgen Amended do resolve conflict with updatedatabase.pl /Marc Rebased for current master /Marc Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 19:30:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 17:30:27 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 --- Comment #27 from Kyle M Hall --- Created attachment 37670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37670&action=edit [PASSED QA] Bug 4041 [QA Followup] * Convert all tabs to 4 spaces * Tidy block in members/boraccount ( tab ) * Move syspref to it's proper place Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 10 19:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 Apr 2015 17:30:35 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 --- Comment #28 from Kyle M Hall --- Created attachment 37671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37671&action=edit [PASSED QA] Bug 4041 [QA Followup] - Change addressformat to AddressFormat Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 04:41:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 02:41:25 +0000 Subject: [Koha-bugs] [Bug 8050] debian/build-git-snapshot should warn user if it fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8050 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 04:43:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 02:43:57 +0000 Subject: [Koha-bugs] [Bug 13938] Staging MARC records for import fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13938 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 04:52:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 02:52:53 +0000 Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring default sort preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 05:03:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 03:03:02 +0000 Subject: [Koha-bugs] [Bug 13850] C4::Ris does not manage correctly 660 and 661 - UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13850 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 05:55:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 03:55:36 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 --- Comment #10 from M. Tompsett --- Comment on attachment 37545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37545 Bug 8684: Fix duplicate check on creating items in the acquisition module Review of attachment 37545: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8684&attachment=37545) ----------------------------------------------------------------- Secondary thought: $ git grep SearchItemsByField | grep \.t: -- Nothing. Perhaps including a test would (a) increase testing coverage (always good, but a pain to do), and (b) prevent brokenness like this, because people would trigger tests for C4::Items and it would be covered. Suggested test would be different commit. Apply before patch, run test, it fails. Apply patch, run test, it passes. As is, I believe the patch is right, but I have not tested it sufficiently (actually triggered it) to sign off. ::: C4/Items.pm @@ -2591,5 @@ > > - my $filters = [ { > - field => $field, > - query => $value, > - } ]; I see why someone may have been half awake reading the if code of the next function and thinking @{$filter->{filters}} when putting those square brackets there. But this isn't that structure, and clearly triggers the else which requires a hash ref, not an array. Now if only I could actually trigger this code, I'd sign this off. But I must be failing at following the test plan. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:12:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:12:53 +0000 Subject: [Koha-bugs] [Bug 10388] acq edited items showing 'null's In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:12:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:12:57 +0000 Subject: [Koha-bugs] [Bug 10388] acq edited items showing 'null's In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37550|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 37672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37672&action=edit Bug 10388: Does not display 'null' after editing an item on receiving After editing an item on receiving, 'null' is displayed if no value is defined for a field. It should be blank. Test plan: 0/ Set AcqCreateItem to 'ordering' 1/ Go on the receipt page page 2/ Edit an item 3/ Does not fill all values 4/ Confirm that undefined values are replaced with an empty string NOTE: I think you meant receive. Editing requires at least clicking the dropdown value, even if you don't change it before clicking save. null's appeared. Post patch application was able to get nulls to disappear. :) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:25:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:25:33 +0000 Subject: [Koha-bugs] [Bug 7480] The Basket manager is always the logged in user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:27:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:27:32 +0000 Subject: [Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:27:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:27:34 +0000 Subject: [Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37644|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 37673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37673&action=edit Bug 10011: Save branch limitations on creating a new patron category The code was just badly placed. It should be executed on update but also on insert. Test plan: 1/ Create a new patron category and select 1+ branch limitations 2/ Confirm it's correctly saved 3/ Edit it and change the branch limitations 4/ Confirm it's correctly saved Signed-off-by: Mark Tompsett NOTE: Not a C4 or Koha library, so tests not required. Though, this code could be cleaned up and have the DB stuff put into some sort of library with tests to prevent regression. However, that dream is beyond the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:29:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:29:29 +0000 Subject: [Koha-bugs] [Bug 10887] Batch item deletion -- doesn't need Use default values section In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10887 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:31:04 +0000 Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:33:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:33:35 +0000 Subject: [Koha-bugs] [Bug 7561] cannot fast catalog with fast cataloging permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7561 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #20 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:43:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:43:55 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #4 from M. Tompsett --- Comment on attachment 37416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37416 Bug 9067: Hide item related strings when importing staged authority records Review of attachment 37416: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9067&attachment=37416) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt @@ +306,5 @@ > [% END %] > [% END %] > > + > + [% IF ( record_type == 'biblio' ) %] You missed the section around line 378: Number of items added 0 Number of items replaced 0 Number of items ignored because of duplicate barcode 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:46:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:46:11 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA --- Comment #5 from M. Tompsett --- Changing to Failed QA, simply because of the block of item counts was displayed: Number of items added 0 Number of items replaced 0 Number of items ignored because of duplicate barcode 0 while viewing .../cgi-bin/koha/tools/manage-marc-import.pl Everything else looked great. Just fix that tiny piece. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 07:47:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 05:47:27 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #6 from M. Tompsett --- Created attachment 37674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37674&action=edit Sample 1 record authority MRC file. Attaching sample authority record that I used for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 09:57:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 07:57:02 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #7 from Marc V?ron --- Version is 'unspecified', is this for master? Wanted to test with patch, does not apply: Applying: Bug 13265 - Still too many search cursor cookies Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Failed to merge in the changes. Patch failed at 0001 Bug 13265 - Still too many search cursor cookies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 12:02:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 10:02:22 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #3 from Fr?d?ric Demians --- I wasn't able to apply this patch on master: fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 12:12:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 10:12:32 +0000 Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- Bug 13934 is in master. It solves check-in error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 12:14:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 10:14:54 +0000 Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 12:14:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 10:14:56 +0000 Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37386|0 |1 is obsolete| | --- Comment #9 from Fr?d?ric Demians --- Created attachment 37675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37675&action=edit Bug 13885 - Cataloging search header should include more options This patch adds the check in and standard catalog search to cataloging-search.inc To test: 1 - Apply patch 2 - Go to More->Cataloging 3 - Search in each tab (Cataloging search / Check out / Check in / Standard search) and ensure that all work as expected Signed-off-by: Frederic Demians - Added search options work properly, and are consistently named. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 12:19:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 10:19:27 +0000 Subject: [Koha-bugs] [Bug 13975] Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13975 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37620|0 |1 is obsolete| | CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- Created attachment 37676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37676&action=edit Bug 13975: Remove compilation warning about encoding pragma Signed-off-by: Frederic Demians I confirm the warning (on Perl version above 5.14). And that the patch fix the warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 12:20:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 10:20:02 +0000 Subject: [Koha-bugs] [Bug 13975] Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13975 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 12:41:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 10:41:32 +0000 Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in ISSUESLIP and ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 12:41:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 10:41:34 +0000 Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in ISSUESLIP and ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36824|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians --- Created attachment 37677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37677&action=edit Add biblioitems to ISSUESLIP and ISSUEQSLIP in C4::Members::IssueSlip() Document all expansions within C4::Members::IssueSlip() http://bugs.koha-community.org/show_bug.cgi?id=13819 Signed-off-by: Frederic Demians - Works as described. ISBN appears on ISSUESLIP & ISSUEQSLIP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 15:58:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 13:58:39 +0000 Subject: [Koha-bugs] [Bug 13849] Introduce acceptance tests with cucumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849 --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 37678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37678&action=edit Trigger script for Cucumber tests suite -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 17:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 15:02:29 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37325|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 37679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37679&action=edit Bug 13889 - Add information about cron jobs to system log This patch adds information about cron jobs performed and make it viewable under Home > Tools > Logs ("Browse system logs") To test: Apply patch - Got to system preferences and set 'CronjobLog' to: [Log] information from cron jobs. - Run some cron jobs - Go to Home > Tools > Logs - Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it with Action "All" and Submit. - Output should show Dae/time and info about Cron jobs Rebased to work on top of Bug 6911 (conflict in viewlog.tt) /MV Rebased after applying patch for Bug 6911 /MV Conflicts resolved: misc/cronjobs/overdue_notices.pl misc/cronjobs/cleanup_database.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 17:13:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 15:13:25 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #5 from Marc V?ron --- (In reply to Fr?d?ric Demians from comment #3) > I wasn't able to apply this patch on master: > > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt). Hi Fr?d?ric, thanks for testing. The patch depends on Bug 6911 (has changes to viewlog.tt), my patch should apply on top of this bug. I rebased 2 more conflicts after applying 6911. Re-tested applying, works for me on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 18:51:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 16:51:46 +0000 Subject: [Koha-bugs] [Bug 5294] Vendor name shows with '%20' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5294 hamlet changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eganyan_79 at mail.ru URL| |http://scilib.narod.ru/Inte | |l/Lonsdale/contents.htm -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 11 22:19:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 Apr 2015 20:19:14 +0000 Subject: [Koha-bugs] [Bug 13980] New: Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980 Bug ID: 13980 Summary: Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.p l Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 37680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37680&action=edit excerpt from /var/log/koha/koha-error_log This error occurs when trying to save the following MARC record from the Amicus Z39.50 server: 01800cam 2200349 a 4500 001 000042344666 003 CaOOAMICUS 005 20140203 .0 008 110402s2011 ohu 000 1 eng d 020 $a 9781609282066 (pbk.) 020 $a 160928206X (pbk.) 040 $a CaBVA $b eng 043 $a n-us-ma 100 1 $a Lanyon, Josh. 245 10 $a All she wrote / $c Josh Lanyon. 260 $a Cincinnati, OH : $b Samhain Pub., $c c2011. 300 $a 270 p. ; $c 22 cm. 490 1 $a Holmes & Moriarity ; $v book 2 520 $a A murderous fall down icy stairs is nearly the death of Anna Hitchcock, the much-beloved "American Agatha Christie" and Christopher Holmes' former mentor. Anna's plea for him to host her annual winter writing retreat touches all Kit's sore spots-- traveling, teaching writing classes, and separation from his new lover, J.X. Moriarity. For J.X., Kit's cancellation of yet another romantic weekend is the death knell of a relationship that has been limping along for months. Soon Kit is snooping around Anna's elegant, snowbound mansion in the Berkshires for clues as to who's trying to kill her. Unfortunately, a clever killer is one step ahead. And it may be too late for J.X. to ride to the rescue. 650 0 $a Holmes, Christopher (Fictitious character) $v Fiction. 650 0 $a Moriarity, J. X. (Fictitious character) $v Fiction. 650 0 $a Private investigators $v Fiction. 650 0 $a Authors $v Fiction. 650 00 $a Ex-police officers as detectives $v Fiction. 650 0 $a Gay men $v Fiction. 650 0 $a Murderers $v Fiction. 651 0 $a Berkshire Hills (Mass.) $v Fiction. 655 4 $a Mystery fiction. 655 4 $a Gay fiction. 655 4 $a Erotic stories. 800 1 $a Lanyon, Josh. $t Holmes & Moriarity ; $v bk. 2 ; $v bk. 2. 852 $9 1 $a CaBVA $z ILL: yes Do a Z39.50 search on author 'lanyon, josh' and import the record for 'All she wrote'. It fails when trying to save the record on Koha 3.18.05 running on openSUSE built from a tarball. It works on Koha 3.18.04 running on Debian 7 installed from koha-common. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:32:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:32:06 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36223|0 |1 is obsolete| | --- Comment #273 from M. Tompsett --- Created attachment 37681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37681&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:32:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:32:20 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36224|0 |1 is obsolete| | --- Comment #274 from M. Tompsett --- Created attachment 37682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37682&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:32:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:32:30 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36225|0 |1 is obsolete| | --- Comment #275 from M. Tompsett --- Created attachment 37683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37683&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:32:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:32:49 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36226|0 |1 is obsolete| | --- Comment #276 from M. Tompsett --- Created attachment 37684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37684&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:34:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:34:49 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37681|0 |1 is obsolete| | --- Comment #277 from M. Tompsett --- Created attachment 37685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37685&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:35:00 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37682|0 |1 is obsolete| | --- Comment #278 from M. Tompsett --- Created attachment 37686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37686&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:35:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:35:19 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37683|0 |1 is obsolete| | --- Comment #279 from M. Tompsett --- Created attachment 37687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37687&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:35:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:35:28 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37684|0 |1 is obsolete| | --- Comment #280 from M. Tompsett --- Created attachment 37688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37688&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:35:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:35:36 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36227|0 |1 is obsolete| | --- Comment #281 from M. Tompsett --- Created attachment 37689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37689&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:35:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:35:49 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36228|0 |1 is obsolete| | --- Comment #282 from M. Tompsett --- Created attachment 37690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37690&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:36:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:36:05 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36229|0 |1 is obsolete| | --- Comment #283 from M. Tompsett --- Created attachment 37691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37691&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:36:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:36:16 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36230|0 |1 is obsolete| | --- Comment #284 from M. Tompsett --- Created attachment 37692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37692&action=edit Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN --------- 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:36:24 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36231|0 |1 is obsolete| | --- Comment #285 from M. Tompsett --- Created attachment 37693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37693&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, in that the protocol is assumed in the OpacBaseURL system preference. It also adds improved error handling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 03:36:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 01:36:33 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36232|0 |1 is obsolete| | --- Comment #286 from M. Tompsett --- Created attachment 37694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37694&action=edit Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 04:59:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 02:59:55 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36177|0 |1 is obsolete| | --- Comment #89 from M. Tompsett --- Created attachment 37695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37695&action=edit Bug 5010 - Fix OPACBaseURL to include protocol First, it is strongly recommended to set the OPACBaseURL. But this patch allows the inclusion of the protocol and not just a site. Next, C4/Auth now puts OPACBaseURL into the template parameters regardless of OPAC or Staff clients. t/db_dependent/Auth.t was tweaked to add a check for confirming that get_template_and_user adds OPACBaseURL to both OPAC and Staff templates. In the staff client, once the OPACBaseURL is set, you get a nice OPAC View link when viewing a biblio's detail. It should reflect the protocol used now. Hard coded 'http://' strings were removed from the sample_notices.sql files. This is what required also updating the letters table in the updatedatabase.pl script. The explanation text in the sysprefs.sql needed updating too to reflect the inclusion of the protocol. And this was the other update done in the updatedatabase.pl script. The opac.pref file was similarly changed as well. catalogue/detail.pl had no need to pass a custom OpacUrl value, since C4/Auth passes the required OPACBaseURL, so it and the corresponding template were modified. Both the MARC21 and NORMARC intranet details files had 'http://' hard coded in them. This was removed. Both the bootstrap and prog theme opac-detail template had a protocol parameter that was used. The logic for the parameter was not removed, because it is used extensively in one template. Perhaps it should be used to simplify the other. However, the calculated current_url parameter had references to the protocol removed, because of the changes to OPACBaseURL. opac/opac-shareshelf.pl had a hard coded 'http://' which was removed. t/db_dependent/Auth_with_cas.t had 'http://' added to the value set for OPACBaseURL. In virtualshelves/sendshelf.pl explicit code which sent the OPACBaseURL preference was removed, since C4/Auth sends it all the time now. C4::Context::set_preference was tweaked to ensure that OPACBaseURL would always start with http. t/db_dependent/Context.t was tweaked to specifically test this. The Shibboleth authentication needs OPACBaseURL set, and that it be https protocol. The _get_uri routine was tweaked to always pass back https:// as the protocol on the OPACBaseURL. t/Auth_with_shibboleth.t was tweaked to specifically test the changes. TEST PLAN --------- This is not an easy patch to test. Difficulties include: - configuring Koha to run under https (tweaking apache2 isn't so hard, just tricky) - configuring Koha to run OPAC and Staff with Plak (since code with comments about plak were sliced out) - configuring Koha to use CAS (may be requires for the CAS test) 1) Apply patch 2) Make sure OPACBaseURL is set without the protocol included. UPDATEDATABASE 3) back up your DB 4) ./installer/data/mysql/updatedatabase.pl -- It should run without errors. 5) Look up the OPACBaseURL system preference in the staff client -- It should have http:// prepended. 6) Run the mysqlclient from your koha git directory USE koha_library; SELECT content FROM letter WHERE content LIKE "%<>%"; -- There should be no prepended http:// on the <>. 7) restore your DB 8) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. AUTH 9) Call up staff client. 10) Call up OPAC. -- C4/Auth.pm doesn't barf. 11) Call up Plack staff client 12) Call up Plack OPAC. -- C4/Auth.pm doesn't barf. 13) prove -v t/db_dependent/Auth.t CONTEXT 14) Home -> Koha administration -> Global System Preferences -> OPAC 15) Modify and save OPACBaseURL to not have http:// or https:// on it. -- It should be modified to include http:// 16) Modify and save another system preference. -- It should save normally 17) prove -v t/db_dependent/Context.t CATALOGUE/DETAIL (tt & pl) 18) Confirm the OPACBaseURL is set 19) Navigate to any biblio details in the staff client -- There should be a "OPAC view" link which has the correct http:// or https:// in it. SQL (sample notices and sysprefs) 20) Run the mysqlclient from your koha git directory USE koha_library; DELETE FROM letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/en/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/it-IT/necessari/notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; DELETE FROM letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql; SELECT content FROM letter WHERE content LIKE "%<>%"; -- Each of the selects should should lines that have <> starting them, but no hard-coded http:// DELETE FROM systempreferences; source installer/data/mysql/sysprefs.sql; SELECT * FROM systempreferences WHERE variable='OPACBaseURL'; -- The explanation should reflect the new explanation. QUIT 21) restore your DB 22) Make sure OPACBaseURL is set with the protocol included, preferably https. -- Using https requires a bunch of apache2 tweaks. SLIM2INTRANETDETAIL 23) Set 'XSLTDetailsDisplay' system preference to default. 24) Set 'marcflavour' system preference to MARC21. 25) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// 26) Set 'marcflavour' system preference to NORMARC. 27) View any biblio's details. -- the URL beside 'OPAC View' should have the appropriate http:// or https:// OPAC-DETAIL 28) Set 'opacthemes' to bootstrap. 29) Set 'SocialNetworks' to enabled. 30) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. 31) Set 'opacthemes' to prog. 32) In OPAC, view any biblio's details. -- the Share links should have the appropriate protocol on the OPACBaseURL. AUTH_WITH_CAS 33) prove -v t/db_dependent/Auth_with_cas.t OPAC-SHARESHELF 34) Set 'OpacAllowSharingPrivateLists' to allow. 35) In OPAC, 'Save to Lists' a search result. 36) Save it to a new private list. 37) Click the Lists button, and select the new list. 38) Click the Share button. AUTH_WITH_SHIBBOLETH 39) prove -v t/Auth_with_shibboleth.t -- needs to be tests on Debian, because I can't get the Test::DBIx::Class installed in Ubuntu. :( Rebased again not on kohadevbox... while trying to test 6874. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 05:54:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 03:54:05 +0000 Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported only as DEFAULT frameworks, not what they were originally In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jacek! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 05:54:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 03:54:55 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 05:55:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 03:55:46 +0000 Subject: [Koha-bugs] [Bug 13936] Fix patrons search on using the checkout tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13936 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks JOnathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 05:56:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 03:56:18 +0000 Subject: [Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour finesCalendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 05:56:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 03:56:53 +0000 Subject: [Koha-bugs] [Bug 13372] Items lost report improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13372 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 05:57:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 03:57:29 +0000 Subject: [Koha-bugs] [Bug 13866] Columns configuration - Patrons search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13866 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:02:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:02:40 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37685|0 |1 is obsolete| | --- Comment #287 from M. Tompsett --- Created attachment 37696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37696&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:02:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:02:49 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37686|0 |1 is obsolete| | --- Comment #288 from M. Tompsett --- Created attachment 37697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37697&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:02:58 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37687|0 |1 is obsolete| | --- Comment #289 from M. Tompsett --- Created attachment 37698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37698&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.7 65.0 66.7 100.0 100.0 0.2 86.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:03:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:03:08 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37688|0 |1 is obsolete| | --- Comment #290 from M. Tompsett --- Created attachment 37699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37699&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:03:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:03:17 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37689|0 |1 is obsolete| | --- Comment #291 from M. Tompsett --- Created attachment 37700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37700&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:03:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:03:25 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37690|0 |1 is obsolete| | --- Comment #292 from M. Tompsett --- Created attachment 37701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37701&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:03:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:03:34 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37691|0 |1 is obsolete| | --- Comment #293 from M. Tompsett --- Created attachment 37702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37702&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:03:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:03:42 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37692|0 |1 is obsolete| | --- Comment #294 from M. Tompsett --- Created attachment 37703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37703&action=edit Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN --------- 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:03:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:03:55 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37693|0 |1 is obsolete| | --- Comment #295 from M. Tompsett --- Created attachment 37704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37704&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, in that the protocol is assumed in the OpacBaseURL system preference. It also adds improved error handling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:04:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:04:07 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37694|0 |1 is obsolete| | --- Comment #296 from M. Tompsett --- Created attachment 37705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37705&action=edit Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:04:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:04:19 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #297 from M. Tompsett --- Created attachment 37706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37706&action=edit Bug 6874: Catch warnings for clean tests. I hate noisy tests, so I cleaned them up. MEGA TEST PLAN -------------- git checkout -b bug_6874 origin/master git bz apply 6874 -- yes, it should all apply smoothly. I intentionally restored an old backup from a couple months ago to force the upgrade. staff client: -- upgrade -- login Koha administration MARC Bibliographic framework MARC structure (for BKS) Search for 856 Subfields Edit (for u) Other options Plugin: upload.pl Save changes Search the catalog tab {choose a word, any word. I used fancy, because I knew we had a cookbook} click first link Edit Edit record 8 (that's the tab name) click the name for 856 scroll down to u and click the plugin icon -- Correctly got a configuration error message. At a command prompt: vi ~/koha-dev/etc/koha-conf.xml /enable_plug -- add in: {appropriate path. I used /home/mtompset/uploads} :wq mkdir {appropriate path used} -- I even added some subdirectories sudo chown -R -v www-data.www-data {appropriate path used} Back in staff client: click the plugin icon again -- this time an upload screen pops up click the 'Upload file' button -- message about no file or destination browse for a file, select one click the 'Upload file' button -- message about no destination click the 'Cancel' button click the plugin icon click a destination radio button click the 'Upload file' button -- message about no file browse for a file, select one click the 'Upload file' button -- message about success click the 'close' button. -- the text box has been filled in with a nice URL click the plugin icon click cancel click the plugin icon click delete -- the test box should be blanked, and a success message given click Close -- reupload a file properly click the plugin icon click delete click upload file browse for a file, select a destination, click upload file click close on success message click 'Clone this subfield' click the second plugin icon click delete click close click the first plugin icon -- Nice error message about a URL which points to nothing. click cancel In the second 856$u type in a URL (eg. www.google.com) click the second plugin icon -- this jumps immediately to the upload screen, but does not give an error message, because the URL does not have opac-retrieve-file in it. click save (we need to save the bibliographic record) In OPAC: search for the same word (I used fancy) find the entry you just updated with links click the two links. The dangling entry should give you a 500 error, and the other link should work just fine. get back to the detail page In staff client: edit edit record 8 change the 856$u to a valid file in the first link. save In OPAC: refresh the detail page, and click the first link again this time it should get downloaded nicely. >From a command line: prove -v t/db_dependent/UploadedFiles.t perldoc C4::Biblio perldoc C4::UploadedFiles One more round of tests tomorrow, and this should be ready. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:47:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:47:18 +0000 Subject: [Koha-bugs] [Bug 2486] Show user comments in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 hamlet changed: What |Removed |Added ---------------------------------------------------------------------------- Deadline| |2015-06-15 CC| |eganyan_79 at mail.ru -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:48:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:48:03 +0000 Subject: [Koha-bugs] [Bug 2486] Show user comments in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 hamlet changed: What |Removed |Added ---------------------------------------------------------------------------- Deadline|2015-06-15 |2015-05-15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:50:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:50:15 +0000 Subject: [Koha-bugs] [Bug 2486] Show user comments in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 hamlet changed: What |Removed |Added ---------------------------------------------------------------------------- Deadline|2015-05-15 |2015-04-12 When did the bot| |2015-05-29 last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 06:51:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 04:51:45 +0000 Subject: [Koha-bugs] [Bug 2486] Show user comments in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 hamlet changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |eganyan_79 at mail.ru -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 09:48:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 07:48:59 +0000 Subject: [Koha-bugs] [Bug 13896] PID is created in /tmp/ instead of in /var/run/koha/... In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 09:57:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 07:57:29 +0000 Subject: [Koha-bugs] [Bug 2542] Manual fine/credit fail on superfluous characters ( e.g. '$' ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2542 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 10:01:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 08:01:55 +0000 Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 10:07:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 08:07:06 +0000 Subject: [Koha-bugs] [Bug 13939] ILS-DI function GetServices doesn't work when the item/biblio is available for hold for specific patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13939 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |chris at bigballofwax.co.nz Severity|trivial |normal Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 12:06:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 10:06:00 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #6 from Fr?d?ric Demians --- (In reply to Marc V?ron from comment #5) > The patch depends on Bug 6911 (has changes to viewlog.tt), my patch should > apply on top of this bug. > I rebased 2 more conflicts after applying 6911. > Re-tested applying, works for me on current master. Works for me also. Your patch add a new syspref in .pref file. I think you still have to add it in the DB also: http://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 16:03:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 14:03:12 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #7 from Marc V?ron --- Created attachment 37707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37707&action=edit [Follow-up]Bug 13889 Add syspref to sysprefs.sql and updatedatabase.pl This patch adds the syspref CronjobLog to sysprefs.sql and updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 16:10:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 14:10:51 +0000 Subject: [Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour finesCalendar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 37708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37708&action=edit Bug 13909: (QA followup) fix references to get_chargeable_units Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 20:18:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 18:18:25 +0000 Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL even if turned off by system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch --- Comment #2 from Marc V?ron --- Re-tested, still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 20:29:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 18:29:58 +0000 Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 22:44:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 20:44:56 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 22:44:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 20:44:59 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37108|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 37709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37709&action=edit [SIGNED OFF] Bug 13790 - Add unique id issue_id to issues and old_issues tables Test Plan: 1) Use a database with existing issues and old issues 2) Apply this patch 3) Run updatedatabase 4) Inspect the database a) old_issues should now have a column issue_id starting with 1 b) issues should now have a column issue_id starting with the number of rows in the old_issues table plus one 5) Perform a checkout, note it is written to the database 6) Check in the checked out item, note it is moved to the old_issues table Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 22:45:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 20:45:07 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37109|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 37710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37710&action=edit [SIGNED OFF] Bug 13790 - Update Koha Schema Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 12 22:47:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 20:47:35 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #9 from Nick Clemens --- I cleared a simple conflict in updatedatabase (or attempted at least) and tested and all worked as expected. Hope it was okay to clear and sign off in one step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 00:17:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 22:17:13 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #24 from Robin Sheat --- (In reply to Kyle M Hall from comment #21) > (In reply to Robin Sheat from comment #19) > > This sounds dangerous for plack. > > I was not aware of that! Should we create a bug report to re-add the > rollback to all unit tests? I think I was confused, I didn't realise it was referencing test cases, which won't be run under plack at all, and was to do with regular koha scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 00:20:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 22:20:54 +0000 Subject: [Koha-bugs] [Bug 5294] Vendor name shows with '%20' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5294 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://scilib.narod.ru/Inte | |l/Lonsdale/contents.htm | CC|eganyan_79 at mail.ru | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 01:43:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 Apr 2015 23:43:11 +0000 Subject: [Koha-bugs] [Bug 2486] Show user comments in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC|eganyan_79 at mail.ru | QA Contact|eganyan_79 at mail.ru |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 08:30:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 06:30:31 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #13 from Fr?d?ric Demians --- Thank you so much Jonathan for pushing to a better handling of print messages. Isn't there something that could be improve conceptually or from an architectural perspective? (always possible of course :-) On the one hand, there is C4::Letters module, and on the other hand process_message_queue.pl and gather_print_notices.pl using these module. Both .pl scripts are doing the same thing: gathering messages from the queue, and process them (send them, and switch there status from pending to sent or failed). For process_message_queue.pl, there is just one call to C4::Letter::SendQueuedMessages. When gather_print_notices.pl do all kind of processing, and then call C4::Letter internal function like _set_message_status. Shouldn't be logical just to merge both .pl scripts, and put all code in SendQueueMessage? SendQueueMessage interface could be extended with more parameters. For example: SendQueueMessage({ mtt => 'print', split => '0|1', dir => '/tmp', email_to => 'a at a.fr', format => 'html|csv', groupby => ['branch', 'letter'] }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 08:52:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 06:52:52 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 08:52:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 06:52:54 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37679|0 |1 is obsolete| | Attachment #37707|0 |1 is obsolete| | --- Comment #8 from Fr?d?ric Demians --- Created attachment 37711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37711&action=edit Bug 13889 - Add information about cron jobs to system log This patch adds information about cron jobs performed and make it viewable under Home > Tools > Logs ("Browse system logs") To test: Apply patch - Got to system preferences and set 'CronjobLog' to: [Log] information from cron jobs. - Run some cron jobs - Go to Home > Tools > Logs - Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it with Action "All" and Submit. - Output should show Date/time and info about Cron jobs Rebased to work on top of Bug 6911 (conflict in viewlog.tt) /MV Rebased after applying patch for Bug 6911 /MV Conflicts resolved: misc/cronjobs/overdue_notices.pl misc/cronjobs/cleanup_database.pl Signed-off-by: Frederic Demians - Merge both patches, and fix updatedatabase.pl - Works as described. Provide intersting feedback from cronjob scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 09:14:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 07:14:13 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 --- Comment #5 from Magnus Enger --- Hi! This is really interesting, but could you please submit a patch as described here: http://wiki.koha-community.org/wiki/Version_Control_Using_Git#Share_with_the_rest_of_the_world The preferred way to submit the actual patch these days is to attach it to the bug here on Bugzilla, and many people use Git bz for that: http://wiki.koha-community.org/wiki/Git_bz_configuration#Submitting_a_patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 09:24:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 07:24:23 +0000 Subject: [Koha-bugs] [Bug 13967] System preferences need a package In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 --- Comment #25 from Jonathan Druart --- (In reply to Robin Sheat from comment #24) > (In reply to Kyle M Hall from comment #21) > > (In reply to Robin Sheat from comment #19) > > > This sounds dangerous for plack. > > > > I was not aware of that! Should we create a bug report to re-add the > > rollback to all unit tests? > > I think I was confused, I didn't realise it was referencing test cases, > which won't be run under plack at all, and was to do with regular koha > scripts. Yes, transactions are not used using the interface (except from tools/batch_delete_records.pl, this script explicitly rollbacks). We could add the rollback call at the end of each db dependent test file, but... it's just useless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 10:12:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 08:12:35 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 --- Comment #11 from Jonathan Druart --- Created attachment 37712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37712&action=edit Bug 8684: Add regression tests for SearchItemsByField -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 10:20:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 08:20:00 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 10:20:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 08:20:03 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37416|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 37713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37713&action=edit Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 10:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 08:28:05 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #14 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #13) > Thank you so much Jonathan for pushing to a better handling of print > messages. > > Isn't there something that could be improve conceptually or from an > architectural perspective? (always possible of course :-) Yes of course, and that was the idea. But as you can see, I have submitted this bug and bug 11678 1 year ago and nothing has moved yet... All should be done with small steps, and these 2 bugs are 2 steps. The idea is to have only 1 script to sent notices, I would also see misc/cronjobs/printoverdues.sh merged in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 10:36:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 08:36:19 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi Mason, can the first patch be obsoleted? I think this is not a problem specific to OverDrive, but to the error messages from the SIP server? Shoudl we adjust the title? To have the library show up in the release notes as a sponsor, you can add Sponsored-by: ... to the commit message (http://wiki.koha-community.org/wiki/Commit_messages) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 10:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 08:37:27 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #5 from Jonathan Druart --- So, switching my patch back in the needs signof queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 10:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 08:48:23 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 10:48:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 08:48:27 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36840|0 |1 is obsolete| | --- Comment #20 from Magnus Enger --- Created attachment 37714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37714&action=edit Bug 11084 - Delete biblios on Leader 05 == d Position 05 of the leader in MARC 21 indicates the record's status. A lower case 'd' indicates that the record is to be deleted (http://www.loc.gov/marc/authority/adleader.html). This patch adds a cronjob script that may be run nightly to delete records where position 05 of the leader is set to 'd'. Test Plan: 1) Edit one or more records, and set the leader position 05 to 'd'. 2) Run misc/cronjobs/delete_records_via_leader.pl -c -v 3) Those records should either be deleted, or an error message should state why they were not. Signed-off-by: Magnus Enger Works as advertised. Edited a record with an item to have leader05 = d, then ran delete_records_via_leader.pl with -c and got a message that the record could not be deleted because of the item. Removed the item and the script deleted the record. Tried with another record with an item, this time with the -i option and the record was deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 10:53:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 08:53:54 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Magnus Enger --- $ git bz apply 13265 Bug 13265 - Still too many search cursor cookies 33616 - Bug 13265 - Still too many search cursor cookies Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13265 - Still too many search cursor cookies Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Failed to merge in the changes. Patch failed at 0001 Bug 13265 - Still too many search cursor cookies The copy of the patch that failed is found in: /home/magnus/scripts/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-13265---Still-too-many-search-cursor-cookies-bMkL_V.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:12:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:12:39 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #6 from Magnus Enger --- I can't reproduce the problem on current master. I spin up kohadevbox, drop and recreate the database, then go to the webinstaller. After logging in once i can start to use the webinstaller. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:12:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:12:48 +0000 Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:12:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:12:51 +0000 Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29964|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 37715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37715&action=edit Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem Squashed this rogue variable initialization Test plan: 1/ Place a hold at a biblio level (on the next available item) 2/ Without this patch you get placerequest.pl: Use of uninitialized value $checkitem in string ne at /home/koha/src/reserve/placerequest.pl line 75. placerequest.pl: Use of uninitialized value $checkitem in string ne at /home/koha/src/reserve/placerequest.pl line 101. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:19:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:19:54 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 --- Comment #7 from Magnus Enger --- I should have said "then go to the webinstaller under Plack (port 5001)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:23:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:23:07 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 --- Comment #8 from Jonathan Druart --- Magnuse is running perl 5.14. I confirm the issue on current master, using perl 5.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:26:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:26:47 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #55 from Jonathan Druart --- Minor since I suppose it existed before: FAIL cataloguing/value_builder/dateaccessioned.pl FAIL forbidden patterns forbidden pattern: tab char (line 54) FAIL members/moremember.pl FAIL forbidden patterns forbidden pattern: tab char (line 136) FAIL C4/Barcodes/hbyymmincr.pm FAIL forbidden patterns forbidden pattern: tab char (line 76) forbidden pattern: tab char (line 106) FAIL C4/Barcodes/annual.pm FAIL forbidden patterns forbidden pattern: tab char (line 84) forbidden pattern: tab char (line 63) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 46) forbidden pattern: tab char (line 52) FAIL C4/Items.pm FAIL forbidden patterns forbidden pattern: trailing space char (line 650) FAIL members/readingrec.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 81) Could you explain why you replaced - my $rsstimestamp = C4::Dates->new($result->{datereviewed},"iso"); - my $rsstimestamp_output = $rsstimestamp->output("rfc822"); - $result->{timestamp} = $rsstimestamp_output; + $result->{timestamp} = strftime("%Y-%m-%dT%H:%M:%S-00:00", gmtime); and - $datereceived = C4::Dates->output('iso') unless $datereceived; + $datereceived = output_pref({ dt=>DateTime->now(), dateonly=>1, otputpref=>'iso' }) unless $datereceived; I would use Koha::DateUtils everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:35:17 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to pages in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #1 from Fr?d?ric Demians --- Are you talking about id/class attributes of exclusively, or about other tags? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:37:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:37:59 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:38:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:38:02 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37357|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 37716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37716&action=edit Bug 13109 - Serial failure for received and general viewing. to test... 1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate' an example url would be... http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1 observe error... 'Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /your/koha/C4/Serials.pm line 2325' 2/ apply patch 3/ repeat step 1/ observe that detail page displays OK Signed-off-by: Jonathan Druart I confirm the issue if startdate is null (can exist with old data, before the js check on the form). Amended patch: Remove trailing space char and the link to the bz number (can be found using git log). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:38:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:38:23 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:50:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:50:55 +0000 Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL even if turned off by system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:50:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:50:57 +0000 Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL even if turned off by system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37274|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 37717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37717&action=edit Bug 13917: OPAC: Putting holds still possible by URL even if turned off by system preference To test: 1) Prepare an URL that put's a hold in OPAC (see comment #1), e.g. [YOUR SERVER]/cgi-bin/koha/opac-reserve.pl?biblionumbers=1 2) Set system preference 'RequestOnOpac' to 'Don't allow patrons to place holds on items from the OPAC.' 3) Go diectly to this URL. Result: The page displays to confirm hold (wrong) 4) Apply patch 5) Repeat step 3 Result: Redirect to 404 page (OK) 6) Set system preference to "Allow" 7) Repeat step 3 Result: The page displays to confirm hold (OK), like it would be from link in OPAC. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:51:28 +0000 Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL even if turned off by system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Hum, I would raise the severity to major for this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:56:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:56:46 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart --- Julian, 1/ I would suggest you to replace $sth = $dbh->prepare($query); $sth->execute($biblionumber1, $status); $count = $sth->fetchrow_array; with a call to $dbh->selectrow_array 2/ use perltidy on new file. 3/ use the qa script to catch the trailing spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:57:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:57:27 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Jonathan Druart --- Sorry, wrong bug report :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 11:57:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 09:57:39 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart --- Julian, 1/ I would suggest you to replace $sth = $dbh->prepare($query); $sth->execute($biblionumber1, $status); $count = $sth->fetchrow_array; with a call to $dbh->selectrow_array 2/ use perltidy on new file. 3/ use the qa script to catch the trailing spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:00:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:00:53 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ids to pages in staff |Add ids to tag in |client where missing |staff client where missing --- Comment #2 from Katrin Fischer --- Hi Frederic, thx for asking - I have clarified the title of the bug. I meant the tag here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:04:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:04:58 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 --- Comment #5 from Jonathan Druart --- Comment on attachment 37178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37178 Bug 13899 : Adding misc/devel/coverage.pl Review of attachment 37178: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13899&attachment=37178) ----------------------------------------------------------------- And please run perltidy on new files. ::: misc/devel/coverage.pl @@ +34,5 @@ > +use C4::Context; > + > +my $KOHA_PATH = C4::Context->config("intranetdir"); > + > +chdir $KOHA_PATH; I would not do that, I'd prefer compare getcwd and intranetdir. If they differ, raise an error. @@ +37,5 @@ > + > +chdir $KOHA_PATH; > + > +eval{ > + require Devel::Cover; Add it to the list of deps (see C4/Installer/PerlDependencies.pm). @@ +41,5 @@ > + require Devel::Cover; > +}; > + > +if ($@) { > + say "Devel::Cover needs to be installed"; And don't catch the deps error. @@ +49,5 @@ > +#Delete old coverage > +system("cover -delete"); > + > +#Start the cover > +system("PERL5OPT=-MDevel::Cover /usr/bin/prove -r t/"); What about existing PERL5OPT? Have a look at prove -M -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:05:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:05:05 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:06:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:06:25 +0000 Subject: [Koha-bugs] [Bug 11496] The number of tested records when searching for duplicates during import is too low In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:12:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:12:26 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mtj at kohaaloha.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:12:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:12:50 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #20 from Marc V?ron --- After applying t/db_dependent/Members.t fails at lin 102 with: # Failed test 'Confirm MoveMemberToDeleted.' # at t/db_dependent/Members.t line 102. # Structures begin differing at: # $got->{primary_contact_method} = Does not exist # $expected->{primary_contact_method} = undef The reason is that the field primary_contact_method is added to the table borrowers but not to the table deletedborrowers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:14:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:14:58 +0000 Subject: [Koha-bugs] [Bug 13981] New: Transliterate rule for oe and ae Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 Bug ID: 13981 Summary: Transliterate rule for oe and ae Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In ICU configuration, add a transliterate rule for ? = oe and ? = ae. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:15:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:15:05 +0000 Subject: [Koha-bugs] [Bug 13981] Transliterate rule for oe and ae In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:23:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:23:59 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:28:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:28:00 +0000 Subject: [Koha-bugs] [Bug 13981] Transliterate rule for oe and ae In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:28:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:28:02 +0000 Subject: [Koha-bugs] [Bug 13981] Transliterate rule for oe and ae In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 --- Comment #1 from Fridolin SOMERS --- Created attachment 37718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37718&action=edit Bug 13981 - Transliterate rule for oe and ae NOTE : I use HTML codes for special characters to avoir encoding issues in patch file. In ICU configuration, add a transliterate rule for œ = oe æ = ae Test plan : - Without patch - Create a record R1 with title containing for example "cœur" - Create a record R2 with title containing for example "coeur" - Index those records - Search for "cœur" => You only find R1 - Search for "coeur" => You only find R2 - Apply patch - Restart zebra - Index R1 and R2 - Search for "cœur" => You find R1 and R2 - Search for "coeur" => You find R1 and R2 (Same test plan for ae) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:30:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:30:51 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is not correct In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 --- Comment #1 from Katrin Fischer --- Hm retesting this, I now see different results - maybe we are only missing an error message for the 'too early'? It seems to list all messages that occured one after the other. For the 4 items on my patron account it reads now: Please note: Your loan renewal failed because of the following reason(s): This item is on hold for another patron. You have renewed this item the maximum number of times allowed. This item is on hold for another patron. And this is correct: 1 on hold 2 not renewable 3 on hold 4 renewed But it's still very confusing - wouldn't it make more sense to say: Not all items could be renewed, please check the table of checkouts carefully? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:48:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:48:34 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #5 from Jonathan Druart --- The "renew all" button appears (same as intranet), should not we remove it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:50:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:50:17 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #6 from Jonathan Druart --- I had 2 items, 1 with an hold (not renewable). I clicked on "renew all" and got "Please note: Your loan renewal failed because of the following reason(s): This item is on hold for another patron." 1 has been renewed (Renewed!) not the other. Could we get another tester on this one please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:51:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:51:30 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #56 from Marc V?ron --- Hi Jonathan, Regarding forbidden chars like tabs: I did not clean up existing things. Regarding your questions: I propose to obsolete the following patches and do them in a next step: "Remove deprecated C4::Dates from opac/opac-showreviews.pl" "Remove C4::Dates from C4/Acquisition.pm" If there are more patches where you have questions or concerns about please do not hesitate to obsolete them. My aim is to have done the "easy ones" in a first round. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:56:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:56:10 +0000 Subject: [Koha-bugs] [Bug 13982] New: Checkouts table not sorting on correct column Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Bug ID: 13982 Summary: Checkouts table not sorting on correct column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The "Date Due" column for checkouts is using the column index 1 to sort by. This column is the one that is used for grouping items into today's checkouts and previous checkouts. This is definitely not the column that should be used. Instead, we should be using column index 2, which contains the raw unformatted due date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:56:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:56:29 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #7 from Katrin Fischer --- Hm, but only the item without the hold was renewed? Or was the item with the hold renewed? I think the confusing message stems is what I noticed on bug 13913 - it just lists without telling you how many or which item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:56:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:56:29 +0000 Subject: [Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13908 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:56:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:56:29 +0000 Subject: [Koha-bugs] [Bug 13908] Checkouts table sorting is not honoring default sort preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13982 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:57:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:57:09 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 --- Comment #6 from Ji?? Kozlovsk? --- Created attachment 37719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37719&action=edit Bug 13930 - Created NCIP svc to effectively parse data from database to JSON in order to query those from xcncip2toolkit koha's connector -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:57:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:57:57 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:58:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:58:51 +0000 Subject: [Koha-bugs] [Bug 3536] Checked In item requiring transfer does not consistently trigger transfer prompt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3536 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7981 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 12:58:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 10:58:51 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Assignee|kyle.m.hall at gmail.com |benjamin.rokseth at kul.oslo.k | |ommune.no See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3536 --- Comment #27 from Jonathan Druart --- HomeOrHoldingBranchReturn has been introduced by bug 3536. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:05:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:05:26 +0000 Subject: [Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:05:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:05:29 +0000 Subject: [Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 --- Comment #1 from Kyle M Hall --- Created attachment 37720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37720&action=edit Bug 13982 - Checkouts table not sorting on correct column The "Date Due" column for checkouts is using the column index 1 to sort by. This column is the one that is used for grouping items into today's checkouts and previous checkouts. This is definitely not the column that should be used. Instead, we should be using column index 2, which contains the raw unformatted due date. Test Plan: 1) Find a patron with some checkouts 2) Checkout a new item so it is due between the due dates of two previously checked out items ( that is, not checked out today ) 3) Attempt to sort by due date 4) Note the sorting is incorrect 5) Apply this patch 6) Clear your browser cache 7) Reload the page 8) Attempt to sort by due date again 9) Note the sorting works correctly this time 10) Verify there are no regressions with bug 13908 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:06:13 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37377|0 |1 is obsolete| | --- Comment #8 from Nicolas Legrand --- Created attachment 37721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37721&action=edit Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:06:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:06:42 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:06:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:06:44 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37721|0 |1 is obsolete| | --- Comment #9 from Nicolas Legrand --- Created attachment 37722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37722&action=edit Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:06:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:06:56 +0000 Subject: [Koha-bugs] [Bug 13983] New: Title shows doubled up in fine description Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13983 Bug ID: 13983 Summary: Title shows doubled up in fine description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To test: - find a patron with overdue fines or created one - go to the fines tab in the patron account - check the description that displays on the 'account' and 'pay fines' tabs: Fine , TITLE OF BOOK : 30/03/2015 23:59 View item TITLE OF BOOK : The title appears doubled up. There is also an additional space after Fine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:08:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:08:32 +0000 Subject: [Koha-bugs] [Bug 13984] New: CardnumberLength missing in sysprefs.sql Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Bug ID: 13984 Summary: CardnumberLength missing in sysprefs.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CardnumberLength added by Bug 10861 is missing in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:08:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:08:38 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:08:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:08:47 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10861 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:08:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:08:47 +0000 Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13984 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:11:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:11:44 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:11:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:11:46 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 --- Comment #1 from Fridolin SOMERS --- Created attachment 37723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37723&action=edit Bug 13984 - CardnumberLength missing in sysprefs.sql Test plan : - create a fresh database with installer - check the presence of the syspref : select value from systempreferences where variable like 'CardnumberLength' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:12:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:12:09 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Database |Installation and upgrade | |(command-line installer) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:14:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:14:21 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |nicolas.legrand at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:14:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:14:46 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > Hm, but only the item without the hold was renewed? Yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:23:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:23:19 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:23:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:23:22 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36615|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 37724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37724&action=edit Bug 7981 - Remove HomeOrHoldingBranchReturn syspref Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:24:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:24:29 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #29 from Jonathan Druart --- Created attachment 37725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37725&action=edit Bug 7981: Remove HomeOrHoldingBranchReturn syspref from C4::UsageStats Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:24:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:24:35 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #30 from Jonathan Druart --- Created attachment 37726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37726&action=edit Bug 7981: Use The Branches TT plugin instead of GetBranchName Note that homebranchname is never used in the template. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:25:47 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #31 from Jonathan Druart --- This should be highlighted in the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:30:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:30:58 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:31:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:31:01 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37723|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 37727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37727&action=edit Bug 13984 - CardnumberLength missing in sysprefs.sql Test plan : - create a fresh database with installer - check the presence of the syspref : select value from systempreferences where variable like 'CardnumberLength' Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:31:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:31:06 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 --- Comment #3 from Jonathan Druart --- Created attachment 37728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37728&action=edit Bug 13984: Add atomic update - Insert pref CardnumberLength if not exists Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:31:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:31:37 +0000 Subject: [Koha-bugs] [Bug 13985] New: Cash Management Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug ID: 13985 Summary: Cash Management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Koha as a POS system - See http://wiki.koha-community.org/wiki/Cash_Management for the RFC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:32:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:32:28 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #11 from Jonathan Druart --- Created attachment 37729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37729&action=edit Bug 13919: Make the tests pass fixing the number of tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:32:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:32:32 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 --- Comment #1 from Martin Renvoize --- POS = Point Of Sale -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 13:37:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 11:37:17 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #57 from Jonathan Druart --- Comment on attachment 36831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36831 Bug 13813 - Remove C4::Dates from C4/Acquisition.pm Review of attachment 36831: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13813&attachment=36831) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +1399,4 @@ > my $order_vendornote = $params->{order_vendornote}; > > my $dbh = C4::Context->dbh; > + $datereceived = output_pref({ dt=>DateTime->now(), dateonly=>1, otputpref=>'iso' }) unless $datereceived; otputpref should be dateformat :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:00:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:00:52 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #58 from Jonathan Druart --- Comment on attachment 36836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36836 Bug 13813 - Remove C4::Dates from PDF templates in acquisitions Review of attachment 36836: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13813&attachment=36836) ----------------------------------------------------------------- ::: acqui/pdfformat/layout2pages.pm @@ +171,4 @@ > $text->text($basketgroup->{'id'}); > > # print the date > + my $today = output_pref({ dt=>DateTime->now(), dateonly=>1 }); Should be output_pref({ dt => dt_from_string, dateonly => 1 }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:02:12 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #59 from Jonathan Druart --- Comment on attachment 36831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36831 Bug 13813 - Remove C4::Dates from C4/Acquisition.pm Review of attachment 36831: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13813&attachment=36831) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +27,5 @@ > use C4::Biblio; > use C4::Contract; > use C4::Debug; > use C4::Templates qw(gettemplate); > +use Koha::DateUtils; Hum, why? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:04:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:04:05 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #60 from Jonathan Druart --- (In reply to Marc V?ron from comment #56) > Hi Jonathan, > > Regarding forbidden chars like tabs: I did not clean up existing things. > > Regarding your questions: > > I propose to obsolete the following patches and do them in a next step: > > "Remove deprecated C4::Dates from opac/opac-showreviews.pl" > "Remove C4::Dates from C4/Acquisition.pm" > > If there are more patches where you have questions or concerns about please > do not hesitate to obsolete them. My aim is to have done the "easy ones" in > a first round. No, keep it. Koha::DateUtils does not support rfc822 format, so I am fine for using strftime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:08:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:08:39 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #3 from Fr?d?ric Demians --- Several TT files have without id/class. We need a test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:13:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:13:45 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36831|0 |1 is obsolete| | --- Comment #61 from Marc V?ron --- Created attachment 37730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37730&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat) / MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:28:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:28:20 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36836|0 |1 is obsolete| | --- Comment #62 from Marc V?ron --- Created attachment 37731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37731&action=edit Bug 13813 - Remove C4::Dates from PDF templates in acquisitions To test: Apply patch In Acquisitions, go to a vendor's "Basket grouping" Find a basket and print order Change PDF templates using syspref OrderPdfFormat and test for - English 2-page - English 3-page - French 3-page - German 2-page Amended following comment #58 /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:40:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:40:45 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37730|0 |1 is obsolete| | --- Comment #63 from Marc V?ron --- Created attachment 37732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37732&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat), See comment #57 / MV Amended because of "use Koha::DateUtils;" instead of original, See comment #59 /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:43:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:43:46 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37732|0 |1 is obsolete| | --- Comment #64 from Marc V?ron --- Comment on attachment 37732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37732 Bug 13813 - Remove C4::Dates from C4/Acquisition.pm Sorry, something went wrong with this amendement, re-activating previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:44:16 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37730|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:49:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:49:26 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #4 from Fr?d?ric Demians --- Created attachment 37733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37733&action=edit Bug 13941 [1/2] Fix tags missing id/class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:50:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:50:41 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #5 from Fr?d?ric Demians --- Created attachment 37734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37734&action=edit Bug 13941 [2/2] Fix tags missing id/class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:50:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:50:51 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #6 from Fr?d?ric Demians --- Created attachment 37735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37735&action=edit Bug 13941 [1/2] Test tag with id/class attributes Test: - Apply the first patch [1/2] containg a new test checking tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid tags. - Apply the second patch [2/2] fixing all invalid tags. - Re-run the test: It passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:51:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:51:16 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:51:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:51:25 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:55:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:55:13 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37730|0 |1 is obsolete| | --- Comment #65 from Marc V?ron --- Created attachment 37736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37736&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat), see comment #57/ MV Amended because of "use Koha::DateUtils;" instead of original, See comment #59 /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 14:58:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 12:58:09 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37736|0 |1 is obsolete| | --- Comment #66 from Marc V?ron --- Created attachment 37737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37737&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat), see comment #57/ MV Amended because of "use Koha::DateUtils;" instead of original, See comment #59 /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:22:05 +0000 Subject: [Koha-bugs] [Bug 11008] Useless column supplierreference in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 37738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37738&action=edit Bug 11008: (RM followup) DBIx schema update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:27:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:27:43 +0000 Subject: [Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35514|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 37739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37739&action=edit Bug 11337: Remove the C4::Serials::GetSubscriptions routine Since SearchSubscriptions is the way to search subscriptions, each call to GetSubscriptions could be replaced by a call to SearchSubscriptions. Test plan: Verify following pages display the same thing as before this patch: - catalogue/detail.pl - opac/opac-ISBDdetail.pl - opac/opac-detail.pl Verify the following page returns correct results: - serials/checkexpiration.pl Verify the Serials UT file still passes: - prove t/db_dependent/Serials.t Note: The title filter on checkexpiration now only searches on the title DB field. I don't think it is a regression, it should be the way to use this field. Maybe should we add new search fields on this form. Bug 5337 reintroduces a bug fixed by bug 5864, this patch restore the right way to search subscription (based on biblionumber). Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:28:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:28:13 +0000 Subject: [Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 --- Comment #5 from Jonathan Druart --- The last patch fixes a trivial conflict on the test file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:37:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:37:07 +0000 Subject: [Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 37740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37740&action=edit Bug 12617 - Koha should let admins to configure automatically generated password complexity/difficulty Adds simple password policy(with regards to complexity) management into categories: - Per category password policy: admins can configure what kind of passwords get generated in member-passwords. User-created passwords are also checked against the policy if it is defined and complexity is enforced for every user based on their set category. - Reworks the old custom password generation code in member-password to use a pretty powerful perl module from the CPAN: App::Genpass - Predefined policies: - simplenumeric: the digits 0-9 allowed only - alphanumeric: passwords must contain only the digits 0-9 and lowercase and uppercase characters. Special characters are not allowed. - complex: patrons are required to use complex passwords containing numbers, uppercase and lowercase characters and special characters. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:37:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:37:11 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- This does not work, it's not filled with the value everywhere it is displayed. It should be fixed on a higher level, for all authorised values I think (C4::Koha::GetAuthorisedValues and some others). Or maybe the best way would be to make the description mandatory on the AV administration page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:37:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:37:18 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:38:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:38:21 +0000 Subject: [Koha-bugs] [Bug 13069] Enable sort by title to ignore articles on circulation and patron detail pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:38:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:38:45 +0000 Subject: [Koha-bugs] [Bug 13865] Columns configuration - Orders search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13865 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:39:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:39:12 +0000 Subject: [Koha-bugs] [Bug 11008] Useless column supplierreference in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:39:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:39:38 +0000 Subject: [Koha-bugs] [Bug 2806] issuingbranch isn't used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2806 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:40:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:40:05 +0000 Subject: [Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:40:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:40:25 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 --- Comment #10 from Marc V?ron --- Created attachment 37741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37741&action=edit [Signed-off] Bug 13189 [QA Followup] - Unit Tests Resolved easy conflict (test count) and tested. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:40:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:40:58 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #34172|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:43:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:43:03 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 --- Comment #11 from Marc V?ron --- I hope it is OK to set it back to "Passed QA" as it was before status "Patch doesn't apply" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:44:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:44:25 +0000 Subject: [Koha-bugs] [Bug 13879] DataTables server-side processing for patrons - sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13879 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Forgot to mark as pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:48:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:48:07 +0000 Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search - circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926 --- Comment #3 from Jonathan Druart --- Created attachment 37742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37742&action=edit Bug 13926: Reintroduce the correct variable name in template It's caused by a mistake in previous patch, introduced by bug 13894 too late, then fixed by 13936. After this patch, all will be fine in any case :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:52:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:52:59 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |frederic at tamil.fr CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:55:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:55:57 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #7 from Jonathan Druart --- Comment on attachment 37735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37735 Bug 13941 [1/2] Test tag with id/class attributes Review of attachment 37735: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13941&attachment=37735) ----------------------------------------------------------------- ::: xt/tt_valid.t @@ +41,4 @@ > } > close $dh; > > +use YAML; Seems useless. @@ +56,5 @@ > + { > + description => ' tag with id and class attributes', > + check => sub { > + my ($self, $name, $token) = @_; > + my $_ = $token->{_string}; Hum... Sure about this? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:59:44 +0000 Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search - circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:59:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:59:46 +0000 Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search - circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37573|0 |1 is obsolete| | Attachment #37742|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 37743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37743&action=edit [PASSED QA] Bug 13926: ake circulation.pl not using C4::Members::Search This patch uses the same method as bug 13894. Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Search for a patron using the checkout tab 2/ The patron list should appear correctly Test with different type of search (returns 0, 1, 1+ results). No behavior changes should be observed. Signed-off-by: Josef Moravec works as expected Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 15:59:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 13:59:54 +0000 Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search - circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926 --- Comment #5 from Kyle M Hall --- Created attachment 37744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37744&action=edit [PASSED QA] Bug 13926: Reintroduce the correct variable name in template It's caused by a mistake in previous patch, introduced by bug 13894 too late, then fixed by 13936. After this patch, all will be fine in any case :) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:02:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:02:36 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #8 from Jonathan Druart --- Comment on attachment 37734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37734 Bug 13941 [2/2] Fix tags missing id/class Review of attachment 37734: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13941&attachment=37734) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt @@ +135,4 @@ > > > > + typo "search" ::: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt @@ +2,4 @@ > Koha › Course reserves › Add items > [% INCLUDE 'doc-head-close.inc' %] > > + why not couse_add_items_step1? ::: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt @@ +3,4 @@ > [% INCLUDE 'doc-head-close.inc' %] > > > + idem. ::: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt @@ +32,4 @@ > > > > + Shouldn't be courses_course_details? ::: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-reserves.tt @@ +14,4 @@ > > > > + Shouldn't be courses_course_reserves? ::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt @@ +19,4 @@ > > > > + Shouldn't be patlist*s*? ::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt @@ +65,4 @@ > > > > + Shouldn't be patlist*s*? ::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt @@ +24,4 @@ > > > > + Shouldn't be patlist*s*? ::: koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-disabled.tt @@ +5,4 @@ > [% INCLUDE 'calendar.inc' %] > > > + typo Shouldn't be plugins_plugins_disabled? ::: koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt @@ +5,4 @@ > [% INCLUDE 'calendar.inc' %] > > > + Shouldn't be plugins_plugins_home? ::: koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-upload.tt @@ +5,4 @@ > [% INCLUDE 'calendar.inc' %] > > > + Shouldn't be plugins_plugins_upload? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:02:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:02:53 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:03:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:03:22 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #9 from Jonathan Druart --- Marked as Failed QA, at least for typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:09:14 +0000 Subject: [Koha-bugs] [Bug 13006] suggestions.mailoverseeing is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13006 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 37745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37745&action=edit Bug 13006: (RM followup) DBIx schema update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:09:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:09:27 +0000 Subject: [Koha-bugs] [Bug 13811] Silent Cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #4 from Fr?d?ric Demians --- 1) Could you document the new --silent parameter in the POD section of borrowers-force-messaging-defaults? 2) Why don't you modify check-url-quick.pl? check-url.pl is supposed to be deprecated. 3) As 1), the new way --html operates imposes to modify the documentation. 4) It may be better to have two bugs: one for each modified script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:09:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:09:51 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30937|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:10:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:10:42 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36896|0 |1 is obsolete| | --- Comment #67 from Marc V?ron --- Created attachment 37746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37746&action=edit Bug 13813 - Remove C4::Dates from circ/circ/transferstoreceive.pl To test: Go to Home > Circulation > Transfers to your library (Circulation Reports - Transfers to receive) Verify that date in page title appears correcty Amendend following comment #58 /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:14:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:14:33 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #10 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #7) Thanks for testing. > Comment on attachment 37735 [details] [review] > Bug 13941 [1/2] Test tag with id/class attributes > > Review of attachment 37735 [details] [review]: > ----------------------------------------------------------------- > > ::: xt/tt_valid.t > @@ +41,4 @@ > > } > > close $dh; > > > > +use YAML; > > Seems useless. Sure. > @@ +56,5 @@ > > + { > > + description => ' tag with id and class attributes', > > + check => sub { > > + my ($self, $name, $token) = @_; > > + my $_ = $token->{_string}; > > Hum... Sure about this? :) Yes. Do you see anything wrong/strange? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:16:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:16:33 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:17:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:17:56 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37741|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 37747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37747&action=edit [PASSED QA] Bug 13189: (QA Followup) Unit Tests Resolved easy conflict (test count) and tested. Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:18:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:18:20 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36898|0 |1 is obsolete| | --- Comment #68 from Marc V?ron --- Created attachment 37748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37748&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/barcode_manual.pl To test: Apply patch Set the plugin for 952$p (or UNIMARC equivalent to items.barcode) for one of your frameworks to barcode_manual.pl instead of barcode.pl Set syspref autoBarcode to -001, -002 and yymm001 Edit items or add item, verify that barcodes are filled in as appropriate by clicking on the value builder link (...) (Note: Description of barcode_manual.pl in Bug 8524) Amended following comment #58 /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:21:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:21:35 +0000 Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables server-side processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #22 from Tom?s Cohen Arazi --- Patches pushed to master. Good job Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:22:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:22:06 +0000 Subject: [Koha-bugs] [Bug 13006] suggestions.mailoverseeing is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13006 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:22:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:22:41 +0000 Subject: [Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:23:44 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Remaining patch (regression tests) pushed. Thanks Kyle, and Marc (rebasing)! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:24:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:24:27 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #11 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #8) > Comment on attachment 37734 [details] [review] > Bug 13941 [2/2] Fix tags missing id/class > > Review of attachment 37734 [details] [review]: Your points are well taken. You have good eyesight. But this: > ::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt > @@ +19,4 @@ > > > > > > > > + > > Shouldn't be patlist*s*? I don't understand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:24:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:24:56 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36899|0 |1 is obsolete| | --- Comment #69 from Marc V?ron --- Created attachment 37749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37749&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/dateaccessioned.pl To test: Apply patch Edit an item Verifiy that autofilling date in d - Date acquired works as before. Amended following comment #58 /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:25:39 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:25:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:25:42 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30201|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 37750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37750&action=edit Bug 12633: Remove SQLHelper in C4::Members This is the only places where SQLHelper is still called. The C4::Members::Search is not used anymore, but ModMember and AddMember. This patch replaced the calls to SQLHelper to use DBIX::Class. TODO: Move them to Koha::Borrower. Test plan: 1/ Make sure the patron search still works (no changes expected since the code was not in used). 2/ Add a patron with all fields filled 3/ Add another patron with some fields filled 4/ Update them with other values 5/ Delete them You should not get any errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:26:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:26:32 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:26:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:26:35 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30937|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 37751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37751&action=edit Bug 12633: Remove SQLHelper in C4::Members This is the only places where SQLHelper is still called. The C4::Members::Search is not used anymore, but ModMember and AddMember. This patch replaced the calls to SQLHelper to use DBIX::Class. TODO: Move them to Koha::Borrower. Test plan: 1/ Make sure the patron search still works (no changes expected since the code was not in used). 2/ Add a patron with all fields filled 3/ Add another patron with some fields filled 4/ Update them with other values 5/ Delete them You should not get any errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:27:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:27:03 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30201|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:27:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:27:08 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37750|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:30:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:30:06 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30201|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 37752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37752&action=edit Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:31:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:31:22 +0000 Subject: [Koha-bugs] [Bug 13440] 'Check out' tab search for patron gives perl error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #7 from Jonathan Druart --- Bug 11385 will remove this package and should get rid of this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:36:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:36:28 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36855|0 |1 is obsolete| | --- Comment #70 from Marc V?ron --- Created attachment 37753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37753&action=edit Bug 13813 - Remove C4::Dates from members/readingrec.pl This patch removes depraceted C4::Dates from members/readingrec.pl To test: Apply patch Go to a patron's cirulation history Verify that circulation history behaves as before. Amended following comment #58 /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:36:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:36:45 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #7 from M. Tompsett --- (In reply to Jonathan Druart from comment #6) > Or maybe the best way would be to make the description mandatory on the AV > administration page. I think this is a better solution, yes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:42:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:42:18 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36858|0 |1 is obsolete| | --- Comment #71 from Marc V?ron --- Created attachment 37754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37754&action=edit Bug 13813 - Remove C4::Dates from C4/Items.pm This patch removes depraceted C4::Dates from C4/Items.pm To test: Apply patch To test: Add modify items. Checkout added item. Verify that item handling works as before. Amended following comment #58 / MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:44:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:44:55 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36360|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 37755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37755&action=edit Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. I could not verify step 1/, because at least one Patron category can not be deleted (Staff, since I'm logged in as a Staff patron and you can not delete categories that are in use). Tested 0/ and 2/ Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Passes QA script and tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:45:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:45:09 +0000 Subject: [Koha-bugs] [Bug 13803] SelfCheck not setting flag when item requires transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13803 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:45:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:45:12 +0000 Subject: [Koha-bugs] [Bug 13803] SelfCheck not setting flag when item requires transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13803 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36665|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 37756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37756&action=edit Bug 13803 Flag to self check book has gone into transit Ensure that the transit flag (in field CV) is set if return message is 'wasTransfered' CV is being set for other return conditions but not for wasTransfered [sic] The presence of this flag is required to route returns to the correct bin if the SC unit is so enabled Signed-off-by: Frederic Demians I agree with the solution to an issue I've already encountered and patched localy that way. It would be nice to have a better doc of C4::Circulation::AddReturn in order to see immediately that WasTransfered is a valid feedback for a check-in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:50:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:50:10 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36859|0 |1 is obsolete| | --- Comment #72 from Marc V?ron --- Created attachment 37757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37757&action=edit Bug 13813 - Remove C4::Dates from C4/Members.pm This patch removes C4::Dates from C4/Members.pm Note: This patch can be tested independently from other patches in this Bug, but it depends on patches from Bug 13601 To test: Make sure that patches from 13601 are applied Apply patch Check changes in code Make sure that following functionality works as before: - Add a patron - Renew patrons - Go to checkout page and create message for patron Amended following comment #58 / MV There is one more DateTime->now() left on line 1825, this is not related to my changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:51:28 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #12 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #11) > (In reply to Jonathan Druart from comment #8) > > Comment on attachment 37734 [details] [review] [review] > > Bug 13941 [2/2] Fix tags missing id/class > > > > Review of attachment 37734 [details] [review] [review]: > > Your points are well taken. You have good eyesight. > > But this: > > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt > > @@ +19,4 @@ > > > > > > > > > > > > + > > > > Shouldn't be patlist*s*? > > I don't understand. The module is plural, not the id (patron_lists vs patlist). See plugins and tools. But if you prefer patlist, go for it :) (In reply to Fr?d?ric Demians from comment #10) > (In reply to Jonathan Druart from comment #7) > > Thanks for testing. > > > Comment on attachment 37735 [details] [review] [review] > > Bug 13941 [1/2] Test tag with id/class attributes > > > > Review of attachment 37735 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: xt/tt_valid.t > > @@ +41,4 @@ > > > } > > > close $dh; > > > > > > +use YAML; > > > > Seems useless. > > Sure. > > > @@ +56,5 @@ > > > + { > > > + description => ' tag with id and class attributes', > > > + check => sub { > > > + my ($self, $name, $token) = @_; > > > + my $_ = $token->{_string}; > > > > Hum... Sure about this? :) > > Yes. Do you see anything wrong/strange? At least a warning :) Use of my $_ is experimental at xt/tt_valid.t line 61. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:52:55 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 37758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37758&action=edit Bug 13497: (Maniac followup) spell category in english Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:54:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:54:25 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #298 from Magnus Enger --- Should the status be "Needs signoff"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:55:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:55:12 +0000 Subject: [Koha-bugs] [Bug 8033] remove unused sco/receipt template file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #72 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Owen! We miss you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:55:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:55:38 +0000 Subject: [Koha-bugs] [Bug 9333] Confirm close JavaScript alerts is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:56:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:56:04 +0000 Subject: [Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 16:56:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 14:56:34 +0000 Subject: [Koha-bugs] [Bug 13942] Testing the 'recordpayment' function in C4::Accounts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13942 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Tests pushed to master. Good job Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:01:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:01:16 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #299 from M. Tompsett --- (In reply to Magnus Enger from comment #298) > Should the status be "Needs signoff"? Oops... Yes, but so does bug 5010, on which this dependent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:07:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:07:47 +0000 Subject: [Koha-bugs] [Bug 12709] Mailling list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12709 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:10:16 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:12:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:12:14 +0000 Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980 --- Comment #1 from Bob Ewart --- Looks like this may be a duplicate of bug 5377 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 At any rate changing the isbn/issn fields in biblioitems fixes the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:13:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:13:16 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #13 from Fr?d?ric Demians --- > > > Shouldn't be patlist*s*? > > > > I don't understand. > > The module is plural, not the id (patron_lists vs patlist). > See plugins and tools. > But if you prefer patlist, go for it :) I understand now your *s*. I wasn't reading it properly... I will keep it as it is if you don't mind. It's already a sort of shortcut. > Use of my $_ is experimental at xt/tt_valid.t line 61. Ok. I don't get it on Perl 5.14, but it's a valid warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:16:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:16:27 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:16:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:16:29 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37734|0 |1 is obsolete| | --- Comment #14 from Fr?d?ric Demians --- Created attachment 37759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37759&action=edit Bug 13941 [2/2] Fix tags missing id/class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:16:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:16:50 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37735|0 |1 is obsolete| | --- Comment #15 from Fr?d?ric Demians --- Created attachment 37760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37760&action=edit Bug 13941 [1/2] Test tag with id/class attributes Test: - Apply the first patch [1/2] containg a new test checking tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid tags. - Apply the second patch [2/2] fixing all invalid tags. - Re-run the test: It passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:21:02 +0000 Subject: [Koha-bugs] [Bug 13986] New: Printing a list only prints the results of the page you are viewing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Bug ID: 13986 Summary: Printing a list only prints the results of the page you are viewing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The print list button only prints the page you are viewing, and not the entire list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:23:15 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:24:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:24:20 +0000 Subject: [Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Fr?re S?bastien Marie changed: What |Removed |Added ---------------------------------------------------------------------------- CC|semarie-koha at latrappe.fr | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:24:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:24:59 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:25:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:25:01 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #1 from Kyle M Hall --- Created attachment 37761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37761&action=edit Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:37:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:37:42 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36862|0 |1 is obsolete| | --- Comment #73 from Marc V?ron --- Created attachment 37762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37762&action=edit Bug 13813 - Remove C4::Dates from C4/Barcodes/annual.pm To test: Set syspref autoBarcode to -001, -002 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. Amended following comment #58 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:42:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:42:24 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36863|0 |1 is obsolete| | --- Comment #74 from Marc V?ron --- Created attachment 37763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37763&action=edit Bug 13813 - Remove C4::Dates from C4/Barcodes/hbyymmincr.pm To test: Set syspref autoBarcode to yymm0001 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. Amended following comment #58 /mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:46:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:46:04 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36878|0 |1 is obsolete| | --- Comment #75 from Marc V?ron --- Created attachment 37764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37764&action=edit Bug 13813 - Remove C4::Dates from C4/Suggestions.pm To test: Apply patch Go to Home > Acquisitions > Suggestions management Verify in "Filter by" that filter works for Suggestion information / dates Amended following comment #58 /mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:49:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:49:23 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36885|0 |1 is obsolete| | --- Comment #76 from Marc V?ron --- Created attachment 37765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37765&action=edit Bug 13813 - Remove C4::Dates from members/moremember.pl To test: Apply patch Go to a patron's Details page (moremember.pl) Verify that dates display correctly (birth date, registration, espiration, manual restriction with date) Amended following comment #58 /mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 17:56:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 15:56:19 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36895|0 |1 is obsolete| | --- Comment #77 from Marc V?ron --- Created attachment 37766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37766&action=edit Bug 13813 - Remove C4::Dates from circ/waitingreserves.pl To test: Go to Home > Circulation > Holds awaiting pickup (Circulation Rports - Holds awaiting pickup) Verify that date in page title appears correcty Amended following comment #58 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:01:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:01:19 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36897|0 |1 is obsolete| | --- Comment #78 from Marc V?ron --- Created attachment 37767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37767&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/barcode.pl To test: Set syspref autoBarcode to -001, -002 and yymm001 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. Amended following comment #58 /mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:22:55 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37731|0 |1 is obsolete| | --- Comment #79 from Marc V?ron --- Created attachment 37768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37768&action=edit Bug 13813 - Remove C4::Dates from PDF templates in acquisitions To test: Apply patch In Acquisitions, go to a vendor's "Basket grouping" Find a basket and print order Change PDF templates using syspref OrderPdfFormat and test for - English 2-page - English 3-page - French 3-page - German 2-page Amended following comment #58 /MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:26:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:26:33 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 37769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37769&action=edit Bug 13539: (RM followup) DBIx schema update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:28:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:28:41 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37737|0 |1 is obsolete| | --- Comment #80 from Marc V?ron --- Created attachment 37770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37770&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat), see comment #57/ MV Amended because of "use Koha::DateUtils;" instead of original, See comment #59 /MV Amended following comment #58 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:31:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:31:45 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Mirko Tietgen --- Patch needs a rebase. Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 13590 - Add ability to charge fines at start of charge period Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation_Issuingrule.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation_Issuingrule.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging admin/smart-rules.pl CONFLICT (content): Merge conflict in admin/smart-rules.pl Auto-merging Koha/Schema/Result/Issuingrule.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Issuingrule.pm Auto-merging C4/Overdues.pm CONFLICT (content): Merge conflict in C4/Overdues.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:32:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:32:30 +0000 Subject: [Koha-bugs] [Bug 13957] Patron autocomplete shows NULL in list of results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:32:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:32:58 +0000 Subject: [Koha-bugs] [Bug 13539] Table patroncards not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:44:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:44:37 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36893|0 |1 is obsolete| | --- Comment #81 from Marc V?ron --- Comment on attachment 36893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36893 Bug 13813 - Remove C4::Dates from patroncards/members-search.pl CONFLICT (modify/delete): patroncards/members-search.pl deleted in HEAD and modified in Bug 13813 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:50:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:50:27 +0000 Subject: [Koha-bugs] [Bug 6007] Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:51:28 +0000 Subject: [Koha-bugs] [Bug 13307] Create a link to the last advanced search in search result page (OPAC) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #20 from Tom?s Cohen Arazi --- Enhancement pushed to master. Thanks Simith! Note: I ammended the commit messages. Please try to include bug number and better descriptions of what the patches are for. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:57:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:57:23 +0000 Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search - circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37743|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 37771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37771&action=edit [PASSED QA] Bug 13926: ake circulation.pl not using C4::Members::Search This patch uses the same method as bug 13894. Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Search for a patron using the checkout tab 2/ The patron list should appear correctly Test with different type of search (returns 0, 1, 1+ results). No behavior changes should be observed. Signed-off-by: Josef Moravec works as expected Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:57:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:57:30 +0000 Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search - circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37744|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 37772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37772&action=edit [PASSED QA] Bug 13926: Reintroduce the correct variable name in template It's caused by a mistake in previous patch, introduced by bug 13894 too late, then fixed by 13936. After this patch, all will be fine in any case :) Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 18:59:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 16:59:43 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Arturo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library at sll.texas.gov --- Comment #80 from Arturo --- Hi, all. My library recently switched to Koha, and this is my first attempt at testing a patch, but I am not sure if I am doing this correctly or if I've truly run into an issue. I followed the instructions at http://wiki.koha-community.org/wiki/Sandboxes to test this patch, bug 8753. I set up Sandbox 6 from BibLibre succesfully, logged in correctly, and did not see any error messages in the 'news' area, so it seems the patch was applied successfully. Before I could follow the test plan listed in this thread, I randomly selected a patron (I chose Colin Campbell), set a password for him, and set his e-mail address to my e-mail address so that I'd receive the e-mail notifications. Then I followed the test plan. Everything seemed OK except that I never received the e-mail to reset the pw. I then remembered that by default, Koha installations do not have e-mail enabled. Could that be the reason? Or would it be safe to assume that e-mail is enabled in the BibLibre sandboxes? I couldn't find that information anywhere. Thanks for any assistance anyonce can provide! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 19:26:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 17:26:31 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #2 from Marc V?ron --- Created attachment 37773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37773&action=edit [Signed-off] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 19:26:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 17:26:53 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #37761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 19:27:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 17:27:01 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 19:42:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 17:42:59 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #16 from Marc V?ron --- Patch 2/2 does not apply on current master because koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt no longer exists. Applying: Bug 13941 [2/2] Fix tags missing id/class Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... error: refusing to lose untracked file at 'koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt' CONFLICT (modify/delete): koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt deleted in HEAD and modified in Bug 13941 [2/2] Fix tags missing id/class. Version Bug 13941 [2/2] Fix tags missing id/class of koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt left in tree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 19:45:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 17:45:09 +0000 Subject: [Koha-bugs] [Bug 13926] SQLHelper replacement - C4::Members::Search - circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13926 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Rebased patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 19:45:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 17:45:56 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:04:18 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37759|0 |1 is obsolete| | --- Comment #17 from Fr?d?ric Demians --- Created attachment 37774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37774&action=edit Bug 13941 [2/2] Fix tags missing id/class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:04:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:04:38 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37760|0 |1 is obsolete| | --- Comment #18 from Fr?d?ric Demians --- Created attachment 37775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37775&action=edit Bug 13941 [1/2] Test tag with id/class attributes Test: - Apply the first patch [1/2] containg a new test checking tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid tags. - Apply the second patch [2/2] fixing all invalid tags. - Re-run the test: It passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:05:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:05:26 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #19 from Fr?d?ric Demians --- (In reply to Marc V?ron from comment #16) > Patch 2/2 does not apply on current master because > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt no longer exists. Thanks. Conflict solved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:18:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:18:08 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 --- Comment #21 from Tom?s Cohen Arazi --- Created attachment 37776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37776&action=edit Bug 13315: (QA followup) fix t/db_dependent/Circulation_issue.t C4::Circulation::AddIssue now returns a Koha::Schema::Result::Issue object so tests need to be fixed. The old behaviour was to always return the due date. It now returns undef if no issue performed. So one of the tests become irrelevant. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:18:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:18:49 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle and Owen, nice job! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:20:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:20:56 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 --- Comment #3 from Marc V?ron --- Created attachment 37777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37777&action=edit [Signed-off] Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl To avoid homonyms, it would be nice if the card number is displayed in the user suggestion.pl. Currently, consult the record of the user to know exactly who made the suggestion. TEST PLAN: Apply the patch. Go on suggestion.pl. Check that nothing has changed, except that cardnumbers are displayed in 'Suggested by' column. Resolved an easy conflict while applying. Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:21:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:21:18 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #33133|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:21:27 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:30:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:30:55 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:33:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:33:57 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! PS. thank Gustavo from UNC that convinced me :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:49:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:49:16 +0000 Subject: [Koha-bugs] [Bug 13987] New: Z39.50 Authority search result not displaying server name Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 Bug ID: 13987 Summary: Z39.50 Authority search result not displaying server name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When doing an Auth search through z3950, the resulting table has the first column (servers name) always empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:53:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:53:58 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 --- Comment #1 from Blou --- Created attachment 37778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37778&action=edit Bug 13987 - Fix server name in z39.50 authority search results When doing an Auth search through z3950, the resulting table has the first column (servers name) always empty. TEST 1) once logged into the intranet, go to Authorities. 2) Click New from z39.50, fill appropriatly for a successful search. 3) Acknowledge first column is empty. Always. 4) Apply the (very simple) patch. 5) Do another search, validate column is not empty anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:54:26 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 20:56:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 18:56:06 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |anthony.laquerre at ccsr.qc.ca | |, eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com --- Comment #2 from Blou --- Sponsored by : CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 21:08:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 19:08:53 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8273|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Created attachment 37779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37779&action=edit Bug 7646: Add "do not print SQL" link to reports I redid the patch without the superfluos CSS part for class noprint. To test: Go to Home > Reports > Guided reports wizard > Saved reports Select a report and run it You will find a new link "Print w/o SQL" above the title Hit this link. The report (this page) will print without the SQL statement. The original patch was QAed in 2012, I think it is better to have put it back to "Needs Sign-off" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 21:09:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 19:09:34 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 21:35:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 19:35:50 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37580|0 |1 is obsolete| | --- Comment #3 from Andreas Hedstr?m Mace --- Created attachment 37780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37780&action=edit Bug 9139: New subscription form - Does not check form on the first page The vendor and Record input try to sent the form if the focus is on the inputs (normal behavior). But the form is on 2 pages, and the popup message ask you to fill info on the second page when you are on the first one. This does not make sense. This patch suggests to launch search when the enter key is press on these inputs. Test plan: 1/ Create a new subscription 2/ Put the focus in the Vendor input and press enter: the vendor search popup should appear 3/ Put the focus in the Record input and press enter: the record search popup should appear Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 21:45:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 19:45:56 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 21:58:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 19:58:12 +0000 Subject: [Koha-bugs] [Bug 13988] New: Log activities related to Acquisitions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988 Bug ID: 13988 Summary: Log activities related to Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Some activities in module Acquisitions could be written to the system log, e.g. changes to exchange rates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 21:58:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 19:58:58 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13988 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 21:58:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 19:58:58 +0000 Subject: [Koha-bugs] [Bug 13988] Log activities related to Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7571 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:06:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:06:01 +0000 Subject: [Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:16:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:16:15 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10951 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:16:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:16:15 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6864 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:20:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:20:06 +0000 Subject: [Koha-bugs] [Bug 13916] NORMARC can have analytics with leader 07 = a, b or p In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13916 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #2 from Mirko Tietgen --- I tried to test this and set up a NORMARC instance. Among other things, there is no MARC field 774 in the Norwegian standard framework. I added it with subfields t and w, but when I tried to set up two linked records I found that the 773 subfields in the child record do not save for me. I enter values, save the record and when I open it again, the values are gone. I suppose there is something wrong with the standard framework, it worked fine for the 774 I added in the parent record. I filled every single 773 subfield and after saving found that subfields 7, a-h keep the value, i, k, s, t, w, x, y, z lose it. I stopped investigating at that point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:31:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:31:43 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #20 from Marc V?ron --- Created attachment 37781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37781&action=edit [Signed-off] Bug 13941 [1/2] Test tag with id/class attributes Test: - Apply the first patch [1/2] containg a new test checking tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid tags. - Apply the second patch [2/2] fixing all invalid tags. - Re-run the test: It passes. Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:32:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:32:16 +0000 Subject: [Koha-bugs] [Bug 7999] send test notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7999 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:32:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:32:22 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:33:13 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:33:41 +0000 Subject: [Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:34:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:34:04 +0000 Subject: [Koha-bugs] [Bug 12656] add a notice that tells patrons when their hold was cancelled because it wasn't picked up in time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:34:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:34:45 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:35:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:35:20 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #21 from Marc V?ron --- Created attachment 37782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37782&action=edit [Signed-off] Bug 13941 [2/2] Fix tags missing id/class Followed test plan (Comment #18), works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:35:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:35:31 +0000 Subject: [Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- It's a problem with the database update not setting a variable correctly I think, we ran into this too, but lost sight of it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:35:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:35:50 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:36:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:36:00 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:36:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:36:02 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:39:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:39:10 +0000 Subject: [Koha-bugs] [Bug 9083] <> in checkin/checkout notices does nothing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9083 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:41:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:41:38 +0000 Subject: [Koha-bugs] [Bug 13989] New: Undocumented Option in ILS-DI LookupPatron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13989 Bug ID: 13989 Summary: Undocumented Option in ILS-DI LookupPatron Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: misilot at fit.edu QA Contact: testopia at bugs.koha-community.org id_type "userid" is not documented in the Description of the LookupPatron API. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:45:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:45:27 +0000 Subject: [Koha-bugs] [Bug 13990] New: ILS-DI LookupPatron Requries ID Type Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990 Bug ID: 13990 Summary: ILS-DI LookupPatron Requries ID Type Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: misilot at fit.edu QA Contact: testopia at bugs.koha-community.org For the LookupPatron the id_type argument seems to be required, even though it says it is optional. For example: https://site/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=4456 I get the following error:

Software error:

Can't use an undefined value as an ARRAY reference at
/usr/lib/perl5/DBI.pm line 2054.
However, if I add &id_type=borrowernumber I get the correct output. 4456 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 13 22:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 Apr 2015 20:47:16 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se Status|Needs Signoff |Failed QA --- Comment #4 from Andreas Hedstr?m Mace --- This patch only seems to solve one of the two issues in the bug. The tab number are there but longer descriptions are still being cut off. Please correct me if i have missed something or misunderstood. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 02:21:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 00:21:14 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia at hotmail.com --- Comment #13 from Aleisha Amohia --- Patch applied cleanly but can't seem to see the print link? Setting as Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 02:29:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 00:29:01 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #3 from Aleisha Amohia --- Patch applied cleanly but server column remains empty? Could just be me testing it wrong so will leave for someone else to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 02:45:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 00:45:13 +0000 Subject: [Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #2 from Aleisha Amohia --- Patch applied cleanly but date is still not sorting correctly. Will leave as Needs signoff in case I'm testing it wrong -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 03:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 01:21:27 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #8 from M. Tompsett --- Created attachment 37783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37783&action=edit Bug 13399: Missing validation on authorised value descriptions This adds validations which force both the OPAC and Staff Client authorised value descriptions to be filled in. Counter Patch in the works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 03:51:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 01:51:50 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37783|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 37784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37784&action=edit Bug 13399: Missing validation on authorised value descriptions This adds validations which force both the OPAC and Staff Client authorized value descriptions to be filled in. TEST PLAN --------- 1) Login to staff client 2) Koha administration -> Authorized values 3) Change drop-down to 'DEPARTMENT' -- Assuming you have default values installed, and DEPARTMENT exists. 4) Click '+ New authorized value for DEPARTMENT' 5) Enter a 'Authorized value:' and click 'Save' -- This will create it without OPAC and Staff Client descriptions! This is wrong. 6) Apply patch 7) $ ./installer/data/mysql/updatedatabase.pl -- expecting atomic update to run. 8) Refresh staff client page -- the descriptions should now be filled in. 9) Repeat steps 4 and 5 -- This time, you will be given two error messages -- Nothing will be created. 10) Attempt to create a new authorized value with descriptions. -- should save without issue. 11) Run koha qa test tools -- SQL files are unchecked, but steps 7 & 8 confirm validity. -- Should be no issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:00:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:00:23 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:00:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:00:25 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37532|0 |1 is obsolete| | Attachment #37784|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 37785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37785&action=edit Bug 13399: Missing validation on authorised value descriptions This adds validations which force both the OPAC and Staff Client authorized value descriptions to be filled in. TEST PLAN --------- 1) Login to staff client 2) Koha administration -> Authorized values 3) Change drop-down to 'DEPARTMENT' -- Assuming you have default values installed, and DEPARTMENT exists. 4) Click '+ New authorized value for DEPARTMENT' 5) Enter a 'Authorized value:' and click 'Save' -- This will create it without OPAC and Staff Client descriptions! This is wrong. 6) Apply patch 7) $ ./installer/data/mysql/updatedatabase.pl -- expecting atomic update to run. 8) Refresh staff client page -- the descriptions should now be filled in. 9) Repeat steps 4 and 5 -- This time, you will be given two error messages -- Nothing will be created. 10) Attempt to create a new authorized value with descriptions. -- should save without issue. 11) Run koha qa test tools -- SQL files are unchecked, but steps 7 & 8 confirm validity. -- Should be no issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:10:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:10:51 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:11:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:11:51 +0000 Subject: [Koha-bugs] [Bug 10551] Merging records allows duplicaton of non-repeatable subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:12:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:12:01 +0000 Subject: [Koha-bugs] [Bug 1091] in the opac search, a second pass with shorter terms if there are no results? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1091 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:12:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:12:10 +0000 Subject: [Koha-bugs] [Bug 2500] Standing enhancement request for adding/updating call number splitting algorithms in C4/Labels.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:12:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:12:18 +0000 Subject: [Koha-bugs] [Bug 2797] Add Summary records to represent summary holdings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2797 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:12:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:12:28 +0000 Subject: [Koha-bugs] [Bug 5069] Authority clean-up scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5069 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:12:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:12:37 +0000 Subject: [Koha-bugs] [Bug 5185] Match modification should (optionally) update the last seen time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5185 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:12:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:12:48 +0000 Subject: [Koha-bugs] [Bug 5362] Simple (non-MARC) cataloging interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5362 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:12:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:12:58 +0000 Subject: [Koha-bugs] [Bug 5609] Holds Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:13:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:13:07 +0000 Subject: [Koha-bugs] [Bug 6762] show orderline numbers in the basket display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6762 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:13:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:13:14 +0000 Subject: [Koha-bugs] [Bug 7177] memoize more function calls to speed up Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7177 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:13:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:13:23 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:13:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:13:31 +0000 Subject: [Koha-bugs] [Bug 9512] "Did you mean" searches authority number as a stem, returns false positives In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9512 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:13:39 +0000 Subject: [Koha-bugs] [Bug 10581] Authority search: no results should not display as 404 error page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10581 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:13:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:13:45 +0000 Subject: [Koha-bugs] [Bug 10673] Message hide timeout can go out of sync in preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10673 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:13:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:13:52 +0000 Subject: [Koha-bugs] [Bug 4040] Placing a hold on an item while it is in transit results in duplicate dialogs upon check-in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4040 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:13:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:13:58 +0000 Subject: [Koha-bugs] [Bug 5627] lock symbol even on not locked fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5627 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:14:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:14:09 +0000 Subject: [Koha-bugs] [Bug 7170] Remove use of XML::Simple In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:14:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:14:17 +0000 Subject: [Koha-bugs] [Bug 7107] 'used in' column on analytics not populating In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7107 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 04:14:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 02:14:24 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins at cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 05:01:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 03:01:30 +0000 Subject: [Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 05:01:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 03:01:32 +0000 Subject: [Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37720|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 37786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37786&action=edit Bug 13982 - Checkouts table not sorting on correct column The "Date Due" column for checkouts is using the column index 1 to sort by. This column is the one that is used for grouping items into today's checkouts and previous checkouts. This is definitely not the column that should be used. Instead, we should be using column index 2, which contains the raw unformatted due date. Revised Test Plan: 1) Find a patron with no checkouts 2) Check out something as due the beginning on the month. 3) Check out something as due the end of the month. 4) Check out something due tomorrow (hopefully not end of month) -- so you should have 2015-04-01, 2015-04-30, and 2015-04-14 (for example) 5) Attempt to sort by due date -- Note the sorting is incorrect 6) Apply this patch 7) Clear your browser cache 8) Reload the page 9) Attempt to sort by due date again -- Note the sorting works correctly this time 10) Verify there are no regressions with bug 13908 -- this will require finding a patron with many checkouts, playing with the Circulation system preferences previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder, and understanding what the four different cases mean with respect to actually manually sorting the 'Due Date' column. NOTE: I did not do step 10, Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 05:42:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 03:42:58 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 --- Comment #1 from Robin Sheat --- Created attachment 37787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37787&action=edit Bug 13979: updates to allow installation on jessie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 05:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 03:43:29 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 --- Comment #2 from Robin Sheat --- Created attachment 37788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37788&action=edit Bug 13979: [3.18.x] updates to allow installation on jessie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 05:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 03:44:16 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 --- Comment #3 from Robin Sheat --- Created attachment 37789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37789&action=edit Bug 13979: [3.16.x] updates to allow installation on jessie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 05:45:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 03:45:22 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 06:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 04:46:50 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 --- Comment #14 from Marc V?ron --- Created attachment 37790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37790&action=edit Screenshot showing position of link after applying patch I re-tested, the link appears as intended by the original patch. See screenshot. Setting back to "Needs signoff". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 06:47:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 04:47:24 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 07:07:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 05:07:03 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #67 from M. Tompsett --- Comment on attachment 35838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35838 Bug 10363 - There is no package for authorised values. Review of attachment 35838: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10363&attachment=35838) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +9766,5 @@ > + CHANGE av_id av_id INT( 11 ) NOT NULL, > + CHANGE branchcode branchcode VARCHAR( 10 ) NOT NULL > + }); > + print "Upgrade to $DBversion done ( Bug 10363 - There is no package for authorised values. )\n"; > + SetVersion($DBversion); Shouldn't this be an atomicupdate now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 07:15:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 05:15:57 +0000 Subject: [Koha-bugs] [Bug 13991] New: Uninitialized value $src in /tools/viewlog.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Bug ID: 13991 Summary: Uninitialized value $src in /tools/viewlog.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl Reason: Line 57 my $src = $input->param("src"); Param is not always defined. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 07:28:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 05:28:57 +0000 Subject: [Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 --- Comment #1 from Marc V?ron --- Created attachment 37791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37791&action=edit Bug 13991 - Uninitialized value $src in /tools/viewlog.pl To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl To test: Apply patch. Verify that no more warnings appear in intranet-error.log Verify that the log viewer behaves as before. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 07:29:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 05:29:29 +0000 Subject: [Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 07:29:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 05:29:42 +0000 Subject: [Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 07:34:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 05:34:41 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- I don't think this is the correct solution. There are reasons why it makes sometimes sense to leave one or both descriptions empty. In the past Koha even came with 0 values that had empty descriptions to offer an empty entry in some pull down lists. Also, if you leave the OPAC description empty it will fall back to the library description as a feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 07:34:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 05:34:50 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 07:37:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 05:37:37 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #12 from Katrin Fischer --- And is this really a bug? What if a library just doesn't want to display anything in department and term? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 08:12:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 06:12:00 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36929|0 |1 is obsolete| | --- Comment #6 from Fr?d?ric Demians --- Created attachment 37792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37792&action=edit Bug 13049: Merge selfreg cron jobs into cleanup_database This patch moves the core code of two selfreg cron jobs into the Members module. The new routines are called from cleanup_database with two new parameters. The old cron jobs are now wrappers to cleanup_database. As a bonus, we can add a unit test now. In time, we can obsolete the selfreg cron jobs. For now, the code is in one place and behavior does not change. A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Test plan: Run the unit test t/db_dependent/Members.t. Test the two new parameters of cleanup_database.pl. Verify if delete_expired_opac_registrations.pl still works. Same for delete_unverified_opac_registrations.pl. Signed-off-by: Frederic Demians . Fixed minor merge confict on UT & cleanup_database.pl . UT ok . The two deprecated scripts still work as before, with a warning message. . cleanup_database.pl do the deletion job, calling new C4::Members function rather that doing it directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 08:11:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 06:11:58 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 08:15:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 06:15:09 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37792|0 |1 is obsolete| | --- Comment #7 from Fr?d?ric Demians --- Created attachment 37793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37793&action=edit Bug 13049: Merge selfreg cron jobs into cleanup_database This patch moves the core code of two selfreg cron jobs into the Members module. The new routines are called from cleanup_database with two new parameters. The old cron jobs are now wrappers to cleanup_database. As a bonus, we can add a unit test now. In time, we can obsolete the selfreg cron jobs. For now, the code is in one place and behavior does not change. A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Test plan: Run the unit test t/db_dependent/Members.t. Test the two new parameters of cleanup_database.pl. Verify if delete_expired_opac_registrations.pl still works. Same for delete_unverified_opac_registrations.pl. Signed-off-by: Frederic Demians . Fixed minor merge confict on UT & cleanup_database.pl . UT ok . The two deprecated scripts still work as before, with a warning message. . cleanup_database.pl do the deletion job, calling new C4::Members function rather that doing it directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 08:43:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 06:43:41 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #15 from Fr?d?ric Demians --- It doesn't work if --letter_code parameter isn't given to the script. There is an encoding problem with html output. I get warnings about wide character and the result isn't utf8 encoded. Maybe '>:encoding(utf8)' is required. It would be nice to have a --send|--nosend, defaulted to --nosend, in order to control whether the messages status is changed from 'pending' to 'sent'. This would ease testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 08:59:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 06:59:19 +0000 Subject: [Koha-bugs] [Bug 8480] auth_subfield_structure is not cleared when deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8480 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 08:59:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 06:59:21 +0000 Subject: [Koha-bugs] [Bug 8480] auth_subfield_structure is not cleared when deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8480 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37402|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 37794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37794&action=edit Bug 8480: Add constraint on auth_subfield_structure.authtypecode In order not to have useless entries in the auth_subfield_structure table, this patch modifies the DB structure to add a foreign key on the authtypecode column. Note that the auth_tag_structure already has this constraint. Test plan: 0/ Don't apply this patch 1/ Create a now authority type 'RM_ME' 2/ Look at the MARC structure, to create the subfield structure and populate the auth_subfield_structure table. 3/ Delete the authority type 4/ Using your SQL cli: SELECT COUNT(*) FROM auth_subfield_structure WHERE authtypecode='RM_ME'; => The data are still in this table. 5/ Apply this patch 6/ Execute the updatedb entry 7/ Confirm the entries in the auth_subfield_structure table related to RM_ME have been deleted 8/ Repeat 1, 2 and 3 and verify the auth_subfield_structure entries have been correctly removed. Signed-off-by: Frederic Demians - Works exactly as described in the (very good) test plan. - After authority type deletion, auth_subfield_structure still contains entries for deleted authority type. Applying the patch clean the previously undeleted records in auth_subfield_strucute. Now deleting a authority type cleans propertly all appropriate records in auth_subfield_structure. - Fix a merge conflict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 09:19:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 07:19:58 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #68 from Katrin Fischer --- We just changed the guidelines, I think for old patches already in the QA the old database updates are not a problem at all. Note: this is the form the RM will convert them to anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 09:52:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 07:52:28 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #81 from Jonathan Druart --- (In reply to Arturo from comment #80) > Hi, all. My library recently switched to Koha, and this is my first attempt > at testing a patch, but I am not sure if I am doing this correctly or if > I've truly run into an issue. > > I followed the instructions at http://wiki.koha-community.org/wiki/Sandboxes > to test this patch, bug 8753. I set up Sandbox 6 from BibLibre succesfully, > logged in correctly, and did not see any error messages in the 'news' area, > so it seems the patch was applied successfully. I have just tested to apply this patch on sandbox 6, I received an email within 5 minutes: sandbox is not ready ! There is a conflict with the patch. Did you see the pref OpacResetPassword? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:01:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:01:18 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #5 from Jonathan Druart --- (In reply to Andreas Hedstr?m Mace from comment #4) > This patch only seems to solve one of the two issues in the bug. The tab > number are there but longer descriptions are still being cut off. Please detail, I don't understand the problem here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:14:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:14:09 +0000 Subject: [Koha-bugs] [Bug 13992] New: Software error in reports if field or table does not exist Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992 Bug ID: 13992 Summary: Software error in reports if field or table does not exist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org To reproduce: - Go to Home > Reports Guided reports wizard - Create report from SQL - Enter something like: select holdrio from borrowers - Save SQL - run report Result: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/reports/guided_reports.pl line 932. expected: graceful error message - Change sql to something like: select id from holdrio; - Save SQL - Run report Result: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/reports/guided_reports.pl line 932. expected: graceful error message - Change sql to something like: pling from plong - Save SQL Result (after saving): Message "The database returned the following error: 1" Expected: Meaningful message "The database returned the following error: No SELECT" (similar to forbidden statements as UPDATE) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:16:20 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #6 from Andreas Hedstr?m Mace --- Created attachment 37795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37795&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:24:30 +0000 Subject: [Koha-bugs] [Bug 13993] New: Transfer order from one vendor to another vendor: Previous orderstatus is not changed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Bug ID: 13993 Summary: Transfer order from one vendor to another vendor: Previous orderstatus is not changed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:24:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:24:58 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor: Previous orderstatus is not changed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:25:14 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #7 from Andreas Hedstr?m Mace --- Added a screenshot of the issue. The description of the fields are still being cut off, like "fixed length control field" turning up as "fixed length control f". Hope this helps, otherwise ask again! =) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:25:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:25:16 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor: Previous orderstatus is not changed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:32:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:32:23 +0000 Subject: [Koha-bugs] [Bug 13992] Software error in reports if field or table does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:33:53 +0000 Subject: [Koha-bugs] [Bug 13992] Software error in reports if field or table does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992 --- Comment #1 from Marc V?ron --- Created attachment 37796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37796&action=edit Bug 13992 - Software error in reports if field or table does not exist To reproduce: - Go to Home > Reports Guided reports wizard - Create report from SQL - Enter something like: select holdrio from borrowers - Save SQL - run report Result: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/reports/guided_reports.pl line 932. expected: graceful error message - Change sql to something like: select id from holdrio; - Save SQL - Run report Result: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/reports/guided_reports.pl line 932. expected: graceful error message - Change sql to something like: pling from plong - Save SQL Result (after saving): Message "The database returned the following error: 1" Expected: Meaningful message "The database returned the following error: No SELECT" (similar to forbidden statements as UPDATE) Test plan: - Apply patch - Try to reproduce issues above. They should be resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:35:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:35:03 +0000 Subject: [Koha-bugs] [Bug 13992] Software error in reports if field or table does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:36:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:36:18 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor: Previous orderstatus is not changed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com --- Comment #1 from Amit --- Created attachment 37797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37797&action=edit Order transfer Suppose if we transfer order from one vendor to another vendor previous orderstatus is not changed still is showing new but if we see order in basket level it shown under cancelled order section. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:43:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:43:10 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor: Previous orderstatus is not changed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 --- Comment #2 from Amit --- Created attachment 37798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37798&action=edit Bug 13993 - Transfer order from one vendor to another vendor previous orderstatus is not changed Transfer order from one vendor to another vendor previous orderstatus is not changed To Test: 1) Create a vendor for ex: A 2) Create a basket under vendor A 3) Create a order 4) Create a vendor for ex: B 5) Create a basket under vendor B 6) Search vendor A and basket/order 7) Click on Transfer link and choose the vendor and basket in which you want to transfer the order 8) Go to mysql prompt and see previous orderstatus. For ex: mysql> select orderstatus from aqorders where ordernumber = 2; +-------------+ | orderstatus | +-------------+ | cancelled | +-------------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:43:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:43:25 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor: Previous orderstatus is not changed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 10:46:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 08:46:14 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Transfer order from one |Transfer order from one |vendor to another vendor: |vendor to another vendor |Previous orderstatus is not |previous orderstatus is not |changed |changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:07:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:07:45 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #16 from Jonathan Druart --- Created attachment 37799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37799&action=edit Bug 11603: Fix encoding issues (bug 11944 is now pushed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:09:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:09:08 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #17 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #15) > It doesn't work if --letter_code parameter isn't given to the script. What do you mean? If you use --csv or --ods, you have to provide a letter_code, otherwise generating a csv file does not have sense. > There is an encoding problem with html output. I get warnings about wide > character and the result isn't utf8 encoded. Maybe '>:encoding(utf8)' is > required. Should be fixed with the last patch, please retest html, csv and ods. > It would be nice to have a --send|--nosend, defaulted to --nosend, in order > to control whether the messages status is changed from 'pending' to 'sent'. > This would ease testing. Sorry but I don't plan to provide anything else than bug fixes until it's pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:15:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:15:20 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #7 from Mason James --- (In reply to Katrin Fischer from comment #6) > Hi Mason, > > can the first patch be obsoleted? hmm, no - it's a perltidy patch, that the feature depends on as you can see from the tidy patch, the sub() desperately needed tidying > I think this is not a problem specific to OverDrive, but to the error > messages from the SIP server? Shoudl we adjust the title? sure, thats fine with me i really was thinking about calling the bug/patch something a bit more general. but i couldn't really think of anything suitable > To have the library show up in the release notes as a sponsor, you can add > Sponsored-by: ... to the commit message > (http://wiki.koha-community.org/wiki/Commit_messages) thanks, i'll do that :0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:18:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:18:42 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 --- Comment #8 from Mason James --- (In reply to M. Tompsett from comment #6) > (In reply to Mason James from comment #4) > > 1/ attempt to view a subscription-detail that has a NULL value for either > > it's 'startdate' or 'enddate' > > The date picker forces it or a length to be entered. How do you get this > situation without messing with data in the back end? hmm, i'm really not sure but, we hit this bug in a prod koha, with no messing of data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:25:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:25:35 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |colin.campbell at ptfs-europe. | |com Component|OPAC |SIP2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:26:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:26:59 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:27:02 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #8 from Jonathan Druart --- Created attachment 37800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37800&action=edit Bug 8399: No need to truncate the marc field text to 22 chars The text for the marc field are truncated to 22 chars when displaying an error on mandatory fields. This limitation is useless and this patch removes it. Test plan: Create a mandatory subfield and set a long text (more than 22 chars) edit or add an authority, click on save. You should get the error displayed with the full text Note that this patch modifies the same code for biblio. Test plan is the same for biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:27:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:27:42 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #9 from Jonathan Druart --- (In reply to Andreas Hedstr?m Mace from comment #7) > Added a screenshot of the issue. The description of the fields are still > being cut off, like "fixed length control field" turning up as "fixed length > control f". Hope this helps, otherwise ask again! =) Perfect thanks! The last patch fixes that. Same on the biblio side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:31:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:31:50 +0000 Subject: [Koha-bugs] [Bug 13994] New: Add a back link to error message in Reports Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13994 Bug ID: 13994 Summary: Add a back link to error message in Reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org To reproduce: - Go to Home > Reports - Create from SQL - Do something that results in an error message, e.g. by entering an UPDATE statement Result: You get an error message with title "The follwing error was encountered" But there is now link to go directly back to fix it. Expected: Link "Back to previous page" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:32:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:32:54 +0000 Subject: [Koha-bugs] [Bug 13994] Add a back link to error message in Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13994 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |veron at veron.ch |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:36:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:36:54 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #1 from Ji?? Kozlovsk? --- Created attachment 37801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37801&action=edit Bug 13931 - Added date of birth to member's search results table (intranet/cgi-bin/koha/members/member.pl) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:42:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:42:38 +0000 Subject: [Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:42:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:42:41 +0000 Subject: [Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37791|0 |1 is obsolete| | --- Comment #2 from Andreas Hedstr?m Mace --- Created attachment 37802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37802&action=edit Bug 13991 - Uninitialized value $src in /tools/viewlog.pl To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl To test: Apply patch. Verify that no more warnings appear in intranet-error.log Verify that the log viewer behaves as before. Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:54:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:54:57 +0000 Subject: [Koha-bugs] [Bug 13994] Add a back link to error message in Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13994 --- Comment #1 from Marc V?ron --- Created attachment 37803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37803&action=edit Bug 13994 - Add a back link to error message in Reports To reproduce: - Go to Home > Reports - Create from SQL - Do something that results in an error message, e.g. by entering an UPDATE statement Result: You get an error message with title "The follwing error was encountered" But there is now link to go directly back to fix it. To test: - Apply patch - Repeat steps above - Verify that a link appears (and works): "Back to previous page" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:55:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:55:16 +0000 Subject: [Koha-bugs] [Bug 13994] Add a back link to error message in Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13994 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:56:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:56:54 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 11:56:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 09:56:57 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37405|0 |1 is obsolete| | Attachment #37800|0 |1 is obsolete| | --- Comment #10 from Andreas Hedstr?m Mace --- Created attachment 37804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37804&action=edit Bug 8399: No need to truncate the marc field text to 22 chars The text for the marc field are truncated to 22 chars when displaying an error on mandatory fields. This limitation is useless and this patch removes it. Test plan: Create a mandatory subfield and set a long text (more than 22 chars) edit or add an authority, click on save. You should get the error displayed with the full text Note that this patch modifies the same code for biblio. Test plan is the same for biblio. Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:14:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:14:08 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35259|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 37805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37805&action=edit Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:14:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:14:05 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:14:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:14:13 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 --- Comment #19 from Jonathan Druart --- Created attachment 37806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37806&action=edit Bug 7380: Rename filter to avoid confusion The branchcode and categorycode parameter names are too common and are confusing. To remove the ambiguity, this patch renames them with branchcode_filter and categorycode_filter. Test plan: 1/ Go on the patron home page (members-home.pl) 2/ Fill the library and category dropdown list in the header search 3/ The patron result list appears and the filters (on the right) are correctly set with what you have selected. Make sure the ones in the header are also correctly selected. 4/ Click on a patron 5/ On the patron detail page (moremember.pl), the dropdown lists in the header are not preselected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:14:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:14:48 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 --- Comment #20 from Jonathan Druart --- (In reply to Kyle M Hall from comment #15) > The library and category filters on moremember.pl appear to be preset to the > library and category of the patron you are viewing. This seems improper. Thanks for the catch! Should be fixed with the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:22:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:22:39 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #2 from Ji?? Kozlovsk? --- Created attachment 37807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37807&action=edit Bug 13931 - Added patron's dateofbirth to autocomplete -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:31:28 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #77 from Josef Moravec --- I tested this, and it looks great. Just few problems: ad Test plan 20. I'm not able to use keyboard shortcuts to focus search fields on the left side 21. I think the checkbox labels should be clickable as well ad part 3 - on search results I'm not able to scroll the page using keyboard Everything else looks working perfect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:34:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:34:13 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #1 from Nicolas Legrand --- Created attachment 37808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37808&action=edit Add desk management Test plan : 1/ perl installer/data/mysql/updatedatabase.pl (create new table desks) 2/ prove t/db_dependent/Desks.t 3/ go to admin page, click on desk management, try to create, modify and delete desks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:36:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:36:04 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:36:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:36:06 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37807|0 |1 is obsolete| | --- Comment #3 from Ji?? Kozlovsk? --- Created attachment 37809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37809&action=edit Bug 13931 - Implemented patron's dateofbirth autocompletion into newest version of circ/ysearch.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:39:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:39:27 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:40:07 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mail at jkozlovsky.cz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:49:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:49:42 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #82 from Jonathan Druart --- Created attachment 37810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37810&action=edit temporary tests Marc, If I am not wrong, these tests reflect what you are doing in the patches. If you have a look, you will see there are some mistakes. For instance output_pref( { dt => dt_from_string($iso), dateformat => 'iso', dateonly => 1 } ); won't return the same as C4::Dates->new( $iso, 'iso' )->output("iso"); But output_pref( { dt => dt_from_string({ dt => $iso, dateformat => 'iso' }), dateformat => 'iso', dateonly => 1 } ); will :) You should try to list exhaustively all existing patterns of C4::Dates you will replace and try to find their correct replacements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 12:56:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 10:56:47 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #22 from Jonathan Druart --- Comment on attachment 37781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37781 [Signed-off] Bug 13941 [1/2] Test tag with id/class attributes Review of attachment 37781: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13941&attachment=37781) ----------------------------------------------------------------- ::: xt/tt_valid.t @@ +55,5 @@ > + description => ' tag with id and class attributes', > + check => sub { > + my ($self, $name, $token) = @_; > + return if $name =~ /bodytag\.inc/; > + $_ = $token->{_string}; Sorry but I still don't understand why this is useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:01:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:01:31 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:01:33 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37801|0 |1 is obsolete| | Attachment #37809|0 |1 is obsolete| | --- Comment #4 from Ji?? Kozlovsk? --- Created attachment 37811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37811&action=edit Bug 13931 - Implemented date of birth in patron search result and in autocomplete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:11:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:11:34 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #5 from Ji?? Kozlovsk? --- Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:11:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:11:49 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #18 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #17) > > It doesn't work if --letter_code parameter isn't given to the script. > What do you mean? If you use --csv or --ods, you have to provide a > letter_code, otherwise generating a csv file does not have sense. It doesn't work with --html. This produces no html file: ./gather_print_notices.pl -s --html This works properly: ./gather_print_notices.pl -s --html --letter_code XXX I will fix that. > Should be fixed with the last patch, please retest html, csv and ods. It works. Thanks. > > It would be nice to have a --send|--nosend, defaulted to --nosend, in order > > to control whether the messages status is changed from 'pending' to 'sent'. > > This would ease testing. > Sorry but I don't plan to provide anything else than bug fixes until it's > pushed. No demand, no offense :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:17:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:17:33 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Actually the code confirms it's a feature: # determine default billing and delivery places depending on librarian homebranch and existing basketgroup data The following code could do the trick, but not sure if it's needed % git diff diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl index 9c57f69..b3fa964 100755 --- a/acqui/basketgroup.pl +++ b/acqui/basketgroup.pl @@ -254,12 +254,12 @@ if ( $op eq "add" ) { $freedeliveryplace = $basketgroup->{freedeliveryplace}; $template->param( closedbg => ($basketgroup ->{'closed'}) ? 1 : 0); } else { + # determine default billing and delivery places depending on librarian homebranch + my $borrower = GetMember( ( 'borrowernumber' => $loggedinuser ) ); + $billingplace = $borrower->{'branchcode'}; + $deliveryplace = $borrower->{'branchcode'}; $template->param( closedbg => 0); } - # determine default billing and delivery places depending on librarian homebranch and existing basketgroup data - my $borrower = GetMember( ( 'borrowernumber' => $loggedinuser ) ); - $billingplace = $billingplace || $borrower->{'branchcode'}; - $deliveryplace = $deliveryplace || $borrower->{'branchcode'}; my $branches = C4::Branch::GetBranchesLoop( $billingplace ); $template->param( billingplaceloop => $branches ); On the other hand I agree the behavior is odd :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:21:19 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #19 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #18) > (In reply to Jonathan Druart from comment #17) > > > > It doesn't work if --letter_code parameter isn't given to the script. > > > What do you mean? If you use --csv or --ods, you have to provide a > > letter_code, otherwise generating a csv file does not have sense. > > It doesn't work with --html. This produces no html file: > > ./gather_print_notices.pl -s --html > > This works properly: > > ./gather_print_notices.pl -s --html --letter_code XXX > > I will fix that. Ha yes, because of the "filter by letter_code" in any case :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:22:55 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 --- Comment #4 from Katrin Fischer --- Hi Jonathan, I'd agree to 'feature' if it only preselected before saving it the first time - but it should display what is saved in the database when you open it again later - even if I have left the field empty on purpose. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:23:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:23:18 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #20 from Fr?d?ric Demians --- Created attachment 37812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37812&action=edit Bug 11603 Add --send|--nosend, fix stuf Fix --html without --letter_code Fix --ods which was producing a 2 lines ods file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:23:32 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 --- Comment #5 from Katrin Fischer --- Otherwise... we should not offer the empty option in the first place! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:23:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:23:46 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:23:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:23:48 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37799|0 |1 is obsolete| | --- Comment #21 from Fr?d?ric Demians --- Created attachment 37813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37813&action=edit [SIGNED-OFF] Bug 11603: Fix encoding issues (bug 11944 is now pushed) Signed-off-by: Frederic Demians No more encoding issue with html file, no problem with csv|ods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:24:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:24:17 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30983|0 |1 is obsolete| | --- Comment #22 from Fr?d?ric Demians --- Created attachment 37814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37814&action=edit [SIGNED-OFF] Bug 11603: If a letter code is given, filenames should contain it If you choose to generate print notices for a specific letter code, the generated files should be distinct. The use case is: you want to process print notice for letter codes: overdue1, overdue2 and overdue3. The cronjobs will be: perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue1 --csv --ods --html --delimiter=";" perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue2 --csv --ods --html --delimiter=";" perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue3 --csv --ods --html --delimiter=";" without this patch, the 2 first files will be erased. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:24:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:24:32 +0000 Subject: [Koha-bugs] [Bug 9988] Unneeded timeouts when saving authorities (Can we merge smarter?) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11496 CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Is it a duplicate of bug 11496? (Or the opposite :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:24:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:24:32 +0000 Subject: [Koha-bugs] [Bug 11496] The number of tested records when searching for duplicates during import is too low In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9988 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:24:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:24:46 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30982|0 |1 is obsolete| | --- Comment #23 from Fr?d?ric Demians --- Created attachment 37815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37815&action=edit [SIGNED-OFF] Bug 11603: Gather print notices - add a ods parameter This patch adds: - the ability to generate an ods file >From now you are able to generate a ods file for print notices. You would like to generate a csv file and not a html file. Test plan: - same as previous patch but test the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods --letter_code=OVERDUE -d=: you should get an error because csv2ods is not installed. Follow the installation instructions and try again the command. A ods file should be generated in your /tmp/test directory. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:25:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:25:18 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30981|0 |1 is obsolete| | --- Comment #24 from Fr?d?ric Demians --- Created attachment 37816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37816&action=edit [SIGNED-OFF] Bug 11603: Gather print notices - add a csv parameter This patch adds: - the ability to generate a csv file instead of a html file. - a letter_code parameter. >From now you are able to generate a csv file for print notices. Imagine a template notice defined as: cardnumber:patron:email:item <>:<> >:<>:<> You would like to generate a csv file and not a html file. Test plan: - define your OVERDUE notice for the print template as: cardnumber:patron:email:item <>:<> >:<>:<> - define overdues rules for a patron category - check 2 items out using a due date in order to generate the overdue notices - check these 2 items in - launch the overdue_notices script - the message_queue table should now contain 2 new entries - launch the gather_print_notices cronjob with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE --letter_code=CHECKIN you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE -d=: will produce 1 csv file in your /tmp/test directory - verify the csv file is correct and contain only 1 csv header column. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:25:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:25:52 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30980|0 |1 is obsolete| | --- Comment #25 from Fr?d?ric Demians --- Created attachment 37817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37817&action=edit [SIGNED-OFF] Bug 11603: Preparation step, cleaning up This patch refactores and adds some good practices: - use Modern::Perl - use Pod::Usage - add POD Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:30:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:30:14 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #26 from Fr?d?ric Demians --- For me, it functional, well documented, and add a way to do something worthwhile with 'print' notifications. I've tested all script options with success producing usable HTML, CSV, and OOffice files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:49:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:49:35 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:49:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:49:38 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 --- Comment #1 from Jonathan Druart --- Created attachment 37818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37818&action=edit Bug 10131: Add a fallback if the pref search is not a valid regex It's possible to search prefs using a regex. But it the regex is not correctly written, the app explodes. We should provide a fallback. Test plan: 0/ Does not apply the patch 1/ Search for sysprefs with "notes.*", note the number of results 2/ Search for *notes*, boom 3/ Apply the patch 4/ Repeat 1 and confirm you get the same number of results 5/ Repeat 2 and confirm you don't get the error anymore -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:50:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:50:51 +0000 Subject: [Koha-bugs] [Bug 10098] Inactive Funds are still showing in Acquisitions Order screen in Internet Explorer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10098 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |WONTFIX --- Comment #2 from Jonathan Druart --- (In reply to Owen Leonard from comment #1) > It works correctly in IE11, FWIW. So mark as wontfix, feel free to reopen if you want to provide a patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:57:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:57:58 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #27 from Jonathan Druart --- Thanks Fr?d?ric. There is something wrong the the patches order. I don't know how you did that but they are in the wrong order :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 13:58:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 11:58:01 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 --- Comment #4 from Blou --- I revalidated. The patches does fix the problem for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 14:07:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 12:07:58 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #23 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #22) > Comment on attachment 37781 [details] [review] > [Signed-off] Bug 13941 [1/2] Test tag with id/class attributes > > Review of attachment 37781 [details] [review]: > ----------------------------------------------------------------- > > ::: xt/tt_valid.t > @@ +55,5 @@ > > + description => ' tag with id and class attributes', > > + check => sub { > > + my ($self, $name, $token) = @_; > > + return if $name =~ /bodytag\.inc/; > > + $_ = $token->{_string}; > > Sorry but I still don't understand why this is useful. The sub complete code is: my ($self, $name, $token) = @_; return if $name =~ /bodytag\.inc/; $_ = $token->{_string}; push @{$self->{errors}->{$name}}, $token->{_lc} if /^{_string} =~ $/^{_string} =~ /id=".+"/ && ! $token->{_string} =~ /class=".+"/; Hope this explanation doesn't obfuscate more something which isn't already that clear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 14:17:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 12:17:59 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 --- Comment #4 from M. Tompsett --- Comment on attachment 37787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37787 Bug 13979: updates to allow installation on jessie Review of attachment 37787: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13979&attachment=37787) ----------------------------------------------------------------- It eyeballs well, just one question... ::: debian/rules @@ +24,5 @@ > $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce > ln -s /usr/share/tinymce/www \ > $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce > +# ln -s /usr/share/javascript/yui \ > +# $(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/lib/yui Why did you comment this one, but the other two you expressly deleted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 14:22:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 12:22:29 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #4 from Julian FIOL --- Created attachment 37819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37819&action=edit Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 14:23:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 12:23:23 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #13 from M. Tompsett --- (In reply to Katrin Fischer from comment #12) > And is this really a bug? What if a library just doesn't want to display > anything in department and term? Then they wouldn't have entered any authorized values, right? Blanks in dropdowns shouldn't be forced data-entries. They should be added to the dropdowns. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 14:25:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 12:25:07 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #14 from M. Tompsett --- (In reply to Katrin Fischer from comment #11) > In the past Koha > even came with 0 values that had empty descriptions to offer an empty entry > in some pull down lists. Can you provide a suggestion where to look in the user interface for these types of drop-downs that may require blanks? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 14:28:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 12:28:39 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37819|0 |1 is obsolete| | --- Comment #5 from Julian FIOL --- Created attachment 37820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37820&action=edit Bug 13969 : Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files 1. Replace all calls to $sth->fetchrow_array with a call to $dbh->selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t && Review.pl files with koha-qa tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 14:28:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 12:28:46 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #8 from M. de Rooy --- Thanks, Frederic for your SO. I am not sure however if everything went fine? When applying your patch, I get: fatal: sha1 information is lacking or useless (misc/cronjobs/cleanup_database.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. And the signed-off patch contains this line: +>>>>>>> Bug 13049: Merge selfreg cron jobs into cleanup_database It is in the usage statement of cleanup_database.pl If it is easy for you to fix it, go ahead :) Otherwise I will fix it tomorrow or so.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 14:45:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 12:45:59 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 14:46:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 12:46:18 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 14:46:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 12:46:43 +0000 Subject: [Koha-bugs] [Bug 13969] Testing C4::Review In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:06:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:06:39 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #82 from Arturo --- (In reply to Jonathan Druart from comment #81) > (In reply to Arturo from comment #80) > > Hi, all. My library recently switched to Koha, and this is my first attempt > > at testing a patch, but I am not sure if I am doing this correctly or if > > I've truly run into an issue. > > > > I followed the instructions at http://wiki.koha-community.org/wiki/Sandboxes > > to test this patch, bug 8753. I set up Sandbox 6 from BibLibre succesfully, > > logged in correctly, and did not see any error messages in the 'news' area, > > so it seems the patch was applied successfully. > > I have just tested to apply this patch on sandbox 6, I received an email > within 5 minutes: > sandbox is not ready ! > > There is a conflict with the patch. > > Did you see the pref OpacResetPassword? Yes, I did see the OpacResetPassword preference, turned it on along with the pref to allow patrons to change their passwords, and went to the homepage and saw the "Forgot my password" link. Below is the result I got when I set up the sandbox. It does seem to start off with a warning, perhaps ("Use of uninitialized value"), but the message does say that the patch for bug 8753 were applied successfully. The sandbox you've requested is now ready. The patches attached to bugzilla 8753 have been applied, and the result is: Updatedatabase: Use of uninitialized value in substitution (s///) at /home/koha/src/installer/data/mysql/updatedatabase.pl line 9676. Upgrade to 3.19.00.004 done (Bug 13346: OpacExportOptions is now multiple) Upgrade to 3.19.00.005 done (Bug 13379 - Modify authorised_values.category to varchar(32)) Upgrade to 3.19.00.006 done (Bug 11944 - Convert DB tables to utf8_unicode_ci) Upgrade to 3.19.00.007 done (Bug 12905: Check budget integrity: OK) Upgrade to 3.19.00.008 done (Bug 12601 - Add new foreign key aqorders.budget_id) Upgrade to 3.19.00.009 done (Bug 13007 - Add new foreign key suggestions.budgetid) Upgrade to 3.19.00.010 done (Bug 5511 - SessionRestrictionByIP) Upgrade to 3.19.00.011 done (Bug 13417: Add permission to delete public lists) Upgrade to 3.19.00.012 done (Bug 13523 - Remove NOT NULL restriction on field marcxml due to mysql STRICT_TRANS_TABLES) Upgrade to 3.19.00.013 done (Bug 11395: Add permission tools_records_batchmod) Upgrade to 3.19.00.014 done (Bug 12648: Add letter ACQ_NOTIF_ON_RECEIV ) Upgrade to 3.19.00.015 done (Bug 11430 - Add primary key for search_history) Upgrade to 3.19.00.016 done (Bug 13380: Add the ORDER_CANCELLATION_REASON authorised value) Upgrade to 3.19.00.017 done (Bug 5786 - Move AllowOnShelfHolds to circulation matrix; Move OPACItemHolds system preference to circulation matrix) Upgrade to 3.19.00.018 done (Bug 10328: Rename opaccolorstylesheet to OpacAdditionalStylesheet Upgrade to 3.19.00.019 done (Bug 9580: Cover image from Coce, a remote image URL cache) Upgrade to XXX done (Bug 8753: Add forgot password link to OPAC) If you use this system for the 1st time, you may find usefull to reach the wiki page http://wiki.koha-community.org/wiki/Sandboxes to have some information about those results, to check if everything went well & if you can test the patch properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:09:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:09:27 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- (In reply to Jonathan Druart from comment #1) > 1/ Search for sysprefs with "notes.*", note the number of results > 2/ Search for *notes*, boom > 3/ Apply the patch > 4/ Repeat 1 and confirm you get the same number of results > 5/ Repeat 2 and confirm you don't get the error anymore Actually, I've tried: black -- works (1 result) black.* -- works (1 result) .*black -- works (1 result) .*black.* -- works (1 result) black* -- works (1 result) *black -- runs (0 results) *black* -- runs (0 results) Perl 5.18.2 on Ubuntu 14.04 if that matters. Why the two with 0 results? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:11:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:11:29 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #3 from M. Tompsett --- Since bugzilla didn't tell me that Jonathan got my question, and since he provided the patch, I changed the bug so he is the assigned person. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:22:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:22:18 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #24 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #23) > (In reply to Jonathan Druart from comment #22) > > Comment on attachment 37781 [details] [review] [review] > > [Signed-off] Bug 13941 [1/2] Test tag with id/class attributes > > > > Review of attachment 37781 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: xt/tt_valid.t > > @@ +55,5 @@ > > > + description => ' tag with id and class attributes', > > > + check => sub { > > > + my ($self, $name, $token) = @_; > > > + return if $name =~ /bodytag\.inc/; > > > + $_ = $token->{_string}; > > > > Sorry but I still don't understand why this is useful. > > The sub complete code is: > > my ($self, $name, $token) = @_; > return if $name =~ /bodytag\.inc/; > $_ = $token->{_string}; > push @{$self->{errors}->{$name}}, $token->{_lc} > if /^ > The $_ is used in the last line which should have been coded like that > without $_ assignation: > > if $token->{_string} =~ $/^ ! $token->{_string} =~ /id=".+"/ && > ! $token->{_string} =~ /class=".+"/; > > Hope this explanation doesn't obfuscate more something which isn't already > that clear. Sorry, read to quickly the push statement. I personally think it's a bad idea to assign the default variable, but I don't want to impose that. Without the second patch applied, I get: % prove xt/tt_valid.t xt/tt_valid.t .. Can't use string ("") as a HASH ref while "strict refs" in use at xt/tt_valid.t line 60. # Looks like your test exited with 255 before it could output anything. xt/tt_valid.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/3 subtests Test Summary Report ------------------- xt/tt_valid.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 3 tests but ran 0. Files=1, Tests=0, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.10 cusr 0.00 csys = 0.12 CPU) Result: FAIL If I apply the second one, and remove an id from a body tag: % git diff diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt index 74bedcb..ffd1c1b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt @@ -123,7 +123,7 @@ function submitForm(form) { //]]> - + [% INCLUDE 'header.inc' %] [% INCLUDE 'acquisitions-search.inc' %] % prove xt/tt_valid.t xt/tt_valid.t .. ok All tests successful. Files=1, Tests=3, 2 wallclock secs ( 0.02 usr 0.00 sys + 2.76 cusr 0.00 csys = 2.78 CPU) Result: PASS Shouldn't it fail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:25:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:25:15 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 --- Comment #4 from Jonathan Druart --- (In reply to M. Tompsett from comment #2) > (In reply to Jonathan Druart from comment #1) > > 1/ Search for sysprefs with "notes.*", note the number of results > > 2/ Search for *notes*, boom > > 3/ Apply the patch > > 4/ Repeat 1 and confirm you get the same number of results > > 5/ Repeat 2 and confirm you don't get the error anymore > > Actually, I've tried: > black -- works (1 result) > black.* -- works (1 result) > .*black -- works (1 result) > .*black.* -- works (1 result) > black* -- works (1 result) > *black -- runs (0 results) > *black* -- runs (0 results) > > Perl 5.18.2 on Ubuntu 14.04 if that matters. > Why the two with 0 results? Because it's not a well formatted regex. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:26:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:26:22 +0000 Subject: [Koha-bugs] [Bug 10161] rebuild_zebra.pl should (at least) exit 1 on error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Which errors should be caught? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:28:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:28:32 +0000 Subject: [Koha-bugs] [Bug 10161] rebuild_zebra.pl should (at least) exit 1 on error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10161 --- Comment #2 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #1) > Which errors should be caught? By the time I filled this one, I noticed that we weren't capturing zebraidx failures (i.e. an error was printed but no error code returned). Also, problems with DB access, koha-conf.xml access, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:31:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:31:46 +0000 Subject: [Koha-bugs] [Bug 13399] Select a department: empty field if no description set in authorized value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13399 --- Comment #15 from Katrin Fischer --- Mark, Term and Department are mandatory in the course reserves module - the library is forced to enter an authorized value. Asked the other way around: what negative side effect does it have to not enforce entering a subscription? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:49:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:49:43 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:49:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:49:46 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 --- Comment #5 from Jonathan Druart --- Created attachment 37821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37821&action=edit Bug 10285: Remove links from the error pages The error page (400, 401, 402, 403, 404, 405 and 500) displays parts the old staff client main page. The user can easily browses using navigation links. Test plan: Go on the 400.pl, 401.pl, 402.pl, 403.pl, 404.pl, 405.pl and 500.pl pages, and confirm all is fine and you don't get the old style blocks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:50:22 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:57:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:57:01 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #24) > Sorry, read to quickly the push statement. > I personally think it's a bad idea to assign the default variable, but I > don't want to impose that. I agree with you. Since I have to fix the patch due to you other comment, I will stop using default variable which doesn't add readability in these case. > Without the second patch applied, I get: > % prove xt/tt_valid.t > xt/tt_valid.t .. Can't use string ("") as a HASH ref while "strict > refs" in use at xt/tt_valid.t line 60. It comes from fixing the warning you reported. I will send new version of the UT. > Shouldn't it fail? Yes, it should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:58:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:58:03 +0000 Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 --- Comment #5 from Nicole C. Engard --- (In reply to Nick Clemens from comment #3) > Outside the scope of this change, but if I had my druthers: > > 246 2nd indicator specifies type of other title, would be nice to display > that when 1st indicator 1. Probab;y it would go into brackets like relator > terms and would be overridden by subfield i > > That out of the way, works as described and will sign off momentarily I think that will be easy to add after the fact - but do agree! Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:58:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:58:22 +0000 Subject: [Koha-bugs] [Bug 10252] File Print of Checkout History Truncates Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jonathan Druart --- All these issues are now fixed. Please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 15:59:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 13:59:52 +0000 Subject: [Koha-bugs] [Bug 13434] 586 XSLT improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 --- Comment #5 from Nicole C. Engard --- (In reply to Nick Clemens from comment #4) > Separation and display look good so signing off, but I have some questions > that I am leaving for QA: > > 1 - Before this patch the awards displayed in the description tab only on > staff-client, and both in detail view and description tab on opac. I am > thinking if we are going to display on the details page we should remove > from description tab on both staff/opac - maybe out of scope. We have the summary in the title notes tab and above the holdings table and the table of contents as well. I think it's okay to leave and if you want to hide it from title notes you can do so using the system preference just for that. > > 2 - indicator 1 is supposed to control generation of display content > "Awards:" (display if blank, dont if =8) and it does if all =8, but with > multiple fields and a mix of =8 or =# you always get the "Awards:" I don't > know if it would be worth splitting them into two display sections based on > the indicator or if it isn't a big deal This one I'm not sure about. I think we should follow MARC rules - but lots of times libraries don't follow MARC rules :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:01:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:01:05 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 --- Comment #8 from Nicole C. Engard --- (In reply to Nick Clemens from comment #7) > I just have a question on this one: > > Are we intentionally not displaying subfields d,f,l,m,o ? They show now but > are gone after I apply. > > I like the addition of n,p,s but I think it would be better to display all > fields that exist as I think you won't often encounter them all, but if they > are there you probably want to see them > > Also, there is no subfield b or c for uniform titles, at least not according > to MARC21 standard The original Spec said: "Display corresponding subfields a, b, c, k, n, p, s" But if those fields were there I do think we should keep them if they're useful. It might have to do with the new rules of MARC - so maybe someone from the libraries that asked for this could chime in. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:01:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:01:24 +0000 Subject: [Koha-bugs] [Bug 10253] tax rate only takes 1 decimal point In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12825 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:01:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:01:24 +0000 Subject: [Koha-bugs] [Bug 12825] GST / VAT rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10253 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:01:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:01:32 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10253 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:01:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:01:32 +0000 Subject: [Koha-bugs] [Bug 10253] tax rate only takes 1 decimal point In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13323 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:05:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:05:02 +0000 Subject: [Koha-bugs] [Bug 13995] New: Proper Exception handling Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Bug ID: 13995 Summary: Proper Exception handling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org We should have a Java-style Exception handling mechanism in place. It will make it easier to handle exception across the board. Try::Tiny and Exception::Class seem to be the most bestest approaches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:06:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:06:22 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:09:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:09:30 +0000 Subject: [Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:09:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:09:32 +0000 Subject: [Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 --- Comment #2 from Jonathan Druart --- Created attachment 37822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37822&action=edit Bug 10235: Add DataTables filters on local use prefs There is no way to search for local use prefs. This patch provides an easy way to search for pref present in of local use prefs table. Test plan: 1/ Go on the system preferences administration page 2/ Click on the Local Use table 3/ Confirm you are able to filter the table by pref name or description using the DataTables filters on top of it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:09:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:09:55 +0000 Subject: [Koha-bugs] [Bug 10235] Koha's syspref search fails to find 'local' sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:18:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:18:56 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:19:48 +0000 Subject: [Koha-bugs] [Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10234 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:19:48 +0000 Subject: [Koha-bugs] [Bug 10234] MySQL error when adding entry to z39.50servers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED Resolution|--- |FIXED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6536 --- Comment #1 from Jonathan Druart --- It should have been solved by bug 6536. Marked as fixed, please open if I am wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:25:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:25:33 +0000 Subject: [Koha-bugs] [Bug 10232] Permission check for editing help files is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- A fix could be to add a permission to edit help files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:29:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:29:21 +0000 Subject: [Koha-bugs] [Bug 10231] When logging in with database user library selection is not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Katrin, do you agree to closed this one marking it as invalid? It has been decided that the DB user should not be used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:30:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:30:16 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:30:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:30:19 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37782|0 |1 is obsolete| | --- Comment #26 from Fr?d?ric Demians --- Created attachment 37823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37823&action=edit Bug 13941 [2/2] Fix tags missing id/class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:30:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:30:42 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37781|0 |1 is obsolete| | --- Comment #27 from Fr?d?ric Demians --- Created attachment 37824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37824&action=edit Bug 13941 [1/2] Test tag with id/class attributes Test: - Apply the first patch [1/2] containing a new test checking tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid tags. - Apply the second patch [2/2] fixing all invalid tags. - Re-run the test: It passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:32:02 +0000 Subject: [Koha-bugs] [Bug 10232] Permission check for editing help files is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 --- Comment #3 from Katrin Fischer --- Hi Jonathan, that would probably be the cleanest option. - Right now it's limited to the superlibrarian, but the code seems like it intended something else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:34:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:34:14 +0000 Subject: [Koha-bugs] [Bug 10231] When logging in with database user library selection is not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10231 --- Comment #5 from Katrin Fischer --- I think we can mark INVALID. Although I think it's still needed that you can choose a library from the GUI - as that is a needed step to create your staff patron for later use. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:49:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:49:06 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:49:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:49:08 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37818|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 37825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37825&action=edit Bug 10131: Add a fallback if the pref search is not a valid regex It's possible to search prefs using a regex. But it the regex is not correctly written, the app explodes. We should provide a fallback. Test plan: 0/ Does not apply the patch 1/ Search for sysprefs with "notes.*", note the number of results 2/ Search for *notes*, boom 3/ Apply the patch 4/ Repeat 1 and confirm you get the same number of results 5/ Repeat 2 and confirm you don't get the error anymore NOTE: As noted on comment #3, the kaboom is because of the leading * and not the following *, because 's*' is a valid regular expression, while '*n' is not. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 16:50:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 14:50:12 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37825|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 37826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37826&action=edit Bug 10131: Add a fallback if the pref search is not a valid regex It's possible to search prefs using a regex. But it the regex is not correctly written, the app explodes. We should provide a fallback. Test plan: 0/ Does not apply the patch 1/ Search for sysprefs with "notes.*", note the number of results 2/ Search for *notes*, boom 3/ Apply the patch 4/ Repeat 1 and confirm you get the same number of results 5/ Repeat 2 and confirm you don't get the error anymore NOTE: As noted on comment #4, the kaboom is because of the leading * and not the following *, because 's*' is a valid regular expression, while '*n' is not. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 17:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 15:06:13 +0000 Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u, | |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Confirmed, it comes from installer/data/mysql/en/optional/sample_creator_data.sql It inserts a row into creator_templates with profile_id=13, but no printers_profile is inserted with this profile_id. Chris, could you have a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 17:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 15:14:41 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 37827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37827&action=edit Bug 13995 - Proper Exception handling try { Koha::Exception::BadSystemPreference->throw(error => 'Syspref DisplayIconsXSLT is not a valid boolean'); } catch { if (blessed($_) && $_->isa('Koha::Exception::BadSystemPreference')) { print $_->as_string(); warn $_->error, "\n", $_->trace->as_string, "\n"; } else { $_->rethrow(); } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 17:17:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 15:17:53 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 17:21:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 15:21:46 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #2 from Olli-Antti Kivilahti --- Decided to create separate packages/files for each Exception, so IDE's can more easily pick up package definitions and autocomplete available packages, so we don't have to remember was the Exception named as Koha::Exceptions::NoSystempreference or Koha::Exception::NoSysPref or Koha::Exception::NoSystemPreference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 17:21:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 15:21:56 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 17:35:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 15:35:12 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 17:50:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 15:50:07 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 18:30:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 16:30:34 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #7 from Heather Braum --- I'm not quite following the comments being made here -- forgive my ignorance on how MARC works with the Koha items table. TLDR version: Regardless of how this is developed and coded, will the final data field result be mappable to a MARC 952 subfield within Koha? It also is a status that needs to be constantly updated, in order for it to be used successfully by an external system. Long version: Background: Right now the not for loan, the lost, the damaged, and the withdrawn fields are separate items table subfields and mapped to the 952 field within MARC. Additionally, the in transit/on hold, waiting for pickup status of an item is stored elsewhere. NEKLS, SEKLS, and CKLS would like to develop an additional Koha field that is then possible to be mapped to a MARC 952 subfield so external systems are able to tell if an item is TRULY available for ILL (in our specific case); I'm sure there are other uses we haven't thought about. This new field would be able to aggregate the separate onloan, notforloan, withdrawn, lost, and damaged item fields, as well as pull in the separate data from the branchtransfers and reserves tables that indicate if an item is in transit and/or on hold waiting for pickup; it would need to be updated automatically -- not only on exports or when scripts are run. When we first looked into this last fall, we discovered that other ILSes typically have one MARC subfield where availability data is stored. Koha currently has the data that determines an item's availability stored all over the place. Right now, this external system profiles our systems using the 952$q field (items.onloan). That field isn't enough, obviously, to determine true availability; items that are on hold, in transit, lost, damaged, regularly appear on ILL request lists. Years ago, we asked about how to fix this problem, but were told a major rewrite of Koha would have to happen. Obviously, we've lived with the situation since. But Jason Robb at SEKLS started asking questions last fall, and we were told that this problem is possible to be fixed now. It was originally explained to us that this development could have greater impact on Koha in other places, too, but Kyle can explain that part much better. As long as we can map the outcome of where ever this data combining all of these statuses is stored to a MARC 952 item field, I don't care how it's developed :) But if the end result is that this new field is not going to be constantly updated and it can't be mapped to a MARC subfield, we may have to abandon this development. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 18:33:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 16:33:02 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 20:07:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 18:07:33 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37766|0 |1 is obsolete| | --- Comment #83 from Marc V?ron --- Created attachment 37828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37828&action=edit Bug 13813 - Remove C4::Dates from circ/waitingreserves.pl To test: Go to Home > Circulation > Holds awaiting pickup (Circulation Rports - Holds awaiting pickup) Verify that date in page title appears correcty Amended following comment #58 Changed output_pref to format 'iso' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 20:39:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 18:39:47 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37817|0 |1 is obsolete| | --- Comment #28 from Fr?d?ric Demians --- Created attachment 37829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37829&action=edit [SIGNED-OFF] Bug 11603: Preparation step, cleaning up This patch refactores and adds some good practices: - use Modern::Perl - use Pod::Usage - add POD Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 20:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 18:40:07 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37816|0 |1 is obsolete| | --- Comment #29 from Fr?d?ric Demians --- Created attachment 37830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37830&action=edit [SIGNED-OFF] Bug 11603: Gather print notices - add a csv parameter This patch adds: - the ability to generate a csv file instead of a html file. - a letter_code parameter. >From now you are able to generate a csv file for print notices. Imagine a template notice defined as: cardnumber:patron:email:item <>:<> >:<>:<> You would like to generate a csv file and not a html file. Test plan: - define your OVERDUE notice for the print template as: cardnumber:patron:email:item <>:<> >:<>:<> - define overdues rules for a patron category - check 2 items out using a due date in order to generate the overdue notices - check these 2 items in - launch the overdue_notices script - the message_queue table should now contain 2 new entries - launch the gather_print_notices cronjob with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE --letter_code=CHECKIN you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE -d=: will produce 1 csv file in your /tmp/test directory - verify the csv file is correct and contain only 1 csv header column. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 20:40:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 18:40:23 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37815|0 |1 is obsolete| | --- Comment #30 from Fr?d?ric Demians --- Created attachment 37831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37831&action=edit [SIGNED-OFF] Bug 11603: Gather print notices - add a ods parameter This patch adds: - the ability to generate an ods file >From now you are able to generate a ods file for print notices. You would like to generate a csv file and not a html file. Test plan: - same as previous patch but test the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods --letter_code=OVERDUE -d=: you should get an error because csv2ods is not installed. Follow the installation instructions and try again the command. A ods file should be generated in your /tmp/test directory. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 20:40:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 18:40:35 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37814|0 |1 is obsolete| | --- Comment #31 from Fr?d?ric Demians --- Created attachment 37832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37832&action=edit [SIGNED-OFF] Bug 11603: If a letter code is given, filenames should contain it If you choose to generate print notices for a specific letter code, the generated files should be distinct. The use case is: you want to process print notice for letter codes: overdue1, overdue2 and overdue3. The cronjobs will be: perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue1 --csv --ods --html --delimiter=";" perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue2 --csv --ods --html --delimiter=";" perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue3 --csv --ods --html --delimiter=";" without this patch, the 2 first files will be erased. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 20:40:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 18:40:53 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37813|0 |1 is obsolete| | --- Comment #32 from Fr?d?ric Demians --- Created attachment 37833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37833&action=edit [SIGNED-OFF] Bug 11603: Fix encoding issues (bug 11944 is now pushed) Signed-off-by: Frederic Demians No more encoding issue with html file, no problem with csv|ods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 20:41:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 18:41:00 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37812|0 |1 is obsolete| | --- Comment #33 from Fr?d?ric Demians --- Created attachment 37834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37834&action=edit Bug 11603 Add --send|--nosend, fix stuf Fix --html without --letter_code Fix --ods which was producing a 2 lines ods file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 20:43:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 18:43:07 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #34 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #27) > Thanks Fr?d?ric. > There is something wrong the the patches order. I don't know how you did > that but they are in the wrong order :) Sorry. I git bz on me. I verified that it's fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 20:51:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 18:51:54 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37753|0 |1 is obsolete| | --- Comment #84 from Marc V?ron --- Created attachment 37835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37835&action=edit Bug 13813 - Remove C4::Dates from members/readingrec.pl This patch removes depraceted C4::Dates from members/readingrec.pl To test: Apply patch Go to a patron's cirulation history Verify that circulation history behaves as before. Amended following comment #58 /MV Amended to fix output_pref (dateonly added) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 21:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 19:18:39 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcapovilla at live.ca --- Comment #6 from Blou --- *** Bug 11874 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 21:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 19:18:39 +0000 Subject: [Koha-bugs] [Bug 11874] Add a "Call number fields" column to the Z39.50 search results. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11874 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Blou --- We merge both solutions (12747 and this) since they are obviously the same thing in the back. *** This bug has been marked as a duplicate of bug 12747 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 21:21:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 19:21:40 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30713|0 |1 is obsolete| | --- Comment #7 from Blou --- Created attachment 37836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37836&action=edit Bug 12747 Add extra column in Z3950 search result This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 21:22:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 19:22:17 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 21:25:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 19:25:51 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Component|Acquisitions |Cataloging Assignee|simith.doliveira at inlibro.co |philippe.blouin at inlibro.com |m | --- Comment #8 from Blou --- This is a redo of the two previous patches, along with the changes to make it identical in Cataloguing as in Acquisitions (see #11874). I switched the component to Cataloguing since it's the most used or the two, and that "Acquisitions" has a tendency to frighten out would-be testers :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 21:28:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 19:28:25 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #35 from Fr?d?ric Demians --- Created attachment 37837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37837&action=edit Bug 11678: Gather print notices: add --email parameter This patch add the ability to send generated files by email. You can specify several emails. Test plan: - same as Bug 11603 - call the script misc/cronjobs/gather_print_notices.pl with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --ods --html --letter_code=CHECKIN -d=: --email="email_one at example.org" --email="email_two at example.org" Signed-off-by: Frederic Demians - Works as desribed. Rebased upon bug-11603. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 21:29:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 19:29:36 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37837|0 |1 is obsolete| | --- Comment #36 from Fr?d?ric Demians --- Comment on attachment 37837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37837 Bug 11678: Gather print notices: add --email parameter Wrong patch attachment! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 21:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 19:31:08 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30984|0 |1 is obsolete| | --- Comment #8 from Fr?d?ric Demians --- Created attachment 37838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37838&action=edit Bug 11678: Gather print notices: add --email parameter This patch add the ability to send generated files by email. You can specify several emails. Test plan: - same as Bug 11603 - call the script misc/cronjobs/gather_print_notices.pl with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --ods --html --letter_code=CHECKIN -d=: --email="email_one at example.org" --email="email_two at example.org" Signed-off-by: Frederic Demians - Works as described. Rebased upon bug-11603. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 21:34:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 19:34:09 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 22:11:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 20:11:52 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36881|0 |1 is obsolete| | --- Comment #85 from Marc V?ron --- Created attachment 37839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37839&action=edit Bug 13813 - Remove C4::Dates from members/printfeercpt.pl To test: Apply patch Go to a patrons Account In table of fines / transactions, column 'Print', click on 'Print' of a payment transaction ("Payment, thanks") Verify that the date displays correctly on the receipt. Amended for proper input for dt_from_string - (is 'iso') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 22:29:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 20:29:33 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37835|0 |1 is obsolete| | --- Comment #86 from Marc V?ron --- Created attachment 37840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37840&action=edit Bug 13813 - Remove C4::Dates from members/readingrec.pl This patch removes depraceted C4::Dates from members/readingrec.pl To test: Apply patch Go to a patron's cirulation history Verify that circulation history behaves as before. Amended following comment #58 /MV Amended to fix output_pref (dateonly added) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 22:33:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 20:33:18 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37839|0 |1 is obsolete| | --- Comment #87 from Marc V?ron --- Created attachment 37841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37841&action=edit Bug 13813 - Remove C4::Dates from members/printfeercpt.pl To test: Apply patch Go to a patrons Account In table of fines / transactions, column 'Print', click on 'Print' of a payment transaction ("Payment, thanks") Verify that the date displays correctly on the receipt. Amended for proper input for dt_from_string - (is 'iso') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 22:36:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 20:36:44 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37841|0 |1 is obsolete| | --- Comment #88 from Marc V?ron --- Created attachment 37842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37842&action=edit Bug 13813 - Remove C4::Dates from members/printfeercpt.pl To test: Apply patch Go to a patrons Account In table of fines / transactions, column 'Print', click on 'Print' of a payment transaction ("Payment, thanks") Verify that the date displays correctly on the receipt. Amended for proper input for dt_from_string - (is 'iso') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 22:40:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 20:40:53 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36880|0 |1 is obsolete| | --- Comment #89 from Marc V?ron --- Created attachment 37843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37843&action=edit Bug 13813 - Remove C4::Dates from members/printinvoice.pl To test: Apply patch Go to a patrons Account In table of fines / transactions, column 'Print', click on 'Print' of a transaction Verify that the date displays correctly on the invoice. Amended for proper format in dt_from_string (is 'iso') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 22:51:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 20:51:56 +0000 Subject: [Koha-bugs] [Bug 13996] New: B_streetnumber: its present in table borrowes but not used in Koha Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13996 Bug ID: 13996 Summary: B_streetnumber: its present in table borrowes but not used in Koha Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The field B_streetnumber is present at sql level in table borrowers but it is not used in Koha. You can't insert data into it using members/memberentry.pl It does not display in 'Alternate address' section of members/moremember.pl It isn't present in opac (opac-memberentry.pl). You can only import it with tools/import_borrowers.pl I think we need a way to insert/display it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 14 23:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 Apr 2015 21:02:03 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #90 from Marc V?ron --- (In reply to Jonathan Druart from comment #82) > Created attachment 37810 [details] > temporary tests > > Marc, > If I am not wrong, these tests reflect what you are doing in the patches. > If you have a look, you will see there are some mistakes. (...) > You should try to list exhaustively all existing patterns of C4::Dates you > will replace and try to find their correct replacements. Jonathan, Thank you very much for your help, your advice and for the idea with the test file. I used it as a base to go systematically through all attachments (and amended some of them). I tested the patches one by one in the staff client as well and hope now that this first patch set is really ready for sign-off. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 02:55:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 00:55:28 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 --- Comment #7 from Chris Cormack --- (In reply to Ji?? Kozlovsk? from comment #6) > Created attachment 37719 [details] [review] > Bug 13930 - Created NCIP svc to effectively parse data from database to JSON > in order to query those from xcncip2toolkit koha's connector A quick fix needed, the copyright statements are wrong (looks like a cut and paste error?) Also Koha is GPLv3 or later not 2 anymore. I'll try to do some functional testing, but if you could fix those, they won't get caught at QA :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 03:46:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 01:46:16 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37787|0 |1 is obsolete| | --- Comment #5 from Robin Sheat --- Created attachment 37844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37844&action=edit Bug 13979: updates to allow installation on jessie I think that bit commented was just a legacy from when I was experimenting, and the others didn't have it because I had to resolve conflicts to get it to apply so cleared it out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 06:09:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 04:09:39 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 06:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 04:09:41 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35541|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 37845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37845&action=edit Bug 13623 - Enhance html for holds queue viewer It would be very helpful from a css/scripting point of view if the author field in the holds queue report had a selectable class. In edition, it would be great if the biblionumber were easy to grab from a hidden div. Test Plan: 1) Apply this patch 2) Load the holds queue report ( view_holdsqueue.pl ) 3) Inspect an author name with your web browser ( or view the html ) a) Note the hq-author class of the wrapping div b) Note the hidden hq-biblionumber div NOTE: Hopefully rebased well. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 07:15:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 05:15:20 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #12 from Robin Sheat --- A couple of notes before I get into it too deeply: libmojolicious-perl in wheezy is 2.98, hopefully it'll work with that. Swagger2 isn't in Debian at all, but is probably buildable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 07:20:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 05:20:33 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #10 from M. Tompsett --- Created attachment 37846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37846&action=edit Bug 10625: Inventory/Stocktaking tool cannot handle windows file uploads The current code uses $barcode = ; logic. This reads until \n, as far as I can tell. EOL is indicated by \n, \r, and \r\n depending on OS and software. So, to this end, rather than File::Slurp (which is a potential memory hog, which is already an issue with no filters), a loop to pre-read the barcodes was written. This loop includes: $barcode =~ s/\r/\n/g; $barcode =~ s/\n\n/\n/g; $barcode =~ s/\n$//; $barcode =~ s/^\n//; my @data = split(/\n/, $barcode); push @uploadedbarcodes, at data; So, that means that lines ending in \n would have it stripped and pushed into the uploaded barcodes array. Lines ending in \r would likely be read as one giant block, have everything converted to single \n's and then using a split, the set of barcodes are pushed into the uploaded barcodes array. Lines ending in \r\n would get that stripped and pushed into the uploaded barcodes array. It is then the uploaded barcodes array that is looped over for validating the barcodes. TEST PLAN --------- 1) Create a file with at least three different barcodes. --- BEGIN EXAMPLE --- BARCODE1\n BARCODE2\r BARCODE3\r\n --- END EXAMPLE --- $ echo "BARCODE1\nBARCODE2\rBARCODE3\r\n" | sed -e "s#\\\\n#\\n#g" | sed -e "s#\\\\r#\\r#g" > test.txt 2) Log into staff client 3) Tools -> Inventory/stocktaking 4) Click 'Browse' and select the file to upload (e.g. test.txt) 5) Click 'Submit' 6) A Javascript warning comes up, click 'Yes' -- This will take a LONG time, at least 1 minute. -- eventual results will be wrong. 7) Apply patch 8) repeat steps 3-6 -- This time correct number of barcodes will be given. 9) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 07:30:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 05:30:09 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|In Discussion |Needs Signoff --- Comment #11 from M. Tompsett --- I believe my counter patch solves the problem, and addresses concerns of memory use by File::Slurp by not using it. I'm setting this to needs sign off, but only apply the second patch. I did not obsolete the original one, in case my counter patch is deemed inadequate. Follow the test plan in comment #10 for testing the second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 07:36:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 05:36:32 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #13 from Robin Sheat --- More comments: * version 6.0 is mandated in the dependencies. That's in no Debian release at all right now. We need to ensure it can work on wheezy. * the httpd conf stuff hasn't been updated in the packages. * the code is woefully underdocumented, some new files having exactly zero comments at all, let alone POD and copyright headers. Now to start looking into getting it actually running... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 07:43:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 05:43:33 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- (In reply to Sophie MEYNIEUX from comment #0) > Inventory tool fails with a timeout if the CB file to process is too large. > In fact it doesn't really fails, CB are properly processed, but the user > can't see the result because of the timeout occuring before the end of > processing. > > One solution could be to implement background job like in MARC import > (BZ1531) I think this would be a decent idea. > Another one could be to add scheduler to plan inventory process like in > reports I like the background job idea better, because if you are there are the inventory/stocktaking tool page, you want that done then and there. A pretty progress back gives nice feedback too. (In reply to Jonathan Druart from comment #3) > Sophie, do you know if this is still valid for recent version of Koha? My testing for bug 10625 for an unfiltered report ran for just over 1 minute for just a couple of barcodes. I can easily imagine that a large barcode file would generate a timeout in terms of the web page not displaying before the script completed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 07:46:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 05:46:56 +0000 Subject: [Koha-bugs] [Bug 9157] inventory tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9157 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- (In reply to Katrin Fischer from comment #3) > So I think maybe what's needed would be: > > - an option to not automatically check items in > - an option to set the inventory/last seen date manually > > ? I thought the request was for: (In reply to Melia Meggs from comment #0) > The librarian > would prefer that the inventory tool were enhanced so that it's smart enough > to skip any items that are currently checked out at the time the .txt file > is uploaded. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 07:48:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 05:48:08 +0000 Subject: [Koha-bugs] [Bug 9157] Enhance inventory tool to skip checked out barcodes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9157 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|inventory tool enhancement |Enhance inventory tool to | |skip checked out barcodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 07:49:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 05:49:22 +0000 Subject: [Koha-bugs] [Bug 9666] add columns for status to inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9666 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 08:29:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 06:29:14 +0000 Subject: [Koha-bugs] [Bug 8276] circ history not sorting right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 08:29:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 06:29:17 +0000 Subject: [Koha-bugs] [Bug 8276] circ history not sorting right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37406|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 37847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37847&action=edit [SIGNED-OFF] Bug 8276: circ history - checked out items are later If the sort is done on "checkin on", the items currently checked out should be list after all others. Test plan: 1/ Go on the checkout history page for a record with checked out items 2/ Sort on the "checkin on" column and confirm that the checked out items are sorted after/before others depending on the sort order (asc/desc). Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 08:31:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 06:31:15 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #12 from Marc V?ron --- Created attachment 37848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37848&action=edit [Signed-off] Bug 10625: Inventory/Stocktaking tool cannot handle windows file uploads The current code uses $barcode = ; logic. This reads until \n, as far as I can tell. EOL is indicated by \n, \r, and \r\n depending on OS and software. So, to this end, rather than File::Slurp (which is a potential memory hog, which is already an issue with no filters), a loop to pre-read the barcodes was written. This loop includes: $barcode =~ s/\r/\n/g; $barcode =~ s/\n\n/\n/g; $barcode =~ s/\n$//; $barcode =~ s/^\n//; my @data = split(/\n/, $barcode); push @uploadedbarcodes, at data; So, that means that lines ending in \n would have it stripped and pushed into the uploaded barcodes array. Lines ending in \r would likely be read as one giant block, have everything converted to single \n's and then using a split, the set of barcodes are pushed into the uploaded barcodes array. Lines ending in \r\n would get that stripped and pushed into the uploaded barcodes array. It is then the uploaded barcodes array that is looped over for validating the barcodes. TEST PLAN --------- 1) Create a file with at least three different barcodes. --- I tested with the test file provided and with a file where some lines have CR and other lines have CR NL (inserted with Win text editor). Worked as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 08:32:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 06:32:37 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC| |veron at veron.ch --- Comment #13 from Marc V?ron --- Signed-off on second patch (by M.Tompsett) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 08:33:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 06:33:02 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37846|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 08:47:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 06:47:11 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 --- Comment #5 from Marc V?ron --- Created attachment 37849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37849&action=edit [Signed-off] Bug 13623 - Enhance html for holds queue viewer It would be very helpful from a css/scripting point of view if the author field in the holds queue report had a selectable class. In edition, it would be great if the biblionumber were easy to grab from a hidden div. Test Plan: 1) Apply this patch 2) Load the holds queue report ( view_holdsqueue.pl ) 3) Inspect an author name with your web browser ( or view the html ) a) Note the hq-author class of the wrapping div b) Note the hidden hq-biblionumber div HTML appears as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 08:47:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 06:47:34 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #37845|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 08:47:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 06:47:44 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 09:01:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 07:01:24 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 --- Comment #23 from M. Tompsett --- Comment on attachment 31251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31251 Bug 11405 [2] - Skip items with waiting holds Review of attachment 31251: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11405&attachment=31251) ----------------------------------------------------------------- ::: tools/inventory.pl @@ +233,4 @@ > if ( $markseen or $op ) { > # retrieve all items in this range. > my $totalrecords; > + ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $ignore_holds_waiting, '', $branchcode, $branch, 0, undef , $staton); This is where a nasty conflict shows up. Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 09:05:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 07:05:43 +0000 Subject: [Koha-bugs] [Bug 12329] Inventory setting date last seen to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12329 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- Nicole, could you retest? I vaguely recall that this was an issue of the data used was pre-update, and that a rerun had it set to the previous runs date that you wanted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 09:12:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 07:12:28 +0000 Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 09:12:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 07:12:30 +0000 Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24934|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 37850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37850&action=edit Bug 11272 - copy submit button on inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 09:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 07:16:02 +0000 Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #11 from M. Tompsett --- I wasn't sure what status to stick this to. If you compare it to the previous obsolete, it's identical. For some strange reason the extra blank lines confused the git bz apply such that it didn't apply. This one does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 09:31:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 07:31:53 +0000 Subject: [Koha-bugs] [Bug 13997] New: no flag is not set in the Home> Visitors> Setting privileges. Bug in log "Use of uninitialized value $roadtype in string..." Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13997 Bug ID: 13997 Summary: no flag is not set in the Home> Visitors> Setting privileges. Bug in log "Use of uninitialized value $roadtype in string..." Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: annvpro at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 37851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37851&action=edit Can not choose the permissions Dear Friends, I'm begginer to Koha. I just tried to install Koha 3.18.04.000 to Linux koha 3.2.0-4-amd64 #1 SMP Debian 3.2.65-1+deb7u2 x86_64 GNU/Linux (mysql Ver 14.14 Distrib 5.5.41, for debian-linux-gnu (x86_64) using readline 6.2). Use man: https://www.youtube.com/watch?v=VqdO1i3Yzsc The installation was error-free. I just tried to alter patron permissions: click the 'More' button on the top right of the patron profile and choose 'Set Permissions', but I can not choose the permissions. (look at attachment) I have bug in log (/var/log/koha/koha: "Use of uninitialized value $roadtype in string at /usr/share/koha/intranet/cgi-bin/members/member-flags.pl line 176" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 09:38:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 07:38:05 +0000 Subject: [Koha-bugs] [Bug 13997] no flag is not set in the Home> Visitors> Setting privileges. Bug in log "Use of uninitialized value $roadtype in string..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13997 --- Comment #1 from annvpro at gmail.com --- Created attachment 37852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37852&action=edit /usr/share/koha/intranet/cgi-bin/members/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 09:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 07:40:07 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #91 from Jonathan Druart --- Comment on attachment 37757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37757 Bug 13813 - Remove C4::Dates from C4/Members.pm Review of attachment 37757: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13813&attachment=37757) ----------------------------------------------------------------- ::: C4/Members.pm @@ +2363,4 @@ > my @results; > > while ( my $data = $sth->fetchrow_hashref ) { > + $data->{message_date_formatted} = output_pref({ dt => dt_from_string( $data->{message_date} ), dateformat => 'iso', dateonly => 1 }); We don't want an iso formatted date here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 09:41:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 07:41:13 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #92 from Jonathan Druart --- Comment on attachment 36882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36882 Bug 13813 - Remove C4::Dates from circ/bookcount.pl Review of attachment 36882: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13813&attachment=36882) ----------------------------------------------------------------- ::: circ/bookcount.pl @@ +86,4 @@ > biblioitemnumber => $bi, > homebranch => $homebranch, > holdingbranch => $holdingbranch, > + lastdate => $lastdate ? output_pref({ dt => dt_from_string( $lastdate ), dateformat => 'iso', dateonly => 1 }) : 0, Not correct, we want a formatted date. @@ +177,4 @@ > my ($date) = @_; > $date or return; > return ( > + output_pref({ dt => dt_from_string( $date, 'iso' ), dateonly => 1 }), This is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 09:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 07:59:50 +0000 Subject: [Koha-bugs] [Bug 13997] no flag is not set in the Home> Visitors> Setting privileges. Bug in log "Use of uninitialized value $roadtype in string..." In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13997 annvpro at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:00:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:00:22 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #93 from Jonathan Druart --- Comment on attachment 36900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36900 Bug 13813 - Remove C4::Dates from tools/koha-news.pl Review of attachment 36900: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13813&attachment=36900) ----------------------------------------------------------------- ::: tools/koha-news.pl @@ +40,5 @@ > my $id = $cgi->param('id'); > my $title = $cgi->param('title'); > my $new = $cgi->param('new'); > +my $expirationdate = output_pref({ dt => dt_from_string( $cgi->param('expirationdate') ), dateformat => 'iso', dateonly => 1 }); > +my $timestamp = output_pref({ dt => dt_from_string( $cgi->param('timestamp') ), dateformat => 'iso', dateonly => 1 }); Not sure about this but it does not seem to break anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:20 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36827|0 |1 is obsolete| | --- Comment #94 from Jonathan Druart --- Created attachment 37853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37853&action=edit Bug 13813 - Remove deprecated C4::Dates from opac/opac-showreviews.pl To test: This patch removes C4::Dates from opac/opac-showreviews.pl and treats the RSS time stamps the same way as in opac/opac-search.pl To test: - Enable display of 'Recent comments' in OPAC (Syspref OpacShowRecentComments) - In OPAC, go to Home > Recent comments - Test RSS feed - Apply patch - Test RSS feed again, it should work as before Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:24 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36832|0 |1 is obsolete| | --- Comment #95 from Jonathan Druart --- Created attachment 37854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37854&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from C4/HoldsQueue.pm To test: Apply patch Make sure that C4::Dates is not used in C4/HoldsQueue.pm Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:27 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36835|0 |1 is obsolete| | --- Comment #96 from Jonathan Druart --- Created attachment 37855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37855&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from Koha/Borrower/Files.pm To test: Apply patch Make sure that uploading arbitrary files for a patron works as before (Set syspref EnableBorrowerFiles for testing ) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:31 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36839|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart --- Created attachment 37856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37856&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from Koha/Misc/Files.pm To test: Apply patch Make sure that C4::Dates is not used in the code Set syspref AcqEnableFiles to enable Go to Home > Acquisitions > Invoices Find an invoice, go to Details, Manage Invoice files, make sure that uploading / displaying files works as before Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:35 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36845|0 |1 is obsolete| | --- Comment #98 from Jonathan Druart --- Created attachment 37857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37857&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from tags/list.pl To test: Apply patch Verify in code that C4::Dates is not necessary in tags/list.pl Set sysprefs to TagsEnabled and TagsModeration Got to Home > Tools > Tags In table of tags, click on a Term You should get a page Home > Tools > Tags > Results for [Term] Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:38 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36864|0 |1 is obsolete| | --- Comment #99 from Jonathan Druart --- Created attachment 37858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37858&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from C4/Barcodes.pm To test: Apply patch Verify that C4::Dates is not used in code. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:42 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36865|0 |1 is obsolete| | --- Comment #100 from Jonathan Druart --- Created attachment 37859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37859&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from C4/Biblio.pm To test: Apply patch Verify that C4::Dates is not used in code. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:46 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36870|0 |1 is obsolete| | --- Comment #101 from Jonathan Druart --- Created attachment 37860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37860&action=edit Bug 13813 - Remove C4::Dates from C4/Log.pm To test: Apply patch Go to Home > Tools > Logs Search logs with different from- and to-dates, verify that date range displays as appropriate. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:49 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36871|0 |1 is obsolete| | --- Comment #102 from Jonathan Druart --- Created attachment 37861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37861&action=edit Bug 13813 - Remove C4::Dates from C4/NewsChannels.pm To test: Apply patch Create some news for OPAC and staff client (Home > Tools > News) Verify that dates appear as appropriate Verify that Publicaten Date (Creation Date) and Expiration Date work as expected. Note: Inconsistency in wording for creation date / publication date should be managed in separate Bug 13834 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:53 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36872|0 |1 is obsolete| | --- Comment #103 from Jonathan Druart --- Created attachment 37862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37862&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from C4/Output.pm To test: Apply patch Verify that C4::Dates is not used in code Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:12:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:12:57 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36879|0 |1 is obsolete| | --- Comment #104 from Jonathan Druart --- Created attachment 37863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37863&action=edit Bug 13813 - Remove C4::Dates from C4/VirtualShelves/Page.pm To test: Apply patch In staff client, go to Home > Lists Verify that list of lists displays as before In OPAC, go to Lists Verify that Public and Private Lists display as before Note: 'dateadded' is not displayed in lists of lists. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:01 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36882|0 |1 is obsolete| | --- Comment #105 from Jonathan Druart --- Created attachment 37864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37864&action=edit Bug 13813 - Remove C4::Dates from circ/bookcount.pl To test: Apply patch Search a biblio with items that are or have been checked out Go to "Items" (moredetail.pl) Locate "Total checkouts" of an item and click 'View item's checkout hsitory' Verify date and time in column "Last seen" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:04 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36883|0 |1 is obsolete| | --- Comment #106 from Jonathan Druart --- Created attachment 37865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37865&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from members/notices.pl To test: Apply patch Verify that C4::Dates is not used in members/notices.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:08 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36886|0 |1 is obsolete| | --- Comment #107 from Jonathan Druart --- Created attachment 37866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37866&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-messaging.pl To test: Apply patch Verify that C4::Dates is not used in code Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:12 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36887|0 |1 is obsolete| | --- Comment #108 from Jonathan Druart --- Created attachment 37867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37867&action=edit Remove superfluous use 'C4::Dates' from opac/opac-privacy.pl To test: Apply patch Verify that C4::Dates is not used in code http://bugs.koha-community.org/show_bug.cgi?id=13813 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:16 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36888|0 |1 is obsolete| | --- Comment #109 from Jonathan Druart --- Created attachment 37868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37868&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-ratings.pl To test: Apply patch Verify that C4::Dates is not used in code Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:20 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36892|0 |1 is obsolete| | --- Comment #110 from Jonathan Druart --- Created attachment 37869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37869&action=edit Bug 13813 - Remove C4::Dates from opac/opac-user.pl To test: Apply patch Manually restrict a patron (with end date) Check in to OPAC with this patron's username/password Verify that message about restrictions displays restriction date correctly in tab "Your summary" (opac-user.pl) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:23 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36900|0 |1 is obsolete| | --- Comment #111 from Jonathan Druart --- Created attachment 37870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37870&action=edit Bug 13813 - Remove C4::Dates from tools/koha-news.pl To test: Apply patch Go to Home > Tools > News Verify that dates appear as expected in date columns Create and edit news, verify dates behave as expected. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:27 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36901|0 |1 is obsolete| | --- Comment #112 from Jonathan Druart --- Created attachment 37871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37871&action=edit Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-search-history.pl To test: Apply patch Verify that C4::Dates is not used in code Go to ome > Tools > Logs Display logs with from and to dates Verify that search range behaves as expected. ' (Note: In table 'XXXX lines found', date and time always appear as timestamp as before) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:31 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36902|0 |1 is obsolete| | --- Comment #113 from Jonathan Druart --- Created attachment 37872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37872&action=edit Bug 13813 - Remove C4::Dates from tools/scheduler.pl To test: Apply patch Go to Home > Tools > Task scheduler Add new tasks Verify that tasks are properly added Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:35 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37746|0 |1 is obsolete| | --- Comment #114 from Jonathan Druart --- Created attachment 37873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37873&action=edit Bug 13813 - Remove C4::Dates from circ/circ/transferstoreceive.pl To test: Go to Home > Circulation > Transfers to your library (Circulation Reports - Transfers to receive) Verify that date in page title appears correcty Amendend following comment #58 /MV Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:39 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37748|0 |1 is obsolete| | --- Comment #115 from Jonathan Druart --- Created attachment 37874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37874&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/barcode_manual.pl To test: Apply patch Set the plugin for 952$p (or UNIMARC equivalent to items.barcode) for one of your frameworks to barcode_manual.pl instead of barcode.pl Set syspref autoBarcode to -001, -002 and yymm001 Edit items or add item, verify that barcodes are filled in as appropriate by clicking on the value builder link (...) (Note: Description of barcode_manual.pl in Bug 8524) Amended following comment #58 /MV Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:46 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37754|0 |1 is obsolete| | --- Comment #117 from Jonathan Druart --- Created attachment 37876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37876&action=edit Bug 13813 - Remove C4::Dates from C4/Items.pm This patch removes depraceted C4::Dates from C4/Items.pm To test: Apply patch To test: Add modify items. Checkout added item. Verify that item handling works as before. Amended following comment #58 / MV Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:42 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37749|0 |1 is obsolete| | --- Comment #116 from Jonathan Druart --- Created attachment 37875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37875&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/dateaccessioned.pl To test: Apply patch Edit an item Verifiy that autofilling date in d - Date acquired works as before. Amended following comment #58 /MV Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:50 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37757|0 |1 is obsolete| | --- Comment #118 from Jonathan Druart --- Created attachment 37877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37877&action=edit Bug 13813 - Remove C4::Dates from C4/Members.pm This patch removes C4::Dates from C4/Members.pm Note: This patch can be tested independently from other patches in this Bug, but it depends on patches from Bug 13601 To test: Make sure that patches from 13601 are applied Apply patch Check changes in code Make sure that following functionality works as before: - Add a patron - Renew patrons - Go to checkout page and create message for patron Amended following comment #58 / MV There is one more DateTime->now() left on line 1825, this is not related to my changes. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:54 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37762|0 |1 is obsolete| | --- Comment #119 from Jonathan Druart --- Created attachment 37878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37878&action=edit Bug 13813 - Remove C4::Dates from C4/Barcodes/annual.pm To test: Set syspref autoBarcode to -001, -002 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. Amended following comment #58 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:13:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:13:58 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37763|0 |1 is obsolete| | --- Comment #120 from Jonathan Druart --- Created attachment 37879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37879&action=edit Bug 13813 - Remove C4::Dates from C4/Barcodes/hbyymmincr.pm To test: Set syspref autoBarcode to yymm0001 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. Amended following comment #58 /mv Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:06 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37765|0 |1 is obsolete| | --- Comment #122 from Jonathan Druart --- Created attachment 37881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37881&action=edit Bug 13813 - Remove C4::Dates from members/moremember.pl To test: Apply patch Go to a patron's Details page (moremember.pl) Verify that dates display correctly (birth date, registration, espiration, manual restriction with date) Amended following comment #58 /mv Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:02 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37764|0 |1 is obsolete| | --- Comment #121 from Jonathan Druart --- Created attachment 37880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37880&action=edit Bug 13813 - Remove C4::Dates from C4/Suggestions.pm To test: Apply patch Go to Home > Acquisitions > Suggestions management Verify in "Filter by" that filter works for Suggestion information / dates Amended following comment #58 /mv Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:09 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37767|0 |1 is obsolete| | --- Comment #123 from Jonathan Druart --- Created attachment 37882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37882&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/barcode.pl To test: Set syspref autoBarcode to -001, -002 and yymm001 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. Amended following comment #58 /mv Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:13 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37768|0 |1 is obsolete| | --- Comment #124 from Jonathan Druart --- Created attachment 37883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37883&action=edit Bug 13813 - Remove C4::Dates from PDF templates in acquisitions To test: Apply patch In Acquisitions, go to a vendor's "Basket grouping" Find a basket and print order Change PDF templates using syspref OrderPdfFormat and test for - English 2-page - English 3-page - French 3-page - German 2-page Amended following comment #58 /MV Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:17 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37770|0 |1 is obsolete| | --- Comment #125 from Jonathan Druart --- Created attachment 37884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37884&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat), see comment #57/ MV Amended because of "use Koha::DateUtils;" instead of original, See comment #59 /MV Amended following comment #58 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:21 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37828|0 |1 is obsolete| | --- Comment #126 from Jonathan Druart --- Created attachment 37885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37885&action=edit Bug 13813 - Remove C4::Dates from circ/waitingreserves.pl To test: Go to Home > Circulation > Holds awaiting pickup (Circulation Rports - Holds awaiting pickup) Verify that date in page title appears correcty Amended following comment #58 Changed output_pref to format 'iso' Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:25 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37840|0 |1 is obsolete| | --- Comment #127 from Jonathan Druart --- Created attachment 37886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37886&action=edit Bug 13813 - Remove C4::Dates from members/readingrec.pl This patch removes depraceted C4::Dates from members/readingrec.pl To test: Apply patch Go to a patron's cirulation history Verify that circulation history behaves as before. Amended following comment #58 /MV Amended to fix output_pref (dateonly added) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:29 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37842|0 |1 is obsolete| | --- Comment #128 from Jonathan Druart --- Created attachment 37887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37887&action=edit Bug 13813 - Remove C4::Dates from members/printfeercpt.pl To test: Apply patch Go to a patrons Account In table of fines / transactions, column 'Print', click on 'Print' of a payment transaction ("Payment, thanks") Verify that the date displays correctly on the receipt. Amended for proper input for dt_from_string - (is 'iso') Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:33 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37843|0 |1 is obsolete| | --- Comment #129 from Jonathan Druart --- Created attachment 37888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37888&action=edit Bug 13813 - Remove C4::Dates from members/printinvoice.pl To test: Apply patch Go to a patrons Account In table of fines / transactions, column 'Print', click on 'Print' of a transaction Verify that the date displays correctly on the invoice. Amended for proper format in dt_from_string (is 'iso') Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:37 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #130 from Jonathan Druart --- Created attachment 37889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37889&action=edit Bug 13813 - (follow-up) Remove C4::Dates from C4/Members.pm message_date_formatted is only used once in the template. Previous patch does not formatted correctly the date (was in iso). The easier for me was to use the KohaDates TT plugin Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:41 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #131 from Jonathan Druart --- Created attachment 37890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37890&action=edit Bug 13813 - (follow-up) Remove C4::Dates from circ/bookcount.pl Previous patch was wrong for the lastdate format. We want a date formatted following the syspref value, not an iso formatted date. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:14:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:14:44 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #132 from Jonathan Druart --- Created attachment 37891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37891&action=edit Bug 13813: Fix compilation errors Bareword "dt_from_string" not allowed while "strict subs" in use Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:15:55 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #133 from Jonathan Druart --- To be honest, I did not check all pages. But looking at the code it should be all right now. I tried some pages and dates look correctly formatted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:18:02 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #134 from Jonathan Druart --- (In reply to Jonathan Druart from comment #93) > Comment on attachment 36900 [details] [review] > Bug 13813 - Remove C4::Dates from tools/koha-news.pl > > Review of attachment 36900 [details] [review]: > ----------------------------------------------------------------- > > ::: tools/koha-news.pl > @@ +40,5 @@ > > my $id = $cgi->param('id'); > > my $title = $cgi->param('title'); > > my $new = $cgi->param('new'); > > +my $expirationdate = output_pref({ dt => dt_from_string( $cgi->param('expirationdate') ), dateformat => 'iso', dateonly => 1 }); > > +my $timestamp = output_pref({ dt => dt_from_string( $cgi->param('timestamp') ), dateformat => 'iso', dateonly => 1 }); > > Not sure about this but it does not seem to break anything. For QAer, have a look at this. I don't see the timestamp param set in the template. On the list view, before the patch, I got: koha-news.pl: Usage: POSIX::strftime(fmt, sec, min, hour, mday, mon, year, wday = -1, yday = -1, isdst = -1) at /home/koha/src/C4/Dates.pm line 187. koha-news.pl: ...caught at /home/koha/src/tools/koha-news.pl line 45. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:22:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:22:35 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #135 from Jonathan Druart --- Something else: I did not try but... C4::Dates was (is) very efficient to format a date from an iso date. Now we have to call dt_from_string and output_pref. Maybe we should introduce a new subroutine without calls to DateTime to do this job. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:28:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:28:37 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #136 from Jonathan Druart --- (In reply to Jonathan Druart from comment #135) > Something else: I did not try but... C4::Dates was (is) very efficient to > format a date from an iso date. > Now we have to call dt_from_string and output_pref. > Maybe we should introduce a new subroutine without calls to DateTime to do > this job. % more t.pl use C4::Dates qw(format_date); my $iso_date = '2015-04-10 09:30:03'; for ( 1 .. 10000 ) { format_date($iso_date); } % time perl t.pl perl t.pl 0.78s user 0.01s system 99% cpu 0.795 total % time perl t.pl perl t.pl 0.74s user 0.01s system 99% cpu 0.749 total % time perl t.pl perl t.pl 0.71s user 0.02s system 99% cpu 0.735 total % more t.pl use Koha::DateUtils; my $iso_date = '2015-04-10 09:30:03'; for ( 1 .. 10000 ) { output_pref({ dt => dt_from_string( $iso_date, 'iso' ), dateonly => 1 }); } % time perl t.pl perl t.pl 2.40s user 0.02s system 100% cpu 2.424 total % time perl t.pl perl t.pl 2.42s user 0.02s system 99% cpu 2.442 total % time perl t.pl perl t.pl 2.43s user 0.01s system 100% cpu 2.439 total -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 10:39:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 08:39:23 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #137 from Marc V?ron --- (In reply to Jonathan Druart from comment #135) > Something else: I did not try but... C4::Dates was (is) very efficient to > format a date from an iso date. > Now we have to call dt_from_string and output_pref. > Maybe we should introduce a new subroutine without calls to DateTime to do > this job. I was thinking about adding new functions to Koha::DateUtils mostly to streamline the transition process to Koha::DateUtils (easier and more human readable calls) but I was afraid that that would slow down the changes. (I'm eager to get Bug 12072 resolved.) I think if calls to dt_from_string and output_pref turn up to be to time costly e.g. in big loops we can resolve this in a follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 11:17:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 09:17:19 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 11:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 09:17:24 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #240 from Chris Cormack --- Created attachment 37892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37892&action=edit Bug 7143 Adding new developers and releases to the history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 11:30:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 09:30:02 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #9 from Marc V?ron --- Created attachment 37893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37893&action=edit [Signed-off] Bug 12747 Add extra column in Z3950 search result This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested in both Acquisition and Cataloguing. Works as expected (and is a great feature). Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 11:30:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 09:30:53 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #37836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 11:31:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 09:31:15 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 11:34:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 09:34:19 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 11:34:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 09:34:21 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 --- Comment #1 from Jonathan Druart --- Created attachment 37894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37894&action=edit Bug 10181: Acq - Improve message for deleted records There are some issues here: 1/ Message not translatable (set in the pl file) 2/ ' by 'displayed even if no author defined 3/ Message not the same every where 4/ Nothing displayed on the invoice page Test plan: 1/ Create a basket 2/ Add 4 orders A, B, C, D 3/ On the basket, you see "$title by $author", or "$title" if no author defined 4/ Delete order A, B 5/ Close the basket 6/ Receive B, C 7/ Delete record created for A, C 8/ Go on the basket page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record 9/ Go on the invoice page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 11:34:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 09:34:44 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch Severity|trivial |normal Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:04:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:04:10 +0000 Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 --- Comment #12 from Marc V?ron --- Created attachment 37895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37895&action=edit [Signed-off] Bug 11272 - copy submit button on inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Rebased. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:04:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:04:32 +0000 Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #37850|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:04:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:04:41 +0000 Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:18:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:18:41 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #28 from Marc V?ron --- Created attachment 37896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37896&action=edit [Signed-off] Bug 13941 [1/2] Test tag with id/class attributes Test: - Apply the first patch [1/2] containing a new test checking tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid tags. - Apply the second patch [2/2] fixing all invalid tags. - Re-run the test: It passes. Folowed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:18:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:18:59 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:20:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:20:40 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #29 from Marc V?ron --- Created attachment 37897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37897&action=edit [Signed-off] Bug 13941 [2/2] Fix tags missing id/class Followed test plan from patch 1/2, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:21:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:21:03 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:21:27 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:24:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:24:45 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:24:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:24:48 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 --- Comment #13 from Jonathan Druart --- Created attachment 37898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37898&action=edit Bug 10174: Add a tooltip to explain what is a digest The digest term seems to be ambiguous for some people. This patch adds a tooltip to explain what it is (feel free to provide a better wording). Test plan: Go at the OPAC and click on the "Your messaging tab", you should see an icon close to "Digest only" to explain what is a digest. Same at the intranet on editing/showing patron info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:25:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:25:08 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:42:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:42:25 +0000 Subject: [Koha-bugs] [Bug 10172] The MARC Preview link could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:42:27 +0000 Subject: [Koha-bugs] [Bug 10172] The MARC Preview link could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 --- Comment #1 from Jonathan Druart --- Created attachment 37899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37899&action=edit Bug 10172: Hide some uneeded stuffs on printing a record When printing a record from the OPAC or the staff interface, some uneeded blocks are displayed. OPAC: 1/ Browse results 2/ The view tags (Normal, MARC, ISBD) Intranet: 1/ Marc view link 2/ The Please upload one image link Test plan: On a record detail page (staff and OPAC), print the page and confirm these blocks no longer appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:42:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:42:58 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The MARC Preview link could |Some links and blocks could |be hidden when printing a |be hidden when printing a |record |record CC| |jonathan.druart at biblibre.co | |m Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:43:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:43:13 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:50:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:50:39 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37789|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 37900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37900&action=edit [SIGNED-OFF] Bug 13979: [3.16.x] updates to allow installation on jessie Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:51:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:51:52 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37788|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Created attachment 37901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37901&action=edit [SIGNED-OFF] Bug 13979: [3.18.x] updates to allow installation on jessie Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:52:48 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:52:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:52:51 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37844|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 37902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37902&action=edit [SIGNED-OFF] Bug 13979: updates to allow installation on jessie Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:54:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:54:14 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 12:56:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 10:56:30 +0000 Subject: [Koha-bugs] [Bug 10169] Software error if one of multiple titles selected for hold in the OPAC has no items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED --- Comment #3 from Jonathan Druart --- Confirmed, this is fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:00:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:00:32 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:02:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:02:10 +0000 Subject: [Koha-bugs] [Bug 10673] Message hide timeout can go out of sync in preferences.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Steps to reproduce? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:11:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:11:04 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #20 from Josef Moravec --- I wanted to test it, but there is merge conflict. Could you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:11:16 +0000 Subject: [Koha-bugs] [Bug 12609] Replace use of DBI in C4::Ratings with DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #10 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #9) > Patches pushed to master. > > Thanks Kyle and Jonathan! This breaks opac-ratings-ajax.pl: opac-ratings-ajax.pl: Can't locate object method "new" via package "Koha::Database" (perhaps you forgot to load "Koha::Database"?) at /home/koha/src/C4/Ratings.pm line 206. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:15:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:15:12 +0000 Subject: [Koha-bugs] [Bug 12609] Replace use of DBI in C4::Ratings with DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13998 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:15:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:15:12 +0000 Subject: [Koha-bugs] [Bug 13998] New: opac-ratings-ajax.pl is broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Bug ID: 13998 Summary: opac-ratings-ajax.pl is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 12609 To reproduce: Enable the star rating at the OPAC, go on a record detail page, note with the stars, nothing happens. Actually yes, boom in the JS console and error in Koha logs: [Wed Apr 15 13:12:52 2015] opac-ratings-ajax.pl: Can't locate object method "new" via package "Koha::Database" (perhaps you forgot to load "Koha::Database"?) at /home/koha/src/C4/Ratings.pm line 206. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:17:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:17:16 +0000 Subject: [Koha-bugs] [Bug 12609] Replace use of DBI in C4::Ratings with DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12609 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > (In reply to Tom?s Cohen Arazi from comment #9) > > Patches pushed to master. > > > > Thanks Kyle and Jonathan! > > This breaks opac-ratings-ajax.pl: > opac-ratings-ajax.pl: Can't locate object method "new" via package > "Koha::Database" (perhaps you forgot to load "Koha::Database"?) at > /home/koha/src/C4/Ratings.pm line 206. Actually it's not introduced by this patch, the issue does not exist on 3.18.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:24:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:24:33 +0000 Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for performance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Ok, found you! This is crazy but... this patch breaks opac-ratings-ajax.pl, see bug 13998 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:26:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:26:35 +0000 Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for performance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13998 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:26:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:26:35 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13852 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:27:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:27:41 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 --- Comment #1 from Jonathan Druart --- This has been introduced by commit f14963605924eacbbaf965c600c65401288b6f2f Date: Tue Mar 17 14:50:14 2015 +0100 Bug 13852 - Manage C4::VirtualShelves in C4::Auth for performance This is crazy, really... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:28:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:28:46 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:33:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:33:08 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 --- Comment #2 from Jonathan Druart --- For what I understand it's because, before bug 13852, Koha::Database was used in C4:Members which was used by C4::VirtualShelves which was used by C4::Auth which was finally used by C4::Ratings... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:40:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:40:28 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 --- Comment #14 from Jonathan Druart --- Comment on attachment 37747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37747 [PASSED QA] Bug 13189: (QA Followup) Unit Tests Review of attachment 37747: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13189&attachment=37747) ----------------------------------------------------------------- ::: t/db_dependent/Members.t @@ +189,5 @@ > +my $attr_type = C4::Members::AttributeTypes->new("TEST", "Test Description"); > +$attr_type->staff_searchable(1); > +$attr_type->store(); > +SetBorrowerAttributes($addmem, [ { code => 'TEST', value => 'XYZZYX' } ] ); > +$results = Search( "XYZZYX", undef, undef, undef, undef, undef, 1 ); It was really not a good idea to push this patch. It introduces a call to C4::Members::Search (I fight with it for months to remove SQLHelper...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:41:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:41:10 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37793|0 |1 is obsolete| | --- Comment #9 from M. de Rooy --- Created attachment 37903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37903&action=edit Bug 13049: Merge selfreg cron jobs into cleanup_database This patch moves the core code of two selfreg cron jobs into the Members module. The new routines are called from cleanup_database with two new parameters. The old cron jobs are now wrappers to cleanup_database. As a bonus, we can add a unit test now. In time, we can obsolete the selfreg cron jobs. For now, the code is in one place and behavior does not change. A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Test plan: Run the unit test t/db_dependent/Members.t. Test the two new parameters of cleanup_database.pl. Verify if delete_expired_opac_registrations.pl still works. Same for delete_unverified_opac_registrations.pl. Signed-off-by: Frederic Demians . Fixed minor merge confict on UT & cleanup_database.pl . UT ok . The two deprecated scripts still work as before, with a warning message. . cleanup_database.pl do the deletion job, calling new C4::Members function rather that doing it directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:41:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:41:42 +0000 Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:44:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:44:30 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:44:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:44:49 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #22 from M. de Rooy --- There we go -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:45:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:45:40 +0000 Subject: [Koha-bugs] [Bug 13479] Add option to add/remove biblios from list of books with forced item holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #7 from M. de Rooy --- Bug 13478 needs attention first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:49:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:49:44 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:49:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:49:47 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 --- Comment #3 from Jonathan Druart --- Created attachment 37904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37904&action=edit Bug 13998: Reintroduce use of Koha::Database for C4::Ratings It has been removed by bug 13852, because before bug 13852, Koha::Database was used in C4:Members which was used by C4::VirtualShelves which was used by C4::Auth which was finally used by C4::Ratings... Test plan: At the opac, record detail page, note the record using the stars. Without this patch it does not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:50:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:50:27 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 --- Comment #4 from Jonathan Druart --- This is a blocker for 3.20. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:53:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:53:09 +0000 Subject: [Koha-bugs] [Bug 13189] Patron card creator patron search browse by last name broken by extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13189 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #15 from Jonathan Druart --- Tomas, that means no sense at all, commit f6c750165de6a96b058dccd77b0000848cb3ef96 Date: Fri Mar 20 17:48:43 2015 +0100 Bug 13891: DataTables server-side processing - patron cards has been pushed and remove the Search calls in the pl files. I think the second patch should be reverted to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:55:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:55:12 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #21 from Jonathan Druart --- (In reply to Josef Moravec from comment #20) > I wanted to test it, but there is merge conflict. Could you please rebase? A patch has been pushed to master and I think it is a mistake. I pingued Tomas on bug 13189. You can test it reverting a7822b0a32faa5ffe6e5a3b43c1cd2c58a8a802a before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 13:55:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 11:55:20 +0000 Subject: [Koha-bugs] [Bug 9988] Unneeded timeouts when saving authorities (Can we merge smarter?) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #2 from M. de Rooy --- (In reply to Jonathan Druart from comment #1) > Is it a duplicate of bug 11496? (Or the opposite :) ) Do not think so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 14:19:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 12:19:13 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 --- Comment #6 from Julian FIOL --- Created attachment 37905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37905&action=edit Bug 13899 : Add changes as asked in Comment 5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 14:21:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 12:21:08 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 14:22:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 12:22:25 +0000 Subject: [Koha-bugs] [Bug 13999] New: Going to a Patron Record After Deleting, doesn't present error message Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13999 Bug ID: 13999 Summary: Going to a Patron Record After Deleting, doesn't present error message Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: misilot at fit.edu QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com After deleting a patron if you go to that patron's record via: https://staffsite/cgi-bin/koha/circ/circulation.pl?borrowernumber={{BorrowerNumber}} You get a page that says Checking out to () and no data (which is expected, since the patron doesn't exist anymore in the borrowers table.). If you click the details page, you do get the error message: "This patron does not exist". Would it make sense to have this page also say "This patron does not exist"? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 14:41:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 12:41:17 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37095|0 |1 is obsolete| | --- Comment #16 from M. de Rooy --- Created attachment 37906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37906&action=edit Bug 13876: [QA Follow-up] Resolve updatedatabase logfile issues This patch removes the test on write permissions of the logdir. It uses File::Temp to generate a file in the logdir or otherwise in a system tmp dir. This resolves issues with both write permissions as well as SELinux denials. Note that after generating an empty file, we are appending to it in the system statement. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Amended: only use File::Temp in the fallback case. Do not add the four character suffix in the first attempt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 14:42:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 12:42:56 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 --- Comment #17 from M. de Rooy --- (In reply to Jonathan Druart from comment #13) > What's the point of the suffix? > Now the log filename is updatedatabase_2015-03-25T15:06:59_uyj4.log > Your patch does not call the tempdir subroutine, you should modify the use > File::Temp line: > 10 use File::Temp qw( tempdir ); Now do a require File::Temp if needed. Only use the particular four character suffix of File::Temp in the fallback case. Could you retest, Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:12:24 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10551 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:12:24 +0000 Subject: [Koha-bugs] [Bug 10551] Merging records allows duplicaton of non-repeatable subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8064 CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:12:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:12:54 +0000 Subject: [Koha-bugs] [Bug 7015] Fixup Template Code to Accommodate More Variety of Label Styles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7015 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:29:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:29:51 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from M. de Rooy --- (In reply to Jonathan Druart from comment #5) > Yes, I am aware of that. > But actually, against master, the display is: > all subfields, alphabetically sorted, present in the record > followed by: > all subfields, alphabetically sorted, non present in the record. > > (search for foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) ~ > l.600-700) > > This patch just suggests to display all subfields, alphabetically sorted. > Which makes more sense. > > If my dsecription of how it works on master is wrong, my patch is certainly > wrong. Yes, I am still afraid that your patch is actually "wrong" ;) I am not sure if you understood my point too. Hope the following clarifies: I tested this: I had a tag 100 with a 9 4 q d e (4 and e were empty) Without your patch, I look in catalogue marc detail, I see: 100 a q d. Fine! Without your patch, I look in opac marc detail, I see: 100 a 9 q d. Fine too. Now with your patch, I edit the record: The order is now: 4-9-a-d-e-q Catalogue marc detail gives: a-d-q CHANGED ! Opac marc detail: 9-a-d-q CHANGED AGAIN ! Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:37:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:37:46 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 --- Comment #1 from Jonathan Druart --- Created attachment 37907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37907&action=edit Bug 10423: Show date due with time if it's a hourly loan On printing the summary from the patron account, the hours are not displayed if needed. The as_date_due flag should be set to display it correctly. Problem, GetPendingIssues modify the value retrieved from the database. In order to not add regression and check all calls to GetPendingIssues, this patch backup the value before the change. Test plan: Check some items out, specify a hourly loan for some. Click on print > print summary and confirm the date due are correctly formatted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:37:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:37:43 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:38:10 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- The original issue is fixed, but hourly loan are not correctly displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:43:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:43:25 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|jonathan.druart at biblibre.co |gmcharlt at gmail.com |m | --- Comment #7 from Jonathan Druart --- (In reply to M. de Rooy from comment #6) Ok so the fields should not sorted alphabetically. In this case, the naive approach cannot work, a much more complicated patch must be provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:43:58 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #8 from Jonathan Druart --- Reset assignee to default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:47:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:47:25 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #7 from Katrin Fischer --- Would be nice to see this moving - I could reproduce the issue whenever a hold is confirmed for the first time in Koha 3.18.5.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:49:51 +0000 Subject: [Koha-bugs] [Bug 10410] SCO displays 'return this item' even if item's barcode is not found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- This is fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 15:52:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 13:52:04 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #9 from M. de Rooy --- (In reply to Jonathan Druart from comment #8) > Reset assignee to default. Should your patch be obsoleted too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 16:03:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 14:03:35 +0000 Subject: [Koha-bugs] [Bug 14000] New: Icons not longer appear on sco Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14000 Bug ID: 14000 Summary: Icons not longer appear on sco Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Looking at bug 10410 and the screenshot attached, you can see the icon the button. The code still exists in the bootstrap theme, but does not use the bootstrap icon. http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18651 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 16:04:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 14:04:09 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #21 from Katrin Fischer --- I just got a screenshot proof from a library on 3.18.5.1 - it's still happening. Item is due today, 23:59 Dateformat is set to metric. ISSUSLIP

<>
Signatur: <>
Barcode: <>
F?llig am: <>


?berf?llig

<>
Signatur: <>
Barcode: <>
F?llig am: <>

-- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 16:05:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 14:05:28 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 16:05:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 14:05:37 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 --- Comment #10 from Jonathan Druart --- (In reply to M. de Rooy from comment #9) > (In reply to Jonathan Druart from comment #8) > > Reset assignee to default. > > Should your patch be obsoleted too? Yes, done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 16:07:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 14:07:54 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #8 from Kyle M Hall --- Thanks Galen! That's a capital idea! I imagine then I would need to add a system preference to decide which field/subfield that status value should go into, right? (In reply to Galen Charlton from comment #4) > (In reply to Kyle M Hall from comment #2) > > (In reply to Katrin Fischer from comment #1) > > > I am not sure about this idea - do we really need to store it in the > > > database as it is a calculated value? Or could it be something that is added > > > on export? > > > Some libraries allow check-out of damaged items depending on severity - not > > > sure if the sequence is something that should/could be configurable. > > > > It must have the ability to be stored in the MARC, otherwise it won't be > > useful. The problem is that external software utilizing z39.50 cannot > > determine the true status of an item based on the fields returned. > > I'm +1 for the general idea of providing a unified item status value to > consumers of Koha APIs, Z39.50 clients, and metadata exports. > > But responding to your response to Katrin's point: for the purpose of a > Z39.50 client or a consumer of a MARC export, it doesn't need to be _stored_ > in the MARC record or in the items table; it only needs to be emitted when > called for. This could, for example, be invoked by EmbedItemsInMarcBiblio(). > Another option would be to have it be a derived DBIC virtual field. > > Why not store it in an items.status column? Because doing so automatically > creates more work: it would HAVE to be kept up to date whenever an item gets > modified or participates in a circulation transaction. Why? You can't stop > folks from writing SQL queries on it, and you can't stop developers who are > not intimately familiar with Koha's notion of item status from trying to use > it. To put it another way, *storing* the calculated unified item status > value in the database means that you couldn't evade the scope creep of > fixing all the item status things in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 16:18:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 14:18:08 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #22 from Katrin Fischer --- Created attachment 37908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37908&action=edit screenshot of the wrong display note date on top and overdues (?berf?llig) due date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 16:46:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 14:46:11 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #23 from Jonathan Druart --- Kyle, I am not able to reproduce the issue, and looking at the cait's data: issuedate: '2015-04-15 16:16:14' lastreneweddate: NULL I really don't understand how this code (C4::Members::IssueSlip) 2443 if ((substr $it->{'issuedate'}, 0, 10) eq $now || (substr $it->{'lastreneweddate'}, 0, 10) eq $now) { 2444 $it->{'now'} = 1; 2445 } 2446 elsif ((substr $it->{'date_due'}, 0, 10) le $now) { 2447 $it->{'overdue'} = 1; 2448 } could set overdue :) All what I know is that in 3.18.05.1, GetPendingIssues does some stuff with the date_due using DateTime::Format::DateParse, which has been removed from master. Anyway, the overdue flag is set in GetPendingIssues, why don't you remove all the code around the date manipulations? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 16:49:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 14:49:08 +0000 Subject: [Koha-bugs] [Bug 13912] System preference for default place of publication (country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Thomas Dukleth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |td-koha-bugs at agogme.com Status|Passed QA |Failed QA --- Comment #11 from Thomas Dukleth --- Tom?s Cohen Arazi brought this bug to my attention with the concern that the currently proposed fix is MARC 21 specific and thus ignores implications for UNIMARC. The more important issue is that the proposed fix sets a default value as the code for United States when left blank which would be the wrong value for far too many users. 1. DEFAULT VALUE WHEN BLANK. Given the international nature of the Koha project, it should always be considered unwise to set a default value for country code in a system wide preference even for those using English when the default value for country code is blank. Even, a least effort patch should either have the value blank when the system preference is blank with a warning about the unset default value when checking system preferences and when invoking the related plugin for the record editor. A greater effort patch would have the default system wide country of production for cataloguing set from a value list. However, a default should be blank. Requiring the user to set a default as part of a guided installation or upgrade would ameliorate the problem. 2. MARC DIFFERENCES. Code for country of production (using a somewhat generic description) is a more complex problem for MARC 21 Bibliographic than for UNIMARC Bibliographic. 2.1. BRIEF CONCLUSION. Given the difference in the treatment for country of production between MARC 21 and UNIMARC, it seems reasonable to specify the system preference label more generically with the additional lablel note that the system preference only applies currently to MARC 21 with direction to UNIMARC users to adjust the default value for 102 $a, $b, or $c if they would choose to have a default value. 2.2. MARC 21. In the case of MARC 21, the value needs to be set as a small part, positions 15 to 17 of fixed field 008 for which a Koha record editor plugin, such as marc21_field_008.pl http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=cataloguing/value_builder/marc21_field_008.pl;hb=HEAD , could be used to set the value as specified by a MARC 21 Koha MARC framework in `marc_subfield_structure`.`value_builder`. Documentation for values is linked from http://www.loc.gov/marc/countries/ . An HTML page with a simple list is at http://www.loc.gov/marc/countries/countries_code.html . An XML file for automated processing is available at http://www.loc.gov/standards/codelists/countries.xml . 2.3. UNIMARC. In the case of UNIMARC, the value occupies a complete subfield for subfields of field 102. As a consequence of using a complete subfield, a default value could be set for a UNIMARC Koha MARC framework in `marc_subfield_structure`.`defaultvalue`. Similarly, as a consequence of using the complete subfield, a value list could be specified by a UNIMARC Koha MARC framework in `marc_subfield_structure`.`authorised_value`. The French framework_DEFAULT.sql, http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql;hb=HEAD does not specify any default values for 102 $a, $b, or $c. Despite the machine readable utility, the UNIMARC standard gives less importance to field 102 and does not specify it as a requirement in contrast to the requirement for full MARC 21 records to at least use 008 overall. Documentation for values is linked from http://www.iso.org/iso/country_codes/country_codes . Values could be parsed from the text contained in https://www.iso.org/obp/ui/#search/code/ . Sadly, ISO charges fees for access to a proper machine readable version. [Their general fee structure discourages the use of standards which should be opposite to the goal of any standards organisation.] 2.4. MARC NEUTRAL FIX. A proper MARC neutral fix with some effort would set a default country of cataloguing for as a system wide preference. Appropriate value lists would be included for MARC 21 or UNIMARC as needed. The system preference would check the value of marcflavour setting for determining the value list used. An appropriate plugin for MARC 21 or UNIMARC would use the appropriate value list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 17:01:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 15:01:22 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #24 from Katrin Fischer --- Even if we weren't able to figure it out yet, this: 2446 elsif ((substr $it->{'date_due'}, 0, 10) le $now) { 2447 $it->{'overdue'} = 1; ... is wrong, if you think of hourly loans, I think? So we shouldn't keep that alive. I can see that we need the flag now for the Quick slip, but why do we need to mangle with the overdue status here...? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 17:27:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 15:27:11 +0000 Subject: [Koha-bugs] [Bug 13912] System preference for default place of publication (country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 --- Comment #12 from Thomas Dukleth --- I should have added for both less ambiguous description and the MARC neutral aspect that `systempreferences`.`variable` should be something such as CountryOfProductionDefault or CountryOfProductionCodeDefault, but not DefaultCountryField008 as in the proposed fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 17:37:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 15:37:16 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #25 from Katrin Fischer --- I think I managed to create a test case: 1) Check out an item today, due date is today 23.59 2) Check out an item yesterday (change issue date in db), due date is today 23:59 ... and the ISSUESLIP is reliably wrong it appears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 17:40:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 15:40:05 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 17:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 15:40:07 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35415|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 37909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37909&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 17:48:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 15:48:02 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #26 from Jonathan Druart --- So, confirmed on master. make sure you have: item1 => date_due = today, issuedate = yesterday item2 => date_due = today, issuedate = today -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 18:38:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 16:38:38 +0000 Subject: [Koha-bugs] [Bug 14001] New: Inventory is not plack friendly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001 Bug ID: 14001 Summary: Inventory is not plack friendly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org Wanting to profile tools/inventory.pl, the following steps were take: - installed the kohadevbox (https://github.com/digibib/kohadevbox) - Log in to plack staff client - Add one book via z39.50, setting barcode to a known value (BARCODE1) - Wait for the reindex - Home -> Tools -> Inventory/Stocktaking - Browse for a file with the barcode in it - Click 'Submit' - Acknowledge it will take long - *kaboom* Plack barfed on line 297. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 18:39:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 16:39:02 +0000 Subject: [Koha-bugs] [Bug 14001] Inventory is not plack friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|gmcharlt at gmail.com |mtompset at hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 18:45:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 16:45:46 +0000 Subject: [Koha-bugs] [Bug 14001] Inventory is not plack friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 18:45:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 16:45:49 +0000 Subject: [Koha-bugs] [Bug 14001] Inventory is not plack friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001 --- Comment #1 from M. Tompsett --- Created attachment 37910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37910&action=edit Bug 14001 - Inventory tool is not plack friendly After receiving an error while attempt a simple inventory run, Line 297 was changed from: ...$_->... to ...$item->... since the loop variable is $item. TEST PLAN --------- 1) Do what is described in comment #1 -- *kaboom* 2) apply the patch on the kohadevbox 3) re-attempt -- success! 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 19:36:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 17:36:18 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 19:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 17:36:24 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 20:19:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 18:19:41 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #27 from Katrin Fischer --- Kyle, would you be ok squashing the patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 20:20:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 18:20:24 +0000 Subject: [Koha-bugs] [Bug 13992] Software error in reports if field or table does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 20:20:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 18:20:39 +0000 Subject: [Koha-bugs] [Bug 13992] Software error in reports if field or table does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37796|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 37911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37911&action=edit [SIGNED OFF] Bug 13992 - Software error in reports if field or table does not exist To reproduce: - Go to Home > Reports Guided reports wizard - Create report from SQL - Enter something like: select holdrio from borrowers - Save SQL - run report Result: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/reports/guided_reports.pl line 932. expected: graceful error message - Change sql to something like: select id from holdrio; - Save SQL - Run report Result: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/reports/guided_reports.pl line 932. expected: graceful error message - Change sql to something like: pling from plong - Save SQL Result (after saving): Message "The database returned the following error: 1" Expected: Meaningful message "The database returned the following error: No SELECT" (similar to forbidden statements as UPDATE) Test plan: - Apply patch - Try to reproduce issues above. They should be resolved. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 20:59:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 18:59:49 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 21:01:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 19:01:54 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #18 from Kyle M Hall --- (In reply to Benjamin Rokseth from comment #17) > Actually,as Kyle mentioned above I'm also not entirely sure the current > implementation is correct as to the SIP2 standard. Checkin is not limited to > checked out items, it is, the way I see it,the only way for an ACS to > validate the circulation status of an item. (hold,wrong branch,in transfer, > etc.) Compare this to a package delivery service where every point involves > a checkin. > > Any critical error in the process should fail the checkin response and give > a suitable feedback. > > The "checked_in_ok" param from SIPConfig.xml is used as param in the checkin > routine and fallbacks to old behaviour (item not checked out) if unset. > Kyle,please correct me if wrong. > > This bug is actually a showstopper for us (50+ self-check machines and book > sorting device) so I hope it can be resolved shortly You're spot on! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 21:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 19:03:29 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #10 from Blou --- Created attachment 37912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37912&action=edit Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. The message box should now show "600 - No matching authority found." if no matching authority was found. For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup should appear, containing a "Modify authority" form. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 21:05:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 19:05:00 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33074|0 |1 is obsolete| | --- Comment #11 from Blou --- Created attachment 37913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37913&action=edit Bug 11299 - add the lost button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 21:06:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 19:06:46 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com Assignee|fcapovilla at live.ca |philippe.blouin at inlibro.com --- Comment #12 from Blou --- I "fixed" Frederik/Simith's patch by standardizing the title and adding the testing scenario to it. Added a second patch with the lost button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 21:44:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 19:44:06 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not useless and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 21:44:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 19:44:12 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not useless and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37382|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 37914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37914&action=edit [SIGNED OFF] Bug 7976: Remove the borrow permission The borrow permission was used but uselessly. For instance, at the opac, the flagsrequired parameter was set to 'borrow' but the 'authnotrequired' was set also (which means no auth required). At the end, this permission was used at only 1 place: for the basket, intranet side. This can be replaced with the catalogue permission (which is used to search). Test plan: 1/ Confirm that you are able to show/download/sent the cart (intranet side) with the catalogue permission. 2/ At the OPAC, you should be able to access the same pages as before with any other permissions. Concretely it is quite difficult to test this patch, you should have a look at the code. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 21:52:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 19:52:08 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Borrow Permission" is not |"Borrow Permission" is not |useless and can be removed |used and can be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:07:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:07:40 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:07:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:07:44 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37716|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 37915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37915&action=edit [PASSED QA] Bug 13109 - Serial failure for received and general viewing. to test... 1/ attempt to view a subscription-detail that has a NULL value for either it's 'startdate' or 'enddate' an example url would be... http://koha-admin.foo.org/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1 observe error... 'Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /your/koha/C4/Serials.pm line 2325' 2/ apply patch 3/ repeat step 1/ observe that detail page displays OK Signed-off-by: Jonathan Druart I confirm the issue if startdate is null (can exist with old data, before the js check on the form). Amended patch: Remove trailing space char and the link to the bz number (can be found using git log). Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:19:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:19:08 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:19:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:19:11 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37892|0 |1 is obsolete| | --- Comment #241 from Nick Clemens --- Created attachment 37916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37916&action=edit [SIGNED OFF] Bug 7143 Adding new developers and releases to the history Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:25:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:25:16 +0000 Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL even if turned off by system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:25:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:25:19 +0000 Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL even if turned off by system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37717|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 37917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37917&action=edit [PASSED QA] Bug 13917: OPAC: Putting holds still possible by URL even if turned off by system preference To test: 1) Prepare an URL that put's a hold in OPAC (see comment #1), e.g. [YOUR SERVER]/cgi-bin/koha/opac-reserve.pl?biblionumbers=1 2) Set system preference 'RequestOnOpac' to 'Don't allow patrons to place holds on items from the OPAC.' 3) Go diectly to this URL. Result: The page displays to confirm hold (wrong) 4) Apply patch 5) Repeat step 3 Result: Redirect to 404 page (OK) 6) Set system preference to "Allow" 7) Repeat step 3 Result: The page displays to confirm hold (OK), like it would be from link in OPAC. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:26:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:26:22 +0000 Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL even if turned off by system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I think if we look really close... we'd find more features that need this kind of fix - thx for the patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:32:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:32:21 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #2 from Blou --- Created attachment 37918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37918&action=edit Bug 11300 - Add a Z39.50 Linker that searches for authority links in the specified Z39.50 server This patch depends on code added in Bug 11299, and must be applied after it. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) This patch adds a Z39.50 Linker which searches for authority links on a remote server. If a matching authority is found, it's imported in the local database for linking with the current biblio record. If no matching authority was found on the remote server, the Linker falls back to a local authority search. Configuration : * The option "Z39.50 Server" is added to the LinkerModule preference. You must choose this to use the new Linker. * The preference LinkerZ3950Server is required and specifies which server to use for linking. It must contain the "name" of the server, as defined in the z3950servers table. * You can set the "local_first" option in the LinkerOptions preference to force the Linker to search for authorities in the local database first. If no local authority match was found, the Linker falls back to a remote Z39.50 search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:32:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:32:41 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:32:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:32:46 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37916|0 |1 is obsolete| | --- Comment #242 from Katrin Fischer --- Created attachment 37919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37919&action=edit [PASSED QA] Bug 7143 Adding new developers and releases to the history Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:33:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:33:05 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com Attachment #23147|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:37:27 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Assignee|fcapovilla at live.ca |philippe.blouin at inlibro.com --- Comment #3 from Blou --- I rebased the patch, on top of bz 11299. I fixed the issues spotted by qa-test. This now applies cleanly. ***** Remember to first apply 11299 before ***** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:42:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:42:37 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:42:40 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37826|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 37920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37920&action=edit [PASSED QA] Bug 10131: Add a fallback if the pref search is not a valid regex It's possible to search prefs using a regex. But it the regex is not correctly written, the app explodes. We should provide a fallback. Test plan: 0/ Does not apply the patch 1/ Search for sysprefs with "notes.*", note the number of results 2/ Search for *notes*, boom 3/ Apply the patch 4/ Repeat 1 and confirm you get the same number of results 5/ Repeat 2 and confirm you don't get the error anymore NOTE: As noted on comment #4, the kaboom is because of the leading * and not the following *, because 's*' is a valid regular expression, while '*n' is not. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:45:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:45:20 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:45:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:45:23 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37898|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 37921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37921&action=edit [SIGNED OFF] Bug 10174: Add a tooltip to explain what is a digest The digest term seems to be ambiguous for some people. This patch adds a tooltip to explain what it is (feel free to provide a better wording). Test plan: Go at the OPAC and click on the "Your messaging tab", you should see an icon close to "Digest only" to explain what is a digest. Same at the intranet on editing/showing patron info Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:48:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:48:36 +0000 Subject: [Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37802|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 37922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37922&action=edit [PASSED QA] Bug 13991 - Uninitialized value $src in /tools/viewlog.pl To reproduce: Go to Home > Tools > Logs Check intranet-error.log. You will find a line similar to: viewlog.pl: Use of uninitialized value $src in string eq at (...)/tools/viewlog.pl line 70., referer: http://(...)/cgi-bin/koha/tools/tools-home.pl To test: Apply patch. Verify that no more warnings appear in intranet-error.log Verify that the log viewer behaves as before. Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:48:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:48:34 +0000 Subject: [Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:53:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:53:30 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:53:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:53:33 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37921|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 37923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37923&action=edit [PASSED QA] Bug 10174: Add a tooltip to explain what is a digest The digest term seems to be ambiguous for some people. This patch adds a tooltip to explain what it is (feel free to provide a better wording). Test plan: Go at the OPAC and click on the "Your messaging tab", you should see an icon close to "Digest only" to explain what is a digest. Same at the intranet on editing/showing patron info Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 22:54:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 20:54:23 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 --- Comment #16 from Katrin Fischer --- I am not sure about the icon, 'i' might not work in all languages. But I really like the idea and I think styling can still be improved later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:02:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:02:15 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Severity|trivial |enhancement --- Comment #21 from Katrin Fischer --- Hi Kyle, I am ok with this missing checks for subscriptions and orders - I think we can assume here checks have been made when setting the flag (although i would like a 'save delete' option or something similar :) ) But can you please fix: FAIL misc/cronjobs/delete_records_via_leader.pl FAIL critic I/O layer ":utf8" used at line 24, column 1. Use ":encoding(UTF-8)" to get strict validation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:02:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:02:28 +0000 Subject: [Koha-bugs] [Bug 14001] Inventory is not plack friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37910|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 37924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37924&action=edit Bug 14001 - Inventory tool is not plack friendly After receiving an error while attempt a simple inventory run, Line 297 was changed from: ...$_->... to ...$item->... since the loop variable is $item. TEST PLAN --------- 1) installed the kohadevbox (https://github.com/digibib/kohadevbox) or have your staff client plackified 2) Log in to plack staff client 3) Add one item via z39.50, setting barcode to a known value (BARCODE1) 4) Wait for the reindex 5) Home -> Tools -> Inventory/Stocktaking 6) Browse for a file with the barcode in it 7) Set the library dropdown to the library branch of the added item. 8) Click 'Submit' -- *kaboom* Plack barfed on line 297. 9) Repeat steps 5-7 10) Check 'Compare barcodes list to results:' 11) Click 'Submit' -- *kaboom* Plack barfed on line 250. 12) apply the patch on the kohadevbox 13) re-attempt process (steps 5-11) -- success! 14) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:19:48 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:19:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:19:52 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37914|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 37925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37925&action=edit [PASSED QA] Bug 7976: Remove the borrow permission The borrow permission was used but uselessly. For instance, at the opac, the flagsrequired parameter was set to 'borrow' but the 'authnotrequired' was set also (which means no auth required). At the end, this permission was used at only 1 place: for the basket, intranet side. This can be replaced with the catalogue permission (which is used to search). Test plan: 1/ Confirm that you are able to show/download/sent the cart (intranet side) with the catalogue permission. 2/ At the OPAC, you should be able to access the same pages as before with any other permissions. Concretely it is quite difficult to test this patch, you should have a look at the code. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:20:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:20:40 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #7 from Katrin Fischer --- Should we also adjust the borrowres.flags for staff users who had borrows permission? Any negative side effects if we don't? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:26:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:26:12 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 --- Comment #15 from Nick Clemens --- Created attachment 37926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37926&action=edit Bug 7646 - Printing w/o the SQL Code showing This patch provides the same function but adds a 'Print results' button rather than the link. Looks a little cleaner to my eye and there doesn't seem to be an option to print with SQL. To test: Go to Home > Reports > Guided reports wizard > Saved reports Select a report and run it You will find a new link "Print w/o SQL" above the title Hit this link. The report (this page) will print without the SQL statement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:27:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:27:53 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #16 from Nick Clemens --- I tested, but the link looked very odd to me, added a patch to put a 'print results' button with the other action buttons. I did not obsolete the old patch so anyone can test both and see which they prefer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:31:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:31:45 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #30 from Katrin Fischer --- Comment on attachment 37897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37897 [Signed-off] Bug 13941 [2/2] Fix tags missing id/class Review of attachment 37897: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13941&attachment=37897) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorder.tt @@ +3,4 @@ > [% INCLUDE "doc-head-close.inc" %] > > > + Typo? I think should be 'acq_addorder'. @@ +7,5 @@ > [% INCLUDE "header.inc" %] > >
> > +
This change doesn't look right - see above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:34:16 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:34:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:34:19 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37896|0 |1 is obsolete| | Attachment #37897|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer --- Created attachment 37927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37927&action=edit [PASSED QA] Bug 13941 [1/2] Test tag with id/class attributes Test: - Apply the first patch [1/2] containing a new test checking tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid tags. - Apply the second patch [2/2] fixing all invalid tags. - Re-run the test: It passes. Folowed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:35:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:35:11 +0000 Subject: [Koha-bugs] [Bug 13994] Add a back link to error message in Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13994 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:35:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:35:13 +0000 Subject: [Koha-bugs] [Bug 13994] Add a back link to error message in Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13994 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37803|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 37928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37928&action=edit [SIGNED OFF] Bug 13994 - Add a back link to error message in Reports To reproduce: - Go to Home > Reports - Create from SQL - Do something that results in an error message, e.g. by entering an UPDATE statement Result: You get an error message with title "The follwing error was encountered" But there is now link to go directly back to fix it. To test: - Apply patch - Repeat steps above - Verify that a link appears (and works): "Back to previous page" Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:35:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:35:25 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #32 from Katrin Fischer --- Created attachment 37929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37929&action=edit [PASSED QA] Bug 13941 [2/2] Fix tags missing id/class Followed test plan from patch 1/2, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:35:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:35:59 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #33 from Katrin Fischer --- Created attachment 37930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37930&action=edit Bug 13941: QA Follow-up - fix for acqui/addorder.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:36:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:36:56 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #34 from Katrin Fischer --- I have written a follow-up for the problem described in the last comment - please check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:41:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:41:43 +0000 Subject: [Koha-bugs] [Bug 13803] SelfCheck not setting flag when item requires transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13803 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com, | |katrin.fischer at bsz-bw.de Component|Self checkout |SIP2 --- Comment #3 from Katrin Fischer --- Kyle or Brendan, could one of you take a look at this please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:47:04 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:47:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:47:07 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37778|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 37931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37931&action=edit [SIGNED OFF] Bug 13987 - Fix server name in z39.50 authority search results When doing an Auth search through z3950, the resulting table has the first column (servers name) always empty. TEST 1) once logged into the intranet, go to Authorities. 2) Click New from z39.50, fill appropriatly for a successful search. 3) Acknowledge first column is empty. Always. 4) Apply the (very simple) patch. 5) Do another search, validate column is not empty anymore. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:48:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:48:39 +0000 Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:48:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:48:42 +0000 Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37715|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 37932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37932&action=edit [PASSED QA] Bug 8474 - Holds done by librarians cause silent errors in koha-error_log, placerequest.pl -> $checkitem Squashed this rogue variable initialization Test plan: 1/ Place a hold at a biblio level (on the next available item) 2/ Without this patch you get placerequest.pl: Use of uninitialized value $checkitem in string ne at /home/koha/src/reserve/placerequest.pl line 75. placerequest.pl: Use of uninitialized value $checkitem in string ne at /home/koha/src/reserve/placerequest.pl line 101. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Fixed a tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:52:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:52:10 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 --- Comment #6 from Katrin Fischer --- Created attachment 37933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37933&action=edit kkk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:52:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:52:51 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 15 23:52:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 21:52:54 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37931|0 |1 is obsolete| | Attachment #37933|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 37934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37934&action=edit [PASSED QA] Bug 13987 - Fix server name in z39.50 authority search results When doing an Auth search through z3950, the resulting table has the first column (servers name) always empty. TEST 1) once logged into the intranet, go to Authorities. 2) Click New from z39.50, fill appropriatly for a successful search. 3) Acknowledge first column is empty. Always. 4) Apply the (very simple) patch. 5) Do another search, validate column is not empty anymore. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 00:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 22:02:03 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- (In reply to Blou from comment #2) > Sponsored by : CCSR Hi Blou, if you want this to go into the release notes, please put it in the commit message - one commit with the line will be enough for it to work: http://wiki.koha-community.org/wiki/Commit_messages#Sponsor_line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 00:05:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 22:05:30 +0000 Subject: [Koha-bugs] [Bug 13992] Software error in reports if field or table does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 00:05:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 22:05:33 +0000 Subject: [Koha-bugs] [Bug 13992] Software error in reports if field or table does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37911|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 37935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37935&action=edit [PASSED QA] Bug 13992 - Software error in reports if field or table does not exist To reproduce: - Go to Home > Reports Guided reports wizard - Create report from SQL - Enter something like: select holdrio from borrowers - Save SQL - run report Result: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/reports/guided_reports.pl line 932. expected: graceful error message - Change sql to something like: select id from holdrio; - Save SQL - Run report Result: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/reports/guided_reports.pl line 932. expected: graceful error message - Change sql to something like: pling from plong - Save SQL Result (after saving): Message "The database returned the following error: 1" Expected: Meaningful message "The database returned the following error: No SELECT" (similar to forbidden statements as UPDATE) Test plan: - Apply patch - Try to reproduce issues above. They should be resolved. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 00:10:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 22:10:42 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- > A next step (as described on the Bugzilla report) would be: remove the Delay > pref for self regs. Can we rethink this? There is another 'movement' in the patches recently to create preferences for options in the cronjobs. This is helpful when you are running multiple installations on one server, where maintaining separate cronjobs for each library would be quite a hassle. Ultimately I'd like a separate tool for those things, but as we have a pref already, why not keep it until that arrives? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 00:35:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 22:35:47 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org Status|Needs Signoff |Failed QA --- Comment #9 from Nick Clemens --- Test plan successful for first patch, when checking for regression I cannot delete a patron Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.ethnicity' in 'field list' at /home/kidclamp/kohaclone/C4/Members.pm line 1864 For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 01:25:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 23:25:27 +0000 Subject: [Koha-bugs] [Bug 13803] SelfCheck not setting flag when item requires transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13803 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 01:25:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 Apr 2015 23:25:29 +0000 Subject: [Koha-bugs] [Bug 13803] SelfCheck not setting flag when item requires transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13803 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37756|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher --- Created attachment 37936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37936&action=edit Bug 13803 Flag to self check book has gone into transit Ensure that the transit flag (in field CV) is set if return message is 'wasTransfered' CV is being set for other return conditions but not for wasTransfered [sic] The presence of this flag is required to route returns to the correct bin if the SC unit is so enabled Signed-off-by: Frederic Demians I agree with the solution to an issue I've already encountered and patched localy that way. It would be nice to have a better doc of C4::Circulation::AddReturn in order to see immediately that WasTransfered is a valid feedback for a check-in. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 02:49:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 00:49:43 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #12 from Winona Salesky --- Does a '|' make sense for both multiple $a in one field and repeated 33x fields? That seems a little awkward to me. What about commas between $a and '|' between repeated fields? Any thoughts? Thanks! -Winona (In reply to Winona Salesky from comment #11) > Okay, I will take a look. > Thanks. > -Winona > > (In reply to Nick Clemens from comment #10) > > looks good for single fields, but repeated fields 33x or multiple $a in one > > field need a separator. > > > > I think using the same '|' wrapped in a span as similar bugs makes sense (In reply to Winona Salesky from comment #11) > Okay, I will take a look. > Thanks. > -Winona > > (In reply to Nick Clemens from comment #10) > > looks good for single fields, but repeated fields 33x or multiple $a in one > > field need a separator. > > > > I think using the same '|' wrapped in a span as similar bugs makes sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 03:20:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 01:20:55 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 --- Comment #8 from Winona Salesky --- Created attachment 37937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37937&action=edit Bug 13433 - 655 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field that would show the record in the search results 5) Note this patch adds field 655 to display. Displays subfields a,v,x,y,z. uses a vertical bar to separate multiple titles. Vertical bar is wrapped in span class="separator" for easy suppression/customization of separator. 6) Repeat steps 4 and 5 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 03:20:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 01:20:53 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:01:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:01:42 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:01:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:01:44 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37623|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 37938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37938&action=edit [SIGNED OFF] Bug 9878: Add consistentcy on restriction messages Between both pages circ/circulation.pl and members/moremember.pl, the restriction messages should be the same. Test plan: 1/ Add a non-unlimited restrictions to a patron 2/ Go on both pages and confirm the restriction message is the same. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:21:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:21:22 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:21:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:21:25 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37821|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 37939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37939&action=edit [SIGNED OFF] Bug 10285: Remove links from the error pages The error page (400, 401, 402, 403, 404, 405 and 500) displays parts the old staff client main page. The user can easily browses using navigation links. Test plan: Go on the 400.pl, 401.pl, 402.pl, 403.pl, 404.pl, 405.pl and 500.pl pages, and confirm all is fine and you don't get the old style blocks. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:22:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:22:31 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #7 from Nick Clemens --- Signed off, but worth noting, I didn't check 405.pl because I can't find it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:30:43 +0000 Subject: [Koha-bugs] [Bug 8802] Library group records - category type reverts to "searchdomain" when editing group record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8802 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37420|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 37940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37940&action=edit [SIGNED OFF] Bug 8802: On editing a library group category type is not set The category type was always set to 'searchdomain', because it's the first of the dropdown list. Test plan: 1/ Create or edit a library group 2/ Set the category type to "properties" 3/ Edit it again 4/ Confirm "properties" is correctly selected Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:30:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:30:40 +0000 Subject: [Koha-bugs] [Bug 8802] Library group records - category type reverts to "searchdomain" when editing group record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8802 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:31:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:31:15 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #8 from M. Tompsett --- (In reply to Nick Clemens from comment #7) > Signed off, but worth noting, I didn't check 405.pl because I can't find it $ git grep 405.t | grep -v "\.po:" generates nothing. 405 can be removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:35:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:35:01 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 --- Comment #9 from M. Tompsett --- (In reply to Nick Clemens from comment #7) > Signed off, but worth noting, I didn't check 405.pl because I can't find it HTTP error code 405 is "Method Not Allowed" -- disable post and get in your apache config, and see what wonderful kabooms occur? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:56:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:56:20 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 04:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 02:56:22 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37904|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 37941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37941&action=edit [SIGNED OFF] Bug 13998: Reintroduce use of Koha::Database for C4::Ratings It has been removed by bug 13852, because before bug 13852, Koha::Database was used in C4:Members which was used by C4::VirtualShelves which was used by C4::Auth which was finally used by C4::Ratings... Test plan: At the opac, record detail page, note the record using the stars. Without this patch it does not work. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 05:16:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 03:16:19 +0000 Subject: [Koha-bugs] [Bug 13981] Transliterate rule for oe and ae In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 07:52:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 05:52:01 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #35 from Fr?d?ric Demians --- (In reply to Katrin Fischer from comment #34) > I have written a follow-up for the problem described in the last comment - > please check. Looks good to me. I suspect other templates may have inconsistent id/class with their file name and module. I thought about improving the UT to detect that cases, but changing id/class that are here since a while may broke local JavaScript developed by libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 08:25:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 06:25:59 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #14 from Robin Sheat --- So there's a bug in the version of tar that debian includes that means I can't currently build mojolicious. I'll have to find a workaround to that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 08:30:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 06:30:05 +0000 Subject: [Koha-bugs] [Bug 13912] System preference for default place of publication (country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 08:32:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 06:32:35 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #11 from M. de Rooy --- (In reply to Katrin Fischer from comment #10) > > A next step (as described on the Bugzilla report) would be: remove the Delay > > pref for self regs. > > Can we rethink this? There is another 'movement' in the patches recently to > create preferences for options in the cronjobs. This is helpful when you are > running multiple installations on one server, where maintaining separate > cronjobs for each library would be quite a hassle. Ultimately I'd like a > separate tool for those things, but as we have a pref already, why not keep > it until that arrives? Fine with me. But this could proceed now separate of that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:03:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:03:20 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:03:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:03:23 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34087|0 |1 is obsolete| | --- Comment #35 from Fr?d?ric Demians --- Created attachment 37942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37942&action=edit Bug 11190 sitemap.pl -- Generate a Catalog sitemap Add a script sitemap.pl to process all biblio records from a Koha instance and generate Sitemap files complying with this protocol as described on http://sitemaps.org. The goal of this script is to be able to provide to search engines direct access to biblio records. It avoid leaving search engine browsing Koha OPAC and so generating a lot of traffic, and workload, for a bad result. Thanks Magnus for testing, and helping to improve the script design. [2015.04.16] Switch from Moose to Moo. Signed-off-by: Magnus Enger All options to the script work as expected and the output looks good. Nice enhancement! Signed-off-by: Frederic Demians I signed-of my own patch after fixing various QA errors. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:09:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:09:49 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart --- Kyle, some questions have been asked, please have a look. Also tests are missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:12:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:12:58 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #36 from Fr?d?ric Demians --- Few personal notes about Moose vs Moo (just seen IRC dev meeting logs): There is an overhead using Moose for small short lived programs. But for long- running cronjob/maintenance scripts, there isn't any problem using Moose. For Koha WUI scripts, Moose start time is a problem as long as Koha operates in CGI mode. As soon as there is persistence (Plack), it isn't a problem anymore. This issue of runtime penaly due to using a large and complex library, doing a lot of stuff behind the scene, is not different with Moose and DBIx::Class I don't say DBIx::Class is bad. Moose it bad too => So let's go with Moose! I'd say both libraries share a lot of good things. I think that Moose has various advantages over other OO frameworks. It's complete, very well documented, widely used, a standard, carefully packaged for all major Linux distro. All books about the so-called "modern-Perl movement" deals with using Moose as OO. There is the Perl's famous moto: There's more than one way to do it. Applied to OO, this could conduct to chaos. There are so many ways to do OO in Perl. Code become unreadable and unreliable. Moose forces to adopt a proper and consistent OO approach. Moo try to solve a non-issue (library weight, startup time) in modern execution environments at high price: too many important features are lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:17:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:17:28 +0000 Subject: [Koha-bugs] [Bug 13981] Transliterate rule for oe and ae In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 --- Comment #2 from Marc V?ron --- Created attachment 37943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37943&action=edit [Signed-off] Bug 13981 - Transliterate rule for oe and ae NOTE : I use HTML codes for special characters to avoir encoding issues in patch file. In ICU configuration, add a transliterate rule for œ = oe æ = ae Test plan : - Without patch - Create a record R1 with title containing for example "cœur" - Create a record R2 with title containing for example "coeur" - Index those records - Search for "cœur" => You only find R1 - Search for "coeur" => You only find R2 - Apply patch - Restart zebra - Index R1 and R2 - Search for "cœur" => You find R1 and R2 - Search for "coeur" => You find R1 and R2 (Same test plan for ae) ------ Tested with all variants of Ae ae Oe oe. Search worked as expected. Note: The words with special characters were not highlighted, but I think this can be done in an other bug. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:18:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:18:14 +0000 Subject: [Koha-bugs] [Bug 13981] Transliterate rule for oe and ae In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #37718|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:18:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:18:22 +0000 Subject: [Koha-bugs] [Bug 13981] Transliterate rule for oe and ae In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:27:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:27:26 +0000 Subject: [Koha-bugs] [Bug 7890] highlight required in yellow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:44:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:44:50 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #12 from Katrin Fischer --- Yes, this is separate, just thought maybe better to discuss first before code written :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:48:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:48:49 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:48:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:48:52 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 --- Comment #8 from Jonathan Druart --- Created attachment 37944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37944&action=edit Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 09:49:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 07:49:26 +0000 Subject: [Koha-bugs] [Bug 7976] "Borrow Permission" is not used and can be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > Should we also adjust the borrowres.flags for staff users who had borrows > permission? Any negative side effects if we don't? Yes you are right, to be safe it's certainly better :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 10:02:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 08:02:26 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Jonathan Druart --- (In reply to Nick Clemens from comment #9) > Test plan successful for first patch, when checking for regression I cannot > delete a patron > > Software error: > > DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.ethnicity' in > 'field list' at /home/kidclamp/kohaclone/C4/Members.pm line 1864 > For help, please send mail to the webmaster ([no address given]), giving > this error message and the time and date of the error. I have retested and it works. Did you update the schema (step 0 of first patch)? You need to edit the file and set $db_name, $db_user and $db_password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 10:09:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 08:09:56 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|kyle at bywatersolutions.com |jonathan.druart at biblibre.co | |m --- Comment #29 from Jonathan Druart --- I will try to provide a patch today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 10:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 08:33:04 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 --- Comment #17 from Marc V?ron --- Created attachment 37945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37945&action=edit [Signed-off] Bug 7646 - Printing w/o the SQL Code showing This patch provides the same function but adds a 'Print results' button rather than the link. Looks a little cleaner to my eye and there doesn't seem to be an option to print with SQL. To test: Go to Home > Reports > Guided reports wizard > Saved reports Select a report and run it You will find a new link "Print w/o SQL" above the title Hit this link. The report (this page) will print without the SQL statement. Works as expected. Print function is displayed as Button. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 10:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 08:33:53 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 10:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 08:34:16 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 10:34:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 08:34:31 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 10:34:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 08:34:39 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 10:52:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 08:52:20 +0000 Subject: [Koha-bugs] [Bug 13912] System preference for default place of publication (country code) for field 008, range 15-17 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 --- Comment #13 from Thomas Dukleth --- The proposed fix using $DefaultCountryField008 follows the somewhat less problematic example of $DefaultLanguageField008. 1. CORRECTING HARD CODED CHOICES. Already existing code has hard coded choices for both language of content and country of production in marc21_field_008.pl if no preference is specified, but we should not be perpetuating that mistake in a new patch. Country also has a narrower scope and is thus more likely to be wrong if not specified than language. If no preference has been set, the corresponding value should be empty by default or specified as an equivalent to "no attempt to code" where relevant. 2. MARC NEUTRAL APPLICATION. The proposed $DefaultCountryField008 follows the mistaken pattern of $DefaultLanguageField008 for the MARC 21 based description in `systempreferences`.`description`. However, the same list of language codes for language of content applies to the current standard for both MARC 21 and UNIMARC $DefaultLanguageField008. [There had been a few differences in language codes for the respective bibliographic standards from the 1990s and earlier.] Consequently, a default specified in $DefaultLanguageField008 could be used equally for both MARC 21 and UNIMARC. A more universal approach for specifying country of production could use a value list for country which would be a superset of country specifications from both the ISO 3166 Country Codes list and Library of Congress MARC Country Codes list. The user could choose by the label for the country code in a manner independent of MARC and the appropriate code could be used based on the MARC standard specified in Koha $marcflavour. Alas, I am uncertain, if I am prepared to do all the work which would be necessary for such a worthy goal along with related validation at the present time. 3. KOHA MARC FRAMEWORK CENTRIC DEFAULT. Tom?s Cohen Arazi is interested in tying a default setting closer to the Koha MARC frameworks. An advantage would be that the user could choose from different default values by choosing different frameworks which the user could create. The difficulty of using `marc_subfield_structure`.`defaultvalue` is that fixed fields, such as MARC 21 008, would be difficult for users to encode as a default. A plugin for the frameworks editor similar to one for the record editor could be used to populate default values for fixed fields in the frameworks. [In the Koha MARC frameworks, MARC 21 fixed fields are managed as if they are subfield $0 of the respective fields. UNIMARC fixed subfields are subfields which is unproblematic for the original design of the Koha MARC frameworks code.] I am a little uncertain of the degree of debugging time required for plugins to work on framework values relative to my time. I would be happy to have a more MARC neutral system preference for country of production at the present time in which the user would enter a value as in the proposed fix, but choosing from the linked documentation for MARC country code list for MARC 21 or the ISO 3166 code list for UNIMARC. We could then file an enhancement bug for adding more granular defaults for fixed fields and fixed subfields associated with Koha MARC frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:10:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:10:25 +0000 Subject: [Koha-bugs] [Bug 14002] New: Show patron expiry date in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14002 Bug ID: 14002 Summary: Show patron expiry date in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We currently don't show the expiry date of the patron on the OPAC detail page. This is an important date and we should display it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:12:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:12:00 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:12:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:12:03 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36048|0 |1 is obsolete| | Attachment #36049|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 37946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37946&action=edit Bug 12847: Items issued today is considered as overdue The date comparisons in C4::Members::IssueSlip does not work as expected. Is an item is issue yesterday and due today (23:59), it should not be considered as an overdue yet. Test plan: Define a valid issue slip (code ISSUESLIP) Check 2 items out and update the issuedate value for one of them as yesterday (using the mariadb/mysql cli or similar) Print the slip Before this patch the item marked as issued yesterday is considered as overdue. Special cases: - hourly loans - Quick slip is impacted too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:17:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:17:17 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37907|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 37947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37947&action=edit Bug 10423: Show date due with time if it's a hourly loan On printing the summary from the patron account, the hours are not displayed if needed. The as_date_due flag should be set to display it correctly. Problem, GetPendingIssues modify the value retrieved from the database. In order to not add regression and check all calls to GetPendingIssues, this patch backup the value before the change. Test plan: Check some items out, specify a hourly loan for some. Click on print > print summary and confirm the date due are correctly formatted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:42:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:42:08 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:42:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:42:11 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36953|0 |1 is obsolete| | Attachment #36954|0 |1 is obsolete| | Attachment #36955|0 |1 is obsolete| | Attachment #36956|0 |1 is obsolete| | Attachment #36957|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall --- Created attachment 37948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37948&action=edit [PASSED QA] Bug 10480: New module and unit test for framework plugins This patch introduces the Koha::FrameworkPlugin object to Koha. This object supports the current "old-style" plugins while adding a new style based on the concept of two anynomous subroutines for building and launching. I will summarize the advantages of this new approach, justifying the additional lines of code in this patch: [1] Centralizing the code for building and launching plugins. [2] Extensive unit testing: this was not possible before. [3] Simplicity: Only define what you need in the plugin. A follow-up patch will delete 1500 lines with *empty* routines. [4] Make it possible to restore the warnings pragma for all plugins. New style plugins do no longer depend on redefinition. [5] Event binding moved from HTML attributes moved to jQuery code. This separates behavior and presentation. [6] Much more documentation, including EXAMPLE plugin in follow-up. [7] Improved error handling. [8] Usability: property noclick tells you if plugin's buttonDot is active. [9] More events supported: Change, keyboard/mouse events. See EXAMPLE. NOTE ON EXAMPLE PLUGIN: The example plugin is added in the third patch of this report. Since it is new style, it can be used only after we start using this object. It also contains an example for a keypress and mouseover event. NOTE ON ITEM PLUGINS: Old style plugins for items contain an additional parameter in the js functions for Blur, Focus and Change. This distinction has no actual use and is resolved for new plugins in the object code. When converting item plugins, this minor correction will be addressed. In the meantime old style item plugins behave as expected. TEST PLAN: Run the new test t/db_dependent/FrameworkPlugin.t At this point in time, you do not need to do anything more. Follow-up patches will incorporate the object in real-life Koha and provide additional test plans. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:42:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:42:29 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37948|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall --- Created attachment 37949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37949&action=edit [PASSED QA] Bug 10480: New module and unit test for framework plugins This patch introduces the Koha::FrameworkPlugin object to Koha. This object supports the current "old-style" plugins while adding a new style based on the concept of two anynomous subroutines for building and launching. I will summarize the advantages of this new approach, justifying the additional lines of code in this patch: [1] Centralizing the code for building and launching plugins. [2] Extensive unit testing: this was not possible before. [3] Simplicity: Only define what you need in the plugin. A follow-up patch will delete 1500 lines with *empty* routines. [4] Make it possible to restore the warnings pragma for all plugins. New style plugins do no longer depend on redefinition. [5] Event binding moved from HTML attributes moved to jQuery code. This separates behavior and presentation. [6] Much more documentation, including EXAMPLE plugin in follow-up. [7] Improved error handling. [8] Usability: property noclick tells you if plugin's buttonDot is active. [9] More events supported: Change, keyboard/mouse events. See EXAMPLE. NOTE ON EXAMPLE PLUGIN: The example plugin is added in the third patch of this report. Since it is new style, it can be used only after we start using this object. It also contains an example for a keypress and mouseover event. NOTE ON ITEM PLUGINS: Old style plugins for items contain an additional parameter in the js functions for Blur, Focus and Change. This distinction has no actual use and is resolved for new plugins in the object code. When converting item plugins, this minor correction will be addressed. In the meantime old style item plugins behave as expected. TEST PLAN: Run the new test t/db_dependent/FrameworkPlugin.t At this point in time, you do not need to do anything more. Follow-up patches will incorporate the object in real-life Koha and provide additional test plans. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:42:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:42:36 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #46 from Kyle M Hall --- Created attachment 37950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37950&action=edit [PASSED QA] Bug 10480: Use the framework plugin object in cataloguing This patch implements the use of Koha::FrameworkPlugin in Cataloguing, Authorities, Acquisition, Serials and Tools. The main change is architectural: see the commit message of the previous patch. No changes in behavior are expected, but the support of new events may provide additional functionality in the future. Some small bugs are resolved along the way. The change primarily focuses on the MARC and items editor in Cataloguing. But the MARC editor for Authorities and the item editor in Acquisition, Serials and Tools are touched too. This commit message gives some comments per module. NOTE FOR CATALOGUING: A new plugin without popup (or other click event code) now shows the title No popup when hovering over the tag editor image. The image alerts the user on a plugin, the title tells about its status. The noclick property allows for further style modifications in the template. Note that a follow-up patch will clean up the old style plugins too with the same effect. Some additional code in cataloging.js makes it possible to clone subfields with plugins (although only theoretically useful). The clones use the same javascript functions but event.data contains an updated id. This effectively resolves bug 13306. Note that if old plugins do not use the javascript parameter for the id but the perl variable, cloning does still operate on the wrong field (with and without this patch set). In the absence of report 12176 in master, it is not yet necessary to modify additem.tt. When it gets pushed, it should be an easy rebase. New style item plugins will no longer need an extra parameter. (The code in the FrameworkPlugin object actually takes care of that.) NOTE FOR AUTHORITIES: This patch also adds class name tag_editor to the buttonDot anchors. This effectively makes the same tag editor image appear as in Cataloguing. Futhermore it removes the button from the tab sequence if there is no click event (really effective after conversion to the new style, since the old style plugins contain empty onclicks and launchers). Both small adjustments increase consistency between auth and bib edits. NOTE FOR ACQUISITION: In Acquisition two scripts use an item editor, but in a different way. The scripts addorderiso2709 and neworderempty both rely on the routine PrepareItemrecordDisplay in C4::Items, but neworderempty creates item blocks dynamically via an ajax call to services/itemrecorddisplay.pl. In order to make the dynamic item blocks work with plugins, some code changes were needed in additem.js. (Normally the event binding is done at document ready time; now it must be done later.) At this moment the routine in Items.pm contains the html tags, and this makes changes to the following templates not necessary for now: * acqui/addorderiso2709.tt * services/itemrecorddisplay.tt Report 13397 has been opened to address moving the html to the templates. NOTE FOR SERIALS: Script serial-edit relies also on C4::Items (just as in Acquisition). This makes changes to serials/serials-edit.tt not necessary for now. NOTE FOR TOOLS: The current code in tools/batchMod.pl allows the use of plugins for batch modification of items. This patch just converts that code to use the new object. Most item plugins however may not be very useful for operating on multiple items at once. PERFORMANCE: I have benchmarked build_tabs in addbiblio to see how especially the additional processing of the javascript in the FrameworkPlugin object would impact performance. Testing default MARC21 framework with 8 plugins gave the following figures: - Old situation: 851 ms - New situation: 942 ms (+10,7%) - New situation after plugin cleanup: 881 ms (+3,4%) Note also that adding lines for event binding is compensated by removing lines for unused events. Page load should essentially be the same. TEST PLAN: Suggestion: If you also apply the next patch with the EXAMPLE plugin, you can test with a rather harmless plugin (with popup) on various places :) But your test should also include old style plugins, with[out] popups. If you want to test a new plugin without popup, rename/remove Click$id in the javascript code of the $builder definition (temporarily). [1] Test Cataloguing: - Add/Edit biblio. Try plugins with and without popup. - Add/Edit items. (EXAMPLE can be used as an item plugin with popup.) - Clone a subfield with plugin (use EXAMPLE): Verify that the plugin works on both original and clone with the respective field values. Is the value put back in the right field too? [2] Test Authorities: Edit an authority record. Try plugins with an without popup. [3] Test Acquisition: Set system preference AcqCreateItem to "placing an order". Check the item editor in the following two places: a- addorderiso2709: Open a basket, add an order from a staged file. Select a file, click Add orders, and go to tab Item information. b- neworderempty: Open a basket, add an order from a new empty record. [4] Test Serials: Check the item editor on serials-edit. Go to subscription detail. Click Receive. Choose "Click to add item". (Note that this subscription should create an item record when receiving this serial.) [5] Test Tools: Check the item editor for batch item modification. Enter a few valid barcodes and press Continue to reach the item editor. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:42:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:42:39 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #47 from Kyle M Hall --- Created attachment 37951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37951&action=edit [PASSED QA] Bug 10480: EXAMPLE plugin with associated template The EXAMPLE plugin helps you to create a new style framework plugin by providing a simple working example and additional documentation for developers. Test plan: [1] Connect the EXAMPLE plugin to one or more fields. [2] Try the following events: a- Focus: If the field is empty, it should put EXAMPLE: into it. b- MouseOver: If the field is empty and you move your mouse over it, it should have the same effect as Focus. c- Change: Edit the field in the editor and tab out of it, the color of the text should toggle (randomly) between red, green and blue. d- KeyPress: If you edit the field and you type @, it should give AT. e- Click: Click on the tag editor. Change the value in the popup. If you press OK, the field should be changed. [3] Would the documentation in the perl script help you to create a plugin? Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:42:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:42:41 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #48 from Kyle M Hall --- Created attachment 37952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37952&action=edit [PASSED QA] Bug 10480: Remove useless routines and irrelevant pod lines This patch makes the following cleanup actions for all plugins: 1- Remove sub plugin_parameters. This function is not used. 2- Remove empty plugin or empty plugin_javascript subs. 3- Remove empty Blur, Clic or Focus routines from javascript. 4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs. 5- Remove the last 1; line. It is no longer needed. Test plan: Run the unit test t/db_dependent/FrameworkPlugins.t Test some cataloguing plugins in addbiblio. Test some item plugins in additem and neworderempty. Signed-off-by: Marcel de Rooy I also checked the syntax of all plugins with perl -c. And checked the pod (if any) with podchecker: Two files still produce a warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:42:44 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #49 from Kyle M Hall --- Created attachment 37953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37953&action=edit [PASSED QA] Bug 10480: Follow-up for unimarc_field_686a/_700-4.pl This patch fixes the pod errors on those two files by removing the pod section that actually does not add anything useful. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:50:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:50:48 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 --- Comment #22 from Kyle M Hall --- Created attachment 37954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37954&action=edit Bug 11084 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 13:51:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 11:51:03 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 14:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 12:01:33 +0000 Subject: [Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 --- Comment #4 from Kyle M Hall --- Thanks for signing off Mark! For what it's worth I do not believe there is any possible way this patch will affect the fix for bug 13908, I just added it to the test plan for thoroughness. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 14:18:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 12:18:50 +0000 Subject: [Koha-bugs] [Bug 14003] New: SIP2 AF Field return 1 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14003 Bug ID: 14003 Summary: SIP2 AF Field return 1 Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: hblancoca at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When try to checkout an item that have any problem (circulation rules, item block or other) appears 1 and no the circulation, patron or item message. Any idea; here is the output for SIP log OUTPUT MSG: '120NUN20150415 120425 AOBIBARA AO = FID_INST_ID AA79736535 AA = FID_PATRON_ID AB100093734 AB = FID_ITEM_ID AJThe Oxford Handbook on the United Nations AJ = FID_TITLE_ID AH AH = FID_DUE_DATE AF1 AF = FID_SCREEN_MSG BLY BL = FID_HOLD_TYPE AY1AZDE35 AY = FID_SEQNO my koha version is 3.08.06.000 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 14:19:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 12:19:56 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 --- Comment #4 from Jonathan Druart --- Created attachment 37955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37955&action=edit [ALTERNATIVE PATCH] Bug 10423: Prevent race condition on printing a ReserveSlip The problem has been well described by Kyle and Nicole on bug 7255 description and comment 1. With this counter patch, I suggest to popup AFTER the return has been confirmed. This will remove the race condition and avoid to pass itemnumber to the pl file as in the patch submitted by Olli. Only the borrowernumber and biblionumber are needed (transfer and op are never used by circ/hold-transfer-slip.pl). Test plan: It is very hard to know all cases (at least 6) where the popup is displayed. Try at least to get the hold and the transfer confirmation messages. You should get the popup if you click on "print slip" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 14:20:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 12:20:53 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 14:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 12:21:39 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 14:21:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 12:21:42 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 --- Comment #8 from Jonathan Druart --- Created attachment 37956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37956&action=edit [ALTERNATIVE PATCH] Bug 13482: Prevent race condition on printing a ReserveSlip The problem has been well described by Kyle and Nicole on bug 7255 description and comment 1. With this counter patch, I suggest to popup AFTER the return has been confirmed. This will remove the race condition and avoid to pass itemnumber to the pl file as in the patch submitted by Olli. Only the borrowernumber and biblionumber are needed (transfer and op are never used by circ/hold-transfer-slip.pl). Test plan: It is very hard to know all cases (at least 6) where the popup is displayed. Try at least to get the hold and the transfer confirmation messages. You should get the popup if you click on "print slip" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 14:58:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 12:58:49 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 --- Comment #3 from M. Tompsett --- Created attachment 37957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37957&action=edit Bug 13993 - Add tests to confirm 'new' and 'cancelled' This adds 2 tests to t/db_dependent/Acquisition/TransferOrder.t in order to confirm the order's status is properly marked. TEST PLAN --------- 1) Apply this patch only 2) prove -v t/db_dependent/Acquisition/TransferOrder.t -- should fail one test: not marked as 'cancelled'. 3) Apply other patch 4) prove -v t/db_dependent/Acquisition/TransferOrder.t -- should succeed. 5) Run test plan as per initial patch. 6) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 14:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 12:59:20 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37798|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 37958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37958&action=edit Bug 13993 - Transfer order from one vendor to another vendor Previous orderstatus is not changed To Test: 1) Create a vendor for ex: A 2) Create a basket under vendor A 3) Create a order 4) Create a vendor for ex: B 5) Create a basket under vendor B 6) Search vendor A and basket/order 7) Click on Transfer link and choose the vendor and basket in which you want to transfer the order 8) Go to mysql prompt and see previous orderstatus. For ex: mysql> select orderstatus from aqorders where ordernumber = 2; +-------------+ | orderstatus | +-------------+ | cancelled | +-------------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 15:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 13:17:24 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 --- Comment #5 from M. Tompsett --- Created attachment 37959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37959&action=edit Bug 13993 - Correct poorly transferred orders Added Atomic Update to fix poorly transferred orders TEST PLAN --------- 1) Do an order transfer 2) Confirm the bad transfer in sql 3) Apply this patch 4) Run the updatedatabase.pl script 5) Confirm the bad transfer is fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 15:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 13:24:10 +0000 Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in atomicupdates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 15:24:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 13:24:37 +0000 Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in atomicupdates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893 --- Comment #6 from M. de Rooy --- QA: Looking at this one now. Will finish it tomorrow (QA sprint). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 15:28:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 13:28:11 +0000 Subject: [Koha-bugs] [Bug 10355] Second click on modification log misses object parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- (In reply to Katrin Fischer from comment #0) > To reproduce the problem: > > 1) Go to any detail page in staff > 2) Click on the modification log tab > 3) Verify, that the object is prefilled with the records biblionumber and > you can also see it as parameter in the url > 4) Click a second time on modification log to reset your search I am not sure this is still valid, when I am on tools/viewlog.pl, I don't see the "modification log" tab, I see the menu from the tools module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 15:37:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 13:37:14 +0000 Subject: [Koha-bugs] [Bug 10340] deleted orders should not be taken into account for Item count calculation in booksellers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10340 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- The number of items from a canceled order is now displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 15:38:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 13:38:35 +0000 Subject: [Koha-bugs] [Bug 10338] Search history can cause "Out of memory" errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- (In reply to Galen Charlton from comment #1) > This should be fixed by the patch to bug 10657, which replaces Storable with > JSON for serializing the search history. Confirmed, should be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 15:57:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 13:57:05 +0000 Subject: [Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 15:57:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 13:57:08 +0000 Subject: [Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 --- Comment #2 from Jonathan Druart --- Created attachment 37960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37960&action=edit Bug 10299: authority plugin - authority field are reversed If you click the plugin next to an authority field that is already populated it takes the values from the field and puts them in the search in the reverse order. Test plan: 1/ Edit a biblio 2/ Fill the subfield for an authority field (for instance 650$v, 650$x, 650$y, etc.) 3/ Click on the authority plugin Before this patch, the values were concatenated in the reverse order. With this patch, it should not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 15:57:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 13:57:35 +0000 Subject: [Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Thanks for the image, very useful :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 15:57:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 13:57:46 +0000 Subject: [Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:10:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:10:26 +0000 Subject: [Koha-bugs] [Bug 6950] Cannot sort the results of a tag search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6950 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #14 from Jonathan Druart --- *** Bug 10813 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:10:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:10:26 +0000 Subject: [Koha-bugs] [Bug 10813] changing sort on tag results shows more results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 6950 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:18:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:18:31 +0000 Subject: [Koha-bugs] [Bug 10355] Second click on modification log misses object parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355 --- Comment #2 from Katrin Fischer --- Hi Jonathan, I just treid in 3.18.5.1: The trick is, that you need to access it from the detail page of a record, not from the tools start page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:27:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:27:35 +0000 Subject: [Koha-bugs] [Bug 13756] Holds over date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13756 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:30:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:30:10 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 --- Comment #6 from Jonathan Druart --- This patch removes too many lines and introduced a bug. If you come from the biblio detail page and click on "modification log", you should get the circ menu, not the tools menu. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:31:28 +0000 Subject: [Koha-bugs] [Bug 14004] New: Disable intranetuserjs / opacuserjs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 Bug ID: 14004 Summary: Disable intranetuserjs / opacuserjs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be *super* handy if intranetuserjs and/or opacuserjs could be temporarily disabled via a check-box or syspref. Right now, debugging issues in intranetuserjs usuaally starts with copying the contents into a text file, blanking the syspref and re-testing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:32:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:32:43 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 --- Comment #7 from Jonathan Druart --- Created attachment 37961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37961&action=edit Bug 6911: (follow-up) Reintroduce few lines to avoid regression If you come from the biblio detail page and click on "modification log", you should get the circ menu, not the tools menu. Test plan: 1/ Go on a biblio detail page 2/ Click on the "modification log" tab 3/ You should get the modification log page with the circ menu. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:33:13 +0000 Subject: [Koha-bugs] [Bug 14004] Add ability to temporarily disable intranetuserjs / opacuserjs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Disable intranetuserjs / |Add ability to temporarily |opacuserjs |disable intranetuserjs / | |opacuserjs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:33:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:33:31 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #8 from Jonathan Druart --- Quick patch, easy to test. Could I get a quick QA look please? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:33:37 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:33:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:33:44 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:34:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:34:54 +0000 Subject: [Koha-bugs] [Bug 10355] Second click on modification log misses object parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > (In reply to Katrin Fischer from comment #0) > > To reproduce the problem: > > > > 1) Go to any detail page in staff > > 2) Click on the modification log tab > > 3) Verify, that the object is prefilled with the records biblionumber and > > you can also see it as parameter in the url > > 4) Click a second time on modification log to reset your search > > I am not sure this is still valid, when I am on tools/viewlog.pl, I don't > see the "modification log" tab, I see the menu from the tools module. That was a bug, see bug 6911 comment 6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:36:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:36:01 +0000 Subject: [Koha-bugs] [Bug 14005] New: Fix working of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Bug ID: 14005 Summary: Fix working of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It appears that many librarians find the language for the default sort order system preferences ambiguous and confusing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:36:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:36:08 +0000 Subject: [Koha-bugs] [Bug 14005] Fix working of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:37:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:37:41 +0000 Subject: [Koha-bugs] [Bug 14005] Fix working of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:37:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:37:43 +0000 Subject: [Koha-bugs] [Bug 14005] Fix working of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 --- Comment #1 from Kyle M Hall --- Created attachment 37962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37962&action=edit Bug 14005 - Fix working of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder It appears that many librarians find the language for the default sort order system preferences ambiguous and confusing. Test Plan: 1) Apply this patch 2) View the system preferences previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder 3) Verify the new language is sensible and describes each sort order correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:37:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:37:57 +0000 Subject: [Koha-bugs] [Bug 14005] Fix wording of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix working of |Fix wording of |previousIssuesDefaultSortOr |previousIssuesDefaultSortOr |der and |der and |todaysIssuesDefaultSortOrde |todaysIssuesDefaultSortOrde |r |r -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:38:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:38:21 +0000 Subject: [Koha-bugs] [Bug 14005] Fix wording of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37962|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 37963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37963&action=edit Bug 14005 - Fix wording of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder It appears that many librarians find the language for the default sort order system preferences ambiguous and confusing. Test Plan: 1) Apply this patch 2) View the system preferences previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder 3) Verify the new language is sensible and describes each sort order correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:41:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:41:10 +0000 Subject: [Koha-bugs] [Bug 10355] Second click on modification log misses object parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:41:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:41:13 +0000 Subject: [Koha-bugs] [Bug 10355] Second click on modification log misses object parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355 --- Comment #4 from Jonathan Druart --- Created attachment 37964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37964&action=edit Bug 10355: paramater 'object' lost on the road Test plan: 1) Go to any detail page in staff 2) Click on the modification log tab 3) Verify, that the object is prefilled with the records biblionumber and you can also see it as parameter in the url 4) Click a second time on modification log to reset your search Before this patch, the object parameter was empty. It now contains the value of the biblionumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:42:01 +0000 Subject: [Koha-bugs] [Bug 10355] Second click on modification log misses object parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6911 Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- It depends on the fix I submitted on bug 6911 comment 7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:42:01 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10355 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:44:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:44:30 +0000 Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 rgravel at marlboro.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rgravel at marlboro.edu --- Comment #6 from rgravel at marlboro.edu --- I think that sounds like a great idea, Nick. One thing to keep in mind is that the second indicator isn't *always* coded; occasionally it's left blank and the type of other title isn't specified. So, I suspect you'd have to tell the xslt what to do in that case. (In reply to Nick Clemens from comment #3) > Outside the scope of this change, but if I had my druthers: > > 246 2nd indicator specifies type of other title, would be nice to display > that when 1st indicator 1. Probab;y it would go into brackets like relator > terms and would be overridden by subfield i > > That out of the way, works as described and will sign off momentarily -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:53:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:53:52 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37906|0 |1 is obsolete| | --- Comment #18 from Chris Nighswonger --- Created attachment 37965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37965&action=edit [SIGNED OFF] Bug 13876: [QA Follow-up] Resolve updatedatabase logfile issues This patch removes the test on write permissions of the logdir. It uses File::Temp to generate a file in the logdir or otherwise in a system tmp dir. This resolves issues with both write permissions as well as SELinux denials. Note that after generating an empty file, we are appending to it in the system statement. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Amended: only use File::Temp in the fallback case. Do not add the four character suffix in the first attempt. Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:54:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:54:55 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37094|0 |1 is obsolete| | --- Comment #19 from Chris Nighswonger --- Created attachment 37966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37966&action=edit [SIGNED-OFF] Bug 13876: Fallback to /tmp if logdir is not writable If the logdir directory is not writable by the koha user, the installer should not explode. This patch uses a temporary directory as a fallback. That means that the history won't be kept. Test plan: 0/ Generate an update (modify updatedatabase.pl and kohaversion) 1/ Make sure the permission are not correct on $logdir 2/ Go on the interface and execute the update entry. 3/ Confirm that the log has been created in a temporaty directory. Retry with correct permissions and confirm the log will be created in $logdir. Signed-off-by: Marcel de Rooy Adding a follow-up for completely resolving encountered issues. Signed-off-by: Katrin Fischer Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:59:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:59:13 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 16:59:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 14:59:16 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #3 from Jonathan Druart --- Created attachment 37967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37967&action=edit Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:00:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:00:20 +0000 Subject: [Koha-bugs] [Bug 13434] 586 XSLT improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 rgravel at marlboro.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rgravel at marlboro.edu --- Comment #6 from rgravel at marlboro.edu --- Regarding 1: That sounds right to me, Nick. The redundancy of the contents and summary notes, for instance, drives me a little crazy personally, and so anything to avoid that appeals to me! I am in favor of leaving it only in the details and not in the notes tab. Regarding 2: I'm no expert on display constants, but I think these are for card/shelf-list printing, so I don't think that distinguishing ## from #8 is necessary, as they are all awards and the cataloger cannot supply a different label anyway. (In reply to Nick Clemens from comment #4) > Separation and display look good so signing off, but I have some questions > that I am leaving for QA: > > 1 - Before this patch the awards displayed in the description tab only on > staff-client, and both in detail view and description tab on opac. I am > thinking if we are going to display on the details page we should remove > from description tab on both staff/opac - maybe out of scope. > > 2 - indicator 1 is supposed to control generation of display content > "Awards:" (display if blank, dont if =8) and it does if all =8, but with > multiple fields and a mix of =8 or =# you always get the "Awards:" I don't > know if it would be worth splitting them into two display sections based on > the indicator or if it isn't a big deal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:01:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:01:07 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Patch complexity|--- |Trivial patch --- Comment #4 from Jonathan Druart --- QA: I already used the message trick in some other bugs: bug 10363, bug 10855, bug 11023 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:03:29 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #33 from rgravel at marlboro.edu --- With our systems librarian on leave, I'm not able to do a done of patch testing, but I wonder: Are multiple relator terms displaying with the patch, like in the below example? Thanks! Contributor(s): Nolan, Christopher, 1970? [film producer, screenwriter, director] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:09:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:09:20 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37961|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 37968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37968&action=edit [PASSED QA] Bug 6911: (follow-up) Reintroduce few lines to avoid regression If you come from the biblio detail page and click on "modification log", you should get the circ menu, not the tools menu. Test plan: 1/ Go on a biblio detail page 2/ Click on the "modification log" tab 3/ You should get the modification log page with the circ menu. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:09:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:09:18 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:26:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:26:38 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:26:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:26:40 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #1 from Jonathan Druart --- Created attachment 37969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37969&action=edit Bug 10706: Search reports by id This patch adds the ability to search reports by their id. Test plan: 1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved) 2/ Search for a report id (refer to the ID column in the table) 3/ The result should be consistent That the filters are not kept, already existed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:27:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:27:10 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:33:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:33:28 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Kyle M Hall --- This patch fixes the mangled display. With the patch, you will still see the lost status. See this screenshot: http://content.screencast.com/users/kylemhall/folders/Jing/media/891a082f-1c71-4207-b01c-44b27b465fd8/00000017.png (In reply to Katrin Fischer from comment #7) > I am not sure I understand this correctly. > > 1) With and without the patch my staff result list for the checked out item > with lost status = 1 looks the same: > > 2 items, 1 available: > > Books Midway Book Cart (1) > Books > > 1 on loan: > > Computer Files Midway Book Cart (1) date due: 11/01/2015 > Computer Files > > > Should we not include the information that the item is lost somehow? > > Please take a look and explain! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:43:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:43:46 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #3 from Kyle M Hall --- (In reply to Owen Leonard from comment #2) > This is an interesting bug... I had no idea this arbitrary limitation was in > the code. Note the associated FIXME: > > # A couple heuristics to limit how many times > # we query the database for item transfer information, sacrificing > # accuracy in some cases for speed; > # > # 1. don't query if item has one of the other statuses > # 2. don't check transit status if the bib has > # more than 20 items > # > # FIXME: to avoid having the query the database like this, and to make > # the in transit status count as unavailable for search limiting, > # should map transit status to record indexed in Zebra. > > The problem with both the old way and the patched version of things is that > something is happening which the user doesn't know anything about. You can > pick an arbitrarily high number for > MaxSearchResultsItemsPerRecordStatusCheck (that's a mouthful!) and rest > assured that no inaccurate information will be displayed or you can set it > to something else and take your chances. > > How does the librarian administrator know what value of > MaxSearchResultsItemsPerRecordStatusCheck is reasonable? > > I'm interested in hearing why the solution proposed in the FIXME isn't the > one which has been implemented. > > If the Zebra solution is not a good one, I think a better solution to this > might just be to add a note which tells the user to click through to the > detail page for accurate status information. I don't think that would be a satisfactory solution for many librarians. The zebra fix is also limited. This problem isn't just inherent in the transit status, but also the lost status ( and probably the not for loan status and who knows what else ). I think the most correct solution would be to remove the limit altogether, but in the interest of those libraries that would prefer speed over accuracy, I made the limit controllable via a system preference instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:48:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:48:45 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31978|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 37970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37970&action=edit Bug 13022 - Hardcoded limit causes records with more than 20 items to show inaccurate statuses If a record has more than 20 items, all the items over 20 will show as available on the search results even if they are not! This is a hard coded limit in the Search module. This number should be configurable. Test Plan: 1) Create a record with more than 20 items 2) Set all the items to waiting holds or in transit 3) Search for results that will include that item 4) Note some say they are available even though they are not 5) Apply this patch 6) Run updatedatabase.pl 7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck to a number larger than the number of items on your record 8) Re-run the search 9) Note that the hold and transit statuses for the items are now correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:52:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:52:27 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37970|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 37971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37971&action=edit Bug 13022 - Hardcoded limit causes records with more than 20 items to show inaccurate statuses If a record has more than 20 items, all the items over 20 will show as available on the search results even if they are not! This is a hard coded limit in the Search module. This number should be configurable. Test Plan: 1) Create a record with more than 20 items 2) Set all the items to waiting holds or in transit 3) Search for results that will include that item 4) Note some say they are available even though they are not 5) Apply this patch 6) Run updatedatabase.pl 7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck to a number larger than the number of items on your record 8) Re-run the search 9) Note that the hold and transit statuses for the items are now correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 17:57:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 15:57:30 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #13 from Blou --- Created attachment 37972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37972&action=edit Bug 11299 - cleaning up warnings/errors appearing in automatic_linker.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:01:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:01:06 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33616|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 37973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37973&action=edit Bug 13265 - Still too many search cursor cookies We have multiple sites that are still exhibiting bug 11369. For whatever reason, the cookies on these sites are larger and thus the maximum of 10 is still too large. This setting should be controlled by a system preference to the number can be tailored on a per-site basis. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference MaxSearchCookies to a high number ( e.g. 20 ). 4) Perform searches until you get the error described in bug 11369 5) Delete your cookies so you can use the staff intranet again 5) Set the system preference to a much lower number ( e.g. 5 ) 6) Repeat setp 4, you should no longer get the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:01:04 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:03:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:03:13 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37918|0 |1 is obsolete| | --- Comment #4 from Blou --- Created attachment 37974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37974&action=edit Bug 11300 - Add a Z39.50 Linker that searches for authority links in the specified Z39.50 server This patch depends on code added in Bug 11299, and must be applied after it. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) This patch adds a Z39.50 Linker which searches for authority links on a remote server. If a matching authority is found, it's imported in the local database for linking with the current biblio record. If no matching authority was found on the remote server, the Linker falls back to a local authority search. Configuration : * The option "Z39.50 Server" is added to the LinkerModule preference. You must choose this to use the new Linker. * The preference LinkerZ3950Server is required and specifies which server to use for linking. It must contain the "name" of the server, as defined in the z3950servers table. * You can set the "local_first" option in the LinkerOptions preference to force the Linker to search for authorities in the local database first. If no local authority match was found, the Linker falls back to a remote Z39.50 search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:03:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:03:30 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #5 from Blou --- Created attachment 37975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37975&action=edit Bug 11300 - correcting table z3950servers now uses 'servername' instead of 'name' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:04:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:04:23 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #6 from Blou --- Rebased over 11299, and small fixes added in new patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:12:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:12:09 +0000 Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 --- Comment #2 from Chris Nighswonger --- Created attachment 37976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37976&action=edit Bug 10222 - Error when saving Demco label templates This patch fixes a bug whereby if you open either of the Demco label templates (loaded by the sample data) and click "save" without making any changes you will get an error: Can't bless non-reference value at C4/Creators/Profile.pm line 92. It also fixes another minor bug in the creator sample data. To test: 1. Install all sample data in a clean database. 2. In the label tool, edit either of the Demco label templates. 3. Save the template and observe the error mentioned above. 4. Drop and recreate the database. 5. Apply the patch. 6. Repeate steps 1-3 and note the successful save. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:12:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:12:25 +0000 Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:34:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:34:51 +0000 Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 --- Comment #7 from Winona Salesky --- Should this become a new issue? -Winona (In reply to rgravel from comment #6) > I think that sounds like a great idea, Nick. > > One thing to keep in mind is that the second indicator isn't *always* coded; > occasionally it's left blank and the type of other title isn't specified. > So, I suspect you'd have to tell the xslt what to do in that case. > > (In reply to Nick Clemens from comment #3) > > Outside the scope of this change, but if I had my druthers: > > > > 246 2nd indicator specifies type of other title, would be nice to display > > that when 1st indicator 1. Probab;y it would go into brackets like relator > > terms and would be overridden by subfield i > > > > That out of the way, works as described and will sign off momentarily -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:47:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:47:24 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:48:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:48:56 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 --- Comment #9 from rgravel at marlboro.edu --- We didn't originally include them because we didn't think they were often used, but it's a valid point: if they are actually there, then you'd want to see them. So, I'm for displaying all subfields associated with these fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:50:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:50:52 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37957|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 37977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37977&action=edit Bug 13993 - (1) Add tests to confirm 'new' and 'cancelled' This adds 2 tests to t/db_dependent/Acquisition/TransferOrder.t in order to confirm the order's status is properly marked. TEST PLAN --------- 1) Log into staff client 2) Acquisitions 3) Create a basket for two differing vendors. 4) Place an order in one of the baskets. 5) Transfer the order from one vendor's basket to the others. 6) Apply this patch (1) only 7) prove -v t/db_dependent/Acquisition/TransferOrder.t -- should fail one test: not marked as 'cancelled'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:51:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:51:05 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37959|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 37978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37978&action=edit Bug 13993 - (2) Correct poorly transferred orders Added Atomic Update to fix poorly transferred orders TEST PLAN --------- 8) Apply patch (2) 9) Run the database updates $ ./installer/data/mysql/updatedatabase.pl -- This should run without error 10) prove -v t/db_dependent/Acquisition/TransferOrder.t -- This should succeed now, because the update fixed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:51:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:51:18 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37958|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 37979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37979&action=edit Bug 13993 - (3) Transfer order leaves incorrect orderstatus 11) Apply patch (3) 12) Log in to staff client 13) Acquisitions 14) Create a basket for two different vendors 15) Place an order in one vendor's basket. 16) Transfer the order to the other vendor's basket. 17) prove -v t/db_dependent/Acquisition/TransferOrder.t -- This should succeed without intervention. 18) Run koha qa test tools for the last 3 commits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:54:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:54:39 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 --- Comment #9 from rgravel at marlboro.edu --- Ideally, they should behave like subject headings and be clickable, too. (In reply to Nick Clemens from comment #6) > 2 - When displaying as Genre/Form the headings are not linked for searching, > I think they should still be clickable. This is just my opinion though, > willing to concede ts one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 18:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 16:55:35 +0000 Subject: [Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 37980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37980&action=edit Bug 13991: (QA followup) uninitialized value and [0] in /tools/viewlog.pl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:02:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:02:49 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:05:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:05:54 +0000 Subject: [Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- Test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:17:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:17:56 +0000 Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 --- Comment #8 from rgravel at marlboro.edu --- If it's not easy to incorporate into these changes and if Nicole thinks this is something we can tackle later, then I'd say no. I'm about to put in a ticket to explore a development for dynamic display of 264s, which would similarly read the second indicator and change the label; these two things seem very related, so I can add this to the ticket to see if they might be better handled together. (In reply to Winona Salesky from comment #7) > Should this become a new issue? > > -Winona -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:22:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:22:24 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- QA followup pushed. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:22:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:22:50 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:23:15 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Enhancement pushed. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:23:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:23:42 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:24:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:24:03 +0000 Subject: [Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:24:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:24:27 +0000 Subject: [Koha-bugs] [Bug 13803] SelfCheck not setting flag when item requires transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13803 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:24:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:24:59 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #243 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Chris! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:25:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:25:04 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37919|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:25:14 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:33:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:33:12 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37445|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 37981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37981&action=edit Bug 13948 - Add ability to dump template toolkit variables to html comment It would be incredibly helpful if we could easily enable Koha to dump all Template Toolkit variables to a comment for debugging purposes. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Enable the new system preferences DumpTemplateVarsIntranet and DumpTemplateVarsOpac 4) Load a page in the staff intranet, view the html source 5) Note the template toolkit variables are embedded in an html comment 6) Load a page in the opac, view the html source 7) Note the template toolkit variable are embedded in an html comment NOTE: I had to cpan2deb Template::Plugin::Stash to test. This is not optimal. Additionally: http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html does not contain Stash. I suspect this was how it was introduced initially by TT. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 19:35:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 17:35:27 +0000 Subject: [Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett --- If what I wrote in my comment is true, then I would fail this. But since I don't have the time to check, I'm signing off, in hopes that QA will have time to confirm one way or another. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 20:09:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 18:09:15 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 20:09:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 18:09:17 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37228|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall --- Created attachment 37982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37982&action=edit [PASSED QA] Bug 13381 - RDA: 245 field changes in XSLT This patch updates the display of the title and statement of responsibility in the XSLT display in the staff and OPAC. Display includes subfields a,b,c,h,k,n,p,s Subfield c is wrapped in a span class=title_resp_stmt for easy suppression via css. Subfield h is wrapped in a span class=title_medium for easy suppression via css. To test: * Search the opac * Click the title * Make sure the fields display properly * Repeat for a few more titles * Repeat in the Staff Client Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 20:27:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 18:27:50 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #50 from Tom?s Cohen Arazi --- Created attachment 37983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37983&action=edit Bug 10480: (QA followup) hide the EXAMPLE.pl plugin The EXAMPLE.pl plugin remains on the source tree for documentation purposes only, and shouldn't be listed when editing both biblio and authority cataloguing frameworks. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 20:29:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 18:29:57 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 20:30:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 18:30:00 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37640|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 37984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37984&action=edit [SIGNED OFF] Bug 10020: Remove DB table and fields related to ethnicity This patch remove the ethnicity table and the ethnicity and ethnotes fields from the 3 tables: borrowers, deletedborrowers and borrower_modifications IF no data exist. Test plan: 0/ Apply this patch and update the Koha::Schema (misc/devel/update_dbix_class_files.pl). 1/ Make sure the ethnicity has at least 1 entry 2/ Launch the updatedb entry and confirm you get a warning message and the DB structure is not updated. 3/ truncate the ethnicity table and fill ethnicity (or ethnotes) for at least 1 row of the borrowers table. 4/ Launch the updatedb entry and confirm you get a warning message and the DB structure is not updated. 5/ Make sure the ethnicity table is empty as well as the ethniciy and the ethnotes fields of borrowers, deletedborrowers and borrower_modifications 6/ Launch the updatedb entry and confirm you don't get the warning message and the DB structure is updated (ie. table and fields dropped). Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 20:30:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 18:30:10 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37641|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 37985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37985&action=edit [SIGNED OFF] Bug 10020: Remove code related to ethnicity This is a(nother) vestige of Koha (2.2?). This patch removes unused code related to the 'ethnicity'. In detail: There is no way to fill the ethnicity table. There is no way to fill the borrowers.ethnicity and borrowers.ethnotes. BUT if borrowers.ethnicity exists, the value is displayed on members/moremember.pl (and only here). Test plan: Apply this patch and confirm there is no regression on adding/updating/deleting patrons. Note that you don't see the ethnicity value on the moremember.pl page even if a patron has it. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 20:37:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 18:37:22 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #51 from Tom?s Cohen Arazi --- Enhancement pushed to master. Great work Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:06:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:06:04 +0000 Subject: [Koha-bugs] [Bug 13756] Holds over date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13756 --- Comment #1 from Christopher Brannon --- Another benefit of going this route is that it will lend itself to more flexibility down the road, if for example, the holds over date (the ReservesMaxPickUpDelay which should be renamed to HoldsOver) is set for each library in the circulation rules rather than a global setting. This one is my 3 cents, making an even nickel. :) Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:13:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:13:37 +0000 Subject: [Koha-bugs] [Bug 14006] New: about.pl checks the wrongzebra index mode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 Bug ID: 14006 Summary: about.pl checks the wrongzebra index mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org about.pl has these lines: 104 if ( (C4::Context->config('zebra_bib_index_mode') eq 'dom') && ($context->{'server'}->{'biblioserver'}->{'config'} !~ /zebra-biblios-dom.cfg/) ) { 105 push @xml_config_warnings, { 106 error => 'zebra_bib_index_mode_mismatch_warn' 107 }; 108 } 109 110 if ( (C4::Context->config('zebra_auth_index_mode') eq 'grs1') && ($context->{'server'}->{'biblioserver'}->{'config'} =~ /zebra-biblios-dom.cfg/) ) { 111 push @xml_config_warnings, { 112 error => 'zebra_bib_index_mode_mismatch_warn' 113 }; 114 } I think line 110 should be looking at C4::Context->config('zebra_*bib*_index_mode'), not C4::Context->config('zebra_auth_index_mode')? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:15:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:15:03 +0000 Subject: [Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|about.pl checks the |about.pl checks the wrong |wrongzebra index mode |zebra index mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:19:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:19:11 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7673 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:19:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:19:11 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12176 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:21:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:21:07 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #13 from M. Tompsett --- Make sure that bug 7673 is not regressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:23:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:23:41 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:23:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:23:43 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36918|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 37986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37986&action=edit [SIGNED OFF] Added 655 display to OPAC and staff full views. This patch field 655 to the full displays in the staff and OPAC views. Multiple 655 fields are separated with a span class=separator | . To test: * Search the opac for records with genre/field 655 * Click the title * Make sure the fields display properly * Repeat for a few more titles * Repeat in the Staff Client http://bugs.koha-community.org/show_bug.cgi?id=13433 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:23:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:23:52 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37937|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 37987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37987&action=edit [SIGNED OFF] Bug 13433 - 655 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field that would show the record in the search results 5) Note this patch adds field 655 to display. Displays subfields a,v,x,y,z. uses a vertical bar to separate multiple titles. Vertical bar is wrapped in span class="separator" for easy suppression/customization of separator. 6) Repeat steps 4 and 5 for the staff interface Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:33:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:33:43 +0000 Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |nick at quecheelibrary.org --- Comment #5 from Nick Clemens --- Is tis still valid on master? I can't recreate, could use a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 21:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 19:51:28 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #52 from M. de Rooy --- (In reply to Tom?s Cohen Arazi from comment #51) > Enhancement pushed to master. And thanks for your follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 22:00:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 20:00:10 +0000 Subject: [Koha-bugs] [Bug 14005] Fix wording of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se --- Comment #3 from Andreas Hedstr?m Mace --- Unfortunately I think that the new language used is more confusing. Especially previousIssuesDefaultSortOrder. For me "due most recently" and "due earliest" is pretty much the same thing. Also todaysIssuesDefaultSortOrder's second option states to sort from "first item checked out today to latest checked item out" due date. Shouldn't it read "...latest checked out item"? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 22:14:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 20:14:49 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 22:14:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 20:14:51 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37969|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 37988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37988&action=edit Bug 10706: Search reports by id This patch adds the ability to search reports by their id. Test plan: 1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved) 2/ Search for a report id (refer to the ID column in the table) 3/ The result should be consistent That the filters are not kept, already existed. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 22:17:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 20:17:58 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #7 from Blou --- Created attachment 37989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37989&action=edit Bug 11300 - Add update_cache method to C4::Linker::Z3950Server to match definition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 22:18:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 20:18:34 +0000 Subject: [Koha-bugs] [Bug 14005] Fix wording of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 22:38:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 20:38:24 +0000 Subject: [Koha-bugs] [Bug 5704] bib level item type icon should display on search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5704 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 23:15:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 21:15:16 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 23:15:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 21:15:19 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37899|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 37990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37990&action=edit [SIGNED OFF] Bug 10172: Hide some uneeded stuffs on printing a record When printing a record from the OPAC or the staff interface, some uneeded blocks are displayed. OPAC: 1/ Browse results 2/ The view tags (Normal, MARC, ISBD) Intranet: 1/ Marc view link 2/ The Please upload one image link Test plan: On a record detail page (staff and OPAC), print the page and confirm these blocks no longer appear. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 23:30:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 21:30:11 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 23:30:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 21:30:13 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37967|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 37991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37991&action=edit Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. Signed-off-by: Mark Tompsett NOTE: Love the simplicity and ability to expand. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 23:32:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 21:32:24 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Nick Clemens --- Applying: Bug 9805 - Lost items are un-lost if returned, but not if renewed. Applying: Bug 9805 [QA Followup] - Control renewing and finding of list items via circ rules fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9805 [QA Followup] - Control renewing and finding of list items via circ rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 23:57:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 21:57:22 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 16 23:57:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 21:57:25 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37946|0 |1 is obsolete| | --- Comment #31 from Nick Clemens --- Created attachment 37992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37992&action=edit [SIGNED OFF] Bug 12847: Items issued today is considered as overdue The date comparisons in C4::Members::IssueSlip does not work as expected. Is an item is issue yesterday and due today (23:59), it should not be considered as an overdue yet. Test plan: Define a valid issue slip (code ISSUESLIP) Check 2 items out and update the issuedate value for one of them as yesterday (using the mariadb/mysql cli or similar) Print the slip Before this patch the item marked as issued yesterday is considered as overdue. Special cases: - hourly loans - Quick slip is impacted too Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 01:05:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 Apr 2015 23:05:37 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 --- Comment #8 from Barton Chittenden --- The double-quoted "ccode" URLs are being passed to the search results page /cgi-bin/koha/catalogue/detail.pl and breaking the "Return to results" link on that page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 04:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 02:54:12 +0000 Subject: [Koha-bugs] [Bug 14007] New: Item Types for items hidden by OpacHiddenItems turn up in facet results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 Bug ID: 14007 Summary: Item Types for items hidden by OpacHiddenItems turn up in facet results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org An example of this bug: Library has hidden item type "password" from the OPAC. Library does a search for a publication for which they have a password. On the OPAC - the record is hidden, but the item type facet contains the item type of "Password" even though the item itself is hidden. Clicking the facet brings back no results. We've already hidden them on the Advanced search in bug 12330, it would be good to tidy this up as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 07:55:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 05:55:53 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 07:55:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 05:55:56 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37938|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 37993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37993&action=edit [PASSED QA] Bug 9878: Add consistentcy on restriction messages Between both pages circ/circulation.pl and members/moremember.pl, the restriction messages should be the same. Test plan: 1/ Add a non-unlimited restrictions to a patron 2/ Go on both pages and confirm the restriction message is the same. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 08:07:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 06:07:09 +0000 Subject: [Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 08:07:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 06:07:12 +0000 Subject: [Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37673|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 37994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37994&action=edit [PASSED QA] Bug 10011: Save branch limitations on creating a new patron category The code was just badly placed. It should be executed on update but also on insert. Test plan: 1/ Create a new patron category and select 1+ branch limitations 2/ Confirm it's correctly saved 3/ Edit it and change the branch limitations 4/ Confirm it's correctly saved Signed-off-by: Mark Tompsett NOTE: Not a C4 or Koha library, so tests not required. Though, this code could be cleaned up and have the DB stuff put into some sort of library with tests to prevent regression. However, that dream is beyond the scope of this bug. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 08:09:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 06:09:44 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37405|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 08:16:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 06:16:11 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 08:16:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 06:16:14 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37405|0 |1 is obsolete| | Attachment #37804|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 37995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37995&action=edit [PASSED QA] Bug 8399: No need to truncate the marc field text to 22 chars The text for the marc field are truncated to 22 chars when displaying an error on mandatory fields. This limitation is useless and this patch removes it. Test plan: Create a mandatory subfield and set a long text (more than 22 chars) edit or add an authority, click on save. You should get the error displayed with the full text Note that this patch modifies the same code for biblio. Test plan is the same for biblio. Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 08:16:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 06:16:27 +0000 Subject: [Koha-bugs] [Bug 8399] Problems with mandatory field alert message for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #12 from Katrin Fischer --- Created attachment 37996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37996&action=edit [PASSED QA] Bug 8399: Display tab number on the mandatory field alert (authority) A wrong variable scope was used here, the number value is contained in the BIG_LOOP (note for later: change this variable name...). Test plan: 1/ Define 1+ mandatory fields for an authority type 2/ Create an authority and don't fill the mandatory fields 3/ Try to save: the popup alert should display the number of the tab. Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 08:21:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 06:21:18 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- I really like that you have the right search now open on pressing enter, but I think the possibility to enter the vendor number or record number directly is kind of a feature, so we should not remove that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 08:51:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 06:51:55 +0000 Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in atomicupdates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 08:51:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 06:51:57 +0000 Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in atomicupdates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37120|0 |1 is obsolete| | Attachment #37389|0 |1 is obsolete| | --- Comment #7 from M. de Rooy --- Created attachment 37997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37997&action=edit Bug 13893 - Add ability to execute perl scripts in atomicupdates Bug 13068 adds the ability to execute sql files from atomicupdates for in process developments to reduce merge conflicts. We need to extend this ability further to be able to handle perl code. Revised Test Plan ----------------- 1) Run updatedatabase.pl -- Expect output to be similar to: $ ./installer/data/mysql/updatedatabase.pl DEV atomic update : test.perl Upgrade to XXX done (Bug 13893 - Add ability to execute perl scripts in atomicupdates) 2) Run koha qa test tools. -- only need to check last commit (-c 1), because first commit is a sample file which shouldn't be pushed. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 08:52:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 06:52:02 +0000 Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in atomicupdates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893 --- Comment #8 from M. de Rooy --- Created attachment 37998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37998&action=edit Bug 13893: [QA Follow-up] Move print statement, sort files in loop Just moving the print statement for DEV updates to show them too for the new perl format. In the loop opendir..readdir is used; this might not be always in the expected order. I added a sort to force the order. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:09:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:09:39 +0000 Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in atomicupdates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893 --- Comment #9 from M. de Rooy --- QA Comment: Looks good to me. Added a small follow-up. Note that (as mentioned earlier) I would also accept .pl as the extension for the perl snippets. But that is somewhat arbitrary. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:11:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:11:46 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 --- Comment #20 from M. de Rooy --- Created attachment 37999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37999&action=edit Bug 13876: [QA Follow-up] Resolve updatedatabase logfile issues This patch removes the test on write permissions of the logdir. It uses File::Temp to generate a file in the logdir or otherwise in a system tmp dir. This resolves issues with both write permissions as well as SELinux denials. Note that after generating an empty file, we are appending to it in the system statement. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Amended: only use File::Temp in the fallback case. Do not add the four character suffix in the first attempt. Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:13:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:13:10 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 --- Comment #21 from M. de Rooy --- Reordered the patches. Katrin: did you forget to sign the second one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:17:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:17:22 +0000 Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in atomicupdates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:17:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:17:38 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 --- Comment #22 from Katrin Fischer --- Hm I probably intended to sign off the second, but wanted to have someone else to have another look at it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:21:27 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |m.de.rooy at rijksmuseum.nl --- Comment #42 from M. de Rooy --- Switching this back to Needs Signoff, looking at the discussion in the last comments and the addition of the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:23:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:23:43 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37965|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:31:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:31:32 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #67 from M. de Rooy --- tcohen: could you please update your comments on bug 11592 as related to bug 12252 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:34:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:34:43 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:52:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:52:28 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 --- Comment #23 from Jonathan Druart --- Created attachment 38000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38000&action=edit Bug 13876: Fallback to /tmp if logdir is not writable If the logdir directory is not writable by the koha user, the installer should not explode. This patch uses a temporary directory as a fallback. That means that the history won't be kept. Test plan: 0/ Generate an update (modify updatedatabase.pl and kohaversion) 1/ Make sure the permission are not correct on $logdir 2/ Go on the interface and execute the update entry. 3/ Confirm that the log has been created in a temporaty directory. Retry with correct permissions and confirm the log will be created in $logdir. Signed-off-by: Marcel de Rooy Adding a follow-up for completely resolving encountered issues. Signed-off-by: Katrin Fischer Signed-off-by: Chris Nighswonger Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:52:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:52:30 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37999|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 38001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38001&action=edit Bug 13876: [QA Follow-up] Resolve updatedatabase logfile issues This patch removes the test on write permissions of the logdir. It uses File::Temp to generate a file in the logdir or otherwise in a system tmp dir. This resolves issues with both write permissions as well as SELinux denials. Note that after generating an empty file, we are appending to it in the system statement. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Amended: only use File::Temp in the fallback case. Do not add the four character suffix in the first attempt. Signed-off-by: Chris Nighswonger Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:52:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:52:33 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 --- Comment #25 from Jonathan Druart --- Created attachment 38002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38002&action=edit Bug 13876: Add the from => to versions in the filenames Additionally to the datetime, it could be useful to have the version numbers in the log filenames. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 09:59:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 07:59:35 +0000 Subject: [Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 --- Comment #7 from Jonathan Druart --- (In reply to M. Tompsett from comment #6) > Test plan? Test plan: 1/ Look at the patch 2/ You will know what you should test 3/ I you don't, test another patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:03:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:03:53 +0000 Subject: [Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:03:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:03:56 +0000 Subject: [Koha-bugs] [Bug 13966] Backport HEA to Koha 3.16 and/or 3.14 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37559|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 38003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38003&action=edit Bug 13966 - Backport HEA to Koha 3.16 and/or 3.14 This trivial patch stops any potential SQL errors/warnings for a HEA enabled 3.16 or 3.14 Koha, when upgrading to a newer Koha Signed-off-by: Jonathan Druart Add the missing prefs unless they exist and don't raise an error if already exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:05:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:05:06 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from M. de Rooy --- > If we don't update the permission: > Can suddenly no longer claim issues from other branches > Woudl also be good to get more opinions about b). In view of the discussion above (including older comments at the top), this patch does not seem to be ready for inclusion yet. I am moving it to FQA for now. Will ask for additional comments on the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:07:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:07:47 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37966|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:13:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:13:41 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38002|0 |1 is obsolete| | --- Comment #26 from M. de Rooy --- Created attachment 38004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38004&action=edit Bug 13876: Add the from => to versions in the filenames Additionally to the datetime, it could be useful to have the version numbers in the log filenames. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:14:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:14:02 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13793 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:14:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:14:02 +0000 Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of the update using Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13876 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:21:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:21:29 +0000 Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for waiting holds on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Signed Off |BLOCKED --- Comment #10 from Jonathan Druart --- This patch is blocked for QA by bug 13851, please reintroduce it in the QA queue when it will be ready. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:23:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:23:23 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:24:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:24:59 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:28:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:28:13 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 --- Comment #5 from Marc V?ron --- Created attachment 38005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38005&action=edit [Signed-off] Bug 10423: Show date due with time if it's a hourly loan On printing the summary from the patron account, the hours are not displayed if needed. The as_date_due flag should be set to display it correctly. Problem, GetPendingIssues modify the value retrieved from the database. In order to not add regression and check all calls to GetPendingIssues, this patch backup the value before the change. Test plan: Check some items out, specify a hourly loan for some. Click on print > print summary and confirm the date due are correctly formatted. Followed test plan. Date + time display as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:28:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:28:32 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37947|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:30:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:30:50 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 --- Comment #38 from Katrin Fischer --- (In reply to Jonathan Druart from comment #36) > Comment on attachment 35312 [details] [review] > [SIGNED OFF] Bug 8438: Followup Set the superserials permission for all > users with the claim_serials permission > > So it is preferable not to update the user permissions and maybe let a note > in the release notes to explain that if they have issues with serial > permissions to check the user permissions. Sounds like the best possible solution to me. Could you take a look if filtering out the issues from other branches would be possible instead of just hiding the claim options? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:31:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:31:39 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #35 from Katrin Fischer --- (In reply to Jonathan Druart from comment #34) > (In reply to Katrin Fischer from comment #33) > > Just wondering: Why not send out the email immediately like the other > > emails, but via a cronjob? > > Because we would like the ability to sent an email for the suggestions not > processed for X days. Ok! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:32:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:32:13 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36276|0 |1 is obsolete| | Attachment #36277|0 |1 is obsolete| | --- Comment #36 from M. de Rooy --- Created attachment 38006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38006&action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:32:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:32:19 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #37 from M. de Rooy --- Created attachment 38007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38007&action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:35:00 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #13 from Jonathan Druart --- It needs QA with bug 11625. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:35:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:35:14 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #38 from M. de Rooy --- Rebased patch 4. Wondering about patch 5 here.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 10:52:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 08:52:49 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:04:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:04:55 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 --- Comment #39 from Katrin Fischer --- After discussing the problem with "seeing issues from other branches" with Jonathan a bit more I think we can keep it like that for now. - You will see them, but you can't claim them. If libraries think this should be more restrictive, please open a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:08:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:08:10 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #3 from Jonathan Druart --- Created attachment 38008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38008&action=edit Bug 10706: Add test I found this test this morning in my working directory, could be useful here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:09:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:09:23 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Patch complexity|Small patch |Medium patch --- Comment #19 from Jonathan Druart --- QA comment: 1/ Please rename the script according to previous change (budget vs fund). 2/ Add basket name in the basket column 3/ Get rid of the warning: FAIL reports/orders_by_budget.pl FAIL valid Possible attempt to put comments in qw() list Possible attempt to separate words with commas The no warnings qw() is not a correct solution (and does not work) 4/ default separator should be chosen (syspref "delimiter") 5/ Add DataTables on the table could be useful and easy. 6/ Both tests fail: t/db_dependent/Budgets.t .. 58/120 DBIx::Class::Row::new(): No such column 'budget_description' on Koha::Schema::Result::Aqbudgetperiod at C4/Budgets.pm line 144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:13:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:13:38 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:13:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:13:42 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:15:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:15:22 +0000 Subject: [Koha-bugs] [Bug 11160] Better message when placing hold at OPAC is blocked In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11160 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:19:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:19:31 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #34 from Jonathan Druart --- Applying: Bug 11625 [QA Followup 3] - Use system preferences to control behavior fatal: sha1 information is lacking or useless (admin/smart-rules.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:20:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:20:22 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #14 from Jonathan Druart --- Bug 11625 does not apply, please also rebase this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:25:30 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |jonathan.druart at biblibre.co | |m Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:28:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:28:06 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:30:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:30:09 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Jonathan Druart --- (In reply to Kyle M Hall from comment #29) > Created attachment 37103 [details] [review] > [SIGNED-OFF] Bug 9468: [COUNTER-PATCH] sample SUGGEST_FORMAT values > To test > ------- > [1] Verify that the new SQL inserts added by this patch work. Yes, it works, but only for English, please add them for others. The change to the opac prog theme should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:47:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:47:07 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #53 from Jonathan Druart --- Comment on attachment 37195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37195 [Signed-off] Bug 13364 - Add a call number browser in item edition page - QA fixed II Review of attachment 37195: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13364&attachment=37195) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt @@ +34,4 @@ >
>
> > + Yes fine, but a previous patch changed the css file and you don't update it here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:47:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:47:33 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #54 from Jonathan Druart --- I will submit a follow-up if it's ready. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:49:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:49:44 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #39 from M. de Rooy --- Created attachment 38009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38009&action=edit Bug 13014: [QA Follow-up] Few typos in cronjob Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:56:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:56:27 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37192|0 |1 is obsolete| | Attachment #37193|0 |1 is obsolete| | Attachment #37194|0 |1 is obsolete| | Attachment #37195|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart --- Created attachment 38010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38010&action=edit Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home ? Administration ? MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (?) beside Full call number input 8) Click in ? Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Magnus Works as advertised. QA scripts pass. Tested together with other patches. Works as expected. Signed-off-by: Marc V?ron Bug 13364 - fix datatables.inc http://bugs.koha-community.org/show_bug.cgi?id=13364 Signed-off-by: Magnus Works as advertised. QA scripts pass. Tested together with other patches, works as expected. Signed-off-by: Marc V?ron Bug 13364 - Add a call number browser in item edition page - QA fixed Tested together with other patches. Signed-off-by: Marc V?ron Bug 13364 - Add a call number browser in item edition page - QA fixed II Tested together with oter patches. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:56:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:56:35 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #56 from Jonathan Druart --- Created attachment 38011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38011&action=edit Bug 13364: Fix table id + software error change table id in css file + C4::Output is used (Undefined subroutine CGI::output_html_with_http_headers) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 11:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 09:57:37 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #57 from Jonathan Druart --- I squashed the 4 patches (add + mv of the file in the same patch set) and perltidy on it. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:02:16 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36272|0 |1 is obsolete| | Attachment #36273|0 |1 is obsolete| | Attachment #36275|0 |1 is obsolete| | Attachment #38006|0 |1 is obsolete| | Attachment #38007|0 |1 is obsolete| | Attachment #38009|0 |1 is obsolete| | --- Comment #40 from M. de Rooy --- Created attachment 38012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38012&action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as "can be treated" if its status is "ASKED". Signed-off-by: Frederic Demians Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:02:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:02:20 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #41 from M. de Rooy --- Created attachment 38013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38013&action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion > TO_PROCESS Others will be added when the patch will be signed off. Signed-off-by: Frederic Demians Followup expected :-) It would be nice also to have an updatabase.pl entry to insert the new TO_PROCESS notification. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:02:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:02:25 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #42 from M. de Rooy --- Created attachment 38014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38014&action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions > TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. Signed-off-by: Frederic Demians Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:02:29 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #43 from M. de Rooy --- Created attachment 38015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38015&action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:02:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:02:33 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #44 from M. de Rooy --- Created attachment 38016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38016&action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Checked by running them manually. English installs 27, Russian 27 and Ukrainian 26. Last language can be updated somewhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:02:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:02:37 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #45 from M. de Rooy --- Created attachment 38017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38017&action=edit Bug 13014: [QA Follow-up] Few typos in cronjob Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:04:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:04:51 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #58 from Jonathan Druart --- Created attachment 38018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38018&action=edit Bug 13364: Remove unused JS functions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:07:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:07:32 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #59 from Jonathan Druart --- Created attachment 38019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38019&action=edit Bug 13364: Use SQL placeholder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:07:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:07:38 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #46 from M. de Rooy --- QA Comment: Code looks good to me. Some small remarks: GetUnprocessedSuggestions misses pod section. notice_unprocessed_suggestions.pl documentation says: =item B<--days> This parameter is mandatory. It must contain an integer representing the number of days elapsed since the last modification of suggestions to process. A further explanation that it only selects suggestion that are exactly x days old should be added. The workflow of sending it after one day and reminding after 7 days with the parameters 1 7 could be clarifying. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:08:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:08:00 +0000 Subject: [Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:11:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:11:38 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #7 from M. de Rooy --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:14:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:14:50 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #8 from M. de Rooy --- CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt CONFLICT (content): Merge conflict in basket/sendbasket.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:16:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:16:36 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37992|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer --- Created attachment 38020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38020&action=edit [PPASSED QA] Bug 12847: Items issued today is considered as overdue The date comparisons in C4::Members::IssueSlip does not work as expected. Is an item is issue yesterday and due today (23:59), it should not be considered as an overdue yet. Test plan: Define a valid issue slip (code ISSUESLIP) Check 2 items out and update the issuedate value for one of them as yesterday (using the mariadb/mysql cli or similar) Print the slip Before this patch the item marked as issued yesterday is considered as overdue. Special cases: - hourly loans - Quick slip is impacted too Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:16:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:16:33 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:17:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:17:31 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #73 from M. de Rooy --- CONFLICT (add/add): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.cookie.min.js Auto-merging koha-tmpl/opac-tmpl/bootstrap/js/basket.js Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:18:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:18:11 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:19:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:19:59 +0000 Subject: [Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #21 from M. de Rooy --- Moving to Blocked. One of the dependencies listed is in FQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:22:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:22:15 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |koha at univ-lyon3.fr QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:27:54 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:27:57 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38000|0 |1 is obsolete| | Attachment #38001|0 |1 is obsolete| | Attachment #38004|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 38021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38021&action=edit [PASSED QA] Bug 13876: Fallback to /tmp if logdir is not writable If the logdir directory is not writable by the koha user, the installer should not explode. This patch uses a temporary directory as a fallback. That means that the history won't be kept. Test plan: 0/ Generate an update (modify updatedatabase.pl and kohaversion) 1/ Make sure the permission are not correct on $logdir 2/ Go on the interface and execute the update entry. 3/ Confirm that the log has been created in a temporaty directory. Retry with correct permissions and confirm the log will be created in $logdir. Signed-off-by: Marcel de Rooy Adding a follow-up for completely resolving encountered issues. Signed-off-by: Katrin Fischer Signed-off-by: Chris Nighswonger Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:28:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:28:07 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 --- Comment #28 from Kyle M Hall --- Created attachment 38022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38022&action=edit [PASSED QA] Bug 13876: [QA Follow-up] Resolve updatedatabase logfile issues This patch removes the test on write permissions of the logdir. It uses File::Temp to generate a file in the logdir or otherwise in a system tmp dir. This resolves issues with both write permissions as well as SELinux denials. Note that after generating an empty file, we are appending to it in the system statement. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Amended: only use File::Temp in the fallback case. Do not add the four character suffix in the first attempt. Signed-off-by: Chris Nighswonger Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:28:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:28:09 +0000 Subject: [Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 --- Comment #29 from Kyle M Hall --- Created attachment 38023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38023&action=edit [PASSED QA] Bug 13876: Add the from => to versions in the filenames Additionally to the datetime, it could be useful to have the version numbers in the log filenames. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:32:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:32:22 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34316|0 |1 is obsolete| | --- Comment #16 from M. de Rooy --- Created attachment 38024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38024&action=edit Bug 13414 - Enable automatic right truncation while searching by relevance This makes slight modification in build_weighted_query function in order to make automatic right truncation possible when QueryWeightFields syspref activated (even little ranked) Modify this syspref type from boolean to choice in order to add this possiblity as a third option : Search by relevance with automatic right truncation. Signed-off-by: kohateam rennes 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:32:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:32:46 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #17 from M. de Rooy --- Just a rebase yet.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:33:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:33:31 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:33:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:33:33 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37941|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 38025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38025&action=edit [PASSED QA] Bug 13998: Reintroduce use of Koha::Database for C4::Ratings It has been removed by bug 13852, because before bug 13852, Koha::Database was used in C4:Members which was used by C4::VirtualShelves which was used by C4::Auth which was finally used by C4::Ratings... Test plan: At the opac, record detail page, note the record using the stars. Without this patch it does not work. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer http://bugs.koha-community.org/show_bug.cgi?id=12998 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:34:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:34:45 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|normal |enhancement QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:37:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:37:15 +0000 Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37006|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 38026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38026&action=edit [PASSED QA] Bug 11165: Automatically save the authority last modification time This patch rename the column auth_header.datemodified with modification_time. Now this column will be automatically updated when a row will be updated. Test plan: 0/ Verify that la major part of your auth_header.datemodified is set to null 1/ Execute the updatedb entry 2/ Verify that the column is renamed and the values have not been changed. 3/ Update an authority and verify (using the sql cli) that this value has been updated. Signed-off-by: Marcel de Rooy In the absence of a coding guideline stipulating a preferred column name for a timestamp, this modification_time works for me. Null values are replaced by current time after db rev; other values are left alone. NOTE FOR RM: Please run update_dbix_class_files.pl. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:37:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:37:13 +0000 Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:44:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:44:33 +0000 Subject: [Koha-bugs] [Bug 13994] Add a back link to error message in Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13994 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:44:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:44:35 +0000 Subject: [Koha-bugs] [Bug 13994] Add a back link to error message in Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13994 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37928|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 38027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38027&action=edit [PASSED QA] Bug 13994 - Add a back link to error message in Reports To reproduce: - Go to Home > Reports - Create from SQL - Do something that results in an error message, e.g. by entering an UPDATE statement Result: You get an error message with title "The follwing error was encountered" But there is now link to go directly back to fix it. To test: - Apply patch - Repeat steps above - Verify that a link appears (and works): "Back to previous page" Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:44:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:44:42 +0000 Subject: [Koha-bugs] [Bug 13994] Add a back link to error message in Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13994 --- Comment #4 from Kyle M Hall --- Created attachment 38028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38028&action=edit Bug 13994 [QA Followup] - Change "Back" to "Return" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:50:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:50:50 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:50:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:50:52 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37727|0 |1 is obsolete| | Attachment #37728|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 38029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38029&action=edit [PASSED QA] Bug 13984 - CardnumberLength missing in sysprefs.sql Test plan : - create a fresh database with installer - check the presence of the syspref : select value from systempreferences where variable like 'CardnumberLength' Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:50:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:50:58 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 --- Comment #5 from Kyle M Hall --- Created attachment 38030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38030&action=edit [PASSED QA] Bug 13984: Add atomic update - Insert pref CardnumberLength if not exists Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:51:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:51:49 +0000 Subject: [Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:54:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:54:59 +0000 Subject: [Koha-bugs] [Bug 13981] Transliterate rule for oe and ae In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:55:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:55:01 +0000 Subject: [Koha-bugs] [Bug 13981] Transliterate rule for oe and ae In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37943|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 38031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38031&action=edit [PASSED QA] Bug 13981 - Transliterate rule for oe and ae NOTE : I use HTML codes for special characters to avoir encoding issues in patch file. In ICU configuration, add a transliterate rule for œ = oe æ = ae Test plan : - Without patch - Create a record R1 with title containing for example "cœur" - Create a record R2 with title containing for example "coeur" - Index those records - Search for "cœur" => You only find R1 - Search for "coeur" => You only find R2 - Apply patch - Restart zebra - Index R1 and R2 - Search for "cœur" => You find R1 and R2 - Search for "coeur" => You find R1 and R2 (Same test plan for ae) ------ Tested with all variants of Ae ae Oe oe. Search worked as expected. Note: The words with special characters were not highlighted, but I think this can be done in an other bug. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:59:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:59:37 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 12:59:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 10:59:40 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36270|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 38032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38032&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email Conflict with bug 13695 fixed. Now it's also possible to send basket/cart using the ISBD format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:07:22 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:07:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:07:26 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36757|0 |1 is obsolete| | --- Comment #74 from Jonathan Druart --- Created attachment 38033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38033&action=edit Bug 10858: Browse selected biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:08:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:08:31 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #9 from Kyle M Hall --- The syspref CronjobLog is created, but is not used. Instead the cronjob logs are always written. I'm not sure if this is a bad thing. However, either then system preference needs to be removed, or utilized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:10:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:10:37 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #40 from Jonathan Druart --- So back in the QA queue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:12:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:12:14 +0000 Subject: [Koha-bugs] [Bug 13975] Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13975 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37676|0 |1 is obsolete| | CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- Created attachment 38034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38034&action=edit Bug 13975: Remove compilation warning about encoding pragma -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:13:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:13:00 +0000 Subject: [Koha-bugs] [Bug 13975] Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13975 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:19:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:19:28 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Signed Off |Patch doesn't apply --- Comment #64 from Jonathan Druart --- Bernardo, This does not longer apply. What is the plan here? I am under the impression we should not lag too much, it will be a pain to maintain this patch set if master moves! Do you generate manually or using a script? What is your confidence level in this patch set? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:22:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:22:25 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:23:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:23:49 +0000 Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in ISSUESLIP and ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:23:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:23:51 +0000 Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in ISSUESLIP and ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37677|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 38035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38035&action=edit [PASSED QA] Add biblioitems to ISSUESLIP and ISSUEQSLIP in C4::Members::IssueSlip() Document all expansions within C4::Members::IssueSlip() http://bugs.koha-community.org/show_bug.cgi?id=13819 Signed-off-by: Frederic Demians - Works as described. ISBN appears on ISSUESLIP & ISSUEQSLIP. Signed-off-by: Kyle M Hall - Not all fields for biblioitems are available, but neither are they all available for other tables. Noted in POD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:23:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:23:58 +0000 Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in ISSUESLIP and ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819 --- Comment #7 from Kyle M Hall --- Created attachment 38036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38036&action=edit Bug 13819 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:32:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:32:29 +0000 Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:32:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:32:31 +0000 Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37675|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 38037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38037&action=edit Bug 13885 - Cataloging search header should include more options This patch adds the check in and standard catalog search to cataloging-search.inc To test: 1 - Apply patch 2 - Go to More->Cataloging 3 - Search in each tab (Cataloging search / Check out / Check in / Standard search) and ensure that all work as expected Signed-off-by: Frederic Demians - Added search options work properly, and are consistently named. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:32:39 +0000 Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 --- Comment #11 from Kyle M Hall --- Created attachment 38038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38038&action=edit Bug 13885 [QA Followup] - Remove tab, remove unnecessary permission check -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:32:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:32:55 +0000 Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38037|0 |1 is obsolete| | Attachment #38038|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 38039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38039&action=edit [PASSED QA] Bug 13885 - Cataloging search header should include more options This patch adds the check in and standard catalog search to cataloging-search.inc To test: 1 - Apply patch 2 - Go to More->Cataloging 3 - Search in each tab (Cataloging search / Check out / Check in / Standard search) and ensure that all work as expected Signed-off-by: Frederic Demians - Added search options work properly, and are consistently named. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:33:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:33:06 +0000 Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 --- Comment #13 from Kyle M Hall --- Created attachment 38040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38040&action=edit [PASSED QA] Bug 13885 [QA Followup] - Remove tab, remove unnecessary permission check Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:37:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:37:31 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 --- Comment #12 from Jonathan Druart --- Bernardo, All looks good but I would like to know what is the plan when it will be pushed into master. Because update/install won't work until the po file is not recreated. Do you plan a big commit? I am wondering if the good idea wouldn't be to wait for the "git repo cleanup" you are doing (have done?) with Chris (see http://lists.koha-community.org/pipermail/koha-devel/2015-March/041293.html). It will avoid the creation and deletion of the same files in a short time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:42:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:42:33 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #41 from M. de Rooy --- (In reply to Jonathan Druart from comment #40) > So back in the QA queue? The permission problem has not been solved? So, I would say: No. We can wait for some responses on the list first btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:42:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:42:39 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:42:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:42:41 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37777|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 38041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38041&action=edit [PASSED QA] Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl To avoid homonyms, it would be nice if the card number is displayed in the user suggestion.pl. Currently, consult the record of the user to know exactly who made the suggestion. TEST PLAN: Apply the patch. Go on suggestion.pl. Check that nothing has changed, except that cardnumbers are displayed in 'Suggested by' column. Resolved an easy conflict while applying. Followed test plan. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:49:17 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #13 from Jonathan Druart --- Note that this patch removes the version number in the filename Introduced by: commit 814795da60318c70059fc1dfbe7be4da37109db0 Author: Fr?d?ric Demians Date: Sun Dec 19 10:57:51 2010 +0100 Bug 5506 Improve translation script And updated only once: commit 69333c9f79bf2cb8ac4e58f46da714dca962a8ee Author: Chris Cormack Date: Sat Oct 22 05:33:40 2011 +1300 Moving po files to 3.6.0 filenames What was the idea behind that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:51:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:51:41 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #29 from Colin Campbell --- NB this is fairly self contained to the emulator should have no effects on other parts of the system - applies cleanly. RM may want to squash these into one patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 13:53:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 11:53:09 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 --- Comment #42 from Jonathan Druart --- To me, there is no permission problem :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:04:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:04:30 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 --- Comment #43 from Katrin Fischer --- I'd vote for: don't mingle with permissions, put a warn that now the behaviour is stricter and you can't claim issues from other branches without the proper permission for doing so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:05:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:05:52 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:05:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:05:54 +0000 Subject: [Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37903|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 38042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38042&action=edit [PASSED QA] Bug 13049: Merge selfreg cron jobs into cleanup_database This patch moves the core code of two selfreg cron jobs into the Members module. The new routines are called from cleanup_database with two new parameters. The old cron jobs are now wrappers to cleanup_database. As a bonus, we can add a unit test now. In time, we can obsolete the selfreg cron jobs. For now, the code is in one place and behavior does not change. A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Test plan: Run the unit test t/db_dependent/Members.t. Test the two new parameters of cleanup_database.pl. Verify if delete_expired_opac_registrations.pl still works. Same for delete_unverified_opac_registrations.pl. Signed-off-by: Frederic Demians . Fixed minor merge confict on UT & cleanup_database.pl . UT ok . The two deprecated scripts still work as before, with a warning message. . cleanup_database.pl do the deletion job, calling new C4::Members function rather that doing it directly. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:16:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:16:26 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Hi Jonathan, unfunnily... this test seems to delete any existing reports in your database (which is why it failed for me the first time and passed the second time I ran it... ) Could you please fix that even if it's a bit scope creeping? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:30:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:30:29 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 --- Comment #18 from Kyle M Hall --- Created attachment 38043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38043&action=edit Bug 7646 [QA Followup] - Tweak button to match other Koha print buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:31:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:31:02 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #5 from Katrin Fischer --- I apologize to the test. It's innocent. But: somehow I manage to make all my reports disappear. Can someone try and confirm? 1) Search for an existing keyword or number = results are ok 2) Search for a non-existing keyword or number = 'no results found' - ok 3) Now click 'used saved' - no reports are showing up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:33:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:33:28 +0000 Subject: [Koha-bugs] [Bug 7646] Printing w/o the SQL Code showing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #19 from Kyle M Hall --- A few issues: 1) Javascript embedded in html. Javascript should be moved outside the html, include the template, and include, or a js file, whichever is best suited. 2) The noprint class is added when clicking the print button, but not removed afterward 3) Only the visible results are printed, but to me the print button implies that it will print all results. If you don't want to go this far, add a tooltip to the print button so it shows "Print visible results" when you hover over it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:35:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:35:30 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:35:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:35:32 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37780|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 38044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38044&action=edit Bug 9139: New subscription form - Does not check form on the first page The vendor and Record input try to sent the form if the focus is on the inputs (normal behavior). But the form is on 2 pages, and the popup message ask you to fill info on the second page when you are on the first one. This does not make sense. This patch suggests to launch search when the enter key is press on these inputs. Test plan: 1/ Create a new subscription 2/ Put the focus in the Vendor input and press enter: the vendor search popup should appear 3/ Put the focus in the Record input and press enter: the record search popup should appear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:35:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:35:47 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:36:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:36:12 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 --- Comment #6 from Jonathan Druart --- The preventDefault was bad placed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:45:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:45:50 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #83 from Fridolin SOMERS --- I test on sandbox 13, I have a conflict on installer/data/mysql/updatedatabase.pl But i solved it manually -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:49:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:49:31 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > I apologize to the test. It's innocent. > > But: somehow I manage to make all my reports disappear. Can someone try and > confirm? > > 1) Search for an existing keyword or number = results are ok > 2) Search for a non-existing keyword or number = 'no results found' - ok > 3) Now click 'used saved' - no reports are showing up Confirmed, but not related to this patch (come from commit 8360343fbc1fb4d8806db951aea8b04ad99d00c1 Date: Wed Apr 6 14:56:45 2011 +1200 Bug 6033 : wr77488 : report selection filter Please open a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:52:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:52:56 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from M. de Rooy --- QA Comment: Thanks for sending your patch. I have been thinking about your patch a while. But in the end it seems to me that we should not be mixing the features ranking and truncation in one syspref. Search.pm is already hard to maintain. A crucial piece of your code: - $weighted_query .= " or wrdl,r9=\"$operand\""; - + } elsif ( $weight_fields == 2 ) { + $weighted_query .= " or wrdl,right-Truncation,r9=\"$operand\""; + } else { + $weighted_query .= " or wrdl,r9=\"$operand\""; Question: Could you think of another way to determine when we want right truncation in the deleted first line? Do we really need an adjusted pref? Since this is a complicated patch (changing Search.pm), I would also like a thorough test plan. There is no test plan now. And I would appreciate to hear from the one who signed off: What did you exactly test? Small stuff: [1] Add type choice in the pref file. [2] There is no print statement in the db rev. Moving this to Failed QA for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:53:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:53:04 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #6 from Ji?? Kozlovsk? --- Created attachment 38045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38045&action=edit Bug 13931 - Fixed Licence & Copyright statements & refactored the code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:53:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:53:51 +0000 Subject: [Koha-bugs] [Bug 14008] New: Saved reports disappear from display Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Bug ID: 14008 Summary: Saved reports disappear from display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To reproduce: - search for a keyword in your reports that exists - search works, correct reports are displayed - search for a keyword in your reports, that doesn't exist - result is correct and a nice message shown - click "use saved" in the navigation to the left to return to your full reports list - nothing is shown, all reports are hiding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:54:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:54:40 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #7 from Jonathan Druart --- Created attachment 38046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38046&action=edit Bug 10706: Delete saved_reports to be sure no reports existed We need to be sure no report existed before launching the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:55:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:55:37 +0000 Subject: [Koha-bugs] [Bug 13931] Date of birth in patron search result and in autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Ji?? Kozlovsk? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38045|1 |0 is patch| | Attachment #38045|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:56:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:56:40 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 --- Comment #8 from Ji?? Kozlovsk? --- Created attachment 38047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38047&action=edit Bug 13931 - Fixed Licence & Copyright statements & refactored the code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:56:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:56:41 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- I find the configuration for this to be a bit on the odd side. I'd much prefer to see it use the standard 123$a syntax rather than 123a. In addition, it does not support fields that have no subfields. Another minor issue, no other pref uses semicolons for a separator. It would be better to use a pipe (|) or a space ( which would be my preference ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:56:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:56:42 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:56:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:56:44 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37988|0 |1 is obsolete| | Attachment #38008|0 |1 is obsolete| | Attachment #38046|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 38048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38048&action=edit [PASSED QA] Bug 10706: Search reports by id This patch adds the ability to search reports by their id. Test plan: 1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved) 2/ Search for a report id (refer to the ID column in the table) 3/ The result should be consistent That the filters are not kept, already existed. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:58:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:58:00 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 --- Comment #9 from Ji?? Kozlovsk? --- (In reply to Chris Cormack from comment #7) > A quick fix needed, the copyright statements are wrong (looks like a cut and > paste error?) Also Koha is GPLv3 or later not 2 anymore. > > I'll try to do some functional testing, but if you could fix those, they > won't get caught at QA :) Thanks! Now I have licence & copyright repaired so there shouldn't be any issues with it anymore :) .. I also did a little refactoring -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:58:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:58:52 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #9 from Katrin Fischer --- I filed a new bug report bug 14008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:59:20 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #10 from Katrin Fischer --- Created attachment 38049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38049&action=edit [PASSED QA] Bug 10706: Add test Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:59:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:59:40 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:59:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:59:43 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38044|0 |1 is obsolete| | --- Comment #7 from Andreas Hedstr?m Mace --- Created attachment 38050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38050&action=edit Bug 9139: New subscription form - Does not check form on the first page The vendor and Record input try to sent the form if the focus is on the inputs (normal behavior). But the form is on 2 pages, and the popup message ask you to fill info on the second page when you are on the first one. This does not make sense. This patch suggests to launch search when the enter key is press on these inputs. Test plan: 1/ Create a new subscription 2/ Put the focus in the Vendor input and press enter: the vendor search popup should appear 3/ Put the focus in the Record input and press enter: the record search popup should appear Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 14:59:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 12:59:56 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #84 from Fridolin SOMERS --- I've found : opac-sendbasket.pl: Error sending mail: Bad or missing From address: '' You need to specify an address in syspref KohaAdminEmailAddress before testing sending emails. In UNIMARC database at least. Works for me with a cart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:03:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:03:57 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #11 from Katrin Fischer --- Created attachment 38051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38051&action=edit [PASSED QA] Bug 10706: Delete saved_reports to be sure no reports existed We need to be sure no report existed before launching the tests. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:04:01 +0000 Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the wrong course! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:04:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:04:43 +0000 Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the wrong course! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 --- Comment #3 from M. de Rooy --- QA: Picking a trivial one now; spent hours in Search.pm :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:06:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:06:52 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:07:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:07:19 +0000 Subject: [Koha-bugs] [Bug 14009] New: Circulation Branchcode Error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14009 Bug ID: 14009 Summary: Circulation Branchcode Error Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mustafa.albayrak at itugvo.k12.tr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently we are using KOHA's 3.14. version. On Monday we added a new branch to our library but it keeps giving the same warning-you can see it below-. Can you please tell us what the problem is and make some suggestions to solve it. Software error: No branchcode argument passed to Koha::Calendar->new at /usr/share/koha/lib/C4/Circulation.pm line 3085 For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:07:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:07:29 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #85 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #84) > You need to specify an address in syspref KohaAdminEmailAddress before > testing sending emails. > In UNIMARC database at least. Same for MARC21 database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:07:46 +0000 Subject: [Koha-bugs] [Bug 14009] Circulation Branchcode Error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14009 Mustafa Albayrak changed: What |Removed |Added ---------------------------------------------------------------------------- OS|All |Linux Hardware|All |HP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:14:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:14:44 +0000 Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from cataloging search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:14:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:14:47 +0000 Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from cataloging search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37347|0 |1 is obsolete| | Attachment #37349|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 38052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38052&action=edit [PASSED QA] Bug 13886 - Add ability to merge records directly from cataloging search This patch adds a merge button and checkboxes to the cataloging search results screen to allow librarians to merge directly from these reults To test: 1 - Apply patch 2 - Perform a cataloging search 3 - Try to select 1 or more than 2 records to merge and check that you get an error 4 - Select 2 records to merge and confirm the correct records are passed to the merge tool Signed-off-by: Nicole Engard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:14:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:14:53 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 --- Comment #21 from Nicole C. Engard --- Created attachment 38053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38053&action=edit Revert "Bug 13189: (QA Followup) Unit Tests" This reverts commit a7822b0a32faa5ffe6e5a3b43c1cd2c58a8a802a. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:15:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:15:00 +0000 Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from cataloging search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886 --- Comment #8 from Kyle M Hall --- Created attachment 38054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38054&action=edit [PASSED QA] Bug 13886 QA Follow Up : Remove tabs Signed-off-by: Nicole Engard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:15:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:15:40 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38053|0 |1 is obsolete| | --- Comment #22 from Nicole C. Engard --- Comment on attachment 38053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38053 Revert "Bug 13189: (QA Followup) Unit Tests" Something strange is going on on my system - ignore me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:15:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:15:58 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:16:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:16:00 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37805|0 |1 is obsolete| | --- Comment #23 from Nicole C. Engard --- Created attachment 38055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38055&action=edit Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:16:20 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37806|0 |1 is obsolete| | --- Comment #24 from Nicole C. Engard --- Created attachment 38056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38056&action=edit Bug 7380: Rename filter to avoid confusion The branchcode and categorycode parameter names are too common and are confusing. To remove the ambiguity, this patch renames them with branchcode_filter and categorycode_filter. Test plan: 1/ Go on the patron home page (members-home.pl) 2/ Fill the library and category dropdown list in the header search 3/ The patron result list appears and the filters (on the right) are correctly set with what you have selected. Make sure the ones in the header are also correctly selected. 4/ Click on a patron 5/ On the patron detail page (moremember.pl), the dropdown lists in the header are not preselected. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:19:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:19:39 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:22:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:22:07 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Nicole C. Engard --- 08:16 ~/kohaclone (master % u=)$ git qa 8688 >From git://git.koha-community.org/koha * branch master -> FETCH_HEAD Branch bug8688-qa set up to track remote branch master from origin. Switched to a new branch 'bug8688-qa' Bug 8688 - Add a recall button to the biblio record details page. 36741 - Bug 8688 - Add a Recall button to the biblio record details page. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8688 - Add a Recall button to the biblio record details page. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/en/mandatory/sample_notices.sql Auto-merging catalogue/detail.pl Failed to merge in the changes. Patch failed at 0001 Bug 8688 - Add a Recall button to the biblio record details page. When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8688---Add-a-Recall-button-to-the-biblio-recor-Glrmn_.patch 08:21 ~/kohaclone (bug8688-qa *+%|AM u=)$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:26:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:26:42 +0000 Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the wrong course! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37383|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 38057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38057&action=edit Bug 13817 - Edit links on course items may point to the wrong course! If items are assigned to multiple courses, the "edit" links for a course item may pass the wrong course id. This is really a cosmetic issue. It appears that in Template Toolkit, if you reuse an existing variable name in a foreach loop, it will not create a new temporary variable but will instead re-use the existing variable leaving assigned at the end to the last assignment, just as it would in Perl code. This is not a problem when all items are assigned to one and only one course, but can cause issues when we loop through the other courses an item may be on. This is solved easily by renaming the variable used in the foreach loop to another unused name. Test Plan: 1) Apply this patch 2) Try the edit and delete links for an item on reserve for a course 3) No changes in behavior should be noted Signed-off-by: Tom Misilo Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:26:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:26:40 +0000 Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the wrong course! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:27:14 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:27:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:27:17 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37662|0 |1 is obsolete| | Attachment #37663|0 |1 is obsolete| | Attachment #37664|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 38058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38058&action=edit [PASSED QA] Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT The previous patch fixed partially the problem. If you try to update more that 1000 records, you will get the same error. This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT (32mb). Test plan: 1/ Try to modify a huge amount of records (1000 should be enough) 2/ Confirm it worked! Signed-off-by: Frederic Demians I confirm that with more than 1000 records the session object is truncated, and then can't be anymore be desirialized, blocking completely Koha. Fixed with this patch. Signed-off-by: Mark Tompsett This only pushes off the problem expontentially (64KB vs. 16MB), but this is a good start. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:27:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:27:34 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38058|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 38059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38059&action=edit [PASSED QA] Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT The previous patch fixed partially the problem. If you try to update more that 1000 records, you will get the same error. This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT (32mb). Test plan: 1/ Try to modify a huge amount of records (1000 should be enough) 2/ Confirm it worked! Signed-off-by: Frederic Demians I confirm that with more than 1000 records the session object is truncated, and then can't be anymore be desirialized, blocking completely Koha. Fixed with this patch. Signed-off-by: Mark Tompsett This only pushes off the problem expontentially (64KB vs. 16MB), but this is a good start. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:27:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:27:41 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #41 from Kyle M Hall --- Created attachment 38060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38060&action=edit [PASSED QA] Bug 13606 Clear job data in session when the job is completed Bug 11395 uses the session to store the report sent to the interface (update on biblio XX OK, etc.). If the session is stored in mysql, the max size of the sessions.a_session will be reached easily (TEXT field). To reproduce: 0/ Set SessionStorage to 'mysql' 1/ Create a file with 500 biblionumbers: mysql -e "select biblionumber from biblio limit 500;" | tail -n 500 > /tmp/biblionumbers.txt 2/ Define a marc modification template (something like "delete field 99$9" is nice) 3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool 4/ Repeat 3 You will get: Syck parser (line 1534, column 6): syntax error at /usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75. None Koha page is reachable. It comes from get_template_and_user > checkauth > get_session > l.1595 $session = new CGI::Session("driver:MySQL;serializer:yaml;id:md5", $sessionID, {Handle=>$dbh}); 5/ Get your sessionID contained in your CGISESSID cookie Have a look at the value a_session in the sessions table: mysql> select a_session from sessions where id="YOUR_SESSIONID"; You should see that the yaml is not correctly ended. The size of the DB field has been reached and the yaml is truncated. Test plan: 0/ Delete your CGISESSID cookie 1/ Try to reproduce the previous issue 2/ After the second batch, have a look at the sessions table and confirm that only one job_$JOB_ID exist in the yaml Signed-off-by: Jonathan Druart NOTE: Nicely clears batch job session information. (2) is incorrect. This cleans up after a full run. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:27:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:27:44 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #42 from Kyle M Hall --- Created attachment 38061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38061&action=edit [PASSED QA] Bug 13606: Add tests and fix existing ones Some tests were wrong and not executed in a transaction. Lot of sessions were created in DB because the session was never flushed. TEST PLAN --------- $ mysql ... > delete from sessions; ^Z $ prove -v t/db_dependent/BackgroundJob.t ... $ fg > select id from sessions; -- There will be lots of ids (10, if I recall) ^Z $ git bz apply 13606 ... $ prove -v t/db_dependent/BackgroundJob.t ... $ fg > select * from sessions; -- there should only be the one orphaned job. You can tell it is correct by the "making new job". > quit Run the koha-qa test tools. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:27:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:27:51 +0000 Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the wrong course! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 --- Comment #5 from M. de Rooy --- Not so trivial to reproduce. With three courses and two items, I couldn't somehow. But the code looks good. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:28:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:28:24 +0000 Subject: [Koha-bugs] [Bug 14008] Saved reports disappear from display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:28:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:28:26 +0000 Subject: [Koha-bugs] [Bug 14008] Saved reports disappear from display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 --- Comment #1 from Jonathan Druart --- Created attachment 38062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38062&action=edit Bug 14008: Display active filters when searching for reports On the saved report list, the filters on the left are not displayed. It means that some can be set, but the user has not visible feedbacks. How filters work here: If a user set a filter, it is saved in the session. Next time he will come on this search, the previous values will be kept. This patch just displayed the filter's values in the input fields. Test plan: Search for reports by date, author and keyword. The filters should be displayed after you have clicked on the submit button ("Apply filter"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:28:34 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:28:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:28:36 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37391|0 |1 is obsolete| | --- Comment #17 from Nicole C. Engard --- Created attachment 38063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38063&action=edit Bug 5685: Validation of email address field This patch adds server-side & client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, "Library use", "Alternate address", "Alternative contact"). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? Signed-off-by: Owen Leonard I have undone the changes to opac.css so that they can be submitted as a separate patch. I have some other follow-ups to make as well. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:28:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:28:43 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37392|0 |1 is obsolete| | --- Comment #18 from Nicole C. Engard --- Created attachment 38064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38064&action=edit Bug 5685 [Compiled CSS] Validation of email address field This patch contains the recompiled opac.css file based on changes made to opac.less in the previous patch. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:28:48 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37393|0 |1 is obsolete| | --- Comment #19 from Nicole C. Engard --- Created attachment 38065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38065&action=edit Bug 5685 [OPAC follow-up] Validation of email address field This patch makes a few changes to the way errors are handled in the OPAC: - The validation plugin has been moved from the global include file to the template itself. Since we aren't doing form validation on any other page yet it doesn't make sense to include it globally at this time. - The error message which appears if you have JavaScript disabled and have submitted invalid emails was styled in a non-standard way. - I have added in-page links to the error message which appears if you have JavaScript disabled so that you can click to jump to the field which contains the error. - I have modified the error message language slightly to make it (I hope) read better. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:28:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:28:56 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:28:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:28:56 +0000 Subject: [Koha-bugs] [Bug 14008] Saved reports disappear from display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10706 CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:29:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:29:43 +0000 Subject: [Koha-bugs] [Bug 14008] Filters are not displayed on search for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Saved reports disappear |Filters are not displayed |from display |on search for reports --- Comment #2 from Jonathan Druart --- (In reply to Katrin Fischer from comment #0) > To reproduce: > - search for a keyword in your reports that exists > - search works, correct reports are displayed > - search for a keyword in your reports, that doesn't exist > - result is correct and a nice message shown > - click "use saved" in the navigation to the left to return to your > full reports list > - nothing is shown, all reports are hiding. It was a feature, but did not work very well :) This patch should remove the ambiguity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:30:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:30:31 +0000 Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #4 from M. de Rooy --- QA: Looking here now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:33:04 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 --- Comment #10 from Winona Salesky --- Looking at the marc documentation these are the subfields I see for the uniform titles: a,d,f,g,h,k,l,m,n,o,p,r,s,t (240 does not have subfield t). Should I go ahead and add all of these? -Winona (In reply to rgravel from comment #9) > We didn't originally include them because we didn't think they were often > used, but it's a valid point: if they are actually there, then you'd want to > see them. So, I'm for displaying all subfields associated with these fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:33:22 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #22 from Jonathan Druart --- The patch has been reverted from master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:36:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:36:27 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:36:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:36:30 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37971|0 |1 is obsolete| | --- Comment #6 from Andreas Hedstr?m Mace --- Created attachment 38066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38066&action=edit Bug 13022 - Hardcoded limit causes records with more than 20 items to show inaccurate statuses If a record has more than 20 items, all the items over 20 will show as available on the search results even if they are not! This is a hard coded limit in the Search module. This number should be configurable. Test Plan: 1) Create a record with more than 20 items 2) Set all the items to waiting holds or in transit 3) Search for results that will include that item 4) Note some say they are available even though they are not 5) Apply this patch 6) Run updatedatabase.pl 7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck to a number larger than the number of items on your record 8) Re-run the search 9) Note that the hold and transit statuses for the items are now correct Signed-off-by: Andreas Hedstr?m Mace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:37:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:37:11 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|simith.doliveira at inlibro.co |philippe.blouin at inlibro.com |m | CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:37:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:37:54 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 --- Comment #25 from Katrin Fischer --- Created attachment 38067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38067&action=edit [PASSED QA] Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:38:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:38:00 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 --- Comment #26 from Katrin Fischer --- Created attachment 38068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38068&action=edit [PASSED QA] Bug 7380: Rename filter to avoid confusion The branchcode and categorycode parameter names are too common and are confusing. To remove the ambiguity, this patch renames them with branchcode_filter and categorycode_filter. Test plan: 1/ Go on the patron home page (members-home.pl) 2/ Fill the library and category dropdown list in the header search 3/ The patron result list appears and the filters (on the right) are correctly set with what you have selected. Make sure the ones in the header are also correctly selected. 4/ Click on a patron 5/ On the patron detail page (moremember.pl), the dropdown lists in the header are not preselected. Signed-off-by: Nicole Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:38:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:38:45 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38056|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:38:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:38:46 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38055|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:44:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:44:48 +0000 Subject: [Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com --- Comment #20 from Kyle M Hall --- Three issues: 1) The layout on this appears to be a bit wonky. I think it needs to use the toolbar markup used in many other places in Koha. 2) The show/hide printed holds button doesn't do what it says. It switches to showing only printed holds or non-printed holds. The language should be "View printed holds" and "View un-printed holds" or some such thing. 3) "Print checked holds" should be "Print selected holds" or maybe just "Print selected" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:46:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:46:11 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer --- Functionally I am fie with this, pushing it back to Jonathan asking nicely for some tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:51:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:51:49 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:51:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:51:52 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 --- Comment #7 from Kyle M Hall --- Created attachment 38069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38069&action=edit Bug 13022 [QA Followup] - Allow the pref to be unset for unlimited item status checks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:57:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:57:49 +0000 Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 15:57:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 13:57:52 +0000 Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37248|0 |1 is obsolete| | --- Comment #5 from M. de Rooy --- Created attachment 38070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38070&action=edit Bug 13385: Add field 508 to XSLT (OPAC and staff) This patch adds field 508 to the XSLT display in the staff and OPAC view. Display includes subfield a. To test: * Search the opac * Click the title * Make sure the fields display properly * Repeat for a few more titles * Repeat in the Staff Client Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Adjusted commit message. Only subfield a is relevant here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 16:03:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 14:03:05 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #34 from Winona Salesky --- Yes, they are. Although, now that I am looking back through the code, I only handle multiple $e, if there are multiple $4 it only displays 1. Should I change that, or is that unlikely to be an issue? -Winona (In reply to rgravel from comment #33) > With our systems librarian on leave, I'm not able to do a done of patch > testing, but I wonder: Are multiple relator terms displaying with the patch, > like in the below example? Thanks! > > Contributor(s): Nolan, Christopher, 1970? [film producer, screenwriter, > director] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 16:04:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 14:04:37 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #10 from M. de Rooy --- QA: Looking here now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 16:07:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 14:07:14 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 16:07:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 14:07:17 +0000 Subject: [Koha-bugs] [Bug 9139] Sending empty vendor or biblio when adding subscriptions gives wrong error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38050|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 38071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38071&action=edit [PASSED QA] Bug 9139: New subscription form - Does not check form on the first page The vendor and Record input try to sent the form if the focus is on the inputs (normal behavior). But the form is on 2 pages, and the popup message ask you to fill info on the second page when you are on the first one. This does not make sense. This patch suggests to launch search when the enter key is press on these inputs. Test plan: 1/ Create a new subscription 2/ Put the focus in the Vendor input and press enter: the vendor search popup should appear 3/ Put the focus in the Record input and press enter: the record search popup should appear Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 16:08:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 14:08:40 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38069|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 38072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38072&action=edit Bug 13022 [QA Followup] - Allow the pref to be unset for unlimited item status checks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 17 16:12:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 Apr 2015 14:12:41 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #11 from Jonathan Druart --- Comment on attachment 37293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37293 [SIGNED-OFF] Bug 8612 - System preference to have custom fields in export csv basket Review of attachment 37293: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8612&attachment=37293) ----------------------------------------------------------------- ::: acqui/basket.pl @@ +197,5 @@ > -type => 'text/csv', > -attachment => 'basket' . $basket->{'basketno'} . '.csv', > ); > + if ( $query->param('csv_profile') eq 'default'){ > + print GetBasketAsCSV($query->param('basketno'), $query); Actually this subroutine should take the csv profile in parameter, don't you think? @@ +531,4 @@ > return \%line; > } > > +sub get_basket_DB_info{ Don't you have something in the module to do that? (I didn't check). In all cases, you cannot add it here in the pl. Yes that means tests. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt @@ +190,5 @@ > [% END %] > +
> +
> + > +
> [% END %] > + Did you mean to make this string change here? @@ +423,4 @@ > > [% UNLESS ( item_level_itypes ) %] [% END %] > [% IF ( show_barcode ) %][% END %] > + Did you mean to make this string change here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 17:54:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 15:54:06 +0000 Subject: [Koha-bugs] [Bug 14025] New: Implement OPACURLOpenInNewWindow for NORMARC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 Bug ID: 14025 Summary: Implement OPACURLOpenInNewWindow for NORMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org NORMARC XSLT does not support OPACURLOpenInNewWindow. It should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:10:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:10:13 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 --- Comment #7 from Kyle M Hall --- Created attachment 38199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38199&action=edit Bug 1917 [QA Followup] - Use html filter, only show 'by' if author exists, change link title -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:15:49 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38117|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 38200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38200&action=edit Bug 1917 [QA Followup] - Use html filter, remove "by", change link title -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:18:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:18:18 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Kyle M Hall --- Tested alternate patch, I receive no popup print notice on the initial checkin, print & confirm hold, but I do on the second time around: http://screencast.com/t/s7lnVcBwox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:25:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:25:19 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38199|0 |1 is obsolete| | Attachment #38200|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 38201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38201&action=edit Bug 1917 [QA Followup] - Use html filter, only show 'by' if author exists, change link title -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:26:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:26:06 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38117|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:31:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:31:43 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:43:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:43:35 +0000 Subject: [Koha-bugs] [Bug 14026] New: Deleting Authority record tag does not update bibliographic marc record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026 Bug ID: 14026 Summary: Deleting Authority record tag does not update bibliographic marc record Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When an authority record that is linked to a bibliographic record has a subfield *deleted*, that deleted tag is *not* deleted from the linked bibliographic record(s). note: edits and additions are reflected in the linked bibliographic records. only deletions are not. Steps to reproduce: 1. Create authority record with multiple subfields. i.e. 110$a$v$x 2. Create new biblio record, a. Select authority record created in step 1 to link the two together 3. Edit authority record by deleting a subfield (i.e. 110$x) 4. View bibliographic record - the deleted authority subfield is still present in the bibliographic record Note: wait for reindexing between steps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:53:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:53:58 +0000 Subject: [Koha-bugs] [Bug 14022] Subscription form resets 'subscription length' to issues on editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 --- Comment #2 from Marc V?ron --- Created attachment 38202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38202&action=edit [Signed-off] Bug 14022: Does not reset the subscription length on editing a subscription The subscription length is always set to the first/default value ('issues') when editing a subscription. Even if you selected another value on creating/editing it, the form will show you the first option. Test plan: 1/ Add/Edit a subscription, select a subscription length different of the first value (issues) 2/ Edit the subscription and confirm the value is kept Bonus: issues, week and months become translatable. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:55:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:55:00 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 --- Comment #10 from Kyle M Hall --- With Katrin's help I was able to run the translator tool and it appears to be pickup up the template, so that should no longer be an issue! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:55:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:55:20 +0000 Subject: [Koha-bugs] [Bug 14022] Subscription form resets 'subscription length' to issues on editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #38197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 18:55:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 16:55:58 +0000 Subject: [Koha-bugs] [Bug 14022] Subscription form resets 'subscription length' to issues on editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:20:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:20:37 +0000 Subject: [Koha-bugs] [Bug 14027] New: Add TableTools plugin for DataTables Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 Bug ID: 14027 Summary: Add TableTools plugin for DataTables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:20:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:20:44 +0000 Subject: [Koha-bugs] [Bug 14027] Add TableTools plugin for DataTables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:22:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:22:04 +0000 Subject: [Koha-bugs] [Bug 14027] Add TableTools plugin for DataTables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 --- Comment #1 from Kyle M Hall --- Created attachment 38203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38203&action=edit Bug 14027 - Add TableTools plugin for DataTables Signed-off-by: Kyle M Hall Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:22:12 +0000 Subject: [Koha-bugs] [Bug 14027] Add TableTools plugin for DataTables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:22:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:22:30 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37234|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:22:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:22:45 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14027 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:22:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:22:45 +0000 Subject: [Koha-bugs] [Bug 14027] Add TableTools plugin for DataTables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6427 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:23:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:23:29 +0000 Subject: [Koha-bugs] [Bug 14027] Add TableTools plugin for DataTables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Kyle M Hall --- Signed off as part of bug 6427 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:25:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:25:31 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #10 from Marc V?ron --- Created attachment 38204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38204&action=edit [Signed-off] Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. Signed-off-by: Mark Tompsett NOTE: Love the simplicity and ability to expand. :) Tested with all pateches applied. Wors as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:25:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:25:54 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:28:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:28:08 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #11 from Marc V?ron --- Created attachment 38205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38205&action=edit [Signed-off] Bug 10752: Remove the specific css for links in an error dialog Comes from commit c28f7d7de5d1e1a8d5e0038b76fce74397c3c489 Date: Tue Mar 20 15:20:25 2012 +0100 Bug 6209 [Revised] Standardize on one plugin for client-side form validation It did not find how it could be useful. --- Tested with all pateches applied. Wors as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:28:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:28:33 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:29:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:29:50 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #12 from Marc V?ron --- Created attachment 38206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38206&action=edit [Signed-off] Bug 10752: Alert if the suggestion has not been added - OPAC Same as previous patches for the OPAC. Test plan is the same. Tested with all patches applied. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:30:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:30:10 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:30:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:30:42 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:42:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:42:39 +0000 Subject: [Koha-bugs] [Bug 13058] Deleting reports should be a permission setting, not a default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13058 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14024 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:42:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:42:39 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13058 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:43:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:43:05 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 19:47:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 17:47:56 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu --- Comment #1 from Tom Misilo --- Could it also track changes that are made to the sql, if it is edited? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 20:40:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 18:40:50 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 --- Comment #2 from Nicole C. Engard --- That's the idea - that's how the action logs work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 20:48:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 18:48:22 +0000 Subject: [Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 20:48:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 18:48:25 +0000 Subject: [Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 38207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38207&action=edit Bug 14006: about.pl checks the wrong zebra index mode This trivial patch makes the about page correctly test for configuration mismatches. Specifically it fixes the situation in which the koha-config.xml file points to zebra-biblios-dom.xml but has 'zebra_bib_index_mode' set to grs1. The test incorrectly queried for 'zebra_auth_index_mode' being set to grs1.' To test: - Have a DOM setup. - Change koha-conf.xml so zebra_bib_index_mode = grs1 => FAIL: No configuration missmatch is shown. - Apply the patch - Reload the about page => SUCCESS: A zebra configuration missmatch is shown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:29:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:29:57 +0000 Subject: [Koha-bugs] [Bug 14028] New: Canceling Holds awaiting pickup should redisplay the holds over tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14028 Bug ID: 14028 Summary: Canceling Holds awaiting pickup should redisplay the holds over tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:31:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:31:46 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Katrin Fischer --- *** Bug 14028 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:31:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:31:46 +0000 Subject: [Koha-bugs] [Bug 14028] Canceling Holds awaiting pickup should redisplay the holds over tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14028 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 13838 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:36:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:36:14 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 --- Comment #2 from Kyle M Hall --- Created attachment 38208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38208&action=edit Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length. Test Plan: 1) Apply this patch 2) Cancel a hold from the "Holds over" tab on circ/waitingreserves.pl 3) Note you are redirected back to the holds over tab -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:36:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:36:11 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:36:42 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:36:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:36:47 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:46:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:46:00 +0000 Subject: [Koha-bugs] [Bug 14022] Subscription form resets 'subscription length' to issues on editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:46:03 +0000 Subject: [Koha-bugs] [Bug 14022] Subscription form resets 'subscription length' to issues on editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38202|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 38209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38209&action=edit [PASSED QA] Bug 14022: Does not reset the subscription length on editing a subscription The subscription length is always set to the first/default value ('issues') when editing a subscription. Even if you selected another value on creating/editing it, the form will show you the first option. Test plan: 1/ Add/Edit a subscription, select a subscription length different of the first value (issues) 2/ Edit the subscription and confirm the value is kept Bonus: issues, week and months become translatable. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:50:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:50:50 +0000 Subject: [Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 --- Comment #3 from Katrin Fischer --- Going to pass this patch as it fixes the checkouts tab, but the problem is still visible on the overdues tab - repeat test plan, but check out an item with a due date in the past, so that you get an overdues tab in the patron account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:51:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:51:23 +0000 Subject: [Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:51:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:51:26 +0000 Subject: [Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38198|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 38210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38210&action=edit [PASSED QA] Bug 14016: Restore correct date format on issue date (00:00 vs 23:59) Introduced by bug 13601, and same fix used in bug 10423 and bug 12847: the date_due retrieved from the DB is modified. There are some problems: 1/ There is confusion between the iso and sql formats in the codebase. 2/ Since bug 13601, dt_from_string does not manage the iso format (there are occurrences of 'iso' but it assumes that both formats are identical). To solve the issue, 2 solutions: 1/ Same as bug 10423 and bug 12847: try to get rid of the change done on date_due in C4::Members::GetPendingIssues, it should be kept as the sql value. 2/ Too many errors found and another fallback should be added to dt_from_string (if 'iso' is passed, try sql then iso). Test plan: Go on the checkout list at the OPAC and confirm that the due dates are correctly formatted. Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:57:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:57:29 +0000 Subject: [Koha-bugs] [Bug 14029] New: Provide link to clear reports search filters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 Bug ID: 14029 Summary: Provide link to clear reports search filters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The reports filters are very 'sticky' - we should provide a link to make clearing the form a 'one-click' thing. To test: - go to the reports module - make sure you got some saved reports - search your saved reports using the author, keyword and date filters - see that there is a button to submit the form, but no link to clear it like on other pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:59:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:59:29 +0000 Subject: [Koha-bugs] [Bug 14008] Filters are not displayed on search for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 21:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 19:59:31 +0000 Subject: [Koha-bugs] [Bug 14008] Filters are not displayed on search for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38136|0 |1 is obsolete| | Attachment #38137|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 38211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38211&action=edit [PASSED QA] Bug 14008: Display active filters when searching for reports On the saved report list, the filters on the left are not displayed. It means that some can be set, but the user has not visible feedbacks. How filters work here: If a user set a filter, it is saved in the session. Next time he will come on this search, the previous values will be kept. This patch just displayed the filter's values in the input fields. Test plan: Search for reports by date, author and keyword. The filters should be displayed after you have clicked on the submit button ("Apply filter"). Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:00:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:00:21 +0000 Subject: [Koha-bugs] [Bug 14008] Filters are not displayed on search for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 --- Comment #9 from Katrin Fischer --- Created attachment 38212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38212&action=edit [PASSED QA] Bug 14008 - Proposed follow-up: Dialog should appear whenever filters are active The first patch displays the value(s) of an active filter if you come back to the page or reload the page via a menu action. To make the situation more clear the dialog "No saved reports match your criteria." shoudl always appear when a filter is active. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:17:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:17:11 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:17:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:17:14 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38204|0 |1 is obsolete| | Attachment #38205|0 |1 is obsolete| | Attachment #38206|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 38213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38213&action=edit [PASSED QA] Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. Signed-off-by: Mark Tompsett NOTE: Love the simplicity and ability to expand. :) Tested with all pateches applied. Wors as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:17:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:17:25 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #14 from Katrin Fischer --- Created attachment 38214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38214&action=edit [PASSED QA] Bug 10752: Remove the specific css for links in an error dialog Comes from commit c28f7d7de5d1e1a8d5e0038b76fce74397c3c489 Date: Tue Mar 20 15:20:25 2012 +0100 Bug 6209 [Revised] Standardize on one plugin for client-side form validation It did not find how it could be useful. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:17:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:17:31 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #15 from Katrin Fischer --- Created attachment 38215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38215&action=edit [PASSED QA] Bug 10752: Alert if the suggestion has not been added - OPAC Same as previous patches for the OPAC. Test plan is the same. Tested with all patches applied. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:17:36 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #16 from Katrin Fischer --- Created attachment 38216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38216&action=edit Bug 14022: Follow-up - rephrase erorr messages a little Rephrased error messages a little and changed the link to look like it does on other pages, for example when looking at an order created from a suggestion. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:20:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:20:43 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:21:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:21:15 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 --- Comment #3 from Marc V?ron --- Created attachment 38217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38217&action=edit Bug 14024 - add reports to action logs This patch sets adds the possibility to log new, update and delete actions for saved reports. To test: -Apply patch -Run updatedatabase.pl -Enable system preference ReportsLog -Create, duplicate, edit and delete saved reports -Go to Home > Tools > Logs -Verify that you can select "Reports" in Modules list -Verify that your actions were logged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:23:17 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:33:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:33:11 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38117|0 |1 is obsolete| | Attachment #38201|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 38218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38218&action=edit [PASSED QA] Bug 1917 - Add RSS Feeds for Lists Test Plan: 1) Apply this patch 2) Create one or more public lists 3) View the list in the opac 4) Note the new RSS icon next to the list name 5) Open the link in FireFox or an RSS reader 6) You should see an RSS feed of your list with the title and author of each item as a hyperlink to the record details Signed-off-by: Nicole Engard Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:33:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:33:27 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 --- Comment #12 from Katrin Fischer --- Created attachment 38219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38219&action=edit [PASSED QA] Bug 1917 [QA Followup] - Use html filter, only show 'by' if author exists, change link title Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 22:34:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 20:34:20 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 --- Comment #13 from Katrin Fischer --- Functionally I am happy with this, but a little confused about the use/non-use of the html filter - can you explain for the different spots? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 23:19:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 21:19:31 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36714|0 |1 is obsolete| | --- Comment #62 from H?ctor Eduardo Castro Avalos --- Created attachment 38220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38220&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. The recommendation can be consulted at . This new feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patch. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C. 7) DC-XML cannot valid if not exist a valid XSD schema. 8) OAI-DC can be validated using and the proper schema typed in text field for URL. 9) Since unit test fail last time, test with prove t/db_dependent/Record.t and prove t/db_dependent/Record/Record.t Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro XML::Entities, HTML::Entities and, HTML::Entities::Numbered were eliminated from patch, use instead C4::Record::_entity_encode, RDF::Helper has been eliminated too. Given, when experimental structures were eliminated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 23:24:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 21:24:49 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #63 from H?ctor Eduardo Castro Avalos --- Greetings, Katrin and Marc Please review the patch again. Thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 23:25:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 21:25:48 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 23:27:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 21:27:45 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #11 from Charles Farmer --- Created attachment 38221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38221&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 23:28:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 21:28:30 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 23:54:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 21:54:07 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 20 23:54:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 21:54:10 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38217|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard --- Created attachment 38222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38222&action=edit Bug 14024 - add reports to action logs This patch sets adds the possibility to log new, update and delete actions for saved reports. To test: -Apply patch -Run updatedatabase.pl -Enable system preference ReportsLog -Create, duplicate, edit and delete saved reports -Go to Home > Tools > Logs -Verify that you can select "Reports" in Modules list -Verify that your actions were logged Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 00:19:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 22:19:01 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer --- Starting for real now - testing this bug together with 13323 and 13324. Some first feedback, I will number every point and keep a list outside of bugzilla too: DATABASE UPDATE 1) Some warns: Use of uninitialized value in string eq at ./installer/data/mysql/updatedatabase.pl line 10228. Use of uninitialized value in string eq at ./installer/data/mysql/updatedatabase.pl line 10228. Use of uninitialized value in string eq at ./installer/data/mysql/updatedatabase.pl line 10228. Use of uninitialized value in string eq at ./installer/data/mysql/updatedatabase.pl line 10228. Upgrade to 3.19.00.XXX done (Bug 13321 - Tax and prices calculation: add new columns to aqorders) Upgrade to 3.19.00.XXX done (Bug 13321 - Tax and prices calculation: tax_value contains the value for 1 item) Upgrade to 3.19.00.XXX done (Bug 13323 - Tax rate can change on receiving) 2) Shouldn't the second database update entry refer to the quantity somehow? Why the hardcoded 2? And shouldn't we fix the first database entry here? Bit worried about the round: + for my $order ( @$orders ) { + $sth->execute( $order->{tax_value} * 2, $order->{ordernumber} ); + } QA SCRIPT AND AUTOMATED TESTS 3) Failing tests: - t/db_dependent/Budgets.t not ok 61 - total spent for budget1 is 160 # Failed test 'total spent for budget1 is 160' # at t/db_dependent/Budgets.t line 371. # got: '0' # expected: '160' not ok 62 - total spent for budget11 is 100 # Failed test 'total spent for budget11 is 100' # at t/db_dependent/Budgets.t line 372. # got: '0' # expected: '100' not ok 63 - total spent for budget111 is 20 # Failed test 'total spent for budget111 is 20' # at t/db_dependent/Budgets.t line 373. # got: '0' # expected: '20' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 00:40:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 22:40:57 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #29 from Katrin Fischer --- I will continue with code review tomorrow! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 01:01:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 23:01:38 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 --- Comment #16 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #12) > Bernardo, > All looks good but I would like to know what is the plan when it will be > pushed into master. > Because update/install won't work until the po file is not recreated. > Do you plan a big commit? Jonathan, if/when this bug is pushed i'll provide our RM with a patch to update/rename all po files. I've done something similar before, on every major release and to fix errors in translation files. But yes, until 'that' patch is pushed, translate will be problematic. But we can warn the RM to push this and the other together. > > I am wondering if the good idea wouldn't be to wait for the "git repo > cleanup" you are doing (have done?) with Chris (see > http://lists.koha-community.org/pipermail/koha-devel/2015-March/041293.html). > It will avoid the creation and deletion of the same files in a short time. We haven't agreed on a timeline yet, but in any case i'll be after 3.20 (In reply to Jonathan Druart from comment #13) > Note that this patch removes the version number in the filename > ... > What was the idea behind that? As Katrin said, it's a relic from the past, not updated in a long long time. It's a change with no practical justification, only a aesthetic one. I prefer not to have a wrong number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 01:46:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 Apr 2015 23:46:41 +0000 Subject: [Koha-bugs] [Bug 14030] New: Add Georgian language and fix Kannada language code Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Bug ID: 14030 Summary: Add Georgian language and fix Kannada language code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Add Georgian language Georgian - ka - geo - ??????? Fix Kannada language ISO639-1 code >From 'ka' to 'kn' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 02:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 00:33:37 +0000 Subject: [Koha-bugs] [Bug 14031] New: Itemnumber should be a numeric search in ccl.properties Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Bug ID: 14031 Summary: Itemnumber should be a numeric search in ccl.properties Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl At the moment, if you do a search in the OPAC or staff client for "itemnumber:1", you'll get no results even when you have an item with an itemnumber of 1. That's because Zebra defaults to a word list search, but there is no word index for itemnumber. It's a numeric index. So, to find that item, you'll have to try "itemnumber,st-numeric:1". However, by tweaking ccl.properties, we can make "itemnumber:1" work as well. We already do this for "notforloan" which we know will always be numeric. Current ccl.properties: notforloan 1=8008 4=109 itemnumber 1=8010 4=109 is the PQF/RPN for "st-numeric". So... let's just add "4=109" to itemnumber, and be merry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 02:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 00:42:27 +0000 Subject: [Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 02:42:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 00:42:30 +0000 Subject: [Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 --- Comment #1 from David Cook --- Created attachment 38223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38223&action=edit Bug 14031 - Itemnumber should be a numeric search in ccl.properties This patch changes the "itemnumber" alias so that it acts like "itemnumber,st-numeric". That is, it always does a numeric search. _TEST PLAN_ The best way to test this patch is to apply the patch and then run "make upgrade", I suspect. As this will refresh your "ccl.properties". However, this patch is actually really small, so you can just apply it manually to an existing "ccl.properties" if you rather save time. Basically, you just need to do the following steps: 0) Do a search for "itemnumber:" 1) Note that you can't retrieve any results 2) Change your ccl.properties to say "itemnumber 1=8010 4=109" 3) Repeat the search for "itemnumber:" 4) Note that you now retrieve your result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 02:43:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 00:43:09 +0000 Subject: [Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 03:12:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 01:12:53 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 38224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38224&action=edit Bug 14030: Add Georgian language and fix Kannada language code This patch adds Georgian language and a fix wrong language code Language added: Georgian - ka - geo I selected 'geo' for ISO639-2 instead of 'kat' because it's the same code form http://www.loc.gov/marc/languages/language_code.html Also a fix is needed to Kannada ISO639-1 code, from 'ka' to 'kn' To test: 1) Apply the patch 2) Run updatedatabase.pl (once) 3) Check language, e.g. go to staff > search > More options > Limits and search for Georgian on language list I only added language code 'ka', not script 'Geor' nor country 'GE', the plan is to name translation files 'ka-*', but can ammend the patch if needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 03:13:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 01:13:49 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 03:41:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 01:41:01 +0000 Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 --- Comment #6 from David Cook --- I can't reproduce this on master either. It looks like the problem caused by: https://library.roseville.ca.us/cgi-bin/koha/opac-search.pl?q=su:%22Fairies.%22 is specific to either 3.16.4 or a modification that Bywater have made to that Koha instance. Here's a link that I see in the Roseville site for the query https://library.roseville.ca.us/cgi-bin/koha/opac-search.pl?q=su:%22Fairies.%22: Colfer, Eoin. However, my query for http://192.168.1.61:2112/cgi-bin/koha/catalogue/search.pl?q=su:%22Fairies.%22 creates the following link: test I suspect that the following line in C4::Search::buildQuery() was added after 3.16.4: $limit_cgi .= "&limit=" . uri_escape_utf8($this_limit); Although it looks like the Roseville site is also doing something with lowercasing and possibly whitespace as well... --- I suspect that the current patch might cause problems if it's used since it removes the TracingQuotesLeft and TracingQuotesRight, which are { and } with ICU, and only " and " with non-ICU. In any case, this doesn't appear to be a problem in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 03:51:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 01:51:14 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook --- I can't reproduce this in master. Search: http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=au:%22De%20Paola,%20Tomie.%22 Creates: Adult Office However... Search: http://192.168.1.61:2112/cgi-bin/koha/catalogue/search.pl?q=au:%22De%20Paola,%20Tomie%22 Creates: test Which works just fine. I noticed the Bywater site is on 3.19.00.016, and I'm on 3.19.00.026, so maybe that makes a difference. Or perhaps there's a setting difference somewhere... but this is the same thing I noticed on http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812. The Bywater link has an extra space and all the letters are lowercased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 05:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 03:53:25 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38150|0 |1 is obsolete| | --- Comment #32 from M. Tompsett --- Created attachment 38225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38225&action=edit Bug 7595 - Add branchcode to accountlines Adds a branchcode column to the accountlines table. For payments, this inserts the branchcode of the library where the payment was recorded. For manual invoices, it insert the branchcode of the library where the manual invoice was created. NOTE: Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 06:01:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 04:01:25 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #33 from M. Tompsett --- There. Should be like it was. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 06:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 04:31:59 +0000 Subject: [Koha-bugs] [Bug 14032] New: Delete item "confirm" only works in Firefox Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14032 Bug ID: 14032 Summary: Delete item "confirm" only works in Firefox Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you go to "Edit Items" in the staff client, and then click on "Delete" in the first table cell, the confirm box will delete the item regardless of the option you choose. The "cancel" option is completely ignored in Chrome and IE, but not Firefox. I know there are those among us who say that we should only ever use Firefox, but a lot of people use other browsers, especially Chrome. Although, honestly I'm surprised that I haven't encountered this before. I also can't fix it for all Chrome/Firefox/IE. I've switched the inline "onclick" to a jQuery click handler and used "e.preventDefault()", which works in Chrome/Firefox... but not IE. Which is weird, because it works on other sites in IE: http://api.jquery.com/event.preventdefault/ I'm fresh out of ideas at the moment, but perhaps I'll look at this one again eventually... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:38:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:38:09 +0000 Subject: [Koha-bugs] [Bug 14033] New: Capitalization: confirmation message on deleting an authority type Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Bug ID: 14033 Summary: Capitalization: confirmation message on deleting an authority type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The capitalization on the confirmation message for deleting an authority type doesn't follow our rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:44:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:44:45 +0000 Subject: [Koha-bugs] [Bug 14032] Delete item "confirm" only works in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- You will probably not want to hear this... but it can happen in Firefox too. I saw it in a screen sharing session using Firefox. (bug 13943) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:46:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:46:25 +0000 Subject: [Koha-bugs] [Bug 8480] auth_subfield_structure is not cleared when deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8480 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:46:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:46:27 +0000 Subject: [Koha-bugs] [Bug 8480] auth_subfield_structure is not cleared when deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8480 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37794|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 38226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38226&action=edit [PASSED QA] Bug 8480: Add constraint on auth_subfield_structure.authtypecode In order not to have useless entries in the auth_subfield_structure table, this patch modifies the DB structure to add a foreign key on the authtypecode column. Note that the auth_tag_structure already has this constraint. Test plan: 0/ Don't apply this patch 1/ Create a now authority type 'RM_ME' 2/ Look at the MARC structure, to create the subfield structure and populate the auth_subfield_structure table. 3/ Delete the authority type 4/ Using your SQL cli: SELECT COUNT(*) FROM auth_subfield_structure WHERE authtypecode='RM_ME'; => The data are still in this table. 5/ Apply this patch 6/ Execute the updatedb entry 7/ Confirm the entries in the auth_subfield_structure table related to RM_ME have been deleted 8/ Repeat 1, 2 and 3 and verify the auth_subfield_structure entries have been correctly removed. Signed-off-by: Frederic Demians - Works exactly as described in the (very good) test plan. - After authority type deletion, auth_subfield_structure still contains entries for deleted authority type. Applying the patch clean the previously undeleted records in auth_subfield_strucute. Now deleting a authority type cleans propertly all appropriate records in auth_subfield_structure. - Fix a merge conflict Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:47:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:47:31 +0000 Subject: [Koha-bugs] [Bug 14032] Delete item "confirm" only works in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14032 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from David Cook --- Ok... I might be going mad. Now I try it and it works fine in IE and Chrome... I think the universe is trolling me today. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:49:34 +0000 Subject: [Koha-bugs] [Bug 14032] Delete item "confirm" only works in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14032 --- Comment #3 from Katrin Fischer --- I think this is a valid and scary bug... we are just not able to track it down YET. The library could only show it to me once, but I did see it and they had it happen more often. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:50:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:50:53 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38183|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 38227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38227&action=edit Bug 13889 - Add information about cron jobs to system log This patch adds information about cron jobs performed and make it viewable under Home > Tools > Logs ("Browse system logs") To test: Apply patch - Got to system preferences and set 'CronjobLog' to: [Log] information from cron jobs. - Run some cron jobs - Go to Home > Tools > Logs - Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it with Action "All" and Submit. - Output should show Date/time and info about Cron jobs Rebased to work on top of Bug 6911 (conflict in viewlog.tt) /MV Rebased after applying patch for Bug 6911 /MV Conflicts resolved: misc/cronjobs/overdue_notices.pl misc/cronjobs/cleanup_database.pl Signed-off-by: Frederic Demians - Merge both patches, and fix updatedatabase.pl - Works as described. Provide intersting feedback from cronjob scripts. -- Modified version taking in account syspref CronJobLog. Handling simplified by introducing a convenience sub cronlogaction in C4/Log.pm /MV Amended to take in account comments #11, #12, #13 /MV http://bugs.koha-community.org/show_bug.cgi?id=13899 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:50:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:50:58 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #17 from M. Tompsett --- Created attachment 38228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38228&action=edit Bug 13889: Added Test Coverage Previous commit was lacking test coverage of new function. TEST PLAN --------- 1) Apply all the patches 2) prove -v t/db_dependent/Log.t -- should be success. 3) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:52:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:52:19 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38227|0 |1 is obsolete| | --- Comment #18 from M. Tompsett --- Created attachment 38229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38229&action=edit Bug 13889 - Add information about cron jobs to system log This patch adds information about cron jobs performed and make it viewable under Home > Tools > Logs ("Browse system logs") To test: Apply patch - Got to system preferences and set 'CronjobLog' to: [Log] information from cron jobs. - Run some cron jobs - Go to Home > Tools > Logs - Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it with Action "All" and Submit. - Output should show Date/time and info about Cron jobs Rebased to work on top of Bug 6911 (conflict in viewlog.tt) /MV Rebased after applying patch for Bug 6911 /MV Conflicts resolved: misc/cronjobs/overdue_notices.pl misc/cronjobs/cleanup_database.pl Signed-off-by: Frederic Demians - Merge both patches, and fix updatedatabase.pl - Works as described. Provide intersting feedback from cronjob scripts. -- Modified version taking in account syspref CronJobLog. Handling simplified by introducing a convenience sub cronlogaction in C4/Log.pm /MV Amended to take in account comments #11, #12, #13 /MV http://bugs.koha-community.org/show_bug.cgi?id=13899 Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:52:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:52:26 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38228|0 |1 is obsolete| | --- Comment #19 from M. Tompsett --- Created attachment 38230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38230&action=edit Bug 13889: Added Test Coverage Previous commit was lacking test coverage of new function. TEST PLAN --------- 1) Apply all the patches 2) prove -v t/db_dependent/Log.t -- should be success. 3) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:52:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:52:32 +0000 Subject: [Koha-bugs] [Bug 14032] Delete item "confirm" only works in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14032 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #4 from David Cook --- Bizarre. Reopening this because it apparently only happens sometimes! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:52:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:52:45 +0000 Subject: [Koha-bugs] [Bug 14032] Delete item "confirm" only works in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14032 --- Comment #5 from David Cook --- Bizarre. Reopening this because it apparently only happens sometimes! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 07:57:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 05:57:21 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #20 from M. Tompsett --- Leaving as 'Needs Signoff', because my test coverage addition can't be signed off by me. Also, I ran the purge suggestions cronjob to test the logging. I did not run all the scripts, though I did look at all of them. They were all the same change: use C4::Log, and trigger a cronlogaction() after a successful start. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 08:01:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 06:01:10 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 08:01:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 06:01:13 +0000 Subject: [Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37990|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 38231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38231&action=edit [PASSED QA] Bug 10172: Hide some uneeded stuffs on printing a record When printing a record from the OPAC or the staff interface, some uneeded blocks are displayed. OPAC: 1/ Browse results 2/ The view tags (Normal, MARC, ISBD) Intranet: 1/ Marc view link 2/ The Please upload one image link Test plan: On a record detail page (staff and OPAC), print the page and confirm these blocks no longer appear. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 08:02:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 06:02:32 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 08:03:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 06:03:57 +0000 Subject: [Koha-bugs] [Bug 14032] Delete item "confirm" only works in Firefox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14032 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|REOPENED |RESOLVED --- Comment #6 from David Cook --- Marking this as a duplicate of Katrin's older bug which is more accurate. *** This bug has been marked as a duplicate of bug 13943 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 08:03:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 06:03:57 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- *** Bug 14032 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 08:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 06:06:17 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 --- Comment #2 from David Cook --- I've definitely experienced this as well, although in my case the problem was with Chrome and IE while it worked in Firefox. After I reported the bug and gave up on it, I tried again in Chrome and IE... and found that they were working as expected! No buggy behaviour! So I don't know... my boss suggested that we make the confirm_deletion function more simple or remove it all together in favour of the following inline code: onclick="return confirm('Are you sure you want to delete this item?')" or onclick="return confirm(_('Are you sure you want to delete this item?'))" Perhaps that's a thought... when I tested the first option, it worked fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 08:18:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 06:18:12 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 --- Comment #2 from M. Tompsett --- Comment on attachment 38224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38224 Bug 14030: Add Georgian language and fix Kannada language code Review of attachment 38224: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14030&attachment=38224) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_14030-Add_Georgian_fix_Kannada_code.sql @@ +1,3 @@ > +UPDATE language_subtag_registry SET subtag = 'kn' WHERE subtag = 'ka' AND description = 'Kannada'; > + > +UPDATE language_rfc4646_to_iso639 SET rfc4646_subtag = 'kn' WHERE rfc4646_subtag = 'ka' AND iso639_2_code = 'kan'; Good idea to include the iso639_2_code in the condition. Makes it runnable multiple times (not that one should). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 09:36:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 07:36:01 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- I'm wondering, are the id columns of the language tables even used? If so, where? If not, then why don't we have unique constraints that actually mean that we could write this SQL such that it could be run multiple times? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 09:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 07:36:24 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #3 from Fridolin SOMERS --- (In reply to David Cook from comment #2) > So I don't know... my boss suggested that we make the confirm_deletion > function more simple or remove it all together in favour of the following > inline code: > > onclick="return confirm('Are you sure you want to delete this item?')" > > or > > onclick="return confirm(_('Are you sure you want to delete this item?'))" > > Perhaps that's a thought... when I tested the first option, it worked fine. Be careful : 1/ JavaScript in HTML attributes is not translatable 2/ Always use double quotes inside _() function because translation may add a single quote -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:25:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:25:26 +0000 Subject: [Koha-bugs] [Bug 11272] copy submit button on inventory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11272 --- Comment #15 from M. Tompsett --- (In reply to Jonathan Druart from comment #13) > Mark, please have a look at the historic of the report before reintroduce a > dead patch. It will take you to bug 12025 comment 4. Apologies. I was just working at lowering the "Patch does not apply" queue. I should have been a little more thorough in checking git logs, and noting see also's above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:27:57 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #30 from Jonathan Druart --- (In reply to Katrin Fischer from comment #28) > Starting for real now - testing this bug together with 13323 and 13324. Thanks! :) > DATABASE UPDATE > > 1) Some warns: > Use of uninitialized value in string eq at > ./installer/data/mysql/updatedatabase.pl line 10228. Yes, wrong check, the column is "orderstatus", not "status". (Commit "Bug 13321: Tax and prices calculation - DB Changes" amended) > 2) Shouldn't the second database update entry refer to the quantity somehow? > Why the hardcoded 2? And shouldn't we fix the first database entry here? Bit > worried about the round: > > + for my $order ( @$orders ) { > + $sth->execute( $order->{tax_value} * 2, $order->{ordernumber} ); > + } Hum... That's weird :) Should be tax_value = tax_value / quantity. Commit "Bug 13321: tax_value should contain the value for 1 item" amended. > QA SCRIPT AND AUTOMATED TESTS > > 3) Failing tests: > > - t/db_dependent/Budgets.t > > not ok 61 - total spent for budget1 is 160 > # Failed test 'total spent for budget1 is 160' > # at t/db_dependent/Budgets.t line 371. > # got: '0' > # expected: '160' > not ok 62 - total spent for budget11 is 100 > # Failed test 'total spent for budget11 is 100' > # at t/db_dependent/Budgets.t line 372. > # got: '0' > # expected: '100' > not ok 63 - total spent for budget111 is 20 > # Failed test 'total spent for budget111 is 20' > # at t/db_dependent/Budgets.t line 373. > # got: '0' > # expected: '20' I forgot to change the call to ModReceiveOrder. Same for t/db_dependent/Acquisition/OrderUsers.t (new file). Commit "Bug 13321: Rename variables" amended. Branch updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:31:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:31:51 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #15 from M. Tompsett --- Comment on attachment 37848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37848 [Signed-off] Bug 10625: Inventory/Stocktaking tool cannot handle windows file uploads Review of attachment 37848: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10625&attachment=37848) ----------------------------------------------------------------- ::: tools/inventory.pl @@ +174,5 @@ > + $barcode =~ s/\r/\n/g; > + $barcode =~ s/\n\n/\n/g; > + $barcode =~ s/\n$//; > + $barcode =~ s/^\n//; > + my @data = split(/\n/,$barcode); Because then I couldn't split the barcodes. I agree the logic might be more optimizable, but the idea is that if $barcode = "foo\nbar"; it needs to split into two barcodes: foo and bar. And given that some OS's may use \r and \n and \r\n in ways different than how $barcode=<$uploadbarcodes> works, I wanted to be certain that all middle combinations get split, and that there are no beginning or end strangeness. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:33:52 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #37 from Katrin Fischer --- I have checked with my coworkers, there will be mulitple $e and multiple $e, appearing in pairs, where the sequence in the field matters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:45:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:45:30 +0000 Subject: [Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:45:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:45:33 +0000 Subject: [Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 --- Comment #5 from Jonathan Druart --- Created attachment 38232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38232&action=edit Bug 14016: (follow-up) Restore correct date format on issue date (00:00 vs 23:59) Same for the overdues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:46:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:46:04 +0000 Subject: [Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > Going to pass this patch as it fixes the checkouts tab, but the problem is > still visible on the overdues tab - repeat test plan, but check out an item > with a due date in the past, so that you get an overdues tab in the patron > account. Yep, see last patch. It should be corrected in the same patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:47:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:47:25 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #29 from M. Tompsett --- Comment on attachment 36355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36355 Bug 10988 - Allow login via Google OAuth2 Review of attachment 36355: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10988&attachment=36355) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc @@ +58,4 @@ >
  • No private lists
  • >
  • New list
  • > [% END %] > + [% ELSIF ( GoogleOAuth2 ) %] I'd be surprised if there wasn't a [% USE Koha %] at the top of the file. Why pass preferences? Koha.Preference('GoogleOAuth2') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:56:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:56:37 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #12 from Marc V?ron --- Created attachment 38233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38233&action=edit [Signed-off] Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with standard field syntax and whitespace. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:56:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:56:53 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38221|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:57:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:57:06 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:59:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:59:16 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 10:59:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 08:59:19 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37956|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 38234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38234&action=edit [ALTERNATIVE PATCH] Bug 13482: Prevent race condition on printing a ReserveSlip The problem has been well described by Kyle and Nicole on bug 7255 description and comment 1. With this counter patch, I suggest to popup AFTER the return has been confirmed. This will remove the race condition and avoid to pass itemnumber to the pl file as in the patch submitted by Olli. Only the borrowernumber and biblionumber are needed (transfer and op are never used by circ/hold-transfer-slip.pl). Test plan: It is very hard to know all cases (at least 6) where the popup is displayed. Try at least to get the hold and the transfer confirmation messages. You should get the popup if you click on "print slip" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 11:00:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 09:00:15 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 --- Comment #13 from Jonathan Druart --- (In reply to Kyle M Hall from comment #11) > Tested alternate patch, I receive no popup print notice on the initial > checkin, print & confirm hold, but I do on the second time around: > > http://screencast.com/t/s7lnVcBwox The print_slip hidden input was not set to 1 for 1 button, the one you tested :) Please try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 11:24:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 09:24:55 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #34 from Marc V?ron --- Created attachment 38235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38235&action=edit [Signed-off] Bug 7595 - Add branchcode to accountlines Adds a branchcode column to the accountlines table. For payments, this inserts the branchcode of the library where the payment was recorded. For manual invoices, it insert the branchcode of the library where the manual invoice was created. NOTE: Rebased --- How I tested: - Apply patch - Do payments, create manual invoices, create credits for patrons and verified result using mysql. Note: Resolved easy conflict in updatedatabase.pl Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 11:25:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 09:25:26 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38225|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 11:25:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 09:25:38 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 11:26:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 09:26:58 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 11:38:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 09:38:22 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #21 from Marc V?ron --- Created attachment 38236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38236&action=edit [Signed-off] Bug 13889: Added Test Coverage Previous commit was lacking test coverage of new function. TEST PLAN --------- 1) Apply all the patches 2) prove -v t/db_dependent/Log.t -- should be success. 3) koha qa test tools Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 11:38:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 09:38:50 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 11:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 09:39:35 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 11:47:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 09:47:49 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- Kyle, can you explain please? [% OPACBaseURL %]/cgi-bin/koha/opac-shelves.pl?rss=1&viewshelf=[% shelfnumber %] But: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #210 from Kyle M Hall --- Created attachment 38265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38265&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e opac/svc/patron/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:23:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:23:00 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #211 from Kyle M Hall --- Created attachment 38266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38266&action=edit Bug 9303 [3] - relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:23:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:23:05 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #212 from Kyle M Hall --- Created attachment 38267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38267&action=edit Bug 9303 [QA Followup] - Remove extra 'USE Koha', change "Call number" back to "Call no." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:25:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:25:41 +0000 Subject: [Koha-bugs] [Bug 10938] item columns in different order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10938 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:25:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:25:44 +0000 Subject: [Koha-bugs] [Bug 10938] item columns in different order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10938 --- Comment #2 from Jonathan Druart --- Created attachment 38268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38268&action=edit Bug 10938: Item columns displayed in random order On the MARC detail page, the columns are displayed in a random order. This means that you can open 2 different records and see the columns displayed in a different order. Test plan: Go on different MARC detail view and confirm that 1/ all fields are present and 2/ they always are displayed in the same order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:25:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:25:49 +0000 Subject: [Koha-bugs] [Bug 10938] item columns in different order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10938 --- Comment #3 from Jonathan Druart --- Created attachment 38269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38269&action=edit Bug 10938: Item columns displayed in random order - OPAC Same as before for the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:33:04 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Nicole C. Engard --- 37404 - Bug 8417: Make the order receive date editable Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8417: Make the order receive date editable fatal: sha1 information is lacking or useless (acqui/orderreceive.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8417: Make the order receive date editable When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8417-Make-the-order-receive-date-editable-OHt7MP.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:35:17 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #24 from Jonathan Druart --- I don't get it, I created a new patron, didn't fill the date of birth, save I got null in DB and nothing in the input on editing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:35:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:35:49 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #25 from Jonathan Druart --- Ok sorry, too quick, I get it when modifying a patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:49:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:49:43 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22588|0 |1 is obsolete| | Attachment #22589|0 |1 is obsolete| | Attachment #22590|0 |1 is obsolete| | Attachment #22591|0 |1 is obsolete| | Attachment #22592|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Created attachment 38270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38270&action=edit Bug 8993: LDAP authentication improvements 1) allow multiple branch authentication 2) allow to use a Perl module to transform ldap entry into a Koha borrower These improvements needs koha-conf.xml to be modified. However, the old authentication mechanism is still there, and if you do not change your configuration file, it must continue to work exactly the same way. There's a POD file describing new features C4/LDAPAuthMethodTutorial.pod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:49:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:49:53 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 --- Comment #56 from Julian Maurice --- Created attachment 38271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38271&action=edit [DO NOT PUSH] Bug 8993: Sample LDAP transformation module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:51:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:51:20 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:51:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:51:24 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #26 from Jonathan Druart --- Created attachment 38272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38272&action=edit Bug 12633: Fix specific default values The dates should be set to undef if defined but empty, otherwise with an empty string, '0000-00-00' will be inserted into the DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:53:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:53:18 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #57 from Julian Maurice --- Patches rebased and cleaned. All indentation-only stuff was removed from patch to ease reading it (and make it easier to apply in the future). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 16:55:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 14:55:40 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #15 from Marc V?ron --- Applying: Bug 12747 - Add extra column in Z3950 search result fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12747 - Add extra column in Z3950 search result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:01:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:01:58 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38270|0 |1 is obsolete| | --- Comment #58 from Julian Maurice --- Created attachment 38273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38273&action=edit Bug 8993: LDAP authentication improvements 1) allow multiple branch authentication 2) allow to use a Perl module to transform ldap entry into a Koha borrower These improvements needs koha-conf.xml to be modified. However, the old authentication mechanism is still there, and if you do not change your configuration file, it must continue to work exactly the same way. There's a POD file describing new features C4/LDAPAuthMethodTutorial.pod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:02:03 +0000 Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple branch and transformation modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38271|0 |1 is obsolete| | --- Comment #59 from Julian Maurice --- Created attachment 38274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38274&action=edit [DO NOT PUSH] Bug 8993: Sample LDAP transformation module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:02:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:02:40 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37404|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 38275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38275&action=edit Bug 8417: Make the order receive date editable Currently the date of the order reception is the date of shipping date, which is wrong. This patch makes this date editable (with default is today). Test plan: 1/ Create an order and receive it 2/ Confirm that you can edit the reception date and it's take into account as the datereceived. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:02:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:02:38 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:04:53 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38093|0 |1 is obsolete| | Attachment #38094|0 |1 is obsolete| | Attachment #38095|0 |1 is obsolete| | Attachment #38096|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 38276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38276&action=edit Bug 11625 - Add system preferences DefaultToLoggedInLibraryCircRules and DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:05:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:05:03 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #40 from Kyle M Hall --- Created attachment 38277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38277&action=edit Bug 11625 - Implement DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:05:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:05:06 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #41 from Kyle M Hall --- Created attachment 38278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38278&action=edit Bug 11625 - Implement DefaultToLoggedInLibraryCircRules This patch set makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Passes QA script and tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:07:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:07:20 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #17 from Katrin Fischer --- I want to test something else before passing qa - thx for the follow-up :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:13:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:13:26 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:16:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:16:27 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #36 from M. Tompsett --- (In reply to Jonathan Druart from comment #35) > Please provide tests for changes in modules. True, most is covered: t/db_dependent/Accounts.t t/db_dependent/Circulation.t t/db_dependent/Circulation_issue.t t/db_dependent/Reserves.t However, the makepayment, chargelostitem, manualinvoice, recordpayment_selectaccts, and makepartialpayment need test coverage. I'm also not certain how to trigger _FixAccountForLostAndReturned, except that AddIssue does call it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:20:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:20:43 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35466|0 |1 is obsolete| | Attachment #35467|0 |1 is obsolete| | Attachment #38112|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 38279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38279&action=edit Bug 11747 - Add system preference DefaultToLoggedInLibraryOverdueTriggers Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:20:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:20:52 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 --- Comment #19 from Kyle M Hall --- Created attachment 38280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38280&action=edit Bug 11747 - Implement DefaultToLoggedInLibraryOverdueTriggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries" Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:22:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:22:14 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38280|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 38281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38281&action=edit Bug 11747 - Implement DefaultToLoggedInLibraryOverdueTriggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries" Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:24:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:24:41 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38234|0 |1 is obsolete| | --- Comment #14 from Mirko Tietgen --- Created attachment 38282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38282&action=edit Bug 13482: Prevent race condition on printing a ReserveSlip The problem has been well described by Kyle and Nicole on bug 7255 description and comment 1. With this counter patch, I suggest to popup AFTER the return has been confirmed. This will remove the race condition and avoid to pass itemnumber to the pl file as in the patch submitted by Olli. Only the borrowernumber and biblionumber are needed (transfer and op are never used by circ/hold-transfer-slip.pl). Test plan: It is very hard to know all cases (at least 6) where the popup is displayed. Try at least to get the hold and the transfer confirmation messages. You should get the popup if you click on "print slip" button. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:24:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:24:58 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:27:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:27:16 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #26 from Marc V?ron --- Created attachment 38283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38283&action=edit [Follow-up] Provide parameter $infos in cronlogaction() (Alternative for patch Bug 13889: Log with parameters) To test: - Apply patches interactive and skip following patch: Bug 13889: Log with parameters - Tweak a cron job in order to call cronlogaction twice, one with a param at the beginning of the cron ob, e.g. cronlogaction("This is my message") and one without param. - Run this cron job. Result: You should have two entries in the log, one with and one without additional information after the path and name of the calling script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:35:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:35:31 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37751|0 |1 is obsolete| | --- Comment #27 from Mirko Tietgen --- Created attachment 38284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38284&action=edit Bug 12633: Remove SQLHelper in C4::Members This is the only places where SQLHelper is still called. The C4::Members::Search is not used anymore, but ModMember and AddMember. This patch replaced the calls to SQLHelper to use DBIX::Class. TODO: Move them to Koha::Borrower. Test plan: 1/ Make sure the patron search still works (no changes expected since the code was not in used). 2/ Add a patron with all fields filled 3/ Add another patron with some fields filled 4/ Update them with other values 5/ Delete them You should not get any errors. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:35:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:35:37 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38272|0 |1 is obsolete| | --- Comment #28 from Mirko Tietgen --- Created attachment 38285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38285&action=edit Bug 12633: Fix specific default values The dates should be set to undef if defined but empty, otherwise with an empty string, '0000-00-00' will be inserted into the DB. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:36:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:36:02 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 17:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 15:57:42 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38240|0 |1 is obsolete| | --- Comment #16 from Charles Farmer --- Created attachment 38286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38286&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 18:00:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 16:00:27 +0000 Subject: [Koha-bugs] [Bug 14037] New: No way to trigger a hold when using itemBarcodeFallbackSearch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14037 Bug ID: 14037 Summary: No way to trigger a hold when using itemBarcodeFallbackSearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When using itemBarcodeFallbackSearch you can check out items without a barcode by searching them with the callnumber or title keywords. This works nicely. You can return the items from the patron account only, as you can't scan a barcode for the check in. The problem occurs, if there is a hold on the item - with a hold, you can't return it from the patron account. So you have to delete the hold, return it and then recreate the hold again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 18:03:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 16:03:54 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Do you mean something like: Confirm deletion of authority structure definition for 'Uniform Title' (UNIF_TITLE) in cgi-bin/koha/admin/authtypes.pl?op=delete_confirm&authtypecode=UNIF_TITLE 'Uniform Title' comes from the description of this authority type. Or am I looking at the wrong place? :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 18:18:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 16:18:15 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 --- Comment #2 from Katrin Fischer --- Try and delete one - it says: No, Do Not Delete... which is not what our rules say :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 18:51:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 16:51:22 +0000 Subject: [Koha-bugs] [Bug 13998] opac-ratings-ajax.pl is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13998 --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 38287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38287&action=edit Bug 13998: (RM followup) tests expect data on the database Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 18:55:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 16:55:57 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 19:56:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 17:56:38 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36497|0 |1 is obsolete| | Attachment #37074|0 |1 is obsolete| | --- Comment #14 from Blou --- Created attachment 38288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38288&action=edit Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice TEST PLAN 1) Create or improve on overduerules data .1) Intranet -> tools -> overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' Sponsored by : Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 20:00:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 18:00:03 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #15 from Blou --- Created attachment 38289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38289&action=edit Bug 13624 - Correcting the atomicupdate/ file. Dev-only patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 20:01:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 18:01:40 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #16 from Blou --- There was merging issues with updatedatabase.pl. Now replaced by new method using atomicupdate/ directory. I hope it all works well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 20:10:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 18:10:48 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 20:10:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 18:10:51 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38288|0 |1 is obsolete| | --- Comment #17 from Jesse Maseto --- Created attachment 38290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38290&action=edit Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice TEST PLAN 1) Create or improve on overduerules data .1) Intranet -> tools -> overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' Sponsored by : Halland County Library Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 20:46:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 18:46:06 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 20:46:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 18:46:09 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #4 from Kyle M Hall --- Created attachment 38291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38291&action=edit Bug 13986 - Implement fix for OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 21:27:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 19:27:26 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 21:53:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 19:53:52 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 --- Comment #3 from Marc V?ron --- git grep 'No, Do' koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 22:14:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 20:14:26 +0000 Subject: [Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 22:14:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 20:14:29 +0000 Subject: [Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38232|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 38292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38292&action=edit [PASSED QA] Bug 14016: (follow-up) Restore correct date format on issue date (00:00 vs 23:59) Same for the overdues. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 22:16:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 20:16:26 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35664|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 22:37:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 20:37:08 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- I found a problem, I hope this will be enough to reproduce: It's a transfer slip with a hold. What I did: - record with 1 item - staff user is in Midway - place record level hold with pickup location Fairfield - check item in in Midway - transfer slip is triggered (status is transfer now) - check the item in a second time in Midway - transfer slip is triggered BUT: Slip reads: no hold found Without the patch the slip is printed correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 22:45:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 20:45:19 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer --- Hm, I found another thing: The RSS feed will only list the first(?) 20 of a longer list. I am not sure why this happens and if there is a way to get a complete list. We have a system preference for the search results - numSearchRSSResults - maybe it should follow that? But I'd kinda expect it to give a full list or at least have an explanation or a link to get to the full list. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 22:48:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 20:48:31 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 23:00:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 21:00:38 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer --- Hi Jonathan, I think I located another use of the Search routine, can you please check? members/nl-search.pl: my $local_results = Search( $identifier ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 23:03:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 21:03:45 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #39 from Katrin Fischer --- With the other patches pushed, this one does no longer apply. Please fix your patch and switch back to 'signef off' again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 23:30:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 21:30:32 +0000 Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 21 23:30:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 21:30:36 +0000 Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37599|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 38293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38293&action=edit [PASSED QA] Bug 10985: [UNIMARC] Fix authority summary The problem is the template in authority type summary is not respected at all. It is only read to see which fields and subfields should appear in the summary. This patch fixes that. It also fixes a bug in auth_finder.pl plugin when summary contains fields other than 2XX. Test plan: 0/ You must use a UNIMARC setup for those tests 1/ edit an authority type summary with: NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*] 2/ create a new authority with previous fields (it is possible some fields don't exist). 3/ search this authority and verify the summary is someting like: NP : Name, D.-- NP -- 23849 ppn: my_ppn 4/ Verify some summary for existing authorities and check they are correct. 5/ Edit a biblio record and use the plugin auth_finder.pl (for example in a 7XX field) 6/ Do a search and verify the summary is correct 7/ Click on 'choose' or one of the numbered links ('1', '2', ... ; you should have multiple 2XX fields for the numbered links to show up) 8/ Verify that the biblio field is correctly filled. /!\ For the ppn, it should be defined in the zebra indexes. In MARC21 and NORMARC setups, this patch should change nothing, please verify that too (you can check that the auth_finder.pl plugin is still working and the auth type summary is correctly displayed in authorities search and auth_finder.pl plugin). Signed-off-by: Frederic Demians It works as described, both in authority search result page, and in authority data entry plugin. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 00:18:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 22:18:25 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA Keywords|Academy | --- Comment #16 from Katrin Fischer --- Hi Simith, starting with a code review here: Results of the QA script: FAIL C4/Accounts.pm OK critic FAIL forbidden patterns forbidden pattern: tab char (line 404) forbidden pattern: tab char (line 410) forbidden pattern: tab char (line 409) forbidden pattern: tab char (line 469) forbidden pattern: tab char (line 408) forbidden pattern: tab char (line 407) forbidden pattern: tab char (line 406) OK pod OK valid Also some tests seem to be failing: Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 512 Tests: 60 Failed: 2) Failed tests: 43-44 Non-zero exit status: 2 'Manual' code review: 1) Don't use double as the type, but decimal, as we are already using decimal in all other places where amounts are stored and double should not be used to store monetary values: + defaultreplacecost double(16,4) default NULL, -- default replacement cost + processfee double(16,4) default NULL, -- default text be recorded in the column note when the processing fee is applied + updatedatabase.pl as well (blocker) 2) Please amend POD of manualinvoice with the new type PF and the new parameter. Can you explain what notifyid is used for? (normal) 3) Spotting a translation problem here: + C4::Accounts::chargelostitem($issues, "Lost Item $issues->{'title'} $issues->{'barcode'}"); ... but it was there before your patch. 4) Please include the updated schema files in a separate patch file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 00:50:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 22:50:07 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #17 from Robin Sheat --- (In reply to Julian Maurice from comment #16) > Created attachment 38246 [details] [review] > Bug 13799: Change Mojolicious minimum version required (5.54) That won't help because the version we need to support is 2.98. I would strongly suggest separating the documentation stuff into another bug, and making the API stuff work with mojolicious 2.98, and deal with the documentation separately and more leisurely. As it is, I can't see it getting in as no one will be able to run it without manually cpanning things, which isn't an option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:03:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:03:58 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #23 from Chris Cormack --- String changes held for 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:04:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:04:57 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- String changes held for 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:08:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:08:01 +0000 Subject: [Koha-bugs] [Bug 6520] Items don't display when viewing staged records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6520 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:10:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:10:15 +0000 Subject: [Koha-bugs] [Bug 13947] serials/subscription-history.pl calls GetBiblio incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:13:44 +0000 Subject: [Koha-bugs] [Bug 13991] Uninitialized value $src in /tools/viewlog.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13991 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:15:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:15:13 +0000 Subject: [Koha-bugs] [Bug 13803] SelfCheck not setting flag when item requires transit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13803 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:18:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:18:22 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:21:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:21:49 +0000 Subject: [Koha-bugs] [Bug 13975] Warning "Use of the encoding pragma is deprecated" in misc/export_borrowers.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13975 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:24:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:24:03 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #34 from Chris Cormack --- Doesn't apply to 3.18.x please rebase if it is needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:25:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:25:07 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- String changes held for 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:29:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:29:22 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 --- Comment #4 from David Cook --- (In reply to Fridolin SOMERS from comment #3) > Be careful : > 1/ JavaScript in HTML attributes is not translatable > 2/ Always use double quotes inside _() function because translation may add > a single quote Good to know :). I don't have any plans to work on this anyway, but good to know :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 01:29:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 Apr 2015 23:29:23 +0000 Subject: [Koha-bugs] [Bug 9978] Update GNU licenses header in Koha files from GPL2 to GPL3 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9978 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #18 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 02:29:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 00:29:09 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 03:19:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 01:19:31 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 03:19:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 01:19:34 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37411|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 38294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38294&action=edit Bug 13887 - Add datatables to item specific holds table This patch adds datatables functionality to the item specific holds table To test: 1 - Apply patch 2 - Attempt to place an item specific hold for a patron 3 - Note that columns are now sortable and searchable 4 - Ensure that you can place both specific and next available holds as before Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 03:19:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 01:19:40 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #10 from Nick Clemens --- Created attachment 38295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38295&action=edit [QA Follow up] Tab fix and "intranet-tmpl" to "[% interface %]" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 03:27:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 01:27:40 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #11 from Nick Clemens --- (In reply to Jonathan Druart from comment #8) > Hi Nick, > > 1/ The table does not have the tbody element Added - did the whitespace fixes in patch as it was adding a level > 2/ Why don't you add the search box? It could be useful I thought the search box is added by default on koha datatables, appears for me when applied, does it need to be added explicitly in this template? > 3/ The "information" column should sort on due date value, don't you think? Do you mean that should be the default sort? I liked it sorting on the hold column/ability to place a hold and that seemed the most useful. It is common for us to have only 2 or 3 items out of 50 available for hold, but we do use holds in an uncommon manner. > Marked as Failed QA for 1 and Discussion for 2-3. Setting back to signed-off but willing to change #2 or #3 if necessary Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 03:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 01:57:42 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #40 from Winona Salesky --- Thanks I will do that. However, I think this bug and 13383, introduce some contradictory logic. I will push this one first, once it gets signed off and is pushed to master I will rework #13383 so they play nicely together. -Winona (In reply to Katrin Fischer from comment #39) > With the other patches pushed, this one does no longer apply. Please fix > your patch and switch back to 'signef off' again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 04:11:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 02:11:17 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 --- Comment #5 from David Cook --- So Liz Rea is a genius! She pointed out that the problem only arises if the screen is using the result browser! For instance: http://192.168.1.61:2112/cgi-bin/koha/cataloguing/additem.pl?biblionumber=1&searchid=scs_1429666452994 Deletes item after "Cancel". http://192.168.1.61:2112/cgi-bin/koha/cataloguing/additem.pl?biblionumber=1 Doesn't delete item after "Cancel". -- The cause is in "koha-tmpl/intranet-tmpl/js/browser.js": $('a[href*="biblionumber="]').click(function (ev) { ev.preventDefault(); window.location = $(this).attr('href') + '&searchid=' + me.searchid; }); Basically, this is rewriting the URL for all the other links on the page, so that when you click... "Edit", "Delete", "Normal", etc. you still have that searchid parameter. Now... it seems to me that the thing to do is either be more sophisticated with the Javascript magic (i.e. parse the href, find the query string, add the key=value appropriately, then set the href for the element before it browser acts on it), or... handle it server-side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 04:12:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 02:12:23 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 --- Comment #6 from David Cook --- Follow-up... that bit of Javascript will do a window.location regardless of the outcome of the "confirm_deletion(); return false;" onclick stuff. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 04:13:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 02:13:21 +0000 Subject: [Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943 --- Comment #7 from David Cook --- (In reply to David Cook from comment #5) > Basically, this is rewriting the URL Well, rewriting the URL and redirecting to it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 04:19:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 02:19:38 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 --- Comment #4 from M. Tompsett --- Created attachment 38296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38296&action=edit Bug 14030 - Added tests for duplicates. It seems that the id's are not really used, but rather the subtags, types, and language related fields. These tests check for duplicates. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Languages.t -- may fail if you have duplicates. 3) ./installer/data/mysql/updatedatabase.pl -- this will trigger the atomicupdate, which because of this tweak, will correct duplicates. 4) prove -v t/db_dependent/Languages.t -- should succeed. 5) Run the updatedatabase.pl script multiple times. 6) prove -v t/db_dependent/Languages.t -- should still succeed. 7) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 04:35:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 02:35:26 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38224|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 38297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38297&action=edit Bug 14030: Add Georgian language and fix Kannada language code This patch adds Georgian language and a fix wrong language code Language added: Georgian - ka - geo I selected 'geo' for ISO639-2 instead of 'kat' because it's the same code form http://www.loc.gov/marc/languages/language_code.html Also a fix is needed to Kannada ISO639-1 code, from 'ka' to 'kn' To test: 1) Apply the patch 2) Run updatedatabase.pl (once) 3) Check language, e.g. go to staff > search > More options > Limits and search for Georgian on language list I only added language code 'ka', not script 'Geor' nor country 'GE', the plan is to name translation files 'ka-*', but can ammend the patch if needed. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 04:35:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 02:35:32 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38296|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 38298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38298&action=edit Bug 14030 - Added tests for duplicates. It seems that the id's are not really used, but rather the subtags, types, and language related fields. These tests check for duplicates. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Languages.t -- may fail if you have duplicates. 3) ./installer/data/mysql/updatedatabase.pl -- this will trigger the atomicupdate, which because of this tweak, will correct duplicates. 4) prove -v t/db_dependent/Languages.t -- should succeed. 5) Run the updatedatabase.pl script multiple times. 6) prove -v t/db_dependent/Languages.t -- should still succeed. 7) koha qa test tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 04:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 02:36:24 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 --- Comment #7 from M. Tompsett --- I can't sign off my own patches, hence we still need sign off. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 04:51:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 02:51:43 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 04:51:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 02:51:45 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37591|0 |1 is obsolete| | --- Comment #41 from Winona Salesky --- Created attachment 38299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38299&action=edit Bug 13382 - RDA: 700/710/711 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span class=separator |. Adds Related and Contained Works as new headings. 7) Repeat steps 4 - 6 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 05:00:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 03:00:24 +0000 Subject: [Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- (In reply to Tom?s Cohen Arazi from comment #1) > - Reload the about page > => SUCCESS: A zebra configuration missmatch is shown. Without the patch, I get one warning. With the patch I get two. The first is a grs1 is deprecated message, which is valid. The second is bothersome, because it says I have dom set, but my koha-conf.xml was tweaked to grs1. It also says my configuration looks like it is for grs1, which I had it set up for dom before the single line configuration file tweak. So, the error triggered does not represent the actual problem. How should we proceed with this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 05:20:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 03:20:56 +0000 Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 --- Comment #3 from M. Tompsett --- Comment on attachment 37976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37976 Bug 10222 - Error when saving Demco label templates Review of attachment 37976: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10222&attachment=37976) ----------------------------------------------------------------- ::: installer/data/mysql/en/optional/sample_creator_data.sql @@ +27,4 @@ > > LOCK TABLES `printers_profile` WRITE; > /*!40000 ALTER TABLE `printers_profile` DISABLE KEYS */; > +INSERT INTO `printers_profile` VALUES (1,'Library Laser',1,'Bypass',-2,9,3,0,'POINT','Labels'),(13,'Library Laser',7,'Tray 1',0,0,0,0,'POINT','Labels'),(14,'Library Laser',12,'Tray 2',0,0,0,0,'POINT','Labels'),(16,'Test Printer 01',23,'Test Bin',0,0,0,0,'POINT','Patroncards'),(22,'Library Laser',0,'Tray 3',0,0,0,0,'POINT','Labels'); Why remove 11? Why are the columns not explicitly named? Also, perhaps splitting lines for human readability might be an idea. And maybe INSERT IGNORE? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 06:03:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 04:03:14 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #4 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 06:03:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 04:03:25 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38275|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 06:03:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 04:03:32 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 --- Comment #5 from sandboxes at biblibre.com --- Created attachment 38300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38300&action=edit Bug 8417: Make the order receive date editable Currently the date of the order reception is the date of shipping date, which is wrong. This patch makes this date editable (with default is today). Test plan: 1/ Create an order and receive it 2/ Confirm that you can edit the reception date and it's take into account as the datereceived. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 06:28:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 04:28:45 +0000 Subject: [Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 06:28:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 04:28:55 +0000 Subject: [Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 06:29:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 04:29:03 +0000 Subject: [Koha-bugs] [Bug 13236] Regression: Table of checkouts no longer preselects overdue items for rewewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13236 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 06:29:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 04:29:11 +0000 Subject: [Koha-bugs] [Bug 13293] Regression: Override renewal limit option broken with AJAX circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13293 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:12:40 +0000 Subject: [Koha-bugs] [Bug 13932] Allow a header to be considered trusted to provide the userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13932 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:12:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:12:42 +0000 Subject: [Koha-bugs] [Bug 13932] Allow a header to be considered trusted to provide the userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13932 --- Comment #1 from Robin Sheat --- Created attachment 38301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38301&action=edit Bug 13932: add support for a trusted HTTP header This adds support for a 'trusted_header' option in koha-conf.xml that specified an HTTP header that you trust that contains the userid. This is to allow Koha to be behind a reverse proxy (for example, running plack fronted by apache) that does user authentication/authorisation. Note: for reasons I can't really tell, this doesn't work when apache is running Koha as CGI, but does work under plack. Test plan: * have a koha-plack setup. * configure apache to send it a header: RequestHeader set X_REMOTE_USER "testuserid" * add X_REMOTE_USER to koha-conf.xml * verify that the user behaves as though they're logged in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:14:39 +0000 Subject: [Koha-bugs] [Bug 13932] Allow a header to be considered trusted to provide the userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13932 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:29:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:29:10 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia at hotmail.com --- Comment #11 from Aleisha Amohia --- When running updatedatabase.pl - Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at updatedatabase.pl line 37. BEGIN failed--compilation aborted at updatedatabase.pl line 37. Hoping this wasn't just me testing this wrong, setting as Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:31:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:31:20 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Katrin Fischer --- Hi Aleisha, you have to make sure your environment variables are set correctly or that you are using the koha shell (depending on how your Koha is set up) - I have checked the updatedatabase, it looks ok. Could you try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:34:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:34:59 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #35 from Katrin Fischer --- It's needed - library found this in 3.18.5.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:38:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:38:45 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #36 from Chris Cormack --- Right, well you've (collective you) have a few hours to get it in a state to apply on 3.18.x (until Bernardo sends the po files and I do the release that is) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:39:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:39:38 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #37 from Katrin Fischer --- Trying to see if I can fix it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:41:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:41:17 +0000 Subject: [Koha-bugs] [Bug 13981] Transliterate rule for oe and ae In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13981 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:42:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:42:12 +0000 Subject: [Koha-bugs] [Bug 14014] Argument "" isn't numeric in numeric gt (>) in circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14014 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:44:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:44:31 +0000 Subject: [Koha-bugs] [Bug 13917] OPAC: Putting holds still possible by URL even if turned off by system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13917 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:52:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:52:19 +0000 Subject: [Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with * In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 07:56:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 05:56:15 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38020|0 |1 is obsolete| | --- Comment #38 from Katrin Fischer --- Created attachment 38302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38302&action=edit [3.18.x] Bug 12847: Items issued today is considered as overdue The date comparisons in C4::Members::IssueSlip does not work as expected. Is an item is issue yesterday and due today (23:59), it should not be considered as an overdue yet. Test plan: Define a valid issue slip (code ISSUESLIP) Check 2 items out and update the issuedate value for one of them as yesterday (using the mariadb/mysql cli or similar) Print the slip Before this patch the item marked as issued yesterday is considered as overdue. Special cases: - hourly loans - Quick slip is impacted too Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Bug 13601 is not in 3.18.x, so I removed the change connected to that and it still tested ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 08:13:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 06:13:21 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- Hi Kyle, I did some tests with the new patches: Record has 1 item, is not checked out. -t -c ERROR DELETING BIBLIO 24: Test mode enabled I was not sure if this would have been an error outside the test mode (not being deleted) or if that just meant that it was not deleted because of the test mode. -t -i -c ERROR DELETING ITEM 102: Test mode enabled ERROR DELETING BIBLIO 24: Test mode enabled Ok, so both throw an error... so not sure: would those be deleted without -t? -c ERROR DELETING BIBLIO 24: This Biblio has items attached, please delete them first before deleting this biblio This one is good - why not display this in the test mode too? -c -i C4::Context->userenv not defined! at /home/katrin/kohaclone/C4/Items.pm line 2278. No messages, but I didn't set verbose. Item and record appear to have been deleted - can you take a look at the error/warn? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 08:20:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 06:20:00 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #30 from Marc V?ron --- git grep ' Search(' result: members/nl-search.pl: my $local_results = Search( $identifier ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 08:45:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 06:45:13 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #18 from Julian Maurice --- Swagger2 is not only for documentation. The API code needs Mojolicious::Plugin::Swagger2, which needs Swagger2, which needs Mojolicious >= 5.54 because Swagger2 fails to compile with a smaller version of Mojolicious. Anyway, Jessie will become the new stable in few days. Should we just wait before integrating this ? But what about swagger2, which is not packaged at all ? It is not the only Perl module that needs to be "cpanned" for Koha. So why should we block for this one ? Koha will continue to work without it. If really needed, it shouldn't be hard to make a Debian package of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 08:53:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 06:53:17 +0000 Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS --- Was pushed in 3.16.09 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 09:01:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 07:01:55 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 --- Comment #4 from Marc V?ron --- Created attachment 38303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38303&action=edit Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 09:02:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 07:02:47 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 09:08:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 07:08:23 +0000 Subject: [Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 --- Comment #13 from Fridolin SOMERS --- Pushed to 3.14, will be in 3.14.15. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 09:15:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 07:15:30 +0000 Subject: [Koha-bugs] [Bug 13523] AddBiblio fails on mysql with STRICT_TRANS_TABLES In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13523 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #22 from Fridolin SOMERS --- Pushed to 3.14, will be in 3.14.15. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 09:17:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 07:17:54 +0000 Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch --- Comment #12 from Fridolin SOMERS --- Pushed to 3.14, will be in 3.14.15. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 09:58:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 07:58:26 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 09:58:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 07:58:29 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 --- Comment #16 from Jonathan Druart --- Created attachment 38304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38304&action=edit Bug 13482: Sent biblionumber to the template The biblionumber is sent to the template as 'itembiblionumber' at 1 place, the template get the 'biblionumber' variable. I don't understand why but the easy way is to sent the variable twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 09:59:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 07:59:09 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #5 from Marc V?ron --- Created attachment 38305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38305&action=edit [Signde-off] Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 09:59:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 07:59:46 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 09:59:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 07:59:52 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 --- Comment #17 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > I found a problem, I hope this will be enough to reproduce: > > It's a transfer slip with a hold. > > What I did: > - record with 1 item > - staff user is in Midway > - place record level hold with pickup location Fairfield > - check item in in Midway - transfer slip is triggered (status is transfer > now) > - check the item in a second time in Midway - transfer slip is triggered > BUT: Slip reads: no hold found > Without the patch the slip is printed correctly. Good catch Katrin. This template is a mess, I tried to fix the problem easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:00:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:00:04 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38291|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:16:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:16:28 +0000 Subject: [Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #39 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:18:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:18:36 +0000 Subject: [Koha-bugs] [Bug 14038] New: SQLHelper replacement - C4::Members::Search - nl-search.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Bug ID: 14038 Summary: SQLHelper replacement - C4::Members::Search - nl-search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, magnus at enger.priv.no members/nl-search.pl currently uses C4::Members::Search. To get rid of SQLHelper, we should not use this subroutine anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:19:18 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14038 --- Comment #31 from Jonathan Druart --- (In reply to Katrin Fischer from comment #29) > Hi Jonathan, > > I think I located another use of the Search routine, can you please check? > > members/nl-search.pl: my $local_results = Search( $identifier ); Good catch, bug 14038 opened. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:19:18 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12633 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:23:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:23:28 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:23:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:23:30 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 --- Comment #1 from Jonathan Druart --- Created attachment 38306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38306&action=edit Bug 14038: Make nl-search.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan for Magnus :) 0/ Enable the pref you need to use the Norwegian national library card ft 1/ Go on the members/nl-search.pl page and search for patrons. 2/ Make sure you search by card number and by "social security number" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:25:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:25:23 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:37:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:37:41 +0000 Subject: [Koha-bugs] [Bug 13510] Cross site scripting in opac lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13510 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #21 from Mason James --- Pushed to 3.16.x will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:38:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:38:16 +0000 Subject: [Koha-bugs] [Bug 12971] Regression: Patron print summary doesn't show checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12971 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:38:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:38:32 +0000 Subject: [Koha-bugs] [Bug 12642] SMS.t requires a database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:39:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:39:38 +0000 Subject: [Koha-bugs] [Bug 11978] OverDrive API now prepends http:// to URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:49:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:49:54 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #12 from Marc V?ron --- Created attachment 38307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38307&action=edit [Signed-off] Bug 13919 - Unit Test Tested both unit test patches together. Without main patch applied: do not pass as expected / with main patch pass OK as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:51:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:51:22 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #13 from Marc V?ron --- Created attachment 38308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38308&action=edit [Signed-off] Bug 13919: Make the tests pass fixing the number of tests Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:51:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:51:54 +0000 Subject: [Koha-bugs] [Bug 12238] tools/export.pl: file list of ids as input parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12238 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #7 from Mason James --- Enhancement, skipping patch for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:52:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:52:43 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #37376|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:53:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:53:00 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:53:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:53:01 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Status|Pushed to Master |Pushed to Stable Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:53:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:53:46 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:54:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:54:54 +0000 Subject: [Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 10:55:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 08:55:55 +0000 Subject: [Koha-bugs] [Bug 3186] invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:06:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:06:32 +0000 Subject: [Koha-bugs] [Bug 14025] Fix display of links from 856$u in the OPAC for NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Implement |Fix display of links from |OPACURLOpenInNewWindow for |856$u in the OPAC for |NORMARC |NORMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:10:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:10:23 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:10:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:10:26 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38294|0 |1 is obsolete| | Attachment #38295|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 38309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38309&action=edit Bug 13887 - Add datatables to item specific holds table This patch adds datatables functionality to the item specific holds table To test: 1 - Apply patch 2 - Attempt to place an item specific hold for a patron 3 - Note that columns are now sortable and searchable 4 - Ensure that you can place both specific and next available holds as before Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:10:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:10:30 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #13 from Jonathan Druart --- Created attachment 38310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38310&action=edit Bug 13887: Tab fix and "intranet-tmpl" to "[% interface %]" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:10:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:10:34 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #14 from Jonathan Druart --- Created attachment 38311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38311&action=edit Bug 13887: Fix sDom to display what is needed in the table 1/ Add the information 'showing x to y of z' 2/ Remove some lost pixels Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:10:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:10:38 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #15 from Jonathan Druart --- Created attachment 38312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38312&action=edit Bug 13887: Move the caption into a h2 With the DT filter, the caption is between the table and the filter. It looks better with the caption as a h2 on top of the table. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:10:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:10:43 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #16 from Jonathan Druart --- Created attachment 38313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38313&action=edit Bug 13887: Display the due date as a due date + sort on info The due dates should be displayed as due dates :) i.e not displayed with 23:59 On the way, this patch fixes the sort on the info column. The column is now sorted using the due dates Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:14:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:14:10 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #17 from Jonathan Druart --- Nick, Could you please test the 3 followups I have added? They improves the ergonomic of the page, The first one modify the default sDom for a better render, the second one move the caption above the filter and the last one displays the due dates correctly (and fixes the column sorting). Feel free to obsolete them if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:21:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:21:32 +0000 Subject: [Koha-bugs] [Bug 14039] New: Add patron title to checkout screen Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Bug ID: 14039 Summary: Add patron title to checkout screen Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When checking out an item to a user, it sounds more professional if the patron can be addressed as Mr / Mrs / Miss etc, but this information doesn't display to the staff member, who has to click on the details tab in order to find out how the patron should be addressed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:21:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:21:48 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:24:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:24:15 +0000 Subject: [Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:24:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:24:37 +0000 Subject: [Koha-bugs] [Bug 10926] print slip different in two places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- It seems to be fixed, please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:24:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:24:45 +0000 Subject: [Koha-bugs] [Bug 13025] Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13025 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:25:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:25:09 +0000 Subject: [Koha-bugs] [Bug 13432] SIP Server does not respect timeout setting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13432 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:25:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:25:44 +0000 Subject: [Koha-bugs] [Bug 13339] Cart button doesn't open the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:26:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:26:42 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts at ptfs-europe.c | |om --- Comment #1 from David Roberts --- Created attachment 38314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38314&action=edit Proposed patch To test: Install this patch. Ensure a user has a salutation (Mr, Dr, Miss etc) set, and checkout an item to this user. In the area above the barcode box, the patron's title should display, e.g: Checking out to Mr John Doe (0001). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:27:06 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:28:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:28:55 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #14 from Marc V?ron --- Created attachment 38315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38315&action=edit [Signed-off] Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:29:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:29:21 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:29:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:29:29 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:31:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:31:58 +0000 Subject: [Koha-bugs] [Bug 10923] can't move a hold to the bottom with numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10923 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- I am not sure this is a bug. The behavior is still the same on master. For instance you have 5 holds, priorities are 1, 2, 3, 4, 5 You ask for 1, 2, 3, 5, 5 There is no 4, so one of the 5 is picked (actually the first one). If you want to put it at the end, you can do: 1, 2, 3, 5, 4 It will work. Please reopen if I missed something. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:51:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:51:05 +0000 Subject: [Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:51:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:51:07 +0000 Subject: [Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 --- Comment #2 from Jonathan Druart --- Created attachment 38316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38316&action=edit Bug 10913: The delete basket confirmation page is never displayed This condition is never reached, the confirmation to delete a basket is done with a popup in the template. Test plan: Confirm you don't find any regression when creation/editing and deleting a basket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:51:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:51:11 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #11 from Dobrica Pavlinusic --- We have a minor problem with databases created with When trying to access it with mysql client from command line, I get following error in where: Illegal mix of collations (utf8_unicode_ci,IMPLICIT) and (utf8_general_ci,IMPLICIT) for operation '=' However, fix is simple: mysql> alter database koha collate = 'utf8_unicode_ci' ; I'm wondering if we should alter database collate also to avoid problems like this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:51:28 +0000 Subject: [Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:53:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:53:31 +0000 Subject: [Koha-bugs] [Bug 10910] You can delete a patron who has made suggestions without any warn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10909 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 11:53:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 09:53:31 +0000 Subject: [Koha-bugs] [Bug 10909] You can delete a patron who has created virtualsheves without any warn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10909 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10910 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:01:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:01:02 +0000 Subject: [Koha-bugs] [Bug 10899] "creation_date" in "news -> edit/create" displays 02/00/0 when the date inputed is 08/11/1940 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- That's not a bug, the creation date is stored into opac_news.timestamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:04:35 +0000 Subject: [Koha-bugs] [Bug 11357] biblio.size value not correctly displayed in list emails sent from OPAC and intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Keywords|rel_3_16_candidate | --- Comment #11 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:06:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:06:16 +0000 Subject: [Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #16 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:20:35 +0000 Subject: [Koha-bugs] [Bug 10866] Books entered in malayalam language cannot to search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10866 --- Comment #2 from Jonathan Druart --- Created attachment 38317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38317&action=edit Bug 10866: Hide patron's history if intranetreadinghistory is set to not allow If set to "not allow", the intranetreadinghistory pref prevent staff members to access patron's checkout history. But: 1/ The page is still accessible if you know the url 2/ The history can be consulted on the item history page Test plan: 0/ Don't apply this patch 1/ Set the intranetreadinghistory to allow 2/ Go on a patron's checkout history page 3/ Open a new tab and go on a item's checkout history page 4/ Set the intranetreadinghistory to not allow 5/ Refresh both pages => no change 6/ Apply this patch 7/ Refresh both page. On the first page, you should see a warning On the other one, you should see that the patron column is not displayed anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:20:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:20:46 +0000 Subject: [Koha-bugs] [Bug 10886] When intranetreadinghistory is set to not allow - staff can still view patron's history in item history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Severity|minor |normal Version|3.10 |master CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:21:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:21:14 +0000 Subject: [Koha-bugs] [Bug 10886] When intranetreadinghistory is set to not allow - staff can still view patron's history in item history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10886 --- Comment #3 from Jonathan Druart --- Created attachment 38318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38318&action=edit Bug 10886: Hide patron's history if intranetreadinghistory is set to not allow If set to "not allow", the intranetreadinghistory pref prevent staff members to access patron's checkout history. But: 1/ The page is still accessible if you know the url 2/ The history can be consulted on the item history page Test plan: 0/ Don't apply this patch 1/ Set the intranetreadinghistory to allow 2/ Go on a patron's checkout history page 3/ Open a new tab and go on a item's checkout history page 4/ Set the intranetreadinghistory to not allow 5/ Refresh both pages => no change 6/ Apply this patch 7/ Refresh both page. On the first page, you should see a warning On the other one, you should see that the patron column is not displayed anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:21:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:21:30 +0000 Subject: [Koha-bugs] [Bug 10866] Books entered in malayalam language cannot to search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10866 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > Created attachment 38317 [details] [review] > Bug 10866: Hide patron's history if intranetreadinghistory is set to not > allow This was for bug 10886. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:22:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:22:20 +0000 Subject: [Koha-bugs] [Bug 10886] When intranetreadinghistory is set to not allow - staff can still view patron's history in item history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:26:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:26:17 +0000 Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 --- Comment #4 from Chris Nighswonger --- (In reply to M. Tompsett from comment #3) > Why remove 11? Because it was a mistake from the beginning. (I wrote the original, btw.) > Why are the columns not explicitly named? Why should they be named? > And maybe INSERT IGNORE? No need. This is only executed upon a fresh install. Why switch this back to "Needs Signoff?" Did you test it and have it fail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:28:34 +0000 Subject: [Koha-bugs] [Bug 14040] New: Confusing messages on items placed on hold in OPAC and staff Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14040 Bug ID: 14040 Summary: Confusing messages on items placed on hold in OPAC and staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org 1) Record with 1 item 2) Check out the item to a user 3) Place an item level hold for another patron 4) Place another hold for another patron in the OPAC Item displays: On hold for patron expected at since 14/04/2015 . This is confusing for the staff user and even more for the patron in the OPAC. I think it means: - it has been placed on hold on 14/4... because the due date is 06/05/2015 (dd/mm) I'd suggest: - Showing the OPAC user only the number of other holds on the item - they might want to pick another then. - Showing the staff user a better message - don't show the branchcode, but the branchname - don't show the branchname, if there is only 1 branch in the system and/or obey SingleBranchmMode - change 'expected' to ...? Fixing this on the OPAC and staff could be done separately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:28:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:28:38 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:29:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:29:10 +0000 Subject: [Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13333 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:32:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:32:04 +0000 Subject: [Koha-bugs] [Bug 14041] New: Use of uninitialized value in /usr/share/kohaclone/svc/checkouts Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14041 Bug ID: 14041 Summary: Use of uninitialized value in /usr/share/kohaclone/svc/checkouts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com checkouts: Use of uninitialized value in string comparison (cmp) at /usr/share/kohaclone/svc/checkouts line 211 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:33:37 +0000 Subject: [Koha-bugs] [Bug 12860] Tools > Data export : "Don't export fields" option doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12860 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:34:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:34:44 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11215 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:34:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:34:44 +0000 Subject: [Koha-bugs] [Bug 11215] Unresponsive script warning when booksellers.pl is loading a list of all vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13371 --- Comment #4 from Jonathan Druart --- Maybe this could be fixed by bug 13371. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:54:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:54:18 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 --- Comment #1 from Jonathan Druart --- Created attachment 38319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38319&action=edit Bug 11064: Hide the framework choice when importing biblio This choice is ignored, it's preferable to hide it. Test plan: 0/ Before to apply the patch, confirm the issue 1/ Stage some records for import and on the detail of the batch (/tools/manage-marc-import.pl?import_batch_id=XXX), confirm the framework dropdown list does not appear anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:54:15 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:54:49 +0000 Subject: [Koha-bugs] [Bug 13638] Batch patron modification tool missing option to switch language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13638 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:55:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:55:13 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- This patch does not fix the problem but hide the framework choice. It will prevent to pretend it works! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:55:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:55:34 +0000 Subject: [Koha-bugs] [Bug 11064] batch import ignoring framework choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:56:22 +0000 Subject: [Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #7 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 12:56:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 10:56:57 +0000 Subject: [Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:00:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:00:55 +0000 Subject: [Koha-bugs] [Bug 13298] Holds ratios report ignores ordered items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13298 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #7 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:02:41 +0000 Subject: [Koha-bugs] [Bug 11954] Clean up currency default files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11954 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:03:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:03:04 +0000 Subject: [Koha-bugs] [Bug 12323] Acquisitions search results fixed in order of biblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12323 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:03:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:03:23 +0000 Subject: [Koha-bugs] [Bug 13431] Shared FastMmap file causes issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:06:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:06:11 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:06:13 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #1 from Jonathan Druart --- Created attachment 38320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38320&action=edit Bug 11006: Drop column aqorders.totalamount This column was not used in the Koha codebase, it can be removed. Test plan: Execute the updatedatabase.pl script and confirm that the column has been dropped. QA step: 1/ git grep totalamount 2/ prove t/db_dependent/Acquisition.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:06:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:06:33 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:13:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:13:52 +0000 Subject: [Koha-bugs] [Bug 10979] No undef checks in DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Jonathan Druart --- Koha::DateUtils has been highly improved recently. The parameters and exceptions should be correctly managed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:17:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:17:51 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:17:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:17:53 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38311|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 38321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38321&action=edit Bug 13887: Fix sDom to display what is needed in the table 1/ Add the information 'showing x to y of z' 2/ Remove some lost pixels Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:18:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:18:00 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38312|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 38322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38322&action=edit Bug 13887: Move the caption into a h2 With the DT filter, the caption is between the table and the filter. It looks better with the caption as a h2 on top of the table. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:18:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:18:06 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38313|0 |1 is obsolete| | --- Comment #20 from Nick Clemens --- Created attachment 38323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38323&action=edit Bug 13887: Display the due date as a due date + sort on info The due dates should be displayed as due dates :) i.e not displayed with 23:59 On the way, this patch fixes the sort on the info column. The column is now sorted using the due dates Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:19:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:19:47 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #21 from Nick Clemens --- (In reply to Jonathan Druart from comment #17) > Could you please test the 3 followups I have added? Tested, they definitely improve the page, thanks for fixing it up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:28:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:28:15 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:28:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:28:18 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 --- Comment #1 from Jonathan Druart --- Created attachment 38324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38324&action=edit Bug 10976: Fix typo itemtype vs itemtypes When creating a new report, the limit step let you choose itype|itemtype. But it should be itype|itemtypes. If you try to create a guided report and you choose this option as a limit, you will get a warning on saving it: Errors found when processing parameters for report: itype: The authorized value category (itemtype) you selected does not exist. Looking at the code: reports/guided_reports.pl l.657 elsif ( $authorised_value eq "itemtypes" ) { Test plan: 0/ Don't apply the patch 1/ Create a guided report, select Koha itemtype as a limit(step 4) 2/ Confirm you get the error when saving 3/ Apply the patch and repeat step 1 4/ There is no error and the report should work correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:31:28 +0000 Subject: [Koha-bugs] [Bug 10975] addbiblio.pl checks if marcflavour equals "usmarc" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 13635 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:31:28 +0000 Subject: [Koha-bugs] [Bug 13635] $record->title is called even if marc flavour is UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #15 from Jonathan Druart --- *** Bug 10975 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:31:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:31:57 +0000 Subject: [Koha-bugs] [Bug 10975] addbiblio.pl checks if marcflavour equals "usmarc" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10975 --- Comment #2 from Jonathan Druart --- This test has been removed and corrected by bug 13635. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:36:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:36:47 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 --- Comment #19 from Kyle M Hall --- Agreed, I think it should be a the full list. (In reply to Katrin Fischer from comment #18) > Hm, I found another thing: The RSS feed will only list the first(?) 20 of a > longer list. I am not sure why this happens and if there is a way to get a > complete list. > > We have a system preference for the search results - numSearchRSSResults - > maybe it should follow that? But I'd kinda expect it to give a full list or > at least have an explanation or a link to get to the full list. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:37:35 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:37:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:37:37 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 --- Comment #20 from Kyle M Hall --- Created attachment 38325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38325&action=edit Bug 1917 [QA Followup] - Don't limit the list results for RSS feeds -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:48:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:48:08 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:48:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:48:10 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 --- Comment #1 from Jonathan Druart --- Created attachment 38326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38326&action=edit Bug 10947: Fix editing the default authority type The default authority type cannot be defined. The authtypecode is en empty string and the tests should be done on "defined", not "exist". Test plan: Edit the default authority type, save it. Note: There is no way to create an authority with an empty string, with you deleted you won't be able to recreate it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:48:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:48:22 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:58:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:58:11 +0000 Subject: [Koha-bugs] [Bug 14042] New: The authority type admin page manage its own pagination Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 Bug ID: 14042 Summary: The authority type admin page manage its own pagination Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Some code could be removed and DataTables introduced for a better rendering. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:58:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:58:40 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10947 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 13:58:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 11:58:40 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14042 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:01:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:01:06 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 --- Comment #1 from Jonathan Druart --- Created attachment 38327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38327&action=edit Bug 14042: Get rid of the home made pagination in the auth type admin This patch removes the home made pagination and introduces datatables on this page. Test plan: Go to the authority type admin page and confirm there is a beautiful table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:01:04 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:01:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:01:19 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:11:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:11:47 +0000 Subject: [Koha-bugs] [Bug 13636] Search results item status incorrect for holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13636 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #8 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:12:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:12:32 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:12:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:12:55 +0000 Subject: [Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:20:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:20:07 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #13 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:31:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:31:02 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38264|0 |1 is obsolete| | --- Comment #213 from Martin Renvoize --- Created attachment 38328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38328&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:31:08 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38265|0 |1 is obsolete| | --- Comment #214 from Martin Renvoize --- Created attachment 38329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38329&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e opac/svc/patron/ Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:31:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:31:15 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38266|0 |1 is obsolete| | --- Comment #215 from Martin Renvoize --- Created attachment 38330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38330&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:31:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:31:20 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38267|0 |1 is obsolete| | --- Comment #216 from Martin Renvoize --- Created attachment 38331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38331&action=edit Bug 9303 [QA Followup] - Remove extra 'USE Koha', change "Call number" back to "Call no." Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:33:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:33:09 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #217 from Martin Renvoize --- I've not spotted any issues in my testing.. so am happy to pass qa on this one. The original sign-off lines appear to be missing from the commits though.. think they must have got lost along the way somewhere.. but I don't see that as a reason to hold this one up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:35:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:35:50 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #218 from Martin Renvoize --- (In reply to Martin Renvoize from comment #217) > I've not spotted any issues in my testing.. so am happy to pass qa on this > one. > > The original sign-off lines appear to be missing from the commits though.. > think they must have got lost along the way somewhere.. but I don't see that > as a reason to hold this one up. Going through the bug history.. is it the signoff by nick - 2014-07-29 17:26:19 UTC we're still using.. has he tested all this since? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:37:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:37:53 +0000 Subject: [Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Keywords|rel_3_16_candidate | --- Comment #16 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:41:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:41:09 +0000 Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #38 from Mason James --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:41:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:41:32 +0000 Subject: [Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:42:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:42:22 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 --- Comment #21 from Martin Renvoize --- Created attachment 38332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38332&action=edit Bug 1917 - Add RSS Feeds for Lists Test Plan: 1) Apply this patch 2) Create one or more public lists 3) View the list in the opac 4) Note the new RSS icon next to the list name 5) Open the link in FireFox or an RSS reader 6) You should see an RSS feed of your list with the title and author of each item as a hyperlink to the record details Signed-off-by: Nicole Engard Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:42:28 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38263|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 38334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38334&action=edit Bug 1917 [QA Followup] - Remove unnecessary use of html filter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:42:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:42:25 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 --- Comment #22 from Martin Renvoize --- Created attachment 38333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38333&action=edit Bug 1917 [QA Followup] - Use html filter, only show 'by' if author exists, change link title Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:42:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:42:31 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38325|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 38335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38335&action=edit Bug 1917 [QA Followup] - Don't limit the list results for RSS feeds Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:43:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:43:05 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #38219|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:43:14 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38218|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:43:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:43:32 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize --- Followups all look sound to me.. passing qa. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:56:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:56:06 +0000 Subject: [Koha-bugs] [Bug 14043] New: fines.pl does not have perldocs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14043 Bug ID: 14043 Summary: fines.pl does not have perldocs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org fines.pl should have perldocs and use Pod::Usage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 14:59:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 12:59:27 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 --- Comment #24 from Kyle M Hall --- Created attachment 38336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38336&action=edit Bug 11084 [QA Followup] - Suppress userenv warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:06:50 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #25 from Kyle M Hall --- (In reply to Katrin Fischer from comment #23) > Hi Kyle, > > I did some tests with the new patches: > > Record has 1 item, is not checked out. > > -t -c > ERROR DELETING BIBLIO 24: Test mode enabled > > I was not sure if this would have been an error outside the test mode (not > being deleted) or if that just meant that it was not deleted because of the > test mode. Right now it's not possible to tell if a record is deletable in Koha without trying to delete it! There are simply no library functions to do so. The test mode will tell you what records and items it would attempt to delete, but is not meant to tell you if they would be deleted successfully. > > -t -i -c > ERROR DELETING ITEM 102: Test mode enabled > ERROR DELETING BIBLIO 24: Test mode enabled > > Ok, so both throw an error... so not sure: would those be deleted without -t? See above. > -c > ERROR DELETING BIBLIO 24: This Biblio has items attached, please delete them > first before deleting this biblio > > This one is good - why not display this in the test mode too? See above as well ; ) The errors come from DelBiblio, so the only way to know if the record can't be deleted is to try to delete it! > -c -i > C4::Context->userenv not defined! at /home/katrin/kohaclone/C4/Items.pm line > 2278. > > No messages, but I didn't set verbose. Item and record appear to have been > deleted - can you take a look at the error/warn? I've attached a followup to take care of this. userenv isn't defined for cli scripts, so we just need to check for it's existence before using it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:08:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:08:52 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 --- Comment #26 from Katrin Fischer --- Can we make that clear in the documentation for the test mode? that it will only list items that it would 'try' to delete? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:11:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:11:58 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 --- Comment #27 from Kyle M Hall --- Created attachment 38337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38337&action=edit Bug 11084 [QA Followup] - Document limitations of test mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:12:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:12:42 +0000 Subject: [Koha-bugs] [Bug 13527] Mixed content warnings in results and detail with Google images on https In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13527 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:19:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:19:04 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 --- Comment #2 from Marc V?ron --- Created attachment 38338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38338&action=edit [Signed-off] Bug 14042: Get rid of the home made pagination in the auth type admin This patch removes the home made pagination and introduces datatables on this page. Test plan: Go to the authority type admin page and confirm there is a beautiful table. Confirmed... Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:19:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:19:20 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:19:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:19:37 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38327|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:29:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:29:41 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 --- Comment #2 from Marc V?ron --- Created attachment 38339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38339&action=edit [Signed-off] Bug 10947: Fix editing the default authority type The default authority type cannot be defined. The authtypecode is en empty string and the tests should be done on "defined", not "exist". Test plan: Edit the default authority type, save it. Note: There is no way to create an authority with an empty string, with you deleted you won't be able to recreate it. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:30:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:30:19 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #38326|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:30:35 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:33:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:33:24 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 --- Comment #3 from Marc V?ron --- Note: Tested for sign-off with and without 10947 applied. Worked in both ways. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:39:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:39:41 +0000 Subject: [Koha-bugs] [Bug 14044] New: Backslashes ( and possibly other characters ) break patron search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Bug ID: 14044 Summary: Backslashes ( and possibly other characters ) break patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron has a backslash character ( \ ) in a field displayed in the patron search, and that patron is part of a set of search results, those search results will never display. Instead, it will just sit at the "Processing..." message forever. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:39:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:39:50 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:42:14 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:42:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:42:17 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 --- Comment #1 from Kyle M Hall --- Created attachment 38340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38340&action=edit Bug 14044 - Backslashes ( and possibly other characters ) break patron search If a patron has a backslash character ( \ ) in a field displayed in the patron search, and that patron is part of a set of search results, those search results will never display. Instead, it will just sit at the "Processing..." message forever. Test Plan: 1) Edit a patron, add a backslash to the address for the patron 2) Do a patron search where this patron would be one of many results 3) Note the results never display 4) Apply this patch 5) Repeat step 2 6) Note the results now display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:49:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:49:56 +0000 Subject: [Koha-bugs] [Bug 14045] New: Add specific quotas to on-site checkout Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Bug ID: 14045 Summary: Add specific quotas to on-site checkout Change sponsored?: Seeking developer Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nicolas.legrand at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com the BULAC (http://www.bulac.fr/) would like to have independent quotas for on-site checkouts with a column ?Current on-site checkouts allow? added to the circulation matrix. As long as Change sponsored? is set on ?Seeking developer?, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: . -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:55:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:55:29 +0000 Subject: [Koha-bugs] [Bug 5362] Simple (non-MARC) cataloging interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5362 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:57:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:57:25 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 15:59:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 13:59:32 +0000 Subject: [Koha-bugs] [Bug 10437] Greater flexibility on Marc Edit screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10437 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:10:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:10:17 +0000 Subject: [Koha-bugs] [Bug 14046] New: CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Bug ID: 14046 Summary: CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org If for some reason biblionumber!=biblioitemnumber (it happens with test DB's) CheckIfIssuedToPatron fails. It's logic should be rewritten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:11:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:11:11 +0000 Subject: [Koha-bugs] [Bug 14046] CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:11:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:11:14 +0000 Subject: [Koha-bugs] [Bug 14046] CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 --- Comment #1 from Jonathan Druart --- Created attachment 38341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38341&action=edit Bug 14046: Make the CheckIfIssuedToPatron using the biblionumber C4::Circ::CheckIfIssuedToPatron called $items = GetItemsByBiblioitemnumber($biblionumber); But if biblionumber != biblioitemnumber, the items retrieved were not the good ones! Test plan: Make your Auto increment values for biblio and biblioitems differs Launch the tests: prove t/db_dependent/Circulation/CheckIfIssuedToPatron.t Before this patch, they did not pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:15:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:15:39 +0000 Subject: [Koha-bugs] [Bug 6036] Mobile interface for Intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6036 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:19:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:19:56 +0000 Subject: [Koha-bugs] [Bug 14046] CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38341|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 38342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38342&action=edit [SIGNED OFF] Bug 14046: Make the CheckIfIssuedToPatron using the biblionumber C4::Circ::CheckIfIssuedToPatron called $items = GetItemsByBiblioitemnumber($biblionumber); But if biblionumber != biblioitemnumber, the items retrieved were not the good ones! Test plan: Make your Auto increment values for biblio and biblioitems differs Launch the tests: prove t/db_dependent/Circulation/CheckIfIssuedToPatron.t Before this patch, they did not pass. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:20:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:20:16 +0000 Subject: [Koha-bugs] [Bug 14046] CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:23:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:23:40 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:23:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:23:43 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38340|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 38343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38343&action=edit Bug 14044 - Backslashes ( and possibly other characters ) break patron search If a patron has a backslash character ( \ ) in a field displayed in the patron search, and that patron is part of a set of search results, those search results will never display. Instead, it will just sit at the "Processing..." message forever. Test Plan: 1) Edit a patron, add a backslash to the address for the patron 2) Do a patron search where this patron would be one of many results 3) Note the results never display 4) Apply this patch 5) Repeat step 2 6) Note the results now display Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:24:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:24:09 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:24:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:24:09 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13810 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:25:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:25:55 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- The bad news is that the issue is certainly also present on members/tables/guarantor_search.tt patroncards/tables/members_results.tt, serials/tables/members_results.tt and common/patron_search.tt But some of the patron information is not displayed on them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:42:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:42:53 +0000 Subject: [Koha-bugs] [Bug 14047] New: Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Bug ID: 14047 Summary: Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When you insert/modify a z39.50 server to use it in derivate cataloguing you can insert 'rank': [it] lets you enter where in the list you'd like this target to appear. If this is left blank the targets will be in alphabetical order. If you use authority servers it is OK. If you use bibliographic servers it doesn't work Now z39.50 bibliographic servers are sorted by id (insert order). This is because now we use DBIx in cataloguing/z3950_search.pl without an 'order_by'. The patch inserts 'order_by' instruction To test it: 1)Insert 3-4 z39.50 biblio servers and insert different values into 'rank' fields. 2)See the if you change 'rank', the order doesn't change 3)Apply the patch 4)See that now order is based on 'rank' and 'servername' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:43:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:43:34 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:50:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:50:39 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #55 from M. Tompsett --- (In reply to Bernardo Gonzalez Kriegel from comment #53) > Rebased & updated Could you rebase and update again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:52:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:52:32 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #29 from Tom?s Cohen Arazi --- P?tch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 16:56:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 14:56:38 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Jonathan Druart --- DefaultToLoggedInLibraryOverdueTriggers is never used in the code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:07:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:07:41 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38298|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 38344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38344&action=edit [SIGNED-OFF] Bug 14030 - Added tests for duplicates. It seems that the id's are not really used, but rather the subtags, types, and language related fields. These tests check for duplicates. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Languages.t -- may fail if you have duplicates. 3) ./installer/data/mysql/updatedatabase.pl -- this will trigger the atomicupdate, which because of this tweak, will correct duplicates. 4) prove -v t/db_dependent/Languages.t -- should succeed. 5) Run the updatedatabase.pl script multiple times. 6) prove -v t/db_dependent/Languages.t -- should still succeed. 7) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors, test run successfully, no more duplicates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:08:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:08:12 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:15:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:15:02 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #1 from Zeno Tajoli --- Created attachment 38345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38345&action=edit Patch for sorting z39.50 servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:15:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:15:14 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:22:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:22:51 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 --- Comment #22 from Kyle M Hall --- Created attachment 38346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38346&action=edit Bug 11747 [QA Followup] - Use system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:23:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:23:23 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:29:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:29:19 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #28 from Jonathan Druart --- Created attachment 38347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38347&action=edit Bug 13419: (follow-up) fix call to set_userenv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:33:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:33:07 +0000 Subject: [Koha-bugs] [Bug 14046] CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:33:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:33:10 +0000 Subject: [Koha-bugs] [Bug 14046] CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38342|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 38348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38348&action=edit [PASSED QA] Bug 14046: Make the CheckIfIssuedToPatron using the biblionumber C4::Circ::CheckIfIssuedToPatron called $items = GetItemsByBiblioitemnumber($biblionumber); But if biblionumber != biblioitemnumber, the items retrieved were not the good ones! Test plan: Make your Auto increment values for biblio and biblioitems differs Launch the tests: prove t/db_dependent/Circulation/CheckIfIssuedToPatron.t Before this patch, they did not pass. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:47:04 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #42 from Jonathan Druart --- Comment on attachment 38277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38277 Bug 11625 - Implement DefaultToLoggedInLibraryNoticesSlips Review of attachment 38277: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11625&attachment=38277) ----------------------------------------------------------------- ::: tools/letter.pl @@ +85,5 @@ > + : $input->param('branchcode') ? $input->param('branchcode') > + : $op ? $input->param('branchcode') > + : GetBranchesCount() == 1 ? undef > + : C4::Branch::mybranch(); > + Sorry but I am not confident enough with this part of code to pass qa on it today. This script is a house of cards and the branchcode variable is used at several place. You modify it at the beginning of the script, but it could introduce side effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:49:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:49:50 +0000 Subject: [Koha-bugs] [Bug 14048] New: Change RefundLostItemFeeOnReturn to be branch specific Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Bug ID: 14048 Summary: Change RefundLostItemFeeOnReturn to be branch specific Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some library systems would like to be able to control the behavior of RefundLostItemFeeOnReturn Expected outcome: To make the RefundLostItemFeeOnReturn system preference branch specific Plan of Attack: 1) Add new field 'refund_lost_item_fee_on_return' to the 'branches' table 2) Pre-populate this field with the system preference value for RefundLostItemFeeOnReturn 3) Remove the system preference RefundLostItemFeeOnReturn 4) Replace uses of RefundLostItemFeeOnReturn with a lookup of the value of branches.refund_lost_item_fee_on_return 5) Use HomeOrHolding to control whether the home branch or the holding branch of the item is used to determine this. 6) Reveal the setting in the branches editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:59:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:59:21 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #86 from techservspec at gmail.com --- Patch not loading on sandbox: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 8753:

    Something went wrong !

    Applying: Bug 8753 - Add forgot password link to OPAC Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Failed to merge in the changes. Patch failed at 0001 Bug 8753 - Add forgot password link to OPAC When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 8753 - Add forgot password link to OPAC 37492 - Bug 8753 - Add forgot password link to OPAC Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-8753---Add-forgot-password-link-to-OPAC-QS82WH.patch . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 17:59:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 15:59:54 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 18:17:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 16:17:37 +0000 Subject: [Koha-bugs] [Bug 14049] New: Personalized OPAC purchase suggestion fields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 Bug ID: 14049 Summary: Personalized OPAC purchase suggestion fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org Before using Koha we were using a local develop for purchase suggestion requests (?desiderata?). Now I'm trying to extend/add suggestion fields to add some data we were asking in the form and Koha doesn't include, something like what ExtendedPatronAttributes syspref does with patron fields. First I naively tried to add to opac-suggestions.tt
  • and on submit: onsubmit="this.note.value=this.note.value+' - '+this.newfield.value; return true;" to concatenate extended fields (yeah, dirty) but it seems Suggestions.pm do a foreach walk over form ids: Software error: DBIx::Class::ResultSet::create(): No such column alum on Koha::Schema::Result::Suggestion at /usr/share/koha/lib/C4/Suggestions.pm line 450 Koha should let staff user to extend suggestions fields, maybe with a ExtendedSuggestionFields sysfref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 18:28:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 16:28:08 +0000 Subject: [Koha-bugs] [Bug 13880] Allow svc/report to be passed sql parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 18:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 16:28:34 +0000 Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 18:29:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 16:29:20 +0000 Subject: [Koha-bugs] [Bug 13159] Enhancements to the SIP2 command line emulator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13159 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #30 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 18:30:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 16:30:28 +0000 Subject: [Koha-bugs] [Bug 13623] Enhance html for holds queue viewer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13623 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Bywater! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 18:31:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 16:31:02 +0000 Subject: [Koha-bugs] [Bug 13156] Display borrower's cardnumber who did a suggestion in suggestion.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 18:31:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 16:31:35 +0000 Subject: [Koha-bugs] [Bug 13819] Add biblioitems to available tables in ISSUESLIP and ISSUEQSLIP In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13819 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Barton! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 18:32:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 16:32:04 +0000 Subject: [Koha-bugs] [Bug 14046] CheckIfIssuedToPatron fails if biblionumber != biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14046 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 19:04:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 17:04:36 +0000 Subject: [Koha-bugs] [Bug 10941] MARC21 documentation links while adding an authority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10941 --- Comment #3 from Pablo AB --- Added to JQuery Library on wiki: http://wiki.koha-community.org/wiki/JQuery_Library#MARC21_documentation_links_while_adding_an_authority but in status=incomplete because it shows also on bibliographic frameworks. A lot of this JQuery enhancement should be added to Koha... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 19:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 17:57:56 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38155|0 |1 is obsolete| | Attachment #38156|0 |1 is obsolete| | Attachment #38157|0 |1 is obsolete| | Attachment #38158|0 |1 is obsolete| | Attachment #38184|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 38349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38349&action=edit Bug 13790 - Add unique id issue_id to issues and old_issues tables Test Plan: 1) Use a database with existing issues and old issues 2) Apply this patch 3) Run updatedatabase 4) Inspect the database a) old_issues should now have a column issue_id starting with 1 b) issues should now have a column issue_id starting with the number of rows in the old_issues table plus one 5) Perform a checkout, note it is written to the database 6) Check in the checked out item, note it is moved to the old_issues table Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 19:58:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 17:58:24 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38349|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 38350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38350&action=edit Bug 13790 - Add unique id issue_id to issues and old_issues tables Test Plan: 1) Use a database with existing issues and old issues 2) Apply this patch 3) Run updatedatabase 4) Inspect the database a) old_issues should now have a column issue_id starting with 1 b) issues should now have a column issue_id starting with the number of rows in the old_issues table plus one 5) Perform a checkout, note it is written to the database 6) Check in the checked out item, note it is moved to the old_issues table Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 19:58:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 17:58:53 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #28 from Kyle M Hall --- Created attachment 38351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38351&action=edit Bug 13790 - Update Koha Schema Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 19:58:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 17:58:56 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #29 from Kyle M Hall --- Created attachment 38352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38352&action=edit Bug 13790 [QA Followup] Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 19:58:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 17:58:59 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #30 from Kyle M Hall --- Created attachment 38353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38353&action=edit Bug 13790: [QA Follow-up] Relocation of db revision in updatedatabase The db rev lines should not be under the bug 13068 sandbox section. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 19:59:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 17:59:02 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #31 from Kyle M Hall --- Created attachment 38354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38354&action=edit Bug 13790 [QA Followup] - Disable auto increment on old_issues after pk values are created Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 20:11:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 18:11:28 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 20:11:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 18:11:33 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #29 from Tom?s Cohen Arazi --- Created attachment 38355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38355&action=edit Bug 13419: (QA followup) remove useless warnings Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 20:25:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 18:25:02 +0000 Subject: [Koha-bugs] [Bug 14013] Use name of a saved report as part of the file name for download In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14013 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 20:25:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 18:25:29 +0000 Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the wrong course! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 20:26:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 18:26:41 +0000 Subject: [Koha-bugs] [Bug 8276] circ history not sorting right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 20:27:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 18:27:09 +0000 Subject: [Koha-bugs] [Bug 13987] Z39.50 Authority search result not displaying server name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13987 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Blou! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 20:27:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 18:27:42 +0000 Subject: [Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #30 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:07:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:07:21 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:07:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:07:25 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38297|0 |1 is obsolete| | Attachment #38344|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 38356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38356&action=edit [PASSED QA] Bug 14030: Add Georgian language and fix Kannada language code This patch adds Georgian language and a fix wrong language code Language added: Georgian - ka - geo I selected 'geo' for ISO639-2 instead of 'kat' because it's the same code form http://www.loc.gov/marc/languages/language_code.html Also a fix is needed to Kannada ISO639-1 code, from 'ka' to 'kn' To test: 1) Apply the patch 2) Run updatedatabase.pl (once) 3) Check language, e.g. go to staff > search > More options > Limits and search for Georgian on language list I only added language code 'ka', not script 'Geor' nor country 'GE', the plan is to name translation files 'ka-*', but can ammend the patch if needed. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:07:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:07:37 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 --- Comment #10 from Katrin Fischer --- Created attachment 38357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38357&action=edit [PASSED QA] [PASSED QA] Bug 14030 - Added tests for duplicates. It seems that the id's are not really used, but rather the subtags, types, and language related fields. These tests check for duplicates. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Languages.t -- may fail if you have duplicates. 3) ./installer/data/mysql/updatedatabase.pl -- this will trigger the atomicupdate, which because of this tweak, will correct duplicates. 4) prove -v t/db_dependent/Languages.t -- should succeed. 5) Run the updatedatabase.pl script multiple times. 6) prove -v t/db_dependent/Languages.t -- should still succeed. 7) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors, test run successfully, no more duplicates Signed-off-by: Katrin Fischer Fixed German description. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:17:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:17:20 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:17:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:17:23 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38339|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 38358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38358&action=edit [PASSED QA] Bug 10947: Fix editing the default authority type The default authority type cannot be defined. The authtypecode is en empty string and the tests should be done on "defined", not "exist". Test plan: Edit the default authority type, save it. Note: There is no way to create an authority with an empty string, with you deleted you won't be able to recreate it. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:28:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:28:29 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #25 from Marc V?ron --- There is a typo in koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc line 81 Koha.Preferences('EnhancedMessagingPreferencesOPAC') should be: Koha.Preference('EnhancedMessagingPreferencesOPAC') (Preferences -> Preference) I tested after locally fixing the issue. IMO status 'In Discussion' could be removed. Regarding comment #19: '...display as it currently is might be a bit confusing to patrons...': Maybe there could be some explanation like in the tab 'your privacy'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:29:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:29:53 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:29:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:29:56 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38282|0 |1 is obsolete| | Attachment #38304|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 38359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38359&action=edit [PASSED QA] Bug 13482: Prevent race condition on printing a ReserveSlip The problem has been well described by Kyle and Nicole on bug 7255 description and comment 1. With this counter patch, I suggest to popup AFTER the return has been confirmed. This will remove the race condition and avoid to pass itemnumber to the pl file as in the patch submitted by Olli. Only the borrowernumber and biblionumber are needed (transfer and op are never used by circ/hold-transfer-slip.pl). Test plan: It is very hard to know all cases (at least 6) where the popup is displayed. Try at least to get the hold and the transfer confirmation messages. You should get the popup if you click on "print slip" button. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:30:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:30:32 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 --- Comment #19 from Katrin Fischer --- Created attachment 38360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38360&action=edit [PASSED QA] Bug 13482: Sent biblionumber to the template The biblionumber is sent to the template as 'itembiblionumber' at 1 place, the template get the 'biblionumber' variable. I don't understand why but the easy way is to sent the variable twice. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:36:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:36:51 +0000 Subject: [Koha-bugs] [Bug 13817] Edit links on course items may point to the wrong course! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:45:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:45:35 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 --- Comment #28 from Katrin Fischer --- Created attachment 38361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38361&action=edit [PASSED QA] Bug 11084 - Delete biblios on Leader 05 == d Position 05 of the leader in MARC 21 indicates the record's status. A lower case 'd' indicates that the record is to be deleted (http://www.loc.gov/marc/authority/adleader.html). This patch adds a cronjob script that may be run nightly to delete records where position 05 of the leader is set to 'd'. Test Plan: 1) Edit one or more records, and set the leader position 05 to 'd'. 2) Run misc/cronjobs/delete_records_via_leader.pl -c -v 3) Those records should either be deleted, or an error message should state why they were not. Signed-off-by: Magnus Enger Works as advertised. Edited a record with an item to have leader05 = d, then ran delete_records_via_leader.pl with -c and got a message that the record could not be deleted because of the item. Removed the item and the script deleted the record. Tried with another record with an item, this time with the -i option and the record was deleted. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:45:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:45:43 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 --- Comment #30 from Katrin Fischer --- Created attachment 38363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38363&action=edit [PASSED QA] Bug 11084 [QA Followup] - Suppress userenv warning Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:45:39 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 --- Comment #29 from Katrin Fischer --- Created attachment 38362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38362&action=edit [PASSED QA] Bug 11084 [QA Followup] Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:45:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:45:47 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 --- Comment #31 from Katrin Fischer --- Created attachment 38364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38364&action=edit [PASSED QA] Bug 11084 [QA Followup] - Document limitations of test mode Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:46:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:46:20 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:46:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:46:16 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:46:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:46:22 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:46:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:46:27 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:46:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:46:25 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37714|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:49:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:49:50 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #17 from Marc V?ron --- Charles, I'm sorry, I was not fast enough, after the newest pushes both patches again do not apply. For the first patch you can remove your changes from installer/data/mysql/updatedatabase.pland follow the new rules in http://wiki.koha-community.org/wiki/Database_updates See part updatedatabase.pl Oh, have a look at C4/Breeding.pm in the second patch, you have remaining lines from merging like: <<<<<<< HEAD ======= (....) >>>>>>> c4c12ed... Bug 12747 - Add extra column in Z3950 search result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 21:52:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 19:52:45 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |eskaaren at yahoo.no |ity.org | CC| |eskaaren at yahoo.no -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:03:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:03:02 +0000 Subject: [Koha-bugs] [Bug 14050] New: Default framework for authorities should not be deletable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14050 Bug ID: 14050 Summary: Default framework for authorities should not be deletable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org If the default authority type is deleted (Home > Administration > Authority types), it can not be recreated, because there is no way to create an authority with an empty string as code. The possibility to delete the default authority type should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:03:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:03:26 +0000 Subject: [Koha-bugs] [Bug 14050] Default framework for authorities should not be deletable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14050 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10947 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:03:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:03:26 +0000 Subject: [Koha-bugs] [Bug 10947] Default framework for authorities can't be edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14050 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:07:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:07:59 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- With the patch applied, there are "" appearing in the result table, even for empty fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:15:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:15:48 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:15:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:15:50 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36554|0 |1 is obsolete| | --- Comment #17 from Charles Farmer --- Created attachment 38365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38365&action=edit Bug 12768 - Replacement cost and processing fee management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:15:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:15:52 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 --- Comment #1 from Marc V?ron --- Created attachment 38366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38366&action=edit Bug 13834 - News: Wording not consistent for Publication date / Creation date This patch replaces column header "Creation date" with "Publication date" in staff client > Home > Tools > News (same as the field label in editing form for news). To test apply patch and verify that column header displays as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:16:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:16:11 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #18 from Charles Farmer --- Created attachment 38367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38367&action=edit Bug 12768 - Updated schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:18:46 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch --- Comment #2 from Marc V?ron --- Oh, sorry, I did not see that it is assigned to Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:22:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:22:37 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|eskaaren at yahoo.no |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:23:44 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:23:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:23:47 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38365|0 |1 is obsolete| | --- Comment #19 from Charles Farmer --- Created attachment 38368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38368&action=edit Bug 12768 - Replacement cost and processing fee management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:24:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:24:43 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 --- Comment #3 from Eivin Giske Skaaren --- (In reply to Marc V?ron from comment #2) > Oh, sorry, I did not see that it is assigned to Eivin Giske Skaaren No problem, I just started developing on Koha tonight and this seemed like a patch that would be good for learning the toolchain etc :) I will find another one and perhaps sign off on this one to learn how to do that as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:27:06 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Welcome Eivin - drop by on IRC if you want and if we can help you with something :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:31:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:31:53 +0000 Subject: [Koha-bugs] [Bug 14040] Confusing messages on items placed on hold in OPAC and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14040 --- Comment #1 from Katrin Fischer --- Maybe.... expected = for pick-up at ... placed on ... ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:32:36 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #22 from Katrin Fischer --- Created attachment 38369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38369&action=edit [PASSED QA] Bug 13887 - Add datatables to item specific holds table This patch adds datatables functionality to the item specific holds table To test: 1 - Apply patch 2 - Attempt to place an item specific hold for a patron 3 - Note that columns are now sortable and searchable 4 - Ensure that you can place both specific and next available holds as before Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:32:39 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #23 from Katrin Fischer --- Created attachment 38370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38370&action=edit [PASSED QA] Bug 13887: Tab fix and "intranet-tmpl" to "[% interface %]" Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:32:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:32:43 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #24 from Katrin Fischer --- Created attachment 38371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38371&action=edit [PASSED QA] Bug 13887: Fix sDom to display what is needed in the table 1/ Add the information 'showing x to y of z' 2/ Remove some lost pixels Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:32:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:32:46 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #25 from Katrin Fischer --- Created attachment 38372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38372&action=edit [PASSED QA] Bug 13887: Move the caption into a h2 With the DT filter, the caption is between the table and the filter. It looks better with the caption as a h2 on top of the table. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:32:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:32:50 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 --- Comment #26 from Katrin Fischer --- Created attachment 38373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38373&action=edit [PASSED QA] [PASSED QA] Bug 13887: Display the due date as a due date + sort on info The due dates should be displayed as due dates :) i.e not displayed with 23:59 On the way, this patch fixes the sort on the info column. The column is now sorted using the due dates Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:34:16 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:34:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:34:18 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:34:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:34:20 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38322|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:34:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:34:23 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38323|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:34:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:34:25 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38309|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:34:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:34:27 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38310|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:36:42 +0000 Subject: [Koha-bugs] [Bug 13887] Add datatables to item specific holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38373|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer --- Created attachment 38374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38374&action=edit [PASSED QA] Bug 13887: Display the due date as a due date + sort on info The due dates should be displayed as due dates :) i.e not displayed with 23:59 On the way, this patch fixes the sort on the info column. The column is now sorted using the due dates Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:45:39 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:45:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:45:40 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36555|0 |1 is obsolete| | --- Comment #20 from Charles Farmer --- Created attachment 38375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38375&action=edit Bug 12768 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:45:42 +0000 Subject: [Koha-bugs] [Bug 14042] The authority type admin page manage its own pagination In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14042 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38338|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 38376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38376&action=edit [PASSED QA] Bug 14042: Get rid of the home made pagination in the auth type admin This patch removes the home made pagination and introduces datatables on this page. Test plan: Go to the authority type admin page and confirm there is a beautiful table. Confirmed... Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:55:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:55:46 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #15 from Katrin Fischer --- Created attachment 38377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38377&action=edit [PASSED QA] Bug 13919 - Unit Test Tested both unit test patches together. Without main patch applied: do not pass as expected / with main patch pass OK as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:55:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:55:49 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #16 from Katrin Fischer --- Created attachment 38378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38378&action=edit [PASSED QA] Bug 13919: Make the tests pass fixing the number of tests Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:55:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:55:52 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #17 from Katrin Fischer --- Created attachment 38379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38379&action=edit [PASSED QA] Bug 13919 - Renewal possible with item level hold on item Test Plan: 1) Apply this patch 2) Enable AllowRenewalIfOtherItemsAvailable 3) Check out an item from a record with multiple holdable items 4) Place an item level hold on the checked out item 5) Verify the item can not be renewed from the opac Signed-off-by: Nicolas Legrand Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:56:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:56:13 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:56:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:56:15 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:56:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:56:17 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38308|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:56:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:56:19 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #21 from Charles Farmer --- Hi Katrin, Following your advice, I changed a few things from the previous patches: * the double fields are now decimals * the method description now has PF with a short description. * a new patch now changes the database structure (atomicupdate + kohastruct + schema) FWIW, the failing test you mentioned also fails on the current master. I believe this is out of the scope of these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:56:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:56:20 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 22:56:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 20:56:50 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 --- Comment #18 from Katrin Fischer --- Tested with various combinations of item level/record level holds and syspref settings - no problems found! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 23:00:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 21:00:42 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #22 from Katrin Fischer --- The tests pass ok for me on current master - can you try again on a database with your patch and all the sample data installed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 23:08:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 21:08:51 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #6 from Katrin Fischer --- Sorry, patch does not apply and I am not sure how to fix the conflict - better leaving it to you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 23:12:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 21:12:41 +0000 Subject: [Koha-bugs] [Bug 13339] Cart button doesn't open the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13339 --- Comment #7 from Liz Rea --- Thanks, this is an improvement. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 23:24:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 21:24:00 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38366|0 |1 is obsolete| | --- Comment #5 from Eivin Giske Skaaren --- Created attachment 38380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38380&action=edit Bug 13834 - News: Wording not consistent for Publication date / Creation date This patch replaces column header "Creation date" with "Publication date" in staff client > Home > Tools > News (same as the field label in editing form for news). To test apply patch and verify that column header displays as appropriate. Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 22 23:59:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 21:59:23 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi Marc, I like this addition :) 2 things: 1) When adding a report you always log the id with 0. Please take a look at options to log the real report id. It seems to work ok for ADD and other logs like adding patrons or items. 2) Can you standardize the info a bit? They are all a little different. I had started working on a follow-up but will better leave it to you. Maybe we could even do simpler - just | somehow matching the syspref syntax? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 00:00:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 22:00:01 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #219 from Nick Clemens --- I tried retesting today just for due diligence but I think I am doing something wrong. As soon as I enable either syspref I get the following error on OPAC: DBIx::Class::ResultSource::_resolve_join(): No such relationship biblio on Item at /home/kidclamp/kohaclone/opac/opac-user.pl line 390 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 00:27:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 22:27:10 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Katrin Fischer --- >From reading the code: + # do the return + ( $returned, $messages, $issueinformation, $borrower ) = + AddReturn( $barcode, $userenv_branch, $exemptfine, $dropboxmode, $return_date_override ); + I think we miss the dropboxdate here - Please check and fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 00:27:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 22:27:55 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #19 from Robin Sheat --- (In reply to Julian Maurice from comment #18) > Anyway, Jessie will become the new stable in few days. Should we just wait > before integrating this ? We'd be waiting for a year or three, we're only dropping squeeze support as at 3.20. > But what about swagger2, which is not packaged at all ? > It is not the only Perl module that needs to be "cpanned" for Koha. So why > should we block for this one ? Koha will continue to work without it. There are no modules that need to be cpanned for Koha, and if there are, that's a bug (with the exception of some test case things, I think.) I think having a significantly useful feature that can't be readily used isn't good, so I'm trying to get it to a point where it can work. > If really needed, it shouldn't be hard to make a Debian package of it. At the moment, it's not particularly easy, as it needs a version of mojolicious that isn't packaged at all. I attempted to package that, but ran into https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748244 which caused it to fail. I'll have another go when I get the chance, but depending on bleeding edge modules is always going to be problematic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 00:41:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 22:41:29 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- This appears to be blocked by its dependencies on Angular and C4::Service currently. I think we need to figure out if both of those are getting in, before we can continue here. I did a code review and spotted nothing obvious. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 00:53:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 22:53:38 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer --- This seems to make some tests fail: t/db_dependent/Reserves.t: not ok 29 - patron notified when item set to waiting # Failed test 'patron notified when item set to waiting' # at t/db_dependent/Reserves.t line 348. # got: '4' # expected: '5' not ok 30 - patron not notified a second time (bug 11445) # Failed test 'patron not notified a second time (bug 11445)' # at t/db_dependent/Reserves.t line 353. # got: '4' # expected: '5' C4::Context->userenv not defined! at /home/katrin/kohaclone/C4/Items.pm line 2275. t/db_dependent/Letter.t: ok 69 - AutoEmailPrimaryAddress=OFF, EnqueueLetter used the patron email address if no to_address is given in parameter DBD::mysql::db selectcol_arrayref failed: Unknown column 'OFF' in 'field list' at /home/katrin/kohaclone/C4/Members.pm line 1569. DBD::mysql::db selectcol_arrayref failed: Unknown column 'OFF' in 'field list' at /home/katrin/kohaclone/C4/Members.pm line 1569. # Looks like you planned 76 tests but ran 69. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 00:58:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 22:58:09 +0000 Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 01:13:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 23:13:58 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I like the idea of this! 1) Should we hide the field for AcqCreateItem = 'cataloguing'? And maybe also 'receive'? (normal) 2) I wonder if there is a use case a library might want to keep the initial order date instead. The way this patch works they can't see the initial date and they can't keep it. (question) 3) Currently the field is named 'Date received', maybe we should use the description of the item field it updates - 'Date acquired' to make the use more clear? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 01:20:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 Apr 2015 23:20:03 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #101 from Katrin Fischer --- Hi Kyle, this doesn't apply on top of 13790 or master: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation fatal: sha1 information is lacking or useless (Koha/Schema/Result/OldIssue.pm). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 02:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 00:04:18 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #37 from Katrin Fischer --- Created attachment 38381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38381&action=edit Bug 11603: Some minor documentation changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 02:06:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 00:06:41 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #38 from Katrin Fischer --- I like this! (But need a bit more time to play with it :( ) Some first notes from reading the docs (yay!) and code: 1) I see there are 2 copyright statements and licenses, one at the top and one at the bottom. Should this be cleaned up? 2) Is this statement about the file name still true? The generated filename will be holdnotices-TODAY.[csv|html|ods] or holdnotices-TODAY-BRANCHCODE.[csv|html|ods] if the --split parameter is given. 3) I have attached some suggestions for the documentation - please take a look and obsolete if you don't agree :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 05:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 03:22:02 +0000 Subject: [Koha-bugs] [Bug 13085] bugfix : tools/export.pl don't works in commandline without id_list_file parameter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13085 --- Comment #6 from Mason James --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 05:26:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 03:26:48 +0000 Subject: [Koha-bugs] [Bug 13744] Paging on some datatables slightly broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13744 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #16 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 05:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 03:32:02 +0000 Subject: [Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #11 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 05:40:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 03:40:47 +0000 Subject: [Koha-bugs] [Bug 12820] SIP2 does not send rental charge fee! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #18 from Mason James --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 05:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 03:42:28 +0000 Subject: [Koha-bugs] [Bug 13801] SVC bib bad encoding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13801 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #13 from Mason James --- (In reply to Fridolin SOMERS from comment #11) > Was pushed in 3.16.09 oops, thanks for spotting that Fridolin :0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 05:43:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 03:43:12 +0000 Subject: [Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 05:45:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 03:45:06 +0000 Subject: [Koha-bugs] [Bug 12507] News does not always display in staff or OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 05:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 03:45:42 +0000 Subject: [Koha-bugs] [Bug 13521] Auth.pm code issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13521 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 05:54:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 03:54:48 +0000 Subject: [Koha-bugs] [Bug 13401] sort branches alphabetically in admin/authorised_values.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13401 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 06:11:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 04:11:21 +0000 Subject: [Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #17 from Mason James --- (In reply to Tom?s Cohen Arazi from comment #12) > Patches pushed to master. Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 07:50:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 05:50:21 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 --- Comment #6 from Marc V?ron --- Eivin, welcome and thanks for signing off! - Please do not forget to switch the status to Signed-off to move the patch to the QAers. (And you will then appear on http://dashboard.koha-community.org/ ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 08:36:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 06:36:03 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38222|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 38382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38382&action=edit Bug 14024 - add reports to action logs This patch sets adds the possibility to log new, update and delete actions for saved reports. To test: -Apply patch -Run updatedatabase.pl -Enable system preference ReportsLog -Create, duplicate, edit and delete saved reports -Go to Home > Tools > Logs -Verify that you can select "Reports" in Modules list -Verify that your actions were logged Signed-off-by: Nicole Engard Amended for QA remarks (see comment #5) / MV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 08:37:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 06:37:32 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38382|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Comment on attachment 38382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38382 Bug 14024 - add reports to action logs Sorry, mistaked for this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 08:38:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 06:38:03 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38222|1 |0 is obsolete| | --- Comment #8 from Marc V?ron --- Comment on attachment 38222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38222 Bug 14024 - add reports to action logs Reactivating previous patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 08:51:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 06:51:19 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 --- Comment #9 from Marc V?ron --- Created attachment 38383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38383&action=edit [Folluw-up] Bug 14024 - add reports to action logs See QA comment #5 - new reports log their Id instead of 0 - format info: | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 08:52:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 06:52:12 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 08:53:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 06:53:28 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Marc V?ron --- I think the follow-up needsa new sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 08:54:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 06:54:25 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:03:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:03:05 +0000 Subject: [Koha-bugs] [Bug 7177] memoize more function calls to speed up Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7177 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #8 from Zeno Tajoli --- Hi Dobrica, I think we now use an othere way (Planck?) to do this, correct ? Can we close it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:09:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:09:23 +0000 Subject: [Koha-bugs] [Bug 10886] When intranetreadinghistory is set to not allow - staff can still view patron's history in item history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10886 --- Comment #4 from Marc V?ron --- Created attachment 38384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38384&action=edit [Signed-off] Bug 10866: Hide patron's history if intranetreadinghistory is set to not allow If set to "not allow", the intranetreadinghistory pref prevent staff members to access patron's checkout history. But: 1/ The page is still accessible if you know the url 2/ The history can be consulted on the item history page Test plan: 0/ Don't apply this patch 1/ Set the intranetreadinghistory to allow 2/ Go on a patron's checkout history page 3/ Open a new tab and go on a item's checkout history page 4/ Set the intranetreadinghistory to not allow 5/ Refresh both pages => no change 6/ Apply this patch 7/ Refresh both page. On the first page, you should see a warning On the other one, you should see that the patron column is not displayed anymore. Followed test plan, results were as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:09:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:09:47 +0000 Subject: [Koha-bugs] [Bug 10886] When intranetreadinghistory is set to not allow - staff can still view patron's history in item history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10886 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #38318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:09:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:09:55 +0000 Subject: [Koha-bugs] [Bug 10886] When intranetreadinghistory is set to not allow - staff can still view patron's history in item history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10886 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:19:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:19:03 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- # git grep totalamount Koha/Schema/Result/Aqorder.pm:=head2 totalamount Koha/Schema/Result/Aqorder.pm: "totalamount", Should that still appear? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:38:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:38:40 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #39 from Jonathan Druart --- Created attachment 38385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38385&action=edit Bug 11603: Preparation step, cleaning up This patch refactores and adds some good practices: - use Modern::Perl - use Pod::Usage - add POD Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:38:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:38:44 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #40 from Jonathan Druart --- Created attachment 38386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38386&action=edit Bug 11603: Gather print notices - add a csv parameter This patch adds: - the ability to generate a csv file instead of a html file. - a letter_code parameter. >From now you are able to generate a csv file for print notices. Imagine a template notice defined as: cardnumber:patron:email:item <>:<> >:<>:<> You would like to generate a csv file and not a html file. Test plan: - define your OVERDUE notice for the print template as: cardnumber:patron:email:item <>:<> >:<>:<> - define overdues rules for a patron category - check 2 items out using a due date in order to generate the overdue notices - check these 2 items in - launch the overdue_notices script - the message_queue table should now contain 2 new entries - launch the gather_print_notices cronjob with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE --letter_code=CHECKIN you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE -d=: will produce 1 csv file in your /tmp/test directory - verify the csv file is correct and contain only 1 csv header column. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:38:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:38:47 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #41 from Jonathan Druart --- Created attachment 38387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38387&action=edit Bug 11603: Gather print notices - add a ods parameter This patch adds: - the ability to generate an ods file >From now you are able to generate a ods file for print notices. You would like to generate a csv file and not a html file. Test plan: - same as previous patch but test the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods --letter_code=OVERDUE -d=: you should get an error because csv2ods is not installed. Follow the installation instructions and try again the command. A ods file should be generated in your /tmp/test directory. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:38:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:38:52 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #42 from Jonathan Druart --- Created attachment 38388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38388&action=edit Bug 11603: If a letter code is given, filenames should contain it If you choose to generate print notices for a specific letter code, the generated files should be distinct. The use case is: you want to process print notice for letter codes: overdue1, overdue2 and overdue3. The cronjobs will be: perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue1 --csv --ods --html --delimiter=";" perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue2 --csv --ods --html --delimiter=";" perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue3 --csv --ods --html --delimiter=";" without this patch, the 2 first files will be erased. Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:38:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:38:55 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #43 from Jonathan Druart --- Created attachment 38389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38389&action=edit Bug 11603: Fix encoding issues (bug 11944 is now pushed) Signed-off-by: Frederic Demians No more encoding issue with html file, no problem with csv|ods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:38:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:38:59 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37834|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart --- Created attachment 38390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38390&action=edit Bug 11603 Add --send|--nosend, fix stuf Fix --html without --letter_code Fix --ods which was producing a 2 lines ods file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:39:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:39:02 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38381|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 38391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38391&action=edit Bug 11603: Some minor documentation changes Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:39:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:39:06 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #46 from Jonathan Druart --- Created attachment 38392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38392&action=edit Bug 11603: (follow-up) pod The filenames will change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:39:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:39:59 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:40:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:40:01 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37830|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:40:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:40:03 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37831|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:40:07 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:40:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:40:11 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37833|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:41:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:41:04 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #47 from Jonathan Druart --- (In reply to Katrin Fischer from comment #38) > I like this! (But need a bit more time to play with it :( ) > > Some first notes from reading the docs (yay!) and code: > > 1) I see there are 2 copyright statements and licenses, one at the top and > one at the bottom. Should this be cleaned up? It depends on how you have fixed the first conflict :) > 2) Is this statement about the file name still true? > The generated filename will be holdnotices-TODAY.[csv|html|ods] or > holdnotices-TODAY-BRANCHCODE.[csv|html|ods] if the --split parameter is > given. Fixed > 3) I have attached some suggestions for the documentation - please take a > look and obsolete if you don't agree :) Ok for me, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:49:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:49:20 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #3 from Jonathan Druart --- (In reply to Marc V?ron from comment #2) > # git grep totalamount > Koha/Schema/Result/Aqorder.pm:=head2 totalamount > Koha/Schema/Result/Aqorder.pm: "totalamount", > > Should that still appear? Yes, I don't update the schema when not needed to test. The RM uploads it when needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:51:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:51:06 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #20 from Julian Maurice --- (In reply to Robin Sheat from comment #19) > There are no modules that need to be cpanned for Koha, and if there are, > that's a bug (with the exception of some test case things, I think.) I think > having a significantly useful feature that can't be readily used isn't good, > so I'm trying to get it to a point where it can work. Ok, so just for pointing it out, required version of DBIx::Class::Schema::Loader (0.07039) is not in wheezy (0.07025-1), and not in debian.koha-community.org neither. > At the moment, it's not particularly easy, as it needs a version of > mojolicious that isn't packaged at all. I attempted to package that, but ran > into https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748244 which caused > it to fail. > > I'll have another go when I get the chance, but depending on bleeding edge > modules is always going to be problematic. How did you try to package it ? I just tried this morning and was successful packaging Mojolicious 6.08 and Swagger2 0.30 for wheezy (+ additionnal Mojo dependency IO::Socket::IP - packaged in wheezy but version too low) In the process, I had to make several other packages, but they are only build dependencies (Test::Warnings, Test::Deep, CPAN::Meta::Check) I only used dh-make-perl and debuild to build packages (and dpkg to install them). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:57:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:57:01 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 --- Comment #4 from Marc V?ron --- Created attachment 38393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38393&action=edit [Signed-off] Bug 11006: Drop column aqorders.totalamount This column was not used in the Koha codebase, it can be removed. Test plan: Execute the updatedatabase.pl script and confirm that the column has been dropped. QA step: 1/ git grep totalamount 2/ prove t/db_dependent/Acquisition.t Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:57:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:57:31 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 09:57:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 07:57:40 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 10:01:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 08:01:06 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #21 from Olli-Antti Kivilahti --- I tested this few weeks ago and I had no issues running them? Just installed from cpan. Maybe I missed something? I ran the manual test cases defined. We definetely should use the latest Mojolicious and Swagger2 implementations. No compromise here. Documentation and all in one bundle like it was meant to be. Very strange that the latest Mojolicious would be unavailable via packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 10:01:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 08:01:44 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38222|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 10:28:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 08:28:41 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Marc V?ron --- Wanted to test, does not apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 10:30:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 08:30:03 +0000 Subject: [Koha-bugs] [Bug 14051] New: Tiny adjustment of ReturnPathDefault pref description Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 Bug ID: 14051 Summary: Tiny adjustment of ReturnPathDefault pref description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Adding that Return-Path is bounce address. Note that if it is empty, the From address is used. This could be the admin address, but Koha uses other from addresses too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 10:32:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 08:32:25 +0000 Subject: [Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 10:32:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 08:32:27 +0000 Subject: [Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 --- Comment #1 from Marcel de Rooy --- Created attachment 38394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38394&action=edit Bug 14051: Tiny adjustment of ReturnPathDefault pref description Adding that Return-Path is bounce address. Note that if it is empty, the From address is used. This could be the admin address, but Koha uses other from addresses too. Test plan: Read the description on the preferences page. Check some Koha mails with/without this pref. Note that this patch does not change behavior in any way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 10:32:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 08:32:59 +0000 Subject: [Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|nengard at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 10:50:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 08:50:09 +0000 Subject: [Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 --- Comment #2 from Marc V?ron --- Created attachment 38395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38395&action=edit [Signed-off] Bug 14051: Tiny adjustment of ReturnPathDefault pref description Adding that Return-Path is bounce address. Note that if it is empty, the From address is used. This could be the admin address, but Koha uses other from addresses too. Test plan: Read the description on the preferences page. Check some Koha mails with/without this pref. Note that this patch does not change behavior in any way. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 10:50:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 08:50:24 +0000 Subject: [Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #38394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 10:50:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 08:50:35 +0000 Subject: [Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 11:17:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 09:17:57 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Katrin Fischer --- 1) Regression test Change of the file name when no options specified but the directory: From: holdnotices-.html ToL notices_hold-.html As by default all notices (including overdues) are in the file, maybe we could rename it to be more general just: notices_.html? (trivial) 2) -s splits by branch The output is identical. 3) --nosend works - helpful in testing! 4) --letter_code generates a nicely named file with only those notices! 5) --ods creates a warn: Use of uninitialized value in lc at /usr/share/perl5/OpenOffice/OODoc/File.pm line 378. 6) --csv This one is giving me some trouble: First I thought it was the concatenation: cardnumber:patron:email:item 1:Koha >:patron at localhost: But this is also not giving all data: cardnumber:patron:patron:email:item 1:Koha:>:patron at localhost: Barcode and surname are missing, but set in the database. We are pretty close here - it's a great enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 11:29:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 09:29:19 +0000 Subject: [Koha-bugs] [Bug 10886] When intranetreadinghistory is set to not allow - staff can still view patron's history in item history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 11:29:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 09:29:21 +0000 Subject: [Koha-bugs] [Bug 10886] When intranetreadinghistory is set to not allow - staff can still view patron's history in item history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38384|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 38396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38396&action=edit [PASSED QA] Bug 10866: Hide patron's history if intranetreadinghistory is set to not allow If set to "not allow", the intranetreadinghistory pref prevent staff members to access patron's checkout history. But: 1/ The page is still accessible if you know the url 2/ The history can be consulted on the item history page Test plan: 0/ Don't apply this patch 1/ Set the intranetreadinghistory to allow 2/ Go on a patron's checkout history page 3/ Open a new tab and go on a item's checkout history page 4/ Set the intranetreadinghistory to not allow 5/ Refresh both pages => no change 6/ Apply this patch 7/ Refresh both page. On the first page, you should see a warning On the other one, you should see that the patron column is not displayed anymore. Followed test plan, results were as expected. Signed-off-by: Marc V?ron http://bugs.koha-community.org/show_bug.cgi?id=10886 Signed-off-by: Katrin Fischer Nice addition! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 11:47:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 09:47:37 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- I can not trigger the error after test plan #2 (without patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 11:49:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 09:49:32 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #75 from Katrin Fischer --- 1) Shoudl this be included on the about.pl page? +// Extends jQuery API +// http://www.wskidmore.com/downloads/jquery-uniqueArray.min.js 2) I think there are display problems, when both the cart and the lists are turned off: For example, this is only available with the prefs ON: var MSG_NO_RECORD_SELECTED = _("No item was selected"); Browse selected record still shows up, but I see only one checkbox on my third record in the list? (confusing) I am not logged in and tried in 2 different browsers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 11:56:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 09:56:39 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 11:59:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 09:59:25 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #24 from Julian Maurice --- Created attachment 38397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38397&action=edit Bug 11999: Check for age restriction in CanBookBeReserved + improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 12:00:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 10:00:31 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Julian Maurice --- This patch should make the "age restriction" test pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 12:17:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 10:17:14 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 --- Comment #5 from Julian Maurice --- Created attachment 38398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38398&action=edit [PASSED QA] Bug 13687: Move hold policy check into CanItemBeReserved Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 12:22:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 10:22:48 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 12:23:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 10:23:24 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 12:44:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 10:44:15 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 12:52:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 10:52:46 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Katrin Fischer --- Hi Kyle, can you please take a look at Jonathan's comment#38? +use C4::Koha qw/GetSupportList/; I am not sure about some of the changes being intentional? if ($displayby =~ /status/i) { - if ( grep { /^($criteriumvalue)$/ } qw(ASKED ACCEPTED REJECTED CHECKED ORDERED AVAILABLE) ) { - return ($criteriumvalue eq 'ASKED'?"Pending":ucfirst(lc( $criteriumvalue))); - } else { - return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue) || $criteriumvalue; + unless ( grep { /$criteriumvalue/ } qw(ASKED ACCEPTED REJECTED CHECKED ORDERED AVAILABLE) ) { + return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue ) || "Unknown"; } + return ($criteriumvalue eq 'ASKED'?"Pending":ucfirst(lc( $criteriumvalue))) if ($displayby =~/status/i); } return (GetBranchName($criteriumvalue)) if ($displayby =~/branchcode/); - return (GetSupportName($criteriumvalue)) if ($displayby =~/itemtype/); + return GetAuthorisedValueByCode('SUGGEST_FORMAT', $criteriumvalue) || "Unknown" if ($displayby =~/itemtype/); Also, "Pending" looks untranslatable there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:00:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:00:12 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 Rolando Isidoro changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |rolando.isidoro at gmail.com |ity.org | --- Comment #1 from Rolando Isidoro --- Created attachment 38399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38399&action=edit Patch that adds date validation This patch adds validation to prevent the error from occurring. Test plan Before applying the patch 1 - In the intranet interface pick a serial biblio record with a subscription with empty "Planned date" and/or "Published date"; 2 - Click the "Subscription(s)" tab on the left side; 3 - Click the subscription title link to view it's detail; The error should occur at this point. Apply the patch, follow the 3 steps from the test plan and the error shouldn't show up anymore. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:00:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:00:50 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 Rolando Isidoro changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:22:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:22:39 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:22:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:22:41 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37984|0 |1 is obsolete| | Attachment #37985|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 38400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38400&action=edit [PASSED QA] Bug 10020: Remove DB table and fields related to ethnicity This patch remove the ethnicity table and the ethnicity and ethnotes fields from the 3 tables: borrowers, deletedborrowers and borrower_modifications IF no data exist. Test plan: 0/ Apply this patch and update the Koha::Schema (misc/devel/update_dbix_class_files.pl). 1/ Make sure the ethnicity has at least 1 entry 2/ Launch the updatedb entry and confirm you get a warning message and the DB structure is not updated. 3/ truncate the ethnicity table and fill ethnicity (or ethnotes) for at least 1 row of the borrowers table. 4/ Launch the updatedb entry and confirm you get a warning message and the DB structure is not updated. 5/ Make sure the ethnicity table is empty as well as the ethniciy and the ethnotes fields of borrowers, deletedborrowers and borrower_modifications 6/ Launch the updatedb entry and confirm you don't get the warning message and the DB structure is updated (ie. table and fields dropped). Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:22:49 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #14 from Kyle M Hall --- Created attachment 38401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38401&action=edit [PASSED QA] Bug 10020: Remove code related to ethnicity This is a(nother) vestige of Koha (2.2?). This patch removes unused code related to the 'ethnicity'. In detail: There is no way to fill the ethnicity table. There is no way to fill the borrowers.ethnicity and borrowers.ethnotes. BUT if borrowers.ethnicity exists, the value is displayed on members/moremember.pl (and only here). Test plan: Apply this patch and confirm there is no regression on adding/updating/deleting patrons. Note that you don't see the ethnicity value on the moremember.pl page even if a patron has it. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:27:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:27:16 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38393|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 38402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38402&action=edit [PASSED QA] Bug 11006: Drop column aqorders.totalamount This column was not used in the Koha codebase, it can be removed. Test plan: Execute the updatedatabase.pl script and confirm that the column has been dropped. QA step: 1/ git grep totalamount 2/ prove t/db_dependent/Acquisition.t Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:27:14 +0000 Subject: [Koha-bugs] [Bug 11006] Useless column totalamount in aqorders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:27:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:27:27 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #49 from Jonathan Druart --- Created attachment 38403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38403&action=edit Bug 11603: Change the output filenames The output filename is notices_all_.[html|csv|ods] if no letter_code parameter is given. If 1 is given: notices__.[html|csv|ods] If 1+ are given: noties__...__.[html|csv|ods] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:32:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:32:47 +0000 Subject: [Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:32:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:32:49 +0000 Subject: [Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38395|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 38404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38404&action=edit [PASSED QA] Bug 14051: Tiny adjustment of ReturnPathDefault pref description Adding that Return-Path is bounce address. Note that if it is empty, the From address is used. This could be the admin address, but Koha uses other from addresses too. Test plan: Read the description on the preferences page. Check some Koha mails with/without this pref. Note that this patch does not change behavior in any way. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:48:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:48:13 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #76 from Jonathan Druart --- Created attachment 38405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38405&action=edit Bug 10858: Define the NO_RECORD_SELECTED msg in any case And not only when cart or list are defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:52:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:52:33 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #2 from M. Tompsett --- Comment on attachment 38399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38399 Patch that adds date validation Review of attachment 38399: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14036&attachment=38399) ----------------------------------------------------------------- ::: C4/Serials.pm @@ +2246,5 @@ > my $expirationdate = GetExpirationDate($subscriptionid); > my ($res) = $dbh->selectrow_array('select max(planneddate) from serial where subscriptionid = ?', undef, $subscriptionid); > my $nextdate = GetNextDate($subscription, $res); > + > + return unless ($nextdate and $expirationdate); See also bug 13109. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:52:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:52:44 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13109 CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:52:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:52:44 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14036 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:52:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:52:54 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:52:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:52:57 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38229|0 |1 is obsolete| | Attachment #38236|0 |1 is obsolete| | Attachment #38239|0 |1 is obsolete| | Attachment #38283|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 38406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38406&action=edit [PASSED QA] Bug 13889 - Add information about cron jobs to system log This patch adds information about cron jobs performed and make it viewable under Home > Tools > Logs ("Browse system logs") To test: Apply patch - Got to system preferences and set 'CronjobLog' to: [Log] information from cron jobs. - Run some cron jobs - Go to Home > Tools > Logs - Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it with Action "All" and Submit. - Output should show Date/time and info about Cron jobs Rebased to work on top of Bug 6911 (conflict in viewlog.tt) /MV Rebased after applying patch for Bug 6911 /MV Conflicts resolved: misc/cronjobs/overdue_notices.pl misc/cronjobs/cleanup_database.pl Signed-off-by: Frederic Demians - Merge both patches, and fix updatedatabase.pl - Works as described. Provide intersting feedback from cronjob scripts. -- Modified version taking in account syspref CronJobLog. Handling simplified by introducing a convenience sub cronlogaction in C4/Log.pm /MV Amended to take in account comments #11, #12, #13 /MV http://bugs.koha-community.org/show_bug.cgi?id=13899 Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:53:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:53:19 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #28 from Kyle M Hall --- Created attachment 38407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38407&action=edit [PASSED QA] Bug 13889: Added Test Coverage Previous commit was lacking test coverage of new function. TEST PLAN --------- 1) Apply all the patches 2) prove -v t/db_dependent/Log.t -- should be success. 3) koha qa test tools Signed-off-by: Marc V?ron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:53:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:53:22 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #29 from Kyle M Hall --- Created attachment 38408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38408&action=edit [PASSED QA] Provide parameter $infos in cronlogaction() (Alternative for patch Bug 13889: Log with parameters) To test: - Apply patches interactive and skip following patch: Bug 13889: Log with parameters - Tweak a cron job in order to call cronlogaction twice, one with a param at the beginning of the cron ob, e.g. cronlogaction("This is my message") and one without param. - Run this cron job. Result: You should have two entries in the log, one with and one without additional information after the path and name of the calling script. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:53:25 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #30 from Kyle M Hall --- Created attachment 38409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38409&action=edit Bug 13889 [QA Followup] - Supress warning, set object column to undef instead of 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:56:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:56:31 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #77 from Jonathan Druart --- (In reply to Katrin Fischer from comment #75) > 1) Shoudl this be included on the about.pl page? > +// Extends jQuery API > +// http://www.wskidmore.com/downloads/jquery-uniqueArray.min.js The domain is down and I don't know at all where I found this piece of code. It was certainly under the MIT license. > 2) I think there are display problems, when both the cart and the lists are > turned off: > > For example, this is only available with the prefs ON: > var MSG_NO_RECORD_SELECTED = _("No item was selected"); Ok fixed. > Browse selected record still shows up, but I see only one checkbox on my > third record in the list? (confusing) > > I am not logged in and tried in 2 different browsers. I don't get it, I have never seen that. Please provide more info to recreate the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:58:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:58:53 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:58:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:58:56 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38380|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 38410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38410&action=edit [PASSED QA] Bug 13834 - News: Wording not consistent for Publication date / Creation date This patch replaces column header "Creation date" with "Publication date" in staff client > Home > Tools > News (same as the field label in editing form for news). To test apply patch and verify that column header displays as appropriate. Signed-off-by: vagrant Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 13:59:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 11:59:54 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #50 from Katrin Fischer --- (In reply to Katrin Fischer from comment #48) > 1) File names make sense now. > 6) --csv > This one is giving me some trouble: This is solved, I had an error in my thinking about the template - using <> in ODUE doesn't work without . The remaining problem is now with the ods export, working on it with Joubu: > 5) --ods creates a warn: > Use of uninitialized value in lc at > /usr/share/perl5/OpenOffice/OODoc/File.pm line 378. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:02:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:02:19 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 --- Comment #8 from Katrin Fischer --- Kyle, could you fix up the sign off line from Eivin? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:05:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:05:40 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #3 from M. Tompsett --- Comment on attachment 38399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38399 Patch that adds date validation Review of attachment 38399: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14036&attachment=38399) ----------------------------------------------------------------- ::: C4/Serials.pm @@ +2386,4 @@ > if ($freqdata->{'unit'}) { > my ( $year, $month, $day ) = split /-/, $publisheddate; > > + return unless check_date($year, $month, $day); Not necessary, because: return unless $subscription and $publisheddate; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:06:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:06:55 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from M. Tompsett --- *** This bug has been marked as a duplicate of bug 13109 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:06:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:06:55 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rolando.isidoro at gmail.com --- Comment #10 from M. Tompsett --- *** Bug 14036 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:07:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:07:51 +0000 Subject: [Koha-bugs] [Bug 13889] Add information about cron jobs to system log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #31 from Jonathan Druart --- Kyle, Have you seen the discussion before? What's your opinion on it? See from comment 22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:11:16 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #26 from M. Tompsett --- (In reply to Julian Maurice from comment #25) > This patch should make the "age restriction" test pass This may totally be tangential and unrelated, but I vaguely recall hitting an age restriction problem in some test file, and it turned out to be a timezone mismatch problem somewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:28:50 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:28:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:28:55 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38385|0 |1 is obsolete| | Attachment #38386|0 |1 is obsolete| | Attachment #38387|0 |1 is obsolete| | Attachment #38388|0 |1 is obsolete| | Attachment #38389|0 |1 is obsolete| | Attachment #38390|0 |1 is obsolete| | Attachment #38391|0 |1 is obsolete| | Attachment #38392|0 |1 is obsolete| | Attachment #38403|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer --- Created attachment 38411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38411&action=edit [PASED QA] Bug 11603: Preparation step, cleaning up This patch refactores and adds some good practices: - use Modern::Perl - use Pod::Usage - add POD Signed-off-by: Frederic Demians Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:29:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:29:03 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #52 from Katrin Fischer --- Created attachment 38412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38412&action=edit [PASSED QA] Bug 11603: Gather print notices - add a csv parameter This patch adds: - the ability to generate a csv file instead of a html file. - a letter_code parameter. >From now you are able to generate a csv file for print notices. Imagine a template notice defined as: cardnumber:patron:email:item <>:<> >:<>:<> You would like to generate a csv file and not a html file. Test plan: - define your ODUE notice for the print template as: cardnumber:patron:email:item <>:<> <>:<>:<> - define overdues rules for a patron category - check 2 items out using a due date in order to generate the overdue notices - check these 2 items in - launch the overdue_notices script - the message_queue table should now contain 2 new entries - launch the gather_print_notices cronjob with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE --letter_code=CHECKIN you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv you should get an error perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --letter_code=OVERDUE -d=: will produce 1 csv file in your /tmp/test directory - verify the csv file is correct and contain only 1 csv header column. Signed-off-by: Frederic Demians Signed-off-by: Katrin Fischer QA note: Keep in mind that you can use all placeholders for the csv that you can use for the normal templates. If you normally get the item information from you need to use that. If you can use <> directly, you can also do so in the csv. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:29:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:29:11 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #53 from Katrin Fischer --- Created attachment 38413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38413&action=edit [PASSED QA] Bug 11603: Gather print notices - add a ods parameter This patch adds: - the ability to generate an ods file >From now you are able to generate a ods file for print notices. You would like to generate a csv file and not a html file. Test plan: - same as previous patch but test the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods --letter_code=OVERDUE -d=: you should get an error because csv2ods is not installed. Follow the installation instructions and try again the command. A ods file should be generated in your /tmp/test directory. Signed-off-by: Frederic Demians Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:29:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:29:15 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #54 from Katrin Fischer --- Created attachment 38414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38414&action=edit [PASSED QA] Bug 11603: If a letter code is given, filenames should contain it If you choose to generate print notices for a specific letter code, the generated files should be distinct. The use case is: you want to process print notice for letter codes: overdue1, overdue2 and overdue3. The cronjobs will be: perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue1 --csv --ods --html --delimiter=";" perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue2 --csv --ods --html --delimiter=";" perl misc/cronjobs/gather_print_notices.pl /tmp --letter_code=overdue3 --csv --ods --html --delimiter=";" without this patch, the 2 first files will be erased. Signed-off-by: Frederic Demians Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:29:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:29:20 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #55 from Katrin Fischer --- Created attachment 38415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38415&action=edit [PASSED QA] Bug 11603: Fix encoding issues (bug 11944 is now pushed) Signed-off-by: Frederic Demians No more encoding issue with html file, no problem with csv|ods Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:29:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:29:25 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #56 from Katrin Fischer --- Created attachment 38416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38416&action=edit [PASSED QA] Bug 11603 Add --send|--nosend, fix stuf Fix --html without --letter_code Fix --ods which was producing a 2 lines ods file Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:29:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:29:29 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #57 from Katrin Fischer --- Created attachment 38417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38417&action=edit Bug 11603: Some minor documentation changes Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:29:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:29:34 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #58 from Katrin Fischer --- Created attachment 38418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38418&action=edit [PASSED QA] Bug 11603: (follow-up) pod The filenames will change Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:29:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:29:38 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #59 from Katrin Fischer --- Created attachment 38419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38419&action=edit [PASSED QA] Bug 11603: Change the output filenames The output filename is notices_all_.[html|csv|ods] if no letter_code parameter is given. If 1 is given: notices__.[html|csv|ods] If 1+ are given: noties__...__.[html|csv|ods] Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:34:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:34:58 +0000 Subject: [Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603 --- Comment #60 from Katrin Fischer --- The warn only appeared on my system, but the file was still created. For me this is not a blocker currently. This patch is a big improvement over the existing script, while I couldn't detect any regressions. It adds useful options. The file name changes slightly, but this is a fix to a bug - the file doesn't only include holds messages nowadays and hasn't for quite a while. The file name properly reflects that now. (bug 12810) There seem to be some issues in our way to enqueue messages and in determining the mtt = print - but they are outside the scope of this script, that just deals with the results of the processes done before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 14:48:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 12:48:09 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 Rolando Isidoro changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #5 from Rolando Isidoro --- Hi M. Tompsett, the bugs are very similar indeed but this problem occurs for 'planneddate' while #13109 refers to 'startdate' or 'enddate'. As for the patch I submitted, both validation are required, the check_date one you mentioned as not being needed is mandatory to solve the problem as the error occurs in the GetNextDate function. I'm reverting the status to 'REOPENED', can you please take a second look at it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:03:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:03:09 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Signed Off |In Discussion --- Comment #8 from Kyle M Hall --- Pardon my being late to reply to this, but could this be solved with a a screen message regex? If not, please reset the status of this bug. (In reply to Bob Birchall from comment #0) > When a Koha user offers correct credentials, Overdrive redirects to the > users' > Overdrive account page and no messages from Koha are displayed. > > However: > 1. Where a correct cardnumber is entered with an incorrect password, Koha's > SIP server responds with '(1) Greetings from Koha.' > 2. Where an incorrect cardnumber is entered (with any password), the SIP > server responds with a blank message: '(1) ' > > These are displayed on an Overdrive page which includes a link: 'Click here > to return to the sign in form' but there is nothing to draw the user's > attention to their error and the need to follow that link back to try again. > > We propose to replace these messages with 'You have entered an incorrect > cardnumber or password. Please try again.' This will appear just above > the 'Click here to return ...' link and should make the process obvious for > the user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:06:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:06:00 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #9 from Katrin Fischer --- Hm, not sure this would work? 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha?' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha?' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:06:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:06:21 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #10 from Katrin Fischer --- ... and 1 being the cardnumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:27:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:27:48 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:27:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:27:50 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38222|0 |1 is obsolete| | --- Comment #11 from Nicole C. Engard --- Created attachment 38420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38420&action=edit Bug 14024 - add reports to action logs This patch sets adds the possibility to log new, update and delete actions for saved reports. To test: -Apply patch -Run updatedatabase.pl -Enable system preference ReportsLog -Create, duplicate, edit and delete saved reports -Go to Home > Tools > Logs -Verify that you can select "Reports" in Modules list -Verify that your actions were logged Signed-off-by: Nicole Engard Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:28:50 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38420|0 |1 is obsolete| | --- Comment #12 from Nicole C. Engard --- Created attachment 38421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38421&action=edit Bug 14024 - add reports to action logs See QA comment #5 - new reports log their Id instead of 0 - format info: | Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:29:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:29:15 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > I like the idea of this! > > 1) Should we hide the field for AcqCreateItem = 'cataloguing'? And maybe > also 'receive'? (normal) It's not a new field, and it needs to be filled. I think we should keep it. > 2) I wonder if there is a use case a library might want to keep the initial > order date instead. The way this patch works they can't see the initial date > and they can't keep it. (question) They can manually change it. We could fix this workflow later if someone ask for it. > 3) Currently the field is named 'Date received', maybe we should use the > description of the item field it updates - 'Date acquired' to make the use > more clear? I am not sure to understand, the date is used to fill aqorders.datereceived. "Date received" seems to fit quite well :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:30:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:30:08 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 --- Comment #13 from Nicole C. Engard --- Strange - i signed off on the follow up but it's not attaching right. Will figure this out in a second. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:31:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:31:27 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38383|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:31:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:31:51 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38421|Bug 14024 - add reports to |[Folluw-up] Bug 14024 - add description|action logs |reports to action logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:32:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:32:04 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38420|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:32:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:32:20 +0000 Subject: [Koha-bugs] [Bug 14024] add reports to action logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 --- Comment #14 from Nicole C. Engard --- Okay, I think I fixed it. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:32:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:32:53 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 --- Comment #8 from Katrin Fischer --- Oh! I thought in my tests it influenced the items.dateaccessioned. Is that possible? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:42:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:42:12 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #43 from Jonathan Druart --- Created attachment 38422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38422&action=edit Bug 11625: [COUNTER-PATCH] Implement DefaultToLoggedInLibraryNoticesSlips -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:45:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:45:40 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #8) > Oh! I thought in my tests it influenced the items.dateaccessioned. Is that > possible? I think this is set to today before and after the patch. But I didn't test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:46:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:46:51 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #44 from Jonathan Druart --- (In reply to Jonathan Druart from comment #43) > Created attachment 38422 [details] [review] > Bug 11625: [COUNTER-PATCH] Implement DefaultToLoggedInLibraryNoticesSlips Kyle, either I missed something and this patch is wrong or it does the same as yours. It looks simpler. Could you please take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:49:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:49:55 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:49:58 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36378|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 38423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38423&action=edit Bug 7939 - Separate po files for different MARC dialects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:50:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:50:34 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 --- Comment #18 from Jonathan Druart --- All looks good, great work Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 15:50:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 13:50:41 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:08:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:08:28 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13852 Blocks|13852 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:08:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:08:28 +0000 Subject: [Koha-bugs] [Bug 13852] Manage C4::VirtualShelves in C4::Auth for performance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13852 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 Depends on|7923 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:10:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:10:36 +0000 Subject: [Koha-bugs] [Bug 3445] action_logs table needs some thought In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:10:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:10:36 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3445 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:23:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:23:31 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38422|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 38424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38424&action=edit Bug 11625: [COUNTER-PATCH] Implement DefaultToLoggedInLibraryNoticesSlips -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:25:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:25:40 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #46 from Jonathan Druart --- (In reply to Jonathan Druart from comment #45) > Created attachment 38424 [details] [review] > Bug 11625: [COUNTER-PATCH] Implement DefaultToLoggedInLibraryNoticesSlips I tried to clean the branchcode value is this patch. It is the same idea as in your patch, if branchcode eq '*', the user has selected the 'all libraries' in the dropdown list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:29:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:29:30 +0000 Subject: [Koha-bugs] [Bug 14027] Add TableTools plugin for DataTables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- I have never an answer of my question concerning this new plugin on bug 6427 comment 583. Why did you move it out this bug? Do you plan to use it for another development? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:29:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:29:45 +0000 Subject: [Koha-bugs] [Bug 14027] Add TableTools plugin for DataTables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 --- Comment #4 from Jonathan Druart --- get* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:36:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:36:49 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #41 from Julian Maurice --- Created attachment 38425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38425&action=edit Bug 7957: Add unit tests for new subroutines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:37:20 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:42:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:42:55 +0000 Subject: [Koha-bugs] [Bug 11490] Deleting Batch Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, | |katrin.fischer at bsz-bw.de, | |nengard at gmail.com Status|NEW |In Discussion See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11343, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8246 --- Comment #1 from Jonathan Druart --- Nicole, Katrin, Could I get your opinion on this one? Bug 8246 has been pushed a couple of weeks ago and there is inconsistency between these 2 bug reports. According to the syspref description it should be considered as a bug. "MaxItemsForBatch: Process up to XXX items in a single modification or deletion batch." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:42:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:42:55 +0000 Subject: [Koha-bugs] [Bug 11343] The max number of items to process in a batch is hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11490 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:42:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:42:55 +0000 Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11490 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 16:43:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 14:43:07 +0000 Subject: [Koha-bugs] [Bug 11490] Deleting Batch Items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:05:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:05:43 +0000 Subject: [Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:05:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:05:45 +0000 Subject: [Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 --- Comment #1 from Jonathan Druart --- Created attachment 38426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38426&action=edit Bug 11464: Prevent wrong "nothing to save" message on saving syspref Sometime you get the "Nothing to save" message when clicking on the "save all preferences" button, even if something has changed. On irritating behavior is the middle click: if you use the middle click to paste some text in the input, the "keyup" event won't be trigger. This patch replaces the "keyup" event with the "change", which works as we want here. The issues: 1/ Search for "wanted" (admin/preferences.pl?op=search&searchfield=wanted) Empty the input, click save Type something and remove it You are able to save, but nothing has changed 2/ Put something in your selection buffer and use the middle click to paste it in the input. No change detected. Test plan: Confirm the issues are fixed and you don't find any regression Note that now the "(modified)" string is displayed when the input loses the focus. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:06:02 +0000 Subject: [Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:07:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:07:20 +0000 Subject: [Koha-bugs] [Bug 11454] Cannot indicate time on Circulation Rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11454 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- This is more an enh request than a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:13:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:13:38 +0000 Subject: [Koha-bugs] [Bug 14016] Due dates in OPAC show 0:00 when it should be 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:14:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:14:00 +0000 Subject: [Koha-bugs] [Bug 14022] Subscription form resets 'subscription length' to issues on editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:16:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:16:26 +0000 Subject: [Koha-bugs] [Bug 10706] keyword search on reports should search report number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:18:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:18:45 +0000 Subject: [Koha-bugs] [Bug 14008] Filters are not displayed on search for reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14008 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:19:18 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #20 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:21:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:21:00 +0000 Subject: [Koha-bugs] [Bug 11448] Accessibility: Make it possible to enter date for restriction without using the datepicker widget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11448 --- Comment #2 from Jonathan Druart --- Created attachment 38427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38427&action=edit Bug 11448: Remove readonly on datepicker - request.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:23:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:23:43 +0000 Subject: [Koha-bugs] [Bug 11448] Accessibility: Make it possible to enter date for restriction without using the datepicker widget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|NEW |In Discussion --- Comment #3 from Jonathan Druart --- So... We have this solution (see patch), it's easy but there is no check on the date format. If you submit the form with a wrong date, you get the ugly software error message. What's better? Wait to have a system to catch dates not correctly formatted or go for this method for the moment? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:28:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:28:54 +0000 Subject: [Koha-bugs] [Bug 11448] Accessibility: Make it possible to enter date for restriction without using the datepicker widget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:34:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:34:52 +0000 Subject: [Koha-bugs] [Bug 11407] Patron search for borrowernumber doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11407 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED --- Comment #1 from Jonathan Druart --- This is fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:35:17 +0000 Subject: [Koha-bugs] [Bug 11448] Accessibility: Make it possible to enter date for restriction without using the datepicker widget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11448 --- Comment #4 from Christopher Brannon --- (In reply to Jonathan Druart from comment #3) > So... > We have this solution (see patch), it's easy but there is no check on the > date format. > If you submit the form with a wrong date, you get the ugly software error > message. > > What's better? Wait to have a system to catch dates not correctly formatted > or go for this method for the moment? This would be a step backwards. Is there no way to implement validation after key up or on submit? We use jquery validation for patron account entry that prevents submission until validation errors are corrected. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:37:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:37:05 +0000 Subject: [Koha-bugs] [Bug 14053] New: Acquisition db tables are missing indexes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Bug ID: 14053 Summary: Acquisition db tables are missing indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Acquisition db tables have a lot of relational constraints and are often missing an index to have performance queries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:37:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:37:12 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:37:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:37:21 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:37:35 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14053 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:37:35 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:42:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:42:20 +0000 Subject: [Koha-bugs] [Bug 11356] can't order from suggestions not at my branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11356 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Nicolde, This seems to be fixed, could you please confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:43:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:43:35 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 38428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38428&action=edit Bug 13023: (RM followup) DBIx updates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:50:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:50:21 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- It seems to be fixed, please reopen if I am wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 17:57:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 15:57:54 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Does not appears on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:00:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:00:38 +0000 Subject: [Koha-bugs] [Bug 11267] default notices should not be allowed to be deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11267 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- I can imagine some cases where they could be deleted. For instance if you create specific letters for each branch, you don't need the default "all libraries" letters. Or if you want to be sure the letter won't never use. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:03:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:03:18 +0000 Subject: [Koha-bugs] [Bug 11236] callnumber no longer can be searched in serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11236 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- There is a specific field for call number (see on serials/serials-search.pl). Not sure this is valid. Please reopen if you think it is. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:07:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:07:21 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38351|0 |1 is obsolete| | --- Comment #32 from Tom?s Cohen Arazi --- Created attachment 38429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38429&action=edit The script we use to update the schema didn't like the checksum of the provided patch. So I obsolete it and regenerate properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:11:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:11:44 +0000 Subject: [Koha-bugs] [Bug 11399] batch Rebuild Items Tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Stephane! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:12:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:12:09 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #26 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:12:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:12:34 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #17 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:13:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:13:00 +0000 Subject: [Koha-bugs] [Bug 13834] News: Wording not consistent for Publication date / Creation date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13834 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:13:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:13:22 +0000 Subject: [Koha-bugs] [Bug 14051] Tiny adjustment of ReturnPathDefault pref description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14051 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:14:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:14:01 +0000 Subject: [Koha-bugs] [Bug 8474] Holds done by librarians cause silent errors in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8474 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. we love removing useless warnings, thanks Olli! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:14:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:14:31 +0000 Subject: [Koha-bugs] [Bug 13994] Add a back link to error message in Reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13994 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Useful one Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:14:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:14:56 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #33 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:22:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:22:56 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:22:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:22:58 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16302|0 |1 is obsolete| | Attachment #37008|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 38430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38430&action=edit Bug 9805 - Lost items are un-lost if returned, but not if renewed. If an item has a lost status, that status is removed when the item is returned. However, it is not removed if the item is renewed. Test Plan: 1) Check an item out to a patron, back date the due date 6 months 2) Run misc/cronjobs/longoverdue.pl -l 30=2 --confirm 3) Verify the item is now checked out but lost 4) Renew the item, verify the item is still lost 5) Apply this patch 6) Renew the item again, verify the item is no longer lost Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:23:16 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 --- Comment #43 from Tom?s Cohen Arazi --- Created attachment 38431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38431&action=edit Bug 13606: (RM followup) DBIx updates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:28:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:28:07 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38430|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 38432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38432&action=edit Bug 9805 - Lost items are un-lost if returned, but not if renewed. If an item has a lost status, that status is removed when the item is returned. However, it is not removed if the item is renewed. Test Plan: 1) Check an item out to a patron, back date the due date 6 months 2) Run misc/cronjobs/longoverdue.pl -l 30=2 --confirm 3) Verify the item is now checked out but lost 4) Renew the item, verify the item is still lost 5) Apply this patch 6) Renew the item again, verify the item is no longer lost Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:28:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:28:17 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #20 from Kyle M Hall --- Created attachment 38433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38433&action=edit Bug 9805 [QA Followup] - Control renewing and finding of list items via circ rules Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circ rules 4) Note the "Renew lost?" and "Renewal marks lost found" rules 5) Set and test each of the rules both ways for the rules for all libraries 6) Repeat but for a specific branch this time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:28:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:28:43 +0000 Subject: [Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #44 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan and Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:31:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:31:45 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35511|0 |1 is obsolete| | Attachment #35512|0 |1 is obsolete| | Attachment #35513|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 38434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38434&action=edit Bug 13492: Add the column configuration for the checkouts table - circulation.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (circulation.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:31:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:31:51 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 --- Comment #11 from Jonathan Druart --- Created attachment 38435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38435&action=edit Bug 13492: Add the column configuration for the checkouts table - morember.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (moremember.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:31:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:31:56 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 --- Comment #12 from Jonathan Druart --- Created attachment 38436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38436&action=edit Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin). Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:52:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:52:02 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 --- Comment #13 from Kyle M Hall --- Created attachment 38437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38437&action=edit Bug 13022 [QA Followup] - Revert changes in whitespace back to original for items count lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:53:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:53:35 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38437|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 38438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38438&action=edit Bug 13022 [QA Followup] - Revert changes in whitespace back to original for items count lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:58:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:58:37 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #30 from Winona Salesky --- Great! Thanks, -Winona (In reply to Tom?s Cohen Arazi from comment #29) > P?tch pushed to master. > > Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 18:58:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 16:58:58 +0000 Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 --- Comment #13 from Winona Salesky --- Great! Thank you, -Winona (In reply to Tom?s Cohen Arazi from comment #12) > Patch pushed to master. > > Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:31:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:31:19 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:31:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:31:21 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37893|0 |1 is obsolete| | Attachment #38286|0 |1 is obsolete| | --- Comment #18 from Charles Farmer --- Created attachment 38439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38439&action=edit Bug 12747 - Add extra column in Z3950 search This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:31:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:31:37 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #19 from Charles Farmer --- Created attachment 38440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38440&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:33:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:33:50 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 --- Comment #15 from Kyle M Hall --- (In reply to Jonathan Druart from comment #11) > I tried with and without the patch, I modified the pref value, but always > got the same display. > > Could I get a more complete test plan? Here's a screencast demo: http://screencast.com/t/dXO8k9MCpaA This is with the patch set applied. I made it simple. The record in question has two items, the second of which is on hold. With any number greater then 2 in the syspref, the item statuses are accurate. But, if you drop the system preference down to 1, it only checks the status of the first item, and thus you get inaccurate results on the search results page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:37:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:37:28 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #20 from Charles Farmer --- These two new patches should do the trick. The code in updatedatabase.pl was moved to an atomicupdate script and the second patch was cleaned of the dangling "<<<< HEAD" stuff. Everything applies cleanly on master for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:46:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:46:56 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:46:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:46:59 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37113|0 |1 is obsolete| | Attachment #37114|0 |1 is obsolete| | Attachment #37115|0 |1 is obsolete| | Attachment #37116|0 |1 is obsolete| | Attachment #37117|0 |1 is obsolete| | --- Comment #102 from Kyle M Hall --- Created attachment 38441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38441&action=edit Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:47:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:47:07 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #103 from Kyle M Hall --- Created attachment 38442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38442&action=edit Bug 9011 - Add the ability to store the last patron to return an item Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:47:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:47:12 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #104 from Kyle M Hall --- Created attachment 38443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38443&action=edit Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:47:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:47:15 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #105 from Kyle M Hall --- Created attachment 38444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38444&action=edit Bug 9011 [QA Followup] Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 19:47:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 17:47:18 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #106 from Kyle M Hall --- Created attachment 38445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38445&action=edit Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:01:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:01:06 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38328|0 |1 is obsolete| | Attachment #38329|0 |1 is obsolete| | Attachment #38330|0 |1 is obsolete| | Attachment #38331|0 |1 is obsolete| | --- Comment #220 from Kyle M Hall --- Created attachment 38446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38446&action=edit Bug 9303 [1] - relative's checkouts in the opac - Database Updates This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:01:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:01:17 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #221 from Kyle M Hall --- Created attachment 38447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38447&action=edit Bug 9303 [2] - relative's checkouts in the opac - Schema Updates e opac/svc/patron/ Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:01:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:01:22 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #222 from Kyle M Hall --- Created attachment 38448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38448&action=edit Bug 9303 [3] - relative's checkouts in the opac Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:01:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:01:29 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #223 from Kyle M Hall --- Created attachment 38449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38449&action=edit Bug 9303 [QA Followup] - Remove extra 'USE Koha', change "Call number" back to "Call no." Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:01:33 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #224 from Kyle M Hall --- Created attachment 38450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38450&action=edit Bug 9303 [QA Followup] - Restore missing biblio relationship -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:09:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:09:51 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #11 from Kyle M Hall --- I see. I hadn't looked deeply enough to realize 1 was the card number. In that case my solution won't work. (In reply to Katrin Fischer from comment #10) > ... and 1 being the cardnumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:16:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:16:39 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:16:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:16:41 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37539|0 |1 is obsolete| | Attachment #37543|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 38451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38451&action=edit Bug 13871 - perltidy build_patron_status perltidy build_patron_status() sub -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:17:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:17:33 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38451|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 38452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38452&action=edit Bug 13871 - perltidy build_patron_status perltidy build_patron_status() sub -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:17:43 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #15 from Kyle M Hall --- Created attachment 38454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38454&action=edit Bug 13871 [QA Followup] - Rename parameter to send_msg_on_invalid_credentials There are likely other services that would use this same feature. Let's name it something a bit more general. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:17:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:17:40 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #14 from Kyle M Hall --- Created attachment 38453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38453&action=edit Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha?' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha?' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha?' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' http://bugs.koha-community.org/show_bug.cgi?id=1387 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:40:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:40:05 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #16 from Kyle M Hall --- Created attachment 38455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38455&action=edit Bug 13871 [QA Followup] - Fix namespaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 20:49:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 18:49:19 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Kyle M Hall --- This is looking really good, but I think if we are going to change the behavior for the patron status response, I think we should have the same behavior for the patron information response as well. Mason, can you implement that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:08:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:08:43 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Sheila Kearns changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sheila.kearns at state.vt.us --- Comment #1 from Sheila Kearns --- It may be a different area of permissions, but it would also be useful if permission to delete patrons was separate from permissions to add and modify patrons. Circulation staff need to add and modify, but an option to prevent them from deleting patrons would be usefuo. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:12:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:12:28 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #6 from M. Tompsett --- (In reply to Rolando Isidoro from comment #5) > As for the patch I submitted, both validation are required, the check_date > one you mentioned as not being needed is mandatory to solve the problem as > the error occurs in the GetNextDate function. > > I'm reverting the status to 'REOPENED', can you please take a second look at > it? GetNextDate receives a parameter $publisheddate (which it may or may not be). As far as I can tell, it is either: NULL, 0000-00-00 (MySQL badness), or a valid MySQL date (YYYY-MM-DD). I have confirmed that 0000-00-00 triggers an error. I'll be attaching tests that were missing. Please remove the first part of this patch, as 13109 resolves that issue. Perhaps add a dependency? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:18:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:18:33 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #21 from Marc V?ron --- Created attachment 38456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38456&action=edit [Signed-off] Bug 12747 - Add extra column in Z3950 search This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested both patches together, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:20:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:20:22 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38456|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:23:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:23:06 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #22 from Marc V?ron --- Created attachment 38457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38457&action=edit Bug 13606: DBRev 3.19.00.029 Signed-off-by: Tomas Cohen Arazi Tested both patches together, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:24:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:24:23 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38457|0 |1 is obsolete| | --- Comment #23 from Marc V?ron --- Comment on attachment 38457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38457 Bug 13606: DBRev 3.19.00.029 Sorry, mistaked again... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:29:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:29:53 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #24 from Marc V?ron --- Created attachment 38458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38458&action=edit [Signed-off] Bug 12747 - Add extra column in Z3950 search This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch; 1) Create a new basket or use an existing one; 2) In -Add order to basket-, click "From an external source"; 3) Select some search targets and enter a subject heading ex. house; 4) Click Search bouton; 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with both patches together, followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:30:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:30:18 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:30:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:30:20 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38399|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 38459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38459&action=edit Bug 14036: "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail When accessing the subscription detail page for a serial with unknown "Planned date" and/or "Published date" the following error occurs: subscription-detail.pl: Date::Calc::PP::Add_Delta_YM(): Date::Calc::Add_Delta_YM(): not a valid date at /usr/share/koha/lib/C4/Serials.pm line 2607 at /usr/share/perl/5.14/CGI/Carp.pm line 379 CGI::Carp::realdie('[Tue Apr 21 14:43:06 2015] subscription-detail.pl: Date::Calc...') called at /usr/share/perl/5.14/CGI/Carp.pm line 475 CGI::Carp::die('Date::Calc::PP::Add_Delta_YM(): Date::Calc::Add_Delta_YM(): n...') called at /usr/share/perl5/Carp/Clan.pm line 225 Carp::Clan::__ANON__('Date::Calc::Add_Delta_YM(): not a valid date') called at /usr/share/perl5/Date/Calc/PP.pm line 408 Date::Calc::PP::DATECALC_DATE_ERROR('Add_Delta_YM') called at /usr/share/perl5/Date/Calc/PP.pm line 817 Date::Calc::PP::Add_Delta_YM(0000, 00, 00, 0, 1) called at /usr/share/koha/lib/C4/Serials.pm line 2607 C4::Serials::GetNextDate('HASH(0x6244de0)', '0000-00-00') called at /usr/share/koha/lib/C4/Serials.pm line 2382 C4::Serials::abouttoexpire(525) called at /usr/share/koha/intranet/cgi-bin/serials/subscription-detail.pl line 104 This patch adds validation to prevent the error from occurring. Test plan Before applying the patch 1 - In the intranet interface pick a serial biblio record with a subscription with empty "Planned date" and/or "Published date"; 2 - Click the "Subscription(s)" tab on the left side; 3 - Click the subscription title link to view it's detail; The error should occur at this point. Apply the patch, follow the 3 steps from the test plan and the error shouldn't show up anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:31:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:31:31 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38440|0 |1 is obsolete| | --- Comment #25 from Marc V?ron --- Created attachment 38460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38460&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with both patches, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:32:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:32:46 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:33:52 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Marc V?ron --- Note: I forgot to add [Signed-off] to title of 2nd patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:43:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:43:35 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #8 from M. Tompsett --- Created attachment 38461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38461&action=edit Bug 14036 - GetNextDate.t lacking test cases. Two test cases were added to improve testing. This catches the problem encountered by Rolando Isidoro. TEST PLAN --------- 1) Apply this test patch first. 2) prove t/db_dependent/Serials/GetNextDate.t -- this should bomb horribly. 3) Apply the other patch. 4) prove t/db_dependent/Serials/GetNextDate.t -- this should succeed. 5) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:45:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:45:13 +0000 Subject: [Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 --- Comment #2 from Marc V?ron --- Created attachment 38462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38462&action=edit [Signed-off] Bug 11464: Prevent wrong "nothing to save" message on saving syspref Sometime you get the "Nothing to save" message when clicking on the "save all preferences" button, even if something has changed. On irritating behavior is the middle click: if you use the middle click to paste some text in the input, the "keyup" event won't be trigger. This patch replaces the "keyup" event with the "change", which works as we want here. The issues: 1/ Search for "wanted" (admin/preferences.pl?op=search&searchfield=wanted) Empty the input, click save Type something and remove it You are able to save, but nothing has changed 2/ Put something in your selection buffer and use the middle click to paste it in the input. No change detected. Test plan: Confirm the issues are fixed and you don't find any regression Note that now the "(modified)" string is displayed when the input loses the focus. Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:45:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:45:36 +0000 Subject: [Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #38426|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:46:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:46:16 +0000 Subject: [Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:48:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:48:47 +0000 Subject: [Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38207|0 |1 is obsolete| | --- Comment #3 from Eivin Giske Skaaren --- Created attachment 38463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38463&action=edit Bug 14006: about.pl checks the wrong zebra index mode When setting zebra_bib_index_mode to grs1 I get two warnings when not applying the patch: "The entry is set to grs1. GRS-1 support is now deprecated and will be removed in future releases. Please use DOM instead by setting to dom (full reindex required)." "You have set but the is not set to dom. Falling back to legacy facet calculation." When applying the patch a third warning appears in addition to the two previous ones: "The entry is set to dom, but your system still appears to be set up for grs1 indexing." Seems like the patch does what it should to me regarding the configuration mismatch warning. Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:49:34 +0000 Subject: [Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |eskaaren at yahoo.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:50:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:50:42 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:50:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:50:45 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38461|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 38464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38464&action=edit Bug 14036 - GetNextDate.t lacking test cases. Two test cases were added to improve testing. This catches the problem encountered by Rolando Isidoro. TEST PLAN --------- 1) Apply this test patch first. 2) prove t/db_dependent/Serials/GetNextDate.t -- this should bomb horribly. 3) Apply the other patch. 4) prove t/db_dependent/Serials/GetNextDate.t -- this should succeed. 5) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:51:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:51:12 +0000 Subject: [Koha-bugs] [Bug 13491] make Selfcheck follow the CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13491 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:51:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:51:17 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38464|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 38465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38465&action=edit Bug 14036 - GetNextDate.t lacking test cases. Two test cases were added to improve testing. This catches the problem encountered by Rolando Isidoro. TEST PLAN --------- 1) Apply this test patch first. 2) prove t/db_dependent/Serials/GetNextDate.t -- this should bomb horribly. 3) Apply the other patch. 4) prove t/db_dependent/Serials/GetNextDate.t -- this should succeed. 5) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:51:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:51:23 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38459|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 38466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38466&action=edit Bug 14036: "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail When accessing the subscription detail page for a serial with unknown "Planned date" and/or "Published date" the following error occurs: subscription-detail.pl: Date::Calc::PP::Add_Delta_YM(): Date::Calc::Add_Delta_YM(): not a valid date at /usr/share/koha/lib/C4/Serials.pm line 2607 at /usr/share/perl/5.14/CGI/Carp.pm line 379 CGI::Carp::realdie('[Tue Apr 21 14:43:06 2015] subscription-detail.pl: Date::Calc...') called at /usr/share/perl/5.14/CGI/Carp.pm line 475 CGI::Carp::die('Date::Calc::PP::Add_Delta_YM(): Date::Calc::Add_Delta_YM(): n...') called at /usr/share/perl5/Carp/Clan.pm line 225 Carp::Clan::__ANON__('Date::Calc::Add_Delta_YM(): not a valid date') called at /usr/share/perl5/Date/Calc/PP.pm line 408 Date::Calc::PP::DATECALC_DATE_ERROR('Add_Delta_YM') called at /usr/share/perl5/Date/Calc/PP.pm line 817 Date::Calc::PP::Add_Delta_YM(0000, 00, 00, 0, 1) called at /usr/share/koha/lib/C4/Serials.pm line 2607 C4::Serials::GetNextDate('HASH(0x6244de0)', '0000-00-00') called at /usr/share/koha/lib/C4/Serials.pm line 2382 C4::Serials::abouttoexpire(525) called at /usr/share/koha/intranet/cgi-bin/serials/subscription-detail.pl line 104 This patch adds validation to prevent the error from occurring. Follow the test plan in the subsequent patch. This patch deals solely with this. > C4::Serials::GetNextDate('HASH(0x6244de0)', '0000-00-00') called at /usr/share/koha/lib/C4/Serials.pm line 2382 abouttoexpire issues exist, but may be resolved by applying bug 13109 first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:53:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:53:07 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38465|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 38467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38467&action=edit Bug 14036 - GetNextDate.t lacking test cases. Two test cases were added to improve testing. This catches the problem encountered by Rolando Isidoro. TEST PLAN --------- 1) Apply this test patch first. 2) prove t/db_dependent/Serials/GetNextDate.t -- this should bomb horribly. 3) Apply the other patch. 4) prove t/db_dependent/Serials/GetNextDate.t -- this should succeed. 5) koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:53:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:53:15 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38466|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 38468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38468&action=edit Bug 14036: "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail When accessing the subscription detail page for a serial with unknown "Planned date" and/or "Published date" the following error occurs: subscription-detail.pl: Date::Calc::PP::Add_Delta_YM(): Date::Calc::Add_Delta_YM(): not a valid date at /usr/share/koha/lib/C4/Serials.pm line 2607 at /usr/share/perl/5.14/CGI/Carp.pm line 379 CGI::Carp::realdie('[Tue Apr 21 14:43:06 2015] subscription-detail.pl: Date::Calc...') called at /usr/share/perl/5.14/CGI/Carp.pm line 475 CGI::Carp::die('Date::Calc::PP::Add_Delta_YM(): Date::Calc::Add_Delta_YM(): n...') called at /usr/share/perl5/Carp/Clan.pm line 225 Carp::Clan::__ANON__('Date::Calc::Add_Delta_YM(): not a valid date') called at /usr/share/perl5/Date/Calc/PP.pm line 408 Date::Calc::PP::DATECALC_DATE_ERROR('Add_Delta_YM') called at /usr/share/perl5/Date/Calc/PP.pm line 817 Date::Calc::PP::Add_Delta_YM(0000, 00, 00, 0, 1) called at /usr/share/koha/lib/C4/Serials.pm line 2607 C4::Serials::GetNextDate('HASH(0x6244de0)', '0000-00-00') called at /usr/share/koha/lib/C4/Serials.pm line 2382 C4::Serials::abouttoexpire(525) called at /usr/share/koha/intranet/cgi-bin/serials/subscription-detail.pl line 104 This patch adds validation to prevent the error from occurring. Follow the test plan in the subsequent patch. This patch deals solely with this. > C4::Serials::GetNextDate('HASH(0x6244de0)', '0000-00-00') called at /usr/share/koha/lib/C4/Serials.pm line 2382 abouttoexpire issues exist, but may be resolved by applying bug 13109 first. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:53:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:53:37 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:54:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:54:21 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #14 from M. Tompsett --- Leaving as 'Needs Signoff' since I shouldn't be signing off on my own tests. Feel free to sign off, Rolando. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:56:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:56:07 +0000 Subject: [Koha-bugs] [Bug 12551] Special due date not cleared after item added through fast cataloging is checked out. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12551 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 21:57:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 19:57:40 +0000 Subject: [Koha-bugs] [Bug 13402] Can't tab to barcode field when adding item to serial In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13402 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 22:04:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 20:04:19 +0000 Subject: [Koha-bugs] [Bug 13765] Only serial issue can be deleted causing error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13765 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- Do bug 13109 or bug 14036 help solve this, Joy? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 22:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 20:15:55 +0000 Subject: [Koha-bugs] [Bug 11281] printing holds awaiting pickup prints both tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:10:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:10:05 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 --- Comment #2 from Marc V?ron --- Created attachment 38469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38469&action=edit Bug 13910 - Prevent delete of one's own patron account This patch adds a check to prevent deleting the user's own account. Additionali it fixes a "missing link" in moremember.pl and wrong comparisions in moremember.tt regarding other forbidden deleting. To test: - Apply patch - Create a user with sufficient privileges to delete users - Log in as this new user - Try to delete this user. Confirm message box "Are you sure..." - Confirm that you get a message "Not allowed to delete own account" and that the user still exists. Bonus test: Try to trigger other forbidden deletions (see members/deletemem.pl): 'CANT_DELETE_STAFF', 'CANT_DELETE_OTHERLIBRARY', 'CANT_DELETE' (You can fake it by using an URL like: /cgi-bin/koha/members/moremember.pl?borrowernumber=115&error=CANT_DELETE_STAFF etc.) Without patch, no message appears. With patch, messages appear as appropriate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:11:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:11:35 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff CC| |veron at veron.ch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:19:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:19:33 +0000 Subject: [Koha-bugs] [Bug 10910] You can delete a patron who has made suggestions without any warn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13910 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:19:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:19:33 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10910 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:23:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:23:28 +0000 Subject: [Koha-bugs] [Bug 10909] You can delete a patron who has created virtualsheves without any warn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10909 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13910 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:23:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:23:28 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10909 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:38:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:38:12 +0000 Subject: [Koha-bugs] [Bug 10232] Permission check for editing help files is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:40:21 +0000 Subject: [Koha-bugs] [Bug 6422] help files for the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6422 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10232 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:40:21 +0000 Subject: [Koha-bugs] [Bug 10232] Permission check for editing help files is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6422 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:42:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:42:07 +0000 Subject: [Koha-bugs] [Bug 11115] Pull help files from the manual In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11115 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10232 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 23 23:42:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 21:42:07 +0000 Subject: [Koha-bugs] [Bug 10232] Permission check for editing help files is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11115 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 00:46:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 22:46:20 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #22 from Robin Sheat --- (In reply to Julian Maurice from comment #20) > Ok, so just for pointing it out, required version of > DBIx::Class::Schema::Loader (0.07039) is not in wheezy (0.07025-1), and not > in debian.koha-community.org neither. That's not needed to run or build Koha. Only the release people need that. Also, IIRC it wasn't feasible to build it without upsetting half the rest of the system. > How did you try to package it ? The proper way for upstreaming it. See here: https://lists.debian.org/debian-perl/2015/04/msg00009.html This is the proper way to build a package, as it bases it on the older existing version and hard work has generally been done for you. > I only used dh-make-perl and debuild to build packages (and dpkg to install > them). That won't result in a package acceptable to Debian. (In reply to Olli-Antti Kivilahti from comment #21) > I tested this few weeks ago and I had no issues running them? > Just installed from cpan. That's fine for testing, just not acceptable for distribution. > We definetely should use the latest Mojolicious and Swagger2 implementations. > No compromise here. No, that's wrong. We can't expect everyone to have it available, and we can't always build it for them. I'm still hopeful we can in this case, but unless that becomes possible, then we have problems. > Very strange that the latest Mojolicious would be unavailable via packages. I am a little surprised by that too, to be honest. I would have at least expected it to be in git, unless it's because everyone else is being bitten by this tar bug too. When I get the chance, I'm going to try to downgrade tar to at least allow things to build. Of course, if someone wants to patch tar for me, that'd be great :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 01:32:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 23:32:25 +0000 Subject: [Koha-bugs] [Bug 14054] New: 246 XSLT Improvements Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054 Bug ID: 14054 Summary: 246 XSLT Improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 13386 246 2nd indicator specifies type of other title, would be nice to display that when 1st indicator 1. Probaby it would go into brackets like relator terms and would be overridden by subfield i -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 01:32:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 23:32:25 +0000 Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14054 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 01:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 23:33:04 +0000 Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14054 | --- Comment #14 from Nicole C. Engard --- Done- I think - please add to/edit it if need be: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 01:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 Apr 2015 23:33:04 +0000 Subject: [Koha-bugs] [Bug 14054] 246 XSLT Improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13386 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 04:39:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 02:39:02 +0000 Subject: [Koha-bugs] [Bug 14055] New: Bug 13979 breaks package upgrades Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14055 Bug ID: 14055 Summary: Bug 13979 breaks package upgrades Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Even though the yui symlink is removed in the build, it doesn't go away on a package upgrade, so the upgrade breaks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 04:40:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 02:40:08 +0000 Subject: [Koha-bugs] [Bug 14055] Bug 13979 breaks package upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14055 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | CC| |chris at bigballofwax.co.nz, | |tomascohen at gmail.com Priority|P5 - low |P1 - high Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 05:17:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 03:17:42 +0000 Subject: [Koha-bugs] [Bug 14056] New: Small punctuation error in description for deleting a holiday Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Bug ID: 14056 Summary: Small punctuation error in description for deleting a holiday Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org When deleting a holiday in the calendar, the description for 'Delete the exceptions within a range" reads --> "This will delete the exceptions inside a given range. Be careful about your scope range if it is oversized you could slow down Koha." Small punctuation error here - should have a hyphen ie ".. Be careful about your scope range - if it is oversized you could slow down Koha." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 05:29:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 03:29:06 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 05:29:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 03:29:09 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 --- Comment #1 from Aleisha Amohia --- Created attachment 38470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38470&action=edit Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a hyphen into the description so that it makes sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a hyphen and reads ".. Be careful about your scope range - if it is oversized you could slow down Koha." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 05:34:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 03:34:05 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aleishaamohia at hotmail.com --- Comment #2 from Aleisha Amohia --- Patch seems to work cleanly, signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 05:53:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 03:53:47 +0000 Subject: [Koha-bugs] [Bug 14055] Bug 13979 breaks package upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14055 --- Comment #1 from Robin Sheat --- Created attachment 38471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38471&action=edit Bug 14055: remove symlink that breaks upgrades Old versions of koha-common would put in a symlink to the system YUI libraries. This causes upgrade problems, so we look out for that and zap it if it's there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 05:54:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 03:54:56 +0000 Subject: [Koha-bugs] [Bug 14055] Bug 13979 breaks package upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14055 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13979 Status|ASSIGNED |Needs Signoff --- Comment #2 from Robin Sheat --- This can and should be applied to all releases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 05:54:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 03:54:56 +0000 Subject: [Koha-bugs] [Bug 13979] Packages uninstallable on Debian Jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13979 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14055 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 06:37:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 04:37:23 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aleishaamohia at hotmail.com --- Comment #7 from Aleisha Amohia --- Patch applies cleanly, signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 06:39:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 04:39:40 +0000 Subject: [Koha-bugs] [Bug 14057] New: Inventory is painfully slow Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Bug ID: 14057 Summary: Inventory is painfully slow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org While attempting to run an inventory, I attempted to run an inventory on a single barcode with no filters. It gave me a gateway timeout error. My goal is to speed it up. The major source of the problem is in C4::Item, where it attempts to replace the authorized value (e.g. 0) with a description (e.g. Lost -- these are hypothetical examples, so don't expect 0=Lost somewhere). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 06:43:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 04:43:04 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 --- Comment #1 from M. Tompsett --- Created attachment 38472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38472&action=edit Bug 14057 - A Rough Start This patch is a rough start. I believe it runs exponentially faster, but its equality to the previous version needs to be tested before I clean it up to acceptable standards. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 08:02:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 06:02:28 +0000 Subject: [Koha-bugs] [Bug 14058] New: not working some deb file sites on web installation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14058 Bug ID: 14058 Summary: not working some deb file sites on web installation Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: girakaduwa at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 08:18:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 06:18:13 +0000 Subject: [Koha-bugs] [Bug 14055] Bug 13979 breaks package upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14055 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |girakaduwa at gmail.com --- Comment #3 from Magnus Enger --- *** Bug 14058 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 08:18:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 06:18:13 +0000 Subject: [Koha-bugs] [Bug 14058] not working some deb file sites on web installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14058 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger --- *** This bug has been marked as a duplicate of bug 14055 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 08:18:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 06:18:48 +0000 Subject: [Koha-bugs] [Bug 14058] not working some deb file sites on web installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14058 --- Comment #2 from Magnus Enger --- Perhaps a duplicate of bug 14055? See if the 3.18.6.1 packages fixes things. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 08:39:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 06:39:17 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- It is really faster. With 30 items I got for the loop Without patch: 0.0321040153503418 With patch: 0.00271320343017578 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 09:21:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 07:21:05 +0000 Subject: [Koha-bugs] [Bug 14058] not working some deb file sites on web installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14058 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 09:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 07:27:02 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38435|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 38473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38473&action=edit Bug 13492: Add the column configuration for the checkouts table - morember.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (moremember.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). Amended patch: replace 'un' and 'deux' with 'sort_order' and 'todays_or_previous_checkouts' in the yml file. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 09:27:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 07:27:07 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38436|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 38474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38474&action=edit Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin). Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 09:55:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 07:55:32 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #23 from Julian Maurice --- (In reply to Robin Sheat from comment #22) > (In reply to Julian Maurice from comment #20) > > I only used dh-make-perl and debuild to build packages (and dpkg to install > > them). > > That won't result in a package acceptable to Debian. But it will be acceptable to debian.koha-community.org, won't it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 10:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 08:06:13 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 10:06:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 08:06:17 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #8 from Jonathan Druart --- Created attachment 38475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38475&action=edit Bug 11880: Select what has been selected before The previous patch wants to select the barcode option when the user is on the item search for label, in all cases. So even if 'title' is selected, a search done, and there is no result, the barcode index is selected anyway. In this case, the title option should be kept. Test plan: Confirm that the barcode option is the default choice, but other values are kept is the search does not return any result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 10:08:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 08:08:44 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #9 from Jonathan Druart --- (In reply to Charles Farmer from comment #6) > Despite the ugliness of the template in its present form, the patch works > and is a development needed by our client. > > This patch should be accepted as is. Fixing the template is considerably out > of the scope of this development. It's not because it's needed by your client that the patch should be accepted as you have written it... It's your duty to sent clean patches and make the code better, not worst. The patch you have sent does not make any sense and adds misunderstanding to the template. Anyway, here a patch to clean the situation, it took me 5 minutes to write, much more less than argue for hours... Back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 10:32:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 08:32:29 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38066|0 |1 is obsolete| | Attachment #38072|0 |1 is obsolete| | Attachment #38076|0 |1 is obsolete| | Attachment #38438|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 38476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38476&action=edit Bug 13022 - Hardcoded limit causes records with more than 20 items to show inaccurate statuses If a record has more than 20 items, all the items over 20 will show as available on the search results even if they are not! This is a hard coded limit in the Search module. This number should be configurable. Test Plan: 1) Create a record with more than 20 items 2) Set all the items to waiting holds or in transit 3) Search for results that will include that item 4) Note some say they are available even though they are not 5) Apply this patch 6) Run updatedatabase.pl 7) Set the new system preference MaxSearchResultsItemsPerRecordStatusCheck to a number larger than the number of items on your record 8) Re-run the search 9) Note that the hold and transit statuses for the items are now correct Signed-off-by: Andreas Hedstr?m Mace Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 10:32:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 08:32:45 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 --- Comment #17 from Jonathan Druart --- Created attachment 38477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38477&action=edit Bug 13022 [QA Followup] - Allow the pref to be unset for unlimited item status checks Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 10:32:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 08:32:51 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 --- Comment #18 from Jonathan Druart --- Created attachment 38478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38478&action=edit Bug 13022 [QA Followup] - Highlight the results with inaccurate status, add explanation when mouse hovers over. Bug 13022 [QA Followup] - Revert changes in whitespace back to original for items count lines Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 10:34:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 08:34:42 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Jonathan Druart --- I have tried with another record and it works now. I have squashed the last 2 patches for more readability. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 10:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 08:37:27 +0000 Subject: [Koha-bugs] [Bug 11220] Patron edit process doesn't remember restriction selections In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11220 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 11:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 09:04:01 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Where is it displayed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 11:17:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 09:17:31 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 --- Comment #2 from Katrin Fischer --- It displays only for irregular subscriptions on the serial collection page on the tab with the next issue (that has no date in that case). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 11:19:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 09:19:28 +0000 Subject: [Koha-bugs] [Bug 11524] Strange URL parameters in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11524 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 11:19:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 09:19:31 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 --- Comment #10 from Marc V?ron --- Created attachment 38479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38479&action=edit [Signed-off] Bug 11880: Select what has been selected before The previous patch wants to select the barcode option when the user is on the item search for label, in all cases. So even if 'title' is selected, a search done, and there is no result, the barcode index is selected anyway. In this case, the title option should be kept. Test plan: Confirm that the barcode option is the default choice, but other values are kept if the search does not return any result. Followed test plan, behaves as expected. Tested with all choices. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 11:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 09:19:50 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 11:20:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 09:20:07 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 11:20:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 09:20:54 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13323 CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- I will try to provide a patch when bug 13323 will be pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 11:20:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 09:20:54 +0000 Subject: [Koha-bugs] [Bug 13323] Change the tax rate on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11514 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 11:41:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 09:41:54 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #9 from Gaetan Boisson --- This also seems to work properly with perl 5.18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 11:43:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 09:43:01 +0000 Subject: [Koha-bugs] [Bug 11498] can bypass sco timeout with print dialog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11498 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 12:14:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 10:14:52 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 Rolando Isidoro changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13109 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 12:14:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 10:14:52 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Rolando Isidoro changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14036 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 12:16:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 10:16:45 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 Rolando Isidoro changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Rolando Isidoro --- Signed off and added bug 13109 dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 12:19:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 10:19:13 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 12:19:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 10:19:16 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #3 from Jonathan Druart --- Created attachment 38480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38480&action=edit Bug 11890: Click events on titles does not work as expected The browse results feature (bug 10404) modified the click events on titles on the search result page (intranet). It introduced bad behaviors: 1/ ctrl+click on a title does not open a new tab 2/ middle click on a title does open a new tab but the browser is not displayed. Note that this patch is not perfect, it fixes the 2 bad behaviors but the ctrl+click gives the focus to the new tab (could go against the preferences of the users). Test plan: 1/ On the staff interface, launch a search (catalogue/search.pl?q=XXX) 2/ When middle-clicking on a title, a new tab should open. On this tab the browse result feature should be displayed 3/ Same for cltr+click -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 12:19:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 10:19:38 +0000 Subject: [Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11890 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 12:19:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 10:19:38 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m CC| |jonathan.druart at biblibre.co | |m Depends on| |10404 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 12:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 10:50:36 +0000 Subject: [Koha-bugs] [Bug 12034] MSG_REMOVE_FROM_LIST different wording between OPAC and staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12034 --- Comment #7 from Jonathan Druart --- *** Bug 11901 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 12:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 10:50:36 +0000 Subject: [Koha-bugs] [Bug 11901] Change old reference to "shelf" to "list" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11901 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- This has been done on bug 12034. I have found 1 left: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt index 00cb335..96adbd3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt @@ -1,5 +1,5 @@ -[% INCLUDE 'doc-head-open.inc' %] -Koha › Download shelf +% INCLUDE 'doc-head-open.inc' %] +Koha › Download list But I don't manage to see it displayed. *** This bug has been marked as a duplicate of bug 12034 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 12:52:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 10:52:35 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 --- Comment #3 from M. Tompsett --- (In reply to Marc V?ron from comment #2) > It is really faster. > With 30 items I got for the loop > Without patch: 0.0321040153503418 > With patch: 0.00271320343017578 Thanks for the numeric confirmation. Did you notice any difference in output? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 13:02:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 11:02:25 +0000 Subject: [Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #1 from Olli-Antti Kivilahti --- Hi! We experimented by disabling the hold catching when checking in Items with the SIP Server. This was because our borrowers would get the Reservation notice and come looking for the Item while the Item was still being processed. Then we started to get issues with Items (that had reservations) being in Available-state between getting checked in with the SIP server and waiting for the librarian to check them in using Koha. We reverted back to the way things are, because we get less issues this way. Our librarians know where to look for the reserved Item if on the rare occasion a borrower is fast enough to intercept the hold before we place it to the self pickup shelf. However if the limbo-available-state between check-in can be fixed, (this might be more trouble than it's worth) I guess this would make sense. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 13:08:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 11:08:42 +0000 Subject: [Koha-bugs] [Bug 11600] log viewer forgets your choice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11600 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 6911 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 13:08:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 11:08:42 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #12 from Jonathan Druart --- *** Bug 11600 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 14:55:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 12:55:43 +0000 Subject: [Koha-bugs] [Bug 14059] New: Fully testing C4::Creators::Lib Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 Bug ID: 14059 Summary: Fully testing C4::Creators::Lib Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Test Suite Assignee: julian.fiol at biblibre.com Reporter: julian.fiol at biblibre.com QA Contact: gmcharlt at gmail.com Testing C4::Creators::Lib at 100% Deleting get_column_names subroutine (never used) TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Creators/Lib.t -- All 644 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Check with bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 11,6% Branch : 0,0% Condition : N/A Subroutine : 36,0% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 14:57:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 12:57:48 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 14:57:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 12:57:52 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 --- Comment #1 from Julian FIOL --- Created attachment 38481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38481&action=edit Bug 14059 : Testing C4::Creators::Lib Testing C4::Creators::Lib at 100% Deleting get_column_names subroutine (never used) TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/Creators/Lib.t -- All 644 tests should run successfully without any error or warning TEST PLAN OPTIONAL ------------------ Check with bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 11,6% Branch : 0,0% Condition : N/A Subroutine : 36,0% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition : N/A Subroutine : 100,0% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 14:59:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 12:59:59 +0000 Subject: [Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 15:05:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 13:05:23 +0000 Subject: [Koha-bugs] [Bug 13492] Add location to the checkouts tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patches pushed to master. Good job Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 15:06:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 13:06:00 +0000 Subject: [Koha-bugs] [Bug 13941] Add ids to tag in staff client where missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #36 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 15:06:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 13:06:44 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. Well done Bernardo! First patchset to use the new atomicupdate schema! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 15:13:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 13:13:48 +0000 Subject: [Koha-bugs] [Bug 13992] Software error in reports if field or table does not exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 15:30:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 13:30:22 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 lesley.speed at cheshireeast.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lesley.speed at cheshireeast.g | |ov.uk --- Comment #2 from lesley.speed at cheshireeast.gov.uk --- Is anyone doing any work on this as it is something we would really like fixing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 15:36:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 13:36:21 +0000 Subject: [Koha-bugs] [Bug 14060] New: Remove readonly on date inputs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Bug ID: 14060 Summary: Remove readonly on date inputs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Currently some inputs use datepicker (or datetimepicker) with a readonly attributes. That can cause accessibility issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 15:36:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 13:36:30 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10995 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 15:36:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 13:36:30 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14060 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 15:40:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 13:40:02 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38472|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 38482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38482&action=edit Bug 14057 - A Rough Start This patch is a rough start. I believe it runs exponentially faster, but its equality to the previous version needs to be tested before I clean it up to acceptable standards. nested hashes of hashes hard to debug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 15:42:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 13:42:38 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38482|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 38483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38483&action=edit Bug 14057 - A Rough Start This patch is a rough start. I believe it runs exponentially faster, but its equality to the previous version needs to be tested before I clean it up to acceptable standards. Nested hashes of hashes was being a debugging nightmare. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:00:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:00:05 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:00:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:00:08 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #1 from Jonathan Druart --- Created attachment 38484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38484&action=edit Bug 14060: Remove readonly attributes on date inputs In order to remove accessibility issues due to the readonly attributes on date inputs, this patch will remove them and introduce a javascript validation on them. This patch is not perfect for some reason: I didn't manage to force the user to select a valid date. One solution would be to reopen the datepicker plugin until a valid date is inserted. But it could be annoying for users (and for me: I did not manage to implement this solution). You will note that input is emptied if the date is not valid. This is a quick and efficient solution to prevent submitting invalid date and make Koha explodes. A proper solution would be to implement the check server side send a friendly message to the user. Test plan: For all inputs, try an invalid and a valid date. 1/ Debar a patron 2/ On the checkout tables (circulation and moremember), add a renewal due date (at the bottom of the tables) 3/ On the checkout page, specify a due date 4/ On the return page, specify a return date 5/ On the invoice page (acquisition module), enter a shipment and billing date 6/ On the invoice search page (invoices.pl) use filters shipment and billing dates 7/ On the offline circ page, specify a due date 8/ On the edit patron page (memberentry), add a debarment 9/ On the reserve page (reserve/request.pl), use the date inputs to suspend until a defined date 10/ Edit patrons in a batch (tools/modborrowers.pl) and use the registration and expiry date inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:02:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:02:14 +0000 Subject: [Koha-bugs] [Bug 14061] New: Inventory fails to map withdrawn authorized values Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Bug ID: 14061 Summary: Inventory fails to map withdrawn authorized values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org if ($f and $sf) fails if: $f is NULL,'', or 0 and similarly with $sf. 952$0 = withdrawn status. This should be (defined $f and defined $sf). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:02:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:02:28 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:05:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:05:25 +0000 Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of renewal date and specific due date in circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #20 from Jonathan Druart --- See bug 14060 for a global solution of this problem. *** This bug has been marked as a duplicate of bug 14060 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:05:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:05:25 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Jonathan Druart --- *** Bug 10995 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:13:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:13:37 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:13:39 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #1 from M. Tompsett --- Created attachment 38485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38485&action=edit Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Run inventory on a filtered set such that the selected barcode is not withdrawn. -- the Withdrawn column displays '0'. 2) Apply patch 3) Rerun -- the Withdrawn column displays '' (as expected) 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:18:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:18:44 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12909 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:18:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:18:44 +0000 Subject: [Koha-bugs] [Bug 12909] item withdrawn is missing in inventory results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12909 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14061 CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:18:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:18:53 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard --- Created attachment 38486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38486&action=edit statuses say 0 It's not just withdrawn that shows 0 by the way ... it's all status columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:20:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:20:24 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Nicole C. Engard --- Also, after applying the patch I still see 0 ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:21:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:21:28 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #4 from Nicole C. Engard --- Created attachment 38487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38487&action=edit after patch I still see 0 after patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:26:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:26:54 +0000 Subject: [Koha-bugs] [Bug 2262] delete guarantor button does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2262 Carmen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carmen at bywatersolutions.com Status|CLOSED |REOPENED Resolution|FIXED |--- --- Comment #1 from Carmen --- It appears that this issue has reappeared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:27:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:27:05 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #5 from M. Tompsett --- Please post a screen shot of your authorized values for WITHDRAWN. If there is no mapping for WITHDRAWN=0, then it will still show 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:31:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:31:57 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #6 from Nicole C. Engard --- Created attachment 38488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38488&action=edit authorized values on first test I didn't have a zero -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:32:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:32:17 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #7 from Nicole C. Engard --- Created attachment 38489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38489&action=edit authorized values on second test I added a 0 with no description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:40:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:40:56 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #8 from Nicole C. Engard --- Created attachment 38490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38490&action=edit withdrawn cataloging with the 0 value I get a 0 in my withdrawn pull down when cataloging now ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:41:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:41:53 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #9 from Nicole C. Engard --- Created attachment 38491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38491&action=edit limit to withdrawn with patch With the patch when I limit to withdrawn I get a 1 instead of the word 'withdrawn' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:44:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:44:36 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 --- Comment #2 from Kyle M Hall --- Created attachment 38492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38492&action=edit Bug 13024 - Nonpublic note not appearing in the staff client The nonpublic note for items is not displayed in the staff client. It should be displayed in the following areas: 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) Test Plan: 1) Ensure your non-public note field is mapped to the items.itemnotes_nonpublic database column 2) Edit an item, add a test nonpublic note 3) Check out the item, verify the note is visible in the checkouts table 4) Check in the item, verify the note is visible in the checkins table 5) View the item details, verify the note is visible and editable if your account has the rights to edit items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:44:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:44:34 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:44:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:44:58 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38485|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 38493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38493&action=edit Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Check what values to have entered for WITHDRAWN authorized values (Home -> Koha Administration -> Authorized values change dropdown to WITHDRAWN) 2) Add a new authorized value of 0 () if one is missing. 3) Add a new authorized value of 1 (Withdrawn) if one is missing. 4) Run inventory on a filtered set such that the selected barcode is not withdrawn. (Home -> Tools -> Inventory/stocktaking) -- the Withdrawn column displays '0'. 5) Run inventory on a filtered set such that the selected barcode is withdrawn. -- the Withdrawn column displays '1'. 6) Apply patch 7) Rerun steps 4 & 5 -- the Withdrawn column displays the descriptions as seen in steps 1-3. 8) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:48:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:48:02 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- It could be quite easy to fix. Nicole, How do you get these errors? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 16:52:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 14:52:06 +0000 Subject: [Koha-bugs] [Bug 11902] When finished receiving, redirect to the vendor. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11902 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Kyle, what do you mean by 'finish one invoice'? On acqui/parcel.pl?invoiceid=XX there is a "finish receiving" button, it you click on it, you are redirected to the invoice details, which makes sense to me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 17:06:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 15:06:37 +0000 Subject: [Koha-bugs] [Bug 11790] C4::Charset should not depend on C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 17:06:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 15:06:39 +0000 Subject: [Koha-bugs] [Bug 11790] C4::Charset should not depend on C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11790 --- Comment #1 from Jonathan Druart --- Created attachment 38494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38494&action=edit Bug 11790: Remove dependency C4::Context from C4::Charset C4::Context is only used to retrieve a syspref value. This patch moves the use of C4::Context to a require. Test plan: Try to reach the SetMarcUnicodeFlag subroutine (batchmod, add/update a biblio, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 17:07:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 15:07:18 +0000 Subject: [Koha-bugs] [Bug 11790] C4::Charset should not depend on C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- This is a quick patch and does not provide a complete fix for this issue. Feel free to provide another one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 17:10:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 15:10:04 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #11 from M. Tompsett --- I'm doing a fresh base install to see if I can replicate your failures, because I can't on my current system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 17:30:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 15:30:50 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 --- Comment #3 from David Roberts --- Created attachment 38495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38495&action=edit Add patron salutation to checkout screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 17:31:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 15:31:52 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 17:33:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 15:33:21 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from David Roberts --- Sorry, my mistake - I was tracking the wrong version! A new patch has now been submitted so hopefully it will work this time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 18:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 16:34:07 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37773|0 |1 is obsolete| | Attachment #38305|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 38496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38496&action=edit Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 18:34:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 16:34:04 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 18:34:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 16:34:13 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #8 from Kyle M Hall --- Created attachment 38497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38497&action=edit Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 20:19:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 18:19:10 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 --- Comment #5 from Marc V?ron --- Created attachment 38498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38498&action=edit [Signed-off] Add patron salutation to checkout screen To test: Install this patch. Ensure a user has a salutation (Mr, Dr, Miss etc) set, and checkout an item to this user. In the area above the barcode box, the patron's title should display, e.g: Checking out to Mr John Doe (0001). --- Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 20:19:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 18:19:29 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38495|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 20:19:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 18:19:47 +0000 Subject: [Koha-bugs] [Bug 14039] Add patron title to checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 21:36:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 19:36:05 +0000 Subject: [Koha-bugs] [Bug 14062] New: Payment note on reversed payment Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14062 Bug ID: 14062 Summary: Payment note on reversed payment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 38499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38499&action=edit note payment reversed Hi, When I wrote a note of a reversed payment, the note is not taken. It's the same when a wrote an other note of a reversed payment, the new note is not taken. See vid?o attached. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 21:36:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 19:36:50 +0000 Subject: [Koha-bugs] [Bug 14062] Payment note on reversed payment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14062 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:06:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:06:09 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #225 from Nick Clemens --- Okay, new patches clear the previous error, but seeing two: With OPACPrivacy set to allow and AllowPatronToSetCheckoutsVisibilityForGuarantor set to allow I cannot see a place to set the visibility anywhere. With OPACPrivacy set to Don't Allow and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow I get the option under 'Personal details' however, I cannot actually change the value or see the guarantor's name. Good news is that the AllowStaffToSetCheckoutsVisibilityForGuarantor pref seems to work as expected. Patron aaccounts are visible/not as expected with different combinations of settings, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:19:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:19:08 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 --- Comment #13 from Nick Clemens --- That (In reply to Winona Salesky from comment #12) > Does a '|' make sense for both multiple $a in one field and repeated 33x > fields? That seems a little awkward to me. What about commas between $a and > '|' between repeated fields? Any thoughts? > Seems like a good compromise to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:28:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:28:27 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 --- Comment #6 from Marc V?ron --- Created attachment 38500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38500&action=edit [TESTPATCH] Bug 14057 - A Rough Start - Compare old and new code This patch gets values using both methods to compare the results. For testing purposes only. To test: Apply patch Compare results by commenting /uncommenting appropriate lines after line 1154 in C4/Items.pm If found one difference: Old code could not handle Withdrawn status (displays 1 instead of the text) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:42:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:42:30 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:42:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:42:33 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38299|0 |1 is obsolete| | --- Comment #42 from Nick Clemens --- Created attachment 38501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38501&action=edit [SIGNED OFF] Bug 13382 - RDA: 700/710/711 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span class=separator |. Adds Related and Contained Works as new headings. 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:43:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:43:37 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 --- Comment #7 from M. Tompsett --- (In reply to Marc V?ron from comment #6) > If found one difference: Old code could not handle Withdrawn status > (displays 1 instead of the text) 952$0 means $sf=0, but is defined. See bug 14061. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:43:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:43:47 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14061 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:43:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:43:47 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14057 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:55:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:55:51 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:55:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:55:54 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38480|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 38502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38502&action=edit [SIGNED OFF] Bug 11890: Click events on titles does not work as expected The browse results feature (bug 10404) modified the click events on titles on the search result page (intranet). It introduced bad behaviors: 1/ ctrl+click on a title does not open a new tab 2/ middle click on a title does open a new tab but the browser is not displayed. Note that this patch is not perfect, it fixes the 2 bad behaviors but the ctrl+click gives the focus to the new tab (could go against the preferences of the users). Test plan: 1/ On the staff interface, launch a search (catalogue/search.pl?q=XXX) 2/ When middle-clicking on a title, a new tab should open. On this tab the browse result feature should be displayed 3/ Same for cltr+click Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 22:56:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 20:56:54 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #5 from Nick Clemens --- > Note that this patch is not perfect, it fixes the 2 bad behaviors but > the ctrl+click gives the focus to the new tab (could go against the > preferences of the users). This is a huge improvement so signing off, would it seem ungrateful to file the above as a new bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 23:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 21:02:41 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 --- Comment #3 from Nicole C. Engard --- You know what - Owen asks a good question ... I have no idea how I got that error - I must have been documenting something, but now I can't make the error happen ... any chance that error is in the code? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 23:11:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 21:11:40 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 --- Comment #3 from Marc V?ron --- Created attachment 38503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38503&action=edit [Signed-off] Bug 13024 - Nonpublic note not appearing in the staff client The nonpublic note for items is not displayed in the staff client. It should be displayed in the following areas: 1) Checkouts (circulation.pl) 2) Checkins (returns.pl) 3) Record details ( moredetail.pl ) Test Plan: 1) Ensure your non-public note field is mapped to the items.itemnotes_nonpublic database column 2) Edit an item, add a test nonpublic note 3) Check out the item, verify the note is visible in the checkouts table 4) Check in the item, verify the note is visible in the checkins table 5) View the item details, verify the note is visible and editable if your account has the rights to edit items Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 23:12:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 21:12:02 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #38492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 23:12:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 21:12:42 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 24 23:23:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 21:23:18 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Nick Clemens --- Applying: Bug 13387 - Uniform titles (130 / 240 / 730) Display in XSLT fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13387 - Uniform titles (130 / 240 / 730) Display in XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 01:11:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 23:11:37 +0000 Subject: [Koha-bugs] [Bug 14055] Bug 13979 breaks package upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14055 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 01:11:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 23:11:44 +0000 Subject: [Koha-bugs] [Bug 14055] Bug 13979 breaks package upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14055 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38471|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 38504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38504&action=edit [PASSED QA] Bug 14055: remove symlink that breaks upgrades Old versions of koha-common would put in a symlink to the system YUI libraries. This causes upgrade problems, so we look out for that and zap it if it's there. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 01:12:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 23:12:01 +0000 Subject: [Koha-bugs] [Bug 14055] Bug 13979 breaks package upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14055 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 01:17:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 23:17:33 +0000 Subject: [Koha-bugs] [Bug 14055] Bug 13979 breaks package upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14055 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 01:18:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 23:18:08 +0000 Subject: [Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 01:18:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 Apr 2015 23:18:44 +0000 Subject: [Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 05:52:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 03:52:53 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from M. Tompsett --- Painfully, I redid a fresh install on Ubuntu 14.04 LTS a full git install from scratch. I ran it without the patch Withdrawn = 0 in the table (as is all the fields beside Withdrawn). I then ran it with the patch. Everything was still 0. I then checked my authorised values, and there was no 0, so I added it 'Not Withdrawn'. Re-ran, and 'Not Withdrawn' is displayed now. I figured I'd check it out. Then re-run, I got a nice yellow warning telling me it checked it back in. So, I re-ran it again, and got 'Not Withdrawn'. Nicole, I think your settings are a-typical or something. I'm going to put this back to 'Needs Signoff' and perhaps someone else with be able to duplicate the issue with the... test plan in comment #10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 10:58:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 08:58:31 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 --- Comment #13 from Marc V?ron --- Created attachment 38505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38505&action=edit [Signed-off] Bug 14061: Fix broken mapping for not withdrawn items. TEST PLAN --------- 1) Check what values to have entered for WITHDRAWN authorized values (Home -> Koha Administration -> Authorized values change dropdown to WITHDRAWN) 2) Add a new authorized value of 0 () if one is missing. 3) Add a new authorized value of 1 (Withdrawn) if one is missing. 4) Run inventory on a filtered set such that the selected barcode is not withdrawn. (Home -> Tools -> Inventory/stocktaking) -- the Withdrawn column displays '0'. 5) Run inventory on a filtered set such that the selected barcode is withdrawn. -- the Withdrawn column displays '1'. 6) Apply patch 7) Rerun steps 4 & 5 -- the Withdrawn column displays the descriptions as seen in steps 1-3. 8) run koha qa test tools Followed test plan #1-#7. Aut. value for 0 set to: 'No' amd 1: "withdrawn'. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 10:58:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 08:58:55 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #38493|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 10:59:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 08:59:53 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 11:00:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 09:00:21 +0000 Subject: [Koha-bugs] [Bug 14061] Inventory fails to map withdrawn authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14061 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 11:49:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 09:49:21 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 --- Comment #8 from Marc V?ron --- Created attachment 38506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38506&action=edit Bug 14057 - A Rough Start - Compare old and new code This patch gets values using both methods to compare the results. For testing purposes only. To test: Apply patch Compare results by commenting /uncommenting appropriate lines after line 1154 in C4/Items.pm If found one difference: Old code could not handle Withdrawn status (displays 1 instead of the text) ------ Amended: I changed the test code to reflect the old behaviour fixed with patch from Bug 14061 It writes a warning if the old and the new value are not the same. I still got differences with the Withdrawn status and found out, that it took the auth value for OPAC. This is due to a part of the select statement in the first patch (Line 1122) that overrules the value for the staff client: IF(TB.lib_opac>'',TB.lib_opac,TB.lib) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 11:50:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 09:50:02 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38500|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 11:51:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 09:51:24 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38506|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Comment on attachment 38506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38506 Bug 14057 - A Rough Start - Compare old and new code Sorry, attached wrong patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 11:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 09:53:16 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 --- Comment #10 from Marc V?ron --- Created attachment 38507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38507&action=edit Bug 14057 - A Rough Start - Compare old and new code This patch gets values using both methods to compare the results. For testing purposes only. To test: Apply patch Compare results by commenting /uncommenting appropriate lines after line 1154 in C4/Items.pm If found one difference: Old code could not handle Withdrawn status (displays 1 instead of the text) ------ Amended: I changed the test code to reflect the old behaviour fixed with patch from Bug 14061 It writes a warning if the old and the new value are not the same. I still got differences with the Withdrawn status and found out, that it took the auth value for OPAC. This is due to a part of the select statement in the first patch (Line 1122) that overrules the value for the staff client: IF(TB.lib_opac>'',TB.lib_opac,TB.lib) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 12:01:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 10:01:12 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 --- Comment #11 from Marc V?ron --- Update: The reason was not in the select statment, but in line 1128; $row->{OPAC} should be: $row->{Intranet} I replaced it in my test code, result: New version provides the same results as old version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 14:37:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 12:37:10 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 38508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38508&action=edit Bug 13423: Remove unused serials-recieve This patch removes two files, serials-recieve.pl and serial-recieve.tt serials-recieve.pl is not called anyware (it's recieve!) Also removes the sub removeMissingIssue called only from serials-recieve.pl git grep serials-recieve.pl . C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl file koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:
    koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: serials/serials-recieve.pl:serials-recieve.pl Just a POD entry and self reference. After removing of files git grep removeMissingIssue . C4/Serials.pm: &check_routing &updateClaim &removeMissingIssue C4/Serials.pm:=head2 removeMissingIssue C4/Serials.pm:removeMissingIssue($subscriptionid) C4/Serials.pm:sub removeMissingIssue { t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test removing a missing issue'); Not used anymore To test: 1) Apply the patch 2) Check serials workflow, no changes must be noted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 14:38:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 12:38:31 +0000 Subject: [Koha-bugs] [Bug 13423] Untranslatable strings in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Bernardo Gonzalez Kriegel --- (In reply to Kyle M Hall from comment #10) > The only non-obsoleted patch no long makes the strings in serials-recieve.tt > translatable. It's also dead code. Followup removes the file. Second patch needs sign. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 15:18:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 13:18:31 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36479|0 |1 is obsolete| | --- Comment #65 from Bernardo Gonzalez Kriegel --- Created attachment 38509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38509&action=edit Bug 10963: Simplified creation - FA framework Patch 1/9 This patch modifies Fast Add framework Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 15:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 13:26:56 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #66 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #64) > Bernardo, > This does not longer apply. > What is the plan here? I am under the impression we should not lag too much, > it will be a pain to maintain this patch set if master moves! > Do you generate manually or using a script? > What is your confidence level in this patch set? Hi, only needed to replace the first patch, a single line difference on FA fw. The plan is simplify current sample fw sql files, no problem with that because they are not updated since long time. What I check with a script are default frameworks (bib or auth) With this patches we generate sample fw copying from default, so no need to update them, but only works at install time. This need a followup to use the same procedure on each language, will do that later. Reverted to Signed-Off status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 15:39:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 13:39:07 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Karam Qubsi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karamqubsi at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 16:05:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 14:05:39 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel at gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel --- As Jonathan said, run koha-qa FAIL misc/devel/coverage.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 8) OK pod OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 16:47:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 14:47:41 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #71 from M. Tompsett --- Comment on attachment 36030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36030 Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Review of attachment 36030: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=36030) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +2401,5 @@ > + my @branches = GetIndependentGroupModificationRights(); > + $query .= > + " AND ( borrowers.branchcode = ? OR borrowers.branchcode IN ( " > + . join( ',', ('?') x @branches ) . " ) ) "; > + push( @query_params, @branches ); This is the only function which checks borrowers.branchcode. Is this correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 16:51:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 14:51:48 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #72 from M. Tompsett --- Since this is taking time to get signed off, perhaps convert the updatedatabase.pl to an atomicupdate, so this will need less tweaks when applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 17:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 15:43:14 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #8 from M. Tompsett --- Comment on attachment 37713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37713 Bug 9067: Hide item related strings when importing staged authority records Review of attachment 37713: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9067&attachment=37713) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt @@ +378,5 @@ > + [% IF ( record_type == 'biblio' ) %] > +
    > + > + > + [ % END %] Tiny spacing issue. Fixing and signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 17:46:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 15:46:56 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 17:46:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 15:46:59 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #9 from M. Tompsett --- Created attachment 38510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38510&action=edit Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 17:47:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 15:47:40 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37713|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 38511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38511&action=edit Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 17:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 15:47:46 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38510|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 38512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38512&action=edit Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 18:03:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 16:03:39 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38123|0 |1 is obsolete| | --- Comment #26 from M. Tompsett --- Created attachment 38513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38513&action=edit Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. NOTE: Mark Tompsett removed sign off, since he completely reworked it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 18:03:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 16:03:46 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38124|0 |1 is obsolete| | --- Comment #27 from M. Tompsett --- Created attachment 38514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38514&action=edit Bug 9254: redirect to 404 if at least 1 pref is off And set the default value of EnhancedMessagingPreferencesOPAC = EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 18:06:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 16:06:01 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38122|0 |1 is obsolete| | --- Comment #28 from M. Tompsett --- Created attachment 38515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38515&action=edit Bug 9254: Problem with EnhancedMessagingPreferences First I don't know the right component to this bug. The problem is the following: - when enabling EnhancedMessagingPreferences, the staff client if able to set the messaging preferences for the patrons categories, and then for the patron (normally the messaging preferences are the same for everyone) - when enabling EnhancedMessagingPreferences, the patrons can set in the OPAC their messaging preferences, which can be against the library rules Solution: - enabling EnhancedMessagingPreferences, should allow the the staff client to set the patrons messaging preferences - enabling EnhancedMessagingPreferences, should't allow patrons to set their messaging preferences (the link doesn't appear in the usermenu.inc) - should be another preference to allow the patrons to set their messaging preferences. Test plan: - apply the patch - enable EnhancedMessagingPreferences, the messaging page should appear in OPAC - disable OPACEnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC - disable EnhancedMessagingPreferences, the messaging page shouldn't appear in OPAC Sponsored-by: KEEP SOLUTIONS NOTE: Re-worked by Mark Tompsett, that's why I removed sign-offs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 18:06:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 16:06:08 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38513|0 |1 is obsolete| | --- Comment #29 from M. Tompsett --- Created attachment 38516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38516&action=edit Bug 9254: Followup - Rename pref to EnhancedMessagingPreferencesOPAC If the new pref is named EnhancedMessagingPreferencesOPAC, it will show up adjacent to EnhancedMessagingPreferences Comment: Works as described. But the patch only hides the link, not disable the feature. If you refresh OPAC after unset EnhancedMessagingPreferencesOPAC, you can still change your messaging preferences. NOTE: Mark Tompsett removed sign off, since he completely reworked it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 18:06:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 16:06:14 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38514|0 |1 is obsolete| | --- Comment #30 from M. Tompsett --- Created attachment 38517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38517&action=edit Bug 9254: redirect to 404 if at least 1 pref is off And set the default value of EnhancedMessagingPreferencesOPAC = EnhancedMessagingPreferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 25 18:14:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 Apr 2015 16:14:15 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #31 from M. Tompsett --- Leaving in discussion as per comments #17, #18, and #19. Which I raised in comment #24. Even though Marc V. suggested that 'In Discussion' was not required in his opinion in comment #25. These other attachments in between were because he pointed out a typo I believe I may have made in rescuing the patch. Apply the latest and follow any test plans given in comments #28, #29, and #30. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 02:11:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 00:11:53 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 02:11:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 00:11:56 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 --- Comment #10 from M. Tompsett --- Created attachment 38518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38518&action=edit Bug 6815: Capture picture from web cam This enhancement gives the librarian the ability to capture a photo from a webcam attached to the Koha server. It does this by adding a 'Capture' button to the member details page. This button is only visible if there is likely a webcam. This is determined by if /dev/video{something} exists. This also corrects the functionality of the delete button, which is broken, because borrowernumber and cardnumber got mixed up. This requires the package streamer be installed: $ sudo apt-get install streamer Additionally, I had to add www-data to the video group. $ sudo addgroup www-data video TEST PLAN --------- 1) Back up DB. 2) Have a picture file available for uploading. 3) Find a particular patron 4) Upload the picture file on hand. -- should work fine. 5) Delete the patron picture. -- fails. 6) Apply patch. 7) Delete the patron picture. -- success 8) Upload the patron picture again. -- success 9) Check for Capture button. a) plug in it and refresh page -- capture button should be there. b) unplug it and refresh page -- capture button should not be there. c) plug it back in and refresh 10) Make a strange face, hold it, and click 'Capture' -- a few seconds later the page should refresh with your face. 11) Restore DB 12) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 02:38:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 00:38:19 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 --- Comment #11 from M. Tompsett --- Though we probably want something more client-side like: http://jsfiddle.net/attuts/svcf41o6/2/ -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 07:03:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 05:03:14 +0000 Subject: [Koha-bugs] [Bug 14063] New: Implement language overlay for authorised values Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Bug ID: 14063 Summary: Implement language overlay for authorised values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr There is an urgent need to make authorised values translatable in mulitlingual installations. For the examples I take English (en), French (FR-fr and German (de-DE). Example: OPAC (Public interface) - Set syspref 'suggestion' to: [Allow] patrons to make purchase suggestions on the OPAC. - Select English - OPAC: Log in, go to Purchase suggestions > Create a new suggesion - The dropdown "Reason for suggestion:" shows the authorised values from OPAC_SUG, e.g. "The copy on the shelf is damaged" and "Upcoming title by popular author" - Select German - The dropdown "Begr?ndung" shows the same (English) values. Intranet (Staff client) - Go to Home > Acquisitions > Suggestions management > New purchase suggestion - Switch between languages, the dropdown "Reason for suggestion" changes the label, but the values are not ranslated. - Same with the detail view of a suggestion There are more places with similar problems. The only (poor and ugly looking) possibility is to have multilingual text in the same entry, e.g. "Damaged | Besch?digt | Ab?m?" "Upcoming title by popular author | Neuer Titel eines popul?ren Autors |Oeuvre ...." - oh, that gets very long for one line in a drop down... I propose a solution that implements a language overlay for authorised values. It is minimal invasive and can immediately be used in production. Patch follows. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 07:05:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 05:05:18 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #78 from Karam Qubsi --- Hi Jessie, I tried to apply the patch on master , but it wasn't applied , I have the following error : Auto-merging svc/bib CONFLICT (content): Merge conflict in svc/bib Failed to merge in the changes. Patch failed at 0001 Bug 11559 - Supporting changes for Rancor is there any order that I have to follow to apply the patches ? thank you for your great efforts . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 07:38:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 05:38:12 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 --- Comment #1 from Marc V?ron --- Created attachment 38519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38519&action=edit Bug 14063 - Implement language overlay for authorised values This patch implements a language overlay for authorised values. To prepare tests - Have an installation with e.g. English, French and German languages - Set syspref 'suggestion' to: [Allow] patrons to make purchase suggestions on the OPAC. - Verify that you have a authorised values for OPAC_SUG (bestseller, damaged) - Open OPAC, log in, go to Purchase suggestions > Create a new suggesion - The dropdown "Reason for suggestion:" shows the authorised values from OPAC_SUG, e.g. "The copy on the shelf is damaged" and "Upcoming title by popular author" - Select German - The dropdown "Begr?ndung" shows the same (English) values. - Same with French - Open Intranet (Staff client) - Go to Home > Acquisitions > Suggestions management > New purchase suggestion - Switch between languages, the dropdown "Reason for suggestion" changes the label, but the values are not ranslated. - Same with the detail view of a suggestion To test: - In Staff client, go to Home > Administration > Authorized values - Add a new category OPAC_SUG-de-DE (add language code) - Create new translated values 'bestseller' and 'damaged' for this category. - Do the same for French (OPAC_SUG-fr-FR) or other installed languages - Go to OPAC > Purchase suggestions > Create a new suggesion - Switch between languages, the values in the dropdown 'Reason' should display in selected language - Got to Staff client > Home > Acquisitions > Suggestions management > New purchase suggestion - Switch between languages and verify that the values in the dropdown 'Reason' display in selected language - Display a suggestion's detail view, switch languages. Text for 'Reason' should change as appropriate. Bonus test: - Create language overlays e.g. for category 'DAMAGED' (DAMAGED-de-DE and DAMAGED-fr-FR), authorised values 0 -> 'No' and 1 -> 'Damaged' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 07:40:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 05:40:57 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Priority|P5 - low |P3 Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 07:50:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 05:50:23 +0000 Subject: [Koha-bugs] [Bug 14064] New: Implement language overlay for item types Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14064 Bug ID: 14064 Summary: Implement language overlay for item types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Implementation of language overlays for item types similar to Bug 14063. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 08:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 06:18:26 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14064, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7789, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13952, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14057, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10363 --- Comment #2 from Marc V?ron --- Related to this bug: Bug 14064 Implement language overlay for item types Bug 7789 (2012-03-22): shows Mockups for a more sophisticated administration interface for language overlays. Bug 13952 - Import and export of authority types would be helpful to manage language overlays as well (export existing - edit to add language overlays - import) Bug 14057 - Inventory is painfully slow would need a $query_mapping that is aware of language overlays (maybe to be moved to a sub in C4:Koha.pm / could be re-used at other places) Bug 10363 - There is no package for authorised values I tested this patch on top of Bug 10363, no problems detected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 08:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 06:18:26 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14063 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 08:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 06:18:26 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 08:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 06:18:26 +0000 Subject: [Koha-bugs] [Bug 14064] Implement language overlay for item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14064 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14063 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 08:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 06:18:26 +0000 Subject: [Koha-bugs] [Bug 7789] Add translations of item type and authorized value descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7789 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 08:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 06:18:26 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 08:34:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 06:34:22 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Severity|enhancement |trivial --- Comment #2 from M. Tompsett --- I'm not part of the grammar police, but it seems to me that hyphen is not the most natural and plain way of expressing this. Though, I definitely agree there needs a tweak somehow. Perhaps: Be careful about your scope range; if it is oversized, you could slow down Koha. instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 09:08:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 07:08:58 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14060 --- Comment #30 from Marc V?ron --- Added Bug 14060 as related because of function validate_date in intranet-tmpl/prog/en/includes/calendar.inc (will need adjustments for new date format dd.mm.yyyy). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 09:08:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 07:08:58 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12072 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 09:51:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 07:51:37 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Maybe the current date format could be displayed in the alert message? Something like: alert(MSG_PLEASE_ENTER_A_VALID_DATE '('+ dateformat + ')'); --- I found following place without validation: Go to Detail of a patron with hold(s) Select Tab Hold Date field near "Suspend all holds until" allows wrong date format, e.g. "12345678" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 15:01:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 13:01:19 +0000 Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eskaaren at yahoo.no --- Comment #2 from Eivin Giske Skaaren --- I am still very new to Koha so please excuse (and explain) if I am thinking wrong here: The query that gets fired when testing this bug looks like this: (SELECT case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end line, reserves.branchcode col, COUNT(*) calculation FROM reserves LEFT JOIN borrowers USING (borrowernumber) WHERE reservedate >= '2015-04-15' AND reservedate <= '2015-04-30' AND (( case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end = '3' ) OR ( case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end = '1' ) OR ( case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end = '4' ) OR ( case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end = '2' ) OR ( case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end = '5' ) ) GROUP BY line, col ) UNION (SELECT case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end line, old_reserves.branchcode col, COUNT(*) calculation FROM old_reserves LEFT JOIN borrowers USING (borrowernumber) WHERE reservedate >= '2015-04-15' AND reservedate <= '2015-04-30' AND (( case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end = '3' ) OR ( case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end = '1' ) OR ( case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end = '4' ) OR ( case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end = '2' ) OR ( case when priority>0 then 1 when priority=0 then (case when found='f' then 4 when found='w' then (case when cancellationdate is null then 3 else 5 end ) else 2 end ) else 6 end = '5' ) ) GROUP BY line, col ) ORDER BY line, col So one way of getting line numbers that are not unique for the same col is if priority is set to >0 for an item in the old_reserves table. Question: Should priority ever be anything else than 0 for an item in the old_reserves table? The patch still gets the same SQL result and then tries to solve the problem by using the value of line as hash key and adds the values of calculation from any rows with the same line value. But this results in the wrong values being added given my example with priority for an item in the old_reserves table being set to >0. The query will as in Jonathan's example create rows with line value 1 for both the reserves table and the old_reserves table, so the line value should not be used as the hash key since it will then add values from the different tables to the calculation field. Perhaps this is better solved by getting the SQL correct for the use case, perhaps by adding a field to the result set that is unique? Also by looking at the reservestatus I suspect that something else is wrong here since line=1 corresponds to 1-placed which should be wrong for anything in the old_reserves table. This patch then does not solve the problem if the things that I have assumed are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 16:47:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 14:47:38 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 20:34:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 18:34:39 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 21:48:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 19:48:07 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 --- Comment #4 from Marc V?ron --- Created attachment 38520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38520&action=edit Bug 11929 - patron modification error shows borrowernumber If an error occurs in patron batch modification, a message similar to the following is displayed: Can not update patron with borrowernumber 7055 It would be useful to have the cardnumber as well. This patch adds the card number to the lists of errors. It is not easy to trigger an error (see comments). For testing, I tweaked the sub ModMember in C4/Members.pm to always return false. To test: Apply patch Go to Home > Tools > Batch patron modification Enter some card numbers, continue to modify. Try to find a modification that triggers an error in ModMember (C4/Members.pm) If an error is triggered, verify that the card number is displayed in the error message(s). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 21:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 19:50:22 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 22:21:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 20:21:18 +0000 Subject: [Koha-bugs] [Bug 5515] Leading 'and' in search never returns a result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5515 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 26 22:25:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 20:25:11 +0000 Subject: [Koha-bugs] [Bug 5515] Leading 'and' in search never returns a result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5515 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master --- Comment #5 from Marc V?ron --- I had similar problems with current master. And the band played -> No results the band played ->results Beauty and the beast -> results and the beast -> no results Beauty and -> no results -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 01:28:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 23:28:44 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 01:30:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 23:30:28 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 01:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 Apr 2015 23:33:13 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 03:35:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 01:35:30 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mtompset at hotmail.com Assignee|gmcharlt at gmail.com |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- It has been annoying me too, Isabela. However, this is not a problem to really worry about if: $ dpkg -l libreadonly-xs-perl displays a version higher than 1.02, which you (and I) both have. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 03:36:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 01:36:22 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 03:36:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 01:36:25 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #2 from M. Tompsett --- Created attachment 38521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38521&action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 03:37:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 01:37:08 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 04:37:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 02:37:26 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 05:20:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 03:20:18 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 --- Comment #12 from M. Tompsett --- (In reply to Marc V?ron from comment #11) > Update: The reason was not in the select statment, but in line 1128; > > $row->{OPAC} should be: $row->{Intranet} > > I replaced it in my test code, result: New version provides the same results > as old version. The problem is the context is unknown for the second function, so opac is always used with staff client fall-back. If I recall correctly. Not looking at code right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 06:16:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 04:16:19 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30579|0 |1 is obsolete| | --- Comment #28 from M. Tompsett --- Created attachment 38522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38522&action=edit Bug 11904: New module Koha::Messages This patch provides a uniform way to send messages to user interface. It uses CGI::Session to store messages and allow to render them thanks to a Template::Toolkit plugin (Koha::Template::Plugin::Messages) and a template include file (messages.inc) This patch doesn't introduce the new template include file anywhere. It will require additional patches to make it work. To use it, simply call messages_set() in a Perl script or module, then put [% INCLUDE 'messages.inc' %] at the right place in the right template file. See POD documentation of Koha::Messages for more information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 06:16:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 04:16:25 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30580|0 |1 is obsolete| | --- Comment #29 from M. Tompsett --- Created attachment 38523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38523&action=edit Bug 11904: Unit tests for Koha::Messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 06:16:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 04:16:30 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30581|0 |1 is obsolete| | --- Comment #30 from M. Tompsett --- Created attachment 38524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38524&action=edit Bug 11904: Example usage of new module Koha::Messages Test plan: 1/ Go to members/moremember.pl 2/ Click on "More" -> "Renew patron" and confirm 3/ A message should appear "Patron's account has been renewed until ..." 4/ In a shell, go to misc/translator and run ./translate create fr-FR (or ./translate update fr-FR) ./translate install fr-FR (you can use your own language of course) 5/ Edit po/fr-FR-messages.po and translate the string "Patron's account has been renewed until ..." 6/ In staff interface change language to French and renew patron once again. 7/ The translated message should appear. Needs patches from bugs 8044 and 11848 for string translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 06:18:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 04:18:10 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #31 from M. Tompsett --- Hopefully this rebase is correct. One less "Patch does not apply". YAY! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 07:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 05:29:05 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- dpkg -l libreadonly-xs-perl Gew?nscht=Unbekannt/Installieren/R=Entfernen/P=Vollst?ndig L?schen/Halten | Status=Nicht/Installiert/Config/U=Entpackt/halb konFiguriert/ Halb installiert/Trigger erWartet/Trigger anh?ngig |/ Fehler?=(kein)/R=Neuinstallation notwendig (Status, Fehler: GROSS=schlecht) ||/ Name Version Architektur Beschreibung +++-==================================-======================-======================-========================================================================= ii libreadonly-xs-perl 1.04-2+b3 amd64 Faster Readonly implementation Staff client > About Koha without patch: Koha : About without patch: Readonly::XS (1.02) 1.04 Staff client > About Koha with patch: Readonly::XS (1.02) Not Installed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 07:30:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 05:30:40 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38483|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 38525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38525&action=edit Bug 14057 - A Rough Start This patch is a rough start. I believe it runs exponentially faster, but its equality to the previous version needs to be tested before I clean it up to acceptable standards. Nested hashes of hashes was being a debugging nightmare. Moved the SQL select to C4::Koha. Changed the GetItemsForInventory to have a hashref parameter. Added interface, in case there is a need for 'opac' vs. 'staff'. Untested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 07:52:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 05:52:16 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38521|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 38526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38526&action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 08:34:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 06:34:36 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #12 from Marc V?ron --- Sorry, could not test patch (no access to webcam with my server / vm) Tested code on jsfiddle.net with a client - works. I would prefer a client side solution. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 08:43:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 06:43:34 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38526|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 38527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38527&action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 08:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 06:46:33 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38507|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Comment on attachment 38507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38507 Bug 14057 - A Rough Start - Compare old and new code Obsoleting my temporary patch with test code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 08:55:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 06:55:44 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #6 from Marc V?ron --- Results with new patch: dpkg -l libreadonly-xs-perl Result: ii libreadonly-xs-perl 1.04-2+b3 amd64 Faster Readonly implementation Staff client > About Koha without patch Readonly::XS (1.02) 1.04 Staff client > About Koha with patch Readonly::XS (1.02) 1.04 The result is now the same with and without patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:05:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:05:10 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #7 from Marc V?ron --- To test what happens if libreadonly-xs-perl is not installed, I did: apt-get remove libreadonly-xs-perl On the about page, I get now: Readonly::XS (1.02) | [nothing in column for version number] I would expect: Readonly::XS (1.02) | Not installed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:15:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:15:59 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #8 from M. Tompsett --- Still looking for a nicer way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:29:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:29:35 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:32:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:32:51 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38527|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 38528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38528&action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:33:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:33:49 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:33:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:33:51 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 --- Comment #10 from Julian FIOL --- Created attachment 38529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38529&action=edit Bug 13899 : Changing license to GPLv3 koha-qa should be good : OK misc/devel/coverage.pl OK critic OK forbidden patterns OK pod OK valid OK C4/Installer/PerlDependencies.pm OK critic OK forbidden patterns OK pod OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:34:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:34:42 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:36:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:36:25 +0000 Subject: [Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38529|0 |1 is obsolete| | --- Comment #11 from Julian FIOL --- Created attachment 38530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38530&action=edit Bug 13899 : Changing license to GPLv3 koha-qa should be good : OK misc/devel/coverage.pl OK critic OK forbidden patterns OK pod OK valid OK C4/Installer/PerlDependencies.pm OK critic OK forbidden patterns OK pod OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:36:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:36:56 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38528|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 38531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38531&action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools All systems running Koha will have perldoc installed. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:51:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:51:52 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:53:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:53:28 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #11 from Marc V?ron --- Created attachment 38532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38532&action=edit [Signed-off] Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools All systems running Koha will have perldoc installed. :) ---- Tested with an without Readonly::XS 1.04 installed. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:53:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:53:54 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 09:55:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 07:55:04 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #6 from Jonathan Druart --- (In reply to Nick Clemens from comment #5) > > Note that this patch is not perfect, it fixes the 2 bad behaviors but > > the ctrl+click gives the focus to the new tab (could go against the > > preferences of the users). > > This is a huge improvement so signing off, would it seem ungrateful to file > the above as a new bug? Not at all, feel free to do it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:04:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:04:33 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36243|0 |1 is obsolete| | Attachment #36244|0 |1 is obsolete| | Attachment #36245|0 |1 is obsolete| | Attachment #36246|0 |1 is obsolete| | Attachment #36247|0 |1 is obsolete| | Attachment #36248|0 |1 is obsolete| | Attachment #36455|0 |1 is obsolete| | --- Comment #79 from Jonathan Druart --- Created attachment 38533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38533&action=edit Bug 11559 - Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Extends humanmsg to allow per-message classes * Adds proper charset to results of svc/bib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:04:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:04:41 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #80 from Jonathan Druart --- Created attachment 38534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38534&action=edit Bug 11559 - New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * pz2 - library for connecting to pazpar2 * require - dependency resolver and module loader -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:04:48 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #81 from Jonathan Druart --- Created attachment 38535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38535&action=edit Bug 11559 - Rancor: professional cataloging interface Test plan: 1. Apply patches for bug 10486 and this bug. 2. Reinstall patches for pazpar2. 3. Switch back and forth between basic and advanced editor, and verify that preference is saved (by workstation, not user. 4. Enter in a record (with all required fields). 5. Save to ISO2709, MARCXML and catalog, verify that all three match. 6. Import a MARCXML and ISO2709 record, and verify that the record is correct after import. 7. Run keyword and advanced searches with a variety of Z39.50 servers to check that searching is correct, and try to both import records as new records and substitute them for the contents of existing records. 8. Create, edit and delete macros, verifying that they are autosaved. 9. Try running macros (example follows). 10. Try enabling and disabling fixed-field widgets and customizing fonts, and test the editor afterwards. Example macro: goto field 003 copy field data insert new field 040 data= goto subfield end insert new subfield a data= goto subfield a paste -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:04:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:04:54 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #82 from Jonathan Druart --- Created attachment 38536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38536&action=edit Bug 11559 followup - Allow insertion of dollar sign, remove fixFloat The dollar sign now shows up as {dollar} inside subfield contents. This is converted on load and save. Also, remove fixFloat, as it has moved and is no longer needed anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:05:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:05:00 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #83 from Jonathan Druart --- Created attachment 38537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38537&action=edit Bug 11559 followup - Remove Pazpar2 dependency, bugfixes Adds a new metasearch service, removing dependency on Pazpar2. Current limitations: * Can only sort by title. Should be easy to fix. * Requires refetching results when changing pages. Also adds an "edit items" link, and fixes a loading error when logged in as the database user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:05:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:05:07 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #84 from Jonathan Druart --- Created attachment 38538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38538&action=edit Bug 11559 followup - refactoring and cleanup Added license headers to all JS files, moved metasearcher code into a new service that largely lives in Koha::, and massively cleaned up the internals of the textual MARC machinery. Also, fixed some encoding and saving issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:05:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:05:14 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #85 from Jonathan Druart --- Created attachment 38539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38539&action=edit Bug 11559 followup - a number of small UI bugfixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:06:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:06:18 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #86 from Jonathan Druart --- (In reply to Karam Qubsi from comment #78) > Hi Jessie, > I tried to apply the patch on master , but it wasn't applied , > I have the following error : > > > Auto-merging svc/bib > CONFLICT (content): Merge conflict in svc/bib > Failed to merge in the changes. > Patch failed at 0001 Bug 11559 - Supporting changes for Rancor > > is there any order that I have to follow to apply the patches ? > > thank you for your great efforts . Karam, I have fixed the conflict in the first patch, you should be able to apply all of them in the same order as they are on this bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:43:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:43:47 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #4 from Jonathan Druart --- Created attachment 38540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38540&action=edit Bug 14060: Add OnClose event on missing datepicker The "suspend until" inputs (hold list on circ/circulation.pl and members/moremember.pl) were not set in the same way. The minDate option should be set for both (bug 10703 removed it for circ/circulation.pl). This patch reintroduces the option and add the OnClose event on both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:43:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:43:53 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #5 from Jonathan Druart --- Created attachment 38541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38541&action=edit Bug 14060: Display the date format on the warning popup The date format is now displayed on the warning popup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:44:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:44:37 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:47:47 +0000 Subject: [Koha-bugs] [Bug 11448] Accessibility: Make it possible to enter date for restriction without using the datepicker widget In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #5 from Jonathan Druart --- (In reply to Christopher Brannon from comment #4) I suggestion a global solution on bug 14060. Actually I should have submitted it here. *** This bug has been marked as a duplicate of bug 14060 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:47:47 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #6 from Jonathan Druart --- *** Bug 11448 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 10:56:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 08:56:30 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #16 from Jonathan Druart --- (In reply to M. Tompsett from comment #15) > Comment on attachment 37848 [details] [review] > [Signed-off] Bug 10625: Inventory/Stocktaking tool cannot handle windows > file uploads > > Review of attachment 37848 [details] [review]: > ----------------------------------------------------------------- > > ::: tools/inventory.pl > @@ +174,5 @@ > > + $barcode =~ s/\r/\n/g; > > + $barcode =~ s/\n\n/\n/g; > > + $barcode =~ s/\n$//; > > + $barcode =~ s/^\n//; > > + my @data = split(/\n/,$barcode); > > Because then I couldn't split the barcodes. > I agree the logic might be more optimizable, but the idea is that if > $barcode = "foo\nbar"; it needs to split into two barcodes: foo and bar. And > given that some OS's may use \r and \n and \r\n in ways different than how > $barcode=<$uploadbarcodes> works, I wanted to be certain that all middle > combinations get split, and that there are no beginning or end strangeness. Ok sorry, did not read it with the context. So the last 2 replacements are useless :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 11:00:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 09:00:46 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 11:09:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 09:09:03 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #24 from Chris Cormack --- (In reply to Julian Maurice from comment #23) > (In reply to Robin Sheat from comment #22) > > (In reply to Julian Maurice from comment #20) > > > I only used dh-make-perl and debuild to build packages (and dpkg to install > > > them). > > > > That won't result in a package acceptable to Debian. > > But it will be acceptable to debian.koha-community.org, won't it ? No, we build proper packages for debian.koha-community.org and upstream them also. eg https://qa.debian.org/developer.php?login=robin at catalyst.net.nz this gets them into debian proper, and from there into ubuntu. Regardless of the packages, I think this should be split into a bunch of bugs, certainly shifting the documentation one off on to its on thing. I don't think we need to build any front end stuff for this. If we do that should be on it's on bug also. To get something like this in, its much better to do what was done with the acquisitions work, seperate bugs that don't mean the entire thing has to pass at once. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 11:40:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 09:40:18 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #25 from Julian Maurice --- (In reply to Chris Cormack from comment #24) > Regardless of the packages, I think this should be split into a bunch of > bugs, certainly shifting the documentation one off on to its on thing. I > don't think we need to build any front end stuff for this. If we do that > should be on it's on bug also. > To get something like this in, its much better to do what was done with the > acquisitions work, seperate bugs that don't mean the entire thing has to > pass at once. I disagree. The "front end stuff" is the API documentation, and I don't think we can integrate the new API without a proper documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 11:59:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 09:59:22 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 11:59:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 09:59:25 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38343|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 38542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38542&action=edit Bug 14044: Escape json strings for patron searches In a couple of patron searches, the address is displayed. If the address contain invalid json characters, DataTables won't manage to parse the results and display them. This patch makes the templates more readable by creating a BLOCK instead of a long line and escape the invalid json characters calling the TT plugin (To.json). Test plan: Edit a patron and add something like: patron
    \123 ? ? in the address field. Search for this patron using the main patron search (members/member.pl) and the guarantor search. Confirm that a result with this patron is correctly displayed. Regression test: Since Koha::Template::Plugin::To::json is modified, confirm that the add users to basket search (on acqui/basket.pl?basketno=X click on the "Add user" button) still works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 11:59:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 09:59:55 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 12:25:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 10:25:25 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m CC| |jonathan.druart at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 12:48:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 10:48:28 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 12:48:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 10:48:30 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #7 from Jonathan Druart --- Created attachment 38543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38543&action=edit Bug 13810: Change collate for tagsubfield (utf8_bin) Before bug 11944, the marc_subfield_structure.tagsubfield column had a specific collate: utf8_bin. It has been introduced by commit 67e20d82ffdfcd69344ec30696bebc51c00d863c Date: Sun Jun 22 16:35:48 2008 -0500 DB Bump 094 - bug 2268 -- allow mixed case subfield labels in MARC21 by changing db column collation. This change should be kept and Koha should continue to allow and create subfields with the same letter but different case sensitivity. What does this patch: 1/ To prevent the updatedatabase entry 3.19.00.006 to fail if subfields with different case sensitivity already exist in the DB, the table is managed separately from others. 2/ To update DB which have already pass this dbrev, a new entry will be create to update the specific collate for this column. Test plan: 1/ a. With a 3.18 DB, create subfield 'a' and 'A' for the same field b. Execute the updatedatabase.pl script. 3.19.00.006 should not fail anymore 2/ a. With a master DB (3.19.00.006 has already been executed), create subfields 'a' and 'A'. You should get an error. b. Apply this patch, execute the DB entry and try again 2/a. you should be able to create the second subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 12:52:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 10:52:17 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #8 from Jonathan Druart --- Nicolas, If you have a look at a 3.18.x branch, you will see that the marc_subfield_structure.tagsubfield had a specific collate. We should keep utf8_unicode_ci for other tables and columns, so I suggest to set back utf8_bin for this column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 12:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 10:52:48 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #9 from Jonathan Druart --- Please obsolete your patch if you agree with mine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 12:54:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 10:54:10 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|normal |major --- Comment #10 from Jonathan Druart --- This issue could cause failures when upgrading from 3.18 to 3.20, I am raising the priority. It should be fixed before the 3.20 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:05:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:05:58 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 --- Comment #3 from Jonathan Druart --- Created attachment 38544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38544&action=edit Bug 11576: Make "manage" translatable - serials-collection If a subscription is irregular, a tab with "manage" is displayed on the serial collection page. But this string is not translatable. Test plan: 1/ Go on the serial collection page of an irregular subscription (or create one). 2/ Note that the first tab was named "managed", it's now "Manage". 3/ Update a po lang file and confirm you see the string and you are able to translate it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:05:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:05:56 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:06:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:06:30 +0000 Subject: [Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:18:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:18:34 +0000 Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 --- Comment #3 from Jonathan Druart --- (In reply to Eivin Giske Skaaren from comment #2) > I am still very new to Koha so please excuse (and explain) if I am thinking > wrong here: > > The query that gets fired when testing this bug looks like this: [skip] > So one way of getting line numbers that are not unique for the same col is > if priority is set to >0 for an item in the old_reserves table. > > Question: Should priority ever be anything else than 0 for an item in the > old_reserves table? Yes, I think so. At least I have some on local installation. I suppose the priority is not updated when a reserve is canceled. So if it has a priority > 0, it will be copied as it to the old_reserves. > Perhaps this is better solved by getting the SQL correct for the use case, > perhaps by adding a field to the result set that is unique? I assumed that the query was correct. But as you can see, it is ugly and there is certainly a better way to do the same work. > This patch then does not solve the problem if the things that I have assumed > are correct. Did you have the patience to test/compare the results? I didn't :) But the customer validated the patch, so I supposed he tested it. If you are able to give me a simple example to recreate a issue on my side, I will have a look and try to provide a fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:28:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:28:24 +0000 Subject: [Koha-bugs] [Bug 14065] New: Typo in opac self registration form Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Bug ID: 14065 Summary: Typo in opac self registration form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The phrase Please type this following characters into the preceding box should be Please type the following characters into the preceding box -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:28:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:28:52 +0000 Subject: [Koha-bugs] [Bug 14065] Typo in opac self registration form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Patch complexity|--- |String patch Assignee|oleonard at myacpl.org |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:29:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:29:31 +0000 Subject: [Koha-bugs] [Bug 14065] Typo in opac self registration form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:29:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:29:37 +0000 Subject: [Koha-bugs] [Bug 14065] Typo in opac self registration form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 --- Comment #1 from Kyle M Hall --- Created attachment 38545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38545&action=edit Bug 14065 - Typo in opac self registration form The phrase Please type this following characters into the preceding box should be Please type the following characters into the preceding box -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:40:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:40:31 +0000 Subject: [Koha-bugs] [Bug 14066] New: Koha code does not really use Readonly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Bug ID: 14066 Summary: Koha code does not really use Readonly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The Readonly and Readonly::XS package are only used in Koha::Calendar. IMO the added value of there packages does not justify their purpose. I would suggest to remove these packages as Koha deps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:42:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:42:11 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart at biblibre.co | |m --- Comment #12 from Jonathan Druart --- When QAing this patch, I was wondering why we used Readonly and Readonly::XS. And actually I did not find valid reasons. I have opened bug 14066 to remove these packages. If valided, it will invalid this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:44:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:44:12 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:44:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:44:15 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #1 from Jonathan Druart --- Created attachment 38546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38546&action=edit Bug 14066: Remove the Readonly[::XS] dependency The Readonly and Readonly::XS package are only used in Koha::Calendar. IMO the added value of there packages does not justify their purpose. Test plan: 1/ Remove Readonly and Readonly::XS 2/ Open the calendar and confirm you don't get any error concerning missing dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:45:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:45:26 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #2 from Jonathan Druart --- Colin, do you have any concerns about this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:49:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:49:26 +0000 Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 --- Comment #4 from Eivin Giske Skaaren --- (In reply to Jonathan Druart from comment #3) > (In reply to Eivin Giske Skaaren from comment #2) > > > So one way of getting line numbers that are not unique for the same col is > > if priority is set to >0 for an item in the old_reserves table. > > > > Question: Should priority ever be anything else than 0 for an item in the > > old_reserves table? > > Yes, I think so. > At least I have some on local installation. > I suppose the priority is not updated when a reserve is canceled. So if it > has a priority > 0, it will be copied as it to the old_reserves. Since the query evaluates on priority this means that the result will be wrong if the rows from old_reserves are not to be shown as "1- placed" in the holds report. > Did you have the patience to test/compare the results? > I didn't :) Yes I did test it ;) > But the customer validated the patch, so I supposed he tested it. > If you are able to give me a simple example to recreate a issue on my side, > I will have a look and try to provide a fix. This is my test result that you can modify to your installation: I have 2 books in the reserves table with priority 1 I have 3 books in the old_reserves table with priority 0 Run the report and it will say: 1- placed: 2 2- processed : 3 Change the priority to 1 for one of the books in the old_reserves table and rerun the report: 1- placed: 3 2- processed: 2 Perhaps it would be good to refactor out the use of magic numbers so the whole thing gets more maintainable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:50:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:50:39 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:50:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:50:45 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #71 from Kyle M Hall --- Created attachment 38547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38547&action=edit Bug 11431 [QA Followup] - Allow https in sound URLs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 13:53:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 11:53:41 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #72 from Kyle M Hall --- Created attachment 38548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38548&action=edit Bug 11431 [QA Followup] - Fix POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 14:19:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 12:19:52 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 14:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 12:24:40 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #34 from Dobrica Pavlinusic --- I have problem with this patch. When applied to our database it generates following errors: [Mon Apr 27 12:33:40 2015] updatedatabase.pl: DBD::mysql::db do failed: Multiple primary key defined at /srv/koha/installer/data/mysql/updatedatabase.pl line 10166. [Mon Apr 27 12:33:40 2015] updatedatabase.pl: DBD::mysql::db do failed: Unknown column 'issue_id' in 'order clause' at /srv/koha/installer/data/mysql/updatedatabase.pl line 10170. [Mon Apr 27 12:33:40 2015] updatedatabase.pl: DBD::mysql::st execute failed: Unknown column 'me.issue_id' in 'field list' at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1481. DBIx::Class::ResultSetColumn::max(): Unknown column 'me.issue_id' in 'field list' at /srv/koha/installer/data/mysql/updatedatabase.pl line 10174 It seems that ALTER TABLE issues ADD issue_id INT( 11 ) NOT NULL AUTO_INCREMENT PRIMARY KEY FIRST doesn't work because we already have itemnumber defined as primary key. Should we drop it before this alter table? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 14:26:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 12:26:09 +0000 Subject: [Koha-bugs] [Bug 12052] Display a patron message on the summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12052 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12411 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 14:26:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 12:26:09 +0000 Subject: [Koha-bugs] [Bug 12411] Encoding broken in the syspref template plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12052 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:06:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:06:38 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:21:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:21:03 +0000 Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 --- Comment #5 from Jonathan Druart --- (In reply to Eivin Giske Skaaren from comment #4) > Perhaps it would be good to refactor out the use of magic numbers so the > whole thing gets more maintainable. Actually I think that all the script should be rewritten. It looks much more complicated than I expected and at the moment I don't plan to work more on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:23:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:23:41 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 --- Comment #12 from Jonathan Druart --- (In reply to Dobrica Pavlinusic from comment #11) Dobrica, could you please detail how did you get this error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:27:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:27:04 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at biblibre.co | |m | CC| |m.de.rooy at rijksmuseum.nl --- Comment #47 from Jonathan Druart --- I would like to get point of view from another QAer on this one and bug 11747. I don't know to be sure Kyle's patch won't introduce regression on the tools/letter.pl page. Moreover I am still concerned by the addition of 3 prefs to do the same thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:29:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:29:59 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #35 from Tom?s Cohen Arazi --- (In reply to Dobrica Pavlinusic from comment #34) > doesn't work because we already have itemnumber defined as primary key. > Should we drop it before this alter table? Dobrica, you mean you altered the original DB definition? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:47:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:47:13 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36362|0 |1 is obsolete| | --- Comment #209 from Jonathan Druart --- Created attachment 38549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38549&action=edit Bug 10855: Add the new package Koha::AdditionalField Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:47:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:47:20 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36363|0 |1 is obsolete| | --- Comment #210 from Jonathan Druart --- Created attachment 38550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38550&action=edit Bug 10855: Add unit tests for the new package Koha::AdditionalField Test plan: - prove t/db_dependent/AdditionalField.t Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:47:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:47:26 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36364|0 |1 is obsolete| | --- Comment #211 from Jonathan Druart --- Created attachment 38551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38551&action=edit Bug 10855: interface configuration for adding new fields to subscriptions This patch adds an interface configuration for adding fields to subscriptions. Test plan: - go to serials/serials-home.pl - click on the "Add subscription fields" link on the left of the screen - try to add/update/delete new fields You are not abble to add a field with an authorised value category and a marcfield. Columns are sortable - for the rest, you should have, at least: * a new field named af1, sortable, linked to a category * a new field named af2, sortable, linked to a marcfield * a new field named af3, not sortable Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:47:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:47:31 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36365|0 |1 is obsolete| | --- Comment #212 from Jonathan Druart --- Created attachment 38552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38552&action=edit Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the "Additional fields" block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:47:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:47:37 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36366|0 |1 is obsolete| | --- Comment #213 from Jonathan Druart --- Created attachment 38553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38553&action=edit Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:47:42 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36367|0 |1 is obsolete| | --- Comment #214 from Jonathan Druart --- Created attachment 38554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38554&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:47:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:47:48 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36368|0 |1 is obsolete| | --- Comment #215 from Jonathan Druart --- Created attachment 38555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38555&action=edit Bug 10855: Squash several fixes Bug 10855: FIX: Add additional fields for closed subscriptions Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. Bug 10855: FIX conflicts with bug 7688 Bug 10855: Fix typo addition_fields -> additional_fields Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. Bug 10855: Remove the advanced serial search box on the serial home page Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. Bug 10855: Fix Type table vs tablename Koha::AdditionalField->all method take "tablename" not "table" in parameter". Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:47:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:47:54 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36369|0 |1 is obsolete| | --- Comment #216 from Jonathan Druart --- Created attachment 38556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38556&action=edit Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:48:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:48:00 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12160 CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:48:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:48:00 +0000 Subject: [Koha-bugs] [Bug 12160] Rename intranetuserjs to IntranetUserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10327 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:47:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:47:59 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36370|0 |1 is obsolete| | --- Comment #217 from Jonathan Druart --- Created attachment 38557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38557&action=edit Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:48:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:48:05 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36371|0 |1 is obsolete| | --- Comment #218 from Jonathan Druart --- Created attachment 38558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38558&action=edit Bug 10855: Additional marc fields are not inserted In subscription-add.pl, the code for inserting additional_fields is not the same for updating and inserting. This patch refactores this code in code to do the same tests. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:48:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:48:11 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36372|0 |1 is obsolete| | --- Comment #219 from Jonathan Druart --- Created attachment 38559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38559&action=edit Bug 10855: Make tests to pass Some recent changes in master make these tests fail. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:48:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:48:17 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36373|0 |1 is obsolete| | --- Comment #220 from Jonathan Druart --- Created attachment 38560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38560&action=edit Bug 10855: (follow-up) Search subscriptions by additional fields 1 occurrence of KohaAuthorisedValues had not been replaced with AuthorisedValues on fixing a previous conflict. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:48:23 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36374|0 |1 is obsolete| | --- Comment #221 from Jonathan Druart --- Created attachment 38561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38561&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 15:50:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 13:50:20 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38543|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 38562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38562&action=edit Bug 13810: Change collate for tagsubfield (utf8_bin) Before bug 11944, the marc_subfield_structure.tagsubfield column had a specific collate: utf8_bin. It has been introduced by commit 67e20d82ffdfcd69344ec30696bebc51c00d863c Date: Sun Jun 22 16:35:48 2008 -0500 DB Bump 094 - bug 2268 -- allow mixed case subfield labels in MARC21 by changing db column collation. This change should be kept and Koha should continue to allow and create subfields with the same letter but different case sensitivity. What does this patch: 1/ To prevent the updatedatabase entry 3.19.00.006 to fail if subfields with different case sensitivity already exist in the DB, the table is managed separately from others. 2/ To update DB which have already pass this dbrev, a new entry will be create to update the specific collate for this column. Test plan: 1/ a. With a 3.18 DB, create subfield 'a' and 'A' for the same field b. Execute the updatedatabase.pl script. 3.19.00.006 should not fail anymore 2/ a. With a master DB (3.19.00.006 has already been executed), create subfields 'a' and 'A'. You should get an error. b. Apply this patch, execute the DB entry and try again 2/a. you should be able to create the second subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:10:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:10:39 +0000 Subject: [Koha-bugs] [Bug 12160] Rename intranetuserjs to IntranetUserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:10:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:10:42 +0000 Subject: [Koha-bugs] [Bug 12160] Rename intranetuserjs to IntranetUserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 --- Comment #1 from Jonathan Druart --- Created attachment 38563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38563&action=edit Bug 12160: Rename intranetuserjs with IntranetUserJS To match IntranetUserCSS, intranetuserjs should be renamed IntranetUserJS. Test plan: 1/ Be sure there is no occurrence of intranetuserjs 2/ Confirm the pref still works as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:10:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:10:47 +0000 Subject: [Koha-bugs] [Bug 12160] Rename intranetuserjs to IntranetUserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 --- Comment #2 from Jonathan Druart --- Created attachment 38564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38564&action=edit Bug 12160: Rename opacuserjs with OpacUserJS Test plan: Same as previous patch for opacuserjs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:11:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:11:31 +0000 Subject: [Koha-bugs] [Bug 12160] Rename intranetuserjs to IntranetUserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:11:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:11:54 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename intranetuserjs to |Rename |IntranetUserJS |[intranet|opac]userjs to | |[Intranet|OPAC]UserJS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:12:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:12:08 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|Opac]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename |Rename |[intranet|opac]userjs to |[intranet|opac]userjs to |[Intranet|OPAC]UserJS |[Intranet|Opac]UserJS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:12:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:12:27 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename |Rename |[intranet|opac]userjs to |[intranet|opac]userjs to |[Intranet|Opac]UserJS |[Intranet|OPAC]UserJS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:13:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:13:52 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38564|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 38565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38565&action=edit Bug 12160: Rename opacuserjs with OPACUserJS Test plan: Same as previous patch for opacuserjs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:16:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:16:10 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Architecture, internals, | |and plumbing See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6427 CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |gmcharlt at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:16:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:16:10 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12159 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:28:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:28:50 +0000 Subject: [Koha-bugs] [Bug 12139] Preference name saved all lowercase In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12139 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jonathan Druart --- Looks good now, I did not manage to recreate this issue. Please reopen if I am wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:40:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:40:16 +0000 Subject: [Koha-bugs] [Bug 11340] make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:55:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:55:18 +0000 Subject: [Koha-bugs] [Bug 12160] Rename [intranet|opac]userjs to [Intranet|OPAC]UserJS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38565|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 38566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38566&action=edit Bug 12160: Rename opacuserjs with OPACUserJS Test plan: Same as previous patch for opacuserjs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:57:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:57:18 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:57:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:57:29 +0000 Subject: [Koha-bugs] [Bug 13437] Convert marc21 framework plugins to new style (see also 10480) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13437 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:59:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:59:43 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #2 from Jonathan Druart --- Created attachment 38567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38567&action=edit Bug 12135: Fix suggestions table width The trick to update the suggestions table width is outdated since jQuery UI has been updated. Test plan: 0/ Don't apply this patch 1/ Go on the suggestions page (suggestion/suggestion.pl), change tabs: the table width is wrong 2/ Apply this patch 4/ Repeat 1 and confirm the width is now updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:59:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:59:40 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 16:59:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 14:59:56 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:09:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:09:13 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #3 from M. Tompsett --- Comment on attachment 38546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38546 Bug 14066: Remove the Readonly[::XS] dependency Review of attachment 38546: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14066&attachment=38546) ----------------------------------------------------------------- ::: C4/Installer/PerlDependencies.pm @@ -240,5 @@ > - 'Readonly' => { > - 'usage' => 'Core', > - 'required' => '1', > - 'min_ver' => '1.03' > - }, I think we should keep Readonly. It is one of the better ways of defining constants, and would allow us to improve our perlcritic levels in the future. Currently, we only require perlcritic -5. @@ -245,5 @@ > - 'Readonly::XS' => { > - 'usage' => 'Core', > - 'required' => '0', > - 'min_ver' => '1.02' > - }, However, from the Readonly page on CPAN: "I repeat, you do not need Readonly::XS if your environment has perl 5.8.x or higher." Perhaps just removing Readonly::XS is the better solution. :) ::: Koha/Calendar.pm @@ +126,4 @@ > > if ( $unit eq 'hours' ) { > # Fixed for legacy support. Should be set as a branch parameter > + my $return_by_hour => 10; Readonly's definition of a scalar value is confusing, such that when you changed it to a simple variable to accidentally left what looks like hashiness (=>), even though it probably should be plainly scalar (=). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:15:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:15:33 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:15:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:15:35 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #1 from Fridolin SOMERS --- Created attachment 38568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38568&action=edit Bug 14053 - Acquisition db tables are missing indexes Acquisition db tables have a lot of relational constraints and are often missing an index to have performance queries. This patch adds an index for all columns used in a forein key. Also adds an index on some columns very often used in search queries : aqbooksellers.name and aqbudgets.budget_code. Also adds an index on aqorders.orderstatus, very often used with hardcoded value like 'cancelled', in various queries. Test plan : - Check SQL syntax is correct - Try to compare performance after and before database update. I think query contained in C4::Acquistion::GetInvoices could be a good example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:15:49 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #2 from Fridolin SOMERS --- Created attachment 38569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38569&action=edit Bug 14053 - Acquisition db tables are missing indexes - atomicupdates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:25:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:25:03 +0000 Subject: [Koha-bugs] [Bug 12109] Authority subfield configuration page for controlled fields is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:25:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:25:06 +0000 Subject: [Koha-bugs] [Bug 12109] Authority subfield configuration page for controlled fields is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 --- Comment #1 from Jonathan Druart --- Created attachment 38570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38570&action=edit Bug 12109: Fix tab on the auth subfield configuration page There is a condition in the template to not display the "New" tab if the user is editing a control field. But it results in a broken template. Looking at the biblio frameworks, the New tab exists even for control fields. This patch only fixes the html structure, but a complete fix should be provide, for auth and biblio, if we want not to let the ability to create subfields for control fields. Test plan: Edit subfields for a control field (admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance) and confirm that the view is now fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:25:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:25:25 +0000 Subject: [Koha-bugs] [Bug 12109] Authority subfield configuration page for controlled fields is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:34:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:34:38 +0000 Subject: [Koha-bugs] [Bug 13914] The holds statistics report returns random data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12082 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:34:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:34:38 +0000 Subject: [Koha-bugs] [Bug 12082] hold statistics wizard can produce misleading results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12082 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13914 CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:36:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:36:23 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- Some interesting reading while researching making things read only. "The interface for this module was inspired by Eric Roode's Readonly. The implementation is inspired by doing everything the opposite way Readonly does it." (http://search.cpan.org/~leont/Const-Fast-0.014/lib/Const/Fast.pm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:50:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:50:14 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #5 from M. Tompsett --- Further reading. http://neilb.org/reviews/constants.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:50:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:50:54 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14066 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 17:50:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 15:50:54 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13767 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 18:39:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 16:39:55 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #58 from Tom?s Cohen Arazi --- Feature pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 18:40:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 16:40:22 +0000 Subject: [Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 21:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 19:13:39 +0000 Subject: [Koha-bugs] [Bug 14067] New: 500 error when deleting patrons Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067 Bug ID: 14067 Summary: 500 error when deleting patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: amy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 38571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38571&action=edit delete patron error msg screen Partners getting a 500 error (screenshot attached) when attempting to delete patrons. It may be that as long as all of the required fields are filled in this error does not occur. But if any fields are missing the error is seen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 21:34:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 19:34:45 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz, | |tomascohen at gmail.com --- Comment #106 from Tom?s Cohen Arazi --- Ok, I hate you guys :-D Couldn't you just choose a PDF library that is shipped with Debian? :-D I successfully built both - libpdf-writer-perl - libpdf-fromhtml-perl on Jessie but I need to check with Robin. Maybe he would let me build those. I put this one on hold for a couple days (it works, I like it). There's also a new non-Perl dependency python-pisa. It definitely needs to be added to control.in on the koha-deps section for this to be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 21:50:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 19:50:12 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #17 from M. Tompsett --- Created attachment 38572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38572&action=edit Three Barcodes and blank lines (\n delimiter) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 21:50:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 19:50:46 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #18 from M. Tompsett --- Created attachment 38573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38573&action=edit Three Barcodes and blank lines (\r delimiter) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 21:51:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 19:51:33 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #19 from M. Tompsett --- Created attachment 38574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38574&action=edit Three Barcodes and blank lines (\r\n delimiter) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 22:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 20:01:04 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37848|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 38575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38575&action=edit Bug 10625: Inventory/Stocktaking tool cannot handle windows file uploads The current code uses $barcode = ; logic. This reads until \n, as far as I can tell. EOL is indicated by \n, \r, and \r\n depending on OS and software. So, to this end, rather than File::Slurp (which is a potential memory hog, which is already an issue with no filters), a loop to pre-read the barcodes was written. This loop includes: $barcode =~ s/\r/\n/g; $barcode =~ s/\n\n/\n/g; my @data = split(/\n/, $barcode); push @uploadedbarcodes, at data; So, that means that lines ending in \n would have it stripped and pushed into the uploaded barcodes array. Lines ending in \r would likely be read as one giant block, have everything converted to single \n's and then using a split, the set of barcodes are pushed into the uploaded barcodes array. Lines ending in \r\n would get that stripped and pushed into the uploaded barcodes array. It is then the uploaded barcodes array that is looped over for validating the barcodes. TEST PLAN --------- 1) Back up your database 2) Download the three sample files (or create your own) 3) Log in to staff client 4) Create a branch with no inventory. 5) Home -> Tools -> Inventory/Stocktaking 6) Browse for your '\r' test file. 7) Limit to just that branch 8) Click 'Submit' -- Confirm expected errors 9) Repeat steps 5-8 with the '\n' test file. 10) Repeat steps 5-8 with the '\r\n' test file. -- one of these repetitions should have problems. 11) Apply patch 12) Repeat steps 5-8 for each of the 3 test files. -- there should be no issues. 13) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 22:05:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 20:05:59 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38575|0 |1 is obsolete| | --- Comment #21 from M. Tompsett --- Created attachment 38576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38576&action=edit Bug 10625: Inventory/Stocktaking tool cannot handle windows file uploads The current code uses $barcode = ; logic. This reads until \n, as far as I can tell. EOL is indicated by \n, \r, and \r\n depending on OS and software. So, to this end, rather than File::Slurp (which is a potential memory hog, which is already an issue with no filters), a loop to pre-read the barcodes was written. This loop includes: $barcode =~ s/\r/\n/g; $barcode =~ s/\n\n/\n/g; my @data = split(/\n/, $barcode); push @uploadedbarcodes, at data; So, that means that lines ending in \n would have it stripped and pushed into the uploaded barcodes array. Lines ending in \r would likely be read as one giant block, have everything converted to single \n's and then using a split, the set of barcodes are pushed into the uploaded barcodes array. Lines ending in \r\n would get that stripped and pushed into the uploaded barcodes array. It is then the uploaded barcodes array that is looped over for validating the barcodes. TEST PLAN --------- 1) Back up your database 2) Download the three sample files (or create your own) 3) Log in to staff client 4) Create a branch with no inventory. 5) Home -> Tools -> Inventory/Stocktaking 6) Browse for your '\r' test file. 7) Limit to just that branch 8) Click 'Submit' -- Confirm expected errors 9) Repeat steps 5-8 with the '\n' test file. 10) Repeat steps 5-8 with the '\r\n' test file. -- one of these repetitions should have problems. 11) Apply patch 12) Repeat steps 5-8 for each of the 3 test files. -- there should be no issues. 13) run koha qa test tools. Note: This is a tweak based on Jonathan Druart's comment #16 I have reset it to needs sign off again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 22:06:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 20:06:29 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 22:31:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 20:31:27 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 27 23:09:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 21:09:51 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |cbrannon at cdalibrary.org --- Comment #6 from Christopher Brannon --- Works in circulation.pl. Problem still exists in member.pl and guarantor_search.pl. Don't know about other areas. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 00:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 22:39:26 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #6 from M. Tompsett --- Created attachment 38577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38577&action=edit Bug 14066: Correct and optimize As far as I can tell $sunday is never used. And it seemed to be scoped to only _init. The remaining hashiness was cleaned up for the $return_by_hour. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Calendar.t 3) prove -v t/db_dependent/Holidays.t 4) prove -v t/Calendar.t 5) perlcritic -3 Koha/Calendar.pm -- the message corresponds to a comment in the code already and not this change. 6) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 00:51:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 22:51:26 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38577|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 38578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38578&action=edit Bug 14066: Correct and optimize As far as I can tell $sunday is never used. And it seemed to be scoped to only _init. The remaining hashiness was cleaned up for the $return_by_hour. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Calendar.t 3) prove -v t/db_dependent/Holidays.t 4) prove -v t/Calendar.t 5) perlcritic -3 Koha/Calendar.pm -- the message corresponds to a comment in the code already and not this change. 6) run koha qa test tools Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 00:52:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 22:52:09 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38546|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 38579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38579&action=edit Bug 14066: Remove the Readonly[::XS] dependency The Readonly and Readonly::XS package are only used in Koha::Calendar. IMO the added value of there packages does not justify their purpose. Test plan: 1/ Remove Readonly and Readonly::XS 2/ Open the calendar and confirm you don't get any error concerning missing dependency Signed-off-by: Mark Tompsett Tested in conjuction with both patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 00:52:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 22:52:22 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38578|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 38580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38580&action=edit Bug 14066: Correct and optimize As far as I can tell $sunday is never used. And it seemed to be scoped to only _init. The remaining hashiness was cleaned up for the $return_by_hour. TEST PLAN --------- 1) Apply both patches 2) prove -v t/db_dependent/Calendar.t 3) prove -v t/db_dependent/Holidays.t 4) prove -v t/Calendar.t 5) perlcritic -3 Koha/Calendar.pm -- the message corresponds to a comment in the code already and not this change. 6) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 00:55:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 22:55:39 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #10 from M. Tompsett --- P.S. I did test around in Home->Tools->Calendar too, and attempting to look for sunday elsewhere in code. P.P.S. It's beautiful to have a white Perl modules tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 00:57:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 22:57:15 +0000 Subject: [Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #13 from M. Tompsett --- I think Jonathan's solution of removing the dependency is better. :) I just tweaked up his solution on bug 14066. Feel free to test it and sign off. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 01:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 Apr 2015 23:33:52 +0000 Subject: [Koha-bugs] [Bug 14067] 500 error when deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- If you look in your intranet error logs, you should be able to find the root cause. >From the sound of it, I'm guessing that it's a SQL error. Worth checking to see if MySQL is in strict mode. Koha and MySQL in strict mode don't get along very well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 02:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 00:27:37 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #107 from Robin Sheat --- (In reply to Tom?s Cohen Arazi from comment #106) > Couldn't you just choose a PDF library that is shipped with Debian? :-D Seconded! > I successfully built both > - libpdf-writer-perl > - libpdf-fromhtml-perl > on Jessie but I need to check with Robin. Maybe he would let me build those. > I put this one on hold for a couple days (it works, I like it). It'll need to build on Wheezy, too. That might be fine, or maybe it won't be. I'll have a look when I get some other people-wanting-dependencies-that-don't-exist issues sorted. I am curious why we need multiple PDF writing things though, is it not possible to standardise around one? (and fair enough if it's not, but I'd like it to be considered before just adding in dependencies.) Tom?s: You can build the packages if you like, so long as they would get into debian :) (or, to be honest, if they pass lintian with pedantic=yes and the pkg-perl profile applied, that's usually 90% of the work done right there. It's about time I started scripting more of the deploy process, and someone else doing stuff with it would make that more necessary.) > There's also a new non-Perl dependency python-pisa. It definitely needs to > be added to control.in on the koha-deps section for this to be pushed. Gar. We literally just removed python as a dependency. Like, a couple of weeks ago. Oh well. Unrelated to the packaging, and I'm not sure if this is a problem, but it looks like files are generated as borrnum/borrnum+date.tar.gz, and this is a totally predictable filename. Is this an OK thing to have? Also, should paths be a system preference? Should library staff be able to change the web paths and file paths on the system? That seems like something that is out of the scope of library policy and well into the scope of systems admin, and so defined in koha-conf.xml. My litmus test there is "does it make sense for library staff to be able to change this.", and in a case like this, I contend that it's meaningless. It also makes it harder for installation processes to set it to something that suits the distribution. Actually, the more I think about it, the more of a problem that last part is, as it means there's no way to have a "default works" situation, and there's no way you could expect library staff to fill out a path on the system. Additionally, this should be creating directories under /var/lib/koha/instancename/ as part of koha-create-dirs to put these files, and alias to them in the appropriate apache template. Other misc things: * discharges.pl has no error handling, it just blindly attempts to open a file and send it. What if the file doesn't exist? It looks like you'll then end up with people saving those PDF files that really contain an error message that confuses everyone. * related, there are other places where files are opened and everything is assumed to be OK. Can we stop assuming that everything is going to be OK? It causes too many problems when it's not. Code defensively, handle errors sensibly. * the RFC talks about mailing things, but I can't see in the patches where that happens, does it exist? I was trying to verify it was using the mailqueue, as the RFC implies (but doesn't say) that it doesn't. I'm going to make it failed because there's a good few things in here that need to be considered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 02:30:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 00:30:37 +0000 Subject: [Koha-bugs] [Bug 12099] process_message_queue.pl tells it sends print mails even if it doesn't. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12099 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- So, test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 02:36:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 00:36:27 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 03:19:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 01:19:21 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 --- Comment #11 from M. Tompsett --- (In reply to M. Tompsett from comment #10) > *** Bug 14036 has been marked as a duplicate of this bug. *** Correction, it isn't. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 04:08:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 02:08:05 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38470|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 38581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38581&action=edit Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a semi-colon into the description so that it makes more grammatical sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a semi-colon and reads ".. Be careful about your scope range - if it is oversized you could slow down Koha." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 04:13:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 02:13:20 +0000 Subject: [Koha-bugs] [Bug 14068] New: Bug 14055 breaks new package installs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14068 Bug ID: 14068 Summary: Bug 14055 breaks new package installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Don't rush things out on Friday afternoon, folks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 04:13:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 02:13:32 +0000 Subject: [Koha-bugs] [Bug 14068] Bug 14055 breaks new package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14068 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | Priority|P5 - low |P1 - high Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 04:50:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 02:50:09 +0000 Subject: [Koha-bugs] [Bug 9920] Set minPasswordLength to a higher value by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9920 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|NEW |Needs Signoff --- Comment #6 from Aleisha Amohia --- Setting to Needs Signoff as it looks like this is ready to be tested by someone -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 05:20:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 03:20:02 +0000 Subject: [Koha-bugs] [Bug 14068] Bug 14055 breaks new package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14068 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14055 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 05:20:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 03:20:02 +0000 Subject: [Koha-bugs] [Bug 14055] Bug 13979 breaks package upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14055 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14068 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 05:45:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 03:45:00 +0000 Subject: [Koha-bugs] [Bug 14068] Bug 14055 breaks new package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14068 --- Comment #1 from Robin Sheat --- Created attachment 38582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38582&action=edit Bug 14068: fix preinst for fresh package installs This should solve it, I hope. Should be applied to all supported koha versions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:05:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:05:01 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38581|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 38583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38583&action=edit Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a semi-colon into the description so that it makes more grammatical sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a semi-colon and reads "... Be careful about your scope range; if it is oversized you could slow down Koha." Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:11:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:11:38 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:15:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:15:08 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29557|0 |1 is obsolete| | --- Comment #45 from Srdjan Jankovic --- Created attachment 38584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38584&action=edit bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - removed GetItemsLocationInfo() - added sort_by input param to GetItemsInfo() - VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call with GetItemsInfo() call, passing order_by "cn_sort" * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:15:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:15:22 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29558|0 |1 is obsolete| | --- Comment #46 from Srdjan Jankovic --- Created attachment 38585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38585&action=edit bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:15:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:15:38 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29559|0 |1 is obsolete| | --- Comment #47 from Srdjan Jankovic --- Created attachment 38586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38586&action=edit bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:15:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:15:52 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29560|0 |1 is obsolete| | --- Comment #48 from Srdjan Jankovic --- Created attachment 38587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38587&action=edit bug_11213: C4::VirtualShelves::Page::shelf_contents() * Extracted shelf items processing from shelfpage() into a separate sub shelf_contents() in order to be able to test it * Added tests for shelf_contents() with XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:16:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:16:44 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29561|0 |1 is obsolete| | Attachment #29562|0 |1 is obsolete| | --- Comment #49 from Srdjan Jankovic --- Created attachment 38588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38588&action=edit bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:17:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:17:06 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29563|0 |1 is obsolete| | --- Comment #50 from Srdjan Jankovic --- Created attachment 38589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38589&action=edit bug_11213: Added XSLTParse4Display() to Items test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:18:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:18:01 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29564|0 |1 is obsolete| | --- Comment #51 from Srdjan Jankovic --- Created attachment 38590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38590&action=edit bug_11213: Check for $item->{itype} presence to avoid warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:18:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:18:34 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:27:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:27:10 +0000 Subject: [Koha-bugs] [Bug 14068] Bug 14055 breaks new package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14068 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:43:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:43:00 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #11 from Marc V?ron --- Testing with both patches, following test plan: 1) Apply both patches OK 2) prove -v t/db_dependent/Calendar.t ?? t/db_dependent/Calendar.t This file does not exist. find -name Cal*.t Result: ./t/Calendar.t OK - error in test plan :-) 3) prove -v t/db_dependent/Holidays.t OK 4) prove -v t/Calendar.t OK 5) perlcritic -3 Koha/Calendar.pm -- the message corresponds to a comment in the code already and not this change. OK, one message found: Package variable declared or used at line 60, column 1. See pages 73,75 of PBP. (Severity: 3) 6) run koha qa test tools qa -c 2 [-v 2] OK Koha/Calendar.pm OK C4/Installer/PerlDependencies.pm Will sign off... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:46:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:46:31 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #12 from Marc V?ron --- Created attachment 38591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38591&action=edit [Signed-off] Bug 14066: Remove the Readonly[::XS] dependency The Readonly and Readonly::XS package are only used in Koha::Calendar. IMO the added value of there packages does not justify their purpose. Test plan: 1/ Remove Readonly and Readonly::XS 2/ Open the calendar and confirm you don't get any error concerning missing dependency Signed-off-by: Mark Tompsett Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:51:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:51:16 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:53:25 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38591|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Comment on attachment 38591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38591 [Signed-off] Bug 14066: Remove the Readonly[::XS] dependency Mistaked (once more...), sorry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:53:49 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38546|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:57:56 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38546|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:58:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:58:20 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38579|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 06:59:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 04:59:57 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #14 from Marc V?ron --- Created attachment 38592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38592&action=edit [Signed-off] Bug 14066: Remove the Readonly[::XS] dependency The Readonly and Readonly::XS package are only used in Koha::Calendar. IMO the added value of there packages does not justify their purpose. Test plan: 1/ Remove Readonly and Readonly::XS 2/ Open the calendar and confirm you don't get any error concerning missing dependency Signed-off-by: Mark Tompsett Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 07:00:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 05:00:26 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 07:02:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 05:02:11 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 --- Comment #15 from Marc V?ron --- Created attachment 38593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38593&action=edit [Signed-off] Bug 14066: Correct and optimize As far as I can tell $sunday is never used. And it seemed to be scoped to only _init. The remaining hashiness was cleaned up for the $return_by_hour. TEST PLAN --------- 1) Apply both patches 2) (Skip this one - file does not exist / MV) prove -v t/db_dependent/Calendar.t 3) prove -v t/db_dependent/Holidays.t 4) prove -v t/Calendar.t 5) perlcritic -3 Koha/Calendar.pm -- the message corresponds to a comment in the code already and not this change. 6) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 07:02:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 05:02:38 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 08:09:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 06:09:51 +0000 Subject: [Koha-bugs] [Bug 9920] Set minPasswordLength to a higher value by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9920 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Marcel de Rooy --- This patch changes db rev 3.00.00.031. It should add a new db rev. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 09:10:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 07:10:45 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Jonathan Druart --- (In reply to Christopher Brannon from comment #6) > Works in circulation.pl. Problem still exists in member.pl and > guarantor_search.pl. Don't know about other areas. > > Christopher Hi Christopher, What does not work? I have tried again it seems to work. Note that this patch does not modify the circulation.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 09:41:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 07:41:39 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #108 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #106) (In reply to Robin Sheat from comment #107) Hi Tom?s and Robin, As you can see, this bug report has been opened a while ago. And I rewrote the original patch (from Matthias) to make it cleaner. The wiki page is outdated, I will put a warning on it. Sorry about that (I have forgotten the existence of this page...) Almost all of your concerns have been addressed/answered in the comments, but I admit 100 comments is a lot to read :) First, the dependencies. Have a look at comment 64 and comment 65, the packaged perl modules don't seem to work. python-pisa works as needed but as it's a python dependency I preferred to remove it (so python vs non packaged perl module). Then the paths, the pdf file is generated on the fly (see Katrin's concerns on comment 64). The html and pdf files are generated using tmpnam. > * the RFC talks about mailing things, but I can't see in the patches where > that happens, does it exist? I was trying to verify it was using the > mailqueue, as the RFC implies (but doesn't say) that it doesn't. This has been abandoned. The most recent "doc" is the commit messages of the last (non-obsoleted) patches. I spent days on this development, starting 2 years ago, and I have rewritten it several times. It starts to make me crazy... Back to Passed QA to let you see my comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 09:53:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 07:53:26 +0000 Subject: [Koha-bugs] [Bug 12057] anonymous suggestions showing to all / own suggestions invisible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12057 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 4137 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 09:53:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 07:53:26 +0000 Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137 --- Comment #11 from Jonathan Druart --- *** Bug 12057 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 10:07:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 08:07:36 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #109 from Robin Sheat --- OK, that does address many of my concerns, though I'd like better error checking still. I don't mind adding a dependency like this, it was more a grump about having just got rid of python? Will have another proper look tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 10:19:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 08:19:43 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Created attachment 38594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38594&action=edit Bug 12054: Inactive vendors should be inactive Bug 12054: Inactive vendors should be inactive This patch make inactive vendors really inactive. That means an inactive vendor won't be able to receive / add a basket / add an order. Test plan: In the acquisition module create 2 vendors: 1 active and 1 inactive. On the acqui/booksellers.pl, acqui/uncertainprice.pl, admin/aqcontract.pl and acqui/supplier.pl (pages which include the acq toolbar) pages, confirm that you are not able to receive shipments, create a new basket, add a new order for the inactive vendor. No change should exist for the active vendor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 10:19:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 08:19:53 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_12054=5D__It=E2=80=99s_possible_to_m?= =?utf-8?q?ake_order_from_an_inactive_vendor?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 10:21:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 08:21:32 +0000 Subject: [Koha-bugs] [Bug 12036] Neworderempty.pl fails to add items when itemrecorddisplay is too long (acqCreateItem=ordering) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12036 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Marcel, do you still have this issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 10:27:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 08:27:43 +0000 Subject: [Koha-bugs] [Bug 12013] Long loan period slows checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- This has certainly been fixed by bug 13242 and/or recent changes to Koha::DateUtils. Please reopen if the issue still exists on master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 10:32:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 08:32:52 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38519|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 38595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38595&action=edit Bug 14063 - Implement language overlay for authorised values This patch implements a language overlay for authorised values. To prepare tests - Have an installation with e.g. English, French and German languages - Set syspref 'suggestion' to: [Allow] patrons to make purchase suggestions on the OPAC. - Verify that you have a authorised values for OPAC_SUG (bestseller, damaged) - Open OPAC, log in, go to Purchase suggestions > Create a new suggesion - The dropdown "Reason for suggestion:" shows the authorised values from OPAC_SUG, e.g. "The copy on the shelf is damaged" and "Upcoming title by popular author" - Select German - The dropdown "Begr?ndung" shows the same (English) values. - Same with French - Open Intranet (Staff client) - Go to Home > Acquisitions > Suggestions management > New purchase suggestion - Switch between languages, the dropdown "Reason for suggestion" changes the label, but the values are not ranslated. - Same with the detail view of a suggestion To test: - In Staff client, go to Home > Administration > Authorized values - Add a new category OPAC_SUG-de-DE (add language code) - Create new translated values 'bestseller' and 'damaged' for this category. - Do the same for French (OPAC_SUG-fr-FR) or other installed languages - Go to OPAC > Purchase suggestions > Create a new suggesion - Switch between languages, the values in the dropdown 'Reason' should display in selected language - Got to Staff client > Home > Acquisitions > Suggestions management > New purchase suggestion - Switch between languages and verify that the values in the dropdown 'Reason' display in selected language - Display a suggestion's detail view, switch languages. Text for 'Reason' should change as appropriate. Bonus test: - Create language overlays e.g. for category 'DAMAGED' (DAMAGED-de-DE and DAMAGED-fr-FR), authorised values 0 -> 'No' and 1 -> 'Damaged' --- Amended: Trailing white space removed to pass QA tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 10:37:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 08:37:13 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker --- Comment #12 from Katrin Fischer --- I agree - updating the priority some more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:02:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:02:11 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #110 from Jonathan Druart --- Created attachment 38596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38596&action=edit Bug 8007: Add error handling when generating the pdf If error occurs when generating the pdf, it would be better to get an encapsulated error instead of the "software error" message in the pdf file. To test this patch I added this change: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:03:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:03:23 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38596|0 |1 is obsolete| | --- Comment #111 from Jonathan Druart --- Created attachment 38597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38597&action=edit Bug 8007: Add error handling when generating the pdf If error occurs when generating the pdf, it would be better to get an encapsulated error instead of the "software error" message in the pdf file. To test this patch I added this change: b/Koha/Borrower/Discharge.pm -115,6 +115,7 @@ sub generate_as_pdf { say $html_fh $html_content; close $html_fh; my $pdf = PDF::FromHTML->new( encoding => 'utf-8' ); + $html_path .= "poeut"; $pdf->load_file( $html_path ); $pdf->convert; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:05:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:05:38 +0000 Subject: [Koha-bugs] [Bug 12002] Koha does not pick up installed languages when running under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12002 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED --- Comment #5 from Jonathan Druart --- Considered as fixed/invalid. Magnus, feel free to reopen if you recreate the error later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:07:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:07:47 +0000 Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding and format errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Pablo, could you please test it again against the master branch? Some recent fixes related to the export and encoding have been pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:08:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:08:14 +0000 Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding and format errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:08:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:08:14 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11997 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:22:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:22:58 +0000 Subject: [Koha-bugs] [Bug 14066] Koha code does not really use Readonly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:29:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:29:46 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron list"s are not accessible from the HTML header "More" -> "Lists" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:29:48 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron list"s are not accessible from the HTML header "More" -> "Lists" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 --- Comment #2 from Jonathan Druart --- Created attachment 38598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38598&action=edit Bug 11941: Add link to patron lists from the patron home page The patron lists are only accessible from the tools module, which is not easily accessible when you are in the patron module. Test plan: Go on the patron home page. In the toolbar, you should see a link to the patron lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:30:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:30:29 +0000 Subject: [Koha-bugs] [Bug 11941] "Patron lists" are not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Patron list"s are not |"Patron lists" are not |accessible from the HTML |easily accessible |header "More" -> "Lists" | CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:45:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:45:18 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #36 from Julian Maurice --- Same problem here. It seems that primary key was introduced by Bug 4002 (version 3.05.00.009 - d0c9592592c0bd6c529915a9fbc04476f9b52851), and it was removed *only from kohastructure.sql* by Bug 6716 (version 3.05.00.011 - 91b5a09c6cef398d9ad39ca1ced7d6569a87456b) So the problem will happen to those who started with Koha 3.4 or less. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:47:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:47:56 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #37 from Julian Maurice --- To make the updatedatabase process to finish correctly I had to run the following query: ALTER TABLE issues DROP PRIMARY KEY -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:49:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:49:56 +0000 Subject: [Koha-bugs] [Bug 11925] patron category not checking ages limits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:49:58 +0000 Subject: [Koha-bugs] [Bug 11925] patron category not checking ages limits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 --- Comment #1 from Jonathan Druart --- Created attachment 38599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38599&action=edit Bug 11925: Check ages limits when creating/updating patrons The check on the ages limits is only done when the dateofbirth field is mandatory, which does not make any sense. This check should be done when the field is filled. Test plan: 1/ Remove the dateofbirth field from the BorrowerMandatoryField pref 2/ Create a patron category for teenager (say between 12-17y) 3/ Try to create a patron in this category outside the range of the ages limits. You should not be able to do it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:50:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:50:07 +0000 Subject: [Koha-bugs] [Bug 11925] patron category not checking ages limits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:51:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:51:07 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #38 from Katrin Fischer --- Hi Julian, thx for investigating. I think we need to fix this prior to release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:53:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:53:44 +0000 Subject: [Koha-bugs] [Bug 14069] New: Follow-up 13790: Fix database update to drop PK on issues/old_issues first Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Bug ID: 14069 Summary: Follow-up 13790: Fix database update to drop PK on issues/old_issues first Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org In some older databases there is a PK on the itemnumber in issues. The database update for 13790 needs to be fixed to also run without problems on those databases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:53:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:53:59 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13790 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:53:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:53:59 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14069 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:54:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:54:38 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14069 | --- Comment #39 from Katrin Fischer --- I have filed a separate 'blocker' bug 14069. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:54:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:54:38 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13790 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:54:49 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13790 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 11:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 09:54:49 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14069 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 12:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 10:08:27 +0000 Subject: [Koha-bugs] [Bug 12364] Useless use of '\'; doesn't escape metacharacter '(' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 12654 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 12:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 10:08:27 +0000 Subject: [Koha-bugs] [Bug 12654] Incorrect quoting in regexp in AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12654 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins at cpbibliography.com --- Comment #5 from Jonathan Druart --- *** Bug 12364 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 12:58:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 10:58:29 +0000 Subject: [Koha-bugs] [Bug 12320] $.cookie('foo', null) deprecated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 12:58:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 10:58:35 +0000 Subject: [Koha-bugs] [Bug 12320] $.cookie('foo', null) deprecated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12320 --- Comment #2 from Jonathan Druart --- Created attachment 38601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38601&action=edit Bug 12320: Remove deprecated construct to delete cookie showColumns $.cookie('foo', null); is deprecated and should be replaced with $.removeCookie('foo'); This patch replaces the occurrences for the "showColumns" cookie. Before this patch, there was a bug on the batchmod tools. To reproduce the issue: 1/ Go on the Batch item modification tool 2/ Fill the textarea with barcodes and submit 3/ Click on some column names (to create the cookie) 4/ Click on 'Show all columns" (to set the cookie to null) 5/ Don't submit and repeat steps 1 & 2 6/ You should see a js error: Error: Syntax error, unrecognized expression: :nth-child ...break;q=a}return s},m.error=function(a){throw new Error("Syntax error, unrecogni... Test plan: Confirm the issue has gone away and there is no regression on the column selection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 12:58:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 10:58:31 +0000 Subject: [Koha-bugs] [Bug 12320] $.cookie('foo', null) deprecated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12320 --- Comment #1 from Jonathan Druart --- Created attachment 38600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38600&action=edit Bug 12320: Remove deprecated construct to delete cookie holdfor $.cookie('foo', null); is deprecated and should be replaced with $.removeCookie('foo'); This patch replaces the occurrences for the "holdfor" cookie. Test plan: 1/ Search for a patron 2/ On the patron detail page, click on "search to hold" 3/ Search for records 4/ On the results page, click on "Place hold" > "Forget PATRON" 5/ Reload the page. 6/ The "Place hold" button should not contain the patron anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 12:58:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 10:58:58 +0000 Subject: [Koha-bugs] [Bug 12320] $.cookie('foo', null) deprecated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 13:07:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 11:07:12 +0000 Subject: [Koha-bugs] [Bug 12290] Gracefully handle errors in datatables.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12290 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 13:20:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 11:20:06 +0000 Subject: [Koha-bugs] [Bug 14022] Subscription form resets 'subscription length' to issues on editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14022 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13471 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 13:20:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 11:20:06 +0000 Subject: [Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14022 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 13:21:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 11:21:32 +0000 Subject: [Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 --- Comment #7 from Katrin Fischer --- > We make an subscription with SLT of months = 12. > Later make an arbitrary edit to the subscription, and miss out the fact that > the SLT selection is set to issues. > Save the changes. > Serial subscription end date is set to 12 issues since the start date, > instead of 12 months which it used to be. This causes a myriad of issues :=) > > AFTER THIS PATCH: > > SLT defaults to the value initially saved instead of always being issues. > Now the selection can be translated! This has been fixed by bug 14022 now - as this patch includes some more changes, I am not closing it yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 13:23:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 11:23:03 +0000 Subject: [Koha-bugs] [Bug 12267] Allow password option in Patron Attribute non functional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- (In reply to Galen Charlton from comment #2) > (In reply to Katrin Fischer from comment #1) > > Hi Joy, I am not sure if that was the purpose of the field. The way someone > > explained it to me in the past was, that it allows you to store a password > > for another application. > > Actually, Joy's right - the original intent was to support secondary logins. http://lists.koha-community.org/pipermail/koha-patches/2008-May/000988.html - password_allowed (if set, staff patron editor will allow a password to be associated with a value; this is mostly a hook for functionality to be implemented in the future. Does it mean we should keep it or the feature won't never be implemented and we can remove the 2 columns in DB? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 13:23:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 11:23:10 +0000 Subject: [Koha-bugs] [Bug 12267] Allow password option in Patron Attribute non functional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 13:25:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 11:25:16 +0000 Subject: [Koha-bugs] [Bug 12833] Patron search no longer searches extended attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12262 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 13:25:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 11:25:16 +0000 Subject: [Koha-bugs] [Bug 12262] Searching patrons by extended attribute should be a search field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12262 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12833 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 14:05:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 12:05:01 +0000 Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull down In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #4 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 14:07:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 12:07:12 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35826|0 |1 is obsolete| | Attachment #35827|0 |1 is obsolete| | Attachment #35828|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall --- Created attachment 38602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38602&action=edit Bug 12357 - Enhancements to RIS and BibTeX exporting Some libraries would like to be able to add arbitrary fields to both the RIS and BibTeX citation formats that a record can be saved as from the staff intranet and public catalog. In addition, they would like to be able to override the default record type and use Koha's itemtype as the record type for those formats as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add the following to the new syspref RisExportAdditionalFields: TY: 942$c LC: 010$a NT: [501$a, 505$g] 4) Find or create a record with an 010$a (lccn) field, a 501$a field, a 942$c field, and multiple 505$g fields. 5) Locate the record in the catalog, choose "Save" and select RIS 6) Inspect the downloaded file, note the replaced TY field, the LC field, and multiple NT fields 7) Add the following to the new syspref BibtexExportAdditionalFields: '@': 942$c lccn: 010$a notes: [501$a, 505$g] 9) Using the previously selected record, choose "Save" and select BIBTEX 10) Inspect the downloaded file, note the lccn, the multiple note fields, and the new record type value Signed-off-by: Frederic Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 14:14:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 12:14:21 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38595|0 |1 is obsolete| | --- Comment #4 from Mirko Tietgen --- Created attachment 38603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38603&action=edit Bug 14063 - Implement language overlay for authorised values This patch implements a language overlay for authorised values. To prepare tests - Have an installation with e.g. English, French and German languages - Set syspref 'suggestion' to: [Allow] patrons to make purchase suggestions on the OPAC. - Verify that you have a authorised values for OPAC_SUG (bestseller, damaged) - Open OPAC, log in, go to Purchase suggestions > Create a new suggesion - The dropdown "Reason for suggestion:" shows the authorised values from OPAC_SUG, e.g. "The copy on the shelf is damaged" and "Upcoming title by popular author" - Select German - The dropdown "Begr?ndung" shows the same (English) values. - Same with French - Open Intranet (Staff client) - Go to Home > Acquisitions > Suggestions management > New purchase suggestion - Switch between languages, the dropdown "Reason for suggestion" changes the label, but the values are not ranslated. - Same with the detail view of a suggestion To test: - In Staff client, go to Home > Administration > Authorized values - Add a new category OPAC_SUG-de-DE (add language code) - Create new translated values 'bestseller' and 'damaged' for this category. - Do the same for French (OPAC_SUG-fr-FR) or other installed languages - Go to OPAC > Purchase suggestions > Create a new suggesion - Switch between languages, the values in the dropdown 'Reason' should display in selected language - Got to Staff client > Home > Acquisitions > Suggestions management > New purchase suggestion - Switch between languages and verify that the values in the dropdown 'Reason' display in selected language - Display a suggestion's detail view, switch languages. Text for 'Reason' should change as appropriate. Bonus test: - Create language overlays e.g. for category 'DAMAGED' (DAMAGED-de-DE and DAMAGED-fr-FR), authorised values 0 -> 'No' and 1 -> 'Damaged' Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 14:14:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 12:14:43 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 14:29:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 12:29:26 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 --- Comment #40 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #39) > I have filed a separate 'blocker' bug 14069. Great job! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 14:41:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 12:41:46 +0000 Subject: [Koha-bugs] [Bug 14064] Implement language overlay for item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14064 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 14:58:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 12:58:18 +0000 Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding and format errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997 --- Comment #3 from Pablo AB --- Still there, Koha 3.18.06.000: $ yaz-marcdump shelf.iso2709 [ugly thing with ? and ?(Separator but not at end of field...?] $ yaz-iconv -f latin1 -t utf8 shelf.iso2709 > shelf.iso2709-utf $ yaz-marcdump shelf.iso2709-utf [Quod erat demonstrandum :P Expected result] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 15:00:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 13:00:02 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 15:00:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 13:00:06 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 --- Comment #37 from Kyle M Hall --- Created attachment 38604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38604&action=edit Bug 12357 [QA Followup] - Unit Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 15:20:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 13:20:21 +0000 Subject: [Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 15:20:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 13:20:24 +0000 Subject: [Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 --- Comment #1 from Jonathan Druart --- Created attachment 38605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38605&action=edit Bug 12253: Fix MARCUrls in basket At the OPAC and the intranet, the urls don't be displayed anymore. The variables used in the templates are not the good ones (MARCurlS vs MARCURLS). Test plan: 1/ On the intranet side, add some urls to some records 2/ Add these records to the basket 3/ Add records without urls defined 4/ Go on the basket view, click "more details" 5/ You should see the urls displayed 6/ Repeat steps 4-5 at the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 15:20:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 13:20:53 +0000 Subject: [Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 15:26:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 13:26:52 +0000 Subject: [Koha-bugs] [Bug 12235] Logs organized inconsistently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10680 CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 15:26:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 13:26:52 +0000 Subject: [Koha-bugs] [Bug 10680] "Modification log" gives wrong data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12235 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 15:32:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 13:32:07 +0000 Subject: [Koha-bugs] [Bug 12217] Funds not matching up In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jonathan.druart at biblibre.co | |m Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- Looks good here, please reopen with more details if it's still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 15:40:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 13:40:42 +0000 Subject: [Koha-bugs] [Bug 9117] Reports hierarchies management improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12213 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 15:40:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 13:40:42 +0000 Subject: [Koha-bugs] [Bug 12213] Creating a report with unnamed report group shows strange "disconnected" tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12213 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9117 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 16:13:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 14:13:06 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 16:13:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 14:13:09 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 --- Comment #1 from Jonathan Druart --- Created attachment 38606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38606&action=edit Bug 12204: Display the expiration date on RESERVESLIP If an expiration date is set on placing an item on hold, the date is not displayed on the reserve slip. It's only generated/displayed if the prefs ExpireReservesMaxPickUpDelay and ReservesMaxPickUpDelay are set. Test plan: 1/ Define RESERVESLIP with, at least, Hold until: <> 2/ Place an item on hold and define an expiration date 3/ Check the item in and print the slip 4/ Note that the expiration date is correctly displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 16:14:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 14:14:12 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |3.18 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Hello Barton, The expirationdate field was not retrieved from the DB before the slip generation, my patch fixes that. But the other fields should be displayed, I have just tested with reservenotes and it displayed correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 16:16:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 14:16:58 +0000 Subject: [Koha-bugs] [Bug 12203] can't print circ receipts in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12203 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- Tested with Chromium Version 40.0.2214.111 Works as expected. Please reopen if it's still broken for you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 16:41:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 14:41:34 +0000 Subject: [Koha-bugs] [Bug 14070] New: Notice not saved when mandatory fields are not filled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070 Bug ID: 14070 Summary: Notice not saved when mandatory fields are not filled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: - Enter a new text for a notice, don't fill the subject line - Save - a note is shown that not all mandatory fields have been filled in - Verify: You are kicked back to the overview page of notices, your changes have not been saved - Start again... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 16:41:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 14:41:39 +0000 Subject: [Koha-bugs] [Bug 14070] Notice not saved when mandatory fields are not filled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 16:45:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 14:45:38 +0000 Subject: [Koha-bugs] [Bug 14071] New: Preserve changes on XSLT files over upgrades Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14071 Bug ID: 14071 Summary: Preserve changes on XSLT files over upgrades Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org We have made some customizations to ?/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2OAIDC.xsl They are silently overwritten on every upgrade, which I avoid with dpkg-divert. Since there is more than 30 XSLTs on that folder a syspref solution might be hard. An easy solution maybe is, instead of overwriting ask the user what to do (stop the upgrade and wait the answer): Configuration file `/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2OAIDC.xsl' ==> Modified (by you or by a script) since installation. ==> Package distributor has shipped an updated version. [...] *** MARC21slim2OAIDC.xsl (Y/I/N/O/D/Z) [default=N] ? Marking them as conffiles as the others (dpkg --status koha-common). Or even always preserve conffiles. User can always overwrite with dpkg-reconfigure or sudo apt-get -o Dpkg::Options::="--force-confmiss" install --reinstall koha-common BTW, I don't know why this XSLT is on a LANG folder, since always use ?en? (bugs 4403 and 10292). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:06:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:06:38 +0000 Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:06:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:06:41 +0000 Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 --- Comment #2 from Jonathan Druart --- Created attachment 38607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38607&action=edit Bug 12178: Update serial status to "claimed" when exporting to CSV On the same way as late issues, the serial status should be updated to 'claimed' when the issues as exported as csv. QA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the same thing, I kick the second on off to centralize the code. Test plan: 1/ Export some late issues as CSV (serials/claims.pl). 2/ Refresh the page (the export does not do it) and confirm that the status, the claim date and the claim count have been updated. 3/ Select some others issues, select a notice and send the notification. Confirm that the behavior is the same. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:09:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:09:32 +0000 Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 --- Comment #3 from Jonathan Druart --- A promise is a promise -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:17:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:17:27 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 --- Comment #5 from Jonathan Druart --- (In reply to Marc V?ron from comment #4) > Created attachment 38520 [details] [review] > Try to find a modification that triggers an error in ModMember > (C4/Members.pm) Please detail :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:21:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:21:57 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Set ExportWithCsvProfile and the export column won't appear anymore with your patch. It's certainly related to this change: +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ -1,4 +1,4 @@ -[% USE Koha %] + Why did you remove that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:25:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:25:38 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:25:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:25:40 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38303|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 38608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38608&action=edit Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:30:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:30:47 +0000 Subject: [Koha-bugs] [Bug 14018] Ordering from suggestion shows 'copy. year:2014' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:30:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:30:50 +0000 Subject: [Koha-bugs] [Bug 14018] Ordering from suggestion shows 'copy. year:2014' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38172|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 38609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38609&action=edit Bug 14018 - Ordering from suggestion shows 'copy. year:2014' This patch fixes some minor display issues in 'Add order from a suggestion' To test: - Add order form a suggestion - The copyright date iss dispayed like 'copy.year:2015' - Apply patch - The copyright date now displays as (copyright sign) 2014, similar to the display in suggestion management Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:42:27 +0000 Subject: [Koha-bugs] [Bug 13838] Redirect to 'expired holds' tab after cancelling a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- The test plan works, but I am redirected to the Hold(s) over tab even if I deleted a waiting hold (first tab). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:44:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:44:06 +0000 Subject: [Koha-bugs] [Bug 14065] Typo in opac self registration form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:44:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:44:10 +0000 Subject: [Koha-bugs] [Bug 14065] Typo in opac self registration form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38545|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 38610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38610&action=edit Bug 14065 - Typo in opac self registration form The phrase Please type this following characters into the preceding box should be Please type the following characters into the preceding box Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 17:44:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 15:44:44 +0000 Subject: [Koha-bugs] [Bug 14065] Typo in opac self registration form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart --- Bypassing QA step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 18:51:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 16:51:19 +0000 Subject: [Koha-bugs] [Bug 14068] Bug 14055 breaks new package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14068 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38582|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 38611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38611&action=edit Bug 14068: fix preinst for fresh package installs Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 18:55:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 16:55:24 +0000 Subject: [Koha-bugs] [Bug 14068] Bug 14055 breaks new package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14068 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Signed Off --- Comment #3 from Mirko Tietgen --- I rolled a package of master+14068, used it to upgrade a 3.18.5 installation and did a fresh installation on another system. I did not encounter problems in the installation process nor display problems described on the mailing list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 19:19:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 17:19:01 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m, tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- Is anyone working on this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 19:19:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 17:19:12 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 19:19:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 17:19:20 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 20:06:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 18:06:56 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 --- Comment #112 from Tom?s Cohen Arazi --- FTR: - It doesn't need python-pisa :-D (this was removed at some point) - The new dependencies for this one are: * libhtml-tidy-perl * libgraphics-colornames-perl * libpdf-fromhtml-perl (build needed) * libpdf-writer-perl (build needed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 20:10:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 18:10:11 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Christopher Brannon --- (In reply to Jonathan Druart from comment #7) > Hi Christopher, > What does not work? I have tried again it seems to work. > Note that this patch does not modify the circulation.pl Turns out the patch is not applying. Please take a look at the patch when you can. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 20:38:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 18:38:24 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #16) > Created attachment 38216 [details] [review] > Bug 14022: Follow-up - rephrase erorr messages a little > > Rephrased error messages a little and changed the link to > look like it does on other pages, for example when looking > at an order created from a suggestion. > > Signed-off-by: Katrin Fischer Katrin, is the bug number on the patch subject wrong and this really belongs here? (it seems so, just over-checking) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 20:39:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 18:39:49 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 --- Comment #18 from Katrin Fischer --- No idea where i got the number from... can you please fix? The patch at least belongs here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 20:42:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 18:42:26 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #30 from Tom?s Cohen Arazi --- Guys, could you please change it so a user who is not used to the "us format" or the "german format" can know what the syspref actually does? I'll make it explicit just in case: Please provide a followup (SYSPREF DESCRIPTION ONLY) so it says something like: US format (Street N? - City - ...) German format (...) Thanks, looking forward to integrate this one ASAP. Also, there's one patch (the last two) that needs to be deprecated. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 20:50:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 18:50:38 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #3 from Christopher Brannon --- I think this patch is working. I definitely see differences. The problem is that with the table width being dynamic and not fixed to the width of the screen, it is very difficult to tell. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 20:56:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 18:56:59 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 20:57:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 18:57:01 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #4 from Christopher Brannon --- Created attachment 38612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38612&action=edit [SIGNED OFF] Bug 12135: Fix suggestions table width The trick to update the suggestions table width is outdated since jQuery UI has been updated. Test plan: 0/ Don't apply this patch 1/ Go on the suggestions page (suggestion/suggestion.pl), change tabs: the table width is wrong 2/ Apply this patch 4/ Repeat 1 and confirm the width is now updated. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 21:19:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 19:19:29 +0000 Subject: [Koha-bugs] [Bug 14072] New: Update German web installer for 3.20 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14072 Bug ID: 14072 Summary: Update German web installer for 3.20 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Update and translate the sql files of the German web installer for the next release 3.20. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 21:48:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 19:48:34 +0000 Subject: [Koha-bugs] [Bug 13919] Renewal possible with item level hold on item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 21:49:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 19:49:06 +0000 Subject: [Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 21:49:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 19:49:29 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #67 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 22:20:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 20:20:45 +0000 Subject: [Koha-bugs] [Bug 14073] New: HTML tags not working in database update message Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14073 Bug ID: 14073 Summary: HTML tags not working in database update message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Example: Upgrade to 3.19.00.027 done (Bug 4222: Nonpublic note not appearing in the staff client) Please check each of your frameworks to ensure your non-public item notes are mapped to items.itemnotes_nonpublic. After doing so please have your administrator run misc/batchRebuildItemsTables.pl ) will display like that, are escaped and not interpreted by the browser. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 22:35:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 20:35:52 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- Hi Marc, please also correct the 'Yes, Delete' and similar on those templates, so both messages match again. there are also some others, like: Delete this Currency (for yes). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 22:37:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 20:37:43 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 22:37:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 20:37:46 +0000 Subject: [Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38583|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 38613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38613&action=edit [PASSED QA] Bug 14056 - Small punctuation error in description for deleting a holiday This patch just inserts a semi-colon into the description so that it makes more grammatical sense. Test plan: 1) Go to Tools --> Calendar 2) Create or find a holiday, click on it so the editing options come up 3) Click on the question mark link to show the description for the option "Delete the exceptions on a range" 4) Confirm that this now has a semi-colon and reads "... Be careful about your scope range; if it is oversized you could slow down Koha." Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 22:49:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 20:49:06 +0000 Subject: [Koha-bugs] [Bug 14074] New: 'suggested on' date on suggestion list not correctly formatted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14074 Bug ID: 14074 Summary: 'suggested on' date on suggestion list not correctly formatted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org One of the dates (suggested on) in the list of suggestions in staff is not correctly formatted. To test: - Create one or many suggestions - Check the list of suggestion, especially in the 'Suggested by - on' column - Verify the date is not displayed according to the dateformat preference - Apply patch - Verify the problem is fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 22:50:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 20:50:52 +0000 Subject: [Koha-bugs] [Bug 14074] 'suggested on' date on suggestion list not correctly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14074 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 22:50:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 20:50:54 +0000 Subject: [Koha-bugs] [Bug 14074] 'suggested on' date on suggestion list not correctly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14074 --- Comment #1 from Katrin Fischer --- Created attachment 38614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38614&action=edit Bug 14074 - Format 'suggested on' date in suggestion list correctly One of the dates (suggested on) in the list of suggestions in staff is not correctly formatted. To test: - Create one or many suggestions - Check the list of suggestion, especially in the 'Suggested by - on' column - Verify the date is not displayed according to the dateformat preference - Apply patch - Verify the problem is fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 22:52:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 20:52:52 +0000 Subject: [Koha-bugs] [Bug 14018] Ordering from suggestion shows 'copy. year:2014' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 22:52:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 20:52:54 +0000 Subject: [Koha-bugs] [Bug 14018] Ordering from suggestion shows 'copy. year:2014' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38609|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 38615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38615&action=edit [PASSED QA] Bug 14018 - Ordering from suggestion shows 'copy. year:2014' This patch fixes some minor display issues in 'Add order from a suggestion' To test: - Add order form a suggestion - The copyright date iss dispayed like 'copy.year:2015' - Apply patch - The copyright date now displays as (copyright sign) 2014, similar to the display in suggestion management Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 23:08:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 21:08:45 +0000 Subject: [Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 23:08:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 21:08:48 +0000 Subject: [Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38462|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 38616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38616&action=edit [PASSED QA] Bug 11464: Prevent wrong "nothing to save" message on saving syspref Sometime you get the "Nothing to save" message when clicking on the "save all preferences" button, even if something has changed. On irritating behavior is the middle click: if you use the middle click to paste some text in the input, the "keyup" event won't be trigger. This patch replaces the "keyup" event with the "change", which works as we want here. The issues: 1/ Search for "wanted" (admin/preferences.pl?op=search&searchfield=wanted) Empty the input, click save Type something and remove it You are able to save, but nothing has changed 2/ Put something in your selection buffer and use the middle click to paste it in the input. No change detected. Test plan: Confirm the issues are fixed and you don't find any regression Note that now the "(modified)" string is displayed when the input loses the focus. Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 23:12:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 21:12:22 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #38567|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 23:12:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 21:12:47 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 23:16:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 21:16:03 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 23:16:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 21:16:06 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #5 from Katrin Fischer --- Created attachment 38617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38617&action=edit [PASSED QA] Bug 12135: Fix suggestions table width The trick to update the suggestions table width is outdated since jQuery UI has been updated. Test plan: 0/ Don't apply this patch 1/ Go on the suggestions page (suggestion/suggestion.pl), change tabs: the table width is wrong 2/ Apply this patch 4/ Repeat 1 and confirm the width is now updated. Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer The table sizes still vary slightly, but this is an improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 23:41:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 21:41:14 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20466|0 |1 is obsolete| | --- Comment #22 from M. Tompsett --- Comment on attachment 20466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20466 Bug 10625 - Inventory/Stocktaking tool cannot handle windows file uploads I think my patch is the way we are going. Obsoleting this. Feel free to unobsolete, as required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 23:44:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 21:44:05 +0000 Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 38618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38618&action=edit Bug 12192: Template toolkit code in HTML attributes is picked up into po-files This patch gives a partial solution for this problem. It ignores strings like "[% something %]", but not "[% IF ( value ) %][% value %][% END %]" We get 100+ strings less to translate To test: 1) Update translation files for your preferred language 2) Apply the patch 3) Update again 4) Compare, you must find 100+ strings removed from translation files eg. -msgid "[% SEARCH_RESULT.biblionumber |url %]" -msgid "[% accepteddate | $KohaDates %]" -msgid "[% amountoutstanding | format('%.2f') %]" -msgid "[% authtypetext |html %]" -msgid "[% barcode_llx |html %]" -msgid "[% barcode_lly |html %]" -msgid "[% biblio.quantity.length ? biblio.quantity : 1 %]" -msgid "[% billingdate | $KohaDates %]" -msgid "[% borname |html %]" ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 28 23:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 21:45:42 +0000 Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 01:11:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 Apr 2015 23:11:49 +0000 Subject: [Koha-bugs] [Bug 14071] Preserve changes on XSLT files over upgrades In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14071 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 03:43:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 01:43:06 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 03:43:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 01:43:08 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38078|0 |1 is obsolete| | --- Comment #14 from Winona Salesky --- Created attachment 38619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38619&action=edit Bug 13387 - Uniform titles (130 / 240 / 730) Display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 130/240/730 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Fields show subfields a,d,f,g,h,k,l,m,n,o,p,r,s,t with multiple fields separated by span class=separator | 7) Repeat steps 4 - 6 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 04:12:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 02:12:41 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37218|0 |1 is obsolete| | --- Comment #14 from Winona Salesky --- Created attachment 38620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38620&action=edit Bug 13734 - RDA: Display 33xs Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 336,337,338 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Adds fields 336, 337 and 338 to staff and opac details. Adds comma between multiple subfields and | with class='separator' between multiple datafields (e.g. two 336 fields) 7) Repeat steps 4 - 6 for the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 04:12:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 02:12:39 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 04:18:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 02:18:20 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 04:18:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 02:18:22 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38525|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 38621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38621&action=edit Bug 14057 - A Rough Start This patch is a rough start. I believe it runs exponentially faster, but its equality to the previous version needs to be tested before I clean it up to acceptable standards. Nested hashes of hashes was being a debugging nightmare. Moved the SQL select to C4::Koha. Changed the GetItemsForInventory to have a hashref parameter. Added interface, in case there is a need for 'opac' vs. 'staff'. Added t/db_dependent/Items/GetItemsForInventory.t Added t/db_dependent/Koha/GetKohaAuthorisedValuesMapping.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 04:22:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 02:22:00 +0000 Subject: [Koha-bugs] [Bug 13109] Serial failure for received and general viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mason! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 05:12:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 03:12:39 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38621|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 38622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38622&action=edit Bug 14057 - A Rough Start This patch is a rough start. I believe it runs exponentially faster, but its equality to the previous version needs to be tested before I clean it up to acceptable standards. Nested hashes of hashes was being a debugging nightmare. Moved the SQL select to C4::Koha. Changed the GetItemsForInventory to have a hashref parameter. Added interface, in case there is a need for 'opac' vs. 'staff'. Added t/db_dependent/Items/GetItemsForInventory.t Added t/db_dependent/Koha/GetKohaAuthorisedValuesMapping.t I see what you mean about opac vs. staff now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 05:16:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 03:16:47 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 --- Comment #17 from M. Tompsett --- I'm up'ing the priority, since I have seen a user run inventory 4 times unfiltered, and it blew up their low-memory (1GB RAM) system with just 80MB of Koha DB. If dcook, mveron, or perhaps anyone else could look at this one more time, I'll submit a patch for sign off if there is no feedback in 48 hours. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 05:51:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 03:51:31 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38187|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 05:55:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 03:55:08 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37671|0 |1 is obsolete| | --- Comment #31 from Marc V?ron --- Created attachment 38623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38623&action=edit [PASSED QA] Bug 4041 [QA Followup] - Change addressformat to AddressFormat Signed-off-by: Kyle M Hall ---- Amended to resolve conflict in sysprefs.sql / mveron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 05:58:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 03:58:08 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37670|0 |1 is obsolete| | --- Comment #32 from Marc V?ron --- Comment on attachment 37670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37670 [PASSED QA] Bug 4041 [QA Followup] Replaced by amended version to make it apply -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 06:04:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 04:04:46 +0000 Subject: [Koha-bugs] [Bug 14075] New: Undefined value creates noisy warns in C4::AuthoritiesMarc Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Bug ID: 14075 Summary: Undefined value creates noisy warns in C4::AuthoritiesMarc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org If sortby is not set and left as undefined, there are a bunch of noisy errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 06:11:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 04:11:01 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #18 from M. Tompsett --- I know there is no test plan, but if someone wishes to test it and sign it off with no test plan, why not? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 06:12:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 04:12:10 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 --- Comment #1 from Aleisha Amohia --- Created attachment 38624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38624&action=edit Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 06:13:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 04:13:30 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 06:23:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 04:23:57 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 --- Comment #33 from Marc V?ron --- Created attachment 38625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38625&action=edit [Follow-up] Bug 4041 - Explain address format style in system preferences See comment #30 by Tom?s Cohen Arazi -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 06:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 04:54:26 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #3 from M. Tompsett --- Comment on attachment 38568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38568 Bug 14053 - Acquisition db tables are missing indexes Review of attachment 38568: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14053&attachment=38568) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +2934,5 @@ > + KEY `budget_parent_id` (`budget_parent_id`), > + KEY `budget_code` (`budget_code`), > + KEY `budget_branchcode` (`budget_branchcode`), > + KEY `budget_period_id` (`budget_period_id`), > + KEY `budget_owner_id` (`budget_owner_id`), I believe this trailing comma is an issue. I dropped koha_library. created it. then run web install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 06:54:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 04:54:34 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 06:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 04:55:27 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #4 from M. Tompsett --- Comment on attachment 38569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38569 Bug 14053 - Acquisition db tables are missing indexes - atomicupdates Review of attachment 38569: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14053&attachment=38569) ----------------------------------------------------------------- Atomic updates worked fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 06:59:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 04:59:48 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 --- Comment #2 from M. Tompsett --- Comment on attachment 38624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38624 Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc Review of attachment 38624: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14075&attachment=38624) ----------------------------------------------------------------- ::: C4/AuthoritiesMarc.pm @@ +18,4 @@ > > use strict; > use warnings; > +use lib '.'; Why this addition? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:02:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:02:38 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 --- Comment #3 from Aleisha Amohia --- (In reply to M. Tompsett from comment #2) > Comment on attachment 38624 [details] [review] > Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc > > Review of attachment 38624 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/AuthoritiesMarc.pm > @@ +18,4 @@ > > > > use strict; > > use warnings; > > +use lib '.'; > > Why this addition? Oops forgot to take that out when I was experimenting earlier! My bad -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:04:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:04:58 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38624|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 38626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38626&action=edit Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:22:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:22:34 +0000 Subject: [Koha-bugs] [Bug 14076] New: Noisy warns in opac-authorities-home.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 Bug ID: 14076 Summary: Noisy warns in opac-authorities-home.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org While testing bug 14075, I noticed other noisy errors in my log file. Please look into conversion of the $query->param(...) stuff starting around line 62 into the use of $query->multi_param(...) equivalents. [Wed Apr 29 01:03:03.943951 2015] [cgi:error] [pid 1930] [client 192.168.45.37:57137] AH01215: [Wed Apr 29 01:03:03 2015] opac-authorities-home.pl: CGI::param called in list context from package main line 62, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. [Wed Apr 29 01:03:03.944202 2015] [cgi:error] [pid 1930] [client 192.168.45.37:57137] AH01215: [Wed Apr 29 01:03:03 2015] opac-authorities-home.pl: CGI::param called in list context from package main line 63, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. [Wed Apr 29 01:03:03.944471 2015] [cgi:error] [pid 1930] [client 192.168.45.37:57137] AH01215: [Wed Apr 29 01:03:03 2015] opac-authorities-home.pl: CGI::param called in list context from package main line 64, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. [Wed Apr 29 01:03:03.944604 2015] [cgi:error] [pid 1930] [client 192.168.45.37:57137] AH01215: [Wed Apr 29 01:03:03 2015] opac-authorities-home.pl: CGI::param called in list context from package main line 65, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:22:55 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:23:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:23:23 +0000 Subject: [Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14075 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:23:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:23:23 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14076 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:24:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:24:38 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 --- Comment #5 from M. Tompsett --- Comment on attachment 38626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38626 Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc Review of attachment 38626: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14075&attachment=38626) ----------------------------------------------------------------- ::: C4/AuthoritiesMarc.pm @@ -18,4 @@ > > use strict; > use warnings; > -use lib '.'; Now you lost your change, because you obsoleted the other patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:25:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:25:19 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #38624|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:27:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:27:53 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 --- Comment #6 from Aleisha Amohia --- (In reply to M. Tompsett from comment #5) > Comment on attachment 38626 [details] [review] > Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc > > Review of attachment 38626 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/AuthoritiesMarc.pm > @@ -18,4 @@ > > > > use strict; > > use warnings; > > -use lib '.'; > > Now you lost your change, because you obsoleted the other patch. Of course oops my mistake again,thanks for fixing that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:28:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:28:03 +0000 Subject: [Koha-bugs] [Bug 13932] Allow a header to be considered trusted to provide the userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13932 --- Comment #2 from Robin Sheat --- Created attachment 38627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38627&action=edit Bug 13932: unset userenv when using trusted header As the trusted header system doesn't keep a session hanging around, when running with plack it can end up with the userenv of another user, which is bad. So this clears it forcing it to be recreated cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:29:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:29:11 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:29:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:29:13 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38624|0 |1 is obsolete| | Attachment #38626|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 38628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38628&action=edit Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log Signed-off-by: Mark Tompsett NOTE: I would have done $sortby //= ''; But this works too. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:33:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:33:49 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38469|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 38629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38629&action=edit Bug 13910 - Prevent delete of one's own patron account This patch adds a check to prevent deleting the user's own account. Additionali it fixes a "missing link" in moremember.pl and wrong comparisions in moremember.tt regarding other forbidden deleting. To test: - Apply patch - Create a user with sufficient privileges to delete users - Log in as this new user - Try to delete this user. Confirm message box "Are you sure..." - Confirm that you get a message "Not allowed to delete own account" and that the user still exists. Bonus test: Try to trigger other forbidden deletions (see members/deletemem.pl): 'CANT_DELETE_STAFF', 'CANT_DELETE_OTHERLIBRARY', 'CANT_DELETE' (You can fake it by using an URL like: /cgi-bin/koha/members/moremember.pl?borrowernumber=115&error=CANT_DELETE_STAFF etc.) Without patch, no message appears. With patch, messages appear as appropriate. --- Amended to restore accidentally removed line in moremember.tt, see comment #3 /mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:34:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:34:33 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:34:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:34:56 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer --- I am sorry, but I can't reproduce the problem on current master. I tried with an irregular subscription that will leave planneddate and publisheddateempty and I manually changed the database values to 0000-00-00 for both. Please include a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:43:17 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:43:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:43:20 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38511|0 |1 is obsolete| | Attachment #38512|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 38630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38630&action=edit [PASSED QA] Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:43:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:43:34 +0000 Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #13 from Katrin Fischer --- Created attachment 38631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38631&action=edit [PASSED QA] Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:52:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:52:47 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- I am sorry, but this doesn't seem to work correctly: Without patch: - Search for something - From the result list, click on any record - Verify the result browser is shown on the left With patch: - Search for the same something as above - From result list, click on the same record - Verify the result browser is missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:59:50 +0000 Subject: [Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 07:59:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 05:59:53 +0000 Subject: [Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38463|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 38632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38632&action=edit [PASSED QA] Bug 14006: about.pl checks the wrong zebra index mode When setting zebra_bib_index_mode to grs1 I get two warnings when not applying the patch: "The entry is set to grs1. GRS-1 support is now deprecated and will be removed in future releases. Please use DOM instead by setting to dom (full reindex required)." "You have set but the is not set to dom. Falling back to legacy facet calculation." When applying the patch a third warning appears in addition to the two previous ones: "The entry is set to dom, but your system still appears to be set up for grs1 indexing." Seems like the patch does what it should to me regarding the configuration mismatch warning. Signed-off-by: Eivin Giske Skaaren Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:05:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:05:02 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38608|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 38633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38633&action=edit Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Signed-off-by: Jonathan Druart --- Amended to replace more strings, see comment #6 / mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:07:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:07:50 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #9 from Katrin Fischer --- I have started testing this - is there a way we could have the 'print preview' match what is actually going to be printed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:10:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:10:13 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:21:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:21:26 +0000 Subject: [Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:21:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:21:28 +0000 Subject: [Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38605|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 38634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38634&action=edit Bug 12253: Fix MARCUrls in basket At the OPAC and the intranet, the urls don't be displayed anymore. The variables used in the templates are not the good ones (MARCurlS vs MARCURLS). Test plan: 1/ On the intranet side, add some urls to some records 2/ Add these records to the basket 3/ Add records without urls defined 4/ Go on the basket view, click "more details" 5/ You should see the urls displayed 6/ Repeat steps 4-5 at the OPAC Signed-off-by: Mark Tompsett NOTE: 856$u displays now in intranet and OPAC. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:27:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:27:24 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #10 from Marc V?ron --- (In reply to Katrin Fischer from comment #9) > I have started testing this - is there a way we could have the 'print > preview' match what is actually going to be printed? I think there is now way to trigger the print preview from JavaScript, because the print preview is part of the browser. One workaround could be to create a separate page for printing, but that would be a different approach (and not a real print preview). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:32:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:32:52 +0000 Subject: [Koha-bugs] [Bug 12109] Authority subfield configuration page for controlled fields is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:32:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:32:54 +0000 Subject: [Koha-bugs] [Bug 12109] Authority subfield configuration page for controlled fields is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38570|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 38635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38635&action=edit Bug 12109: Fix tab on the auth subfield configuration page There is a condition in the template to not display the "New" tab if the user is editing a control field. But it results in a broken template. Looking at the biblio frameworks, the New tab exists even for control fields. This patch only fixes the html structure, but a complete fix should be provide, for auth and biblio, if we want not to let the ability to create subfields for control fields. Test plan: Edit subfields for a control field (admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance) and confirm that the view is now fixed. Signed-off-by: Mark Tompsett NOTE: Checked LDR, 001, and 008. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:50:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:50:07 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 --- Comment #19 from Marc V?ron --- Created attachment 38636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38636&action=edit [Signed-off] Bug 14057 - A Rough Start This patch is a rough start. I believe it runs exponentially faster, but its equality to the previous version needs to be tested before I clean it up to acceptable standards. Nested hashes of hashes was being a debugging nightmare. Moved the SQL select to C4::Koha. Changed the GetItemsForInventory to have a hashref parameter. Added interface, in case there is a need for 'opac' vs. 'staff'. Added t/db_dependent/Items/GetItemsForInventory.t Added t/db_dependent/Koha/GetKohaAuthorisedValuesMapping.t --- How I tested: - Apply patch - Do some full and some filtered Inventories, behaviour is the same (but faster as without patch) - Run both tests Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:50:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:50:34 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38622|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 08:51:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 06:51:05 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:08:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:08:58 +0000 Subject: [Koha-bugs] [Bug 12135] Pending suggestions table width is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135 --- Comment #6 from Jonathan Druart --- (In reply to Christopher Brannon from comment #3) > I think this patch is working. I definitely see differences. The problem > is that with the table width being dynamic and not fixed to the width of the > screen, it is very difficult to tell. (In reply to Katrin Fischer from comment #5) > Signed-off-by: Katrin Fischer > The table sizes still vary slightly, but this is an improvement. Yes, it's how it is supposed to behave. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:18:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:18:29 +0000 Subject: [Koha-bugs] [Bug 14074] 'suggested on' date on suggestion list not correctly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14074 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:18:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:18:32 +0000 Subject: [Koha-bugs] [Bug 14074] 'suggested on' date on suggestion list not correctly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14074 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38614|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 38637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38637&action=edit Bug 14074 - Format 'suggested on' date in suggestion list correctly One of the dates (suggested on) in the list of suggestions in staff is not correctly formatted. To test: - Create one or many suggestions - Check the list of suggestion, especially in the 'Suggested by - on' column - Verify the date is not displayed according to the dateformat preference - Apply patch - Verify the problem is fixed Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:35:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:35:19 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38629|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 38638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38638&action=edit Bug 13910 - Prevent delete of one's own patron account This patch adds a check to prevent deleting the user's own account. Additionali it fixes a "missing link" in moremember.pl and wrong comparisions in moremember.tt regarding other forbidden deleting. To test: - Apply patch - Create a user with sufficient privileges to delete users - Log in as this new user - Try to delete this user. Confirm message box "Are you sure..." - Confirm that you get a message "Not allowed to delete own account" and that the user still exists. Bonus test: Try to trigger other forbidden deletions (see members/deletemem.pl): 'CANT_DELETE_STAFF', 'CANT_DELETE_OTHERLIBRARY', 'CANT_DELETE' (You can fake it by using an URL like: /cgi-bin/koha/members/moremember.pl?borrowernumber=115&error=CANT_DELETE_STAFF etc.) Without patch, no message appears. With patch, messages appear as appropriate. Signed-off-by: Mark Tompsett NOTE: Attempted all CANT combinations. From reading the code, this is kind of an important patch, because I'm not sure deleting error messages work at all right now based on what I read. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:35:17 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:36:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:36:36 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #68 from Jonathan Druart --- Created attachment 38639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38639&action=edit Revert "Bug 8992: Use the existing greybox plugin in interface/theme" This reverts commit 986b03e1c602b057275e343e3251a5cfbcc7cca6. Tomas, due to bug 12101, this commit should be reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:46:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:46:58 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:47:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:47:01 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #8 from Jonathan Druart --- Created attachment 38640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38640&action=edit Bug 11890: Prevent default on click event It seems that the previous patch does not stop the propagation of the event if the link is clicked with the left button (which=1). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:48:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:48:13 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > I am sorry, but this doesn't seem to work correctly: > > Without patch: > - Search for something > - From the result list, click on any record > - Verify the result browser is shown on the left > > With patch: > - Search for the same something as above > - From result list, click on the same record > - Verify the result browser is missing Good to have a QA step :) Sorry about that, I am sure I tested this case, the trivial one! (but it seems not with this code...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:51:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:51:40 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 09:51:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 07:51:43 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38542|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 38641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38641&action=edit Bug 14044: Escape json strings for patron searches In a couple of patron searches, the address is displayed. If the address contain invalid json characters, DataTables won't manage to parse the results and display them. This patch makes the templates more readable by creating a BLOCK instead of a long line and escape the invalid json characters calling the TT plugin (To.json). Test plan: Edit a patron and add something like: patron
    \123 ? ? in the address field. Search for this patron using the main patron search (members/member.pl) and the guarantor search. Confirm that a result with this patron is correctly displayed. Regression test: Since Koha::Template::Plugin::To::json is modified, confirm that the add users to basket search (on acqui/basket.pl?basketno=X click on the "Add user" button) still works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:00:43 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:00:45 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38520|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 38642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38642&action=edit Bug 11929 - patron modification error shows borrowernumber If an error occurs in patron batch modification, a message similar to the following is displayed: Can not update patron with borrowernumber 7055 It would be useful to have the cardnumber as well. This patch adds the card number to the lists of errors. It is not easy to trigger an error (see comments). For testing, I tweaked the sub ModMember in C4/Members.pm to always return false. TEST PLAN --------- 1) Log in as a superlibrarian and create a test user 2) Change the cardnumber to a number differing from the borrower number. 3) Home -> Tools -> Batch patron modification 4) Type in the cardnumber of that test user 5) Check the Library checkbox. 6) Click Save -- nice error, but it is only the card number. 7) Apply the patch 8) Repeat steps 3-6 -- nice error, but it is now more informative. 9) run koha qa test tools. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:02:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:02:19 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38642|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 38643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38643&action=edit Bug 11929 - patron modification error shows borrowernumber If an error occurs in patron batch modification, a message similar to the following is displayed: Can not update patron with borrowernumber 7055 It would be useful to have the cardnumber as well. This patch adds the card number to the lists of errors. It is not easy to trigger an error (see comments). For testing, I tweaked the sub ModMember in C4/Members.pm to always return false. TEST PLAN --------- 1) Log in as a superlibrarian and create a test user 2) Change the cardnumber to a number differing from the borrower number. 3) Home -> Tools -> Batch patron modification 4) Type in the cardnumber of that test user 5) Check the Library checkbox. 6) Click Save -- nice error, but it is borrower number instead of the card number which was entered. 7) Apply the patch 8) Repeat steps 3-6 -- nice error, but it is now more informative. 9) run koha qa test tools. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:02:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:02:27 +0000 Subject: [Koha-bugs] [Bug 11997] Download / export lists of records coding and format errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11997 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |3.18 --- Comment #4 from Jonathan Druart --- Pablo, Bug 11944 has been pushed to master and will be in Koha 3.20. I can confirm you this bug is fixed on the master branch (tested right now). I don't plan to provide patches for encoding related issues on the branches without patches from bug 11944. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:20:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:20:08 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 --- Comment #2 from Jonathan Druart --- Created attachment 38644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38644&action=edit Bug 14069: Drop existing primary key on items if exists On old databases, the issues table has a primary key on itemnumber. The DBrev 3.19.00.028 (Bug 13790 - Add unique id issue_id to issues and oldissues tables) has to remove it before adding the new primary key Test plan: 1/ Make sure you have an old DB, or add primary key (issues.itemnumber)manually on a DB created before 3.19.00.028. 2/ Execute the updatedatabase.pl script 3/ You should not get any error and the primary key on itemnumber should have been removed and the new one created as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:20:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:20:05 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:20:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:20:23 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:33:22 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 --- Comment #6 from Jonathan Druart --- Comment on attachment 38638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38638 Bug 13910 - Prevent delete of one's own patron account Review of attachment 38638: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13910&attachment=38638) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ +144,3 @@ > [% IF ( error ) %] >
    > + [% IF ( error == 'AUTH_UPDATE_FAILED' ) %] I don't manager to trigger this one. Looking at the code, it is never set. I would prefer not to see this one changed in this bug report but remove in its own bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:38:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:38:04 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:38:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:38:06 +0000 Subject: [Koha-bugs] [Bug 11929] patron modification error shows borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38643|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 38645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38645&action=edit Bug 11929 - patron modification error shows borrowernumber If an error occurs in patron batch modification, a message similar to the following is displayed: Can not update patron with borrowernumber 7055 It would be useful to have the cardnumber as well. This patch adds the card number to the lists of errors. It is not easy to trigger an error (see comments). For testing, I tweaked the sub ModMember in C4/Members.pm to always return false. TEST PLAN --------- 1) Log in as a superlibrarian and create a test user 2) Change the cardnumber to a number differing from the borrower number. 3) Home -> Tools -> Batch patron modification 4) Type in the cardnumber of that test user 5) Check the Library checkbox. 6) Click Save -- nice error, but it is borrower number instead of the card number which was entered. 7) Apply the patch 8) Repeat steps 3-6 -- nice error, but it is now more informative. 9) run koha qa test tools. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:43:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:43:57 +0000 Subject: [Koha-bugs] [Bug 906] ISBN Check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906 --- Comment #14 from M. Tompsett --- Having encountered horrific ISBN problems a while back, I get the feeling that warning people about bad ISBNs is the best we should do, because sometimes companies use invalid ISBNs. Anyone going to follow up on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:45:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:45:20 +0000 Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:45:42 +0000 Subject: [Koha-bugs] [Bug 11790] C4::Charset should not depend on C4::Context In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:52:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:52:46 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #17 from M. Tompsett --- Please see the test plan in comment #12, Katrin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:53:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:53:26 +0000 Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:53:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:53:28 +0000 Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38618|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 38646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38646&action=edit Bug 12192: Template toolkit code in HTML attributes is picked up into po-files This patch gives a partial solution for this problem. It ignores strings like "[% something %]", but not "[% IF ( value ) %][% value %][% END %]" We get 100+ strings less to translate To test: 1) Update translation files for your preferred language 2) Apply the patch 3) Update again 4) Compare, you must find 100+ strings removed from translation files eg. -msgid "[% SEARCH_RESULT.biblionumber |url %]" -msgid "[% accepteddate | $KohaDates %]" -msgid "[% amountoutstanding | format('%.2f') %]" -msgid "[% authtypetext |html %]" -msgid "[% barcode_llx |html %]" -msgid "[% barcode_lly |html %]" -msgid "[% biblio.quantity.length ? biblio.quantity : 1 %]" -msgid "[% billingdate | $KohaDates %]" -msgid "[% borname |html %]" ... Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 10:55:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 08:55:37 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #18 from Katrin Fischer --- Mark, this is what I did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:02:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:02:15 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Untranslatable strings in |Unused code in |serials-edit.tt and |serials-edit.tt and |serials-recieve.tt |serials-recieve.tt CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:04:40 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:04:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:04:36 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #19 from M. Tompsett --- mtompset at debian:~/kohaclone$ git reset --hard origin/master HEAD is now at 381959a Bug 13109: Serial failure for received and general viewin g. mtompset at debian:~/kohaclone$ git bz apply 14036 Bug 14036 - "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail 38467 - Bug 14036 - GetNextDate.t lacking test cases. 38468 - Bug 14036: "Date::Calc::Add_Delta_YM(): not a valid date" error when acc essing subscription detail Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 14036 - GetNextDate.t lacking test cases. mtompset at debian:~/kohaclone$ prove -v t/db_dependent/Serials/GetNextDate.t t/db_dependent/Serials/GetNextDate.t .. 1..88 Date::Calc::Delta_Days(): not a valid date at /home/mtompset/kohaclone/C4/Serial s.pm line 2345. # Looks like your test exited with 255 before it could output anything. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 88/88 subtests Test Summary Report ------------------- t/db_dependent/Serials/GetNextDate.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 88 tests but ran 0. Files=1, Tests=0, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.31 cusr 0.05 csys = 0.38 CPU) Result: FAIL mtompset at debian:~/kohaclone$ git bz apply 14036 Bug 14036 - "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail 38467 - Bug 14036 - GetNextDate.t lacking test cases. 38468 - Bug 14036: "Date::Calc::Add_Delta_YM(): not a valid date" error when acc essing subscription detail Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 14036: "Date::Calc::Add_Delta_YM(): not a valid date" error when a ccessing subscription detail mtompset at debian:~/kohaclone$ prove -v t/db_dependent/Serials/GetNextDate.t t/db_dependent/Serials/GetNextDate.t .. 1..88 ok 1 - 0000-00-00 is an expected undef date. ok 2 - 9999-99-99 is an expected undef date. [SNIP] ok 88 ok All tests successful. Files=1, Tests=88, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.37 cusr 0.00 csy s = 0.39 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:04:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:04:44 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37435|0 |1 is obsolete| | Attachment #38508|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 38647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38647&action=edit Bug 13423: Remove unused JS function in serials-edit.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected NOTE: I did not run this test plan. Verification steps ------------------ 1. Find out where barcode_check is used. $ git grep barcode_check -- This is only in serials-edit.tt and serials-receive.tt 2. This patch only affects serials-edit.tt, so check who put the $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- note the commit related number. 3. Check out the commit. $ git show 77b64098 -- should show bug 5917, but the patches on bugzilla don't have the change nicely, so... 4. Hunt through the pages to find the change. -- Note: it is part of a "new file" diff! 5. Since this code hasn't been running since it was added... 6. apply the patch 7. run koha-qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:04:48 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #14 from Jonathan Druart --- Created attachment 38648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38648&action=edit Bug 13423: Remove unused serials-recieve This patch removes two files, serials-recieve.pl and serial-recieve.tt serials-recieve.pl is not called anyware (it's recieve!) Also removes the sub removeMissingIssue called only from serials-recieve.pl git grep serials-recieve.pl . C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl file koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: serials/serials-recieve.pl:serials-recieve.pl Just a POD entry and self reference. After removing of files git grep removeMissingIssue . C4/Serials.pm: &check_routing &updateClaim &removeMissingIssue C4/Serials.pm:=head2 removeMissingIssue C4/Serials.pm:removeMissingIssue($subscriptionid) C4/Serials.pm:sub removeMissingIssue { t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test removing a missing issue'); Not used anymore To test: 1) Apply the patch 2) Check serials workflow, no changes must be noted Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:04:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:04:52 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #15 from Jonathan Druart --- Created attachment 38649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38649&action=edit Bug 13423: Fix number of tests in Serials.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:05:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:05:21 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #16 from Jonathan Druart --- I took the liberty to edit the commit message of the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:20:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:20:48 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 --- Comment #7 from Marc V?ron --- Created attachment 38650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38650&action=edit [Follow-up] Bug 13910 - Line with AUTH_UPDATE_FAILED restored As of comment #6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:23:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:23:09 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- (In reply to Marc V?ron from comment #2) > I can not trigger the error after test plan #2 (without patch). Marc, Have you gone to the last step "Save your custom report"? Give a name to the report and click "save report". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:23:17 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:23:27 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:25:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:25:09 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #20 from M. Tompsett --- BTW, I have no subscriptions before testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:25:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:25:20 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Zeno, same code is used in cataloguing/z3950_search.pl, you need to copy/paste your change. (That's exactly why I did not want to see DBIx::Class queries in pl files...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:26:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:26:17 +0000 Subject: [Koha-bugs] [Bug 14047] Sort z39.50 biblio servers by rank in derivate cataloguing doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14047 --- Comment #3 from Jonathan Druart --- I meant acqui/z3950_search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:30:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:30:42 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #21 from Katrin Fischer --- Can you still reproduce the issue in the GUI on current master? What does your entry in subscription and serial look like? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:30:43 +0000 Subject: [Koha-bugs] [Bug 14077] New: Remove unused AUTH_UPDATE_FAILED from moremember.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Bug ID: 14077 Summary: Remove unused AUTH_UPDATE_FAILED from moremember.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com 'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910). To verify: git grep 'AUTH_UPDATE_FAILED' Result: Only one occurence (in moremember.tt) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:31:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:31:13 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38638|0 |1 is obsolete| | Attachment #38650|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 38651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38651&action=edit Bug 13910 - Prevent delete of one's own patron account This patch adds a check to prevent deleting the user's own account. Additionali it fixes a "missing link" in moremember.pl and wrong comparisions in moremember.tt regarding other forbidden deleting. To test: - Apply patch - Create a user with sufficient privileges to delete users - Log in as this new user - Try to delete this user. Confirm message box "Are you sure..." - Confirm that you get a message "Not allowed to delete own account" and that the user still exists. Bonus test: Try to trigger other forbidden deletions (see members/deletemem.pl): 'CANT_DELETE_STAFF', 'CANT_DELETE_OTHERLIBRARY', 'CANT_DELETE' (You can fake it by using an URL like: /cgi-bin/koha/members/moremember.pl?borrowernumber=115&error=CANT_DELETE_STAFF etc.) Without patch, no message appears. With patch, messages appear as appropriate. Signed-off-by: Mark Tompsett NOTE: Attempted all CANT combinations. From reading the code, this is kind of an important patch, because I'm not sure deleting error messages work at all right now based on what I read. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:31:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:31:21 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 --- Comment #9 from Jonathan Druart --- Created attachment 38652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38652&action=edit Bug 13910 - Line with AUTH_UPDATE_FAILED restored As of comment #6 Signed-off-by: Jonathan Druart This should be fixed in a separate patch, this error is not sent to the template and the related code could be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:31:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:31:33 +0000 Subject: [Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13910 Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:31:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:31:33 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14077 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:36:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:36:18 +0000 Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Jonathan Druart --- 1/ The change should be done for all languages. 2/ I also think it could be better to name the column, to prevent further changes to this table (add new column?) Marked as Failed QA for 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:36:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:36:35 +0000 Subject: [Koha-bugs] [Bug 10938] item columns in different order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10938 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:39:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:39:25 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #22 from M. Tompsett --- (In reply to Katrin Fischer from comment #21) > Can you still reproduce the issue in the GUI on current master? > What does your entry in subscription and serial look like? I will attempt to replicate it in the interface later, but I did not use the interface in my testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:40:07 +0000 Subject: [Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 --- Comment #1 from Marc V?ron --- Created attachment 38653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38653&action=edit Bug 14077 - Remove unused AUTH_UPDATE_FAILED from moremember.tt 'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910). To verify: git grep 'AUTH_UPDATE_FAILED' Result: Only one occurence (in moremember.tt) Test plan: - Apply patch (on top of Bug 13910) - Verify that the part with AUTH_UPDATE_FAILED is removed from moremember.tt - Go to a patron's detail page and verify that nothing is broken (Home > Patrons > Patrons details for...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:41:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:41:30 +0000 Subject: [Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13910 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:41:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:41:30 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14077 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 11:47:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 09:47:08 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 --- Comment #9 from Jonathan Druart --- Comment on attachment 37978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37978 Bug 13993 - (2) Correct poorly transferred orders Review of attachment 37978: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13993&attachment=37978) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/Bug-13993-Correct-OrderStatus-Of-Poorly-Transferred-Orders.sql @@ +1,2 @@ > +UPDATE aqorders SET orderstatus='cancelled' > + WHERE (NOT datecancellationprinted IS NULL OR The correct syntax is field is not null -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:03:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:03:11 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 --- Comment #4 from Marc V?ron --- Testing (without patch) Home > Reports > Guided reports wizard Button [Bulid new] Step 1: Choose Circulaton , Not public Step 2: Report type Tabular Step 3: Choose some columns from Biblioitems and add them Step 4: Check "Koha itemtype" (BK), Check Type (issue) Step 5: Check items.itemnumber and set to 'count' Step 6: Check items.itemnumber (asc) Finish Save as... Testreport-Bug10976 Report OK (see comment #3) Run this report -> Get table on screen Download as Comma separated text -> Download OK What do I miss? :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:05:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:05:14 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 --- Comment #10 from Marc V?ron --- (In reply to Jonathan Druart from comment #9) (...) > This should be fixed in a separate patch, this error is not sent to the > template and the related code could be removed. See Bug 14077 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:08:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:08:12 +0000 Subject: [Koha-bugs] [Bug 14001] Inventory is not plack friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Mark, I don't manage to recreate the error. I would say the patch is correct, but there is certainly another issue, even without Plack: the $_ (l. ~297) equals {} and does not contain the item data. It would be good to highlight this problem in the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:08:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:08:25 +0000 Subject: [Koha-bugs] [Bug 14001] Inventory is not plack friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14001 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:12:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:12:28 +0000 Subject: [Koha-bugs] [Bug 14078] New: converting from ISO5426 is not complete Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Bug ID: 14078 Summary: converting from ISO5426 is not complete Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426(). Each character or combined characters conversion is defined in a map. This conversion is missing some cases and some actual conversions are odd. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:12:40 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:20:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:20:31 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 --- Comment #5 from Jonathan Druart --- (In reply to Marc V?ron from comment #4) > Testing (without patch) > > Home > Reports > Guided reports wizard > Button [Bulid new] > Step 1: Choose Circulaton , Not public > Step 2: Report type Tabular > Step 3: Choose some columns from Biblioitems and add them > Step 4: Check "Koha itemtype" (BK), Check Type (issue) Here check 'Koha itemtype' but don't choose a value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:30:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:30:19 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 --- Comment #1 from Fridolin SOMERS --- I've found only one full documentation about this conversion : http://www.gymel.com/charsets/MAB2.html Is it correct ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:30:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:30:22 +0000 Subject: [Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:30:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:30:25 +0000 Subject: [Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38653|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 38654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38654&action=edit Bug 14077 - Remove unused AUTH_UPDATE_FAILED from moremember.tt 'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910). To verify: git grep 'AUTH_UPDATE_FAILED' Result: Only one occurence (in moremember.tt) Test plan: - Apply patch (on top of Bug 13910) - Verify that the part with AUTH_UPDATE_FAILED is removed from moremember.tt - Go to a patron's detail page and verify that nothing is broken (Home > Patrons > Patrons details for...) Signed-off-by: Jonathan Druart This has been introduced by commit 1a91801b06607ee9e5f8c21d531a7b7a3ca3b683 Date: Sat Dec 1 20:56:27 2007 -0600 Add Staff member type. Add permissions checks for bug# 1269 and related permissions on memberentry and mods. But was already not used... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:32:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:32:38 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 --- Comment #2 from Fridolin SOMERS --- Created attachment 38655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38655&action=edit Bug 14078 - converting from ISO5426 is not complete Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426(). Each character or combined characters conversion is defined in a map. This patch changes some odd actual conversions. In char_decode5426(), only characters between 0xC0 and 0xDF will be used for combining with following charater : ($char >= 0xC0 && $char <= 0xDF) So conversion like "$chars{0x81d1}=0x00b0" will never be used. Rules for "h with breve below" use combining with 0xf9 but looks like the correct caracter is 0xd5. See http://www.gymel.com/charsets/MAB2.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:32:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:32:59 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:33:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:33:31 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Needs Signoff |Failed QA --- Comment #21 from Jonathan Druart --- t/db_dependent/Acquisition.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/87 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:36:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:36:34 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 --- Comment #3 from Fridolin SOMERS --- Created attachment 38656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38656&action=edit Bug 14078 - converting from ISO5426 is not complete - followup1 Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426(). Each character or combined characters conversion is defined in a map. This patch adds missing conversions. See http://www.gymel.com/charsets/MAB2.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:37:35 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 --- Comment #4 from Fridolin SOMERS --- Patches are actually drafts so I do not set to "need signoff". Looking for feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 12:48:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 10:48:03 +0000 Subject: [Koha-bugs] [Bug 13265] Still too many search cursor cookies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |jonathan.druart at biblibre.co | |m --- Comment #10 from Jonathan Druart --- Kyle, Don't you think it would be better to correctly fix the issue and store the searches using the sessionStorage? It will avoid YASP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:18:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:18:49 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 --- Comment #6 from Marc V?ron --- Ok, reproduced: Errors found when processing parameters for report: itype: The authorized value category (itemtype) you selected does not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:23:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:23:53 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 --- Comment #7 from Marc V?ron --- Created attachment 38657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38657&action=edit [Signed-off] Bug 10976: Fix typo itemtype vs itemtypes When creating a new report, the limit step let you choose itype|itemtype. But it should be itype|itemtypes. If you try to create a guided report and you choose this option as a limit, you will get a warning on saving it: Errors found when processing parameters for report: itype: The authorized value category (itemtype) you selected does not exist. Looking at the code: reports/guided_reports.pl l.657 elsif ( $authorised_value eq "itemtypes" ) { Test plan: 0/ Don't apply the patch 1/ Create a guided report, select Koha itemtype as a limit(step 4) 2/ Confirm you get the error when saving 3/ Apply the patch and repeat step 1 4/ There is no error and the report should work correctly Tested with steps in comment #4/#5, error is gone after applying patch. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:24:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:24:41 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:24:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:24:55 +0000 Subject: [Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:32:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:32:04 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38128|0 |1 is obsolete| | --- Comment #92 from Jonathan Druart --- Created attachment 38658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38658&action=edit Bug 5010 - Fix OPACBaseURL to include protocol Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:32:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:32:13 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #93 from Jonathan Druart --- Created attachment 38659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38659&action=edit Bug 5010: Fix - replace tab with spaces Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:33:37 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #94 from Jonathan Druart --- Signing off but it needs another one, I did not really follow the test plan. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:37:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:37:39 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:37:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:37:42 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38628|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 38660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38660&action=edit Bug 14075: Undefined value creates noisy warns in C4::AuthoritiesMarc This match sets $sortby (previously undefined value) as an empty string to get rid of the warns. To test: 1) Go to a URL such as http://localhost:8080/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=a&marclist=any&and_or=and 2) Notice the warns in the error log 3) Apply patch 4) Reload URL 5) Notice page still works but no warns in error log Signed-off-by: Mark Tompsett NOTE: I would have done $sortby //= ''; But this works too. :) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:38:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:38:08 +0000 Subject: [Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart at biblibre.co | |m Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:43:39 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:48:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:48:31 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36744|0 |1 is obsolete| | --- Comment #13 from Nicolas Legrand --- Comment on attachment 36744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36744 Change default collation to utf8_bin Jonathan's patch seems far better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 13:56:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 11:56:24 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #5 from Zeno Tajoli --- Hi Fridolin, I confirm you that http://www.gymel.com/charsets/MAB2.html is a good source for ISO 5426 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:38:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:38:37 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36951|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 38661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38661&action=edit Bug 13758: Move the Koha version from kohaversion.pl It will permit not to run another perl interpreter. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:39:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:39:59 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38661|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 38662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38662&action=edit [SIGNED OFF] Bug 13758: Move the Koha version from kohaversion.pl It will permit not to run another perl interpreter. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:40:07 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36988|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 38663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38663&action=edit [SIGNED OFF] Bug 13758: Add POD Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:40:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:40:35 +0000 Subject: [Koha-bugs] [Bug 13758] KOHAVERSION should be statically set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |tomascohen at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:41:24 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:41:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:41:26 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38562|0 |1 is obsolete| | --- Comment #14 from Nicolas Legrand --- Created attachment 38664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38664&action=edit Bug 13810: Change collate for tagsubfield (utf8_bin) Before bug 11944, the marc_subfield_structure.tagsubfield column had a specific collate: utf8_bin. It has been introduced by commit 67e20d82ffdfcd69344ec30696bebc51c00d863c Date: Sun Jun 22 16:35:48 2008 -0500 DB Bump 094 - bug 2268 -- allow mixed case subfield labels in MARC21 by changing db column collation. This change should be kept and Koha should continue to allow and create subfields with the same letter but different case sensitivity. What does this patch: 1/ To prevent the updatedatabase entry 3.19.00.006 to fail if subfields with different case sensitivity already exist in the DB, the table is managed separately from others. 2/ To update DB which have already pass this dbrev, a new entry will be create to update the specific collate for this column. Test plan: 1/ a. With a 3.18 DB, create subfield 'a' and 'A' for the same field b. Execute the updatedatabase.pl script. 3.19.00.006 should not fail anymore 2/ a. With a master DB (3.19.00.006 has already been executed), create subfields 'a' and 'A'. You should get an error. b. Apply this patch, execute the DB entry and try again 2/a. you should be able to create the second subfield. Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:43:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:43:13 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #15 from Nicolas Legrand --- Note I've only done test plan 1, I'm working on a base that was breaking, I don't have the one to try to break :). Thanks a lot for the patch ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:55:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:55:29 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 --- Comment #5 from Jonathan Druart --- I think we need to implement something more generic. We have this translation issue for item types (as you noticed, cf bug 14064) but also for sysprefs (i.e. OPACMySummaryHTML, OPACMySummaryNote, OpacNav*, etc.), the library names, etc. (something else?) We could imagine a table in DB with columns "type" column (will contain "authorised_values", "item_types", "sysprefs", etc.) and "lang" ('fr-FR', 'de-DE', etc.). The complexity will be to implement an ergonomic view to edit the different translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:56:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:56:15 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:56:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:56:18 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38306|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 38665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38665&action=edit Bug 14038: Make nl-search.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan for Magnus :) 0/ Enable the pref you need to use the Norwegian national library card ft 1/ Go on the members/nl-search.pl page and search for patrons. 2/ Make sure you search by card number and by "social security number" Signed-off-by: Magnus Enger Searching works the same with and without the patch. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 14:56:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 12:56:28 +0000 Subject: [Koha-bugs] [Bug 906] ISBN Check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906 --- Comment #15 from Tom?s Cohen Arazi --- (In reply to M. Tompsett from comment #14) > Having encountered horrific ISBN problems a while back, I get the feeling > that warning people about bad ISBNs is the best we should do, because > sometimes companies use invalid ISBNs. > > Anyone going to follow up on this? Mark, the unanswered question is what the workflow would be? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 15:01:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 13:01:01 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #32 from Jonathan Druart --- Bug 14038 is signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 15:01:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 13:01:51 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 --- Comment #3 from Magnus Enger --- QA team: This patch can only really be tested by a Norwegian library system vendor, because you need all sorts of passwords and secret handshakes... I think what can be done is testing for regressions, e.g. that normal patron search works as expected with NorwegianPatronDBEnable = Disable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 15:09:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 13:09:27 +0000 Subject: [Koha-bugs] [Bug 13964] "Withdrawn" status does not appear in Staff search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13964 Steven Nickerson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |snicker1 at maine.rr.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 15:29:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 13:29:43 +0000 Subject: [Koha-bugs] [Bug 14074] 'suggested on' date on suggestion list not correctly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14074 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 15:29:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 13:29:46 +0000 Subject: [Koha-bugs] [Bug 14074] 'suggested on' date on suggestion list not correctly formatted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14074 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38637|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 38666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38666&action=edit Bug 14074 - Format 'suggested on' date in suggestion list correctly One of the dates (suggested on) in the list of suggestions in staff is not correctly formatted. To test: - Create one or many suggestions - Check the list of suggestion, especially in the 'Suggested by - on' column - Verify the date is not displayed according to the dateformat preference - Apply patch - Verify the problem is fixed Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 16:01:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 14:01:44 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37671|1 |0 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 16:06:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 14:06:33 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37671|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 16:40:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 14:40:55 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- QA comments: 1/ The items.itemnotes does not appear in the return table (already before this patch). I think it's because of circ/returns.pl: 577 $ri{itemnote} = $biblio->{'itemnotes'}; should be 577 $ri{itemnote} = $item->{'itemnotes'}; 2/ The non public notes does not appear in the relatives issues table. 3/ Do you know what is the span class "circ-hlt"? Marked as Failed QA for 2, but it would be great to see 1 fixed too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 16:54:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 14:54:55 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 16:56:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 14:56:30 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #22 from M. Tompsett --- Created attachment 38667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38667&action=edit Bug 11122: Follow up Based on comment #21, this patch corrects the failings in the t/db_dependent/Acquisition.t tests. When two fields were added to the query, the corresponding array in the the test file was not updated to match. TEST PLAN --------- 1) Apply the first two patches 2) prove -v t/db_dependent/Acquisition.t -- fails 2 tests 3) Apply this patch 4) prove -v t/db_dependent/Acquisition.t -- passes 5) Run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:04:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:04:30 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37977|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 38668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38668&action=edit Bug 13993 - (1) Add tests to confirm 'new' and 'cancelled' This adds 2 tests to t/db_dependent/Acquisition/TransferOrder.t in order to confirm the order's status is properly marked. TEST PLAN --------- 1) Log into staff client 2) Acquisitions 3) Create a basket for two differing vendors. 4) Place an order in one of the baskets. 5) Transfer the order from one vendor's basket to the others. 6) Apply this patch (1) only 7) prove -v t/db_dependent/Acquisition/TransferOrder.t -- should fail one test: not marked as 'cancelled'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:04:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:04:36 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37978|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 38669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38669&action=edit Bug 13993 - (2) Correct poorly transferred orders Added Atomic Update to fix poorly transferred orders TEST PLAN --------- 8) Apply patch (2) 9) Run the database updates $ ./installer/data/mysql/updatedatabase.pl -- This should run without error 10) prove -v t/db_dependent/Acquisition/TransferOrder.t -- This should succeed now, because the update fixed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:04:40 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37979|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 38670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38670&action=edit Bug 13993 - (3) Transfer order leaves incorrect orderstatus 11) Apply patch (3) 12) Log in to staff client 13) Acquisitions 14) Create a basket for two different vendors 15) Place an order in one vendor's basket. 16) Transfer the order to the other vendor's basket. 17) prove -v t/db_dependent/Acquisition/TransferOrder.t -- This should succeed without intervention. 18) Run koha qa test tools for the last 3 commits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:06:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:06:35 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart --- Kyle, Please provide tests for the changes in C4::VirtualShelves. I don't know if you feel comfortable with this code, but personally I am not at all. So maybe the better is to start and move the code into Koha::VirtualShelves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:08:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:08:02 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #12 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) > So maybe the better is to start and move the code into Koha::VirtualShelves. Since your changes consist in adding a check, it's certainly a bit hard to start here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:17:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:17:29 +0000 Subject: [Koha-bugs] [Bug 4041] Address Format as a I18N/L10N system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4041 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Tom?s Cohen Arazi --- Enhancement pushed to master. Thanks Marc! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:18:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:18:06 +0000 Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #69 from Tom?s Cohen Arazi --- Good catch Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:18:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:18:33 +0000 Subject: [Koha-bugs] [Bug 1917] Add RSS Feeds for Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #26 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:41:51 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #13 from M. Tompsett --- Still debugging/testing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:57:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:57:10 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 --- Comment #10 from Christopher Brannon --- Created attachment 38671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38671&action=edit [SIGNED OFF]Bug 14044: Escape json strings for patron searches In a couple of patron searches, the address is displayed. If the address contain invalid json characters, DataTables won't manage to parse the results and display them. This patch makes the templates more readable by creating a BLOCK instead of a long line and escape the invalid json characters calling the TT plugin (To.json). Test plan: Edit a patron and add something like: patron
    \123 ? ? in the address field. Search for this patron using the main patron search (members/member.pl) and the guarantor search. Confirm that a result with this patron is correctly displayed. Regression test: Since Koha::Template::Plugin::To::json is modified, confirm that the add users to basket search (on acqui/basket.pl?basketno=X click on the "Add user" button) still works as expected. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:58:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:58:23 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:58:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:58:24 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 17:59:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 15:59:12 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 18:10:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 16:10:44 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 --- Comment #11 from Christopher Brannon --- Did the sign off, but had to figure out how to work around issues the special characters in your test plan created. FYI. Otherwise, looks good. Works great. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 18:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 16:11:32 +0000 Subject: [Koha-bugs] [Bug 906] ISBN Check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 18:32:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 16:32:57 +0000 Subject: [Koha-bugs] [Bug 14079] New: performing actions on invoices refreshes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14079 Bug ID: 14079 Summary: performing actions on invoices refreshes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org When you close an invoice from the invoice search it refreshes and you lose the options you made: http://screencast.com/t/D893f9vwC1V Nicole -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 19:35:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 17:35:12 +0000 Subject: [Koha-bugs] [Bug 13060] number of holds on acq multiplying by copies ordered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13060 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon --- We're seeing this too. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 19:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 17:59:44 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 --- Comment #6 from Christopher Brannon --- Actually, on 3.18, which we just upgraded to, we are seeing the opposite now. The first page of notices works as expected, but when you go to the next page, everything is expanded, and cannot be collapsed! If you change view to more than 20 at a time, the first 20 are normal and the rest are expanded. Very weird! Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:00:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:00:36 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:03:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:03:18 +0000 Subject: [Koha-bugs] [Bug 14080] New: cancelled orders should show on invoice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14080 Bug ID: 14080 Summary: cancelled orders should show on invoice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 38672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38672&action=edit cancelled on basket only Right now if you cancel an order it doesn't show under on the receiving page as a confirmation (under already received would make sense) and it doesn't show on the invoice. This item can only be seen in the basket, but most people want to know what was cancelled on their invoice. Side note - you also can't find it by doing an order search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:13:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:13:43 +0000 Subject: [Koha-bugs] [Bug 14068] Bug 14055 breaks new package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:13:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:13:47 +0000 Subject: [Koha-bugs] [Bug 14068] Bug 14055 breaks new package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38611|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 38673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38673&action=edit [PASSED QA] Bug 14068: fix preinst for fresh package installs Signed-off-by: Mirko Tietgen Signed-off-by: Tomas Cohen Arazi Works as expected. Tested both upgrading and on a new install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:43:39 +0000 Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #14 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:44:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:44:13 +0000 Subject: [Koha-bugs] [Bug 11165] auth_header.datemodified should be updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:44:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:44:36 +0000 Subject: [Koha-bugs] [Bug 14068] Bug 14055 breaks new package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:45:04 +0000 Subject: [Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Frido and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:45:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:45:32 +0000 Subject: [Koha-bugs] [Bug 13893] Add ability to execute perl scripts in atomicupdates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13893 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:56:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:56:23 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38668|0 |1 is obsolete| | --- Comment #14 from M. Tompsett --- Created attachment 38674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38674&action=edit Bug 13993 - (1) Add tests to confirm 'new' and 'cancelled' This adds 2 tests to t/db_dependent/Acquisition/TransferOrder.t in order to confirm the order's status is properly marked. TEST PLAN --------- 1) Log into staff client 2) Acquisitions 3) Create a basket for two differing vendors. 4) Place an order in one of the baskets. 5) Transfer the order from one vendor's basket to the others. 6) Apply this patch (1) only 7) prove -v t/db_dependent/Acquisition/TransferOrder.t -- should fail one test: not marked as 'cancelled'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:56:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:56:31 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38669|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 38675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38675&action=edit Bug 13993 - (2) Correct poorly transferred orders Added Atomic Update to fix poorly transferred orders TEST PLAN --------- 8) Apply patch (2) 9) Run the database updates $ ./installer/data/mysql/updatedatabase.pl -- This should run without error 10) prove -v t/db_dependent/Acquisition/TransferOrder.t -- This should fail, because the transfer function is still not fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:56:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:56:45 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38670|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 38676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38676&action=edit Bug 13993 - (3) Transfer order leaves incorrect orderstatus 11) Apply patch (3) 12) Log in to staff client 13) Acquisitions 14) Create a basket for two different vendors 15) Place an order in one vendor's basket. 16) Transfer the order to the other vendor's basket. 17) prove -v t/db_dependent/Acquisition/TransferOrder.t -- This should succeed without intervention. 18) Run koha qa test tools for the last 3 commits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 20:57:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 18:57:09 +0000 Subject: [Koha-bugs] [Bug 13993] Transfer order from one vendor to another vendor previous orderstatus is not changed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 21:01:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 19:01:11 +0000 Subject: [Koha-bugs] [Bug 14080] cancelled orders should show on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14080 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Nicole, you can search for cancelled orders by selecting the cancelled status on the order search form -I think we just don't include them by default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 21:41:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 19:41:43 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- Please provide steps to make the problem visible outside of the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 21:49:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 19:49:50 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #24 from M. Tompsett --- (In reply to Katrin Fischer from comment #23) > Please provide steps to make the problem visible outside of the tests. I'll work on it, but it make require setting up bad data in an earlier version, upgrading, and then trying to edit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 21:56:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 19:56:33 +0000 Subject: [Koha-bugs] [Bug 14025] Fix display of links from 856$u in the OPAC for NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 21:56:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 19:56:35 +0000 Subject: [Koha-bugs] [Bug 14025] Fix display of links from 856$u in the OPAC for NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 --- Comment #1 from Magnus Enger --- Created attachment 38677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38677&action=edit Bug 14025 - Fix 865u-links in the OPAC for NORMARC The display of links found in 856$u for NORMARC has not been keeping up with the one for MARC21, and several sysprefs have not been implemented. This patch tries to fix that. Affected sysprefs: - OPACURLOpenInNewWindow - URLLinkText - OPACDisplay856uAsImage - OPACTrackClicks To test: - Make sure you have a record with a URL in 856$u and marcflavor = NORMARC. (It does not have to be a full NORMARC setup or a NORMARC record, just make sure you are viewing the record through the NORMARC XSLT files.) - View the record both in a result list and in detail view - Check that the 4 involved sysprefs affect the display in the expected ways -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 21:58:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 19:58:05 +0000 Subject: [Koha-bugs] [Bug 14025] Fix display of links from 856$u in the OPAC for NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 --- Comment #2 from Magnus Enger --- The scope of this bug changed a bit after I made the first comment, please disregard it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:01:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:01:11 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:01:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:01:15 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38651|0 |1 is obsolete| | Attachment #38652|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 38678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38678&action=edit [PASSED QA] Bug 13910 - Prevent delete of one's own patron account This patch adds a check to prevent deleting the user's own account. Additionali it fixes a "missing link" in moremember.pl and wrong comparisions in moremember.tt regarding other forbidden deleting. To test: - Apply patch - Create a user with sufficient privileges to delete users - Log in as this new user - Try to delete this user. Confirm message box "Are you sure..." - Confirm that you get a message "Not allowed to delete own account" and that the user still exists. Bonus test: Try to trigger other forbidden deletions (see members/deletemem.pl): 'CANT_DELETE_STAFF', 'CANT_DELETE_OTHERLIBRARY', 'CANT_DELETE' (You can fake it by using an URL like: /cgi-bin/koha/members/moremember.pl?borrowernumber=115&error=CANT_DELETE_STAFF etc.) Without patch, no message appears. With patch, messages appear as appropriate. Signed-off-by: Mark Tompsett NOTE: Attempted all CANT combinations. From reading the code, this is kind of an important patch, because I'm not sure deleting error messages work at all right now based on what I read. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:01:33 +0000 Subject: [Koha-bugs] [Bug 13910] Prevent delete of one's own patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 --- Comment #12 from Katrin Fischer --- Created attachment 38679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38679&action=edit [PASSED QA] Bug 13910 - Line with AUTH_UPDATE_FAILED restored As of comment #6 Signed-off-by: Jonathan Druart This should be fixed in a separate patch, this error is not sent to the template and the related code could be removed. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:05:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:05:04 +0000 Subject: [Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #25 from Katrin Fischer --- If you or Rolando can tell me how to alter the data in order to make the problem appear that would work for me for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:08:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:08:32 +0000 Subject: [Koha-bugs] [Bug 14025] Fix 865u-links in the OPAC for NORMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix display of links from |Fix 865u-links in the OPAC |856$u in the OPAC for |for NORMARC |NORMARC | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:08:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:08:44 +0000 Subject: [Koha-bugs] [Bug 14081] New: price labels are not consistent in acq Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 Bug ID: 14081 Summary: price labels are not consistent in acq Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 38680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38680&action=edit order screen labels In acquisitions the price fields are inconsistently labeled. There are 4 price fields: vendor price estimated cost replacement cost actual cost However as you can see in the screenshots it says it differently everywhere. Some phrases: * Unit price * RRP * EST * Budgeted cost * Actual cost * Base-level And more. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:09:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:09:01 +0000 Subject: [Koha-bugs] [Bug 14081] price labels are not consistent in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #1 from Nicole C. Engard --- Created attachment 38681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38681&action=edit fund list labels -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:09:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:09:40 +0000 Subject: [Koha-bugs] [Bug 14081] price labels are not consistent in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #2 from Nicole C. Engard --- Created attachment 38682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38682&action=edit fund management view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:10:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:10:02 +0000 Subject: [Koha-bugs] [Bug 14081] price labels are not consistent in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #3 from Nicole C. Engard --- Created attachment 38683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38683&action=edit invoice labels -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:10:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:10:19 +0000 Subject: [Koha-bugs] [Bug 14081] price labels are not consistent in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #4 from Nicole C. Engard --- Created attachment 38684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38684&action=edit order search labels -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:11:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:11:03 +0000 Subject: [Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:11:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:11:07 +0000 Subject: [Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38654|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 38685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38685&action=edit [PASSED QA] Bug 14077 - Remove unused AUTH_UPDATE_FAILED from moremember.tt 'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910). To verify: git grep 'AUTH_UPDATE_FAILED' Result: Only one occurence (in moremember.tt) Test plan: - Apply patch (on top of Bug 13910) - Verify that the part with AUTH_UPDATE_FAILED is removed from moremember.tt - Go to a patron's detail page and verify that nothing is broken (Home > Patrons > Patrons details for...) Signed-off-by: Jonathan Druart This has been introduced by commit 1a91801b06607ee9e5f8c21d531a7b7a3ca3b683 Date: Sat Dec 1 20:56:27 2007 -0600 Add Staff member type. Add permissions checks for bug# 1269 and related permissions on memberentry and mods. But was already not used... Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:16:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:16:29 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:16:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:16:32 +0000 Subject: [Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38633|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 38686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38686&action=edit [PASSED QA] Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Fixed some tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:19:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:19:08 +0000 Subject: [Koha-bugs] [Bug 14081] price labels are not consistent in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #5 from Nicole C. Engard --- Created attachment 38687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38687&action=edit price labels on item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:21:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:21:25 +0000 Subject: [Koha-bugs] [Bug 14081] price labels are not consistent in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #6 from Nicole C. Engard --- Created attachment 38688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38688&action=edit ordered search labels -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:22:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:22:03 +0000 Subject: [Koha-bugs] [Bug 14081] price labels are not consistent in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #7 from Nicole C. Engard --- Created attachment 38689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38689&action=edit spent fund search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:22:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:22:44 +0000 Subject: [Koha-bugs] [Bug 14081] price labels are not consistent in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #8 from Nicole C. Engard --- I think: Unit cost = vendor price est = budgeted = estimated unit price replacement cost = rrp Etc etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:27:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:27:25 +0000 Subject: [Koha-bugs] [Bug 14080] cancelled orders should show on invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14080 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:27:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:27:42 +0000 Subject: [Koha-bugs] [Bug 14079] performing actions on invoices refreshes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14079 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:27:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:27:45 +0000 Subject: [Koha-bugs] [Bug 11925] patron category not checking ages limits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:27:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:27:48 +0000 Subject: [Koha-bugs] [Bug 11925] patron category not checking ages limits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38599|0 |1 is obsolete| | --- Comment #2 from Christopher Brannon --- Created attachment 38690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38690&action=edit [SIGNED OFF]Bug 11925: Check ages limits when creating/updating patrons The check on the ages limits is only done when the dateofbirth field is mandatory, which does not make any sense. This check should be done when the field is filled. Test plan: 1/ Remove the dateofbirth field from the BorrowerMandatoryField pref 2/ Create a patron category for teenager (say between 12-17y) 3/ Try to create a patron in this category outside the range of the ages limits. You should not be able to do it. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:28:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:28:38 +0000 Subject: [Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:28:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:28:41 +0000 Subject: [Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38634|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 38691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38691&action=edit [PASSED QA] Bug 12253: Fix MARCUrls in basket At the OPAC and the intranet, the urls don't be displayed anymore. The variables used in the templates are not the good ones (MARCurlS vs MARCURLS). Test plan: 1/ On the intranet side, add some urls to some records 2/ Add these records to the basket 3/ Add records without urls defined 4/ Go on the basket view, click "more details" 5/ You should see the urls displayed 6/ Repeat steps 4-5 at the OPAC Signed-off-by: Mark Tompsett NOTE: 856$u displays now in intranet and OPAC. :) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:28:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:28:56 +0000 Subject: [Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com, | |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:31:28 +0000 Subject: [Koha-bugs] [Bug 14082] New: can't edit vendor notes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14082 Bug ID: 14082 Summary: can't edit vendor notes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 38692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38692&action=edit receive page - not editable vendor note When receiving you can add vendor notes on the receipt page but you can't edit them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:31:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:31:36 +0000 Subject: [Koha-bugs] [Bug 14082] can't edit vendor notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14082 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:31:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:31:53 +0000 Subject: [Koha-bugs] [Bug 14082] can't edit vendor notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14082 --- Comment #1 from Nicole C. Engard --- Created attachment 38693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38693&action=edit receipt summary - can add but not edit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:37:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:37:04 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer --- Sorry, I found another something - try adding a " to the address data - it will display as " on the patron result list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:38:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:38:06 +0000 Subject: [Koha-bugs] [Bug 13061] filters on invoices not clearing after results found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13061 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:38:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:38:47 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:39:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:39:19 +0000 Subject: [Koha-bugs] [Bug 13061] filters on invoices not clearing after results found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13061 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14079 --- Comment #1 from Nicole C. Engard --- I think it's possible that this request is counter to this other request: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14079 Nicole PS. I entered both on behalf of library partners so we might need feedback here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:39:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:39:19 +0000 Subject: [Koha-bugs] [Bug 14079] performing actions on invoices refreshes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14079 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13061 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:41:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:41:02 +0000 Subject: [Koha-bugs] [Bug 14083] New: new acq date field Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Bug ID: 14083 Summary: new acq date field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu It would be nice if there were another date field in Acq. There is no field to enter the date the item was actually ordered from the vendor. There is the date the basket was created in Koha and the date the item shipped and was received - but not the date you placed the order with the vendor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:42:40 +0000 Subject: [Koha-bugs] [Bug 14083] new acq date field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Nicole, I think the aqorders.closedate is the one you are looking for. The moment you close the basket the status switches from new to ordered and the date is set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:42:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:42:43 +0000 Subject: [Koha-bugs] [Bug 14084] New: order date language in Koha inconsistent Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14084 Bug ID: 14084 Summary: order date language in Koha inconsistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu In Koha when you create a basket there is a basket opened date, on other pages it's called the order date, on other pages it's called the placed on date and in some places it's the creation date - they should all be consistent which ever they use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:43:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:43:30 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:45:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:45:17 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:45:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:45:19 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38665|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 38694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38694&action=edit [PASSED QA] Bug 14038: Make nl-search.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan for Magnus :) 0/ Enable the pref you need to use the Norwegian national library card ft 1/ Go on the members/nl-search.pl page and search for patrons. 2/ Make sure you search by card number and by "social security number" Signed-off-by: Magnus Enger Searching works the same with and without the patch. Thanks Jonathan! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:46:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:46:00 +0000 Subject: [Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 --- Comment #5 from Katrin Fischer --- Code touched by this patch is specific to the Norwegian library card feature - no regressions found and trusting Magnus as a tester here (have to... ;) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:48:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:48:27 +0000 Subject: [Koha-bugs] [Bug 14085] New: search biblionumber in acquisitions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14085 Bug ID: 14085 Summary: search biblionumber in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu It would be nice if the order search in Acquisitions allowed searching on biblionumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:52:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:52:32 +0000 Subject: [Koha-bugs] [Bug 14086] New: date ordered on ordered fund search doesn't match order date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14086 Bug ID: 14086 Summary: date ordered on ordered fund search doesn't match order date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu Created attachment 38695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38695&action=edit ordered date When you click to see what orders make up the total ordered in your fund you see a 'date ordered' it however does not seem to match any date in the order. It should be the date the basket was created since that's the order date. The date received seems closest to the date showing in the images and that's not the order date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:52:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:52:45 +0000 Subject: [Koha-bugs] [Bug 14086] date ordered on ordered fund search doesn't match order date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14086 --- Comment #1 from Nicole C. Engard --- Created attachment 38696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38696&action=edit dates on order -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:55:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:55:19 +0000 Subject: [Koha-bugs] [Bug 14087] New: show all price fields on order search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14087 Bug ID: 14087 Summary: show all price fields on order search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu It would be nice if all the price costs showed on the acquisitions order search - right now it's just unit cost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:56:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:56:30 +0000 Subject: [Koha-bugs] [Bug 14088] New: Show qty on order search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14088 Bug ID: 14088 Summary: Show qty on order search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu It would be nice to see the qty ordered on the order search results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 22:57:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 20:57:35 +0000 Subject: [Koha-bugs] [Bug 14089] New: show reason for cancellation on order search results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14089 Bug ID: 14089 Summary: show reason for cancellation on order search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu It would be nice to see the cancellation reason on the order search results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:01:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:01:51 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38284|0 |1 is obsolete| | Attachment #38285|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer --- Created attachment 38697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38697&action=edit [PASSED QA] Bug 12633: Remove SQLHelper in C4::Members This is the only places where SQLHelper is still called. The C4::Members::Search is not used anymore, but ModMember and AddMember. This patch replaced the calls to SQLHelper to use DBIX::Class. TODO: Move them to Koha::Borrower. Test plan: 1/ Make sure the patron search still works (no changes expected since the code was not in used). 2/ Add a patron with all fields filled 3/ Add another patron with some fields filled 4/ Update them with other values 5/ Delete them You should not get any errors. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:02:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:02:06 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #34 from Katrin Fischer --- Created attachment 38698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38698&action=edit [PASSED QA] Bug 12633: Fix specific default values The dates should be set to undef if defined but empty, otherwise with an empty string, '0000-00-00' will be inserted into the DB. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:03:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:03:05 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:03:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:03:55 +0000 Subject: [Koha-bugs] [Bug 14090] New: add link to basket from invoice and vice versa Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14090 Bug ID: 14090 Summary: add link to basket from invoice and vice versa Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu It would be nice to have a link to the basket from the invoice (right now it's just the receipt page) and a link from the basket to the invoice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:04:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:04:41 +0000 Subject: [Koha-bugs] [Bug 14091] New: way to distinguish deleted versus cancelled in acq Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14091 Bug ID: 14091 Summary: way to distinguish deleted versus cancelled in acq Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu It would be nice if in Acq you could distinguish between things that were cancelled and things that were deleted due an error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:09:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:09:36 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:11:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:11:19 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 --- Comment #5 from Katrin Fischer --- Created attachment 38699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38699&action=edit [PASSED QA] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:13:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:13:09 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #35 from Katrin Fischer --- Habits.. this was only a sign off, fixing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:14:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:14:36 +0000 Subject: [Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #36 from Katrin Fischer --- It's getting too late... this is PASSED QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:15:55 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:15:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:15:59 +0000 Subject: [Koha-bugs] [Bug 11385] C4::SQLHelper should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37752|0 |1 is obsolete| | Attachment #38699|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 38700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38700&action=edit [SIGNED OFF] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:33:04 +0000 Subject: [Koha-bugs] [Bug 12109] Authority subfield configuration page for controlled fields is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:33:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:33:03 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #23 from Chris Cormack --- Theres a conflict in patroncards/create-pdf.pdf .. please rebase on 3.18.x if you want it in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:33:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:33:06 +0000 Subject: [Koha-bugs] [Bug 12109] Authority subfield configuration page for controlled fields is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38635|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 38701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38701&action=edit [PASSED QA] Bug 12109: Fix tab on the auth subfield configuration page There is a condition in the template to not display the "New" tab if the user is editing a control field. But it results in a broken template. Looking at the biblio frameworks, the New tab exists even for control fields. This patch only fixes the html structure, but a complete fix should be provide, for auth and biblio, if we want not to let the ability to create subfields for control fields. Test plan: Edit subfields for a control field (admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance) and confirm that the view is now fixed. Signed-off-by: Mark Tompsett NOTE: Checked LDR, 001, and 008. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:34:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:34:45 +0000 Subject: [Koha-bugs] [Bug 6007] Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Applied on 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:37:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:37:42 +0000 Subject: [Koha-bugs] [Bug 6911] Log viewer should remember search terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack --- Applied on 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:43:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:43:37 +0000 Subject: [Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #24 from Chris Cormack --- Applied on 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:45:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:45:29 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack --- Applied to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:47:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:47:09 +0000 Subject: [Koha-bugs] [Bug 14092] New: order search doesn't allow for all statuses Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Bug ID: 14092 Summary: order search doesn't allow for all statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu Created attachment 38702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38702&action=edit status pull down You can do all statuses except cancelled or individual statuses but not all statuses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:48:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:48:35 +0000 Subject: [Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 --- Comment #12 from Chris Cormack --- Applied to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:49:17 +0000 Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack --- Applied to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:49:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:49:49 +0000 Subject: [Koha-bugs] [Bug 14083] new acq date field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 --- Comment #2 from Nicole C. Engard --- Nope, that's not the date I placed the order with the vendor. So the way it works is this: 1. go to vendor site and place order 2. go to koha and enter order info again 3. close the basket So there is no way to get the date I ordered from the vendor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:51:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:51:45 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #17 from Katrin Fischer --- Created attachment 38703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38703&action=edit [PASSED QA] Bug 13423: Remove unused JS function in serials-edit.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected NOTE: I did not run this test plan. Verification steps ------------------ 1. Find out where barcode_check is used. $ git grep barcode_check -- This is only in serials-edit.tt and serials-receive.tt 2. This patch only affects serials-edit.tt, so check who put the $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- note the commit related number. 3. Check out the commit. $ git show 77b64098 -- should show bug 5917, but the patches on bugzilla don't have the change nicely, so... 4. Hunt through the pages to find the change. -- Note: it is part of a "new file" diff! 5. Since this code hasn't been running since it was added... 6. apply the patch 7. run koha-qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:51:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:51:49 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #18 from Katrin Fischer --- Created attachment 38704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38704&action=edit [PASSED QA] Bug 13423: Remove unused serials-recieve This patch removes two files, serials-recieve.pl and serial-recieve.tt serials-recieve.pl is not called anyware (it's recieve!) Also removes the sub removeMissingIssue called only from serials-recieve.pl git grep serials-recieve.pl . C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl file koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: serials/serials-recieve.pl:serials-recieve.pl Just a POD entry and self reference. After removing of files git grep removeMissingIssue . C4/Serials.pm: &check_routing &updateClaim &removeMissingIssue C4/Serials.pm:=head2 removeMissingIssue C4/Serials.pm:removeMissingIssue($subscriptionid) C4/Serials.pm:sub removeMissingIssue { t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test removing a missing issue'); Not used anymore To test: 1) Apply the patch 2) Check serials workflow, no changes must be noted Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:51:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:51:53 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #19 from Katrin Fischer --- Created attachment 38705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38705&action=edit [PASSED QA] Bug 13423: Fix number of tests in Serials.t Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:52:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:52:19 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:52:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:52:22 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38648|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:52:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:52:24 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38649|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:52:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:52:26 +0000 Subject: [Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38647|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 29 23:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 21:57:38 +0000 Subject: [Koha-bugs] [Bug 14093] New: way for course and course items to expire Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14093 Bug ID: 14093 Summary: way for course and course items to expire Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: sfayle at roseman.edu It would be nice if a course had an expiration date so you didn't have to disable it manually. Also if you could have certain items expire from reserve automatically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 00:07:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 22:07:50 +0000 Subject: [Koha-bugs] [Bug 11925] patron category not checking ages limits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 00:07:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 22:07:53 +0000 Subject: [Koha-bugs] [Bug 11925] patron category not checking ages limits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38690|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 38706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38706&action=edit [PASSED QA] Bug 11925: Check ages limits when creating/updating patrons The check on the ages limits is only done when the dateofbirth field is mandatory, which does not make any sense. This check should be done when the field is filled. Test plan: 1/ Remove the dateofbirth field from the BorrowerMandatoryField pref 2/ Create a patron category for teenager (say between 12-17y) 3/ Try to create a patron in this category outside the range of the ages limits. You should not be able to do it. Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 00:13:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 22:13:09 +0000 Subject: [Koha-bugs] [Bug 14094] New: Add separators for DDC classification in detail pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14094 Bug ID: 14094 Summary: Add separators for DDC classification in detail pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The DDC classification shows the entries separated by space. We should use | to make them better readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 00:15:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 22:15:53 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer --- OPAC view: Open in new window. still opens in the same tab for me :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 01:02:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 Apr 2015 23:02:10 +0000 Subject: [Koha-bugs] [Bug 14095] New: Automatic Renewal Enhancements Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14095 Bug ID: 14095 Summary: Automatic Renewal Enhancements Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Automatic renewals should put the focus back on checkout barcode textbox after being checked or unchecked. It should also stay on until turned off again or a new patron is pulled up. It would be courteous to show automatic renewal has been applied on the slips. My two cents. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 02:33:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 00:33:15 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #21 from M. Tompsett --- Comment on attachment 38063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38063 Bug 5685: Validation of email address field Review of attachment 38063: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5685&attachment=38063) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.validate.min.js @@ +1,4 @@ > +/*! jQuery Validation Plugin - v1.10.0 - 9/7/2012 > +* https://github.com/jzaefferer/jquery-validation > +* Copyright (c) 2012 J?rn Zaefferer; Licensed MIT, GPL */ > +(function(a){a.extend(a.fn,{validate:function(b){if(!this.length){b&&b.debug&&window.console&&console.warn("nothing selected, can't validate, returning nothing");return}var c=a.data(this[0],"validator");return c?c:(this.attr("novalidate","novalidate"),c=new a.validator(b,this[0]),a.data(this[0],"validator",c),c.settings.onsubmit&&(this.validateDelegate(":submit","click",function(b){c.settings.submitHandler&&(c.submitButton=b.target),a(b.target).hasClass("cancel")&&(c.cancelSubmit=!0)}),this.submit(function(b){function d(){var d;return c.settings.submitHandler?(c.submitButton&&(d=a("").attr("name",c.submitButton.name).val(c.submitButton.value).appendTo(c.currentForm)),c.settings.submitHandler.call(c,c.currentForm,b),c.submitButton&&d.remove(),!1):!0}return c.settings.debug&&b.preventDefault(),c.cancelSubmit?(c.cancelSubmit=!1,d()):c.form()?c.pendingRequest?(c.formSubmitted=!0,!1):d():(c.focusInvalid(),!1)})),c)},valid:function(){if(a(this[0]).is("form"))return this.validate().form();var b=!0,c=a(this[0].form).validate();return this.each(function(){b&=c.element(this)}),b},removeAttrs:function(b){var c={},d=this;return a.each(b.split(/\s/),function(a,b){c[b]=d.attr(b),d.removeAttr(b)}),c},rules:function(b,c){var d=this[0];if(b){var e=a.data(d.form,"validator").settings,f=e.rules,g=a.validator.staticRules(d);switch(b){case"add":a.extend(g,a.validator.normalizeRule(c)),f[d.name]=g,c.messages&&(e.messages[d.name]=a.extend(e.messages[d.name],c.messages));break;case"remove":if(!c)return delete f[d.name],g;var h={};return a.each(c.split(/\s/),function(a,b){h[b]=g[b],delete g[b]}),h}}var i=a.validator.normalizeRules(a.extend({},a.validator.metadataRules(d),a.validator.classRules(d),a.validator.attributeRules(d),a.validator.staticRules(d)),d);if(i.required){var j=i.required;delete i.required,i=a.extend({required:j},i)}return i}}),a.extend(a.expr[":"],{blank:function(b){return!a.trim(""+b.value)},filled:function(b){return!!a.trim(""+b.value)},unchecked:function(a){return!a.checked}}),a.validator=function(b,c){this.settings=a.extend(!0,{},a.validator.defaults,b),this.currentForm=c,this.init()},a.validator.format=function(b,c){return arguments.length===1?function(){var c=a.makeArray(arguments);return c.unshift(b),a.validator.format.apply(this,c)}:(arguments.length>2&&c.constructor!==Array&&(c=a.makeArray(arguments).slice(1)),c.constructor!==Array&&(c=[c]),a.each(c,function(a,c){b=b.replace(new RegExp("\\{"+a+"\\}","g"),c)}),b)},a.extend(a.validator,{defaults:{messages:{},groups:{},rules:{},errorClass:"error",validClass:"valid",errorElement:"label",focusInvalid:!0,errorContainer:a([]),errorLabelContainer:a([]),onsubmit:!0,ignore:":hidden",ignoreTitle:!1,onfocusin:function(a,b){this.lastActive=a,this.settings.focusCleanup&&!this.blockFocusCleanup&&(this.settings.unhighlight&&this.settings.unhighlight.call(this,a,this.settings.errorClass,this.settings.validClass),this.addWrapper(this.errorsFor(a)).hide())},onfocusout:function(a,b){!this.checkable(a)&&(a.name in this.submitted||!this.optional(a))&&this.element(a)},onkeyup:function(a,b){if(b.which===9&&this.elementValue(a)==="")return;(a.name in this.submitted||a===this.lastActive)&&this.element(a)},onclick:function(a,b){a.name in this.submitted?this.element(a):a.parentNode.name in this.submitted&&this.element(a.parentNode)},highlight:function(b,c,d){b.type==="radio"?this.findByName(b.name).addClass(c).removeClass(d):a(b).addClass(c).removeClass(d)},unhighlight:function(b,c,d){b.type==="radio"?this.findByName(b.name).removeClass(c).addClass(d):a(b).removeClass(c).addClass(d)}},setDefaults:function(b){a.extend(a.validator.defaults,b)},messages:{required:"This field is required.",remote:"Please fix this field.",email:"Please enter a valid email address.",url:"Please enter a valid URL.",date:"Please enter a valid date.",dateISO:"Please enter a valid date (ISO).",number:"Please enter a valid number.",digits:"Please enter only digits.",creditcard:"Please enter a valid credit card number.",equalTo:"Please enter the same value again.",maxlength:a.validator.format("Please enter no more than {0} characters."),minlength:a.validator.format("Please enter at least {0} characters."),rangelength:a.validator.format("Please enter a value between {0} and {1} characters long."),range:a.validator.format("Please enter a value between {0} and {1}."),max:a.validator.format("Please enter a value less than or equal to {0}."),min:a.validator.format("Please enter a value greater than or equal to {0}.")},autoCreateRanges:!1,prototype:{init:function(){function d(b){var c=a.data(this[0].form,"validator"),d="on"+b.type.replace(/^validate/,"");c.settings[d]&&c.settings[d].call(c,this[0],b)}this.labelContainer=a(this.settings.errorLabelContainer),this.errorContext=this.labelContainer.length&&this.labelContainer||a(this.currentForm),this.containers=a(this.settings.errorContainer).add(this.settings.errorLabelContainer),this.submitted={},this.valueCache={},this.pendingRequest=0,this.pending={},this.invalid={},this.reset();var b=this.groups={};a.each(this.settings.groups,function(c,d){a.each(d.split(/\s/),function(a,d){b[d]=c})});var c=this.settings.rules;a.each(c,function(b,d){c[b]=a.validator.normalizeRule(d)}),a(this.currentForm).validateDelegate(":text, [type='password'], [type='file'], select, textarea, [type='number'], [type='search'] ,[type='tel'], [type='url'], [type='email'], [type='datetime'], [type='date'], [type='month'], [type='week'], [type='time'], [type='datetime-local'], [type='range'], [type='color'] ","focusin focusout keyup",d).validateDelegate("[type='radio'], [type='checkbox'], select, option","click",d),this.settings.invalidHandler&&a(this.currentForm).bind("invalid-form.validate",this.settings.invalidHandler)},form:function(){return this.checkForm(),a.extend(this.submitted,this.errorMap),this.invalid=a.extend({},this.errorMap),this.valid()||a(this.currentForm).triggerHandler("invalid-form",[this]),this.showErrors(),this.valid()},checkForm:function(){this.prepareForm();for(var a=0,b=this.currentElements=this.elements();b[a];a++)this.check(b[a]);return this.valid()},element:function(b){b=this.validationTargetFor(this.clean(b)),this.lastElement=b,this.prepareElement(b),this.currentElements=a(b);var c=this.check(b)!==!1;return c?delete this.invalid[b.name]:this.invalid[b.name]=!0,this.numberOfInvalids()||(this.toHide=this.toHide.add(this.containers)),this.showErrors(),c},showErrors:function(b){if(b){a.extend(this.errorMap,b),this.errorList=[];for(var c in b)this.errorList.push({message:b[c],element:this.findByName(c)[0]});this.successList=a.grep(this.successList,function(a){return!(a.name in b)})}this.settings.showErrors?this.settings.showErrors.call(this,this.errorMap,this.errorList):this.defaultShowErrors()},resetForm:function(){a.fn.resetForm&&a(this.currentForm).resetForm(),this.submitted={},this.lastElement=null,this.prepareForm(),this.hideErrors(),this.elements().removeClass(this.settings.errorClass).removeData("previousValue")},numberOfInvalids:function(){return this.objectLength(this.invalid)},objectLength:function(a){var b=0;for(var c in a)b++;return b},hideErrors:function(){this.addWrapper(this.toHide).hide()},valid:function(){return this.size()===0},size:function(){return this.errorList.length},focusInvalid:function(){if(this.settings.focusInvalid)try{a(this.findLastActive()||this.errorList.length&&this.errorList[0].element||[]).filter(":visible").focus().trigger("focusin")}catch(b){}},findLastActive:function(){var b=this.lastActive;return b&&a.grep(this.errorList,function(a){return a.element.name===b.name}).length===1&&b},elements:function(){var b=this,c={};return a(this.currentForm).find("input, select, textarea").not(":submit, :reset, :image, [disabled]").not(this.settings.ignore).filter(function(){return!this.name&&b.settings.debug&&window.console&&console.error("%o has no name assigned",this),this.name in c||!b.objectLength(a(this).rules())?!1:(c[this.name]=!0,!0)})},clean:function(b){return a(b)[0]},errors:function(){var b=this.settings.errorClass.replace(" ",".");return a(this.settings.errorElement+"."+b,this.errorContext)},reset:function(){this.successList=[],this.errorList=[],this.errorMap={},this.toShow=a([]),this.toHide=a([]),this.currentElements=a([])},prepareForm:function(){this.reset(),this.toHide=this.errors().add(this.containers)},prepareElement:function(a){this.reset(),this.toHide=this.errorsFor(a)},elementValue:function(b){var c=a(b).attr("type"),d=a(b).val();return c==="radio"||c==="checkbox"?a('input[name="'+a(b).attr("name")+'"]:checked').val():typeof d=="string"?d.replace(/\r/g,""):d},check:function(b){b=this.validationTargetFor(this.clean(b));var c=a(b).rules(),d=!1,e=this.elementValue(b),f;for(var g in c){var h={method:g,parameters:c[g]};try{f=a.validator.methods[g].call(this,e,b,h.parameters);if(f==="dependency-mismatch"){d=!0;continue}d=!1;if(f==="pending"){this.toHide=this.toHide.not(this.errorsFor(b));return}if(!f)return this.formatAndAdd(b,h),!1}catch(i){throw this.settings.debug&&window.console&&console.log("exception occured when checking element "+b.id+", check the '"+h.method+"' method",i),i}}if(d)return;return this.objectLength(c)&&this.successList.push(b),!0},customMetaMessage:function(b,c){if(!a.metadata)return;var d=this.settings.meta?a(b).metadata()[this.settings.meta]:a(b).metadata();return d&&d.messages&&d.messages[c]},customDataMessage:function(b,c){return a(b).data("msg-"+c.toLowerCase())||b.attributes&&a(b).attr("data-msg-"+c.toLowerCase())},customMessage:function(a,b){var c=this.settings.messages[a];return c&&(c.constructor===String?c:c[b])},findDefined:function(){for(var a=0;aWarning: No message defined for "+b.name+"")},formatAndAdd:function(b,c){var d=this.defaultMessage(b,c.method),e=/\$?\{(\d+)\}/g;typeof d=="function"?d=d.call(this,c.parameters,b):e.test(d)&&(d=a.validator.format(d.replace(e,"{$1}"),c.parameters)),this.errorList.push({message:d,element:b}),this.errorMap[b.name]=d,this.submitted[b.name]=d},addWrapper:function(a){return this.settings.wrapper&&(a=a.add(a.parent(this.settings.wrapper))),a},defaultShowErrors:function(){var a,b;for(a=0;this.errorList[a];a++){var c=this.errorList[a];this.settings.highlight&&this.settings.highlight.call(this,c.element,this.settings.errorClass,this.settings.validClass),this.showLabel(c.element,c.message)}this.errorList.length&&(this.toShow=this.toShow.add(this.containers));if(this.settings.success)for(a=0;this.successList[a];a++)this.showLabel(this.successList[a]);if(this.settings.unhighlight)for(a=0,b=this.validElements();b[a];a++)this.settings.unhighlight.call(this,b[a],this.settings.errorClass,this.settings.validClass);this.toHide=this.toHide.not(this.toShow),this.hideErrors(),this.addWrapper(this.toShow).show()},validElements:function(){return this.currentElements.not(this.invalidElements())},invalidElements:function(){return a(this.errorList).map(function(){return this.element})},showLabel:function(b,c){var d=this.errorsFor(b);d.length?(d.removeClass(this.settings.validClass).addClass(this.settings.errorClass),d.attr("generated")&&d.html(c)):(d=a("<"+this.settings.errorElement+"/>").attr({"for":this.idOrName(b),generated:!0}).addClass(this.settings.errorClass).html(c||""),this.settings.wrapper&&(d=d.hide().show().wrap("<"+this.settings.wrapper+"/>").parent()),this.labelContainer.append(d).length||(this.settings.errorPlacement?this.settings.errorPlacement(d,a(b)):d.insertAfter(b))),!c&&this.settings.success&&(d.text(""),typeof this.settings.success=="string"?d.addClass(this.settings.success):this.settings.success(d,b)),this.toShow=this.toShow.add(d)},errorsFor:function(b){var c=this.idOrName(b);return this.errors().filter(function(){return a(this).attr("for")===c})},idOrName:function(a){return this.groups[a.name]||(this.checkable(a)?a.name:a.id||a.name)},validationTargetFor:function(a){return this.checkable(a)&&(a=this.findByName(a.name).not(this.settings.ignore)[0]),a},checkable:function(a){return/radio|checkbox/i.test(a.type)},findByName:function(b){return a(this.currentForm).find('[name="'+b+'"]')},getLength:function(b,c){switch(c.nodeName.toLowerCase()){case"select":return a("option:selected",c).length;case"input":if(this.checkable(c))return this.findByName(c.name).filter(":checked").length}return b.length},depend:function(a,b){return this.dependTypes[typeof a]?this.dependTypes[typeof a](a,b):!0},dependTypes:{"boolean":function(a,b){return a},string:function(b,c){return!!a(b,c.form).length},"function":function(a,b){return a(b)}},optional:function(b){var c=this.elementValue(b);return!a.validator.methods.required.call(this,c,b)&&"dependency-mismatch"},startRequest:function(a){this.pending[a.name]||(this.pendingRequest++,this.pending[a.name]=!0)},stopRequest:function(b,c){this.pendingRequest--,this.pendingRequest<0&&(this.pendingRequest=0),delete this.pending[b.name],c&&this.pendingRequest===0&&this.formSubmitted&&this.form()?(a(this.currentForm).submit(),this.formSubmitted=!1):!c&&this.pendingRequest===0&&this.formSubmitted&&(a(this.currentForm).triggerHandler("invalid-form",[this]),this.formSubmitted=!1)},previousValue:function(b){return a.data(b,"previousValue")||a.data(b,"previousValue",{old:null,valid:!0,message:this.defaultMessage(b,"remote")})}},classRuleSettings:{required:{required:!0},email:{email:!0},url:{url:!0},date:{date:!0},dateISO:{dateISO:!0},number:{number:!0},digits:{digits:!0},creditcard:{creditcard:!0}},addClassRules:function(b,c){b.constructor===String?this.classRuleSettings[b]=c:a.extend(this.classRuleSettings,b)},classRules:function(b){var c={},d=a(b).attr("class");return d&&a.each(d.split(" "),function(){this in a.validator.classRuleSettings&&a.extend(c,a.validator.classRuleSettings[this])}),c},attributeRules:function(b){var c={},d=a(b);for(var e in a.validator.methods){var f;e==="required"?(f=d.get(0).getAttribute(e),f===""&&(f=!0),f=!!f):f=d.attr(e),f?c[e]=f:d[0].getAttribute("type")===e&&(c[e]=!0)}return c.maxlength&&/-1|2147483647|524288/.test(c.maxlength)&&delete c.maxlength,c},metadataRules:function(b){if(!a.metadata)return{};var c=a.data(b.form,"validator").settings.meta;return c?a(b).metadata()[c]:a(b).metadata()},staticRules:function(b){var c={},d=a.data(b.form,"validator");return d.settings.rules&&(c=a.validator.normalizeRule(d.settings.rules[b.name])||{}),c},normalizeRules:function(b,c){return a.each(b,function(d,e){if(e===!1){delete b[d];return}if(e.param||e.depends){var f=!0;switch(typeof e.depends){case"string":f=!!a(e.depends,c.form).length;break;case"function":f=e.depends.call(c,c)}f?b[d]=e.param!==undefined?e.param:!0:delete b[d]}}),a.each(b,function(d,e){b[d]=a.isFunction(e)?e(c):e}),a.each(["minlength","maxlength","min","max"],function(){b[this]&&(b[this]=Number(b[this]))}),a.each(["rangelength","range"],function(){b[this]&&(b[this]=[Number(b[this][0]),Number(b[this][1])])}),a.validator.autoCreateRanges&&(b.min&&b.max&&(b.range=[b.min,b.max],delete b.min,delete b.max),b.minlength&&b.maxlength&&(b.rangelength=[b.minlength,b.maxlength],delete b.minlength,delete b.maxlength)),b.messages&&delete b.messages,b},normalizeRule:function(b){if(typeof b=="string"){var c={};a.each(b.split(/\s/),function(){c[this]=!0}),b=c}return b},addMethod:function(b,c,d){a.validator.methods[b]=c,a.validator.messages[b]=d!==undefined?d:a.validator.messages[b],c.length<3&&a.validator.addClassRules(b,a.validator.normalizeRule(b))},methods:{required:function(b,c,d){if(!this.depend(d,c))return"dependency-mismatch";if(c.nodeName.toLowerCase()==="select"){var e=a(c).val();return e&&e.length>0}return this.checkable(c)?this.getLength(b,c)>0:a.trim(b).length>0},remote:function(b,c,d){if(this.optional(c))return"dependency-mismatch";var e=this.previousValue(c);this.settings.messages[c.name]||(this.settings.messages[c.name]={}),e.originalMessage=this.settings.messages[c.name].remote,this.settings.messages[c.name].remote=e.message,d=typeof d=="string"&&{url:d}||d;if(this.pending[c.name])return"pending";if(e.old===b)return e.valid;e.old=b;var f=this;this.startRequest(c);var g={};return g[c.name]=b,a.ajax(a.extend(!0,{url:d,mode:"abort",port:"validate"+c.name,dataType:"json",data:g,success:function(d){f.settings.messages[c.name].remote=e.originalMessage;var g=d===!0||d==="true";if(g){var h=f.formSubmitted;f.prepareElement(c),f.formSubmitted=h,f.successList.push(c),delete f.invalid[c.name],f.showErrors()}else{var i={},j=d||f.defaultMessage(c,"remote");i[c.name]=e.message=a.isFunction(j)?j(b):j,f.invalid[c.name]=!0,f.showErrors(i)}e.valid=g,f.stopRequest(c,g)}},d)),"pending"},minlength:function(b,c,d){var e=a.isArray(b)?b.length:this.getLength(a.trim(b),c);return this.optional(c)||e>=d},maxlength:function(b,c,d){var e=a.isArray(b)?b.length:this.getLength(a.trim(b),c);return this.optional(c)||e<=d},rangelength:function(b,c,d){var e=a.isArray(b)?b.length:this.getLength(a.trim(b),c);return this.optional(c)||e>=d[0]&&e<=d[1]},min:function(a,b,c){return this.optional(b)||a>=c},max:function(a,b,c){return this.optional(b)||a<=c},range:function(a,b,c){return this.optional(b)||a>=c[0]&&a<=c[1]},email:function(a,b){return this.optional(b)||/^((([a-z]|\d|[!#\$%&'\*\+\-\/=\?\^_`{\|}~]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+(\.([a-z]|\d|[!#\$%&'\*\+\-\/=\?\^_`{\|}~]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+)*)|((\x22)((((\x20|\x09)*(\x0d\x0a))?(\x20|\x09)+)?(([\x01-\x08\x0b\x0c\x0e-\x1f\x7f]|\x21|[\x23-\x5b]|[\x5d-\x7e]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(\\([\x01-\x09\x0b\x0c\x0d-\x7f]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]))))*(((\x20|\x09)*(\x0d\x0a))?(\x20|\x09)+)?(\x22)))@((([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])*([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])))\.)+(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])*([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])))$/i.test(a)},url:function(a,b){return this.optional(b)||/^(https?|ftp):\/\/(((([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(%[\da-f]{2})|[!\$&'\(\)\*\+,;=]|:)*@)?(((\d|[1-9]\d|1\d\d|2[0-4]\d|25[0-5])\.(\d|[1-9]\d|1\d\d|2[0-4]\d|25[0-5])\.(\d|[1-9]\d|1\d\d|2[0-4]\d|25[0-5])\.(\d|[1-9]\d|1\d\d|2[0-4]\d|25[0-5]))|((([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])*([a-z]|\d|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])))\.)+(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])*([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])))\.?)(:\d*)?)(\/((([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(%[\da-f]{2})|[!\$&'\(\)\*\+,;=]|:|@)+(\/(([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(%[\da-f]{2})|[!\$&'\(\)\*\+,;=]|:|@)*)*)?)?(\?((([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(%[\da-f]{2})|[!\$&'\(\)\*\+,;=]|:|@)|[\uE000-\uF8FF]|\/|\?)*)?(\#((([a-z]|\d|-|\.|_|~|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])|(%[\da-f]{2})|[!\$&'\(\)\*\+,;=]|:|@)|\/|\?)*)?$/i.test(a)},date:function(a,b){return this.optional(b)||!/Invalid|NaN/.test(new Date(a))},dateISO:function(a,b){return this.optional(b)||/^\d{4}[\/\-]\d{1,2}[\/\-]\d{1,2}$/.test(a)},number:function(a,b){return this.optional(b)||/^-?(?:\d+|\d{1,3}(?:,\d{3})+)?(?:\.\d+)?$/.test(a)},digits:function(a,b){return this.optional(b)||/^\d+$/.test(a)},creditcard:function(a,b){if(this.optional(b))return"dependency-mismatch";if(/[^0-9 \-]+/.test(a))return!1;var c=0,d=0,e=!1;a=a.replace(/\D/g,"");for(var f=a.length-1;f>=0;f--){var g=a.charAt(f);d=parseInt(g,10),e&&(d*=2)>9&&(d-=9),c+=d,e=!e}return c%10===0},equalTo:function(b,c,d){var e=a(d);return this.settings.onfocusout&&e.unbind(".validate-equalTo").bind("blur.validate-equalTo",function(){a(c).valid()}),b===e.val()}}}),a.format=a.validator.format})(jQuery),function(a){var b={};if(a.ajaxPrefilter)a.ajaxPrefilter(function(a,c,d){var e=a.port;a.mode==="abort"&&(b[e]&&b[e].abort(),b[e]=d)});else{var c=a.ajax;a.ajax=function(d){var e=("mode"in d?d:a.ajaxSettings).mode,f=("port"in d?d:a.ajaxSettings).port;return e==="abort"?(b[f]&&b[f].abort(),b[f]=c.apply(this,arguments)):c.apply(this,arguments)}}}(jQuery),function(a){!jQuery.event.special.focusin&&!jQuery.event.special.focusout&&document.addEventListener&&a.each({focus:"focusin",blur:"focusout"},function(b,c){function d(b){return b=a.event.fix(b),b.type=c,a.event.handle.call(this,b)}a.event.special[c]={setup:function(){this.addEventListener(b,d,!0)},teardown:function(){this.removeEventListener(b,d,!0)},handler:function(b){var d=arguments;return d[0]=a.event.fix(b),d[0].type=c,a.event.handle.apply(this,d)}}}),a.extend(a.fn,{validateDelegate:function(b,c,d){return this.bind(c,function(c){var e=a(c.target);if(e.is(b))return d.apply(e,arguments)})}})}(jQuery) \ No newline at end of file http://cdn.jsdelivr.net/jquery.validation/1.13.1/jquery.validate.min.js This is an older version. And the newer one is only MIT license. Does this pose a problem for Koha's GPL3 nature? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 02:56:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 00:56:09 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 02:56:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 00:56:13 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #22 from M. Tompsett --- Created attachment 38707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38707&action=edit Bug 5685: Add missing about information In comment #20, Katrin requested the about page be updated to reflect the addition of a jquery plugin. TEST PLAN --------- 1) Apply all patches 2) Log in to Staff Client 3) Home -> About Koha -> Licenses -- jQuery Validation Plugin is now listed nicely. 4) Run koha qa test tools -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 02:56:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 00:56:44 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38063|0 |1 is obsolete| | --- Comment #23 from M. Tompsett --- Created attachment 38708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38708&action=edit Bug 5685: Validation of email address field This patch adds server-side & client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, "Library use", "Alternate address", "Alternative contact"). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? Signed-off-by: Owen Leonard I have undone the changes to opac.css so that they can be submitted as a separate patch. I have some other follow-ups to make as well. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 02:56:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 00:56:50 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38064|0 |1 is obsolete| | --- Comment #24 from M. Tompsett --- Created attachment 38709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38709&action=edit Bug 5685 [Compiled CSS] Validation of email address field This patch contains the recompiled opac.css file based on changes made to opac.less in the previous patch. Signed-off-by: Nicole Engard FIXED the compress. - mtompset -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 02:56:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 00:56:58 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38065|0 |1 is obsolete| | --- Comment #25 from M. Tompsett --- Created attachment 38710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38710&action=edit Bug 5685 [OPAC follow-up] Validation of email address field This patch makes a few changes to the way errors are handled in the OPAC: - The validation plugin has been moved from the global include file to the template itself. Since we aren't doing form validation on any other page yet it doesn't make sense to include it globally at this time. - The error message which appears if you have JavaScript disabled and have submitted invalid emails was styled in a non-standard way. - I have added in-page links to the error message which appears if you have JavaScript disabled so that you can click to jump to the field which contains the error. - I have modified the error message language slightly to make it (I hope) read better. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 02:57:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 00:57:05 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38707|0 |1 is obsolete| | --- Comment #26 from M. Tompsett --- Created attachment 38711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38711&action=edit Bug 5685: Add missing about information In comment #20, Katrin requested the about page be updated to reflect the addition of a jquery plugin. TEST PLAN --------- 1) Apply all patches 2) Log in to Staff Client 3) Home -> About Koha -> Licenses -- jQuery Validation Plugin is now listed nicely. 4) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 04:33:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 02:33:14 +0000 Subject: [Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 04:33:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 02:33:17 +0000 Subject: [Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38316|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 38712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38712&action=edit Bug 10913: The delete basket confirmation page is never displayed This condition is never reached, the confirmation to delete a basket is done with a popup in the template. Test plan: Confirm you don't find any regression when creation/editing and deleting a basket. Signed-off-by: Mark Tompsett NOTE: I didn't create or edit. However, the only perl script that uses the template is acqui/basket.pl and the only place delete_confirm is set in acqui/basket.pl is in that code which is only called if del_basket actually existed anywhere else, which it doesn't. I did have two baskets, one with two transfers from the first, so I transferred one back, and then proceeded to test the two delete buttons in the modal. No issues. Cancel (to close the modal) works too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 07:31:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 05:31:01 +0000 Subject: [Koha-bugs] [Bug 12369] serial history notes not editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12369 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Still valid. It used to be that you could edit the manual history anytime. Now it's that you have to have checked the checkbox in the subscription and then you can edit it from the tabs in the subscription detail view. BUT: it will no longer update automatically then in my tests :( I think this changed with the changes to the serial module and is quite a change of behaviour compared to 3.12? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 07:33:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 05:33:05 +0000 Subject: [Koha-bugs] [Bug 12369] serial history notes not editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12369 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11843 --- Comment #3 from Katrin Fischer --- See. bug 11843. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 07:33:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 05:33:05 +0000 Subject: [Koha-bugs] [Bug 11843] Manual subscription history doesn't seem to work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12369 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 08:09:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 06:09:47 +0000 Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 08:09:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 06:09:49 +0000 Subject: [Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38646|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 38713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38713&action=edit Bug 12192: Template toolkit code in HTML attributes is picked up into po-files This patch gives a partial solution for this problem. It ignores strings like "[% something %]", but not "[% IF ( value ) %][% value %][% END %]" We get 100+ strings less to translate To test: 1) Update translation files for your preferred language 2) Apply the patch 3) Update again 4) Compare, you must find 100+ strings removed from translation files eg. -msgid "[% SEARCH_RESULT.biblionumber |url %]" -msgid "[% accepteddate | $KohaDates %]" -msgid "[% amountoutstanding | format('%.2f') %]" -msgid "[% authtypetext |html %]" -msgid "[% barcode_llx |html %]" -msgid "[% barcode_lly |html %]" -msgid "[% biblio.quantity.length ? biblio.quantity : 1 %]" -msgid "[% billingdate | $KohaDates %]" -msgid "[% borname |html %]" ... Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Verified all strings removed from the po files were pure TT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 08:21:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 06:21:00 +0000 Subject: [Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 08:21:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 06:21:03 +0000 Subject: [Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38712|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 38714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38714&action=edit [PASSED QA] Bug 10913: The delete basket confirmation page is never displayed This condition is never reached, the confirmation to delete a basket is done with a popup in the template. Test plan: Confirm you don't find any regression when creation/editing and deleting a basket. Signed-off-by: Mark Tompsett NOTE: I didn't create or edit. However, the only perl script that uses the template is acqui/basket.pl and the only place delete_confirm is set in acqui/basket.pl is in that code which is only called if del_basket actually existed anywhere else, which it doesn't. I did have two baskets, one with two transfers from the first, so I transferred one back, and then proceeded to test the two delete buttons in the modal. No issues. Cancel (to close the modal) works too. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 08:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 06:42:03 +0000 Subject: [Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 08:43:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 06:43:28 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #16 from Katrin Fischer --- A first thought: Should we also take care of the auth_subfield_structure table? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:08:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:08:41 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #27 from Marc V?ron --- Created attachment 38715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38715&action=edit [Signed-off] Bug 5685: Add missing about information In comment #20, Katrin requested the about page be updated to reflect the addition of a jquery plugin. TEST PLAN --------- 1) Apply all patches 2) Log in to Staff Client 3) Home -> About Koha -> Licenses -- jQuery Validation Plugin is now listed nicely. 4) Run koha qa test tools License appears as expected, qa OK Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:09:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:09:52 +0000 Subject: [Koha-bugs] [Bug 5685] Validation of email address field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:17:47 +0000 Subject: [Koha-bugs] [Bug 14096] New: Licences on About page not consistently linked Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14096 Bug ID: 14096 Summary: Licences on About page not consistently linked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: About Assignee: nengard at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Some components on the About page have links to their license and others not. Example: jquery.multiple.select.js - not linked Javascript Diff Algorithm - linked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:25:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:25:57 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #17 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > A first thought: Should we also take care of the auth_subfield_structure > table? The only place where the collate utf8_bin was used before bug 11944 was on marc_subfield_structure.tagsubfield. If we want to change it for auth_subfield_structure.tagsubfield it won't be a bugfix but an enh and should be done in another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:31:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:31:19 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #11 from Jonathan Druart --- (In reply to Katrin Fischer from comment #10) > OPAC view: Open in new window. still opens in the same tab for me :( Please detail, what does not work? Clicking on what and how (middle click, left click, ctrl+click)? I confirm it works here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:34:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:34:10 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #18 from Katrin Fischer --- Hi Jonathan, cool - I didn't check. This should bring us back to the before-state then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:36:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:36:40 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 --- Comment #7 from Jonathan Druart --- (In reply to Christopher Brannon from comment #6) > Actually, on 3.18, which we just upgraded to, we are seeing the opposite > now. The first page of notices works as expected, but when you go to the > next page, everything is expanded, and cannot be collapsed! If you change > view to more than 20 at a time, the first 20 are normal and the rest are > expanded. Very weird! > > Christopher Confirmed on 3.18.x and master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:36:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:36:47 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |3.18 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:36:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:36:51 +0000 Subject: [Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Katrin Fischer --- After sleeping over it, I think it might be out of scope of the bug. But there is another bug related to the link rewriting: If you set your OpacBaseUrl we display a link to the OPAC in the details page, that opens in a new tab by default - but currently this doesn't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:36:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:36:58 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Severity|major |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:41:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:41:48 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:41:51 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34581|0 |1 is obsolete| | Attachment #34583|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 38716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38716&action=edit Bug 13421: Add the creation time for virtual shelves Test plan: 1/ Execute the updatedb entry 2/ Create a list 3/ Go on the shelve list and confirm that the creation and last modification time are now displayed. 4/ Confirm that you are able to sort the list by creation/modification time. Applied on top of 13419 (rebased updatedatabase.pl) Works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 09:42:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 07:42:33 +0000 Subject: [Koha-bugs] [Bug 13421] Add the creation time for virtual shelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13421 --- Comment #11 from Jonathan Druart --- Created attachment 38717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38717&action=edit Bug 13421 - Change creation_time to created_on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 10:06:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 08:06:55 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 10:06:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 08:06:58 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 --- Comment #13 from Jonathan Druart --- Created attachment 38718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38718&action=edit Bug 14044: Don't escape html characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 10:09:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 08:09:16 +0000 Subject: [Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 --- Comment #14 from Jonathan Druart --- (In reply to Katrin Fischer from comment #12) > Sorry, I found another something - try adding a " to the address data - it > will display as " on the patron result list. Yes, either we escape html characters or not :) It seems that there are not in other places, but in this case if a
    is found, it will make the table explodes. But... who does put these tags or quote in an address field? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 11:19:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 09:19:46 +0000 Subject: [Koha-bugs] [Bug 14097] New: Add unit tests to C4::UsageStats Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Bug ID: 14097 Summary: Add unit tests to C4::UsageStats Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Test Suite Assignee: julian.fiol at biblibre.com Reporter: julian.fiol at biblibre.com QA Contact: gmcharlt at gmail.com DESCRIPTION ----------- Add unit tests to C4::UsageStats Subroutine : (V : tested, X : Not tested) V NeedUpdate V BuiltReport X ReportToCommunity V _count TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/UsageStats.t -- All tests should run successfully /!\ I have 1 warning but I don't know where it can come /!\ (in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308 TEST PLAN OPTIONAL ------------------ Go check bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 40,5% Branch : 0,0% Condition : 0,0% Subroutine : 55,6% Coverage AFTER this patch : Statement : 81,0% Branch : 100,0% Condition : 100,0% Subroutine : 88,8% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 11:21:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 09:21:30 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Julian FIOL changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 11:21:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 09:21:33 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #1 from Julian FIOL --- Created attachment 38719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38719&action=edit Bug 14097 : Testing C4::UsageStats DESCRIPTION ----------- Add unit tests to C4::UsageStats Subroutine : (V : tested, X : Not tested) V NeedUpdate V BuiltReport X ReportToCommunity V _count TEST PLAN --------- 1. Apply patch 2. prove -v t/db_dependent/UsageStats.t -- All tests should run successfully /!\ I have 1 warning but I don't know where it can come /!\ (in cleanup) DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308 TEST PLAN OPTIONAL ------------------ Go check bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 40,5% Branch : 0,0% Condition : 0,0% Subroutine : 55,6% Coverage AFTER this patch : Statement : 81,0% Branch : 100,0% Condition : 100,0% Subroutine : 88,8% -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 11:29:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 09:29:35 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se --- Comment #11 from Andreas Hedstr?m Mace --- Also very interested in this. Any progress lately? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 14:36:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 12:36:03 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Got following error: t/db_dependent/UsageStats.t .. 1/552 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_kohadev`.`issues`, CONSTRAINT `issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE) at t/db_dependent/UsageStats.t line 45. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_kohadev`.`issues`, CONSTRAINT `issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE) at t/db_dependent/UsageStats.t line 45. # Looks like you planned 552 tests but ran 9. # Looks like your test exited with 255 just after 9. t/db_dependent/UsageStats.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 543/552 subtests After that, my DB seems to be broken, can not langer search, get: No results found You did not specify any search criteria. Error: Can't call method "raw" on an undefined value at /usr/share/kohaclone/C4/Search.pm line 799. Not sure what happend. Will have to restore my VM from yesterday's backup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 15:32:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 13:32:46 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38644|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 38720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38720&action=edit [SIGNED-OFF] Bug 14069: Drop existing primary key on items if exists On old databases, the issues table has a primary key on itemnumber. The DBrev 3.19.00.028 (Bug 13790 - Add unique id issue_id to issues and oldissues tables) has to remove it before adding the new primary key Test plan: 1/ Make sure you have an old DB, or add primary key (issues.itemnumber)manually on a DB created before 3.19.00.028. 2/ Execute the updatedatabase.pl script 3/ You should not get any error and the primary key on itemnumber should have been removed and the new one created as expected. Signed-off-by: Bernardo Gonzalez Kriegel No koha-qa errors Tested using a 3.4 db (3.0404000) Interestingly, it gives a similar error on the same table but on another (older $DBversion = "3.05.00.009";) update 1) Pre-patch, 3.4 DB, updatedatabase from master, errors (older) DBD::mysql::db do failed: Multiple primary key defined at installer/data/mysql/updatedatabase.pl line 4435. (13790) DBD::mysql::db do failed: Multiple primary key defined at installer/data/mysql/updatedatabase.pl line 10166. DBD::mysql::db do failed: Unknown column 'issue_id' in 'order clause' at installer/data/mysql/updatedatabase.pl line 10170. DBD::mysql::st execute failed: Unknown column 'me.issue_id' in 'field list' at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1593. DBIx::Class::ResultSetColumn::max(): Unknown column 'me.issue_id' in 'field list' at installer/data/mysql/updatedatabase.pl line 10174 2) Post-patch, same conditions (only older) DBD::mysql::db do failed: Multiple primary key defined at installer/data/mysql/updatedatabase.pl line 4435. There are other warnings, but nor related with keys. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 15:34:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 13:34:08 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 15:46:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 13:46:58 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #3 from Marc V?ron --- Ok, restored VM, tested with same failure as above. No problem with database after testing. Do not now what happend to break it before. Question: What happens if the script stops / exits / fails for whatever reason after following lines? my $dbh = C4::Context->dbh; $dbh->{AutoCommit} = 0; $dbh->{RaiseError} = 1; $dbh->do('DELETE FROM biblio'); $dbh->do('DELETE FROM items'); $dbh->do('DELETE FROM auth_header'); $dbh->do('DELETE FROM old_issues'); $dbh->do('DELETE FROM old_reserves'); $dbh->do('DELETE FROM borrowers'); $dbh->do('DELETE FROM aqorders'); $dbh->do('DELETE FROM subscription'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:27:58 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31139|0 |1 is obsolete| | --- Comment #28 from M. Tompsett --- Created attachment 38721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38721&action=edit Bug 12167: Invalid results check for opac_news test C4/NewsChannels.pm has a function GetNewsToDisplay at the end of the file. It returns an array reference (i.e. one result). t/db_dependent/NewsChannels.t has a test which expects two values. This is likely a cut and paste error on my part. Notice get_opac_news returns an array of two things. TEST PLAN --------- 1) prove -v t/db_dependent/NewsChannels.t -- magically the wrong condition still passes. 2) apply this first patch only. 3) prove -v t/db_dependent/NewsChannels.t -- notice the second result value is UNDEFINED. -- notice the first result is an array reference. -- and the last test passes, because unless somehow the array reference was less than 2, it will pass. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer Tested news expiration and publication dates: - publication date today, expiration date tomorrow: shows - publication date tomorrow, expiration date later: doesn't show - publication date yesterday, expiration date today: shows - publication date some time ago, expiration date yesterday: doesn't show - publication date today, expiration date empty: shows Passes all tests and QA script, no problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:28:05 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #29 from M. Tompsett --- Created attachment 38722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38722&action=edit Bug 12167: Bad expected results and condition check for GetNewsToDisplay This corrected the results expected to a single array reference. It then determines that it is defined and an array reference. And lastly, correct the logic that was supposed to check for valid results. TEST PLAN --------- 1) Apply patch 1 and 2. 2) prove -v t/db_dependent/NewsChannels.t -- all tests should pass -- note the test changes to verify correctly what should be tested for. Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:28:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:28:11 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #30 from M. Tompsett --- Created attachment 38723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38723&action=edit Bug 12167: Clean up GetNewsToDisplay This bug started out as a result of busting while in transitions of MySQL were happening in Ubuntu. However, I figured this fix should remove backtick MySQLisms as per http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL6:_Backticks And clean up GetNewsToDisplay a bit. TEST PLAN --------- 1) News should function fine before applying any patches. 2) Apply all patches. 3) prove -v t/db_dependent/NewsChannels.t -- expecting all happy results. -- note the removal of backticks and the assumed typecasting of a timestamp to date. -- specified opac_news.timestamp to make sure that it would more likely parse as a fieldname and not as a keyword. Signed-off-by: Bernardo Gonzalez Kriegel All patches applied, test pass, cleaner code, no regressions found, no koha-qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:28:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:28:16 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #31 from M. Tompsett --- Created attachment 38724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38724&action=edit Bug 12167: Made SQL even more ANSI SQL. The comparison against '00-00-0000' is not possible under PostgreSQL. By providing a database upgrade which replaces all '0000-00-00' dates with NULL, this portion of the SQL query can be removed. Additionally, MySQL can handle CURRENT_DATE(), but PostgreSQL barfs horribly. By removing the ()'s, it functions in both. The NewsChannels.t specifically added an explanationdate IS NULL case to catch what was not tested before. TEST PLAN --------- 1) Apply patch. 2) ./installer/data/mysql/updatedatabase.pl 3) prove -v t/db_dependent/NewsChannels.t -- This will confirm that the modified GetNewsToDisplay function has not broken. Signed-off-by: Bernardo Gonzalez Kriegel Update database runs without problem, test pass, no koha-qa errors. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:28:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:28:56 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:29:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:29:07 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:29:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:29:16 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30884|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:29:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:29:24 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30885|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:29:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:29:42 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:36:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:36:29 +0000 Subject: [Koha-bugs] [Bug 14098] New: Regression in Marc Modification Templates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Bug ID: 14098 Summary: Regression in Marc Modification Templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In previous versions of Koha, a marc modfication rules like "Copy field XXX$Y to 952$x" would add the field to an existing 952 field if there was one already, and only create a 952 field if none existed. Now an entirely new 952 field is created to store the subfield even if there is already one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:36:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:36:43 +0000 Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:37:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:37:23 +0000 Subject: [Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #32 from M. Tompsett --- I rebased this, even though I am still working on something based on comment #27. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:55:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:55:09 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Kyle M Hall --- C4::VirtualShelves has no unit tests. Further complicating the issue is that the code relies on CGI objects. I think the two small changes I made to C4::VirtualShelves::Page are pretty obvious and won't cause regressions. I can't imagine that this one small feature would justify rewriting VirtualShelves, but I do agree it could use a rewrite. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:56:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:56:17 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org Status|Pushed to Master |In Discussion --- Comment #21 from Christopher Brannon --- Found an issue with this patch. Although most content now appears on first printing, it appears that the items.holdingbranch has incorrect data on first scan of item. It seems it prints the library code of the library receiving the item on the first scan. If you scan it again, it then shows the correct library code (the library that is scanning the item). Before the patch, this field was blank on first scan. Now it has the incorrect information on first scan. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 16:59:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 14:59:21 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38496|0 |1 is obsolete| | Attachment #38497|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 38725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38725&action=edit Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:02:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:02:33 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #15 from Kyle M Hall --- Created attachment 38726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38726&action=edit Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:19:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:19:23 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #22 from Katrin Fischer --- Hi Christopher, this patch is already pushed - so it would be better to have the problem description on a separate bug depending on this one and linkng them. Can you tell which slip is the one that prints the wrong information? With a step by step instruction maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:19:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:19:30 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:29:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:29:43 +0000 Subject: [Koha-bugs] [Bug 14099] New: RESERVESLIP shows incorrect information in items.holdingbranch on first scan Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099 Bug ID: 14099 Summary: RESERVESLIP shows incorrect information in items.holdingbranch on first scan Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This bug depends on Bug 13482, which fixes information being printed on the RESERVESLIP on first scan. Before, not all information was being populated on the slip after the first scan for holds being sent to another library. Now, information is always populated, but I have found the items.holdingbranch to be holding the incorrect value on the first scan. When you scan the item a seconde time, the value is correct. To reproduce problem: 1) Include the items.holdingbranch field on the RESERVESLIP. 2) Place a hold on an item to be picked up at a different branch. 3) Check in the item and print the slip. Notice that the items.holdingbranch field is populated with the library the item is being sent to, not your library. 4) Check in the item again and print the slip again. Notice now that the items.holdingbranch field is populated with the library the item is being scanned at (the correct location). Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:31:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:31:00 +0000 Subject: [Koha-bugs] [Bug 14099] RESERVESLIP shows incorrect information in items.holdingbranch on first scan In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14099 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13482 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:31:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:31:00 +0000 Subject: [Koha-bugs] [Bug 13482] A race condition prevents item info from being available for ReserveSlip (hold notice) printing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13482 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14099 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:34:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:34:01 +0000 Subject: [Koha-bugs] [Bug 14100] New: Generic solution for language overlay Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Bug ID: 14100 Summary: Generic solution for language overlay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: new feature Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart at biblibre.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The idea is to implement a global solution to make item types, branch names, sysprefs value and authorised values translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:34:16 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14063, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14064 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:34:16 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14100 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:34:16 +0000 Subject: [Koha-bugs] [Bug 14064] Implement language overlay for item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14064 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14100 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 17:59:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 15:59:26 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #1 from Jonathan Druart --- Created attachment 38727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38727&action=edit Bug 14100: [POC] Generic solution for language overlay This is a proof of concept! Test plan: 1/ update the Schema (misc/devel/update_dbix_class_files.pl) 2/ Translate templates for some languages (es-DE, de-DE for instance) 3/ Enable them in the pref (search for 'lang') for the staff interface 4/ Go on the item type admin page (admin/itemtypes.pl) 5/ Edit one 6/ Click on the 'translate for other languages' link 7/ You are now on the interface to translate the item type's description in the languages you want. So translate some :) 8/ Go back on the item type list view (admin/itemtypes.pl) 9/ You should see the original description (non translated) 10/ Switch the language 11/ You should see the translated description in the correct language. If the description is non translated, the original description is displayed. Think further / Todo: 1/ Update all occurrences of the item type's description 2/ Implement for authorised values 3/ Implement for syspref value (at least textarea) 4/ Implement for branch names 5/ Centralize all the translation on a single page in the admin area ... N/ Implement a webservice to centralize all the translations and give the ability to sync the item types/authorised values description with the rest of the world (push and pull). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 19:11:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 17:11:05 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |mtompset at hotmail.com --- Comment #23 from M. Tompsett --- Since it is my patch that needs sign off. See comment #21 for a test plan. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 20:34:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 18:34:26 +0000 Subject: [Koha-bugs] [Bug 1487] Set only the used fields/subfields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1487 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 20:35:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 18:35:03 +0000 Subject: [Koha-bugs] [Bug 11814] Serial statuses should be stored in constants In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #29 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 20:48:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 18:48:38 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 --- Comment #5 from M. Tompsett --- I checked the SQL syntax. I tweaked the SQL to not fail for me. Current master needs: sudo apt-get install libgraphics-colornames-perl sudo apt-get install libimage-size-perl sudo apt-get install libhtml-tidy-perl cpan2deb PDF::Writer sudo dpkg -i libpdf-writer-perl_0.06-1_all.deb cpan2deb PDF::FromHTML sudo dpkg -i libpdf-fromhtml-perl_0.31-1_all.deb I did not check performance, though I doubt this would hinder it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 20:49:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 18:49:10 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38568|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 38728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38728&action=edit Bug 14053 - Acquisition db tables are missing indexes Acquisition db tables have a lot of relational constraints and are often missing an index to have performance queries. This patch adds an index for all columns used in a forein key. Also adds an index on some columns very often used in search queries : aqbooksellers.name and aqbudgets.budget_code. Also adds an index on aqorders.orderstatus, very often used with hardcoded value like 'cancelled', in various queries. Test plan : - Check SQL syntax is correct - Try to compare performance after and before database update. I think query contained in C4::Acquistion::GetInvoices could be a good example Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 20:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 18:49:17 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38569|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 38729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38729&action=edit Bug 14053 - Acquisition db tables are missing indexes - atomicupdates Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 20:51:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 18:51:06 +0000 Subject: [Koha-bugs] [Bug 14101] New: auto renewal is tied to 'no renewal before' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Bug ID: 14101 Summary: auto renewal is tied to 'no renewal before' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It seems as though the autorenewal feature needs to have the column "no renewal before" filled in or it will auto renew everyday after the duedate I'm not sure (haven't had time to test) how this effects auto renewals that happen from the check box on the check out screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 20:52:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 18:52:01 +0000 Subject: [Koha-bugs] [Bug 14053] Acquisition db tables are missing indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14053 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from M. Tompsett --- Fridolin, could you please confirm my tweaks? See comment #5 about issues you may encounter. If it works for you, then feel free to set it to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 21:34:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 19:34:45 +0000 Subject: [Koha-bugs] [Bug 7843] Create RSS for OPAC news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #30 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Viktor! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 21:35:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 19:35:13 +0000 Subject: [Koha-bugs] [Bug 6059] Problem with changing quantity on uncertain prices list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 21:39:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 19:39:18 +0000 Subject: [Koha-bugs] [Bug 14102] New: item search export should include itemnumber Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14102 Bug ID: 14102 Summary: item search export should include itemnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice if the item search csv included itemnumber for items without barcodes that you might want to batch modify. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 21:42:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 19:42:26 +0000 Subject: [Koha-bugs] [Bug 7939] Separate po files for different MARC dialects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7939 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #19 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 21:43:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 19:43:01 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #113 from Tom?s Cohen Arazi --- Feature pushed to master. Thanks Yohann and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 21:48:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 19:48:24 +0000 Subject: [Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 21:48:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 19:48:53 +0000 Subject: [Koha-bugs] [Bug 9528] Add delivery branch to the place hold display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9528 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. We miss you Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 21:58:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 19:58:54 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Hi Jonathan, I tested the proof of concept. It works as described and I think it is really the way to go. To make it work I had to remove the column 'gstrate' from queries in C4/Koha.pm and ad in/itemtypes.pl (maybe I should have applied te patch on top of an other patch?) One minor thing is the 'mapping' between the language and the translation. You do it with the main part of the language code, e.g. de for de-DE or fr for fr-FR. Maybe it is better to do the mapping on the whole language code? - I think that there could be a need to differentiate between sublanguages, and I remeber that it was somehow an issue with the news. Looking forward for the next steps... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 23:06:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 21:06:00 +0000 Subject: [Koha-bugs] [Bug 14103] New: Discharge management: Software error on main page after upgrade - Missing dependencies on About page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Bug ID: 14103 Summary: Discharge management: Software error on main page after upgrade - Missing dependencies on About page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com After the upgrade to 3.19.00.035 the mainpage of the cgi-bin/koha/mainpage.pl -> Software error: Can't locate PDF/FromHTML.pm in @INC However, other pages are available, e.g. cgi-bin/koha/circ/circulation-home.pl There were missing dependencies, see comment on Bug 8007 * libhtml-tidy-perl * libgraphics-colornames-perl * libpdf-fromhtml-perl (build needed) * libpdf-writer-perl (build needed) However, the depenencies are not listed on the About page (Perl modules). The crash on mainpage.pl occurs because does use Koha::Borrower::Discharge Maybe this could be handled more gracefully if the dependencies are not installed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 23:06:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 21:06:29 +0000 Subject: [Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8007 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 23:06:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 21:06:29 +0000 Subject: [Koha-bugs] [Bug 8007] Discharge management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14103 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 23:19:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 21:19:25 +0000 Subject: [Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #7 from Marc V?ron --- Is this still valid for current master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 23:34:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 21:34:22 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38576|0 |1 is obsolete| | --- Comment #24 from Marc V?ron --- Created attachment 38730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38730&action=edit Bug 10625: Inventory/Stocktaking tool cannot handle windows file uploads The current code uses $barcode = ; logic. This reads until \n, as far as I can tell. EOL is indicated by \n, \r, and \r\n depending on OS and software. So, to this end, rather than File::Slurp (which is a potential memory hog, which is already an issue with no filters), a loop to pre-read the barcodes was written. This loop includes: $barcode =~ s/\r/\n/g; $barcode =~ s/\n\n/\n/g; my @data = split(/\n/, $barcode); push @uploadedbarcodes, at data; So, that means that lines ending in \n would have it stripped and pushed into the uploaded barcodes array. Lines ending in \r would likely be read as one giant block, have everything converted to single \n's and then using a split, the set of barcodes are pushed into the uploaded barcodes array. Lines ending in \r\n would get that stripped and pushed into the uploaded barcodes array. It is then the uploaded barcodes array that is looped over for validating the barcodes. TEST PLAN --------- 1) Back up your database 2) Download the three sample files (or create your own) 3) Log in to staff client 4) Create a branch with no inventory. 5) Home -> Tools -> Inventory/Stocktaking 6) Browse for your '\r' test file. 7) Limit to just that branch 8) Click 'Submit' -- Confirm expected errors 9) Repeat steps 5-8 with the '\n' test file. 10) Repeat steps 5-8 with the '\r\n' test file. -- one of these repetitions should have problems. 11) Apply patch 12) Repeat steps 5-8 for each of the 3 test files. -- there should be no issues. 13) run koha qa test tools. Note: This is a tweak based on Jonathan Druart's comment #16 I have reset it to needs sign off again. Followed test plan. Works as expected. qa OK. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 23:35:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 21:35:55 +0000 Subject: [Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 30 23:47:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Apr 2015 21:47:28 +0000 Subject: [Koha-bugs] [Bug 14104] New: Renew check-box appears on checked out items with item level holds Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14104 Bug ID: 14104 Summary: Renew check-box appears on checked out items with item level holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com As of 3.18, it is possible to renew an item that has a hold on it, as long as the hold can be filled. If a biblio-level hold is placed, and all items are checked out, the 'Renew' check-box in the 'Checked out' tab in circ/circulation.pl will be replaced by the text 'On Hold'. If the checked out item has an item level hold on it, the 'Renew' check box *will* show, and no 'On Hold' text will display. If you select the 'Renew' check box for that item and click "Renew or check in selected items", the renew *will* fail, and the check box will then be replaced with the message 'Renew failed: on reserve' The issue not that the item is renewable, but simply that we are not being consistent about how we display the renew-ability of the item. 1) log in to http://intranet.bywatersolutions.com/ (user: bywater pass:bywater) 2) Check out item The Avengers 0003039002483 to Bilbo Bagins (55) 3) In separate tab, place Item level hold on The Avengers 0003039002483 4) Display check outs -- The Avengers 0003039002483 *does* show as renewable (i.e. the check box is available, and the 'on hold' text does not show) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
    BarcodeCall numberTitleItem typeBarcodeCall number
    Number of items added[% num_items_added %]
    Number of items replaced[% num_items_replaced %]
    Number of items ignored because of duplicate barcode[% num_items_errored %]
    or