[Koha-bugs] [Bug 13947] New: serials/subscription-history.pl calls GetBiblio incorrectly

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13947

            Bug ID: 13947
           Summary: serials/subscription-history.pl calls GetBiblio
                    incorrectly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mtompset at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

While looking at bug 10906, I noticed that this bug existed as well, but it was
not reported.

Look at C4/Biblio.pm and find the GetBiblio function. It is obvious that it
only returns undef or a HASH reference. However,
serials/subscription-history.pl calls it expecting ($count, $biblio), which is
wrong.

1) confirm the problem:
    $ git grep "=\s*GetBiblio\s*(" | grep subscription-history
2) apply the patch
3) confirm the fix:
    $ git grep "=\s*GetBiblio\s*(" | grep subscription-history
   -- The return value should be just a single parameter as expected.
4) run koha-qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.