[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #54 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Starting on this...

- QA script OK
- Code review OK

-------------------

1)  New test is failing for me:
not ok 8 - Koha::Acquisition::Order->insert set created_by to logged in user if
not given
#   Failed test 'Koha::Acquisition::Order->insert set created_by to logged in
user if not given'
#   at t/db_dependent/Acquisition/NewOrder.t line 91.
#          got: undef
#     expected: '42'
# Looks like you failed 1 test of 8.

2) Why only display the order line creator during the receive process, but not
on the order pages? We can only see the basket creator there.

3) On the order receive page: Maybe we should write "Ordered by" instead of
"Created by"?

4) On the parcel page: You change the display for the unreceived order lines
table, but the received orders miss the link to the order. I think it would be
better to be consistent and also to keep the | for separating the links from
each other.

5) The popup window appers 'unstyled' - for example it appears in a much bigger
than the rest serif font for me. Maybe something for a follow up?

Could you please take a look? Especially at the failing test and 4)

-- 
You are receiving this mail because:
You are watching all bug changes.