[Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Apr 6 21:25:17 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954

--- Comment #11 from Chris Nighswonger <cnighswonger at foundations.edu> ---
I can't tell you how many times I've looked at that particular part of the spec
and completely missed the scale options... thanks for pointing it out.

I ran some tests on your patch using some extremely large, compressed jpegs and
it works fine on everything I've thrown at it so far.

I still have an issue (not too much of one) with the approach to the fix. I'd
love to see us rip out the ImageMagick stuff, keep some restrictions on the
size of what can be uploaded, and let the scaling be handled during rendering.

Its been a while since I worked on all of the affected sections of code, so
this might be a big project.

With that in mind, I'll drop my objection to this patch (and even sign-off on
it) with the condition that a new enhancement request be opened to suggest a
more through cleanup of this.

Thanks again, Marc. I have never really liked ImageMagick as it always seemed a
bit klungy.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list