[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Kyle M Hall from comment #3)
> Patch removes quotes. Another possibility would be to escape or encode the
> quotes, but I'm not well versed enough with the XSLT to do so.

We could register an extension function with XML::LibXSLT, using
XML::LibXSLT::register_function(), that allows us to escape or encode quotes.
While I think XSLT 2.0 has a uri encoding function, XSLT 1.0 doesn't, so
extension functions have to be used.

I thought about adding this to the XSLT handler, but it's a global option, so
we can just set it after "use XML::LibXSLT" to make the extension function
available. (I wonder a bit about the repercussions while using Plack, but I
don't yet know enough about Plack to really speculate on that one. I suppose it
depends on the scope in which XML::LibXSLT is loaded.)

-- 
You are receiving this mail because:
You are watching all bug changes.