[Koha-bugs] [Bug 13933] t/DateUtils.t causes the build to break (from bug 13601)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13933

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Robin Sheat from comment #5)
> Cheers, I had a quick look but I couldn't actually see _why_ it was
> happening.

It's what I tried to explain in the commit description. Before 13601, the
C4::Context->preference method was mocked: for all calls, "us" was returned.
The patches for 13601 replaced this global mock with a call to
t::lib::Mocks::mock_preference, which mocks only the dateformat pref.
But somewhere (dt_from_string if I remember correctly) the value for TimeFormat
is retrieved. Since it's not mocked, the value in the DB is picked.
You know the rest of the story :)

-- 
You are receiving this mail because:
You are watching all bug changes.