[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Apr 8 00:18:36 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #60 from Héctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> ---
(In reply to Katrin Fischer from comment #59)

Hi Katrin

> Ok, one step further:  sudo apt-get install librdf-trine-perl :)
> 
> As usual I will start with the automated tests. In my test run, I notice
> that 2 tests in t/db_dependent/Records.t failing:
> 

I didn't know about this kind of unit test. But fails because Record.t is coded
for the previous output which i've changed in this new patch. As shown below in
the chunk of xml tags.

Can I change this Unit Test in Record.t to fit with this patch?

Give me some positive feedback.

> #   Failed test 'testing marc2dcxml'
> #   at t/db_dependent/Record.t line 59.
> #          got: undef
> #     expected: '<?xml version="1.0" encoding="UTF-8"?>
> # <metadata
> #   xmlns="http://example.org/myapp/"
> #   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> #   xsi:schemaLocation="http://example.org/myapp/
> http://example.org/myapp/schema.xsd"
> #   xmlns:dc="http://purl.org/dc/elements/1.1/"
> #   xmlns:dcterms="http://purl.org/dc/terms/">
> # </metadata>'
> 
> #   Failed test 'testing marcQualified'
> #   at t/db_dependent/Record.t line 71.
> #          got: undef
> #     expected: '<?xml version="1.0" encoding="UTF-8"?>
> # <metadata
> #   xmlns="http://example.org/myapp/"
> #   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> #   xsi:schemaLocation="http://example.org/myapp/
> http://example.org/myapp/schema.xsd"
> #   xmlns:dc="http://purl.org/dc/elements/1.1/"
> #   xmlns:dcterms="http://purl.org/dc/terms/">
> # </metadata>'
> # Looks like you failed 2 tests of 11.
> 
> Can you please check?
> 
> The QA script points out various uses of given-when - can you please fix by
> rewriting those parts?
> 
>  FAIL	C4/Record.pm
>    OK	  critic
>    OK	  forbidden patterns
>    OK	  pod
>    FAIL	  valid
> 		when is experimental 
> 		given is experimental 
> 
>  FAIL	Koha/DublinCoreTransformer.pm
>    OK	  critic
>    OK	  forbidden patterns
>    OK	  pod
>    FAIL	  valid
> 		given is experimental 
> 		when is experimental 
> 
>  FAIL	catalogue/export.pl
>    OK	  critic
>    OK	  forbidden patterns
>    OK	  pod
>    FAIL	  valid
> 		when is experimental 
> 		given is experimental 
> 
>  FAIL	opac/opac-export.pl
>    OK	  critic
>    OK	  forbidden patterns
>    OK	  pod
>    FAIL	  valid
> 		given is experimental 
> 		when is experimental

You're right that kind of code is experimental, I will change this.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list