[Koha-bugs] [Bug 9333] Confirm close JavaScript alerts is not used

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Apr 9 07:47:54 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9333

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37574|0                           |1
        is obsolete|                            |

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 37596
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37596&action=edit
Bug 9333: Remove useless JS code - confirm close basket

On closing a basket, the librarian is redirect to a new page for the
confirmation, the JavaScript confirmation is useless.

This code is never triggered and can be removed.

Test plan:
Without this patch, confirm you don't get a JavaScript confirmation
popup on closing a basket
With this patch, confirm you don't get any JavaScript error on
closing/reopening a basket.

NOTE: acqui/basket.tt is only used by acqui/basket.pl
      git grep "confirm_close" | grep -v "\.po:"
      doesn't show anything else. Reopening only works on
      basketgroups, not baskets. Unable to trigger any errors
      as expected and desired. :)

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list