[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Apr 13 11:26:47 CEST 2015
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813
--- Comment #55 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Minor since I suppose it existed before:
FAIL cataloguing/value_builder/dateaccessioned.pl
FAIL forbidden patterns
forbidden pattern: tab char (line 54)
FAIL members/moremember.pl
FAIL forbidden patterns
forbidden pattern: tab char (line 136)
FAIL C4/Barcodes/hbyymmincr.pm
FAIL forbidden patterns
forbidden pattern: tab char (line 76)
forbidden pattern: tab char (line 106)
FAIL C4/Barcodes/annual.pm
FAIL forbidden patterns
forbidden pattern: tab char (line 84)
forbidden pattern: tab char (line 63)
forbidden pattern: tab char (line 49)
forbidden pattern: tab char (line 46)
forbidden pattern: tab char (line 52)
FAIL C4/Items.pm
FAIL forbidden patterns
forbidden pattern: trailing space char (line 650)
FAIL members/readingrec.pl
FAIL forbidden patterns
forbidden pattern: trailing space char (line 81)
Could you explain why you replaced
- my $rsstimestamp = C4::Dates->new($result->{datereviewed},"iso");
- my $rsstimestamp_output = $rsstimestamp->output("rfc822");
- $result->{timestamp} = $rsstimestamp_output;
+ $result->{timestamp} = strftime("%Y-%m-%dT%H:%M:%S-00:00", gmtime);
and
- $datereceived = C4::Dates->output('iso') unless $datereceived;
+ $datereceived = output_pref({ dt=>DateTime->now(), dateonly=>1,
otputpref=>'iso' }) unless $datereceived;
I would use Koha::DateUtils everywhere.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list