[Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 37178
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37178
Bug 13899 : Adding misc/devel/coverage.pl

Review of attachment 37178:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13899&attachment=37178)
-----------------------------------------------------------------

And please run perltidy on new files.

::: misc/devel/coverage.pl
@@ +34,5 @@
> +use C4::Context;
> +
> +my $KOHA_PATH = C4::Context->config("intranetdir");
> +
> +chdir $KOHA_PATH;

I would not do that, I'd prefer compare getcwd and intranetdir. If they differ,
raise an error.

@@ +37,5 @@
> +
> +chdir $KOHA_PATH;
> +
> +eval{
> +	require Devel::Cover;

Add it to the list of deps (see C4/Installer/PerlDependencies.pm).

@@ +41,5 @@
> +	require Devel::Cover;
> +};
> +
> +if ($@) {
> +	say "Devel::Cover needs to be installed";

And don't catch the deps error.

@@ +49,5 @@
> +#Delete old coverage
> +system("cover -delete");
> +
> +#Start the cover
> +system("PERL5OPT=-MDevel::Cover /usr/bin/prove -r t/");

What about existing PERL5OPT? Have a look at prove -M

-- 
You are receiving this mail because:
You are watching all bug changes.