[Koha-bugs] [Bug 11337] calls to GetSubscriptions can be replaced by Searchsubscriptions

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Apr 13 15:27:43 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11337

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35514|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 37739
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37739&action=edit
Bug 11337: Remove the C4::Serials::GetSubscriptions routine

Since SearchSubscriptions is the way to search subscriptions, each call
to GetSubscriptions could be replaced by a call to SearchSubscriptions.

Test plan:
Verify following pages display the same thing as before this patch:
- catalogue/detail.pl
- opac/opac-ISBDdetail.pl
- opac/opac-detail.pl

Verify the following page returns correct results:
- serials/checkexpiration.pl

Verify the Serials UT file still passes:
- prove t/db_dependent/Serials.t

Note: The title filter on checkexpiration now only searches on the title
DB field. I don't think it is a regression, it should be the way to use
this field. Maybe should we add new search fields on this form.
Bug 5337 reintroduces a bug fixed by bug 5864, this patch restore the
right way to search subscription (based on biblionumber).

Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list