[Koha-bugs] [Bug 9472] subfields in order when cataloging

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #5)
> Yes, I am aware of that.
> But actually, against master, the display is:
>   all subfields, alphabetically sorted, present in the record
> followed by:
>   all subfields, alphabetically sorted, non present in the record.
> 
> (search for foreach my $subfield ( sort( keys %{ $tagslib->{$tag} } ) ) ~
> l.600-700)
> 
> This patch just suggests to display all subfields, alphabetically sorted.
> Which makes more sense.
> 
> If my dsecription of how it works on master is wrong, my patch is certainly
> wrong.

Yes, I am still afraid that your patch is actually "wrong" ;) I am not sure if
you understood my point too. Hope the following clarifies:

I tested this:
I had a tag 100 with a 9 4 q d e  (4 and e were empty) 
Without your patch, I look in catalogue marc detail, I see: 100 a q d. Fine!
Without your patch, I look in opac marc detail, I see: 100 a 9 q d. Fine too.

Now with your patch, I edit the record:
The order is now: 4-9-a-d-e-q
Catalogue marc detail gives: a-d-q CHANGED !
Opac marc detail: 9-a-d-q  CHANGED AGAIN !

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.