[Koha-bugs] [Bug 10131] System preference search doesn't work for search terms starting with *
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Apr 15 22:42:40 CEST 2015
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10131
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #37826|0 |1
is obsolete| |
--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 37920
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37920&action=edit
[PASSED QA] Bug 10131: Add a fallback if the pref search is not a valid regex
It's possible to search prefs using a regex.
But it the regex is not correctly written, the app explodes.
We should provide a fallback.
Test plan:
0/ Does not apply the patch
1/ Search for sysprefs with "notes.*", note the number of results
2/ Search for *notes*, boom
3/ Apply the patch
4/ Repeat 1 and confirm you get the same number of results
5/ Repeat 2 and confirm you don't get the error anymore
NOTE: As noted on comment #4, the kaboom is because of the
leading * and not the following *, because 's*' is a valid
regular expression, while '*n' is not.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list