[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 37293
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37293
[SIGNED-OFF] Bug 8612 - System preference to have custom fields in export csv
basket

Review of attachment 37293:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8612&attachment=37293)
-----------------------------------------------------------------

::: acqui/basket.pl
@@ +197,5 @@
>          -type       => 'text/csv',
>          -attachment => 'basket' . $basket->{'basketno'} . '.csv',
>      );
> +    if ( $query->param('csv_profile') eq 'default'){
> +        print GetBasketAsCSV($query->param('basketno'), $query);

Actually this subroutine should take the csv profile in parameter, don't you
think?

@@ +531,4 @@
>      return \%line;
>  }
>  
> +sub get_basket_DB_info{

Don't you have something in the module to do that? (I didn't check).
In all cases, you cannot add it here in the pl. Yes that means tests.

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
@@ +190,5 @@
>                      [% END %]
> +                       <div class="btn-group">
> +                       <fieldset class="action">
> +                          <label for="csv_code">Select CSV profile:</label>
> +                          <select id="csv_profile_for_export">

This block is c/p twice, should be in a TT BLOCK.

-- 
You are receiving this mail because:
You are watching all bug changes.