[Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page.

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Apr 18 21:53:07 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 38119
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38119&action=edit
Bug 8688: Update License, Perlcritic -3 friendly

This patch tweaks the license information to v3, as per the
license found in the Coding Guidelines on the wiki:
http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

This also changes:
    use strict;
    use warnings;
into:
    use Modern::Perl;
As per the PERL2: Modern::Perl requirement in the Guidelines:
http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL2:_Modern::Perl

And though the guidelines only require perlcritic -5, a single
line tweak gets a bump to perlcritic -3.

TEST PLAN
---------
1) perlcritic -5 circ/send_recall_notice.pl
   -- success, so technically no change was required.
2) perlcritic -3 circ/send_recall_notice.pl
   -- fails
3) apply patch
4) perlcritic -3 circ/send_recall_notice.pl
   -- success
5) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list