[Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37724|0                           |1
        is obsolete|                            |
  Attachment #37725|0                           |1
        is obsolete|                            |
  Attachment #37726|0                           |1
        is obsolete|                            |
  Attachment #38151|0                           |1
        is obsolete|                            |
  Attachment #38174|0                           |1
        is obsolete|                            |

--- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 38176
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38176&action=edit
Bug 7981 - Remove HomeOrHoldingBranchReturn syspref

This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl
respect branch
circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip
notice should reflect this.

Default should always be to return item to home branch.

Test plan:
- make sure syspref 'AutomaticItemReturn' is set to 'false'
- unset 'Default checkout, hold and return policy' or set 'Return policy' to
'Item returns home'
- checkout an item and do a checkin from different branch than items homebranch
- verify that you're prompted with a transfer message to item's home branch and
that print slip matches

- set 'Return policy' to 'Item returns to issuing library'
- do a checkout and a checkin from branch different than item's home branch
- verify that you're not prompted with a transfer message and that holding
library is your current branch

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Follow-up:
- Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn
  policies
- Removed HomeOrHoldingBranchReturn from sysprefs.sql
- Added notice on removing syspref in updatedatabase

QA edits:
- removed trailing whitespace in tests
- moved branchname lookup from returns.pl to template

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.