[Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Starting for real now - testing this bug together with 13323 and 13324.
Some first feedback, I will number every point and keep a list outside of
bugzilla too:

DATABASE UPDATE

1) Some warns:
Use of uninitialized value in string eq at
./installer/data/mysql/updatedatabase.pl line 10228.
Use of uninitialized value in string eq at
./installer/data/mysql/updatedatabase.pl line 10228.
Use of uninitialized value in string eq at
./installer/data/mysql/updatedatabase.pl line 10228.
Use of uninitialized value in string eq at
./installer/data/mysql/updatedatabase.pl line 10228.
Upgrade to 3.19.00.XXX done (Bug 13321 - Tax and prices calculation: add new
columns to aqorders)
Upgrade to 3.19.00.XXX done (Bug 13321 - Tax and prices calculation: tax_value
contains the value for 1 item)
Upgrade to 3.19.00.XXX done (Bug 13323 - Tax rate can change on receiving)

2) Shouldn't the second database update entry refer to the quantity somehow?
Why the hardcoded 2? And shouldn't we fix the first database entry here? Bit
worried about the round:

+    for my $order ( @$orders ) {
+        $sth->execute( $order->{tax_value} * 2, $order->{ordernumber} );
+    }

QA SCRIPT AND AUTOMATED TESTS

3) Failing tests:

- t/db_dependent/Budgets.t

not ok 61 - total spent for budget1 is 160
#   Failed test 'total spent for budget1 is 160'
#   at t/db_dependent/Budgets.t line 371.
#          got: '0'
#     expected: '160'
not ok 62 - total spent for budget11 is 100
#   Failed test 'total spent for budget11 is 100'
#   at t/db_dependent/Budgets.t line 372.
#          got: '0'
#     expected: '100'
not ok 63 - total spent for budget111 is 20
#   Failed test 'total spent for budget111 is 20'
#   at t/db_dependent/Budgets.t line 373.
#          got: '0'
#     expected: '20'

-- 
You are receiving this mail because:
You are watching all bug changes.