[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
I can't reproduce this on master either. It looks like the problem caused by:

https://library.roseville.ca.us/cgi-bin/koha/opac-search.pl?q=su:%22Fairies.%22

is specific to either 3.16.4 or a modification that Bywater have made to that
Koha instance.

Here's a link that I see in the Roseville site for the query
https://library.roseville.ca.us/cgi-bin/koha/opac-search.pl?q=su:%22Fairies.%22:

<a href="/cgi-bin/koha/opac-search.pl?q=ccl=su%3A"
fairies."&sort_by="relevance_asc&limit=au:Colfer%2C%20Eoin.""
title="Colfer, Eoin.">Colfer, Eoin.</a>

However, my query for
http://192.168.1.61:2112/cgi-bin/koha/catalogue/search.pl?q=su:%22Fairies.%22

creates the following link:

<a
href="/cgi-bin/koha/catalogue/search.pl?q=ccl=su%3A%22Fairies.%22&sort_by=relevance_dsc&limit=itype:TEST"
title="TEST">test</a>

I suspect that the following line in C4::Search::buildQuery() was added after
3.16.4:

$limit_cgi       .= "&limit=" . uri_escape_utf8($this_limit);

Although it looks like the Roseville site is also doing something with
lowercasing and possibly whitespace as well...

---

I suspect that the current patch might cause problems if it's used since it
removes the TracingQuotesLeft and TracingQuotesRight, which are { and } with
ICU, and only " and " with non-ICU.

In any case, this doesn't appear to be a problem in master.

-- 
You are receiving this mail because:
You are watching all bug changes.