[Koha-bugs] [Bug 13943] Cancelling the deletion process of an item deletes item anyway

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13943

Fridolin SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #3 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to David Cook from comment #2)

> So I don't know... my boss suggested that we make the confirm_deletion
> function more simple or remove it all together in favour of the following
> inline code:
> 
> onclick="return confirm('Are you sure you want to delete this item?')"
> 
> or
> 
> onclick="return confirm(_('Are you sure you want to delete this item?'))"
> 
> Perhaps that's a thought... when I tested the first option, it worked fine.

Be careful :
1/ JavaScript in HTML attributes is not translatable
2/ Always use double quotes inside _() function because translation may add a
single quote

-- 
You are receiving this mail because:
You are watching all bug changes.