[Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #28)
> Starting for real now - testing this bug together with 13323 and 13324.

Thanks! :)

> DATABASE UPDATE
> 
> 1) Some warns:
> Use of uninitialized value in string eq at
> ./installer/data/mysql/updatedatabase.pl line 10228.

Yes, wrong check, the column is "orderstatus", not "status". (Commit "Bug
13321: Tax and prices calculation - DB Changes" amended)

> 2) Shouldn't the second database update entry refer to the quantity somehow?
> Why the hardcoded 2? And shouldn't we fix the first database entry here? Bit
> worried about the round:
> 
> +    for my $order ( @$orders ) {
> +        $sth->execute( $order->{tax_value} * 2, $order->{ordernumber} );
> +    }

Hum... That's weird :)
Should be tax_value = tax_value / quantity.
Commit "Bug 13321: tax_value should contain the value for 1 item" amended.

> QA SCRIPT AND AUTOMATED TESTS
> 
> 3) Failing tests:
> 
> - t/db_dependent/Budgets.t
> 
> not ok 61 - total spent for budget1 is 160
> #   Failed test 'total spent for budget1 is 160'
> #   at t/db_dependent/Budgets.t line 371.
> #          got: '0'
> #     expected: '160'
> not ok 62 - total spent for budget11 is 100
> #   Failed test 'total spent for budget11 is 100'
> #   at t/db_dependent/Budgets.t line 372.
> #          got: '0'
> #     expected: '100'
> not ok 63 - total spent for budget111 is 20
> #   Failed test 'total spent for budget111 is 20'
> #   at t/db_dependent/Budgets.t line 373.
> #          got: '0'
> #     expected: '20'

I forgot to change the call to ModReceiveOrder.
Same for t/db_dependent/Acquisition/OrderUsers.t (new file).
Commit "Bug 13321: Rename variables" amended.

Branch updated.

-- 
You are receiving this mail because:
You are watching all bug changes.