[Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Apr 22 17:47:04 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625

--- Comment #42 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 38277
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38277
Bug 11625 - Implement DefaultToLoggedInLibraryNoticesSlips

Review of attachment 38277:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11625&attachment=38277)
-----------------------------------------------------------------

::: tools/letter.pl
@@ +85,5 @@
> +  : $input->param('branchcode')                                      ? $input->param('branchcode')
> +  : $op                                                              ? $input->param('branchcode')
> +  : GetBranchesCount() == 1                                          ? undef
> +  :                                                                    C4::Branch::mybranch();
> +

Sorry but I am not confident enough with this part of code to pass qa on it
today.
This script is a house of cards and the branchcode variable is used at several
place.
You modify it at the beginning of the script, but it could introduce side
effects.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list