[Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Apr 23 12:52:46 CEST 2015


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle,

can you please take a look at Jonathan's comment#38?
+use C4::Koha qw/GetSupportList/;

I am not sure about some of the changes being intentional?

     if ($displayby =~ /status/i) {
-        if ( grep { /^($criteriumvalue)$/ } qw(ASKED ACCEPTED REJECTED CHECKED
ORDERED AVAILABLE) ) {
-            return ($criteriumvalue eq 'ASKED'?"Pending":ucfirst(lc(
$criteriumvalue)));
-        } else {
-            return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue)
|| $criteriumvalue;
+        unless ( grep { /$criteriumvalue/ } qw(ASKED ACCEPTED REJECTED CHECKED
ORDERED AVAILABLE) ) {
+            return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue
) || "Unknown";
         }
+        return ($criteriumvalue eq 'ASKED'?"Pending":ucfirst(lc(
$criteriumvalue))) if ($displayby =~/status/i);
     }
     return (GetBranchName($criteriumvalue)) if ($displayby =~/branchcode/);
-    return (GetSupportName($criteriumvalue)) if ($displayby =~/itemtype/);
+    return GetAuthorisedValueByCode('SUGGEST_FORMAT', $criteriumvalue) ||
"Unknown" if ($displayby =~/itemtype/);

Also, "Pending" looks untranslatable there.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list