[Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167

--- Comment #31 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 38724
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38724&action=edit
Bug 12167: Made SQL even more ANSI SQL.

The comparison against '00-00-0000' is not possible under
PostgreSQL. By providing a database upgrade which replaces all
'0000-00-00' dates with NULL, this portion of the SQL query can
be removed.

Additionally, MySQL can handle CURRENT_DATE(), but PostgreSQL
barfs horribly. By removing the ()'s, it functions in both.

The NewsChannels.t specifically added an explanationdate IS NULL
case to catch what was not tested before.

TEST PLAN
---------
1) Apply patch.
2) ./installer/data/mysql/updatedatabase.pl
3) prove -v t/db_dependent/NewsChannels.t
   -- This will confirm that the modified GetNewsToDisplay
      function has not broken.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Update database runs without problem, test pass, no koha-qa errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.