From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 02:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 00:27:37 +0000 Subject: [Koha-bugs] [Bug 14123] Patroncard: Patron search for batch no longer has Select / Select All / Add selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 02:30:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 00:30:34 +0000 Subject: [Koha-bugs] [Bug 14123] Patroncard: Patron search for batch no longer has Select / Select All / Add selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #1 from Indranil Das Gupta --- (In reply to Marc V?ron from comment #0) > Created attachment 38773 [details] > Compare patron search for patron card batch 3.18 - current master > > The new patron search for patron card batches has no longer the possibility > to select /select all and add selected to batch. > > To add, each single patron has to be added clicking the 'Add' button in the > table row. > > Use case: Search for patrons for a category, select all, add all to the > batch. > > See screenshot with old / new version. Not only that, it seems that the batch can handle only one single 'item' in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 06:35:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 04:35:20 +0000 Subject: [Koha-bugs] [Bug 14581] Display of book jacket in RSS page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14581 --- Comment #1 from Vinod --- Further, i noticed that the book cover image is displayed in RSS when it is selected to fetch the image from Amazon in system preferences-enhanced content but it does not work from google cover image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 10:56:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 08:56:46 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 11:09:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 09:09:52 +0000 Subject: [Koha-bugs] [Bug 14123] Patroncard: Patron search for batch no longer has Select / Select All / Add selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 --- Comment #2 from Indranil Das Gupta --- (In reply to Indranil Das Gupta from comment #1) > (In reply to Marc V?ron from comment #0) > > Created attachment 38773 [details] > > Compare patron search for patron card batch 3.18 - current master > > > > The new patron search for patron card batches has no longer the possibility > > to select /select all and add selected to batch. > > > > To add, each single patron has to be added clicking the 'Add' button in the > > table row. > > > > Use case: Search for patrons for a category, select all, add all to the > > batch. > > > > See screenshot with old / new version. > > Not only that, it seems that the batch can handle only one single 'item' in > it. Ok! that was hasty! it can handle multiple items, but they can only be added one at a time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 11:11:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 09:11:49 +0000 Subject: [Koha-bugs] [Bug 9480] Set barcode width and height configurable with system preferences in patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9480 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com Component|Tools |Label/patron card printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 11:13:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 09:13:59 +0000 Subject: [Koha-bugs] [Bug 13960] Patroncards: Code needs some cleanup / enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13960 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 11:14:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 09:14:05 +0000 Subject: [Koha-bugs] [Bug 13954] Patroncards: images show inadequate rough pixelation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13954 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 11:22:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 09:22:10 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #2 from Marc V?ron --- Created attachment 41295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41295&action=edit [Signed-off] Bug 14509: Reject invalid passwords Bug 10177 rejects password with leading or trailing whitespaces, but only on the member-password page. It's not consistent to only do this check on 1 place. This patch adds the check for the 2 other places: memberentry and at the OPAC. Test plan: 1/ Edit a patron and set a password with leading and/or trailing whitespaces. You should not be allowed to do it (no server side check). 2/ Same at the OPAC ("Change you password" tab). Here there is a server side check. Followed test plan. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 11:22:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 09:22:34 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #40993|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 11:22:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 09:22:45 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 13:55:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 11:55:55 +0000 Subject: [Koha-bugs] [Bug 14623] Specify due date and offline circulation, overdue fines is not synchronizing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14623 Jerwyn changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Jerwyn --- Apologies, after downgrading the system, we found out that we still have the same dilemma. We oversight the Maxfine settings under Patrons preferences. Kind regards, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 15:15:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 13:15:31 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41153|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 15:36:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 13:36:56 +0000 Subject: [Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41253|0 |1 is obsolete| | --- Comment #10 from Olli-Antti Kivilahti --- Created attachment 41296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41296&action=edit Bug 14495 - WebDriver/WebTester Factory for easy generation of Web testing UserAgents. Has an optional dependency to Buugg 13799 Because life is short, getting test web drivers must be easy. use t::lib::WebDriverFactory; my ($firefox) = t::lib::WebDriverFactory::getUserAgentDrivers('firefox'); In Ubuntu 14.04, Selenium no longer requires a stand-alone testing Server, so running integration tests is much much more fun! This factory encapsulates all the boring bits about getting a web driver to mimic user behaviour in the GUI. And makes it super easy to get a test driver for any testing type environment. Adds support for Test::Mojo and Selenium, see t::lib::WebDriverFactory for installation and usage instructions. ---------------------------- -INSTALLATION INSTRUCTIONS:- ---------------------------- -All the WebDriver tests use the Selenium::PhantomJS-package by default. You MUST install the following dependencies: cpanm Selenium::Remote::Driver cpanm Selenium::PhantomJS apt-get install phantomjs #Minimum version acceptable is v1.09 Optionally you can install other Selenium browsers like Firefox Chrome IE But they are only useful when testing the WebDriver scripts on a graphical environment. You are better off using Selenium IDE to learn/test WebDriver scripts. run t::lib::webDriverFactory.t to see your configured capabilities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 15:41:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 13:41:55 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14539 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 15:41:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 13:41:55 +0000 Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13906 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 1 16:09:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Aug 2015 14:09:58 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 02:33:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 00:33:14 +0000 Subject: [Koha-bugs] [Bug 7369] duplicate item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7369 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 14:13:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 12:13:18 +0000 Subject: [Koha-bugs] [Bug 7947] 440/490 Koha Mapping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7947 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #2 from Mirko Tietgen --- We also still have 440 visible by default in the frameworks and 490 hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 15:31:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 13:31:31 +0000 Subject: [Koha-bugs] [Bug 12216] One should be able to override zebra configuration on a per instance basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12216 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 15:33:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 13:33:29 +0000 Subject: [Koha-bugs] [Bug 12216] One should be able to override zebra configuration on a per instance basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12216 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28112|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 41297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41297&action=edit [SIGNED OFF] Bug 12216: One should be able to override zebra config One should be able to override zebra configuration on a per instance basis. This patch adds /etc/koha/sites/instance to the 'profilePath' in the zebra config files such that that location is sources first for any override config files. Signed-off-by: Tomas Cohen Arazi Great catch Martin. I thought this was already pushed by the way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 15:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 13:33:52 +0000 Subject: [Koha-bugs] [Bug 12216] One should be able to override zebra configuration on a per instance basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12216 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |robin at catalyst.net.nz |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:09:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:09:44 +0000 Subject: [Koha-bugs] [Bug 14626] can't save preferences without clicking 'out' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14626 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I can confirm this behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:13:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:13:14 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #36 from Katrin Fischer --- Hi Kyle, could you do me a favour and try the test case I described? I feel if we push this without checking the basic functionality of the tool is correct, we will just end up with unhappy feedback on a good new feature. > Example: Argh? I created a patron list with 6 patrons, I checked out a book > to one of the patrons. The test run on the patron delete tells me the that 6 > patrons would have been deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:17:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:17:35 +0000 Subject: [Koha-bugs] [Bug 11967] Add support for RMA notices to Acquisitions. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|philippe.blouin at inlibro.com |koha-bugs at lists.koha-commun | |ity.org Change sponsored?|Sponsored |--- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi Blou, I have removed the assigned status and the 'sponsored'. I am hesitating to close this, as it might be a feature someone else might want to work at. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:36:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:36:21 +0000 Subject: [Koha-bugs] [Bug 14548] Typo in help file for 3.20 (batch_record_modification.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:36:24 +0000 Subject: [Koha-bugs] [Bug 14548] Typo in help file for 3.20 (batch_record_modification.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41046|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 41298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41298&action=edit [PASSED QA] Bug 14548 - Typo in help file for 3.20 (batch_record_modification.tt) Typo found in batch_record_modification.tt file for Koha help in 3.20 Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/batch_record_modification.tt:20' and check the typo "critera" or go to Tools ? Batch record modification, open up the help 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed. Sponsored-by: Universidad de El Salvador Signed-off-by: Aleisha Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:36:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:36:50 +0000 Subject: [Koha-bugs] [Bug 14548] Typo in help file for 3.20 (batch_record_modification.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14548 --- Comment #4 from Katrin Fischer --- I added Aleisha's sign-off line manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:38:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:38:52 +0000 Subject: [Koha-bugs] [Bug 14547] Typo in help file for 3.20 (basket.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14547 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:38:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:38:55 +0000 Subject: [Koha-bugs] [Bug 14547] Typo in help file for 3.20 (basket.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14547 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41045|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 41299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41299&action=edit [PASSED QA] Bug 14547 - Typo in help file for 3.20 (basket.tt) Typo found in basket.tt file for Koha help in 3.20 Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/basket.tt:24' and check the typo "susbscription" or go to Acqusitions > create or view an existing basket, open up the help 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed. Sponsored-by: Universidad de El Salvador Signed-off-by: Aleisha Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:39:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:39:22 +0000 Subject: [Koha-bugs] [Bug 14547] Typo in help file for 3.20 (basket.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14547 --- Comment #4 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #2) > Pathc applied cleanly and typo is fixed, signing off I added Aleisha's sign-off manually to the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:46:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:46:08 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:46:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:46:17 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41206|0 |1 is obsolete| | Attachment #41207|0 |1 is obsolete| | --- Comment #261 from Katrin Fischer --- Created attachment 41300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41300&action=edit [PASSED QA] Bug 7143: Add missing people to history.txt Indranil Das Gupta needs to be included. Emmanuele Somma was missed a while back, so adding ad shifting numbers for people after her. Some tab fixes too, I don't have the time to fix them all. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 19:47:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 17:47:05 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #262 from Katrin Fischer --- Created attachment 41301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41301&action=edit [PASSED QA] Bug 7143: New developers Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 20:42:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 18:42:26 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #74 from Katrin Fischer --- Created attachment 41302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41302&action=edit Bug 10363: QA Follow-up - fixing POD and spelling We should stick with either AE (authorized) or BE (authorised) spelling. Corrected error messages to use authorized. Also fixed tiny copy & paste error in POD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 20:43:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 18:43:10 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #75 from Katrin Fischer --- There is a bug in there: 1) Create or edit an authorized value 2) Limit to 2+ branches (I had 5) 3) Try to edit the authorized value Software error: Can't use string ("CPL") as a HASH ref while "strict refs" in use at /home/katrin/kohaclone/admin/authorised_values.pl line 63. For help, please send mail to the webmaster (webmaster at bumblebee), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 20:56:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 18:56:02 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #76 from Katrin Fischer --- Hm also: the duplicate check is not working. 1) Enter an entry to any authorized value category with value new 2) Try to enter another with value new for the same category 3) on master: an error message is shown with the patches: authorized value saved successfully... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 23:16:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 21:16:57 +0000 Subject: [Koha-bugs] [Bug 14626] can't save preferences without clicking 'out' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14626 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- That bug will be the cause of this, but it's already fixed in 3.18.09. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389#c20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 23:31:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 21:31:19 +0000 Subject: [Koha-bugs] [Bug 14389] Editing a syspref in a textarea does not enable the Save button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14389 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 23:32:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 21:32:59 +0000 Subject: [Koha-bugs] [Bug 13435] OPAC self registration can't find OPAC_REG_VERIFY notice if it is assigned to a branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13435 --- Comment #1 from Liz Rea --- While I was looking over my bugs in progress, it occurred to me that this can never work how we want it to, because we don't allow self registering borrowers to select their branch. Without a logged in user, Koha will never know which branch to send to the notices module, and thus it will never know which notice to use (except "All libraries"). So either we need a little re-engineering here, or at the very least documentation of why this doesn't/can't work the way libraries might expect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 23:47:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 21:47:41 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 2 23:47:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 21:47:44 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41188|0 |1 is obsolete| | --- Comment #3 from Liz Rea --- Created attachment 41303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41303&action=edit Bug 14602 - Fix failing t/Creators.t test to test.. 1/ run t/Creators.t test from git repo, get a FAIL 2/ apply patch 3/ repeat step 1, get a PASS mason at xen1:~/g/k/3.16.x$ sudo koha-shell -c 'export PERL5LIB=/home/mason/g/k/3.16.x ; cd /home/mason/g/k/3.16.x ; prove -v t/Creators.t' k316x1 t/Creators.t .. 1..16 ok 1 - use C4::Creators; ok 2 - use C4::Creators::PDF; ok 3 - testing new() works ok 4 - testing pdf file created ok 5 - testing Add() works ok 6 - testing Bookmark() works ok 7 - testing Compress() works ok 8 - testing Font() works ok 9 - testing FontSize() is set to 12 by default ok 10 - testing FontSize() can be set to a different value ok 11 - testing Page() works ok 12 - testing StrWidth() returns correct point width ok 13 - testing Text() writes from a given x-value ok 14 - testing Text() writes to the correct x-value ok 15 - testing End() works ok 16 - test file /tmp/4YjPQDExeS created OK ok All tests successful. Files=1, Tests=16, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.48 cusr 0.05 csys = 0.57 CPU) Result: PASS Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 00:18:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 22:18:00 +0000 Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Status|In Discussion |ASSIGNED --- Comment #3 from Magnus Enger --- (In reply to Brendan Gallagher from comment #2) > (In reply to Liz Rea from comment #1) > > Yep, this seems fine. Do you have a preference where it goes on the website? > > I do not have a preference. Anybody with more style have a preference? Just put it *somewhere* and we can "argue" about the details later? :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 01:47:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 23:47:18 +0000 Subject: [Koha-bugs] [Bug 12216] One should be able to override zebra configuration on a per instance basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12216 --- Comment #4 from Robin Sheat --- Created attachment 41304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41304&action=edit Bug 12216: One should be able to override zebra config One should be able to override zebra configuration on a per instance basis. This patch adds /etc/koha/sites/instance to the 'profilePath' in the zebra config files such that that location is sources first for any override config files. Signed-off-by: Tomas Cohen Arazi Great catch Martin. I thought this was already pushed by the way. Signed-off-by: Robin Sheat This will be useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 01:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 23:47:47 +0000 Subject: [Koha-bugs] [Bug 12216] One should be able to override zebra configuration on a per instance basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12216 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41297|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 01:47:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 23:47:54 +0000 Subject: [Koha-bugs] [Bug 12216] One should be able to override zebra configuration on a per instance basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12216 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 01:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Aug 2015 23:55:27 +0000 Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables server-side processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 02:09:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 00:09:15 +0000 Subject: [Koha-bugs] [Bug 14630] New: date runtime parameter formatting date wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14630 Bug ID: 14630 Summary: date runtime parameter formatting date wrong Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org In 3.18.8 - when running reports if you have <> the calendar plugin is using the local date format instead of the mysql date format as it used to. This means all reports that have that in them (and that's a lot) are returning no results. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 02:35:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 00:35:14 +0000 Subject: [Koha-bugs] [Bug 14631] New: Change to "Patron" in patroncard toolbar Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Bug ID: 14631 Summary: Change to "Patron" in patroncard toolbar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org The toolbar for "Manage patron card batches" template shows "item(s)" instead of "patron(s)". This patch proposes to fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 02:39:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 00:39:12 +0000 Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #1 from Indranil Das Gupta --- Created attachment 41305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41305&action=edit patron(s) described as item(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 03:15:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 01:15:38 +0000 Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #2 from Indranil Das Gupta --- Created attachment 41306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41306&action=edit Bug 14631 - Change item(s) to patron(s) in toolbar The toolbar for "Manage patron card batches" template shows "item(s)" instead of "patron(s)". This patch proposes to fix it. Test plan ========= 1/ Go to Patron card creator > Manage patron card batches notice. 2/ Select a batch to edit, you should see the toolbar as described in attachment 41305 3/ Apply patch and refresh page. The toolbar should read correctly as 'patron(s)' 4/ Go back to step #1 above and select "New batch" and let the page automatically refresh. The toolbar button presented should read "Add patron(s)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 03:16:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 01:16:24 +0000 Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 03:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 01:37:20 +0000 Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606 --- Comment #4 from Liz Rea --- Ha, my discretion it is then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 03:43:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 01:43:49 +0000 Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Liz Rea --- I have added this, however I was unsure of the text to use, nor do I (I think...) have a description or further explanation of what the money goes for on the website to link to. It is on the home page, at the bottom right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 04:14:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 02:14:28 +0000 Subject: [Koha-bugs] [Bug 14632] New: Incorrect alert while deleting single item in batch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Bug ID: 14632 Summary: Incorrect alert while deleting single item in batch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org In "Manage patron card batches", the user is prevented from deleting the items from a single item batch as that would remove the entry from table creator_batches effectively deleting the batch. However, the JS alert's message reads as "Please select at least label to delete.". This is incorrect as one item is already selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 04:38:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 02:38:11 +0000 Subject: [Koha-bugs] [Bug 14123] Patroncard: Patron search for batch no longer has Select / Select All / Add selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|critical |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 05:56:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 03:56:48 +0000 Subject: [Koha-bugs] [Bug 14581] Display of book jacket in RSS page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14581 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 05:59:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 03:59:26 +0000 Subject: [Koha-bugs] [Bug 14633] New: apache2-mpm-itk depencency makes KOHA uninstallable on Debian Stretch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Bug ID: 14633 Summary: apache2-mpm-itk depencency makes KOHA uninstallable on Debian Stretch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: John.Seymour at nal.gov.au QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Please replace the dependency on the transitional package apache2-mpm-itk with a dependency on libapache2-mpm-itk as apache2-mpm-itk has been dropped from Stretch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 06:08:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 04:08:51 +0000 Subject: [Koha-bugs] [Bug 14633] apache2-mpm-itk depencency makes Koha uninstallable on Debian Stretch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14633 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|apache2-mpm-itk depencency |apache2-mpm-itk depencency |makes KOHA uninstallable on |makes Koha uninstallable on |Debian Stretch |Debian Stretch Severity|enhancement |major Priority|P5 - low |P4 Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | --- Comment #1 from Robin Sheat --- Well have to track back and make sure this is the case in the supported distros (Ubuntu 14.04LTS, Wheezy, and Jessie) too. But even if it's not, doing an 'or' dependency is trivial. So yeah, important. At least, important before the next Debian release so we have a year or two :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 06:23:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 04:23:09 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 --- Comment #1 from Indranil Das Gupta --- (In reply to Indranil Das Gupta from comment #0)> > However, the JS alert's message reads as "Please select at least label to > delete.". This is incorrect as one item is already selected. The function Remove() checks for document.items.action.length > 0. In cases of batches with only a single item / patron, this test fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 06:26:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 04:26:52 +0000 Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #6 from Aleisha Amohia --- (Liz you haven't attached anything) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 06:37:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 04:37:22 +0000 Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Aleisha Amohia --- oops ignore me, good stuff signing off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 06:38:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 04:38:47 +0000 Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #3 from Aleisha Amohia --- The patch works fine, but just wanted to add a few things which still should be changed from item(s) to patron(s): - title of 'Items in Batch number x' (which can be seen in your screenshot) - on the main Manage batches page where it gives a list of Currently Available Batches, there is a column title 'Item Count' - when adding a new batch, there is a message saying "There are no items in batch 0 yet, Use the toolbar above to add items." So in my opinion, four more instances where it should say patrons. Will set to Failed QA so you can submit a new patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 06:39:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 04:39:38 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 --- Comment #2 from Indranil Das Gupta --- Created attachment 41307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41307&action=edit Bug 14632 - Fix alert message for single item batch Fixes the incorrect msg "Please select at least label to delete." for attempts to delete from single patron batches. Notifies the user that doing so will delete the batch. It disallows direct deletion, instead suggests the users to use the 'Delete batch' option assuming the users know what they are doing. Test plan ========= 1/ Load a single patron batch in edit mode and attempt to delete the single record. The JS alert message will inform that "Please select at least label to delete." 2/ Apply patch and refresh page and try to delete the single record again. 3/ This time the alert will inform the user that doing so will delete the batch and should that be desired action to choose the 'Delete batch' option from the toolbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 06:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 04:40:52 +0000 Subject: [Koha-bugs] [Bug 14632] Incorrect alert while deleting single item in batch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14632 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 07:10:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 05:10:05 +0000 Subject: [Koha-bugs] [Bug 14634] New: Warns when placing hold on record with no items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Bug ID: 14634 Summary: Warns when placing hold on record with no items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Use of uninitialized value $canReserve in string eq at /home/vagrant/kohaclone/reserve/request.pl line 204 Use of uninitialized value $canReserve in string eq at /home/vagrant/kohaclone/reserve/request.pl line 208 Use of uninitialized value $canReserve in string eq at /home/vagrant/kohaclone/reserve/request.pl line 211 Use of uninitialized value $canReserve in hash element at /home/vagrant/kohaclone/reserve/request.pl line 216 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 07:12:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 05:12:31 +0000 Subject: [Koha-bugs] [Bug 14634] Warns when placing hold on record with no items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 07:12:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 05:12:49 +0000 Subject: [Koha-bugs] [Bug 14634] Warns when placing hold on record with no items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 --- Comment #1 from Aleisha Amohia --- Created attachment 41308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41308&action=edit Bug 14634: Warns when placing hold on record with no items To test: 1) Create a new record in Cataloguing 2) When done, instead of adding an item to the record, click on the Holds tab in the left nav 3) Notice warns 4) Apply patch and refresh page 5) Click on Holds tab again 6) Notice warns are gone and page still works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 07:20:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 05:20:46 +0000 Subject: [Koha-bugs] [Bug 14603] Warns when checking in items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14603 --- Comment #1 from Aleisha Amohia --- Also started getting these warns when I tried to check in the same barcode that wasn't already checked out, multiple times: returns.pl: Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/circ/returns.pl line 386 returns.pl: Use of uninitialized value in hash element at /home/vagrant/kohaclone/circ/returns.pl line 466 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 07:33:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 05:33:19 +0000 Subject: [Koha-bugs] [Bug 14635] New: Sort branches in patroncards/add_user_search.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14635 Bug ID: 14635 Summary: Sort branches in patroncards/add_user_search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: indradg at gmail.com Reporter: indradg at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The branch names appear in random order. This patch will look to alphabetically sort them in the dropdown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 07:40:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 05:40:00 +0000 Subject: [Koha-bugs] [Bug 14630] date runtime parameter formatting date wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 14382 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 07:40:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 05:40:00 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #28 from Katrin Fischer --- *** Bug 14630 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 07:59:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 05:59:38 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #74 from Robin Sheat --- I've just pushed a new commit that makes the code work with the newer Catmandu::Store::Elasticsearch version. Until I re-roll the dependencies tarball, you'll want to grab the .deb file here: http://debian.koha-community.org/koha/otherthings/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 10:29:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 08:29:04 +0000 Subject: [Koha-bugs] [Bug 14458] Add SwaggerUI documentation for RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14458 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41167|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 41309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41309&action=edit Bug 14458: 5. Add SwaggerUI documentation for RESTful API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 11:00:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 09:00:26 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #14 from Pedro Ferreira --- can anyone guide me to sort this problem ..? thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 11:19:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 09:19:03 +0000 Subject: [Koha-bugs] [Bug 14600] MySQL server has gone away In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14600 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41152|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 11:43:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 09:43:19 +0000 Subject: [Koha-bugs] [Bug 14636] New: Sorting and searching by publication year in item search doesn't work correctly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Bug ID: 14636 Summary: Sorting and searching by publication year in item search doesn't work correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I am not sure if this is only a problem for MARC21 - it might. If you limit an item search by Year, using the pull down field and by call number, the reults are not correct. The shown publication year doesn't match what was searched for, the call number is correct in my example. Sorting the column for copyright year gives wrong results - the list changes, but the sorting is incorrect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 11:49:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 09:49:43 +0000 Subject: [Koha-bugs] [Bug 14102] item search export should include itemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14102 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I second that - for a library that doesn't have barcodes on all items the itemnumber is really useful for locating the right item or initiating a batch edit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 12:45:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 10:45:16 +0000 Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41258|0 |1 is obsolete| | --- Comment #14 from Olli-Antti Kivilahti --- Created attachment 41310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41310&action=edit Bug 14540 - Move member-flags.pl to PermissionsManager to better manage permissions for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 13:46:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 11:46:10 +0000 Subject: [Koha-bugs] [Bug 14637] New: Add patron category fails with MySQL 5.6.26 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Bug ID: 14637 Summary: Add patron category fails with MySQL 5.6.26 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: boutrosboutrosboutros at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Cannot add patron category in web interface (/cgi-bin/koha/admin/categorie.pl?op=add_form). It fails with "An error occurred when inserting this patron category. The patron category might already exist." The logs wil show: categorie.pl: DBD::mysql::st execute failed: Incorrect date value: '' for column 'enrolmentperioddate' at row 1 at /usr/share/koha/intranet/cgi-bin/admin/categorie.pl line 231., referer: http://192.168.50.12:8081/cgi-bin/koha/admin/categorie.pl?op=add_form Disabling STRICT_TRANS_TABLES in MySQL will fix the problem, but as the setting is default now, we should have a permanent fix. This is a similar problem as bug #13523. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 14:12:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 12:12:26 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41256|0 |1 is obsolete| | --- Comment #19 from Olli-Antti Kivilahti --- Created attachment 41311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41311&action=edit Bug 7174 - Authentication Rewrite - Core -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 14:12:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 12:12:49 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 --- Comment #20 from Olli-Antti Kivilahti --- Created attachment 41312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41312&action=edit Bug 7174 - Authentication Rewrite - Wrapper for C4::Auth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:14:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:14:22 +0000 Subject: [Koha-bugs] [Bug 14638] New: serials help wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 Bug ID: 14638 Summary: serials help wrong Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org The serials help file hasn't been updated for the new way of adding patterns. Patch coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:18:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:18:43 +0000 Subject: [Koha-bugs] [Bug 14638] serials help wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:36:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:36:39 +0000 Subject: [Koha-bugs] [Bug 14639] New: Extend Koha::MetadataRecord to handle serialization format Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Bug ID: 14639 Summary: Extend Koha::MetadataRecord to handle serialization format Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Koha::MetadataRecord was introduced to abstract records, and carry information about the records. It is currently missing a way to know the serialization format used. This is pretty important when it comes to using Koha::RecordProcessor to apply filters on records, as different filter could be needed depending on the serialization format: for example, a source could be a USMARC record and another one an XML record, both representing MARC21 metadata. The same applies if you think of JSON records, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:36:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:36:56 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins at cpbibliography.com Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:42:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:42:48 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:43:14 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #28 from R?mi Mayrand-Provencher --- Created attachment 41313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41313&action=edit Bug12747 - Follow-up to QA Removed unnecessary code in Breeding.pm and provided a new test in Breeding.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:43:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:43:30 +0000 Subject: [Koha-bugs] [Bug 14638] serials help wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 --- Comment #1 from Nicole C. Engard --- Created attachment 41314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41314&action=edit 0001-Bug-14638-Update-Serials-Help -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:56:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:56:33 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 41315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41315&action=edit Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle serialization format In order to use Koha::MetadataRecord as a container for moving records around it is important to let it carry the serialization format of the record object it was built with, so it is easier and cheaper to make decisions about records. This patch introduces regression tests for the changes to be made. The 'format' param is introduced, and also sets default values: schema => 'marc21' format => 'usmarc' so the default behaviour is preserved, and no changes are needed in places Koha::MetadataRecord is used. ->new also returns undef if no record is passed, and raises a carped warning. To test: - Apply the patch - Run the new tests $ prove t/Koha_MetadataRecord.t => FAIL: Tests shoud fail as the changes are not implemented on Koha::MetadataRecord -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:56:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:56:38 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 41316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41316&action=edit Bug 14639: Extend Koha::MetadataRecord to handle serialization format The description of this changes is on the regression tests commit message. To test: - Run $ prove t/Koha_MetadataRecord.t => FAIL: Tests fail because changes are not implemented - Apply this patch - Run $ prove t/Koha_MetadataRecord.t => SUCCESS: tests pass - Run $ prove t/Koha_Util_MARC.t => SUCCESS: it still passes - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:56:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:56:52 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 16:57:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 14:57:01 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:01:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:01:02 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #29 from R?mi Mayrand-Provencher --- Created attachment 41317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41317&action=edit Bug 12747 - Add extra column in Z3950 search This patch permits to add an extra column in Z3950 search result. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) shares same syspref as above 1) Go to cataloguing, click New from z3950 2) fill to result in a successful search 3) validate column Addition Fields sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with both patches together, followed test plan, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:01:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:01:06 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38460|0 |1 is obsolete| | --- Comment #30 from R?mi Mayrand-Provencher --- Created attachment 41318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41318&action=edit Bug 12747 - Add extra column in Z3950 search result This patch uses the standard field syntax (ex: 023$ab), allows writing fields without mentionning subfields and uses whitespace as a field separator instead of semicolon. sponsored by the CCSR ( http://www.ccsr.qc.ca ) Tested with both patches, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:01:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:01:10 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41313|0 |1 is obsolete| | --- Comment #31 from R?mi Mayrand-Provencher --- Created attachment 41319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41319&action=edit Bug12747 - Follow-up to QA Removed unnecessary code in Breeding.pm and provided a new test in Breeding.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:01:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:01:29 +0000 Subject: [Koha-bugs] [Bug 12216] One should be able to override zebra configuration on a per instance basis In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12216 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:01:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:01:44 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |remi.mayrand-provencher at inL | |ibro.com Attachment #38458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:02:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:02:10 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #263 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Chris! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:02:16 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41300|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:02:21 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41301|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:02:58 +0000 Subject: [Koha-bugs] [Bug 14547] Typo in help file for 3.20 (basket.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14547 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. ?Gracias Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:03:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:03:25 +0000 Subject: [Koha-bugs] [Bug 14548] Typo in help file for 3.20 (batch_record_modification.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14548 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. ?Gracias Hector! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 17:13:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 15:13:16 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #112 from Olli-Antti Kivilahti --- Created attachment 41320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41320&action=edit Bug 13799 - 1.1 RESTful API with reverse proxy configuration without api.host.domain OPTIONAL replacement to the Buugg 13799: 1. RESTful API with Mojolicious and Swagger2 httpd-configuration. Instead of having to go to your dns-provider, you can run the api from your current virtualhost. Use these configurations to reverse proxy www.host.domain/v1/ to the REST API. --------------------------- :INSTALLATION INSTRUCTIONS: --------------------------- You need Buugg 14448 - Adding the REST API as a Hypnotoad service, koha-api-daemon. to deploy the backend Mojolicous application as a FastCGI-daemon. Then add the modifications from etc/koha-httpd.conf to your /etc/apache2/sites-enabled/koha.conf and adjust paths to fit. ..$ a2enmod proxy ..$ a2enmod proxy_http ..$ service apache2 restart Much recommended is Buugg 14458: 5. Add SwaggerUI documentation for RESTful API to browse your API capabilities. Then just go to /v1/doc to see the API autodocumentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 18:09:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 16:09:43 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41271|0 |1 is obsolete| | --- Comment #113 from Olli-Antti Kivilahti --- Created attachment 41321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41321&action=edit Bug 13799: 4. API Authentication, part 1: API keys management in interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 19:29:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 17:29:24 +0000 Subject: [Koha-bugs] [Bug 14601] Cardnumber should not be required for patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601 --- Comment #3 from Danielle Elder --- Well, it's not so much that they don't want to add a cardnumber as it is they don't want to overwrite it. A lot of universities update patron data every semester with data from the school. The particular workflow it to import patrons from university data, with a populated cardnumber (same as attribute value (unique - college id). Then student comes into library to get a library-issued cardnumber and that borrower record is updated with that value. They want to, after that, be able to update patron data matching on the attribute (college id) for future semesters .... but if the cardnumber is required, that would be overwritten and the library-isssued cardnumber disappears. Usually you can make updates by only including the columns you want to change and leaving columns out you don't want to update. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 19:42:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 17:42:06 +0000 Subject: [Koha-bugs] [Bug 14601] Cardnumber should not be required for patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601 --- Comment #4 from Katrin Fischer --- Hm, I understand - we have a library requesting something similar. We currently restore the cardnumbers with SQL after importing, which works but is not a good solution. I think another way to make this work could be a 'don't update if not empty' flag for the import or something similar? We could also make the cardnumber optional, but I think we'd have quite a few libraries run into the mentioned bugs then. Not sure what's best. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 21:46:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 19:46:43 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |wsalesky at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 22:43:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 20:43:30 +0000 Subject: [Koha-bugs] [Bug 14640] New: 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640 Bug ID: 14640 Summary: 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com 1) place biblio level hold on a book to borrower A. 3) check out an item of the book to borrower B. 4) When confirming checkout, check the 'Cancel hold' check-box, and click the "Yes, check out" button. 5) Click Show Checkouts. Note that the item has an 'On hold' link in the 'Check In' area. Clicking the link brings you to reserve/request.pl?biblionumber=..., showing the un-cancelled hold. This was replicated on Koha 3.19.00.038 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 23:18:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 21:18:05 +0000 Subject: [Koha-bugs] [Bug 14630] date runtime parameter formatting date wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14630 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- This is fixed in 3.18.09. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 3 23:58:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 21:58:15 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #264 from Liz Rea --- Created attachment 41322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41322&action=edit Bug 7143 - paces in history.txt instead of tabs break display on website. This may be the only place in koha where a tab should be a tab and not 4 spaces. Yes, I'll try to fix the script that does the conversion for the website to handle 4 spaces instead of tabs, but for now can we have this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 00:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 22:17:24 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Attachment #41322|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 00:19:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 22:19:38 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #265 from Liz Rea --- Created attachment 41323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41323&action=edit Bug 7143 - spaces in history.txt instead of tabs break display on website This may be the only place in koha where a tab should be a tab and not 4 spaces. I'll try to fix the script that does the conversion for the website to handle 4 spaces instead of tabs, but for now can we have this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 01:12:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Aug 2015 23:12:57 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #266 from Liz Rea --- I've fixed the website conversion script to deal with 4 space tabs so it is fine at the moment, but I still think we should be consistent in the history.txt file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 03:37:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 01:37:37 +0000 Subject: [Koha-bugs] [Bug 14263] Export of CSV from item search form does only work in English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #16 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 03:40:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 01:40:39 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #31 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 04:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 02:21:39 +0000 Subject: [Koha-bugs] [Bug 14638] serials help wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 --- Comment #2 from Aleisha Amohia --- Created attachment 41324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41324&action=edit Bug 14638: Update Serials Help The serials help file was out of date for 3.18+ To test: * apply patch * Go to serials > new subscription * Click help * Confirm help correct Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 04:21:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 02:21:51 +0000 Subject: [Koha-bugs] [Bug 14638] serials help wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 04:31:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 02:31:03 +0000 Subject: [Koha-bugs] [Bug 14641] New: Warns in subscription-add.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Bug ID: 14641 Summary: Warns in subscription-add.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com subscription-add.pl: Use of uninitialized value $selected_lettercode in string eq at /home/vagrant/kohaclone/serials/subscription-add.pl line 231 subscription-add.pl: Use of uninitialized value $selected_lettercode in string eq at /home/vagrant/kohaclone/serials/subscription-add.pl line 231 To reproduce, go to Serials and click New Subscription. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 04:34:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 02:34:37 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 --- Comment #1 from Aleisha Amohia --- Created attachment 41325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41325&action=edit Bug 14641: Warns in subscription-add.pl I think the warns are being triggered because there are brackets around it (like my ($selected_lettercode) ) which doesn't seem necessary as we're only declaring one variable? So I've removed the brackets. To test: 1) Reproduce warns by clicking New Subscription 2) Apply patch 3) Click New Subscription again 4) Confirm warns are gone -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 04:34:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 02:34:45 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 08:43:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 06:43:51 +0000 Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 --- Comment #4 from Jonathan Druart --- (In reply to M. Tompsett from comment #3) > Comment on attachment 40990 [details] [review] > Bug 10005: Inventory - Add an option to not check in items > > Review of attachment 40990 [details] [review]: > ----------------------------------------------------------------- > > ::: tools/inventory.pl > @@ +218,5 @@ > > + if ($doreturn){ > > + push @errorloop, {'barcode'=>$barcode,'ERR_ONLOAN_RET'=>1} > > + } else { > > + push @errorloop, {'barcode'=>$barcode,'ERR_ONLOAN_NOT_RET'=>1} > > + } > > This unless statement merely doesn't check them in. Where's the warning as > requested in comment #1? I don't get it. Did you test the patch? >From the description; "I think the problem here is that there is no warning or way to tell Koha to not check the items in" I have chosen the second way and added a checkbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 08:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 06:47:04 +0000 Subject: [Koha-bugs] [Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #8) > I also tested this on master - works ok for me. All pages in cataloguing > search seem to display results as expected. > > Jonathan, could this be a problem with one of the filters again? Yes, it could be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 08:56:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 06:56:27 +0000 Subject: [Koha-bugs] [Bug 13443] DBD::mysql::db do failed: Table 'koha_library.roadtype' doesn't exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- (In reply to Mason James from comment #3) > this bug might be a WONTFIX Agreed, I would even say this is not a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:14:39 +0000 Subject: [Koha-bugs] [Bug 14123] Patroncard: Patron search for batch no longer has Select / Select All / Add selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |13891 --- Comment #3 from Jonathan Druart --- With bug 13891 (and others), the patron searches are now standardized. They are all the same and all use the same code. I have tried to keep all previous behaviors, but, if I am remember correctly, these 2 links only existed on this page. I have preferred to kick them and keep consistency in the code. I have not look at the code yet, but it should be quite easier (I hope!) to add these 2 links to the tables where it's needed. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 [Bug 13891] Make all patron searches use DataTables server-side processing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:14:39 +0000 Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables server-side processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14123 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 [Bug 14123] Patroncard: Patron search for batch no longer has Select / Select All / Add selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:23:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:23:04 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com --- Comment #69 from Matthias Meusburger --- When applying the patch on master, I get the following error when trying to display an existing record: Request: /cgi-bin/koha/oai.pl?verb=GetRecord&identifier=KOHA-OAI-TEST:10&metadataPrefix=oai_dc Response: Can't use an undefined value as a subroutine reference at /home/koha/versions/kohacommunity/opac/oai.pl line 337. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:28:34 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Actually I would say that the line could only be replaced with a call to C4::Context->preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:28:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:28:55 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:33:53 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #21 from Jonathan Druart --- (In reply to Maxime Beaulieu from comment #20) > Indeed, the "guarantor" option could be added to the syspref. > If you agree to add this feature to bug 12802, we can close this one and/or > mark it as duplicate. As you can see on bug 12802, I am not in charge of this bug anymore. And I would be very surprised that it will be included. I have suggested that to help you to integrate this one, not to make 12802 much harder to integrate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:40:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:40:24 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #70 from Gaetan Boisson --- Indeed, that was sloppy testing on my part: i tested the listrecord verb, verified deleted records and resumption token where properly handled, but it turns out the getrecord verb is broken. Marking as failed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:56:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:56:18 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41268|0 |1 is obsolete| | --- Comment #114 from Olli-Antti Kivilahti --- Created attachment 41326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41326&action=edit Bug 13799: 1. RESTful API with Mojolicious and Swagger2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:56:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:56:38 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41320|0 |1 is obsolete| | --- Comment #115 from Olli-Antti Kivilahti --- Created attachment 41327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41327&action=edit Bug 13799 - 1.1 RESTful API with reverse proxy configuration without api.host.domain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:56:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:56:55 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41269|0 |1 is obsolete| | --- Comment #116 from Olli-Antti Kivilahti --- Created attachment 41328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41328&action=edit Bug 13799 - 2. Set up logging and configuration file reading for Mojolicious. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:57:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:57:11 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41270|0 |1 is obsolete| | --- Comment #117 from Olli-Antti Kivilahti --- Created attachment 41329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41329&action=edit Bug 13799: 3. Force UTF-8 charset in responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:57:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:57:27 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41321|0 |1 is obsolete| | --- Comment #118 from Olli-Antti Kivilahti --- Created attachment 41330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41330&action=edit Bug 13799: 4. API Authentication, part 1: API keys management in interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:57:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:57:43 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41272|0 |1 is obsolete| | --- Comment #119 from Olli-Antti Kivilahti --- Created attachment 41331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41331&action=edit Bug 13799: 5. API authentication system - Swagtenticator authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:58:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:58:00 +0000 Subject: [Koha-bugs] [Bug 14458] Add SwaggerUI documentation for RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14458 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41309|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 41332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41332&action=edit Bug 14458: 5. Add SwaggerUI documentation for RESTful API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:58:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:58:14 +0000 Subject: [Koha-bugs] [Bug 14448] Hypnotoad and Nginx config for REST API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14448 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41168|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 41333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41333&action=edit Bug 14448 - Adding the REST API as a Hypnotoad service, koha-api-daemon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 09:58:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 07:58:43 +0000 Subject: [Koha-bugs] [Bug 14448] Hypnotoad and Nginx config for REST API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14448 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41169|0 |1 is obsolete| | --- Comment #7 from Olli-Antti Kivilahti --- Created attachment 41334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41334&action=edit Bug 14448 - Nginx reverse proxy config baseline for Koha REST API. Tweaking needed to work with makefile. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 10:06:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 08:06:57 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #32 from Jonathan Druart --- (In reply to Kyle M Hall from comment #31) > I've been testing > https://git.biblibre.com/biblibre/kohac/commits/ft/bug_13323 > > Branch definitely needs rebased, but I tested it as is. My own attempts to > rebase it ended with the unit tests failing, which I'm hoping is just my > fault I didn't get any conflict (except updatedatabase.pl) on rebasing the branch on master. > Not sure which of the three bugs to put this on, so it's going here ; ) > > There seems to be an issue where if you receive multiple, the receiving > screen lists the total, but then the total is multiplied by the number of > items received! > > http://screencast.com/t/0gpbhP0P2tdC > http://screencast.com/t/NDwekDjesa > http://screencast.com/t/Fk6PBDv15o2K 1 screen is missing, the neworderempty when you have created the order. I have tested on my local branch (before the jajm rebase) and with the remote branch, it seems to work as excepted. - Create an order without filling "actual cost" - Receive 1 or 2 item(s) (the actual cost is automatically filled with the budgeted cost, for 1 item. For you, it's 18, it should be 9 on your second screenshot. Did you update it manually or it was automatically filled with 18?). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 10:22:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 08:22:46 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #17 from Jonathan Druart --- (In reply to R?mi Mayrand-Provencher from comment #12) > Hi Jonathan, > > > ::: acqui/basket.pl > > @@ +197,5 @@ > > > -type => 'text/csv', > > > -attachment => 'basket' . $basket->{'basketno'} . '.csv', > > > ); > > > + if ( $query->param('csv_profile') eq 'default'){ > > > + print GetBasketAsCSV($query->param('basketno'), $query); > > > > Actually this subroutine should take the csv profile in parameter, don't you > > think? > > Could you be more specific about what are the changes you would like to see > here? You added 2 subroutines to the script acqui/basket.pl to build a CSV file. But the subroutine GetBasketAsCSV already does it. I think you should modify this subroutine to do what you want to do: export a basket as CSV given a specific CSV profile. The call would be: my $csv = GetBasketAsCSV($basketno, $query, $csv_profile_id); Yes, it's a little bit more work, but more robust and reusable :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 10:46:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 08:46:36 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 --- Comment #33 from Katrin Fischer --- Looking at this - could it be auser error? I think Kyle wanted to receive 2 items (9 was the calculated cost), so he entered the price for 2 = 18 into actual cost on receive - but it expects the price for a single item, so he should have entered 9 and let Koha mulitply it. (I checked, that's how it's currently working too in 3.18.8). It could be a nice enh for the future to add a little text hint there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:03:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:03:52 +0000 Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:03:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:03:56 +0000 Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 --- Comment #4 from Jonathan Druart --- Created attachment 41335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41335&action=edit Bug 14205: Deleting an Item/Record does not remove link to course reserve A constraint is missing on the course_reserves.ci_id field. This patch adds it and removes orphan rows. Test plan: 0/ Don't apply the patch 1/ Login to Staff Site. 2/ Go to Course Reserves 3/ Create Course 4/ Add Reserve 5/ Go to item added (delete item/record) 6/ Refresh Course (see no items attached) 7/ Delete Course 8/ See course still listed in the courses (Not deleted) 9/ Apply the patch and execute the updatedatabase entry. 10/ Delete the Course Note that the course has correctly been removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:05:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:05:17 +0000 Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Depends on| |8215 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 [Bug 8215] Add Course Reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:05:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:05:17 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14205 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 [Bug 14205] Deleting an Item/Record does not remove link to course reserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:07:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:07:30 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #13 from Jonathan Druart --- (In reply to Kyle M Hall from comment #11) > Based on my initial skimming of the patches, I think this looks great! > > The only very minor nitpicky suggestion would be the naming of the clases. > You could rename Koha::Virtualshelf to Koha::List and > Koha::Virtualshelfshares to Koha::List::Sharess or something along those > lines so that we can start down the road to having our internal nomenclature > match our external nomenclature. > > What do you think of that Jonathan? It seems that a consensus on the name is not reach :) And I really don't want to rewrite the job already done or wait to find a name... I am sure it will be quite easy to rename everything (tables and classes) when this change will be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:11:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:11:41 +0000 Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13232 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:11:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:11:41 +0000 Subject: [Koha-bugs] [Bug 13232] patron letter browse not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14562 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:15:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:15:02 +0000 Subject: [Koha-bugs] [Bug 13780] A patron without cardnumer will break searching for category code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- It seems to work now. Could you confirm? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:19:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:19:03 +0000 Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 --- Comment #1 from Jonathan Druart --- What kind of searches did you try? I have a patron with cardnumber="", search by letter (browse by name), and different filter combinations work here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:29:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:29:10 +0000 Subject: [Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rameau authorities |Introduce a way of handling | |Rameau composed | |authorities, without | |breaking normal workflow CC| |gaetan.boisson at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:29:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:29:46 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Jonathan Druart --- I have just retested and it works for me. Could you give me more details please? The button should appears on the list view: /cgi-bin/koha/virtualshelves/shelves.pl, tab "Public lists". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 11:54:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 09:54:44 +0000 Subject: [Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 --- Comment #4 from Gaetan Boisson --- It is quite likely that composed authorities are a specificity of the French national library (BNF). The idea is that, in a single authority controlled field of your bibliographic record, you will be linking to different authorities of your authority file. In Matthias' example: 606 _311954119 _aGuerillas _311943195 _yBolivie _311976947 _z1945-1970 The 606 field is for "a common noun or noun phrase used as a subject heading", but it allows for a $y Geographical Subdivision and a $z Chronological Subdivision. The idea behind composed authorities is that the geographical subdivision will link to a different authority, which will be a Geographical Name, which would typically go in a 607 field as the main heading. So instead of having one authority for Guerillas in Bolivia, another one for Timor, yet another one for... etc. You have one Guerilla authority, and the subdivisions link to similarly unique authorities for geographical names. For now this patch only aims at making this possible in Koha, and compatible with the tool we made to update one library's records with those from the BNF server's, available here: https://git.biblibre.com/biblibre/vendangeur. Managing this in the graphical interface would be the next step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 12:00:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 10:00:35 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 12:29:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 10:29:36 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 12:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 10:29:40 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #7 from Jonathan Druart --- Created attachment 41336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41336&action=edit Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 12:30:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 10:30:32 +0000 Subject: [Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14470 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 12:30:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 10:30:32 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10860 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 [Bug 10860] On-site checkouts (was In-House Use) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 12:51:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 10:51:30 +0000 Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Jonathan Druart --- Katrin, I think we are not understanding each others. This patch only affect the tag cloud, not the table. The mine parameter is *removed* by this patch. The idea is to display the same tag cloud, whatever you have clicked on "your tags" or "tag cloud" links. I can confirm it works for me. Please try again. The problem you reported is just a wording issue: the limit just allows to restrict the number of tags displayed (no matter who has created them). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 13:18:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 11:18:55 +0000 Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178 --- Comment #18 from Katrin Fischer --- Hi Jonathan, I think the table and the other display appeared the same for me. The 'mine' pull down still showed... and I think I disagree with the idea :( I think it should be possible to show me a tag cloud with only my tags. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 13:48:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 11:48:38 +0000 Subject: [Koha-bugs] [Bug 14638] serials help wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 --- Comment #3 from Nicole C. Engard --- Created attachment 41337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41337&action=edit Bug 14638: Update Serials Help The serials help file was out of date for 3.18+ To test: * apply patch * Go to serials > new subscription * Click help * Confirm help correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 13:49:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 11:49:41 +0000 Subject: [Koha-bugs] [Bug 14638] serials help wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 13:49:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 11:49:56 +0000 Subject: [Koha-bugs] [Bug 14638] serials help wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 13:56:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 11:56:57 +0000 Subject: [Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 --- Comment #4 from Vitor Fernandes --- Created attachment 41338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41338&action=edit Bug 14420 : bulkmarcimport.pl - Some problems http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 Created by: Vitor Fernandes Sponsored by: KEEP SOLUTIONS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 14:14:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 12:14:32 +0000 Subject: [Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 Vitor Fernandes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41338|0 |1 is obsolete| | --- Comment #5 from Vitor Fernandes --- Created attachment 41339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41339&action=edit Bug 14420 : bulkmarcimport.pl - Some problems http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 Test plan: - Add one record with two ISBN using bulkmarcimport - Add the same record using bulkmarcimport with ISBN comparing - The comparing of ISBN isn't working because the bulkmarcimport are trying to check if isbn1 is in the column isbn of biblio table (check if equal). The column isbn of the first record is "isbn1 | isbn2". - Add one record with one ISBN using bulkmarcimport - Add the same record using bulkmarcimport and ISBN comparing - The first record will be updated but the items of the second record will not be added to the first one - Apply the patch - Add one record with two ISBN using bulkmarcimport - Add the same record using bulkmarcimport with ISBN comparing - The comparing of ISBN will work because the bulkmarcimport will use "like" comparing instead of "equal" - Add one record with one ISBN using bulkmarcimport - Add the same record using bulkmarcimport with ISBN comparing and updateadditems - The first record will be updated and the items of the second record will be added to the first one Created by: Vitor Fernandes Sponsored by: KEEP SOLUTIONS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 14:17:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 12:17:54 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 --- Comment #3 from Vitor Fernandes --- Created attachment 41340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41340&action=edit export_borrowers.pl changed to support patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 14:24:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 12:24:38 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Vitor Fernandes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40802|0 |1 is obsolete| | Attachment #41340|0 |1 is obsolete| | --- Comment #4 from Vitor Fernandes --- Created attachment 41341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41341&action=edit export_borrowers.pl changed to support patron attributes Test plan: - Use export_borrowers.pl to export all patron and all fields - The patrons extended attributes are not exported - Apply the patch - Use export_borrowers.pl with the no fields specified or with the field patron_attributes - The patrons extended attributes will be exported in one column Create by: Vitor Fernandes Sponsored by: KEEP SOLUTIONS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 14:49:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 12:49:54 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #134 from Katrin Fischer --- Hm, do we still need a bug report for the visibility check of the hold buttons? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 14:57:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 12:57:20 +0000 Subject: [Koha-bugs] [Bug 14642] New: Add logging of hold modifications Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Bug ID: 14642 Summary: Add logging of hold modifications Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I think it's high time we added a HoldsLog system preference to log creation, updating, and filling of holds. I would say the following is needed: 1) Hold creation ( staff/opac, bib, item, date, priority ) 2) All hold modifications ( changing of priorities except for reflowing priorities, trapping an item to a hold, deleting a hold, etc ) 3) Hold fulfillment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 14:57:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 12:57:24 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:05:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:05:16 +0000 Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #19 from Jonathan Druart --- (In reply to Katrin Fischer from comment #18) > Hi Jonathan, I think the table and the other display appeared the same for > me. The 'mine' pull down still showed... and I think I disagree with the > idea :( > I think it should be possible to show me a tag cloud with only my tags. With C4::Tags as it is for now, it's impossible to introduce big changes. IMO the tag cloud should display all tags, especially because the page says "all tags". What is the 'mine' pull down? Setting in discussion. Nicole and Owen, what's your opinion on this one? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:06:50 +0000 Subject: [Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 --- Comment #5 from Matthias Meusburger --- Created attachment 41342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41342&action=edit Bug 14560 [Follow-up]: Compatible with DOM indexing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:16:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:16:32 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #77 from Jonathan Druart --- FWIW, it works perfectly on my local branch, but it is ... 1440 commits behind master... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:18:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:18:30 +0000 Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 --- Comment #2 from Bernard Shiundu --- (In reply to Colin Campbell from comment #1) > Can you document the messages and responses. The initial error suggests that > the login is failing especially as sip.err is closed as soon at login > succeeds. Took a further look on syslog and the outputs below: ============= Scenario A: LDAP Enabled: ============= koha_sip[29552]: Configuration::find_service: Trying 9001/tcp koha_sip[29552]: raw_transport: uname/inst: 'term1/SUL' koha_sip[29552]: read_SIP_packet, INPUT MSG: '9300CNterm1|COterm1|CPSUL|AY1AZF5DE' koha_sip[29552]: INPUT MSG: '9300CNterm1|COterm1|CPSUL|AY1AZF5DE' koha_sip[29552]: Sip::MsgType::new('C4::SIP::Sip::MsgType', '9300CNterm...', '93'): seq.no '1', protocol 2 koha_sip[29552]: Sip::MsgType::_initialize('Login', '00CNterm1|COterm1|CPSUL|', 'A1A1', '2', ...) koha_sip[29552]: Successful login/auth for 'term1' of 'SUL' koha_sip[29552]: login_core: $VAR1 = 'ILS'; koha_sip[29552]: new ILS 'SUL' koha_sip[29552]: OUTPUT MSG: '941AY1AZFDFC' koha_sip[29552]: read_SIP_packet, INPUT MSG: '9900302.00AY2AZFCA4' koha_sip[29552]: INPUT MSG: '9900302.00AY2AZFCA4' koha_sip[29552]: Sip::MsgType::new('C4::SIP::Sip::MsgType', '9900302.00...', '99'): seq.no '2', protocol 2 koha_sip[29552]: Sip::MsgType::_initialize('SC Status', '00302.00', 'CA3A4', '8', ...) koha_sip[29552]: OUTPUT MSG: '98YYYYNN10000520150804 1304072.00AOSUL|BXYYYYYYYYYYYNYYYY|AY2AZEE64' koha_sip[29552]: read_SIP_packet, INPUT MSG: '6300120150804 130404 AOSUL|AAkohauser|AC|ADldappwd|AY3AZED0C' koha_sip[29552]: INPUT MSG: '6300120150804 130404 AOSUL|AAkohauser|AC|ADldappwd|AY3AZED0C' koha_sip[29552]: Sip::MsgType::new('C4::SIP::Sip::MsgType', '6300120150...', '63'): seq.no '3', protocol 2 koha_sip[29552]: Sip::MsgType::_initialize('Patron Info', '00120150804 130404 AOSUL|AAkohauser|AC|ADldappwd|', 'A3A18A10','31', ...) koha_sip[29552]: new ILS::Patron(kohauser): found patron '00783' koha_sip[29552]: patron_status_string: 00783 charge_ok: 1 koha_sip[29552]: OUTPUT MSG: '64 00120150804 130407000000080008000000000000AOSUL|AA00783|AEBernard Shiundu Simwenyi|BLY|CQN|CC5001|BDP O Box 41539 Mombasa 80100|BEkohauser at my.email|BF0721 230520|PCAC|PIY|AFGreetings from Koha. |AY3AZC03E' koha_sip[29552]: read_SIP_packet, INPUT MSG: '' koha_sip[29552]: read_SIP_packet input empty (), end of input. koha_sip[29552]: raw_transport: shutting down ================ Scenario B: LDAP Disabled ================ koha_sip[29264]: Configuration::find_service: Trying 9001/tcp koha_sip[29264]: raw_transport: timeout is 60 koha_sip[29264]: read_SIP_packet, INPUT MSG: '9300CNterm1|COterm1|CPSUL|AY1AZF5DE' koha_sip[29264]: INPUT MSG: '9300CNterm1|COterm1|CPSUL|AY1AZF5DE' koha_sip[29264]: Sip::MsgType::new('C4::SIP::Sip::MsgType', '9300CNterm...', '93'): seq.no '1', protocol 2 koha_sip[29264]: Sip::MsgType::_initialize('Login', '00CNterm1|COterm1|CPSUL|', 'A1A1', '2', ...) koha_sip[29264]: Successful login/auth for 'term1' of 'SUL' koha_sip[29264]: login_core: $VAR1 = 'ILS'; koha_sip[29264]: new ILS 'SUL' koha_sip[29264]: OUTPUT MSG: '941AY1AZFDFC' koha_sip[29264]: raw_transport: uname/inst: 'term1/SUL' koha_sip[29264]: read_SIP_packet, INPUT MSG: '9900302.00AY2AZFCA4' koha_sip[29264]: INPUT MSG: '9900302.00AY2AZFCA4' koha_sip[29264]: Sip::MsgType::new('C4::SIP::Sip::MsgType', '9900302.00...', '99'): seq.no '2', protocol 2 koha_sip[29264]: Sip::MsgType::_initialize('SC Status', '00302.00', 'CA3A4', '8', ...) koha_sip[29264]: OUTPUT MSG: '98YYYYNN10000520150804 1257372.00AOSUL|BXYYYYYYYYYYYNYYYY|AY2AZEE5A' koha_sip[29264]: read_SIP_packet, INPUT MSG: '6300120150804 125734 AOSUL|AAkohauser|AC|ADkohapwd|AY3AZEDC8' koha_sip[29264]: INPUT MSG: '6300120150804 125734 AOSUL|AAkohauser|AC|ADkohapwd|AY3AZEDC8' koha_sip[29264]: Sip::MsgType::new('C4::SIP::Sip::MsgType', '6300120150...', '63'): seq.no '3', protocol 2 koha_sip[29264]: Sip::MsgType::_initialize('Patron Info', '00120150804 125734 AOSUL|AAkohauser|AC|ADkohapwd|', 'A3A18A10','31', ...) koha_sip[29264]: new ILS::Patron(kohauser): found patron '00783' koha_sip[29264]: patron_status_string: 00783 charge_ok: 1 koha_sip[29264]: OUTPUT MSG: '64 00120150804 125737000000080008000000000000AOSUL|AA00783|AEBernard Shiundu Simwenyi|BLY|CQY|CC5001|BDP O Box 41539 Mombasa 80100|BEkohauser at my.email|BF0721 230520|PCAC|PIY|AFGreetings from Koha. |AY3AZC029' koha_sip[29264]: read_SIP_packet, INPUT MSG: '' koha_sip[29264]: read_SIP_packet input empty (), end of input. koha_sip[29264]: raw_transport: shutting down > > Not sure what is involved ehen you say "Koha users cannot login via SIP" Just to clarify further - I run a mixed mode outfit. Currently University Employees use ldap credentials to login to the opac while Students login to the opac using koha database credentials. However from a SIP client - only users with koha database credentials can login. My thinking was that authentication from a SIP client should mirror authentication via the OPAC (i.e hierarchical) > what request are you sending and what response are you receiving? I guess those are all in the syslog outputs above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:25:30 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #78 from Katrin Fischer --- Maybe something got lost in a rebase? I think the needed fix is probably something small, but I didn't understand the code enough to make it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:28:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:28:40 +0000 Subject: [Koha-bugs] [Bug 6178] tag cloud diff depends on where you click In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178 --- Comment #20 from Katrin Fischer --- I think we are misunderstanding each other somewhere - I will try do make some screenshots soon. - also others taking a look is a good idea :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:46:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:46:19 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #79 from Jonathan Druart --- Created attachment 41343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41343&action=edit Bug 10363: FIX rebase conflict error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:46:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:46:46 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #80 from Jonathan Druart --- Created attachment 41344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41344&action=edit Bug 10363: FIX prevent duplicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:50:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:50:25 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41344|0 |1 is obsolete| | --- Comment #81 from Jonathan Druart --- Created attachment 41345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41345&action=edit Bug 10363: FIX regression - prevent duplicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:59:50 +0000 Subject: [Koha-bugs] [Bug 14643] New: Add homebranch to checkouts table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14643 Bug ID: 14643 Summary: Add homebranch to checkouts table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Librarians have expressed that they would like to be able to see the home library for a given checkout's item. I think adding yet another column would be counter-productive and it would be better to add the library name to either the location or callnumber column. Any thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 15:59:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 13:59:58 +0000 Subject: [Koha-bugs] [Bug 14643] Add homebranch to checkouts table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14643 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:07:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:07:05 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 --- Comment #5 from Jonathan Druart --- Is it ready to test? Don't forget to provide a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:14:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:14:11 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn't back backup Zebra indexes by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:19:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:19:26 +0000 Subject: [Koha-bugs] [Bug 14611] SMS::Send hangs on malformed mobile #, process_message_queue fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14611 --- Comment #3 from Kyle M Hall --- Excellent writeup! It seems to me that checking on the front-end using libphonenumber would be the simplest and most effect change. Of course this doesn't fix bad phone numbers already in the database. I think updatedatabase could do a basic validity check and warn if there is anything untoward in there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:22:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:22:07 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Vitor Fernandes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Vitor Fernandes --- Jonathan, Yes, is ready to test. You can check the test plan on the patch commit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:22:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:22:43 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40480|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 41346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41346&action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan: 0/ sudo cpanm Template::Stash::AutoEscaping 1/ Verify don't reproduce the XSS issue described on bug 13609 and other xss related bugs. 2/ Try to find some encoding issues (detail page, search results, facets, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:22:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:22:53 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40481|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 41347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41347&action=edit Bug 13618: Remove html filters at the OPAC This patch removes the html filters at the OPAC, if necessary. Generated with: perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:22:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:22:59 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40482|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 41348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41348&action=edit Bug 13618: Specific places where we don't need to escape variables There is no need to escape the html generated by the XSLT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:23:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:23:14 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40483|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 41349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41349&action=edit Bug 13618: Remove html filters at the intranet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:23:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:23:20 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40484|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 41350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41350&action=edit Bug 13618: Specific places where we don't need to escape variables - intra -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:23:27 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40485|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 41351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41351&action=edit Bug 13618: Specific for pagination_bar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:23:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:23:37 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40487|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 41352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41352&action=edit Bug 13618: Specific for the ISBD view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:24:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:24:36 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:33:13 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #6 from Jonathan Druart --- I can try and provide a fix if we know what we need. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:34:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:34:15 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 --- Comment #7 from Jonathan Druart --- (In reply to Vitor Fernandes from comment #6) > You can check the test plan on the patch commit. Yes sorry, it's on the bug report but not on the patch! Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:40:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:40:35 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #34 from Jonathan Druart --- Does not work: circulation.pl: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 618. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:53:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:53:34 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:53:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:53:40 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #35 from Jonathan Druart --- Created attachment 41353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41353&action=edit Bug 13618: Fix error 'Not a GLOB reference' The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. The easier fix is to replace it with a SWITCH. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:58:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:58:46 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #36 from Jonathan Druart --- Found something else, the checkout table is broken on circulation.pl (JS errors). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 16:59:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 14:59:05 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #7 from Katrin Fischer --- I think this could be something for the mailing lists - wonder if people are aware of current behaviour and if someone can explain "why". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:12:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:12:03 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #37 from Jonathan Druart --- Created attachment 41354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41354&action=edit Bug 13618: Specific for IntranetUser* and OPACUser* prefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:12:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:12:10 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #38 from Jonathan Druart --- Created attachment 41355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41355&action=edit Bug 13618: Specific for ColumnsSettings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:12:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:12:32 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:21:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:21:22 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:35:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:35:39 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:35:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:35:43 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #3 from Jonathan Druart --- Created attachment 41356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41356&action=edit Bug 11298: Don't force the renew time to 23:59 If you try to renew an item using the "Renewal due date" at the bottom of the checkouts table, the time will be hardcoded to 23:59 no matter what the user has chosen. Test plan: Check an item out to a patron renew the item and specify a due date using the datetime picker plugin at the bottom of the table Confirm the time you have chosen is correctly used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:36:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:36:01 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:36:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:36:17 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11298 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 [Bug 11298] Renewal due date won't take specified time into account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:36:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:36:17 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 [Bug 11703] Convert checkouts table to ajax datatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:42:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:42:05 +0000 Subject: [Koha-bugs] [Bug 14644] New: SIP2 terminal authentication via telnet transport broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Bug ID: 14644 Summary: SIP2 terminal authentication via telnet transport broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The removal of C4::SIP::Sip::Configuration::* in bug 13506 did not reach all of the code that was using those classes. In particular, the telnet transport expects to compare the password supplied by the client with the password in the SIP configuration, and at the moment attempts to use the object method ->password() that was previously supplied by C4::SIP::Sip::Configuration::Account. Since that method no longer exists, what happens is that the SIPServer backend crashes and aborts the connection if the client attempts to log in via the telnet transport. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 17:42:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 15:42:23 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gmcharlt at gmail.com |ity.org | Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:08:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:08:18 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41315|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 41357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41357&action=edit Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle serialization format and record id In order to use Koha::MetadataRecord as a container for moving records around it is important to let it carry the serialization format of the record object it was built with, so it is easier and cheaper to make decisions about records. This patch introduces regression tests for the changes to be made. The 'format' param is introduced, and also sets default values: schema => 'marc21' format => 'marc' A new (optional) 'id' param is added so the record carries its own id outside of it. The default behaviour is preserved, and no changes are needed in places Koha::MetadataRecord is used. ->new also returns undef if no record is passed, and raises a carped warning. To test: - Apply the patch - Run the new tests $ prove t/Koha_MetadataRecord.t => FAIL: Tests shoud fail as the changes are not implemented on Koha::MetadataRecord -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:08:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:08:25 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41316|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 41358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41358&action=edit Bug 14639: Extend Koha::MetadataRecord to handle serialization format and record id The description of this changes is on the regression tests commit message. To test: - Run $ prove t/Koha_MetadataRecord.t => FAIL: Tests fail because changes are not implemented - Apply this patch - Run $ prove t/Koha_MetadataRecord.t => SUCCESS: tests pass - Run $ prove t/Koha_Util_MARC.t => SUCCESS: it still passes - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:08:59 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 --- Comment #1 from Galen Charlton --- Created attachment 41359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41359&action=edit Bug 14644: unbreak SIP2 terminal login when using telnet transport This patch fixes breakage introduced by the patch for bug 13506 that prevented SIP2 clients from authenticating themselves over the telnet transport. Attempts to do so would manifest by the SIPServer backend crashing and the connection getting closed. To test: [1] Use the stock SIPServer config, etc/SIPconfig.xml, and ensure that the database contains a staff user whose username is 'term1' and password is 'term1' that has the circulate permission. [2] Start SIPServer, telnet to port 8023, and attempt to log in. The connection will be aborted: $ telnet localhost 8023 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. login: term1 password: term1 Connection closed by foreign host. [3] Apply the patch and restart SIPSever, then repeat step 2. This time, the login should succeed: $ telnet localhost 8023 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. login: term1 password: term1 Login OK. Initiating SIP Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:09:14 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:22:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:22:24 +0000 Subject: [Koha-bugs] [Bug 14645] New: Koha::RecordProcessor should deal with Koha::MetadataRecord objects Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 Bug ID: 14645 Summary: Koha::RecordProcessor should deal with Koha::MetadataRecord objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Koha::RecordProcessor is designed to apply the right filters to records, depending on the declared schema. This means that a Dummy filter named like this: Koha::Filter::$schema::Dummy is going to be applied to records, based on the $schema param. It is a smart design, but in order to use this more broadly we need to remove the ambiguity between the metadata schema (for example: MARC21, UNIMARC, DublinCore, DarwinCore, MODS, etc) and the serialization format (for example USMARC/ISO, XML, JSON, etc). This will let us make better decisions on how to apply filters to records, and also provide us with enhanced flexibility on writing filters, because MARC is not enough information, you know? :-D With that in mind, I proposed extending the Koha::MetadataRecord object (I even included the record id, which could be retrieved from the search engine so less useless processing) on bug 14639, and now propose we make Koha::RecordProcessor work on Koha::MetadataRecord objects instead of just MARC::Record objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:23:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:23:03 +0000 Subject: [Koha-bugs] [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Depends on| |14639 Assignee|gmcharlt at gmail.com |tomascohen at gmail.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 [Bug 14639] Extend Koha::MetadataRecord to handle serialization format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:23:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:23:03 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14645 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:23:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:23:56 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:35:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:35:40 +0000 Subject: [Koha-bugs] [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking cosponsors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:35:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:35:34 +0000 Subject: [Koha-bugs] [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:37:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:37:50 +0000 Subject: [Koha-bugs] [Bug 14382] datepicker's dateFormat setting for reports is missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14382 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:41:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:41:55 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:44:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:44:00 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41357|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 41360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41360&action=edit Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle serialization format and record id In order to use Koha::MetadataRecord as a container for moving records around it is important to let it carry the serialization format of the record object it was built with, so it is easier and cheaper to make decisions about records. This patch introduces regression tests for the changes to be made. The 'format' param is introduced, and also sets default values: schema => 'marc21' format => 'MARC' A new (optional) 'id' param is added so the record carries its own id outside of it. The default behaviour is preserved, and no changes are needed in places Koha::MetadataRecord is used. ->new also returns undef if no record is passed, and raises a carped warning. To test: - Apply the patch - Run the new tests $ prove t/Koha_MetadataRecord.t => FAIL: Tests shoud fail as the changes are not implemented on Koha::MetadataRecord Edit: made serialization format be upper-case to match what is used on Koha::Filter's -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:44:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:44:06 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41358|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 41361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41361&action=edit Bug 14639: Extend Koha::MetadataRecord to handle serialization format and record id The description of this changes is on the regression tests commit message. To test: - Run $ prove t/Koha_MetadataRecord.t => FAIL: Tests fail because changes are not implemented - Apply this patch - Run $ prove t/Koha_MetadataRecord.t => SUCCESS: tests pass - Run $ prove t/Koha_Util_MARC.t => SUCCESS: it still passes - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:49:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:49:08 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 18:57:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 16:57:48 +0000 Subject: [Koha-bugs] [Bug 14601] Cardnumber should not be required for patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601 --- Comment #5 from Danielle Elder --- Can the cardnumber just be optional with the overwrite option? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 21:23:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 19:23:39 +0000 Subject: [Koha-bugs] [Bug 14611] SMS::Send hangs on malformed mobile #, process_message_queue fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14611 --- Comment #4 from Fred P --- Kyle - I think the patch you approved for Bug 3186 might cover our situation. I thought I had it installed already, but the timing was such that we did not get it yet. The following patch should resolve the process_message_queue failure, in which case this is a duplicate bug: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31291 Although using the Google-supplied library to test phone numbers would help catch data-entry errors. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 21:29:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 19:29:37 +0000 Subject: [Koha-bugs] [Bug 14646] New: Koha::RecordProcessor only accepts one filter at a time Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 Bug ID: 14646 Summary: Koha::RecordProcessor only accepts one filter at a time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Koha::RecordProcessor is designed and documented to accept more than one Koha::Filter as parameter. The current code only support one filter to be passed. Regression test coming- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 21:29:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 19:29:49 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com CC| |jcamins at cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 21:30:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 19:30:00 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14645 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 21:30:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 19:30:00 +0000 Subject: [Koha-bugs] [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14646 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 [Bug 14646] Koha::RecordProcessor only accepts one filter at a time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 21:30:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 19:30:07 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 23:13:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 21:13:30 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 23:16:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 21:16:18 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 23:21:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 21:21:54 +0000 Subject: [Koha-bugs] [Bug 14569] Typo for borrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14569 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 4 23:28:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 21:28:53 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com Status|Needs Signoff |Failed QA --- Comment #20 from Francois Charbonnier --- Sorry, It doesn't work for me. Did I miss something? * I applied the 3 patches on an up-to-date master and then run updatedatabase.pl * I set up "MarcFieldDocURL" with the value : www.marc21.ca/MaJ/BIB/B{FIELD}.pdf * I went to the cataloguing module and add a new biblio,click on the ? shortcut for the 245. A new blank tab opened and that's it. I should have had this page opened : http://www.marc21.ca/MaJ/BIB/B245.pdf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 00:45:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 22:45:36 +0000 Subject: [Koha-bugs] [Bug 14638] Update serials help files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|serials help wrong |Update serials help files CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 00:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 22:47:16 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I'd add suspending/unsuspending to the list :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 00:49:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Aug 2015 22:49:37 +0000 Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Wondering... could this be bug 9936? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 05:02:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 03:02:36 +0000 Subject: [Koha-bugs] [Bug 14545] Typo in help file for 3.20 (stage-marc-import.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14545 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 05:06:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 03:06:08 +0000 Subject: [Koha-bugs] [Bug 14456] EmbedSeeFromHeadings record filter shouldn't process MARC holding fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14456 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 06:13:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 04:13:33 +0000 Subject: [Koha-bugs] [Bug 14647] New: Make the file name extension dynamic on exporting records Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647 Bug ID: 14647 Summary: Make the file name extension dynamic on exporting records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Tools --> Export Data (or /cgi-bin/koha/tools/export.pl) Under the Output format sections (on both the bibliographic and authority records tabs) there is a drop-down menu to select the file format of the exported file. The default file format is marc and default file name is 'koha.mrc', but I think it would be a good idea to make the extension dynamic so that when the user selects a different file format (xml or csv) the file name changes respectively (ie to 'koha.xml' or 'koha.csv'). Makes the system more efficient for users and teaches them about correct filenames and extensions without having to actually teach them anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 07:21:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 05:21:20 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #15 from David Cook --- (In reply to Pedro Ferreira from comment #14) > can anyone guide me to sort this problem ..? > thanks That's a fair question. It looks like your etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl file needs the following block added within the element. So that it looks like: After patching the file, you can re-index Zebra, and then it should work. It would probably be prudent for a developer to add it to the Koha codebase as well. I don't use UNIMARC, so it's not really a problem for my libraries and I, but I'm sure that this problem would raise its head with others. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 07:22:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 05:22:47 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #16 from David Cook --- Typically, it's not a good idea to patch individual files, and instead wait for bug fix updates, but since this is a configuration file stored in /etc... I don't think bug fix updates will touch it. I think if it were fixed in master, it would only be fixed for new installs... perhaps someone else can correct me... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 08:41:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 06:41:49 +0000 Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13669 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 08:41:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 06:41:49 +0000 Subject: [Koha-bugs] [Bug 13669] Webinstaller fails on MySQL 5.6 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14637 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 08:47:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 06:47:02 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #8 from Jonathan Druart --- What is this second patch, there is no signoff on it? I don't think generating html in the module is a good idea. But it's certainly the quickest fix and will avoid to copy/paste code in the different templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 08:59:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 06:59:25 +0000 Subject: [Koha-bugs] [Bug 13275] (OMNIBUS) Tests on t/ should pass without a DB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13275 --- Comment #2 from Jonathan Druart --- I think this is solved, could you confirm Tomas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 09:22:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 07:22:06 +0000 Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 09:35:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 07:35:55 +0000 Subject: [Koha-bugs] [Bug 14638] Update serials help files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 09:35:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 07:35:59 +0000 Subject: [Koha-bugs] [Bug 14638] Update serials help files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41324|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 41362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41362&action=edit Bug 14638: Update Serials Help The serials help file was out of date for 3.18+ To test: * apply patch * Go to serials > new subscription * Click help * Confirm help correct Signed-off-by: Aleisha Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 09:38:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 07:38:21 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- It passes for me (using a dev install from git). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 09:47:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 07:47:55 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #37 from Jonathan Druart --- (In reply to Katrin Fischer from comment #36) > Hi Kyle, > > could you do me a favour and try the test case I described? I feel if we > push this without checking the basic functionality of the tool is correct, > we will just end up with unhappy feedback on a good new feature. > > > Example: Argh? I created a patron list with 6 patrons, I checked out a book > > to one of the patrons. The test run on the patron delete tells me the that 6 > > patrons would have been deleted. Katrin, I have tried and it works: Create patrons A and B Check an item out to B Add A and B to a patron list Use the tool to delete patrons from this list Test tun tells me 1 patron will be deleted Permanently delete the patrons delete only 1 patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 09:49:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 07:49:23 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36313|0 |1 is obsolete| | Attachment #36315|0 |1 is obsolete| | Attachment #41289|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart --- Created attachment 41363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41363&action=edit Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table Signed-off-by: Nicole Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 09:49:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 07:49:30 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #39 from Jonathan Druart --- Created attachment 41364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41364&action=edit Bug 10612 [Code cleanup] - Rename some variables To move towards a more consistent codebase, I have changed some variables from being camelCased or onelongname to the more standard convention of words_separated_with_underscores. In addition, this changes the use of the word 'member' to the word 'patron' to move towards unification of our terminology. Our internal terminology should move towards matching our external terminology ( members, borrowers => patrons, reserves => holds, etc ). Signed-off-by: Nicole Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 09:49:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 07:49:37 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #40 from Jonathan Druart --- Created attachment 41365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41365&action=edit Bug 10612 [QA Followup] - Remove user icons from buttons Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 09:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 07:53:16 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Kyle, please provide tests for this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:10:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:10:17 +0000 Subject: [Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:10:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:10:22 +0000 Subject: [Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41245|0 |1 is obsolete| | Attachment #41246|0 |1 is obsolete| | Attachment #41247|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 41366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41366&action=edit Bug 12372: koha-mysql: process any mysql args Signed-off-by: Ian Bays Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:10:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:10:28 +0000 Subject: [Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 --- Comment #22 from Jonathan Druart --- Created attachment 41367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41367&action=edit Bug 12372: (QA followup) Standardized argument parsing for koha-mysql. http://bugs.koha-community.org/show_bug.cgi?id=12372 Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:10:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:10:34 +0000 Subject: [Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 --- Comment #23 from Jonathan Druart --- Created attachment 41368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41368&action=edit Updated man pages for koha-mysql http://bugs.koha-community.org/show_bug.cgi?id=12372 Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:18:26 +0000 Subject: [Koha-bugs] [Bug 14557] Add holds count to holds tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart --- I am not a fan of using template plugins for this kind of usage, but I don't see another good and easy way to do this job. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:19:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:19:39 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #41 from Katrin Fischer --- Hi Jonathan, thx for testing! - I will rerun my test and see if I did something differently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:19:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:19:55 +0000 Subject: [Koha-bugs] [Bug 14557] Add holds count to holds tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41239|0 |1 is obsolete| | Attachment #41240|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 41369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41369&action=edit Bug 14557 - Clean up biblio-view-menu.inc Signed-off-by: Jason Robb Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:19:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:19:59 +0000 Subject: [Koha-bugs] [Bug 14557] Add holds count to holds tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14557 --- Comment #9 from Jonathan Druart --- Created attachment 41370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41370&action=edit Bug 14557 - Add holds count to holds tab Some librarians have expressed that it would be helpful if the holds tab displayed the count of holds for a record. Test Plan: 1) Apply this patch 2) Note the Holds tab for a record now displays the number of holds for that record Signed-off-by: Jason Robb Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:28:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:28:21 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |kyle at bywatersolutions.com |ommunity.org | --- Comment #12 from Jonathan Druart --- Yes it is! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:29:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:29:02 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- I would like to get another signoff on this one please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:33:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:33:03 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |remi.mayrand-provencher at inL |ity.org |ibro.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:44:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:44:51 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:44:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:44:55 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41230|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 41371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41371&action=edit Bug 12748: QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:45:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:45:47 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart --- R?mi, Could you please provide some tests for the changes you have done to ModSerialStatus? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:55:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:55:12 +0000 Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual fine is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- I would say that the expected behavior was to display the description (what you did) and the title of the biblio, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 10:55:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 08:55:45 +0000 Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual fine is wrong In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 --- Comment #7 from Jonathan Druart --- And what about existing rows in the DB? Do you think it's possible to update them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:00:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:00:57 +0000 Subject: [Koha-bugs] [Bug 14586] Update 3.18 Koha team with new release maintainers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:01:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:01:00 +0000 Subject: [Koha-bugs] [Bug 14586] Update 3.18 Koha team with new release maintainers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14586 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41116|0 |1 is obsolete| | Attachment #41211|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 41372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41372&action=edit Bug 14586 - Update about page with new 3.18 release team To test: Look at more -> about koha in the staff client, Koha team tab. It should list the correct names for the release maintainers. Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:05:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:05:32 +0000 Subject: [Koha-bugs] [Bug 14601] Cardnumber should not be required for patron import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |stephane.delaune at biblibre.c | |om --- Comment #6 from Jonathan Druart --- CCing St?phane, I would like to get your opinion on this point. Do you have the same problem when you migrate/import patrons to Koha? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:09:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:09:37 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #17 from Katrin Fischer --- (In reply to David Cook from comment #16) > Typically, it's not a good idea to patch individual files, and instead wait > for bug fix updates, but since this is a configuration file stored in > /etc... I don't think bug fix updates will touch it. > > I think if it were fixed in master, it would only be fixed for new > installs... perhaps someone else can correct me... I don't think that's quite correct and depending on how you installed it different things might happen. For an older standard installation, rerunning the Makefile.pl during the update process will update your index definitions as well: perl Makefile.PL --prev-install-log make make test sudo make upgrade I am adding Robin because I think he can tell what happens for a package installation. To my knowledge the index definitions are updated there as well - we build our own packages with some additional indexes and that seems to work perfectly fine. But I think local changes might create problems and even keep the files from updating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:12:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:12:55 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41359|0 |1 is obsolete| | --- Comment #2 from Colin Campbell --- Created attachment 41373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41373&action=edit Signed Off patch Signed off - works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:28:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:28:15 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9351 --- Comment #9 from Jonathan Druart --- Is it a duplicate of bug 9351? I would say we need to update existing rows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:28:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:28:15 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14598 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:38:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:38:20 +0000 Subject: [Koha-bugs] [Bug 13895] Add API routes for issues retrieval and renewal In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |BLOCKED --- Comment #6 from Jonathan Druart --- Blocked by bug 13799. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:49:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:49:25 +0000 Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Any chances to get some tests to highlight this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:50:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:50:38 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 11:52:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 09:52:12 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:09:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:09:28 +0000 Subject: [Koha-bugs] [Bug 14534] Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:09:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:09:32 +0000 Subject: [Koha-bugs] [Bug 14534] Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41094|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 41374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41374&action=edit Bug 14534: Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber Signed-off-by: Chris Cormack To test: 1/ Run the overdue_notices.pl script (don't do this on production obviously :)) 2/ Notice the warns 3/ Apply patch 4/ Run again 5/ Notice no warns, but notices are still generated ok Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:24:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:24:04 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Kyle, The tax rate is displayed at several places, at least acqui/supplier.tt. The change should affect all the places where it is displayed. You should also have a look at how I display them on bug 13323 using a template plugin: [% order.gstrate * 100 | $Price %] I can provide a patch on top of bug 13323 if you can wait for it to be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:24:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:24:43 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10253 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:24:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:24:43 +0000 Subject: [Koha-bugs] [Bug 10253] tax rate only takes 1 decimal point In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14541 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:36:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:36:16 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #10) > (In reply to Jonathan Druart from comment #9) > > (In reply to Chris Nighswonger from comment #6) > > > That all sounds good. I wish I had time to sign off! > > > > Chris, > > I am not confident with part of code, it would be great to get your signoff > > on this one :) > > Hi Jonathan, > while waiting to Chris, which part of the code is giving you trouble? > I can review it if you want Hum, all C4::Creators? :) It works as expected but I cannot be sure the patch won't introduce regressions. Looking at it again and all looks good. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:37:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:37:00 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40741|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 41375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41375&action=edit Bug 14468: Remove warnings when creating Labels This patch removes 2 types of warnings when creating Labels a) Using '0' as filling char is not to the like of prStrWidth On C4/Creators/Layout.pm b) A RM followup from Galen on Bug 8375 to C4/Creators/PDF.pm makes impossible to find properly a font :( (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=f7ef93e758850e991091e7268b8d1b1453082df4) on C4/Labels/Label.pm To test: Pre patch 1) Go to Tools > Labels 2) Create a new layout, name ABC, type 'Barcode/Biblio' 3) Create a new batch, add 2 items 4) Export as PDF using the new layout 5) Look at logs, you will find something like a) label-create-pdf.pl: Use of uninitialized value $strwidth in numeric lt (<) at /home/bgkriegel/kohaclone/C4/Creators/Layout.pm line 233., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl (Only one of this kind) b) Two related lines similar to this examples label-create-pdf.pl: Use of uninitialized value in -e at /home/bgkriegel/kohaclone/C4/Creators/PDF.pm line 226., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl label-create-pdf.pl: ERROR in koha-conf.xml -- missing /path/to/font.ttf at /home/bgkriegel/kohaclone/C4/Creators/PDF.pm line 229., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl (many many lines x number of items on batch) 6) Apply the patch 7) Export the same PDF, no more warnings 8) Bonus 1: change main font to Courier and Helvetica and check results 9) Bonus 2: check using arabic records Many hours to find :( Easy to fix Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:42:03 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40321|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 41376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41376&action=edit Bug 11194: Add a new index for "Edition Statement" of a MARC Record Adds the "Edition Statement" MARC-field as a sortable search index in Koha. This Field is also used by the MARC::Record->edition(). It is mapped to search keyword "edition" and it targets the following MARC-fields: UNIMARC: all 205-subfields concatenated MARC21 : all 250-subfields concatenated NORMARC: all 250-subfields concatenated After applying this patch a full biblio reindexing needs to be done to make old records searchable. New Biblios, and Biblios that are part of some operations (checkin/out/hold/...), are searchable. These generate good test data to test this feature without fully reindexing the search index. TEST PLAN: 0. Move the search index and search word definitions from the koha source code to the directory where Zebra uses them. This is most easiest to do by reinstalling Koha, but can be manually moved as well. 1. Find a record with some data in the "Edition Statement" -field. 2. Modify that Record and reindex it. 3. Search with the keyword "edition=''" where is the stuff you wrote in the MARC-field. 4. Observe the found record. Signed-off-by: Bernardo Gonzalez Kriegel Tested on MARC21 and UNIMARC, works No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:44:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:44:50 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart --- Kyle, I am afraid that there is a lack of tests for the 2 new methods added to Koha::Hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:41:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:41:58 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 12:57:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 10:57:33 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > What is this second patch, there is no signoff on it? Hm. I rebased the patch but forgot to take the one with the signoff.. I will resubmit. > I don't think generating html in the module is a good idea. But it's > certainly the quickest fix and will avoid to copy/paste code in the > different templates. I will still have a look for a simple follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 13:20:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 11:20:05 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart --- I have the same feeling as David, it sounds a bit hacky. I understand your problem, but you have to provide something useful for others, not a specific stuffs for you. I would like to see some docs on the help page to explain what it is possible to do with this new fields. As David said, I don't think it's a good idea to add this field at the server level, we could have the need to use 4=109 and 4=1 in the same query. A dropdown list in front of each field sounds more useful and flexible. I don't mark it as failed, I would like to get another QAer's opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 13:52:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 11:52:35 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Passed QA --- Comment #19 from Jonathan Druart --- I think it would have been better to use network list (192.168.1.255) instead of the start of the ips to allow. Note that superlibrarian can access to the page, even if the user is not connected from the ips allowed, is it expected? I will submit a follow-up to access pref from the templates, squash the patches (not to add and remove files in the same patch set). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 13:54:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 11:54:19 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40820|0 |1 is obsolete| | Attachment #40821|0 |1 is obsolete| | Attachment #40822|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 41377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41377&action=edit Bug 13485 - Add a proxy page To test: I) Apply the patch II) Run updatedatabase.pl scenario I) 1) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 2) Add your machine ip (ex. 127.0.0) 3) Validate cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents. scenario II) 1) Logout opac page 2) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 3) Add other ip that your machine ip. 4) Validate: cgi-bin/koha/opac-proxypage.pl shows a login page. 5) Validate: cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents after login. Followed both scenarios, works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Bug 13485 [QA Followup] Signed-off-by: Kyle M Hall Bug 13485 - Atomic Update + Rename Proxy page to Restricted page Test plan: I) Apply the patch II) Run updatedatabase.pl scenario I) 1) Add some content in RestrictedPageContent and RestrictedPageTitle sysprefs. 2) Add your machine ip (ex. 127.0.0) 3) Validate cgi-bin/koha/opac-restrictedpage.pl shows a page with RestrictedPageContent and RestrictedPageTitle contents. scenario II) 1) Logout opac page 2) Add some content in RestrictedPageContent and RestrictedPageTitle sysprefs. 3) Add a diffrent ip. 4) Validate: cgi-bin/koha/opac-restrictedpage.pl shows a login page. 5) Validate: cgi-bin/koha/opac-restrictedpage.pl shows a page with RestrictedPageContent and RestrictedPageTitle contents after login. new file: installer/data/mysql/atomicupdate/Bug13485_RestrictedSitesPage.sql modified: installer/data/mysql/sysprefs.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref renamed: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-proxypage.tt -> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-restrictedpage.tt renamed: opac/opac-proxypage.pl -> opac/opac-restrictedpage.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 13:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 11:54:26 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #21 from Jonathan Druart --- Created attachment 41378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41378&action=edit Bug 13485: Use the Koha template plugin to access syspref values And remove the useless use of the KohaDates plugin Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 14:12:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 12:12:25 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |paul.poulain at biblibre.com --- Comment #48 from Jonathan Druart --- Ccing some QAers since we are waiting for feedbacks for 3 months now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 14:18:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 12:18:44 +0000 Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com Status|NEW |Needs Signoff --- Comment #4 from Colin Campbell --- Created attachment 41379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41379&action=edit Potential patch This patch changes the Auth routine to one that takes account of authentication sources other than simple pw in the database. I have only tested this in the context of a password authenticating database NB the patron information request/response pair's function is not primarily authentication and supplying a password is optional, the sip process returns a password OK for an empty password field, this is done because some clients have traditionally sent an empty field rather than skipping it completely Please test if this enables authentication using LDAP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 14:29:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 12:29:31 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 14:29:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 12:29:38 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40123|0 |1 is obsolete| | Attachment #40124|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 41380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41380&action=edit Bug 13663 - Fix permissions in upload-file.pl and upload-file-progress.pl Test plan: Verify that the circulate_remaining_permissions perm is enough to upload .koc file. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 14:29:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 12:29:49 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 --- Comment #16 from Jonathan Druart --- Created attachment 41381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41381&action=edit Bug 13663: (followup) fixes tab char QA test fails Fixes the tab char qa test suite fails in the following files: 1/ tools/upload-file-progress.pl 2/ tools/upload-file.pl Signed-off-by: Jonathan Druart Amended patch: tidy whitespaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 15:05:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 13:05:07 +0000 Subject: [Koha-bugs] [Bug 14648] New: Batch Remove Reserve Items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Bug ID: 14648 Summary: Batch Remove Reserve Items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: misilot at fit.edu QA Contact: testopia at bugs.koha-community.org Hi, It would be great to see the ability to mass remove course reserves. For example, if given a list of Barcodes have the option to remove the items from any course they are tied to. This would be useful at the end of an academic semester, when books are returned to their original shelving location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 15:10:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 13:10:45 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #57 from Tom?s Cohen Arazi --- I tried this patchset along with the regression tests I wrote on bug 14598 (because I missed this bug on my first search). The regression tests pass with this patchset. But I'm not happy with this patchset, as it seems to touch CanBookBeIssued which is out of the scope of this bug, without regression tests for it (too). Also, I'm not sure about the DB update, as it seems to update all returns item types, and it should only touch those with NULL values. So, I propose we stick with bug 14598 (which is missing the DB update step) and mark this one as duplicate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 15:36:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 13:36:02 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 15:42:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 13:42:48 +0000 Subject: [Koha-bugs] [Bug 9936] SIP2 should use C4/Auth.pm for user authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 --- Comment #2 from Colin Campbell --- Patch for 9611 switches to callingC4::Auth for password validation but still bypasses ldap & CAS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 15:55:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 13:55:55 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #81 from Jonathan Druart --- QA comments: 1/ There are no tests for new modules 2/ I really would like to see Koha::Template::Plugin::Koha::AudioAlerts moved somewhere else 3/ SyntaxError: missing ) after condition ndexOf('http://') == 0 || sound.indexOf('https://') == 0 ) { Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 16:26:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 14:26:48 +0000 Subject: [Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 16:26:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 14:26:52 +0000 Subject: [Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39897|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 41382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41382&action=edit Bug 14031 - Itemnumber should be a numeric search in ccl.properties This patch changes the "itemnumber" alias so that it acts like "itemnumber,st-numeric". That is, it always does a numeric search. _TEST PLAN_ The best way to test this patch is to apply the patch and then run "make upgrade", I suspect. As this will refresh your "ccl.properties". However, this patch is actually really small, so you can just apply it manually to an existing "ccl.properties" if you rather save time. Basically, you just need to do the following steps: 0) Do a search for "itemnumber:" 1) Note that you can't retrieve any results 2) Change your ccl.properties to say "itemnumber 1=8010 4=109" 3) Repeat the search for "itemnumber:" 4) Note that you now retrieve your result Signed-off-by: Magnus Enger Tested on a gitified package install. Made the change to /etc/koha/zebradb/ccl.properties manually. After this change I can successfully search for "itemnumber:1". Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 16:38:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 14:38:34 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #82 from Jonathan Druart --- Comment on attachment 41066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41066 Bug 10276 - Extend IndependentBranches to support groups of libraries Review of attachment 41066: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=41066) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ +1912,5 @@ > +C<@results> is sorted alphabetically by book title. > + > +=cut > + > +sub GetParcel { Has been removed by Bug 13318 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 17:06:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 15:06:27 +0000 Subject: [Koha-bugs] [Bug 14649] New: fund names not displayed in budget planning Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Bug ID: 14649 Summary: fund names not displayed in budget planning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In a budget planning, cgi-bin/koha/admin/aqplan.pl, the fund names are not displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 17:07:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 15:07:49 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11714 --- Comment #1 from Fridolin SOMERS --- This is a side effect of Bug 11714 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 [Bug 11714] GetBudgetHierarchy needs optimization -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 17:07:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 15:07:49 +0000 Subject: [Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14649 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 [Bug 14649] fund names not displayed in budget planning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 17:35:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 15:35:35 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 17:48:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 15:48:41 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #18 from Fridolin SOMERS --- In UNIMARC, Date-of-acquisition is usually defined in 099$c, this is the default Zebra configuration. One must use the script misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl to copy creation date from database to 099$c. We usually set it nightly to only update daily modified/created records : misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl --run --where "TO_DAYS(NOW()) - TO_DAYS(biblio.datecreated) <= 1 OR TO_DAYS(NOW()) - TO_DAYS(DATE(biblio.timestamp)) <= 1" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 17:59:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 15:59:24 +0000 Subject: [Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 17:59:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 15:59:30 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 18:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 16:04:35 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #19 from Katrin Fischer --- Hi Fridolin, I think the dateaccessioned in MARC21 is a item field related to acquisitions - does UNIMARC have no dateaccessioned or similar in 995? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 18:07:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 16:07:37 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #58 from Fridolin SOMERS --- (In reply to Tom?s Cohen Arazi from comment #57) > But I'm not happy with this patchset, as it seems to touch CanBookBeIssued This code has the same problem as AddReturn since it calls UpdateStats with $item->{'itemtype'} instead of $item->{'itype'}. Only it works because there is a dirty hack $item->{'itemtype'}=$item->{'itype'};. One day maybe this hack will be removed. Once there is a full abstraction layer with datas surely. > So, I propose we stick with bug 14598 (which is missing the DB update step) > and mark this one as duplicate. +1 Since AddReturn part is much more important. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 18:21:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 16:21:32 +0000 Subject: [Koha-bugs] [Bug 14650] New: Public/Staff notes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14650 Bug ID: 14650 Summary: Public/Staff notes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jesse at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Public/Staff notes should show up on the Batch item modification page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 18:22:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 16:22:43 +0000 Subject: [Koha-bugs] [Bug 14650] Public/Staff notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14650 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:13:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:13:58 +0000 Subject: [Koha-bugs] [Bug 13886] Add ability to merge records directly from cataloging search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:14:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:14:19 +0000 Subject: [Koha-bugs] [Bug 13885] Cataloging search header should include more options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:23:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:23:06 +0000 Subject: [Koha-bugs] [Bug 14651] New: Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Bug ID: 14651 Summary: Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org I fill this bug to start a conversation about this issue. It seems the codebase has several ways of determining the itemtype. For example, C4::Circulation::AddReturn used the biblio-level itemtype (until bug 14598) and C4::Circulation::CanBookBeIssued just sticks to item-level itemtype. At first sight, it seems clear to me that we should start moving into using Koha::Item objects, that even provide an ->effective_itemtype method! Having talked about this on IRC there seems to be a consensus that if the item doesn't have an itemtype, then there should be a fallback to biblio-level itemtype. This means we should add that check to the ->effective_itemtype method. But it would mean including Koha::Biblios. Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:28:48 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41203|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 41383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41383&action=edit Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:28:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:28:56 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41204|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 41384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41384&action=edit Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set > SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set > SELECT * FROM statistics WHERE type="return"; => FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t => SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps => SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:29:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:29:03 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41205|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 41385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41385&action=edit Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:29:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:29:22 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:29:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:29:34 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #59 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 14598 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:29:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:29:34 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #13 from Tom?s Cohen Arazi --- *** Bug 9351 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:30:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:30:44 +0000 Subject: [Koha-bugs] [Bug 14531] Check-in statistical report broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14531 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 14598 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:30:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:30:44 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #14 from Tom?s Cohen Arazi --- *** Bug 14531 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 20:38:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 18:38:57 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 21:06:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 19:06:34 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41360|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 41386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41386&action=edit Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle serialization format and record id In order to use Koha::MetadataRecord as a container for moving records around it is important to let it carry the serialization format of the record object it was built with, so it is easier and cheaper to make decisions about records. This patch introduces regression tests for the changes to be made. The 'format' param is introduced, and also sets default values: schema => 'marc21' format => 'MARC' A new (optional) 'id' param is added so the record carries its own id outside of it. The default behaviour is preserved, and no changes are needed in places Koha::MetadataRecord is used. ->new also returns undef if no record is passed, and raises a carped warning. To test: - Apply this test patch - Run the new tests $ prove t/Koha_MetadataRecord.t => FAIL: Tests shoud fail as the changes are not implemented on Koha::MetadataRecord Edit: made serialization format be upper-case to match what is used on Koha::Filter's Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 21:06:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 19:06:38 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41361|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 41387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41387&action=edit Bug 14639: Extend Koha::MetadataRecord to handle serialization format and record id The description of this changes is on the regression tests commit message. To test: - Apply the test patch - Run $ prove t/Koha_MetadataRecord.t => FAIL: Tests fail because changes are not implemented - Apply this patch - Run $ prove t/Koha_MetadataRecord.t => SUCCESS: tests pass - Run $ prove t/Koha_Util_MARC.t => SUCCESS: it still passes - Sign off :-D NOTE: Tested as above. Read code. Seems to cover all cases. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 21:07:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 19:07:00 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 21:17:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 19:17:23 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 41388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41388&action=edit Bug 14646: (regression test) Koha::RecordProcessor only accepts one filter at a time This patch introduces new tests to t/RecordProcessor.t so it tests for creating processors with more than one filter. It does so by running my $processor = new Koha::RecordProcessor({ filters => ['Null','Dummy'] }); and testing the results. To test: - Apply the patch - Run: $ prove t/RecordProcessor.t => FAIL: tests related to multiple filters fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 21:17:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 19:17:29 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 41389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41389&action=edit Bug 14646: Koha::RecordProcessor should accept more than one filter The docs say that Koha::RecordProcessor accepts more than one filter at a time. But as the regression tests show it doesn't. This is really important to extend its usage in record processing (either to enforce policy, transform, etc). This patch makes ->new evaluate the reference type of the passed filters and builds an array with a single item if a scalar has been passed. The loop now explicitly casts the filters as an array. To test: - Run $ prove t/RecordProcessor.t => FAIL: tests fail because Koha::RecordProcessor doesn't hanlde more than one filter at a time. - Apply the patch - Run $ prove t/RecordProcessor.t => SUCCESS: tests now pass - Easy, right? Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 21:17:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 19:17:39 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 21:32:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 19:32:07 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #107 from Tim Hannah --- Had a look at this, first time using kohadevbox and git bz, so could be something I did or didn't do. Looked good, no stray text, but when I tried resetting a password I got error message DBIx::Class::ResultSet::next(): Table koha_kohadev.borrower_password_recovery' doesn't exist at /home/vagrant/kohaclone/C4/Passwordrecovery.pm line 70 Any clues? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 22:04:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 20:04:08 +0000 Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 5 22:04:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 20:04:11 +0000 Subject: [Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41335|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 41390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41390&action=edit Bug 14205: Deleting an Item/Record does not remove link to course reserve A constraint is missing on the course_reserves.ci_id field. This patch adds it and removes orphan rows. Test plan: 0/ Don't apply the patch 1/ Login to Staff Site. 2/ Go to Course Reserves 3/ Create Course 4/ Add Reserve 5/ Go to item added (delete item/record) 6/ Refresh Course (see no items attached) 7/ Delete Course 8/ See course still listed in the courses (Not deleted) 9/ Apply the patch and execute the updatedatabase entry. 10/ Delete the Course Note that the course has correctly been removed. NOTE: Make sure to set the UseCourseReserves system preference to test. Tested before (problem existed) and after (problem solved) update. Dropped DB, web installed, and put in dummy data and retested. Problem solved. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 00:14:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 22:14:36 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41388|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 41391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41391&action=edit Bug 14646: (regression test) Koha::RecordProcessor only accepts one filter at a time This patch introduces new tests to t/RecordProcessor.t so it tests for creating processors with more than one filter. It does so by running my $processor = new Koha::RecordProcessor({ filters => ['Null','Dummy'] }); and testing the results. To test: - Apply the patch - Run: $ prove t/RecordProcessor.t => FAIL: tests related to multiple filters fail. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 00:14:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 22:14:44 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41389|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 41392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41392&action=edit Bug 14646: Koha::RecordProcessor should accept more than one filter The docs say that Koha::RecordProcessor accepts more than one filter at a time. But as the regression tests show it doesn't. This is really important to extend its usage in record processing (either to enforce policy, transform, etc). This patch makes ->new evaluate the reference type of the passed filters and builds an array with a single item if a scalar has been passed. The loop now explicitly casts the filters as an array. To test: - Apply the test patch - Run $ prove t/RecordProcessor.t => FAIL: tests fail because Koha::RecordProcessor doesn't hanlde more than one filter at a time. - Apply this patch - Run $ prove t/RecordProcessor.t => SUCCESS: tests now pass - Easy, right? Sign off :-D NOTE: Read code. Don't like the ? operator logic, but it is functional despite readability issues. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 00:15:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 22:15:39 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 00:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 22:21:23 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #1 from Jesse Weaver --- Created attachment 41393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41393&action=edit Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 00:57:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 22:57:01 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #20 from Robin Sheat --- (In reply to Katrin Fischer from comment #17) > I am adding Robin because I think he can tell what happens for a package > installation. To my knowledge the index definitions are updated there as > well - we build our own packages with some additional indexes and that seems > to work perfectly fine. But I think local changes might create problems and > even keep the files from updating. It should be OK. I haven't tested this, but I would expect it would warn you that it's changed and ask you if you want to keep your own version or if you want to install the packaged version. Either way, it'll keep the other version named with the extension .dpkg-{dist,orig} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 01:10:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 23:10:33 +0000 Subject: [Koha-bugs] [Bug 14652] New: Change gender option N/A to None specified Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Bug ID: 14652 Summary: Change gender option N/A to None specified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org We should do this because it is more respectful to people who do not wish to specify a gender. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 01:11:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 23:11:08 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 --- Comment #1 from Liz Rea --- Created attachment 41394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41394&action=edit Bug 14652 - change gender specification from "N/A" to "None specified" To test: Edit a patron in the intranet, note that the gender options are "Female," "Male," and "None specified" Setting "None specified" should result in the gender not being shown on the patron detail page (unchanged functionality) In the opac, log in and click the "your personal details" tab, and note that the gender options are "Female," "Male," and "None specified" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 01:15:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 23:15:07 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 01:21:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 23:21:59 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 01:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Aug 2015 23:22:02 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41394|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 41395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41395&action=edit Bug 14652 - change gender specification from "N/A" to "None specified" To test: Edit a patron in the intranet, note that the gender options are "Female," "Male," and "None specified" Setting "None specified" should result in the gender not being shown on the patron detail page (unchanged functionality) In the opac, log in and click the "your personal details" tab, and note that the gender options are "Female," "Male," and "None specified" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 08:22:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 06:22:52 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 08:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 06:22:55 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 --- Comment #2 from Jonathan Druart --- Created attachment 41396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41396&action=edit Bug 14649: Fix regression - display fund name on budget planning A patch from bug 11714 removes 'budget_name_indent', which was useless. The script and the template should use the budget_name value. Note that this patch impacts the CSV export, which does not work, so it cannot be tested. Test plan: Edit a fund and click on one of the Planning value (by months, etc.) The "Fund name" column should be correctly populated with the fund names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 09:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 07:42:32 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 09:42:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 07:42:34 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41396|0 |1 is obsolete| | --- Comment #3 from Fridolin SOMERS --- Created attachment 41397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41397&action=edit Bug 14649: Fix regression - display fund name on budget planning A patch from bug 11714 removes 'budget_name_indent', which was useless. The script and the template should use the budget_name value. Note that this patch impacts the CSV export, which does not work, so it cannot be tested. Test plan: Edit a fund and click on one of the Planning value (by months, etc.) The "Fund name" column should be correctly populated with the fund names. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 09:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 07:43:14 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41397|Bug 14649: Fix regression - |[SIGNED-OFF] Bug 14649: Fix description|display fund name on budget |regression - display fund |planning |name on budget planning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 09:44:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 07:44:32 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 --- Comment #4 from Fridolin SOMERS --- Thanks a lot Jonathan, you where faster than me for patching ;) I of course signoff. > Note that this patch impacts the CSV export, which does not work, so it cannot be tested. I have a correction I will set in another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 09:58:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 07:58:15 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 --- Comment #5 from Fridolin SOMERS --- Created attachment 41398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41398&action=edit Bug 14649: Followup - correct budget_period_id in fund name link Now that fund name is displayed in the table as a link, you see that arg budget_period_id is never defined in this link. This is because the template var is [% budget_line.budget_period_id %] instead of [% budget_period_id %]. This looks like a mistake when converting from tmpl to tt. Test plan : - Without patch - Look for a planning with funds : /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS - Click on a fund name => You see in URL that budget_id is empty : /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id= - Apply patch - Look for a planning with funds : /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS - Click on a fund name => you see in URL that budget_id is defined like in planning page : /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 09:58:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 07:58:57 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #6 from Fridolin SOMERS --- Small followup needs signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 10:16:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 08:16:11 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #21 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #19) > Hi Fridolin, I think the dateaccessioned in MARC21 is a item field related > to acquisitions - does UNIMARC have no dateaccessioned or similar in 995? I can't find anything. I've seen it sometimes in a numeric subfield. Maybe there is no convention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 10:27:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 08:27:59 +0000 Subject: [Koha-bugs] [Bug 14653] New: Acq planning filter and export always use default active period Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Bug ID: 14653 Summary: Acq planning filter and export always use default active period Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code : # IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 10:28:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 08:28:04 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 10:28:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 08:28:15 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14649 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 10:28:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 08:28:15 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14653 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:09:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:09:09 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:09:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:09:55 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 --- Comment #1 from Fridolin SOMERS --- Created attachment 41399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41399&action=edit Bug 14653 - Acq planning filter always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code : - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the filter form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - In filter form, select "by months" in "Select planning type" => Without patch, you see planning of "B_ACTIVE" with 1 fund => Without patch, you see planning of "B_OLD" with 3 funds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:10:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:10:05 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 --- Comment #2 from Fridolin SOMERS --- Created attachment 41400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41400&action=edit Bug 14653 - Acq planning export always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the export form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - Click on "Submit" in export form => Without patch, you get the planning of "B_ACTIVE" with 1 fund => Without patch, you get the planning of "B_OLD" with 3 funds by libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:10:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:10:23 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:10:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:10:40 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:19:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:19:47 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #22 from Katrin Fischer --- Pedro, have you followed the discussion? It looks like there is no date_accessioned in the item in UNIMARC - can you confirm this for your installation? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:45:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:45:27 +0000 Subject: [Koha-bugs] [Bug 14654] New: Add desk filter in Holds awaiting pickup list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 Bug ID: 14654 Summary: Add desk filter in Holds awaiting pickup list Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nicolas.legrand at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 13881 On waitingreserves.pl add a menu to filter holds by desks they are attached to. By default, put the desk the user have set. Otherwise, show all holds (current behaviour). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 [Bug 13881] Add desk management -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:45:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:45:27 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14654 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 [Bug 14654] Add desk filter in Holds awaiting pickup list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:51:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:51:17 +0000 Subject: [Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:53:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:53:05 +0000 Subject: [Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:55:35 +0000 Subject: [Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 --- Comment #1 from Nicolas Legrand --- Created attachment 41401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41401&action=edit Bug 14654 - Add desk filter in Holds awaiting pickup list On waitingreserves.pl add a menu to filter holds by desks they are attached to. By default, put the desk the user have set. Otherwise, show all holds (current behaviour). Test plan : 1/ apply bug 13881 and this one, add some desks, check in some holded books to pass them on status wainting. Do it with different desks set on your user session, 2/ go to the waitingreserves.pl page, you should see only books awaiting pickup from your desk, 3/ select all desk, you should see all books awaiting pickup at your library, 4/ select other desks, you should see holds awaiting pickup there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 11:55:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 09:55:53 +0000 Subject: [Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 12:06:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 10:06:15 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #23 from Pedro Ferreira --- Hello , yes i can confirm that there is no 999$c field doing a grep i get xekhz at mail:/var/www/koha3.20/etc/zebradb/marc_defs/unimarc/biblios$ grep 999 biblio-zebra-indexdefs.xsl but i think the filed 995 is what i need, because date-of-aquisition is field 995 in unimarc. doing a grep xekhz at mail:/var/www/koha3.20/etc/zebradb/marc_defs/unimarc/biblios$ grep 995 biblio-zebra-indexdefs.xsl xekhz at mail:/var/www/koha3.20/etc/zebradb/marc_defs/unimarc/biblios$ ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 12:25:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 10:25:54 +0000 Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41310|0 |1 is obsolete| | --- Comment #15 from Olli-Antti Kivilahti --- Created attachment 41402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41402&action=edit Bug 14540 - Move member-flags.pl to PermissionsManager to better manage permissions for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 13:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 11:26:56 +0000 Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #11 from Olli-Antti Kivilahti --- Hi there! I like your approach, you are doing the right thing. DBIx::Connector is said to be more robust and I am happy to hear it has solved your issues. However there is an issue with this patch that needs addressing if you want a sign off from me. First of all the naming convention is changed which can cause a lot of issues for everybody. Some tests, custom modifications etc. can depend on $context->{dbh}. The new name doesn't help increase clarity IMHO and we should stick to the old "dbh". - return $context->{"dbh"}; + return $context->{'DBconn'}->dbh; Same issue here -sub _new_dbh +sub _new_DBconn _new_dbh is addressed directly from many places (atleast I do) regardless of it being a private method. This is to circumvent bugs/limitations of the C4::Context->dbh()-system. No reason to change it. Because of these things a small and beautiful, yet invaluably important fix is drowned into a large commit changing too many things for reasons I do not agree of. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 13:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 11:29:48 +0000 Subject: [Koha-bugs] [Bug 14374] dont use mysql_auto_reconnect with DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #3 from Olli-Antti Kivilahti --- Shouldn't this bug be merged into Bug 14375? You cannot disable - $dbh->{mysql_auto_reconnect} = 1; Without first introducing the DBIx::Connector? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 15:16:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 13:16:03 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Uploader In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 15:50:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 13:50:20 +0000 Subject: [Koha-bugs] [Bug 14655] New: Cannot checkin without Anonymous Patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Bug ID: 14655 Summary: Cannot checkin without Anonymous Patron Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com 3.18.9 has a huge error. You cannot check in if you don't have an anonymous patron. Most of our partners don't allow opacprivacy or anonymous suggestions so they don't have an anonymous patron. You shouldn't need one if you don't do anything with anonymizing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:13:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:13:15 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9942 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I don't reproduce, please return the result of the following commands/queries mysq> select value from systempreferences where variable="OPACPrivacy" or variable="AnonymousPatron"; $ git show-branch HEAD v3.18.09 # To be sure it's a pure 3.18.09 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:13:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:13:15 +0000 Subject: [Koha-bugs] [Bug 9942] Circulation module cannot anonymise if anonymity user is not set up correctly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14655 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 [Bug 14655] Cannot checkin without Anonymous Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:32:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:32:42 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41034|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 41403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41403&action=edit Bug 14544: Add Koha::Virtualshelf and Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:32:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:32:47 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41035|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 41404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41404&action=edit Bug 14544: Get rid of GetShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:32:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:32:51 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41036|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 41405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41405&action=edit Bug 14544: Get rid of AddShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:32:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:32:55 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41037|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 41406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41406&action=edit Bug 14544: Get rid of DelShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:32:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:32:59 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41038|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 41407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41407&action=edit Bug 14544: Get rid of ModShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:33:04 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41039|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 41408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41408&action=edit Bug 14544: Move share routines to Koha::Virtualshelfshare and Koha::Virtualshelfshares -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:33:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:33:08 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41040|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 41409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41409&action=edit Bug 14544: Get rid of GetAllShelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:33:13 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41041|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 41410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41410&action=edit Bug 14544: Koha::Virtualshelfcontent[s] Get rid of AddToShelf and DelFromShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:33:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:33:18 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #22 from Jonathan Druart --- Created attachment 41411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41411&action=edit Bug 14544: Make the intranet side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:33:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:33:22 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #23 from Jonathan Druart --- Created attachment 41412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41412&action=edit Bug 14544: Get rid of GetBibliosShelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 16:34:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 14:34:00 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41042|Bug 14544: WIP - Get rid of |[DO NOT APPLY] Bug 14544: description|GetShelves |WIP - Get rid of GetShelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 17:36:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 15:36:14 +0000 Subject: [Koha-bugs] [Bug 14656] New: Delete Bibliographic Records REST API route & permission Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14656 Bug ID: 14656 Summary: Delete Bibliographic Records REST API route & permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Adds a new permission 'editcatalogue' => 'delete_catalogue' and changes the /cgi-bin/koha/catalogue/detail.pl?biblionumber=??? -view to use the REST API to delete a Biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 17:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 15:36:42 +0000 Subject: [Koha-bugs] [Bug 14656] Delete Bibliographic Records REST API route & permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14656 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13799 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 17:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 15:36:42 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14656 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14656 [Bug 14656] Delete Bibliographic Records REST API route & permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 17:37:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 15:37:18 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Merge UploadedFile and |Merge UploadedFile and |UploadedFiles into |UploadedFiles into |Koha::Uploader |Koha::Upload -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 17:40:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 15:40:27 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41311|0 |1 is obsolete| | --- Comment #21 from Olli-Antti Kivilahti --- Created attachment 41413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41413&action=edit Bug 7174 - Authentication Rewrite - Core Fixed Cookie authentication to work behind a reverse proxy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 18:45:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 16:45:45 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #2 from Nicole C. Engard --- For the record: http://irc.koha-community.org/koha/2015-08-06#i_1713701 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 18:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 16:52:55 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #3 from Nicole C. Engard --- Jonathan, We are using package sites - that might be why you can't reproduce. Sorry I left out that info. Nicole -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 19:05:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 17:05:24 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 20:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 18:10:16 +0000 Subject: [Koha-bugs] [Bug 14657] New: Is Hidden By Default for Price hides Fine Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 Bug ID: 14657 Summary: Is Hidden By Default for Price hides Fine Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jyorio at esilibrary.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 41414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41414&action=edit Columns prior to applying the setting Going to Administration | Additional Parameters | Configure columns | Circulation and checking Is Hidden By Default for Price hides the Fine column in the checkout display, not Price. Clicking on Show/hide columns for the checkout display does not show Price as an option, and Fine is unchecked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 20:10:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 18:10:45 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 --- Comment #1 from John Yorio --- Created attachment 41415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41415&action=edit Change columnns Circulation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 20:11:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 18:11:08 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 --- Comment #2 from John Yorio --- Created attachment 41416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41416&action=edit Checkout display after change applied -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 20:12:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 18:12:22 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 --- Comment #3 from John Yorio --- Created attachment 41417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41417&action=edit Checkout display before change applied -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 20:14:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 18:14:04 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 John Yorio changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41414|Columns prior to applying |Uploaded incorrect file. description|the setting | Attachment #41414|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 20:48:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 18:48:50 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 20:48:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 18:48:52 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40977|0 |1 is obsolete| | --- Comment #3 from Jesse Weaver --- Created attachment 41418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41418&action=edit Bug 14510: Allow column visibility in additem.pl to be customized This patch adds the table of items on additem.pl to the columns customizer. Test plan: 1. Open item editor on a record, and verify that all columns are visible. 2. Apply patch. 3. Reload editor, and verify that column visibility hasn't changed. 4. Open "Hide/show columns," and verify that you can add and remove columns. 5. Change the visibility and togglability of some columns in columns_settings.pl, and verify that these correctly apply to additem.pl. NOTE: The columns that are configurable are selected from the non-hidden columns that have mappings to MARC subfields in the default MARC21 framework (and can thus be displayed in the item editor). Signed-off-by: Jenny Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 20:49:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 18:49:05 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 --- Comment #4 from Jesse Weaver --- Created attachment 41419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41419&action=edit Bug 14510: (QA followup) remove extraneous whitespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 21:01:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 19:01:50 +0000 Subject: [Koha-bugs] [Bug 14658] New: Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Bug ID: 14658 Summary: Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 21:05:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 19:05:28 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14659 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 21:05:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 19:05:28 +0000 Subject: [Koha-bugs] [Bug 14659] New: Allow patrons to enter card number and patron category on OPAC registration page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Bug ID: 14659 Summary: Allow patrons to enter card number and patron category on OPAC registration page Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Depends on: 14658 Both will be hidden by default, via PatronSelfModificationBorrowerUnwantedField (see bug 14658). Also, they will be read only for existing patrons (as cardnumber is currently). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 22:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 20:34:07 +0000 Subject: [Koha-bugs] [Bug 14349] Checkouts and Fines tabs missing category description on the left In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14349 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 22:35:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 20:35:34 +0000 Subject: [Koha-bugs] [Bug 14657] Is Hidden By Default for Price hides Fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14657 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 6 22:54:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 20:54:56 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #113 from Jesse Weaver --- (In reply to Iming Chan from comment #112) > Just checked out the sandbox of this development, I'm really excited and > looking forward for it to go live. Great job for all involved. > > However, I would like to make a couple improvement suggestions: > > 1. Existing interface to Leader, Tag 007 and 008 is better than what's been > proposed. You can see all character position elements in one screen with > corresponding headings. Whereas the proposed design, you really have to > know your fixed-length data elements well! It will, unfortunately, be difficult to impossible to integrate the existing UI, but would a good future enhancement be an expanded version of the current fixed-field widgets? I agree, the current UI is intended mostly for those who have the fixed-field formats deep in their bones. > > 2. Some tags don't use one or both indicators. It will be nice to prevent > data entry to one or both indicators when they are not used to a given tag. > Perhaps after you have enter a tag number (say 020 for ISBN), press [Tab] > will take the cursor straight to next position that require data entry (in > the case of the example above, it will be at "$a" and skipped both Indicator > 1 & 2). This could be a lot trickier, as the MARC frameworks in Koha do not contain any information about indicator values/use; we'd have to extend them to include that before adding this functionality to Rancor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 00:16:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 22:16:40 +0000 Subject: [Koha-bugs] [Bug 14660] New: Cataloguing plugin stocknumberAV.pl broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Bug ID: 14660 Summary: Cataloguing plugin stocknumberAV.pl broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The cataloguing plugin stocknumberAV is no longer working on master. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 00:22:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 22:22:12 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugin stocknumberAV.pl broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 00:22:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 22:22:15 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugin stocknumberAV.pl broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #1 from Katrin Fischer --- Created attachment 41420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41420&action=edit Bug 14660: Fix stocknumberAV.pl catalguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 00:22:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 22:22:35 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugin stocknumberAV.pl broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 00:36:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 22:36:55 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugin stocknumberAV.pl broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #2 from Katrin Fischer --- Created attachment 41421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41421&action=edit Bug 14660: Fix stocknumberam123.pl catalguing plugin The cataloguing plugin stocknumberam123.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Create a new item, set the inventory number to: A 0000000002 - Start to catalog another item, enter A into inventory and - Enter A as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 00:37:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 22:37:39 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cataloguing plugin |Cataloguing plugins for |stocknumberAV.pl broken |generating inventory | |numbers are broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 00:38:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 22:38:45 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41420|0 |1 is obsolete| | Attachment #41421|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 41422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41422&action=edit Bug 14660: Fix stocknumberAV.pl cataloguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 00:39:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 22:39:20 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #4 from Katrin Fischer --- Created attachment 41423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41423&action=edit Bug 14660: Fix stocknumberam123.pl cataloguing plugin The cataloguing plugin stocknumberam123.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Create a new item, set the inventory number to: A 0000000002 - Start to catalog another item, enter A into inventory and - Enter A as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 01:15:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 23:15:14 +0000 Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 --- Comment #2 from Jesse Weaver --- Ah, on closer inspection, this is fixed by commit 481479fe627dcbabb3ef66df0724cc3fe75b110c: "Bug 12648: Fix conflict with bug 12833", which just needs to be backported to 3.18. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 01:29:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Aug 2015 23:29:52 +0000 Subject: [Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Yarik Dot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yarikdot at gmail.com --- Comment #1 from Yarik Dot --- Created attachment 41424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41424&action=edit Patch - remove CREATE USER when koha-create --use-db Please, check the attachment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 02:17:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 00:17:30 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #114 from Jesse Weaver --- Created attachment 41425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41425&action=edit Bug 11559: (followup) Fix import bugs, display/parsing issues This fixes the following issues: * ISO2709 import fails for Unicode * Import only works with .mrc/.xml extensions * MARC21 widgets not translatable * Macro UI broken * Uppercase subfield codes forbidden * Tag with no valid subfields shows as error but tries to save -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 08:14:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 06:14:00 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 08:15:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 06:15:43 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41422|0 |1 is obsolete| | Attachment #41423|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 41426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41426&action=edit Bug 14660: Fix stocknumberAV.pl cataloguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 08:15:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 06:15:59 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #6 from Josef Moravec --- Created attachment 41427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41427&action=edit Bug 14660: Fix stocknumberam123.pl cataloguing plugin The cataloguing plugin stocknumberam123.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Create a new item, set the inventory number to: A 0000000002 - Start to catalog another item, enter A into inventory and - Enter A as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 14:20:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 12:20:07 +0000 Subject: [Koha-bugs] [Bug 14661] New: space needed in added to staff side cart message, if items added are already in cart Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Bug ID: 14661 Summary: space needed in added to staff side cart message, if items added are already in cart Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". Some sort of break needed between the two messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 14:27:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 12:27:59 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com --- Comment #3 from bondiurbano --- Kyle, Galen I think it is a "major" bug... Today I will attach the test I've done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 14:58:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 12:58:39 +0000 Subject: [Koha-bugs] [Bug 10707] inventory not removing lost status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10707 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #3 from Barton Chittenden --- This seems to be fixed in master Test procedure used: 1. Set item to missing status. 2. Run inventory with barcode in file. 3. See that the last seen date has been updated, and the missing status is still intact. When I tested against 3.21.00.016, I found that the missing status had been cleared for the item in question. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 15:32:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 13:32:06 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- This may be version specific. I could not replicate this in 3.21. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 15:32:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 13:32:06 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- This may be version specific. I could not replicate this in 3.21. Christopher --- Comment #2 from Christopher Brannon --- This may be version specific. I could not replicate this in 3.21. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 15:32:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 13:32:24 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 --- Comment #3 from Christopher Brannon --- This may be version specific. I could not replicate this in 3.21. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 15:32:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 13:32:47 +0000 Subject: [Koha-bugs] [Bug 14662] New: Add empty entry to pull down when subfield is mandatory and linked to authorized value Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14662 Bug ID: 14662 Summary: Add empty entry to pull down when subfield is mandatory and linked to authorized value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If you mark a subfield as mandatory and it's linked to an authorised value the first value will be preselected and there is no empty entry in the list. This means the mandatory warning can never be triggered and a library might not notice that a wrong value has been selected. I think the behaviour should be that for a new item the field is empty at the beginning, so it will warn if you try to save without selecting a value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 15:44:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 13:44:03 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #121 from Kyle M Hall --- (In reply to Jonathan Druart from comment #119) > (In reply to Kyle M Hall from comment #115) > > As far as I can tell there is no way around this. I tried to use a left join > > but you cannot use a group by in an update statement. > > Kyle, > Just a quick thought: wouldn't it be possible to execute another update > statement after the existing one, instead of adding complexity to it? I do not believe this is possible. The addition isn't adding additional changes, it's *preventing* additional changes. We can't create a second query that prevents updates caused by the first one. I think we have only two choices here, either accept the speed cost or switch back to the original version. I have no problem with either choice, but one must be made. We can't hold this feature in discussion forever. This is not complicated as a choice, especially since it seems that the speed cost is unacceptable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 15:45:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 13:45:41 +0000 Subject: [Koha-bugs] [Bug 14663] New: Change location and behavior of barcode entry box in lists Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14663 Bug ID: 14663 Summary: Change location and behavior of barcode entry box in lists Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: nick at quecheelibrary.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently the barcode boc is at the bottom of the lists page. When scanning in items in a batch you must scroll back to the box to enter another barcode To recreate: 1 - Open or create a list with multiple items 2 - Scroll to the bottom and scan a barcode to add to the list 3 - note that you jump to the top of the page 4 - you must now scroll to the bottom to enter another (and lcik on the box ot focus) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 15:46:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 13:46:30 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #122 from Kyle M Hall --- (In reply to Katrin Fischer from comment #120) > I'd really like to avoid us storing patron related information in the items > table and potentially double the information to yet another place. It would > be great if more people could take a look here to help figure out if there > is a "fast" way of doing this with the existing data. Katrin, can you explain the justification for not wanting option B aside from the fact that it's storing data in another place? What are your actual concerns about this practice? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 15:47:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 13:47:30 +0000 Subject: [Koha-bugs] [Bug 14663] Change location and behavior of barcode entry box in lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at quecheelibrary.org Severity|trivial |minor CC| |cbrannon at cdalibrary.org, | |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 15:52:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 13:52:11 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #123 from Katrin Fischer --- Basically a big pile of paperwork where I have to document every table that has in any form a connection to patron data and the duplication of the information. Also the possibility that this will leak out into the OPAC with the other item data when someone maps it to a 952 field not thinking about the consequences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 15:54:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 13:54:45 +0000 Subject: [Koha-bugs] [Bug 14390] On renewal, the last fine is not marked as accounttype 'F' when item is checked in. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #4 from bondiurbano --- Created attachment 41428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41428&action=edit Step by step sample Sorry, in spanish -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 16:22:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 14:22:07 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #4 from Barton Chittenden --- Created attachment 41429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41429&action=edit Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 16:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 14:22:55 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #124 from Kyle M Hall --- (In reply to Katrin Fischer from comment #123) > Basically a big pile of paperwork where I have to document every table that > has in any form a connection to patron data and the duplication of the > information. Also the possibility that this will leak out into the OPAC with > the other item data when someone maps it to a 952 field not thinking about > the consequences. Thanks! I'm not sure we've any way around that. The connection won't be made unless the feature is specifically enabled. Likewise, this data would never be revealed in the opac unless some specifically map the column to a field. To accidentally reveal the data would definitely require jumping through some hoops, but we have no way to absolutely prevent such an occurrence. On the other hand I don't feel that this should be a blocker considering we could do the exact same thing in other areas of Koha. Consider how trivial it would be to create a patrons report and then mark it public? Just because that's possible doesn't mean we stopped the public reports feature from making it into Koha. That being said, I'll defer to your judgement, but someone has to make a decision. Either we go with choice A or choice B. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 16:24:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 14:24:04 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 16:41:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 14:41:45 +0000 Subject: [Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 --- Comment #2 from Tom?s Cohen Arazi --- (In reply to Yarik Dot from comment #1) > Created attachment 41424 [details] [review] > Patch - remove CREATE USER when koha-create --use-db > > Please, check the attachment. I think the behaviour should be: - If the user passes DB parameters (user, pass, hostname, dbname), use them to configure the instance. This needs more parameters to be added to koha-create. hostname should default to 'localhost' if ommited. - If some of the new parameters is missing, fallback to what is configured in /etc/koha/passwd. - If some of the relevant parameters is missing, fail loudly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 16:43:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 14:43:43 +0000 Subject: [Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 --- Comment #3 from Tom?s Cohen Arazi --- Comment on attachment 41424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41424 Patch - remove CREATE USER when koha-create --use-db - if [ "$op" = use ] - then - mysql --defaults-extra-file=/etc/mysql/koha-common.cnf --force < References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #5 from bondiurbano --- (In reply to Galen Charlton from comment #2) > I don't think that renewing a loan actually converts accrued overdue fines > to committed/closed ones. Rather, I think the sequence of events is this: > > - make loan > - loan becomes overdue > - accrued fines start getting calculated (accounttype = FU) > - loan is renewed > - accrued fine record is not changed (and while the fine itself shouldn't go > away, the accounttype *ought* to be changed to F and the description updated > to indicate that the loan was renewed while overdue) > - loan becomes overdue again > - accrued fines start getting calculated on a second accountlines row > - loan gets returned > > During the return processing, _FixOverduesOnReturn will change the > accounttype of accrued fines from FU to F. However, it currently assumes > that there is exactly one such fine; if there are multiple ones, only one > gets its accounttype changed. Fully agree with you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 16:46:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 14:46:11 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14277 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277 [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 16:46:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 14:46:11 +0000 Subject: [Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |14217 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 [Bug 14217] Add a DOM syntax for specifying conditions on indexes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 16:47:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 14:47:10 +0000 Subject: [Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 17:00:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 15:00:12 +0000 Subject: [Koha-bugs] [Bug 7377] Feature Request: Add Lexile Search for Ranges of Lexile Scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7377 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #2 from Barton Chittenden --- See bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277 Search index 'lex' does not honor MARC indicator "ind1" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 17:49:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 15:49:01 +0000 Subject: [Koha-bugs] [Bug 14664] New: Harvesting records of an non-existent set, instead of an error return all the records Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14664 Bug ID: 14664 Summary: Harvesting records of an non-existent set, instead of an error return all the records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org Steps: - Enable syspref OAI-PMH and leave OAI-PMH:ConfFile empty. - Set an OAI set on Home ? Administration ? OAI sets configuration - Remember the setSpec you choose (the real set primary key), for example setSpec==THESIS - Fetch with set=THESIS, you will get records on that set. - Now fetch records with set=bananas. Expected result: A badArgument error like this one: http://digital.bl.fcen.uba.ar/gsdl-282/cgi-bin/oaiserver.cgi?verb=ListRecords&metadataPrefix=oai_dc&set=bananas (Greenstone v2.82) Actual result: List ALL records, like here: http://catalog.bywatersolutions.com/cgi-bin/koha/oai.pl?verb=ListRecords&from=2010-01-01&metadataPrefix=oai_dc&set=bananas Reference: https://www.openarchives.org/OAI/2.0/guidelines-harvester.htm#Sets https://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 19:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 17:27:54 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #8 from bondiurbano --- Jonathan, I was testing in a local installation. All works fine if I discard checkout.js modifications. If I consider checkout.js modifications all checkouts in the checkout patron view are missing. Please see attached PDF. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 19:29:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 17:29:17 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #9 from bondiurbano --- Created attachment 41430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41430&action=edit Missing data display in checkout patron view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 19:59:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 17:59:46 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 --- Comment #4 from Kyle M Hall --- Created attachment 41431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41431&action=edit Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 20:00:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 18:00:06 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com Attachment #41431|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 20:03:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 18:03:06 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Failed QA --- Comment #13 from Tom?s Cohen Arazi --- Hi, please check why this patch makes tests fail: $ prove t/db_dependent/Labels/t_Layout.t t/db_dependent/Labels/t_Layout.t .. 1/36 # Testing Layout->new() method. # Testing Layout->get_attr() method. # Testing Layout->set_attr() method. # Testing Layout->save() method with a new object. # Testing Layout->retrieve() method. # Testing Layout->save() method with an updated object. # Testing Layout->get_text_wrap_cols() method. # Failed test 'Layout->get_text_wrap_cols()' # at t/db_dependent/Labels/t_Layout.t line 103. # got: '21' # expected: '23' # Testing Layout->delete() method. Use of uninitialized value $del_results in string ne at t/db_dependent/Labels/t_Layout.t line 108. # Looks like you failed 1 test of 36. ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 20:03:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 18:03:48 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 --- Comment #5 from Kyle M Hall --- Created attachment 41432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41432&action=edit Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 20:04:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 18:04:41 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 20:05:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 18:05:02 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41432|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 41433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41433&action=edit Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 20:05:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 18:05:21 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 20:20:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 18:20:31 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 20:22:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 18:22:29 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41433|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 41434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41434&action=edit [SIGNED-OFF] Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines Signed-off-by: Heather Braum -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 20:35:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 18:35:57 +0000 Subject: [Koha-bugs] [Bug 14665] New: Items Permanent Location not set when item is ordered Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14665 Bug ID: 14665 Summary: Items Permanent Location not set when item is ordered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In Acquisitions, when an item record is created during the ordering process, and a location is selected, that location does not save to the items.permanent_location field. Items then have NULL value in permanent_location and if Cart to shelf is turned on the location becomes CART and the permanent location becomes CART also (in the course of circulating the item). 1. Create basket 2. Create order record for an item (create the item record) 3. Check items table for location and permanent_location values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 7 20:39:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 18:39:05 +0000 Subject: [Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514 Joel Sasse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse at plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 8 00:08:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 22:08:41 +0000 Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 --- Comment #15 from Nick Clemens --- *** Bug 14663 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 8 00:08:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 22:08:41 +0000 Subject: [Koha-bugs] [Bug 14663] Change location and behavior of barcode entry box in lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 11325 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 8 00:09:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 22:09:07 +0000 Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 8 01:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Aug 2015 23:23:17 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m --- Comment #4 from Jesse Weaver --- The issue here is that there can be a large number of patrons with a privacy of 2 ("Never") even if all of the following are true: * OPACPrivacy is off * All patron categories have a default privacy of Forever or Default This can occur for three major reasons: * The patrons had their privacy settings changed when OPACPrivacy was previously enabled, but it has since been disabled * The patrons were imported with a privacy of 2 * A patron category had a default privacy setting of Never at the time the patron was created (if the category's default privacy setting is later changed, it does not affect the privacy of previously created patrons) This isn't an edge case; we have a large number of libraries whose checkins were silently failing after a bugfix upgrade due to one of the three scenarios above. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 8 10:01:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Aug 2015 08:01:10 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Hm, so it looks like the main problme is a mismatch of the template logic to display the warning with the logic in the module? (privacy setting of the borrower vs. system preferences?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 8 10:01:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Aug 2015 08:01:42 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master --- Comment #6 from Katrin Fischer --- As this patch is in master - I am changing the version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 8 16:34:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Aug 2015 14:34:52 +0000 Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 8 16:34:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Aug 2015 14:34:54 +0000 Subject: [Koha-bugs] [Bug 10005] inventory checks items in without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40990|0 |1 is obsolete| | --- Comment #5 from Jason Robb --- Created attachment 41435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41435&action=edit [SIGNED OFF] Bug 10005: Inventory - Add an option to not check in items The inventory tools automatically check in items, this patch adds it as an option. Test plan: 1/ Check an item out, fill a file with its barcode, and use this file in the inventory tools. 2/ Check the new checkbox and confirm that the item is not checked in 3/ Repeat again and don't check it, the behavior should be the same as before this patch. Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 8 20:29:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Aug 2015 18:29:43 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Christopher Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mr.cataloger at gmail.com --- Comment #115 from Christopher Davis --- (In reply to Jesse Weaver from comment #73) > Notes: All settings, including switching between the basic editor and > Rancor, are saved per-user as local settings. This means they should be > completely separated by user (though not private). Also, the [@number] > markings are just an artifact of the software used to prepare this. > > The individual parts of this test plan should be separately testable; please > test what you can! > > 1. Apply patch. > > *** Part 1 - Navigating to editor > 2. [@2] Go to the Cataloging section. > 3. Click on "Advanced editor." This should take you to Rancor with an empty > record loaded. > 4. Click on "Settings" -> "Switch to basic editor," then "OK." This should > switch to the basic editor with an empty record. > 5. Click on "Switch to advanced editor." This should take you back to Rancor. > 6. Navigate to a record, and click "Edit" -> "Edit record." This should load > the record in Rancor. > 7. Verify that clicking on "(view)" and "(edit items)" go to the correct > screens for the current record (in a new window). > 8. Click "Settings" -> "Switch to basic editor," then repeat. This should > now load in the basic editor. Click "Switch to advanced editor" for the > following steps. > 9. Go back to the Cataloging home page. > 10. Click on "New from Z39.50/SRU," run a Z39.50 search (doesn't matter what > for) and click "Import." This should open in the basic editor; the old-style > Z39.50 search interface is separate from that built into Rancor. > *** Part 2 - Editing records > 11. [@11] Return back to a new record in Rancor. > 12. Verify that the data portion non-control fields (>010) can be freely > typed into. Typing a dollar sign, alphanumeric and a space should create a > new subfield. For known MARC subfields, the description of the current field > (and subfield) should be shown in the status bar at the bottom. > 13. The data portion of control fields, tag numbers and indicators should be > editable, but in overwrite mode. If a syntactically incorrect MARC tag is > entered, the entire line should lose any other highlighting and turn red. > 14. For known fixed fields (currently only MARC21 leader or 000, 005 and > 008), the data portion of the field should be displayed as a widget, with > underlined portions that expand into text fields/dropdowns for the various > coded parts of the field. These widgets are toggleable in the settings. > 15. Subfields with authorized values attached to them should also be > displayed as simple, single-dropdown widgets. > 16. It should be possible to tab between the tag number, indicators, each > subfield and each element in a fixed field widget. Typing values for these > fields should work as expected. > 17. By pressing Enter anywhere in a field, the cursor should be moved to a > new field on the next line. > 18. After typing in the number of a tag, pressing Tab should tab through and > automatically create the indicator positions. > 19. By pressing Ctrl-X, the entire field should be deleted. > > *** Part 3 - Record Import/Export > 20. [@20] By entering text into any of the given fields on the left, a > search will be run with the given search field and contents (and none of the > others). Verify that they can be focused with their listed keyboard > shortcuts. > 21. Click on the checkboxes next to any of the available search targets to > enable/disable that target. > 22. Click on the arrows above any column to resort the results by that > column. Sorting defaults to title. NOTE: performance of the above will be > severely degraded if Koha::Cache is not running in memcached/fastmmap mode. > 23. Click on "View MARC" to show a preview of the record contents, and "Hide > MARC" to return to the original view. > 24. Click on "Import", and the record contents should be replaced with that > of the selected record. > 25. Click on "Advanced" in the search box on the left. > 26. Check or uncheck any of the servers to enable/disable them before the > search. The search query will be ANDed together from any non-empty fields. > 27. Verify that advanced search behaves similarly to a quick search after > results are returned. > 28. Open an existing catalog record in Rancor. > 29. Perform a search, and verify that "Substitute" copies the record > contents into the current catalog record, while "Import" starts editing a > new record. > 30. Verify that "Save" correctly saves record contents to the catalog. > 31. Click on the dropdown next to "Save to catalog," then either "Save as > ISO2709 (.mrc) file" or "Save as MARCXML (.xml) file." Click "Save file" (or > your browser's equivalent), then verify that the exported record's contents > are correct. > 32. Click on "Import record", then any ISO-2709 (.mrc) or MARC-XML (.xml) > record. The record contents should be loaded. > > *** Part 4 - Settings/Macros > 33. [@33] The "Settings" menu contains several font configuration options. > Verify that they all work as expected (some fonts may not exist on your > system). > 34. Click on "Macros." This should bring up a screen with no existing macros. > 35. Click "New macro..." and type in a name for the new macro. It should be > added to the list on the side. > 36. The format dropdown exists to allow compatibility with a proprietary > vendor format; the default of Rancor should be sufficient. > 37. Type any text into the macro editor, and it should be autosaved after a > brief delay. > 38. Hit "Delete macro" to delete this macro. > 39. Create a new macro, insert some text, wait for it to autosave, then > reload the page to verify that the macro contents are saved. > 40. Enter in some test macros, and verify that they work as expected. There > are a number of possible macro commands, but all are variants of two basic > forms: > - delete TARGET :: Deletes the given TARGET. > - TARGET=SOURCE :: Copies the contents of SOURCE into TARGET (spaces > around the equals sign are not allowed for reasons of ambiguity in fixed > fields). > 41. The possible targets are (specific tags/subfields are used, but only as > examples): > - 001 :: The entire contents of a control field (will be created if > needed). > - 245 :: The entire contents of the first 245 field (will be created if > needed). > - new 245 :: The entire contents of a new 245 field, inserted in > numerical order. > - new 245 grouped :: The entire contents of a new 245 field, inserted at > the end of the 200s. > - 245a OR 245a at end :: The contents of the $a subfield of the first > 245 field (will be created at the end of the field if needed). > - 245a after c :: The contents of the 245 $a subfield (will be created > after the $c subfield if needed). > - new 245a OR new 245a at end OR new 245a after c :: The contents of a > new 245 $a subfield in the given position. > - $a :: The contents of the $a subfield of the last mentioned tag. > - 245 indicators OR indicators :: Sets both indicators of either the > first field with the given tag or the last mentioned tag. > 42. The possible sources are: > - 001 OR 245 :: The entire contents of the first field with the given > tag. > - 245a :: The contents of the first $a subfield of the first 245 field. > 43. Some example commands: > - new 245=$a Charlotte's Web /$c by E.B. White. > - delete 245c > - 003=ByWater > 44. Verify that entering a syntactically correct macro and hitting "Run > macro" closes the macro editor and runs the given macro. To Whom It May Concern: In the above test plan, step number fifteen (15) states, "Subfields with authorized values attached to them should also be displayed as simple, single-dropdown widgets." When I proceed through this test plan, I cannot find any single-dropdown widgets in the MARC record which I create, except for those in, for example, MARC field 008. Is the "authorized values" mentioned in step fifteen of the test plan referring to authorized headings/access points or is this term referring to Koha authorized values such as Koha CCODES, location codes, NOT_LOAN codes, etc.? Please help me understand so that I can proceed with signing off this bug. Thank you, Christopher Davis, MLS Systems & E-Services Librarian Uintah County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 9 03:12:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 01:12:53 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #19 from Christopher Brannon --- If I am testing correctly, and reading correctly, I am not seeing any benefit to this patch. In it's current state, it is doing what it always did. Can someone tell me what should be different in behavior with the patch applied? Sorry. Don't know if it just me or what. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 9 14:12:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 12:12:41 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #20 from Eivin Giske Skaaren --- The difference is that the loan period is not shortened for the next scanned book. Without the patch if you get a shortened loan period then the next scanned book will also get that same shortened period automatically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 9 18:43:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 16:43:33 +0000 Subject: [Koha-bugs] [Bug 14525] undo checkin/out when accompanying message appears In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14525 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 9 18:43:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 16:43:40 +0000 Subject: [Koha-bugs] [Bug 14525] undo checkin/out when accompanying message appears In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14525 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 9 23:31:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 21:31:36 +0000 Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #17 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 9 23:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 21:33:52 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 00:21:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 22:21:00 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #24 from Katrin Fischer --- Hi Pedro, not sure you grepped for the right things. Maybe a good first step would be to see if you currently store a dateaccessioned in your items or bibliographic data - checking the Koha-to-MARC-mappings for it and also the bibliographic frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 00:29:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 22:29:50 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hm, is the Price plugin the right one there? Because it's not an amount but a percentage value? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 00:42:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 22:42:56 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #125 from Katrin Fischer --- I think I can totally imagine a library trying to make this visible in the editor and item view pages - which would require mapping it. And not being aware that the hidden fields (opac visibility most of all) are basically broken. Or not thinking about Z39.50, OAI-PMH... etc. We also deactivated the feature to make reports public in the GUI for our customers because of privacy concerns. I have no problem with the idea of this feature in itself - it's optional. I just think there might be a third option we haven't investigated yet. Or a way to improve performance. I am not sure I dare to suggest,... but what about a separate table? That wouldn't fix the duplicate information issue - so not ideal, but it could help fixing the other concerns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 00:45:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 22:45:55 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #108 from Katrin Fischer --- Hi Tim, not sure if that's the reason - but did you run the database update? you can run updatedatabase.pl from the command line or change kohaversion.pl to +1 and then after the update is run change it back to the number it had before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 00:55:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 22:55:43 +0000 Subject: [Koha-bugs] [Bug 13343] Items are not embedded when sending a basket/shelf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 --- Comment #11 from Chris Cormack --- (In reply to Katrin Fischer from comment #5) > A note about this: as things currently are, we will send out information > that has been marked as not visible in the OPAC or labelled as internal > note. I wonder if we should make including items in the staff/cart optional > for the time being as fixing the problem with visibility is a much bigger > issue. > There has been a discussion about this for OAI as well, but things OPAC side > might need a different treatment (bug 12252). > > I know this patch just makes things more consistent as one download includes > items and the other does not - if people are ok with the idea of optional, I > will try to work up a patch on a separate bug - not blocking this. I'd still like to see this, Koha should be the most privacy conscious library system out there. Let's try to make this our goal. I'd be happy to test and sign off a patch that respects the hidden settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 00:58:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Aug 2015 22:58:11 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #109 from Katrin Fischer --- ... that should read 'add 1 to the version number at the end...' or similar :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 05:54:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 03:54:10 +0000 Subject: [Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |Seeking cosponsors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 06:50:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 04:50:46 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia at hotmail.com --- Comment #110 from Aleisha Amohia --- The system breaks for me if I don't provide an email or username (leave both spaces empty) to send the reset link to. Get this error: opac-password-recovery.pl: Can't use an undefined value as an ARRAY reference at /home/vagrant/kohaclone/opac/opac-password-recovery.pl line 66 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 10:28:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 08:28:07 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > Hm, is the Price plugin the right one there? Because it's not an amount but > a percentage value? I'd say yes, we could add an option to the plugin later (something like "display as %"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 10:29:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 08:29:35 +0000 Subject: [Koha-bugs] [Bug 14666] New: adds fixed_fines for overdues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Bug ID: 14666 Summary: adds fixed_fines for overdues Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: stephane.delaye at biblibre.com QA Contact: testopia at bugs.koha-community.org adds fixed_fines for overdues - Add a overduerules.fixed_fineX for the 3 levels - Add a column "Fixed fines" in the tools/overduerules.pl page - Add column in csv generated by circ/overdue.pl (document_type and generatedate = the today's date) - Add column in csv generated by overduenoticeS.pl (streetnumber, streettype, generatedate, overdue_level - Now you can add 'count' and 'total_amount' in circulation letters count is "itemcount" and total_amount is the transcription of the total_amount (which is the sum of items.price + fixed_fine). The langage used is the locale of the system. - New dependency : Lingua::Any::Numbers. If you want use fr for example, you will have to install Lingua::FR::Numbers too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 10:37:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 08:37:43 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #10 from Jonathan Druart --- It seems to work here. Are you sure you have correctly refreshed the page (to take into account the JS changes)? You certainly got a JS error, please report it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 10:39:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 08:39:19 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #8 from Katrin Fischer --- For me Price feels not right - and only 2 decimals I think? not enough for the percentage? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 10:59:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 08:59:55 +0000 Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 10:59:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 08:59:59 +0000 Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 --- Comment #3 from Jonathan Druart --- Created attachment 41436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41436&action=edit Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833) This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x): commit 481479fe627dcbabb3ef66df0724cc3fe75b110c Bug 12648: Fix conflict with bug 12833 Test plan: Set the cardnumber of one of the patron to an empty string Do a patron search and use filters The search will redirect to the patron detail page of the patron with the empty string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 11:00:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 09:00:19 +0000 Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 11:00:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 09:00:47 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #25 from Pedro Ferreira --- Hello, koha to marc mapping i have in the items tab itemnumber 995 9 Internal item number (Koha itemnumber, autogenerated) Alterar barcode 995 f Barcode Alterar dateaccessioned 995 5 Date acquired Alterar homebranch 995 b Origin of item (home branch) (coded) Alterar in a test koha, i created the 995$c and liked it to the database field date-of-aquisition. Re-index the zebra and the search is empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 11:14:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 09:14:51 +0000 Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375 --- Comment #12 from Fridolin SOMERS --- Created attachment 41437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41437&action=edit Bug 14375 - Use mock on dbh instead of _new_dbh This patch changes in test modules the mock on database connexion. Instead of mocking method _new_dbh (removed by main patch), mock directly method dbh. Always use t::lib::Mocks::mock_dbh() for that. To test, just run prove on modified test modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 11:15:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 09:15:59 +0000 Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Fridolin SOMERS --- I've corrected test modules that mock database connexion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 11:22:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 09:22:45 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #7 from Jonathan Druart --- (In reply to Jesse Weaver from comment #4) > The issue here is that there can be a large number of patrons with a privacy > of 2 ("Never") even if all of the following are true: > > * OPACPrivacy is off > * All patron categories have a default privacy of Forever or Default > > This can occur for three major reasons: > > * The patrons had their privacy settings changed when OPACPrivacy was > previously enabled, but it has since been disabled Restricting the privacy of the users is really not kind. Especially if they had chosen to protect their data previously. I'd say it's like breaking a contract :) > * The patrons were imported with a privacy of 2 They should not have been imported with privacy=2 if OPACPrivacy is off. > * A patron category had a default privacy setting of Never at the time the > patron was created (if the category's default privacy setting is later > changed, it does not affect the privacy of previously created patrons) Same as before, there is an inconsistency in the configuration ('Never' with OPACPrivacy off). > This isn't an edge case; we have a large number of libraries whose checkins > were silently failing after a bugfix upgrade due to one of the three > scenarios above. You should have got a big warnings during the updatedatabase process, don't you got it? (In reply to Katrin Fischer from comment #5) > Hm, so it looks like the main problme is a mismatch of the template logic to > display the warning with the logic in the module? (privacy setting of the > borrower vs. system preferences?) The checks look good to me. We could apply the following changes: diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 7813e33..2e06ff2 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2077,7 +2077,7 @@ sub MarkIssueReturned { my ( $borrowernumber, $itemnumber, $dropbox_branch, $returndate, $privacy ) = @_; my $anonymouspatron; - if ( $privacy == 2 ) { + if ( $privacy == 2 and C4::Context->preference('OPACPrivacy') ) { But I still think the privacy should be respected and the data updated if inconsistencies exist. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 11:25:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 09:25:21 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #8) > For me Price feels not right - and only 2 decimals I think? not enough for > the percentage? It's better than 1, and the patch suggested to set it to 2, what the plugin does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 11:30:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 09:30:18 +0000 Subject: [Koha-bugs] [Bug 14667] New: Label creator UI/UX revamp Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Bug ID: 14667 Summary: Label creator UI/UX revamp Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org The label creator is overdue for some UI/UX attention. This bug will keep track of the proposed changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 11:34:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 09:34:36 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 --- Comment #10 from Katrin Fischer --- Hm, but is 2 enough? Int wouldn't be for Kyle's example. Maybe we should just display 'as it is configured' and not cut it off. .07625 would be 7.625 I think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 11:36:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 09:36:59 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 11:38:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 09:38:42 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #8 from Katrin Fischer --- The suggested change looks good to me - I think that should work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 12:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 10:24:26 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 12:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 10:24:30 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #1 from Liz Rea --- Created attachment 41438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41438&action=edit Bug 14667 - UI/UX improvements for the Label creator Reasoning Librarians will be doing label things in the following frequencies, from most frequent to least frequent: 1. Creating new label batches - every day/every few days 2. Managing existing label batches - every day/every few days 3. Managing existing label layouts - as needed, infrequent 5. Managing existing label templates - as needed, infrequent 6. Creating new label layouts - as needed, infrequent 7. Creating new label templates - as needed, infrequent 8. Managing existing printer profiles - possibly once only! 9. Creating new printer profiles - possibly once only! This change to the label creator aims to make the most frequently used items easily accessible at the top of the main area, reduces clutter on the page, and makes the label creator fall in line with UI paradigms found elsewhere in Koha. To test: Open the label creator: More -> Tools -> Label creator Note that the toolbar has changed. It should be consistent across all of the label creator (it is an include). + New menu: Label batch 1. make sure it looks ok - toolbar buttons are consistent at the top of the main block. 2. add items both by barcode, and by search (note this patch does not touch the pop up window. Another day.) 3. note that the usual buttons have moved below the textarea, and now have icons. 4. delete and export single items using the buttons corresponding to each item 5. select multiple and use the buttons above the table to remove and export selected items 6. export a full batch 7. deduplicate a batch There should be no regressions in functionality. Layout 1. This menu item should take you directly to the "Edit layout" screen. 2. no functional changes here. 3. note toolbar at top is consistent Label template 1. this menu item should take you directly to the "Edit label template" page. 2. no functional changes here. 3. note toolbar at top is consistent. Printer profile 1. this menu item should take you directly to the "Edit printer profile" page. 2. no functional changes here. 3. note toolbar at top is consistent. + Manage menu: Label batches 1. This menu item should take you directly to the "currently available batches" page. 2. select a batch to edit using the buttons 3. select a batch to delete using the buttons - it should ask for confirm. 4. select several batches using the tickboxes, and select Export selected. Batches should be exported as normal. 5. note toolbar at top is consistent. Layouts 1. This menu item should take you directly to the "currently available layouts" page. 2. select a layout to edit using the buttons 3. select a layout to delete using the buttons 4. note toolbar at top is consistent. Label templates 1. This menu item should take you directly to the "currently available templates" page. 2. select a template to edit using the buttons 3. select a template to delete using the buttons 4. note toolbar at top is consistent. Printer profiles 1. This menu item should take you directly to the "currently available profiles" page. 2. select a profile to edit using the buttons 3. select a profile to delete using the buttons 4. note toolbar at top is consistent + General * note that sidebar now only has "labels home" instead of the full "manage" list. It seemed redundant with the toolbar tidied up. Please note that I am happy to take suggestions/amendments to these changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 14:09:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 12:09:16 +0000 Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375 --- Comment #14 from Fridolin SOMERS --- Created attachment 41439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41439&action=edit test module Test module. It saves a record and tries to get it each 15 minutes 4 times. Without patch, it fails with : database has run away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 15:08:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 13:08:57 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #11 from bondiurbano --- You are wright Jonathan, I'm soooooo sorry. All work fine, great job! I've attached a PDF file with some legends suggestions. Thank you very much Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 15:10:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 13:10:36 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #12 from bondiurbano --- Created attachment 41440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41440&action=edit Legends suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 16:09:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 14:09:38 +0000 Subject: [Koha-bugs] [Bug 14668] New: Show serial enumeration in the checkin page and the patron's opac checkout summary Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 Bug ID: 14668 Summary: Show serial enumeration in the checkin page and the patron's opac checkout summary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: francois.charbonnier at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Serial enumeration can be useful when checking in several serials in a row to control what was checked in. It's also an information useful to the patrons when they checked out different volumes from the same serial. The enumeration helps to keep track which one is due in their account's checkout summary. This patch will display items.enumchron in : * the checkin page * the patron's opac checkout summary -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 16:25:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 14:25:27 +0000 Subject: [Koha-bugs] [Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12085 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085 [Bug 12085] Allow staff to place multiple reserves for the same patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 16:25:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 14:25:27 +0000 Subject: [Koha-bugs] [Bug 12085] Allow staff to place multiple reserves for the same patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12085 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13430 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 [Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 16:29:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 14:29:57 +0000 Subject: [Koha-bugs] [Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 --- Comment #5 from Olli-Antti Kivilahti --- It looks like I had missed a dependency there, and the dependency is quite a deep Koha modification allowing people to place multiple holds on one Biblio. We are rebasing all our production features against master when we upgrade to 3.22. We will upgrade when 3.22 comes out :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 16:38:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 14:38:49 +0000 Subject: [Koha-bugs] [Bug 13080] Addition of noEnterSubmit class should not apply to textarea, only to input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11563 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 16:38:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 14:38:49 +0000 Subject: [Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13080 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 17:59:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 15:59:56 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 23:01:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 21:01:16 +0000 Subject: [Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 23:05:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 21:05:49 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #17 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 23:08:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 21:08:38 +0000 Subject: [Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 23:21:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 21:21:21 +0000 Subject: [Koha-bugs] [Bug 14547] Typo in help file for 3.20 (basket.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14547 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 23:21:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 21:21:46 +0000 Subject: [Koha-bugs] [Bug 14548] Typo in help file for 3.20 (batch_record_modification.tt) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14548 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 10 23:30:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 21:30:53 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |wizzyrea at gmail.com |u | Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 00:29:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 22:29:32 +0000 Subject: [Koha-bugs] [Bug 14669] New: search by branch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Bug ID: 14669 Summary: search by branch Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/histsearch.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org It would be nice to do an order search by branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 00:29:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 22:29:55 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Stephane, I am in doubt about this patch - especially the new dependencies. What are they used for? We have a new plugin to format prices now and also some existing code to do that - could it be achieved with the existing modules? I also think this would be good on separate bugs - for example the colums added to the CSV seem unrelated to the main feature. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 00:40:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 22:40:36 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #126 from Heather Braum --- I skimmed through the conversation, made it to the bottom, and am pondering Katrin's latest comment. What ABOUT a new table to store this data? That seems to be the simplest solution. Something that is storing the fields id, borrowernumber, itemnumber, date, and "reason" or something like that, where the "reason" field or whatever it could be called is the reason for this data being stored -- "last borrower" in this case. And a field like that could open the door for this table to be used for a few other things. It could be used to store data like the statistics.type fieldd oes, that stores issue, return, renew, localuse data. Could something be written to delete this table for those countries/locations that need to anonymize all patron data, due to privacy concerns/laws; and then leave the data in this table for those libraries that need this data? And this may be way outside the scope of this conversation, but could a new table like this open the door to also be used [after future development] to store (staff) borrower data for tracking items adds/edits/deletes/branch transfers to items, using the above "reason" field? Because while this particular data is stored in the cataloging logs, my system is way too big to keep those logs turned on, and I'd love a way to be able to track that type of data. I propose this additional suggestion, so maybe this table could possibly take on additional uses, other than just the one way to balance privacy differences for those who want to keep last borrower data and anonymize the rest of the data vs those who can't keep any of these data due to local policies and laws. Will be curious to see where this conversation goes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 00:59:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 22:59:36 +0000 Subject: [Koha-bugs] [Bug 14670] New: add 'cite' option to detail page in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Bug ID: 14670 Summary: add 'cite' option to detail page in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 41441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41441&action=edit cite option & pop up It would be nice if we could add a 'cite' option to the menu on the right of the opac detail pages like in some other discovery interfaces - see attached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 01:04:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Aug 2015 23:04:28 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #127 from Christopher Brannon --- I LOVE the idea of having a separate table for this function. Perhaps it can be designed in such a way that this function would have an option to store the last x patrons. It could also have a timestamp and feature to remove the data if it is x days old. It definitely should have the ability to be turned off if needed. And to address what Heather suggested, yes, it could be used for other things, but I think having a tables for specific functions lends itself to a more efficient database rather than trying to design a table that encompasses many things. I think the more a table tries to cover, makes the table bigger and less efficient. There is more stuff to wade through. Something that needs to be considered for any table in the database. The more you throw in a table, the less effective the database, as a whole, becomes. My Two Cents, Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 03:59:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 01:59:46 +0000 Subject: [Koha-bugs] [Bug 14586] Update 3.18 Koha team with new release maintainers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14586 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Passed QA |Pushed to Stable --- Comment #6 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 04:00:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 02:00:08 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #14 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 04:00:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 02:00:43 +0000 Subject: [Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #10 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 04:01:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 02:01:06 +0000 Subject: [Koha-bugs] [Bug 14569] Typo for borrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14569 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #6 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 04:01:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 02:01:31 +0000 Subject: [Koha-bugs] [Bug 14456] EmbedSeeFromHeadings record filter shouldn't process MARC holding fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14456 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #8 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 04:01:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 02:01:58 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #9 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 04:02:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 02:02:27 +0000 Subject: [Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #6 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 04:05:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 02:05:33 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #18 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 04:06:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 02:06:15 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 --- Comment #19 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 04:06:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 02:06:43 +0000 Subject: [Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #13 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 04:39:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 02:39:19 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 09:59:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 07:59:28 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #45 from Fridolin SOMERS --- *** Bug 6864 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 09:59:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 07:59:28 +0000 Subject: [Koha-bugs] [Bug 6864] add a syspref to allow custom text for OPAC user/pass information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6864 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #24 from Fridolin SOMERS --- For me, this is a complete duplicate of Bug 10951 *** This bug has been marked as a duplicate of bug 10951 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 10:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 08:02:03 +0000 Subject: [Koha-bugs] [Bug 10001] Translation scripts pick up TT comments for translation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10001 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 10:06:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 08:06:42 +0000 Subject: [Koha-bugs] [Bug 14374] dont use mysql_auto_reconnect with DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 --- Comment #4 from Fridolin SOMERS --- (In reply to Olli-Antti Kivilahti from comment #3) > Shouldn't this bug be merged into Bug 14375? > You cannot disable > - $dbh->{mysql_auto_reconnect} = 1; > Without first introducing the DBIx::Connector? Bug 14375 does not introduce the use of DBIx::Connector, it's Bug 13645 pushed since 3.16. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 10:07:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 08:07:50 +0000 Subject: [Koha-bugs] [Bug 14374] dont use mysql_auto_reconnect with DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13645 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 [Bug 13645] DBIx connection needs to be cached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 10:07:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 08:07:50 +0000 Subject: [Koha-bugs] [Bug 13645] DBIx connection needs to be cached In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14374 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 [Bug 14374] dont use mysql_auto_reconnect with DBIx::Connector -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 10:16:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 08:16:57 +0000 Subject: [Koha-bugs] [Bug 14671] New: Allow correct translation of CAS authentication Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 Bug ID: 14671 Summary: Allow correct translation of CAS authentication Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org In authentication pages with CAS, the use of acronym or abbr tags does not allow a correct translation of the text. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7 It does not help a lot end users to know that CAS is Central Authentication Service, I think. Now one can custom the login page with NoLoginInstructions syspref to describe how to use the authentication. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 10:17:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 08:17:08 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5983 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 10:17:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 08:17:08 +0000 Subject: [Koha-bugs] [Bug 5983] Change the wording around the CAS login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14671 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 10:17:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 08:17:17 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 10:36:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 08:36:19 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 10:36:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 08:36:22 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 --- Comment #1 from Fridolin SOMERS --- Created attachment 41442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41442&action=edit Bug 14671 - Allow correct translation of CAS authentication In authentication pages with CAS, the use of acronym or abbr tags does not allow a correct translation of the text. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7 It does not help a lot end users to know that CAS is Central Authentication Service, I think. Now one can custom the login page with NoLoginInstructions syspref to describe how to use the authentication. This patch removes the use of acronym and abbr is authentication pages. Test plan (example with fr-FR locale) : - Without patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a " - Is is translated in : msgstr "Si vous avez un compte " - Apply patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a CAS account, %s please " - You can now translate it : msgstr "Si vous avez un compte CAS, %s veuillez " - Same test for intranet authentication page - Install the translation : cd misc/translator ; perl translate install fr-FR - Look at the result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 11:43:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 09:43:31 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 11:43:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 09:43:34 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41395|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen --- Created attachment 41443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41443&action=edit Bug 14652 - change gender specification from "N/A" to "None specified" To test: Edit a patron in the intranet, note that the gender options are "Female," "Male," and "None specified" Setting "None specified" should result in the gender not being shown on the patron detail page (unchanged functionality) In the opac, log in and click the "your personal details" tab, and note that the gender options are "Female," "Male," and "None specified" Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 13:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 11:22:28 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 --- Comment #19 from Katrin Fischer --- Still an issue - could we modify the script that adds the searchid to the URLs to not touch the OPAC link? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 13:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 11:43:59 +0000 Subject: [Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 --- Comment #4 from Yarik Dot --- (In reply to Tom?s Cohen Arazi from comment #2) > > I think the behaviour should be: > > - If the user passes DB parameters (user, pass, hostname, dbname), use them > to configure the instance. This needs more parameters to be added to > koha-create. hostname should default to 'localhost' if ommited. There is currently /etc/mysql/koha-common.cnf used right? Why to change this behavior? If there is nothing defined in here, default client configuration from /etc/mysql/my.cnf is used. Anyway, I am ok with changing this behaviour if the change is consistent. That means, there won't be 10 places where the database connection can be defined. > - If some of the new parameters is missing, fallback to what is configured > in /etc/koha/passwd. Why? That is why passwdfile is used, isn't it? > - If some of the relevant parameters is missing, fail loudly. Agree. ------- To explain more how we use it: first# koha-create --request-db mysql# mysql; CREATE DB ...; GRANT ...; first# koha-create --populate-db second# koha-create --use-db --passwdfile ./file (In reply to Tom?s Cohen Arazi from comment #3) > This is not enough, as the DB is still being created. Look at my previous > comment I have just double checked the koha-create script and database is only created when --create is used. It is on line 560 and nowhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 14:12:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 12:12:29 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 14:12:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 12:12:32 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41336|0 |1 is obsolete| | --- Comment #13 from Mirko Tietgen --- Created attachment 41444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41444&action=edit Bug 14470: Do not allow renew for on-site checkouts At the opac, the renew checkbox should not be displayed if it's an on-site checkout (same on the intranet). On the way, this patch adds a specific message to the intranet if the librarian try to renew an on-site checkout. Indeed before this patch a renew was allowed if the barcode was scanned. Test plan: 1/ Create an on-site checkout for a patron 2/ Confirm that the checkbox 'renew' is not displayed on the checkout list tables 3/ At the OPAC, the renew should not be allowed (no checkbox) 4/ Try to check the item out to the same patron, confirm that you get a specifig message to inform you the renew is not allowed for on-site checkouts. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 14:18:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 12:18:33 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #14 from Mirko Tietgen --- The display is not consistent. I observed: OPAC (opac-user.pl, column ?Renew?) before patch (if renewal allowed according to circ matrix): ?[checkbox] Renew (x of x renewals remaining)? before patch (if renewal not allowed): ?[no checkbox] Not renewable? after patch: [empty] Staff (Checkouts, tab ?Check out?, column ?Renew?) before patch (if renewal allowed): ?0? before patch (if renewal not allowed): ?0 Not renewable? after patch: ?0? OPAC should display no checkbox, but the message ?Not renewable?, as it does if renewal is not allowed for other reasons. Staff should display ?Not renewable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 14:25:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 12:25:27 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #7 from Mirko Tietgen --- (In reply to Fridolin SOMERS from comment #5) > => You see in URL that budget_id is empty : > /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id= > => you see in URL that budget_id is defined like in planning page : > > /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=2 Do you mean ?budget_period_id is empty/defined? (not budget_id) in both cases? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 14:51:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 12:51:45 +0000 Subject: [Koha-bugs] [Bug 1515] Circulation warns of outstanding fines when patron has credit on their account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1515 Deepak KV changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |deepakkv10 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 14:56:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 12:56:24 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mirko at abunchofthings.net --- Comment #4 from Mirko Tietgen --- I get an error when I try to apply the patch: > Applying: Bug 14484: Jonathan Druart's fix > fatal: sha1 information is lacking or useless (members/member-password.pl). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 14484: Jonathan Druart's fix It looks like the second patch modifies the first one, so 1) the first patch should not be obsoleted OR 2) the second one should be done against master without the first in between the second being the better option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 15:02:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 13:02:32 +0000 Subject: [Koha-bugs] [Bug 8779] .deb upgrade fails on incomplete instance setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8779 Yarik Dot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yarikdot at gmail.com --- Comment #1 from Yarik Dot --- Created attachment 41445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41445&action=edit Do not trigger update database when originalversion is not peresent. We are currently dealing with the same problem. Please find attached the patch. There is a check of $original_version before the migration is being executed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 15:05:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 13:05:08 +0000 Subject: [Koha-bugs] [Bug 14672] New: Payment is not able to done, when the patron has credit balance Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Bug ID: 14672 Summary: Payment is not able to done, when the patron has credit balance Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: deepakkv10 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 41446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41446&action=edit Error message I am not able to pay the patron fine from their credit amount. First I selected the fine from the 'Pay fine' tab(fine amount = 5, Credit amount = -600 , Total due = -595) then I clicked 'Pay selected' (It shows : Total amount outstanding = 5 and Collect from patron = 5) When I clicked 'Confirm' It shows an error 'You must pay a value less than or equal to -595.00' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 15:06:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 13:06:05 +0000 Subject: [Koha-bugs] [Bug 8779] .deb upgrade fails on incomplete instance setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8779 --- Comment #2 from Yarik Dot --- Created attachment 41447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41447&action=edit Don't upgrade the database when original version is not present. Sorry! The patch is incorrect! There is a problem in the condition. Please find a new one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 15:45:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 13:45:37 +0000 Subject: [Koha-bugs] [Bug 5609] Holds Rewrite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|koha.sekjal at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 16:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 14:15:11 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #3 from Joonas Kylm?l? --- Attachment 41295 uses client side checking for the whitespaces in the staff side password changing view. Shouldn't we change it to server side as it looks like all the other fields are checked that way. I think it would be more consistent. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 16:20:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 14:20:41 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #4 from Owen Leonard --- (In reply to Joonas Kylm?l? from comment #3) > Shouldn't we change it to server side > as it looks like all the other fields are checked that way. There are changes to the template and to opac-passwd.pl. To confirm, disable JavaScript and see if the server-side check is working correctly as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 16:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 14:21:19 +0000 Subject: [Koha-bugs] [Bug 14673] New: Renewals cause Sipserver to crash Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Bug ID: 14673 Summary: Renewals cause Sipserver to crash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Bug 13315 Changed the return of C4::Circulation::AddIssue to a hash reflecting the added issue ; However if AddIssue is called with the borrower currently having the item on loan a renewal is carried out nut as no issue is created in the db undef is returned rather than the issue structure. The same bug made the first thing the sipserver does is to extract the due_date from that non-existent structure causing a fatal error if it is a renewal. This is potentially a major bug as almost all self-issue units use checkout requests rather than renewal requests when renewing borrowers items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 16:31:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 14:31:39 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kim Gnerre changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kgnerre at hotchkiss.org --- Comment #128 from Kim Gnerre --- We're just going through the migration process but we currently have that feature with Innovative's Millenium and it is helpful when something is returned damaged or something like a dvd case is returned without the dvd inside. So, speaking for my Access Services Librarian, it would be a feature that we would be interested in having with our KOHA system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 16:40:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 14:40:47 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #5 from Joonas Kylm?l? --- (In reply to Owen Leonard from comment #4) > (In reply to Joonas Kylm?l? from comment #3) > > Shouldn't we change it to server side > > as it looks like all the other fields are checked that way. > > There are changes to the template and to opac-passwd.pl. To confirm, disable > JavaScript and see if the server-side check is working correctly as well. opac-passwd.pl is for the end user server side check, right? I disabled JavaScript in the staff side and there wasn't any check from the server side, it allowed to change the password (this was also mentioned in the test plan). So should we change the code so that it checks for the whitespaces in the server side when the password is changed from the staff view? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 16:59:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 14:59:51 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #370 from Tom?s Cohen Arazi --- Created attachment 41448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41448&action=edit Bug 6874: (QA followup) Warnings in about page This patch introduces checks on the about.pl page so the user is warned for a deficient configuration. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 17:00:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 15:00:22 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #371 from Tom?s Cohen Arazi --- Created attachment 41449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41449&action=edit Bug 6874: (QA followup) upload_path missing in koha-conf.xml.in Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 17:00:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 15:00:54 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #372 from Tom?s Cohen Arazi --- Created attachment 41450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41450&action=edit Bug 6874: (RM followup) DBIx updates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 17:16:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 15:16:32 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41371|0 |1 is obsolete| | --- Comment #6 from R?mi Mayrand-Provencher --- Created attachment 41451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41451&action=edit Bug12748 - Fixes duplicate serials with an "expected" status bug Added a new sub to Serials.pm to be able to get serials with their statuses. Now the sub ModSerialStatus checks for other serials with an "expected" status before doing anything. Also modified Serials.t to be able to test those changes. Test Plan 1) Apply patch 2) Run ./t/db_dependent/Serials.t 3) Validate that there are no errors 4) Go on "Serial collection information" page for a serial of your choice 5) Click on "Generate next" 6) Change the status of the original serial from "late" to "expected" 7) Change the newly generated serial from "expected" to "delete" 8) Validate that there are no new serials created by instruction 7 and that the serial was deleted 9) Run ./t/db_dependent/Serials.t With QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 17:23:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 15:23:52 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from R?mi Mayrand-Provencher --- (In reply to Jonathan Druart from comment #5) > R?mi, Could you please provide some tests for the changes you have done to > ModSerialStatus? Are those the tests you wanted to see? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 17:59:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 15:59:19 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #373 from Tom?s Cohen Arazi --- Feature pushed to master. Congratulations to everyone involved! Note: this is an early push of a working feature. It needs testing and followup bugs will be filled (at least by me) that will be blockers for the release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 18:00:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 16:00:15 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 18:00:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 16:00:39 +0000 Subject: [Koha-bugs] [Bug 14534] Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14534 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Ulrich! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 18:02:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 16:02:22 +0000 Subject: [Koha-bugs] [Bug 14674] New: koha-create should set upload_path in koha-conf.xml Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Bug ID: 14674 Summary: koha-create should set upload_path in koha-conf.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 18:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 16:02:29 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6874 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 [Bug 6874] Attach files to bibliographic records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 18:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 16:02:29 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14674 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 [Bug 14674] koha-create should set upload_path in koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 18:11:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 16:11:05 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #1 from Colin Campbell --- Created attachment 41452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41452&action=edit Proposed patch Not the most elegant solution, but this should allow renewals to proceed without causing 'Communications Error' at the client end -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 19:45:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 17:45:37 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #87 from Tom?s Cohen Arazi --- I'm sorry, but can u please rebase it? The updatedatabase.pl issue was trivial to solve, but such was not the case for the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 20:16:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 18:16:54 +0000 Subject: [Koha-bugs] [Bug 11325] Focus not on "Add Item" in Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11325 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- Patch pushed to master. Good one Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 20:17:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 18:17:21 +0000 Subject: [Koha-bugs] [Bug 13030] Show waiting hold expiration date for waiting holds on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #21 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 20:17:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 18:17:46 +0000 Subject: [Koha-bugs] [Bug 13853] Show waiting hold expiration date for waiting holds in holds ajax datatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13853 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 20:18:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 18:18:12 +0000 Subject: [Koha-bugs] [Bug 13485] Add a page to display links to restricted sites In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Simith, and everyone involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 20:36:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 18:36:48 +0000 Subject: [Koha-bugs] [Bug 13030] Show hold expiration date for waiting holds on circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show waiting hold |Show hold expiration date |expiration date for waiting |for waiting holds on |holds on circulation.pl |circulation.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 20:37:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 18:37:10 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 20:50:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 18:50:27 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 --- Comment #12 from Agnes Rivers-Moore --- We find the pop-up message that appears every time a barcode is scanned is distracting and hard on the eyes for staff at a busy checkout. Would prefer the option in system preferences to turn it off. I expect after staff have seen it a few times they may permanently get the message and it would not be needed any more. Also staff find checkout significantly slower from 3.14 to 3.20 - this may not be the only factor, but I would prefer to be able to turn off any features that might affect response time of system and of staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 22:24:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 20:24:22 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #18 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 22:26:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 20:26:25 +0000 Subject: [Koha-bugs] [Bug 14534] Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14534 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 22:29:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 20:29:29 +0000 Subject: [Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 --- Comment #13 from Chris Cormack --- (In reply to Agnes Rivers-Moore from comment #12) > We find the pop-up message that appears every time a barcode is scanned is > distracting and hard on the eyes for staff at a busy checkout. > Would prefer the option in system preferences to turn it off. > I expect after staff have seen it a few times they may permanently get the > message and it would not be needed any more. > Also staff find checkout significantly slower from 3.14 to 3.20 - this may > not be the only factor, but I would prefer to be able to turn off any > features that might affect response time of system and of staff. Hi Agnes Once a bug is pushed, the best thing to do is to open a new bug, and link to this one. Or your comment will be missed. (This is marked pushed to stable, so it wont be showing up on anyone's lists to check) Hope this make sense. I do agree, the ajax circ stuff is slower, unless you have a borrower with a large amount of existing checkouts. I think there may be some bugs around the speed issue already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 23:38:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 21:38:46 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|3.18 |master CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- A workaround for paying single lines of fines is using the 'pay' button - but this needs to be fixed to pay multiple selected fines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 23:47:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 21:47:41 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #116 from Christopher Davis --- Created attachment 41453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41453&action=edit Step 26: Error message when all checkboxes are cleared I hope this helps :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 11 23:50:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Aug 2015 21:50:18 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Christopher Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #117 from Christopher Davis --- Please see the 2015-08-11 attachment for an error message which is displayed when all of the check boxes described in step 26 of the test plan are cleared/unchecked. Christopher Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 02:34:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 00:34:34 +0000 Subject: [Koha-bugs] [Bug 13178] cardnumber field length is too short In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Brendon Ford changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendon.ford at manhattan.edu --- Comment #3 from Brendon Ford --- We are also having an issue with the 16 digit character limit. Our card readers output a trailing equals sign and then send a backspace keystroke to remove it when swiping a card. Since our card numbers are 16 digits the equals sign never gets typed into the field and the backspace removes the last digit of the card number. We can't reprogram the card readers because it would leave the equals sign in other fields that we swipe card numbers into. We are currently using a bit of javascript to extend the maxlength, but it would be great to see the character limit extended. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 04:40:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 02:40:12 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #111 from Aleisha Amohia --- Also could be a good idea to fix the title in the metadata - at the moment it says Waitaki District Libraries catalog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 04:54:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 02:54:10 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-JPHKQjIqqx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 04:54:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 02:54:30 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-HUKSzAbiqR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 --- Comment #5 from Aleisha Amohia <aleishaamohia at hotmail.com> --- Created attachment 41454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41454&action=edit Bug 14484: warns when changing patron pw To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 04:54:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 02:54:53 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-jSw33klVW8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 05:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 03:36:42 +0000 Subject: [Koha-bugs] [Bug 14675] New: Updating personal details on OPAC - request sent even if no changes are made Message-ID: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 Bug ID: 14675 Summary: Updating personal details on OPAC - request sent even if no changes are made Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Rather than saying that the user's updates have been submitted when they haven't made any, it should take them back to the details page and there should be a pop-up that says "No changes were made". More accurate message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 06:28:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 04:28:56 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-R5aAXl4Mnc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #112 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 41455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41455&action=edit Bug 8753 - [followup] fix error when no information is provided To test: All normal checks plus make sure that a nice error is displayed when no data is provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 06:31:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 04:31:09 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-mGZqG41qcs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #113 from Liz Rea <liz at catalyst.net.nz> --- I wasn't able to replicate Aleisha's 2nd issue, it may be a local issue to her environment. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 06:31:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 04:31:20 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-WNd1J9H4WP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 07:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 05:17:47 +0000 Subject: [Koha-bugs] [Bug 14585] Fixing up the online help on main page In-Reply-To: <bug-14585-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14585-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14585-70-rnAEleVdD4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14585 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |cnorthcott.work at gmail.com --- Comment #2 from cnorthcott.work at gmail.com --- Patched applied cleanly, signing off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 08:35:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 06:35:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-CXexkIaDTY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #114 from Aleisha Amohia <aleishaamohia at hotmail.com> --- Signing off! Works for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 10:05:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 08:05:26 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-LzMWzWcPxv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #374 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Tom?s Cohen Arazi from comment #373) > Feature pushed to master. > > Congratulations to everyone involved! > > Note: this is an early push of a working feature. It needs testing > and followup bugs will be filled (at least by me) that will be blockers > for the release. Patches for bug 14321 forthcoming ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 10:34:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 08:34:39 +0000 Subject: [Koha-bugs] [Bug 12965] can create an item type that already exists In-Reply-To: <bug-12965-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12965-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12965-70-9M7gpSqlaw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12965 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40942|0 |1 is obsolete| | --- Comment #4 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41456&action=edit Bug 12965: Prevent to erase an existing item type On creating an item type, if it already exists, it will replace the existing one. This patch prevent that and display a message to the interface. Note: The fields are lost. Test plan: 1/ Create an item type 'AAA', description 'AAA' 2/ Edit it, update the description with 'BBB' 3/ Create an item type 'AAA' with a description 'CCC' => you should get a warning "already exists". Works well, no errors Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com> Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 11:07:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 09:07:22 +0000 Subject: [Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-ESRpCtcONH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41125|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41457&action=edit Bug 14589: Replace fetch CGI::Cookie calls This patch is inspired by the change in bug 14588. It replaces the indirect object syntax for CGI::Cookie. Some trivial corrections are made to authorities/merge_ajax.pl just as bug 14588 does for cataloguing. Test plan: Run the URL authorities/merge_ajax.pl in staff. Upload a file with Stage MARC records for import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 11:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 09:07:46 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-KAXpt1f6mZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14588, 14589 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 [Bug 14588] Simplify merge_ajax.pl http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 [Bug 14589] Replace fetch CGI::Cookie calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 11:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 09:07:46 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-7yqtGG4RS0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14321 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 11:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 09:07:46 +0000 Subject: [Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-T4mlYaBnzZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14321 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 11:08:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 09:08:44 +0000 Subject: [Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-3tj8iyelrI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Rebased on top of 6874. I need this (trivial) patch for 14321. Please add your (easy) signoff.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 13:18:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 11:18:36 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14661-70-xDq2iea7Ke@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 --- Comment #8 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41458&action=edit Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines Signed-off-by: Heather Braum <hbraum at nekls.org> Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 13:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 11:30:35 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-IA9yPbkH8c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Marcel de Rooy from comment #1) > ... (Note that > Class::->method is preferred above Class->method. See perlobj.) http://perldoc.perl.org/perlobj.html#Invoking-Class-Methods Interesting. I did not know this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 13:41:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 11:41:25 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14584-70-B089RcVpil@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 13:50:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 11:50:10 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-J8av6iuETd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Mirko Tietgen <mirko at abunchofthings.net> --- Sorry, but the new attachment looks the same as the one before (and I get the same error) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 14:10:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 12:10:39 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13906-70-J2I3Sk2LKe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 --- Comment #11 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41459&action=edit Bug 13906 - (follow-up) Add SystemPreferenceFactory (TestObjectFactory) This follow-up adds SystemPreferenceFactory into TestObject Factories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 14:12:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 12:12:41 +0000 Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: <bug-14562-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14562-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14562-70-rBz3LAqxRd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #4 from Mirko Tietgen <mirko at abunchofthings.net> --- Can't reproduce on 3.18.9. I do a search for 't', then filter the results by search type or category. One of the patrons has an empty card number. Works for me. Anything else I should try? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 14:15:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 12:15:20 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-NH6B0EohSA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #7 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41460&action=edit Bug 14536: (follow-up) Add Memberentry PageObject and navigations This follow-up adds Memberentry PageObject and adds navigations to memberentry page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 14:17:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 12:17:40 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-An97iDi1LE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 --- Comment #1 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41461&action=edit Bug 14620 - Contact information validations I'm thinking we should centralize all patron's contact information validators into one module. Currently we only have validations for e-mail addresses, using the Email::Valid module. In our local library we also want to validate phone numbers with a regex that only recognizes phone numbers from my country. So I suggest we create a phone number validation as well, with an option to easily create custom regex for your local use. If a library does not wish to use validations, we should give them an option to turn them off. If more local validators are implemented, we should also give the library an option to select which validator they wish to use. With this method we could implement phone number validators from around the world and add them into our module. Then we would make the validations simply by calling our validator. The validator would know by system preference which one of the implemented phone number validators it should use. Validations should be both client and server side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 14:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 12:31:28 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-xKCX5thD9O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14620 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 [Bug 14620] Contact information validations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 14:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 12:31:28 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-G9dFcYDsMX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14536 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 15:08:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 13:08:14 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-8Ui7C3pY7y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 --- Comment #2 from Lari Taskula <larit at student.uef.fi> --- (In reply to Lari Taskula from comment #1) > Created attachment 41461 [details] [review] > Bug 14620 - Contact information validations > Centralizes email and phone number validations into Koha::Validation. Adds two new system preferences, 'ValidateEmailAddress' and 'ValidatePhoneNumber', which determine whether to use the validations or not. Email address validation uses Email::Valid module introduced in Bug 5685. Email can be verified via Koha::Validation::validate_email("email at address.com"). Phone number validation uses regex to validate phone numbers. The system preference, ValidatePhoneNumber, let's you define which regex you want to use. In the patch there is two different phone number validators implemented, (international and Finnish). Anyone can easily create their own regex for his local use. Validations are both client- and server-side. The following test plan applies to memberentry.pl, opac-memberentry.pl and opac-messaging.pl. Test plan: 1. Apply the patch (and run updatedatabase.pl). 2. Set system preferences ValidateEmailAddress to "Enable" and ValidatePhoneNumber to "International Phone Numbers". 3. Navigate to edit user contact informations in Staff client and OPAC. 4. Make sure JavaScript is enabled. 5. Insert invalid email (e.g. "invalid") and invalid phone number ("+123invalid") and send the form. 6. Confirm that form will not be submitted and errors will be given. 7. Disable JavaScript. 8. Try sending the form again. 9. Confirm that form will be submitted but errors will be given on top of the form. 10. Observe that none of the changes are accepted. 11. Set system preferences ValidateEmailAddress to "Disable" and ValidatePhoneNumber to "none". 12. Repeat step 3-9 but observe that errors will not be given and changes will be submitted and saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 15:12:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 13:12:20 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-jBrGS8NCok@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Alan <aschrock at eunc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aschrock at eunc.edu --- Comment #48 from Alan <aschrock at eunc.edu> --- Hi All, When do you anticipate this being available for use? We had used the command line tool in the past, so now are in a mode of manual uploads until this is ready. Thanks for all of the work you are doing! Alan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 15:28:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 13:28:53 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-rD5kowjJ5P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 15:28:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 13:28:55 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-PP77TDg58W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41126|0 |1 is obsolete| | --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41462&action=edit Checked the code, looks good to me. I didn't notice any changes in the behaviour of the merge functionality. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 16:31:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 14:31:49 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11371-70-CvsBoUI1dM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 R?mi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37010|0 |1 is obsolete| | --- Comment #20 from R?mi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> --- Created attachment 41463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41463&action=edit Add a new report : Orders by budget This patch adds the "Orders by budget" report to the reports page. This report can generate the list of all orders on a specific budget. The "All budgets" and "All active budgets" options are also available to have different views of all your orders. A "[i]" is also added before the names of inactive budgets in the budget selection box. How to test: Go to Home > Reports > Orders by budget Select one or all budgets Output to Scrren or CSV file Set a budget to inactive Verify that this budget is marked wit [i] in drop down list (Filters) Sponsored-by: ccsr http://bugs.koha-community.org/show_bug.cgi?id=11371 Signed-off-by: Nicole Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 16:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 14:32:02 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11371-70-9VQ4zKEKQK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 R?mi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37011|0 |1 is obsolete| | --- Comment #21 from R?mi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> --- Created attachment 41464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41464&action=edit Bug11371 - QA fix http://bugs.koha-community.org/show_bug.cgi?id=11371 Signed-off-by: Nicole Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 16:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 14:34:16 +0000 Subject: [Koha-bugs] [Bug 11371] Add a new report : Orders by budget In-Reply-To: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11371-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11371-70-VcLCFd6m47@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 R?mi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |remi.mayrand-provencher at inL | |ibro.com Status|Failed QA |Needs Signoff --- Comment #22 from R?mi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com> --- Fixed Conflicts in first patch and updated QA fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 16:59:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 14:59:34 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-Bi8vSrui7j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Joonas Kylm?l? from comment #3) > Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> Thx Joonas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 17:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 15:11:32 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-9FjkuZGfHy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Christopher Davis <mr.cataloger at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mr.cataloger at gmail.com --- Comment #129 from Christopher Davis <mr.cataloger at gmail.com> --- Dear Colleagues, I am new to Bugzilla, so I hope that this comment will not overstep my bounds. In my opinion, this bug is a slippery slope on the mountain of professional ethics. I would rather error on the side of patron privacy and confidentiality than I would on the side of trying to recuperate lost or damaged items. If we say that we anonymize patron data, then we should go all the way without exception. FWIW, Christopher Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 17:12:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 15:12:00 +0000 Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices. In-Reply-To: <bug-12353-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12353-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12353-70-WGzaUQDsaY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Christopher Davis <mr.cataloger at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mr.cataloger at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 18:37:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 16:37:18 +0000 Subject: [Koha-bugs] [Bug 2443] Acquisitions by EDIFACT In-Reply-To: <bug-2443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2443-70-3nfhF7AMGU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2443 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |kyle.m.hall at gmail.com Status|NEW |RESOLVED --- Comment #8 from Kyle M Hall <kyle.m.hall at gmail.com> --- *** This bug has been marked as a duplicate of bug 7736 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 18:37:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 16:37:18 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-UPquQiKsIm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #120 from Kyle M Hall <kyle.m.hall at gmail.com> --- *** Bug 2443 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 19:56:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 17:56:02 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10468-70-G1vrrBsw2N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 20:21:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 18:21:17 +0000 Subject: [Koha-bugs] [Bug 14592] Export data bad encoding In-Reply-To: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14592-70-u9LNdAQCzR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 20:21:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 18:21:20 +0000 Subject: [Koha-bugs] [Bug 14592] Export data bad encoding In-Reply-To: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14592-70-ZuPj1J192g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41129|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41465&action=edit [SIGNED OFF] Bug 14592: Export data bad encoding Tools > Export data produces a file badly encoded, when marc/xml file format is chosen. It works with CSV. To test: 1. Tools > Export data 2. Choose a limited interval of biblionumber 3. Export in marc/xml/csv. 4. Check files exported at 3: csv file is ok. marc/xml files are corrupted, ie badly encoded. 5. Apply the patch 6. Repeat steps 3&4, and confirm that all file formats are valid. Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 20:23:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 18:23:00 +0000 Subject: [Koha-bugs] [Bug 14592] Export data bad encoding In-Reply-To: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14592-70-3hwJ4lKgT1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |major CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Good catch Frederic. Even if the patch is trivial, I find the problem a big deal, libraries here are used to export their catalogs for sending to union catalogs and this bug is really nasty for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 21:04:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 19:04:44 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-XSXv9BHNfx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Chris Nighswonger <cnighswonger at foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u --- Comment #2 from Chris Nighswonger <cnighswonger at foundations.edu> --- Nice improvements, Liz. I'd like to see these applied to the patron card tool in conjunction with this to keep the interfaces similar in look and feel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 21:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 19:15:11 +0000 Subject: [Koha-bugs] [Bug 14295] Add creation time, size and owner for uploaded files In-Reply-To: <bug-14295-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14295-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14295-70-2evcV4hIJZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14295 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 21:15:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 19:15:42 +0000 Subject: [Koha-bugs] [Bug 14296] Introduce upload settings, add quota and translate alerts In-Reply-To: <bug-14296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14296-70-eRIF5p4xCH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 21:23:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 19:23:57 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-O2yFLfShFC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Chris Nighswonger <cnighswonger at foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 21:32:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 19:32:13 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-JwsEjXxhjT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Chris Nighswonger <cnighswonger at foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41438|0 |1 is obsolete| | --- Comment #3 from Chris Nighswonger <cnighswonger at foundations.edu> --- Created attachment 41466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41466&action=edit [Signed off] Bug 14667 - UI/UX improvements for the Label creator Note: It would be good to adopt these same changes in the Patron Card creator for consistency and push them in conjunction with these changes. -Chris_n Reasoning Librarians will be doing label things in the following frequencies, from most frequent to least frequent: 1. Creating new label batches - every day/every few days 2. Managing existing label batches - every day/every few days 3. Managing existing label layouts - as needed, infrequent 5. Managing existing label templates - as needed, infrequent 6. Creating new label layouts - as needed, infrequent 7. Creating new label templates - as needed, infrequent 8. Managing existing printer profiles - possibly once only! 9. Creating new printer profiles - possibly once only! This change to the label creator aims to make the most frequently used items easily accessible at the top of the main area, reduces clutter on the page, and makes the label creator fall in line with UI paradigms found elsewhere in Koha. To test: Open the label creator: More -> Tools -> Label creator Note that the toolbar has changed. It should be consistent across all of the label creator (it is an include). + New menu: Label batch 1. make sure it looks ok - toolbar buttons are consistent at the top of the main block. 2. add items both by barcode, and by search (note this patch does not touch the pop up window. Another day.) 3. note that the usual buttons have moved below the textarea, and now have icons. 4. delete and export single items using the buttons corresponding to each item 5. select multiple and use the buttons above the table to remove and export selected items 6. export a full batch 7. deduplicate a batch There should be no regressions in functionality. Layout 1. This menu item should take you directly to the "Edit layout" screen. 2. no functional changes here. 3. note toolbar at top is consistent Label template 1. this menu item should take you directly to the "Edit label template" page. 2. no functional changes here. 3. note toolbar at top is consistent. Printer profile 1. this menu item should take you directly to the "Edit printer profile" page. 2. no functional changes here. 3. note toolbar at top is consistent. + Manage menu: Label batches 1. This menu item should take you directly to the "currently available batches" page. 2. select a batch to edit using the buttons 3. select a batch to delete using the buttons - it should ask for confirm. 4. select several batches using the tickboxes, and select Export selected. Batches should be exported as normal. 5. note toolbar at top is consistent. Layouts 1. This menu item should take you directly to the "currently available layouts" page. 2. select a layout to edit using the buttons 3. select a layout to delete using the buttons 4. note toolbar at top is consistent. Label templates 1. This menu item should take you directly to the "currently available templates" page. 2. select a template to edit using the buttons 3. select a template to delete using the buttons 4. note toolbar at top is consistent. Printer profiles 1. This menu item should take you directly to the "currently available profiles" page. 2. select a profile to edit using the buttons 3. select a profile to delete using the buttons 4. note toolbar at top is consistent + General * note that sidebar now only has "labels home" instead of the full "manage" list. It seemed redundant with the toolbar tidied up. Please note that I am happy to take suggestions/amendments to these changes. Signed-off-by: Chris Nighswonger <cnighswonger at foundations.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 21:50:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 19:50:23 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-fQq2GaF7f1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #130 from Nick Clemens <nick at quecheelibrary.org> --- My consortium sponsored this development, and it has taken some time to progress it this far forward. If MySQL performance is the only blocker right now I would really like to see a solution that addresses that and unsticks the bug rather than requiring a rewrite of the feature. I played around with the query and the below, while still containing a NOT IN, eliminates the GROUP BY and improves speed significantly: if ( C4::Context->preference('StoreLastBorrower') ) { # Do not delete the newest old_issue for any itemnumber $query .= " AND issue_id NOT IN ( SELECT issue_id FROM (Select oi.issue_id from old_issues oi LEFT OUTER JOIN old_issues oi2 ON oi.itemnumber=oi2.itemnumber AND oi2.issue_id>oi.issue_id WHERE oi.borrowernumber= ? AND oi2.borrowernumber IS NULL) AS oi ) "; push @bind_params, $borrowernumber; Another option is to just use the query labeleed as 'oi' above in a separate update. It effectively finds all the 'last returned' info for a borrower and would allow you to mark those somehow (say invert borrower number to negative of borrowernumber) then perform the regular anonymizing, and then update any rows with a negative borrowrnumber to a positive borrowernumber (or whatever marker was used) I think Chris's comment #129 has been addressed, the feature is optional (syspref) and gives a big warning to the patron when it is enabled for full transparency. And I don't think sharing your opinion is overstepping :-) If the above queries don't work, a new table could work, though I do wonder about the redundancy. I wonder if it would be possible to use the 'return' column in old_issues to mark 'lastreturned' or something similar to allow for easy SQL selection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 22:06:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 20:06:51 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14517-70-beztLjhHe7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Can I get a rebase please Applying: Bug 14517: List shelves list is broken for translated interfaces fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 14517: List shelves list is broken for translated interfaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 22:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 20:27:57 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-rcM2notZZT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #131 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx you all for sharing your opinions and commenting! Chris D. - you didn't overstep at all - please keep commenting on bugzila :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 22:41:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 20:41:00 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-axkFjopWhO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #132 from Chris Rohde <crohde at roseville.ca.us> --- Another point to make is that if a library is using RFID/AMH (Automated Materials Handling), the materials are checked in before anyone has a chance to catch damages. We don't charge for damages, unless an item is completely unusable. However, when items such as a storytime kit go in, it jams the sorter. In our case, we offer the anonymization option to our patrons, to honor their privacy choice. I'd be fine with using a timestamp on the lastpatron table, and a chron job which slides along datewise, deleting returns older than 'x' days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 22:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 20:43:29 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-xMZgUISZ6T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #133 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to Christopher Davis from comment #129) > Dear Colleagues, > > I am new to Bugzilla, so I hope that this comment will not overstep my > bounds. In my opinion, this bug is a slippery slope on the mountain of > professional ethics. I would rather error on the side of patron privacy and > confidentiality than I would on the side of trying to recuperate lost or > damaged items. If we say that we anonymize patron data, then we should go > all the way without exception. > I agree with this, I think we should be aiming to have Koha being the most privacy respecting system that exists. And that we should treat privacy issues like we treat security ones. They are the same thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 22:49:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 20:49:08 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-K2sHqLRf32@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #134 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Chris Cormack from comment #133) > (In reply to Christopher Davis from comment #129) > > Dear Colleagues, > > > > I am new to Bugzilla, so I hope that this comment will not overstep my > > bounds. In my opinion, this bug is a slippery slope on the mountain of > > professional ethics. I would rather error on the side of patron privacy and > > confidentiality than I would on the side of trying to recuperate lost or > > damaged items. If we say that we anonymize patron data, then we should go > > all the way without exception. > > > I agree with this, I think we should be aiming to have Koha being the most > privacy respecting system that exists. And that we should treat privacy > issues like we treat security ones. They are the same thing. It should not be Koha's job to enforce privacy rules. Rules come and go, and vary from place to place. It should be a system preference, not something forced by the system. Koha needs to be able to handle multiple scenarios. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 22:53:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 20:53:48 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-flKn1ym3z5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #135 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to Christopher Brannon from comment #134) > > It should not be Koha's job to enforce privacy rules. Rules come and go, > and vary from place to place. It should be a system preference, not > something forced by the system. Koha needs to be able to handle multiple > scenarios. > I'm saying the default should be privacy, and you have to opt in to not respecting privacy as a conscious choice. Which I think the suggestion of having a cron to delete it after x days, is a workable compromise. The system does of course have to enforce it, but I agree with you that if a library wants to opt out of respecting privacy, they can do that by turning on the system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 23:51:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 21:51:59 +0000 Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: <bug-14562-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14562-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14562-70-K8xKeEiYrs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 --- Comment #5 from Jesse Weaver <jweaver at bywatersolutions.com> --- This error only occurs when you don't click on a first letter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 23:55:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 21:55:50 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14517-70-1aqHAuViJJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40994|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 41467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41467&action=edit Bug 14517: List shelves list is broken for translated interfaces The translation script adds quotes ("") around translated string (Edit for instance). Which breaks the json structure. Example: "dt_action": "<a style=\"cursor:pointer\"><form action='shelves.pl' method='get'><input class="editshelf" value="Editar" type="submit" /></form></a>" Test plan: 1/ On the staff interface create a private list 2/ Go to More > Lists ('Your lists' tab) 3/ Translate the templates to any language like: $ cd misc/translator/ $ perl translate install es-ES 4/ Enable the translated templates on the sysprefs 5/ Switch to the translated language 6/ Go to the lists page (Mas > Listas in es-ES) The list should be displayed correctly. Note: There is a limitation. If a translated string contains a simple quote ('), it will also break the json. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 12 23:55:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 21:55:47 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14517-70-WfSusn87JA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 00:00:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 22:00:21 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14517-70-JKoGcU7Mqf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 --- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> --- I just noticed that our To plugin, we just use to do JSON .. In future we could maybe use this? But this is a just a comment. No reason to hold the bug http://search.cpan.org/~nuffin/Template-Plugin-JSON-0.06/lib/Template/Plugin/JSON.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 00:02:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 22:02:27 +0000 Subject: [Koha-bugs] [Bug 13022] Hardcoded limit causes records with more than 20 items to show inaccurate statuses In-Reply-To: <bug-13022-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13022-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13022-70-X53cWZ6n5o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13022 jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 00:35:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 22:35:16 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-kc3Vq38ovV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #4 from Liz Rea <liz at catalyst.net.nz> --- Hi Chris, That is a good point, I'll put it on my list of pet projects, because yeah, that part needs updating too. There are lots of places that need love. :) I wonder, could you help out with one thing though - the table headers are untranslatable at the moment, if you have some time could you have a look at that, or give me some hints as to how that could be done in a translatable way? Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 00:43:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 22:43:31 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-IlQ4xUSet9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 00:43:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 22:43:52 +0000 Subject: [Koha-bugs] [Bug 7627] Editing of invoice number In-Reply-To: <bug-7627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7627-70-TTJdsvQRD2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7627 Suzanne Fayle <sfayle at roseman.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 00:44:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 22:44:48 +0000 Subject: [Koha-bugs] [Bug 14676] New: UI/UX enhancements for the patron card creator Message-ID: <bug-14676-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Bug ID: 14676 Summary: UI/UX enhancements for the patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org This interface could use the same kind of love that the label creator is getting, as it has a similar UI structure to the label creator tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 00:45:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 22:45:25 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-GzaWTjc7DR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #5 from Heather Braum <hbraum at nekls.org> --- I'll be taking a look at this -- because this area definitely needed some love. And +1 on overhauling the patron card creator, including taking on bug 12804, please! Looking forward to looking at it, Liz. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 00:48:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 22:48:20 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: <bug-14676-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14676-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14676-70-efky6Sq6Ns@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |wizzyrea at gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 00:49:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Aug 2015 22:49:06 +0000 Subject: [Koha-bugs] [Bug 12804] Patron card creator search should have a branch dropdown option In-Reply-To: <bug-12804-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12804-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12804-70-euJhl9fGfZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12804 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 02:27:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 00:27:25 +0000 Subject: [Koha-bugs] [Bug 5153] Patron Import tool does not show progress of upload In-Reply-To: <bug-5153-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5153-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5153-70-9S3945r2my@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5153 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 02:28:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 00:28:56 +0000 Subject: [Koha-bugs] [Bug 8291] patron import should show error names In-Reply-To: <bug-8291-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8291-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8291-70-F4bUwYsmAj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8291 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #1 from Heather Braum <hbraum at nekls.org> --- +1 for this bug. I ran into this situation this evening: 201 imported records (last was {last patron info}) 1079 overwritten (last was {last patron info}) 0 not imported because already in borrowers table and overwrite disabled 4 not imported because they are not in the expected format (last was {last patron info}) 1284 records parsed What were the 4 that weren't overwritten/loaded? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 06:25:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 04:25:06 +0000 Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays() In-Reply-To: <bug-14522-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14522-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14522-70-OYPL9DApGk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Bob Birchall <bob at calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 09:05:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 07:05:57 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: <bug-14641-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14641-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14641-70-FK6LB3tsT3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #2 from Joonas Kylm?l? <j.kylmala at gmail.com> --- The warning is triggered when get_letter_loop() is called without an argument. We should maybe check if @_ is true, and if it's not then use $_ or "" as the value? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 09:30:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 07:30:53 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-GsUI5s0MLF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #136 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Nick Clemens from comment #130) > My consortium sponsored this development, and it has taken some time to > progress it this far forward. If MySQL performance is the only blocker right > now I would really like to see a solution that addresses that and unsticks > the bug rather than requiring a rewrite of the feature. > > I played around with the query and the below, while still containing a NOT > IN, eliminates the GROUP BY and improves speed significantly: > if ( C4::Context->preference('StoreLastBorrower') ) { > # Do not delete the newest old_issue for any itemnumber > $query .= " AND issue_id NOT IN ( SELECT issue_id FROM (Select > oi.issue_id from old_issues oi LEFT OUTER JOIN old_issues oi2 ON > oi.itemnumber=oi2.itemnumber AND oi2.issue_id>oi.issue_id WHERE > oi.borrowernumber= ? AND oi2.borrowernumber IS NULL) AS oi ) "; > push @bind_params, $borrowernumber; I haven't tested if this works, but I am hopeful it does and improves speed. > Another option is to just use the query labeleed as 'oi' above in a separate > update. It effectively finds all the 'last returned' info for a borrower > and would allow you to mark those somehow (say invert borrower number to > negative of borrowernumber) then perform the regular anonymizing, and then > update any rows with a negative borrowrnumber to a positive borrowernumber > (or whatever marker was used) This seems a bit hacky... but doesn't mean it couldn't work. > If the above queries don't work, a new table could work, though I do wonder > about the redundancy. I wonder if it would be possible to use the 'return' > column in old_issues to mark 'lastreturned' or something similar to allow > for easy SQL selection. Hm not sure how the return could be used - can you explain? Kyle, could you take a look at these options? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 09:41:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 07:41:37 +0000 Subject: [Koha-bugs] [Bug 14585] Fixing up the online help on main page In-Reply-To: <bug-14585-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14585-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14585-70-h8gfEiAqTy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14585 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41115|0 |1 is obsolete| | --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41468&action=edit Bug 14585: Fixing up online help on main page Fixes look good to me. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 11:00:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 09:00:31 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-zFinQuuNfL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Phone number validation still accepts trailing (and I think also leading) whitespaces. Didn't figure out any fix to this yet, so if anyone has ideas of how to fix this, they're welcome! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 13:44:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 11:44:08 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-zJ90fu6DYH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 --- Comment #4 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41469&action=edit Bug 14620 - Whitespace fix for validations This fix trims emails and phone numbers just before form is sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 14:10:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 12:10:48 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-MlOJmbEMxp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41469|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 14:26:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 12:26:54 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-WmMbVxCKjZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 --- Comment #5 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41470&action=edit Bug 14620 - Whitespace fix for validations This fix trims emails and phone numbers just before form is sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 14:29:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 12:29:22 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-AIKmlpKcY9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41470|0 |1 is obsolete| | --- Comment #6 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41471&action=edit Bug 14620 - Whitespace fix for validations This fix trims emails and phone numbers just before form is sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 14:55:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 12:55:35 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-yW6evs909d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41471|0 |1 is obsolete| | --- Comment #7 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41472&action=edit Bug 14620 - Whitespace fix for validations This fix trims emails and phone numbers just before form is sent. Fixes the invalid syntax used in JQuery's .on() functions' argument. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 15:11:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 13:11:43 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-BNXC2MMMsi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #6 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Liz Rea from comment #4) > Hi Chris, > > That is a good point, I'll put it on my list of pet projects, because yeah, > that part needs updating too. There are lots of places that need love. :) And don't forget manual re-writes to match the new interface... ;-) > > I wonder, could you help out with one thing though - the table headers are > untranslatable at the moment, if you have some time could you have a look at > that, or give me some hints as to how that could be done in a translatable > way? I implemented DT in both of these sections before (IIRC) it was implemented in Koha generally. I'm not sure what mechanism is currently used, but probably the code would need to be refactored to match what's presently being done other places. I'm pretty much unfamiliar with how that is, so I'll not be much help there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 17:10:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 15:10:52 +0000 Subject: [Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-ExKydaLYjy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41473&action=edit Bug 11229: (regression tests) makepayment and makepartialpayment should log correctly This patch introduces tests for makepayment and makepartialpayment to check they are correctly logging to the statistics table. To test: - Run $ prove t/db_dependent/Accounts.t => FAIL: tests fail because statistics are not correctly logged. Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 17:11:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 15:11:06 +0000 Subject: [Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-NkQvRdqK4L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39971|0 |1 is obsolete| | --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41474&action=edit Bug 11229: makepayment doesn't log branch in statistics correctly This patch fixes makepayment() so it correctly logs the branch code to the statistics table. To test: - Run (with the regression tests applied) $ prove t/db_dependent/Accounts.t => FAIL: makepayment() tests fail because logging is wrong - Apply the patch - Run $ prove t/db_dependent/Accounts.t => SUCCESS: tests for makepayment now pass (Note: makepartialpayment tests still fail as they need the next patch) Original commit message relying on the UI to test: There are several ways of paying fines, not all of them recorded the branch the payment was made at correctly: 1) Pay button next to an individual fine 2) Checkbox + pay amount 3) Checkbox + pay selected For each of those, check if the payment registered in the table statistics contains the branchcode before and after the patch. The patch should fix 1). 2) and 3) are ok with and without the patch. Important: Don't change the amount, pay individual fines. Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> Note: i fixed the commit message, because this is a fix for makepayment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 17:11:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 15:11:17 +0000 Subject: [Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-dfwwff8hoE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41475&action=edit Bug 11229: (followup) makepartialpayment fix makepartialpayment() wasn't logging the branch either. This patch fixes that too. To test: - Run (with the regression tests applied) $ prove t/db_dependent/Accounts.t => FAIL: tests fail because makepartialpayment is not logging the branch code - Apply the patch - Run $ prove t/db_dependent/Accounts.t => SUCCESS: tests pass - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 17:13:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 15:13:00 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-YmlTmrfOXK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|Payments wrongly saved in |makepayment and |Statistics table by |makepartialpayment |C4::Accounts::makepartialpa |(C4::Accounts) don't log |yment and makepayment |branch to statistics table Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:01:45 +0000 Subject: [Koha-bugs] [Bug 14677] New: Inventory: Compare Barcodes List to Result function Message-ID: <bug-14677-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14677 Bug ID: 14677 Summary: Inventory: Compare Barcodes List to Result function Change sponsored?: --- Product: Koha Version: 3.20 Hardware: PC OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kleinpastec at xenos.org QA Contact: testopia at bugs.koha-community.org I am trying to use the "Compare Barcodes List to Result" function in Koha 3.20. From my understanding, this should compare the list of barcodes that I scan from the shelf to the shelf list of what should be there and will let me know of any misshelved books. However, when I check the box for this function, it creates the following error message: Software error: Can't locate object method "ymd" via package "dateformat" (perhaps you forgot to load "dateformat"?) at /usr/share/koha/lib/Koha/DateUtils.pm line 206, <fh00001barcode test 2.txt> line 91. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. Here is what I am doing: Log into the staff client. Click "Tools" Click "Inventory/stocktaking" Choose a file to upload (I'm using a .txt file with 90 real book barcodes in order, skipping one book on the shelf, having one book out of order, and scanning one ISBN instead of our barcode to make sure it catches all issues) Set inventory date to: current date Select "Home Library" For Library, choose Main Campus (Our branch) Do not select a shelving location For Item callnumber between ...and enter "300" and "400" (Dewey decimal segment that I pulled these barcodes out of so it isn't searching the entire catalog) Do not select any Item statuses Inventory date: current date Select "skip items on loan" "export to csv file" and "compare barcodes list to results" Click "Submit" We have found through experimenting that the only options that impact this error message are the ones under items.notforloan. If you have one of these selected, it creates the report, but nothing is different about it than if you don't have "compare barcodes" selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:08:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:08:23 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-hfEyQaERQs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #118 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 41476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41476&action=edit Bug 11559: (followup) Fix error when all servers are deselected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:34:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:34:21 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12772-70-s0YmY8Iryh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #2 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> --- Created attachment 41477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41477&action=edit Bug 12772 - Update Database (Based on Bug13624) This patch applies to Bug13624. Removes letter number from overduerules and overdurules_transport_types modified: installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl modified: installer/data/mysql/kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:34:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:34:26 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12772-70-fXMgQoOUiI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #3 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> --- Created attachment 41478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41478&action=edit Bug 12772 - Overdue rules tool and backend library modified: C4/Overdues.pm modified: koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt modified: tools/overduerules.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:34:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:34:31 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12772-70-7P8Kn3ldOK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #4 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> --- Created attachment 41479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41479&action=edit Bug 12772 - Reworked overdue_notices.pl script modified: misc/cronjobs/overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:41:51 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12772-70-9BucDE0b4w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #5 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> --- Created attachment 41480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41480&action=edit Bug 12772 - Renames atomic update file, .pl -> .perl renamed: update_13624_overduerules_transport_type.pl -> update_13624_overduerules_transport_type.perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:42:44 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13624-70-gTtvcxcCv8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12772 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 [Bug 12772] Overdue Notice/Status triggers tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:42:44 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12772-70-yNxtBlxkXK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Maxime Beaulieu <maxime.beaulieu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13624 Status|ASSIGNED |Needs Signoff --- Comment #6 from Maxime Beaulieu <maxime.beaulieu at inlibro.com> --- Test plan Apply patches (Bugs 13624 and 12772) Run updatedatabase.pl Add rules in Tools > Overdue notice/status triggers Change checked out items due date to match the rules defined above Run the overdue_notices.pl script (in /misc/cronjobs) You should receive emails corresponding to your overdue rules Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:58:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:58:05 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-hVcJS5Z67M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41481&action=edit Bug 13791: Plack out-of-the-box support on packages This patch introduces a koha-plack script that controls running Plack processes for each instance. They are run using 'starman', listening on a Unix Domain Socket (UDS): /var/run/koha/<instancename>/plack.sock The plack configuration file[1] is expected to be on: /etc/koha/plack.psgi It also adds the following helper functions to koha-functions.sh: - is_plack_enabled - is_plack_running Done: - koha-plack script - suitable psgi file TODO (by priority): - changes to koha-create - configurable workers/max-reqs (per instance?) - allow per instance psgi file (debugging?) and fallback to shipped - tab completion in bash [1] Yeah, a single file. Because we will be relying on multiple mount points for each "app" (i.e. 'opac' and 'intranet', and 'api' ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:58:13 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-6i34M3DmX6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41483&action=edit Bug 13791: koha-plack documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:58:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:58:09 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-jbEkUcnytK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41482&action=edit Bug 13791: Apache configuration files This patch adds an include to each VirtualHost definition (OPAC and Intranet) and a variable definition, taking advantage of Apache 2.4.x features. The instance name is reused inside the includes providing a simple way of dealing with the apache <-> plack configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:58:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:58:16 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-uLYICmZSpt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41484&action=edit Bug 13791: make koha-list aware of plack This patch adds the --plack and --noplack option switches to koha-list for filtering instances to be listed. This is particularly important for init scripts and cronjobs. To test: - Play with koha-list --plack and koha-plack --enable/--disable and verify that koha-list returns the expected results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:58:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:58:20 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-sPBrXspHMY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41485&action=edit Bug 13791: make koha-common init script aware of plack This patch makes the packages' koha-common script aware of plack. It does so by relying on koha-list --plack to know which instances have Plack configured, and uses the koha-plack script to manage the running daemons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 19:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 17:59:31 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-h99Gb8SKaG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 20:07:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 18:07:09 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-UIf9PPHSe7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 20:28:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 18:28:49 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-R6MOKNpHrn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 20:29:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 18:29:42 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-Tgm9wYv6ZU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41484|0 |1 is obsolete| | --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41486&action=edit Bug 13791: make koha-list aware of plack This patch adds the --plack and --noplack option switches to koha-list for filtering instances to be listed. This is particularly important for init scripts and cronjobs. To test: - Play with koha-list --plack and koha-plack --enable/--disable and verify that koha-list returns the expected results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 21:03:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 19:03:15 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14498-70-Jy8xh01Vy6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 --- Comment #5 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #4) > > 2) Edit the accountno's for those fines and set them to 0 > > I suppose you mean by editing the row in DB using the sql CLI? That is correct > Do you have an idea how it's possible to generate 2 rows with the same > accountno for the same patron? I this point I do not know how the situation is occurring. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 21:10:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 19:10:12 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-PxXTs8wDYs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #9 from Jesse Weaver <jweaver at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7) > (In reply to Jesse Weaver from comment #4) > > The issue here is that there can be a large number of patrons with a privacy > > of 2 ("Never") even if all of the following are true: > > > > * OPACPrivacy is off > > * All patron categories have a default privacy of Forever or Default > > > > This can occur for three major reasons: > > > > * The patrons had their privacy settings changed when OPACPrivacy was > > previously enabled, but it has since been disabled > > Restricting the privacy of the users is really not kind. Especially if they > had chosen to protect their data previously. > I'd say it's like breaking a contract :) > > > * The patrons were imported with a privacy of 2 > > They should not have been imported with privacy=2 if OPACPrivacy is off. > > > * A patron category had a default privacy setting of Never at the time the > > patron was created (if the category's default privacy setting is later > > changed, it does not affect the privacy of previously created patrons) > > Same as before, there is an inconsistency in the configuration ('Never' with > OPACPrivacy off). > > > This isn't an edge case; we have a large number of libraries whose checkins > > were silently failing after a bugfix upgrade due to one of the three > > scenarios above. > > You should have got a big warnings during the updatedatabase process, don't > you got it? > > (In reply to Katrin Fischer from comment #5) > > Hm, so it looks like the main problme is a mismatch of the template logic to > > display the warning with the logic in the module? (privacy setting of the > > borrower vs. system preferences?) > > The checks look good to me. > > We could apply the following changes: > > diff --git a/C4/Circulation.pm b/C4/Circulation.pm > index 7813e33..2e06ff2 100644 > --- a/C4/Circulation.pm > +++ b/C4/Circulation.pm > @@ -2077,7 +2077,7 @@ sub MarkIssueReturned { > my ( $borrowernumber, $itemnumber, $dropbox_branch, $returndate, > $privacy ) = @_; > > my $anonymouspatron; > - if ( $privacy == 2 ) { > + if ( $privacy == 2 and C4::Context->preference('OPACPrivacy') ) { > > But I still think the privacy should be respected and the data updated if > inconsistencies exist. Oh, indeed. Would it be possible to show the warning if anonymouspatron is not set and a patron exists with privacy == 2? It's not necessarily a huge issue with how the backend works, the issue is when the checkin explodes with no indication as to why. Doing this with "SELECT borrowernumber FROM borrowers WHERE privacy = 2 LIMIT 1" ran in 0.02s on one of our largest sites (~125K borrowers), so it is practical. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 22:02:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 20:02:13 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14498-70-PxNjTHgJHj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #6 from Joy Nelson <joy at bywatersolutions.com> --- I suspect this may be a data migration issue where the lines in the accountlines are not added with a tool that sequences them. I cannot think of a way where Koha would create this natively. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 23:00:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 21:00:34 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12772-70-pbNyz1hexY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #7 from Francois Charbonnier <francois.charbonnier at inlibro.com> --- Since we had to rewrite part of the overdue_notices.pl script, I put together all the information you'll need to understand what changes with this new script here : http://wiki.koha-community.org/wiki/Overdue_Notice_Enhancement#Complete_Overdue_notices.pl_test_plan Also, I put all the test cases I used here : http://wiki.koha-community.org/wiki/Overdue_Notice_Enhancement#Complete_Overdue_notices.pl_test_plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 13 23:01:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 21:01:46 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12772-70-DSdTIPM8ty@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #8 from Francois Charbonnier <francois.charbonnier at inlibro.com> --- The first link is wrong. The changings in the script is here : http://wiki.koha-community.org/wiki/Overdue_Notice_Enhancement#Changings_in_the_overdue_notices.pl_script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 00:52:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Aug 2015 22:52:28 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-3tWQ8UjyiX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Laura <ljohnson at roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ljohnson at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 03:44:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 01:44:03 +0000 Subject: [Koha-bugs] [Bug 14678] New: Update Koha language codes to ISO 639-2 spec Message-ID: <bug-14678-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678 Bug ID: 14678 Summary: Update Koha language codes to ISO 639-2 spec Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr http://www.loc.gov/standards/iso639-2/php/code_list.php more info to come... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 03:44:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 01:44:26 +0000 Subject: [Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec In-Reply-To: <bug-14678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14678-70-gm6GJSlDtH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14030 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 03:44:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 01:44:26 +0000 Subject: [Koha-bugs] [Bug 14030] Add Georgian language and fix Kannada language code In-Reply-To: <bug-14030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14030-70-yIlv4Hk0zE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14030 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14678 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 03:44:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 01:44:54 +0000 Subject: [Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec In-Reply-To: <bug-14678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14678-70-OSd1IrqM7C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 03:56:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 01:56:07 +0000 Subject: [Koha-bugs] [Bug 14631] Change to "Patron" in patroncard toolbar In-Reply-To: <bug-14631-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14631-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14631-70-r6RGFuDWzo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #4 from Liz Rea <liz at catalyst.net.nz> --- I noticed this while working on bug 14676, and was going to tidy it up as part of that. I'll use your stuff if you beat me to it though. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 04:01:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 02:01:50 +0000 Subject: [Koha-bugs] [Bug 12064] labels that don't use the splitter print zeros In-Reply-To: <bug-12064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12064-70-hl4vvK8XGA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12064 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #7 from Liz Rea <liz at catalyst.net.nz> --- I saw something like this, if you looked in the log it would say label-create-pdf.pl: Increasing $Text::Wrap::columns from 0 to 2 at /usr/share/koha/lib/C4/Labels/Label.pm line 442, Decreasing the left text margin to 0 seemed to fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 04:02:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 02:02:43 +0000 Subject: [Koha-bugs] [Bug 12064] labels that don't use the splitter print zeros In-Reply-To: <bug-12064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12064-70-byG7jTspgb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12064 --- Comment #8 from Liz Rea <liz at catalyst.net.nz> --- (this was in 3.20.2, btw.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 04:03:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 02:03:41 +0000 Subject: [Koha-bugs] [Bug 12064] labels that don't use the splitter print zeros In-Reply-To: <bug-12064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12064-70-tCzKtf1ufV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12064 --- Comment #9 from Liz Rea <liz at catalyst.net.nz> --- label-create-pdf.pl: Use of uninitialized value $string_width in addition (+) at /usr/share/koha/lib/C4/Labels/Label.pm line 466. this one also possibly helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 04:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 02:15:37 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: <bug-14639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14639-70-rBXwmbnlST@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 04:20:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 02:20:43 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-KrrJe7BzMh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 04:21:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 02:21:01 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-RX0UmiEWK0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41454|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleishaamohia at hotmail.com> --- Created attachment 41487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41487&action=edit Bug 14484: warns when changing patron pw To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 05:24:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 03:24:55 +0000 Subject: [Koha-bugs] [Bug 12804] Patron card creator search should have a branch dropdown option In-Reply-To: <bug-12804-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12804-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12804-70-9GyV1sQB4C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12804 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |aleishaamohia at hotmail.com Resolution|--- |FIXED --- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> --- This drop-down is in Koha version 3.21.00.018. Setting to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 05:49:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 03:49:33 +0000 Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page In-Reply-To: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14579-70-JTmJbrGMjY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnorthcott.work at gmail.com Status|Needs Signoff |Signed Off --- Comment #2 from cnorthcott.work at gmail.com --- Patch applies, link now works but alignment of Log In text and Help text are mismatched. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 05:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 03:52:55 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10468-70-APDmuZpOH4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 05:53:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 03:53:34 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10468-70-4gUvk0qPIq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 --- Comment #1 from Aleisha Amohia <aleishaamohia at hotmail.com> --- In version 3.21 of Koha, print summary shows checkouts and outstanding fines but not holds, so will work out how to put this in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 06:09:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 04:09:05 +0000 Subject: [Koha-bugs] [Bug 14580] Warn when accessing Help from error pages In-Reply-To: <bug-14580-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14580-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14580-70-8MnqRoCeXO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14580 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnorthcott.work at gmail.com Status|Needs Signoff |Signed Off --- Comment #2 from cnorthcott.work at gmail.com --- Patch applies correctly, warn silenced as expected. Signed off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 07:56:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 05:56:43 +0000 Subject: [Koha-bugs] [Bug 14679] New: die with bad template path on item search because template file name has a period which is not a safe character Message-ID: <bug-14679-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14679 Bug ID: 14679 Summary: die with bad template path on item search because template file name has a period which is not a safe character Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: ajm at bom.gov.au QA Contact: testopia at bugs.koha-community.org Summary: When performing an item search in the intranet interface, KOHA dies with "bad template path at /usr/share/koha/lib/C4/Auth.pm line 161". This is because get_template_and_user is called with a template_name of "catalogue/itemsearch.csv.tt", and $safe_chars does not have the ASCII period character. Steps to reproduce: 1. Login to intranet interface 2. Click on Search on top bar 3. Click on Goto Item Search 4. Perform any item search to CSV Expected results: Search works and returns search results. Actual results: KOHA dies with the message in the summary. Suggested fix: Expand the $safe_chars regex on lib/C4/Auth.pm line 160 to include ASCII period ('.') as a valid character. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 08:11:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 06:11:58 +0000 Subject: [Koha-bugs] [Bug 14679] die with bad template path on item search because template file name has a period which is not a safe character In-Reply-To: <bug-14679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14679-70-e2pPvVBmOO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14679 --- Comment #1 from Anthony Moore <ajm at bom.gov.au> --- Created attachment 41488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41488&action=edit koha-bom-get_template_and_user-regex.patch Attached proposed fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 08:16:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 06:16:29 +0000 Subject: [Koha-bugs] [Bug 14679] die with bad template path on item search because template file name has a period which is not a safe character In-Reply-To: <bug-14679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14679-70-0Q3ch5aEIk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14679 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Anthony, could this be a duplicate of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14450? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 08:27:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 06:27:50 +0000 Subject: [Koha-bugs] [Bug 14679] die with bad template path on item search because template file name has a period which is not a safe character In-Reply-To: <bug-14679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14679-70-KHyTVMiFIz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14679 --- Comment #3 from Anthony Moore <ajm at bom.gov.au> --- Sounds like it.. says that a fix is in 3.18.09, i'm on 3.18.08. I will try 09 and report back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 08:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 06:28:05 +0000 Subject: [Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client In-Reply-To: <bug-13024-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13024-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13024-70-dNQXyAfXqv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 08:45:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 06:45:26 +0000 Subject: [Koha-bugs] [Bug 14679] die with bad template path on item search because template file name has a period which is not a safe character In-Reply-To: <bug-14679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14679-70-Lwau1d4W3b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14679 Anthony Moore <ajm at bom.gov.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Anthony Moore <ajm at bom.gov.au> --- Katrin, This bug is fixed for me in version 3.18.09. Thanks for your help. *** This bug has been marked as a duplicate of bug 14450 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 08:45:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 06:45:26 +0000 Subject: [Koha-bugs] [Bug 14450] Stricter template name rules cause itemsearch to stop working In-Reply-To: <bug-14450-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14450-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14450-70-xkfVWbv6EX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14450 Anthony Moore <ajm at bom.gov.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ajm at bom.gov.au --- Comment #10 from Anthony Moore <ajm at bom.gov.au> --- *** Bug 14679 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 09:05:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 07:05:02 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: <bug-14676-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14676-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14676-70-s8gvepdypo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Indranil Das Gupta <indradg at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 10:11:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 08:11:09 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: <bug-14666-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14666-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14666-70-GEQdsUmGhy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9016 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 10:11:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 08:11:09 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: <bug-9016-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9016-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9016-70-qeqr1V764A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14666 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 10:11:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 08:11:28 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: <bug-14666-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14666-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14666-70-VIQ7Sv5ODS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 10:31:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 08:31:32 +0000 Subject: [Koha-bugs] [Bug 14680] New: when doing acquisitions, MarcFieldsToOrder-syspref discounts are instead added. Message-ID: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Bug ID: 14680 Summary: when doing acquisitions, MarcFieldsToOrder-syspref discounts are instead added. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org Using the syspref 'MarcFieldsToOrder', getting the discount directly from the MARC causes the price to actually increase by the discount percentage, not decrease, if the Vendor/Bookseller is configured to include the VAT/GST in the list price. REPLICATE ISSUE: -1. Define 'MarcFieldsToOrder'-syspref to match the discount and price columns of your staged MARC Records. 0. Stage a MARC batch. 1. Make and acquisition from the staged file using /acqui/addorderiso2709.pl (Save the big staging list, don't click "Add order" on an individual Biblio.) 2. Observe that the Replacement price (rrp) is actually the (price + discount) instead of (price - discount). And the estimated cost is just the price in the MARC Record without any discount. AFTER THIS PATCH: Replay step 1. 2. rrp is now the price in the MARC Record incl. VAT/GST. ecost is now the VAT/GST included discounted price. NOTE! Because the subroutine I modified doesn't make much sense, it is presumed that there can be regression in other parts for other kinds of vendor configurations. Because the acquisitions module is in urgent need of complete back-end refactoring + PageObject/Cucumber regression test coverage, no further investigation is made to resolve those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 10:33:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 08:33:00 +0000 Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. In-Reply-To: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14680-70-Pa48kRKkrt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|when doing acquisitions, |when doing acquisitions |MarcFieldsToOrder-syspref |from a staged file, |discounts are instead |MarcFieldsToOrder-syspref |added. |discounts are instead | |added. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 10:34:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 08:34:56 +0000 Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. In-Reply-To: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14680-70-c9TqZ5c8yr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41489&action=edit Bug 14680 - when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. Using the syspref 'MarcFieldsToOrder', getting the discount directly from the MARC causes the price to actually increase by the discount percentage, not decrease, if the Vendor/Bookseller is configured to include the VAT/GST in the list price. REPLICATE ISSUE: -1. Define 'MarcFieldsToOrder'-syspref to match the discount and price columns of your staged MARC Records. 0. Stage a MARC batch. 1. Make and acquisition from the staged file using /acqui/addorderiso2709.pl (Save the big staging list, don't click "Add order" on an individual Biblio.) 2. Observe that the Replacement price (rrp) is actually the (price + discount) instead of (price - discount). And the estimated cost is just the price in the MARC Record without any discount. AFTER THIS PATCH: Replay step 1. 2. rrp is now the price in the MARC Record incl. VAT/GST. ecost is now the VAT/GST included discounted price. NOTE! Because the subroutine I modified doesn't make much sense, it is presumed that there can be regression in other parts for other kinds of vendor configurations. Because the acquisitions module is in urgent need of complete back-end refactoring + PageObject/Cucumber regression test coverage, no further investigation is made to resolve those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 10:35:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 08:35:18 +0000 Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. In-Reply-To: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14680-70-ZqEHKDNHFA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 10:36:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 08:36:38 +0000 Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. In-Reply-To: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14680-70-IbrfjLDxAc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Failed QA because missing test coverage. Because the modification is in the controller, no unit testing is possible. Only way to test is with PageObjects. This needs a lot of scaffolding to be made to enable running tests on Acquisitions module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 11:36:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 09:36:18 +0000 Subject: [Koha-bugs] [Bug 14681] New: Warn when adding help to 404 page Message-ID: <bug-14681-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14681 Bug ID: 14681 Summary: Warn when adding help to 404 page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Going to cgi-bin/koha/errors/404.pl in staff side and then clicking the Help and after that clicking Add help you get the following warning/error: edithelp.pl: Use of uninitialized value $lang in concatenation (.) or string at kohaclone/edithelp.pl line 74. The problem is the same type as it is in Bug 14580. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 11:37:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 09:37:47 +0000 Subject: [Koha-bugs] [Bug 14681] Warn when adding help to 404 page In-Reply-To: <bug-14681-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14681-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14681-70-e12fF3aWog@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14681 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14580 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 11:37:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 09:37:47 +0000 Subject: [Koha-bugs] [Bug 14580] Warn when accessing Help from error pages In-Reply-To: <bug-14580-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14580-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14580-70-5mXRJwDFLm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14580 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14681 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 12:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 10:47:16 +0000 Subject: [Koha-bugs] [Bug 3642] Modify Overdue.pl export to include other borrower information In-Reply-To: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-GbUdsomqaT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 12:47:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 10:47:25 +0000 Subject: [Koha-bugs] [Bug 3642] Modify Overdue.pl export to include other borrower information In-Reply-To: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-1ev9wFD121@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Alias| |New, informations, in, | |overdues, CSV, export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 12:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 10:47:42 +0000 Subject: [Koha-bugs] [Bug 3642] Modify Overdue.pl export to include other borrower information In-Reply-To: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-VfZSD2eTEK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Alias|CSV, export, in, | |informations, New, overdues | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 12:48:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 10:48:38 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-86pKwgHOg7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Modify Overdue.pl export to |New informations in |include other borrower |overdues CSV export |information | --- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- I propose some patches. not only for borrower informations so I change a bit the title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 12:50:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 10:50:24 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-kWr1JfbGlr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 12:50:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 10:50:34 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-OtJHykXcMg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 41490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41490&action=edit Bug 3642 - New informations in overdues CSV export - prepare This patch prepare columns list to ease other patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 12:50:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 10:50:59 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-UFubAH37nf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 41491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41491&action=edit Bug 3642 - New informations in overdues CSV export - add cardnumber This patch adds patron cardnumber to overdues CSV export Test plan : - Go to overdues page : <server>/cgi-bin/koha/circ/overdue.pl - Find some overdues - Click on "Download file of displayed overdues" - Open generated CSV => You see cardnumber column with data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 12:51:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 10:51:19 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-sUDEUCVkfE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 41492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41492&action=edit Bug 3642 - New informations in overdues CSV export - add itemtype This patch adds record itemtype to overdues CSV export, from item or biblioitems depending on syspref "item-level_itypes" Test plan : - Go to overdues page : <server>/cgi-bin/koha/circ/overdue.pl - Find some overdues - Click on "Download file of displayed overdues" - Open generated CSV => You see itemtype column with data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 12:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 10:52:40 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-kokthKWVgR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 41493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41493&action=edit Bug 3642 - New informations in overdues CSV export - move streetnumber and streettype This patch moves columns streetnumber and streettype next to address. This is more logical to read the CSV. For example : streetnumber,streettype,address,address2,zipcode,city 181,rue,Breteuil,,13001,Marseille Test plan : - Go to overdues page : <server>/cgi-bin/koha/circ/overdue.pl - Find some overdues of patrons with streetnumber and streettype - Click on "Download file of displayed overdues" - Open generated CSV => You see streetnumber and streettype before address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 12:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 10:53:25 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-9a4y5sgCmG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Enjoy and please test ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 13:24:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 11:24:51 +0000 Subject: [Koha-bugs] [Bug 14580] Warn when accessing Help from error pages In-Reply-To: <bug-14580-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14580-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14580-70-ozhz7Xh4zz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14580 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- The problem is with C4::Templates::themelanguage function, it doesn't return anything in this situation. Should we fix that function instead, because bug 14681 has the same problem and I'm thinking other pages might have it too. I tried to look into a fix to that function but didn't come up with any clever fix. One idea was to default to some default themes/language but then we cannot know if they're installed or not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 13:31:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 11:31:35 +0000 Subject: [Koha-bugs] [Bug 14682] New: Export.pl doesn't work from command line Message-ID: <bug-14682-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14682 Bug ID: 14682 Summary: Export.pl doesn't work from command line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org When I'm calling export.pl script from command line, I'm receiving this error message and nothing is exported: Can't use an undefined value as a HASH reference at /usr/share/koha/intranet/cgi-bin/tools/export.pl line 149. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 13:51:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 11:51:03 +0000 Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted In-Reply-To: <bug-14621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14621-70-dw2UKmkOzp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 --- Comment #1 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41494&action=edit Bug 14621 - Messaging preferences table needs to be sorted I have been working with messaging preferences and I noticed a weird issue in Firefox on Ubuntu. On messaging preferences page, the table is unsorted and the content in rows are generated randomly on every page refresh. When you select/deselect checkboxes and refresh the page (without posting the changes), Firefox will remember your choices. Now the issue is that when the table is unsorted and the rows keep changing on page refresh, Firefox has trouble remembering your choices. This makes it appear as if the checkboxes are magically changing values on each page refresh. Here is a patch that prevents this problem by sorting the messaging settings. Test plan: 1. Apply patch and have Perl version 5.18 or higher 2. In OPAC, navigate to "your messaging" 3. Observe the order of rows in the messaging settings table 4. Refresh the page 5. Observe that the order of rows is still the same as in step 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:09:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:09:23 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-hOUkRo5V5w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:09:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:09:26 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-iSR6KjoIhY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41487|0 |1 is obsolete| | --- Comment #8 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41495&action=edit Bug 14484: warns when changing patron pw Warning disappears, code looks good. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:18:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:18:23 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-lwjerFIli3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 --- Comment #1 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41496&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to "ipn" 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything) 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to "your personal details" 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to "your messaging" 7. Check all messaging preferences and submit changes 8. Navigate to "your personal details" 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for "Phone" and "Email" columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:19:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:19:06 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-avi4gq6Atw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 --- Comment #2 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41497&action=edit Bug 14590 - PageObject tests for misconfigured messaging preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:19:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:19:35 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-hPCgQ0MSnM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14621 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 [Bug 14621] Messaging preferences table needs to be sorted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:19:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:19:35 +0000 Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted In-Reply-To: <bug-14621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14621-70-a20Ijf2NdT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14590 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:33:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:33:08 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-6OfMJyHhwx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41498&action=edit Bug 14321: Using Koha::Upload in tools/upload-file.pl This patch introduces Koha::Upload. It will replace the modules C4::UploadedFile.pm and the new C4::UploadedFiles.pm (from BZ 6874). This operation will be performed in a few steps. As a first step, we will use Koha::Upload instead of UploadedFile in the following places. (In these three places files are uploaded temporarily.) [1] stage-marc-import.pl [2] upload-cover-image.pl [3] offline_circ/process_koc.pl and enqueue_koc.pl A new file-upload.js replaces file-upload.inc in the associated template. We now use ajax to get progress figures instead of launching perl script upload-file-progress. Also we do not need the jquery plugin ajaxfileupload.js anymore. A subsequent patch will remove these files. The js changes now also allow for aborting a file upload. This feature has been added to stage-marc-import only for now. NOTE: In editing the process_koc.tt I noticed that the form enqueuefile was hidden and no longer used (with associated code in process_koc.pl). When a file has been uploaded, I display the form again (with the Apply directly button). The code still works. Test plan: [1] Upload a marc file in stage-marc-import. [2] Check new entry in table uploaded_files. Look for the file in the directory defined by upload_path in koha-conf.xml. [3] Upload another (larger) file and abort the upload. Check table and directory again. [4] Verify that Stage for import still works as expected. [5] Test Upload local cover image. (Enable OPACLocalCoverImages.) You can test an individual image or a zip file including images and a file called datalink.txt (with lines biblionumber,filename). [6] Test uploading a offline circulation file: Enable AllowOfflineCirculation, and create a koc file (plain text): Line1: Version=1.0\tA=1\tB=2 Line2: 2015-08-06 08:00:00 345\treturn\t[barcode] Note: Replace tabs and barcode. The number of tabs is essential! Checkout the item with your barcode. Go to Offline circulation file upload. Upload and click Apply directly. Checkout again. Upload again, click Add to offline circulation queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:33:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:33:15 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-ge8Gs76k31@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41500&action=edit Bug 14321: Add public column to uploaded_files This patch adds uploaded_files.public. This column will be used to mark uploaded files as available via opac-retrieve. The db rev sets this flag for current records having a category (as uploaded via the BZ 6874 plugin: so public). A followup patch will adjust the plugin to use Koha::Upload. Test plan: [1] Run the dbrev. [2] Add a record (upload a file) via stage-marc-import. [3] Check that public is null in the new record. (This is a temporary file without category.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:33:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:33:12 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-oH9m5NvuLM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41499&action=edit Bug 14321: Add some error checking to Upload.pm This patch makes Upload return some error codes if a file cannot be read or cannot be written. Test plan: [1] Upload a file with stage-marc-import.pl. This is a temporary file; it will be saved in your system's temporary dir (e.g. /tmp) within the folder koha_upload. [2] Change the owner of this koha_upload dir and remove write permissions. [3] Upload the file again. You should get: Upload status: Failed. [4] Restore owner and permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:33:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:33:19 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-VidBPjOc5f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41501&action=edit Bug 14321: Redirect upload plugin to general upload script This patch makes the following changes to achieve that: [1] Adds a tools/upload script and template. It allows to upload multiple files at once. [2] Adds additional parameter to js function AjaxUpload (for category and public column). [3] Adds methods to Upload: count, delete, getCategories, httpheaders. [4] Makes upload-file return error messages in JSON. For a multiple upload, we could have some files with errors and others without errors. The upload is now marked as Failed only if there was no upload at all. [5] Adds decode_utf8 statement for UTF-8 chars in filenames (in the CGI hook). Note that we do not want the -utf8 flag here for binary uploads. [6] The upload plugin is converted to use tools/upload with plugin param. Deleting an upload is now presented via the search results form. NOTE: A unit test is supplied in a follow-up patch. Test plan: [1] Upload three files via tools/upload.pl with a category and marked as public. Check the results in the table. [2] Pick one new file and one of the files of step 1. Upload them in the same category. One upload should succeed. Check for reported error. [3] Upload a file via stage-marc-import. Stage it. [4] Go to Cataloguing editor. Connect upload.pl to field 856$u. In an empty 856$u, click the tag editor. Upload a file and click Choose. Save the record. Open the record in the OPAC and click the link. Copy this link to your clipboard for step 5. [5] Go back to editor. Click the tag editor on the same 856 field. Choose for Delete. Open the link in your clipboard again. [6] Check the process of upload, search, download and delete of an upload with some diacritical characters in the filename. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:36:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:36:35 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-hppvJSp7R1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- This shows my progress until now. Almost done :) I will still add a test file and remove some obsolete files. After that there may be some smaller style issues, adding upload to the menu and perhaps adding a specific permission or so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 14:41:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 12:41:09 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-ayYUaTe44O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 15:07:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 13:07:08 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: <bug-14666-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14666-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14666-70-74CCbkJj0w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 --- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Katrin Fischer from comment #1) > Hi Stephane, > > I am in doubt about this patch - especially the new dependencies. What are > they used for? We have a new plugin to format prices now and also some > existing code to do that - could it be achieved with the existing modules? Ok thanks for the information. > > I also think this would be good on separate bugs - for example the colums > added to the CSV seem unrelated to the main feature. Indeed, this bug will only focus on adding fixed_fines to overdue notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 15:07:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 13:07:19 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: <bug-14666-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14666-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14666-70-ufu6uX8cKK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 16:26:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 14:26:45 +0000 Subject: [Koha-bugs] [Bug 14683] New: Unable to clear SMS number Message-ID: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 Bug ID: 14683 Summary: Unable to clear SMS number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: larit at student.uef.fi QA Contact: testopia at bugs.koha-community.org In opac-messaging.pl (your messaging) you cannot unset your SMS number once it has been set if your mobile (other phone) field is empty. When checking for modified SMS number, we also check if SMS number does not equal mobile phone. This is causing the bug: $query->param('SMSnumber') ne $borrower->{'mobile'} Since mobile is empty and the given SMS number is also empty, the given SMS number will not be saved. Does anybody have an idea why we have this kind of condition? to reproduce: -2. Make sure borrower does not have mobile (other phone) set -1. Make sure you have SMS messaging enabled 1. Navigate to your messaging 2. Insert SMS number and submit 3. Clear SMS number and submit 4. Observe that the sms number did not change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 16:31:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 14:31:37 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-lPFYpziX4C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41461|0 |1 is obsolete| | --- Comment #8 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41502&action=edit Bug 14620 - Contact information validations I'm thinking we should centralize all patron's contact information validators into one module. Currently we only have validations for e-mail addresses, using the Email::Valid module. In our local library we also want to validate phone numbers with a regex that only recognizes phone numbers from my country. So I suggest we create a phone number validation as well, with an option to easily create custom regex for your local use. If a library does not wish to use validations, we should give them an option to turn them off. If more local validators are implemented, we should also give the library an option to select which validator they wish to use. With this method we could implement phone number validators from around the world and add them into our module. Then we would make the validations simply by calling our validator. The validator would know by system preference which one of the implemented phone number validators it should use. Validations should be both client and server side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 18:58:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 16:58:55 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-16QtUQQSj1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 19:19:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 17:19:30 +0000 Subject: [Koha-bugs] [Bug 14506] barcode printing In-Reply-To: <bug-14506-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14506-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14506-70-w8QWDoIfpa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14506 sy <siewyee2 at yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |siewyee2 at yahoo.com --- Comment #3 from sy <siewyee2 at yahoo.com> --- had this issue also. homebranch in the "Koha to MARC mapping" was not mapped to a value. solution: Home ? Administration ? Koha to MARC mapping (items) homebranch: map it to "952 a Permanent location" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 21:10:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 19:10:51 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-LOghyfyqD5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #119 from Nick Clemens <nick at quecheelibrary.org> --- Test plan went well, a couple things I noticed along the way: MAJOR: Editing or adding an item deletes all items from the record MINOR: 1 - Backspacing on indicators or field number is hard to fix (insert mode keeps changing and have to press the button after each insertion) 2 - Letters should not be valid in field number 3 - Spaces (as opposed to underscores) invalidate the field, but it is hard to tell that is the problem. Could they possibly translate to underscores? 4 - Using delete you can bring another field into the current field, however you can't use enter to return it to the next line. You should either not be able to pull the line up, or you should have some recourse to return it. 5 - Pressing end on a new blank field moves the cursor in line with the next field and backspacing then deletes the field below 6 - It would be nice to have an apply button when selecting/deselecting search sources. If you want to make more than one change the waiting between each click is tedious 7 - Ctrl+X to delete a field works nicely, but it doesn't work as 'cut' if text is highlighted. Having the ability to move text between fields would be appreciated if possible 8 - Error message "Missing mandatory subfield $a" when field a is present but empty could say "Mandatory subfield $a is blank" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 21:15:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 19:15:35 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-bvtTgZchwM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41482|0 |1 is obsolete| | --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41504&action=edit Bug 13791: Apache configuration files This patch adds an include to each VirtualHost definition (OPAC and Intranet) and a variable definition, taking advantage of Apache 2.4.x features. The instance name is reused inside the includes providing a simple way of dealing with the apache <-> plack configuration. A check for the right apache version is introduced, in the for of an IfVersion block: <IfVersion >= 2.4> --- Plack configuration here --- </IfVersion> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 21:15:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 19:15:27 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-m47FFkhZb5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41481|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41503&action=edit Bug 13791: Plack out-of-the-box support on packages This patch introduces a koha-plack script that controls running Plack processes for each instance. They are run using 'starman', listening on a Unix Domain Socket (UDS): /var/run/koha/<instancename>/plack.sock The plack configuration file[1] is expected to be on: /etc/koha/plack.psgi It also adds the following helper functions to koha-functions.sh: - is_plack_enabled - is_plack_running Done: - koha-plack script - suitable psgi file [1] Yeah, a single file. Because we will be relying on multiple mount points for each "app" (i.e. 'opac' and 'intranet', and 'api' ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 21:15:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 19:15:42 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-5K3mzB8gHD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41483|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41505&action=edit Bug 13791: koha-plack documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 21:15:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 19:15:52 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-d4mI8qMzPV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41486|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41506&action=edit Bug 13791: make koha-list aware of plack This patch adds the --plack and --noplack option switches to koha-list for filtering instances to be listed. This is particularly important for init scripts and cronjobs. To test: - Play with koha-list --plack and koha-plack --enable/--disable and verify that koha-list returns the expected results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 21:16:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 19:16:03 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-BJb82yrHAo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41485|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41507&action=edit Bug 13791: make koha-common init script aware of plack This patch makes the packages' koha-common script aware of plack. It does so by relying on koha-list --plack to know which instances have Plack configured, and uses the koha-plack script to manage the running daemons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 23:44:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 21:44:51 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-XfvikudmsZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41504|0 |1 is obsolete| | --- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41509&action=edit Bug 13791: Apache configuration files This patch adds an include to each VirtualHost definition (OPAC and Intranet) and a variable definition, taking advantage of Apache 2.4.x features. The instance name is reused inside the includes providing a simple way of dealing with the apache <-> plack configuration. A check for the right apache version is introduced, in the for of an IfVersion block: <IfVersion >= 2.4> --- Plack configuration here --- </IfVersion> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 23:44:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 21:44:59 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-eCuo9wcGnp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41505|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41510&action=edit Bug 13791: koha-plack documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 23:44:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 21:44:44 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-305eWtnkvc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41503|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41508&action=edit Bug 13791: Plack out-of-the-box support on packages This patch introduces a koha-plack script that controls running Plack processes for each instance. They are run using 'starman', listening on a Unix Domain Socket (UDS): /var/run/koha/<instancename>/plack.sock The plack configuration file[1] is expected to be on: /etc/koha/plack.psgi and is installed by the package. It also adds the following helper functions to koha-functions.sh: - is_plack_enabled - is_plack_running Done: - koha-plack script - suitable psgi file [1] Yeah, a single file. Because we will be relying on multiple mount points for each "app" (i.e. 'opac' and 'intranet', and 'api' ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 23:45:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 21:45:07 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-VSnhscTDv0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41506|0 |1 is obsolete| | --- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41511&action=edit Bug 13791: make koha-list aware of plack This patch adds the --plack and --noplack option switches to koha-list for filtering instances to be listed. This is particularly important for init scripts and cronjobs. To test: - Play with koha-list --plack and koha-plack --enable/--disable and verify that koha-list returns the expected results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 23:45:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 21:45:17 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-urQdYUnUP3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41507|0 |1 is obsolete| | --- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41512&action=edit Bug 13791: make koha-common init script aware of plack This patch makes the packages' koha-common script aware of plack. It does so by relying on koha-list --plack to know which instances have Plack configured, and uses the koha-plack script to manage the running daemons. It also introduces a plack_status function to check the status of the Plack daemon when called: $ servive koha-common status Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 14 23:45:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 21:45:26 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-WBnS5Vvvle@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41513&action=edit Bug 13791: tab-completion for koha-plack in bash This patch adds tab-completion in bash for the koha-plack command. After the --start, --stop, --restart and --disable switches it only offers plack-enabled instances. And disabled instances to --enable. --help and -h just finish end the completion. --quiet and -q are trickier to implement. They will work (be offered) only before the action switches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 15 01:02:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 23:02:25 +0000 Subject: [Koha-bugs] [Bug 14530] 856$u URL checker ( check-url.pl ) complains about ftp based URLs In-Reply-To: <bug-14530-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14530-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14530-70-b98rYlNHmm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #4 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to M. Tompsett from comment #2) > Actually, couldn't you put an http URL for an ftp proxy into host? > > ./misc/cronjobs/check-url.pl --host=http://this.site.proxies.ftp.requests > > then it would attempt to go to > http://this.site.proxies.ftp.requests/ftp://whatever/whereever/whatever.foo > > Personally, I'd prefer to see a re-write to allow for other protocols (bring > back gopher! :) ). > > Because skipping the ftp URLs kind of defeats the purpose of the script > which is to validate that the URLs exist. This could be a significant > problem if a large portion of URLs are not http. That sounds reasonable, but not everyone will want to go to the trouble of setting that up. As a middle ground, I think adding a --skip-ftp parameter should suffice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 15 01:03:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 23:03:24 +0000 Subject: [Koha-bugs] [Bug 14530] 856$u URL checker ( check-url.pl ) complains about ftp based URLs In-Reply-To: <bug-14530-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14530-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14530-70-2C4VkDTkAN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 --- Comment #5 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to M. Tompsett from comment #3) > Also, quick says it replaces the non-quick version. Perhaps we should delete > the non-quick version? That sounds good to me. Would you want to file a separate bug report for that? If that bug/patch makes it into master before this one, I'll just have to update it. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 15 01:09:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Aug 2015 23:09:28 +0000 Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch In-Reply-To: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14297-70-BvjlrWjcGN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #6 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #5) > Any chances to get some tests to highlight this change? I'll see what I can do! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 15 06:36:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Aug 2015 04:36:22 +0000 Subject: [Koha-bugs] [Bug 14530] 856$u URL checker ( check-url.pl ) complains about ftp based URLs In-Reply-To: <bug-14530-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14530-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14530-70-8CkgQocMQk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14530 --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- BTW, I was bored a while back, and actually wrote a forking LWP version. I'll attach it later, once I actually test it in place. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 15 09:54:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Aug 2015 07:54:28 +0000 Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh In-Reply-To: <bug-14375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14375-70-Yjk6gKdENI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 15 10:12:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Aug 2015 08:12:44 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-YuuoP6iv6e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 16 23:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Aug 2015 21:58:13 +0000 Subject: [Koha-bugs] [Bug 14592] Export data bad encoding In-Reply-To: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14592-70-bxxC4WCssv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41465|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 41514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41514&action=edit [PASSED QA] Bug 14592: Export data bad encoding Tools > Export data produces a file badly encoded, when marc/xml file format is chosen. It works with CSV. To test: 1. Tools > Export data 2. Choose a limited interval of biblionumber 3. Export in marc/xml/csv. 4. Check files exported at 3: csv file is ok. marc/xml files are corrupted, ie badly encoded. 5. Apply the patch 6. Repeat steps 3&4, and confirm that all file formats are valid. Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 16 23:58:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Aug 2015 21:58:10 +0000 Subject: [Koha-bugs] [Bug 14592] Export data bad encoding In-Reply-To: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14592-70-WBHGRYrVa6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 00:10:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Aug 2015 22:10:13 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-Z2Yg7CXN91@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40980|0 |1 is obsolete| | --- Comment #14 from Martin Persson <xarragon at gmail.com> --- Created attachment 41515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41515&action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML This patch adds the ability to use a WYSIWYG editor for system preferences. The key files that I touch are: 1) admin/systempreferences.pl 2) koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt 3) koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt I also add: 4) koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc and 5) koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/advimage This plugin is part of the TinyMCE distribution. It used to be in Koha, but then someone removed it. It's useful for preferences like "opacheader" though. *If you're using anything except IE, this should work super well. If you're using IE, it'll probably only work for keyboard input and dragging text within the editor box but not from outside of it. IE has worse security, so you can probably paste using the context menu paste. *While I think a WYSIWYG editor can be useful, there might be times where the content is displayed differently than it is in the editor because of higher level CSS and Javascript. Signed-off-by: Martin Persson <xarragon at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 00:26:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Aug 2015 22:26:12 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-h0ASmv5Mo5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40982|0 |1 is obsolete| | --- Comment #15 from Martin Persson <xarragon at gmail.com> --- Created attachment 41516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41516&action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML (add licence) This patch adds the TinyMCE license info to about.pl Signed-off-by: Martin Persson <xarragon at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 00:32:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Aug 2015 22:32:53 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-oMGc09SKTB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xarragon at gmail.com --- Comment #16 from Martin Persson <xarragon at gmail.com> --- Created attachment 41517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41517&action=edit Patch to work with newly added dropdown Sorry, screwed up the patches i signed off, obsoleted the wrong ones because git-bz was a bit confusing for me. I have merged these patches so that they apply cleanly on current master and added support for the drop-down type selector. Not sure if we need a second round of sign-offs for the merge changes. Please advise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 00:34:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Aug 2015 22:34:52 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-wzqCm4iTri@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40981|0 |1 is obsolete| | --- Comment #17 from Martin Persson <xarragon at gmail.com> --- Created attachment 41518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41518&action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML (add licence) This patch adds the TinyMCE license info to about.pl Signed-off-by: Martin Persson <xarragon at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 00:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Aug 2015 22:37:27 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-Sji3Wf96El@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41515|0 |1 is obsolete| | --- Comment #18 from Martin Persson <xarragon at gmail.com> --- Created attachment 41519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41519&action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML (add licence) This patch adds the TinyMCE license info to about.pl Signed-off-by: Martin Persson <xarragon at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 00:38:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Aug 2015 22:38:29 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-d1QJ1yvTFE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41519|0 |1 is obsolete| | --- Comment #19 from Martin Persson <xarragon at gmail.com> --- Created attachment 41520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41520&action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML This patch adds the ability to use a WYSIWYG editor for system preferences. The key files that I touch are: 1) admin/systempreferences.pl 2) koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt 3) koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt I also add: 4) koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc and 5) koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/advimage This plugin is part of the TinyMCE distribution. It used to be in Koha, but then someone removed it. It's useful for preferences like "opacheader" though. *If you're using anything except IE, this should work super well. If you're using IE, it'll probably only work for keyboard input and dragging text within the editor box but not from outside of it. IE has worse security, so you can probably paste using the context menu paste. *While I think a WYSIWYG editor can be useful, there might be times where the content is displayed differently than it is in the editor because of higher level CSS and Javascript. Signed-off-by: Martin Persson <xarragon at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 00:40:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Aug 2015 22:40:30 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-gENLl5rKQy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41516|0 |1 is obsolete| | --- Comment #20 from Martin Persson <xarragon at gmail.com> --- Created attachment 41521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41521&action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML (add system preference) This patch adds a system preference "UseWYSIWYGinSystemPreferences" to the Staff Client tab. By default, it is off, which means that the TinyMCE WYSIWYG editor won't be shown for system preferences with a type of "htmlarea". However, when it's on, it will show the editor for "Local Use" preferences with a "htmlarea" type, and for other system preferences in the "Opac", "Circulation", and "Staff Client" tabs, which I have re-assigned. (Basically, I grepped for HTML and changed the type for all the system preferences I found except for "IntranetNav", "OpacCustomSearch", and "OPACSearchForTitleIn", as a WYSIWYG editor would potentially break the output for these system preferences or add no value to them...) _TEST PLAN_ 0) Run `perl installer/data/mysql/updatedatabase.pl` after setting your environmental variables 1) Check the Opac tab to make sure that the WYSIWYG is nowhere to be seen 2) Change the "UseWYSIWYGinSystemPreferences" preference in "Staff Client" to "Show" 3) Refresh the Opac tab and notice that many system preferences now have a WYSIWYG editor 4) Try typing some text into these fields 5) Note that it gets marked as "modified" 6) Save the preference, and refresh the page 7) Note that the content has been saved 8) Take a look at how it's rendered on the actual webpage! Signed-off-by: Martin Persson <xarragon at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 00:44:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Aug 2015 22:44:44 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-bn3WxsdvCx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #21 from Martin Persson <xarragon at gmail.com> --- Okay I tried to clear this up.. But the order of the patches are different now. They do however seem to apply and work when I test them. Sorry for the mess, I was trying to use relative names instead of sha1:s and it did not work out well since I didn't pay enough attention to the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 03:55:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 01:55:21 +0000 Subject: [Koha-bugs] [Bug 14684] New: Import MARC records no longer has link to biblio Message-ID: <bug-14684-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14684 Bug ID: 14684 Summary: Import MARC records no longer has link to biblio Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org The stage MARC records for import tool used to provide a link to the detail page in the post-import report so that you could click through to see the record before it had been indexed. This functionality seems to have gone away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 03:59:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 01:59:22 +0000 Subject: [Koha-bugs] [Bug 14684] Import MARC records no longer has link to biblio In-Reply-To: <bug-14684-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14684-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14684-70-S6Fr6TorbC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14684 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Liz Rea <liz at catalyst.net.nz> --- Yeah, I had a bad matching rule - sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 06:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 04:27:57 +0000 Subject: [Koha-bugs] [Bug 14685] New: Cannot set guarantor for a child account Message-ID: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Bug ID: 14685 Summary: Cannot set guarantor for a child account Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In 3.20.2 one cannot add a child and set the guarantor. It appears this was introduced by bug 13970. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 06:28:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 04:28:06 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-qBVdVYqkVH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13970 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 [Bug 13970] Remove related code to category_type -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 06:28:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 04:28:06 +0000 Subject: [Koha-bugs] [Bug 13970] Remove related code to category_type In-Reply-To: <bug-13970-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13970-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13970-70-3Fu55IwRBv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14685 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 [Bug 14685] Cannot set guarantor for a child account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 06:53:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 04:53:13 +0000 Subject: [Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense In-Reply-To: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14574-70-V4Ry2UclFx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 06:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 04:53:16 +0000 Subject: [Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense In-Reply-To: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14574-70-Q5rVJhHuss@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574 cnorthcott.work at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41105|0 |1 is obsolete| | --- Comment #2 from cnorthcott.work at gmail.com --- Created attachment 41522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41522&action=edit Bug 14574: Fixing error messages on staff client so they make more sense To test: 1) Go to cgi-bin/koha/errors/errornumber.pl to see the error messages which currently don't make sense (ie cgi-bin/koha/errors/401.pl etc). Have only made changes to 401, 403 and 404 2) Apply patch 3) Go to cgi-bin/koha/errors/401.pl --> Check that it now says "This error means that you aren't authorized to view this page." and "Please log in and try again.". Check that 'log in' redirects to the log in page (mainpage.pl). 4) Go to cgi-bin/koha/errors/403.pl --> Check that it now says "This error means that you are forbidden to view this page." 5) Go to cgi-bin/koha/errors/404.pl --> This page should be very different. Check that the 'Error 404' is now in italics and not bold. Check that the page gives a list of reasons the user may have been given this error and some options for their next step. Signed-off-by: Catherine <cnorthcott.work at gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 07:48:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 05:48:37 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-4xUuoLEB1f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #18 from Josef Moravec <josef.moravec at gmail.com> --- Hello Tom?s, I think there is a typo in apache configuration here: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41509&action=diff#a/debian/templates/apache-site.conf.in_sec1 Start tag <IfVersion>, but end tag </IfDefine> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 08:10:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 06:10:39 +0000 Subject: [Koha-bugs] [Bug 12885] Search fails with errors when HTML5 Media is enabled and url has plus (+) charcters In-Reply-To: <bug-12885-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12885-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12885-70-NVDNDjdslU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12885 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41210|0 |1 is obsolete| | --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41523&action=edit Bug 12885: Fix if url contains +*... and HTML5 Media is enabled Error disappears and code looks good to me. Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 08:11:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 06:11:54 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-fy6AIPNa6E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #19 from Josef Moravec <josef.moravec at gmail.com> --- And I had to install starman and perl module Plack::Middleware::ReverseProxy shouldn't it be at least documented somewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 08:32:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 06:32:40 +0000 Subject: [Koha-bugs] [Bug 13178] cardnumber field length is too short In-Reply-To: <bug-13178-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13178-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13178-70-jLwsQStart@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #4 from Joonas Kylm?l? <j.kylmala at gmail.com> --- There is CardnumberLength system preference but it doesn't change the max length of the cardnumber when trying to edit x patron's cardnumber. Does anyone know what is the purpose of this preference, does it change the cardnumber length somewhere else? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 09:35:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 07:35:15 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-3yXcKvkzxc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #8 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41524&action=edit Bug 14536: (follow-up) Add OpacMessaging, Circulation and LeftNavigation for Members/Circulation pages in Staff Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 09:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 07:57:56 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-E4UfbLj3cs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #9 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41525&action=edit Bug 14536: (follow-up) Add more functionalty for handling messaging preferences - Fixes memberentry form submit to return Circulation PageObject. - Prevents missing element errors at different steps of memberentry page. Patron modification has multiple different steps (full edit, information edit, sms number edit, library use edit, alternate address edit, alternative contact edit). Some of the input fields required for validation are not always present in each step of these modifications. - Adds functionality to check checkboxes and validate if they are checked or not - Adds navigation to moremember edit links. - Adds navigation to opac-messaging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 10:01:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 08:01:49 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-DVtxsxgypO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 10:05:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 08:05:39 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-aw5FCGyLgP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41496|0 |1 is obsolete| | --- Comment #3 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41526&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to "ipn" 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything) 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to "your personal details" 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to "your messaging" 7. Check all messaging preferences and submit changes 8. Navigate to "your personal details" 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for "Phone" and "Email" columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 12:17:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 10:17:26 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-1gzvHOQKi8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41472|0 |1 is obsolete| | --- Comment #9 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41527&action=edit Bug 14620 - Whitespace fix for validations This fix trims emails and phone numbers just before form is sent. Fixes the invalid syntax used in JQuery's .on() functions' argument. Removes the trimming for click events as change event should be enough. Test plan: 1. Apply the patches (and run updatedatabase.pl). 2. Set system preferences ValidateEmailAddress to "Enable" and ValidatePhoneNumber to "International Phone Numbers". 3. Make sure JavaScript is enabled. 4. Navigate to edit user contact informations in Staff client and OPAC. 5. Clear email and phone fields. 6. Insert whitespaces to email and phone fields and submit the form. 7. Edit patron. 8. Observe that there are no longer whitespaces in email and phone fields. 9. Insert invalid email (e.g. "invalid") and invalid phone number ("+123invalid") and send the form. 10. Confirm that form will not be submitted and errors will be given. 11. Disable JavaScript. 12. Insert invalid email and invalid phone number 13. Try sending the form again. 14. Confirm that form will be submitted but errors will be given on top of the form. 15. Observe that none of the changes are accepted. 16. Set system preferences ValidateEmailAddress to "Disable" and ValidatePhoneNumber to "none". 17. Repeat step 3-9 but observe that errors will not be given and changes will be submitted and saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 12:45:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 10:45:10 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-xi4qDm6o4k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41526|0 |1 is obsolete| | --- Comment #4 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41528&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 13:59:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 11:59:05 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: <bug-13995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13995-70-xWQJjGoVjv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41249|0 |1 is obsolete| | --- Comment #14 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41529&action=edit Bug 13995 - Proper Exception handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 13:59:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 11:59:25 +0000 Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types In-Reply-To: <bug-14539-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14539-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14539-70-mg0D3lyq4G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41250|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41530&action=edit Bug 14539 - Introduction to cast() (ToObject), aka. make a Koha::Object from various input types and validate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 13:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 11:59:50 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13906-70-Y0wIoCadv5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41251|0 |1 is obsolete| | Attachment #41459|0 |1 is obsolete| | --- Comment #12 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41531&action=edit Bug 13906 - TestObjectFactory(ies) for Koha objects. Enable easy Test object creation/deletion from HASHes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:00:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:00:07 +0000 Subject: [Koha-bugs] [Bug 14616] Introducing Koha::Object subclasses In-Reply-To: <bug-14616-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14616-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14616-70-13cBATULV1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41252|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41532&action=edit Bug 14616 - Introducing Koha::Object subclasses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:00:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:00:24 +0000 Subject: [Koha-bugs] [Bug 14495] WebDriver/WebTester Factory for easy generation of Web testing UserAgents. In-Reply-To: <bug-14495-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14495-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14495-70-CfjgMoBJyL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41296|0 |1 is obsolete| | --- Comment #11 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41533&action=edit Bug 14495 - WebDriver/WebTester Factory for easy generation of Web testing UserAgents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:00:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:00:47 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-tmyHSq1Ihy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41254|0 |1 is obsolete| | Attachment #41460|0 |1 is obsolete| | Attachment #41524|0 |1 is obsolete| | Attachment #41525|0 |1 is obsolete| | --- Comment #10 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41534&action=edit Bug 14536 - PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:01:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:01:06 +0000 Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. In-Reply-To: <bug-14540-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14540-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14540-70-ALYoaP0xCS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41402|0 |1 is obsolete| | --- Comment #16 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41535&action=edit Bug 14540 - Move member-flags.pl to PermissionsManager to better manage permissions for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:01:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:01:26 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7174-70-HZiZfsOb4c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41413|0 |1 is obsolete| | --- Comment #22 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41536&action=edit Bug 7174 - Authentication Rewrite - Core -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:01:43 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7174-70-5dHyM0Cqvu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41312|0 |1 is obsolete| | --- Comment #23 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41537&action=edit Bug 7174 - Authentication Rewrite - Wrapper for C4::Auth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:02:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:02:01 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-QFyCp8DgGz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41326|0 |1 is obsolete| | --- Comment #120 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41538&action=edit Bug 13799: 1. RESTful API with Mojolicious and Swagger2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:02:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:02:18 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-5GouUOtHTT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41327|0 |1 is obsolete| | --- Comment #121 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41539&action=edit Bug 13799 - 1.1 RESTful API with reverse proxy configuration without api.host.domain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:09:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:09:53 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-excubVtKNW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Josef Moravec from comment #19) > And I had to install starman and perl module Plack::Middleware::ReverseProxy > > shouldn't it be at least documented somewhere? I'll fix both. Thanks Josef -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:15:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:15:25 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-udPz6S5Ygd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41328|0 |1 is obsolete| | --- Comment #122 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41540&action=edit Bug 13799 - 2. Set up logging and configuration file reading for Mojolicious. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:15:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:15:42 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-IkrUmXWRF0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41329|0 |1 is obsolete| | --- Comment #123 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41541&action=edit Bug 13799: 3. Force UTF-8 charset in responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:16:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:16:00 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-lUaldYpuMh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41330|0 |1 is obsolete| | --- Comment #124 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41542&action=edit Bug 13799: 4. API Authentication, part 1: API keys management in interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:16:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:16:22 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-iWPUaCb39V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41331|0 |1 is obsolete| | --- Comment #125 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41543&action=edit Bug 13799: 5. API authentication system - Swagtenticator authentication -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:16:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:16:43 +0000 Subject: [Koha-bugs] [Bug 14458] Add SwaggerUI documentation for RESTful API In-Reply-To: <bug-14458-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14458-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14458-70-JWodDtxvO4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14458 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41332|0 |1 is obsolete| | --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41544&action=edit Bug 14458: 5. Add SwaggerUI documentation for RESTful API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:16:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:16:59 +0000 Subject: [Koha-bugs] [Bug 14448] Hypnotoad and Nginx config for REST API In-Reply-To: <bug-14448-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14448-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14448-70-ANLDbls7XG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14448 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41333|0 |1 is obsolete| | --- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41545&action=edit Bug 14448 - Adding the REST API as a Hypnotoad service, koha-api-daemon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:17:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:17:20 +0000 Subject: [Koha-bugs] [Bug 14448] Hypnotoad and Nginx config for REST API In-Reply-To: <bug-14448-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14448-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14448-70-dAhA4YFFSr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14448 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41334|0 |1 is obsolete| | --- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41546&action=edit Bug 14448 - Nginx reverse proxy config baseline for Koha REST API. Tweaking needed to work with makefile. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:17:36 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-SSOpB5Lcry@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41273|0 |1 is obsolete| | --- Comment #126 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41547&action=edit Bug 13799 - 6. REST API Testing framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:17:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:17:55 +0000 Subject: [Koha-bugs] [Bug 13895] Add API routes for issues retrieval and renewal In-Reply-To: <bug-13895-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-WbsTzfSgs5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41163|0 |1 is obsolete| | --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41548&action=edit Bug 13895: 5. Add API routes for issues retrieval and renewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:18:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:18:23 +0000 Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves In-Reply-To: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13903-70-t4SKAOKxW9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41164|0 |1 is obsolete| | --- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41549&action=edit Bug 13903: 6. Add API routes to list, create, update, delete reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:18:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:18:37 +0000 Subject: [Koha-bugs] [Bug 14656] Delete Bibliographic Records REST API route & permission In-Reply-To: <bug-14656-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14656-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14656-70-bomFOi6njR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14656 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41550&action=edit Bug 14656 - Delete Bibliographic Records REST API route & permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:18:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:18:53 +0000 Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. In-Reply-To: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14680-70-M8Dts1QztL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41489|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41551&action=edit Bug 14680 - when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:22:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:22:07 +0000 Subject: [Koha-bugs] [Bug 14686] New: New menu option and permission for file uploading Message-ID: <bug-14686-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Bug ID: 14686 Summary: New menu option and permission for file uploading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Bug 14321 adds tools/upload.pl This report adds a specific permission and adds it to the menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:22:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:22:16 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: <bug-14686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14686-70-X5WAMJ11qT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:24:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:24:33 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-us2k8Ey9GY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:24:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:24:36 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-0mox4AH6HZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41552&action=edit Bug 14685: Fix set guarantor for a child account Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only a child can have a guarantor. Test plan: Create an adult patron and add a child. The guarantor info should be retrieved and set on the child creation page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:29:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:29:07 +0000 Subject: [Koha-bugs] [Bug 14687] New: Patron's transaction history changes items' order after paying fines. Message-ID: <bug-14687-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Bug ID: 14687 Summary: Patron's transaction history changes items' order after paying fines. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P4 Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com 1. Go to: Staff side -> Patrons -> X patron -> Fines -> *Create manual invoice* 2. Create one invoice with amount of 1. 3. Create other invoice with amount of 2. 4. Go to tab *Account* and take a look how the transactions are ordered. 5. Go to tab *Pay fines* and click Pay amount and then confirm. 6. Now you can see that in the *Account* tab the order of transactions have changed and that they go in the wrong order now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:56:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:56:11 +0000 Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines. In-Reply-To: <bug-14687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14687-70-yKKqZvZ3eJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41553&action=edit Bug 14687: Patron's transaction history changes items' order after paying fines. Sorts Patron's accounting data consistently from newest to oldest. It doesn't depend on anymore to timestamp (which can be same for multiple entries) from database but instead uses accountline's id to sort. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 14:57:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 12:57:24 +0000 Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines. In-Reply-To: <bug-14687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14687-70-9gpHkmQUpN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Test plan for the patch above: 1. Go to: Staff side -> Patrons -> X patron -> Fines -> *Create manual invoice* 2. Create one invoice with amount of 1. 3. Create other invoice with amount of 2. 4. Go to tab *Account* and take a look how the transactions are ordered. 5. Go to tab *Pay fines* and click Pay amount and then confirm. 6. Now you can see that in the *Account* tab the order of transactions have changed and that they go in the wrong order now. 7. Apply patch and see that the transactions are now ordered from newest to oldest. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:04:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:04:13 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-62Qncei9Ut@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41538|0 |1 is obsolete| | --- Comment #127 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41554&action=edit Bug 13799: 1. RESTful API with Mojolicious and Swagger2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:18:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:18:28 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-4ik9LCfiNK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41498|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41555&action=edit Bug 14321: Using Koha::Upload in tools/upload-file.pl This patch introduces Koha::Upload. It will replace the modules C4::UploadedFile.pm and the new C4::UploadedFiles.pm (from BZ 6874). This operation will be performed in a few steps. As a first step, we will use Koha::Upload instead of UploadedFile in the following places. (In these three places files are uploaded temporarily.) [1] stage-marc-import.pl [2] upload-cover-image.pl [3] offline_circ/process_koc.pl and enqueue_koc.pl A new file-upload.js replaces file-upload.inc in the associated template. We now use ajax to get progress figures instead of launching perl script upload-file-progress. Also we do not need the jquery plugin ajaxfileupload.js anymore. A subsequent patch will remove these files. The js changes now also allow for aborting a file upload. This feature has been added to stage-marc-import only for now. NOTE: In editing the process_koc.tt I noticed that the form enqueuefile was hidden and no longer used (with associated code in process_koc.pl). When a file has been uploaded, I display the form again (with the Apply directly button). The code still works. Test plan: [1] Upload a marc file in stage-marc-import. [2] Check new entry in table uploaded_files. Look for the file in the directory defined by upload_path in koha-conf.xml. [3] Upload another (larger) file and abort the upload. Check table and directory again. [4] Verify that Stage for import still works as expected. [5] Test Upload local cover image. (Enable OPACLocalCoverImages.) You can test an individual image or a zip file including images and a file called datalink.txt (with lines biblionumber,filename). [6] Test uploading a offline circulation file: Enable AllowOfflineCirculation, and create a koc file (plain text): Line1: Version=1.0\tA=1\tB=2 Line2: 2015-08-06 08:00:00 345\treturn\t[barcode] Note: Replace tabs and barcode. The number of tabs is essential! Checkout the item with your barcode. Go to Offline circulation file upload. Upload and click Apply directly. Checkout again. Upload again, click Add to offline circulation queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:18:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:18:31 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-nQ2JvRPAHn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41499|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41556&action=edit Bug 14321: Add some error checking to Upload.pm This patch makes Upload return some error codes if a file cannot be read or cannot be written. Test plan: [1] Upload a file with stage-marc-import.pl. This is a temporary file; it will be saved in your system's temporary dir (e.g. /tmp) within the folder koha_upload. [2] Change the owner of this koha_upload dir and remove write permissions. [3] Upload the file again. You should get: Upload status: Failed. [4] Restore owner and permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:18:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:18:35 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-H0ZiY5rBjY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41500|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41557&action=edit Bug 14321: Add public column to uploaded_files This patch adds uploaded_files.public. This column will be used to mark uploaded files as available via opac-retrieve. The db rev sets this flag for current records having a category (as uploaded via the BZ 6874 plugin: so public). A followup patch will adjust the plugin to use Koha::Upload. Test plan: [1] Run the dbrev. [2] Add a record (upload a file) via stage-marc-import. [3] Check that public is null in the new record. (This is a temporary file without category.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:18:39 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-V93C3B7Y5w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41501|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41558&action=edit Bug 14321: Redirect upload plugin to general upload script This patch makes the following changes to achieve that: [1] Adds a tools/upload script and template. It allows to upload multiple files at once. [2] Adds additional parameter to js function AjaxUpload (for category and public column). [3] Adds methods to Upload: count, delete, getCategories, httpheaders. [4] Makes upload-file return error messages in JSON. For a multiple upload, we could have some files with errors and others without errors. The upload is now marked as Failed only if there was no upload at all. [5] Adds decode_utf8 statement for UTF-8 chars in filenames (in the CGI hook). Note that we do not want the -utf8 flag here for binary uploads. [6] The upload plugin is converted to use tools/upload with plugin param. Deleting an upload is now presented via the search results form. NOTE: A unit test is supplied in a follow-up patch. Test plan: [1] Upload three files via tools/upload.pl with a category and marked as public. Check the results in the table. [2] Pick one new file and one of the files of step 1. Upload them in the same category. One upload should succeed. Check for reported error. [3] Upload a file via stage-marc-import. Stage it. [4] Go to Cataloguing editor. Connect upload.pl to field 856$u. In an empty 856$u, click the tag editor. Upload a file and click Choose. Save the record. Open the record in the OPAC and click the link. Copy this link to your clipboard for step 5. [5] Go back to editor. Click the tag editor on the same 856 field. Choose for Delete. Open the link in your clipboard again. [6] Check the process of upload, search, download and delete of an upload with some diacritical characters in the filename. (Bonus points for adding special chars in the category code.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:18:46 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-xZ5gKLVXwH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41560&action=edit Bug 14321: Unit test for Koha::Upload This unit test replaces the test for UploadedFiles.pm. That one used dependency Test::CGI::Multipart. We are now mocking CGI and its hook to achieve the same result. Some tests are added to cover additional routines in Upload.pm. Test plan: Run the test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:18:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:18:42 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-GlEsuLOj65@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41559&action=edit Bug 14321: Switch to Upload in opac-retrieve A last step to obsolete UploadedFiles.pm. Note that we now also check for the public flag. If that flag is not set, the uploaded file cannot be reached via the opac. Test plan: [1] Check downloading a file marked public in OPAC without logging in. [2] Check another file (not marked as public). Should not be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:18:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:18:49 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-9pTDS7MW5o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41561&action=edit Bug 14321: Fix permissions check in upload-file.pl This fixes an error in one of the patches of bug 6874. The userid of the Koha admin user is passed to haspermission, but we should pick the userid from the session. NOTE: Bug 14686 will add a specific permission for tools/upload.pl. At that time we can add the script to the Tools menu too. For now, you need edit_catalogue to start upload.pl and you will additionally need a permission like upload_local_cover_images (see tools/upload-file) to successfully upload a new file. Searching for files and copying URLs to the editor can still be done with edit_catalogue. Test plan: [1] Pick a staff user that only has catalogue and edit_catalogue. [2] Without this patch, you can upload a file on tools/upload.pl. [3] Apply this patch. [4] Retry. Should not work: Upload status is Denied. [5] Login with enough permissions. Upload again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:18:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:18:53 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-gmi0C3wkYY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41562&action=edit Bug 14321: Final cleanup, removing obsolete files The new Upload.pm, unit test and file-upload.js obsolete a number of files, including an older jQuery plugin. The test files progressbar.pl and progressbarsubmit.pl are outdated and do not serve any purpose in this form. (Actually, we could argue if they should be here or just be part of a debugging phase.) Test plan: [1] Git grep on file-progress, file-upload.inc, UploadedFile, ajaxfileupload, ajaxFileUpload UploadedFile: Only a reference to DBIx file is found ajaxfileupload: Only release notes [2] Upload a file with tools/upload and stage-marc-import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:19:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:19:15 +0000 Subject: [Koha-bugs] [Bug 14686] New menu option and permission for file uploading In-Reply-To: <bug-14686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14686-70-h7NVVDJ2MR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14686 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14321 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:19:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:19:15 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-deineXYKkR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14686 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:23:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:23:19 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-9kpYct7ONZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- At the end, this patch set actually reduces code. Another bug will take care of menu and permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:24:30 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: <bug-11297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11297-70-y5QYi0BVS1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #11 from Blou <philippe.blouin at inlibro.com> --- fyi, There is nothing in the current patch that would prevent "4=109 and 4=1". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:27:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:27:05 +0000 Subject: [Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature (see also 6874) In-Reply-To: <bug-14294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14294-70-FPLsiF4fVX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Submitted bug 14321 now (larger patch, one module instead of two; and some additional benefits) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:32:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:32:15 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14584-70-xTeEeK9JJf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 --- Comment #3 from Blou <philippe.blouin at inlibro.com> --- Well, I'm fine with that, but isn't it just making this function useless? I think what you're suggesting is what it was before the latest change. I just presumed there had been a need for that "encode('UTF-8'" call... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:46:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:46:16 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-VfcVmFEzOv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41508|0 |1 is obsolete| | --- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41563&action=edit Bug 13791: Plack out-of-the-box support on packages This patch introduces a koha-plack script that controls running Plack processes for each instance. They are run using 'starman', listening on a Unix Domain Socket (UDS): /var/run/koha/<instancename>/plack.sock The plack configuration file[1] is expected to be on: /etc/koha/plack.psgi and is installed by the package. It also adds the following helper functions to koha-functions.sh: - is_plack_enabled - is_plack_running Done: - koha-plack script - suitable psgi file To test this patches you will need to install - starman - libplack-middleware-reverseproxy-perl [1] Yeah, a single file. Because we will be relying on multiple mount points for each "app" (i.e. 'opac' and 'intranet', and 'api' ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:46:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:46:25 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-ynOFQOMmck@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41509|0 |1 is obsolete| | --- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41564&action=edit Bug 13791: Apache configuration files This patch adds an include to each VirtualHost definition (OPAC and Intranet) and a variable definition, taking advantage of Apache 2.4.x features. The instance name is reused inside the includes providing a simple way of dealing with the apache <-> plack configuration. A check for the right apache version is introduced, in the for of an IfVersion block: <IfVersion >= 2.4> --- Plack configuration here --- </IfVersion> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:46:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:46:30 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-4TcAGFKsat@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41510|0 |1 is obsolete| | --- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41565&action=edit Bug 13791: koha-plack documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:46:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:46:35 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-IcY0HXHtjL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41511|0 |1 is obsolete| | --- Comment #24 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41566&action=edit Bug 13791: make koha-list aware of plack This patch adds the --plack and --noplack option switches to koha-list for filtering instances to be listed. This is particularly important for init scripts and cronjobs. To test: - Play with koha-list --plack and koha-plack --enable/--disable and verify that koha-list returns the expected results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:46:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:46:40 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-2lmzPqvuw9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41512|0 |1 is obsolete| | --- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41567&action=edit Bug 13791: make koha-common init script aware of plack This patch makes the packages' koha-common script aware of plack. It does so by relying on koha-list --plack to know which instances have Plack configured, and uses the koha-plack script to manage the running daemons. It also introduces a plack_status function to check the status of the Plack daemon when called: $ servive koha-common status Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:46:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:46:46 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-pVDBtqxWO0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41513|0 |1 is obsolete| | --- Comment #26 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41568&action=edit Bug 13791: tab-completion for koha-plack in bash This patch adds tab-completion in bash for the koha-plack command. After the --start, --stop, --restart and --disable switches it only offers plack-enabled instances. And disabled instances to --enable. --help and -h just finish end the completion. --quiet and -q are trickier to implement. They will work (be offered) only before the action switches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 15:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 13:49:51 +0000 Subject: [Koha-bugs] [Bug 14592] Export data bad encoding In-Reply-To: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14592-70-xO64T7QxKV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 16:13:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 14:13:04 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-lCP90NW5yg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14536 |7174 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 [Bug 7174] Authentication rewriting http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 16:13:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 14:13:04 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7174-70-6U3Yu5wiA5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14620 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 [Bug 14620] Contact information validations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 16:13:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 14:13:04 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-kHiTq0PWpD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14620 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 [Bug 14620] Contact information validations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 18:30:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 16:30:03 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10314-70-VNBapurgg8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 18:53:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 16:53:24 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-CAjvXQtan9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41569&action=edit Bug 14337 [QA Followup] - Add unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 18:53:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 16:53:34 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-n44yk9fdJa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 18:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 16:54:08 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-V9y7uPC6bA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #6 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #4) > Kyle, please provide tests for this change. Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 21:22:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 19:22:04 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-9za3ZWThhY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 23:16:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 21:16:58 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-wEZmdL6LeS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 23:17:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 21:17:00 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-dxlJ7akmfL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41552|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 41570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41570&action=edit Bug 14685: Fix set guarantor for a child account Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only a child can have a guarantor. Test plan: Create an adult patron and add a child. The guarantor info should be retrieved and set on the child creation page. Signed-off-by: Liz Rea <liz at catalyst.net.nz> Guarantor details now coming through and ability to add a guarantor restored. Thanks for the quick fix, Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 23:43:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 21:43:32 +0000 Subject: [Koha-bugs] [Bug 14688] New: Cannot set guarantor for an organisation -> professional account Message-ID: <bug-14688-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14688 Bug ID: 14688 Summary: Cannot set guarantor for an organisation -> professional account Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: critical Priority: P3 Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 13970 Similar to 14685, one cannot set organisational links between accounts any more as well, the box is not displayed to add a guarantor to a professional account. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 [Bug 13970] Remove related code to category_type -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 23:43:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 21:43:32 +0000 Subject: [Koha-bugs] [Bug 13970] Remove related code to category_type In-Reply-To: <bug-13970-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13970-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13970-70-byQwX6OibK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14688 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14688 [Bug 14688] Cannot set guarantor for an organisation -> professional account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 17 23:43:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 21:43:32 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-hipAWpOoqT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14688 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 00:45:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 22:45:42 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-6Ifk7LkDoF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 00:46:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Aug 2015 22:46:01 +0000 Subject: [Koha-bugs] [Bug 14688] Cannot set guarantor for an organisation -> professional account In-Reply-To: <bug-14688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14688-70-D84OeBqraz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14688 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 05:46:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 03:46:20 +0000 Subject: [Koha-bugs] [Bug 9983] printable fines page should include name/barcode In-Reply-To: <bug-9983-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9983-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9983-70-JYF4PWOte8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9983 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #5 from Barton Chittenden <barton at bywatersolutions.com> --- You could do it something like this: in intranetuserCSS: @media screen { .stuff { visibility: hidden; } } @media print { .stuff { ... name and barcode styling goes here ... } } Then we need to add something like this to the .tt file for the fines page: <div class="stuff">... Name and/or barcode information ....</div> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 05:51:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 03:51:32 +0000 Subject: [Koha-bugs] [Bug 10190] notices based on item type In-Reply-To: <bug-10190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10190-70-ad4JqjefZ4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #1 from Barton Chittenden <barton at bywatersolutions.com> --- This is standard behavior now, right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:01:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:01:34 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-UeRfDL4NeF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:02:03 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-8ogd5TPjZU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41563|0 |1 is obsolete| | --- Comment #27 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 41571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41571&action=edit Bug 13791: Plack out-of-the-box support on packages This patch introduces a koha-plack script that controls running Plack processes for each instance. They are run using 'starman', listening on a Unix Domain Socket (UDS): /var/run/koha/<instancename>/plack.sock The plack configuration file[1] is expected to be on: /etc/koha/plack.psgi and is installed by the package. It also adds the following helper functions to koha-functions.sh: - is_plack_enabled - is_plack_running Done: - koha-plack script - suitable psgi file To test this patches you will need to install - starman - libplack-middleware-reverseproxy-perl [1] Yeah, a single file. Because we will be relying on multiple mount points for each "app" (i.e. 'opac' and 'intranet', and 'api' ;-) ) Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:02:12 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-zm32XGsycp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41564|0 |1 is obsolete| | --- Comment #28 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 41572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41572&action=edit Bug 13791: Apache configuration files This patch adds an include to each VirtualHost definition (OPAC and Intranet) and a variable definition, taking advantage of Apache 2.4.x features. The instance name is reused inside the includes providing a simple way of dealing with the apache <-> plack configuration. A check for the right apache version is introduced, in the for of an IfVersion block: <IfVersion >= 2.4> --- Plack configuration here --- </IfVersion> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:02:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:02:19 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-85wQJMIk5W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41565|0 |1 is obsolete| | --- Comment #29 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 41573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41573&action=edit Bug 13791: koha-plack documentation Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:02:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:02:26 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-i8cZiWkIy8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41566|0 |1 is obsolete| | --- Comment #30 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 41574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41574&action=edit Bug 13791: make koha-list aware of plack This patch adds the --plack and --noplack option switches to koha-list for filtering instances to be listed. This is particularly important for init scripts and cronjobs. To test: - Play with koha-list --plack and koha-plack --enable/--disable and verify that koha-list returns the expected results. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:02:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:02:33 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-7veShejVaQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41567|0 |1 is obsolete| | --- Comment #31 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 41575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41575&action=edit Bug 13791: make koha-common init script aware of plack This patch makes the packages' koha-common script aware of plack. It does so by relying on koha-list --plack to know which instances have Plack configured, and uses the koha-plack script to manage the running daemons. It also introduces a plack_status function to check the status of the Plack daemon when called: $ servive koha-common status Regards Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:02:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:02:40 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-mvBqLyWKT8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41568|0 |1 is obsolete| | --- Comment #32 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 41576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41576&action=edit Bug 13791: tab-completion for koha-plack in bash This patch adds tab-completion in bash for the koha-plack command. After the --start, --stop, --restart and --disable switches it only offers plack-enabled instances. And disabled instances to --enable. --help and -h just finish end the completion. --quiet and -q are trickier to implement. They will work (be offered) only before the action switches. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:10:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:10:28 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-cDHAGiSocI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:10:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:10:31 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-y4L1X4VYY5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41570|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41577&action=edit Bug 14685: Fix set guarantor for a child or professional accounts Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only children or professional can have a guarantor. Test plan: 1/ Create an adult patron and add a child. 2/ The guarantor info should be retrieved and set on the child creation page. 3/ Create an organization and add a child 4/ The guarantor info should be retrieved and set on the adult creation page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:10:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:10:51 +0000 Subject: [Koha-bugs] [Bug 14688] Cannot set guarantor for an organisation -> professional account In-Reply-To: <bug-14688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14688-70-y2WuG0pWKY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14688 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 14685 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:10:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:10:51 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-1V8A8Jy8ee@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 14688 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 10:11:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 08:11:57 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-9SxpVXKgQz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Liz, thanks for testing! I have marked bug 14688 as duplicate, the patch should fix the 2 regressions (more?) introduced by bug 13970. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 12:23:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 10:23:21 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: <bug-12426-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12426-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12426-70-VyjFTYXTIg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 13:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 11:43:58 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-YAb3xGm1xM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41578&action=edit Bug 14529: The new list permission is 'lists', not 'shelves' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 13:44:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 11:44:13 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-4Sva60TCCQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 14:03:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 12:03:51 +0000 Subject: [Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made In-Reply-To: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14675-70-uEO5e8zIqz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin at bugs.koha-community. | |org.xinxidi.net Status|NEW |ASSIGNED CC| |martin at bugs.koha-community. | |org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 14:14:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 12:14:12 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: <bug-14244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14244-70-5shXEK8sVA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #1 from Tom Misilo <misilot at fit.edu> --- Would catalogue => "*" make sense here? If so I can make a patch for it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:45:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:45:50 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-k4FkZCRfSR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6279 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:45:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:45:50 +0000 Subject: [Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC In-Reply-To: <bug-6279-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6279-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6279-70-1s7nl0Oqzy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 --- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Will be fixed by 14544. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:47:46 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-CqCqDKM7S0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:47:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:47:49 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-bo9NumBvlP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40749|0 |1 is obsolete| | Attachment #40750|0 |1 is obsolete| | Attachment #40751|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41579&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:47:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:47:58 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-ShrKbr87TE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #40 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41580&action=edit Bug 8352 - Add printer administration, update script to use Koha defined printers This patch adds the ability to define printers within Koha. The printer CRUD is based on the code for the quote of the day system. This patch extends the existing ability to print via LPR to any network printer with the added ability to print to a CUPS printer configured on the Koha server. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Browse to admin/printers.pl 4) Configure a network printer via LPR ( explained in the printers help ) 5) Create a hold 6) Execute the command "misc/cronjobs/holds/print_holds.pl -v --printer $BRANCHCODE=$PRINTER_ID where branchcode is the pickup branch for the hold, and printer_id is the id number for the printer. 7) See your reserve slip is printer! Bonus points: Repeat the test plan, but for a printer you set up via CUPS on the Koha server -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:48:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:48:01 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-1aGbyuyS44@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41581&action=edit Bug 8352 [QA Followup] - Fix column type in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:48:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:48:04 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-NscRGYExFW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41582&action=edit Bug 8352 [QA Followup] * Add --confirm option to print_holds.pl * Modify old_reserves to match reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:48:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:48:08 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-ZDr8vOVf1T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41583&action=edit Bug 8352 [QA Followup] - Don't use SQL in pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:16 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-uO0qKsIydZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41042|0 |1 is obsolete| | Attachment #41403|0 |1 is obsolete| | Attachment #41404|0 |1 is obsolete| | Attachment #41405|0 |1 is obsolete| | Attachment #41406|0 |1 is obsolete| | Attachment #41407|0 |1 is obsolete| | Attachment #41408|0 |1 is obsolete| | Attachment #41409|0 |1 is obsolete| | Attachment #41410|0 |1 is obsolete| | Attachment #41411|0 |1 is obsolete| | Attachment #41412|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41584&action=edit Bug 14544: Add Koha::Virtualshelf and Koha::Virtualshelves The 2 modules C4::VirtualShelves and C4::VirtualShelves::Page are really badly coded and buggy. It became complicated to fix and enhance them. This rewrite will make the code more robust and the list feature will be easier to change. Some new modules are added to the Koha namespace (Koha::Virtualshelf, Koha::Virtualshelves, Koha::Virtualshelfshare[s] and Koha::Virtualshelfcontent[s]) to take advantage of Dbix::Class. The patchset fixes some bugs: 1/ Bug 6279 - Can't delete lists from the second page of lists in the OPAC 2/ The owner of a list should not need any permission to remove content from his lists. 3/ No feedback messages when actions are done Test plan: A) Intranet and OPAC 1/ Create more than 20 private and public lists with different users 2/ Edit some and confirm that the changes are taken into account 3/ Share some lists with other users 4/ Add / remove contents Be sure you have some lists with more than 20 items (to test the pagination) 5/ Play with permissions and confirm it works as expected. For private lists: They should not be viewed by anyone else, if they are not shared If they are shared (OPAC only): a. "Allow anyone else to add entries" Should allow the user with whom the list is shared to add entries. b. "Allow anyone to remove his own contributed entries." Should allow the user with whom the list is shared to remove his own entries. c. "Allow anyone to remove other contributed entries." Should allow the user with whom the list is shared to remove any entries. For public lists: They should be viewed by anyone else. a. "Allow anyone else to add entries" Should allow any user to add entries. b. "Allow anyone to remove his own contributed entries." Should allow any user to remove his own entries. c. "Allow anyone to remove other contributed entries." Should allow any user to remove any entries. 6/ Download and sent lists. 7/ Confirm that the "Add to" feature works as expected. 8/ Confirm that the "Add an item to" works as expected. 9/ Delete some lists. 10/ Print some lists and subscribe to the RSS feed (OPAC only) (with more than 20 items). 11/ Use the remove "Remove share" links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:21 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-Hd7QcJxrof@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41585&action=edit Bug 14544: Get rid of GetShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:24 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-K2MGSnqkY7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41586&action=edit Bug 14544: Get rid of AddShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:27 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-WJq4Ng5i6O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41587&action=edit Bug 14544: Get rid of DelShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:31 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-tAS5eiATGx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41588&action=edit Bug 14544: Get rid of ModShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:34 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-VmtWfkYsza@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41589&action=edit Bug 14544: Move share routines to Koha::Virtualshelfshare and Koha::Virtualshelfshares -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:37 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-yg97lg32mU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41590&action=edit Bug 14544: Get rid of GetAllShelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:40 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-pObRzOdDQm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41591&action=edit Bug 14544: Koha::Virtualshelfcontent[s] Get rid of AddToShelf and DelFromShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:44 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-mo6mJbG89S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41592&action=edit Bug 14544: Make the intranet side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:47 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-2jjqbtQxPh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41593&action=edit Bug 14544: Get rid of GetBibliosShelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:50 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-I85b4pE4jl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41594&action=edit Bug 14544: Get rid of GetShelves This does not work for now, see later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:54 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-CvOojMo97l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41595&action=edit Bug 14544: Make the OPAC side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:54:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:54:57 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-FMfywwxGeh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41596&action=edit Bug 14544: Get rid of ShelfPossibleAction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:55:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:55:04 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-nqc0V6AMkw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41598&action=edit Bug 14544: Get rid of GetSomeShelfNames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:55:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:55:00 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-S39stWOxz1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41597&action=edit Bug 14544: Get rid of GetShelfContent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:55:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:55:07 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-jjmhXYHXCc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41599&action=edit Bug 14544: Move HandleDelBorrower to C4::Members -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:55:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:55:10 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-scnYr57MPA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41600&action=edit Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:55:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:55:14 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-Rwnw2Ogm1e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41601&action=edit Bug 14544: Remove wrong tips about permissions The owner of a list should not need any permission to remove contents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 15:55:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 13:55:44 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-KYoy6zhU2s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:04:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:04:39 +0000 Subject: [Koha-bugs] [Bug 13970] Remove related code to category_type In-Reply-To: <bug-13970-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13970-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13970-70-BXXRBdBuvD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:10:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:10:44 +0000 Subject: [Koha-bugs] [Bug 14374] dont use mysql_auto_reconnect with DBIx::Connector In-Reply-To: <bug-14374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14374-70-IjL52qfFPk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:19:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:19:04 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10314-70-4L3tJ8jvY4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Kyle, could you please provide tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:20:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:20:48 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-OrKRiNeBcq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Only the first patch is signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:21:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:21:49 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-wPCMdLFiZs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- svc/printer does not follow the coding guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:28:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:28:27 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14498-70-YK1v04VCb0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:28:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:28:29 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14498-70-badjWSvFA3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40810|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41602&action=edit Bug 14498 - uri_escape error triggered by duplicate accountno's for patron If a patron has duplicate accountno's for two different fines in Koha this will trigger the error usi_escape: Unmatched [ in regex; marked by <-- HERE in m/([ <-- HERE ])/ at (eval 133) line 1. upon attempt to pay. How those accountno's get duplicated is unknown, but considering accountno is somewhat vestigial at this point in time, it would be much more sensible to use accountlines_id which is has guaranteed uniqueness at the database level. Test Plan: 1) Create a patron with 2 fines 2) Edit the accountno's for those fines and set them to 0 3) Attempt to pay one, note the error 4) Apply this patch 5) Refesh the page 6) Attempt to pay one, no error this time! 7) Test Pay, Write off, Pay amount, Write off all, and Pay selected Signed-off-by: Deborah Duce <deborah.duce at huntsvillelibrary.ca> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:30:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:30:20 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10314-70-ZDlTaZMjJw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |barton at bywatersolutions.com --- Comment #20 from Barton Chittenden <barton at bywatersolutions.com> --- I'll write the unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:35:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:35:27 +0000 Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page In-Reply-To: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14579-70-BIOl2XVcMC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to cnorthcott.work from comment #2) > Patch applies, link now works but alignment of Log In text and Help text are > mismatched. Aleisha, could you try to fix the alignment? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:35:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:35:42 +0000 Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page In-Reply-To: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14579-70-iTGwlexx7U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:37:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:37:13 +0000 Subject: [Koha-bugs] [Bug 14681] Warn when adding help to 404 page In-Reply-To: <bug-14681-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14681-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14681-70-Ar05GurGSZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14681 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:39:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:39:07 +0000 Subject: [Koha-bugs] [Bug 14580] Warn when accessing Help from error pages In-Reply-To: <bug-14580-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14580-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14580-70-wH5ZuZwFm0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14580 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |minor Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- We would like a global solution here. themelanguage should be fixed not to return undef. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:41:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:41:38 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-IQ9W42tNJg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:41:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:41:40 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-2S3A4EfHoq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41495|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41603&action=edit Bug 14484: warns when changing patron pw To test: 1) Go to any patron's page, click Change password 2) Notice warns in error log 3) Apply patch, reload page 4) Click Change password 5) Notice warns are gone and page still works correctly Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:46:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:46:53 +0000 Subject: [Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense In-Reply-To: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14574-70-XA1WbKjLfL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:46:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:46:55 +0000 Subject: [Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense In-Reply-To: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14574-70-hH0TnFdLHr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41522|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41604&action=edit Bug 14574: Fixing error messages on staff client so they make more sense To test: 1) Go to cgi-bin/koha/errors/errornumber.pl to see the error messages which currently don't make sense (ie cgi-bin/koha/errors/401.pl etc). Have only made changes to 401, 403 and 404 2) Apply patch 3) Go to cgi-bin/koha/errors/401.pl --> Check that it now says "This error means that you aren't authorized to view this page." and "Please log in and try again.". Check that 'log in' redirects to the log in page (mainpage.pl). 4) Go to cgi-bin/koha/errors/403.pl --> Check that it now says "This error means that you are forbidden to view this page." 5) Go to cgi-bin/koha/errors/404.pl --> This page should be very different. Check that the 'Error 404' is now in italics and not bold. Check that the page gives a list of reasons the user may have been given this error and some options for their next step. Signed-off-by: Catherine <cnorthcott.work at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Amended patch: replace tab with 4 spaces. Note: I am not sure the em tag is useful here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:47:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:47:20 +0000 Subject: [Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense In-Reply-To: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14574-70-thN2Psf5Xg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:49:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:49:11 +0000 Subject: [Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made In-Reply-To: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14675-70-0X5DbBYB6q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 --- Comment #1 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Created attachment 41605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41605&action=edit Bug 14675: Don't update details if no changes made if no changes has been made for personal details, bring user back to details page and inform them that no changes has been made. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 16:50:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 14:50:57 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: <bug-11297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11297-70-a5QJhSsNtT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Blou from comment #11) > fyi, There is nothing in the current patch that would prevent "4=109 and > 4=1". There is nothing in the current patch to make it possible :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:01:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:01:48 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-PlzFy32Hzu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #45) > svc/printer does not follow the coding guidelines. forget that, it's done in the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:07:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:07:29 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-WpijGNFdBp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35533|0 |1 is obsolete| | Attachment #35534|0 |1 is obsolete| | Attachment #35535|0 |1 is obsolete| | Attachment #35536|0 |1 is obsolete| | Attachment #35537|0 |1 is obsolete| | Attachment #35538|0 |1 is obsolete| | Attachment #35918|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41606&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print > Print overdues Signed-off-by: Amy Purvis <APurvis at galencollege.edu> Signed-off-by: Laurie McKee <lmckee at littleelm.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:07:46 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-A8eeKaDA7V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41607&action=edit Bug 12933 - Add new OVERDUES_SLIP letter Signed-off-by: Amy Purvis <APurvis at galencollege.edu> Signed-off-by: Laurie McKee <lmckee at littleelm.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:07:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:07:48 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-5RFbBhm6h0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41608&action=edit Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:07:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:07:51 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-clxMhpPFzd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41609&action=edit Bug 12933 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:07:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:07:54 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-AGLcrsITM6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #38 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41610&action=edit Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:07:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:07:57 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-bsdM6CgGze@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41611&action=edit Bug 12933 [QA Followup] - Remove Template plugin and use thereof -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:08:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:08:43 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-Tp8NaNrsIN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com Attachment #41611|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:10:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:10:12 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-V5ICMkW5Oi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jesse Weaver from comment #9) > Doing this with "SELECT borrowernumber FROM borrowers WHERE privacy = 2 > LIMIT 1" ran in 0.02s on one of our largest sites (~125K borrowers), so it > is practical. I don't understand why you want that, could you please detail? Have a look at the updatedb entry 3.21.00.013, we were careful to raise a warning if needed. I don't think it's worth to add a select statement for every checkin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:14:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:14:12 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: <bug-14672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14672-70-AxYwN12dXY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 --- Comment #2 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41612&action=edit Bug 14672 - Payment is not able to done, when the patron has credit balance Enables paying with credit, at least when using C4::Accounts::recordpayment function. The code is still buggy and needs more work. Sponsored-by Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:16:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:16:27 +0000 Subject: [Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made In-Reply-To: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14675-70-KxCbDmIWLy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:16:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:16:34 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-ZyrTphrOPD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #40 from Kyle M Hall <kyle.m.hall at gmail.com> --- > > By using a TT plugin, we don't have to modify each and every script that > > uses the members toolbar. > > Yes, but it's the way it's done everywhere into Koha. > I still really don't like to see an other overhead to get this kind of info. There is no sacrifice or performance using this method. In fact, based on my followup, using the plugin results in somewhat better performance! The key here is that just because we've always done something in a particular way doesn't mean we should keep doing it that way. In fact, we have precedence for this very pattern. Once we introduced the plugin for getting system preferences, we began to remove the template parameters that only passed system preferences. There is no need to fetch the values in the script and pass them to the template, because the script has absolutely no need for them. Doing so only added unnecessary complexity and by using a plugin we greatly reduce that complexity. This is essentially the exact same issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:17:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:17:33 +0000 Subject: [Koha-bugs] [Bug 14585] Fixing up the online help on main page In-Reply-To: <bug-14585-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14585-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14585-70-BWzAQt1ZGB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14585 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Letting the QA step to a English native speaker. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:17:47 +0000 Subject: [Koha-bugs] [Bug 14585] Fixing up the online help on main page In-Reply-To: <bug-14585-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14585-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14585-70-LrLvbEwHIv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14585 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:23:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:23:47 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-O3aUccvVA7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #1) >(Note that Class::->method is preferred above Class->method. See perlobj.) I did not find where it's written it's better. I personally think you are adding a third way where we already have new CGI and CGI->new... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:23:44 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: <bug-14672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14672-70-6o41VpexQk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- You can try the above patch I just made, it works like that that you have first few invoice and credit entries in the patron's account you're testing, and then after that go and pay all the fines/invoices at once, and it should work. I think that the result of it wasn't consistent all the time, but it might have been... I will look into testing this tomorrow and hope that some of you will also! :) Is the implementation way I used good? I think we need to implement the same kind of code also in recordpayment_selectaccts, makepartialpayment, makepayment, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:25:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:25:56 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-hude2cnKV4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:25:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:25:58 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-JZPIOzUkW3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40976|0 |1 is obsolete| | Attachment #41578|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41613&action=edit [SIGNED-OFF] Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:26:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:26:06 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-XykdKwmMaw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41614&action=edit [SIGNED-OFF] Bug 14529: The new list permission is 'lists', not 'shelves' Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:27:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:27:37 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-mgRkZewUzv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com Attachment #41613|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:27:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:27:45 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-fBsjcfrJlg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:27:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:27:51 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-3YO62zV7sO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41578|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:27:57 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-1786Ai9ihQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40976|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:28:05 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-AxmeRv734H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:29:05 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: <bug-14639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14639-70-fmvvvVU0LT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 41387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41387 Bug 14639: Extend Koha::MetadataRecord to handle serialization format and record id Review of attachment 41387: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14639&attachment=41387) ----------------------------------------------------------------- ::: Koha/MetadataRecord.pm @@ +84,5 @@ > + > + my $record = $params->{ record }; > + my $schema = $params->{ schema } // 'marc21'; > + my $format = $params->{ format } // 'MARC'; > + my $id = $params->{ id }; Don't you think these 4 params should be mandatory? I would raise an exception if one of them is not given to the constructor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:30:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:30:13 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-QuJiyBrgQN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40976|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41615&action=edit [SIGNED OFF] Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission. Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:30:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:30:21 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-BhGc9xhuKW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41578|0 |1 is obsolete| | --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41616&action=edit [SIGNED OFF] Bug 14529: The new list permission is 'lists', not 'shelves' Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:30:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:30:47 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-B7xdRmLJ1D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:32:39 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-drXXQx4rCU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:32:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:32:42 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-Eab0DmOe8l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41615|0 |1 is obsolete| | Attachment #41616|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41617&action=edit [PASSED QA] Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission. Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:32:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:32:50 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-ZxNtZ0xRvQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41618&action=edit [PASSED QA] Bug 14529: The new list permission is 'lists', not 'shelves' Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:38:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:38:11 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14517-70-yZnGFvffhL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Chris Cormack from comment #7) > I just noticed that our To plugin, we just use to do JSON .. In future we > could maybe use this? But this is a just a comment. No reason to hold the bug > > http://search.cpan.org/~nuffin/Template-Plugin-JSON-0.06/lib/Template/Plugin/ > JSON.pm The idea was to avoid another dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:42:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:42:31 +0000 Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch In-Reply-To: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14297-70-PDMRSg44Ja@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:42:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:42:58 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-tzJBneLdyE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:47:04 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: <bug-11297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11297-70-x8JU8U5Fau@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #13 from Blou <philippe.blouin at inlibro.com> --- Actually, I said that because the old patch (which was waaay impossible to apply anymore) would have replaced one 4= by another. In this new patch, Maxime prepends the 4=1 to whatever is there by default (4=109, let say), so I figure both are sent. small characters: But I might be wrong. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:54:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:54:13 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-wTFSGegSCt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:54:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:54:16 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-P2HnVoejvG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41473|0 |1 is obsolete| | Attachment #41474|0 |1 is obsolete| | Attachment #41475|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41619&action=edit Bug 11229: (regression tests) makepayment and makepartialpayment should log correctly This patch introduces tests for makepayment and makepartialpayment to check they are correctly logging to the statistics table. To test: - Run $ prove t/db_dependent/Accounts.t => FAIL: tests fail because statistics are not correctly logged. Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:54:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:54:22 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-wADkgz34nt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41620&action=edit Bug 11229: makepayment doesn't log branch in statistics correctly This patch fixes makepayment() so it correctly logs the branch code to the statistics table. To test: - Run (with the regression tests applied) $ prove t/db_dependent/Accounts.t => FAIL: makepayment() tests fail because logging is wrong - Apply the patch - Run $ prove t/db_dependent/Accounts.t => SUCCESS: tests for makepayment now pass (Note: makepartialpayment tests still fail as they need the next patch) Original commit message relying on the UI to test: There are several ways of paying fines, not all of them recorded the branch the payment was made at correctly: 1) Pay button next to an individual fine 2) Checkbox + pay amount 3) Checkbox + pay selected For each of those, check if the payment registered in the table statistics contains the branchcode before and after the patch. The patch should fix 1). 2) and 3) are ok with and without the patch. Important: Don't change the amount, pay individual fines. Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> Note: i fixed the commit message, because this is a fix for makepayment Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:54:26 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-2N76zp2d6R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41621&action=edit Bug 11229: (followup) makepartialpayment fix makepartialpayment() wasn't logging the branch either. This patch fixes that too. To test: - Run (with the regression tests applied) $ prove t/db_dependent/Accounts.t => FAIL: tests fail because makepartialpayment is not logging the branch code - Apply the patch - Run $ prove t/db_dependent/Accounts.t => SUCCESS: tests pass - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:54:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:54:30 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-spsOKKBHGo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41622&action=edit Bug 11229: Make the tests pass even if issues exist in the DB This is not introduced by the previous patches of this patchset. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:54:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:54:34 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-OlR0FBldQd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41623&action=edit Bug 11229: Remove error rollback ineffective with AutoCommit enabled The full error is: rollback ineffective with AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1621. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:55:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:55:58 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-xptiyCRGVe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #14) > Created attachment 41623 [details] [review] > Bug 11229: Remove error rollback ineffective with AutoCommit enabled > > The full error is: > rollback ineffective with AutoCommit enabled at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1621. > > Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> RM: Feel free to skip this one if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 17:56:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 15:56:29 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-h8OpRjqixB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #15) > (In reply to Jonathan Druart from comment #14) > > Created attachment 41623 [details] [review] [review] > > Bug 11229: Remove error rollback ineffective with AutoCommit enabled > > > > The full error is: > > rollback ineffective with AutoCommit enabled at > > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1621. > > > > Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> > > RM: Feel free to skip this one if you disagree. As usual ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:01:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:01:48 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14517-70-ggOmHRvFT8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41467|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41624&action=edit [PASSED QA] Bug 14517: List shelves list is broken for translated interfaces The translation script adds quotes ("") around translated string (Edit for instance). Which breaks the json structure. Example: "dt_action": "<a style=\"cursor:pointer\"><form action='shelves.pl' method='get'><input class="editshelf" value="Editar" type="submit" /></form></a>" Test plan: 1/ On the staff interface create a private list 2/ Go to More > Lists ('Your lists' tab) 3/ Translate the templates to any language like: $ cd misc/translator/ $ perl translate install es-ES 4/ Enable the translated templates on the sysprefs 5/ Switch to the translated language 6/ Go to the lists page (Mas > Listas in es-ES) The list should be displayed correctly. Note: There is a limitation. If a translated string contains a simple quote ('), it will also break the json. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:01:45 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14517-70-isckA0BuM9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:15:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:15:21 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-7UddjHxQGV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41623|0 |1 is obsolete| | --- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Comment on attachment 41623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41623 Bug 11229: Remove error rollback ineffective with AutoCommit enabled The problem is generated by how TestBuilder is coded. We should fix it instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:19:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:19:00 +0000 Subject: [Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense In-Reply-To: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14574-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14574-70-QCMPjup1aB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:19:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:19:11 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-yDDep35I8P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:19:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:19:29 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14517-70-Yg8ODoikji@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Great job Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:19:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:19:51 +0000 Subject: [Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table In-Reply-To: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11229-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11229-70-ehLQn2lTdf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:22:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:22:45 +0000 Subject: [Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format In-Reply-To: <bug-14639-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14639-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14639-70-MKcpdJtWav@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 --- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #9) > Comment on attachment 41387 [details] [review] > Bug 14639: Extend Koha::MetadataRecord to handle serialization format and > record id > > Review of attachment 41387 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/MetadataRecord.pm > @@ +84,5 @@ > > + > > + my $record = $params->{ record }; > > + my $schema = $params->{ schema } // 'marc21'; > > + my $format = $params->{ format } // 'MARC'; > > + my $id = $params->{ id }; > > Don't you think these 4 params should be mandatory? > I would raise an exception if one of them is not given to the constructor. I agree. But my plan was to do that on a later stage, so the transition into using this is more smooth. So for now I just fallback to the current behaviour. Once this is in, I will provide the relevant regression tests for an API change. Also, we need to get the exception handling code pushed before that too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:41:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:41:35 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-442mv5mh4b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:41:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:41:38 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-oAMr9i6Yir@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41466|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41625&action=edit Bug 14667 - UI/UX improvements for the Label creator Signed-off-by: Chris Nighswonger <cnighswonger at foundations.edu> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:41:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:41:44 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-nJrsF6nnmK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41626&action=edit Bug 14667: Make some strings translatable This patch 1/ Fixes a regression introduced by the previous patch: the "Are you sure to delete..." strings was translatable and 2/ Make the table headers translatable. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:43:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:43:23 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-nejeMVo0zA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Liz, don't you think the help on the label home page was helpful ("Welcome to Koha's label creator module")? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:55:42 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14598-70-BTIBnO5tbA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:55:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:55:45 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14598-70-wk0PXYN1BZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41383|0 |1 is obsolete| | Attachment #41384|0 |1 is obsolete| | Attachment #41385|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41627&action=edit [SIGNED-OFF] Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:55:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:55:51 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14598-70-eJFfw656hc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41628&action=edit [SIGNED-OFF] Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set > SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set > SELECT * FROM statistics WHERE type="return"; => FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t => SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps => SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 18:55:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 16:55:54 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14598-70-L5Li066QDh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41629&action=edit [SIGNED-OFF] Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:16:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:16:25 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-GhF5CAyOJa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:16:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:16:27 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-uBi3ssNHOa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41630&action=edit Bug 14655: Add a warning if the checkin will fail On the checkin and checkout page, the checkin will fail if the patron has requested the privacy and the AnonymousPatron is not correctly set. This patch adds a warning message on both pages. Test plan: 0/ Be sure you don't have any patron with privacy=2 (Never) 1/ Set OPACPrivacy, not AnonymousPatron 2/ Go on the checkin, you should a warning (same as before this patch). 3/ Set the privacy=2 for a patron 4/ Go on the circulation page, a warning should appear (for this specific patron) 5/ Check an item out to this patron 6/ Check the item in on the checkin page. The item is not checked in and you get a specific message for this patron. Confirm other/correct situations don't trigger the messages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:16:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:16:35 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-WgmkbSDKoC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41631&action=edit Bug 14655: Add a warning on the about page if patrons have requested privacy New warning on the about page if at least a patron has requested a privacy on checkin but the AnonymousPatron is not set to a valid patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:16:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:16:54 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-h1RqVOnsfb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:19:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:19:10 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14598-70-iO7a4W4NBd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #9) > Is it a duplicate of bug 9351? > > I would say we need to update existing rows. What about existing rows? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:24:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:24:02 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: <bug-14509-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14509-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14509-70-PSPfgkRLU9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Joonas Kylm?l? from comment #5) > (In reply to Owen Leonard from comment #4) > > (In reply to Joonas Kylm?l? from comment #3) > > > Shouldn't we change it to server side > > > as it looks like all the other fields are checked that way. > > > > There are changes to the template and to opac-passwd.pl. To confirm, disable > > JavaScript and see if the server-side check is working correctly as well. > > opac-passwd.pl is for the end user server side check, right? I disabled > JavaScript in the staff side and there wasn't any check from the server > side, it allowed to change the password (this was also mentioned in the test > plan). So should we change the code so that it checks for the whitespaces in > the server side when the password is changed from the staff view? If you like, you can provide it. But I don't know why a librarian will force a password if the application denies it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:30:54 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: <bug-14666-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14666-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14666-70-6KQtnpXzYb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12770 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:30:54 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: <bug-12770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12770-70-o1NoaVlR2p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14666 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:35:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:35:41 +0000 Subject: [Koha-bugs] [Bug 9472] subfields in order when cataloging In-Reply-To: <bug-9472-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9472-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9472-70-y1o4HcTfVH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:39:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:39:19 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14584-70-tjKEWHAeIC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Blou from comment #3) > Well, I'm fine with that, but isn't it just making this function useless? I > think what you're suggesting is what it was before the latest change. I > just presumed there had been a need for that "encode('UTF-8'" call... Not useless, it can be called from the templates. Back 1 year ago, from bug 12411: "This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944." So bug 12411 should not have been pushed to master or 11944 should have reverted the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:39:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:39:28 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14584-70-4dGL8wbDB4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Assignee|philippe.blouin at inlibro.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:41:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:41:05 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14584-70-yyVi67zFUC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41113|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41632&action=edit Bug 14584: Encoding broken with system preferences The pref are double encoded. >From bug 12411: "This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944." They should not have been pushed together. Test plan: 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like "H?lo m?dames ? m?cie?x" 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:41:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:41:13 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14584-70-UXA3MsC6vx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 19:42:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 17:42:54 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14584-70-EMgtEwtgDL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Should be backported to 3.20, not 3.18! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 20:01:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 18:01:06 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: <bug-14607-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14607-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14607-70-wOy1HdEQIA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 20:09:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 18:09:34 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: <bug-14607-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14607-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14607-70-xa8dn5yMCo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 20:09:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 18:09:36 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: <bug-14607-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14607-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14607-70-ChFLgJCCmw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41393|0 |1 is obsolete| | --- Comment #2 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 41633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41633&action=edit Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. Signed-off-by: Alexis Rodegerdts <arodegerdts at wallawallawa.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 20:23:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 18:23:37 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-GtZST6UWCA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #82 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41634&action=edit Bug 11431 [QA Followup] - Fix js error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 20:53:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 18:53:20 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: <bug-14607-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14607-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14607-70-nZji3w8VqS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:18:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:18:00 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: <bug-14509-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14509-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14509-70-lTX5TnMkbN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #7 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Jonathan Druart from comment #6) > (In reply to Joonas Kylm?l? from comment #5) > > (In reply to Owen Leonard from comment #4) > > > (In reply to Joonas Kylm?l? from comment #3) > > > > Shouldn't we change it to server side > > > > as it looks like all the other fields are checked that way. > > > > > > There are changes to the template and to opac-passwd.pl. To confirm, disable > > > JavaScript and see if the server-side check is working correctly as well. > > > > opac-passwd.pl is for the end user server side check, right? I disabled > > JavaScript in the staff side and there wasn't any check from the server > > side, it allowed to change the password (this was also mentioned in the test > > plan). So should we change the code so that it checks for the whitespaces in > > the server side when the password is changed from the staff view? > > If you like, you can provide it. > But I don't know why a librarian will force a password if the application > denies it. Librarian doesn't need to force the password, only use a browser where the JavaScript is disabled. So I give one vote for the server side check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:25:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:25:17 +0000 Subject: [Koha-bugs] [Bug 14689] New: Marc field 648 does not appear in the subject index Message-ID: <bug-14689-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Bug ID: 14689 Summary: Marc field 648 does not appear in the subject index Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: verolencinas at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org Actually you cannot search content stored in the Marc21 648 field (Subject Added Entry - Chronological Term). Terms stored in the $a subfield of this field should be searchable through the normal subject index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:41:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:41:12 +0000 Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype In-Reply-To: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14651-70-GrJUTEioEJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41635&action=edit Bug 14651: (regression test) fallback to bib-level if itype is undef Koha::Item->effective_itemtype should fallback to biblio-level itemtype even if item-level item types are set, in the case the item has no itemtype set (bad migration, bad old code). To test: - Run $ prove t/db_dependent/Items.t => FAIL: Koha::Item->effective_itemtype doesn't work properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:41:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:41:16 +0000 Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype In-Reply-To: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14651-70-U50xAYvFQL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41636&action=edit Bug 14651: Koha::Item->effective_itemtype fallback to bib-level In some situations (bad migrations, old bugs that introduced bad data, people having bib-level itypes for ages and switching to item level...) the user ends with undex itype values for items. The current code, if the user has item_level-itype set, just returns undef. It should fallback to bib-level. To test: - Run the regression tets: $ prove t/db_dependent/Items.t => FAIL: tests fail. - Apply the patch - Run the tests again => SUCCESS: The tests now pass. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:41:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:41:41 +0000 Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype In-Reply-To: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14651-70-M1qidwnFa7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:42:32 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14598-70-00eQ9gDCmM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14651 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:42:32 +0000 Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype In-Reply-To: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14651-70-Jg9jUDSMXd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14598 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:49:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:49:01 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14598-70-QCwEtA10jO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #19 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41637&action=edit Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl block that updates the rows that lack itemtype. It relies on Koha::Item->effective_itemtype() to choose the rigt one. I wrote it using SQL because the statistics table lacks PKs. Note: I'm not sure about making this dependent on 14651, I need a QA POV on this, and I'm biased as I wrote all the related patches... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:51:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:51:52 +0000 Subject: [Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index In-Reply-To: <bug-14689-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14689-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14689-70-ARNVwZjVxT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|oleonard at myacpl.org |tomascohen at gmail.com Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:51:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:51:59 +0000 Subject: [Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index In-Reply-To: <bug-14689-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14689-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14689-70-X2HTF0H0O3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 21:53:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 19:53:11 +0000 Subject: [Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index In-Reply-To: <bug-14689-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14689-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14689-70-GG2m8h83Io@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Searching Assignee|tomascohen at gmail.com |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 22:27:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 20:27:07 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: <bug-5771-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5771-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5771-70-khlxX9cJCf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 22:32:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 20:32:18 +0000 Subject: [Koha-bugs] [Bug 14690] New: Patron import tool page missing extra search patron options Message-ID: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Bug ID: 14690 Summary: Patron import tool page missing extra search patron options Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The Search Patrons box at the top of import_borrowers.pl has a + sign so you can reveal the extra options to search by library and/or categorycode. All that happens when you click on the [+] link, the [+] changes to a [-], and vice versa. No extra line is revealed. Test plan: 1.) Go to Tools --> Import Patrons. 2.) Click on the Search Patrons box (if it isn't activated already). 3.) Click on the [+] link next to the search box. 4.) Note that it changes to [-], but no extra line is revealed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 22:40:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 20:40:57 +0000 Subject: [Koha-bugs] [Bug 14691] New: Can't delete patron with ' character in cardnumber Message-ID: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 Bug ID: 14691 Summary: Can't delete patron with ' character in cardnumber Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron cardnumber has a ' character in it, and you try to delete the account, nothing happens -- the delete pop-up message doesn't appear. This appears to not affect cards with any other special character, and I've tested " & - so far]. It's only cardnumbers with the ' character in them. Test plan: 1. Create patron account with cardnumber sss'ssssssss and save the account. 2. Try to delete the account. Nothing happens. 3. Edit the account, and remove the ' character. Save the acccount. 4. Try to delete the account; note the Delete pop-up message that now appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 22:55:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 20:55:01 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: <bug-14305-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14305-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14305-70-wqOiRo1dUx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #1 from Martin Persson <xarragon at gmail.com> --- Created attachment 41638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41638&action=edit Bug : View arbitrary branch's news This patch adds an input named 'branch' to opac-main.pl that allows overriding the home library to view news from any branch. This is part of the 'Use Koha as a CMS' development. To reviewers: Does this create any security implications? The column is text; it is possbile to push SQL statemens into the DB via the opac-membership.pl page, but all the code there seems to use DBIx::Class and prepared statements. When attemped, accepting the changes were rejected because of the foreign key constraint placed on the main borrowers table. It is recommended to use this patch in conjunction with 11584 which adds a WYSIWYG editor to System Preferences. Test plan: * Make sure your Koha installation has multiple branches: * Log in to the Staff interface and select 'Koha administration' * Select 'Libraries and groups', the first item in the list * Add an extra branch named 'BRANCH1': * Press the 'New library' button * Set 'Library code' to 'BRANCH1' * Enter an arbitrary name * Press 'Submit' * Add at least two news items with different branches: * Log in to the Staff interface and select 'Tools' * Under 'Additional tools' select 'News' * On the 'Koha news' page, create a news item for all libraries: * Press the 'New entry' button * Set 'Library' to 'All libraries' and enter a title. * Press 'Submit' * On the 'Koha news' page, create a news item for one library: * Press the 'New entry' button * Set 'Library' to 'BRANCH1' and enter a title * Press 'Submit' * Add links to OPAC to select branch: * Select 'System preferences' and then the 'OPAC' tab * Scroll down to the 'OpacNav' preference and click 'Click to Edit' * Create two hyperlinks with a parameter named 'branch': * '<a href="?branch=BRANCH1">BRANCH1</a>' * '<a href="?branch=">none</a>' * Click 'Save all OPAC preferences' * Test OPAC: * By default, global news and news for home branch should show. * When clicking the 'BRANCH1' link, you should see global news plus news for the BRANCH1 branch. * When the parameter 'branch' is set but has no value, news from the home branch should be shown. Issues: Tricky to create a link to the same page which removes existing paramters. The user normally has a home branch set. We can override it with the parameter. If undefined, the home branch should be shown. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 22:56:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 20:56:23 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: <bug-14305-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14305-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14305-70-SQCbxvv3Bo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |xarragon at gmail.com Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 23:06:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 21:06:57 +0000 Subject: [Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches In-Reply-To: <bug-14305-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14305-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14305-70-TaQCDINCKR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #2 from Martin Persson <xarragon at gmail.com> --- Created attachment 41639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41639&action=edit Bug 14305: View arbitrary branch's news, RSS fix This fix changes the RSS link to reflect the URL paramter override. This is less elegant than the existing solution which uses the Branches TT module, perhaps there is a better way? Sponsored-By: Halland County Library Test plan: * Follow instructions in the original patch but also check the URLs and contents of the RSS link at the bottom the OPAC page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 23:12:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 21:12:16 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-cB5uFg9aTL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #10 from Liz Rea <liz at catalyst.net.nz> --- I didn't - the reason I didn't is because it is not like any other page. That help should be in the upper right hand help menu, in my opinion. Also thank you very much for helping out with the translation stuff. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 23:17:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 21:17:38 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14584-70-U4Fa8OWcRV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 23:17:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 21:17:59 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-jwKOw3KueN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 23:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 21:18:02 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-PlXn0qs5OH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41577|0 |1 is obsolete| | --- Comment #6 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 41640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41640&action=edit Bug 14685: Fix set guarantor for a child or professional accounts Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only children or professional can have a guarantor. Test plan: 1/ Create an adult patron and add a child. 2/ The guarantor info should be retrieved and set on the child creation page. 3/ Create an organization and add a child 4/ The guarantor info should be retrieved and set on the adult creation page. Signed-off-by: Liz Rea <liz at catalyst.net.nz> This patch catches both cases, thanks Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 23:18:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 21:18:07 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14584-70-K9PrQpgPax@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41632|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41641&action=edit [SIGNED OFF] Bug 14584: Encoding broken with system preferences The pref are double encoded. >From bug 12411: "This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944." They should not have been pushed together. Test plan: 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like "H?lo m?dames ? m?cie?x" 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 23:30:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 21:30:07 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: <bug-14367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14367-70-KtMXTkxuGI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #1 from Martin Persson <xarragon at gmail.com> --- Created attachment 41642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41642&action=edit Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library Test plan: * Log into OPAC, search for a title, chose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 18 23:47:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 21:47:36 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: <bug-14367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14367-70-yReaOhliDK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 00:12:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 22:12:43 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-Wvj5yC4rFw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #11 from Chris Nighswonger <cnighswonger at foundations.edu> --- On the other hand, I thought it was cool and that every tool should have a solid intro page which gives a brief overview of its purpose and usage. But that's just my opinion. And pretty biased at that since I created it. ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 00:28:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 22:28:37 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-1S9m5FClfy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #12 from Liz Rea <liz at catalyst.net.nz> --- :) I can totally understand where you're coming from there. I have observed, when watching librarians learn this tool, that they just don't read it, and the wall of text distracts them from what they are supposed to do. Possibly though, that's because I emphasize the help in the upper right hand corner so they get it drilled into them to look there for help. Certainly the decision to remove it isn't scientific by any stretch, just based on my observations of people using the tool. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 00:34:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 22:34:29 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: <bug-14658-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14658-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14658-70-i3PUXvK9rh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 00:34:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Aug 2015 22:34:31 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: <bug-14658-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14658-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14658-70-oZoGA9hJqn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #1 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 41643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41643&action=edit Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Test plan: 1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField. 2) Apply patch, and update database. 3) Check to make sure that the new system preference PatronSelfModificationBorrowerUnwantedField has the same value as PatronSelfRegistrationBorrowerUnwantedField. 4) Verify that the same fields are hidden for self-registering a new borrower and edting a new one (both on the OPAC). 5) Change PatronSelfModificationBorrowerUnwantedField, and verify that the two preferences correctly apply to editing vs. creating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 03:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 01:31:05 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-jsXQegQuj6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 03:31:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 01:31:07 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-BhVyEX8H2l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #1 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 41644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41644&action=edit Bug 14691 - Can't delete patron with ' character in cardnumber Test plan: 1. Create patron account with cardnumber sss'ssssssss and save the account. 2. Try to delete the account. Nothing happens. 3. Apply the patch, refresh the page. 4. Try to delete the account; note the Delete pop-up message that now appears. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 03:32:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 01:32:44 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-whypC7yQ7j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Attachment #41644|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz at catalyst.net.nz> --- Comment on attachment 41644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41644 Bug 14691 - Can't delete patron with ' character in cardnumber Oops, typo. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 03:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 01:36:42 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-bZdjfyeqyX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #3 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 41645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41645&action=edit Bug 14691 - Can't delete patron with ' character in cardnumber Test plan: 1. Create patron account with cardnumber sss'ssssssss and save the account. 2. Try to delete the account. Nothing happens. 3. Apply the patch, refresh the page. 4. Try to delete the account; note the Delete pop-up message that now appears. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 05:27:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 03:27:24 +0000 Subject: [Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options In-Reply-To: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14690-70-FLeKHde3UW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea <liz at catalyst.net.nz> --- This is not an issue in 3.20, because of bug 13235. I'm about to attach a modified version of the patch for 3.18. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 05:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 03:31:08 +0000 Subject: [Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options In-Reply-To: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14690-70-NabtcHjUBC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 05:31:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 03:31:11 +0000 Subject: [Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options In-Reply-To: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14690-70-sa9PHF5Xb1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 --- Comment #2 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 41646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41646&action=edit Bug 14690 - [3.18.x] Patron import tool page missing extra search patron options To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Also please be sure to check the patron import page. Owen is listed as the author of this, because that's mostly true - I just resolved the conflict for 3.18.x (LR) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 05:55:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 03:55:20 +0000 Subject: [Koha-bugs] [Bug 13235] Revise layout of patron search form In-Reply-To: <bug-13235-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13235-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13235-70-GKxoEeU0HJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 07:18:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 05:18:11 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-xjAZyPaOxn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook <dcook at prosentient.com.au> --- I encountered this a while ago and thought about fixing it as well, but then Chris Cormack pointed me to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 which should fix this problem everywhere I think? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 07:52:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 05:52:00 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: <bug-14672-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14672-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14672-70-whHSX605AT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41612|0 |1 is obsolete| | --- Comment #4 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41647&action=edit Bug 14672 - Payment is not able to done, when the patron has credit balance This is fixed version of the yesterday's patch, the credit was calculated wrongly and now it's fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 08:55:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 06:55:06 +0000 Subject: [Koha-bugs] [Bug 12356] Stay in advanced search and keep settings when it returns no results. In-Reply-To: <bug-12356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12356-70-PIP7PQq95l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12356 Viktor Sarge <viktor.sarge at regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Viktor Sarge <viktor.sarge at regionhalland.se> --- Don't know who to thank but this one is done now :) I guess it should be marked as a duplicate, but I don't know of what bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:33:59 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: <bug-14509-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14509-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14509-70-UToOjGEJSE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The intranet side does not work if JS is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:34:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:34:54 +0000 Subject: [Koha-bugs] [Bug 14603] Warns when checking in items In-Reply-To: <bug-14603-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14603-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14603-70-IMnyzcjJJU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14603 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #2 from Joonas Kylm?l? <j.kylmala at gmail.com> --- I can't confirm returns.pl: Use of uninitialized value $holdingBranch in string eq at kohaclone/circ/returns.pl line 619. Can you give more specific instructions to reproduce, like which type of an item you checked out etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:41:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:41:16 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14661-70-tOCwMVJEp1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:41:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:41:19 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14661-70-BkYwXLFIzF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41648&action=edit Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines Signed-off-by: Heather Braum <hbraum at nekls.org> Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:41:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:41:50 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14661-70-3OHUAcQOvB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I confirm the bug on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:42:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:42:03 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14661-70-1DPOgqGgaD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41434|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:42:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:42:08 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14661-70-OQsRYAwB1i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:45:39 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: <bug-14652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14652-70-ix5dNA8eQK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:45:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:45:41 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: <bug-14652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14652-70-fmkLnBOKbP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41443|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41649&action=edit Bug 14652 - change gender specification from "N/A" to "None specified" To test: Edit a patron in the intranet, note that the gender options are "Female," "Male," and "None specified" Setting "None specified" should result in the gender not being shown on the patron detail page (unchanged functionality) In the opac, log in and click the "your personal details" tab, and note that the gender options are "Female," "Male," and "None specified" Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:45:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:45:49 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: <bug-14652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14652-70-echJpQDB0X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41650&action=edit Bug 14652: Change one more occurrence of N/A. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:46:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:46:05 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: <bug-14652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14652-70-YxKQ2sJHab@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|oleonard at myacpl.org |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:46:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:46:19 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-vmNsoaVCDj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- Looks good, the localization works as expected. I found some pages, where the localization is not used: Intranet: admin/smart-rules.pl authorities/authorities.pl catalogue/detail.pl catalogue/itemsearch.pl catalogue/moredetail.pl reports/acquisitions_stats.pl reports/bor_issues_top.pl reports/cat_issues_top.pl reports/catalogue_out.pl reports/catalogue_stats.pl reports/issues_avg_stats.pl reports/issues_stats.pl reports/itemslost.pl reports/manager.pl reports/reserves_stats.pl suggestion/suggestion.pl tools/export.pl Opac: opac-detail.pl opac-MARCdetail.pl opac-search.pl It isn't propably the complete list, but I tried my best ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:47:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:47:51 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: <bug-14509-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14509-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14509-70-QcorH4EvP3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #9 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Well it doesn't (In reply to Jonathan Druart from comment #8) > The intranet side does not work if JS is disabled. It works and looks actually pretty ok, from the whole process of finding the patron with the search bar in the top to changing the password. But I also think it is not so urgent to do the server side check. However, there is bug 14620, so if it goes to upstream then maybe the password validation could go there and then it could check also for the spaces :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:57:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:57:44 +0000 Subject: [Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10480-70-4lQfmC9LN7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14660 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 [Bug 14660] Cataloguing plugins for generating inventory numbers are broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 09:57:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 07:57:44 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-5GpKxmhJKP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |10480 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- git bisect blames the following commit commit ff5996d65e4788e20d1c113ec70e80d0fd0710af Bug 10480: Use the framework plugin object in cataloguing This patch implements the use of Koha::FrameworkPlugin in Cataloguing, Authorities, Acquisition, Serials and Tools. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 [Bug 10480] Improvements for framework plugins in cataloguing/item editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:03:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:03:14 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-FivSP8mp9U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- % grep -Hl output_ `grep -RL 'C4::Output' cataloguing/value_builder` cataloguing/value_builder/callnumber.pl cataloguing/value_builder/unimarc_field_010.pl cataloguing/value_builder/stocknumberAV.pl cataloguing/value_builder/stocknumberam123.pl cataloguing/value_builder/callnumber-KU.pl Some others exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:13:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:13:35 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-LM9hCk0tYc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:13:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:13:38 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-cyJxs9PVZj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41426|0 |1 is obsolete| | Attachment #41427|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41651&action=edit Bug 14660: Fix stocknumberAV.pl cataloguing plugin The cataloguing plugin stocknumberAV.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Set up a new authorised value INVENTORY, the code is an uppercase prefix - "B" - The Descriptions is your starting number - 1 - The OPAC description remains empty - Catalalog an item - Enter B as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:13:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:13:47 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-dIyxGp7f9i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41653&action=edit Bug 14660: Fix 3 other cataloguing plugins These 3 should use C4::Output not to explode. Test plan: Link the plugins with the correct fields They should not log an error when calling them Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:13:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:13:44 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-n9VTu12mua@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41652&action=edit Bug 14660: Fix stocknumberam123.pl cataloguing plugin The cataloguing plugin stocknumberam123.pl is broken and no longer generating numbers - this patch fixes it. To test: - Link a subfield to the plugin - usually it's 952$i or the UNIMARC equivalent in your MARC frameworks - Create a new item, set the inventory number to: A 0000000002 - Start to catalog another item, enter A into inventory and - Enter A as stocknumber and activate the plugin by clicking on ... at the end of the field - The number will not get added - Firebug shows an error: Undefined subroutine CGI::output_html_with_http_headers - Apply patch - Verify numbers are now generated and no errors are shown Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:15:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:15:41 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-KTAMwnkeLR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #11) > Created attachment 41653 [details] [review] > Bug 14660: Fix 3 other cataloguing plugins > > These 3 should use C4::Output not to explode. > > Test plan: > Link the plugins with the correct fields > They should not log an error when calling them > > Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> I have not tested the behavior of the plugins, but they raised an error in the log. With this patch, they don't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:16:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:16:15 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-QBRh23AxtR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Increasing the severity to major. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:17:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:17:31 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-i5trCeH7jg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Should be backported to 3.20.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:21:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:21:26 +0000 Subject: [Koha-bugs] [Bug 14582] OPAC detail shows an unuseful link to "add tag" when user is not logged in In-Reply-To: <bug-14582-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14582-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14582-70-0qWVMik6G6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14582 Viktor Sarge <viktor.sarge at regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se --- Comment #1 from Viktor Sarge <viktor.sarge at regionhalland.se> --- That is silly. I think "Add tag(s)" is good to have visible in the same place as when it's actually usable. What about "Add tag(s) - requires login"? Ideally that would give a login dialog and then do the normal behavior without leaving the page. Then we keep the same workflow while logged in/not logged in. I'll see if anyone in my team can have a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:34:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:34:05 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14224-70-2XTfyDZf9f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Viktor Sarge <viktor.sarge at regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:37:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:37:15 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14224-70-esHVG3dVT2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |martin at bugs.koha-community. | |org.xinxidi.net Assignee|oleonard at myacpl.org |martin at bugs.koha-community. | |org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 10:41:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 08:41:38 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14510-70-CcP1bAwSe1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Jesse, This works quite well! How did you choose the order of the fields on the column settings configuration page? What about the stocknumber and statisticvalue fields, for instance? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 11:03:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 09:03:19 +0000 Subject: [Koha-bugs] [Bug 14692] New: Same Day/End of day loans Message-ID: <bug-14692-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14692 Bug ID: 14692 Summary: Same Day/End of day loans Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently it's not possible to do a same day, i.e. to end of day loan. We're working on implementing such a circ rule. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 11:09:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 09:09:17 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: <bug-12021-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12021-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12021-70-NnSmgm5wKr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7981 | --- Comment #9 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> --- Any news on this? bug 7981 is pushed to master, so there is no more dependencies. I still believe the AutomaticItemReturn syspref should be disabled, as turning it on would disable any alerts. this is from the docs, http://manual.koha-community.org/3.20/en/patscirc.html: The various Return Policies have the following effects: Item returns home: The item will prompt the librarian to transfer the item to its home library If the AutomaticItemReturn preference is set to automatically transfer the items home, then a prompt will not appear I am positive this is also the case with SIP2: if AutomaticItemReturn is enabled, then SIP2 return will not alert. This bug corrects an obvious bug which can be seen in the code: https://github.com/Koha-Community/Koha/blob/master/C4/SIP/ILS/Transaction/Checkin.pm#L82-L119 where CT message should be appended to item $self->{item}->destination_loc not $self->destination_loc Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 [Bug 7981] Remove HomeOrHoldingBranchReturn syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 11:09:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 09:09:17 +0000 Subject: [Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref In-Reply-To: <bug-7981-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7981-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7981-70-rfzu5uQYLJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12021 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 11:13:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 09:13:18 +0000 Subject: [Koha-bugs] [Bug 14692] Same Day/End of day loans In-Reply-To: <bug-14692-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14692-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14692-70-iDKmb9IvBQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14692 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Scenario is this: borrower checksout item return date is today ( i.e. midnight today ). Seems a logical requirement for ceryain collection. Logically its a day loan of length 0 but we have code currently forbidding that -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:41:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:41:56 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-q042OpUFaT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41654&action=edit Bug 14100: (follow-up) Language overlay for item types Display the translated description for item types in the following pages: > admin/smart-rules.pl > catalogue/detail.pl > catalogue/itemsearch.pl > catalogue/moredetail.pl > reports/acquisitions_stats.pl > reports/bor_issues_top.pl > reports/cat_issues_top.pl > reports/catalogue_out.pl > reports/catalogue_stats.pl > reports/issues_avg_stats.pl > reports/issues_stats.pl > reports/itemslost.pl > reports/manager.pl > reports/reserves_stats.pl > suggestion/suggestion.pl > tools/export.pl > Opac: > opac-detail.pl > opac-MARCdetail.pl > opac-search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:42:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:42:20 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-3deTOJsWSi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Josef Moravec from comment #11) > Looks good, the localization works as expected. > > I found some pages, where the localization is not used: > > Intranet: > admin/smart-rules.pl Fixed. > authorities/authorities.pl Looks good here, please detail. > catalogue/detail.pl > catalogue/itemsearch.pl > catalogue/moredetail.pl > reports/acquisitions_stats.pl > reports/bor_issues_top.pl > reports/cat_issues_top.pl > reports/catalogue_out.pl > reports/catalogue_stats.pl > reports/issues_avg_stats.pl > reports/issues_stats.pl > reports/itemslost.pl > reports/manager.pl > reports/reserves_stats.pl > suggestion/suggestion.pl > tools/export.pl Fixed. > Opac: > opac-detail.pl > opac-MARCdetail.pl > opac-search.pl Fixed. > It isn't propably the complete list, but I tried my best ;) Thanks for this list! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:48:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:48:15 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14646-70-ukJYUgqaWk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:48:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:48:19 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14646-70-APTBXUj6y0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41391|0 |1 is obsolete| | Attachment #41392|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41655&action=edit Bug 14646: (regression test) Koha::RecordProcessor only accepts one filter at a time This patch introduces new tests to t/RecordProcessor.t so it tests for creating processors with more than one filter. It does so by running my $processor = new Koha::RecordProcessor({ filters => ['Null','Dummy'] }); and testing the results. To test: - Apply the patch - Run: $ prove t/RecordProcessor.t => FAIL: tests related to multiple filters fail. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:48:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:48:27 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14646-70-Aq9Q180O2X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41656&action=edit Bug 14646: Koha::RecordProcessor should accept more than one filter The docs say that Koha::RecordProcessor accepts more than one filter at a time. But as the regression tests show it doesn't. This is really important to extend its usage in record processing (either to enforce policy, transform, etc). This patch makes ->new evaluate the reference type of the passed filters and builds an array with a single item if a scalar has been passed. The loop now explicitly casts the filters as an array. To test: - Apply the test patch - Run $ prove t/RecordProcessor.t => FAIL: tests fail because Koha::RecordProcessor doesn't hanlde more than one filter at a time. - Apply this patch - Run $ prove t/RecordProcessor.t => SUCCESS: tests now pass - Easy, right? Sign off :-D NOTE: Read code. Don't like the ? operator logic, but it is functional despite readability issues. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:49:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:49:15 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14646-70-z4VEABCfHE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to M. Tompsett from comment #4) > NOTE: Read code. Don't like the ? operator logic, but it is > functional despite readability issues. Something better to suggest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:56:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:56:14 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: <bug-14644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14644-70-SUeHJUclgy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:56:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:56:17 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: <bug-14644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14644-70-v2VI8wmS2y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41373|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41657&action=edit Bug 14644: unbreak SIP2 terminal login when using telnet transport This patch fixes breakage introduced by the patch for bug 13506 that prevented SIP2 clients from authenticating themselves over the telnet transport. Attempts to do so would manifest by the SIPServer backend crashing and the connection getting closed. To test: [1] Use the stock SIPServer config, etc/SIPconfig.xml, and ensure that the database contains a staff user whose username is 'term1' and password is 'term1' that has the circulate permission. [2] Start SIPServer, telnet to port 8023, and attempt to log in. The connection will be aborted: $ telnet localhost 8023 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. login: term1 password: term1 Connection closed by foreign host. [3] Apply the patch and restart SIPSever, then repeat step 2. This time, the login should succeed: $ telnet localhost 8023 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. login: term1 password: term1 Login OK. Initiating SIP Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:57:56 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: <bug-14644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14644-70-dITqvxDmqc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13506 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Should be backported to 3.20.x. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 [Bug 13506] Sip/Configuration/*.pm classes are unused -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:57:56 +0000 Subject: [Koha-bugs] [Bug 13506] Sip/Configuration/*.pm classes are unused In-Reply-To: <bug-13506-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13506-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13506-70-T4Y4F9euWV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13506 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14644 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 [Bug 14644] SIP2 terminal authentication via telnet transport broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 12:58:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 10:58:36 +0000 Subject: [Koha-bugs] [Bug 14605] The description on pay/write off individual fine is wrong In-Reply-To: <bug-14605-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14605-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14605-70-TSdqQDguJL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:02:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:02:19 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-faC9Nwt1z3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #14 from Josef Moravec <josef.moravec at gmail.com> --- Thanks for the quick fix! I tried authorities.pl again and it looks good for me too, propably my mistake. I'm going to test it once again and probably sign off, if there will be some other places with non-translated itemtypes we still could file new bug for specific occurences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:11:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:11:10 +0000 Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page In-Reply-To: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14579-70-MiRsrOPpZG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41106|0 |1 is obsolete| | --- Comment #4 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41658&action=edit Bug 14579: 'You are not logged in' should link to log in page I fixed the aligment of the two links but the padding still needs to be set right. I also fixed mismatching html tags. To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:14:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:14:57 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-YgKr82GLi0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40965|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 41659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41659&action=edit Bug 14100: Generic solution for language overlay - Item types Test plan: 1/ update the Schema (misc/devel/update_dbix_class_files.pl) 2/ Translate templates for some languages (es-DE, de-DE for instance) 3/ Enable them in the pref (search for 'lang') for the staff interface 4/ Go on the item type admin page (admin/itemtypes.pl) 5/ Edit one 6/ Click on the 'translate for other languages' link 7/ You are now on the interface to translate the item type's description in the languages you want. So translate some :) 8/ Go back on the item type list view (admin/itemtypes.pl) 9/ You should see the original description (non translated) 10/ Switch the language 11/ You should see the translated description in the correct language. If the description is non translated, the original description is displayed. 12/ On the different page where the item type is displayed, confirm that the translated description appears. Think further / Todo: 1/ Update all occurrences of the item type's description (DONE) 2/ Implement for authorised values 3/ Implement for syspref value (at least textarea) 4/ Implement for branch names 5/ Centralize all the translation on a single page in the admin area ... N/ Implement a webservice to centralize all the translations and give the ability to sync the item types/authorised values description with the rest of the world (push and pull). Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:15:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:15:42 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-IQKUQTaoyT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:15:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:15:57 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-YQoQQbTRRk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41654|0 |1 is obsolete| | --- Comment #16 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 41660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41660&action=edit Bug 14100: (follow-up) Language overlay for item types Display the translated description for item types in the following pages: > admin/smart-rules.pl > catalogue/detail.pl > catalogue/itemsearch.pl > catalogue/moredetail.pl > reports/acquisitions_stats.pl > reports/bor_issues_top.pl > reports/cat_issues_top.pl > reports/catalogue_out.pl > reports/catalogue_stats.pl > reports/issues_avg_stats.pl > reports/issues_stats.pl > reports/itemslost.pl > reports/manager.pl > reports/reserves_stats.pl > suggestion/suggestion.pl > tools/export.pl > Opac: > opac-detail.pl > opac-MARCdetail.pl > opac-search.pl Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:23:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:23:48 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14598-70-xgNrs6C6y9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am not sure it's a good idea to use existing subroutines/methods in the updatedb process. It cans work now but how to know it won't be broken in several versions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:28:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:28:17 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: <bug-14395-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14395-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14395-70-Js9g8Uj5eD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Applying: Bug 14395: Add new syspref NoRenewalBeforePrecision Applying: Bug 14395: Code changes fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:35:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:35:57 +0000 Subject: [Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted record will fail In-Reply-To: <bug-14597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14597-70-cyHbmP9H56@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 41170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41170 [SIGNED-OFF] Bug 14597 - Reverting a batch where a record overlaid is now deleted record will fail Review of attachment 41170: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14597&attachment=41170) ----------------------------------------------------------------- ::: C4/ImportBatch.pm @@ +813,4 @@ > sub BatchRevertRecords { > my $batch_id = shift; > > + my $logger = Koha::Logger->get( { category => 'C4.ImportBatch.BatchRevertRecords' } ); Really? We are going to create an instance of Log::Log4perl for each subroutine call? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:44:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:44:48 +0000 Subject: [Koha-bugs] [Bug 14174] Home suspension and / or in situ In-Reply-To: <bug-14174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14174-70-Wyl6YVjeDJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14174 H?ctor <hectorejch at yahoo.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Version|unspecified |master Severity|enhancement |new feature Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:45:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:45:12 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-h9jDk9QskI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- One test does not pass for me: # Failed test 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' # at t/db_dependent/Holds.t line 449. # got: 'OK' # expected: 'tooManyReserves' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:52:40 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: <bug-14101-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14101-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14101-70-CfYoxyWmtd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Holger, please provide tests for the changes done to CanBookBeRenewed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:55:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:55:59 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-bUKyi85fqu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #83 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41661&action=edit Bug 11431 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 13:57:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 11:57:32 +0000 Subject: [Koha-bugs] [Bug 14174] Home suspension and / or in situ In-Reply-To: <bug-14174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14174-70-lJThoBWRUk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14174 H?ctor <hectorejch at yahoo.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 14:02:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 12:02:44 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-kxgG3zm2D3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 14:02:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 12:02:47 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-PyhcG4tPjR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #84 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41662&action=edit Bug 11431 [QA Followup] - Simplify audio_alert_id to just id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 14:05:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 12:05:47 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-gmbFPUrbtq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #85 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Kyle M Hall from comment #84) > Created attachment 41662 [details] [review] > Bug 11431 [QA Followup] - Simplify audio_alert_id to just id audio_alert_id is very wordy and it's a better convention to just give the table id the name 'id'. No changes in the code were needed since I was already using the id() method. Unit tests pass pre and post patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 14:08:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 12:08:23 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-5yxSw193AG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5) > (In reply to Marcel de Rooy from comment #1) > >(Note that Class::->method is preferred above Class->method. See perlobj.) > > I did not find where it's written it's better. > I personally think you are adding a third way where we already have new CGI > and CGI->new... ThereIsMoreThanOneWayToDoIt The reference is few comments up, but for the rest it is completely unimportant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 14:59:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 12:59:19 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10988-70-TdkISsRAn7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I can take a look again with a detailed test plan using a non-public IP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:00:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:00:01 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10988-70-cWo2rHesIc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41663&action=edit Bug 10988: Fix the svc script path -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:04:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:04:50 +0000 Subject: [Koha-bugs] [Bug 3333] item status for "not for loan" by item type / item is different In-Reply-To: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3333-70-hfXKdK6BeT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3333 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Nick Clemens from comment #12) > > Additionally, a Place hold link should disappear in the opac, when it is > > not possible to place a hold on any item of one biblio. > > Everything got marked 'Not for loan' as expected, but I didn't see the above > triggered > > 'Item available for reference' statement in OPAC search results also seems a > big presumption for a not for loan item type, but that is pre-existing / not > your problem Marcel, is it still valid? Should we remove from the test plan or it's a bug? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:16:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:16:41 +0000 Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh In-Reply-To: <bug-14375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14375-70-ipqxXiUfqR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #14) > Created attachment 41439 [details] > test module > > Test module. > > It saves a record and tries to get it each 15 minutes 4 times. > Without patch, it fails with : database has run away. Why 900sec? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:17:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:17:41 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14685-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14685-70-xsjkrOzW1B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:22:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:22:44 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-FQZRgWsBMm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Kyle, could you please rebase this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:25:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:25:36 +0000 Subject: [Koha-bugs] [Bug 13811] Silent Cronjobs In-Reply-To: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13811-70-KG8GHt6med@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:25:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:25:38 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-LrDEu0flMp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #7 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Jonathan Druart from comment #5) > (In reply to Marcel de Rooy from comment #1) > >(Note that Class::->method is preferred above Class->method. See perlobj.) > > I did not find where it's written it's better. > I personally think you are adding a third way where we already have new CGI > and CGI->new... I agree that "better" is not the word used. However, it is expressly explicit in how Perl should interpret the call. There is something to be said positively for explicitness. "Because Perl allows you to use barewords for package names and subroutine names, it sometimes interprets a bareword's meaning incorrectly." http://perldoc.perl.org/perlobj.html#Invoking-Class-Methods Though, I do share Jonathan's view that CGI->new is sufficient. This explicit syntax is an example of confusing ugliness that I personally would prefer to avoid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:26:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:26:42 +0000 Subject: [Koha-bugs] [Bug 14693] New: t/db_dependent/Contract.t fails do to fixed date Message-ID: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Bug ID: 14693 Summary: t/db_dependent/Contract.t fails do to fixed date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com To reproduce: - Run (on master) $ prove t/db_dependent/Contract.t => FAIL: tests fail due to a fixed date (2015-07-31) being set as a future date which hasn't arrived yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:28:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:28:43 +0000 Subject: [Koha-bugs] [Bug 3333] item status for "not for loan" by item type / item is different In-Reply-To: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3333-70-CV12YbThwO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3333 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13) > (In reply to Nick Clemens from comment #12) > > > Additionally, a Place hold link should disappear in the opac, when it is > > > not possible to place a hold on any item of one biblio. > > > > Everything got marked 'Not for loan' as expected, but I didn't see the above > > triggered > > > > 'Item available for reference' statement in OPAC search results also seems a > > big presumption for a not for loan item type, but that is pre-existing / not > > your problem > > Marcel, is it still valid? Should we remove from the test plan or it's a bug? I think so, but will verify. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:28:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:28:49 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: <bug-14674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14674-70-kX5PkmKwDi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:29:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:29:53 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-fn8KPLqBzw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- If there is widespread concensus for removing this *ugly* construction, I will be happy to remove it quickly :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:33:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:33:44 +0000 Subject: [Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected" In-Reply-To: <bug-12748-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12748-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12748-70-31568xmHxf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Yes, thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:35:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:35:35 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14646-70-pxLFXikPr0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 --- Comment #8 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Jonathan Druart from comment #7) > (In reply to M. Tompsett from comment #4) > > NOTE: Read code. Don't like the ? operator logic, but it is > > functional despite readability issues. > > Something better to suggest? As noted it is merely readability issues. I do not have anything better to suggest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:40:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:40:15 +0000 Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number In-Reply-To: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14683-70-rArD7w2vGe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41664&action=edit Bug 14683: Unable to clear SMS number Enables to clear SMS number. To test: 1. Go to opac-messaging.pl 2. Insert SMS number and submit 3. Clear SMS number and submit 4. Observe that the sms number did not change 5. Apply patch 6. Clear SMS number and submit 7. Observe that the sms number changes Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:40:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:40:42 +0000 Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number In-Reply-To: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14683-70-NWcil41m6i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |j.kylmala at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:46:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:46:23 +0000 Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted In-Reply-To: <bug-14621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14621-70-5wEoYAGHz3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:50:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:50:57 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-JEIJ4GzPPk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41559|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41665&action=edit Bug 14321: Switch to Upload in opac-retrieve A last step to obsolete UploadedFiles.pm. Note that we now also check for the public flag. If that flag is not set, the uploaded file cannot be reached via the opac. This patch also the encode step to tools/upload for the http header that could include a filename with special chars (just as in opac-retrieve). Test plan: [1] Check downloading a file marked public in OPAC without logging in. If possible, include some special chars in the filename. [2] Check another file (not marked as public). Should not be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:51:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:51:00 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-6kcp3gYB1x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41560|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41666&action=edit Bug 14321: Unit test for Koha::Upload This unit test replaces the test for UploadedFiles.pm. That one used dependency Test::CGI::Multipart. We are now mocking CGI and its hook to achieve the same result. Some tests are added to cover additional routines in Upload.pm. Test plan: Run the test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:51:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:51:04 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-2kaaY7cGju@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41561|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41667&action=edit Bug 14321: Fix permissions check in upload-file.pl This fixes an error in one of the patches of bug 6874. The userid of the Koha admin user is passed to haspermission, but we should pick the userid from the session. NOTE: Bug 14686 will add a specific permission for tools/upload.pl. At that time we can add the script to the Tools menu too. For now, you need edit_catalogue to start upload.pl and you will additionally need a permission like upload_local_cover_images (see tools/upload-file) to successfully upload a new file. Searching for files and copying URLs to the editor can still be done with edit_catalogue. Test plan: [1] Pick a staff user that only has catalogue and edit_catalogue. [2] Without this patch, you can upload a file on tools/upload.pl. [3] Apply this patch. [4] Retry. Should not work: Upload status is Denied. [5] Login with enough permissions. Upload again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:51:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:51:07 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-L9LVK7lqX7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41668&action=edit Bug 14321: Just some documentation lines added or fixed Test plan: Actually, you cannot really test this. But you could run the unit test again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:51:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:51:11 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-0o8TY1a8M5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41562|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41669&action=edit Bug 14321: Final cleanup, removing obsolete files The new Upload.pm, unit test and file-upload.js obsolete a number of files, including an older jQuery plugin. The test files progressbar.pl and progressbarsubmit.pl are outdated and do not serve any purpose in this form. (Actually, we could argue if they should be here or just be part of a debugging phase.) Test plan: [1] Git grep on file-progress, file-upload.inc, UploadedFile, ajaxfileupload, ajaxFileUpload UploadedFile: Only a reference to DBIx file is found ajaxfileupload: Only release notes [2] Upload a file with tools/upload and stage-marc-import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:56:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:56:17 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-yFIvnW7EdH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Small consistency adjustment in patch 5 and new patch 8 for some pod lines in Upload.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 15:59:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 13:59:35 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-A6EWoHZNsN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Kyle, the test you have provided passes against master. I would expect something to fail, and then to be fixed by your patch. Why is the version set to 3.18? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:12:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:12:54 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-b003WVayYk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41670&action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. (Note that Class::->method is preferred above Class->method. See perlobj.) Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:13:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:13:17 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-it4x3jjbYK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:14:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:14:47 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-80rE5JEMGS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:15:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:15:05 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-c0lT3i8hCv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41517|0 |1 is obsolete| | Attachment #41518|0 |1 is obsolete| | Attachment #41520|0 |1 is obsolete| | Attachment #41521|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41671&action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML This patch adds the ability to use a WYSIWYG editor for system preferences. The key files that I touch are: 1) admin/systempreferences.pl 2) koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt 3) koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt I also add: 4) koha-tmpl/intranet-tmpl/prog/en/includes/wysiwyg-systempreferences.inc and 5) koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/advimage This plugin is part of the TinyMCE distribution. It used to be in Koha, but then someone removed it. It's useful for preferences like "opacheader" though. *If you're using anything except IE, this should work super well. If you're using IE, it'll probably only work for keyboard input and dragging text within the editor box but not from outside of it. IE has worse security, so you can probably paste using the context menu paste. *While I think a WYSIWYG editor can be useful, there might be times where the content is displayed differently than it is in the editor because of higher level CSS and Javascript. Signed-off-by: Martin Persson <xarragon at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:15:11 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-4bQtIt0g5T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41672&action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML (add licence) This patch adds the TinyMCE license info to about.pl Signed-off-by: Martin Persson <xarragon at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:15:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:15:15 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-NX316RKYov@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41673&action=edit Bug 11584 - Add wysiwyg editor to system preferences dealing with HTML (add system preference) This patch adds a system preference "UseWYSIWYGinSystemPreferences" to the Staff Client tab. By default, it is off, which means that the TinyMCE WYSIWYG editor won't be shown for system preferences with a type of "htmlarea". However, when it's on, it will show the editor for "Local Use" preferences with a "htmlarea" type, and for other system preferences in the "Opac", "Circulation", and "Staff Client" tabs, which I have re-assigned. (Basically, I grepped for HTML and changed the type for all the system preferences I found except for "IntranetNav", "OpacCustomSearch", and "OPACSearchForTitleIn", as a WYSIWYG editor would potentially break the output for these system preferences or add no value to them...) _TEST PLAN_ 0) Run `perl installer/data/mysql/updatedatabase.pl` after setting your environmental variables 1) Check the Opac tab to make sure that the WYSIWYG is nowhere to be seen 2) Change the "UseWYSIWYGinSystemPreferences" preference in "Staff Client" to "Show" 3) Refresh the Opac tab and notice that many system preferences now have a WYSIWYG editor 4) Try typing some text into these fields 5) Note that it gets marked as "modified" 6) Save the preference, and refresh the page 7) Note that the content has been saved 8) Take a look at how it's rendered on the actual webpage! Signed-off-by: Martin Persson <xarragon at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:15:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:15:19 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-dVshaOsmMh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41674&action=edit Bug 11584: Syspref WYSIWYG, dropdown added This patch adds the 'Htmlarea' type to the dropdown box introduced by bug 14268, commit 6e3bcc38. Sponsored-By: Halmstad County Library Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:20:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:20:02 +0000 Subject: [Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-rV95W3J5Rl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41457|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41675&action=edit Bug 14589: Replace fetch CGI::Cookie calls This patch is inspired by the change in bug 14588. It replaces the indirect object syntax for CGI::Cookie. Some trivial corrections are made to authorities/merge_ajax.pl just as bug 14588 does for cataloguing. Test plan: Run the URL authorities/merge_ajax.pl in staff. Upload a file with Stage MARC records for import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:21:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:21:06 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-NBAGYqekqw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41670|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41676&action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:22:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:22:38 +0000 Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost items checks them in In-Reply-To: <bug-12311-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12311-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12311-70-h9kgf9tt83@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com | |, katrin.fischer at bsz-bw.de --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I need help on this one to provide a fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:23:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:23:03 +0000 Subject: [Koha-bugs] [Bug 10009] self check out not really logging out In-Reply-To: <bug-10009-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10009-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10009-70-7PUK7ZvWgN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10009 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:25:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:25:27 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-G6yMfWf2hs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41669|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41677&action=edit Bug 14321: Final cleanup, removing obsolete files The new Upload.pm, unit test and file-upload.js obsolete a number of files, including an older jQuery plugin. The test files progressbar.pl and progressbarsubmit.pl are outdated and do not serve any purpose in this form. (Actually, we could argue if they should be here or just be part of a debugging phase.) Test plan: [1] Git grep on file-progress, file-upload.inc, UploadedFile, ajaxfileupload, ajaxFileUpload UploadedFile: Only a reference to DBIx file is found ajaxfileupload: Only release notes [2] Upload a file with tools/upload and stage-marc-import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:26:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:26:00 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-UP4V7uaKxL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Rebased last patch for change on dependency patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:30:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:30:31 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-PUkqeJsl0j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #11 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41678&action=edit Bug 14536: (follow-up) Adds polling to Page.pm and enhances navigation. This follow-up adds a subroutine poll to superclass Page.pm. Polling will execute an anonymous subroutine for as long as defined or until the subroutine is successful. Also adds enchancements to navigation success confirmations. In earlier versions, the modify patron page (memberentry.pl) defines page title as follows: Modify <category> patron <name> But in current version it is defined as follows: Modify patron <name> (<category>) Instead of checking for title "Modify patron", we now check for "Modify(.*)patron" for determining if we are on the right memberentry.pl page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:33:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:33:25 +0000 Subject: [Koha-bugs] [Bug 13073] Search in Russian and in Armenian In-Reply-To: <bug-13073-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13073-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13073-70-SG8w9RPVcx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13073 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:43:17 +0000 Subject: [Koha-bugs] [Bug 14694] New: Make decreaseloanHighHolds more flexible Message-ID: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Bug ID: 14694 Summary: Make decreaseloanHighHolds more flexible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This enhancement will add an option to the decreaseloanHighHolds preferences so that users have the ability to choose A) based on the number of holds, as Koha currently does or B) set a number of holds past the number of holdable items in that record Work to be done: l) Add new system Preferences o decreaseloanHighHoldsOffset o decreaseloanHighHoldslgnoreDamaged o decreaseloanHighHoldslgnoreLost o decreaselnanHighHoldslgnoreWthdrawn o decreaseloanHighHoldslgnoreNotForloan 2) Implement logic for new system preferences 3) Add unit tests We could possibly use the multi-select enhancement for system preferences from bug 9043 to avoid having 4 prefs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:43:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:43:24 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14694-70-pi2oSXBmCw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:48:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:48:19 +0000 Subject: [Koha-bugs] [Bug 14628] anonymization of patron data ignores refund lost In-Reply-To: <bug-14628-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14628-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14628-70-AnWDA1jPLI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14628 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sorry, I don't understand what you mean. Could you provide a step-by-step plan to reproduce the issue? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:49:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:49:04 +0000 Subject: [Koha-bugs] [Bug 3333] item status for "not for loan" by item type / item is different In-Reply-To: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3333-70-tvKDlI71hx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3333 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13) > (In reply to Nick Clemens from comment #12) > > > Additionally, a Place hold link should disappear in the opac, when it is > > > not possible to place a hold on any item of one biblio. > > > > Everything got marked 'Not for loan' as expected, but I didn't see the above > > triggered > > > Marcel, is it still valid? Should we remove from the test plan or it's a bug? The Place hold link disappears for a biblio with (all) items marked not for loan via the special itemtype. But here is the misunderstanding: The test plan does not include this specific case mentioned in the commit message. (Since the second biblio in the test plan only has one item of the itemtype with NFL.) So no bug, no actual change of test plan needed. Could have been an additional test in the test plan.. And it works for me :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:51:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:51:10 +0000 Subject: [Koha-bugs] [Bug 14695] New: Add ability to place multiple item holds on a given record per patron Message-ID: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Bug ID: 14695 Summary: Add ability to place multiple item holds on a given record per patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently Koha only allows one hold to be placed on a given bib per patron, even it the record has multiple items. This enhancement will give Koha the ability to place a hold on at least two items on the same bibliographic record. For example, in the case of a television season DVD which has one record but many unique items. Work to be done: 1) Locate all code in Koha that checks for a patron already having a hold on a record 2) Add a new system preference to define the number of holds allowed per record 3) Create new subroutine/method to check for this 4) Implement call to new sub in areas defined in part 1 5) Ensure no code in C4::Reserves assumes that it can modify holds based on borrowernumber only This is not the first attempt at such a feature, but previous iterations are far out of date. It's time for a fresh start. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:51:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:51:21 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14695-70-6VFOxsMFnb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 16:55:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 14:55:45 +0000 Subject: [Koha-bugs] [Bug 14143] Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields In-Reply-To: <bug-14143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14143-70-EU2sKDlC7U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14143 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Blocked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:05:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:05:10 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup In-Reply-To: <bug-13585-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13585-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13585-70-il45qOa58z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 41024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41024 Bug 13585 : Add a cronjob which send UsageStats monthly. Review of attachment 41024: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13585&attachment=41024) ----------------------------------------------------------------- ::: debian/koha-common.cron.monthly @@ +15,5 @@ > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see <http://www.gnu.org/licenses/>. > + > + > +koha-foreach --enabled /usr/share/koha/bin/cronjobs/share_usage_with_koha_community.pl The problem is that the share_usage_with_koha_community.pl considers it's an error to launch it if the pref is not enabled. There is a warning message and an exit 1 in this case. I suppose it's not what we want, the admin will receive an email every month. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:06:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:06:11 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-WK7A1H1r16@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #120 from Christopher Davis <mr.cataloger at gmail.com> --- Anyone care to reply to comment 115? I think that step 15 of the test plan is referring to Koha authorized values (Home>Administration>Authorized values) and not authorized access points from the authority file. Your thoughts? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:08:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:08:28 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14608-70-ZujY6y01Vm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The new pref should be added to the updatedb (atomicupdate file). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:11:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:11:12 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14608-70-fulEhBr1gO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The UsageStatsLastDisplay pref should be hidden (like UsageStatsID and usagestatslastupdatetime). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:13:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:13:10 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14608-70-grBClb6fZK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Otherwise everything looks good. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:17:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:17:51 +0000 Subject: [Koha-bugs] [Bug 14611] SMS::Send hangs on malformed mobile #, process_message_queue fails In-Reply-To: <bug-14611-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14611-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14611-70-xGVMDXYqXY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14611 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 3186 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:17:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:17:51 +0000 Subject: [Koha-bugs] [Bug 3186] invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail In-Reply-To: <bug-3186-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3186-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3186-70-86d41pO8f0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 14611 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:21:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:21:25 +0000 Subject: [Koha-bugs] [Bug 9913] String::Random should not be required given its limited usage In-Reply-To: <bug-9913-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9913-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9913-70-67BAFsgSym@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9913 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It's now used for the captcha at the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:22:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:22:44 +0000 Subject: [Koha-bugs] [Bug 14696] New: useless use of String::Random in catalogue/search.pl Message-ID: <bug-14696-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696 Bug ID: 14696 Summary: useless use of String::Random in catalogue/search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:25:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:25:49 +0000 Subject: [Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl In-Reply-To: <bug-14696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14696-70-xfnmdN1pAB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:25:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:25:52 +0000 Subject: [Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl In-Reply-To: <bug-14696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14696-70-eHmk57Gb1b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41680&action=edit Bug 14696: useless use of String::Random in catalogue/search.pl Bug 10404 adds the use of String::Random to catalogue/search.pl but bug 11369 removes it without removing the import line. Test plan: git grep String::Random catalogue/search.pl should not return anything -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:32:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:32:34 +0000 Subject: [Koha-bugs] [Bug 10454] Duplicate card numbers may be generated In-Reply-To: <bug-10454-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10454-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10454-70-phe3oSmGYk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- No activity for 2 years, lowering the severity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:35:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:35:03 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10855-70-hvx3v53ehW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #223 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Nicole C. Engard from comment #222) The query works for me, maybe you was using an old patchset? With the last patches, the correct collation (utf8_unicode_ci) is used for the new tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:35:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:35:46 +0000 Subject: [Koha-bugs] [Bug 6514] Save book price in different currencies (cataloging) In-Reply-To: <bug-6514-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6514-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6514-70-Th1qxoXjpd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:40:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:40:58 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: <bug-14697-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14697-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14697-70-yyHnLJiqjJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking cosponsors Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:40:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:40:45 +0000 Subject: [Koha-bugs] [Bug 14697] New: Extend and enhance "Claims returned" lost status Message-ID: <bug-14697-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Bug ID: 14697 Summary: Extend and enhance "Claims returned" lost status Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A group of librarians have been brainstorming about claimed returns in Koha. They think this would be a good list of features for a claims returned system in Koha: * Add a system preference to flag which lost status is "Claims returned". Not setting this pref would disable the feature. * Add ability to mark item as "Claims returned" * Add the ability to mark an item as claims returned from the checkouts table on the checkouts and patron details pages * This functionality would operate in the same way checkins and renewals do. * It may be better to slim down to one column of checkboxes for all three functions ( that is, one at a time with one set of checkboxes ) * The ability mark an item as "Claims returned" from the item details would be disabled when the feature is enabled. All claims returned marking would happen through the checkouts table. * Charge or don't charge for claims returned * Some libraries charge the lost fee on claimed returns, some don't. * Add system preference to ask ?charge?, ?don?t charge?, or ?ask for confirmation? when marking an item claimed returned * Some libraries want to alerted of repeat offenders. * Add a sys pref to offer an option to block a patron, or alert staff somehow, after a set number of claimed returns. * This will be a running total over the lifetime of the patron, not the current number of outstanding claimed returns. * There will need to be a table that stores basic information about the item on patron?s record so you can track how many times they?ve said ?i returned that? * This allows us to track claimed returns even for returned and deleted items * This data will display on a new tab on the patron record ( moremember.pl ) for "claims returned" items * Will store the status so we know if the claim is open or resolved * ex. [title 1] / checked out {date} / claimed {date} / not returned / notes * Remove item from patron's current checkouts on marking "claims returned" ( e.g. current lost behavior ) * Will stop fines from continuing to accrue for said item * show as missing in the opac and claimed returned in the staff client ( e.g. current lost behavior, no change needed ) * Be able to mark item as ?found? from claimed tab if item happens to be found ( using standard 'found' behavior Koha already has ) * Offer options of ?returned by patron? or ?found in library? in a pull down to the side of every item that has been claimed. * next to each claimed item have a ?notes? field. Should be in line editable for ease of use * Claimed items should be easily distinguishable on staff side (compared to other types of lost items) on patron check out under ?Attention? so alert ?Patron has claimed returns? that links to the ?Claimed? tab below ( in a similar fashion to the current restrictions system ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:51:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:51:13 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-8UnoNZBNmc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #115 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- FAIL opac/opac-password-recovery.pl FAIL spelling doesnt ==> doesn't FAIL valid defined(@array) is deprecated Smartmatch is experimental shift on reference is experimental (Maybe you should just omit the defined()?) FAIL C4/Passwordrecovery.pm FAIL pod *** ERROR: Spurious text after =cut in file C4/Passwordrecovery.pm *** ERROR: Spurious =cut command in file C4/Passwordrecovery.pm FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt FAIL spelling occured ==> occurred -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 17:59:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 15:59:53 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-PGoE8wxlfh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #121 from Christopher Davis <mr.cataloger at gmail.com> --- Step 29 of the test plan: the "Substitute" link to the right of the results list disappears after the first one or two searches, leaving only "View MARC" and "Import" links. Also, when viewing the search results within this interface, clicking the "Next>>" buttons located near the top and bottom of this list only works for the first two pages. Thereafter, clicking the "Next>>" buttons simply redisplays the same page (page two) except that the search results of page two fail to display (blank page). One must click on the number button of the next page (e.g. page three) in order to sequentially move through the pages. FWIW Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 18:28:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 16:28:40 +0000 Subject: [Koha-bugs] [Bug 3333] item status for "not for loan" by item type / item is different In-Reply-To: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3333-70-Y4GA53rUox@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3333 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Using an existing record, I get 1 item "available for loan" and 1 "available for reference". The one "available for reference" is the one with an item type not for loan. The display is the same before and after the patch. I don't manage to know why it has this status. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 19:03:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 17:03:37 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-ADDCCMnZmn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #122 from Jesse Weaver <jweaver at bywatersolutions.com> --- (In reply to Christopher Davis from comment #120) > Anyone care to reply to comment 115? I think that step 15 of the test plan > is referring to Koha authorized values (Home>Administration>Authorized > values) and not authorized access points from the authority file. Your > thoughts? > > Thanks Apologies, I responded via email out of habit, and forgot that doesn't work with Bugzilla. Yes, this is referring to the latter (CCODES, locations, etc.). However, the exact same infrastructure is used for item types (942$c), so you can test it that way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 19:25:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 17:25:02 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-GxLLE8PICC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 19:25:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 17:25:05 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-n9JrT6DiCu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41682&action=edit Bug 14693: Contract.t should generate dates based on current date The current test for still-active contracts fails because it was written with fixed dates, which already passed :-D This patch calculates the current date, and uses it to generate a future one, so the tests serve their purpose no matter what the current date is. To test: - Run: $ prove t/db_dependent/Contract.t => FAIL: activeonly compares contractenddate with now(), and fails because a fixed 2015-07-31 is writteng on the test data - Apply the patch - Run: $ prove t/db_dependent/Contract.t => SUCCESS: the sample data has been calculated using the current date and the tests pass. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 19:25:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 17:25:20 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-6HRwJ36HRh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 19:45:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 17:45:05 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-aNC39aqnec@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 19:45:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 17:45:55 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-7ERftNDd9f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #8 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #7) > Kyle, the test you have provided passes against master. > I would expect something to fail, and then to be fixed by your patch. > > Why is the version set to 3.18? My bad. I assumed the test would fail on master but failed to test my assumption! Not sure why the version was set that way. Updated to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 20:07:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 18:07:39 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: <bug-14180-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14180-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14180-70-bSqWnHdmvI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Agnes Rivers-Moore <arm at hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #4 from Agnes Rivers-Moore <arm at hanover.ca> --- I would like a global preference to turn "always show checkouts" on or off. It is not something we would want to select daily or per session or per staff person. There is also an extra row below "specify due date" in checkout that reports the barcode that was last checked out. If "always show" is turned on - this is no longer needed, as the information is displayed twice. I would wish to have that associated with the "Always show" function so that it only appears if "always show" is turned off. It uses up screen space we would rather use to see the last several items we checked out - and there is already room for only one or two rows to show unless the screen resolution is dialed up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 20:09:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 18:09:29 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-YNI0198PQc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41676|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 41683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41683&action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala <j.kylmala at gmail.com> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 20:45:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 18:45:27 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: <bug-14180-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14180-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14180-70-BXTwKLMLl4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 20:47:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 18:47:53 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-ambJ9vi8ip@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #9 from Kyle M Hall <kyle.m.hall at gmail.com> --- I just wanted to publicly observe that these unit tests are such a mess that I'm spending hours writing unit tests for a patch that took minutes to complete. We really need to think about how to clean these tests up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 20:55:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 18:55:01 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: <bug-11299-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-dtdxzX0UWA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #21 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 39477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39477 Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. Review of attachment 39477: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11299&attachment=39477) ----------------------------------------------------------------- ::: cataloguing/automatic_linker.pl @@ +29,5 @@ > +my $input = new CGI; > +print $input->header('application/json'); > + > +# Check the user's permissions > +my %cookies = fetch CGI::Cookie; Bug 14589 is attempting to standardize to CGI::Cookie->fetch; Please change your syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 20:55:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 18:55:12 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: <bug-11299-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-8VYwwhgBwA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14589 CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 20:55:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 18:55:12 +0000 Subject: [Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-Z7t6NyWSnh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 20:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 18:59:31 +0000 Subject: [Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-KevZWPnqr0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 41675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41675 Bug 14589: Replace fetch CGI::Cookie calls Review of attachment 41675: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14589&attachment=41675) ----------------------------------------------------------------- There is scope creep as noted below. It would make more sense to have a "Replace 'new CGI' calls" bug separately, as this occurs in more than just these places. ::: tools/background-job-progress.pl @@ +30,4 @@ > use CGI::Cookie; # need to check cookies before > # having CGI parse the POST request > > +my $input = CGI->new; Scope creep. @@ +51,4 @@ > $job_status = $job->status(); > } > > +my $reply = CGI->new; Scope creep. ::: tools/upload-file-progress.pl @@ +47,4 @@ > } > } > > +my $reply = CGI->new; Scope creep. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 21:24:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 19:24:31 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13624-70-qCx4HDEfW7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40329|0 |1 is obsolete| | --- Comment #28 from Martin Persson <xarragon at gmail.com> --- Created attachment 41684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41684&action=edit Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice TEST PLAN 1) Create or improve on overduerules data .1) Intranet -> tools -> overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' Sponsored by : Halland County Library Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com> Signed-off-by: Martin Persson <xarragon at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 21:25:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 19:25:12 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13624-70-x244QFGaYl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40330|0 |1 is obsolete| | --- Comment #29 from Martin Persson <xarragon at gmail.com> --- Created attachment 41685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41685&action=edit Bug 13624 - Tidying the atomicupdate file and kohastructure.sql Signed-off-by: Martin Persson <xarragon at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 21:33:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 19:33:50 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-FfjuW6k0Jw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 19 21:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 19:43:17 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13624-70-vSX0raMbBU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |xarragon at gmail.com --- Comment #30 from Martin Persson <xarragon at gmail.com> --- Tested these patches against origin/master commit 75d123d760d86f0e0d9f58d65874b40f6816008d. Both patches merged perfectly and both manual and automated tests passed. Tested with 3 categories and all tabs filled with complex, unique combinations of rules. Verified by screenshot before and after. Code looks good to me but I am unfamiliar with some SQL details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 00:25:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 22:25:11 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-BHLe9b8w3U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #116 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 41686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41686&action=edit Bug 8753 - [followup} Correcting spelling mistakes Make sure it all still works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 00:45:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 22:45:55 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-NxPh9PMVtB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41455|0 |1 is obsolete| | --- Comment #117 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 41687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41687&action=edit Bug 8753 - [followup] fix error when no information is provided To test: All normal checks plus make sure that a nice error is displayed when no data is provided. fixing the deprecated thing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 01:20:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Aug 2015 23:20:06 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-SkLbCY8t5N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #118 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 41688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41688&action=edit Bug 8753 - [followup] POD cleanup Check to make sure the messages from the qa checker are gone. Note I'm not sure about this one because my test tools are apparently broken, and I can't get the error to manifest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 05:56:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 03:56:23 +0000 Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page In-Reply-To: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14579-70-XFNBAOkBgp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 06:43:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 04:43:07 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-2dKWW41NCb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #5 from Liz Rea <liz at catalyst.net.nz> --- Possibly you are right, I'd need to do a bit of reading. Thanks for pointing that out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 08:29:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 06:29:59 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10468-70-lwydvcV0un@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 08:30:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 06:30:18 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10468-70-y9wPDnULo8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 --- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> --- Created attachment 41689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41689&action=edit Bug 10468: Adding holds table to summary print To test: 1) Add a hold to a patron 2) Go to patron page 3) Click Print Summary 4) Confirm that 'Pending Holds' table displays with correct information under appropriate headings (should be Title, Author, Placed on (reserve date), Expires on (expiration date), and Pick up library) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 08:34:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 06:34:20 +0000 Subject: [Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made In-Reply-To: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14675-70-v7ts08KqBn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 08:34:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 06:34:36 +0000 Subject: [Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made In-Reply-To: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14675-70-iZu9UmHBEZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41605|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> --- Created attachment 41690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41690&action=edit Bug 14675: Don't update details if no changes made if no changes has been made for personal details, bring user back to details page and inform them that no changes has been made. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 08:53:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 06:53:57 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-eFNSRowSrh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace fetch CGI::Cookie |Adjust |calls |authorities_merge_ajax and | |replace some indirect | |syntax --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to M. Tompsett from comment #5) > There is scope creep as noted below. It would make more sense to have a > "Replace 'new CGI' calls" bug separately, as this occurs in more than just > these places. I would not really mind, but most important for me now is to get bug 14321 rolling. And this is a dependency.. What about a title change :) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 08:59:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 06:59:09 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-a7IaOcILps@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41675|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41691&action=edit Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax This patch does the following: [1] Adjust authorities_merge_ajax just as in bug 14588. [2] Replace some indirect syntax for fetch GGI::Cookie. [3] Along the way replace some new CGI's. Note that I am not aiming to replace them Koha wide. The "fetch class" variant is less readable. Test plan: [1] Run the URL authorities/merge_ajax.pl in staff. [2] Upload a file with Stage MARC records for import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 09:12:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 07:12:54 +0000 Subject: [Koha-bugs] [Bug 3333] item status for "not for loan" by item type / item is different In-Reply-To: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3333-70-1QUXWwsaGE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3333 --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #16) > Using an existing record, I get 1 item "available for loan" and 1 "available > for reference". > The one "available for reference" is the one with an item type not for loan. > > The display is the same before and after the patch. > I don't manage to know why it has this status. Without the patch === staff catalogue results: 2 items, 2 available opac xslt results: 1 for loan, 1 for reference opac non-xslt results: Available: branch(1), branch(1) With the patch: === staff catalogue results: 2 items, 1 available opac xslt results: 1 for loan, 1 for reference opac non-xslt results: Available: branch(1) So, your test confirms my opac xslt results. But note the results in opac non-xslt and staff catalogue. See commit message. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 09:15:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 07:15:12 +0000 Subject: [Koha-bugs] [Bug 13073] Search in Russian and in Armenian In-Reply-To: <bug-13073-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13073-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13073-70-XWXlwbicSR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13073 --- Comment #2 from Joonas Kylm?l? <j.kylmala at gmail.com> --- I couldn't replicate this in 3.16 nor newer releases. What type the search string was? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 09:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 07:23:17 +0000 Subject: [Koha-bugs] [Bug 14582] OPAC detail shows an unuseful link to "add tag" when user is not logged in In-Reply-To: <bug-14582-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14582-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14582-70-55aYtmBVCE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14582 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 09:25:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 07:25:40 +0000 Subject: [Koha-bugs] [Bug 3333] item status for "not for loan" by item type / item is different In-Reply-To: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3333-70-jBmY8U9NFV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3333 --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Joubu: $status = "reference"; see XSLT.pm sub buildKohaItemsNamespace (why did I forget that :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 09:29:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 07:29:16 +0000 Subject: [Koha-bugs] [Bug 13324] [DEPENDS_ON_13321] The fund values must be based on tax included values In-Reply-To: <bug-13324-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13324-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13324-70-yDCuTS4y7L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The fund values must be |[DEPENDS_ON_13321] The fund |based on tax included |values must be based on tax |values |included values CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 09:30:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 07:30:04 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: <bug-13321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13321-70-jI25NCPYAT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Back to the needs QA queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 09:35:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 07:35:23 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-8L7ZZvK9sP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #9) > I just wanted to publicly observe that these unit tests are such a mess that > I'm spending hours writing unit tests for a patch that took minutes to > complete. We really need to think about how to clean these tests up. I totally agree with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 09:38:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 07:38:17 +0000 Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via plugin In-Reply-To: <bug-13775-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13775-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13775-70-Ty5hodQHBb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- I get also similar error: Can't call method "subfields" on an undefined value at ~/kohaclone/authorities/blinddetail-biblio-search.pl line 88. First I edit marc record's field 648 -> chronological term, then I try to add there one by clicking a link on the left side of the field. From there it opens me to a new window: cgi-bin/koha/authorities/auth_finder.pl. In that window I click Create a new authority, I click on the authority creating fields randomly, I don't input there anything but the window puts there some randomly looking data itself, and after that I try to save the new authority and it gives the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 09:48:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 07:48:05 +0000 Subject: [Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh In-Reply-To: <bug-14375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14375-70-DUJ6abTlz4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375 --- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #15) > (In reply to Fridolin SOMERS from comment #14) > > Created attachment 41439 [details] > > test module > > > > Test module. > > > > It saves a record and tries to get it each 15 minutes 4 times. > > Without patch, it fails with : database has run away. > > Why 900sec? It is to loose the DB connexion. Maybe a few minutes is enought. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 09:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 07:51:09 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-XW09181ode@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:02:21 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: <bug-11747-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11747-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11747-70-TEdDZQTeUu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Applying: Bug 11747 - Add system preference DefaultToLoggedInLibraryOverdueTriggers /home/koha/testclone/.git/rebase-apply/patch:50: trailing whitespace. - When editing overdue notice/status triggers show the fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:03:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:03:30 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: <bug-11747-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11747-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11747-70-CQNaHGDuWf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #23) > Applying: Bug 11747 - Add system preference > DefaultToLoggedInLibraryOverdueTriggers > /home/koha/testclone/.git/rebase-apply/patch:50: trailing whitespace. > - When editing overdue notice/status triggers show the > fatal: sha1 information is lacking or useless > (installer/data/mysql/sysprefs.sql). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. oops, dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:09:14 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-J1CUIEHmtL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37609|0 |1 is obsolete| | Attachment #37610|0 |1 is obsolete| | Attachment #37611|0 |1 is obsolete| | Attachment #37612|0 |1 is obsolete| | Attachment #37613|0 |1 is obsolete| | Attachment #37614|0 |1 is obsolete| | Attachment #37653|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41692&action=edit Bug 11759: Batch checkout - prepare the ground This patch does not introduce any changes. It prepares the circulation script to accept several barcodes in parameter. A loop is done on all barcodes (until now, only 1) to generate a structure to sent to the template. At the end, only the first generated data is sent. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:09:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:09:19 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-5J46vZFI18@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41693&action=edit Bug 11759: Batch checkout - Add the new template This patch is the main patch. It adds: - the new template circ/circulation_batch_checkouts.tt - the change into circ/circulation.pl === Why this feature is useful for some libraries? === Currently Koha does not allow to checkout several items at once to a user. This can cause a waste of time when a user want to checkout more than 10 items. This development has been asked to have statistics on in-house use. Every night, a librarian will enter a barcode list (from a file or a scanner : the librarian scans the barcode of the documents that users let on the tables). Barcodes will be added to a statistics patron in order to count the number of items consulted. The development has been expanded to cover another need: some special libraries (BDP for "Bibliotheque departementale de pret": "Loan Regional Library"). These libraries loan items to smaller libraries (municipal). The number of items could be very important and the current way offered by Koha is not adequate. === Test plan === 0/ Apply all patches and execute the DB change entry. 1/ Verify you are abble to do some checkouts (with confirmations, errors). = Statistics way = 2/ Create a statistical patron (e.g. category code STATS). 3/ Update the batch_checkouts pref with the category code (STATS). 4/ Go on the member page and verify the new "Batch check out" tab appears (and only for this user). 5/ Check some items out on the new page using the textarea or a file. 6/ Verify the table contains the item's information and the "Information" column contains "Local use recorded". = Real checkouts = 7/ Create a non statistical patron and update the pref. 8/ Check some items out on the new page using the textarea or a file. 9/ Verify the information in the table is consistent. 10/ Verify item without confirmation needed or impossible alert is checked out. 11/ If the logged in user has the "force_checkout" permission, all checkouts with a "confirmation needed" message can be done. If the logged in user does not have it, there is no way to force the checkout. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:09:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:09:24 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-SjvK0jafL8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41694&action=edit Bug 11759: Add links to the new page Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:09:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:09:30 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-8i9FNh33q8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41695&action=edit Bug 11759: Add some css to highlight warnings and errors Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:09:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:09:36 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-OW132kTjdn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41696&action=edit Bug 11759: Batch checkout - DB changes Add the new pref batch_checkouts in DB. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:09:41 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-gBmYSz0qbt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41697&action=edit Bug 11759: (follow-up) Some fixes This is a squash of the following patches: Bug 11759: (follow-up) Prevent access to the batch checkout if not allowed If a user pass '&batch=1' to the url, he was allowed to access to the batch checkout page even if the patron is not in an authorised category. This patch also fixes the link to "Batch check out" from the "Details" tab (cf changes in circ-menu.inc). Bug 11759: FIX Javascript error The following JS error occurred: ReferenceError: MSG_ADD_MESSAGE is not defined The circulation.js file is useless and should not be included. Bug 11759: FIX the alert message if an item is on hold. If an item is on hold, the hold is not cancelled. This patch corrects the message displayed in this case. Bug 11759: FIX issue list is empty The issue list is empty after checking an item out to a patron without existing checkout. To reproduce: - Search for a patron without checkout. - Check an item out using the "normal" checkout. - Verify the checkout list contain the checkout. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:09:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:09:47 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-2qyASItmkB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41698&action=edit Bug 11759 [QA Followup] - Fix koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:10:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:10:31 +0000 Subject: [Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl In-Reply-To: <bug-14696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14696-70-eWYuJs3waE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41680|0 |1 is obsolete| | --- Comment #2 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41699&action=edit Looks like there is no dependencies to that module. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:14:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:14:43 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-kjCKTZffh7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:22:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:22:00 +0000 Subject: [Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl In-Reply-To: <bug-14696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14696-70-t5duP5CYDZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:30:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:30:42 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11625-70-Qqn1htuHmB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #49 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I put this patch in FQA now. I think first Kyle should comment on the counter patch before anyone else does anything else :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:34:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:34:36 +0000 Subject: [Koha-bugs] [Bug 13321] [DEPENDS 12826] Tax and prices calculation need to be fixed In-Reply-To: <bug-13321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13321-70-Uxiany3lQS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Summary|Tax and prices calculation |[DEPENDS 12826] Tax and |need to be fixed |prices calculation need to | |be fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:36:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:36:05 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13734-70-Mc1e8wE0me@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:36:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:36:12 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13734-70-0S5MDtPLBz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:45:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:45:33 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-NZ0HE9Vzp3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41528|0 |1 is obsolete| | --- Comment #5 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41700&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:48:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:48:14 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-CKPOdlPMdz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41700|0 |1 is obsolete| | --- Comment #6 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41701&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:54:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:54:32 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13734-70-nMU091e3AG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38957|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41702&action=edit Bug 13734: RDA: Display 33xs Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 336,337,338 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Adds fields 336, 337 and 338 to staff and opac details. Adds comma between multiple subfields and | with class='separator' between multiple datafields (e.g. two 336 fields) 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works, no errors Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 10:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 08:56:22 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13734-70-R8QKjQcEPm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: Had to make these fields visible, but works fine. Note that delimeter looks like a spelling error, but it is already there.. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:02:12 +0000 Subject: [Koha-bugs] [Bug 13321] [DEPENDS 12826] Tax and prices calculation need to be fixed In-Reply-To: <bug-13321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13321-70-9beTQ17BWC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Bug 13321 depends on bug 12826, which changed state. Bug 12826 Summary: GST / VAT rewrite - plumbing http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12826 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:02:12 +0000 Subject: [Koha-bugs] [Bug 12826] GST / VAT rewrite - plumbing In-Reply-To: <bug-12826-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12826-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12826-70-3SGoeSlQgs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12826 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The plumbing is done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:02:12 +0000 Subject: [Koha-bugs] [Bug 12825] GST / VAT rewrite In-Reply-To: <bug-12825-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12825-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12825-70-ogB8pRwDx6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12825 Bug 12825 depends on bug 12826, which changed state. Bug 12826 Summary: GST / VAT rewrite - plumbing http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12826 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:02:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:02:13 +0000 Subject: [Koha-bugs] [Bug 13318] C4::Acq::GetParcel is not used and can be removed In-Reply-To: <bug-13318-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13318-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13318-70-xbLTQPZFPY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318 Bug 13318 depends on bug 12826, which changed state. Bug 12826 Summary: GST / VAT rewrite - plumbing http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12826 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:02:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:02:31 +0000 Subject: [Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed In-Reply-To: <bug-13321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13321-70-jDYKhyhhsI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DEPENDS 12826] Tax and |Tax and prices calculation |prices calculation need to |need to be fixed |be fixed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:05:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:05:05 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: <bug-14649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14649-70-q8RSORBi37@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Mirko Tietgen from comment #7) > (In reply to Fridolin SOMERS from comment #5) > > > => You see in URL that budget_id is empty : > > /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id= > > > => you see in URL that budget_id is defined like in planning page : > > > > /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=2 > > Do you mean ?budget_period_id is empty/defined? (not budget_id) in both > cases? Yes indeed, thanks for this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:06:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:06:33 +0000 Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via plugin In-Reply-To: <bug-13775-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13775-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13775-70-oMrVdkVK1E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Debug: It's because the field 148 is not filled # If 148 is not set, @fields = (); 82 my @fields = $record->field( $auth_type->{auth_tag_to_report} ); # Repet is never set, so $repet = 0 83 my $repet = ($query->param('repet') || 1) - 1; 84 my $field = $fields[$repet]; 85 86 # Get all values for each distinct subfield 87 my %subfields; if 148 is not set, boom here 88 for ( $field->subfields ) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:07:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:07:31 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: <bug-14649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14649-70-gkxsWkHfmT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41398|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 41703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41703&action=edit Bug 14649: Followup - correct budget_period_id in fund name link Now that fund name is displayed in the table as a link, you see that arg budget_period_id is never defined in this link. This is because the template var is [% budget_line.budget_period_id %] instead of [% budget_period_id %]. This looks like a mistake when converting from tmpl to tt. Test plan : - Without patch - Look for a planning with funds : /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS - Click on a fund name => You see in URL that budget_period_id is empty : /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id= - Apply patch - Look for a planning with funds : /cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS - Click on a fund name => you see in URL that budget_period_id is defined like in planning page : /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:08:06 +0000 Subject: [Koha-bugs] [Bug 3333] item status for "not for loan" by item type / item is different In-Reply-To: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3333-70-8r1BxoSmoO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3333 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:08:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:08:08 +0000 Subject: [Koha-bugs] [Bug 3333] item status for "not for loan" by item type / item is different In-Reply-To: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3333-70-0QzCR4BG3Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3333 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40599|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41704&action=edit Bug 3333: Confusing item status for not-for-loans Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:17:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:17:18 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6499-70-AMGv7L2guA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:17:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:17:27 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6499-70-DUc26UkbCG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:20:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:20:21 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10363-70-SlTFISrxjz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:22:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:22:17 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: <bug-5262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5262-70-LxLaf0pxQX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Jo?o Pinto <joao.pinto at ua.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joao.pinto at ua.pt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:35:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:35:55 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-TKrDGPB2J8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:35:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:35:58 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-IR6LQGrYkJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41705&action=edit Bug 14505: single quotes in journal number cause print routing list window to not appear Escapes single quotes from serial.serialseq string. Test plan: 1. Have a serial with a number which has single quote in it. 2. Go to Serials -> Find some serial subscription -> Serial collection. 3. Set up a routing list for this serial. 4. Click on Print list under the column Routing. 5. Notice that the print window doesn't open. 6. Apply patch. 7. Notice that the print window opens. Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:47:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:47:49 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13624-70-43kPWizJVF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Blou from comment #20) > 4) Took me a while to remember WHY we want it out. I guess it's premature, > but this is the first step to allow for unlimited "steps", and as such that > combo cannot be unique. BUT this being the first step, I cannot justify > removing it yet, only that it will be more complicated to remove later. > I WILL LEAVE IT IN, you being QA and all ;) Sorry, but I think that the constraint should not be removed in this patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 11:53:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 09:53:07 +0000 Subject: [Koha-bugs] [Bug 4888] pre-set of field indicators value In-Reply-To: <bug-4888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4888-70-aDruT8l0Do@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Jo?o Pinto <joao.pinto at ua.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joao.pinto at ua.pt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:05:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:05:00 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-dnzUxWRkTc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #119 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Does the status should be Signoff? I would say we should not provide any information if the user does not fill correct login or email. The message should be generic "Bad info" instead of "Bad login" or "Bad email". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:06:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:06:10 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-Od3ai98MNA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #120 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- >From perldoc rand: rand() is not cryptographically secure. You should not rely on it in security-sensitive situations. As of this writing, a number of third-party CPAN modules offer random number generators intended by their authors to be cryptographically secure, including: Data::Entropy, Crypt::Random, Math::Random::Secure, and Math::TrulyRandom. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:06:50 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-lmEQTe7tPL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41688|0 |1 is obsolete| | --- Comment #121 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41706&action=edit Bug 8753 - [followup] POD cleanup Check to make sure the messages from the qa checker are gone. Note I'm not sure about this one because my test tools are apparently broken, and I can't get the error to manifest. Amended patch by Jonathan Druart: Add a blank line before =head2 It now passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:11:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:11:47 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-SFGgqrxX2A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #122 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 1/ Receive the email 2/ Click on the link 3/ Change the pwd 4/ Click again on the link 5/ Change the pwd 6/ You get an error The error should appear at step 5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:13:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:13:31 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-38GUZ3ZB4b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #123 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- comment 21 did not get an answer. For instance tests are still missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:13:39 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: <bug-10832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10832-70-hIq6iLxnmV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 delaye <stephane.delaye at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye at biblibre.co | |m --- Comment #34 from delaye <stephane.delaye at biblibre.com> --- In 3.18 -> if a user don't have an email defined and an email is required and print is not required, a print notice is generated with the content of email. -> if a user don't have an email defined and an email is required and print is required, a print notice is generated with the content of print. Print required ou not not required , we must have a print notice with content of print not content of email with a message_transport_type=print.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:21:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:21:26 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-Lt6Uxtfwwi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:21:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:21:28 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-M6mt4PlDv0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41683|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41707&action=edit Bug 14588: Simplify merge_ajax.pl This script does not need a few modules: IO::File; CGI::Session; C4::UploadedFile. Warnings can be enabled (with Modern::Perl). Indirect object syntax replaced for CGI and CGI::Cookie. Moved the $reply line upwards (not needed twice anymore). Test plan: [1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl. You should see the JSON reponse in the browser. [2] Logout. Run the URL again. Blank screen. [3] Go to addbooks.pl (Cataloging Search). Search something, select two biblios and click Merge selected, etc. Signed-off-by: Joonas Kylmala <j.kylmala at gmail.com> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:24:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:24:52 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: <bug-10832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10832-70-KvEn7aLSrU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to delaye from comment #34) > In 3.18 > > -> if a user don't have an email defined and an email is > required and print is not required, a print notice is generated with the > content of email. > > -> if a user don't have an email defined and an email is > required and print is required, a print notice is generated with the > content of print. > > Print required ou not not required , we must have a print notice with > content of print not content of email with a message_transport_type=print.... It looks the same as bug 14133. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:25:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:25:02 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14133-70-NRMlYcYopE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sophie, what do you suggest? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:43:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:43:37 +0000 Subject: [Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script In-Reply-To: <bug-13572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13572-70-GIAzBN0UiM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |remi.mayrand-provencher at inL |ity.org |ibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:43:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:43:54 +0000 Subject: [Koha-bugs] [Bug 14497] Add warning to patron details page if patron's fines exceed noissuescharge In-Reply-To: <bug-14497-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14497-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14497-70-i7vgg22ZCy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:44:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:44:22 +0000 Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer In-Reply-To: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14622-70-459pUN2PZQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |francois.charbonnier at inlibr |ity.org |o.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:45:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:45:40 +0000 Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer In-Reply-To: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14622-70-OK7NbzmkVr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- How did you generate this list? Be care, userpermissions.sq is not up-to-date. Why did you create fr-CA/obligatoire? (we have a fr-FR/1-Obligatoire). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:45:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:45:58 +0000 Subject: [Koha-bugs] [Bug 14634] Warns when placing hold on record with no items In-Reply-To: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14634-70-Wz2T7DbuE0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:47:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:47:57 +0000 Subject: [Koha-bugs] [Bug 14641] Warns in subscription-add.pl In-Reply-To: <bug-14641-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14641-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14641-70-4txjuEJcTp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|Needs Signoff |Failed QA Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The brackets should be kept, for consistency at least. I haven't tested, but this patch is certainly wrong. Moreover, tests should be provided. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:49:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:49:02 +0000 Subject: [Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup list In-Reply-To: <bug-14654-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14654-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14654-70-XbhWAh2xb3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nicolas.legrand at bulac.fr |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:50:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:50:32 +0000 Subject: [Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines. In-Reply-To: <bug-14687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14687-70-4VhiZTpK4O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |j.kylmala at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:53:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:53:23 +0000 Subject: [Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options In-Reply-To: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14690-70-OdpPq6c0df@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |liz at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:54:08 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-Gxw9NaFV40@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14505 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:54:08 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-ldch0Gx7vK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14691 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:54:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:54:20 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-5QyqAehcqN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |j.kylmala at gmail.com |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:58:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:58:40 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-DvJhCTl7Jk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 41682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41682 Bug 14693: Contract.t should generate dates based on current date Review of attachment 41682: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14693&attachment=41682) ----------------------------------------------------------------- ::: t/db_dependent/Contract.t @@ +72,5 @@ > is( $contract->{contractdescription}, $my_contract1->{contractdescription}, 'AddContract stores the contract description correctly.' ); > is( $contract->{booksellerid}, $my_contract1->{booksellerid}, 'AddContract stores the bookseller id correctly.' ); > > +my $now = dt_from_string; > +my $three_more_days = $now + DateTime::Duration->new( days => 3 ); 1/ DateTime::Duration should be imported 2/ Are you sure this works ? There are the 2 add_duration or subtract_duration methods, which is certainly better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 12:59:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 10:59:33 +0000 Subject: [Koha-bugs] [Bug 14649] fund names not displayed in budget planning In-Reply-To: <bug-14649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14649-70-Fc2hsCbTj8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:03:29 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-1nRr9lheyf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Julian, please rebase, I will try to have a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:08:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:08:40 +0000 Subject: [Koha-bugs] [Bug 14379] Batch item modification tool - Can't change custom subfields In-Reply-To: <bug-14379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14379-70-MiCvh7nB70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14379 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Can you list the steps of how to reproduce this bug. I have had hard time trying to figure out how to reproduce this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:14:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:14:25 +0000 Subject: [Koha-bugs] [Bug 14378] koha-run-backups should check disk usage first In-Reply-To: <bug-14378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14378-70-W2Bls1WhDm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14378 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Pablo AB from comment #0) > + option to backup indefinitely until destination dir/partition grow up to a > given percentage (lets say 95 (%)). The size of backups & free space could vary then quite a lot if there is a huge/small storage in use. I suggest to leave there some nMb/nGb of space. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:15:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:15:22 +0000 Subject: [Koha-bugs] [Bug 14698] New: AtomicUpdater - Keeps track of which updates have been applied to a database Message-ID: <bug-14698-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 Bug ID: 14698 Summary: AtomicUpdater - Keeps track of which updates have been applied to a database Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org We need to know which atomicupdates have been deployed to various test databases. This feature adds a database table to keep track of the deployed updates. There is also a cronjob to easily interface with the atomicupdate database log to revert entries and show them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:16:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:16:34 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-uNUu5NZKiR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:16:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:16:36 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-9NJgCGBUah@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41263|0 |1 is obsolete| | Attachment #41569|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41708&action=edit Bug 14337 - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:16:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:16:44 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-U2E1llCnTB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41709&action=edit Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability AllowRenewalIfOtherItemsAvailable checks C4::Reserves::IsAvailableForItemLevelRequest to see if the item is holdable, which catches not for loan values less than 0 ( i.e. holdable, but not circ-able ). However, since this feature is about actually checking out items to patrons, we should not count *any* not for loan items when deciding if the available items will satisfy all current holds. Test Plan: 1) Enable AllowRenewalIfOtherItemsAvailable 2) Create a record with two items 3) Check out one item to a patron 4) Ensure the item is renewable 5) Place a hold on the record 6) The item should now be non-renewable 7) Add a second item to the record, but with a not for loan value < 0 8) Note the checkout is still renewable 9) Apply this patch 10) Note the checkout is now non-renewable Works ok. Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:17:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:17:58 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-1637I0rOmW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #13 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #10) > (In reply to Kyle M Hall from comment #9) > > I just wanted to publicly observe that these unit tests are such a mess that > > I'm spending hours writing unit tests for a patch that took minutes to > > complete. We really need to think about how to clean these tests up. > > I totally agree with that. Success! I created a new block of tests at the end of the file and by starting from scratch ( mostly ) I believe I have now crafted a correct unit test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:25:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:25:17 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-0ZOKZ6rvsq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Koha -> Tools -> Notices, you mean? Would there be one one row per patron and there would be all the info? I'm not sure if I understood right what you suggested. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:35:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:35:28 +0000 Subject: [Koha-bugs] [Bug 11388] Error exporting records to non-Unicode/MARC-8 In-Reply-To: <bug-11388-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11388-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11388-70-Z9DIT8IpdM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com Assignee|oleonard at myacpl.org |j.kylmala at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:57:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:57:59 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6499-70-wZZFrkg6Xj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:58:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:58:02 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6499-70-xFMZo325Vs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39099|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41710&action=edit Bug 6499: Add Zebra index "Other-control-number" covering MARC21 035$a, 035$z and 035 (entire tag) 1) Apply patch 2) Make sure that you have a bib that has MARC21 035$a (and possibly also 035$z) populated. pre 3) Replace all modified zebra files and restart zebra server 3) Rebuild zebra: misc/migration_tools/rebuild_zebra.pl -x -b -z 4) Add the following to the intranetuserjs syspref: $(document).ready(function(){ // Add Other Control Number to advanced search if (window.location.href.indexOf("catalogue/search.pl") > -1) { $(".advsearch").append('<option value="Other-control-number">Other Control Number</option>'); } }); 5) Do an advanced search, select "Other Control Number" from the search menu, then add the Other Control Number in 035$a for the bib specified in step 1. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works, no koha-qa errors Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 13:58:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 11:58:06 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6499-70-csoC7OGGuo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41711&action=edit Bug 6499: [QA Follow-up] Trivial adjustments Removes commented line from bib1.att. Adjust OCLC-number to Other-control-number in comment of ccl properties. No need to explicitly add 035$a and $z if you index 035 completely in record.abs as well as biblio-koha-indexdefs.xml. Rerun koha-indexdefs-to-zebra.xsl on index defs. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:03:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:03:24 +0000 Subject: [Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching In-Reply-To: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6499-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6499-70-vfcZE2HXtZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: Works for me, added a followup. The test plan includes an addition to intranetuserjs to use this field. But many users will miss that of course. If you really would need it in the menu, you could do that on a separate report. Full-text search will find it too of course now. Instead of Other-control-number perhaps System-control-number would still have been closer to the LOC naming :) No problem for me. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:13:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:13:26 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-dZqBSoLAGR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:27:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:27:29 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14608-70-rQEwFY55ij@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #7 from Julian FIOL <julian.fiol at biblibre.com> --- Created attachment 41712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41712&action=edit Bug 14608 : Adding the new syspref UsageStatsLastDisplay to the updatedb (atomicupdate dir) In response of Joubu comment #4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:28:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:28:35 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-UCTPB56SAc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #2) > Comment on attachment 41682 [details] [review] > 1/ DateTime::Duration should be imported I agree. Will fix it now. > 2/ Are you sure this works ? There are the 2 add_duration or > subtract_duration methods, which is certainly better. It is just syntax sugar. Using the plus symbol is correctly documented on DateTime: $dt2 = $dt + $duration_object; $dt3 = $dt - $duration_object; I think it provides better readability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:29:05 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14608-70-QIzvfa3k15@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #8 from Julian FIOL <julian.fiol at biblibre.com> --- Created attachment 41713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41713&action=edit Big 14608 : Hide UsageStatsLastDisplay syspref In response of Joubu comment #5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:29:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:29:35 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14608-70-nF5s5DqIsN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Julian FIOL <julian.fiol at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:34:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:34:09 +0000 Subject: [Koha-bugs] [Bug 14373] Disallow payment of accruing fines In-Reply-To: <bug-14373-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14373-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14373-70-itK7RwB5Us@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14373 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- I wasn't able to apply the patch because some 3-way merge problems. Can you send the patch again in a version where there is no connections to some other git histories, or what might be causing the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:43:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:43:04 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-ksnGP4327K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #60 from Viktor Sarge <viktor.sarge at regionhalland.se> --- Seems to work as advertised in the testplan and may prove quite useful for using RFID readers that send all barcodes in a batch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:49:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:49:41 +0000 Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer In-Reply-To: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14622-70-ny1lInzODK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 --- Comment #3 from Francois Charbonnier <francois.charbonnier at inlibro.com> --- Hi Jonathan, How did you generate this list? - I checked what the english folder had Be care, userpermissions.sq is not up-to-date. - I will check this (but did this file change since 3.20.0?) Why did you create fr-CA/obligatoire? (we have a fr-FR/1-Obligatoire). - Because, when installing in fr-CA, the installer will not check in the fr-FR folder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:50:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:50:38 +0000 Subject: [Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made In-Reply-To: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14675-70-IZD7B4dweT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:50:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:50:41 +0000 Subject: [Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made In-Reply-To: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14675-70-HnXFOLDIvC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41690|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41714&action=edit Bug 14675: Don't update details if no changes made if no changes has been made for personal details, bring user back to details page and inform them that no changes has been made. Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:58:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:58:48 +0000 Subject: [Koha-bugs] [Bug 14369] don't allow labels on staged records In-Reply-To: <bug-14369-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14369-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14369-70-if92WW0e11@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14369 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #2 from Joonas Kylm?l? <j.kylmala at gmail.com> --- I can reproduce this bug with non-unicode marc8 files. With unicode utf-8 MARC files there is no problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 14:59:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 12:59:11 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-OYKqCIgshO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:05:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:05:17 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-AbbzO9ToaD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41682|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41715&action=edit Bug 14693: Contract.t should generate dates based on current date The current test for still-active contracts fails because it was written with fixed dates, which already passed :-D This patch calculates the current date, and uses it to generate a future one, so the tests serve their purpose no matter what the current date is. To test: - Run: $ prove t/db_dependent/Contract.t => FAIL: activeonly compares contractenddate with now(), and fails because a fixed 2015-07-31 is writteng on the test data - Apply the patch - Run: $ prove t/db_dependent/Contract.t => SUCCESS: the sample data has been calculated using the current date and the tests pass. - Sign off :-D Edit: added missing use DateTime::Duration, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:10:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:10:07 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-FfZ2PkAQux@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14517 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:10:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:10:07 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14517-70-6NtmSKC3Mi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:11:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:11:57 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-JPFYyPfnCH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 41708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41708 Bug 14337 - Add Unit Tests Review of attachment 41708: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14337&attachment=41708) ----------------------------------------------------------------- ::: t/db_dependent/Circulation.t @@ +649,5 @@ > + my $borrower2 = GetMember( borrowernumber => $borrowernumber2 ); > + > + my $issue = AddIssue( $borrower1, $barcode1 ); > + > + my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber2, $itemnumber1 ); Shouldn't be borrowernumber1? Chelsea didn't check out itemnumber1. @@ +667,5 @@ > + > + ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber2, $itemnumber1 ); > + is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled' ); > + > + diag("Setting item not checked out to be not for loan but holdable"); No need to overload the output, just a comment would be enough, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:14:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:14:40 +0000 Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer In-Reply-To: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14622-70-QaaEfPicyA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Francois Charbonnier from comment #3) > Hi Jonathan, > > How did you generate this list? > - I checked what the english folder had > > Be care, userpermissions.sq is not up-to-date. > - I will check this (but did this file change since 3.20.0?) No, but 3.20 has delete_public_lists. > Why did you create fr-CA/obligatoire? (we have a fr-FR/1-Obligatoire). > - Because, when installing in fr-CA, the installer will not check in the > fr-FR folder. Yes of course, but why not fr-CA/1-Obligatoire? I don't care, just want to know :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:15:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:15:19 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-O69Yrc8A3Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #42 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Patch "Make the intranet side independent of Page.pm" needs rebase since Bug 14517 is pushed. Nice job btw -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:15:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:15:45 +0000 Subject: [Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made In-Reply-To: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14675-70-PNtgnBvLMJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Patch complexity|--- |Small patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:16:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:16:18 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-1C6rvwo5Mt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- So, passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:29:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:29:01 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-FyV38oNcqN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:31:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:31:41 +0000 Subject: [Koha-bugs] [Bug 14369] don't allow labels on staged records In-Reply-To: <bug-14369-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14369-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14369-70-VFPB9OxgEU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14369 --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Joonas Kylm?l? from comment #2) > I can reproduce this bug with non-unicode marc8 files. With unicode utf-8 > MARC files there is no problem. I was a bit confused about how to import the MARC files there and which type of a MARC file, but I guess the one I should have imported there was MARC (Unicode/UTF-8) type of file. With that type of file the bug exists also, as I tried just a moment ago. I'll try to look into what might cause the bug here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:33:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:33:32 +0000 Subject: [Koha-bugs] [Bug 14369] don't allow labels on staged records In-Reply-To: <bug-14369-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14369-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14369-70-uNeCrkeSmq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14369 --- Comment #4 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Nicole C. Engard from comment #0) > If you click the create label batch from manage-marc-import.pl on a file > that's staged and not imported you get an error asking you to talk to the > sys admin. The problem is simple - it's a staged file - not imported. I > think that the option to create a label batch shouldn't show in this case. Nicole, why the label batch shouldn't show in that case? Also, which type of file we should stage with the stage-marc-import.pl page? If any type of MARC file then we need to fix this bug certainly but if there is one and the right file type which doesn't cause this bug then we should maybe restrict stage-marc-import.pl to only accept MARC files with that encoding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:37:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:37:09 +0000 Subject: [Koha-bugs] [Bug 14699] New: Intranet search history issues due to DataTables pagination Message-ID: <bug-14699-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 Bug ID: 14699 Summary: Intranet search history issues due to DataTables pagination Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org DataTables removes hidden rows from the DOM. Because of that, "Select all", "Clear all" and the form submission don't work correctly (basically they act only on the currently displayed page). As OPAC search history doesn't use DataTables, this bug only affects intranet. To reproduce: 1/ Go to your search history page 2/ Make you sure you have at least 21 entries in your search history. If not, do some searches and come back here. 3/ Click "Select all" and change page. The checkboxes on the new page are not checked. 4/ Check some checkboxes on this new page and click "Clear all". Go back to the previous page, checkboxes are still checked. 5/ Check some checkboxes on at least 2 different pages and click "Delete". Only search history entries selected on the current page were deleted. This bug affects both biblio and authority search history. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:23 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-EKa0BmjaYM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41584|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41716&action=edit Bug 14544: Add Koha::Virtualshelf and Koha::Virtualshelves The 2 modules C4::VirtualShelves and C4::VirtualShelves::Page are really badly coded and buggy. It became complicated to fix and enhance them. This rewrite will make the code more robust and the list feature will be easier to change. Some new modules are added to the Koha namespace (Koha::Virtualshelf, Koha::Virtualshelves, Koha::Virtualshelfshare[s] and Koha::Virtualshelfcontent[s]) to take advantage of Dbix::Class. The patchset fixes some bugs: 1/ Bug 6279 - Can't delete lists from the second page of lists in the OPAC 2/ The owner of a list should not need any permission to remove content from his lists. 3/ No feedback messages when actions are done Test plan: A) Intranet and OPAC 1/ Create more than 20 private and public lists with different users 2/ Edit some and confirm that the changes are taken into account 3/ Share some lists with other users 4/ Add / remove contents Be sure you have some lists with more than 20 items (to test the pagination) 5/ Play with permissions and confirm it works as expected. For private lists: They should not be viewed by anyone else, if they are not shared If they are shared (OPAC only): a. "Allow anyone else to add entries" Should allow the user with whom the list is shared to add entries. b. "Allow anyone to remove his own contributed entries." Should allow the user with whom the list is shared to remove his own entries. c. "Allow anyone to remove other contributed entries." Should allow the user with whom the list is shared to remove any entries. For public lists: They should be viewed by anyone else. a. "Allow anyone else to add entries" Should allow any user to add entries. b. "Allow anyone to remove his own contributed entries." Should allow any user to remove his own entries. c. "Allow anyone to remove other contributed entries." Should allow any user to remove any entries. 6/ Download and sent lists. 7/ Confirm that the "Add to" feature works as expected. 8/ Confirm that the "Add an item to" works as expected. 9/ Delete some lists. 10/ Print some lists and subscribe to the RSS feed (OPAC only) (with more than 20 items). 11/ Use the remove "Remove share" links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:27 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-P2L9ErlqNv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41585|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41717&action=edit Bug 14544: Get rid of GetShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:30 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-2r4ZDKOZ7Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41586|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41718&action=edit Bug 14544: Get rid of AddShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:33 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-2aG1AJaQyy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41587|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41719&action=edit Bug 14544: Get rid of DelShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:36 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-lL7KyJFNb6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41588|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41720&action=edit Bug 14544: Get rid of ModShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:39 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-ehJyuVQLwq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41589|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41721&action=edit Bug 14544: Move share routines to Koha::Virtualshelfshare and Koha::Virtualshelfshares -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:43 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-UkG8HgKiQz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41590|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41722&action=edit Bug 14544: Get rid of GetAllShelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:47 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-5djIXtj6WR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41591|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41723&action=edit Bug 14544: Koha::Virtualshelfcontent[s] Get rid of AddToShelf and DelFromShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:51 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-Nxuz6Ir6Pr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41592|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41724&action=edit Bug 14544: Make the intranet side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:54 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-aFAej7tqBY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41593|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41725&action=edit Bug 14544: Get rid of GetBibliosShelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:39:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:39:57 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-s6HaaKgdMG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41594|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41726&action=edit Bug 14544: Get rid of GetShelves This does not work for now, see later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:40:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:40:01 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-DFy8La28Eu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41595|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41727&action=edit Bug 14544: Make the OPAC side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:40:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:40:04 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-sI7QSrjgH8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41596|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41728&action=edit Bug 14544: Get rid of ShelfPossibleAction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:40:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:40:07 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-x3uHgztD57@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41597|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41729&action=edit Bug 14544: Get rid of GetShelfContent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:40:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:40:11 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-4LyqqPp53V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41598|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41730&action=edit Bug 14544: Get rid of GetSomeShelfNames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:40:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:40:14 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-KP4Hk91MKK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41599|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41731&action=edit Bug 14544: Move HandleDelBorrower to C4::Members -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:40:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:40:17 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-3yeB7v9cUB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41600|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41732&action=edit Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:40:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:40:20 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-QzyyP1el5d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41601|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41733&action=edit Bug 14544: Remove wrong tips about permissions The owner of a list should not need any permission to remove contents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:42:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:42:29 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-mwVr4MMEdo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Last patchset fixes conflicts with bug 14517 and bug 14529. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:43:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:43:09 +0000 Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination In-Reply-To: <bug-14699-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14699-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14699-70-6meaewySVd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41734&action=edit Bug 14699: Fix intranet search history issues due to pagination DataTables removes hidden rows from the DOM. Because of that, "Select all", "Clear all" and the form submission don't work correctly (basically they act only on the currently displayed page). This patch fixes just that. Test plan: 1/ Go to your search history page 2/ Make you sure you have at least 21 entries in your search history. If not, do some searches and come back here. 3/ Click "Select all" and change page. The checkboxes on the new page should be checked. 4/ Check some checkboxes on this new page and click "Clear all". Go back to the previous page, checkboxes shouldn't be checked. 5/ Check some checkboxes on at least 2 different pages and click "Delete". All selected search history entries should be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:43:17 +0000 Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination In-Reply-To: <bug-14699-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14699-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14699-70-k47A8rxdkh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:43:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:43:27 +0000 Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination In-Reply-To: <bug-14699-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14699-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14699-70-2Er4BhXlzQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:50:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:50:41 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-lNH0EProms@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41692|0 |1 is obsolete| | --- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41735&action=edit Bug 11759: Batch checkout - prepare the ground This patch does not introduce any changes. It prepares the circulation script to accept several barcodes in parameter. A loop is done on all barcodes (until now, only 1) to generate a structure to sent to the template. At the end, only the first generated data is sent. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:50:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:50:45 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: <bug-13663-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13663-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13663-70-bWC1lPnwCM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 --- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Fridolin SOMERS from comment #14) > I think Bug 6874 will impact this bug In the end no, the feature does not use upload-file.pl nor upload-file-progress.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:51:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:51:11 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-KUuQKXm3kF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:51:15 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-JSKvhpXvft@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41693|0 |1 is obsolete| | --- Comment #62 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41736&action=edit Bug 11759: Batch checkout - Add the new template This patch is the main patch. It adds: - the new template circ/circulation_batch_checkouts.tt - the change into circ/circulation.pl === Why this feature is useful for some libraries? === Currently Koha does not allow to checkout several items at once to a user. This can cause a waste of time when a user want to checkout more than 10 items. This development has been asked to have statistics on in-house use. Every night, a librarian will enter a barcode list (from a file or a scanner : the librarian scans the barcode of the documents that users let on the tables). Barcodes will be added to a statistics patron in order to count the number of items consulted. The development has been expanded to cover another need: some special libraries (BDP for "Bibliotheque departementale de pret": "Loan Regional Library"). These libraries loan items to smaller libraries (municipal). The number of items could be very important and the current way offered by Koha is not adequate. === Test plan === 0/ Apply all patches and execute the DB change entry. 1/ Verify you are abble to do some checkouts (with confirmations, errors). = Statistics way = 2/ Create a statistical patron (e.g. category code STATS). 3/ Update the batch_checkouts pref with the category code (STATS). 4/ Go on the member page and verify the new "Batch check out" tab appears (and only for this user). 5/ Check some items out on the new page using the textarea or a file. 6/ Verify the table contains the item's information and the "Information" column contains "Local use recorded". = Real checkouts = 7/ Create a non statistical patron and update the pref. 8/ Check some items out on the new page using the textarea or a file. 9/ Verify the information in the table is consistent. 10/ Verify item without confirmation needed or impossible alert is checked out. 11/ If the logged in user has the "force_checkout" permission, all checkouts with a "confirmation needed" message can be done. If the logged in user does not have it, there is no way to force the checkout. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:51:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:51:22 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-r2T4CrT6sh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41694|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41737&action=edit Bug 11759: Add links to the new page Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:51:27 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-GS3JFuuXbN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41695|0 |1 is obsolete| | --- Comment #64 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41738&action=edit Bug 11759: Add some css to highlight warnings and errors Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:51:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:51:32 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-gcfqnPnqLH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41696|0 |1 is obsolete| | --- Comment #65 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41739&action=edit Bug 11759: Batch checkout - DB changes Add the new pref batch_checkouts in DB. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:51:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:51:37 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-MSrP5Jm1VS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41697|0 |1 is obsolete| | --- Comment #66 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41740&action=edit Bug 11759: (follow-up) Some fixes This is a squash of the following patches: Bug 11759: (follow-up) Prevent access to the batch checkout if not allowed If a user pass '&batch=1' to the url, he was allowed to access to the batch checkout page even if the patron is not in an authorised category. This patch also fixes the link to "Batch check out" from the "Details" tab (cf changes in circ-menu.inc). Bug 11759: FIX Javascript error The following JS error occurred: ReferenceError: MSG_ADD_MESSAGE is not defined The circulation.js file is useless and should not be included. Bug 11759: FIX the alert message if an item is on hold. If an item is on hold, the hold is not cancelled. This patch corrects the message displayed in this case. Bug 11759: FIX issue list is empty The issue list is empty after checking an item out to a patron without existing checkout. To reproduce: - Search for a patron without checkout. - Check an item out using the "normal" checkout. - Verify the checkout list contain the checkout. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:51:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:51:43 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-4veIqpvqzU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41698|0 |1 is obsolete| | --- Comment #67 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41741&action=edit Bug 11759 [QA Followup] - Fix koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:53:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:53:20 +0000 Subject: [Koha-bugs] [Bug 14700] New: batch_id is not correctly populated on patron card creation Message-ID: <bug-14700-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14700 Bug ID: 14700 Summary: batch_id is not correctly populated on patron card creation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To replicate problem: 1) Navigate to cgi-bin/koha/patroncards/home.pl 2) Click 'New Batch' this will take you to cgi-bin/koha/patroncards/edit-batch.pl?op=new 3) Click 'Add Item(s)' -> opens pop up koha/patroncards/members-search.pl?batch_id=0 4) Search for a patron 5) Click 'add' on that borrower, edit-batch.pl updates to: cgi-bin/koha/patroncards/edit-batch.pl?op=add&batch_id=0&borrower_number=xxxxxx the header on the edit-items screen shows "Items in batch number " ... this should read "Items in batch number YYYY" -- the batch number is not populated. It is impossible to export the batch. Clicking back into manage batches *will* show a valid batch number and allow the batch to be exported, but we've broken the batch id on the batch creator page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 15:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 13:57:37 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-upXvkX6cR5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #68 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: I am passing qa on this patch set, but it is not completely without some doubts. I saw some minor details needing attention (spelling, warning, count) but the functionality point below could be a discussion on itself.. Functionality: We also have something similar in Offline circulation. You can checkin, checkout etc. with koc files. Spelling: Allow patron categories allowed Idem: Breadcrumbs: Checkouts a batch Warning: Note that adding batch=1 to the URL does not imply that there is a borrowernumber circulation.pl: Use of uninitialized value in regexp compilation at /home/koha/testclone/circ/circulation.pl line 120. @$barcodes = $query->param('barcodes'); /cgi-bin/koha/circ/circulation.pl?borrowernumber=4&barcodes=1&barcodes=2 This results in "1 checkouts" tab with 2 entries (!!) Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 16:35:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 14:35:28 +0000 Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer In-Reply-To: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14622-70-ckwM7UEwdA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 --- Comment #5 from Francois Charbonnier <francois.charbonnier at inlibro.com> --- Created attachment 41742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41742&action=edit BZ14622 - follow up - missing userpermissions added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 16:49:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 14:49:14 +0000 Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer In-Reply-To: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14622-70-tNSDXsZi2O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 --- Comment #6 from Francois Charbonnier <francois.charbonnier at inlibro.com> --- I sent a new patch to fix the missing userpermission About the 1-Obligatoire, I actually used some translation from fr-FR and updated others as well. Just so you know, not all files are translated in the fr-FR folder (for example,numberpattern.pl). Plus, I wanted the letters to be all formated the same way and there are "mandatory" authorised values that are not considered mandatory in the other folders. I wanted the fr-CA to be as close as the other folders (same stucure, same content, etc.) The only differences are in the marc21 framework default sql. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 16:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 14:59:50 +0000 Subject: [Koha-bugs] [Bug 14701] New: option to show item type icons on checkout Message-ID: <bug-14701-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14701 Bug ID: 14701 Summary: option to show item type icons on checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 41743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41743&action=edit checkouts Some libraries would like to see the item type icons on the check out screen. See attached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 17:17:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 15:17:21 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14510-70-eVSPHh57mk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 --- Comment #6 from Jesse Weaver <jweaver at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5) > Jesse, > This works quite well! > How did you choose the order of the fields on the column settings > configuration page? > What about the stocknumber and statisticvalue fields, for instance? The order and selection of the columns in question is based on which columns are mapped to subfields in the MARC21 framework. These are the only columns that can appear in the table. Are there any such fields that are mapped in UNIMARC but not MARC21? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 18:19:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 16:19:35 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-0i45URDyHW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- root at koha-deb:/usr/sbin# koha-plack --disable library Plack disabled for library root at koha-deb:/usr/sbin# koha-plack --enable library Plack already enabled for library hum? Not sure I have tested correctly, back on this one tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 18:46:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 16:46:31 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: <bug-14644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14644-70-r0ccevVJSj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 18:47:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 16:47:00 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-4b9rsxPAF5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Katrina and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 18:47:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 16:47:24 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14498-70-HjZ05iSE58@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 18:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 16:47:46 +0000 Subject: [Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made In-Reply-To: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14675-70-LJanVdGnZ1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 18:48:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 16:48:08 +0000 Subject: [Koha-bugs] [Bug 3333] item status for "not for loan" by item type / item is different In-Reply-To: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3333-70-cNNJZNOgxj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3333 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 18:48:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 16:48:30 +0000 Subject: [Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time In-Reply-To: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14646-70-G4fIFA1oBV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 18:48:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 16:48:54 +0000 Subject: [Koha-bugs] [Bug 14484] Warns when changing patron password In-Reply-To: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14484-70-c7NVpouTVL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14484 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 18:50:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 16:50:31 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: <bug-14181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14181-70-hZa5PUs9W4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 19:09:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 17:09:58 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-Z8f03YzacR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #34 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #33) > root at koha-deb:/usr/sbin# koha-plack --disable library > Plack disabled for library > root at koha-deb:/usr/sbin# koha-plack --enable library > Plack already enabled for library > > hum? > > Not sure I have tested correctly, back on this one tomorrow. Hi Jonathan! 1) It seems to me that the script is not catching the absense of the relevant line on your site's virtualhosts definition. This could be a bug in koha-functions.sh (is_plack_enabled). Probably not using the right koha-functions.sh (look at (4). 2) You should be looking at /var/log/koha/<instance>/plack-output.log to know if you are on plack. But you should notice, you know... it is slightly super faster. When you have plack enabled a line like this is uncommented in /etc/apache2/sites-enabled/<instance>.conf: OPAC: # Include /etc/koha/apache-shared-opac-plack.conf Intranet: # Include /etc/koha/apache-shared-intranet-plack.conf Those files need to be present in those dirs (look at (4) for details). 3) You need to know that koha-plack --enable <instance> is not starting the daemon for now, so you need to issue koha-plack --start <instance> to have it running. This is independent from the Apache conf hook, so Plack might be running but not being used. You can ps waux | grep starman (there should be a master process with two workers). 4) Where the files are put is really important because they are picked to generate a suitable apache configuration, otherwise it won't work.: debian/templates/apache-shared-*-plack.conf -> /etc/koha debian/templates/apache-site.conf.in -> /etc/koha debian/koha-common.bash-completion -> /etc/bash_completion.d/koha-common debian/scripts/koha-functions.sh -> /usr/share/koha/bin debian/scripts/koha-* -> /usr/sbin The template files need to be put in place BEFORE the instance is created. I think I'll build the packages for this so testing is pretty easier. Also note that you need to install - starman - libplack-middleware-reverseproxy-perl Thanks for your time testing this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 19:32:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 17:32:56 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-VKqCRmuhq9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #41 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 41744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41744&action=edit Bug 11190 sitemap.pl -- Generate a Catalog sitemap Add a script sitemap.pl to process all biblio records from a Koha instance and generate Sitemap files complying with this protocol as described on http://sitemaps.org. The goal of this script is to be able to provide to search engines direct access to biblio records. It avoid leaving search engine browsing Koha OPAC and so generating a lot of traffic, and workload, for a bad result. Thanks Magnus for testing, and helping to improve the script design. [2015.04.16] Switch from Moose to Moo. [2015.08.20] Add complere (more) UT. Signed-off-by: Magnus Enger <magnus at enger.priv.no> All options to the script work as expected and the output looks good. Nice enhancement! Signed-off-by: Frederic Demians <f.demians at tamil.fr> I signed-of my own patch after fixing various QA errors. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 19:34:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 17:34:25 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-PyZij7mImw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 19:34:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 17:34:28 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-IE506W6acO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #42 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 41745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41745&action=edit Bug 11190 sitemap.pl -- Generate a Catalog sitemap Add a script sitemap.pl to process all biblio records from a Koha instance and generate Sitemap files complying with this protocol as described on http://sitemaps.org. The goal of this script is to be able to provide to search engines direct access to biblio records. It avoid leaving search engine browsing Koha OPAC and so generating a lot of traffic, and workload, for a bad result. Thanks Magnus for testing, and helping to improve the script design. [2015.04.16] Switch from Moose to Moo. [2015.08.20] Add complete (more) UT. Signed-off-by: Magnus Enger <magnus at enger.priv.no> All options to the script work as expected and the output looks good. Nice enhancement! Signed-off-by: Frederic Demians <f.demians at tamil.fr> I signed-of my own patch after fixing various QA errors. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 19:35:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 17:35:10 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-jdjONNHliT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39712|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 19:35:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 17:35:26 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-0NPcwgTxh4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 19:37:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 17:37:12 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-ByLkVIptCe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #43 from Fr?d?ric Demians <frederic at tamil.fr> --- I have set back this patch status to 'Signed off'. The UT should suit QA needs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 21:11:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 19:11:41 +0000 Subject: [Koha-bugs] [Bug 14665] Items Permanent Location not set when item is ordered In-Reply-To: <bug-14665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14665-70-Dpt7TToymt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14665 Tom Misilo <misilot at fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 21:12:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 19:12:10 +0000 Subject: [Koha-bugs] [Bug 13026] permanent location becomes CART. In-Reply-To: <bug-13026-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13026-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13026-70-fKihAqlqMN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13026 Tom Misilo <misilot at fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 21:12:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 19:12:20 +0000 Subject: [Koha-bugs] [Bug 7634] Permanent Location (shelving location) is NULL when Import MARC records tool is used In-Reply-To: <bug-7634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7634-70-CcEIRx8YMw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634 Tom Misilo <misilot at fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 23:14:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 21:14:49 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-898SAaAPKq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 --- Comment #2 from Liz Rea <liz at catalyst.net.nz> --- I was looking at something similar for bug 14691 and David pointed out http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 which may fix this sort of problem across the board. I just haven't had a chance to investigate whether or not that is true. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 23:38:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 21:38:29 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-wnovMv7dXJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #39 from Liz Rea <liz at catalyst.net.nz> --- This patch seems to break sysprefs such as intranetnav and opacmainuserblock - they show their HTML instead of interpreting it. I haven't checked all of the user configurable areas with this patch but we definitely should check them all. Off the top of my head (ok, ok, I went and looked through, but I still might have missed some): opacmainuserblock opacnav opacnavright opaccredits opacheader opacuserjs opacusercss opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs intranetusercss intranetuserjs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 23:43:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 21:43:15 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-vFNzIotHSx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #40 from Liz Rea <liz at catalyst.net.nz> --- Ok, sorry I didn't have the last couple of patches - that's my bad but we still should check all of those sysprefs as part of testing. :) --- Comment #41 from Liz Rea <liz at catalyst.net.nz> --- Ok, sorry I didn't have the last couple of patches - that's my bad but we still should check all of those sysprefs as part of testing. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 23:50:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 21:50:51 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-ep5SF4BdXY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #42 from Liz Rea <liz at catalyst.net.nz> --- Actually, I'm sure I have all of the patches now, and intranetNav, at least, still has a problem. Also the news items are displaying their HTML, and they shouldn't be. LR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 20 23:52:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 21:52:19 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-x64gxNTqyt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #43 from Heather Braum <hbraum at nekls.org> --- If it's any sys pref that deals with HTML/JS/CSS, here's a few more to check; what about all the notices/slips templates? Do those need to be checked, too, since they also use HTML/JS/CSS? Extra user-edited sys prefs: OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 00:02:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 22:02:44 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-ukPtzu8miq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #6 from Liz Rea <liz at catalyst.net.nz> --- Right, ok. So, bug 13618 is nowhere near ready - I think if it isn't ready by shortly before string freeze we should go with this one in the meantime (and same for bug 14505) because even though we have a workaround (delete the '), it still shouldn't break like this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 00:55:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 22:55:09 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-agFQQ7sxOa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #44 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 41746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41746&action=edit Bug 13618 - memberentrygen.tt errors Not a GLOB reference Like Jonathan said: The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. Replaced it with a SWITCH, like the other patch for this similar error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 01:04:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 23:04:43 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-aqPucwWakr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #45 from Liz Rea <liz at catalyst.net.nz> --- On memberentrygen.tt, all of the cases for *popup are broken, they show the html we're sending in that variable instead of the dropdown. Most of them are conditional, the main reason I noticed was because of the Patron title: field. Suspect there will be heaps of stuff like this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 01:05:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 23:05:29 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-vlgBsjdWcA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 01:09:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 23:09:25 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-kv9WO8NkFI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #46 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 41747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41747&action=edit Bug 13618 - memberentrygen.tt errors Not a GLOB reference Like Jonathan said: The interpolation of a variable on including a file caused an unexpected error: Template process failed: undef error - Not a GLOB reference at /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. Replaced it with a SWITCH, like the other patch for this similar error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 01:42:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 23:42:38 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-jJETZAEYsm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #7 from David Cook <dcook at prosentient.com.au> --- (In reply to Liz Rea from comment #6) > Right, ok. So, bug 13618 is nowhere near ready - I think if it isn't ready > by shortly before string freeze we should go with this one in the meantime > (and same for bug 14505) because even though we have a workaround (delete > the '), it still shouldn't break like this. When I originally mentioned bug 13618, I didn't realize that it wasn't ready yet, so I think you're totally right about moving ahead with something else in the meantime. Another idea would be to upgrade Template Toolkit from version 2.24 to 2.26 and use the "uri" or "url" filter: "As of version 2.26 of the Template Toolkit, the uri and url filters use the unsafe character set defined by RFC3986. This means that certain characters ("(", ")", "~", "*", "!" and the single quote "'") are now deemed unsafe and will be escaped as hex character sequences. The double quote character ('"') is now deemed safe and will not be escaped."* (http://template-toolkit.org/docs/manual/Filters.html#section_uri) But it seems like Debian is still using 2.24 and only moved to 2.24 in the Squeeze-Wheezy move... (https://packages.debian.org/search?keywords=libtemplate-perl) *I suppose double quote characters could cause problems if the Javascript was using double quotes instead of single quotes... another idea is to roll our own TT::Filter... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 01:45:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Aug 2015 23:45:14 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-kQTI5TChNJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #8 from Liz Rea <liz at catalyst.net.nz> --- Yeah I was looking at that - I wasn't sure (didn't test, actually) whether |html or |uri or |url would work here - the manual for TT doesn't indicate that ' is an escaped character in uri/url, and it will convert it to an entity in html which I didn't test, but certainly could. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 02:13:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 00:13:27 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-RHdtm6XL4c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #9 from Liz Rea <liz at catalyst.net.nz> --- Yeah ok, I've tested those filters and none of them actually work, where this one does. If someone has a better solution, I'm happy to know it because then I'll learn something. Otherwise... yeah lets test this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 04:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 02:25:14 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: <bug-14181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14181-70-JPohtitoba@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 --- Comment #9 from Winona Salesky <wsalesky at gmail.com> --- Great! Thanks. -Winona (In reply to Tom?s Cohen Arazi from comment #8) > Patch pushed to master. > > Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 09:18:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 07:18:55 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-dNWZaNEuHr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- If we use something like Template::Stash::AutoEscape then we can get this fixed quite soon but if we wait for the Template Toolkit version 2.26 in Debian then it might take a while. We will wait and see what happens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 09:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 07:39:42 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-93lR3Dt0qI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Testing this one now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:35:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:35:56 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-SQhkZsH8hD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Thanks a lot for this additional information, it's very useful. I had to restart apache2 to take into account the change (I suppose it's intended). But... I got an error on the mainpage: ==> /var/log/koha/library-plack/plack-error.log <== Could not compile /usr/share/koha/intranet/cgi-bin/mainpage.pl: Attempt to reload C4/Auth.pm aborted. Compilation failed in require at /usr/share/koha/intranet/cgi-bin/mainpage.pl line 25. BEGIN failed--compilation aborted at /usr/share/koha/intranet/cgi-bin/mainpage.pl line 25. I successfully access to / but got this error on /cgi-bin/koha/mainpage.pl Not caused by this patch. Marked as Passed QA, great job Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:36:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:36:31 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-yMVw3k8RLo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:36:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:36:34 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-YhSmmkNIAd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41571|0 |1 is obsolete| | Attachment #41572|0 |1 is obsolete| | Attachment #41573|0 |1 is obsolete| | Attachment #41574|0 |1 is obsolete| | Attachment #41575|0 |1 is obsolete| | Attachment #41576|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41748&action=edit Bug 13791: Plack out-of-the-box support on packages This patch introduces a koha-plack script that controls running Plack processes for each instance. They are run using 'starman', listening on a Unix Domain Socket (UDS): /var/run/koha/<instancename>/plack.sock The plack configuration file[1] is expected to be on: /etc/koha/plack.psgi and is installed by the package. It also adds the following helper functions to koha-functions.sh: - is_plack_enabled - is_plack_running Done: - koha-plack script - suitable psgi file To test this patches you will need to install - starman - libplack-middleware-reverseproxy-perl [1] Yeah, a single file. Because we will be relying on multiple mount points for each "app" (i.e. 'opac' and 'intranet', and 'api' ;-) ) Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:36:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:36:38 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-DKYjx4SAwz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #37 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41749&action=edit Bug 13791: Apache configuration files This patch adds an include to each VirtualHost definition (OPAC and Intranet) and a variable definition, taking advantage of Apache 2.4.x features. The instance name is reused inside the includes providing a simple way of dealing with the apache <-> plack configuration. A check for the right apache version is introduced, in the for of an IfVersion block: <IfVersion >= 2.4> --- Plack configuration here --- </IfVersion> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:36:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:36:41 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-gV5Gu6FIju@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41750&action=edit Bug 13791: koha-plack documentation Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:36:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:36:45 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-blaJ60cBKx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41751&action=edit Bug 13791: make koha-list aware of plack This patch adds the --plack and --noplack option switches to koha-list for filtering instances to be listed. This is particularly important for init scripts and cronjobs. To test: - Play with koha-list --plack and koha-plack --enable/--disable and verify that koha-list returns the expected results. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:36:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:36:49 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-p1rDiF0gMm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41752&action=edit Bug 13791: make koha-common init script aware of plack This patch makes the packages' koha-common script aware of plack. It does so by relying on koha-list --plack to know which instances have Plack configured, and uses the koha-plack script to manage the running daemons. It also introduces a plack_status function to check the status of the Plack daemon when called: $ servive koha-common status Regards Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:36:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:36:52 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-SQvu3vIOxI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41753&action=edit Bug 13791: tab-completion for koha-plack in bash This patch adds tab-completion in bash for the koha-plack command. After the --start, --stop, --restart and --disable switches it only offers plack-enabled instances. And disabled instances to --enable. --help and -h just finish end the completion. --quiet and -q are trickier to implement. They will work (be offered) only before the action switches. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:38:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:38:19 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-AayzLjVtOZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I would be really useful to have the ability to enable plack for the OPAC or staff side only (since the staff is not stable yet...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:40:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:40:10 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-db0wBycEJj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #35) > Thanks a lot for this additional information, it's very useful. > > I had to restart apache2 to take into account the change (I suppose it's > intended). > But... I got an error on the mainpage: > > ==> /var/log/koha/library-plack/plack-error.log <== > Could not compile /usr/share/koha/intranet/cgi-bin/mainpage.pl: Attempt to > reload C4/Auth.pm aborted. > Compilation failed in require at > /usr/share/koha/intranet/cgi-bin/mainpage.pl line 25. > BEGIN failed--compilation aborted at > /usr/share/koha/intranet/cgi-bin/mainpage.pl line 25. > > I successfully access to / but got this error on /cgi-bin/koha/mainpage.pl > > Not caused by this patch. And actually all other pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:41:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:41:01 +0000 Subject: [Koha-bugs] [Bug 10910] You can delete a patron who has made suggestions without any warn In-Reply-To: <bug-10910-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10910-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10910-70-BXTkd01huR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- There comes the alert: "Are you sure you want to delete this patron? This cannot be undone." We could change it to something like: "Are you sure you want to delete this patron? All patron's details will be deleted including suggestions, blablabla. This cannot be undone." What would be a good alert text there? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:45:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:45:32 +0000 Subject: [Koha-bugs] [Bug 14702] New: Fix GetReserveFee Message-ID: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Bug ID: 14702 Summary: Fix GetReserveFee Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com While working on bug 9809, I discovered some wonderful errors in GetReserveFee and its various calls. Bug 9809 makes just a small change in this respect; this report should do the rest :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:45:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:45:52 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-SSe5H0djit@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:46:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:46:23 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-KmQ78yYxv0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- So, the install where I have tried this page is 3.2002000. I have tried with a git install, checkouted 3.20.02, and I don't get the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:50:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:50:29 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-yVFApfcoEu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #45 from Mike <black23 at gmail.com> --- (In reply to Jonathan Druart from comment #43) Helo, I want to confirm same problem in staff side. Mike > Thanks a lot for this additional information, it's very useful. > > I had to restart apache2 to take into account the change (I suppose it's > intended). > But... I got an error on the mainpage: > > ==> /var/log/koha/library-plack/plack-error.log <== > Could not compile /usr/share/koha/intranet/cgi-bin/mainpage.pl: Attempt to > reload C4/Auth.pm aborted. > Compilation failed in require at > /usr/share/koha/intranet/cgi-bin/mainpage.pl line 25. > BEGIN failed--compilation aborted at > /usr/share/koha/intranet/cgi-bin/mainpage.pl line 25. > > I successfully access to / but got this error on /cgi-bin/koha/mainpage.pl > > Not caused by this patch. And actually all other pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:59:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:59:55 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-tVuXKQZqwd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40734|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41755&action=edit Bug 9809 - Update Schema files Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:59:50 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-W074EJl1pv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40733|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41754&action=edit Bug 9809 - DB Updates Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 10:59:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 08:59:58 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-8v4z6HKB9J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40735|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41756&action=edit Bug 9809 - Remove DBIC module for reserveconstraints Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:00:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:00:02 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-fK2yIjylfq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40736|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41757&action=edit Bug 9809 - Update unit tests Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:00:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:00:07 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-fpBLhEE5Bl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40737|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41758&action=edit Bug 9809 - Remove reserveconstraints references from C4::Reserves Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:00:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:00:11 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-ovMqi3dJRw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40738|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41759&action=edit Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:00:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:00:15 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-uYxc2wDZ3p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41760&action=edit Bug 9809: [QA Follow-up] Remove warnings from Hold.pm Resolves two warnings on a uninitialized found column: holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 Test plan: Run t/db_dependent/Hold.t. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:00:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:00:19 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-505qAWK2CF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41761&action=edit Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:00:45 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-D1HuNLtWib@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:01:43 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-rTRQ5lmdjX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looks good to me! Thanks, Kyle. I added two small follow-ups and a see-also to a new report for GetReserveFee. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:02:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:02:01 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-AL85t8S22k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #62 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- There is a little error in opac/opac-addbybiblionumber.pl : Line 120 : $shelf-> This brakes the addition of records in a list. Other point : I see in opac/opac-addbybiblionumber.pl : } else { # TODO } Why not using $errcode ? like in virtualshelves/addbybiblionumber.pl ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:06:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:06:45 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-fJv6JtZnn5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35872|0 |1 is obsolete| | Attachment #35873|0 |1 is obsolete| | Attachment #35874|0 |1 is obsolete| | Attachment #35875|0 |1 is obsolete| | --- Comment #43 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41762&action=edit Bug 7957: Routing lists enhancements Rebased on master Squashed the first four patches + moved the updatedatabase part to atomicupdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:07:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:07:09 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-2K3LXH9Nif@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #45 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41764&action=edit Bug 7957: Redirect after creating a new routing list This avoids creating the same list multiple times when reloading the page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:07:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:07:00 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-bsPCKUuNQr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38425|0 |1 is obsolete| | --- Comment #44 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41763&action=edit Bug 7957: Add unit tests for new subroutines Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:07:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:07:34 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-KCL47VNT55@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:09:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:09:55 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-dzeQ3v9Olk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14702 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:09:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:09:55 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-Nt5BAHVRLk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9809 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:12:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:12:29 +0000 Subject: [Koha-bugs] [Bug 8080] login and password no longer pre-filled by the browser when creating a new patron In-Reply-To: <bug-8080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8080-70-09EjuAswDJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8080 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14599 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:12:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:12:29 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: <bug-14599-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14599-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14599-70-8VxhbyYEnF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8080 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:12:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:12:34 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-Ih2JxAjoSc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14702 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 [Bug 14702] Fix GetReserveFee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:12:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:12:34 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-7p1KFry083@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9809 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 [Bug 9809] Get rid of reserveconstraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:14:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:14:29 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14133-70-JSt34n6YUM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 --- Comment #2 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- That print messages use print template, even when print is a fallback -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:46:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:46:31 +0000 Subject: [Koha-bugs] [Bug 14599] Saved auth login and password are used in patron creation from In-Reply-To: <bug-14599-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14599-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14599-70-OVGdaIA3eV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14599 --- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- When using private navigation in Firefox : In loggin form the loggin is not filled-in automatically and the password is filled-in automatically after choosing a loggin. Then in add patron form, the problem does not occurs. Also, in normal navigation, it is the same behavior if I have more than one loggin registred. The problem seems to be a Firefox behaviour, independently from "autocomplete=off". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:47:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:47:33 +0000 Subject: [Koha-bugs] [Bug 14703] New: Holidays description shows \r\n for every new line Message-ID: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 Bug ID: 14703 Summary: Holidays description shows \r\n for every new line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org First go to /cgi-bin/koha/tools/holidays.pl. If one adds there a new line to a holiday's description, in the left side of the page, under Description column, the new line is written in the form of \r\n. I think this should be fixed to show a new line and not a newline character. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 11:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 09:54:49 +0000 Subject: [Koha-bugs] [Bug 13097] Use of ampersands ( & ) in holiday titles or descriptions breaks the calendar In-Reply-To: <bug-13097-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13097-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13097-70-Bxm2Pg2Wrg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13097 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #5 from Joonas Kylm?l? <j.kylmala at gmail.com> --- On current master I wasn't able to reproduce this bug anymore. I tried ampersands in the title/description with: - every Holiday only on this day. - Holiday repeated every same day of the week. - Holiday repeated yearly on the same date Can we close this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:06:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:06:16 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14133-70-bTCONZNRCh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:06:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:06:19 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14133-70-LTa3VJ2f9w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41765&action=edit Bug 14133: Print notices should be generated with the print template If the overdue notice to send is an email or a SMS and the patron does not provided such information, a print notice is generated. But it will be generated with the email or sms template, which is not useful, especially in the SMS case. The template to use should be the print one. Test plan: 0/ Does not apply this patch and Correctly define the overdue rules to generate an overdue notice to the message_queue table. Check email + SMS 1/ Define an email address and a SMS number for a patron 2/ Generate the overdue notices (misc/cronjobs/overdue_notices.pl [-t]) 3/ 2 notices should have been generated: mtt=email with the email template used mtt=sms with the sms template used 4/ Truncate the message_queue table 5/ Remove the email address and repeat 2 6/ Only 1 notice should have been generated: mtt=print with the email template used 7/ Truncate the message_queue table 8/ Remove the sms alert number and repeat 2 9/ 2 notices should have been generated: mtt=print with the email template used (or sms I suppose) 10/ Apply this patch and repeat previous steps. The print notices should be generated with the print template. IMPORTANT NOTE: This test plan does not take into account the notices generated for the staff ("These messages were not sent directly to the patrons."). However the behavior will also change, the print template will be used in all cases. Is it what we want? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:06:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:06:48 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14133-70-uVshjnxGKK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |katrin.fischer at bsz-bw.de, | |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:14:06 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-eRk4iEGPbK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #21) > [2] Check the warn for placing a hold on such a book in OPAC. Actually, this should read: a hold for such a patron ! Maybe we should also think of moving this fee to item types? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:14:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:14:58 +0000 Subject: [Koha-bugs] [Bug 13097] Use of ampersands ( & ) in holiday titles or descriptions breaks the calendar In-Reply-To: <bug-13097-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13097-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13097-70-rXMpAulIhg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13097 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |kyle.m.hall at gmail.com --- Comment #6 from Kyle M Hall <kyle.m.hall at gmail.com> --- Agreed. I have been unable to reproduce on master as well. (In reply to Joonas Kylm?l? from comment #5) > On current master I wasn't able to reproduce this bug anymore. I tried > ampersands in the title/description with: > - every Holiday only on this day. > - Holiday repeated every same day of the week. > - Holiday repeated yearly on the same date > > Can we close this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:18:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:18:44 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-eFTbUJ2qvz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41766&action=edit Bug 14544: (follow-up) Get rid of ShelfPossibleAction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:20:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:20:55 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-PbnnatPl9T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #62) > There is a little error in opac/opac-addbybiblionumber.pl : > Line 120 : $shelf-> > This brakes the addition of records in a list. Oops, fixed! > Other point : > I see in opac/opac-addbybiblionumber.pl : > } else { > # TODO > } > Why not using $errcode ? like in virtualshelves/addbybiblionumber.pl ? Because it didn't before the changes, and I would like to submit another patchset to fix the 2 addbybiblionumber scripts. Not in the scope of this bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:22:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:22:32 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-vjuZfpd3ds@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41754|0 |1 is obsolete| | Attachment #41755|0 |1 is obsolete| | Attachment #41756|0 |1 is obsolete| | Attachment #41757|0 |1 is obsolete| | Attachment #41758|0 |1 is obsolete| | Attachment #41759|0 |1 is obsolete| | Attachment #41760|0 |1 is obsolete| | Attachment #41761|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41767&action=edit [SIGNED-OFF] Bug 9809 - DB Updates Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:22:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:22:39 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-XiaCMrr3Dv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41768&action=edit [SIGNED-OFF] Bug 9809 - Update Schema files Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:22:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:22:42 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-N2MDZ1X7ab@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41769&action=edit [SIGNED-OFF] Bug 9809 - Remove DBIC module for reserveconstraints Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:22:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:22:44 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-1wnds6Kmyn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41770&action=edit [SIGNED-OFF] Bug 9809 - Update unit tests Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:22:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:22:47 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-DZ92UB7ii3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41771&action=edit [SIGNED-OFF] Bug 9809 - Remove reserveconstraints references from C4::Reserves Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:22:49 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-dp0ffVvxZm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41772&action=edit [SIGNED-OFF] Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:22:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:22:52 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-lghxRg63Oz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41773&action=edit [SIGNED-OFF] Bug 9809: [QA Follow-up] Remove warnings from Hold.pm Resolves two warnings on a uninitialized found column: holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 Test plan: Run t/db_dependent/Hold.t. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:22:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:22:54 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-AnhjQvIoOz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41774&action=edit [SIGNED-OFF] Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:24:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:24:01 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-96YRq6uSGX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #32 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Marcel de Rooy from comment #22) > Looks good to me! Thanks, Kyle. > I added two small follow-ups and a see-also to a new report for > GetReserveFee. Thanks for the followups Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:31:59 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-FpZKit14V2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9809 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:31:59 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-THq8Yc6XVI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14526 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:34:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:34:04 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-IM5bcBm79j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Bug 14464 is passed QA and will be in conflict with this patch. Please provide a followup build on top of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:34:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:34:53 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-o9ss8KujDH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14526 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:34:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:34:53 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-aXPZLiR5jh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14337 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:35:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:35:29 +0000 Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks In-Reply-To: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14155-70-bkdFMBE4UR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14526 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:35:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:35:29 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-V4rloqnH9L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14155 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:36:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:36:16 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14097-70-IiRhyVxbcA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14526 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:36:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:36:16 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-mrIBWPA6mg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14097 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:36:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:36:59 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13930-70-JbZXejQrCR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14526 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:36:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:36:59 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-UntaPSMLig@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13930 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:37:27 +0000 Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves In-Reply-To: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13903-70-sqk5fW8648@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14526 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:37:27 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-9MvYKmd797@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13903 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:38:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:38:04 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-UmglkmYejd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14526 --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 14526 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:38:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:38:04 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-zDydzFE7o1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:39:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:39:45 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-1zF72ZWe02@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:21 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-Bmo24p63AF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14337 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:21 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-BZcZRqvLgU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526 |id=9809 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:21 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-mSsYfIFPl2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14337 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:34 +0000 Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks In-Reply-To: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14155-70-fPLKQNPIjn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526 |id=9809 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:34 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-dSF37rqeIQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14155 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:34 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-TgvZ0GFKkq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14155 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:40 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14097-70-ewdQoFEk3M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526 |id=9809 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:40 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-GjJQV9rjfo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14097 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:40 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-hob0ea3KGU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14097 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:48 +0000 Subject: [Koha-bugs] [Bug 13930] Add supporting service svc/ncip for xnciptoolkit driver In-Reply-To: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13930-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13930-70-QZJNP53lHo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526 |id=9809 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:48 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-nCdvrthXlX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13930 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:48 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-oXiEHvuEWe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13930 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:54 +0000 Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete reserves In-Reply-To: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13903-70-pUXl1fhpWz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526 |id=9809 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:54 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-mB1bLuq64s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13903 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:40:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:40:54 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-ZjI3nQfgwn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13903 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:41:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:41:02 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-slJ61VkiRh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14526 |id=9809 --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I meant bug 9809. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:41:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:41:02 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-ppxstC7k1p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:41:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:41:02 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-LdcKTy0V2N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12632 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:42:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:42:05 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7376-70-16jv0ZNPyr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9809 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 9809 (contrainst param removed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:42:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:42:05 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-eWJODhfe5s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7376 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:42:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:42:10 +0000 Subject: [Koha-bugs] [Bug 14704] New: members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM (' Message-ID: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14704 Bug ID: 14704 Summary: members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM (' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com At Ubuntu 14.04 using MariaDB, the following SQL doesn't work: SELECT COUNT(*) as count_precedent_state,issues,onloan,return FROM ( SELECT it.* FROM issues i, items it WHERE i.borrowernumber = 1234 AND i.itemnumber = it.itemnumber AND DATE(i.issuedate) < CAST(now() AS date) UNION SELECT it.* FROM old_issues oi, items it WHERE oi.borrowernumber = 1234 AND oi.itemnumber = it.itemnumber AND DATE(oi.issuedate) < CAST(now() AS date) AND DATE(oi.returndate) = CAST(now() AS date) ) tmp GROUP BY issues,onloan,return; We get "Syntax error near 'return FROM ('" This patch changes the SQL to prefix the selected columns with a table name prefix, so we get: SELECT COUNT(*) as count_precedent_state,tmp.issues,tmp.onloan,tmp.return FROM ( SELECT it.* FROM issues i, items it WHERE i.borrowernumber = 1234 AND i.itemnumber = it.itemnumber AND DATE(i.issuedate) < CAST(now() AS date) UNION SELECT it.* FROM old_issues oi, items it WHERE oi.borrowernumber = 1234 AND oi.itemnumber = it.itemnumber AND DATE(oi.issuedate) < CAST(now() AS date) AND DATE(oi.returndate) = CAST(now() AS date) ) tmp GROUP BY tmp.issues,tmp.onloan,tmp.return; Which is more formal and less implicit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:42:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:42:49 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: <bug-5144-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5144-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5144-70-K3QNDg6ltz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9809 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Be care, AddReserve prototype changed by bug 9809 (contrainst param removed). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:42:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:42:49 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-4gDXIpoQ0Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:44:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:44:46 +0000 Subject: [Koha-bugs] [Bug 14704] members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM (' In-Reply-To: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14704-70-WKwDFKO8Et@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14704 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41775&action=edit Bug 14704 - members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM (' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 12:51:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 10:51:08 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-ndXOTrE0JI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #33) > Bug 14464 is passed QA and will be in conflict with this patch. Please > provide a followup build on top of it. Well. maybe we should wait to see it get pushed first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:05:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:05:51 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-TeATEskzwY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41776&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:06:13 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-ozNCl4aKjP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Thanks for the pref list! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:10:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:10:11 +0000 Subject: [Koha-bugs] [Bug 14704] members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM (' In-Reply-To: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14704-70-naIbnnFvG5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14704 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I got the following if I execute directly the second query in my MariaDB CLI: ERROR 1054 (42S22): Unknown column 'tmp.return' in 'field list' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:15:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:15:58 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: <bug-13231-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13231-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13231-70-bWUSD5Fi22@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #9 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Katrin Fischer from comment #8) > Hm, 2 things here: I think the described case can only happen when not using > authorities as there seems no way to include ISBD punctuation at the end > when you do. No way to include ISBD punctuation when adding/changing authorities? What do you mean? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:22:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:22:27 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14510-70-nNLgVSNOgJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Joubu: pianohacker: for instance stocknumber is not mapped by default, but can be mapped pianohacker: hrm, decent point. pianohacker: Joubu: based on my patch, and your work with the datatables stuff, even if I throw in all those columns it will only show the ones that are actually visible in the "show/hide columns" menu, and in the correct order, right? Joubu: I think so, yes matts est d?sormais connu sous le nom de matts_away Joubu: that's the point, I think it's better to show all columns pianohacker: agreed nengard est d?sormais connu sous le nom de nengard_webinar Joubu: and display them either the order on admin/koha2marclinks.pl either the DB order edveal-afk est d?sormais connu sous le nom de edveal Joubu: DB order ie. kohastructure.sql pianohacker: yeah, to be consistent with something pianohacker: Joubu: all right, have that on my todo list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:24:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:24:36 +0000 Subject: [Koha-bugs] [Bug 14705] New: Allow .pl too in atomicupdate Message-ID: <bug-14705-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 Bug ID: 14705 Summary: Allow .pl too in atomicupdate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Bug 13893 added perl files with the extension .perl. In practice you always tend to add a .pl file. I suggest to add it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:26:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:26:11 +0000 Subject: [Koha-bugs] [Bug 14705] Allow .pl too in atomicupdate In-Reply-To: <bug-14705-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14705-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14705-70-lI0W8Tozuh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:26:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:26:14 +0000 Subject: [Koha-bugs] [Bug 14705] Allow .pl too in atomicupdate In-Reply-To: <bug-14705-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14705-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14705-70-KxUsqKEbmY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41777&action=edit Bug 14705: Allow .pl too in atomicupdate Bug 13893 added perl files with the extension .perl. In practice you always tend to add a .pl file. I suggest to add it. Test plan: [1] Add a .pl file in atomicupdate. [2] Try the update step in webinstaller. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:26:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:26:23 +0000 Subject: [Koha-bugs] [Bug 14705] Allow .pl too in atomicupdate In-Reply-To: <bug-14705-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14705-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14705-70-ZQkUFeSzOU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:31:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:31:14 +0000 Subject: [Koha-bugs] [Bug 14705] Allow .pl too in atomicupdate In-Reply-To: <bug-14705-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14705-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14705-70-rHvhHlzk3P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41777|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41778&action=edit Bug 14705: Allow .pl too in atomicupdate Bug 13893 added perl files with the extension .perl. In practice you always tend to add a .pl file. I suggest to add it. Test plan: [1] Add a .pl file in atomicupdate. [2] Try the update step in webinstaller. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:35:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:35:51 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-y3vEpZIeZQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41779&action=edit Bug 14702: Fix GetReserveFee The code in this sub of Reserves is unneeded and erroneous. The old code checked via biblioitems if there still was an item not issued and if so, it checked reserves: if there was no no hold yet for the biblio, the reserve fee went to zero. (Strange !) So only the second hold would trigger a charge. (But Koha does NOT allow that second hold at this time!) So it actually does nothing! This can/should be drastically simplified: We only call GetReserveFee from AddReserve. So there is an item free and it is possible to place a hold. Since it is currently not possible to place a second hold, and even if it was, we just charge our hold fee from patron categories! NOTE: It somehow seems a bit odd to have hold fee in the patron categories. Maybe it should be added to itemtypes (on another report)? This is a fix that changes behavior! A follow-up will print a warning for libraries upgrading. Test plan: [1] Add a hold for a patron without hold fee. Check the patron account if there is no charge for the new hold. [2] Add a hold for a ptron with hold fee. Check account again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:35:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:35:54 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-56bc516F5S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41780&action=edit Bug 14702: Unit test for GetReservesFee Test plan: Run the test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:35:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:35:58 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-oLvrabSgh3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41781&action=edit Bug 14702: Database revision for GetReserveFee change This patch adds a warning when upgrading. Test plan: [1] Have a patron category with a hold fee. [2] Run the webinstaller upgrade. Check for the warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:36:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:36:19 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-0bEchAfQpI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:38:41 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-OZhGaEVkcW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- hmm maybe it still needs some attention for the biblio level hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:38:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:38:57 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-KYQGVVG6J3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:39:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:39:49 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-fCyf47ttrb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- s/IFNULL/COALESCE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:43:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:43:08 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-DrFmwnp2rX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4) > hmm maybe it still needs some attention for the biblio level hold OK Instead of calling GetReserveFee when we are in AddReserve, we should only charge the hold fee when filling the reserve. So we should move the call to ModReserveFill ! I will make some changes next week.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 13:56:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 11:56:02 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12460-70-PWyek6ltYw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35699|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41782&action=edit Bug 12460: Allow to start a new search from multiple search history lines Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 14:03:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 12:03:30 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12460-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12460-70-q2MoDwqtwz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14699 Status|In Discussion |Needs Signoff --- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> --- Patch rebased on top of bug 14699 It also includes minor changes to address problem 2 of comment 9: - "Start a new search" link is displayed on its own line and doesn't require that the user selected some searches to be "clickable" - Add an alert() popup when user clicks on "Go" without having selected searches. So, the expected user behavior is now: 1/ Click on "Start a new search". (The 'Not' column appears) 2/ Select some searches (optionally toggle the NOT option for some of these) 3/ Click on Go Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 [Bug 14699] Intranet search history issues due to DataTables pagination -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 14:03:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 12:03:30 +0000 Subject: [Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination In-Reply-To: <bug-14699-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14699-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14699-70-YDCnPyHYnM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12460 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 [Bug 12460] Search history: Combine to start a new search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 14:09:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 12:09:51 +0000 Subject: [Koha-bugs] [Bug 13927] Add API route to check hold capabilities In-Reply-To: <bug-13927-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13927-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13927-70-jjwPx8pyd3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 14:10:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 12:10:15 +0000 Subject: [Koha-bugs] [Bug 14461] API authentication for SwaggerUI In-Reply-To: <bug-14461-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14461-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14461-70-LND2BPdl7Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14461 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 14:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 12:22:55 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-LV0qgrU0Ql@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- On updating the DB, I got several lines of this type: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`subscriptionrouting`, CONSTRAINT `subscriptionrouting_ibfk_2` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE) at /home/koha/src/installer/data/mysql/atomicupdate/bug_7957.perl line 62. DBD::mysql::st execute failed: Duplicate entry '2-7363' for key 'PRIMARY' at /home/koha/src/installer/data/mysql/atomicupdate/bug_7957.perl line 62. Any ideas of why? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 14:23:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 12:23:25 +0000 Subject: [Koha-bugs] [Bug 14706] New: Allow enabling/disabled Plack for OPAC and Intranet individually Message-ID: <bug-14706-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14706 Bug ID: 14706 Summary: Allow enabling/disabled Plack for OPAC and Intranet individually Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 14:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 12:25:14 +0000 Subject: [Koha-bugs] [Bug 14706] Allow enabling/disabled Plack for OPAC and Intranet individually In-Reply-To: <bug-14706-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14706-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14706-70-1eEt8zYjwZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14706 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13791 Change sponsored?|--- |Seeking cosponsors Assignee|gmcharlt at gmail.com |tomascohen at gmail.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 [Bug 13791] Plack - Out of the box support on packages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 14:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 12:25:14 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-rP3ejoU4qE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14706 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14706 [Bug 14706] Allow enabling/disabled Plack for OPAC and Intranet individually -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 14:30:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 12:30:33 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-2FogkxDkvW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #65 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #64) > (In reply to Fridolin SOMERS from comment #62) > > There is a little error in opac/opac-addbybiblionumber.pl : > > Line 120 : $shelf-> > > This brakes the addition of records in a list. > > Oops, fixed! > It works fine, i continue testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 14:47:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 12:47:58 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-860gARy9UN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #375 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41783&action=edit Bug 6874: (QA followup) fix templates Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:09:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:09:32 +0000 Subject: [Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp In-Reply-To: <bug-12388-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12388-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12388-70-lrjt8Y7Qdb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41784&action=edit Patch Here is a patch from Pasi which I just found for this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:10:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:10:54 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-UQZYSegMS1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- MariaDB [koha]> select * from subscriptionroutinglist; +-----------+----------------+---------+----------------+ | routingid | borrowernumber | ranking | subscriptionid | +-----------+----------------+---------+----------------+ [SKIP] | 195 | 7874 | 38 | 2 | | 196 | 7874 | 39 | 2 | [SKIP] I don't know if it's a DB data error or if it comes from the updatedb entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:16:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:16:28 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-PxFFFFyZZ7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:23:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:23:27 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: <bug-14464-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14464-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14464-70-GaHrpVgi3j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Jesse! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:23:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:23:55 +0000 Subject: [Koha-bugs] [Bug 14661] space needed in added to staff side cart message, if items added are already in cart In-Reply-To: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14661-70-WxLywa6cbg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14661 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:24:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:24:19 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13734-70-KEsusV8dvO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Good job Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:25:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:25:02 +0000 Subject: [Koha-bugs] [Bug 14652] Change gender option N/A to None specified In-Reply-To: <bug-14652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14652-70-loqTeaKPd0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Liz and Jonathan! I think we should go further and rename sex => gender all over the place at some point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:28:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:28:31 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-uU0DNzk7XS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:28:34 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-sBk0EZ6rt9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41715|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41785&action=edit [SIGNED-OFF] Bug 14693: Contract.t should generate dates based on current date The current test for still-active contracts fails because it was written with fixed dates, which already passed :-D This patch calculates the current date, and uses it to generate a future one, so the tests serve their purpose no matter what the current date is. To test: - Run: $ prove t/db_dependent/Contract.t => FAIL: activeonly compares contractenddate with now(), and fails because a fixed 2015-07-31 is writteng on the test data - Apply the patch - Run: $ prove t/db_dependent/Contract.t => SUCCESS: the sample data has been calculated using the current date and the tests pass. - Sign off :-D Edit: added missing use DateTime::Duration, Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:40:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:40:09 +0000 Subject: [Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties In-Reply-To: <bug-14031-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14031-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14031-70-ocuFQKSAHJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:40:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:40:30 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-fl9f92N3Lb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:43:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:43:06 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-AvW7yXvc3g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 15:43:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 13:43:09 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-nAWgfG7FCY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41785|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41786&action=edit Bug 14693: Contract.t should generate dates based on current date The current test for still-active contracts fails because it was written with fixed dates, which already passed :-D This patch calculates the current date, and uses it to generate a future one, so the tests serve their purpose no matter what the current date is. To test: - Run: $ prove t/db_dependent/Contract.t => FAIL: activeonly compares contractenddate with now(), and fails because a fixed 2015-07-31 is writteng on the test data - Apply the patch - Run: $ prove t/db_dependent/Contract.t => SUCCESS: the sample data has been calculated using the current date and the tests pass. - Sign off :-D Edit: added missing use DateTime::Duration, Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 16:28:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 14:28:39 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12224-70-rvtViVHEoG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #7 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Katrin Fischer from comment #6) > Would be great to see this moving. It's starting to move. Follow-up coming soon! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 16:28:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 14:28:54 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12224-70-VpWcQl0hxp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pasi.kallinen at pttk.fi |j.kylmala at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 16:38:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 14:38:33 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-u8EaedYKKA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41708|0 |1 is obsolete| | Attachment #41709|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41787&action=edit Bug 14337 - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 16:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 14:38:41 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-tqBkiWMsXV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41788&action=edit Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability AllowRenewalIfOtherItemsAvailable checks C4::Reserves::IsAvailableForItemLevelRequest to see if the item is holdable, which catches not for loan values less than 0 ( i.e. holdable, but not circ-able ). However, since this feature is about actually checking out items to patrons, we should not count *any* not for loan items when deciding if the available items will satisfy all current holds. Test Plan: 1) Enable AllowRenewalIfOtherItemsAvailable 2) Create a record with two items 3) Check out one item to a patron 4) Ensure the item is renewable 5) Place a hold on the record 6) The item should now be non-renewable 7) Add a second item to the record, but with a not for loan value < 0 8) Note the checkout is still renewable 9) Apply this patch 10) Note the checkout is now non-renewable Works ok. Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 16:39:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 14:39:13 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-o4dfncWN4L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #19 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #14) > Comment on attachment 41708 [details] [review] > Bug 14337 - Add Unit Tests > > Review of attachment 41708 [details] [review]: > ----------------------------------------------------------------- > > ::: t/db_dependent/Circulation.t > @@ +649,5 @@ > > + my $borrower2 = GetMember( borrowernumber => $borrowernumber2 ); > > + > > + my $issue = AddIssue( $borrower1, $barcode1 ); > > + > > + my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber2, $itemnumber1 ); > > Shouldn't be borrowernumber1? > Chelsea didn't check out itemnumber1. > > @@ +667,5 @@ > > + > > + ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber2, $itemnumber1 ); > > + is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled' ); > > + > > + diag("Setting item not checked out to be not for loan but holdable"); > > No need to overload the output, just a comment would be enough, don't you > think? You are correct. Unit test patch is updated based on your comments! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 16:41:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 14:41:50 +0000 Subject: [Koha-bugs] [Bug 14707] New: Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list Message-ID: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Bug ID: 14707 Summary: Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.fiol at biblibre.com Reporter: julian.fiol at biblibre.com QA Contact: testopia at bugs.koha-community.org This patch avoid issues with Hea. With Bug 14608 we add UsageStatsCountry and UsageStatsLibraryType in the stats for Hea (http://hea.koha-community.org/). But if this 2 syspref are free text, we could have some syntax issues. (ex : US / United States / USA will be count in 3 different country) This patch is supposed to normalize the country and type possibilities. The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 16:45:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 14:45:25 +0000 Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list In-Reply-To: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14707-70-eJGgQyR0DS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Julian FIOL <julian.fiol at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 16:46:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 14:46:42 +0000 Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list In-Reply-To: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14707-70-UD1I17Ns8r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 --- Comment #1 from Julian FIOL <julian.fiol at biblibre.com> --- Created attachment 41789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41789&action=edit Bug 14707 : Replace UsageStatsCountry and UsageStatsLibraryType syspref from free text to a dropdown list. This will avoid syntax problems with Hea when a user will fill this 2 sysprefs The default choice for UsageStatsLibraryType and UsageStatsCountry is 'empty' Test Plan --------- 1. Create a new Koha install 2. Go to the 'Administration' page 3. Go to 'Global system preferences' 4. Go to 'Administration' 5. At the end of this page you should see a dropdown menu for - UsageStatsCountry with all countries - UsageStatsLibraryType with all type of library They both should be empty by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 16:47:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 14:47:05 +0000 Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list In-Reply-To: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14707-70-aOdhlgWH46@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Is it a good idea to have a country dropdown? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 17:57:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 15:57:02 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-YPDsXuIvIO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 17:57:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 15:57:18 +0000 Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen In-Reply-To: <bug-14464-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14464-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14464-70-xGDRyjJsiv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 19:27:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 17:27:19 +0000 Subject: [Koha-bugs] [Bug 14708] New: The patron set as the anonymous patron should not be deletable. Message-ID: <bug-14708-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Bug ID: 14708 Summary: The patron set as the anonymous patron should not be deletable. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Right now it's possible to delete the anonymous patron at any time. When this happens the system will break just as if anonymouspatron was unset but patrons still have an "always anonymize" privacy setting. This issue occurs more frequently than one would expect. We should make it so that the patron set in AnonymousPatron is not deletable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 19:31:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 17:31:21 +0000 Subject: [Koha-bugs] [Bug 13723] OPAC cart not pulling date from RDA tag 264 only tag 260 In-Reply-To: <bug-13723-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13723-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13723-70-Q49g4SvijZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13723 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 19:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 17:31:28 +0000 Subject: [Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c In-Reply-To: <bug-12756-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12756-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12756-70-u7OziWIn7a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:02:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:02:48 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-682MisYwLn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 J Schmidt <jschmidt at switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:28:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:28:09 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14097-70-06IanrFSAc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|kyle at bywatersolutions.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:32:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:32:53 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-HVcC1thyRg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|kyle at bywatersolutions.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:39:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:39:13 +0000 Subject: [Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date In-Reply-To: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14693-70-EOUL2HoViO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Fix pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:39:39 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13387-70-tOCpwl5gnk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:46:50 +0000 Subject: [Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted record will fail In-Reply-To: <bug-14597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14597-70-fdASPUKlRw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #7 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #6) > Comment on attachment 41170 [details] [review] > [SIGNED-OFF] Bug 14597 - Reverting a batch where a record overlaid is now > deleted record will fail > > Review of attachment 41170 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/ImportBatch.pm > @@ +813,4 @@ > > sub BatchRevertRecords { > > my $batch_id = shift; > > > > + my $logger = Koha::Logger->get( { category => 'C4.ImportBatch.BatchRevertRecords' } ); > > Really? > We are going to create an instance of Log::Log4perl for each subroutine call? Yes, otherwise we cannot do the namespacing as far as I know. This is intrinsic with Log4Perl and not a limitation of Koha::Logger. Without namespacing we may was well stick to using warn() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:56:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:56:00 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-1rmso3MVKM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:56:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:56:04 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-VFfQ3r944c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39124|0 |1 is obsolete| | Attachment #39125|0 |1 is obsolete| | Attachment #39126|0 |1 is obsolete| | Attachment #39127|0 |1 is obsolete| | Attachment #39128|0 |1 is obsolete| | --- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41790&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:56:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:56:13 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-Q5apIFiTsZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41791&action=edit Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:56:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:56:16 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-37kCJRSGwo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #52 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41792&action=edit Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:56:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:56:19 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-u0yc5U8at0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #53 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41793&action=edit Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 20:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 18:56:22 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-dFgjM63agz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41794&action=edit Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 21:01:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 19:01:03 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11625-70-uQPRunv5jK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 21:01:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 19:01:05 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11625-70-H0C4IqUcnJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38276|0 |1 is obsolete| | Attachment #38277|0 |1 is obsolete| | Attachment #38278|0 |1 is obsolete| | Attachment #38424|0 |1 is obsolete| | --- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41795&action=edit [SIGNED-OFF] Bug 11625 - Add system preferences DefaultToLoggedInLibraryCircRules and DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 21:01:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 19:01:17 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11625-70-4amz1fQLcZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41796&action=edit [SIGNED-OFF] Bug 11625 - Implement DefaultToLoggedInLibraryCircRules This patch set makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes QA script and tests. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 21:01:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 19:01:20 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11625-70-VtMxgxtZmw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #52 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41797&action=edit [SIGNED-OFF] Bug 11625: Implement DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 21:01:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 19:01:28 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11625-70-VF8OIDxMRE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #53 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Marcel de Rooy from comment #49) > I put this patch in FQA now. I think first Kyle should comment on the > counter patch before anyone else does anything else :) Looks good to me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 21:04:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 19:04:05 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-dM8VXXfnWp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35256|0 |1 is obsolete| | Attachment #35257|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41798&action=edit Bug 12632 - Hold limits ignored for record level holds with item level itemtypes The crux of the issue is that if you are using item level itemtypes, but are allowing biblio levels holds, those holds do not have items. So, in CanItemBeReserved, when Koha counts the number of holds to compare against the given rule, it will always give 0 ( except of course for found holds, and the occasional item-level hold ). So the query is saying "link each of these reserves to the reserved item, and count the number of reserves this patron where the itemtype is DVD". However, since these are all record level reserves, there are no items to link to, and so when it looks for all reserves this and item whose itemtype is DVD, it finds zero reserves! This patch solves the problem by looking first at the item level itemtype, and if it does not exist, then it looks at the record level itemtype. For installations using record level itemtypes, the behavior remains unchanged. Test plan: 1) Enable item level itemtypes 2) Create two records with one item each of a given itemtype 3) Create a single issuing rule and limit the holds allowed for that itemtype to 1 4) Place a record level hold on your first record 5) Attempt to place a record level hold for the same patron on your second record. You should not be able to but you can! 6) Apply this patch 7) Repeat step 5, note you can no longer place the hold! Signed-off-by: Paola Rossi <paola.rossi at cineca.it> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 21:04:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 19:04:13 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-n9Y8taqHle@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41799&action=edit Bug 12632 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 21:12:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 19:12:49 +0000 Subject: [Koha-bugs] [Bug 14174] Home suspension and / or in situ In-Reply-To: <bug-14174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14174-70-C5qYRm14zQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14174 H?ctor <hectorejch at yahoo.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 21:51:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 19:51:48 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable. In-Reply-To: <bug-14708-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14708-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14708-70-MxHTeJtBUI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 22:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 20:08:06 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14510-70-TfCclZyGWH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 22:08:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 20:08:08 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14510-70-nt04kgVDie@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 --- Comment #8 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 41800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41800&action=edit Bug 14510: (QA followup) Add more columns, resort Per a conversation with Jonathan Druart, add all columns that could be reasonably mapped, and order them the same as in kohastructure.sql. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 21 22:08:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Aug 2015 20:08:30 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14510-70-jYZZjhd5fX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 22 09:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Aug 2015 07:27:58 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11998-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11998-70-8eAfzVY5VF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 22 09:29:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Aug 2015 07:29:02 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: <bug-12173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12173-70-4j4WxV21rd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 07:15:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 05:15:45 +0000 Subject: [Koha-bugs] [Bug 14592] Export data bad encoding In-Reply-To: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14592-70-EkSI6Tsefo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14592 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 08:03:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 06:03:06 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-0fFilyvMkR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> --- Template changes holding for 3.20.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 08:05:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 06:05:33 +0000 Subject: [Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface In-Reply-To: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14517-70-cfiNqVYcut@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> --- Even though this makes template changes, it stops the templates breaking completely so pushing Will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 08:12:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 06:12:00 +0000 Subject: [Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken In-Reply-To: <bug-14644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14644-70-dvppxl907R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 08:15:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 06:15:06 +0000 Subject: [Koha-bugs] [Bug 14660] Cataloguing plugins for generating inventory numbers are broken In-Reply-To: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14660-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14660-70-cQmcNoHGs5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14660 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 08:16:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 06:16:16 +0000 Subject: [Koha-bugs] [Bug 14498] uri_escape error triggered by duplicate accountno's for patron In-Reply-To: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14498-70-ASZHqjeOPW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14498 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 08:27:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 06:27:33 +0000 Subject: [Koha-bugs] [Bug 14521] SQL injection in local use system preferences In-Reply-To: <bug-14521-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14521-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14521-70-dYkci2tQNB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14521 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia at bugs.koha-communit | |y.org Product|Koha security |Koha Group|Koha security | Component|Koha |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 18:39:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 16:39:45 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14224-70-mznnfl3jzS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #1 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Created attachment 41801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41801&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summery" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Make sure the branch has an email address specified 4) Check out an item to a patron 5) Log in with the patron you checked out the item for 6) In "your summery", write a message in the new "Note" field for the item checked out. Hit ENTER to save/send. 7) Success message should be seen and an email sent to the email address specified for the branch which the item was checked out from. 8) Log in with staff account and check in the item 9) The note should be shown The note can be changed by the patron at any time while the item is checked out. Each change will send a new email to the branch. Only the latest note version will be shown on check in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 18:54:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 16:54:39 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14224-70-Tsd0UNwVTv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 21:38:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 19:38:40 +0000 Subject: [Koha-bugs] [Bug 10910] You can delete a patron who has made suggestions without any warn In-Reply-To: <bug-10910-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10910-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10910-70-ztQDZPmWhF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, I think maybe keep the suggestions, but just set the borrowernumber to 0 or 'anonymous' if that isn't the case yet? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 21:42:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 19:42:50 +0000 Subject: [Koha-bugs] [Bug 10190] notices based on item type In-Reply-To: <bug-10190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10190-70-yxSwb7LGjM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Right now we can only set the overdue notices by patron category, but we can't differentiate by item type. I think this is still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 22:05:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 20:05:52 +0000 Subject: [Koha-bugs] [Bug 13231] ISBD/AACR2 punctuation causes double facets In-Reply-To: <bug-13231-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13231-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13231-70-tmDggm8q2F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13231 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- In testing I found it impossible to add . or similar to a heading linked to an authority record - but I just added that note here for documentation. So it would be easier for others to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 22:38:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 20:38:04 +0000 Subject: [Koha-bugs] [Bug 12204] in RESERVESLIP, any 'reserve' field is not being expanded correctly. In-Reply-To: <bug-12204-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12204-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12204-70-ErmAr3tK0B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 22:46:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 20:46:31 +0000 Subject: [Koha-bugs] [Bug 14532] koha-dump shouldn't back backup Zebra indexes by default In-Reply-To: <bug-14532-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14532-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14532-70-uRmm68YkWn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14532 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:09:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:09:32 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-6YUjYrSUGW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 --- Comment #4 from Liz Rea <liz at catalyst.net.nz> --- It will fix it, but the patch for that isn't ready and may take a while - it would be good to get bugfixes like this at least back into stable versions. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:44:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:44:14 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-LGsT9B097B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:44:16 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-AmW7G7cmD6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:44:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:44:18 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14694-70-6QJ724xI8g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:44:20 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: <bug-11565-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11565-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11565-70-71bGKdb1hA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:44:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:44:22 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10067-70-rllrwPKzEl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:44:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:44:24 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14695-70-Y7JFzl7crK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:44:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:44:26 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: <bug-14629-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14629-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14629-70-D6DGO8QutM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:45:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:45:25 +0000 Subject: [Koha-bugs] [Bug 12375] Store serials enumeration data in separate fields In-Reply-To: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12375-70-PUbFEHuofj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:45:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:45:23 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-GsxiC6J0Gw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:45:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:45:27 +0000 Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers In-Reply-To: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9021-70-SoEC15jcFv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:45:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:45:29 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-baVKvCiG7z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:45:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:45:34 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-B1uBZKlErL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:45:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:45:37 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10612-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10612-70-ikxNS2tyth@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:45:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:45:44 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6427-70-GUvHTgjb54@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:45:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:45:49 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: <bug-11622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11622-70-Le9F5OEMWG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:45:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:45:50 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: <bug-11405-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11405-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11405-70-mwvnF7d70d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:47:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:47:12 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-fM0Ed7x52M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:47:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:47:14 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11625-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11625-70-Pe82RgjSM5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:47:16 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: <bug-11747-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11747-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11747-70-HTVnyX2Fv3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:47:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:47:18 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11431-70-qTWEvjIqVS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:47:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:47:21 +0000 Subject: [Koha-bugs] [Bug 12357] Enhancements to RIS and BibTeX exporting In-Reply-To: <bug-12357-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12357-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12357-70-oAvl63LkPW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12357 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:47:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:47:23 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-fjOcv9DATJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:47:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:47:26 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13517-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13517-70-D48JWIZE3R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:47:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:47:29 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-7dS8fEZOmy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:47:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:47:38 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12803-70-IS6yHUXLQ2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:48:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:48:40 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13733-70-aTkrQGxTme@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:48:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:48:42 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-vA0CWEAJJU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:48:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:48:50 +0000 Subject: [Koha-bugs] [Bug 13986] Printing a list only prints the results of the page you are viewing In-Reply-To: <bug-13986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13986-70-sqMhajCq9f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:49:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:49:01 +0000 Subject: [Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron In-Reply-To: <bug-13518-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13518-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13518-70-6NTBei6BDj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:49:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:49:04 +0000 Subject: [Koha-bugs] [Bug 14557] Add holds count to holds tab In-Reply-To: <bug-14557-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14557-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14557-70-BppEfuiI2N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14557 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:49:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:49:07 +0000 Subject: [Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server In-Reply-To: <bug-14512-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14512-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14512-70-4yMLol4JIz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:07 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: <bug-14659-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14659-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14659-70-OnfyQX3j8E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:09 +0000 Subject: [Koha-bugs] [Bug 13937] Add a 'primary status' field for items In-Reply-To: <bug-13937-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-JZORbtuE3z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:11 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14578-70-t9Yn9MgIbx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:13 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: <bug-14577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14577-70-B7tjJAixSW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:16 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: <bug-14576-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-QDSKY4wXPQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:16 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-fukbGf7Nrk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:18 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: <bug-14048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14048-70-w2FHft0xwe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:21 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-wDebvFoQtd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:24 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7882-70-S2Rbn1ZwOL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:26 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: <bug-13630-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13630-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13630-70-M9bmaXATWE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:30 +0000 Subject: [Koha-bugs] [Bug 14141] Changing the Library for a notice duplicates the notice instead of updating it In-Reply-To: <bug-14141-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14141-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14141-70-8t7d8a2y5k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:51:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:51:32 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: <bug-14607-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14607-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14607-70-1t5FjVqkBk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:52:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:52:08 +0000 Subject: [Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1" In-Reply-To: <bug-14277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14277-70-TjHrKm0XRQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:52:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:52:10 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: <bug-14292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14292-70-sa6sYSGgXZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:52:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:52:12 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14504-70-WgCAwyOOwv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 23 23:52:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 21:52:14 +0000 Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days In-Reply-To: <bug-14402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14402-70-XeUznHnQvq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 Nicole Engard (ByWater) <nicole at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 01:28:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 23:28:05 +0000 Subject: [Koha-bugs] [Bug 14378] koha-run-backups should check disk usage first In-Reply-To: <bug-14378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14378-70-Nqv1rCuQH3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14378 --- Comment #2 from Robin Sheat <robin at catalyst.net.nz> --- Keep in mind that filesystems have a capability to reserve a certain percentage for the root user, preventing things from going catastrophically bad when they fill up. While not exactly the same thing, that should give you some protection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 01:48:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 23:48:03 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-lDMFkEFB2M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #10 from David Cook <dcook at prosentient.com.au> --- (In reply to Liz Rea from comment #8) > Yeah I was looking at that - I wasn't sure (didn't test, actually) whether > |html or |uri or |url would work here - the manual for TT doesn't indicate > that ' is an escaped character in uri/url, and it will convert it to an > entity in html which I didn't test, but certainly could. (I know we talked about this already on IRC but I'll mention it here for everyone else) The TT manual mentions that it doesn't escape the single quote prior to version 2.26, but it will with version 2.26 and later (unless the line "Template::Filters->use_rfc2732;" is added). But the version in Debian Wheezy onwards is 2.24, so the url/uri filters won't work until Debian moves on to 2.26+, which I don't imagine will be for a while, since they just moved to 2.24 from 2.22 between Squeeze and Wheezy. -- Personally, I think I'm more in favour of adding our own Template Toolkit Filter Plugin based on the 2.26 uri filter. It would be more comprehensive than the replace vmethod and if one day we have TT 2.26 as the required version, we can always do a simple replacement in the code of "| escape_uri" with "| uri". -- http://template-toolkit.org/docs/modules/Template/Filters.html#section_FILTERS http://template-toolkit.org/docs/manual/Directives.html#section_FILTER http://www.template-toolkit.org/docs/modules/Template/Plugin/Filter.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 01:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 23:49:34 +0000 Subject: [Koha-bugs] [Bug 14378] koha-run-backups should check disk usage first In-Reply-To: <bug-14378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14378-70-JlFoVReNr0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14378 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I suggest taking a look at bug 14532, which makes backups skip Zebra index files by default and would prevent most of the problems. As for the enhancement request, I'd say you can now choose how many backups to keep (days) and that's pretty much all you need. As robin said, it is not obvious to know how big the backup would be, and it might not even be necessary with current options (and bug 14532 that needs some love from you). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 01:53:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Aug 2015 23:53:47 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-mwI5ZJWKT1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #11 from David Cook <dcook at prosentient.com.au> --- I'll take a look at doing an alternate patch in a sec... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 02:06:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 00:06:35 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-VN2OZEiHM4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #12 from David Cook <dcook at prosentient.com.au> --- Actually, at a glance, it seems like the default in 2.26 is still to use RFC2732 despite what the manual says... (see "our $UNSAFE_CHARS = $UNSAFE_SPEC->{ RFC2732 };" in http://cpansearch.perl.org/src/ABW/Template-Toolkit-2.26/lib/Template/Filters.pm) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 02:21:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 00:21:34 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-UWcc1YpotG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #13 from David Cook <dcook at prosentient.com.au> --- Yikes and maybe this is why: https://github.com/abw/Template2/issues/13 https://github.com/abw/Template2/issues/35 I was wondering why they were no longer escaping double quotes... I was going to do a custom version. That must be why 2.26 still uses the code for RFC2732... the manual must be out of date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 03:10:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 01:10:00 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-XQPhcBO8X5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #14 from David Cook <dcook at prosentient.com.au> --- Created attachment 41803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41803&action=edit Bug 14691 - [Alternate] Can't delete patron with ' character in cardnumber This patch adds a new Template Toolkit plugin. To use it, simple add [% USE EscapeURI %] at the top of the template, and then use "escape_uri" just as you would with the normal "uri" filter (e.g. "[% variable | escape_uri %]". It is based on the code from version 2.26 of Template::Filter::uri_filter(), but with a fix for the RFC3986 reserved character definition. In versions prior to 2.26, single quotes weren't escapes, which causes problems when trying to use the uri filter for text containing single quotes within a single quoted string, as observed in some Javascript for deleting patrons. Test plan: 1. Create patron account with cardnumber sss'ssssssss and save the account. 2. Try to delete the account. Nothing happens. 3. Apply the patch, refresh the page. 4. Try to delete the account; note the Delete pop-up message that now appears; note that the patron gets deleted if you click OK. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 03:10:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 01:10:50 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10988-70-DzfY5dEnOd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 03:21:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 01:21:30 +0000 Subject: [Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber In-Reply-To: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14691-70-LkFVppGW9f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #15 from David Cook <dcook at prosentient.com.au> --- Looks like the RFC3986 regression was fixed in master... https://github.com/abw/Template2/commit/af3444f719490d814c15c2fea3ff3c4e34d1f9a9 -- Another alternative option to my alternate patch is instead of using a Template::Plugin::Filter, we could add a "&escape_uri" function to the FILTERS configuration option in C4::Templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 03:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 01:30:35 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10988-70-tVv4XQ8I3t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #42 from Mason James <mtj at kohaaloha.com> --- FYI: CALYX came up with a technique to force a google-auth session logout when a user logs out of Koha. (note: this may be considered optional behaviour) Unfortunately, it is a solution that exists within a Google account, therefore is outside of Koha More info to come... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 07:05:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 05:05:04 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-tlcrd24VDc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #5 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Liz Rea from comment #4) > It will fix it, but the patch for that isn't ready and may take a while - it > would be good to get bugfixes like this at least back into stable versions. > > Liz I'll then change the status to "needs sign off". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 07:28:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 05:28:39 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-CNTDugwn7v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #2 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 41804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41804&action=edit Bug 14567: backend code for browse interface This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 07:28:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 05:28:42 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-BwHPDUTM5y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #3 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 41805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41805&action=edit Bug 14567: frontend template and JS for browse interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 07:28:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 05:28:45 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-XciVar5USC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #4 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 41806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41806&action=edit Bug 14567: recompile CSS with less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 07:33:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 05:33:25 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-btqpBKPPAU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #5 from Robin Sheat <robin at catalyst.net.nz> --- This is working. It's currently visible at http://elasticsearch.koha.catalystdemo.net.nz/cgi-bin/koha/opac-browse.pl though it may not stay there for too long. The patches attached are intended to be applied on top of the elasticsearch branch, they won't work without it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:41:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:41:54 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-U6HYKWE8iY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41010|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41807&action=edit Bug 14526: MoveReserve should look at future holds too At checkout a hold for the same borrower is considered to be filled. It is consistent to do the same for holds of the same borrower within [ConfirmFutureHolds] days (if non-zero). This goal is achieved by adjusting the CheckReserves call within MoveReserve, adding the lookahead parameter. I used this occasion to revisit other calls of CheckReserves: - transferbook: no need to add lookahead; a future hold should not block a transfer; - CanBookBeIssued: no lookahead; future hold does not block an issue; - CanBookBeRenewed: idem. - GetOtherReserves (only used in circ/returns): this call might be a candidate for lookahead too, but I leave that for another report. It is in the context of checkin and transfer, not checkout. Test plan: [1] Set ConfirmFutureHolds to zero days. (You may also need to enable AllowHoldDateInFuture.) [2] Place a hold with borrower A on biblio X for tomorrow. Also place a hold with borrower B on X for today. (Use biblio level holds.) [3] Check out item Y of X to borrower A. Ignore the warning for borrower B and do not cancel the hold of B (so: confirm checkout). Verify that X has still two holds. [4] Check in Y (without confirming a hold). [5] Enable ConfirmFutureHolds, say 2 days. [6] Check out Y to A again. Ignore the warning for B (no cancel). Verify that X now only has one hold for borrower B (the hold for A was filled). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:42:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:42:00 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-oESUJt4rrX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41241|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41808&action=edit Bug 14526: Add some unit tests for MoveReserve The change in MoveReserve from the previous patch begs for a test. Here we add some to Reserves.t. In all six tests we place a hold, move it and check the reserves again. Depending on the status of ConfirmFutureHolds, and the reservedate the hold should be moved or not. Test plan: Run the unit test. Bonus: If you run Reserves.t by applying this patch but without the first patch that changed MoveReserve, tests 60 and 61 should fail: not ok 60 - MoveReserve filled future hold now not ok 61 - MoveReserve filled future waiting hold now This may further illustrate the need of the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:43:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:43:50 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-HuL1pnsrZY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Rebased (unit test for bug 14464) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:57:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:57:53 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-XaWG9CHn2M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41809&action=edit Bug 9809 - DB Updates Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:57:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:57:57 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-dkltrpQvCz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41810&action=edit Bug 9809 - Update Schema files Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:58:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:58:01 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-O5ArcE2ter@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41811&action=edit Bug 9809 - Remove DBIC module for reserveconstraints Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:58:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:58:05 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-yf74McrUnD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41812&action=edit Bug 9809 - Update unit tests Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:58:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:58:09 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-W3UxdAciR1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41813&action=edit Bug 9809 - Remove reserveconstraints references from C4::Reserves Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:58:13 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-xHI6ZzJvxo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41814&action=edit Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:58:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:58:17 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-bFFRVwZ7Ur@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41815&action=edit Bug 9809: [QA Follow-up] Remove warnings from Hold.pm Resolves two warnings on a uninitialized found column: holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 Test plan: Run t/db_dependent/Hold.t. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:58:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:58:25 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-qlC6y1Pmmi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41817&action=edit Bug 9809: [QA Follow-up] Remove constrainttype from 14464 tests Some additional unit tests of bug 14464 still included a constraint in the AddReserve calls. Test plan: Run Reserves.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 08:58:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 06:58:21 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-qwPdCKz1yK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41816&action=edit Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:00:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:00:48 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-kUW1LDOzqu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Rebased (after 14464) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:01:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:01:51 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-NJFfeWSbuC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41767|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:01:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:01:53 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-tSAF7bh2Ij@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41768|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:01:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:01:55 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-cuvV7fZJBE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:01:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:01:58 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-mcj6iYOw4Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:02:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:02:00 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-XDDI1Sfs0t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41771|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:02:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:02:02 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-DYtTSKeWYY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41772|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:02:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:02:06 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-MiVl2I7z7w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:02:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:02:04 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-NjVZ4esFZz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41773|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:39:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:39:37 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-XpahUkqXuH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #48 from Julian Maurice <julian.maurice at biblibre.com> --- It seems you have a problem with your database. On master, subscriptionroutinglist has UNIQUE (`subscriptionid`, `borrowernumber`) so you shouldn't be able to have 2 rows with same borrowernumber and subscriptionid. Also, subscriptionroutinglist has a foreign key constraint on borrowernumber; the "Cannot add or update a child row" error should not happen I could "hide" those errors by adding IGNORE to the INSERT query, but I don't know if it's the best thing to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 09:57:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 07:57:24 +0000 Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list In-Reply-To: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14707-70-fO02zN1MfG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 10:08:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 08:08:13 +0000 Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list In-Reply-To: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14707-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14707-70-LV537cdDIe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 --- Comment #3 from Julian FIOL <julian.fiol at biblibre.com> --- Hi Tom?s, We need to standardize users answers for 'country' and 'type' to avoid Hea issues. Why do you think a country dropdown would be a bad idea ? Do you have another solution in mind ? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 11:06:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 09:06:31 +0000 Subject: [Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections In-Reply-To: <bug-13040-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13040-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13040-70-JwfMM9iZG1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14709 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 [Bug 14709] The export tool is broken if used from the command line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 11:06:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 09:06:31 +0000 Subject: [Koha-bugs] [Bug 14709] New: The export tool is broken if used from the command line Message-ID: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 Bug ID: 14709 Summary: The export tool is broken if used from the command line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Tools Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 13040 The script dies with Can't use an undefined value as a HASH reference at tools/export.pl line 149. if it is called from the command line. This is introduced by bug 13040. The C4::Context->userenv is not defined in this case. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 [Bug 13040] Improve exporter to allow multiple branch selections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 11:07:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 09:07:19 +0000 Subject: [Koha-bugs] [Bug 14709] The export tool is broken if used from the command line In-Reply-To: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14709-70-T7b4kLJ18B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The severity could be increased to critical if someone occurs the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 11:09:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 09:09:20 +0000 Subject: [Koha-bugs] [Bug 14709] The export tool is broken if used from the command line In-Reply-To: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14709-70-FMu0DXY6fE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 11:09:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 09:09:22 +0000 Subject: [Koha-bugs] [Bug 14709] The export tool is broken if used from the command line In-Reply-To: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14709-70-Q3HkvPHCXC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41818&action=edit Bug 14709: Do not access to C4::Context->userenv from the commandline The script dies with Can't use an undefined value as a HASH reference at tools/export.pl line 149. if it is called from the command line. This is introduced by bug 13040. The C4::Context->userenv is not defined in this case. Test plan: Execute the script using the command line. With the patch applies you should not get the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 11:22:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 09:22:46 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12224-70-7MnjPe0TgB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29693|0 |1 is obsolete| | --- Comment #8 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41819&action=edit Rebased to master version of the previous patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 11:24:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 09:24:23 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12224-70-pRXSQPk9WA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #9 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41820&action=edit Bug 12224: (follow-up) Allow easy printing of patron check-ins for today This adds a printing option to the staff client patron details page to print a list of items the patron returned today at this branch. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have CHECKINSLIP slip, and have print message there. If not, run updatedatabase.pl 3) Check-in items for a patron. 4) Go to that patron's detail page, and from the Print-menu in the toolbar, select "Print check-in slip" 5) You should get a slip of the patron's checked-in items. 6) Optionally, test Check-ins for the same patron, but in different branches - should only print items for the current branch. 7) Optionally, test Check-ins for the same patron, but returned in different day - should only print items for today. 8) Run unit test t/db_dependent/Members/IssueSlip.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 11:33:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 09:33:24 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12224-70-SEx81HO8Cv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #10 from Joonas Kylm?l? <j.kylmala at gmail.com> --- With the follow-up version of the patch the unit test might fail if the test is run at 12 +- 0.0001s AM/PM. What shall we do with this? It would be great to keep those unit tests. Maybe we could change the function GetTodaysReturnsForBorrower to accept a day from which the returns should be retrieved, and also function CheckInSlip to accept a day from which to retrieve the slip. Then in the unit test we could specify the day.. And I think in this way the code would be more generalized. Btw, i'm thinking of integrating the function CheckInSlip with IssueSlip, so another follow-up maybe coming soon! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:38:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:38:11 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7683-70-CYKYZQDIu7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #92 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41821&action=edit Bug 7683: Catalog statistics wizard: QA fixes 1/ Do not allow invalid date ranges (from > to) (datepicker only) 2/ Relabel "From:" to "From" for consistency 3/ Fix MIME type for CSV 4/ Use Koha::DateUtils instead of C4::Dates 5/ Use placeholders in SQL query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:39:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:39:53 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7683-70-VQyvTaCqZs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #93 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Jonathan Druart from comment #91) > 2/ Other date ranges don't have the datetime plugin (not introduced by this > patch). The only other date range should be filled with year only, so there is no need for datepicker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:47:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:47:39 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-xXck3a9fCc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:47:42 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-dJiNuq6xzK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38163|0 |1 is obsolete| | Attachment #38164|0 |1 is obsolete| | Attachment #38165|0 |1 is obsolete| | Attachment #38166|0 |1 is obsolete| | Attachment #38167|0 |1 is obsolete| | Attachment #38168|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41822&action=edit Bug 9468: make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Amended patch: Remove OPAC prog file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:47:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:47:51 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-yKkrzFPUg7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41823&action=edit Bug 9468: define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:47:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:47:55 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-1AOoyeSSAy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41824&action=edit Bug 9468: use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:47:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:47:57 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-BDmdWs5UQv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41825&action=edit Bug 9468: sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:48:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:48:01 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-lGBvo4zXiO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41826&action=edit Bug 9468 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:48:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:48:03 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-WxRkqXttEU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41827&action=edit Bug 9468: followup insert ignore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:48:06 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-PRGT7lezPj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41828&action=edit Bug 9468 [QA Followup] - Remove GetSupportList dependency from updatadatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 12:49:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 10:49:03 +0000 Subject: [Koha-bugs] [Bug 10910] You can delete a patron who has made suggestions without any warn In-Reply-To: <bug-10910-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10910-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10910-70-gphP0ugAuk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Katrin Fischer from comment #2) > Hm, I think maybe keep the suggestions, but just set the borrowernumber to 0 > or 'anonymous' if that isn't the case yet? I could guess the suggestions are kept already (I hope so). But If we delete a patron I think we cannot just delete the references to that Patron object, and leave all the data still in the system. If we want to keep some info like email address then we need to transfer it to the suggestion object. However, I don't see this as an important feature to implement (to keep the email address). In my opinion the warning message is enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:02:12 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7683-70-Vn88jS3mjW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41821|0 |1 is obsolete| | --- Comment #94 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41829&action=edit Bug 7683: Catalog statistics wizard: QA fixes 1/ Do not allow invalid date ranges (from > to) (datepicker only) 2/ Relabel "From:" to "From" for consistency 3/ Fix MIME type for CSV 4/ Use Koha::DateUtils instead of C4::Dates 5/ Use placeholders in SQL query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:04:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:04:00 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-kyLuUY20Ck@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #137 from Kyle M Hall <kyle.m.hall at gmail.com> --- I like this idea, but I think it won't work because it requires the borrowernumber to be known. Because of that, the last item checked out will not be retained if a library were to run misc/cronjobs/batch_anonymise.pl or tools/cleanborrowers.pl (In reply to Nick Clemens from comment #130) > My consortium sponsored this development, and it has taken some time to > progress it this far forward. If MySQL performance is the only blocker right > now I would really like to see a solution that addresses that and unsticks > the bug rather than requiring a rewrite of the feature. > > I played around with the query and the below, while still containing a NOT > IN, eliminates the GROUP BY and improves speed significantly: > if ( C4::Context->preference('StoreLastBorrower') ) { > # Do not delete the newest old_issue for any itemnumber > $query .= " AND issue_id NOT IN ( SELECT issue_id FROM (Select > oi.issue_id from old_issues oi LEFT OUTER JOIN old_issues oi2 ON > oi.itemnumber=oi2.itemnumber AND oi2.issue_id>oi.issue_id WHERE > oi.borrowernumber= ? AND oi2.borrowernumber IS NULL) AS oi ) "; > push @bind_params, $borrowernumber; > > Another option is to just use the query labeleed as 'oi' above in a separate > update. It effectively finds all the 'last returned' info for a borrower > and would allow you to mark those somehow (say invert borrower number to > negative of borrowernumber) then perform the regular anonymizing, and then > update any rows with a negative borrowrnumber to a positive borrowernumber > (or whatever marker was used) > > I think Chris's comment #129 has been addressed, the feature is optional > (syspref) and gives a big warning to the patron when it is enabled for full > transparency. And I don't think sharing your opinion is overstepping :-) > > If the above queries don't work, a new table could work, though I do wonder > about the redundancy. I wonder if it would be possible to use the 'return' > column in old_issues to mark 'lastreturned' or something similar to allow > for easy SQL selection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:23:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:23:47 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-NiczXaEOrp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35865|0 |1 is obsolete| | --- Comment #104 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41830&action=edit Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:23:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:23:57 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-7978GwPG8g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35866|0 |1 is obsolete| | --- Comment #105 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41831&action=edit Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:24:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:24:25 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-Mmu6rFRylo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35867|0 |1 is obsolete| | --- Comment #106 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41832&action=edit Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:24:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:24:38 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-TF0Ks6RLV7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35868|0 |1 is obsolete| | --- Comment #107 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41833&action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:24:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:24:49 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-ynlIRF4lWO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35869|0 |1 is obsolete| | --- Comment #108 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41834&action=edit Bug 8296: Display publisheddatetext in OPAC bootstrap theme Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:25:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:25:01 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-C6LevijyK9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35870|0 |1 is obsolete| | --- Comment #109 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41835&action=edit Bug 8296: Fix unit tests in t/db_dependent/Serials.t Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:25:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:25:20 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-7Y4s9Z8AxM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35871|0 |1 is obsolete| | --- Comment #110 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41836&action=edit Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is empty Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:26:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:26:54 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-Y0oqzZ6rlo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #111 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Katrin Fischer from comment #103) > Hi Julian, > > I think the common "entry page" to subscriptions for parons in the OPAC is > opac-detail > subscriptions tab. This view is labelled as 'Normal view' when > you look at it from the the full history page. I think adding the > information there the same way we have it on the full history page would > make sense to me. It appears that the date shown on this page is the 'planneddate' which is the date of reception. Should we change that and display the 'publisheddate' instead ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:54:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:54:24 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14097-70-VxWTTUMX2K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #21 from Julian FIOL <julian.fiol at biblibre.com> --- Created attachment 41837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41837&action=edit Bug 14097 : Rollback issue and warning corrected The rollback issue came from '_count' testing. It used a 'DROP TABLE' and 'CREATE TABLE' which implicitly do autocommit. That's why the final rollback could not be. This patch no longer uses t::lib::TestBuilder either because it was the cause of the warning on Comment #1 : "DBIx::Class::Storage::txn_rollback(): A txn_rollback in nested transaction is ineffective! (depth 1) at t/lib/TestBuilder.pm line 308" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:56:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:56:07 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14097-70-mE7zeucV9e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Julian FIOL <julian.fiol at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:58:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:58:54 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-oyJ36HPVPG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #84 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41838&action=edit Bug 10858: Always show checkboxes in OPAC search results Because "Browse selected biblios" action will always be available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 13:59:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 11:59:28 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-lnzZqgkDFZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:01:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:01:38 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-wfZXjEbHnL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38033|0 |1 is obsolete| | --- Comment #85 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41839&action=edit Bug 10858: Browse selected biblios Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:01:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:01:49 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-KK0xkWHuTR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38405|0 |1 is obsolete| | --- Comment #86 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41840&action=edit Bug 10858: Define the NO_RECORD_SELECTED msg in any case Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:01:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:01:59 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-UMIEAH0zS1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39502|0 |1 is obsolete| | --- Comment #87 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41841&action=edit Bug 10858: Replace the unique jQuery function with our own Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:02:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:02:10 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10858-70-BLKn5MVHUy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41838|0 |1 is obsolete| | --- Comment #88 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41842&action=edit Bug 10858: Always show checkboxes in OPAC search results Because "Browse selected biblios" action will always be available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:08:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:08:52 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14097-70-ewbIHxc90L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #22 from Julian FIOL <julian.fiol at biblibre.com> --- Created attachment 41843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41843&action=edit Bug 14097 : Avoid issue if the number of syspref shared is modified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:08:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:08:57 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14097-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14097-70-9XSDLNXiXh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 --- Comment #23 from Julian FIOL <julian.fiol at biblibre.com> --- Created attachment 41844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41844&action=edit Bug 14097 : Changing AddReserve prototype call In response of Joubu comment #19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:09:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:09:36 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-bMZgMQCyct@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41845&action=edit Bug 9809: [QA Follow-up] Still found some remains In the staff client we had still some remains referring to the constraint types. Also touched one comment line from SIP. Test plan: Add a hold in the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:11:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:11:15 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-PwneuPahBY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:11:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:11:17 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-7S1IaVqnLI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:11:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:11:18 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-6uDBhk3k4Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:11:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:11:20 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-73Mk406rBx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:12:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:12:47 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-qTL4JAz7m0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #6) > Instead of calling GetReserveFee when we are in AddReserve, we should only > charge the hold fee when filling the reserve. So we should move the call to > ModReserveFill ! Hm. I will try to keep closer to what the code originally does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:19:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:19:08 +0000 Subject: [Koha-bugs] [Bug 14710] New: Export checkout list export all item infos Message-ID: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 Bug ID: 14710 Summary: Export checkout list export all item infos Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 11703 This has been introduced by bug 11703. Bug 13190 should have been fixed it. If the pref ExportWithCsvProfile is defined with a MARC CSV profile and it contains item infos to display, only info from the checked in item should be displayed. On the current master, the infos from all items of the record is exported. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 [Bug 11703] Convert checkouts table to ajax datatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:19:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:19:08 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: <bug-11703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11703-70-SJbGwtTUTp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14710 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 [Bug 14710] Export checkout list export all item infos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:19:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:19:08 +0000 Subject: [Koha-bugs] [Bug 13190] Export checkout list does not work anymore In-Reply-To: <bug-13190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13190-70-1SY5VHcHVK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13190 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14710 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:26:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:26:01 +0000 Subject: [Koha-bugs] [Bug 14710] Export checkout list export all item infos In-Reply-To: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14710-70-afKTsKSKEZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:26:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:26:03 +0000 Subject: [Koha-bugs] [Bug 14710] Export checkout list export all item infos In-Reply-To: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14710-70-jJhSWWjXIg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41846&action=edit Bug 14710: Make the export checkout list export only the checked out item infos This has been introduced by bug 11703. Bug 13190 should have been fixed it. If the pref ExportWithCsvProfile is defined with a MARC CSV profile and it contains item infos to display, only info from the checked out item should be displayed. Test plan: 0/ Don't apply this patch 1/ Create a biblio with 1+ items 2/ Check one of the item out to a patron 3/ Define a CSV profile which contains item fields ("245$a|952$p" for instance) 4/ Export the item (from circ/circulation/pl) using the CSV option Note that the csv contains the barcode from all items 5/ Apply this patch and repeat 4. 6/ Note that the csv contains only the barcode from the checked out item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:26:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:26:45 +0000 Subject: [Koha-bugs] [Bug 14710] Export checkout list exports all item infos In-Reply-To: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14710-70-69HIaNwqoh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Export checkout list export |Export checkout list |all item infos |exports all item infos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:35:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:35:30 +0000 Subject: [Koha-bugs] [Bug 14709] The export tool is broken if used from the command line In-Reply-To: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14709-70-fnAlhfkr9B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:35:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:35:33 +0000 Subject: [Koha-bugs] [Bug 14709] The export tool is broken if used from the command line In-Reply-To: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14709-70-BKYVSylSaZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41818|0 |1 is obsolete| | --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41847&action=edit Patch fixes the bug. I don't see any side effects caused by the fix. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:39:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:39:34 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-bShmyw7cbj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41814|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41848&action=edit Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> AMENDED: An else branch in reserve/placerequest.pl was removed. This had the effect of making it no longer possible to place an any hold in the staff client. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Verified placing a biblio level and an item level hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:39:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:39:38 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-K9xTwBBJGa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41815|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41849&action=edit Bug 9809: [QA Follow-up] Remove warnings from Hold.pm Resolves two warnings on a uninitialized found column: holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 Test plan: Run t/db_dependent/Hold.t. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:39:42 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-B7syuq722p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41816|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41850&action=edit Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:39:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:39:45 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-dXUZZgdSDy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41817|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41851&action=edit Bug 9809: [QA Follow-up] Remove constrainttype from 14464 tests Some additional unit tests of bug 14464 still included a constraint in the AddReserve calls. Test plan: Run Reserves.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:39:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:39:49 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-tKlzrbkro0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41845|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41852&action=edit Bug 9809: [QA Follow-up] Still found some remains In the staff client we had still some remains referring to the constraint types. Also touched one comment line from SIP. Test plan: Add a hold in the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:47:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:47:08 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-iW9yf72ykC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41853&action=edit Bug 14702: Refactor GetReserveFee The code of GetReserveFee was not very clear. What it did was: check if there are some items not issued. If so and there are no holds, calculate no fee. Since AddReserves only calls this sub, we can move the code for charging the fee to this sub. I renamed it to ChargeReserveFee. There is no change in behavior. Test plan: [1] Make sure that a patron category (X) includes a hold fee. [2] Select a biblio with 2 items. [3] Issue one item to another patron. [4] Place a hold on this biblio by patron with category X. No charge? [5] Cancel the hold from the previous step. [6] Use another patron to place another hold on this biblio. [7] Place hold again by patron with category X. Is it charged? [8] Cancel that hold again. Issue the second item to another patron. [9] Place hold again by patron with category X. Is it charged again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:47:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:47:13 +0000 Subject: [Koha-bugs] [Bug 14702] Fix GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-ZpEA3ArObW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41854&action=edit Bug 14702: Unit tests for ChargeReservesFee Test plan: Run the test: t/db_dependent/Reserves_ChargeReserveFee.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:47:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:47:29 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-mfZIA74Fol@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix GetReserveFee |Refactor GetReserveFee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:49:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:49:32 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-QsJdS7xiIf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- In the end I kept closer to the original "design". So no behavior change! A closer look revealed that part of the original loop was useless. Hope that this makes things at least easier to understand.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:50:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:50:37 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12772-70-XX4u73S1pm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #9 from Martin Persson <xarragon at gmail.com> --- Created attachment 41855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41855&action=edit Bug 12772 - Fix warnings This commit fixes a bunch of warnings for verbose messages which would clutter up the output. They should not affect normal excution. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:53:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:53:52 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-PT34faMrWM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41853|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41856&action=edit Bug 14702: Refactor GetReserveFee The code of GetReserveFee was not very clear. What it did was: check if there are some items not issued. If so and there are no holds, calculate no fee. Since AddReserves only calls this sub, we can move the code for charging the fee to this sub. I renamed it to ChargeReserveFee. There is no change in behavior. Test plan: [1] Make sure that a patron category (X) includes a hold fee. [2] Select a biblio with 2 items. [3] Issue one item to another patron. [4] Place a hold on this biblio by patron with category X. No charge? [5] Cancel the hold from the previous step. [6] Use another patron to place another hold on this biblio. [7] Place hold again by patron with category X. Is it charged? [8] Cancel that hold again. Issue the second item to another patron. [9] Place hold again by patron with category X. Is it charged again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 14:53:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 12:53:56 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-rhDs5sZ2gX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41854|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41857&action=edit Bug 14702: Unit tests for ChargeReservesFee Test plan: Run the test: t/db_dependent/Reserves_ChargeReserveFee.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:15:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:15:32 +0000 Subject: [Koha-bugs] [Bug 14711] New: We do no longer need bibitems in AddReserve Message-ID: <bug-14711-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Bug ID: 14711 Summary: We do no longer need bibitems in AddReserve Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If bug 9809 and bug 14702 make their way into Koha, time comes to remove the bibitems parameter from AddReserve. In that case it is no longer used (code for reserve fee calculation being replaced). Note that this parameter was not supplied in the same form consistently thru Koha. The old code could handle that; the new code does not need it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:25:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:25:15 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-E3PM6t91GD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Just looking for a new placeholder. We got <<items.fine>> to display the fine per item. And we have something like <<today>> to display today's date. The suggestion would be to have something like <<totalfine>> or similar to print the total amount owed by a patron in the letter. So a single placeholder - not one to be repeated in the letter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:28:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:28:49 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-gIGCYzOdS6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Jacek Ablewicz from comment #3) > 1) if order line is deleted, additional fields for this order will > stay in the database Order lines are never removed from database, so additional fields data should remain too. > 3) non-latin character encoding: similar issues as in 10855 (see also > Bug 11302 - Template::output should deal with object). I think this has been fixed by bug 11944 or bug 10855 because I can't reproduce the problem. Remaining issue: > 2) in case order gets transferred to another basket, additional fields > will remain associated with initial order record (now "cancelled" > after the transfer); shouldn't they rather got re-associated with the > newly created order record (the clone of the original) instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:29:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:29:15 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-iduXUdbcDn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:29:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:29:17 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-JYxZbWxHE9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41799|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41858&action=edit Bug 12632 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:31:05 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-soIGnBcFZN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #26 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #20) > One test does not pass for me: > > # Failed test 'Patron cannot reserve item with hold limit of 1, 1 bib > level hold placed' > # at t/db_dependent/Holds.t line 449. > # got: 'OK' > # expected: 'tooManyReserves' Fixed! On master the issuing rule I created for the test was getting deleted before the new tests were run! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:32:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:32:48 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-bu2CEC1oR8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41859&action=edit Bug 11844: Copy additional fields values when transfering order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:32:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:32:52 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-1BNgWh3eRY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41860&action=edit Bug 11844: Fix additional field values when creating a new order line ordernumber was not correctly retrieved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:33:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:33:05 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-QNmeKA3hH4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:41:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:41:14 +0000 Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour customizable In-Reply-To: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8994-70-rym4vCan8Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36424|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41861&action=edit Bug 8994: Improve FindDuplicateAuthority With two new sysprefs: - FindDuplicateOptions, - FindDuplicateMaxResults, you can modify the behaviour of this sub in order to fit your needs. You can now search on another index than 'he' and compare subfields of search results. For example, if FindDuplicateOptions is 'he,wrdl/2..ab | See/4..ab', FindDuplicate will search on index 'he' and try to compare $a and $b subfields for all 2XX fields of search results with $a and $b for 2XX fields of newly created authority. If there is no results it will try to search on 'See' index and compare 4XX$a$b of search results with 2XX$a$b of created authority. FindDuplicateMaxResults define how many results should be fetched for comparison. The '/2..ab' part can be omitted from FindDuplicateOptions. In this case, no comparison is made on subfields and the first search result is returned as duplicate. To keep the current behaviour, fill FindDuplicateOptions with 'he,wrdl' (default value in updatedatabase.pl) Note: search on 'at' index is still done in all cases, so only the authorities of the same type are returned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 15:47:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 13:47:45 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-JO5utr55VU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Katrin Fischer from comment #2) > Just looking for a new placeholder. We got <<items.fine>> to display the > fine per item. And we have something like <<today>> to display today's date. > The suggestion would be to have something like <<totalfine>> or similar to > print the total amount owed by a patron in the letter. So a single > placeholder - not one to be repeated in the letter. Yeah, that would great. Actually we just spoke about that kind of feature in our library. I think I could add that quickly there. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 16:06:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 14:06:31 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12772-70-wi5QYPiWnQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Martin Persson <xarragon at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xarragon at gmail.com --- Comment #10 from Martin Persson <xarragon at gmail.com> --- I have done basic testing with this and it seems to work for simple cases at least. I plan to work throught the test plan before I sign off on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 16:28:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 14:28:31 +0000 Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour customizable In-Reply-To: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8994-70-2GGxPccmcz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> --- For the test plan, I'm assuming 2XX authority fields are indexed in a 'he' index and 4XX fields are indexed in a 'See' index. Also, I don't know MARC21 authorities, so the examples here are for UNIMARC. Test plan: 0/ Delete all your authorities and reindex or be sure to use unique strings in the following examples. 1/ Create an authority type T with "Authority field to copy" = "200" 2/ Create a new authority A1 of type T 200$a: Foo 200$b: Bar 400$a: Baz 3/ Set FindDuplicateOptions to 'he,wrdl' (the default) 4/ Reindex authorities 5/ Create a new authority of type T 200$a: Foo A duplicate should be found (A1). Cancel the creation. 6/ Create a new authority of type T 200$a: Baz No duplicate should be found. 7/ Set FindDuplicateOptions to 'he,wrdl/2..a' 8/ Create a new authority of type T 200$a: Foo 200$b: Baz A duplicate should be found (A1). Cancel the creation. 9/ Set FindDuplicateOptions to 'he,wrdl/2..ab' 10/ Create a new authority of type T 200$a: Foo 200$b: Baz No duplicate should be found 11/ Set FindDuplicateOptions to 'See/4..a' 12/ Create a new authority of type T 200$a: Foo No duplicate should be found 14/ Create a new authority of type T 200$a: Baz A duplicate should be found (A1). Cancel the creation. This is a very simple test plan as there can be many more cases to test, but I hope this will make testing easier. There is something that may need clarification, however. The Zebra query is built using the 'index' and 'subfield' parts of the syspref, and the "Authority field to copy" defined in authority type. For example, if: - type T has "Auth field to copy" = 215 - FindDuplicateOptions is 'See/4..ay' - we try to create an authority: 215$a: 'foo', 215$b: 'bar', 215$y: 'baz' The query will look like this: "See = foo and See = baz" (215$b is not used) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 16:48:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 14:48:50 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-7mgJusx9SB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41862&action=edit Bug 13918 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 16:49:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 14:49:11 +0000 Subject: [Koha-bugs] [Bug 12670] Show materials label instead of code In-Reply-To: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12670-70-fWSS9BJizr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 16:56:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 14:56:01 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-xIVWkByhDl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41863&action=edit Bug 13918 [QA Followup] - Remove reserves_count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 17:12:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 15:12:03 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-s2wKzaKng0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41864&action=edit Bug 13918 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 17:19:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 15:19:37 +0000 Subject: [Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface In-Reply-To: <bug-11904-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11904-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11904-70-I22SiYAQyj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 17:36:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 15:36:56 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-gizMfI3ccx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 17:36:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 15:36:58 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-CjZN01deMO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41864|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41865&action=edit Bug 13918 [QA Followup] - Improve $biblio->subtitles() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 17:39:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 15:39:23 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13387-70-tbYxVRU3ZP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 --- Comment #18 from Winona Salesky <wsalesky at gmail.com> --- Great! Thank you. -Winona (In reply to Tom?s Cohen Arazi from comment #17) > Patch pushed to master. > > Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 18:11:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 16:11:22 +0000 Subject: [Koha-bugs] [Bug 14712] New: Feature for controlling cron jobs/cmd line scripts from staff client Message-ID: <bug-14712-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 Bug ID: 14712 Summary: Feature for controlling cron jobs/cmd line scripts from staff client Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: eivin at sysmystic.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz This feature will add an admin page to the staff client enabling superusers to trigger cron or other scripts without having to rely on a server admin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 18:11:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 16:11:43 +0000 Subject: [Koha-bugs] [Bug 14712] Feature for controlling cron jobs/cmd line scripts from staff client In-Reply-To: <bug-14712-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14712-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14712-70-13TeFgB4ng@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 Eivin Giske Skaaren <eivin at sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |eivin at sysmystic.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 18:12:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 16:12:39 +0000 Subject: [Koha-bugs] [Bug 14712] Feature for controlling cron jobs/cmd line scripts from staff client In-Reply-To: <bug-14712-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14712-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14712-70-PbvMkLHmb8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 Eivin Giske Skaaren <eivin at sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored --- Comment #1 from Eivin Giske Skaaren <eivin at sysmystic.com> --- Sponsored-by: Halland county library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 18:13:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 16:13:45 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-KCuHgPxSbn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #46 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41866&action=edit Bug 13791: (QA followup) Plack support requires Apache 2.4.8+ The Apache 2.4 documentation says UDS support for ProxyPass has been introduced in Apache 2.4.7. That's what is shipped by Koha's supported Debian / Ubuntu versions. But it is not true, empiric tests and even the changelog for the apache project says the feature got introduced in 2.4.8. So to avoid breakages I raised the version number test on the apache files to 2.4.8. New bugs will be filled for dealing with this if we find it necessary. Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 18:16:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 16:16:51 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-uJWzto5SN9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #47 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Farewell, CGI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 18:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 16:47:04 +0000 Subject: [Koha-bugs] [Bug 14713] New: remaining_permissions permission under the "updatecharges" permission not working Message-ID: <bug-14713-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 Bug ID: 14713 Summary: remaining_permissions permission under the "updatecharges" permission not working Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: amy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Partner reports that: One of our institutions would like students to be able to collect fines, but not waive fines. You would think selecting the "remaining_permissions" permission under the "updatecharges" permission would allow you to collect fines and fees without waiving them because "writeoff" fines and fees is a separate permission, but it is not. They can't write off any fines- which is what we want. The problem is, they can't collect fines either, and we do want them to be able to do that. We tested this and it seems to be true that even using the correct settings under this permission the student cannot collect fines, though they are prevented from waiving them as anticipated. On the student account permissions the remaining permissions is checked and write off is not selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 20:43:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 18:43:21 +0000 Subject: [Koha-bugs] [Bug 14714] New: koha-mysql tab-completion in bash Message-ID: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 Bug ID: 14714 Summary: koha-mysql tab-completion in bash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The koha-mysql script lacks tab-completion in bash which would be handy. It should complete using only one valid instance name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 20:43:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 18:43:40 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-94BAuDXKaI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 20:47:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 18:47:53 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-5VylT31l6h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 20:47:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 18:47:56 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-2iOOwoRdfI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41867&action=edit Bug 14714: Add tab-completion to koha-mysql command This patch introduces tab-completion in bash to the koha-mysql command. It completes using valid instance names. It stops completing once an instance name is chosen (i.e. it respects the fact that koha-mysql accepts only one instance name as parameter). To test: - Have a packages install (kohadevbox works) - Run: $ . debian/koha-common.bash-completion - Type koha-mysql <tab> => SUCCESS: You are prompted valid instance names for completion. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 20:48:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 18:48:26 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-D0s4pQlICT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12372 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 [Bug 12372] Make koha-mysql handle arbitrary mysql arguments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 20:48:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 18:48:26 +0000 Subject: [Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments In-Reply-To: <bug-12372-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12372-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12372-70-HVSzPUrWEl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14714 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 [Bug 14714] koha-mysql tab-completion in bash -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 20:59:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 18:59:54 +0000 Subject: [Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments In-Reply-To: <bug-12372-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12372-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12372-70-DIT0Lm1B1Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Barton! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 21:03:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 19:03:17 +0000 Subject: [Koha-bugs] [Bug 14361] koha-restart-zebra fails and probably breaks upgrade In-Reply-To: <bug-14361-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14361-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14361-70-Uf3XFE3P0L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14361 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 21:30:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 19:30:41 +0000 Subject: [Koha-bugs] [Bug 14715] New: results per page setting for catalog search in staff client and opac Message-ID: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Bug ID: 14715 Summary: results per page setting for catalog search in staff client and opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin at bugs.koha-community.org.xinxidi.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Add a select field to the search results page (both in staff client and opac) where user can select how many results per page should be shown. For instance: 20/40/60/80/100/all -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 21:33:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 19:33:47 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-8xriIjGX8g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin at bugs.koha-community. |ity.org |org.xinxidi.net CC| |martin at bugs.koha-community. | |org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 21:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 19:33:59 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-4bkYc2JHN3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 22:04:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 20:04:30 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-uLBG4S2DhS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 --- Comment #2 from Nick Clemens <nick at quecheelibrary.org> --- Created attachment 41868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41868&action=edit [SIGNED OFF] Bug 14714: Add tab-completion to koha-mysql command This patch introduces tab-completion in bash to the koha-mysql command. It completes using valid instance names. It stops completing once an instance name is chosen (i.e. it respects the fact that koha-mysql accepts only one instance name as parameter). To test: - Have a packages install (kohadevbox works) - Run: $ . debian/koha-common.bash-completion - Type koha-mysql <tab> => SUCCESS: You are prompted valid instance names for completion. - Sign off :-D Signed-off-by: Nick Clemens <nick at quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 22:05:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 20:05:06 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-s0WFeyyTdi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 22:06:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 20:06:11 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-hixHVsova1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41867|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 22:10:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 20:10:01 +0000 Subject: [Koha-bugs] [Bug 14710] Export checkout list exports all item infos In-Reply-To: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14710-70-K0YpURnIFA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41846|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- Created attachment 41869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41869&action=edit [SIGNED-OFF]Bug 14710: Make the export checkout list export only the checked out item infos This has been introduced by bug 11703. Bug 13190 should have been fixed it. If the pref ExportWithCsvProfile is defined with a MARC CSV profile and it contains item infos to display, only info from the checked out item should be displayed. Test plan: 0/ Don't apply this patch 1/ Create a biblio with 1+ items 2/ Check one of the item out to a patron 3/ Define a CSV profile which contains item fields ("245$a|952$p" for instance) 4/ Export the item (from circ/circulation/pl) using the CSV option Note that the csv contains the barcode from all items 5/ Apply this patch and repeat 4. 6/ Note that the csv contains only the barcode from the checked out item. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 22:10:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 20:10:20 +0000 Subject: [Koha-bugs] [Bug 14710] Export checkout list exports all item infos In-Reply-To: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14710-70-SZFxCou9Fp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 22:27:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 20:27:22 +0000 Subject: [Koha-bugs] [Bug 14716] New: opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Message-ID: <bug-14716-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Bug ID: 14716 Summary: opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 41870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41870&action=edit marc record with test data To reproduce Add a bib with the following data in biblioitems.marcxml: <datafield tag="440" ind1=" " ind2="0"> <subfield code="a">Magic tree house ;</subfield> <subfield code="v">#6</subfield> <subfield code="9">39181</subfield> </datafield> [the attached bib-14675.utf8 contains just such a record] Make sure that the fast indexer picks up the record. In the opac a title search for the bib; this should bring up opac-detail.pl Using view source The 'Series' link looks like this: <a href="/cgi-bin/koha/opac-search.pl?q=se,phr:%22Magic%20tree%20house%20;%22">Magic tree house ; #6</a> When url-decoded, the href looks like /cgi-bin/koha/opac-search.pl?q=se,phr:"Magic tree house ;" ... this will not return any search results When the trailing space and semicolon is removed: /cgi-bin/koha/opac-search.pl?q=se,phr:"Magic tree house" The resulting string can be url-encoded and appended to the opac base url -- this will return search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 23:48:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 21:48:00 +0000 Subject: [Koha-bugs] [Bug 14717] New: Adding a new patron can end up with 0000-00-00 as the debarred date Message-ID: <bug-14717-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Bug ID: 14717 Summary: Adding a new patron can end up with 0000-00-00 as the debarred date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 12633 introduced a bug, that where debarred is blank, the column is being filled with 0000-00-00 You can test this by importing a patron using the import tool, the patron must have no debarred date set. Then check in the DB and you will notice it has an invalid date 0000-00-00 This in turn makes Koha error in circulation as we try to truncate and invalid date object. Adding $data{'debarred'} = undef if( not $data{'debarred'} ); to the AddMembers subroutine should fix this issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 24 23:48:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 21:48:07 +0000 Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date In-Reply-To: <bug-14717-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14717-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14717-70-bVSRkTEpGM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 00:03:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 22:03:25 +0000 Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date In-Reply-To: <bug-14717-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14717-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14717-70-z5rllzVSRK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 --- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 41871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41871&action=edit Bug 14717: Invalid dates in debarred column To test 1/ Import a patron using the patron import tool, make sure they have no debarred column in the file 2/ Check the database, notice the debarred column is 0000-00-00 3/ For bonus points, checkout an item to that borrower, then check it in notice Koha errors 4/ Apply patch 5/ Import a new patron 6/ Notice column is now NULL and that checkins work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 00:03:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 22:03:23 +0000 Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date In-Reply-To: <bug-14717-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14717-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14717-70-isHmVEbjBF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 00:28:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 22:28:09 +0000 Subject: [Koha-bugs] [Bug 14718] New: Documentation/screenshot update Message-ID: <bug-14718-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14718 Bug ID: 14718 Summary: Documentation/screenshot update Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Documentation Assignee: nengard at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Depends on: 14467 Assuming bug 14467 gets in, the screenshots for the label creator, the online help, and the manual will need to be updated with the new UI layout. Please and thank you! Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 [Bug 14467] Security updates break some Koha plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 00:28:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Aug 2015 22:28:09 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: <bug-14467-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14467-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14467-70-gjNgfOxnI9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14718 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14718 [Bug 14718] Documentation/screenshot update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 03:29:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 01:29:43 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-NRwkFZvMvi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 03:30:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 01:30:34 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-EwUEAyzxUh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #44 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Fr?d?ric Demians from comment #43) > I have set back this patch status to 'Signed off'. The UT should suit QA > needs. I consider this passed QA, but as Jonathan asked about tests for the features, and the tests have been provided, I think it is Jonathan who should tell. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 04:14:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 02:14:51 +0000 Subject: [Koha-bugs] [Bug 14718] Documentation/screenshot update In-Reply-To: <bug-14718-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14718-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14718-70-okz7PRksNs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14718 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14467 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 [Bug 14467] Security updates break some Koha plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 04:14:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 02:14:51 +0000 Subject: [Koha-bugs] [Bug 14467] Security updates break some Koha plugins In-Reply-To: <bug-14467-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14467-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14467-70-GAgkaqLd2O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14467 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14718 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14718 [Bug 14718] Documentation/screenshot update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 08:29:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 06:29:17 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-RjyUwss8ZW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #4 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41872&action=edit Bug 13961: Option to include patron's total amount of fines in notices Possibility to show patrons's total amount of fines in notices. Test plan: 1. Apply patch 2. Modify some notice in Tools -> notices & slips 3. See that in the left side of where one can edit message's body is now also a new attribute that one can include to the text: borrowers.totalfine 4. Include that to the text and see it showing the patron's total amount of fines. Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 08:29:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 06:29:37 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-TfqT6YIOqW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:02:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:02:51 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-RcGz4omb5U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41555|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41873&action=edit Bug 14321: Using Koha::Upload in tools/upload-file.pl This patch introduces Koha::Upload. It will replace the modules C4::UploadedFile.pm and the new C4::UploadedFiles.pm (from BZ 6874). This operation will be performed in a few steps. As a first step, we will use Koha::Upload instead of UploadedFile in the following places. (In these three places files are uploaded temporarily.) [1] stage-marc-import.pl [2] upload-cover-image.pl [3] offline_circ/process_koc.pl and enqueue_koc.pl A new file-upload.js replaces file-upload.inc in the associated template. We now use ajax to get progress figures instead of launching perl script upload-file-progress. Also we do not need the jquery plugin ajaxfileupload.js anymore. A subsequent patch will remove these files. The js changes now also allow for aborting a file upload. This feature has been added to stage-marc-import only for now. NOTE: In editing the process_koc.tt I noticed that the form enqueuefile was hidden and no longer used (with associated code in process_koc.pl). When a file has been uploaded, I display the form again (with the Apply directly button). The code still works. NOTE 2: The changes to upload-file and upload-file-progress in respect to replacing the indirect syntax for CGI::Cookie come from bug 14589. Test plan: [1] Upload a marc file in stage-marc-import. [2] Check new entry in table uploaded_files. Look for the file in the directory defined by upload_path in koha-conf.xml. [3] Upload another (larger) file and abort the upload. Check table and directory again. [4] Verify that Stage for import still works as expected. [5] Test Upload local cover image. (Enable OPACLocalCoverImages.) You can test an individual image or a zip file including images and a file called datalink.txt (with lines biblionumber,filename). [6] Test uploading a offline circulation file: Enable AllowOfflineCirculation, and create a koc file (plain text): Line1: Version=1.0\tA=1\tB=2 Line2: 2015-08-06 08:00:00 345\treturn\t[barcode] Note: Replace tabs and barcode. The number of tabs is essential! Checkout the item with your barcode. Go to Offline circulation file upload. Upload and click Apply directly. Checkout again. Upload again, click Add to offline circulation queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:02:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:02:55 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-GqANaPYsLJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41556|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41874&action=edit Bug 14321: Add some error checking to Upload.pm This patch makes Upload return some error codes if a file cannot be read or cannot be written. Test plan: [1] Upload a file with stage-marc-import.pl. This is a temporary file; it will be saved in your system's temporary dir (e.g. /tmp) within the folder koha_upload. [2] Change the owner of this koha_upload dir and remove write permissions. [3] Upload the file again. You should get: Upload status: Failed. [4] Restore owner and permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:02:58 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-8nHv523qex@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41557|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41875&action=edit Bug 14321: Add public column to uploaded_files This patch adds uploaded_files.public. This column will be used to mark uploaded files as available via opac-retrieve. The db rev sets this flag for current records having a category (as uploaded via the BZ 6874 plugin: so public). A followup patch will adjust the plugin to use Koha::Upload. Test plan: [1] Run the dbrev. [2] Add a record (upload a file) via stage-marc-import. [3] Check that public is null in the new record. (This is a temporary file without category.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:03:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:03:02 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-cArOifdMAW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41558|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41876&action=edit Bug 14321: Redirect upload plugin to general upload script This patch makes the following changes to achieve that: [1] Adds a tools/upload script and template. It allows to upload multiple files at once. [2] Adds additional parameter to js function AjaxUpload (for category and public column). [3] Adds methods to Upload: count, delete, getCategories, httpheaders. [4] Makes upload-file return error messages in JSON. For a multiple upload, we could have some files with errors and others without errors. The upload is now marked as Failed only if there was no upload at all. [5] Adds decode_utf8 statement for UTF-8 chars in filenames (in the CGI hook). Note that we do not want the -utf8 flag here for binary uploads. [6] The upload plugin is converted to use tools/upload with plugin param. Deleting an upload is now presented via the search results form. NOTE: A unit test is supplied in a follow-up patch. Test plan: [1] Upload three files via tools/upload.pl with a category and marked as public. Check the results in the table. [2] Pick one new file and one of the files of step 1. Upload them in the same category. One upload should succeed. Check for reported error. [3] Upload a file via stage-marc-import. Stage it. [4] Go to Cataloguing editor. Connect upload.pl to field 856$u. In an empty 856$u, click the tag editor. Upload a file and click Choose. Save the record. Open the record in the OPAC and click the link. Copy this link to your clipboard for step 5. [5] Go back to editor. Click the tag editor on the same 856 field. Choose for Delete. Open the link in your clipboard again. [6] Check the process of upload, search, download and delete of an upload with some diacritical characters in the filename. (Bonus points for adding special chars in the category code.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:03:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:03:09 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-XY3qD0Vv7g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41666|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41878&action=edit Bug 14321: Unit test for Koha::Upload This unit test replaces the test for UploadedFiles.pm. That one used dependency Test::CGI::Multipart. We are now mocking CGI and its hook to achieve the same result. Some tests are added to cover additional routines in Upload.pm. Test plan: Run the test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:03:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:03:06 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-P59bPMksLR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41665|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41877&action=edit Bug 14321: Switch to Upload in opac-retrieve A last step to obsolete UploadedFiles.pm. Note that we now also check for the public flag. If that flag is not set, the uploaded file cannot be reached via the opac. This patch also the encode step to tools/upload for the http header that could include a filename with special chars (just as in opac-retrieve). Test plan: [1] Check downloading a file marked public in OPAC without logging in. If possible, include some special chars in the filename. [2] Check another file (not marked as public). Should not be possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:03:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:03:13 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-guBezeJM56@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41667|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41879&action=edit Bug 14321: Fix permissions check in upload-file.pl This fixes an error in one of the patches of bug 6874. The userid of the Koha admin user is passed to haspermission, but we should pick the userid from the session. NOTE: Bug 14686 will add a specific permission for tools/upload.pl. At that time we can add the script to the Tools menu too. For now, you need edit_catalogue to start upload.pl and you will additionally need a permission like upload_local_cover_images (see tools/upload-file) to successfully upload a new file. Searching for files and copying URLs to the editor can still be done with edit_catalogue. Test plan: [1] Pick a staff user that only has catalogue and edit_catalogue. [2] Without this patch, you can upload a file on tools/upload.pl. [3] Apply this patch. [4] Retry. Should not work: Upload status is Denied. [5] Login with enough permissions. Upload again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:03:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:03:17 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-pG1eF0Gqfg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41668|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41880&action=edit Bug 14321: Just some documentation lines added or fixed Test plan: Actually, you cannot really test this. But you could run the unit test again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:03:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:03:21 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-Zqraq56Oqm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41677|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41881&action=edit Bug 14321: Final cleanup, removing obsolete files The new Upload.pm, unit test and file-upload.js obsolete a number of files, including an older jQuery plugin. The test files progressbar.pl and progressbarsubmit.pl are outdated and do not serve any purpose in this form. (Actually, we could argue if they should be here or just be part of a debugging phase.) Test plan: [1] Git grep on file-progress, file-upload.inc, UploadedFile, ajaxfileupload, ajaxFileUpload UploadedFile: Only a reference to DBIx file is found ajaxfileupload: Only release notes [2] Upload a file with tools/upload and stage-marc-import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:04:15 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-TlsnISjyH0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 --- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Rebased, included small change from bug 14589 for upload-file and upload-file-progress. No dependencies anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:04:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:04:25 +0000 Subject: [Koha-bugs] [Bug 14588] Simplify merge_ajax.pl In-Reply-To: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14588-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14588-70-1qtbCXZG5D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14321 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:04:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:04:25 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-lCGLlHXUXa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14321 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:04:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:04:25 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-VQZnq96c0A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14588, 14589 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588 [Bug 14588] Simplify merge_ajax.pl http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:07:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:07:39 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-klJ32vIb89@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41882&action=edit Bug 14589: Replace fetch CGI::Cookie calls This patch is inspired by the change in bug 14588. It replaces the indirect object syntax for CGI::Cookie. Some trivial corrections are made to authorities/merge_ajax.pl just as bug 14588 does for cataloguing. NOTE: The changes to tools/upload-file.pl and upload-file-progress.pl are moved to report 14321. Test plan: Run the URL authorities/merge_ajax.pl in staff. Upload a file with Stage MARC records for import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:10:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:10:26 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-2PGrQHhdf4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41691|0 |1 is obsolete| | Attachment #41882|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41883&action=edit Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax This patch does the following: [1] Adjust authorities_merge_ajax just as in bug 14588. [2] Replace some indirect syntax for fetch GGI::Cookie. [3] Along the way replace some new CGI's. Note that I am not aiming to replace them Koha wide. The "fetch class" variant is less readable. NOTE: The changes to tools/upload-file.pl and upload-file-progress.pl are moved to report 14321. Test plan: [1] Run the URL authorities/merge_ajax.pl in staff. [2] Upload a file with Stage MARC records for import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:11:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:11:06 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-rUFWg0ItRQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14321 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:11:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:11:06 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-ca3akC6uqG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14589 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:21:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:21:43 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-TcD2tenlBN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41701|0 |1 is obsolete| | --- Comment #7 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41884&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:29:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:29:20 +0000 Subject: [Koha-bugs] [Bug 14710] Export checkout list exports all item infos In-Reply-To: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14710-70-d42DXPLatM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- > Sponsored-by: Universidad de El Salvador Hum, this does not seem to be at the correct place :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:31:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:31:35 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-KIPxp2fvhs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 41885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41885&action=edit Bug 14703: Holidays description shows \r\n for every new line Adds a new line for the holiday's description instead of the string \r\n. Test plan: 1. In tools -> Calendar look at some holiday's description (Do a new holiday with description of multiple lines if there is not already) 2. Notice that there is characters \r\n if someone has put a newline in the holiday's description 3. Apply patch 4. See that the new lines show there now nicely Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:32:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:32:56 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-UyJwHEGFxc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 09:53:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 07:53:29 +0000 Subject: [Koha-bugs] [Bug 14712] Feature for controlling cron jobs/cmd line scripts from staff client In-Reply-To: <bug-14712-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14712-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14712-70-DEEoL409Rs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 10:43:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 08:43:51 +0000 Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl In-Reply-To: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13980-70-bLsn0SKH5v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED CC| |j.kylmala at gmail.com --- Comment #2 from Joonas Kylm?l? <j.kylmala at gmail.com> --- I get this error still: Can't call method "fields" on an undefined value at /home/koha/kohaclone/cataloguing/additem.pl line 703. I was importing a new item and I koha said that there is duplicate record, I clicked then: Yes, edit existing items and this error popped up. I guess there was a problem with zebra indexing, but I think we should fix this error, maybe just show a message which could suggest what is wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 10:57:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 08:57:49 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7174-70-mCgB2KG721@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 10:59:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 08:59:30 +0000 Subject: [Koha-bugs] [Bug 14704] members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM (' In-Reply-To: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14704-70-bXu6tBlI3z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14704 --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- (In reply to Jonathan Druart from comment #2) > I got the following if I execute directly the second query in my MariaDB CLI: > > ERROR 1054 (42S22): Unknown column 'tmp.return' in 'field list' That is because my hastily created example SQL was missing explicit definition for issues.return and old_issues.return. This wasn't the case in the code (hopefully). Try this: SELECT COUNT(*) as count_precedent_state,tmp.issues,tmp.onloan,tmp.return FROM ( SELECT it.*, i.return FROM issues i, items it WHERE i.borrowernumber = 1234 AND i.itemnumber = it.itemnumber AND DATE(i.issuedate) < CAST(now() AS date) UNION SELECT it.*, oi.return FROM old_issues oi, items it WHERE oi.borrowernumber = 1234 AND oi.itemnumber = it.itemnumber AND DATE(oi.issuedate) < CAST(now() AS date) AND DATE(oi.returndate) = CAST(now() AS date) ) tmp GROUP BY tmp.issues,tmp.onloan,tmp.return; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:01:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:01:15 +0000 Subject: [Koha-bugs] [Bug 14704] members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM (' In-Reply-To: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14704-70-7EU6JyAXhu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14704 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- The dynamically created SQL here is problematic and needs to be overhauled on a more broader level. Since the columns desired can be gained from a syspref, the SQL needs to take that into account as well. This is an optimal scenario to leverage DBIx and its more configurable search building. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:01:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:01:47 +0000 Subject: [Koha-bugs] [Bug 14704] members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM (' In-Reply-To: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14704-70-dbXHev5WQn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14704 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:02:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:02:31 +0000 Subject: [Koha-bugs] [Bug 14719] New: Regression tests for members/statistics.pl Message-ID: <bug-14719-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14719 Bug ID: 14719 Summary: Regression tests for members/statistics.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:03:29 +0000 Subject: [Koha-bugs] [Bug 14719] Regression tests for members/statistics.pl In-Reply-To: <bug-14719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14719-70-M0oY78Xrm0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14719 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 41886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41886&action=edit Bug 14719 - Regression tests for members/statistics.pl Run perl t/db_dependent/Members/statistics.t Depends on PageObject tests and TestObjectFactories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:03:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:03:43 +0000 Subject: [Koha-bugs] [Bug 14719] Regression tests for members/statistics.pl In-Reply-To: <bug-14719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14719-70-hm8fdJvTmt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14719 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:04:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:04:02 +0000 Subject: [Koha-bugs] [Bug 14719] Regression tests for members/statistics.pl In-Reply-To: <bug-14719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14719-70-mikArFwXc1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14719 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14704 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:04:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:04:02 +0000 Subject: [Koha-bugs] [Bug 14704] members/statistics.pl crashes because the SQL 'return'-keyword might be reserved at 'return FROM (' In-Reply-To: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14704-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14704-70-Q7PxgoJgkV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14704 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14719 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:04:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:04:31 +0000 Subject: [Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled In-Reply-To: <bug-14507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14507-70-CSg9dEyDjR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:05:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:05:45 +0000 Subject: [Koha-bugs] [Bug 14719] Regression tests for members/statistics.pl In-Reply-To: <bug-14719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14719-70-qcVFsSwqVL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14719 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14536 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:05:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:05:45 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-synfFXqDuC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14719 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14719 [Bug 14719] Regression tests for members/statistics.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:12:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:12:17 +0000 Subject: [Koha-bugs] [Bug 14720] New: build_holds_queue.pl error Message-ID: <bug-14720-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14720 Bug ID: 14720 Summary: build_holds_queue.pl error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P3 Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz I get this error when I run build_hold_queue.pl: DBD::mysql::st execute failed: Unknown column 'print_status' in 'field list' at /home/putti/kohaclone/C4/HoldsQueue.pm line 288. Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2064. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:28:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:28:47 +0000 Subject: [Koha-bugs] [Bug 14721] New: OAI-PMH must return error when no results Message-ID: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721 Bug ID: 14721 Summary: OAI-PMH must return error when no results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org When getting records from OAI-PMH, an error must be returned if there is no results. See : http://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:28:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:28:55 +0000 Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results In-Reply-To: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14721-70-qi2AH1MAyZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:29:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:29:08 +0000 Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results In-Reply-To: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14721-70-WWFynHOUUj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14664 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:29:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:29:08 +0000 Subject: [Koha-bugs] [Bug 14664] Harvesting records of an non-existent set, instead of an error return all the records In-Reply-To: <bug-14664-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14664-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14664-70-hewPlmUgEm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14664 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14721 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:42:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:42:27 +0000 Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results In-Reply-To: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14721-70-s6zVWWsv3H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721 Christophe Brocquet <christophe.brocquet at obspm.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.brocquet at obspm.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:50:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:50:12 +0000 Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results In-Reply-To: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14721-70-VxbTxUSIE1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 41887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41887&action=edit Bug 14721 - OAI-PMH must return error when no results When getting records from OAI-PMH, an error must be returned if there is no results. See : http://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions Test plan : - Enable OAI webservice - Perform a query that will return no results. ie : /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2099-12-30&until=2099-12-31 => Without patch you get a response with : <ListRecords/> => With patch you get a response with error code : <error code="noRecordsMatch">No records match the given criteria</error> - Check a good query returns still results - Same test with ListIdentifiers verb -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:50:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:50:53 +0000 Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results In-Reply-To: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14721-70-F9wa7Sdgom@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:51:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:51:21 +0000 Subject: [Koha-bugs] [Bug 14721] OAI-PMH must return error when no results In-Reply-To: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14721-70-p31TBciYWj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14721 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 11:56:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 09:56:26 +0000 Subject: [Koha-bugs] [Bug 14722] New: Refactor the export tool Message-ID: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Bug ID: 14722 Summary: Refactor the export tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The export tool (tools/export.pl) is badly designed and can be call from the command line. The part of the code used when called from the command line should be moved to a specific script. The common code must be moved to a package, with tests provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 12:20:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 10:20:41 +0000 Subject: [Koha-bugs] [Bug 12670] Show materials label instead of code In-Reply-To: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12670-70-fa1cM0zfPL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 --- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41888&action=edit Bug 12670: Show materials label in checkin/checkout messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 12:20:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 10:20:53 +0000 Subject: [Koha-bugs] [Bug 12670] Show materials label instead of code In-Reply-To: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12670-70-acXJDI0zlQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12670 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 12:41:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 10:41:30 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14224-70-TKphPvxme9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 12:43:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 10:43:13 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14722-70-wizsWurV5R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 12:43:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 10:43:15 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14722-70-y9xwe5toFO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41889&action=edit Bug 14722: Add Koha::Biblioitem[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 12:43:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 10:43:22 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14722-70-rp1zyTV7wS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41890&action=edit Bug 14722: Refactor the export tool Why a refactoring was need for this script? The export tool (tools/export.pl) can be called from the command line and some parts of code were unnecessarity complicated (just look at the code, you will understand). Worse still, the script does not provide the same options for both interface. For instance you cannot export records given a range of biblionumbers, authids, callnumbers, etc. from the commandline. What does this patch? 1/ Important: The script tools/export.pl does not work anymore if called from the command line (should be in the release notes). 2/ The code used to generated a file (csv, iso2709 or xml) has been moved to a new module (Koha::Exporter::Record) and tests have been provided. 3/ No change is done on the web interface 4/ Some new options have been added to the commandline script (misc/export.pl): - starting_authid - ending_authid - authtype - starting_biblionumber - ending_biblionumber - itemtype - starting_callnumber - ending_callnumber - start_accession - end_accession 5/ There is a change in the behavior if an error occurs: Can't call method "as_usmarc" on an undefined value at Koha/Exporter/Record.pm line 114. record (number 5530) is invalid and therefore not exported because its reopening generates warnings above at Koha/Exporter/Record.pm line 117. Before this patch, they were not displayed (using the command line). What does not do this patch? It does not provide the 'clean', 'timestamp' and 'deleted_barcodes' options to the web interface (same as before). What about the perfs? With a DB with ~800 biblios (MARC21) Before: perl tools/export.pl 14.79s user 0.83s system 71% cpu 21.905 total After: perl misc/export.pl 17.19s user 0.84s system 75% cpu 24.018 total With a DB with ~6400 biblios (UNIMARC) Before: perl tools/export.pl 26.55s user 0.76s system 76% cpu 35.498 total After: perl misc/export.pl 26.78s user 0.84s system 80% cpu 34.494 total How to test this patch? Test plan: A. Web interface: 1/ On the current master, export some records, biblios and authorities (with the 3 differents exports) playing with the different filters (item type, libraries, callnumber, accession date, don't export items, remove non-local items, don't export fields, etc.). 2/ Apply this patch, export again the same records, and compare the generated files. They must be identical! 3/ Confirm that the export features on the checkout list (circ/circulation.pl) works as before this patch. B. The command line 1/ On the current master, export some records, biblios and authorities (with the 2 differents exports) playing with the different options (date, deleted_barcodes, clean). 2/ Apply this patch, export again the same records, and compare the generated files. They must be identical! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 12:43:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 10:43:45 +0000 Subject: [Koha-bugs] [Bug 14709] The export tool is broken if used from the command line In-Reply-To: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14709-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14709-70-3IpCny2dsO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14722 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 [Bug 14722] Refactor the export tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 12:43:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 10:43:45 +0000 Subject: [Koha-bugs] [Bug 14710] Export checkout list exports all item infos In-Reply-To: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14710-70-YwR63nFadR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14722 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 [Bug 14722] Refactor the export tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 12:43:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 10:43:45 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14722-70-pILWuV0gFd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14709, 14710 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14709 [Bug 14709] The export tool is broken if used from the command line http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 [Bug 14710] Export checkout list exports all item infos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:16:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:16:51 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8436-70-UNjppVmkVT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41891&action=edit Bug 8436: Use C4::Context->IsSuperLibrarian() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:17:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:17:28 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8436-70-Hrc8LaFOdQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:02 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-1oXlPu77e5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41809|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41892&action=edit Bug 9809 - DB Updates Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:06 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-9112tqjToA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41810|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41893&action=edit Bug 9809 - Update Schema files Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:10 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-U1Tpfj4VbK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41811|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41894&action=edit Bug 9809 - Remove DBIC module for reserveconstraints Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:13 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-wH1bpwQfhA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41812|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41895&action=edit Bug 9809 - Update unit tests Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:16 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-UwXtb1nyfY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41813|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41896&action=edit Bug 9809 - Remove reserveconstraints references from C4::Reserves Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:23 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-XIQry1ryC3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41849|0 |1 is obsolete| | --- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41898&action=edit Bug 9809: [QA Follow-up] Remove warnings from Hold.pm Resolves two warnings on a uninitialized found column: holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 53., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 holds: Use of uninitialized value in string eq at /home/koha/testclone/Koha/Hold.pm line 74., referer: http://test.rijkskoha.nl:28080/cgi-bin/koha/circ/circulation.pl?borrowernumber=152 Test plan: Run t/db_dependent/Hold.t. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:20 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-ybXuXra6gP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41848|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41897&action=edit Bug 9809 - Update AddReserve prototype to remove constraint parameter Test Plan: 1) Apply this patch set 2) prove t/db_dependent/Circulation.t 3) prove t/db_dependent/Holds.t 4) prove t/db_dependent/Holds/LocalHoldsPriority.t 5) prove t/db_dependent/Holds/RevertWaitingStatus.t 6) prove t/db_dependent/HoldsQueue.t 7) prove t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> AMENDED: An else branch in reserve/placerequest.pl was removed. This had the effect of making it no longer possible to place an any hold in the staff client. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Verified placing a biblio level and an item level hold. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:26 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-AweJ9pVyh2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41850|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41899&action=edit Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:30 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-Tyuwd9lkyK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41851|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41900&action=edit Bug 9809: [QA Follow-up] Remove constrainttype from 14464 tests Some additional unit tests of bug 14464 still included a constraint in the AddReserve calls. Test plan: Run Reserves.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:33 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-WD9AHlB4ks@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41852|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41901&action=edit Bug 9809: [QA Follow-up] Still found some remains In the staff client we had still some remains referring to the constraint types. Also touched one comment line from SIP. Test plan: Add a hold in the staff client. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:36 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-KMyqhATOBo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41902&action=edit Bug 9809: Fix pod errors FAIL C4/Reserves.pm FAIL pod in file C4/Reserves.pm *** ERROR: Spurious =cut command Test plan: perl -e "use Pod::Checker;podchecker('C4/Reserves.pm');" Should not return any errors. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:40 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-1hSt0jMswK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 --- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41903&action=edit Bug 9809: Remove one more occurrence of reserveconstraints This file is not updated, but no need to keep on occurrence of an nonexistent table in it. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:37:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:37:55 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-KVTmg7H3Zw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:48:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:48:30 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-iCZFyijeQh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41787|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41904&action=edit Bug 14337 - Add Unit Tests Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:48:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:48:33 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-9qKEMbbyNE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41788|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41905&action=edit Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability AllowRenewalIfOtherItemsAvailable checks C4::Reserves::IsAvailableForItemLevelRequest to see if the item is holdable, which catches not for loan values less than 0 ( i.e. holdable, but not circ-able ). However, since this feature is about actually checking out items to patrons, we should not count *any* not for loan items when deciding if the available items will satisfy all current holds. Test Plan: 1) Enable AllowRenewalIfOtherItemsAvailable 2) Create a record with two items 3) Check out one item to a patron 4) Ensure the item is renewable 5) Place a hold on the record 6) The item should now be non-renewable 7) Add a second item to the record, but with a not for loan value < 0 8) Note the checkout is still renewable 9) Apply this patch 10) Note the checkout is now non-renewable Works ok. Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:48:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:48:35 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-Kd3tXCMpP1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41906&action=edit Bug 14337: Fix conflict with bug 9809 The reserves.constrainttype does not exist anymore, it has been removed by bug 9809. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:48:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:48:38 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-l4FMYYqcOW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41907&action=edit Bug 14337: Add 2 more tests to be complete Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:48:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:48:56 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-IPwDpXn4Bx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14337 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 13:48:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 11:48:56 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-bR6h8a1S6f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Depends on| |9809 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 [Bug 9809] Get rid of reserveconstraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:00:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:00:20 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-rReWuO3Q4H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #66 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Small bugs in : koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt 1/ Line 20, the closing span tag is missing :  <span>anyone else to add entries. 2/ In [% BLOCK list_permissions %] the permissions vars must be called from "shelf" : [% IF allow_add %] must be [% IF shelf.allow_add %] Idem for allow_delete_own and allow_delete_other 3/ In breadcrumbs, a <li></li> tag has been removed. It was : <li><a href="/cgi-bin/koha/opac-shelves.pl?display=privateshelves">Your lists</a></li> Direct text is not correct inside a <ul></ul>. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:00:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:00:48 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-oQWBmY8nxe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:02:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:02:09 +0000 Subject: [Koha-bugs] [Bug 14458] Add SwaggerUI documentation for RESTful API In-Reply-To: <bug-14458-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14458-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14458-70-GyHI043bmX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14458 --- Comment #8 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41908&action=edit Bug 14458: (follow-up) Add checkbox to optionally disable Authorization-header In case you want to test in SwaggerUI without sending the Authorization-header, there is now a checkbox to optionally disable it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:04:15 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14510-70-VGT32Wed4z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Jesse, This does not work (even without the last patch). To reproduce: hide the first column by default (barcode), save and refresh the add item page. The first column is hidden (in my case 'damaged'). You will have to change the way the feature works. The way it works currently is based on the order of the columns, not the names. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:15:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:15:41 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-xLkEIbRkcI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #67 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41909&action=edit Bug 14544: Fix several minor fixes at the OPAC follow-up for Bug 14544: Remove wrong tips about permissions and Bug 14544: Make the OPAC side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:16:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:16:14 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-V5WOoOqeCO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41909|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41910&action=edit Bug 14544: Fix several minor bugs at the OPAC follow-up for Bug 14544: Remove wrong tips about permissions and Bug 14544: Make the OPAC side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:27:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:27:55 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11999-70-uvBVDh1sf2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:30:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:30:40 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-78v77k7RFV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:31:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:31:50 +0000 Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype In-Reply-To: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14651-70-o0pJITTYNd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:32:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:32:33 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-1iT9DVehx0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 --- Comment #24 from Kyle M Hall <kyle.m.hall at gmail.com> --- Thanks for the followups Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:41:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:41:11 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-5AuVrRVsQ5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #69 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #68) > Created attachment 41910 [details] [review] > Bug 14544: Fix several minor bugs at the OPAC > In breadcrumbs, › must also be inside a <li>. Like in ISBD view : <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li> <li><a href="#">ISBD view</a></li> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:41:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:41:44 +0000 Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype In-Reply-To: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14651-70-AIvAeeA0fc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Tom?s Cohen Arazi from comment #0) > At first sight, it seems clear to me that we should start moving into using > Koha::Item objects, that even provide an ->effective_itemtype method! > > Having talked about this on IRC there seems to be a consensus that if the > item doesn't have an itemtype, then there should be a fallback to > biblio-level itemtype. > > This means we should add that check to the ->effective_itemtype method. But > it would mean including Koha::Biblios. The patches work fine, but aren't we masquerading a problem that should be addressed instead of hidden ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:47:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:47:05 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-wosjmjua6K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #70 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- 4/ I've noticed that when editing a list, the HTML warnings show there are 2 useless ending div tags. I think the correction is : diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt index 245a8dd..e5c40db 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt @@ -705,13 +705,13 @@ <p>No private lists.</p> [% END %] [% END %] + </div> + </div> [% ELSIF NOT loggedinusernumber %] [% IF Koha.Preference( 'opacuserlogin' ) == 1 %] <div class="alert alert-info"><a href="/cgi-bin/koha/opac-user.pl">Log in</a> to create new lists.</div> [% END %] [% END # IF loggedinusername %] - </div> - </div> </div> <!-- / #usershelves --> </div> <!-- / .span10/12 --> </div> <!-- / .row-fluid --> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:50:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:50:26 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-WZBcV48gtR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11493 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:50:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:50:26 +0000 Subject: [Koha-bugs] [Bug 11493] Batch Item Modification not handling unicode characters In-Reply-To: <bug-11493-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11493-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11493-70-dFTezsGKPe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11493 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11247 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:55:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:55:36 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-2tvAHov2v8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 --- Comment #9 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 41911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41911&action=edit Bug 11247: Removed unused params from TransformHtmlToXml() $indicator and $ind_tag should not be TransformHtmlToXml() params. TransformHtmlToXml() is only used for items: - $indicator is always empty - $ind_tag was not even used in the function To test: Check that integrity of following functions is preserved: * Acquisition - ordering and receiving, needs setting AcqCreateItem to placing and receiving an order * Cataloging - create/modify an item * Batcih modify in Tools * Serials receiving -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 14:58:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 12:58:32 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-KdVokYqKX2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22953|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:01:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:01:42 +0000 Subject: [Koha-bugs] [Bug 14634] Warns when placing hold on record with no items In-Reply-To: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14634-70-dAy09i4G7K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:01:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:01:44 +0000 Subject: [Koha-bugs] [Bug 14634] Warns when placing hold on record with no items In-Reply-To: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14634-70-ViKKVZhc5z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41308|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41912&action=edit Bug 14634: Warns when placing hold on record with no items To test: 1) Create a new record in Cataloguing 2) When done, instead of adding an item to the record, click on the Holds tab in the left nav 3) Notice warns 4) Apply patch and refresh page 5) Click on Holds tab again 6) Notice warns are gone and page still works Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Warns disappear; note that the display of the error message is still ugly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:13:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:13:57 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-E0iFcmRPAH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41910|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41913&action=edit Bug 14544: Fix several minor bugs at the OPAC follow-up for Bug 14544: Remove wrong tips about permissions and Bug 14544: Make the OPAC side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:15:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:15:28 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-PtXw4RiXp6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41913|0 |1 is obsolete| | --- Comment #72 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41914&action=edit Bug 14544: Fix several minor bugs at the OPAC follow-up for Bug 14544: Remove wrong tips about permissions and Bug 14544: Make the OPAC side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:24:26 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14722-70-aJFs3cQNEi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:27:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:27:35 +0000 Subject: [Koha-bugs] [Bug 14723] New: Additional delivery notes to messages Message-ID: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Bug ID: 14723 Summary: Additional delivery notes to messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: larit at student.uef.fi QA Contact: testopia at bugs.koha-community.org Currently at message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. Some SMS gateway providers send the customer a report about the status of delivery. For example, in our local library we have a provider that does this. With the SMS HTTP request to their Gateway, we also provide them a "report" parameter that includes an URL. Once the SMS delivery has been finished, they will notify us with the status to the given report URL. If they notify us that the delivery was failed, we will modify its status in the database accordingly. They also provide a short description of why the delivery was failed. To be able to store more detailed information about the delivery, I propose adding a new column (e.g "delivery_notes") to message_queue table. In our local library we sometimes have angry borrowers complaining that they have not received SMS messages, so this type of enhancement would be very useful to be able to find out why such has happened. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:27:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:27:48 +0000 Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl In-Reply-To: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13980-70-FJVo2MLBjO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Could you please give more details, I don't get the error. What values did you choose for the following params? Record matching rule Action if matching record found Action if no match is found and on the next screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:37:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:37:35 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-578YfwgWaT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:46:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:46:21 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-Y5Nxby3SHp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The tests pass even without the first patch. Please provide a patch on top of bug 9809. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:46:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:46:49 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-YcUGoHbIin@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #27) > Please provide a patch on top of bug 9809. Erk, maybe 1 on top for master, and another one for the stable branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:48:06 +0000 Subject: [Koha-bugs] [Bug 14528] Viewing lists fails silently when not having correct permisison In-Reply-To: <bug-14528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14528-70-7wE0VdLcQq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:48:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:48:28 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-nNW4yMXSDd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14528 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:48:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:48:28 +0000 Subject: [Koha-bugs] [Bug 14528] Viewing lists fails silently when not having correct permisison In-Reply-To: <bug-14528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14528-70-vof7MoKdEY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:52:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:52:57 +0000 Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl In-Reply-To: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13980-70-1esbctYHfR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980 --- Comment #4 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Jonathan Druart from comment #3) > Could you please give more details, I don't get the error. > What values did you choose for the following params? > Record matching rule > Action if matching record found > Action if no match is found > > and on the next screen. The error comes most likely if you do as follows: 1. Delete all item records from database / delete the whole database and create it again. 2. Zebra/something leaves indexes there and you can still find the items in search. 3. Now go to cataloguing -> New from Z39.50. 4. Find a same record you have already in Koha (the one that you can find with search but it really isn't there). 5. Import that record. 6. Now I think it says that it has detected a duplicate of the record. 7. Press the button which merges / does something with those duplicates (the button on the left!) The record I experienced this issue was from Z39.50, With a title of "Free running /" and data of "c2013.". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:58:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:58:22 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-CrEcwwyez2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #73 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41915&action=edit Bug 14544: Do not use shelf as a variable loop Otherwise the shelf variable send from the pl script is overwrite -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 15:58:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 13:58:37 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6810-70-QeqfKTRnbm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #80 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 41916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41916&action=edit Bug 6810 - Fix QA failures - remove DateTime->now() - use Koha::DateUtils->dt_from_string; - use Pod2usage for the usage - use Modern::Perl - use branches table - Change letter code from MEMEXP to MEMBERSHIP_EXPIRY - review comments implemented - fix qa script comments Bug 6810 - Fix QA failures - MembershipExpiryDaysNotice system preferences arragned alphabetical order. Bug 6810 - Add sample notices - review comments implemented - default value of is_html field in letter table is 0 Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:03:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:03:35 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-qcLWdNj2OK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41915|0 |1 is obsolete| | --- Comment #74 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41917&action=edit Bug 14544: Do not use shelf as a variable loop Otherwise the shelf variable send from the pl script is overwrite -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:04:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:04:21 +0000 Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl In-Reply-To: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13980-70-BLwkbo3om1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980 --- Comment #5 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Joonas Kylm?l? from comment #4) > (In reply to Jonathan Druart from comment #3) > > Could you please give more details, I don't get the error. > > What values did you choose for the following params? > > Record matching rule > > Action if matching record found > > Action if no match is found > > > > and on the next screen. > > The error comes most likely if you do as follows: > 1. Delete all item records from database / delete the whole database and > create it again. > 2. Zebra/something leaves indexes there and you can still find the items in > search. > 3. Now go to cataloguing -> New from Z39.50. > 4. Find a same record you have already in Koha (the one that you can find > with search but it really isn't there). > 5. Import that record. > 6. Now I think it says that it has detected a duplicate of the record. > 7. Press the button which merges / does something with those duplicates (the > button on the left!) > > The record I experienced this issue was from Z39.50, With a title of "Free > running /" and data of "c2013.". not data, date :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:07:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:07:03 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6810-70-66SwjMk6l3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40766|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:10:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:10:57 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6810-70-IjyRUWlytK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:12:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:12:30 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-Ko7vzTThVf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #75 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41918&action=edit Bug 14544: Fix redirect on editing a list If you edit a list from the list view, after saving the form, you are not redirected to the list view (but on the edit form). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:18:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:18:25 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-WUMLIWFi5E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #76 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41919&action=edit Bug 14544: Cosmetic: › should be a class divider -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:23:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:23:05 +0000 Subject: [Koha-bugs] [Bug 14724] New: Manage Staged MARC Records stuck at 0% on Koha 3.12.04.000 Message-ID: <bug-14724-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14724 Bug ID: 14724 Summary: Manage Staged MARC Records stuck at 0% on Koha 3.12.04.000 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: jesus at medios.es QA Contact: testopia at bugs.koha-community.org Created attachment 41920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41920&action=edit Screenshot job progress stuck at 0% Using no matchig rule while importing a staged batch, the Manage Staged MARC Records gets stuck at 0%. I can see a www-data owned background job running but the browser is stuck at 0% and no entries in the db. Tried leaving it overnight with no progress. Tried with ie and chrome. Same MARC file is imported fine in EOS.web. See attached records (only 8) in MARC21 format causing the issue. See attached screenshot for rules used during this import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:23:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:23:23 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14224-70-x8G0fLdpaj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41801|0 |1 is obsolete| | --- Comment #2 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Created attachment 41921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41921&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summery" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Make sure the branch has an email address specified 4) Check out an item to a patron 5) Log in with the patron you checked out the item for 6) In "your summery", write a message in the new "Note" field for the item checked out. Hit ENTER to save/send. 7) Success message should be seen and an email sent to the email address specified for the branch which the item was checked out from. 8) Log in with staff account and check in the item 9) The note should be shown The note can be changed by the patron at any time while the item is checked out. Each change will send a new email to the branch. Only the latest note version will be shown on check in. Obsoletes: 41801 - Bug 14224: Allow patron notes about item shown at check in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:23:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:23:56 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14224-70-stVqrMGA0T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:24:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:24:37 +0000 Subject: [Koha-bugs] [Bug 14724] Manage Staged MARC Records stuck at 0% on Koha 3.12.04.000 In-Reply-To: <bug-14724-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14724-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14724-70-MHPrJjraMA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14724 --- Comment #1 from jesus at medios.es --- Created attachment 41922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41922&action=edit MARC21 records that cause the issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:31:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:31:45 +0000 Subject: [Koha-bugs] [Bug 14725] New: Searching by Author limited to 245$c on Koha 3.12.04.000 Message-ID: <bug-14725-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14725 Bug ID: 14725 Summary: Searching by Author limited to 245$c on Koha 3.12.04.000 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jesus at medios.es QA Contact: testopia at bugs.koha-community.org Created attachment 41923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41923&action=edit Zebra config files Zebra does not return matching records on 7xx or 1xx when searching Author. It returns only bibs with the search term in 245$c. I checked Zebra config files with no relevant info. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:33:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:33:01 +0000 Subject: [Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. In-Reply-To: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14640-70-julcIKjNjV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640 --- Comment #1 from Kyle M Hall <kyle.m.hall at gmail.com> --- First, I want to point out there are two different pieces of code that handle similar situations, first is where a librarian attempts to check out a book on hold and *waiting* for a different patron. When this happens, Koha will offer to cancel or revert the waiting hold. This feature works correctly. This bug is dealing with the situation where an item is checked out to a patron that is not the next in line hold-wise for an item. In this case, Koha will warn the librarian that there are holds on the item and show the first person in line. Again, I want to stress that this is the case where the item *is not waiting* for a patron. The hold for the patron listed will just have a priority of 1. The only situation where the "Cancel hold" checkbox will function is when the priority 1 hold is an item level hold. This is due to the fact that CancelReserve is being passed the trio of biblionumber, borrowernumber, and itemnumber rather than the singular reserve_id. The call stack is as such: AddIssue MoveReserve ( here is where CancelReserve should be called using reserve_id ) CancelReserve -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:33:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:33:03 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-yJFcBQpIWl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #77 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41924&action=edit Bug 14544: Fix regression: checkboxes'values are empty They should be filled with the biblionumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:35:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:35:14 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-LzcMs0AYfY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #267 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41925&action=edit Bug 7143: Add Benjamin Rokseth to the projects history file and about page Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:37:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:37:43 +0000 Subject: [Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. In-Reply-To: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14640-70-xUmMy0gBLV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:37:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:37:45 +0000 Subject: [Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. In-Reply-To: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14640-70-Pn1YUGdXfR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41926&action=edit Bug 14640 - 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. This bug is dealing with the situation where an item is checked out to a patron that is not the next in line hold-wise for an item. In this case, Koha will warn the librarian that there are holds on the item and show the first person in line. Again, I want to stress that this is the case where the item *is not waiting* for a patron. The hold for the patron listed will just have a priority of 1. The only situation where the "Cancel hold" checkbox will function is when the priority 1 hold is an item level hold. This is due to the fact that CancelReserve is being passed the trio of biblionumber, borrowernumber, and itemnumber rather than the singular reserve_id. 1) place biblio level hold on a book to borrower A. 2) check out an item of the book to borrower B. 3) When confirming checkout, check the 'Cancel hold' check-box, and click the "Yes, check out" button. 4) Note the hold was not canceled 5) Apply this patch 6) Repeat steps 1 through 3 7) Note the hold was indeed canceled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:37:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:37:59 +0000 Subject: [Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. In-Reply-To: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14640-70-1qjB2reSFA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:41:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:41:10 +0000 Subject: [Koha-bugs] [Bug 6508] Enhancement: Additional Information on the Fines & Charges Tab in the Patron Details of Staff Client In-Reply-To: <bug-6508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6508-70-g5F3Vf41h7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- In the checkout page there is for example the message: Attention: Fees & Charges: Patron has Outstanding fees & charges of 2.00. <Make payment> This message can vary if there is some other information which might prevent the checkout. I propose that we include that same thing to the page Details (maybe under the alternate address info). I looked into this already but it looked difficult to implement because at the moment there is no abstraction in the code which serves the Check out page. And the solution which I see as doable in a short period of time (4 hours) is to just copy paste the code from circulation.pl. Otherwise it could take day(s) to refactor circulation.pl to use some generic functions to get the info. And then after that do the code which shows the info in the Details page... Refactoring is what I would go with but... We will see. I like also the idea of having the red indication in the fines tab and it could also have the amount owed in the title. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:42:35 +0000 Subject: [Koha-bugs] [Bug 14724] Manage Staged MARC Records stuck at 0% on Koha 3.12.04.000 In-Reply-To: <bug-14724-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14724-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14724-70-ONDGUsrqgz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14724 --- Comment #2 from jesus at medios.es --- Bulk-importing the records cause these errors: kobli at especializadas:/home/www/kobli/bin/migration_tools$ ./bulkmarcimport.pl -b -v -file=./koha.8.records.stuck.mrc .Use of uninitialized value $biblionumber in concatenation (.) or string at ./bulkmarcimport.pl line 382, <GEN13> line 1. ERROR: Adding biblio failed: Can't call method "field" on an undefined value at /home/www/kobli/lib/C4/Biblio.pm line 3736, <GEN13> line 1. .Use of uninitialized value $biblionumber in concatenation (.) or string at ./bulkmarcimport.pl line 382, <GEN13> line 2. ERROR: Adding biblio failed: Can't call method "field" on an undefined value at /home/www/kobli/lib/C4/Biblio.pm line 3736, <GEN13> line 2. .Use of uninitialized value $biblionumber in concatenation (.) or string at ./bulkmarcimport.pl line 382, <GEN13> line 3. ERROR: Adding biblio failed: Can't call method "field" on an undefined value at /home/www/kobli/lib/C4/Biblio.pm line 3736, <GEN13> line 3. .Use of uninitialized value $biblionumber in concatenation (.) or string at ./bulkmarcimport.pl line 382, <GEN13> line 4. ERROR: Adding biblio failed: Can't call method "field" on an undefined value at /home/www/kobli/lib/C4/Biblio.pm line 3736, <GEN13> line 4. .Use of uninitialized value $biblionumber in concatenation (.) or string at ./bulkmarcimport.pl line 382, <GEN13> line 5. ERROR: Adding biblio failed: Can't call method "field" on an undefined value at /home/www/kobli/lib/C4/Biblio.pm line 3736, <GEN13> line 5. .Use of uninitialized value $biblionumber in concatenation (.) or string at ./bulkmarcimport.pl line 382, <GEN13> line 6. ERROR: Adding biblio failed: Can't call method "field" on an undefined value at /home/www/kobli/lib/C4/Biblio.pm line 3736, <GEN13> line 6. .Use of uninitialized value $biblionumber in concatenation (.) or string at ./bulkmarcimport.pl line 382, <GEN13> line 7. ERROR: Adding biblio failed: Can't call method "field" on an undefined value at /home/www/kobli/lib/C4/Biblio.pm line 3736, <GEN13> line 7. .Use of uninitialized value $biblionumber in concatenation (.) or string at ./bulkmarcimport.pl line 382, <GEN13> line 8. ERROR: Adding biblio failed: Can't call method "field" on an undefined value at /home/www/kobli/lib/C4/Biblio.pm line 3736, <GEN13> line 8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:52:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:52:59 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-QlSa7jwvVF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #27) > The tests pass even without the first patch. > > Please provide a patch on top of bug 9809. > > Marked as Failed QA. The test 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' fails on master with the default sample data. It passes with the first patch applied. The other new unit tests are just testing existing functionality, so they *should* pass on master. If you are finding that the test 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' passes for you without the main patch, I would suggest testing it on a fresh database with the sample data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:53:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:53:28 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-N6uzF02Axj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41927&action=edit Bug 14544: Pass the itemtype description and notforloan to the template Before it was returned by GetShelfContents and the join on itemtype. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:53:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:53:28 +0000 Subject: [Koha-bugs] [Bug 14726] New: Title not showing up on checkout summary Message-ID: <bug-14726-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726 Bug ID: 14726 Summary: Title not showing up on checkout summary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When doing a checkout, there's normally a summary just below the blue block, with something like Checked out: Some Title (32154001669305). Due on 24/09/2015 Since the move to Schemas, this doesn't show anymore. This is caused by the line in circulation.tt [% IF ( issue ) %] <div class="lastchecked"> <p><strong>Checked out: </strong>[% issue.item.biblio.title %] ([% issue.item.barcode %]). Due on [% issue.date_due | $KohaDates %]</p> </div> [% END %] issue.item.biblio.title does not resolve. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:54:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:54:03 +0000 Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary In-Reply-To: <bug-14726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14726-70-8uHy2HZZnX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726 Blou <philippe.blouin at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:54:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:54:22 +0000 Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary In-Reply-To: <bug-14726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14726-70-qHCDNO1ON8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726 Blou <philippe.blouin at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:54:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:54:28 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-nWubKfowFw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #30 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #28) > (In reply to Jonathan Druart from comment #27) > > Please provide a patch on top of bug 9809. > > Erk, maybe 1 on top for master, and another one for the stable branches. Once 9809 is pushed to master, and this has passed qa, I will submit separate unit tests to update this patch set for master and retain the current unit tests patch for backporting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:57:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:57:32 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-0FMFDBdsFt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41868|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41928&action=edit [PASSED QA] Bug 14714: Add tab-completion to koha-mysql command This patch introduces tab-completion in bash to the koha-mysql command. It completes using valid instance names. It stops completing once an instance name is chosen (i.e. it respects the fact that koha-mysql accepts only one instance name as parameter). To test: - Have a packages install (kohadevbox works) - Run: $ . debian/koha-common.bash-completion - Type koha-mysql <tab> => SUCCESS: You are prompted valid instance names for completion. - Sign off :-D Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:57:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:57:30 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-6GgQqBNzIH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:57:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:57:41 +0000 Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl In-Reply-To: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13980-70-wKjUfkSKsd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I should have read the description of the bug... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:59:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:59:01 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-byOqYfyVRl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41323|0 |1 is obsolete| | --- Comment #268 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41929&action=edit [SIGNED OFF] Bug 7143: spaces in history.txt instead of tabs break display on website This may be the only place in koha where a tab should be a tab and not 4 spaces. I'll try to fix the script that does the conversion for the website to handle 4 spaces instead of tabs, but for now can we have this? Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:59:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:59:14 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-VFSs3FJBZO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41925|0 |1 is obsolete| | --- Comment #269 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41930&action=edit [SIGNED OFF] Bug 7143: Add Benjamin Rokseth to the projects history file and about page Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 16:59:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 14:59:57 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-LHcmrRvJlR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:00:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:00:05 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-Zy5EKfrsrg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:00:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:00:14 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-1DnQ36wZY4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:04:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:04:14 +0000 Subject: [Koha-bugs] [Bug 8797] can't delete quote of the day In-Reply-To: <bug-8797-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8797-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8797-70-vXNXcHdXJE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #8 from Joonas Kylm?l? <j.kylmala at gmail.com> --- At the moment there comes only the following JS error if deleting an quote: TypeError: this.oApi._fnServerParams is not a function. Line 12 in /intranet-tmpl/lib/jquery/plugins/dataTables.fnReloadAjax.js. I'm trying to figure out an fix for that and after that I'll also look into this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:04:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:04:29 +0000 Subject: [Koha-bugs] [Bug 8797] can't delete quote of the day In-Reply-To: <bug-8797-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8797-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8797-70-cvzGjiNSsh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |j.kylmala at gmail.com |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:09:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:09:33 +0000 Subject: [Koha-bugs] [Bug 14710] Export checkout list exports all item infos In-Reply-To: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14710-70-3QYlsGiZ4f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 --- Comment #4 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- (In reply to Jonathan Druart from comment #3) > > Sponsored-by: Universidad de El Salvador > > Hum, this does not seem to be at the correct place :) Where to place? or I need an institutional email to appear in the credits when released? Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:10:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:10:02 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-doFFl5uXIj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #79 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41931&action=edit Bug 14544: Allow a user to delete his own contents -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:10:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:10:06 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-s3G9D0IwgV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #80 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41932&action=edit Bug 14544: Remove warnings in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:16:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:16:42 +0000 Subject: [Koha-bugs] [Bug 14727] New: koha-indexer tab completion in bash Message-ID: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Bug ID: 14727 Summary: koha-indexer tab completion in bash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz The koha-indexer script should provide tab-completion in bash, as other scripts do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:16:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:16:52 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-SCNZeMV8sx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14727 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 [Bug 14727] koha-indexer tab completion in bash -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:16:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:16:52 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14727-70-gIqsHHxOMg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14714 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 [Bug 14714] koha-mysql tab-completion in bash -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:16:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:16:56 +0000 Subject: [Koha-bugs] [Bug 11894] Funds toolbar menu items greyed out without explanation In-Reply-To: <bug-11894-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11894-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11894-70-rbUsG1ogTK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11894 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- What are some circumstances? User not having right permissions? I think greying out and disabling the items is good thing because then with that info the user knows that she/he cannot access that.. but maybe and mouse hoover message would be great in that situation, as you mentioned about showing an explanation. I didn't reproduce this bug myself because I'm not familiar with the accounting tools and I don't know what you mean by some circumstances.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:16:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:16:56 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14727-70-IR3wuS5BjG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:21:02 +0000 Subject: [Koha-bugs] [Bug 11943] AcceptShare should check for double accepts In-Reply-To: <bug-11943-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11943-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11943-70-pV22XOvL8Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- What's the status with this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:22:05 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14727-70-Ge6YnFce5G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:22:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:22:08 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14727-70-QvRDAXMjuX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 41933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41933&action=edit Bug 14727: koha-indexer tab completion in bash This patch introduces tab-completion in bash to the koha-indexer command. It completes using valid option switches and instance names. It stops completing then -h or --help are issued, and once a command switch is chosen (either --start, --stop or --restart) it goes ahead with valid instances completion. To test: - Have a packages install (kohadevbox works) - Run: $ . debian/koha-common.bash-completion - Type koha-indexer <tab> - Play with all the options => SUCCESS: They work as they should. - Sign off :-D Note: it fixes a small glitch on the plack completion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:22:28 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14727-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14727-70-QMj9Knmfqt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:31:38 +0000 Subject: [Koha-bugs] [Bug 14710] Export checkout list exports all item infos In-Reply-To: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14710-70-E7YTTeE7bz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to H?ctor Eduardo Castro Avalos from comment #4) > (In reply to Jonathan Druart from comment #3) > > > Sponsored-by: Universidad de El Salvador > > > > Hum, this does not seem to be at the correct place :) > > Where to place? or I need an institutional email to appear in the credits > when released? > > Regards The 'Sponsored-by' only applies for patches generated by the sponsor, not for signers. The RM cans add your institution in the release notes, if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:38:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:38:21 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-47sAo67MIF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:38:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:38:24 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-X4VI03tc0r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41798|0 |1 is obsolete| | Attachment #41858|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41934&action=edit Bug 12632 - Hold limits ignored for record level holds with item level itemtypes The crux of the issue is that if you are using item level itemtypes, but are allowing biblio levels holds, those holds do not have items. So, in CanItemBeReserved, when Koha counts the number of holds to compare against the given rule, it will always give 0 ( except of course for found holds, and the occasional item-level hold ). So the query is saying "link each of these reserves to the reserved item, and count the number of reserves this patron where the itemtype is DVD". However, since these are all record level reserves, there are no items to link to, and so when it looks for all reserves this and item whose itemtype is DVD, it finds zero reserves! This patch solves the problem by looking first at the item level itemtype, and if it does not exist, then it looks at the record level itemtype. For installations using record level itemtypes, the behavior remains unchanged. Test plan: 1) Enable item level itemtypes 2) Create two records with one item each of a given itemtype 3) Create a single issuing rule and limit the holds allowed for that itemtype to 1 4) Place a record level hold on your first record 5) Attempt to place a record level hold for the same patron on your second record. You should not be able to but you can! 6) Apply this patch 7) Repeat step 5, note you can no longer place the hold! Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:38:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:38:32 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-xCBMCSi33u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41935&action=edit Bug 12632 - Unit Tests Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:39:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:39:02 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-F86bswfymg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- RM: Do not push this patch after bug 9809 as it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 17:42:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 15:42:17 +0000 Subject: [Koha-bugs] [Bug 13980] Can't call method "fields" on an undefined value at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl In-Reply-To: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13980-70-IO4FfYxnOj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13980 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am not sure it's relevant. The Zebra index is supposed to be up-to-date, the indexer processes the zebraqueue every minute. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:11:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:11:34 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-W5tEvxPW7S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- A bit late to be sure there is no regression, but everything looks good. Just some minor notes: > t/db_dependent/BiblioObject.t I would prefer a better filename, but nothing in mind to suggest. > +my $field_mappings = Koha::Database->new()->schema()->resultset('Fieldmapping'); Could be better to have a Koha::Fieldmapping[s] > - waiting_count => $wcount, This variable is still used in the template. > + WAITING => $reserves->waiting() Why not remove this one and access to the waiting holds using RESERVES.waiting in the template? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:32:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:32:31 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-1eb5DRLfTZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41822|0 |1 is obsolete| | Attachment #41823|0 |1 is obsolete| | Attachment #41824|0 |1 is obsolete| | Attachment #41825|0 |1 is obsolete| | Attachment #41826|0 |1 is obsolete| | Attachment #41827|0 |1 is obsolete| | Attachment #41828|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41936&action=edit Bug 9468: make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Amended patch: Remove OPAC prog file Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:32:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:32:28 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-VR1C1c7yvE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:32:36 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-b9iXYkuIxR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41937&action=edit Bug 9468: define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:32:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:32:41 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-X8O0kRWXwv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41938&action=edit Bug 9468: use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:32:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:32:45 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-tkatCKgDki@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41939&action=edit Bug 9468: sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:32:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:32:50 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-cJm6pwHKqj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #51 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41940&action=edit Bug 9468 [QA Followup] Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:32:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:32:55 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-GcK033aT0x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41941&action=edit Bug 9468: followup insert ignore Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:33:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:33:00 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-8kKhhfqPi7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41942&action=edit Bug 9468 [QA Followup] - Remove GetSupportList dependency from updatadatabase.pl Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:33:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:33:04 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-uRBmJcW1IP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41943&action=edit Bug 9468: Fix syntax error in updatedb Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:34:07 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9468-70-op2nyTqcJA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #55 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #54) > Created attachment 41943 [details] [review] > Bug 9468: Fix syntax error in updatedb > > Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Thanks for the followup Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:35:00 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-Dp9AsQDv9n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12632 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 [Bug 12632] Hold limits ignored for record level holds with item level itemtypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:35:00 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-ZXEydhhiBG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9809 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 [Bug 9809] Get rid of reserveconstraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:37:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:37:50 +0000 Subject: [Koha-bugs] [Bug 14710] Export checkout list exports all item infos In-Reply-To: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14710-70-TqcfJyVp38@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14710 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41869|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- Created attachment 41944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41944&action=edit [SIGNED-OFF]Bug 14710: Make the export checkout list export only the checked out item infos This has been introduced by bug 11703. Bug 13190 should have been fixed it. If the pref ExportWithCsvProfile is defined with a MARC CSV profile and it contains item infos to display, only info from the checked out item should be displayed. Test plan: 0/ Don't apply this patch 1/ Create a biblio with 1+ items 2/ Check one of the item out to a patron 3/ Define a CSV profile which contains item fields ("245$a|952$p" for instance) 4/ Export the item (from circ/circulation/pl) using the CSV option Note that the csv contains the barcode from all items 5/ Apply this patch and repeat 4. 6/ Note that the csv contains only the barcode from the checked out item. Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:37:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:37:56 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-F1vIT2aqQG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9809 | --- Comment #34 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #33) > RM: Do not push this patch after bug 9809 as it! Jonathan, I've been looking at the tests and code, and I don't think this bug conflicts with 9809. With this on top of 9809 the tests still pass and fail correctly just like they do without 9809. The unit tests don't create any new holds, so they are unaffected by the changes made my 9809. Can you confirm this? Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 [Bug 9809] Get rid of reserveconstraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:37:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:37:56 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-459igApNil@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12632 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 [Bug 12632] Hold limits ignored for record level holds with item level itemtypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:48:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:48:22 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-rgh0C0HsuY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40035|0 |1 is obsolete| | Attachment #41862|0 |1 is obsolete| | Attachment #41863|0 |1 is obsolete| | Attachment #41865|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41945&action=edit Bug 13918 - Add waiting expiration date to opac list of holds for user Waiting holds for patrons in the opac should display the hold expiration date based on the max pickup delay if it is set. Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Check in the item, use it to fill the hold 4) Log into the opac as that user 5) View the holds list, note the 'until <date>' addition to the waiting hold line. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS at ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki at mplmain.mtpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:48:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:48:29 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-Zy6acgRQ0b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41946&action=edit Bug 13918 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:48:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:48:31 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-0avaIdhvTF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41947&action=edit Bug 13918 [QA Followup] - Remove reserves_count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 18:48:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 16:48:34 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-g2N1SkYBnL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41948&action=edit Bug 13918 [QA Followup] - Improve $biblio->subtitles() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 19:12:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 17:12:45 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-RzXZBEHwx4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #34) > (In reply to Jonathan Druart from comment #33) > > RM: Do not push this patch after bug 9809 as it! > > Jonathan, I've been looking at the tests and code, and I don't think this > bug conflicts with 9809. With this on top of 9809 the tests still pass and > fail correctly just like they do without 9809. The unit tests don't create > any new holds, so they are unaffected by the changes made my 9809. > > Can you confirm this? Yes it is :) +my $res_id = AddReserve( $branch, $borrowernumbers[0], $bibnum, 'a', '', 1, ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 19:26:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 17:26:52 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7187-70-lL0LVRh9rS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Brendan Gallagher <brendan at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #34 from Brendan Gallagher <brendan at bywatersolutions.com> --- Has this been submitted on another bug? I just looked at the git repo and haven't seen an update in awhile. Thanks, Brendan (In reply to Chris Cormack from comment #33) > This is being tested by clients, you can (as always) see the work on the > catalyst repo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 19:43:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 17:43:07 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7187-70-tqh6gZvD5W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:24:26 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable. In-Reply-To: <bug-14708-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14708-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14708-70-EJQeXt8MUz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:24:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:24:54 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-PweWpmKuWg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #1 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Created attachment 41949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41949&action=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:25:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:25:19 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-D8QIcd88M7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:26:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:26:12 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-pqR4K7ufES@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:30:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:30:19 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: <bug-14048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14048-70-tEjRaLebxC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Karl Holten <kholten at switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:46:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:46:49 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-Thri0ZJSYr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #36 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #35) > (In reply to Kyle M Hall from comment #34) > > (In reply to Jonathan Druart from comment #33) > > > RM: Do not push this patch after bug 9809 as it! > > > > Jonathan, I've been looking at the tests and code, and I don't think this > > bug conflicts with 9809. With this on top of 9809 the tests still pass and > > fail correctly just like they do without 9809. The unit tests don't create > > any new holds, so they are unaffected by the changes made my 9809. > > > > Can you confirm this? > > Yes it is :) > > +my $res_id = AddReserve( $branch, $borrowernumbers[0], $bibnum, 'a', '', 1, > ); Thanks Jonathan! I totally missed that. As I'm typing this I realized it only worked for me because I didn't run updatedatabase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:47:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:47:21 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-66tqPVq8mE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12632 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 [Bug 12632] Hold limits ignored for record level holds with item level itemtypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:47:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:47:21 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-7UT0Ik7Y8E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9809 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 [Bug 9809] Get rid of reserveconstraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:49:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:49:27 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-xseZoYGbjl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41935|Bug 12632 - Unit Tests |Bug 12632 - Unit Tests [For description| |Backporting] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:53:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:53:15 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-EsaDUslqgY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41950&action=edit Bug 12632 - Unit Tests Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 20:53:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 18:53:34 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-pj4pYPDzVZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41950|Bug 12632 - Unit Tests |Bug 12632 - Unit Tests [For description| |Master] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 21:08:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 19:08:04 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-E1z31jzfxh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #10 from M. Tompsett <mtompset at hotmail.com> --- I have put this to 'In Discussion', since srdjan at catalyst.net.nz hasn't responded to the comments made in comments #6, #7, and #8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 21:23:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 19:23:20 +0000 Subject: [Koha-bugs] [Bug 14700] batch_id is not correctly populated on patron card creation In-Reply-To: <bug-14700-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14700-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14700-70-uQX8yBePUi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14700 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |minor Assignee|cnighswonger at foundations.ed |barton at bywatersolutions.com |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 21:43:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 19:43:32 +0000 Subject: [Koha-bugs] [Bug 14700] batch_id is not correctly populated on patron card creation In-Reply-To: <bug-14700-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14700-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14700-70-CaDOKfj8fO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14700 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 21:47:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 19:47:10 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: <bug-14642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14642-70-RW0Equ8Ldn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 21:50:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 19:50:54 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: <bug-14642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14642-70-7BOIaXyXl9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 --- Comment #2 from Heather Braum <hbraum at nekls.org> --- I agree -- suspending/unsuspending. I think this is a really good start to help troubleshoot better when something with holds go awry, esp in high-hold and/or multi-branch environments. I'm sure there's more things to add, but this is a great start. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 22:03:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 20:03:12 +0000 Subject: [Koha-bugs] [Bug 14123] Patroncard: Patron search for batch no longer has Select / Select All / Add selected In-Reply-To: <bug-14123-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14123-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14123-70-Eh30i8lZNN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 Shane Sammons <ssammons at npelem.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.20 CC| |ssammons at npelem.com --- Comment #4 from Shane Sammons <ssammons at npelem.com> --- I think this is related, so I am adding my comment here. Maybe it is unique to my install. Patron's Batches can only have a single patron added when making a new "batch". Clicking the "Add" text next to a name keeps placing it behind the pop-up, but replacing the previously clicked user. Should you add someone, then click "manage batches" on the left and edit the batch. You are able to add users via the pop-up and "Add" text. If you had clicked many users while creating, a new batch was made for each one with a single entry in each batch that you can now edit. Another thing I wanted to add, as it might be related to this bug, is when we do edit batch and tried adding anyone with an apostrophe (like O'Leary) in the name would not add at all. This could be unique to me, as we went from 3.12 -> 3.20 so many changes on the files. If so feel free to ignore this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 25 23:30:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 21:30:45 +0000 Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded. In-Reply-To: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13812-70-Uwg9VF7qE6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 01:32:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Aug 2015 23:32:45 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-n6bfrE4Lyp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 --- Comment #11 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- (In reply to M. Tompsett from comment #10) > I have put this to 'In Discussion', since srdjan at catalyst.net.nz hasn't > responded to the comments made in comments #6, #7, and #8. Sorry, I did not know what to do with it. My intention was to correct something that I found obviusly wrong when doing some other work. I did not want to go into changing the way things work. I'm happy for this to be dropped, but the fact stays that the code as it is now is wrong. It works just because it is being called in particular way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 03:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 01:15:49 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-vchAQX29RA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 --- Comment #12 from M. Tompsett <mtompset at hotmail.com> --- I'm not sure indicators are working properly in all contexts, but I don't have the time nor energy to test. *sigh* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 03:57:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 01:57:41 +0000 Subject: [Koha-bugs] [Bug 14728] New: ignore warning for rest of session Message-ID: <bug-14728-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14728 Bug ID: 14728 Summary: ignore warning for rest of session Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nicole at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice if there was an option to 'ignore warning' for the rest of the session when on a patron record and checking out. For example if you have it set to warn you that the patron owes money it will do it over and over for each item you check out and that's a bit annoying. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 03:58:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 01:58:44 +0000 Subject: [Koha-bugs] [Bug 14729] New: circ rule for number of on shelf holds allowed Message-ID: <bug-14729-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14729 Bug ID: 14729 Summary: circ rule for number of on shelf holds allowed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nicole at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Would be nice to limit the number of on shelf holds allowed - so another option to the circ matrix for how many on shelf holds are allowed per patron/item type. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 03:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 01:59:44 +0000 Subject: [Koha-bugs] [Bug 14730] New: let patrons upload their own images Message-ID: <bug-14730-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14730 Bug ID: 14730 Summary: let patrons upload their own images Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nicole at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice if patrons could upload their own images - of course these would need to go in to moderation of some sort and have a switch to turn this option on/off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 08:24:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 06:24:17 +0000 Subject: [Koha-bugs] [Bug 14730] let patrons upload their own images In-Reply-To: <bug-14730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14730-70-QHDeebVWDq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14730 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- On top of bug 14321 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 08:37:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 06:37:50 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-TS4zTrg5kn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #6 from Robin Sheat <robin at catalyst.net.nz> --- (In reply to Robin Sheat from comment #5) > This is working. It's currently visible at > http://elasticsearch.koha.catalystdemo.net.nz/cgi-bin/koha/opac-browse.pl > though it may not stay there for too long. > > The patches attached are intended to be applied on top of the elasticsearch > branch, they won't work without it. I've put a more permanent version at http://browse.koha.catalystdemo.net.nz/cgi-bin/koha/opac-browse.pl It's sharing a database (though not an ES index) with the elasticsearch demo, though I've cherrypicked the schema changes over to prevent things getting too weird. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 08:38:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 06:38:17 +0000 Subject: [Koha-bugs] [Bug 6383] itemnumber not stored when a lost item is returned and credited to account In-Reply-To: <bug-6383-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6383-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6383-70-MdZLkdTgq3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6383 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Do you know which code does the crediting of the patron when the item is found? I couldn't find it... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 09:33:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 07:33:28 +0000 Subject: [Koha-bugs] [Bug 14731] New: Sip2 not use Patron Attributes Message-ID: <bug-14731-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14731 Bug ID: 14731 Summary: Sip2 not use Patron Attributes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: ugurbulgan at sdu.edu.tr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com On KOHA when performing check out operations we can make the check out process possible via the user authentication from card number, user id and patron attributes informations. But on SIP2 the user authentication can only be made with the card number and user id. Is it possible to do user authentication with user id on SIP2 as well? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 09:33:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 07:33:51 +0000 Subject: [Koha-bugs] [Bug 14731] Sip2 not use Patron Attributes In-Reply-To: <bug-14731-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14731-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14731-70-JmNsdNFh20@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14731 U?ur Bulgan <ugurbulgan at sdu.edu.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ugurbulgan at sdu.edu.tr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 09:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 07:38:10 +0000 Subject: [Koha-bugs] [Bug 14731] Sip2 unavailable Patron Attributes In-Reply-To: <bug-14731-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14731-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14731-70-6H3oQpft5S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14731 U?ur Bulgan <ugurbulgan at sdu.edu.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sip2 not use Patron |Sip2 unavailable Patron |Attributes |Attributes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 10:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 08:04:18 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11999-70-FnLtSJajnZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36630|0 |1 is obsolete| | --- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41951&action=edit Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 10:04:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 08:04:29 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11999-70-Y3WSBrq82F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38397|0 |1 is obsolete| | --- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 41952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41952&action=edit Bug 11999: Check for age restriction in CanBookBeReserved Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 10:04:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 08:04:54 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11999-70-jSa6xFaD0v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 10:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 08:15:49 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-PoBnexa9wb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #81 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- New day, new bug :D The creation of a new list after selecting some records fails : It is because after creating Koha::Virtualshelf->new, one must call store() so that it impacts database, used by AddBibliosToShelf(). diff --git a/opac/opac-addbybiblionumber.pl b/opac/opac-addbybiblionumber.pl index 10420fe..9181efd 100755 --- a/opac/opac-addbybiblionumber.pl +++ b/opac/opac-addbybiblionumber.pl @@ -106,7 +106,8 @@ sub HandleNewVirtualShelf { $errcode = 1; return; } - AddBibliosToShelf($shelfnumber, @biblionumber); + $shelf->store(); + AddBibliosToShelf($shelf->shelfnumber, @biblionumber); #Reload the page where you came from print $query->header; print "<html><meta http-equiv=\"refresh\" content=\"0\" /><body onload=\"window.opener.location.reload(true);self.close();\"></body></html>"; Idem on staff interface. You may also allow AddBibliosToShelf() to get a shelf object or a shelnumber as first argument. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 10:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 08:21:02 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: <bug-11250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11250-70-LJzZLflUWb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #6 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to M. Tompsett from comment #4) > There is a difference between none_available (but eventually some may) vs. > comment #2's "{item} is not allowed to be placed on hold". Is there a way to > check for this? What do you mean with this paragraph? I didn't understand it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 11:10:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 09:10:45 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-8TqcbFTNeb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #13 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Tried to test the patches but got the following: Applying: Bug 14702: Refactor GetReserveFee fatal: sha1 information is lacking or useless (C4/Reserves.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 14702: Refactor GetReserveFee Looks like some commits are missing from the master. Are you able to fix this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 11:45:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 09:45:31 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: <bug-14242-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14242-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14242-70-wtn4Vt1lxo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |martin at bugs.koha-community. | |org.xinxidi.net CC| |martin at bugs.koha-community. | |org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 12:00:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 10:00:08 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-QgDO47g60n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #82 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Typo in "Bug 14544: Fix several minor bugs at the OPAC" : [% IF op != 'list' %] <li><a href="/cgi-bin/koha/cgi-bin/koha/opac-shelves.pl">Lists</a></li> [% ELSE %] /cgi-bin/koha twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 12:18:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 10:18:56 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-MqnouYiq7N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #83 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- 3/ Share some lists with other users Note that it is managed by syspref OpacAllowSharingPrivateLists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 13:05:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 11:05:56 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-TQSpi4bUHE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Joonas Kylm?l? from comment #13) > Tried to test the patches but got the following: > > Applying: Bug 14702: Refactor GetReserveFee > fatal: sha1 information is lacking or useless (C4/Reserves.pm). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 14702: Refactor GetReserveFee > > Looks like some commits are missing from the master. Are you able to fix > this? Joonas, Did you see that this depends on bug 9809? So you should apply those first.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 13:07:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 11:07:09 +0000 Subject: [Koha-bugs] [Bug 14732] New: Search patrons and add selected patrons to a new list gives an error Message-ID: <bug-14732-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14732 Bug ID: 14732 Summary: Search patrons and add selected patrons to a new list gives an error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P3 Component: Lists Assignee: gmcharlt at gmail.com Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Steps to reproduce this bug which disables the ability to create new list: 1. Search for patrons in staff side. 2. Select one or more patrons from the list. 3. Next to the text "Add selected patrons to:" choose [ New list ]. 4. Give that list a name. 5. Click save and notice the alert "an error occurred". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 13:11:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 11:11:19 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-CjehQK4Lty@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #15 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Marcel de Rooy from comment #14) > Joonas, > Did you see that this depends on bug 9809? So you should apply those first.. Didn't even know that there was that kind of an attribute in Bugzilla! Works now, thanks. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 13:11:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 11:11:54 +0000 Subject: [Koha-bugs] [Bug 11943] AcceptShare should check for double accepts In-Reply-To: <bug-11943-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11943-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11943-70-mpQXNbIqnM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Joonas Kylm?l? from comment #1) > What's the status with this bug? There is a report now that rewrites a lot of lists code. After that we can verify if this problem is still possible. (Probably..) See bug 14544.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 13:30:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 11:30:52 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11999-70-n0vSMvYjYQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14362 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 13:30:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 11:30:52 +0000 Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails In-Reply-To: <bug-14362-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14362-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14362-70-rafa2YQe2d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11999 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 13:31:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 11:31:42 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11999-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11999-70-gECMeAccID@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #29 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Katrin Fischer from comment #23) > This seems to break one of the existing tests, please check: > > not ok 52 - Reserving a 'PEGI 16' Biblio by a 15 year old borrower fails > # Failed test 'Reserving a 'PEGI 16' Biblio by a 15 year old borrower > fails' > # at t/db_dependent/Reserves.t line 498. > # got: 'none_available' > # expected: 'ageRestricted' > ok 53 - Reserving a 'PEGI 16' Biblio by a 30 year old borrower succeeds > # Looks like you failed 1 test of 53. > > Please also include a short explanation in your new tests: > > ok 35 - cannot request item if policy that matches on bib-level item type > forbids it (bug 9532) > ok 36 > ok 37 > ok 38 > ok 39 - Waiting reserve beyond max pickup delay *not* canceled on holiday You ran it at the magical failure hour for your timezone. See bug 14362. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 13:43:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 11:43:28 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-mUfZlprAIc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #16 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Well what I noticed from here is that the $bibitems variable is now unneeded and should be removed from the AddReserve subroutine. I think I will still look into this more and try to fully understand the changes, and that there is nothing left out which might be important and is missing in this new version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 13:46:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 11:46:41 +0000 Subject: [Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve In-Reply-To: <bug-14711-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14711-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14711-70-X0CjvtScMI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14702 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 13:46:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 11:46:41 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-H4vB2exjov@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14711 --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Joonas Kylm?l? from comment #16) > Well what I noticed from here is that the $bibitems variable is now unneeded > and should be removed from the AddReserve subroutine. I think I will still > look into this more and try to fully understand the changes, and that there > is nothing left out which might be important and is missing in this new > version. True. I opened bug 14711 for that. Should have added a see also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:18:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:18:00 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: <bug-11250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11250-70-sJM7C2znTz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #7 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Joonas Kylm?l? from comment #6) > (In reply to M. Tompsett from comment #4) > > There is a difference between none_available (but eventually some may) vs. > > comment #2's "{item} is not allowed to be placed on hold". Is there a way to > > check for this? > > What do you mean with this paragraph? I didn't understand it. "Too many holds" -- But I don't have any holds on the book at all! In this case, there is some sort of holds queue limitation. "None available" -- Because there is a holds limitation preventing a hold from being placed. "Too many holds" -- Right, because some items just can't be put on hold period. This is a specific case of the previous one. "None available" -- And there never will be, because it can't be put on hold. "Too many holds" -- Oh, but I'm insane and taking a quadruple major and need all 20 books! In this case, the patron is holds-happy putting everything they can on hold. "None available" -- Because you are clearly an holds-happy patron! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:06 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-HeeydCFHTQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41716|0 |1 is obsolete| | Attachment #41717|0 |1 is obsolete| | Attachment #41718|0 |1 is obsolete| | Attachment #41719|0 |1 is obsolete| | Attachment #41720|0 |1 is obsolete| | Attachment #41721|0 |1 is obsolete| | Attachment #41722|0 |1 is obsolete| | Attachment #41723|0 |1 is obsolete| | Attachment #41724|0 |1 is obsolete| | Attachment #41725|0 |1 is obsolete| | Attachment #41726|0 |1 is obsolete| | Attachment #41727|0 |1 is obsolete| | Attachment #41728|0 |1 is obsolete| | Attachment #41729|0 |1 is obsolete| | Attachment #41730|0 |1 is obsolete| | Attachment #41731|0 |1 is obsolete| | Attachment #41732|0 |1 is obsolete| | Attachment #41733|0 |1 is obsolete| | Attachment #41766|0 |1 is obsolete| | Attachment #41914|0 |1 is obsolete| | Attachment #41917|0 |1 is obsolete| | Attachment #41918|0 |1 is obsolete| | Attachment #41919|0 |1 is obsolete| | Attachment #41924|0 |1 is obsolete| | Attachment #41927|0 |1 is obsolete| | Attachment #41931|0 |1 is obsolete| | Attachment #41932|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41953&action=edit Bug 14544: Add Koha::Virtualshelf and Koha::Virtualshelves The 2 modules C4::VirtualShelves and C4::VirtualShelves::Page are really badly coded and buggy. It became complicated to fix and enhance them. This rewrite will make the code more robust and the list feature will be easier to change. Some new modules are added to the Koha namespace (Koha::Virtualshelf, Koha::Virtualshelves, Koha::Virtualshelfshare[s] and Koha::Virtualshelfcontent[s]) to take advantage of Dbix::Class. The patchset fixes some bugs: 1/ Bug 6279 - Can't delete lists from the second page of lists in the OPAC 2/ The owner of a list should not need any permission to remove content from his lists. 3/ No feedback messages when actions are done Test plan: A) Intranet and OPAC 1/ Create more than 20 private and public lists with different users 2/ Edit some and confirm that the changes are taken into account 3/ Share some lists with other users 4/ Add / remove contents Be sure you have some lists with more than 20 items (to test the pagination) 5/ Play with permissions and confirm it works as expected. For private lists: They should not be viewed by anyone else, if they are not shared If they are shared (OPAC only): a. "Allow anyone else to add entries" Should allow the user with whom the list is shared to add entries. b. "Allow anyone to remove his own contributed entries." Should allow the user with whom the list is shared to remove his own entries. c. "Allow anyone to remove other contributed entries." Should allow the user with whom the list is shared to remove any entries. For public lists: They should be viewed by anyone else. a. "Allow anyone else to add entries" Should allow any user to add entries. b. "Allow anyone to remove his own contributed entries." Should allow any user to remove his own entries. c. "Allow anyone to remove other contributed entries." Should allow any user to remove any entries. 6/ Download and sent lists. 7/ Confirm that the "Add to" feature works as expected. 8/ Confirm that the "Add an item to" works as expected. 9/ Delete some lists. 10/ Print some lists and subscribe to the RSS feed (OPAC only) (with more than 20 items). 11/ Use the remove "Remove share" links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:11 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-WrSvoJWNCA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #85 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41954&action=edit Bug 14544: Get rid of GetShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:15 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-icnyhZkwrc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #86 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41955&action=edit Bug 14544: Get rid of AddShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:19 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-2AAG7lkaQG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #87 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41956&action=edit Bug 14544: Get rid of DelShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:23 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-slSuL2Otwa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #88 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41957&action=edit Bug 14544: Get rid of ModShelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:27 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-mcDVhxgcfH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #89 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41958&action=edit Bug 14544: Move share routines to Koha::Virtualshelfshare and Koha::Virtualshelfshares -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:31 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-dINL1iH2Rr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #90 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41959&action=edit Bug 14544: Get rid of GetAllShelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:34 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-hAyDv4DhTl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #91 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41960&action=edit Bug 14544: Koha::Virtualshelfcontent[s] Get rid of AddToShelf and DelFromShelf Bug 14544: Allow a user to delete his own contents -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:39 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-ThNB1s7AVN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #92 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41961&action=edit Bug 14544: Make the intranet side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:44 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-1GUZsjOpQv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #93 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41962&action=edit Bug 14544: Get rid of GetBibliosShelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:49 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-hpcuwOdmSh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #94 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41963&action=edit Bug 14544: Get rid of GetShelves This does not work for now, see later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:55 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-A5UUqQwJQN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #95 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41964&action=edit Bug 14544: Make the OPAC side independent of Page.pm Bug 14544: Fix redirect on editing a list If you edit a list from the list view, after saving the form, you are not redirected to the list view (but on the edit form). Bug 14544: Cosmetic: › should be a class divider -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:45:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:45:59 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-mJerB19PgY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #96 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41965&action=edit Bug 14544: Get rid of ShelfPossibleAction Bug 14544: (follow-up) Get rid of ShelfPossibleAction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:46:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:46:05 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-IO7naCSbTf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #97 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41966&action=edit Bug 14544: Get rid of GetShelfContent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:46:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:46:10 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-6j9a8dcKYd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #98 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41967&action=edit Bug 14544: Get rid of GetSomeShelfNames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:46:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:46:16 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-ePETf2BMny@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #99 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41968&action=edit Bug 14544: Move HandleDelBorrower to C4::Members -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:46:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:46:22 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-FM6C2s7YdU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #100 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41969&action=edit Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:46:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:46:28 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-polQzz2ktf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #101 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41970&action=edit Bug 14544: Remove wrong tips about permissions The owner of a list should not need any permission to remove contents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:52:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:52:35 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-x8viqEH0Cl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Srdjan Jankovic from comment #11) > Sorry, I did not know what to do with it. My intention was to correct > something that I found obviusly wrong when doing some other work. I did not > want to go into changing the way things work. > I'm happy for this to be dropped, but the fact stays that the code as it is > now is wrong. It works just because it is being called in particular way. I amended your path in order to not lose everything including your remarks about wrong calls and a param not being used. (Adding a comment) I switched the params at three places where they were in reverse order. Added a trivial unit test. Since the indicator param works fine, I favored leaving it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:53:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:53:02 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-vssw2xaC5M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41911|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:53:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:53:26 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-1p5UOVKQSO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41971&action=edit Bug 11247: Fix calls of TransformHtmlToXml The ind_tag of TransformHtmlToXml is unused. Some calls to this function incorrectly revert indicator and ind_tag (which is not a problem when both are empty..) Patch of Srdjan Jankovic, amended and signed off by Marcel de Rooy. The following calls are fixed: call in acqui/addorder.pl: switched indicator with ind_tag call in acqui/addorderiso2709.pl replaced too acqui/finishreceive.pl replaced too These calls are fine: two calls in cataloguing/additem.pl are fine call in serials/serials-edit.pl is fine call in tools/batchMod.pl is fine The folllow-up patch adds a simple unit test. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> With AcqCreateItem=='placing an order', tested if adding an order still worked (covered both addorder.pl and addorderiso2709.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:53:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:53:29 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-fVFC7841mm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41972&action=edit Bug 11247: Add a simple unit test for TransformHtmlToXml Test plan: Run t/Biblio_TransformHtmlToXml.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:53:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:53:45 +0000 Subject: [Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml() In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-tY3UIEempk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 14:55:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 12:55:11 +0000 Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-rABhfaTlYV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove unused params from |Fix calls of |TransformHtmlToXml() |TransformHtmlToXml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:06:02 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: <bug-11250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11250-70-as0qdwtlwM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #8 from Joonas Kylm?l? <j.kylmala at gmail.com> --- M. Tompsett: Still don't get what do you mean. What do you mean by "but eventually some may". And what is the thing you're trying to say with that there is a difference between none_available and "{item} is not allowed to be placed on hold"? Or if you could rephrase the thing what you suggested to be done here: ::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ +309,5 @@ > + <li><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]">[% borrowerfirstname %] [% borrowersurname %]</a> <strong>already has a hold</strong> on this item </li> > + [% ELSIF ( ageRestricted ) %] > + <li><strong>Age restricted</strong></li> > + [% ELSIF ( none_available ) %] > + <li> <strong>No items are available</strong> to be placed on hold</li> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:09:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:09:13 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-VSkv1y15Ta@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41961|0 |1 is obsolete| | --- Comment #102 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41973&action=edit Bug 14544: Make the intranet side independent of Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:09:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:09:17 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-TLjuyRVf3D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41962|0 |1 is obsolete| | --- Comment #103 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41974&action=edit Bug 14544: Get rid of GetBibliosShelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:09:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:09:21 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-jhdUr3acaW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41963|0 |1 is obsolete| | --- Comment #104 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41975&action=edit Bug 14544: Get rid of GetShelves This does not work for now, see later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:09:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:09:26 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-NdzaVbrsjq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41964|0 |1 is obsolete| | --- Comment #105 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41976&action=edit Bug 14544: Make the OPAC side independent of Page.pm Bug 14544: Fix redirect on editing a list If you edit a list from the list view, after saving the form, you are not redirected to the list view (but on the edit form). Bug 14544: Cosmetic: › should be a class divider -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:09:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:09:29 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-x41lDKPtds@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41965|0 |1 is obsolete| | --- Comment #106 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41977&action=edit Bug 14544: Get rid of ShelfPossibleAction Bug 14544: (follow-up) Get rid of ShelfPossibleAction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:09:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:09:33 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-wQbuXRfd0Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41966|0 |1 is obsolete| | --- Comment #107 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41978&action=edit Bug 14544: Get rid of GetShelfContent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:09:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:09:40 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-9JuLj46I01@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41968|0 |1 is obsolete| | --- Comment #109 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41980&action=edit Bug 14544: Move HandleDelBorrower to C4::Members -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:09:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:09:37 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-VmhbMK2ze4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41967|0 |1 is obsolete| | --- Comment #108 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41979&action=edit Bug 14544: Get rid of GetSomeShelfNames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:09:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:09:44 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-kW3N01pZ0W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41969|0 |1 is obsolete| | --- Comment #110 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41981&action=edit Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:09:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:09:48 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-sa72OLW2JT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41970|0 |1 is obsolete| | --- Comment #111 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41982&action=edit Bug 14544: Remove wrong tips about permissions The owner of a list should not need any permission to remove contents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:24:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:24:15 +0000 Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-gPJDIWY4DX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:24:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:24:22 +0000 Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-qyL9HiGU98@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:25:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:25:25 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-pRvA6Eh1E4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #112 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41983&action=edit Bug 14544: Fix regression on adding a new list The user should not be allowed to create a new list and get a friendly error message if he tries. The "New list" links are removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:35:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:35:18 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-nlBxzPHw6k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:35:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:35:23 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-7BGwXNyAmj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #270 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41984&action=edit Bug 7143: spaces in history.txt instead of tabs break display on website This may be the only place in koha where a tab should be a tab and not 4 spaces. I'll try to fix the script that does the conversion for the website to handle 4 spaces instead of tabs, but for now can we have this? Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:35:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:35:34 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-qWUdyQRRyo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41929|0 |1 is obsolete| | Attachment #41930|0 |1 is obsolete| | --- Comment #271 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41985&action=edit Bug 7143: Add Benjamin Rokseth to the projects history file and about page Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:36:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:36:57 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-VdG1XPxT9q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41983|0 |1 is obsolete| | --- Comment #113 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41986&action=edit Bug 14544: Fix regression on adding a new list The user should not be allowed to create a new list and get a friendly error message if he tries. The "New list" links are removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:38:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:38:09 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-e7pEDAoGLn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #272 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Hmm is this numbering of devs in history.txt that important? about.pl could number them too.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:39:42 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-fBqiHctwki@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Kyle, what does the last patch set? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:43:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:43:22 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-X6FSDWVLb7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:45:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:45:29 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14306-70-1cNjThT8Oj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39741|0 |1 is obsolete| | Attachment #41237|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41987&action=edit Bug 14306: Show URL from MARC21 field 555$u under Title Notes/Descriptions This patch includes: [1] Add some logic to GetMarcNotes to embed the contents of MARC21 field 555$u in a html anchor tag. [2] Add a unit test for GetMarcNotes in Biblio.t [3] Remove calls to GetMarcNotes from sendbasket.pl (opac and staff). A closer look revealed that the data was not used; the notes in the mail of sendbasket are taken from GetBiblioData. Test plan: [1] Edit a record. Add one or two URLS in 555$u. Add something in 500$a too. [2] Check if you can click the URLs in opac and staff detail tab Notes or Descriptions. [3] Run the unit test t/db../Biblio.t [4] Add something in the cart. Click More Details and send the cart. Verify that you have something in Notes (from 500$a). Signed-off-by: Marc Veron <veron at veron.ch> Followed test plan. Works as expected. QA tools OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:48:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:48:47 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-qIT19YdfRl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #114 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41988&action=edit Bug 14544: DB Changes: Set a default value for sortfield -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:49:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:49:59 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: <bug-11250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11250-70-tmIX6UN8ec@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:53:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:53:05 +0000 Subject: [Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record In-Reply-To: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11194-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11194-70-hXVLKM5h3A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 --- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Olli, can u add it to queryparser.yml also please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 15:55:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 13:55:46 +0000 Subject: [Koha-bugs] [Bug 14732] Search patrons and add selected patrons to a new list gives an error In-Reply-To: <bug-14732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14732-70-mhR678nbjU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14732 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org CC| |gmcharlt at gmail.com, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle.m.hall at gmail.com Component|Lists |Patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:04:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:04:21 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-aU2By1kGMA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:04:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:04:24 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-dlUV5CQkdc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41745|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41989&action=edit Bug 11190 sitemap.pl -- Generate a Catalog sitemap Add a script sitemap.pl to process all biblio records from a Koha instance and generate Sitemap files complying with this protocol as described on http://sitemaps.org. The goal of this script is to be able to provide to search engines direct access to biblio records. It avoid leaving search engine browsing Koha OPAC and so generating a lot of traffic, and workload, for a bad result. Thanks Magnus for testing, and helping to improve the script design. [2015.04.16] Switch from Moose to Moo. [2015.08.20] Add complete (more) UT. Signed-off-by: Magnus Enger <magnus at enger.priv.no> All options to the script work as expected and the output looks good. Nice enhancement! Signed-off-by: Frederic Demians <f.demians at tamil.fr> I signed-of my own patch after fixing various QA errors. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Amended patch: replace tabs with spaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:05:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:05:34 +0000 Subject: [Koha-bugs] [Bug 14732] Search patrons and add selected patrons to a new list gives an error In-Reply-To: <bug-14732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14732-70-FgxBkOS0h8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14732 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Seems like the error was only with the kohaadmin account. This bug can be closed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:09:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:09:29 +0000 Subject: [Koha-bugs] [Bug 14634] Warns when placing hold on record with no items In-Reply-To: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14634-70-JMjHVnAlD0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:09:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:09:32 +0000 Subject: [Koha-bugs] [Bug 14634] Warns when placing hold on record with no items In-Reply-To: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14634-70-7s9loO36zV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41912|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 41990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41990&action=edit Bug 14634: Warns when placing hold on record with no items To test: 1) Create a new record in Cataloguing 2) When done, instead of adding an item to the record, click on the Holds tab in the left nav 3) Notice warns 4) Apply patch and refresh page 5) Click on Holds tab again 6) Notice warns are gone and page still works Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Warns disappear; note that the display of the error message is still ugly. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:09:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:09:36 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-8vD9YzRe0p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #63 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks guys! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:10:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:10:19 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-bTeDxx1GIV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #273 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:10:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:10:25 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-nB7rOKfP8n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41984|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:10:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:10:33 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-dwzod5o96d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41985|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:11:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:11:03 +0000 Subject: [Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes In-Reply-To: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12632-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12632-70-zrt5oAOo8p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #38 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Good job Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:11:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:11:50 +0000 Subject: [Koha-bugs] [Bug 14361] koha-restart-zebra fails and probably breaks upgrade In-Reply-To: <bug-14361-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14361-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14361-70-yznSBUT6Xe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14361 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Benjamin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:12:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:12:10 +0000 Subject: [Koha-bugs] [Bug 14714] koha-mysql tab-completion in bash In-Reply-To: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14714-70-VHsZCDOfht@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14714 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:12:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:12:33 +0000 Subject: [Koha-bugs] [Bug 14557] Add holds count to holds tab In-Reply-To: <bug-14557-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14557-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14557-70-qdFXkHSA7k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14557 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:13:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:13:01 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-4GXwEMAEze@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #46 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Feature pushed to master. Awesome work Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:15:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:15:28 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-rv0dyU2hKp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41884|0 |1 is obsolete| | --- Comment #8 from Lari Taskula <larit at student.uef.fi> --- Created attachment 41991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41991&action=edit Bug 14590 - Checkboxes should be disabled without valid contact information in messaging preferences This patch makes both client and server side validations, both in OPAC and Staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:24:40 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-K19Iqp0CTY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #251 from Heather Braum <hbraum at nekls.org> --- I hope this appropriate to ask -- any chance this could get pushed to master soon, since it looks like it's passed QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:30:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:30:51 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-FnJ2UL3bbN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37457|0 |1 is obsolete| | Attachment #37458|0 |1 is obsolete| | Attachment #37459|0 |1 is obsolete| | --- Comment #88 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 41992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41992&action=edit Bug 8236 Renewing policy in overdue or restriction case This patch introduces 2 sysprefs : RestrictionBlockRenewing to allow/block renewal of items when patron is restricted. OverduesBlockRenewing to allow, block only the late ones or block all checked out items Default is "allow" in both case. Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:31:04 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-XjRApmjwLQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #89 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 41993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41993&action=edit Bug 8236: Tests for Renewing policy in overdue or restriction case - Add tests in t/db_dependent/Circulation.t Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:31:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:31:14 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-bM6U2c1jWS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #90 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 41994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41994&action=edit Bug 8236 [QA Followup] - Tweak language, fix whitespace error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:32:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:32:51 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-P9K0kLzFUj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|Patch doesn't apply |Needs Signoff --- Comment #91 from Alex Arnaud <alex.arnaud at biblibre.com> --- @Tom?s: I've rebased these patches and use atomic updates for the news sysprefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 16:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 14:39:35 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-OC6nYJFTXX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #115 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- A behaviour I'm not sure it is the scope of this bug : - Log-in with a user A at intranet - Create a public list - Add some records - Allow anyone else to add entries and anyone to remove his own contributed entries, do not allow any user to remove any entries - Log-in with a user B at OPAC - View the list - You see links "Remove from this list" on every record, even if they where added by another user => It would be better to show this link only in records you can remove - When clicked and alert accepted, you get the message "No biblio has been removed." (records are not removed) => You should get a message of "unauthorized_on_remove_biblios" - Select some records - Click on "Remove from list" - You get no message (records are not removed) => Not sure what to do here because you may be allowed on some selected records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 17:15:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 15:15:45 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-jUMzx7DXsD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #116 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It's the expected behavior, at least the one before this patch. But I completely agree, it could be improved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 17:40:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 15:40:49 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14306-70-5SDvqOerFY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 41995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41995&action=edit Bug 14306: Follow-up for URLs in 555$u This patch removes the code for inserting the <a> anchor tags around URLs in GetMarcNotes (as added originally). The URLs are placed in separate array elements; the template should take care of further handling. The unit test has been adjusted accordingly. Test plan: Run the unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 17:42:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 15:42:26 +0000 Subject: [Koha-bugs] [Bug 14733] New: Prevent a record from having holds with duplicate priorities Message-ID: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733 Bug ID: 14733 Summary: Prevent a record from having holds with duplicate priorities Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It is possible to create holds with duplicate priorities. The reason for this is that typically the priority is calculated before placing the hold. When the hold is placed the priority is calculated. This can easily be shown by opening up two browser windows and starting to place a hold for a record in each one. You'll see that both list the same priority. If you than place the hold in each window, both holds will have the same priority! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 17:42:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 15:42:31 +0000 Subject: [Koha-bugs] [Bug 14733] Prevent a record from having holds with duplicate priorities In-Reply-To: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14733-70-ou4xopRWR4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 17:45:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 15:45:54 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14306-70-rd0ptkhprF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Still a patch coming for one/more templates.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 17:47:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 15:47:51 +0000 Subject: [Koha-bugs] [Bug 14733] Prevent a record from having holds with duplicate priorities In-Reply-To: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14733-70-AwZ31Cg0kt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 17:47:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 15:47:53 +0000 Subject: [Koha-bugs] [Bug 14733] Prevent a record from having holds with duplicate priorities In-Reply-To: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14733-70-SfG7MDojMf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41996&action=edit Bug 14733 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 17:48:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 15:48:02 +0000 Subject: [Koha-bugs] [Bug 14733] Prevent a record from having holds with duplicate priorities In-Reply-To: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14733-70-yII79Vtykf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41997&action=edit Bug 14733 - Prevent a record from having holds with duplicate priorities It is possible to create holds with duplicate priorities. The reason for this is that typically the priority is calculated before placing the hold. When the hold is placed the priority is calculated. This can easily be shown by opening up two browser windows and starting to place a hold for a record in each one. You'll see that both list the same priority. If you than place the hold in each window, both holds will have the same priority! Test Plan: 1) Run unit tests pre-patch, note they fail 2) Run unit tests post-patch, note they succeed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 17:48:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 15:48:05 +0000 Subject: [Koha-bugs] [Bug 14733] Prevent a record from having holds with duplicate priorities In-Reply-To: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14733-70-yluKA7hX1r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41998&action=edit Bug 14733 - Tidy AddReserve -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 17:52:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 15:52:07 +0000 Subject: [Koha-bugs] [Bug 14733] Prevent a record from having holds with duplicate priorities In-Reply-To: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14733-70-Fdegv9tMHY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 18:05:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 16:05:42 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: <bug-8483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8483-70-qQaUzuMXQd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #12 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Robin Sheat from comment #11) > Is this a bit overengineered? Could you not just extend the query? I can see why you'd think that. I'd consider this as an opportunity to add some more useful Koha objects. There's little point to having an OO model if we don't take advantage of it, and there always has to be that first step! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 18:09:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 16:09:23 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: <bug-8483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8483-70-dWvMLFvKhC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41015|0 |1 is obsolete| | Attachment #41016|0 |1 is obsolete| | Attachment #41017|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 41999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41999&action=edit Bug 8483 - Add checkout classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 18:09:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 16:09:30 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: <bug-8483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8483-70-jprLHejck8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42000&action=edit Bug 8483 - Add record and item related classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 18:09:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 16:09:33 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: <bug-8483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8483-70-Us2CvmVgRV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42001&action=edit Bug 8483 - Borrower reading history should include deleted items When showing a borrower's reading history, it'd be good to be able to include the deleted items also, as we have that information available. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Members/GetAllIssues.t 3) Verify old checkouts for deleted items show in reading history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 18:20:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 16:20:21 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-qRJVlVxHKJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #2 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Magnus Enger from comment #1) > This sounds interesting! Who should be able to place the requests? Local > patrons or other libraries? Is this something you will be working on, or is > it more of an idea? I'm actively developing this. This is for local patrons ( though libraries could have accounts ). In essence it is somewhat similar to how holds work, but instead of a hold for a item, it's a request for a photocopy ( or digital copy ) of part of an item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 18:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 16:20:35 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-U0yGCxraFw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 19:26:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 17:26:00 +0000 Subject: [Koha-bugs] [Bug 14734] New: Enhance 264 display in OPAC and Staff XSLT Message-ID: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 Bug ID: 14734 Summary: Enhance 264 display in OPAC and Staff XSLT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: wsalesky at gmail.com QA Contact: testopia at bugs.koha-community.org Make 264 repeatable in display with labels that match the coding in the indicators. So: Dynamically display as Producer, Publisher, Distributor, Manufacturer, and/or Copyright Date information, that is, read 2nd indicators under 264 and translate them to different descriptors: (brief/full display) _0 ? Producer _1 ? Publisher _2 ? Distributor _3 ? Manufacturer _4 ? Copyright Date (display copyright symbol [If I recall correctly, this is a known bug]) example: 264 _1 --> Publisher: New York : Basic Books, [2005] 264 _4 --> Copyright date: ?2005 Display subfields a, b, c, 3 Use if/then/else regarding 260 and 264: If there is no 264, then display 260, else display 264 This enhances changes made in: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12724, http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12725, http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12726. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 19:29:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 17:29:21 +0000 Subject: [Koha-bugs] [Bug 14735] New: cache_expiry is not saved when updating a SQL report Message-ID: <bug-14735-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14735 Bug ID: 14735 Summary: cache_expiry is not saved when updating a SQL report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Steps to duplicate (must have memcached enabled): 1. Create and save a report using the default values for "Report is public" and cache time. 2. Run the report. 3. Edit the report changing the setting for "Report is public" to yes. 4. Save the report. The cache time is now 0. 5. Edit the report changing the cache time to 300. 6. Save the report. The cache time is now 0 again. This seems to be due to the fact that cache_expiry is not passed to the update_sql function in the phase 'Update SQL'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 19:30:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 17:30:10 +0000 Subject: [Koha-bugs] [Bug 14736] New: AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds Message-ID: <bug-14736-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736 Bug ID: 14736 Summary: AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This issue was originally reported in bug 14320. If the AllowRenewalIfOtherItemsAvailable sys pref is set to allow, and a borrower has an item checked out that has many items {30+} AND many holds {70+) on it, loading the checkouts table for this borrower takes FOREVER to load. The load time takes forever, because of the factoring that happens to determine if an item is truly available for renewal. At this time, the situation couldn't be improved in bug 14320, but I want this report out there, in case this becomes a bigger problem and/or someone comes up with a way to speed up the processing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 19:36:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 17:36:36 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14734-70-0T1TCj90qm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 Winona Salesky <wsalesky at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |wsalesky at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:21:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:21:38 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14734-70-CNefJldPn5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com, | |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:22:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:22:35 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: <bug-14377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14377-70-k2FQxprD9C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:14 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13382-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13382-70-mFEqb0TXKY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:15 +0000 Subject: [Koha-bugs] [Bug 14326] XSLT Syntax error in MARC21slimOPACResults.xsl In-Reply-To: <bug-14326-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14326-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14326-70-j3WlUoKMLj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14326 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:15 +0000 Subject: [Koha-bugs] [Bug 13434] 586 XSLT improvements In-Reply-To: <bug-13434-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13434-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13434-70-JsJ6Jq3XtU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:15 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13387-70-5YNXHfNcOW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:15 +0000 Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT In-Reply-To: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13385-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13385-70-M9WRLxVDgT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:15 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13383-70-H5zAl388IY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:16 +0000 Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT In-Reply-To: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13386-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13386-70-p1sXqhHOHD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:16 +0000 Subject: [Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx In-Reply-To: <bug-13600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13600-70-cyjfmmZBgv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:16 +0000 Subject: [Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank In-Reply-To: <bug-14181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14181-70-aDIL0haWKP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:16 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13734-70-Zxf6zsQd9l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:17 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13381-70-cXybqlPJTb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:17 +0000 Subject: [Koha-bugs] [Bug 13650] Parenthesis in subject links problematic for search In-Reply-To: <bug-13650-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13650-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13650-70-5LThtcCNtW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:23:17 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13433-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13433-70-6Lc592vC9y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:30:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:30:32 +0000 Subject: [Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout In-Reply-To: <bug-14470-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14470-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14470-70-ukNXrPgFkU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 --- Comment #15 from bondiurbano <costalc at gmail.com> --- It's fine for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:30:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:30:34 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-F403aX9hjO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Chris Rohde <crohde at roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:33:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:33:21 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-BKZk2R3vlA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #3 from Magnus Enger <magnus at libriotech.no> --- (In reply to Kyle M Hall from comment #2) > I'm actively developing this. This is for local patrons ( though libraries > could have accounts ). Yeah, in Norway we have a whole infrastructure for letting libraries log on to the OPACs of other libraries, in order to place ILL requests. > In essence it is somewhat similar to how holds work, > but instead of a hold for a item, it's a request for a photocopy ( or > digital copy ) of part of an item. So from a Norwegian perspective, this sounds like it would take care of the copy part of ILL. Now Alex from PTFS Europe is already working on ILL over on bug 7317. Maybe it could be worthwhile to have a look at his work and see if your efforts can be combined? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:33:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:33:57 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-NCWY6wpKpu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7317, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9852 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:33:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:33:57 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: <bug-7317-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7317-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7317-70-EZpZCKIYN7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14610 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 20:33:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 18:33:57 +0000 Subject: [Koha-bugs] [Bug 9852] Add interlibrary loan request form to the OPAC In-Reply-To: <bug-9852-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9852-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9852-70-rzC2vfEg6W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9852 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14610 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 21:00:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 19:00:57 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: <bug-7317-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7317-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7317-70-Z9B7XdKh1k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 21:01:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 19:01:14 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14734-70-YBdikNWgxp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 21:01:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 19:01:55 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-IUxyUZEWbI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 21:02:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 19:02:51 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-dJQMzTiZo0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 21:09:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 19:09:22 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: <bug-14377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14377-70-7lHuggiO9K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 21:27:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 19:27:08 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: <bug-11858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11858-70-yD2LHjFSwz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 caro fjorde <carokoha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carokoha at gmail.com --- Comment #4 from caro fjorde <carokoha at gmail.com> --- Hi there, My name is Caroline and I work at the Farmington Library in Connecticut. We use Tech-Logic RFID readers and have been tagging our collection for almost a year. We are able to check in and out one item at a time, but would love to improve our accuracy and be able to check in multiple items at once using RFID. We noticed that we can use the KOHA offline component to check multiple items at a time using RFID, but sadly holds are not picked up using this method. I am not the most tech savvy person, but am willing to help. Thanks. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 21:30:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 19:30:49 +0000 Subject: [Koha-bugs] [Bug 14737] New: Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions Message-ID: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Bug ID: 14737 Summary: Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The plugin requires the following permissions/flags: flagsrequired => { tools => 'cn_browser', catalogue => 1 }, and there is no way to set tools > cn_browser. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 22:25:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 20:25:43 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-wn8LONZSjw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 22:34:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 20:34:25 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: <bug-14242-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14242-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14242-70-s3Gq4EiQi6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #1 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Created attachment 42002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42002&action=edit Bug 14242: Use ISBN-field to automaticly fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automaticly fills requested fields with search result. Use in OPAC purchase suggestions to automaticly fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACAutoFill" 3. Log into OPAC and go to purchase suggetions page 4. Write a valid ISBN into the ISBN field and press the edit icon next to the field, or unfocus the field. 5. Title, Author, Publisher and Item Type fields should now be filled automaticly. 6. Press "undo" to undo - should restore all changed fields to original values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 22:35:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 20:35:13 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: <bug-14242-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14242-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14242-70-OxezKllUgx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 23:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 21:14:39 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-RiPa850CBz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #252 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to Heather Braum from comment #251) > I hope this appropriate to ask -- any chance this could get pushed to master > soon, since it looks like it's passed QA? It's always appropriate to ask, the step after Passed QA is generally pushed to master. But that step involves the RM testing still. So it's not just a formality. Changes like this which could potentially cause a privacy breach if there was a mistake of course take a lot of testing. I suspect it is in the queue of things for Tomas to look at when he gets time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 26 23:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Aug 2015 21:40:52 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-CTdStZSN46@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #253 from Heather Braum <hbraum at nekls.org> --- Thanks for the explanation Chris, which makes perfect sense -- I forgot about the RM testing. In that case, I'll keep waiting for this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 02:24:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 00:24:20 +0000 Subject: [Koha-bugs] [Bug 14738] New: Rancor - Advanced Search usability problems Message-ID: <bug-14738-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14738 Bug ID: 14738 Summary: Rancor - Advanced Search usability problems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 11559 The Rancor professional cataloguing advanced search interface has a couple of small usability problems, which I don't think preclude it getting in, but could use a tidy up at some point. Advanced Search window: - unchecking the only checked searched server doesn't clear the results (or take you back to the search screen) - checking a searched server that has no results still shows the formerly checked server's paging, even if there are no results. - It's not clear to the user that a given server has no results from the search area. (The count is displayed next to the server, though, so it's not completely context free, thanks for that!) - the layout of the page, while having similar functionality to the z39.50 search box, is different and that seems unexpected to users. Because the functionality is similar (though not exactly the same!) as the existing z39.50 search functions, I feel the layout should be the same, with the servers to search on the right, and the fields to the left, and the search button below the server list, on the right. < this last will be a slight difference to the existing windows, to accommodate the functionality of this new search screen. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 [Bug 11559] Professional cataloger's interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 02:24:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 00:24:20 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-g683hl1Jxu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14738 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14738 [Bug 14738] Rancor - Advanced Search usability problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 04:45:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 02:45:25 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-79KWZKsVmr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Bob Birchall <bob at calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 05:12:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 03:12:44 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: <bug-8483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8483-70-Q9QqzMzgrL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia at hotmail.com --- Comment #16 from Aleisha Amohia <aleishaamohia at hotmail.com> --- DBD::mysql::db do failed: Lock wait timeout exceeded; try restarting transaction at ../t/db_dependent/Members/GetAllIssues.t line 20. # Looks like your test exited with 255 before it could output anything. ../t/db_dependent/Members/GetAllIssues.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 16/16 subtests Test Summary Report ------------------- ../t/db_dependent/Members/GetAllIssues.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 16 tests but ran 0. Files=1, Tests=0, 56 wallclock secs ( 0.01 usr 0.03 sys + 1.19 cusr 0.22 csys = 1.45 CPU) Result: FAIL Setting to Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 05:34:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 03:34:30 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-xyTz12TVIw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 05:34:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 03:34:48 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-CEXiSVe5E3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41949|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia at hotmail.com> --- Created attachment 42003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42003&action=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 05:58:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 03:58:48 +0000 Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page In-Reply-To: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14579-70-Np4AWXz9s8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 05:59:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 03:59:06 +0000 Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page In-Reply-To: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14579-70-wrh7QJAFrp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Aleisha Amohia <aleishaamohia at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41658|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia at hotmail.com> --- Created attachment 42004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42004&action=edit Bug 14579: 'You are not logged in' should link to log in page To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page Signed-off-by: Aleisha <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 08:02:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 06:02:33 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-MkzvWURyFS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #18 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Marcel de Rooy from comment #8) >Since AddReserves only calls this sub, we can move the code for charging the >fee to this sub. I renamed it to ChargeReserveFee. >There is no change in behavior. I'd suggest putting the fee calculation to another subroutine because it will help keeping the Koha code more modulated and reusable in future cases (even though it's not many lines (2!?)). Also the code below the comment "# If not all items are issued and there are no holds: charge no fee" shouldn't work like that. What if someone wants to explicitly have that one item or an item from one specific branch and the library doesn't do inter-library transportations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 08:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 06:25:47 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-oPsR97IdaZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #19 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Joonas Kylm?l? from comment #18) > Also the code below the comment "# If not all items are issued and there are > no holds: charge no fee" shouldn't work like that. What if someone wants to > explicitly have that one item or an item from one specific branch and the > library doesn't do inter-library transportations. There is the "Item level holds" attribute where you can decide whether it is or not allowed to set a hold per item and not per record (/cgi-bin/koha/admin/smart-rules.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 08:30:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 06:30:03 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-2302ymxfc8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Joonas Kylm?l? from comment #18) > (In reply to Marcel de Rooy from comment #8) > >Since AddReserves only calls this sub, we can move the code for charging the > >fee to this sub. I renamed it to ChargeReserveFee. > >There is no change in behavior. > > I'd suggest putting the fee calculation to another subroutine because it > will help keeping the Koha code more modulated and reusable in future cases > (even though it's not many lines (2!?)). I will move these lines. > Also the code below the comment "# If not all items are issued and there are > no holds: charge no fee" shouldn't work like that. What if someone wants to > explicitly have that one item or an item from one specific branch and the > library doesn't do inter-library transportations. This is outside the scope of this report. This report does not change behavior but actually documents what Koha does here. If we want to change behavior, we should open a new report on top of this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 09:14:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 07:14:44 +0000 Subject: [Koha-bugs] [Bug 14398] Duplicate inventory results when an item is in the wrong place (ie using branch/location filter) In-Reply-To: <bug-14398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14398-70-TmcXq2e06d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14398 Patrick Munro <patrick.munro787 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.munro787 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 09:15:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 07:15:05 +0000 Subject: [Koha-bugs] [Bug 14677] Inventory: Compare Barcodes List to Result function In-Reply-To: <bug-14677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14677-70-Ot9aY2RYNQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14677 Patrick Munro <patrick.munro787 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.munro787 at gmail.com --- Comment #1 from Patrick Munro <patrick.munro787 at gmail.com> --- Hello Loan Seeker, Are you in any financial problem or mess? Do you need quick or cash loans to clear off your debit and get back to feet financially. If so do contact us with our email below Email:westafricaloancompanyltd at gmail.com Please do provide us with the following application data information below,for us to start the processing of your loan funds immediately okay,i await your urgent response asap. 1)Full Names: 2)Country: 3)Age: 4)Occupation: 5)Phone Number: 6)Monthly income: 7)Loan Amount Needed: 8)Loan Duration: 9)Sex: 10)Purpose of Loan: Best Regards, Mr Patrick Munro(MD) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 09:15:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 07:15:33 +0000 Subject: [Koha-bugs] [Bug 4120] Add options for handling holds in self checkout In-Reply-To: <bug-4120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4120-70-6MrsSjqtnJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4120 Patrick Munro <patrick.munro787 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.munro787 at gmail.com --- Comment #1 from Patrick Munro <patrick.munro787 at gmail.com> --- Hello Loan Seeker, Are you in any financial problem or mess? Do you need quick or cash loans to clear off your debit and get back to feet financially. If so do contact us with our email below Email:westafricaloancompanyltd at gmail.com Please do provide us with the following application data information below,for us to start the processing of your loan funds immediately okay,i await your urgent response asap. 1)Full Names: 2)Country: 3)Age: 4)Occupation: 5)Phone Number: 6)Monthly income: 7)Loan Amount Needed: 8)Loan Duration: 9)Sex: 10)Purpose of Loan: Best Regards, Mr Patrick Munro(MD) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 09:18:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 07:18:09 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-IjHjXnvfrq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42006&action=edit Bug 14702: Unit tests for GetReserveFee and ChargeReservesFee Test plan: Run the test: t/db_dependent/Reserves_Fee.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 09:18:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 07:18:05 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-sdscj0gAwU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41856|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42005&action=edit Bug 14702: Refactor GetReserveFee The code of GetReserveFee was not very clear. What it did was: check if there are some items not issued. If so and there are no holds, calculate no fee. While doing so, I moved the code to charge the fee (in AddReserve) to a small new sub ChargeReserveFee. There is no change in behavior. The follow-up patch adds unit tests. Test plan: [1] Make sure that a patron category (X) includes a hold fee. [2] Select a biblio with 2 items. [3] Issue one item to another patron. [4] Place a hold on this biblio by patron with category X. No charge? [5] Cancel the hold from the previous step. [6] Use another patron to place another hold on this biblio. [7] Place hold again by patron with category X. Is it charged? [8] Cancel that hold again. Issue the second item to another patron. [9] Place hold again by patron with category X. Is it charged again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 09:19:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 07:19:03 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-1hpfq2Rupe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41857|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 09:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 07:22:28 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-tuiR4OUC94@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 09:22:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 07:22:32 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-bcX4RYqIRq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41994|0 |1 is obsolete| | --- Comment #92 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42007&action=edit Bug 8236 [QA Followup] - Tweak language, fix whitespace error Changes in the strings look good. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 09:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 07:24:10 +0000 Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page In-Reply-To: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14579-70-gNFTexmv8w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 09:24:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 07:24:12 +0000 Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page In-Reply-To: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14579-70-iXqgv23dx8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42004|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42008&action=edit Bug 14579: 'You are not logged in' should link to log in page To test: 1) Go to any page on the staff client and make sure you are not logged in (ie an error page, cgi-bin/koha/errors/400.pl) 2) Try click on 'You are not logged in |' 3) Notice it is not really a link and doesn't take you anywhere 4) Apply patch 5) Refresh page 6) Click on what now says 'Log in |' 7) Confirm that you are redirected to the intranet log in page Signed-off-by: Aleisha <aleishaamohia at hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:06:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:06:00 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-SlObiTrf2W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- See https://github.com/joubu/Koha/tree/bug_13618 for an up-to-date patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:17:36 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-Q5Tb7ag70v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42009&action=edit Bug 13618: Specific for Salutation on editing a patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:28:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:28:43 +0000 Subject: [Koha-bugs] [Bug 14739] New: Regression on adding several patrons to a new batch Message-ID: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Bug ID: 14739 Summary: Regression on adding several patrons to a new batch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org >From bug 14123 comment 4 Patron's Batches can only have a single patron added when making a new "batch". Clicking the "Add" text next to a name keeps placing it behind the pop-up, but replacing the previously clicked user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:28:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:28:59 +0000 Subject: [Koha-bugs] [Bug 14739] Regression on adding several patrons to a new batch In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-8KvxE3A415@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |jonathan.druart at bugs.koha-c |u |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:29:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:29:57 +0000 Subject: [Koha-bugs] [Bug 14739] Regression on adding several patrons to a new batch In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-rCO5PsRXiU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13891 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 [Bug 13891] Make all patron searches use DataTables server-side processing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:29:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:29:57 +0000 Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables server-side processing In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13891-70-quZEr7nkST@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14739 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 [Bug 14739] Regression on adding several patrons to a new batch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:31:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:31:37 +0000 Subject: [Koha-bugs] [Bug 14123] Patroncard: Patron search for batch no longer has Select / Select All / Add selected In-Reply-To: <bug-14123-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14123-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14123-70-X7T4FJ2D3V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14739 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Shane Sammons from comment #4) > I think this is related, so I am adding my comment here. Maybe it is unique > to my install. Yes it's related but not the same issue. > Patron's Batches can only have a single patron added when making a new > "batch". Clicking the "Add" text next to a name keeps placing it behind the > pop-up, but replacing the previously clicked user. Confirmed, I have open a new bug 14739 > Should you add someone, then click "manage batches" on the left and edit the > batch. You are able to add users via the pop-up and "Add" text. If you had > clicked many users while creating, a new batch was made for each one with a > single entry in each batch that you can now edit. > > Another thing I wanted to add, as it might be related to this bug, is when > we do edit batch and tried adding anyone with an apostrophe (like O'Leary) > in the name would not add at all. I don't reproduce this one (at least on master). Please open a new bug with a more detailed description if it's confirmed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:31:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:31:37 +0000 Subject: [Koha-bugs] [Bug 14739] Regression on adding several patrons to a new batch In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-qdPKZkzwIG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14123 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:39:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:39:11 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14306-70-ug1FGdDnUI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:39:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:39:13 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14306-70-Ti9XtbaBd7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41987|0 |1 is obsolete| | Attachment #41995|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42010&action=edit Bug 14306: Show URL from MARC21 field 555$u under Title Notes/Descriptions This patch includes: [1] Add some logic to GetMarcNotes to embed the contents of MARC21 field 555$u in a html anchor tag. [2] Add a unit test for GetMarcNotes in Biblio.t [3] Remove calls to GetMarcNotes from sendbasket.pl (opac and staff). A closer look revealed that the data was not used; the notes in the mail of sendbasket are taken from GetBiblioData. Test plan: [1] Edit a record. Add one or two URLS in 555$u. Add something in 500$a too. [2] Check if you can click the URLs in opac and staff detail tab Notes or Descriptions. [3] Run the unit test t/db../Biblio.t [4] Add something in the cart. Click More Details and send the cart. Verify that you have something in Notes (from 500$a). Signed-off-by: Marc Veron <veron at veron.ch> Followed test plan. Works as expected. QA tools OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:39:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:39:22 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14306-70-4lbl0piUrb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42012&action=edit Bug 14306: Changes for basket and detail templates A simple regex is added to the basket and detail templates to select the URLs passed separately from MARC21 555$u by GetMarcNotes. Note that the regex tests if a note starts with http:// or https:// and does not contain any whitespace in order to be considered as a url. These URLs are put in an anchor tag. This touches four places: [1] opac detail, tab title notes [2] catalogue detail, tab Descriptions [3] opac basket, more details, notes [4] staff basket, more details, notes Test plan: [1] Edit a record. Add a 500$a, 555$a and a URL in 555$u. Put "http://this is not a url" in the 500$a (whitespace!). [2] Check opac-detail, tab Title Notes. Check the URL. [3] Do the same for catalogue/detail. [4] Add record to cart in OPAC. Open basket. Check More details. [5] Repeat previous step in staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:39:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:39:18 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14306-70-pSH3nBhx6b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42011&action=edit Bug 14306: Follow-up for URLs in 555$u This patch removes the code for inserting the <a> anchor tags around URLs in GetMarcNotes (as added originally). The URLs are placed in separate array elements; the template should take care of further handling. The unit test has been adjusted accordingly. Test plan: Run the unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:39:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:39:25 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff) In-Reply-To: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14306-70-ACrVfHLJtm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42013&action=edit Bug 14306: Remove call to GetMarcNotes from sendshelf Just as mentioned in the first patch for sendbasket, I discovered that the call of GetMarcNotes is not really used in sendshelf. The array is passed to the template, but the template does not use it. (It uses the information from GetBiblioData.) Test plan: [1] Send a list that includes a record with some notes (opac and staff). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:44:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:44:10 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14306-70-gTQA5K1jXU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show URL from MARC21 field |Show URL from MARC21 field |555$u under Title Notes |555$u in basket and detail |(OPAC) or Descriptions | |(Staff) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:52:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:52:10 +0000 Subject: [Koha-bugs] [Bug 13891] Make all patron searches use DataTables server-side processing In-Reply-To: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13891-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13891-70-RNuy28ytjE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14739 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14739 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 [Bug 14739] Regression on adding several patrons to a new batch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:52:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:52:10 +0000 Subject: [Koha-bugs] [Bug 14739] Regression on adding several patrons to a new batch In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-g9gk0hLC3z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13891 Depends on|13891 | --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Actually it's even worst, a new batch is created for each user you add. Note that this bug existed before bug 13891 (so in 3.18.x) Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13891 [Bug 13891] Make all patron searches use DataTables server-side processing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:52:40 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-Jg7pQPMT5T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression on adding |Add several patrons to a |several patrons to a new |new batch will create a new |batch |batch per patron added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:55:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:55:02 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-ox5ubtNIpU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41808|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42014&action=edit Bug 14526: Add some unit tests for MoveReserve The change in MoveReserve from the previous patch begs for a test. Here we add some to Reserves.t. In all six tests we place a hold, move it and check the reserves again. Depending on the status of ConfirmFutureHolds, and the reservedate the hold should be moved or not. Test plan: Run the unit test. Bonus: If you run Reserves.t by applying this patch but without the first patch that changed MoveReserve, tests 60 and 61 should fail: not ok 60 - MoveReserve filled future hold now not ok 61 - MoveReserve filled future waiting hold now This may further illustrate the need of the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 10:55:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 08:55:21 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-1xeP4eYQa9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Unit test rebased for 9809 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:05:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:05:12 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-8Wunko5hWs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12911 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Introduced by commit 2dd97f26c1e72bc35e29b1afd1fc38d301c48e9e Bug 12911: batch_id for new labels batches can be asssigned to several batches exists since 3.18.7. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 [Bug 12911] batch_id for new label batches can be assigned to several batches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:05:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:05:12 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: <bug-12911-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12911-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12911-70-p3ggB9fd4y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14739 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 [Bug 14739] Add several patrons to a new batch will create a new batch per patron added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:07:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:07:42 +0000 Subject: [Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches In-Reply-To: <bug-12911-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12911-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12911-70-GCLJgYxI6J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- > Test plan: > 1 -In one browser window, go to tools->label creator and click the new batch > button > 2 - Before adding items, open a new browser, and go tools->label creator and > click the new batch button > 3 - Note that both batches have the same number listed > 4 - Add an item to the first batch - you should now see one item in the batch > 5 - Add an item to the second batch, you should see two items in the batch > 6 - Apply patch and repeat steps 1&2 > 7 - Note that neither batch lists a batch number > 8 - Add an item to the first batch, you should see one item and a batch > number > 9 - Add an item to the second batch, you should see one item and a new batch > number But does not work if you add a second item! See bug 14739 and please provide a quick fix. This bug is much more annoying than the one fixed by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:07:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:07:53 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-j76ce1Dxgn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |nick at quecheelibrary.org |ommunity.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:14:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:14:44 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-m4Q1CHsjYr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9809 --- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Conflicts with bug 9809. Don't forget to uptade AddReserve calls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:14:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:14:44 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-mG9SjMIuzt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7957 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:22:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:22:50 +0000 Subject: [Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac In-Reply-To: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-GLAGlLfwus@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I would prefer to see a version of this patch using sessionStorage instead of cookies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:27:06 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-XxBmfwiOJy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42005|0 |1 is obsolete| | --- Comment #23 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42015&action=edit Bug 14702: Refactor GetReserveFee Test plan worked, did also my own tests. Code was also doing the same things as before. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:28:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:28:33 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-zRlvlXOQ0K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #24 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Marcel, in unit test could you add the license in the top of the file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:35:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:35:09 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-GZjrfNiV2Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Joonas Kylm?l? from comment #24) > Marcel, in unit test could you add the license in the top of the file. Does it block your signoff ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:38:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:38:53 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-Q1tLIqvaJs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42006|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42016&action=edit Bug 14702: Unit tests for GetReserveFee and ChargeReservesFee Test plan: Run the test: t/db_dependent/Reserves_Fee.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:39:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:39:48 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-rstBopE6Ao@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #25) > (In reply to Joonas Kylm?l? from comment #24) > > Marcel, in unit test could you add the license in the top of the file. > > Does it block your signoff ? I added it now, but note that a lot of unit tests do not contain the copyright block.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:41:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:41:18 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-oWeaRViGMh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9809 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 [Bug 9809] Get rid of reserveconstraints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 11:41:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 09:41:18 +0000 Subject: [Koha-bugs] [Bug 9809] Get rid of reserveconstraints In-Reply-To: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9809-70-7xCL2faWp9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14702 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 [Bug 14702] Refactor GetReserveFee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 12:15:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 10:15:40 +0000 Subject: [Koha-bugs] [Bug 14740] New: Cataloging plugins: remove no warnings redefine Message-ID: <bug-14740-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14740 Bug ID: 14740 Summary: Cataloging plugins: remove no warnings redefine Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Just a reminder here: $ git grep "redefine" * barcode.pl:no warnings 'redefine'; # otherwise loading up multiple plugins fills barcode_manual.pl:no warnings 'redefine'; # otherwise loading up multiple plugin cn_browser.pl:no warnings 'redefine'; dateaccessioned.pl:no warnings 'redefine'; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 12:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 10:15:55 +0000 Subject: [Koha-bugs] [Bug 14740] Cataloging plugins: remove no warnings redefine In-Reply-To: <bug-14740-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14740-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14740-70-Bi8pD2Jn4h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14740 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |ASSIGNED Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 12:25:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 10:25:01 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-e078eCNGh5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42016|0 |1 is obsolete| | --- Comment #28 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42017&action=edit Bug 14702: Unit tests for GetReserveFee and ChargeReservesFee Test plan worked, code looks now great with the license! Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 12:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 10:25:39 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-Y92kckJUbU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 12:33:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 10:33:46 +0000 Subject: [Koha-bugs] [Bug 14432] Resolve warnings from marc21 framework plugins In-Reply-To: <bug-14432-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14432-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14432-70-wcryUPKy54@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14432 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- marc21_field_007 is kinda noisy substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 73. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 74. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 75. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 76. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 77. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 78. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 79. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 80. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 81. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 82. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 83. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 84. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 85. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 86. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 87. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 88. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 89. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 90. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 91. substr outside of string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 92. Use of uninitialized value $f3 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f4 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f5 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f6 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f7 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f8 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f9 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f10 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f11 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f12 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f13 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f14 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f15 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f16 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f17 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f18 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f19 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f20 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f21 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. Use of uninitialized value $f22 in concatenation (.) or string at /srv/jenkins/workspace/Koha_Master_D7/cataloguing/value_builder/marc21_field_007.pl line 99. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 12:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 10:51:09 +0000 Subject: [Koha-bugs] [Bug 13971] Adjusted locations in koha-rebuild-zebra for gitified instance In-Reply-To: <bug-13971-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13971-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13971-70-GZWjjMDXD5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Looks good to me. I would like to get a signoff from Robin or Chris Hall to be more comfortable before passing QA on it. Is there an easy way to know if an instance has been gitified? It will avoid to manually add a new entry to the koha-conf file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 13:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 11:45:04 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13592-70-SjRfgnIMSt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #8 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Katrin Fischer from comment #7) > I think this could be something for the mailing lists - wonder if people are > aware of current behaviour and if someone can explain "why". Now it is: https://lists.katipo.co.nz/pipermail/koha/2015-August/043527.html :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 13:49:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 11:49:56 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13592-70-p043a20DQz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Please note that the sub has been refactored (without changing behavior but at least increasing readability) on bug 14702 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 13:50:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 11:50:46 +0000 Subject: [Koha-bugs] [Bug 14702] Refactor GetReserveFee In-Reply-To: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14702-70-c0Q6PRXlsY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13592 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 13:50:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 11:50:46 +0000 Subject: [Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold In-Reply-To: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13592-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13592-70-z9LlKTAWiQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14702 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:20:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:20:18 +0000 Subject: [Koha-bugs] [Bug 14308] Remove CGI::checkbox from subfield editors In-Reply-To: <bug-14308-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14308-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14308-70-yz1Ujnwkro@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14308 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Bernardo, There is some problem in the authority side of this. I cannot add a new subfield. I saw that existing data was overwritten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:23:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:23:07 +0000 Subject: [Koha-bugs] [Bug 14700] batch_id is not correctly populated on patron card creation In-Reply-To: <bug-14700-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14700-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14700-70-q27TTvFJRP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14700 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |nick at quecheelibrary.org --- Comment #1 from Nick Clemens <nick at quecheelibrary.org> --- *** This bug has been marked as a duplicate of bug 14739 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:23:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:23:07 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-XGaTdldx7m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Nick Clemens <nick at quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #3 from Nick Clemens <nick at quecheelibrary.org> --- *** Bug 14700 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:30:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:30:39 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-0QQEVlvxEu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41175|0 |1 is obsolete| | --- Comment #71 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 42018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42018&action=edit Bug 12252 - OAI-PMH result includes item data [SIGNED-OFF] GetRecord for OAI-PMH was pulling the MARCXML directly from the database. Now it uses GetMarcBiblio and includes the item data with it, making it more generally useful. Test plan: * Run an OAI-PMH query, for example: http://koha/cgi-bin/koha/oai.pl?verb=GetRecord&identifier=KOHA-OAI-TEST:52&metadataPrefix=marcxml to fetch biblionumber 52 * Note that it doesn't include the 952 data * Apply the patch * Do the same thing, but this time see that the 952 data is at the bottom of the MARCXML. Note: * This patch also includes a small tidy-up in C4::Biblios to group things semantically a bit better, so I don't spend ages looking for a function that was staring me in the face all along again. Signed-off-by: David Cook <dcook at prosentient.com.au> Works as described. Simple yet useful patch. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Frederic Demians <f.demians at tamil.fr> 952/995 item fields are back in response to GetRecord OAI verb. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Admin User Koha <koha at matrice_wheezy> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:30:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:30:41 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-tXXJEQts8K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #4 from Nick Clemens <nick at quecheelibrary.org> --- I tried an easy fix (update batch_id after adding an item), but if a user clicks on several patrons to add without waiting for background page to reload the batch_id doesn't have time to update. Barton said he is taking a look today and I will touch base with him when I get in this afternoon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:30:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:30:53 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-vR3wYAjo8D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41176|0 |1 is obsolete| | --- Comment #72 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 42019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42019&action=edit Bug 12252 - OAI-PMH items respect OpacHiddenItems [SIGNED-OFF] This allows the OAI-PMH service to not provide item information when there is a rule that would supress it in OpacHiddenItems. Test plan: * Find an OAI-PMH URL that shows you some items. * Add an entry to OpacHiddenItems that would block that. * Check that it's blocked. Signed-off-by: Frederic Demians <f.demians at tamil.fr> Tested, playing with OpacHiddenItems. GetRecord OAI verb returns a record complying with OpacHiddenItems rules, for example without items from a specific library. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Admin User Koha <koha at matrice_wheezy> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:31:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:31:05 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-k74Z8vhjQD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41177|0 |1 is obsolete| | --- Comment #73 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 42020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42020&action=edit Bug 12252 - include item data in OAI-PMH ListRecords result [SIGNED-OFF] Same in spirit to the other patch, this also includes the item detail in ListRecords. Test plan: * Fetch a URL like: http://koha/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml * Verify that there are 952 entries in the returned records where appropriate. Signed-off-by: Frederic Demians <f.demians at tamil.fr> ListRecords OAI verb returns a list of records including items in 952/995 which are not hidden based on OpacHiddenItems syspref. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Admin User Koha <koha at matrice_wheezy> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:31:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:31:36 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-YYsIHa9YJp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41179|0 |1 is obsolete| | --- Comment #75 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 42022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42022&action=edit Bug 12252: (qa-follow-up) Remove perlcritic error [SIGNED-OFF] Signed-off-by: Admin User Koha <koha at matrice_wheezy> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:31:17 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-aXXAhC0vtG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41178|0 |1 is obsolete| | --- Comment #74 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 42021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42021&action=edit Bug 12252: Add tests for EmbedItemsInMarcBiblio [SIGNED-OFF] Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Admin User Koha <koha at matrice_wheezy> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:31:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:31:50 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-ZEhYPpGVnA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41180|0 |1 is obsolete| | --- Comment #76 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 42023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42023&action=edit Bug 12252 Include item data only in extended mode [SIGNED-OFF] Previous patches attached to this bug have been refactored to merge bug 3206 and bug 13568 features. So OAI server must be carrefully tested to ensure that there is no regression in this area: deleted records and resumption token. This last patch fixed the way items are returned. They are returned only if OAI server operates in extended mode, and specifically for format having the parameter include_item set to 1 (true). For example this configuration file set via OAI-PMH:ConfFile syspref will return items: Signed-off-by: Admin User Koha <koha at matrice_wheezy> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:32:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:32:01 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-pnJx8UJiyq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #77 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 42024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42024&action=edit Bug 12252: (follow-up) Fix error raised on comment 69 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252#c69 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:37:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:37:03 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-UqX66zDqXz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |alex.arnaud at biblibre.com --- Comment #78 from Alex Arnaud <alex.arnaud at biblibre.com> --- I have rebased this patch because i didn't manage to apply them (with or without git-bz) and added a follow up to fix the error on comment 69. However, i didn't understand the way the OAI server's config file works. I created a YAML file containing only "include_items: 1" and now i get an error while retrieving a record: <error code="cannotDisseminateFormat">Dissemination as 'oai_dc' is not supported</error> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:40:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:40:30 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-MNLg7G6g8T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I think the easier and cleaner way to do would be to create (and so get an id) the batch when the "Add items" button is clicked. It's not perfect, but I don't see another way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:44:20 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to be visible In-Reply-To: <bug-13757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13757-70-wYCETvwauG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jweaver at bywatersolutions.co | |m CC| |nengard at gmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:44:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:44:31 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to be visible In-Reply-To: <bug-13757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13757-70-JePxMwHdqu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:44:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:44:48 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to be visible In-Reply-To: <bug-13757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13757-70-Hulup27pFE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:47:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:47:38 +0000 Subject: [Koha-bugs] [Bug 14741] New: Set permissions doesn't tick the top level check box and doesn't clear child check boxes Message-ID: <bug-14741-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 Bug ID: 14741 Summary: Set permissions doesn't tick the top level check box and doesn't clear child check boxes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Set permissions doesn't tick the top level check box and doesn't always clear child check boxes. How to reproduce this bug: 1. Go to /cgi-bin/koha/members/member-flags.pl?member=<borroweid> / search for some patron and click set permissions from the more menu. 2. Choose all child checkboxes of some top level checkbox 3. Notice that the top level check box didn't got the tick automatically. 1. 1. Go to /cgi-bin/koha/members/member-flags.pl?member=<borroweid> / search for some patron and click set permissions from the more menu. 2. Choose all child checkboxes of some top level checkbox 3. Check the top level check box 4. Uncheck the top level check box 5. Notice that the child checkboxes didn't become unchecked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:48:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:48:54 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-WElJhnL09e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41885|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42025&action=edit Bug 14703: Holidays description shows \r\n for every new line Adds a new line for the holiday's description instead of the string \r\n. Test plan: 1. In tools -> Calendar look at some holiday's description (Do a new holiday with description of multiple lines if there is not already) 2. Notice that there is characters \r\n if someone has put a newline in the holiday's description 3. Apply patch 4. See that the new lines show there now nicely Sponsored-by: Vaara-kirjastot Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Amended slightly: no need to replace title. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:49:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:49:15 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-lyZ9NiAUZO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:51:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:51:55 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-bZArcPdR2s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Taking the liberty to promote this trivial patch to PQA directly. Thanks, Joonas. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:52:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:52:19 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-P76xYB2s6Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |j.kylmala at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 14:57:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 12:57:23 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14739-70-ZwQ5edpj14@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:02:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:02:36 +0000 Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number In-Reply-To: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14683-70-ZpECARcM4N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |j.kylmala at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:34:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:34:00 +0000 Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number In-Reply-To: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14683-70-qEIGUZkC7T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Still testing this, still see an issue here. Finish it tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:35:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:35:21 +0000 Subject: [Koha-bugs] [Bug 14720] build_holds_queue.pl error In-Reply-To: <bug-14720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14720-70-VdBtjpgzW2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14720 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- In latest master it is for some reason now gone. Or maybe there was some problem with my db. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:37:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:37:12 +0000 Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch In-Reply-To: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14297-70-6g5wfSFdJB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41110|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42026&action=edit Bug 14297 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:37:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:37:18 +0000 Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch In-Reply-To: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14297-70-QN9Cv5QAYd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42027&action=edit Bug 14297 - Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch If a record has a hold on it where the pickup and home branch do not match, the holds queue builder will only look at items from the least cost branch ( as defined by the transport cost matrix or the sys pref StaticHoldsQueueWeight. Test Plan: 1) Create a record with two items, one for library A and one for library B 2) Set your circulation rules such that the book from library A is holdable by all and the book from library B is holdable only by library B patrons 3) Create a hold for a Library C patron for pickup at library C 4) Set the syspref StaticHoldsQueueWeight to by Library B, Library A, Library C in that order 5) Rebuild the holds queue 6) Note the hold wasn't picked up even though the item from library A could have filled the hold 7) Apply this patch 8) Rebuild the holds queue 9) View the holds queue again 10) Note the hold now displays Signed-off-by: Nora Blake <nblake at masslibsystem.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:37:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:37:26 +0000 Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch In-Reply-To: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14297-70-Ss2NVEShOG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:37:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:37:32 +0000 Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch In-Reply-To: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14297-70-UBTiYiwSFt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:39:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:39:04 +0000 Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch In-Reply-To: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14297-70-HbhTaM0jXL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42026|0 |1 is obsolete| | Attachment #42027|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42028&action=edit Bug 14297 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:39:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:39:11 +0000 Subject: [Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch In-Reply-To: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14297-70-69sR94NlsH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42029&action=edit Bug 14297 - Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch If a record has a hold on it where the pickup and home branch do not match, the holds queue builder will only look at items from the least cost branch ( as defined by the transport cost matrix or the sys pref StaticHoldsQueueWeight. Test Plan: 1) Create a record with two items, one for library A and one for library B 2) Set your circulation rules such that the book from library A is holdable by all and the book from library B is holdable only by library B patrons 3) Create a hold for a Library C patron for pickup at library C 4) Set the syspref StaticHoldsQueueWeight to by Library B, Library A, Library C in that order 5) Rebuild the holds queue 6) Note the hold wasn't picked up even though the item from library A could have filled the hold 7) Apply this patch 8) Rebuild the holds queue 9) View the holds queue again 10) Note the hold now displays Signed-off-by: Nora Blake <nblake at masslibsystem.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:40:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:40:15 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: <bug-14509-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14509-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14509-70-qI7yYmN7To@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14620 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:40:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:40:15 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-RbnHsouBPp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14509 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 15:45:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 13:45:31 +0000 Subject: [Koha-bugs] [Bug 14742] New: 082 field corrupt in FA Framework in new installs Message-ID: <bug-14742-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14742 Bug ID: 14742 Summary: 082 field corrupt in FA Framework in new installs Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In a new install of Koha, the 082 field doesn't display in the FA framework, yet when you try adding a catalogue record using that framework the 082 displays (without a field description). This problem is caused by the following row in the marc_tag_structure table: | 082 | DEWEY DECIMAL CLASSIFICATION NUMBER | DEWEY DECIMAL CLASSIFICATION NUMBER | 1 | 0 | NULL | | To fix it, you need to use the following SQL: update marc_tag_structure set frameworkcode = 'FA' where tagfield = '082 ' and frameworkcode = ''; This alters the row to the following: | 082 | DEWEY DECIMAL CLASSIFICATION NUMBER | DEWEY DECIMAL CLASSIFICATION NUMBER | 1 | 0 | NULL | FA | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:00:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:00:06 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-SslzX4jd7W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #75 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42030&action=edit opac_search_for_d_sort_by_relevance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:00:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:00:03 +0000 Subject: [Koha-bugs] [Bug 14743] New: addorder.pl redirect problems under plack behind apache 2.4.10 Message-ID: <bug-14743-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Bug ID: 14743 Summary: addorder.pl redirect problems under plack behind apache 2.4.10 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump): HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:28:41 GMT Server: Apache/2.4.10 (Debian) Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610 Vary: User-Agent Content-Length: 0 Keep-Alive: timeout=5, max=98 Connection: Keep-Alive Content-Type: text/x-perl However, when running behind apache 2.4.10 on Debian wheezy I see chunked response: HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:21:28 GMT Server: Apache/2.4.10 (Debian) Vary: User-Agent Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Transfer-Encoding: chunked Content-Type: text/x-perl 60 Transfer-Encoding: chunked Date: Thu, 27 Aug 2015 13:21:28 GMT Connection: keep-alive 0 0 This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen). Solution is (for now) to exclude addoprder.pl from proxypass using: ProxyPass /cgi-bin/koha/acqui/addorder.pl ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:00:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:00:37 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-Krx8Poofkb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #76 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42031&action=edit opac_search_for_d_sort_by_title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:01:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:01:00 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-mBNpbFwj2b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #77 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42032&action=edit opac_search_for_harry_sort_by_title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:01:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:01:15 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-7SbPMjTPGq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42033&action=edit limit_by_book_sort_by_pubdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:01:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:01:41 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-E3edOP8hUH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #79 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Me again :) So, I have tried to do some tests locally using your branch (OPAC biblio search only). The first problem I got was to find a MARC21 DB (since the UNIMARC mappings are not defined, I cannot test with an UNIMARC DB). I have used the one created for the sandboxes (http://git.koha-community.org/gitweb/?p=contrib/global.git;a=blob;f=sandbox/sql/sandbox1.sql.gz;h=19268bccb43b2a33d5644b7d86cbb1abb323016b;hb=HEAD). But there are only 436 biblios, it's not enough to test some stuffs (facets for instance). Or maybe you can share your DB? Here some notes: 1/ Add deps to C4/Installer/PerlDependencies.pm 2/ The number of tests provided is very low. 3/ catalyst/elastic_search is 1004 commits behind origin/master, please rebase 4/ The message "No 'elasticsearch' block is defined in koha-conf.xml" should be raised before starting the indexation process, and not on commiting the first batch. 5/ You really need to tune the default value for the commit :) commit 100: perl misc/search_tools/rebuild_elastic_search.pl -b 77.57s user 0.86s system 91% cpu 1:25.62 total commit 1000: perl misc/search_tools/rebuild_elastic_search.pl -b 24.68s user 0.52s system 79% cpu 31.595 total For Solr, we used 5000. Yes I know, it's configurable. 6/ Verbose does not work as expected, it could be fixed with - print $msg if ($verbose <= $level); + print $msg if ($verbose >= $level); 7/ perl -e "use Pod::Checker;podchecker('misc/search_tools/rebuild_elastic_search.pl')"; *** WARNING: empty section in previous paragraph at line 36 in file misc/search_tools/rebuild_elastic_search.pl *** ERROR: =over on line 38 without closing =back at line EOF in file misc/search_tools/rebuild_elastic_search.pl 8/ 2 occurrences of "Solr" reintroduced in installer/data/mysql/sysprefs.sql and koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref 9/ Test! I have launched some searches, with the same DB (the one from the sandbox). On a local using your remote branch and another one using master (sandbox7 provided by BibLibre). a. Search for 'd' (screentshot opac_search_for_d_sort_by_relevance.png ES on the left, Zebra on the right). Main differences: - 183 vs 182 results (?) - the order is not the same (make sense) - Locations and Places facets are missing - 6 entries are displayed in the facets for ES (current behavior is 5). b. Search for 'd', sort by title AZ (screenshot opac_search_for_d_sort_by_title.png) - Zebra displayes only 1 facet - The order is still completely different c. Search for 'harry', sort by title AZ (screenshot opac_search_for_harry_sort_by_title.png) - 'Show more' links is displayed even if only 2 entries for a facet are available - The order is still different ("The discovery of heaven" should be sorted either before Dollhouse (if the is a stopword) either after "Hareios*" - The availability is wrong for ES (The item for Dollhouse is not for loan) d. Search for Books (limit by item type in the adv search), sort by pubdate (screenshot limit_by_book_sort_by_pubdate.png) - "Return to the last advanced search" link is not displayed - The item types facet contains several entries, which does not make sense - The number of results highly differ (395 vs 364) - The order is still completely different. I had a look in the index and found: "Pictura mural?*" has "pubdate":"||||" (/_search?q=_id:39&pretty) The Korean Go Association's learn to play go "pubdate":"uuuu" (/_search?q=_id:155&pretty) Where do come from these values? Shouldn't be a date, or at least an integer? It's not easy to know what is indexed where. Did you have a look at the indexes configuration page the Solr stuff had? It provided an interface to configure the different mappings, it was very useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:12:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:12:35 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-APhT4JU7TX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- IMO this should be done after the input (and correct the values in DB), not on display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:26:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:26:57 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-o10UAnVFqy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 --- Comment #5 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Jonathan Druart from comment #4) > IMO this should be done after the input (and correct the values in DB), not > on display. I tried that in a way that I left the new line character there, but then there was some JavaScript which refused to work with that. And if we put the <br> tag in the database I'm not sure if it will show in the description as the string <br> or as a new line. Let me try that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:28:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:28:44 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-obb7L7A8Cm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 --- Comment #6 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Joonas Kylm?l? from comment #5) > (In reply to Jonathan Druart from comment #4) > > IMO this should be done after the input (and correct the values in DB), not > > on display. > > I tried that in a way that I left the new line character there, but then > there was some JavaScript which refused to work with that. And if we put the > <br> tag in the database I'm not sure if it will show in the description as > the string <br> or as a new line. Let me try that. But wait, I think I tried that and the <br> will show in the edit text box as <br>.. So I came to the conclusion that it's much more better to have the fix in only one place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:39:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:39:17 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-0UryFL666B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:39:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:39:20 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-ObAjtVQowc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 42034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42034&action=edit Bug 14737: wrong permissions required for cn_browser.pl plugin The cn_browser.pl cataloguing plugin only searches for used callnumbers on the bibliographic database. There is no need for this plugin to require special permissions besides access to the catalog. To test: - Link the cb_browser.pl cataloguing plugin to 952$o in your favourite cataloguing framework - Login with a superlibrarian user - Try the plugin => SUCCESS: you can use it - Login with a user that has the full 'tools' permission - Try the plugin => SUCCSES: you can use it - Login with a user that doesn't have full 'tools' permission but has the normal catalogue and cataloguing permissions. - Try the plugin => FAIL: you are requested to login with a different user - Apply the patch - Retry => SUCCESS: you can use it - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:58:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:58:06 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13411-70-daS2uLdLBs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40952|0 |1 is obsolete| | Attachment #40953|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42035&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 16:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 14:58:13 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13411-70-wOF5DyFIGi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42036&action=edit Bug 13411 [QA Followup] - Add logging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:19:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:19:23 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-KIsk1UBHVi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Forget the idea if it's not easy to do :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:20:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:20:04 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-kbMZHZ9jXC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:20:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:20:14 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-UmhM1L0MfH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |tomascohen at gmail.com |ommunity.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:23:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:23:43 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-urp2d1Me7R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:23:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:23:45 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-LeDTJk4zR8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42034|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42037&action=edit Bug 14737: wrong permissions required for cn_browser.pl plugin The cn_browser.pl cataloguing plugin only searches for used callnumbers on the bibliographic database. There is no need for this plugin to require special permissions besides access to the catalog. To test: - Link the cb_browser.pl cataloguing plugin to 952$o in your favourite cataloguing framework - Login with a superlibrarian user - Try the plugin => SUCCESS: you can use it - Login with a user that has the full 'tools' permission - Try the plugin => SUCCSES: you can use it - Login with a user that doesn't have full 'tools' permission but has the normal catalogue and cataloguing permissions. - Try the plugin => FAIL: you are requested to login with a different user - Apply the patch - Retry => SUCCESS: you can use it - Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:41:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:41:09 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13364-70-MsZFpEZYbe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14737 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:41:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:41:09 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-xf7vdORCT1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13364 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 [Bug 13364] Add a call number browser to add item page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:41:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:41:42 +0000 Subject: [Koha-bugs] [Bug 14744] New: Cannot select guarantor when quote in one of the fields Message-ID: <bug-14744-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Bug ID: 14744 Summary: Cannot select guarantor when quote in one of the fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a field (here it's the branch name) contains a quote, the Select button doesn't work in guarantor_search.pl. For example, if our branch is "Biblioth?que d'Avignon", the resulting json in the link is all broken and the "select" does nothing. Setup: - Have a Child patron and Adult patron in your DB. - In Admin/Libraries and Group, modify the name to add a ' in the middle. Test: - Modify your child patron. - The second section should be "Guarantor Information" - Click the "Set to patron" button - Enter the info to find your adult - In the resulting list, click the Select at the end of the line - Nothing will happen - Hover over the link, you'll see the gibberish inside. - Remove the ' from the branch name. Do the steps above. Everything is alright. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:42:35 +0000 Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one of the fields In-Reply-To: <bug-14744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14744-70-jz0e9oKmqk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Blou <philippe.blouin at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com |ity.org | CC| |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:43:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:43:48 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14217-70-7v32oal1lb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #3 from Barton Chittenden <barton at bywatersolutions.com> --- (In reply to Tom?s Cohen Arazi from comment #2) > To test: > - Verify that the shipped XSLT files are current regarding the shipped index > definitions: > $ for i in marc21 normarc unimarc; do > xsltproc etc/zebradb/xsl/xsl/koha-indexdefs-to-zebra.xsl \ > etc/zebradb/marc_defs/$i/biblios/biblio-koha-indexdefs.xml \ > > etc/zebradb/marc_defs/$i/biblios/biblio-zebra-indexdefs.xsl > done Small change in test plan: etc/zebradb/xsl/xsl/koha-indexdefs-to-zebra.xsl should be etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl so the first step in the test plan becomes. - Verify that the shipped XSLT files are current regarding the shipped index definitions: $ for i in marc21 normarc unimarc; do xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/$i/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/$i/biblios/biblio-zebra-indexdefs.xsl done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 17:48:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 15:48:49 +0000 Subject: [Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set In-Reply-To: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14529-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14529-70-72g7ATwTBZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:02:12 +0000 Subject: [Koha-bugs] [Bug 14726] Title not showing up on checkout summary In-Reply-To: <bug-14726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14726-70-N84FYOGjc6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14726 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:10:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:10:33 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-bs2arDbZj6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6756 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:10:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:10:33 +0000 Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success In-Reply-To: <bug-6756-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6756-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6756-70-ATn1skLFlc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14655 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:16:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:16:57 +0000 Subject: [Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date In-Reply-To: <bug-14717-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14717-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14717-70-A6cwVd1jTR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:19:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:19:00 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13791-70-cUTOjW7xOa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 --- Comment #48 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 42038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42038&action=edit Bug 13791: (RM followup) Add new dependencies for packaging Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:21 +0000 Subject: [Koha-bugs] [Bug 11944] Cleanup Koha UTF-8 In-Reply-To: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11944-70-l713pITVmR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #295 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- This bug is resolved already. The major refactoring it involved is already in 3.20 and further bugs / fixes should belong to their own bug reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:22 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: <bug-7380-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7380-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7380-70-E89BIXDIeX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Bug 7380 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:23 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10855-70-IlbPEiWHGI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Bug 10855 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:24 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-hzsLVqiHH1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Bug 11844 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:24 +0000 Subject: [Koha-bugs] [Bug 12176] Remove HTML from additem.pl In-Reply-To: <bug-12176-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12176-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12176-70-ZOnZMk52vL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bug 12176 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:25 +0000 Subject: [Koha-bugs] [Bug 12832] Basketgroup printing doesn't support no latin chars In-Reply-To: <bug-12832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12832-70-jPBRthWEMI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12832 Bug 12832 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:25 +0000 Subject: [Koha-bugs] [Bug 13239] MySQL Character encoding utf8 In-Reply-To: <bug-13239-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13239-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13239-70-toaCQjfVKn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13239 Bug 13239 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:26 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: <bug-13345-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13345-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13345-70-cUkns9XwhS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bug 13345 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:26 +0000 Subject: [Koha-bugs] [Bug 13577] The correct COLLATE is not set to all DB tables In-Reply-To: <bug-13577-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13577-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13577-70-BMmUWA9LfM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13577 Bug 13577 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:28 +0000 Subject: [Koha-bugs] [Bug 13646] Facets encoding problem with GRS1 In-Reply-To: <bug-13646-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13646-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13646-70-trw8LOoZue@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13646 Bug 13646 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:27 +0000 Subject: [Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8 In-Reply-To: <bug-13596-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13596-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13596-70-m3a8IIIuug@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Bug 13596 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:28 +0000 Subject: [Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation In-Reply-To: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13810-70-p92kbSZ2wo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 Bug 13810 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:28 +0000 Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding everywhere In-Reply-To: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13815-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13815-70-gRh41jCVs0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815 Bug 13815 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:29 +0000 Subject: [Koha-bugs] [Bug 13934] Check in fails on master "Can't bless non-reference at .../ItemType.pm Line 64" In-Reply-To: <bug-13934-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13934-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13934-70-zYiUwtMUdA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13934 Bug 13934 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:29 +0000 Subject: [Koha-bugs] [Bug 14431] Encoding issues - search in staff In-Reply-To: <bug-14431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14431-70-qnm6JJ4JAJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14431 Bug 14431 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:30 +0000 Subject: [Koha-bugs] [Bug 12637] UTF-8 problems when creating a patron list from the patron search results page In-Reply-To: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12637-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12637-70-qyHtzvgr0s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12637 Bug 12637 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:24:30 +0000 Subject: [Koha-bugs] [Bug 13579] History file should be open using utf-8 encoding In-Reply-To: <bug-13579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13579-70-8wRf46lrvP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13579 Bug 13579 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:27:02 +0000 Subject: [Koha-bugs] [Bug 14634] Warns when placing hold on record with no items In-Reply-To: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14634-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14634-70-Mq2ISgkSMg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:28:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:28:12 +0000 Subject: [Koha-bugs] [Bug 14579] 'You are not logged in' should link to log in page In-Reply-To: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14579-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14579-70-zmRHeEo00h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14579 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Joonas, and congratulations for your first commit in Koha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:31:08 +0000 Subject: [Koha-bugs] [Bug 14745] New: RDA: RDA Registry metadata Message-ID: <bug-14745-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14745 Bug ID: 14745 Summary: RDA: RDA Registry metadata Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: hector.hecaxmmx at gmail.com Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org RDA Registry is a set of metadata to serialize RDA metadata and MARC records in other formats, using the constrained and uncostrained elements of RDA. You can see examples in turtle (text/turtle) in <http://www.rdaregistry.info/Examples/> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:34:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:34:53 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-QjRbQoySzh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:35:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:35:32 +0000 Subject: [Koha-bugs] [Bug 13364] Add a call number browser to add item page In-Reply-To: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13364-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13364-70-GCykmGs2Sw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:35:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:35:33 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-5scwzPHoA9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Bug 14737 depends on bug 13364, which changed state. Bug 13364 Summary: Add a call number browser to add item page http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:36:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:36:50 +0000 Subject: [Koha-bugs] [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects In-Reply-To: <bug-14645-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14645-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14645-70-ej3xbGeN0i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #1 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- Hi, Tom?s, I'm working in Dublin Core with serialization formats in bug <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642>. With a DublinCore.pm module, my question is if I go in the right way and can continue with this bug or I can help you in something in this new bug? Right now i'll upgrade the code for Dublin Core since some new modules had been added to Koha. Regards PS: Also I want to start working with the RDA Registry metadata <http://www.rdaregistry.info/> to serialize in constrained and unconstrained metadata. I will start to work with mapping MARC with BIBFRAME <http://bibframe.org/> in the near future. I filed a new bug for RDA Registry at <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14745> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:39:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:39:52 +0000 Subject: [Koha-bugs] [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects In-Reply-To: <bug-14645-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14645-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14645-70-IjxqVGK382@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 --- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- A BIBFRAME bug has been filed by Nicole at <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:43:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:43:00 +0000 Subject: [Koha-bugs] [Bug 14239] Bibframe support in Koha In-Reply-To: <bug-14239-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14239-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14239-70-rKXptO91Tu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:48:23 +0000 Subject: [Koha-bugs] [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects In-Reply-To: <bug-14645-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14645-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14645-70-nqUQ7QOVdz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 --- Comment #3 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- Magnus opened up a bug about serialization too. <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7236> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:51:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:51:36 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-6GuvMug3Ke@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:57:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:57:52 +0000 Subject: [Koha-bugs] [Bug 14746] New: Set up logging and configuration file reading for Mojolicious Message-ID: <bug-14746-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14746 Bug ID: 14746 Summary: Set up logging and configuration file reading for Mojolicious Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: olli-antti.kivilahti at jns.fi Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 13799 Use environmental values to control some aspects of Mojolicious: This way we can have different settings for different servers running Mojolicious. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 18:57:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 16:57:52 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-KZQhmtblPE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14746 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14746 [Bug 14746] Set up logging and configuration file reading for Mojolicious -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:00:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:00:13 +0000 Subject: [Koha-bugs] [Bug 14746] Set up logging and configuration file reading for Mojolicious In-Reply-To: <bug-14746-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14746-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14746-70-u98eiviW5v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14746 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 42039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42039&action=edit Bug 14746: Set up logging and configuration file reading for Mojolicious Use environmental values to control some aspects of Mojolicious: This way we can have different settings for different servers running Mojolicious. %%%% Configuration file %%%% $ENV{MOJO_CONFIG} should be set in the system service (init) starting Mojolicious, eg: export MOJO_CONFIG=/home/koha/kohaclone/api/v1/hypnotoad.conf This configuration file read by the Mojolicious::Plugin::Config http://mojolicio.us/perldoc/Mojolicious/Plugin/Config %%%%% Logging %%%%% >NOTE!! >There is a "feature" in Mojo::Server disabling STDOUT and STDERR, >because such errors are not-suited-for-prod~ >This modification in Mojo::Server disables this and preserves the STD* >handles for forked server threads >in Mojo::Server::daemonize(), comment out the following lines > ># Close filehandles ># open STDOUT, '>/dev/null'; ># open STDERR, '>&STDOUT'; Log to a filename configured in an environemnt variable $ENV{MOJO_LOGFILE} using loglevel $ENV{MOJO_LOGLEVEL}. Defaults to '/tmp/koha-api.log' and loglevel of 'error' Examples: export MOJO_LOGFILE=/home/koha/koha-dev/var/log/kohaapi.mojo.log export MOJO_LOGLEVEL=debug Logging is done by Mojo::Log http://www.mojolicio.us/perldoc/Mojo/Log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:01:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:01:14 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-lf75lU0xmi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41540|0 |1 is obsolete| | --- Comment #128 from Julian Maurice <julian.maurice at biblibre.com> --- Comment on attachment 41540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41540 Bug 13799 - 2. Set up logging and configuration file reading for Mojolicious. Patch moved to bug 14746 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:02:29 +0000 Subject: [Koha-bugs] [Bug 14746] Set up logging and configuration file reading for Mojolicious In-Reply-To: <bug-14746-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14746-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14746-70-7ABiZif7vV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14746 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:04:18 +0000 Subject: [Koha-bugs] [Bug 14747] New: RESTful API with reverse proxy configuration Message-ID: <bug-14747-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747 Bug ID: 14747 Summary: RESTful API with reverse proxy configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: olli-antti.kivilahti at jns.fi Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 13799, 14448 RESTful API with reverse proxy configuration Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14448 [Bug 14448] Hypnotoad and Nginx config for REST API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:04:18 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-tQWhU6vbL4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14747 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747 [Bug 14747] RESTful API with reverse proxy configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:04:18 +0000 Subject: [Koha-bugs] [Bug 14448] Hypnotoad and Nginx config for REST API In-Reply-To: <bug-14448-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14448-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14448-70-plT6vWwvqM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14448 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14747 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747 [Bug 14747] RESTful API with reverse proxy configuration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:10:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:10:06 +0000 Subject: [Koha-bugs] [Bug 14747] RESTful API with reverse proxy configuration In-Reply-To: <bug-14747-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14747-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14747-70-u1MG9CtZ9y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 42040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42040&action=edit Bug 14747: RESTful API with reverse proxy configuration OPTIONAL replacement to the Bug 13799: RESTful API with Mojolicious and Swagger2 httpd-configuration. Instead of having to go to your dns-provider, you can run the api from your current virtualhost. Use these configurations to reverse proxy www.host.domain/v1/ to the REST API. --------------------------- :INSTALLATION INSTRUCTIONS: --------------------------- You need Bug 14448: Adding the REST API as a Hypnotoad service, koha-api-daemon. to deploy the backend Mojolicous application as a FastCGI-daemon. Then add the modifications from etc/koha-httpd.conf to your /etc/apache2/sites-enabled/koha.conf and adjust paths to fit. ..$ a2enmod proxy ..$ a2enmod proxy_http ..$ service apache2 restart Much recommended is Bug 14458: Add SwaggerUI documentation for RESTful API to browse your API capabilities. Then just go to /v1/doc to see the API autodocumentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:10:16 +0000 Subject: [Koha-bugs] [Bug 14747] RESTful API with reverse proxy configuration In-Reply-To: <bug-14747-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14747-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14747-70-yduhBP7OUo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:10:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:10:41 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-OKpgypfZFS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41539|0 |1 is obsolete| | --- Comment #129 from Julian Maurice <julian.maurice at biblibre.com> --- Comment on attachment 41539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41539 Bug 13799 - 1.1 RESTful API with reverse proxy configuration without api.host.domain Patch moved to bug 14747 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:22:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:22:25 +0000 Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13920-70-s5Ery8wE6R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41260|0 |1 is obsolete| | --- Comment #26 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 42041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42041&action=edit Bug 13920: API Authentication, part 1: API keys management in interface Depends on Bug 14539 and Bug 7174. This introduces the concept of API keys for use in the new REST API. A key is a string of 32 alphanumerical characters (32 is purely arbitrary, it can be changed easily). A user can have multiple keys (unlimited at the moment) Keys can be generated automatically, and then we have the possibility to delete or revoke each one individually. ApiKeys can be easily accessed using the Koha::ApiKeys-package. Includes unit tests and selenium integration tests for Intra and OPAC. Test plan: 1/ Go to staff interface 2/ Go to a borrower page 3/ In toolbar, click on More -> Manage API keys 4/ Click on "Generate new key" multiple times, check that they are correctly displayed under the button, and they are active by default 5/ Revoke some keys, check that they are not active anymore 6/ Delete some keys, check that they disappear from table 7/ Go to opac interface, log in 8/ In your user account pages, you now have a new tab to the left "your API keys". Click on it. 9/ Repeat steps 4-6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:22:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:22:38 +0000 Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13920-70-px2BSADCqp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41166|0 |1 is obsolete| | --- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 42042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42042&action=edit Bug 13920: API authentication system - Swagtenticator authentication Reads the Swagger2 definitions and defines the API routes and controllers for Mojolicious. Authentiates the API consumer using Koha::Auth::Challenge::RESTV1 with all the necessary details inferred from Swagger2, like permissions. Validates all input to match the Swagger2 definition. Authentication is based on the permissions defined in the Swagger2 definition. Add x-koha-permission to the Operation Object to define needed Koha permissions to access the resource. Eg. "/borrowers/{borrowernumber}": { "get": { "x-mojo-controller": "Koha::REST::V1::Borrowers", "x-koha-permission": { "borrowers": "*" }, "operationId": "getBorrower", "tags": ["borrowers"], -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:22:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:22:58 +0000 Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13920-70-QiFxzmGpgz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:23:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:23:36 +0000 Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13920-70-SZolmbxhRg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14539, 7174 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 [Bug 7174] Authentication rewriting http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:23:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:23:36 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7174-70-1v2AVO0Y8r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13920 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 [Bug 13920] API authentication system - proposal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:23:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:23:36 +0000 Subject: [Koha-bugs] [Bug 14539] Introduction to castToObject(), aka. make a Koha::Object from various input types In-Reply-To: <bug-14539-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14539-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14539-70-47DDEuk63W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13920 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 [Bug 13920] API authentication system - proposal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:23:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:23:50 +0000 Subject: [Koha-bugs] [Bug 13920] API authentication system - proposal In-Reply-To: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13920-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13920-70-GGb1cg1ufb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13920 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:24:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:24:23 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-LmNmXj3yib@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41542|0 |1 is obsolete| | --- Comment #130 from Julian Maurice <julian.maurice at biblibre.com> --- Comment on attachment 41542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41542 Bug 13799: 4. API Authentication, part 1: API keys management in interface Patch moved to bug 13920 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:24:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:24:44 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-IRILzi8g5z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41543|0 |1 is obsolete| | --- Comment #131 from Julian Maurice <julian.maurice at biblibre.com> --- Comment on attachment 41543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41543 Bug 13799: 5. API authentication system - Swagtenticator authentication Patch moved to bug 13920 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:24:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:24:43 +0000 Subject: [Koha-bugs] [Bug 13888] 'Lists' permission should allow/disallow using the lists module in staff In-Reply-To: <bug-13888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13888-70-5DFysOfgWn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:26:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:26:44 +0000 Subject: [Koha-bugs] [Bug 14748] New: REST API Testing framework Message-ID: <bug-14748-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748 Bug ID: 14748 Summary: REST API Testing framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: olli-antti.kivilahti at jns.fi Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 13799 REST API Testing framework Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:26:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:26:44 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-VJWWHsfRa9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14748 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748 [Bug 14748] REST API Testing framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:28:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:28:04 +0000 Subject: [Koha-bugs] [Bug 14748] REST API Testing framework In-Reply-To: <bug-14748-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14748-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14748-70-9YlCEmZSWe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 42043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42043&action=edit Bug 14748: REST API Testing framework Introduces the Swagger2TestRunner which takes care of authentication and API consumer creation behind the scenes, and makes sure all API endpoints get test coverage. This way the test automator can focus on testing the business logic instead of duplicating authentication and API consumer creation in various test scripts. Run t/db_dependent/Api/V1/testREST.pl and it will tell you what you need to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:28:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:28:15 +0000 Subject: [Koha-bugs] [Bug 14748] REST API Testing framework In-Reply-To: <bug-14748-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14748-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14748-70-xpnlUlnL4W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14748 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:28:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:28:42 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-u0m2QUOcXm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41547|0 |1 is obsolete| | --- Comment #132 from Julian Maurice <julian.maurice at biblibre.com> --- Comment on attachment 41547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41547 Bug 13799 - 6. REST API Testing framework Patch moved to bug 14748 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:30:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:30:14 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-Z3I6JN8QSS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41541|0 |1 is obsolete| | Attachment #41554|0 |1 is obsolete| | --- Comment #133 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 42044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42044&action=edit Bug 13799: RESTful API with Mojolicious and Swagger2 Actual routes are: /borrowers Return a list of all borrowers in Koha /borrowers/{borrowernumber} Return the borrower identified by {borrowernumber} (eg. /borrowers/1) There is a test file you can run with: $ prove t/db_dependent/rest/borrowers.t All API stuff is in /api/v1 (except Perl modules) So we have: /api/v1/script.cgi CGI script /api/v1/swagger.json Swagger specification Change both OPAC and Intranet VirtualHosts to access the API, so we have: http://OPAC/api/v1/swagger.json Swagger specification http://OPAC/api/v1/{path} API endpoint http://INTRANET/api/v1/swagger.json Swagger specification http://INTRANET/api/v1/{path} API endpoint Add a (disabled) virtual host in Apache configuration api.HOSTNAME, so we have: http://api.HOSTNAME/api/v1/swagger.json Swagger specification http://api.HOSTNAME/api/v1/{path} API endpoint Add 'unblessed' subroutines to both Koha::Objects and Koha::Object to be able to pass it to Mojolicious Test plan: 1/ Install Perl modules Mojolicious and Swagger2 2/ perl Makefile.PL 3/ make && make install 4/ Change etc/koha-httpd.conf and copy it to the right place if needed 5/ Reload Apache 6/ Check that http://(OPAC|INTRANET)/v1/borrowers and http://(OPAC|INTRANET)/v1/borrowers/{borrowernumber} works Optionally, you could verify that http://(OPAC|INTRANET)/vX/borrowers (where X is an integer greater than 1) returns a 404 error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:30:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:30:28 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-Knxl0EYPRD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41274|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:30:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:30:55 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-VPbCh0jaaT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7174 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 [Bug 7174] Authentication rewriting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:30:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:30:55 +0000 Subject: [Koha-bugs] [Bug 7174] Authentication rewriting In-Reply-To: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7174-70-6NyJmUOnDi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13799 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:34:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:34:41 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-8zgj00Jp9C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #134 from Julian Maurice <julian.maurice at biblibre.com> --- All patches moved to their own bugs so we have a simple patch that just works (I hope...) and without a huge dependency tree. It should make testing a lot easier. A feature is still missing however: the cookie-based authentication. I'll try to work on that soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:39:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:39:03 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-0qT6Jv9Kav@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #135 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Julian Maurice from comment #134) > A feature is still missing however: the cookie-based authentication. I'll > try to work on that soon. ... but feel free to test the patch right now! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 19:55:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 17:55:44 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-jeSapmwqCx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #16 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #15) > Kyle, what does the last patch set? I'm not sure what you mean. Can you explain? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 20:25:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 18:25:06 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14217-70-uWfnDRrnG6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 20:25:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 18:25:08 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14217-70-hNLtwvoQ5j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40842|0 |1 is obsolete| | --- Comment #4 from Barton Chittenden <barton at bywatersolutions.com> --- Created attachment 42045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42045&action=edit Bug 14217: Add 'condition' attribute for DOM index definition This patch introduces an extension to the current syntax for DOM index definition. Specifically, it extends the 'index_subfields' tag to allow adding a 'condition' attribute that is used as a condition ofr applying the specified index. This (exotic) example is self-explanatory: The previous syntax (which is keeped by this patch) took this snippet from biblio-koha-indexdefs.xml <index_subfields tag="100" subfields="acbd"> <target_index>Encuadernador:w</target_index> </index_subfields> and generated an XSLT snippet in the DOM indexing XSLT that looks like this: <xslo:for-each select="marc:subfield"> <xslo:if test="contains('acbd', @code)"> <z:index name="Encuadernador:w"> <xslo:value-of select="."/> </z:index> </xslo:if> </xslo:for-each> This patch introduces this syntax change (note the 'condition' attribute: <index_subfields tag="100" subfields="acbd" condition="@ind2='7'"> <target_index>Encuadernador:w</target_index> </index_subfields> which yields to this XSLT snippet in the DOM indexing XSLT: <xslo:if test="@ind2='7'"> <xslo:for-each select="marc:subfield"> <xslo:if test="contains('acbd', @code)"> <z:index name="Encuadernador:w"> <xslo:value-of select="."/> </z:index> </xslo:if> </xslo:for-each> </xslo:if> To test: - Verify that the shipped XSLT files are current regarding the shipped index definitions: $ for i in marc21 normarc unimarc; do xsltproc etc/zebradb/xsl/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/$i/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/$i/biblios/biblio-zebra-indexdefs.xsl done $ git status (repeat for authorities, skip normarc which doesn't have authorities) - Apply the patch - Re-run the previous commands => SUCCESS: no changes - Add a condition to an index_subfields tag (for example, condition="@ind2='7'" in the Author's index - Regenerate the specific XSLT => SUCCESS: doing a diff shows the only change is the code has been wrapped inside an xslo:if using the condition for the test - Apply the generated xsl to a MARCXML record that has a field matching the condition like this: $ xsltproc .../biblio-zebra-indexdefs.xsl sample_record.xml => SUCCESS: There's an index on the result, containing the configured field/subfields, that matches the criteria. - Sign off and feel really happy :-D Note: the attached sample record includes a 100 field, with ind2=7 and $a=Tomasito Sponsored-by: Orex Digital Signed-off-by: Barton Chittenden <barton at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 20:31:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 18:31:32 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14217-70-jx16QjIhb3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 --- Comment #5 from Barton Chittenden <barton at bywatersolutions.com> --- I also tested the case where the indicator does *not* match, just for completeness. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 21:32:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 19:32:37 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14510-70-kDDGqMxqDr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 --- Comment #10 from Jesse Weaver <jweaver at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9) > Jesse, > > This does not work (even without the last patch). > To reproduce: hide the first column by default (barcode), save and refresh > the add item page. > The first column is hidden (in my case 'damaged'). > > You will have to change the way the feature works. The way it works > currently is based on the order of the columns, not the names. > > Marked as Failed QA. Was this on a UNIMARC system? If so, is there any chance you could post a sandbox link that I could look at? I thought I'd made it possible for it to work based on name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 21:59:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 19:59:06 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-gxyuhWeNN7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #124 from Chris Rohde <crohde at roseville.ca.us> --- Glad to see recent movement on this. Realize it's already made it to QA, but if there's anything I/my library can do to help or just encourage, I'm up for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 27 22:35:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Aug 2015 20:35:20 +0000 Subject: [Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific In-Reply-To: <bug-14048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14048-70-HJi7RNUoGg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 02:19:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 00:19:14 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-vRorAPAd1H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #80 from Robin Sheat <robin at catalyst.net.nz> --- (In reply to Jonathan Druart from comment #79) > The first problem I got was to find a MARC21 DB (since the UNIMARC mappings > are not defined, I cannot test with an UNIMARC DB). The UNIMARC mappings should be defined, though not tested. > I have used the one created for the sandboxes > (http://git.koha-community.org/gitweb/?p=contrib/global.git;a=blob;f=sandbox/ > sql/sandbox1.sql.gz;h=19268bccb43b2a33d5644b7d86cbb1abb323016b;hb=HEAD). But > there are only 436 biblios, it's not enough to test some stuffs (facets for > instance). > Or maybe you can share your DB? I could, but I think we'll get more useful results from different databases. > Here some notes: > > 1/ Add deps to C4/Installer/PerlDependencies.pm Yeah, I'm mostly waiting for things to settle (which they have now.) > 2/ The number of tests provided is very low. Yes, I've been meaning to go back and add a pile more. > 3/ catalyst/elastic_search is 1004 commits behind origin/master, please > rebase It's just a tedious process, so I keep putting it off :) should do that soon though. > 4/ The message "No 'elasticsearch' block is defined in koha-conf.xml" should > be raised before starting the indexation process, and not on commiting the > first batch. Added to my TODO. > 5/ You really need to tune the default value for the commit :) > commit 100: perl misc/search_tools/rebuild_elastic_search.pl -b 77.57s > user 0.86s system 91% cpu 1:25.62 total > commit 1000: perl misc/search_tools/rebuild_elastic_search.pl -b 24.68s > user 0.52s system 79% cpu 31.595 total > For Solr, we used 5000. > Yes I know, it's configurable. I just picked a number and haven't gone back to it. I'm also thinking that maybe dropping the committing entirely and just feeding straight into Catmandu and letting it do its own batching, rather than doubling up on it. More experimentation needed really, but definitely increasing the default is a sensible thing to do. FWIW, committing at 5,000: real 2m14.627s user 1m13.272s sys 0m2.228s 100: real 6m6.280s user 4m45.268s sys 0m2.828s That's a fair difference :) > 6/ Verbose does not work as expected, it could be fixed with Oops. TODOed. > > 7/ perl -e "use > Pod::Checker;podchecker('misc/search_tools/rebuild_elastic_search.pl')"; > *** WARNING: empty section in previous paragraph at line 36 in file > misc/search_tools/rebuild_elastic_search.pl > *** ERROR: =over on line 38 without closing =back at line EOF in file > misc/search_tools/rebuild_elastic_search.pl TODOed. > 8/ 2 occurrences of "Solr" reintroduced in installer/data/mysql/sysprefs.sql > and koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref Must have come about when merging. TODOed. > 9/ Test! > I have launched some searches, with the same DB (the one from the sandbox). > On a local using your remote branch and another one using master (sandbox7 > provided by BibLibre). > > a. Search for 'd' (screentshot opac_search_for_d_sort_by_relevance.png ES on > the left, Zebra on the right). > Main differences: > - 183 vs 182 results (?) I wouldn't necessarily expect them to be the same, especially for a fairly meaningless search. > - the order is not the same (make sense) > - Locations and Places facets are missing Yeah, they're not faceted yet. Added that to my TODO list before I forget again. > - 6 entries are displayed in the facets for ES (current behavior is 5). > > b. Search for 'd', sort by title AZ (screenshot > opac_search_for_d_sort_by_title.png) > - Zebra displayes only 1 facet That's probably zebra being wrong then :) > - The order is still completely different I'm not sure which is right in this case, though I'm doing some work on the sorting at the moment that would allow you to pick which of the fields that end up in title you want to sort by. For example, it might be that ES is putting the ones with a lower series title near the start, even though it displays a different title. That'll be tuneable when I'm done with the current stuff. > c. Search for 'harry', sort by title AZ (screenshot > opac_search_for_harry_sort_by_title.png) > - 'Show more' links is displayed even if only 2 entries for a facet are > available Thought I'd fixed that, I'll have to have a look again. > - The order is still different ("The discovery of heaven" should be sorted > either before Dollhouse (if the is a stopword) either after "Hareios*" Dollhouse probably has another title field that's actually being used, as noted above. > - The availability is wrong for ES (The item for Dollhouse is not for loan) Why is it not for loan? Is it by policy, because there are no items, or because all items are issued? > d. Search for Books (limit by item type in the adv search), sort by pubdate > (screenshot limit_by_book_sort_by_pubdate.png) > - "Return to the last advanced search" link is not displayed I wonder how it knows to show that... I can't actually find that string in my checkout at all. > - The item types facet contains several entries, which does not make sense Curious. Are there situations where you have a biblio-level itemtype that differs from the item-level item type, or where one biblio might have multiple items with different item types? At the moment, I think they're all being thrown into one facet pot. > - The number of results highly differ (395 vs 364) Probably due to biblio-vs-item itemtype selection not being supported yet. If you can find it giving you a record that plain shouldn't match though, that'd be interesting. > - The order is still completely different. I had a look in the index and > found: > "Pictura mural?*" has "pubdate":"||||" (/_search?q=_id:39&pretty) > The Korean Go Association's learn to play go "pubdate":"uuuu" > (/_search?q=_id:155&pretty) > Where do come from these values? Shouldn't be a date, or at least an integer? Could be the mapping is funny/broken for that. My test system has things like: "pubdate":"1998" though, which implies that it's correct. The actual mapping comes from: INSERT INTO `elasticsearch_mapping` (`indexname`, `mapping`, `facet`, `suggestible`, `type`, `marc21`, `unimarc`, `normarc`) VALUES ('biblios','pubdate',FALSE,FALSE,'','008_/7-10','100a_/9-12','008_/7-10'); On the other hand, it does have: "date-entered-on-file":"61006" which doesn't look right no matter how you carve it. > It's not easy to know what is indexed where. Did you have a look at the > indexes configuration page the Solr stuff had? > It provided an interface to configure the different mappings, it was very > useful. I haven't yet got to the point where I have the time to make an interface. At the moment it's all configured in elasticsearch_mapping.sql, which is somewhat human readable/editable. After loading the data into a table, it rewrites all those tables into a form that'll be more conducive for having a GUI on top of, but is less human readable. BTW, if you add <trace_to>Stderr</trace_to> to the <elasticsearch> block, it'll dump all the chatter with ES out to stderr, which is useful for seeing what exactly is going on. I warn you, there is a lot there though. Thanks for testing, even if I have a pile more things to fix now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 04:47:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 02:47:39 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: <bug-14494-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14494-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14494-70-hjO7PR9Nl6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #32 from Mason James <mtj at kohaaloha.com> --- (In reply to Liz Rea from comment #31) > Pushed to 3.18.x, will be in 3.18.10. Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 04:56:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 02:56:41 +0000 Subject: [Koha-bugs] [Bug 14465] Broken umlauts/diacritics in feedback of last checkout In-Reply-To: <bug-14465-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14465-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14465-70-SZgHIQUriL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 07:11:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 05:11:20 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: <bug-14494-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14494-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14494-70-F9q3GfqNhz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12669 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 07:11:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 05:11:20 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12669-70-91zt9qFBo6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14494 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 [Bug 14494] Terribly slow checkout caused by DateTime->new in far future -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 07:11:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 05:11:52 +0000 Subject: [Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone" In-Reply-To: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12669-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12669-70-LlOkVxm5We@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #28 from Mason James <mtj at kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 07:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 05:43:58 +0000 Subject: [Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module In-Reply-To: <bug-14445-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14445-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14445-70-9vBCY9X76W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James <mtj at kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 07:44:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 05:44:39 +0000 Subject: [Koha-bugs] [Bug 14569] Typo for borrowers In-Reply-To: <bug-14569-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14569-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14569-70-IoZ8UwEi6n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14569 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James <mtj at kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 07:45:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 05:45:07 +0000 Subject: [Koha-bugs] [Bug 14456] EmbedSeeFromHeadings record filter shouldn't process MARC holding fields In-Reply-To: <bug-14456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14456-70-jF6zTMnWs7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14456 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James <mtj at kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 07:45:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 05:45:32 +0000 Subject: [Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron In-Reply-To: <bug-11693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11693-70-DerI6WyMBG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James <mtj at kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 08:03:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 06:03:39 +0000 Subject: [Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities. In-Reply-To: <bug-14387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14387-70-IMj73vvU4t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James <mtj at kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 08:04:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 06:04:31 +0000 Subject: [Koha-bugs] [Bug 14487] Warns from returns.pl during checkin In-Reply-To: <bug-14487-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14487-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14487-70-nQVq7dAABJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14487 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #20 from Mason James <mtj at kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 08:05:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 06:05:03 +0000 Subject: [Koha-bugs] [Bug 10961] Error in GetMarcBiblio can cause severe data loss In-Reply-To: <bug-10961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10961-70-7zIxPPEv1z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10961 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #14 from Mason James <mtj at kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 08:07:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 06:07:15 +0000 Subject: [Koha-bugs] [Bug 13663] offline circ permission issue In-Reply-To: <bug-13663-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13663-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13663-70-zHaicWGpcX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #20 from Mason James <mtj at kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 08:35:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 06:35:33 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-Te06vLZWmn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 08:35:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 06:35:35 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-zYfxxT1kY4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42037|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42046&action=edit Bug 14737: wrong permissions required for cn_browser.pl plugin The cn_browser.pl cataloguing plugin only searches for used callnumbers on the bibliographic database. There is no need for this plugin to require special permissions besides access to the catalog. To test: - Link the cb_browser.pl cataloguing plugin to 952$o in your favourite cataloguing framework - Login with a superlibrarian user - Try the plugin => SUCCESS: you can use it - Login with a user that has the full 'tools' permission - Try the plugin => SUCCSES: you can use it - Login with a user that doesn't have full 'tools' permission but has the normal catalogue and cataloguing permissions. - Try the plugin => FAIL: you are requested to login with a different user - Apply the patch - Retry => SUCCESS: you can use it - Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 08:36:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 06:36:07 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-5E266DzqwO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 08:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 06:43:39 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-cKG1LxxOaY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Hobby holiday project: See newHolidays.pl if ($description) { $description =~ s/\r/\\r/g; $description =~ s/\n/\\n/g; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 08:45:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 06:45:56 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-IumJuNFOQg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Joonas: If you want to change the patch, go ahead and change the status. But I do not mind pushing this tiny adjustment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 08:58:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 06:58:09 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14217-70-3evgIRHluc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- This is certainly an interesting development! But it might need some further (broader) discussion before getting in. In the first place: Why do we really need it? Can you elaborate/illustrate? If we add conditions, what kind of conditions do we want? Syntax? Etc. A broader design may be easier to maintain.. How do comparable systems implement this? If we add this for Zebra, what about other search engines? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 09:20:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 07:20:53 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-RxPVOENcNT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 --- Comment #10 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Marcel de Rooy from comment #8) > Hobby holiday project: > > See newHolidays.pl > > if ($description) { > $description =~ s/\r/\\r/g; > $description =~ s/\n/\\n/g; > } I looked into that. Changing the new line into <br> didn't work in the because then we need to also change the description editor to convert <br> to \r\n. So it's similar fix to that what we do now when displaying the description (but more changes with no reason). And so we have done already the fix to change the description so I will go with the current patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 09:34:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 07:34:03 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-6C6gunOmoc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #144 from Marc V?ron <veron at veron.ch> --- Still applies. Still blocks Bug 12072: New dateformat dd.mm.yyyy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 09:34:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 07:34:12 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12072-70-WdYHysYF54@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #31 from Marc V?ron <veron at veron.ch> --- Still blocked by Bug 13813. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 09:42:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 07:42:59 +0000 Subject: [Koha-bugs] [Bug 14749] New: Add API route to get top issues Message-ID: <bug-14749-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 Bug ID: 14749 Summary: Add API route to get top issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Web services Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Add API route to get top issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 09:45:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 07:45:37 +0000 Subject: [Koha-bugs] [Bug 14749] Add API route to get top issues In-Reply-To: <bug-14749-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14749-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14749-70-Cm1CrGBx1u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 42047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42047&action=edit Bug 14749: Add API route /v1/topissues See Swagger specification for documentation Refactor opac-topissues.pl code into C4::Circulation::GetTopIssues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 09:46:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 07:46:51 +0000 Subject: [Koha-bugs] [Bug 14749] Add API route to get top issues In-Reply-To: <bug-14749-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14749-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14749-70-USWv3xyoLM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |13799 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 09:46:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 07:46:51 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-rkFvEonbqU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14749 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 [Bug 14749] Add API route to get top issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:08:06 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-D6k1iIT0mP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #13 from Marc V?ron <veron at veron.ch> --- Created attachment 42048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42048&action=edit [Signed-off] Bug 14655: Add a warning if the checkin will fail On the checkin and checkout page, the checkin will fail if the patron has requested the privacy and the AnonymousPatron is not correctly set. This patch adds a warning message on both pages. Test plan: 0/ Be sure you don't have any patron with privacy=2 (Never) 1/ Set OPACPrivacy, not AnonymousPatron 2/ Go on the checkin, you should a warning (same as before this patch). 3/ Set the privacy=2 for a patron 4/ Go on the circulation page, a warning should appear (for this specific patron) 5/ Check an item out to this patron 6/ Check the item in on the checkin page. The item is not checked in and you get a specific message for this patron. Confirm other/correct situations don't trigger the messages. Followed test plan. Works as expected. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:08:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:08:40 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-9NmdqdTD63@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #41630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:09:41 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-ZI98ekEKLa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #14 from Marc V?ron <veron at veron.ch> --- Created attachment 42049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42049&action=edit [Signed-off] Bug 14655: Add a warning on the about page if patrons have requested privacy New warning on the about page if at least a patron has requested a privacy on checkin but the AnonymousPatron is not set to a valid patron. Works as expected. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:10:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:10:01 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-hhVEgnItVj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:10:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:10:10 +0000 Subject: [Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron In-Reply-To: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14655-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14655-70-AjvfZbcUwM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:15:37 +0000 Subject: [Koha-bugs] [Bug 14750] New: Rename borrowers.mobile to otherphone Message-ID: <bug-14750-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14750 Bug ID: 14750 Summary: Rename borrowers.mobile to otherphone Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Borrowers.mobile is not mobile phone, but other phone. This had led to several misunderstandings (in the code too). We should rename the column. See also bug 13142 and bug 14683. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:17:43 +0000 Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number In-Reply-To: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14683-70-2THQY2RdnZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:17:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:17:45 +0000 Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number In-Reply-To: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14683-70-lDsbjYZDDO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41664|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42050&action=edit Bug 14683: Unable to clear SMS number Enables to clear SMS number. To test: 1. Go to opac-messaging.pl 2. Insert SMS number and submit 3. Clear SMS number and submit 4. Observe that the sms number did not change 5. Apply patch 6. Clear SMS number and submit 7. Observe that the sms number changes Sponsored-by: Vaara-kirjastot Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Adding a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:17:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:17:50 +0000 Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number In-Reply-To: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14683-70-HJUFMebfUG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42051&action=edit Bug 14683: [QA Follow-up] Mixup between mobile and smsalertnumber This is an issue discussed on older reports already in the past. Column mobile in borrowers is actually 'Other phone', not necessary a mobile number. The name of the field is confusing. (Renaming it is outside the scope of this report.) The field that we are editing here is smsalertnumber. It should not be compared with mobile at all. What could be the side-effect of this correction? === First, the change is only relevant for libraries with pref SMSSendDriver enabled. In the past patrons editing their message preferences saw mobile (read: other phone) in their smsalertnumber field (if the latter was still empty). If they saved it, it was copied to smsalertnumber. This change does not affect these patrons. They just have the same number in two columns. No big deal. What if a patron does not yet have a smsalertnumber? In that case no sms is sent in Letters.pm. So no change in behavior. If he submits opac-messaging now, he will no longer copy his other phone to smsalert [we cannot assume that it was mobile anyway!]. If he enters a mobile number, it will be saved correctly in the right field. Conclusion: this change will not break things or hurt anyone. It only prevents unwanted copying other phone to smsalertnumber. Also modified the compare to prevent uninitialized warnings. And removed a commented warn. Test plan: [1] Add, edit or delete the SMS number on opac-messaging regardless of the value of Other Phone (in the badly named mobile field). Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:18:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:18:20 +0000 Subject: [Koha-bugs] [Bug 14683] Unable to clear SMS number In-Reply-To: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14683-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14683-70-BOi35jeKYv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14750 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:18:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:18:20 +0000 Subject: [Koha-bugs] [Bug 14750] Rename borrowers.mobile to otherphone In-Reply-To: <bug-14750-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14750-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14750-70-9apwqCPkQe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14750 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14683 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:18:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:18:33 +0000 Subject: [Koha-bugs] [Bug 14750] Rename borrowers.mobile to otherphone In-Reply-To: <bug-14750-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14750-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14750-70-haYRaRXM2n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14750 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13142 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:18:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:18:33 +0000 Subject: [Koha-bugs] [Bug 13142] Change "mobile phone" label back to "other phone" In-Reply-To: <bug-13142-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13142-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13142-70-QBZo7eEDeV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13142 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14750 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:18:46 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-klGNSuoGGP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #16) > (In reply to Jonathan Druart from comment #15) > > Kyle, what does the last patch set? > > I'm not sure what you mean. Can you explain? (Maybe a do is missing) What does the last patch set do? You have answered my comment 10 by a new patch set, but I don't want to compare the 2 patch sets (before and after my comment) to know if you have taken into account my comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:32:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:32:33 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-4qVnE9gRz3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #145 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marc V?ron from comment #144) > Still applies. > Still blocks Bug 12072: New dateformat dd.mm.yyyy Will have a look now. But the number of patches here is scary.. Do not know if I can finish this in one session. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:33:37 +0000 Subject: [Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized In-Reply-To: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14510-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14510-70-TRkMjQoLVX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Yes it was a UNIMARC install. But same on a MARC21 fresh install. Check "cn_source is hidden by default". Refresh cataloguing/additem.pl?biblionumber=109 The third column is hidden (damaged status). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:41:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:41:04 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-5wMAE7E1vR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #146 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Marc: Why do you add MARC::Record in Acquisition.pm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:41:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:41:31 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-Q3Pn3fHaNO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #147 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #145) > (In reply to Marc V?ron from comment #144) > > Still applies. > > Still blocks Bug 12072: New dateformat dd.mm.yyyy > > Will have a look now. But the number of patches here is scary.. > Do not know if I can finish this in one session. It's almost always the same changes. See comments 134-136 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:42:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:42:38 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-g245vUYsjh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron <veron at veron.ch> --- Works as expected. However, C4/Letters.pm line 648 has forbidden pattern (trailing space chars). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:43:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:43:52 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-GLkgGy0V0Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #148 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #146) > Marc: Why do you add MARC::Record in Acquisition.pm? It's a bad merge conflict, in the local branch I have, there is only -use C4::Dates qw(format_date format_date_in_iso); use MARC::Record; Now there is use C4::Dates qw(format_date format_date_in_iso); +use MARC::Record; It should be -use C4::Dates qw(format_date format_date_in_iso); -use MARC::Record; :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 10:44:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 08:44:17 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-hB6y1qQRcN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #149 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #148) > It should be > > -use C4::Dates qw(format_date format_date_in_iso); > -use MARC::Record; > > :) Well no, it should be -use C4::Dates qw(format_date format_date_in_iso); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:12:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:12:11 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13411-70-mDVkBi67QF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Patch not working as advertised - in the rebasings it looks like we've lost the check of the config value to pass to checkin so the checked_in_ok variable is never passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:14:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:14:25 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-mL8ZSqSWSp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #150 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Apart from the previous question, here are the results of the Dutch jury: =head2 DelItem @@ -2128,7 +2128,7 @@ C<items.withdrawn> sub _set_defaults_for_add { my $item = shift; - $item->{dateaccessioned} ||= C4::Dates->new->output('iso'); + $item->{dateaccessioned} || output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }); $item->{$_} ||= 0 for (qw( notforloan damaged itemlost withdrawn)); } OOPS: You lost an important character || instead of ||= !!!!!!! C4/Members: $data->{message_date_formatted} = $d->output; [ no longer added ] GetMessages Not sure if you also resolved all calls of this sub accordingly. Could you confirm? C4/VirtualShelves - $this_item->{'dateadded'} = format_date( $this_item->{'dateadded'} ); + $this_item->{'dateadded'} = output_pref({ dt => dt_from_string( $this_item->{'dateadded'} ), dateformat => 'iso', dateonly => 1 }); No iso ? circ.bookcount - lastdate => $lastdate ? format_date($lastdate) : 0, + lastdate => $lastdate ? output_pref({ dt => dt_from_string( $lastdate, 'iso' ), dateonly => 1 }) : 0, No iso? - format_date($date), + output_pref({ dt => dt_from_string( $date, 'iso' ), dateonly => 1 }), Again. moremember + $template->param( 'userdebarreddate' => output_pref({ dt => dt_from_string( $debar, 'iso' ), dateonly => 1 }) ); Looks different members/printfeercpt.pl - my %row = ( 'date' => format_date($accts->[$i]{'date'}), + my %row = ( 'date' => output_pref({ dt => dt_from_string( $accts->[$i]{'date'}, 'iso' ), dateonly => 1 }), No iso? members/printinvoice.pl Again opac-showreviews.pl + timestamp => strftime("%Y-%m-%dT%H:%M:%S-00:00", gmtime), Could you confirm this is the same as rfc822 Since I see it more, would this be something for the KohaDates module too ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:14:41 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-YjLVKQDeKk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:15:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:15:00 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-Nh4N0Q9I50@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #151 from Marc V?ron <veron at veron.ch> --- Created attachment 42052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42052&action=edit Bug 13813 - [Follow-up] Remove C4::Dates from C4/Acquisition.pm Fix badly merged lines in C4/Acquisition.pm See comments #146-149 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:15:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:15:44 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-1ia8AE950f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #6 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Marc V?ron from comment #5) > Works as expected. > However, C4/Letters.pm line 648 has forbidden pattern (trailing space chars). I don't see any in that line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:35:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:35:12 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10181-70-HK5ojK6WrX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Applying: Bug 10181: Acq - Improve message for deleted records fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:36:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:36:13 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: <bug-11213-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11213-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11213-70-LM02hWe8L2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Needs Signoff |Patch doesn't apply --- Comment #59 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Applying: bug_11213: C4::VirtualShelves::Page::shelf_contents() fatal: sha1 information is lacking or useless (C4/VirtualShelves/Page.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:53:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:53:08 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14723-70-NezVZTMDHD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #1 from Lari Taskula <larit at student.uef.fi> --- Created attachment 42053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42053&action=edit Bug 14723 - Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue. They are useful, because there can be multiple reasons for a delivery to fail. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:54:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:54:39 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-lnJms6Azf0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41346|0 |1 is obsolete| | --- Comment #51 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42054&action=edit Bug 13618: Use Template::Stash::AutoEscaping to use the html filter Test plan done and worked. I deleted the commits from 13609, and then applied this and it also solved the xss vulnerability. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:55:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:55:01 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-8CZLkeZMry@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42055&action=edit Used to test the change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:55:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:55:46 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-qSQGvUWC3O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Jonathan: I cannot reproduce with the simple third patch. What should I change there to see behavior change with/without your patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 11:58:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 09:58:32 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-EJ3eL8RyXe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Oops, I lost some changes in that test file. But what exactly should trigger the error on txn_begin or end in testbuilder? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:07:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:07:15 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-ifOYl2UNqx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42055|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42056&action=edit Used to test the change This seems to work like it should not.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:10:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:10:00 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-aC7dKAalxL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Only this question: Why does the test abort with the DESTROY and does it only warn when I undef $builder ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:13:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:13:50 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-2XbZw6V8Ct@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #8) > Only this question: Why does the test abort with the DESTROY and does it > only warn when I undef $builder ? Because the second DESTROY crashes the test :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:16:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:16:26 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-AhS0MEXxuz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:16:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:16:28 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-OBeldNmM5y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39146|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42057&action=edit Bug 14197: Remove the warning on destroying TestBuilder objects This module will be called by db_dependent tests, which already create a transaction. TestBuilder creates a new one (which is certainly useless) and the rollback does not do anything. To see the warning see patches on bug 14045. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:16:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:16:36 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-7cuJxmZizP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40859|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42058&action=edit Bug 14197: TestBuilder - Remove the error on starting the transaction DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway at t/lib/TestBuilder.pm line 363 Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:17:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:17:40 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-PY7dvTZjQh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42056|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42059&action=edit Used to test the change with/without first two patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:17:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:17:59 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-M94ivR4ntr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:18:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:18:49 +0000 Subject: [Koha-bugs] [Bug 14197] Warning raised by TestBuilder In-Reply-To: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14197-70-IM6k5HzsJv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42059|Used to test the change |[DO_NOT_PUSH] Used to test description|with/without first two |the change with/without |patches |first two patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:44:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:44:38 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14723-70-TF1PmW1Nyr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13799 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:44:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:44:38 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-yNYYDT8e0K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14723 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 [Bug 14723] Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 12:56:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 10:56:25 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-HqMY7Ku8KV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #12 from Lari Taskula <larit at student.uef.fi> --- Created attachment 42060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42060&action=edit Bug 14536: (follow-up) Add PageObject for members/notices.pl This patch adds a new PageObject Notices for members/notices.pl page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:04:40 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14723-70-EH2z15MwhE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |larit at student.uef.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:29:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:29:22 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-WC2x4CyVPp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #81 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Robin Sheat from comment #80) > (In reply to Jonathan Druart from comment #79) > > The first problem I got was to find a MARC21 DB (since the UNIMARC mappings > > are not defined, I cannot test with an UNIMARC DB). > > The UNIMARC mappings should be defined, though not tested. Well, it's defined yes, but does not work at all (the marc21 mappings are used) :) It is caused by some errors in the sql file. Patch's coming. Note the following: MariaDB [koha_es_unimarc]> insert into search_field (name, type) select distinct mapping, type from elasticsearch_mapping; Query OK, 73 rows affected, 57 warnings (0.05 sec) Records: 73 Duplicates: 0 Warnings: 57 MariaDB [koha_es_unimarc]> show warnings; +---------+------+--------------------------------------------+ | Level | Code | Message | +---------+------+--------------------------------------------+ | Warning | 1265 | Data truncated for column 'type' at row 1 | and 72 others. > > I have used the one created for the sandboxes > > (http://git.koha-community.org/gitweb/?p=contrib/global.git;a=blob;f=sandbox/ > > sql/sandbox1.sql.gz;h=19268bccb43b2a33d5644b7d86cbb1abb323016b;hb=HEAD). But > > there are only 436 biblios, it's not enough to test some stuffs (facets for > > instance). > > Or maybe you can share your DB? > > I could, but I think we'll get more useful results from different databases. Yes of course, but I am not a real tester, I am a developer, and it would be useful to share info on specific data. I am fine to use the sandbox DB, if it's ok for you. > > Here some notes: > > > > 1/ Add deps to C4/Installer/PerlDependencies.pm > > Yeah, I'm mostly waiting for things to settle (which they have now.) > > > 2/ The number of tests provided is very low. > > Yes, I've been meaning to go back and add a pile more. Ok, I let it that for you :) > > 6/ Verbose does not work as expected, it could be fixed with > > Oops. TODOed. Patch is coming. > > 7/ perl -e "use > > Pod::Checker;podchecker('misc/search_tools/rebuild_elastic_search.pl')"; > > *** WARNING: empty section in previous paragraph at line 36 in file > > misc/search_tools/rebuild_elastic_search.pl > > *** ERROR: =over on line 38 without closing =back at line EOF in file > > misc/search_tools/rebuild_elastic_search.pl > > TODOed. Patch is coming. > > 8/ 2 occurrences of "Solr" reintroduced in installer/data/mysql/sysprefs.sql > > and koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref > > Must have come about when merging. TODOed. Patch is coming. > > 9/ Test! > > c. Search for 'harry', sort by title AZ (screenshot > > opac_search_for_harry_sort_by_title.png) > > - 'Show more' links is displayed even if only 2 entries for a facet are > > available > > Thought I'd fixed that, I'll have to have a look again. Patch is coming. > > - The order is still different ("The discovery of heaven" should be sorted > > either before Dollhouse (if the is a stopword) either after "Hareios*" > > Dollhouse probably has another title field that's actually being used, as > noted above. Yes it has: title":["Dollhouse"],["Seasons one & two."]] 245$a Dollhouse 490$a Seasons one & two. But 245$a should be used for sorting :) > > - The availability is wrong for ES (The item for Dollhouse is not for loan) > > Why is it not for loan? Is it by policy, because there are no items, or > because all items are issued? The item is a "Visual Materials" which has a itemtype.notforloan flag set. > > d. Search for Books (limit by item type in the adv search), sort by pubdate > > (screenshot limit_by_book_sort_by_pubdate.png) > > - "Return to the last advanced search" link is not displayed > > I wonder how it knows to show that... > > I can't actually find that string in my checkout at all. Yes sorry, introduced by Bug 13307: Create a link to the last advanced search in search result page (OPAC). Which is not in your branch yet. > > - The item types facet contains several entries, which does not make sense > > Curious. Are there situations where you have a biblio-level itemtype that > differs from the item-level item type, or where one biblio might have > multiple items with different item types? At the moment, I think they're all > being thrown into one facet pot. It comes from biblioitems.itemtype=2WEEK Not sure if the data I used are correct... > > - The number of results highly differ (395 vs 364) > > Probably due to biblio-vs-item itemtype selection not being supported yet. > If you can find it giving you a record that plain shouldn't match though, > that'd be interesting. Outch, not sure how I could find that easily. > > - The order is still completely different. I had a look in the index and > > found: > > "Pictura mural?*" has "pubdate":"||||" (/_search?q=_id:39&pretty) > > The Korean Go Association's learn to play go "pubdate":"uuuu" > > (/_search?q=_id:155&pretty) > > Where do come from these values? Shouldn't be a date, or at least an integer? > > Could be the mapping is funny/broken for that. My test system has things > like: > > "pubdate":"1998" > > though, which implies that it's correct. The actual mapping comes from: > > INSERT INTO `elasticsearch_mapping` (`indexname`, `mapping`, `facet`, > `suggestible`, `type`, `marc21`, `unimarc`, `normarc`) VALUES > ('biblios','pubdate',FALSE,FALSE,'','008_/7-10','100a_/9-12','008_/7-10'); It comes from the 008 > "Pictura mural?*" has "pubdate":"||||" (/_search?q=_id:39&pretty) 008 090409|||||||||xx |||||||||||||| ||und|| > The Korean Go Association's learn to play go "pubdate":"uuuu" 008 971030muuuu9999nyua 000 0 eng But the index should not contain an invalid date. For Solr (you can find the code on the BibLibre repo at https://git.biblibre.com/biblibre/koha_biblibre/commits/dev/solr Browse C4/Search/), we used a system of plugins. And there is a Date plugin (https://git.biblibre.com/biblibre/koha_biblibre/blob/bd38ce1811289fcfbd75a37ec99fc4cd3c5d37f4/C4/Search/Plugins/Date.pm) which does this job. A plugin can be linked to a mapping. Just a note: I know nobody has ever had a look at the Solr code, but it is used in production by several (4 or 5) customers for more than 4 years now. And I have already had all the issues and problems you will encounter. > > It's not easy to know what is indexed where. Did you have a look at the > > indexes configuration page the Solr stuff had? > > It provided an interface to configure the different mappings, it was very > > useful. > > I haven't yet got to the point where I have the time to make an interface. > At the moment it's all configured in elasticsearch_mapping.sql, which is > somewhat human readable/editable. After loading the data into a table, it > rewrites all those tables into a form that'll be more conducive for having a > GUI on top of, but is less human readable. > > BTW, if you add > > <trace_to>Stderr</trace_to> > > to the <elasticsearch> block, it'll dump all the chatter with ES out to > stderr, which is useful for seeing what exactly is going on. I warn you, > there is a lot there though. I will try and see if I can find some time and propose something here, I you want some help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:30:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:30:28 +0000 Subject: [Koha-bugs] [Bug 14751] New: Allow C4::Context->interface to be set to 'sip' or 'commandline' Message-ID: <bug-14751-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Bug ID: 14751 Summary: Allow C4::Context->interface to be set to 'sip' or 'commandline' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. I propose we extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:30:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:30:33 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: <bug-14751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14751-70-JHAJpvHh1g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:31:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:31:43 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-smWBAIWAal@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #52 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Joonas Kylm?l? from comment #51) > Created attachment 42054 [details] [review] > Bug 13618: Use Template::Stash::AutoEscaping to use the html filter > > Test plan done and worked. I deleted the commits from 13609, and then > applied this and it also solved the xss vulnerability. > > Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> Thought it worked, but now noticed it broked the html in /cgi-bin/koha/opac-tags.pl?mine=1 (my tags in opac). Under the title column it only shows html as plain text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:32:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:32:01 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: <bug-14751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14751-70-weFBmRfAVn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:32:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:32:03 +0000 Subject: [Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline' In-Reply-To: <bug-14751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14751-70-Ym9y3eMKHt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42061&action=edit Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. We should extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:38:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:38:31 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-FxAX7EHm4o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #82 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42062&action=edit Bug 12478: Fix the UNIMARC and NORMARC indexing 1/ This patch fixes a major issue on UNIMARC and NORMARC installations (Compulsive c/p on insert into insert into search_marc_to_field for unimarc and normarc) 2/ After fixing that, I got invalid marc path at /usr/share/perl5/Catmandu/Fix/marc_map.pm line 35. on reindexing. It was caused by some "" values instead of NULL. 3/ Then, a "duplicate entry" error was caused by 3 lines for Local-number. It seems to be an error, 1 is enough (I suppose 0909 was an error too). Note that the following is not fixed by this patch: MariaDB [koha_es_unimarc]> insert into search_field (name, type) select distinct mapping, type from elasticsearch_mapping; Query OK, 73 rows affected, 57 warnings (0.05 sec) Records: 73 Duplicates: 0 Warnings: 57 MariaDB [koha_es_unimarc]> show warnings; +---------+------+--------------------------------------------+ | Level | Code | Message | +---------+------+--------------------------------------------+ | Warning | 1265 | Data truncated for column 'type' at row 1 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:38:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:38:37 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-ThouWFjfkK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #83 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42063&action=edit Bug 12478: Change the commit count to 5k It will improve the indexing time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:38:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:38:42 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-cF7YRBPBVA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #84 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42064&action=edit Bug 12478: Fix the verbose flag on reindexing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:38:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:38:46 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-OWTS3YdrFv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #85 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42065&action=edit Bug 12478: Fix pod in the rebuild_ES.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:38:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:38:51 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-cvrqNPY1dm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #86 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42066&action=edit Bug 12478: Remove Solr occurrences reintroduced by a previous patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:38:56 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-9pzfatcN5T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #87 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42067&action=edit Bug 12478: Display the correct number of facets (5 instead of 6) The loop on facet entries was wrong, it should stop after 5 iterations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:39:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:39:01 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-ccAKOBRAjd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #88 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42068&action=edit Bug 12478: Do not display the 'Show more' links if no more facet available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:39:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:39:07 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-qpRMvyFTJT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #89 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42069&action=edit Bug 12478: Fix encoding issue on facets Filer on "?lez, Ts." => Can't escape \x{015A}, try uri_escape_utf8() instead at /home/koha/src/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 221. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:42:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:42:12 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-Ne6cSkXpGF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #90 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Something else, there is a sort issue in the facets: [Some entries] Zeitoun, Ariel, ? Cadhain, M?irt?n. ?lez, Ts.. ? should be after O, not after Z. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:52:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:52:31 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10181-70-CwLotuQY9s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:52:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:52:34 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10181-70-ZU0Wl4E85O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37894|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42070&action=edit Bug 10181: Make string translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:52:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:52:38 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10181-70-xlIHfldx8H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42071&action=edit Bug 10181: Acq - Improve message for deleted records There are some issues here: 1/ Message not translatable (set in the pl file) 2/ ' by 'displayed even if no author defined 3/ Message not the same every where 4/ Nothing displayed on the invoice page Test plan: 1/ Create a basket 2/ Add 4 orders A, B, C, D 3/ On the basket, you see "$title by $author", or "$title" if no author defined 4/ Delete order A, B 5/ Close the basket 6/ Receive B, C 7/ Delete record created for A, C 8/ Go on the basket page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record 9/ Go on the invoice page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 13:52:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 11:52:58 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10181-70-W7eShQMPCr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #2) > Applying: Bug 10181: Acq - Improve message for deleted records > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt). > Repository lacks necessary blobs to fall back on 3-way merge. Oops, I have forgotten a patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 14:01:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 12:01:48 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-0OCdhE7WjL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41776|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42072&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 14:02:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 12:02:02 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-8V5VvDyTaJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42073&action=edit Bug 13618: Specific for XSLTBloc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 14:03:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 12:03:18 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-HkODDDkVa8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Joonas Kylm?l? from comment #52) > (In reply to Joonas Kylm?l? from comment #51) > > Created attachment 42054 [details] [review] [review] > > Bug 13618: Use Template::Stash::AutoEscaping to use the html filter > > > > Test plan done and worked. I deleted the commits from 13609, and then > > applied this and it also solved the xss vulnerability. > > > > Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> > > Thought it worked, but now noticed it broked the html in > /cgi-bin/koha/opac-tags.pl?mine=1 (my tags in opac). Under the title column > it only shows html as plain text. "Bug 13618: Specific for other prefs" reuploaded, OPACMySummaryNote was not correctly managed. New patch "Specific for XSLTBloc" should fix your issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 14:05:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 12:05:33 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14723-70-UzLXr3J679@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #2 from Lari Taskula <larit at student.uef.fi> --- To test template modifications: 1. Find a borrower with notices at members/notices.pl 2. Observe that there is no column for Delivery notes 3. Apply patch and run the given database update 4. Repeat step 1. 5. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 14:09:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 12:09:13 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14723-70-NkATKCBsB8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #3 from Lari Taskula <larit at student.uef.fi> --- Created attachment 42074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42074&action=edit Bug 14723: (follow-up) Example of handling custom SMS::Send Driver reports This patch presents an example of how SMS::Send driver can be configured to receive reports from your SMS Gateway provider if they support such feature. With Bug 14723 adding a delivery note column to message_queue, you are now able to update the error status provided by your SMS gateway provider to the message. It uses REST API, so make sure to include dependencies. Koha conf gets a new block "smsProviders", where you are able to define your SMS Gateway login data and the report URL that our provider will use. Koha httpd conf gets an example for blocking all traffic to the REST API address for modifying the message status, apart from our provider IPs. Here is a description of the protocol and common actions with the example driver. 1. message_queue gets processed as usual. 2. Letters.pm calls our example driver with phone number, content and message_id (new!). 3. Our example driver sends a POST request to the SMS Gateway provider as follows: - user: username, loaded from koha conf smsProviders->labyrintti - password: password, loaded from koha conf smsProviders->labyrintti - dests: destination phone number - text: content of the message - report: the URL that SMS Gateway provider will update the status of this delivery, loaded from koha conf (with REST API, it should be http://yourhost.com/v1/messages) smsProviders->labyrintti 4. We get (hopefully) an OK message from our SMS provider. It will already let us know if there was an error with the phone number. If so, we return it to Letters.pm via HASH: { status => 1/0, delivery_note => the message of error/success } 5. When the delivery is complete, our SMS Gateway will contact us via the report URL we provided. 6. Via Swagger definitions, we will use Koha::REST::V1::Messages delivery_report to handle the report. If the given status is "ERROR" (this is our example provider's protocol), we will update the message status (and add delivery note) in message_queue for the given message_id. 7. All done, we have now handled the report given by our SMS Gateway provider :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 14:32:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 12:32:06 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14217-70-ouiGDRI2gi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 --- Comment #7 from Barton Chittenden <barton at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #6) > This is certainly an interesting development! > > But it might need some further (broader) discussion before getting in. > In the first place: Why do we really need it? Can you elaborate/illustrate? > If we add conditions, what kind of conditions do we want? Syntax? Etc. A > broader design may be easier to maintain.. > How do comparable systems implement this? > If we add this for Zebra, what about other search engines? Marcel, The functionality definitely *is* needed -- see, for instance bug 14277, where the meaning of 521$a varies drastically based on the value of ind1. The 'condition=' syntax feels like overkill to me -- before work with the inicators, I assumed that the arguments to the <index_subfields> xml tag were essentially limits that were ANDed together... I guess they're not, but I think that we could pull a 'convention over configuration' fast one and pretend that they are: 'tag' and 'subfield' are required attributes, specifying the marc field and subfield, alll other attributes are limits -- if not present, all matching tags/subfields will be used. ...or we could go with the 'condition=' syntax, and make it explicit. I'm fine either way, as long as I can limit by indicator. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 14:48:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 12:48:59 +0000 Subject: [Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes In-Reply-To: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14217-70-cTVxB3E37j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #6) > This is certainly an interesting development! > > But it might need some further (broader) discussion before getting in. > In the first place: Why do we really need it? Can you elaborate/illustrate? > If we add conditions, what kind of conditions do we want? Syntax? Etc. A > broader design may be easier to maintain.. > How do comparable systems implement this? There are some situations where you need to add conditions as Barton told you. Possible conditions (the ones I had in mind are conditions on the indicator values, as I stated on the commit message). As Barton wrote, if you want to send a field/subfield to a different index depending on the value of the indicators, you can do it with this. If you look at it, we already do it for authority records, but with a more complex syntax. Look at authority-koha-indexdefs.xml: <kohaidx:index_heading_conditional tag="450" test="substring(marc:subfield[@code='w']/text(), 2, 1)" subfields="abvxyz" subdivisions="vxyz"> <kohaidx:target_index>Previous-heading-see-from:p</kohaidx:target_index> </kohaidx:index_heading_conditional> the whole syntax is similar to the one i implement, but you need to add a new tag name if you want conditional indexing, while i just overload the current syntax, which is really convenient. > If we add this for Zebra, what about other search engines? Each search engine provides means to specify what/how to index. I guess stuff like ES are more flexible than Zebra, for sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 14:50:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 12:50:01 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-cchXehdj9K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42073|0 |1 is obsolete| | --- Comment #56 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42075&action=edit Bug 13618: Specific for XSLTBloc Fixes the raw text nicely Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 14:51:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 12:51:54 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-62rWQZ4D6m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:02:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:02:25 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-WojgTblFRU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14723 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 [Bug 14723] Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:02:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:02:25 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14723-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14723-70-TKKOtWcgRk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14536 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:04:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:04:33 +0000 Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee In-Reply-To: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13697-70-IpL5uWRT8Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 42076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42076&action=edit Bug 13697: (QA followup) idiomatic fix add > charge Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:04:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:04:54 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-8noGbTUYRe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #7 from Marc V?ron <veron at veron.ch> --- Created attachment 42077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42077&action=edit Screenshot from diff view - white chars in empty line 648 in C4/letters.pm Hi Joonas, There are some space chars in an empty line, see screenshot from diff view. Marc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:11:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:11:37 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-82HBhPL32G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41350|0 |1 is obsolete| | --- Comment #57 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42078&action=edit Fixed the plain texts. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:18:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:18:19 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-SSeWYGALdK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42078|Fixed the plain texts. |Bug 13618: Specific places description| |where we don't need to | |escape | | variables - intra -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:25:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:25:21 +0000 Subject: [Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions In-Reply-To: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14737-70-Zl7hVYM9Vt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Fix pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:25:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:25:52 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13383-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13383-70-4CTEPlS4uB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:26:19 +0000 Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee In-Reply-To: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13697-70-qOcrAqJNwE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Christophe and Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:27:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:27:00 +0000 Subject: [Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items. In-Reply-To: <bug-11880-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11880-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11880-70-MCrqZJlzi6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Frederick and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:33:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:33:07 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-B2BU9GnG79@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #152 from Marc V?ron <veron at veron.ch> --- Hi Marcel, Thanks a lot for QAing. I really appreciate. Question: Can we remove the 'problematic' patches from this huge patch set and then do a second round (maybe with a new bug number) after the 'unproblematic' patches have been pushed? Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:42:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:42:09 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-oSE7JKGfMD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #8 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Marc V?ron from comment #7) > Created attachment 42077 [details] > Screenshot from diff view - white chars in empty line 648 in C4/letters.pm > > Hi Joonas, > > There are some space chars in an empty line, see screenshot from diff view. > > Marc When I apply the patch and try to edit with Gedit, Atom, Nano none of these editors see the whitespace. Can you please make a follow-up where you remove it because I'm not able to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:43:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:43:52 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-0oF83a3mbE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #27 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Enhancement pushed to master. Nice one David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:44:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:44:13 +0000 Subject: [Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line In-Reply-To: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14703-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14703-70-uElmUfu0Xa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Joonas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:44:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:44:43 +0000 Subject: [Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability In-Reply-To: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14337-70-DzlXPuodnh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Kyle and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:46:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:46:30 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-Tqw3gH5d2b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #9 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Joonas Kylm?l? from comment #8) > (In reply to Marc V?ron from comment #7) > > Created attachment 42077 [details] > > Screenshot from diff view - white chars in empty line 648 in C4/letters.pm > > > > Hi Joonas, > > > > There are some space chars in an empty line, see screenshot from diff view. > > > > Marc > > When I apply the patch and try to edit with Gedit, Atom, Nano none of these > editors see the whitespace. Can you please make a follow-up where you remove > it because I'm not able to. I think the problem is with the bugzilla's diff shower because in my patch I didn't even modify that line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:47:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:47:52 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-WIrFm2r5yI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 42079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42079&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. variables - intra -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:49:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:49:53 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-MCo4j4R5NH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com, | |nicole at bywatersolutions.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:51:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:51:17 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-IyoWhjhEzy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 15:58:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 13:58:47 +0000 Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-B0rlkFyR1M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- % sudo service mysql stop % prove t/Biblio_TransformHtmlToXml.t t/Biblio_TransformHtmlToXml.t .. DBI connect('dbname=koha_ut;host=localhost;port=3306','koha_',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/share/perl5/DBIx/Connector.pm line 32. We already have a t/Biblio/TransformKohaToMarc.t, it makes much more sense to put this new file in the t/Biblio dir, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:00:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:00:12 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-Tt0pveMXmT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41502|0 |1 is obsolete| | Attachment #41527|0 |1 is obsolete| | --- Comment #10 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42080&action=edit Bug 14620 - Contact information validations I'm thinking we should centralize all patron's contact information validators into one module. Currently we only have validations for e-mail addresses, using the Email::Valid module. In our local library we also want to validate phone numbers with a regex that only recognizes phone numbers from my country. So I suggest we create a phone number validation as well, with an option to easily create custom regex for your local use. If a library does not wish to use validations, we should give them an option to turn them off. If more local validators are implemented, we should also give the library an option to select which validator they wish to use. With this method we could implement phone number validators from around the world and add them into our module. Then we would make the validations simply by calling our validator. The validator would know by system preference which one of the implemented phone number validators it should use. Validations should be both client and server side. Test plan: 1. Apply the patches (and run updatedatabase.pl). 2. Set system preferences ValidateEmailAddress to "Enable" and ValidatePhoneNumber to "International Phone Numbers". 3. Make sure JavaScript is enabled. 4. Navigate to edit user contact informations in Staff client and OPAC. 5. Clear email and phone fields. 6. Insert whitespaces to email and phone fields and submit the form. 7. Edit patron. 8. Observe that there are no longer whitespaces in email and phone fields. 9. Insert invalid email (e.g. "invalid") and invalid phone number ("+123invalid") and send the form. 10. Confirm that form will not be submitted and errors will be given. 11. Disable JavaScript. 12. Insert invalid email and invalid phone number 13. Try sending the form again. 14. Confirm that form will be submitted but errors will be given on top of the form. 15. Observe that none of the changes are accepted. 16. Set system preferences ValidateEmailAddress to "Disable" and ValidatePhoneNumber to "none". 17. Repeat step 3-9 but observe that errors will not be given and changes will be submitted and saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:02:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:02:27 +0000 Subject: [Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0! In-Reply-To: <bug-14543-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14543-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14543-70-gcKxDSpcMB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I would be happy to test this patch if it was not dependent on bug 14541. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:03:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:03:16 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13411-70-JDgm228xTz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:03:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:03:19 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13411-70-E1wqq8KjGJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42035|0 |1 is obsolete| | Attachment #42036|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42081&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:03:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:03:26 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13411-70-gJYnJOW3l8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42082&action=edit Bug 13411 [QA Followup] - Add logging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:04:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:04:50 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13411-70-G8IZSGk3bU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #28 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Colin Campbell from comment #25) > Patch not working as advertised - in the rebasings it looks like we've lost > the check of the config value to pass to checkin so the checked_in_ok > variable is never passed Thanks for catching that! I've re-rebased the patch to correct that omission! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:07:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:07:57 +0000 Subject: [Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences In-Reply-To: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14590-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14590-70-XH8Skz7RnU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #9 from Lari Taskula <larit at student.uef.fi> --- This patch makes both client and server side validations, both in OPAC and Staff client. Depends on Bug 14620. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to "ipn" 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything), and allow syspref EnhancedMessagingPreferences 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to "your personal details" 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to "your messaging" 7. Check all messaging preferences and submit changes 8. Navigate to "your personal details" 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for "Phone" and "Email" columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:08:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:08:09 +0000 Subject: [Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted In-Reply-To: <bug-14621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14621-70-wOqdd9TmPM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |larit at student.uef.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:08:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:08:15 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: <bug-14541-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14541-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14541-70-ZHsApDCFFA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #11 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #5) > Kyle, > The tax rate is displayed at several places, at least acqui/supplier.tt. > The change should affect all the places where it is displayed. > You should also have a look at how I display them on bug 13323 using a > template plugin: [% order.gstrate * 100 | $Price %] > > I can provide a patch on top of bug 13323 if you can wait for it to be > pushed. That works for me Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:10:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:10:40 +0000 Subject: [Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn In-Reply-To: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14598-70-MaBRL3gTpf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:12:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:12:03 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test In-Reply-To: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14602-70-pAO4Ugzlh2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Signed Off |RESOLVED --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- ping Mason! % git checkout -b bug_14602 3b23fb8 Switched to a new branch 'bug_14602' % prove t/Creators.t t/Creators.t .. ok All tests successful. Files=1, Tests=16, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.60 cusr 0.02 csys = 0.66 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:16:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:16:46 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-kX2CgbLuhk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #18 from Kyle M Hall <kyle.m.hall at gmail.com> --- Thanks, I understand what you were asking now. > > t/db_dependent/BiblioObject.t > > I would prefer a better filename, but nothing in mind to suggest. I feel the same way, but have nothing better to suggest either. > > +my $field_mappings = Koha::Database->new()->schema()->resultset('Fieldmapping'); > > Could be better to have a Koha::Fieldmapping[s] I can do this if you'd like. It was just a quick way to create a field mapping, so I went with dbic directly. Just let me know if you want me to go ahead an add a followup to add and use Koha::Fieldmapping[s] > > > - waiting_count => $wcount, > > This variable is still used in the template. > > > + WAITING => $reserves->waiting() > > Why not remove this one and access to the waiting holds using > RESERVES.waiting in the template? I'm working on these ones right now. Question, I see in the code that there is a "Waiting" tab for only waiting holds, yet I don't see it in the opac ( while on master ). Is this dead code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:19:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:19:30 +0000 Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype In-Reply-To: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14651-70-hpzeRpZD97@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41635|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 42083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42083&action=edit Bug 14651: (regression test) fallback to bib-level if itype is undef Koha::Item->effective_itemtype should fallback to biblio-level itemtype even if item-level item types are set, in the case the item has no itemtype set (bad migration, bad old code). To test: - Run $ prove t/db_dependent/Items.t => FAIL: Koha::Item->effective_itemtype doesn't work properly Edit: Added a test for a warning when falling back as per QA request and because it made a lot of sense :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:19:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:19:36 +0000 Subject: [Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype In-Reply-To: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14651-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14651-70-R9hDmD9V5G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41636|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 42084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42084&action=edit Bug 14651: Koha::Item->effective_itemtype fallback to bib-level In some situations (bad migrations, old bugs that introduced bad data, people having bib-level itypes for ages and switching to item level...) the user ends with undex itype values for items. The current code, if the user has item_level-itype set, just returns undef. It should fallback to bib-level. In order to avoid hiding the problem a warning is raised. To test: - Run the regression tets: $ prove t/db_dependent/Items.t => FAIL: tests fail. - Apply the patch - Run the tests again => SUCCESS: The tests now pass. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:52:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:52:53 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-ox1J937dKL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42044|0 |1 is obsolete| | --- Comment #136 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 42085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42085&action=edit Bug 13799: RESTful API with Mojolicious and Swagger2 Actual routes are: /borrowers Return a list of all borrowers in Koha /borrowers/{borrowernumber} Return the borrower identified by {borrowernumber} (eg. /borrowers/1) There is a test file you can run with: $ prove t/db_dependent/rest/borrowers.t All API stuff is in /api/v1 (except Perl modules) So we have: /api/v1/script.cgi CGI script /api/v1/swagger.json Swagger specification Change both OPAC and Intranet VirtualHosts to access the API, so we have: http://OPAC/api/v1/swagger.json Swagger specification http://OPAC/api/v1/{path} API endpoint http://INTRANET/api/v1/swagger.json Swagger specification http://INTRANET/api/v1/{path} API endpoint Add a (disabled) virtual host in Apache configuration api.HOSTNAME, so we have: http://api.HOSTNAME/api/v1/swagger.json Swagger specification http://api.HOSTNAME/api/v1/{path} API endpoint Add 'unblessed' subroutines to both Koha::Objects and Koha::Object to be able to pass it to Mojolicious Test plan: 1/ Install Perl modules Mojolicious and Swagger2 2/ perl Makefile.PL 3/ make && make install 4/ Change etc/koha-httpd.conf and copy it to the right place if needed 5/ Reload Apache 6/ Check that http://(OPAC|INTRANET)/v1/borrowers and http://(OPAC|INTRANET)/v1/borrowers/{borrowernumber} works Optionally, you could verify that http://(OPAC|INTRANET)/vX/borrowers (where X is an integer greater than 1) returns a 404 error Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 16:58:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 14:58:34 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-Vu25tz4xV4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42085|0 |1 is obsolete| | --- Comment #137 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 42086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42086&action=edit Bug 13799: RESTful API with Mojolicious and Swagger2 Actual routes are: /borrowers Return a list of all borrowers in Koha /borrowers/{borrowernumber} Return the borrower identified by {borrowernumber} (eg. /borrowers/1) There is a test file you can run with: $ prove t/db_dependent/rest/borrowers.t All API stuff is in /api/v1 (except Perl modules) So we have: /api/v1/script.cgi CGI script /api/v1/swagger.json Swagger specification Change both OPAC and Intranet VirtualHosts to access the API, so we have: http://OPAC/api/v1/swagger.json Swagger specification http://OPAC/api/v1/{path} API endpoint http://INTRANET/api/v1/swagger.json Swagger specification http://INTRANET/api/v1/{path} API endpoint Add a (disabled) virtual host in Apache configuration api.HOSTNAME, so we have: http://api.HOSTNAME/api/v1/swagger.json Swagger specification http://api.HOSTNAME/api/v1/{path} API endpoint Add 'unblessed' subroutines to both Koha::Objects and Koha::Object to be able to pass it to Mojolicious Test plan: 1/ Install Perl modules Mojolicious and Swagger2 2/ perl Makefile.PL 3/ make && make install 4/ Change etc/koha-httpd.conf and copy it to the right place if needed 5/ Reload Apache 6/ Check that http://(OPAC|INTRANET)/api/v1/borrowers and http://(OPAC|INTRANET)/api/v1/borrowers/{borrowernumber} works Optionally, you could verify that http://(OPAC|INTRANET)/vX/borrowers (where X is an integer greater than 1) returns a 404 error Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:02:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:02:21 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-9cS4ZqKpaz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #138 from Alex Arnaud <alex.arnaud at biblibre.com> --- reattached the patch because i've changed the webservices url in the commit message (http://(OPAC|INTRANET)/api/v1/borrowers instead of http://(OPAC|INTRANET)/v1/borrowers) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:05:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:05:14 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10855-70-skoMEqQQlg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA Assignee|jonathan.druart at bugs.koha-c |julian.maurice at biblibre.com |ommunity.org | --- Comment #224 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Julian, there is a bug here. The additional_field_values entries are not deleted when a subscription is deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:13:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:13:09 +0000 Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11084-70-szYjHrUG1r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:24:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:24:41 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-8q9nU3MYKa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42079|0 |1 is obsolete| | --- Comment #59 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42087&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:25:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:25:42 +0000 Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-aMTrple0Uc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #16) > % sudo service mysql stop > > % prove t/Biblio_TransformHtmlToXml.t > t/Biblio_TransformHtmlToXml.t .. DBI > connect('dbname=koha_ut;host=localhost;port=3306','koha_',...) failed: Can't > connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' > (2) at /usr/share/perl5/DBIx/Connector.pm line 32. Oops, forgot that it checks a preference.. > We already have a t/Biblio/TransformKohaToMarc.t, it makes much more sense > to put this new file in the t/Biblio dir, don't you think? Will move it to t/db_dependent somewhere.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:30:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:30:33 +0000 Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-kuIgu1Jbst@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:30:35 +0000 Subject: [Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml In-Reply-To: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11247-70-99FfokBqjD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41972|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 42088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42088&action=edit Bug 11247: Add a simple unit test for TransformHtmlToXml The unit test is db dependent (as Jonathan correctly remarked), since the sub checks a preference. Test plan: Run t/db_dependent/Biblio/TransformHtmlToXml.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:34:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:34:00 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-IKj7Y7CYW4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #10 from Marc V?ron <veron at veron.ch> --- Created attachment 42089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42089&action=edit [Follow-up] Remove whitespace from line 648 in C4/Letters.pm White space in 'empty' line removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:34:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:34:34 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-v2G9TwI7n8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:42:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:42:52 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-5tL94HVZxv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #18) > Question, I see in the code that there is a "Waiting" tab for only waiting > holds, yet I don't see it in the opac ( while on master ). Is this dead code? It looks like more than a bug :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 17:47:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 15:47:53 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-sVlfNwkeOq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #19) > (In reply to Kyle M Hall from comment #18) > > Question, I see in the code that there is a "Waiting" tab for only waiting > > holds, yet I don't see it in the opac ( while on master ). Is this dead code? > > It looks like more than a bug :) After a deep dive into the code, it seems broken for a while! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 18:25:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 16:25:07 +0000 Subject: [Koha-bugs] [Bug 14752] New: Add multiple copies to a basket at once Message-ID: <bug-14752-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Bug ID: 14752 Summary: Add multiple copies to a basket at once Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 18:28:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 16:28:25 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: <bug-12544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12544-70-thyaf2ojSs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jweaver at bywatersolutions.co | |m Status|NEW |ASSIGNED CC| |jweaver at bywatersolutions.co | |m, | |nicole at bywatersolutions.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 18:34:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 16:34:19 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: <bug-12663-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12663-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12663-70-8BHSos5f0K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jweaver at bywatersolutions.co |ity.org |m CC| |jweaver at bywatersolutions.co | |m, | |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 18:47:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 16:47:00 +0000 Subject: [Koha-bugs] [Bug 14753] New: Show accession date on checkin Message-ID: <bug-14753-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 Bug ID: 14753 Summary: Show accession date on checkin Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, nicole at bywatersolutions.com This will have a CSS class for easy hiding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 19:14:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 17:14:42 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: <bug-14292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14292-70-icHuGfqWVR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard at gmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 23:08:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 21:08:34 +0000 Subject: [Koha-bugs] [Bug 14754] New: save fail safe Message-ID: <bug-14754-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14754 Bug ID: 14754 Summary: save fail safe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Every page with 'save' on it should warn before leaving and not saving - cause you can do back button or click home at any time and lose your info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 28 23:26:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Aug 2015 21:26:27 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-kL2yv0RVtu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Heather <heather_hernandez at nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #7 from Heather <heather_hernandez at nps.gov> --- I tried it out here: http://browse.koha.catalystdemo.net.nz It seems nice, but it doesn't seem like a true browse to me--what I look for in a browse is to enter a search term, and have the results returned to be what is exactly before my searched term in the given index, then where the searched term is/would be, then what is exactly after the searched term in the index. So there would be no need for "exact, fuzzy, really fuzzy," because when I browse an index, I want the results to be what is before and after that term in the given index. That said, when I searched "exact" for "Author": Rowling I get: Rowling, J. K. Rowling, J.K. This is nice, but, again, it doesn't seem like a "browse" to me--these are just search results. When I click the names, I get the exact same search results as I do via Advanced Search, Author Phrase: http://browse.koha.catalystdemo.net.nz/cgi-bin/koha/opac-search.pl?idx=au%2Cphr&q=rowling&op=and&idx=kw&op=and&idx=kw&do=Search&sort_by=relevance&limit= If I Browse via "Fuzzy" with: Rowling I get these results: Rollins, Henry, Rowland, Sarah-Jane. Rowlands, David. Rowlands, Gena. Rowling, J. K. Rowling, J.K. Which does show me some results which should be in the author index above Rowling, but I get no results that should be in the author index after Rowling. "Really fuzzy" is the same. I would like to see the searched for term in the middle of hits that occur before and after it in the index, e.g. something like this (an author "Browse" result, with made up examples below Rowling, J.K.): Rollins, Henry, Rowland, Sarah-Jane. Rowlands, David. Rowlands, Gena. Rowling, J. K. Rowling, J.K. Rowlins, Fred. Rozalind, Sue. Rualla, Max. Ruscha, Ed. Ruther, Martin. Quahog, Amir. Quaker Alliance for Peace. I hope this is helpful! --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 06:20:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 04:20:07 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test In-Reply-To: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14602-70-dZ5T2xW6Wt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #6 from Mason James <mtj at kohaaloha.com> --- (In reply to Jonathan Druart from comment #4) > It passes for me (using a dev install from git). if you use koha-shell to run tests (and you should be!), it will fail so, bug still exists for some situations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 06:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 04:21:23 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test In-Reply-To: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14602-70-7inNrCCehV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 06:21:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 04:21:54 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test In-Reply-To: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14602-70-sh3yjXypTE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 06:22:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 04:22:38 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell In-Reply-To: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14602-70-PGBb5uM4bj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix failing t/Creators.t |Fix failing t/Creators.t |test |test, when using koha-shell -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 09:34:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 07:34:51 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-ndkKuOhNLf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42072|0 |1 is obsolete| | --- Comment #60 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42090&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 09:36:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 07:36:07 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-BHDA1rHDhz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42009|0 |1 is obsolete| | --- Comment #61 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42091&action=edit Bug 13618: Specific for Salutation on editing a patron Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 09:37:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 07:37:07 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-rkKGHFMMqN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41352|0 |1 is obsolete| | --- Comment #62 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42092&action=edit Bug 13618: Specific for the ISBD view Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 10:04:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 08:04:10 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-91aGyf3dts@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #63 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Jonathan Druart from comment #35) > Created attachment 41353 [details] [review] > Bug 13618: Fix error 'Not a GLOB reference' > > The interpolation of a variable on including a file caused an unexpected > error: > Template process failed: undef error - Not a GLOB reference at > /usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619. > > The easier fix is to replace it with a SWITCH. Did you considered adding .raw in the end of the Koha.Preference( 'AddressFormat' ) ? It would be more generalized code and it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 10:09:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 08:09:06 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-DFJniwD6zw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41351|0 |1 is obsolete| | --- Comment #64 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42093&action=edit Bug 13618: Specific for pagination_bar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 10:20:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 08:20:51 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-17hhayYKik@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41348|0 |1 is obsolete| | --- Comment #65 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42094&action=edit Bug 13618: Specific places where we don't need to escape variables There is no need to escape the html generated by the XSLT. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 10:24:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 08:24:14 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-tBZ68mG6L3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41355|0 |1 is obsolete| | --- Comment #66 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42095&action=edit Bug 13618: Specific for ColumnsSettings Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 10:37:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 08:37:59 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-P79nuyN1Iv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42093|0 |1 is obsolete| | --- Comment #67 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42096&action=edit Bug 13618: Specific for pagination_bar Last time for some reason I didn't sign-off this even though I supposed to. Patch looks good. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> variables - intra -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 11:12:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 09:12:10 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-tr2ysNbfi8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #68 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Jonathan Druart from comment #28) > Created attachment 41347 [details] [review] > Bug 13618: Remove html filters at the OPAC > > This patch removes the html filters at the OPAC, if necessary. > > Generated with: > perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc @@ -85,7 +85,7 @@ [% END %] ). [% END %] - <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url %]&count=[% countrss |html %]&sort_by=acqdate_dsc&forma~ + <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url %]&count=[% countrss %]&sort_by=acqdate_dsc&format=rss2~ [% END # / IF total %] </p> [% END # / IF searchdesc %] Shouldn't that one also be removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 11:19:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 09:19:34 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-MkcHcQGFqT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #69 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Joonas Kylm?l? from comment #68) > (In reply to Jonathan Druart from comment #28) > > Created attachment 41347 [details] [review] [review] > > Bug 13618: Remove html filters at the OPAC > > > > This patch removes the html filters at the OPAC, if necessary. > > > > Generated with: > > perl -p -i -e 's/\ ?\|\ ?html(\ ?)%/\1%/g' **/*.tt **/*.inc > > @@ -85,7 +85,7 @@ > [% END %] > ). > [% END %] > - <a href="[% OPACBaseURL > %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url > %]&count=[% countrss |html %]&sort_by=acqdate_dsc&forma~ > + <a href="[% OPACBaseURL > %]/cgi-bin/koha/opac-search.pl?[% query_cgi | url %][% limit_cgi |html | url > %]&count=[% countrss %]&sort_by=acqdate_dsc&format=rss2~ > [% END # / IF total %] > </p> > [% END # / IF searchdesc %] > > Shouldn't that one also be removed? Also in this patch there was two more of these so they should be maybe removed also if this one is. I used regex ^\+.+\|html to find these -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 11:22:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 09:22:16 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-Z50UJoYSv3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41349|0 |1 is obsolete| | --- Comment #70 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42097&action=edit Bug 13618: Remove html filters at the intranet Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 11:28:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 09:28:37 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-lJw8GrfiXM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #71 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Jonathan Druart from comment #37) > Created attachment 41354 [details] [review] > Bug 13618: Specific for IntranetUser* and OPACUser* prefs --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt @@ -8,7 +8,7 @@ <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/lib/bootstrap/css/bootstrap.min.css" /> <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/lib/jquery/jquery-ui.css" /> <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/sco.css" /> -[% IF ( OPACUserCSS ) %]<style type="text/css">[% OPACUserCSS %]</style>[% END %] +[% IF ( OPACUserCSS ) %]<style type="text/css">[% OPACUserCSS.raw %]</style>[% END %] [% IF ( SCOUserCSS ) %]<style type="text/css">[% SCOUserCSS %]</style>[% END %] Why not have also raw SCOUserCSS if we let the user have OPACUserCSS as raw? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 12:25:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 10:25:24 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-8uuICvbFKS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #72 from Joonas Kylm?l? <j.kylmala at gmail.com> --- The front page in Staff side doesn't render html under News->What's Next. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 12:59:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 10:59:17 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10181-70-gEmM7yqmhd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42071|0 |1 is obsolete| | --- Comment #6 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42098&action=edit Bug 10181: Acq - Improve message for deleted records Test plan didn't quite work for the step 6, but it doesn't have any effect on this patch. So looks good to me. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 13:01:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 11:01:10 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10181-70-QyCkvhcVnG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42070|0 |1 is obsolete| | --- Comment #7 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42099&action=edit Bug 10181: Make string translatable Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 13:02:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 11:02:18 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10181-70-KuSJHn1Llt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |j.kylmala at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 29 18:15:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Aug 2015 16:15:44 +0000 Subject: [Koha-bugs] [Bug 14753] Show accession date on checkin In-Reply-To: <bug-14753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14753-70-fKmW2iXx4q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe we could also use the columns configuration for the table on this page? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 00:15:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Aug 2015 22:15:06 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell In-Reply-To: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14602-70-6BOVaK6ayc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Mason James from comment #6) > (In reply to Jonathan Druart from comment #4) > > It passes for me (using a dev install from git). > > if you use koha-shell to run tests (and you should be!), it will fail > > so, bug still exists for some situations I'm not against the patch, but Liz, didn't w find a koha-shell bug the other day? Maybe it is related -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 00:24:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Aug 2015 22:24:00 +0000 Subject: [Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell In-Reply-To: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14602-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14602-70-tlvoa9lWCt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 --- Comment #8 from Liz Rea <liz at catalyst.net.nz> --- Naw, that bug is that on a gitified install koha-shell uses the system /usr/share/koha PERL5LIB instead of the one from the git install, and that can cause general test weirdness. I think this is different, I get this issue in my vagrant and/or gitify installs as well. Something to do with the fact that it can't write a temp file, but I didn't have time to try and fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 01:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Aug 2015 23:54:08 +0000 Subject: [Koha-bugs] [Bug 14398] Duplicate inventory results when an item is in the wrong place (ie using branch/location filter) In-Reply-To: <bug-14398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14398-70-BB0Wyfto2M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14398 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|patrick.munro787 at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 01:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Aug 2015 23:54:08 +0000 Subject: [Koha-bugs] [Bug 14677] Inventory: Compare Barcodes List to Result function In-Reply-To: <bug-14677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14677-70-kNJhtT0Hzd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14677 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|patrick.munro787 at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 01:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Aug 2015 23:54:08 +0000 Subject: [Koha-bugs] [Bug 4120] Add options for handling holds in self checkout In-Reply-To: <bug-4120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4120-70-68aTz2wJNf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4120 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|patrick.munro787 at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 04:18:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 02:18:42 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: <bug-11213-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11213-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11213-70-7GkRetdAgJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #60 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #59) > Applying: bug_11213: C4::VirtualShelves::Page::shelf_contents() > fatal: sha1 information is lacking or useless (C4/VirtualShelves/Page.pm). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. Not sure why. Applying: bug_11213: C4::VirtualShelves::Page::shelf_contents() Using index info to reconstruct a base tree... M C4/VirtualShelves/Page.pm Falling back to patching base and 3-way merge... Auto-merging C4/VirtualShelves/Page.pm etc Can you please give it another go? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 04:43:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 02:43:24 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-vD9cVuJiyd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #8 from Robin Sheat <robin at catalyst.net.nz> --- (In reply to Heather from comment #7) > I tried it out here: http://browse.koha.catalystdemo.net.nz > It seems nice, but it doesn't seem like a true browse to me--what I look for > in a browse is to enter a search term, and have the results returned to be > what is exactly before my searched term in the given index, then where the > searched term is/would be, then what is exactly after the searched term in > the index. So there would be no need for "exact, fuzzy, really fuzzy," > because when I browse an index, I want the results to be what is before and > after that term in the given index. There are technical reasons why this is particularly hard, essentially that pulling the index terms out in order is not something that can readily be done without patching Elasticsearch itself, which I'm considering out of scope of this project :) However, when I thought about it with that in mind, I got to wondering what the point of a complete alphabetical index really is to a library user. There's no semantic relationship between a word that starts with R and a word that starts with S, why would it be meaningful to put one beside the other. A subject of "Symbols" is not closely related to a subject of "Tarantulas", just because they're alphabetically close. However, an author name of "Stephen" is (sorta) semantically related to an author name of "Steven", if the user hasn't quite remembered the whole name or the spelling. > That said, when I searched "exact" for "Author": Rowling > I get: > Rowling, J. K. > Rowling, J.K. This is a GIGO situation with the data that is the result of it not being terribly cleanly catalogued in the first place. I tend to prefer working with data like this as it is better at highlighting odd edge cases. I've been thinking about ways to correct for cases like this (where it's just a punctuation or whitespace difference), but it presents some issues relating to how it'd be done reliably with no false positives. So I've postponed further thinking about it for now. In an ideal world, everyone will be using authorities anyway, and this won't happen :) > This is nice, but, again, it doesn't seem like a "browse" to me--these are > just search results. When I click the names, I get the exact same search > results as I do via Advanced Search, Author Phrase: It is doing pretty much the same thing as a search, yes. Essentially, it's goal is to be an easier way to look for some specific things, possibly when you're a bit unsure about the details. I think that subjects will benefit from this the most actually, as scrolling through "Birds -- Kakapo", "Birds -- Kea", "Birds -- Kiwi" is something that has real use. Additionally, a search for "Kiwi" will also find "Birds -- Kiwi" (though this behaviour isn't visible in the data that's currently on the test site due to the way it's catalogued.) > If I Browse via "Fuzzy" with: Rowling > I get these results: > Rollins, Henry, > Rowland, Sarah-Jane. > Rowlands, David. > Rowlands, Gena. > Rowling, J. K. > Rowling, J.K. > > Which does show me some results which should be in the author index above > Rowling, but I get no results that should be in the author index after > Rowling. "Really fuzzy" is the same. I'll double check this, but it's most likely that in this database, there's just nothing further that matches. Actually, in this case, fuzzy and extra fuzzy will be doing the same thing as there's a max edit distance limit for the fuzziness, and I think it will have been hit. I'm probably going to remove the "extra fuzzy" option anyway, it risks being more confusing than anything. > I would like to see the searched for term in the middle of hits that occur > before and after it in the index, e.g. something like this (an author > "Browse" result, with made up examples below Rowling, J.K.): But why? What does an alphabetically adjacent author tell you about that set of authors, and what does it provide that a library user would find useful? (Technical reasons for why this is hard aside.) > I hope this is helpful! --h2 Thanks for checking it out! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 07:08:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 05:08:08 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-Z73jA1Fw3Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 --- Comment #11 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42100&action=edit Bug 14526: (follow-up) add a space before equals sign -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 07:16:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 05:16:01 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-vrvJKWCd3B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41807|0 |1 is obsolete| | --- Comment #12 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42101&action=edit Bug 14526: MoveReserve should look at future holds too Test plan works. Did also my own checking and tried to find any problems this change might cause. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 07:20:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 05:20:20 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12478-70-ran9FWuoCM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #91 from Robin Sheat <robin at catalyst.net.nz> --- (In reply to Jonathan Druart from comment #81) > Well, it's defined yes, but does not work at all (the marc21 mappings are > used) :) > It is caused by some errors in the sql file. Patch's coming. Ah, ta. > > Note the following: > MariaDB [koha_es_unimarc]> insert into search_field (name, type) select > distinct mapping, type from elasticsearch_mapping; > Query OK, 73 rows affected, 57 warnings (0.05 sec) > Records: 73 Duplicates: 0 Warnings: 57 > > MariaDB [koha_es_unimarc]> show warnings; > +---------+------+--------------------------------------------+ > | Level | Code | Message | > +---------+------+--------------------------------------------+ > | Warning | 1265 | Data truncated for column 'type' at row 1 | Hmm, I remember that, but I'm not 100% sure it mattered. Could be wrong though. > Yes of course, but I am not a real tester, I am a developer, and it would be > useful to share info on specific data. > I am fine to use the sandbox DB, if it's ok for you. Fair point. Let me see if I can tidy the database some for uploading somewhere. Here it is: http://elasticsearch.koha.catalystdemo.net.nz/files/koha_es_marc21.sql.bz2 it's not the best data, but it's good enough for messing about with. > > > 2/ The number of tests provided is very low. > > Yes, I've been meaning to go back and add a pile more. > Ok, I let it that for you :) Oh, you don't have to. I don't mind if you go and write them all for me :) > Patch is coming. > Patch is coming. > Patch is coming. > Patch is coming. Thanks! > > Yes it has: > title":["Dollhouse"],["Seasons one & two."]] > > 245$a Dollhouse > 490$a Seasons one & two. > > But 245$a should be used for sorting :) Yes, that's something I'm trying to fix at the moment :) > The item is a "Visual Materials" which has a itemtype.notforloan flag set. Good to know, I've not tested that case yet. > Outch, not sure how I could find that easily. Probably easiest to construct a case manually. > It comes from the 008 > > "Pictura mural?*" has "pubdate":"||||" (/_search?q=_id:39&pretty) > 008 090409|||||||||xx |||||||||||||| ||und|| > > The Korean Go Association's learn to play go "pubdate":"uuuu" > 008 971030muuuu9999nyua 000 0 eng > > But the index should not contain an invalid date. Hmm. I don't know if we can put validation into the fixer rules. I'll have to explore that some further. Possibly also telling ES that this must be a number could cause bad data to get rejected, but it may reject the whole record, not sure. Do you happen to know how zebra handles that? > For Solr (you can find the code on the BibLibre repo at > https://git.biblibre.com/biblibre/koha_biblibre/commits/dev/solr Browse > C4/Search/), we used a system of plugins. And there is a Date plugin > (https://git.biblibre.com/biblibre/koha_biblibre/blob/ > bd38ce1811289fcfbd75a37ec99fc4cd3c5d37f4/C4/Search/Plugins/Date.pm) which > does this job. > A plugin can be linked to a mapping. We probably can't directly reuse that, at present we're using Catmandu do do the data conversion and interfacing with ES for the most part. But it's possible I can hook something in somewhere. > Just a note: I know nobody has ever had a look at the Solr code, but it is > used in production by several (4 or 5) customers for more than 4 years now. > And I have already had all the issues and problems you will encounter. I'm sure I'll encounter some exciting new ones :) > I will try and see if I can find some time and propose something here, I you > want some help. Sure, anything is welcome. (In reply to Jonathan Druart from comment #90) > Something else, there is a sort issue in the facets: > > [Some entries] > Zeitoun, Ariel, > ? Cadhain, M?irt?n. > ?lez, Ts.. > > ? should be after O, not after Z. Line 573 of opac/opac-search.pl does a sort with cmp, which isn't very unicode aware. I'm putting that in the not-my-problem bin as it's in upstream :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 07:47:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 05:47:17 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-GPSXZLYZgf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42014|0 |1 is obsolete| | --- Comment #13 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42102&action=edit Bug 14526: Add some unit tests for MoveReserve Test plan worked. Code looks just what it should look like. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 07:48:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 05:48:34 +0000 Subject: [Koha-bugs] [Bug 14526] MoveReserve should look at future holds too In-Reply-To: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14526-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14526-70-7P3QZc206b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 08:17:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 06:17:12 +0000 Subject: [Koha-bugs] [Bug 14755] New: Checking in gives error 500 Message-ID: <bug-14755-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755 Bug ID: 14755 Summary: Checking in gives error 500 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: j.kylmala at gmail.com Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When I try to Check in an item with the top bar Check in functionality I get this error: An error has occurred! Error 500 In Koha this typically means that the Koha team is working on new features Wait while system maintenance is being done or email the Koha administrator. Use top menu bar to navigate to another part of Koha. In the koha-error log: http://paste.koha-community.org/57 Checking in from the patron's details page works fine. I just did today a database upgrade to 3.21.00.21, so not sure if that is the problem or something else. I'm trying to figure out this and will let you know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 08:49:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 06:49:15 +0000 Subject: [Koha-bugs] [Bug 14756] New: The format you asked for ('') is unrecognized. Message-ID: <bug-14756-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14756 Bug ID: 14756 Summary: The format you asked for ('') is unrecognized. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With today's new git pull the error "The format you asked for ('') is unrecognized. at /C4/NewsChannels.pm line 212 " appeared. I tried to drop and recreate db but it didn't help. The error came after I had clicked the login button in staff side. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 08:51:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 06:51:13 +0000 Subject: [Koha-bugs] [Bug 14756] The format you asked for ('') is unrecognized. In-Reply-To: <bug-14756-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14756-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14756-70-uJmfYGuZcT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14756 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 09:45:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 07:45:26 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-vqKfZKn313@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #79 from Gaetan Boisson <gaetan.boisson at biblibre.com> --- The conf file needs to be more complete, an example conf file would be (note there was a small typo in Frederic's example in the metadataPrefix, but this one should work): --- format: marcxml: metadataPrefix: marcxml metadataNamespace: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim schema: http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd include_items: 1 oai_dc: metadataNamespace: http://www.openarchives.org/OAI/2.0/oai_dc/ metadataPrefix: oai_dc schema: http://www.openarchives.org/OAI/2.0/oai_dc.xsd xsl_file: /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2OAIDC.xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 10:31:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 08:31:25 +0000 Subject: [Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token In-Reply-To: <bug-13568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13568-70-0GMzeTK6w0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- This patch will not be in 3.14.x so set as resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 10:31:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 08:31:26 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-Y5KM6uNy79@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Bug 12252 depends on bug 13568, which changed state. Bug 13568 Summary: OAI Server doesn't handle properly resumption token http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 10:48:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 08:48:07 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-4kgB4V0qRr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #80 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- There is a problem I think in "OAI-PMH items respect OpacHiddenItems" : This patch changes GetMarcBiblio adding "opac" arg. But there is no : $opac = shift -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 10:58:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 08:58:19 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-ahEdmHyHg1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #81 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Fridolin SOMERS from comment #80) > There is a problem I think in "OAI-PMH items respect OpacHiddenItems" : > > This patch changes GetMarcBiblio adding "opac" arg. > But there is no : $opac = shift Oups sorry, its corrected by patch : "Include item data only in extended mode" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:05:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:05:02 +0000 Subject: [Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. In-Reply-To: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14640-70-tLsA5mfrLY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:05:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:05:04 +0000 Subject: [Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. In-Reply-To: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14640-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14640-70-sMOwuDnpxt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41926|0 |1 is obsolete| | --- Comment #3 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42103&action=edit Bug 14640 - 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. Test plan passed, code looks good. Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:12:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:12:52 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9316-70-8i191kFZSw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #55 from Joonas Kylm?l? <j.kylmala at gmail.com> --- What's the status with this bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:20:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:20:32 +0000 Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21 In-Reply-To: <bug-11130-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11130-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11130-70-WJog8yqwUv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #7 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Mirko Tietgen from comment #5) > 11130 follow-up: DOM indexing Is there a follow-up coming or what do you mean by this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:25:39 +0000 Subject: [Koha-bugs] [Bug 12952] Log koha actions to syslog too In-Reply-To: <bug-12952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12952-70-tBiTCT29K5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12952 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #4 from Joonas Kylm?l? <j.kylmala at gmail.com> --- diff --git a/debian/scripts/koha-create b/debian/scripts/koha-create index 6891ac1..5c4aa2a 100755 --- a/debian/scripts/koha-create +++ b/debian/scripts/koha-create @@ -546,8 +546,12 @@ eof # Generate and install Apache site-available file and log dir. generate_config_file apache-site.conf.in \ "/etc/apache2/sites-available/$name.conf" + # Generate and install rsyslog conf + generate_config_file rsyslog-site.conf.in \ + "/etc/rsyslog.d/99-$name.conf" mkdir "/var/log/koha/$name" - chown "$username:$username" "/var/log/koha/$name" + chown "$username:adm" "/var/log/koha/$name" The last line should not have the group adm but $username instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:26:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:26:57 +0000 Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode) in acquisitions is broken In-Reply-To: <bug-11273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11273-70-yqLVNletlM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273 --- Comment #9 from Marc V?ron <veron at veron.ch> --- Created attachment 42104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42104&action=edit [Signed-off] Bug 11273: FIX barcode generation in acquisition if hbyymmincr When AutoBarcode is activated and you have set AcqCreateItem to 'on order' there is a Javascript error when you try to generate a barcode for the item: TypeError: document.f is undefined http://localhost:8080/intranet-tmpl/lib/jquery/jquery.js Line 11 Test plan: 0/ a. Set AutoBarcode to hbyymmincr b. Set AcqCreateItem to 'on ordering' c. Set the plugin barcode.pl to the barcode field for the default and the ACQ frameworks 1/ Go on the add items page (cataloguing/additem.pl) and confirm that the plugin works as expected. 2/ Go on the New order page (acqui/neworderempty.pl) and confirm that the plugin works as expected. Followed test plan, works as expected. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:27:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:27:20 +0000 Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode) in acquisitions is broken In-Reply-To: <bug-11273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11273-70-6STKmSncSw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #40989|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:27:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:27:32 +0000 Subject: [Koha-bugs] [Bug 11273] Barcode generation hbyymmincr (AutoBarcode) in acquisitions is broken In-Reply-To: <bug-11273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11273-70-KZlxD2zBeM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11273 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:41:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:41:08 +0000 Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21 In-Reply-To: <bug-11130-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11130-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11130-70-UhWhpDrKmL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 --- Comment #8 from Mirko Tietgen <mirko at abunchofthings.net> --- (In reply to Joonas Kylm?l? from comment #7) > (In reply to Mirko Tietgen from comment #5) > > 11130 follow-up: DOM indexing > > Is there a follow-up coming or what do you mean by this? It is already there. The patch includes the original one and the followup patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:43:14 +0000 Subject: [Koha-bugs] [Bug 11807] Add categorycode conversions to LDAP authentication. In-Reply-To: <bug-11807-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11807-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11807-70-1PrYxUXgLV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11807 --- Comment #5 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42105&action=edit Bug 11807: (follow-up) remove date conversions The date conversions are now removed with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:57:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:57:53 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-LXgtHT3Jfs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 --- Comment #6 from Marc V?ron <veron at veron.ch> --- Created attachment 42106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42106&action=edit [Signed-off] Bug 14505: single quotes in journal number cause print routing list window to not appear Escapes single quotes from serial.serialseq string. Test plan: 1. Have a serial with a number which has single quote in it. 2. Go to Serials -> Find some serial subscription -> Serial collection. 3. Set up a routing list for this serial. 4. Click on Print list under the column Routing. 5. Notice that the print window doesn't open. 6. Apply patch. 7. Notice that the print window opens. Sponsored-by: Vaara-kirjastot Followed test plan. Works as expected. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:58:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:58:14 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-c4zOd5tYLJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #41705|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 11:58:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 09:58:25 +0000 Subject: [Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear In-Reply-To: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14505-70-RuI9S2njPw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 12:08:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 10:08:53 +0000 Subject: [Koha-bugs] [Bug 14620] Contact information validations In-Reply-To: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14620-70-RiFgLxJ74K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42080|0 |1 is obsolete| | --- Comment #11 from Lari Taskula <larit at student.uef.fi> --- Created attachment 42107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42107&action=edit Bug 14620 - Contact information validations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 12:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 10:15:49 +0000 Subject: [Koha-bugs] [Bug 10468] patron print summary should show more In-Reply-To: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10468-70-13l4K7zpzD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron <veron at veron.ch> --- Patch works as expected but qa tools complain about forbidden patterns: FAIL members/summary-print.pl FAIL forbidden patterns forbidden pattern: tab char (line 131) forbidden pattern: trailing space char (line 138) forbidden pattern: tab char (line 130) forbidden pattern: tab char (line 134) forbidden pattern: tab char (line 133) forbidden pattern: trailing space char (line 135) forbidden pattern: trailing space char (line 137) forbidden pattern: trailing space char (line 140) forbidden pattern: tab char (line 132) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt FAIL forbidden patterns forbidden pattern: tab char (line 90) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 12:36:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 10:36:20 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: <bug-14555-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14555-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14555-70-lUOFKMHJHn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |martin at bugs.koha-community. | |org.xinxidi.net CC| |martin at bugs.koha-community. | |org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 12:44:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 10:44:40 +0000 Subject: [Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date. In-Reply-To: <bug-9004-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9004-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9004-70-njQUePzTgQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #14 from Joonas Kylm?l? <j.kylmala at gmail.com> --- (In reply to Kyle M Hall from comment #5) > Created attachment 13213 [details] [review] > Bug 9004 - Talking Tech doesn't account for holidays when calculating a > holds last pickup date - Add holidays check Code looks good to me but I'm unable to test this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 12:47:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 10:47:34 +0000 Subject: [Koha-bugs] [Bug 14555] Warns in opac-search.pl In-Reply-To: <bug-14555-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14555-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14555-70-uOllO84O2y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14555 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Can no longer reproduce. Perhaps already fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:03:29 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13906-70-gTUN97KffV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 --- Comment #13 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 42108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42108&action=edit Bug 13906 - TestObjectFactoreis squashables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:04:01 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: <bug-13995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13995-70-zb0zYiplY1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #15 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 42109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42109&action=edit Bug 13995 - Koha::Exception squashable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:04:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:04:34 +0000 Subject: [Koha-bugs] [Bug 14616] Introducing Koha::Object subclasses In-Reply-To: <bug-14616-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14616-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14616-70-0nXD7DVZBH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 42110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42110&action=edit Bug 14616 - Koha::Object subclasses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:05:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:05:08 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-0gHanajAQ1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #13 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 42111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42111&action=edit Bug 14536 - PageObject squashable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:07:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:07:57 +0000 Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database In-Reply-To: <bug-14698-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14698-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14698-70-rNWBM3mlZf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 42112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42112&action=edit Bug 14698 - AtomicUpdater - Keeps track of which updates have been applied to a database When deploying production databases to test environments, it is imperative to keep track of which database changes have been applied. When one is running, in production, features that require DB changes, and want to add more features which need more DB changes, keeping track of which updates have been applied is challenging. After several cycles of upgrade-deploy, with multiple atomicupdate-scripts piling to the atomicupdates/-directory, it is impossible to easily distinguish which updates have been applied and which are not. Rerunning the same update scripts again and again causes lots of noise in the upgrade log and hides real issues from being detected. Also repeatedly running upgrade scripts might cause bad side effects which are potentially hard to repair. This feature adds a script atomicupdate.pl which runs all atomicupdate/* scripts and .sqls and logs the event to the koha.atomicupdates-table. On subsequent runs of atomicupdate.pl, the already deployed upgrades are skipped, greatly reducing the unnecessary clutter and risk of upgrading. You can also remove existing log entries to allow rerunning the same upgrade script again, list all applied upgrades and show pending updates. Unit tests included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:09:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:09:28 +0000 Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database In-Reply-To: <bug-14698-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14698-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14698-70-CcEUvu9y5Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 42113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42113&action=edit Presentation about AtomicUpdate workflow for managing in-house features in production -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:09:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:09:56 +0000 Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database In-Reply-To: <bug-14698-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14698-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14698-70-4BZ0SxlB8u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:24:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:24:18 +0000 Subject: [Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database In-Reply-To: <bug-14698-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14698-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14698-70-jOaLnsr6Ic@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:45:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:45:22 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10933-70-iaWRmRWrI1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28022|0 |1 is obsolete| | --- Comment #13 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42114&action=edit Bug 10933: The PurgeSearchHistory should be merge into the C4::Search::History module Since bug 10803 adds a C4::Search::History module, the PurgeSearchHistory routine should be moved. Test plan: - run misc/cronjobs/cleanup_database.pl with the searchhistory param and verify behavior is the same as before applying this patch. - run prove t/Search/History.t Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:45:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:45:57 +0000 Subject: [Koha-bugs] [Bug 14656] Delete Bibliographic Records REST API route & permission In-Reply-To: <bug-14656-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14656-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14656-70-PB90lIYO0S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14656 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41550|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 42115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42115&action=edit Bug 14656 - Delete Bibliographic Records REST API route & permission !!Now with atomicupdates!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:46:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:46:03 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10933-70-f6KWvwMy8f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 13:46:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 11:46:06 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10933-70-rCiQFzmRKR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 --- Comment #14 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Created attachment 42116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42116&action=edit Bug 10933: (follow-up) fix the previous patch to work with master This makes the previous patch to work with the master branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:05:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:05:54 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13918-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13918-70-LI9jK9KIuH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #21 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #20) > (In reply to Jonathan Druart from comment #19) > > (In reply to Kyle M Hall from comment #18) > > > Question, I see in the code that there is a "Waiting" tab for only waiting > > > holds, yet I don't see it in the opac ( while on master ). Is this dead code? > > > > It looks like more than a bug :) > > After a deep dive into the code, it seems broken for a while! Thanks for looking into that! Any idea how long a while has been? Any idea what the last major version of Koha it worked in was? It seems that maybe it should be considered dead code since nobody has ever noticed, complained, or filed a bug related to it! I did look for a related bug submission, but could find none. This is also rather superfluous, as the waiting holds are already in the holds tab. There's really no need for yet another tab that lists only the waiting holds. I would like to remove the dead code, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:08:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:08:48 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: <bug-14131-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14131-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14131-70-mqKnQ4m40L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #6 from Marc V?ron <veron at veron.ch> --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:10:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:10:54 +0000 Subject: [Koha-bugs] [Bug 14757] New: Allow the use of Template Toolkit syntax for slips and notices Message-ID: <bug-14757-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Bug ID: 14757 Summary: Allow the use of Template Toolkit syntax for slips and notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org We should enable TT syntax for slips and notices. This could work side by side with the existing syntax parser for a release or two before we officially remove our bespoke parsing code for slips and notices, giving libraries ample time to switch over. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:10:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:10:59 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: <bug-14757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14757-70-0xAijKLgIC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:16:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:16:16 +0000 Subject: [Koha-bugs] [Bug 14758] New: Re-engineer Talking Tech support in Koha Message-ID: <bug-14758-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 Bug ID: 14758 Summary: Re-engineer Talking Tech support in Koha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org Right now Talking Tech support within Koha works, but does not integrate well with the existing messaging system. I would propose we re-engineer Talking Tech by doing the following: 1) Remove all the exceptions that hide/modify the use of the 'phone' notice so that it is once again treated like any other type of notice. 2) Define the 'phone' notice for a given action as the line that is created in the CSV file 3) Have the outbound cron script for Talking Tech gather these notices together into a CSV file, rather than having it generate the notices and CSV file itself. This will end with a much cleaner implementation of Talking Tech that could easily be used for other phone automation systems as well! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:16:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:16:22 +0000 Subject: [Koha-bugs] [Bug 14758] Re-engineer Talking Tech support in Koha In-Reply-To: <bug-14758-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14758-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14758-70-cXSUzEboFj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:16:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:16:33 +0000 Subject: [Koha-bugs] [Bug 14758] Re-engineer Talking Tech support in Koha In-Reply-To: <bug-14758-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14758-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14758-70-npz1MpjUsP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:16:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:16:33 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: <bug-14757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14757-70-kiwuGulf3w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14758 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 [Bug 14758] Re-engineer Talking Tech support in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:25:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:25:10 +0000 Subject: [Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping In-Reply-To: <bug-13146-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13146-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13146-70-EYZVQTr79F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #4 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Looks like the results are the same with or without the patch. Also the SQL calls disappeared (good!). But I'm not sure what is subtitle field mapping. Is it about MARC records subfield something? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:40:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:40:49 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9743-70-bJRIkrT3M2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #33 from Joonas Kylm?l? <j.kylmala at gmail.com> --- What does it mean when a MARC21 300$a field contains a reference to multiple volumes/parts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:44:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:44:44 +0000 Subject: [Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data In-Reply-To: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12252-70-5r6VGATVFq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #82 from Alex Arnaud <alex.arnaud at biblibre.com> --- Thx Gaetan, it works fine with this configuration file. The QA script hasn't found any issues so the last patch could be checked for singing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:45:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:45:17 +0000 Subject: [Koha-bugs] [Bug 14616] Introducing Koha::Object subclasses In-Reply-To: <bug-14616-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14616-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14616-70-yCi56AbYwl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 42117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42117&action=edit Bug 14616 - Squashable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:48:23 +0000 Subject: [Koha-bugs] [Bug 14616] Introducing Koha::Object subclasses In-Reply-To: <bug-14616-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14616-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14616-70-HccMJyVouv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13906 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:48:23 +0000 Subject: [Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. In-Reply-To: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13906-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13906-70-cEAQUanRpu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14616 CC| |larit at student.uef.fi Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 [Bug 14616] Introducing Koha::Object subclasses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:51:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:51:45 +0000 Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500 In-Reply-To: <bug-14755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14755-70-4VUke2umFV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:52:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:52:25 +0000 Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500 In-Reply-To: <bug-14755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14755-70-UbPfZPfsD2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755 Joonas Kylm?l? <j.kylmala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 14:59:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 12:59:43 +0000 Subject: [Koha-bugs] [Bug 14744] Cannot select guarantor when quote in one of the fields In-Reply-To: <bug-14744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14744-70-mLRSnNOfKB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14744 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron <veron at veron.ch> --- Confirmed. I tested by having a guarantor with a single quote in his/her branch name. The same happens if the single quote appears in the guarantor's name (d'Artangnan) or in the address / city (Bourbon-l'Archambault) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 15:10:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 13:10:41 +0000 Subject: [Koha-bugs] [Bug 14759] New: Replacement for Text::Unaccent Message-ID: <bug-14759-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Bug ID: 14759 Summary: Replacement for Text::Unaccent Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: ketan at carvingit.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com There appears to be a better alternative "Text::Unaccent::PurePerl" for "Text::Unaccent". I guess we should use this. This Text::Unaccent has some issues on 64 bit Cent OS perhaps due to its dependancy on libiconv. I see that this module is not used in many places and thus, update of code is easy. However, considerable testing will be required. Regards, Ketan -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 15:15:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 13:15:57 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14536-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14536-70-oxezX7tEZc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Lari Taskula <larit at student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42060|0 |1 is obsolete| | --- Comment #14 from Lari Taskula <larit at student.uef.fi> --- Created attachment 42118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42118&action=edit Bug 14536: (follow-up) Add PageObject for members/notices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 15:26:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 13:26:41 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11190-70-vNxwXYbpSk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #47 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 42119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42119&action=edit QA followup for tests on jenkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 15:35:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 13:35:33 +0000 Subject: [Koha-bugs] [Bug 14760] New: Disabled courses display in the course reserves list for items Message-ID: <bug-14760-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Bug ID: 14760 Summary: Disabled courses display in the course reserves list for items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org If an item is on reserve for two courses but one of those courses is disabled, both courses are still listed on opac-detail.pl! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 15:35:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 13:35:48 +0000 Subject: [Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items In-Reply-To: <bug-14760-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14760-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14760-70-50moIneMKx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 15:36:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 13:36:32 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: <bug-14759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14759-70-ETlABjdNiM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Ketan Kulkarni <ketan at carvingit.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |ketan at carvingit.com |ity.org | Status|NEW |Needs Signoff CC| |ketan at carvingit.com --- Comment #1 from Ketan Kulkarni <ketan at carvingit.com> --- Created attachment 42120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42120&action=edit This patch uses the proposed module - Text::Unaccent::PurePerl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 15:38:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 13:38:35 +0000 Subject: [Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items In-Reply-To: <bug-14760-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14760-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14760-70-AXiGFddk3c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 15:38:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 13:38:38 +0000 Subject: [Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items In-Reply-To: <bug-14760-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14760-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14760-70-kac11G5omn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 42121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42121&action=edit Bug 14760 - Disabled courses display in the course reserves list for items If an item is on reserve for two courses but one of those courses is disabled, both courses are still listed on opac-detail.pl! Test Plan: 1) Enable course reserves 2) Create two courses 3) Place one item on reserve for both courses 4) Disable one of the two courses 5) View the record details for that record/item 6) You should see both courses listed in the course reserves column 7) Apply this patch 8) Reload the page 9) You should now only see the active course in the course reseves column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 16:02:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 14:02:02 +0000 Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee In-Reply-To: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13697-70-w6cpBltj5n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 --- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 42122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42122&action=edit Bug 13697: (QA followup) fix typo in sysprefs.sql Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 16:15:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 14:15:25 +0000 Subject: [Koha-bugs] [Bug 9743] Allow customization for making hold notes required In-Reply-To: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9743-70-jzpjwuFMoz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743 --- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Joonas Kylm?l? from comment #33) > What does it mean when a MARC21 300$a field contains a reference to multiple > volumes/parts? This biblio describes for example a work in three parts, but it has been catalogued as one (in our case we still have these ones only having one item too that comprises all parts; we split the items when labeling.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 16:42:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 14:42:00 +0000 Subject: [Koha-bugs] [Bug 14755] Checking in gives error 500 In-Reply-To: <bug-14755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14755-70-Xg50YLUmsO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755 --- Comment #1 from Joonas Kylm?l? <j.kylmala at gmail.com> --- Found the problem: This bug happens when you import biblio records from an older version of Koha and then you create an item without first manually editing the record (just clicking edit and then saving it is enough to get it working). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 17:02:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 15:02:33 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-VuymlYVUQk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #139 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 42123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42123&action=edit Bug 13799: Add cookie-based authentication to REST API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 17:02:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 15:02:48 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-V8BOaAQyzr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 17:19:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 15:19:23 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-gXEh5rvaI4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #9 from Heather <heather_hernandez at nps.gov> --- (In reply to Robin Sheat from comment #8) > (In reply to Heather from comment #7) > > I tried it out here: http://browse.koha.catalystdemo.net.nz > > It seems nice, but it doesn't seem like a true browse to me--what I look for > > in a browse is to enter a search term, and have the results returned to be > > what is exactly before my searched term in the given index, then where the > > searched term is/would be, then what is exactly after the searched term in > > the index. So there would be no need for "exact, fuzzy, really fuzzy," > > because when I browse an index, I want the results to be what is before and > > after that term in the given index. > > There are technical reasons why this is particularly hard, essentially that > pulling the index terms out in order is not something that can readily be > done without patching Elasticsearch itself, which I'm considering out of > scope of this project :) > > However, when I thought about it with that in mind, I got to wondering what > the point of a complete alphabetical index really is to a library user. > There's no semantic relationship between a word that starts with R and a > word that starts with S, why would it be meaningful to put one beside the > other. A subject of "Symbols" is not closely related to a subject of > "Tarantulas", just because they're alphabetically close. However, an author > name of "Stephen" is (sorta) semantically related to an author name of > "Steven", if the user hasn't quite remembered the whole name or the spelling. > > > That said, when I searched "exact" for "Author": Rowling > > I get: > > Rowling, J. K. > > Rowling, J.K. > > This is a GIGO situation with the data that is the result of it not being > terribly cleanly catalogued in the first place. I tend to prefer working > with data like this as it is better at highlighting odd edge cases. > > I've been thinking about ways to correct for cases like this (where it's > just a punctuation or whitespace difference), but it presents some issues > relating to how it'd be done reliably with no false positives. So I've > postponed further thinking about it for now. In an ideal world, everyone > will be using authorities anyway, and this won't happen :) > > > This is nice, but, again, it doesn't seem like a "browse" to me--these are > > just search results. When I click the names, I get the exact same search > > results as I do via Advanced Search, Author Phrase: > > It is doing pretty much the same thing as a search, yes. Essentially, it's > goal is to be an easier way to look for some specific things, possibly when > you're a bit unsure about the details. I think that subjects will benefit > from this the most actually, as scrolling through > "Birds -- Kakapo", "Birds -- Kea", "Birds -- Kiwi" is something that has > real use. Additionally, a search for "Kiwi" will also find "Birds -- Kiwi" > (though this behaviour isn't visible in the data that's currently on the > test site due to the way it's catalogued.) > > > If I Browse via "Fuzzy" with: Rowling > > I get these results: > > Rollins, Henry, > > Rowland, Sarah-Jane. > > Rowlands, David. > > Rowlands, Gena. > > Rowling, J. K. > > Rowling, J.K. > > > > Which does show me some results which should be in the author index above > > Rowling, but I get no results that should be in the author index after > > Rowling. "Really fuzzy" is the same. > > I'll double check this, but it's most likely that in this database, there's > just nothing further that matches. Actually, in this case, fuzzy and extra > fuzzy will be doing the same thing as there's a max edit distance limit for > the fuzziness, and I think it will have been hit. I'm probably going to > remove the "extra fuzzy" option anyway, it risks being more confusing than > anything. > > > I would like to see the searched for term in the middle of hits that occur > > before and after it in the index, e.g. something like this (an author > > "Browse" result, with made up examples below Rowling, J.K.): > > But why? What does an alphabetically adjacent author tell you about that set > of authors, and what does it provide that a library user would find useful? > (Technical reasons for why this is hard aside.) > > > I hope this is helpful! --h2 > > Thanks for checking it out! Hi, Robin! One of the main purposes of a complete alphabetical browse for the library user is exactly what you mentioned: when the user is unsure of the spelling, but has most of it, e.g., "Stephens" or "Stevens," or something like "Ralphs," or "Rolphs." And, with subjects, the user will receive a list with all subdivisions listed & will see those, rather than just search results that don't show the subject terms. Yes--GIGO is an issue in the above browse, and ideally all access points are under authority control, but the browse is useful for libraries that have order records that are not yet cataloged, and who only do their authority control/cataloging upon receipt of the item. The above issue in the spacing of "Rowling, J. K." could occur with order records vs. fully cataloged & received items. The alphabetic browse is also invaluable for the catalogers on the staff side doing authority control--it's the easiest way to spot heading variations. In the Koha public opac, a basic search always gives you a list of search results that never shows subject terms--the facets on the left show *some* subject terms but, e.g., if you do a basic keyword search in your demo catalog for "Birds," the subject facets on the left have subdivisions broken out & not associated with the main heading: Animals (2) Birds (6) Maoritanga. (1) Mystery and suspense stories. (1) Mythology, Maori. (1) Natural history (2) New Zealand (3) New Zealand. (3) Penguins. (1) Pictorial works. (1) Show more (It's the same in our catalog, i.e. this search only gives you facets on the left that are main headings, not headings *with* their subdivisions: http://keys.bywatersolutions.com/cgi-bin/koha/opac-search.pl?q=ships) So an alphabetical browse that does return subject terms with their subdivision, like in your example, would be useful to a user, e.g.: Birds--Kakapo. Birds--Kea. Birds--Kuwait. Birds--Pictorial works. Birds--Qatar. (BTW, the Authority Search in the demo catalog has a problem--do an authority search with default options & the term "Birds" & you get: Software error: Can't call method "each" on unblessed reference at /opt/kohaclones/browse/Koha/SearchEngine/Elasticsearch/Search.pm line 265. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error.") Do a similar authority search in our catalog for ships: http://keys.bywatersolutions.com/cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operator=contains&value=ships&marclist=any&and_or=and&orderby=HeadingAsc And you get close to a subject heading browse result--the only problem is that it returns only main headings, not an alphabetic list of the terms *with subdivisions* as used in the records, which would be very useful to the user. I bring this up because, IMO, as it is, authority control/authority search is not an alternative to a true alphabetical catalog browse for the public opac user, of subject terms with subdivisions as used in the catalog. I hope this is helpful! Best, --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 17:22:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 15:22:20 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_14761=5D_New=3A_Importing_bibliograp?= =?utf-8?q?hic_/__author_records_is_slow_=E2=80=93=C2=A0stage-marc-import?= =?utf-8?b?LnBs?= Message-ID: <bug-14761-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14761 Bug ID: 14761 Summary: Importing bibliographic / author records is slow ? stage-marc-import.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org Using stage-marc-import.pl to import bibliographic or author records is really slow. I ran some profiling program and it showed the database calls as the bottle neck. Maybe we should think a better way of doing those, if possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 17:23:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 15:23:19 +0000 Subject: [Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML In-Reply-To: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11584-70-EOy7eh5Z2L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 --- Comment #28 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 42124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42124&action=edit Bug 11584: (QA followup) add missing newline at end of YAML file Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 17:24:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 15:24:58 +0000 Subject: [Koha-bugs] [Bug 14762] New: Importing records doesn't add missing subelements Message-ID: <bug-14762-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762 Bug ID: 14762 Summary: Importing records doesn't add missing subelements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org If using stage-marc-import.pl it doesn't generate the missing data to bibliographic records (subelements, updating some data, etc.). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 17:34:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 15:34:20 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-mCqSmjs4XT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I was thinking this morning, maybe a 'starts with' search option could help to bring the result list a little closer to an alphabetic index. Could this be an option? I have asked some of the coworkers to give the search a test, but some of the results are quite confusing. Example: Exact, Author: Miller The first result shown is "Millard, Annie". I didn't expect that for the exact search option, but only with fuzzy activated. Another issue could be related to ISBD punctuation in the fields. Often there are 2 entries which what seems to be the same author, only different by a . at the end: Example: Exact, Author: Smith Smith, Alexander Gordon. Smith, Alexander Gordon Smith, Jim Smith, Jim. Would be good if those could be merged for display and search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 17:53:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 15:53:57 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: <bug-14292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14292-70-RMV4e5nWW0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #1 from Barton Chittenden <barton at bywatersolutions.com> --- Created attachment 42125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42125&action=edit Add patron category restrictions to longoverdue.pl Add command line options --category and --skip-category Convert usage() to pod2usage. (This was previous FIXME) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 17:54:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 15:54:24 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: <bug-12770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12770-70-H9LdafMujb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin at bugs.koha-community. | |org.xinxidi.net --- Comment #7 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Tried to apply patch to master (208400f) but got merge conflicts in misc/cronjobs/overdue_notices.pl. It works well against 2331a21 (random pick from 2015-07-21 when patch was last said to work). All values show as described. Would perhaps be nice to add accountlines in the SQLfieldnames ($field_selection, letter.pl:247)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 18:05:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 16:05:53 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-V9ej6RDmRh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #11 from Heather <heather_hernandez at nps.gov> --- (In reply to Katrin Fischer from comment #10) > I was thinking this morning, maybe a 'starts with' search option could help > to bring the result list a little closer to an alphabetic index. Could this > be an option? It sounds to me like it could be an option, if the results were an alphabetic list of terms from the searched index, rather than a list of records. > I have asked some of the coworkers to give the search a test, but some of > the results are quite confusing. > > Example: Exact, Author: Miller > The first result shown is "Millard, Annie". > I didn't expect that for the exact search option, but only with fuzzy > activated. It sounds like your "exact" is kind of "fuzzy!" > Another issue could be related to ISBD punctuation in the fields. Often > there are 2 entries which what seems to be the same author, only different > by a . at the end: > > Example: Exact, Author: Smith > Smith, Alexander Gordon. > Smith, Alexander Gordon > Smith, Jim > Smith, Jim. > > Would be good if those could be merged for display and search. Could this also be an issue of variations in the headings' $q fields, which Koha tends to not display in search results, and when used there's no punctuation between the end of the $a and the beginning of the $q subfields? In your example, above, the headings could be for different people, and so should not be merged, e.g., could be: 100 1_ Smith, Alexander Gordon. 100 1_ Smith, Alexander Gordon $q (Alexander Gordon Frank) 100 1_ Smith, Jim $q (James Allen) 100 1_ Smith, Jim. (The headings' variations are most likely the result of GIGO, & so proper authority control would collate them.) --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 18:18:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 16:18:38 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: <bug-14292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14292-70-VqnbAF4hMT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Barton Chittenden <barton at bywatersolutions.com> --- Prerequisites for testing: Several borrower categories defined (Let's call them ADULT, STAFF, CHILD) Borrowers defined in each category (AA -- ADULT, SS -- STAFF, CC -- CHILD) Items available for checkout. Make sure that you are using the default authorised value 2 as "Long Overdue (Lost)" Apply patch Make sure that $KOHA_CONF and $PERL5LIB are set correctly. Test plan: 1) Check out items to AA, SS and CC. Backdate the check-ins so that the due date more than 90 days prior (2015-05-01 is a practical date, if testing in 2015). Note the borrower number and item number for each checkout. 2) Run longoverdue.pl in verbose without the --confirm option: ./misc/cronjobs/longoverdue.pl -l 90=2 -v ### TEST MODE -- NO ACTIONS TAKEN ### Range 1 Due 90 - 366 days ago (2014-08-30 to 2015-06-02), lost => 2 Due 2015-04-01 23:59:00: item # from borrower ## to lost: 2 Due 2015-05-01 23:59:00: item # from borrower ## to lost: 2 Due 2015-05-01 23:59:00: item # from borrower ## to lost: 2 3) Run longoverdue.pl without --confirm using --category STAFF: ./misc/cronjobs/longoverdue.pl -l 90=2 -v --category STAFF You should see the item checked out to STAFF set as lost, but the other two items will not be processed. 4) Run longoverdue.pl without --confirm using --skip-category STAFF ./misc/cronjobs/longoverdue.pl -l 90=2 -v --skip-category STAFF You should see the items checked out to ADULT and CHILD set as lost, but STAFF will not be processed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 18:19:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 16:19:59 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: <bug-14292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14292-70-RWZ5Y8jW28@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m, | |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 19:10:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 17:10:56 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-N1b9TDR3yw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #123 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- Good job, Weaver. I was testing in your sandbox, but i got some issues when typing and trying to delete characters with backspace, sometimes the last word cannot be deleted and sometimes all line cannot be deleted or edited. 1) IMHO, i prefer the MARC Maker style like MARC Edit <http://www.loc.gov/marc/makrbrkr.html>. So you shouldn't take care about the spaces around the subfields, that i think is the problem in previous issue. e.g. =100 1\$aWeaver, Jesse. =245 10$aProfessional cataloger's interface /$bby Jesse Weaver. 2) Also some scape character like {dollar}, {ntilde}, {phono} this is when you cannot infer with some accent character, MARCMaker uses this scape characters. They call this Character Mnemonic Strings at <http://www.loc.gov/marc/mnemonics.html> maybe providing a Modal with all those characters. A cataloger thought Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 19:31:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 17:31:44 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-bBxXjCCWST@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #124 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- (In reply to H?ctor Eduardo Castro Avalos from comment #123) > I was testing in your sandbox, but i got some issues when typing and trying > to delete characters with backspace, sometimes the last word cannot be > deleted and sometimes all line cannot be deleted or edited. Also when typing spanish accents fails e.g. cl?sicos, when this happens the option Settings->Show fields verbatim fails too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 20:47:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 18:47:45 +0000 Subject: [Koha-bugs] [Bug 14763] New: show patron's age Message-ID: <bug-14763-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14763 Bug ID: 14763 Summary: show patron's age Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice if Koha calculated the patron's age to display on the patron record near the birthday. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 22:10:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 20:10:59 +0000 Subject: [Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool In-Reply-To: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12772-70-45htl5IOeZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 --- Comment #11 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Created attachment 42126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42126&action=edit Bug 12772 - Fix rule updates Overduerules ID was not sent correctly when editing rules, resulting in rule being cleared instead of updated. This patch fixes this issue, and a couple of uninitilized values as a bonus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 22:33:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 20:33:13 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10067-70-nIxL6qqGcJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #21 from Eivin Giske Skaaren <eivin at sysmystic.com> --- I have just retested this and the difference is what I said earlier: With the patch you can set the "specify due date" and when the item get shortened loan date "specify due date" will not be changed to the shortened date and you can keep on checking out items with the original date. I have attached some screenshots. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 22:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 20:33:53 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10067-70-Q9iKskBcbV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #22 from Eivin Giske Skaaren <eivin at sysmystic.com> --- Created attachment 42127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42127&action=edit Shortened loan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 22:34:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 20:34:29 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10067-70-GizP9xKXPu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #23 from Eivin Giske Skaaren <eivin at sysmystic.com> --- Created attachment 42128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42128&action=edit Specify due date not changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 22:34:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 20:34:52 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10067-70-g2Nd9ZQB4V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin at sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 31 23:05:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Aug 2015 21:05:36 +0000 Subject: [Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements In-Reply-To: <bug-14762-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14762-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14762-70-9SCI6i8SKP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Can you describe the problem a bit more? What should be added/is missing? -- You are receiving this mail because: You are watching all bug changes.