[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41357|0                           |1
        is obsolete|                            |

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 41360
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41360&action=edit
Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle
serialization format and record id

In order to use Koha::MetadataRecord as a container for moving records
around it is important to let it carry the serialization format
of the record object it was built with, so it is easier and cheaper to
make decisions about records.

This patch introduces regression tests for the changes to be made.
The 'format' param is introduced, and also sets default values:
  schema => 'marc21'
  format => 'MARC'

A new (optional) 'id' param is added so the record carries its own id outside
of it.

The default behaviour is preserved, and no changes are needed in places
Koha::MetadataRecord is used.
->new also returns undef if no record is passed, and raises a carped warning.

To test:
- Apply the patch
- Run the new tests
  $ prove t/Koha_MetadataRecord.t
=> FAIL: Tests shoud fail as the changes are not implemented on
Koha::MetadataRecord

Edit: made serialization format be upper-case to match what is used on
Koha::Filter's

-- 
You are receiving this mail because:
You are watching all bug changes.