[Koha-bugs] [Bug 14651] New: Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651

            Bug ID: 14651
           Summary: Koha::Item::effective_itemtype should fallback to
                    biblio-level if no item-level itemtype
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I fill this bug to start a conversation about this issue.
It seems the codebase has several ways of determining the itemtype. For
example, C4::Circulation::AddReturn used the biblio-level itemtype (until bug
14598) and C4::Circulation::CanBookBeIssued just sticks to item-level itemtype.

At first sight, it seems clear to me that we should start moving into using
Koha::Item objects, that even provide an ->effective_itemtype method!

Having talked about this on IRC there seems to be a consensus that if the item
doesn't have an itemtype, then there should be a fallback to biblio-level
itemtype.

This means we should add that check to the ->effective_itemtype method. But it
would mean including Koha::Biblios.

Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.