[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533

--- Comment #4 from Yarik Dot <yarikdot at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #2)
> 
> I think the behaviour should be:
> 
> - If the user passes DB parameters (user, pass, hostname, dbname), use them
> to configure the instance. This needs more parameters to be added to
> koha-create. hostname should default to 'localhost' if ommited.

There is currently /etc/mysql/koha-common.cnf used right? Why to change this
behavior?

If there is nothing defined in here, default client configuration from
/etc/mysql/my.cnf is used.

Anyway, I am ok with changing this behaviour if the change is consistent. That
means, there won't be 10 places where the database connection can be defined.

> - If some of the new parameters is missing, fallback to what is configured
> in /etc/koha/passwd.

Why? That is why passwdfile is used, isn't it?

> - If some of the relevant parameters is missing, fail loudly.

Agree.

-------

To explain more how we use it:

first# koha-create --request-db
mysql# mysql; CREATE DB ...; GRANT ...;
first# koha-create --populate-db
second# koha-create --use-db --passwdfile ./file

(In reply to Tomás Cohen Arazi from comment #3)
> This is not enough, as the DB is still being created. Look at my previous
> comment

I have just double checked the koha-create script and database is only created
when --create is used. It is on line 560 and nowhere else.

-- 
You are receiving this mail because:
You are watching all bug changes.