[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41498|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 41555
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41555&action=edit
Bug 14321: Using Koha::Upload in tools/upload-file.pl

This patch introduces Koha::Upload. It will replace the modules
C4::UploadedFile.pm and the new C4::UploadedFiles.pm (from BZ 6874).
This operation will be performed in a few steps.

As a first step, we will use Koha::Upload instead of UploadedFile in the
following places. (In these three places files are uploaded temporarily.)

[1] stage-marc-import.pl
[2] upload-cover-image.pl
[3] offline_circ/process_koc.pl and enqueue_koc.pl

A new file-upload.js replaces file-upload.inc in the associated template.
We now use ajax to get progress figures instead of launching perl script
upload-file-progress. Also we do not need the jquery plugin
ajaxfileupload.js anymore. A subsequent patch will remove these files.

The js changes now also allow for aborting a file upload. This feature has
been added to stage-marc-import only for now.

NOTE: In editing the process_koc.tt I noticed that the form enqueuefile was
hidden and no longer used (with associated code in process_koc.pl). When a
file has been uploaded, I display the form again (with the Apply directly
button). The code still works.

Test plan:
[1] Upload a marc file in stage-marc-import.
[2] Check new entry in table uploaded_files. Look for the file in the
    directory defined by upload_path in koha-conf.xml.
[3] Upload another (larger) file and abort the upload. Check table and
    directory again.
[4] Verify that Stage for import still works as expected.
[5] Test Upload local cover image. (Enable OPACLocalCoverImages.) You can
    test an individual image or a zip file including images and a file
    called datalink.txt (with lines biblionumber,filename).
[6] Test uploading a offline circulation file:
    Enable AllowOfflineCirculation, and create a koc file (plain text):
    Line1: Version=1.0\tA=1\tB=2
    Line2: 2015-08-06 08:00:00 345\treturn\t[barcode]
    Note: Replace tabs and barcode. The number of tabs is essential!
    Checkout the item with your barcode.
    Go to Offline circulation file upload. Upload and click Apply directly.
    Checkout again. Upload again, click Add to offline circulation queue.

-- 
You are receiving this mail because:
You are watching all bug changes.