[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 41387
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41387
Bug 14639: Extend Koha::MetadataRecord to handle serialization format and
record id

Review of attachment 41387:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14639&attachment=41387)
-----------------------------------------------------------------

::: Koha/MetadataRecord.pm
@@ +84,5 @@
> +
> +    my $record = $params->{ record };
> +    my $schema = $params->{ schema } // 'marc21';
> +    my $format = $params->{ format } // 'MARC';
> +    my $id     = $params->{ id };

Don't you think these 4 params should be mandatory?
I would raise an exception if one of them is not given to the constructor.

-- 
You are receiving this mail because:
You are watching all bug changes.