[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

--- Comment #7 from Joonas Kylmälä <j.kylmala at gmail.com> ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Joonas Kylmälä from comment #5)
> > (In reply to Owen Leonard from comment #4)
> > > (In reply to Joonas Kylmälä from comment #3)
> > > > Shouldn't we change it to server side
> > > > as it looks like all the other fields are checked that way.
> > > 
> > > There are changes to the template and to opac-passwd.pl. To confirm, disable
> > > JavaScript and see if the server-side check is working correctly as well.
> > 
> > opac-passwd.pl is for the end user server side check, right? I disabled
> > JavaScript in the staff side and there wasn't any check from the server
> > side, it allowed to change the password (this was also mentioned in the test
> > plan). So should we change the code so that it checks for the whitespaces in
> > the server side when the password is changed from the staff view?
> 
> If you like, you can provide it.
> But I don't know why a librarian will force a password if the application
> denies it.

Librarian doesn't need to force the password, only use a browser where the
JavaScript is disabled. So I give one vote for the server side check.

-- 
You are receiving this mail because:
You are watching all bug changes.