[Koha-bugs] [Bug 14589] Replace fetch CGI::Cookie calls

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 41675
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41675
Bug 14589: Replace fetch CGI::Cookie calls

Review of attachment 41675:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14589&attachment=41675)
-----------------------------------------------------------------

There is scope creep as noted below. It would make more sense to have a
"Replace 'new CGI' calls" bug separately, as this occurs in more than just
these places.

::: tools/background-job-progress.pl
@@ +30,4 @@
>  use CGI::Cookie; # need to check cookies before
>                   # having CGI parse the POST request
>  
> +my $input = CGI->new;

Scope creep.

@@ +51,4 @@
>      $job_status = $job->status();
>  }
>  
> +my $reply = CGI->new;

Scope creep.

::: tools/upload-file-progress.pl
@@ +47,4 @@
>      }
>  }
>  
> +my $reply = CGI->new;

Scope creep.

-- 
You are receiving this mail because:
You are watching all bug changes.