[Koha-bugs] [Bug 14702] Fix GetReserveFee

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 41779
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41779&action=edit
Bug 14702: Fix GetReserveFee

The code in this sub of Reserves is unneeded and erroneous.
The old code checked via biblioitems if there still was an item not issued
and if so, it checked reserves: if there was no no hold yet for the biblio,
the reserve fee went to zero. (Strange !)
So only the second hold would trigger a charge. (But Koha does NOT allow
that second hold at this time!) So it actually does nothing!

This can/should be drastically simplified:
We only call GetReserveFee from AddReserve. So there is an item free and it
is possible to place a hold.
Since it is currently not possible to place a second hold, and even if it
was, we just charge our hold fee from patron categories!
NOTE: It somehow seems a bit odd to have hold fee in the patron categories.
Maybe it should be added to itemtypes (on another report)?

This is a fix that changes behavior! A follow-up will print a warning for
libraries upgrading.

Test plan:
[1] Add a hold for a patron without hold fee. Check the patron account if
    there is no charge for the new hold.
[2] Add a hold for a ptron with hold fee. Check account again.

-- 
You are receiving this mail because:
You are watching all bug changes.