[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
(In reply to Liz Rea from comment #8)
> Yeah I was looking at that - I wasn't sure (didn't test, actually) whether
> |html or |uri or |url would work here - the manual for TT doesn't indicate
> that ' is an escaped character in uri/url, and it will convert it to an
> entity in html which I didn't test, but certainly could.

(I know we talked about this already on IRC but I'll mention it here for
everyone else)

The TT manual mentions that it doesn't escape the single quote prior to version
2.26, but it will with version 2.26 and later (unless the line
"Template::Filters->use_rfc2732;" is added). 

But the version in Debian Wheezy onwards is 2.24, so the url/uri filters won't
work until Debian moves on to 2.26+, which I don't imagine will be for a while,
since they just moved to 2.24 from 2.22 between Squeeze and Wheezy.

--

Personally, I think I'm more in favour of adding our own Template Toolkit
Filter Plugin based on the 2.26 uri filter. It would be more comprehensive than
the replace vmethod and if one day we have TT 2.26 as the required version, we
can always do a simple replacement in the code of "| escape_uri" with "| uri".



--
http://template-toolkit.org/docs/modules/Template/Filters.html#section_FILTERS

http://template-toolkit.org/docs/manual/Directives.html#section_FILTER

http://www.template-toolkit.org/docs/modules/Template/Plugin/Filter.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.