[Koha-bugs] [Bug 14702] Refactor GetReserveFee

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14702

--- Comment #18 from Joonas Kylmälä <j.kylmala at gmail.com> ---
(In reply to Marcel de Rooy from comment #8)
>Since AddReserves only calls this sub, we can move the code for charging the
>fee to this sub. I renamed it to ChargeReserveFee.
>There is no change in behavior.

I'd suggest putting the fee calculation to another subroutine because it will
help keeping the Koha code more modulated and reusable in future cases (even
though it's not many lines (2!?)).

Also the code below the comment "# If not all items are issued and there are no
holds: charge no fee" shouldn't work like that. What if someone wants to
explicitly have that one item or an item from one specific branch and the
library doesn't do inter-library transportations.

-- 
You are receiving this mail because:
You are watching all bug changes.